From: Brian Paul <brian.paul@tungstengraphics.com>
Date: Wed, 14 May 2008 22:01:31 +0000 (-0600)
Subject: mesa: glUniform(location==-1) is not an error
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f84005c0a114837a0c7209a3c598e02fb5f47da1;p=mesa.git

mesa: glUniform(location==-1) is not an error
---

diff --git a/src/mesa/shader/shader_api.c b/src/mesa/shader/shader_api.c
index 2b3dbff7a08..d0512b8ed1d 100644
--- a/src/mesa/shader/shader_api.c
+++ b/src/mesa/shader/shader_api.c
@@ -1151,6 +1151,10 @@ _mesa_uniform(GLcontext *ctx, GLint location, GLsizei count,
       return;
    }
 
+   if (location == -1)
+      return;   /* The standard specifies this as a no-op */
+
+
    if (location < 0 || location >= (GLint) shProg->Uniforms->NumUniforms) {
       _mesa_error(ctx, GL_INVALID_VALUE, "glUniform(location)");
       return;
@@ -1246,11 +1250,16 @@ _mesa_uniform_matrix(GLcontext *ctx, GLint cols, GLint rows,
                      GLboolean transpose, const GLfloat *values)
 {
    struct gl_shader_program *shProg = ctx->Shader.CurrentProgram;
+
    if (!shProg || !shProg->LinkStatus) {
       _mesa_error(ctx, GL_INVALID_OPERATION,
          "glUniformMatrix(program not linked)");
       return;
    }
+
+   if (location == -1)
+      return;   /* The standard specifies this as a no-op */
+
    if (location < 0 || location >= shProg->Uniforms->NumUniforms) {
       _mesa_error(ctx, GL_INVALID_VALUE, "glUniformMatrix(location)");
       return;