From: Jan Beulich Date: Mon, 19 Dec 2022 08:36:00 +0000 (+0100) Subject: gprofng/testsuite: eliminate bogus casts X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f8b6a781fb6b7e799c95c1c2be87accc39c0b7c0;p=binutils-gdb.git gprofng/testsuite: eliminate bogus casts Casting pointers to unsigned int is generally problematic and hence compilers tend to warn about such. While here they're used only in fprintf(), it still seems better to omit such casts, even if only to avoid setting bad precedents. --- diff --git a/gprofng/testsuite/gprofng.display/synprog/so_syn.c b/gprofng/testsuite/gprofng.display/synprog/so_syn.c index 6fc5aa61163..d6c9331f9d5 100644 --- a/gprofng/testsuite/gprofng.display/synprog/so_syn.c +++ b/gprofng/testsuite/gprofng.display/synprog/so_syn.c @@ -32,7 +32,7 @@ so_cputime () /* put a memory leak in here */ (void) malloc (13); - fprintf (stderr, "so_burncpu @ 0x%08x\n", (unsigned int) so_burncpu); + fprintf (stderr, "so_burncpu @ %p\n", so_burncpu); so_burncpu (); wlog ("end of so_cputime", NULL); diff --git a/gprofng/testsuite/gprofng.display/synprog/so_syx.c b/gprofng/testsuite/gprofng.display/synprog/so_syx.c index ae7da6f7414..1994a0aca11 100644 --- a/gprofng/testsuite/gprofng.display/synprog/so_syx.c +++ b/gprofng/testsuite/gprofng.display/synprog/so_syx.c @@ -32,7 +32,7 @@ sx_cputime () /* put a memory leak in here */ (void) malloc (13); - fprintf (stderr, "sx_burncpu @ 0x%08x\n", (unsigned int) sx_burncpu); + fprintf (stderr, "sx_burncpu @ %p\n", sx_burncpu); sx_burncpu (); wlog ("end of sx_cputime", NULL); return 13;