From: Joel Brobecker <brobecker@gnat.com>
Date: Fri, 8 Jan 2010 13:54:40 +0000 (+0000)
Subject: GDB crash with empty executable name (MinGW).
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f91e5ac34e150aeb5030c1005a510a231449c33c;p=binutils-gdb.git

GDB crash with empty executable name (MinGW).

        * source.c (openp): Add assert that parameter string is not NULL.
        if parameter string is an empty string, then return with a failure
        immediately.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 707b2f20be2..cb49ab9ddbf 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,10 @@
+2009-01-08  Joel Brobecker  <brobecker@adacore.com>
+
+	GDB crash with empty executable name (MinGW).
+	* source.c (openp): Add assert that parameter string is not NULL.
+	if parameter string is an empty string, then return with a failure
+	immediately.
+
 2009-01-08  Joel Brobecker  <brobecker@adacore.com>
 
 	Get rid of support for VAX Floats.
diff --git a/gdb/source.c b/gdb/source.c
index fcfce65a327..20903265716 100644
--- a/gdb/source.c
+++ b/gdb/source.c
@@ -707,6 +707,20 @@ openp (const char *path, int opts, const char *string,
 
   /* The open syscall MODE parameter is not specified.  */
   gdb_assert ((mode & O_CREAT) == 0);
+  gdb_assert (string != NULL);
+
+  /* A file with an empty name cannot possibly exist.  Report a failure
+     without further checking.
+
+     This is an optimization which also defends us against buggy
+     implementations of the "stat" function.  For instance, we have
+     noticed that a MinGW debugger built on Windows XP 32bits crashes
+     when the debugger is started with an empty argument.  */
+  if (string[0] == '\0')
+    {
+      errno = ENOENT;
+      return -1;
+    }
 
   if (!path)
     path = ".";