From: Pedro Alves <pedro@palves.net>
Date: Thu, 12 May 2022 20:04:42 +0000 (+0100)
Subject: Momentary breakpoints should have no breakpoint number
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=f9703051465a03bace3cc17b80fcd12c19a60821;p=binutils-gdb.git

Momentary breakpoints should have no breakpoint number

Momentary breakpoints have no breakpoint number, their breakpoint
number should be always 0, to avoid constantly incrementing (or
decrementing) the internal breakpoint count.

Indeed, set_momentary_breakpoint installs the created breakpoint
without a number.

However, momentary_breakpoint_from_master incorrectly gives an
internal breakpoint number to the new breakpoint.  This commit fixes
that.

Change-Id: Iedcae5432cdf232db9e9a6e1a646d358abd34f95
---

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 0c3946cbc36..9006311b4bf 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7945,7 +7945,6 @@ momentary_breakpoint_from_master (struct breakpoint *orig,
 
   copy->enable_state = bp_enabled;
   copy->disposition = disp_donttouch;
-  copy->number = internal_breakpoint_number--;
 
   breakpoint *b = add_to_breakpoint_chain (std::move (copy));
   update_global_location_list_nothrow (UGLL_DONT_INSERT);