From: Eric Anholt <eric@anholt.net>
Date: Fri, 21 Nov 2014 03:41:26 +0000 (-0800)
Subject: vc4: Add a note about a piece of errata I've learned about.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fa74ec7e98edb185806967fb17dd2d885727aa95;p=mesa.git

vc4: Add a note about a piece of errata I've learned about.

Right now in my environment I've only got a small CMA area, so this
constraint ends up holding.
---

diff --git a/src/gallium/drivers/vc4/vc4_draw.c b/src/gallium/drivers/vc4/vc4_draw.c
index e70506b6245..2d824624b5f 100644
--- a/src/gallium/drivers/vc4/vc4_draw.c
+++ b/src/gallium/drivers/vc4/vc4_draw.c
@@ -48,6 +48,10 @@ vc4_start_draw(struct vc4_context *vc4)
          * BO allocations align to that anyway), then for some reason the
          * simulator wants an extra page available, even if you have overflow
          * memory set up.
+         *
+         * XXX: The binner only does 28-bit addressing math, so the tile alloc
+         * and tile state should be in the same BO and that BO needs to not
+         * cross a 256MB boundary, somehow.
          */
         uint32_t tile_alloc_size = 32 * tilew * tileh;
         tile_alloc_size = align(tile_alloc_size, 4096);