From: Brian Paul <brianp@vmware.com>
Date: Wed, 22 Apr 2009 17:16:03 +0000 (+0100)
Subject: mesa: Fix buffer overflow when parsing generic vertex attributes.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fa92756400ccfbb3f0201df634feb45ab4f98352;p=mesa.git

mesa: Fix buffer overflow when parsing generic vertex attributes.
---

diff --git a/src/mesa/shader/arbprogparse.c b/src/mesa/shader/arbprogparse.c
index b47bf360cf5..c7a031067ef 100644
--- a/src/mesa/shader/arbprogparse.c
+++ b/src/mesa/shader/arbprogparse.c
@@ -1513,10 +1513,16 @@ generic_attrib_check(struct var_cache *vc_head)
    curr = vc_head;
    while (curr) {
       if (curr->type == vt_attrib) {
-         if (curr->attrib_is_generic)
-            genericAttrib[ curr->attrib_binding ] = GL_TRUE;
-         else
+         if (curr->attrib_is_generic) {
+            GLuint attr = (curr->attrib_binding == 0)
+               ? 0 : (curr->attrib_binding - VERT_ATTRIB_GENERIC0);
+            assert(attr < MAX_VERTEX_PROGRAM_ATTRIBS);
+            genericAttrib[attr] = GL_TRUE;
+         }
+         else {
+            assert(curr->attrib_binding < MAX_VERTEX_PROGRAM_ATTRIBS);
             explicitAttrib[ curr->attrib_binding ] = GL_TRUE;
+         }
       }
 
       curr = curr->next;