From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Thu, 5 Mar 2020 12:30:05 +0000 (+0000)
Subject: add more comments
X-Git-Tag: div_pipeline~1776
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fa980a2968cdaf23d3656699feb0c13befa5f195;p=soc.git

add more comments
---

diff --git a/src/decoder/power_decoder.py b/src/decoder/power_decoder.py
index a8badb62..1b15e952 100644
--- a/src/decoder/power_decoder.py
+++ b/src/decoder/power_decoder.py
@@ -169,6 +169,9 @@ class PowerDecoder(Elaboratable):
         m = Module()
         comb = m.d.comb
 
+        # note: default opcode is "illegal" as this is a combinatorial block
+
+        # go through the list of CSV decoders first
         for d in self.dec:
             opcode_switch = Signal(d.bitsel[1] - d.bitsel[0],
                                    reset_less=True)
@@ -232,7 +235,7 @@ def create_pdecode():
         Subdecoder(pattern=30, opcodes=get_csv("minor_30.csv"),
                    opint=True, bitsel=(1, 6), suffix=None, subdecoders=[]),
         Subdecoder(pattern=31, opcodes=get_csv("minor_31.csv"),
-                   opint=True, bitsel=(1, 11), suffix=5, subdecoders=[]),
+                   opint=True, bitsel=(1, 11), suffix=0b00101, subdecoders=[]),
         Subdecoder(pattern=58, opcodes=get_csv("minor_58.csv"),
                    opint=True, bitsel=(0, 2), suffix=None, subdecoders=[]),
         Subdecoder(pattern=62, opcodes=get_csv("minor_62.csv"),