From: Rob Clark Date: Wed, 18 May 2016 14:38:40 +0000 (-0400) Subject: nir: coverity unitialized pointer read X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fcd6b3f42be904d162b78fe75ba14c6415cdb815;p=mesa.git nir: coverity unitialized pointer read Not sure how coverity arrives at the conclusion that we can read comp[j] unitialized (around line 204), other than not being aware that ncomp is greater than 1 so it won't underflow in the 'if (tex->is_array)' case. Signed-off-by: Rob Clark Reviewed-by: Matt Turner --- diff --git a/src/compiler/nir/nir_lower_tex.c b/src/compiler/nir/nir_lower_tex.c index a0804754098..2086263e3fc 100644 --- a/src/compiler/nir/nir_lower_tex.c +++ b/src/compiler/nir/nir_lower_tex.c @@ -177,6 +177,8 @@ saturate_src(nir_builder *b, nir_tex_instr *tex, unsigned sat_mask) /* split src into components: */ nir_ssa_def *comp[4]; + assume(tex->coord_components >= 1); + for (unsigned j = 0; j < tex->coord_components; j++) comp[j] = nir_channel(b, src, j);