From: Timothy Arceri <tarceri@itsqueeze.com>
Date: Tue, 23 May 2017 12:01:52 +0000 (+1000)
Subject: mesa: remove redundant modulus operation
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fd461b22e9573ba1bf7d86aa22569ace99e033ab;p=mesa.git

mesa: remove redundant modulus operation

The if check above means we can only get here if size is less than 4.

Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
---

diff --git a/src/mesa/program/prog_parameter.c b/src/mesa/program/prog_parameter.c
index 44e680c048c..40bc47de358 100644
--- a/src/mesa/program/prog_parameter.c
+++ b/src/mesa/program/prog_parameter.c
@@ -267,9 +267,8 @@ _mesa_add_parameter(struct gl_program_parameter_list *paramList,
             COPY_4V(paramList->ParameterValues[oldNum + i], values);
          } else {
             /* copy 1, 2 or 3 values */
-            GLuint remaining = size % 4;
-            assert(remaining < 4);
-            for (j = 0; j < remaining; j++) {
+            assert(size < 4);
+            for (j = 0; j < size; j++) {
                paramList->ParameterValues[oldNum + i][j].f = values[j].f;
             }
             /* fill in remaining positions with zeros */