From: Lancelot SIX <lsix@lancelotsix.com>
Date: Sun, 21 Nov 2021 00:20:56 +0000 (+0000)
Subject: gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fdc3b97899bfc9bbd4a562816b7ee38ff712f61d;p=binutils-gdb.git

gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp

When running the testsuite, I have:

    Running .../gdb/testsuite/gdb.base/ui-redirect.exp ...
    DUPLICATE: gdb.base/ui-redirect.exp: redirect while already logging: set logging redirect off

Fix by moving the first 'set logging redirect off' to the end of the
previous [with_test_prefix] test block. The statement's purpose is to
clean the on flag set in this previous block, so moving it there makes
sense and does not change the sequence of commands in the test file.

Tested on x86_64-linux.
---

diff --git a/gdb/testsuite/gdb.base/ui-redirect.exp b/gdb/testsuite/gdb.base/ui-redirect.exp
index 7d9f26862b0..13bc964f46c 100644
--- a/gdb/testsuite/gdb.base/ui-redirect.exp
+++ b/gdb/testsuite/gdb.base/ui-redirect.exp
@@ -95,10 +95,10 @@ with_test_prefix "redirect" {
     gdb_test_no_output "userdefined"
     gdb_test "set logging enabled off" "Done logging to /dev/null\\."
     gdb_test "help" "List of classes of commands:.*"
+    gdb_test_no_output "set logging redirect off"
 }
 
 with_test_prefix "redirect while already logging" {
-    gdb_test_no_output "set logging redirect off"
     gdb_test "set logging enabled on" \
     "Copying output to /dev/null.*Copying debug output to /dev/null\\."
     gdb_test "set logging redirect on" \