From: Tom Tromey <tromey@redhat.com>
Date: Thu, 30 May 2013 16:28:29 +0000 (+0000)
Subject: fix cleanups in som_symtab_read
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fe48dfb1ce26560b351cc9fbaed38e69f4ba89db;p=binutils-gdb.git

fix cleanups in som_symtab_read

This fixes som_symtab_read not to leak cleanups.

	* somread.c (som_symtab_read): Call do_cleanups.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 86c63690db2..2345ff8003a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2013-05-30  Tom Tromey  <tromey@redhat.com>
+
+	* somread.c (som_symtab_read): Call do_cleanups.
+
 2013-05-30  Tom Tromey  <tromey@redhat.com>
 
 	* printcmd.c (print_command_1): Unconditionally call do_cleanups.
diff --git a/gdb/somread.c b/gdb/somread.c
index db6c4d441e9..6c6cc14c117 100644
--- a/gdb/somread.c
+++ b/gdb/somread.c
@@ -46,6 +46,7 @@ static void
 som_symtab_read (bfd *abfd, struct objfile *objfile,
 		 struct section_offsets *section_offsets)
 {
+  struct cleanup *cleanup;
   struct gdbarch *gdbarch = get_objfile_arch (objfile);
   unsigned int number_of_symbols;
   int val, dynamic;
@@ -65,7 +66,7 @@ som_symtab_read (bfd *abfd, struct objfile *objfile,
      We avoid using alloca because the memory size could be so large
      that we could hit the stack size limit.  */
   buf = xmalloc (symsize * number_of_symbols);
-  make_cleanup (xfree, buf);
+  cleanup = make_cleanup (xfree, buf);
   bfd_seek (abfd, obj_som_sym_filepos (abfd), SEEK_SET);
   val = bfd_bread (buf, symsize * number_of_symbols, abfd);
   if (val != symsize * number_of_symbols)
@@ -316,6 +317,8 @@ som_symtab_read (bfd *abfd, struct objfile *objfile,
 								  section),
 					   objfile);
     }
+
+  do_cleanups (cleanup);
 }
 
 /* Scan and build partial symbols for a symbol file.