From: Simon Marchi <simon.marchi@efficios.com>
Date: Thu, 30 Apr 2020 00:35:35 +0000 (-0400)
Subject: gdb: silence shellcheck warning SC2162 (use read -r) in gdbarch.sh
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ffc2844e9672ce4b2d9d2a4f6f676a46f64f4d09;p=binutils-gdb.git

gdb: silence shellcheck warning SC2162 (use read -r) in gdbarch.sh

shellcheck reports:

    In gdbarch.sh line 53:
        while IFS='' read line
                     ^--^ SC2162: read without -r will mangle backslashes.

See the rationale at [1].  In our case, we actually want the backslashes
to be interpreted and removed.  Silence the warning using a directive.

[1] https://github.com/koalaman/shellcheck/wiki/SC2162

gdb/ChangeLog:

	* gdbarch.sh (do_read): Add shellcheck disable directive for
	warning SC2162.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index eb6841640b9..830bc30979c 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
+
+	* gdbarch.sh (do_read): Add shellcheck disable directive for
+	warning SC2162.
+
 2020-04-29  Simon Marchi  <simon.marchi@efficios.com>
 
 	* gdbarch.sh: Use ${foo:-} where shellcheck would report a
diff --git a/gdb/gdbarch.sh b/gdb/gdbarch.sh
index 24f8cdfe90b..13775078c25 100755
--- a/gdb/gdbarch.sh
+++ b/gdb/gdbarch.sh
@@ -50,6 +50,7 @@ do_read ()
     # On some SH's, 'read' trims leading and trailing whitespace by
     # default (e.g., bash), while on others (e.g., dash), it doesn't.
     # Set IFS to empty to disable the trimming everywhere.
+    # shellcheck disable=SC2162
     while IFS='' read line
     do
 	if test "${line}" = ""