From: Rob Clark <robdclark@chromium.org>
Date: Sat, 28 Mar 2020 18:14:05 +0000 (-0700)
Subject: util: fix u_fifo_pop()
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=ffd32266780a83695ae5dd8d36b73fe970cfe4dc;p=mesa.git

util: fix u_fifo_pop()

Seems like no one ever depended on it to actually return false when fifo
is empty.

Fixes: 6e61d062093 ("util: Add super simple fifo")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4366>
---

diff --git a/src/gallium/auxiliary/util/u_fifo.h b/src/gallium/auxiliary/util/u_fifo.h
index a7aad6179d9..b53a3ddd52d 100644
--- a/src/gallium/auxiliary/util/u_fifo.h
+++ b/src/gallium/auxiliary/util/u_fifo.h
@@ -80,7 +80,7 @@ u_fifo_pop(struct util_fifo *fifo, void **ptr)
 
    *ptr = array[fifo->tail];
 
-   ++fifo->num;
+   --fifo->num;
 
    return TRUE;
 }