From: Eric Anholt <eric@anholt.net>
Date: Sat, 22 Oct 2011 02:08:55 +0000 (-0700)
Subject: i965: Add a note about an unsafe-looking state check.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=fff693828ed5398ae284fb01c129d0f8986a126e;p=mesa.git

i965: Add a note about an unsafe-looking state check.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Acked-by: Paul Berry <stereotype441@gmail.com>
---

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index c02b2bc7852..c3755d564a5 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -350,6 +350,11 @@ static bool brw_try_draw_prims( struct gl_context *ctx,
       else
 	 gen6_set_prim(brw, &prim[i]);
 
+      /* Note that before the loop, brw->state.dirty.brw was set to != 0, and
+       * that the state updated in the loop outside of this block is that in
+       * *_set_prim or intel_batchbuffer_flush(), which only impacts
+       * brw->state.dirty.brw.
+       */
       if (brw->state.dirty.brw) {
 	 brw_validate_state(brw);