Eric Anholt [Fri, 27 Aug 2010 19:00:29 +0000 (12:00 -0700)]
i965: Fix swizzling in vector splitting for the new FS backend.
We weren't smearing a component of a split RHS out to reach an unsplit
LHS's writemask, so gl_FragColor (always unsplit) would often get
uninitialized values.
Fixes: glsl-algebraic-add-add-1 (and probably many others).
Zack Rusin [Fri, 27 Aug 2010 17:09:38 +0000 (13:09 -0400)]
graw: fix the build (missing header)
Brian Paul [Fri, 27 Aug 2010 16:51:47 +0000 (10:51 -0600)]
mesa: free the fallback texture object in free_shared_state()
Brian Paul [Fri, 27 Aug 2010 16:21:59 +0000 (10:21 -0600)]
mesa: fix double-underscore naming
Keith Whitwell [Fri, 27 Aug 2010 12:40:23 +0000 (13:40 +0100)]
llvmpipe: use util_iround in place of round
Fix mingw build.
Keith Whitwell [Fri, 27 Aug 2010 12:29:00 +0000 (13:29 +0100)]
util: fix typo in MAX4
Thanks to Michal for spotting it.
Keith Whitwell [Fri, 27 Aug 2010 10:03:58 +0000 (11:03 +0100)]
llvmpipe: eliminate tri->dx, tri->dy values
Use an internal struct for line setup information.
Hui Qi Tay [Tue, 10 Aug 2010 10:41:32 +0000 (11:41 +0100)]
llvmpipe: point sprites rasterization
Point sprites now done in the rasterizer setup code instead of
going through the draw module.
Hui Qi Tay [Fri, 27 Aug 2010 09:46:19 +0000 (10:46 +0100)]
llvmpipe: native point rasterization with better pixel rasterization
A few subpixel_snap and fixed width changes.
Conflicts:
src/gallium/drivers/llvmpipe/lp_setup_point.c
Hui Qi Tay [Fri, 27 Aug 2010 09:37:09 +0000 (10:37 +0100)]
llvmpipe: native point rasterization
Conflicts:
src/gallium/drivers/llvmpipe/lp_setup_context.h
src/gallium/drivers/llvmpipe/lp_setup_line.c
src/gallium/drivers/llvmpipe/lp_setup_tri.c
Keith Whitwell [Thu, 26 Aug 2010 19:09:22 +0000 (20:09 +0100)]
llvmpipe: update line rasterization code to current master
Keith Whitwell [Thu, 26 Aug 2010 19:03:03 +0000 (20:03 +0100)]
util: add MIN4, MAX4
Hui Qi Tay [Wed, 4 Aug 2010 16:13:39 +0000 (17:13 +0100)]
llvmpipe: native line rasterization with correct pixel rasterization
Line rasterization that follows diamond exit rule.
Can still optimize logic for start/endpoints.
Hui Qi Tay [Mon, 19 Jul 2010 14:23:09 +0000 (15:23 +0100)]
llvmpipe: native rasterization for lines
Rasterize lines directly by treating them as 4-sided polygons.
Still need to check the exact pixel rasteration.
Keith Whitwell [Fri, 27 Aug 2010 10:18:11 +0000 (11:18 +0100)]
llvmpipe: add lp_setup_coef to makefile
Keith Whitwell [Sun, 22 Aug 2010 09:57:12 +0000 (10:57 +0100)]
llvmpipe: intrinsics version of triangle coeficient calculation
Looks nice, but makes almost no impact on performance - maybe
a percent or so in isosurf, nothing elsewhere. May be of use
later on.
Vinson Lee [Fri, 27 Aug 2010 07:40:42 +0000 (00:40 -0700)]
gallium: Remove unnecessary header from p_shader_tokens.h.
Remove p_compiler.h.
Vinson Lee [Fri, 27 Aug 2010 07:34:32 +0000 (00:34 -0700)]
tgsi: Include missing header in tgsi_parse.h.
Include p_compiler.h for boolean and INLINE symbols.
Vinson Lee [Fri, 27 Aug 2010 07:31:27 +0000 (00:31 -0700)]
tgsi: Include missing header in tgsi_info.h.
Include p_compiler.h for uint symbol.
Vinson Lee [Fri, 27 Aug 2010 07:26:59 +0000 (00:26 -0700)]
tgsi: Include missing header in tgsi_dump.h.
Include p_compiler.h for uint symbol.
Vinson Lee [Fri, 27 Aug 2010 07:15:04 +0000 (00:15 -0700)]
gallium: Remove unnecessary header from p_format.h.
Remove p_compiler.h.
Vinson Lee [Fri, 27 Aug 2010 07:07:38 +0000 (00:07 -0700)]
graw: Include missing header in graw.h.
Include p_compiler.h for PUBLIC symbol.
Vinson Lee [Fri, 27 Aug 2010 07:04:50 +0000 (00:04 -0700)]
r300g: Include missing header in r300_texture.h.
Include p_compiler.h for uint32_t and boolean symbols.
Kenneth Graunke [Fri, 27 Aug 2010 06:07:45 +0000 (23:07 -0700)]
Fix typo in function name "shading_laguage_version".
Dave Airlie [Fri, 27 Aug 2010 05:45:58 +0000 (15:45 +1000)]
Revert "r600g: simplify states"
This reverts commit
bd25e23bf3740f59ce8859848c715daeb9e9821f.
Apart from introducing a lot of hex magic numbers and being highly impenetable code,
it causes lots of lockups on an average piglit run that always runs without lockups.
Always run piglit before/after doing big things like this.
Dave Airlie [Wed, 25 Aug 2010 05:57:41 +0000 (15:57 +1000)]
r600g: add initial if/else/endif support
this adds handling for some more CF instructions and conditions
also adds parameter for stack size emission
These seem to pass on VS with the stack size hack but not on FS,
TODO: fix FS + stack size calcs
Dave Airlie [Wed, 25 Aug 2010 06:02:38 +0000 (16:02 +1000)]
r600g: optimise op2 and swapped op2 emission.
this makes op2 emission smaller, since it skips instructions
that don't write to the dst. not sure if this could have unwanted
side effects but try it and see.
Dave Airlie [Tue, 24 Aug 2010 01:47:56 +0000 (11:47 +1000)]
r600g: add exp support in theory.
though it isn't passing the test, and this instruction is pure bonghits.
Dave Airlie [Tue, 24 Aug 2010 00:29:33 +0000 (10:29 +1000)]
r600g: add DPH support.
Eric Anholt [Thu, 26 Aug 2010 23:39:41 +0000 (16:39 -0700)]
i965: Add preliminary support for uniforms to the new FS backend.
+269 piglits
Eric Anholt [Fri, 27 Aug 2010 00:04:30 +0000 (17:04 -0700)]
i965: Abort on gl_FragDepth in the new FS backend for now.
It hangs the GPU due to FB_WRITE handling being incomplete. There are
bigger issues to handle first.
Eric Anholt [Thu, 26 Aug 2010 23:59:55 +0000 (16:59 -0700)]
i965: Fix up and actually enable the NewShader and NewShaderProgram hooks.
Eric Anholt [Thu, 26 Aug 2010 22:43:00 +0000 (15:43 -0700)]
i965: Hack in avoidance of c++ reserved keyword in libdrm.
I'm also fixing this upstream in libdrm, but this avoids new libdrm
dependency for the moment.
Eric Anholt [Thu, 26 Aug 2010 21:42:06 +0000 (14:42 -0700)]
i965: Add GLSL IR-level source annotation and comments to new FS debug.
This should make debugging way easier, as now we have context for
reading large programs.
Eric Anholt [Thu, 26 Aug 2010 21:09:54 +0000 (14:09 -0700)]
i965: Use the implied move in brw_math() in the new FS.
Eric Anholt [Tue, 17 Aug 2010 04:53:02 +0000 (21:53 -0700)]
i965: Add support for in varyings to the new FS codegen.
At least some tests, like glsl-vs-sign, now work.
Eric Anholt [Mon, 16 Aug 2010 01:58:58 +0000 (18:58 -0700)]
i965: Start building the codegen visitor.
This can successfully emit a real program that generates magenta now.
Eric Anholt [Thu, 26 Aug 2010 19:12:00 +0000 (12:12 -0700)]
i965: Start building direct GLSL2 IR to 965 assembly codegen.
Our channel-expressions and vector-splitting changes now happen into a
private copy of the IR that we maintain for ourselves. Uniform
assignment still happens by the core, so we continue using Mesa IR
generation not just for swrast fallbacks but also for uniform values
(since there's no storage for their contents other than
shader_program->FragmentProgram->Parameters->ParameterValues). And
most importantly, at the moment no actual codegen is hooked up other
than emitting our favorite color to the framebuffer.
Eric Anholt [Thu, 26 Aug 2010 19:02:26 +0000 (12:02 -0700)]
i965: Add new pass to split vectors into scalar variables
Combined with the previous pass, this lets other optimization passes
do their work thanks to ir_tree_grafting. Still have regression in
instruction count with INTEL_NEW_FS, but register count is even
better.
Eric Anholt [Fri, 13 Aug 2010 09:20:40 +0000 (02:20 -0700)]
i965: Add a pass for the FS to reduce vector expressions down to scalar.
This is a step towards implementing a GLSL IR backend for the 965
fragment shader. Because it has downsides with the current codegen,
it is hidden under the environment variable INTEL_NEW_FS.
This results in an increase in instruction count at the moment (1444
-> 1752 for glsl-fs-raytrace, 345 -> 359 on my demo), because dot
products are turned into a series of multiplies and adds instead of a
custom expansion of MULs and MACs, and by not splitting the variable
types up we don't get tree grafting and thus there are extra moves of
temporary storage. However, register count drops for the non-GLSL
path (64 -> 56 on my demo shader) because the register allocator sees
all the sub-operations.
Eric Anholt [Wed, 11 Aug 2010 03:39:06 +0000 (20:39 -0700)]
i965: Start building 965 FS backend.
Brian Paul [Thu, 26 Aug 2010 17:45:25 +0000 (11:45 -0600)]
llvmpipe: fix PIPE_CAP_MAX_VERTEX_TEXTURE_UNITS query
Fixes crashes in glean glsl1 and demos/src/glsl/vert-tex.
See comments for details.
José Fonseca [Thu, 26 Aug 2010 05:52:12 +0000 (06:52 +0100)]
graw: Add copyright headers to the interfaces.
Eric Anholt [Thu, 26 Aug 2010 18:23:09 +0000 (11:23 -0700)]
ir_to_mesa: Don't assume that an ir_dereference_array is of a variable.
Fixes:
glsl-array-bounds-02 (software)
glsl-array-bounds-04
glsl-array-bounds-06 (software)
glsl-array-bounds-08
Eric Anholt [Thu, 26 Aug 2010 17:42:47 +0000 (10:42 -0700)]
glsl: Add a quick hack to constant folding to reduce duplicated work.
Reduces runtime of glsl-max-varyings 92% on my system.
Vinson Lee [Thu, 26 Aug 2010 17:38:28 +0000 (10:38 -0700)]
st/mesa: Remove unnecessary header.
José Fonseca [Thu, 26 Aug 2010 17:28:29 +0000 (18:28 +0100)]
scons: Fix inverted logic.
Brian Paul [Thu, 26 Aug 2010 17:24:22 +0000 (11:24 -0600)]
docs: update news.html with 7.8.2 release info
Brian Paul [Thu, 26 Aug 2010 17:20:31 +0000 (11:20 -0600)]
docs: remove links to tungstengraphics.com, and misc updates
Brian Paul [Thu, 26 Aug 2010 17:18:06 +0000 (11:18 -0600)]
docs: remove link to old memory.html page
José Fonseca [Thu, 26 Aug 2010 17:19:57 +0000 (18:19 +0100)]
scons: Add glsl_symbol_table.cpp
Eric Anholt [Thu, 26 Aug 2010 15:47:24 +0000 (08:47 -0700)]
i965: Add support for destination RelAddr writes in the VS.
Fixes: glsl-vs-varying-array
Eric Anholt [Thu, 26 Aug 2010 16:10:19 +0000 (09:10 -0700)]
i965: Fix the test for variable indexing of shader inputs.
Shader inputs appear in source registers, not dst registers. Catches
unsupported shaders in glsl-fs-varying-array and Humus
RaytracedShadows.
Ian Romanick [Thu, 26 Aug 2010 16:24:58 +0000 (09:24 -0700)]
glsl2: Remove a couple FINISHME comments that have already been resolved
Kenneth Graunke [Mon, 23 Aug 2010 21:52:06 +0000 (14:52 -0700)]
glsl: Move built-ins to live beyond the global scope.
Per the GLSL 1.20 specification (presumably a clarification of 1.10).
Also, when creating user functions, make a new ir_function that shadows the
built-in ir_function, rather than adding new signatures. User functions
are supposed to hide built-ins, not overload them.
Fixes piglit tests redeclaration-{04, 12, 14}.vert.
Kenneth Graunke [Sat, 21 Aug 2010 03:04:39 +0000 (20:04 -0700)]
glsl: Move is_built_in flag from ir_function_signature to ir_function.
Also rename it to "is_builtin" for consistency.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Kenneth Graunke [Tue, 24 Aug 2010 08:45:49 +0000 (01:45 -0700)]
glsl: Refactor variable declaration handling.
Moving the check for an earlier variable declaration helps cleanly
separate out the re-declaration vs. new declaration code a bit. With
that in place, conflicts between variable names and structure types or
function names aren't caught by the earlier "redeclaration" error
message, so check the return type on glsl_symbol_table::add_variable
and issue an error there. If one occurs, don't emit the initializer.
Fixes redeclaration-01.vert and redeclaration-09.vert.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Kenneth Graunke [Thu, 26 Aug 2010 00:10:16 +0000 (17:10 -0700)]
glsl: Don't add overloads to existing structure constructors.
Instead, make a new ir_function and try to add it to the symbol table.
Fixes piglit test redeclaration-08.vert.
Kenneth Graunke [Wed, 25 Aug 2010 23:37:46 +0000 (16:37 -0700)]
glsl: Remove name_declared_this_scope check when adding functions.
Instead, rely on the symbol table's rules.
Fixes redeclaration-02.vert.
Kenneth Graunke [Sun, 22 Aug 2010 03:23:18 +0000 (20:23 -0700)]
glsl: Use a single shared namespace in the symbol table.
As of 1.20, variable names, function names, and structure type names all
share a single namespace, and should conflict with one another in the
same scope, or hide each other in nested scopes.
However, in 1.10, variables and functions can share the same name in the
same scope. Structure types, however, conflict with/hide both.
Fixes piglit tests redeclaration-06.vert, redeclaration-11.vert,
redeclaration-19.vert, and struct-05.vert.
Brian Paul [Thu, 26 Aug 2010 15:20:18 +0000 (09:20 -0600)]
st/mesa: add missing packed depth/stencil formats in st_format_datatype()
Fixes llvmpipe regression from one of the prev commits.
Brian Paul [Thu, 26 Aug 2010 14:59:43 +0000 (08:59 -0600)]
mesa: fix mixed-up function call name
Nick Bowler [Thu, 26 Aug 2010 14:26:21 +0000 (07:26 -0700)]
mesa: Identify packed depth/stencil buffers using the Format field.
Intel sometimes uses packed depth/stencil buffers even when only a depth
buffer or only a stencil buffer was requested. Common code currently
uses the _BaseFormat field to determine whether a depth/stencil wrapper
is necessary. But unless the user explicitly requested a packed
depth/stencil buffer, the _BaseFormat field does not encode this
information, and the required wrappers are not created.
The problem was introduced by commit
45e76d2665b38b ("mesa: remove a
bunch of gl_renderbuffer fields"), which killed off the _ActualFormat
field upon which the decision to create a wrapper used to be made. This
patch changes the logic to use the Format field instead, which is more
like the old code.
Fixes fdo bug 27590.
Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Signed-off-by: Brian Paul <brianp@vmware.com>
Nick Bowler [Wed, 25 Aug 2010 13:14:42 +0000 (06:14 -0700)]
intel: Merge identical cases in switch statement.
Signed-off-by: Nick Bowler <nbowler@draconx.ca>
Signed-off-by: Brian Paul <brianp@vmware.com>
Andre Maasikas [Thu, 26 Aug 2010 12:22:21 +0000 (15:22 +0300)]
r600: fix vertex buffer size calculation
when we dont know max_index we cannot calculate vb size from count
anymore - just use the bo size.
Also added an assert to remind that we dont handle GL_INT GL_DOUBLE
upload when we dont' know max_index - will fix later
José Fonseca [Thu, 26 Aug 2010 10:37:42 +0000 (11:37 +0100)]
graw: Undo late loading of graw drivers.
Keith prefers a clean separation between graw applications and
implementations, where apps do not link libgallium.a but instead
get all functionality they need via graw interface.
Although this is not incompatible with late loading of graw drivers, it
it would make it very hard to maintain, as wrappers for every utility
symbol exposed in graw would have to be written or generated somehow.
Chia-I Wu [Wed, 25 Aug 2010 18:15:22 +0000 (02:15 +0800)]
st/mesa: Fix glEGLImageTargetTexture2DOES.
stObj->pt should be set in st_bind_surface, just as in st_TexImage. On
the other hand, st_TexImage should unreference stObj->pt. It also needs
to initialize the texture image again as _mesa_clear_texture_object
clears the image.
Chia-I Wu [Wed, 25 Aug 2010 17:49:18 +0000 (01:49 +0800)]
st/egl: Add support for EGL_MESA_image_drm.
Chia-I Wu [Thu, 26 Aug 2010 07:10:14 +0000 (01:10 -0600)]
st/egl: Add support for EGL_KHR_surfaceless_*.
Chia-I Wu [Wed, 25 Aug 2010 16:51:28 +0000 (00:51 +0800)]
st/mesa: Add support for surfaceless current contexts.
A surfaceless current context is a context that is made current without
draw and read framebuffers. Such contexts can only render to FBOs.
Chia-I Wu [Wed, 25 Aug 2010 16:38:59 +0000 (00:38 +0800)]
st/egl: Make KMS support optional in KMS backend.
It should be called DRM backend now.
Vinson Lee [Thu, 26 Aug 2010 08:38:23 +0000 (01:38 -0700)]
r300g: Include missing header in r300_texture_desc.h.
Include p_format.h for enum pipe_format symbol.
Fixes r300g build.
Vinson Lee [Thu, 26 Aug 2010 08:30:07 +0000 (01:30 -0700)]
gallium: Clean up header file inclusion in p_defines.h.
Remove p_format.h.
Include p_compiler.h for boolean and uint64_t symbols.
Vinson Lee [Thu, 26 Aug 2010 08:21:10 +0000 (01:21 -0700)]
gallium: Clean up header file inclusion in p_context.h.
Remove p_state.h.
Include p_compiler.h for boolean symbol.
Add needed forward declarations after removing p_state.h.
Vinson Lee [Thu, 26 Aug 2010 08:14:28 +0000 (01:14 -0700)]
graw: Include missing header in graw_dl.h.
Include p_state.h for pipe_shader_state symbol.
Vinson Lee [Thu, 26 Aug 2010 08:08:30 +0000 (01:08 -0700)]
util: Include missing header in u_simple_shaders.c.
Include p_state.h for PIPE_MAX_COLOR_BUFS symbol.
Vinson Lee [Thu, 26 Aug 2010 07:34:30 +0000 (00:34 -0700)]
tgsi: Include missing header in tgsi_sse2.h.
Include p_compiler.h for boolean symbol.
Clean up forward declarations.
Vinson Lee [Thu, 26 Aug 2010 07:29:58 +0000 (00:29 -0700)]
rtasm: Include missing header in rtasm_x86sse.h.
Include p_compiler.h for stdint.h uint*_t symbols.
Vinson Lee [Thu, 26 Aug 2010 07:22:19 +0000 (00:22 -0700)]
pipebuffer: Clean up header file inclusion in pb_bufmgr.h.
Remove p_compiler.h and p_defines.h.
Include pb_buffer.h for pb_size symbol.
Eric Anholt [Thu, 26 Aug 2010 07:07:58 +0000 (00:07 -0700)]
glsl2: Move ir_expression_flattening to using the rvalue visitor class.
The previous implementation was missing handling of some rvalues, such
as "if" conditions, leading to glsl-mat-int-from-ctor-* not getting
caught.
Eric Anholt [Thu, 26 Aug 2010 06:27:56 +0000 (23:27 -0700)]
glsl: Don't consider things with a type containing a sampler as an lvalue.
We had ad-hoc handled some common cases by flagging sampler-typed
variables as read_only, and rejected initializers of samplers.
However, people could sneak them in in all sorts of surprising ways,
like using whole-array or structure assignment.
Fixes:
glslparsertest/glsl2/sampler-01.frag
glslparsertest/glsl2/sampler-03.frag
glslparsertest/glsl2/sampler-04.frag
glslparsertest/glsl2/sampler-06.frag
Bug #27403.
Eric Anholt [Thu, 26 Aug 2010 06:26:29 +0000 (23:26 -0700)]
mesa: Disable the debug spam for x86 CPU detection with a compile-time flag.
I don't know of any problems with CPU detection in years. Don't spam
the user that was just looking to enable assertions with this stuff.
Eric Anholt [Thu, 26 Aug 2010 06:24:50 +0000 (23:24 -0700)]
mesa: Move the x86 detection debug messages next to the detection.
Eric Anholt [Thu, 26 Aug 2010 06:14:45 +0000 (23:14 -0700)]
mesa: Don't warn when the desired result of s3tc lib available occurs.
Vinson Lee [Thu, 26 Aug 2010 06:37:27 +0000 (23:37 -0700)]
util: Include missing header in u_blit.h.
Include p_compiler.h for uint symbol.
Clean up forward declarations.
Vinson Lee [Thu, 26 Aug 2010 06:31:04 +0000 (23:31 -0700)]
util: Include missing header in u_bitmask.h.
Include p_compiler.h for boolean symbol.
Vinson Lee [Thu, 26 Aug 2010 06:04:39 +0000 (23:04 -0700)]
util: Include missing header in u_dirty_surfaces.h.
Include p_state.h for pipe_surface symbol.
Vinson Lee [Thu, 26 Aug 2010 05:55:15 +0000 (22:55 -0700)]
util: Add include guard in u_split_prim.h.
Vinson Lee [Thu, 26 Aug 2010 05:50:15 +0000 (22:50 -0700)]
util: Include missing headers in u_split_prim.h.
Include p_compiler.h for boolean symbol.
Include u_debug.h for assert symbol.
José Fonseca [Thu, 26 Aug 2010 05:47:24 +0000 (06:47 +0100)]
graw: Remove graw-null.
Pointless now that the graw tests can be built independently of any graw
implementation.
José Fonseca [Thu, 26 Aug 2010 05:44:02 +0000 (06:44 +0100)]
graw: Dynamically load graw libraries.
This allows to build multiple graws libs simultaneously and avoid
unnecessary rebuilds of the tests.
Also remove graw_util.c from inside the graw implementation -- it was
only being provided by one implementation, and graw tests were linking
against gallium anyway.
José Fonseca [Thu, 26 Aug 2010 05:40:49 +0000 (06:40 +0100)]
scons: Fix old script compatability logic.
Sconscript could be invoked twice if specified in the command line.
Vinson Lee [Thu, 26 Aug 2010 05:41:20 +0000 (22:41 -0700)]
util: Include missing headers in u_tile.h.
Include p_format.h for enum pipe_format symbol.
Include p_state.h for pipe_box symbol.
Vinson Lee [Thu, 26 Aug 2010 05:34:31 +0000 (22:34 -0700)]
util: Clean up header file inclusion in u_upload_mgr.h.
Remove p_defines.h.
Remove unnecessary forward declarations.
Add forward declaration for pipe_context.
Marek Olšák [Thu, 26 Aug 2010 01:28:47 +0000 (03:28 +0200)]
r300g: fix constant buffer upload once again for r3xx->r4xx
Vinson Lee [Thu, 26 Aug 2010 01:06:01 +0000 (18:06 -0700)]
r600: Remove unnecessary headers.
Vinson Lee [Thu, 26 Aug 2010 01:00:23 +0000 (18:00 -0700)]
r300: Remove unnecessary header.
Eric Anholt [Wed, 25 Aug 2010 23:38:37 +0000 (16:38 -0700)]
Revert "mesa: Don't add 1 to GL_ACTIVE_UNIFORM_MAX_LENGTH."
This reverts commit
001a7bfdfc8b3c8930d5ced21982dbdfb8cd35b3. I
hadn't found the section of the spec clarifying that the old behavior
was right. Reverting fixes the new version of the testcase, and the
Humus demos that could no longer find their uniforms.
Bug #29782
Bug #29783
Aras Pranckevicius [Wed, 25 Aug 2010 19:42:13 +0000 (22:42 +0300)]
glsl: fix crash with variable indexing into array in a struct
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Eric Anholt [Wed, 25 Aug 2010 23:00:09 +0000 (16:00 -0700)]
i965: Fix detection of implicit MOVs to message regs in brw_optimize.c.
Texcoords in AmbientApertureLighting were getting trashed since the
move of math arguments to implied moves, due to the logic for
detecting ALU message reg writes overriding the logic for SEND
implicit message reg writes.