Andreas Krebbel [Mon, 16 Dec 2019 08:03:28 +0000 (08:03 +0000)]
Fix PR92950: Wrong code emitted for movv1qi
The backend emits 16 bit memory loads for single element character
vector. As a result the character will not be right justified in the
GPR.
gcc/ChangeLog:
2019-12-16 Andreas Krebbel <krebbel@linux.ibm.com>
PR target/92950
* config/s390/vector.md ("mov<mode>" for V_8): Replace lh, lhy,
and lhrl with llc.
gcc/testsuite/ChangeLog:
2019-12-16 Andreas Krebbel <krebbel@linux.ibm.com>
PR target/92950
* gcc.target/s390/vector/pr92950.c: New test.
From-SVN: r279410
Andrew Pinski [Mon, 16 Dec 2019 03:43:19 +0000 (03:43 +0000)]
Add a couple int128_t bit-field testcases.
2019-12-15 Andrew Pinski <apinski@marvell.com>
* gcc.c-torture/compile/bitfield-1.c: New test.
* gcc.c-torture/compile/bitfield-endian-1.c: New test.
* gcc.c-torture/compile/bitfield-endian-2.c: New test.
From-SVN: r279409
GCC Administrator [Mon, 16 Dec 2019 00:16:20 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279408
GCC Administrator [Sun, 15 Dec 2019 00:16:13 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279402
Jakub Jelinek [Sat, 14 Dec 2019 22:18:53 +0000 (23:18 +0100)]
re PR preprocessor/92919 (invalid memory access in wide_str_to_charconst when running ucn2.C testcase (caught by hwasan))
PR preprocessor/92919
* charset.c (wide_str_to_charconst): If str contains just the
NUL terminator, punt quietly.
From-SVN: r279399
Martin Sebor [Sat, 14 Dec 2019 17:31:54 +0000 (17:31 +0000)]
extend.texi (attribute access): Correct typos.
gcc/ChangeLog:
* doc/extend.texi (attribute access): Correct typos.
From-SVN: r279398
Jakub Jelinek [Sat, 14 Dec 2019 11:19:07 +0000 (12:19 +0100)]
re PR ipa/92357 (ICE in IPA pass fnsummary in openmp offload)
PR ipa/92357
* ipa-fnsummary.c (ipa_fn_summary_write): Use
lto_symtab_encoder_iterator with lsei_start_function_in_partition and
lsei_next_function_in_partition instead of walking all cgraph nodes
in encoder.
From-SVN: r279395
Jakub Jelinek [Sat, 14 Dec 2019 11:18:30 +0000 (12:18 +0100)]
re PR tree-optimization/92930 (GCC incorrectly optimizes away __builtin_apply() calls)
PR tree-optimization/92930
* ipa-pure-const.c (special_builtin_state): Don't handle
BUILT_IN_APPLY. Formatting fixes.
(check_call): Formatting fixes.
* gcc.dg/tree-ssa/pr92930.c: New test.
From-SVN: r279394
Iain Sandoe [Sat, 14 Dec 2019 08:25:02 +0000 (08:25 +0000)]
[Darwin, PPC] Use Darwin9 bundle header for Rosetta builds.
On Darwin10 it's possible to make a 32b PPC build using the
'Rosetta' emulator. However, these builds need to make use of
Darwin9 crts (for exes, dylibs and bundles). This adds the
change to cater for bundles.
gcc/ChangeLog:
2019-12-14 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.h (DARWIN_EXTRA_SPECS): Add new
bundle spec. (DARWIN_BUNDLE1_SPEC): New.
(STARTFILE_SPEC): Use darwin bundle spec.
* config/rs6000/darwin.h (DARWIN_BUNDLE1_SPEC): New.
(DARWIN_DYLIB1_SPEC): Delete duplicate.
From-SVN: r279393
Martin Sebor [Sat, 14 Dec 2019 00:52:46 +0000 (00:52 +0000)]
PR middle-end/91582 - missing heap overflow detection for strcpy
PR middle-end/91582 - missing heap overflow detection for strcpy
PR middle-end/92868 - ICE: tree check: expected integer_cst, have ssa_name
gcc/ChangeLog:
PR middle-end/91582
PR middle-end/92868
* builtins.c (addr_decl_size): New function.
(gimple_call_alloc_size): Add arguments.
(compute_objsize): Add an argument. Set *PDECL even for allocated
objects.
Correct checking for negative wide_int.
Correct handling of negative outer offsets into unknown regions
or with unknown inner offsets.
Extend offsets to at most sizetype precision.
Only handle constant subobject sizes.
* builtins.h (gimple_call_alloc_size): Add arguments.
* tree.c (component_ref_size): Always return sizetype.
* tree-ssa-strlen.c (strinfo::alloc): New member.
(get_addr_stridx): Add argument.
(get_stridx): Use ptrdiff_t. Add argument.
(new_strinfo): Set new member.
(get_string_length): Handle alloca and VLA.
(dump_strlen_info): Dump more state.
(maybe_invalidate): Print more info. Decrease indentation.
(unshare_strinfo): Set new member.
(valid_builtin_call): Handle alloca and VLA.
(maybe_warn_overflow): Check and set no-warning bit. Improve
handling of offsets. Print allocated objects.
(handle_builtin_strlen): Handle strinfo records with null lengths.
(handle_builtin_strcpy): Add argument. Call maybe_warn_overflow.
(is_strlen_related_p): Handle dynamically allocated objects.
(get_range): Add argument.
(handle_builtin_malloc): Rename...
(handle_alloc): ...to this and handle all allocation functions.
(handle_builtin_memset): Call maybe_warn_overflow.
(count_nonzero_bytes): Handle more MEM_REF forms.
(strlen_check_and_optimize_call): Call handle_alloc_call. Pass
arguments to more callees.
(handle_integral_assign): Add argument. Create strinfo entries
for MEM_REF assignments.
(check_and_optimize_stmt): Handle more MEM_REF forms.
gcc/testsuite/ChangeLog:
PR middle-end/91582
* c-c++-common/Wrestrict.c: Adjust expected warnings.
* gcc/testsuite/c-c++-common/Wstringop-truncation-4.c: Enable more
warnings.
* gcc/testsuite/c-c++-common/Wstringop-truncation.c: Remove an xfail.
* gcc.dg/Warray-bounds-46.c: Disable -Wstringop-overflow.
* gcc.dg/Warray-bounds-47.c: Same.
* gcc.dg/Warray-bounds-52.c: New test.
* gcc.dg/Wstringop-overflow-27.c: New test.
* gcc.dg/Wstringop-overflow-28.c: New test.
* gcc.dg/Wstringop-overflow-29.c: New test.
* gcc.dg/attr-alloc_size.c (test): Disable -Warray-bounds.
* gcc.dg/attr-copy-2.c: Adjust expected warnings.
* gcc.dg/builtin-stringop-chk-5.c: Adjust text of expected messages.
* gcc.dg/strlenopt-86.c: Relax test.
* gcc.target/i386/pr82002-1.c: Prune expected warnings.
From-SVN: r279392
GCC Administrator [Sat, 14 Dec 2019 00:16:44 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279391
Julian Brown [Fri, 13 Dec 2019 23:14:15 +0000 (23:14 +0000)]
Fix potential race condition in OpenACC "exit data" operations
PR libgomp/92881
libgomp/
* libgomp.h (gomp_remove_var_async): Add prototype.
* oacc-mem.c (delete_copyout): Call gomp_remove_var_async instead of
gomp_remove_var.
* target.c (gomp_unref_tgt): Change return type to bool, indicating
whether target_mem_desc was unmapped.
(gomp_unref_tgt_void): New.
(gomp_remove_var): Reimplement in terms of...
(gomp_remove_var_internal): ...this new helper function.
(gomp_remove_var_async): New, implemented using above helper function.
(gomp_unmap_vars_internal): Use gomp_unref_tgt_void instead of
gomp_unref_tgt.
Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
From-SVN: r279388
Iain Sandoe [Fri, 13 Dec 2019 21:06:22 +0000 (21:06 +0000)]
[Darwin, PPC] Use Darwin9 dylib header for Rosetta builds.
On Darwin10 it's possible to make a 32b PPC build using the
'Rosetta' emulator. However, these builds need to make use of
Darwin9 crts (for exes and dylibs). This adds the change to
cater for dylibs.
gcc/ChangeLog:
2019-12-13 Iain Sandoe <iain@sandoe.co.uk>
* config/rs6000/darwin.h (DARWIN_DYLIB1_SPEC): New.
From-SVN: r279381
Ian Lance Taylor [Fri, 13 Dec 2019 20:04:47 +0000 (20:04 +0000)]
libbacktrace: add DWARF 5 support
* dwarf.c (struct attr): Add val field.
(enum attr_val_encoding): Add ATTR_VAL_ADDDRESS_INDEX,
ATTR_VAL_STRING_INDEX, ATTR_VAL_RNGLISTS_INDEX.
(struct line_header): Add addrsize field.
(struct line_header_format): Define.
(struct unit): Add str_offsets_base, addr_base, and rnglists_base
fields.
(read_uint24): New static function.
(read_attribute): Add implicit_val parameter. Replace dwarf_str
and dwarf_str_size parameters with dwarf_sections parameter. Add
support for new DWARF 5 forms. Change all callers.
(resolve_string): New static function.
(resolve_addr_index): Likewise.
(read_abbrevs): Support DW_FORM_implicit_const.
(struct pcrange): Add lowpc_is_addr_index, highpc_is_addr_Index,
and ranges_is_index fields.
(update_pcrange): Support DWARF 5 encodings.
(add_high_low_range): New static function, split out of
add_ranges.
(add_ranges_from_ranges): Likewise.
(add_ranges_from_rnglists): New static function.
(add_ranges): Just call new helper functions.
(find_address_ranges): Use resolve_string for strings, after
reading all attributes. Handle new DWARF 5 attributes.
(build_address_map): Support DWARF 5 compilation units.
(read_v2_paths): New static function, split out of
read_line_header.
(read_lnct): New static function.
(read_line_header_format_entries): Likewise.
(read_line_header): Add ddata parameter. Support DWARF 5 line
headers. Call new helper functions. Change all callers.
(read_line_program): Use addrsize from line program header. Don't
special case directory index 0 for DWARF 5.
(read_referenced_name): Use resolve_string.
(read_function_entry): Handle DWARF 5 encodings. Use
resolve_string.
* internal.h (enum dwarf_section): Add DEBUG_ADDR,
DEBUG_STR_OFFSETS, DEBUG_LINE_STR, DEBUG_RNGLISTS.
* elf.c (dwarf_section_names): Add new section names.
* pecoff.c (dwarf_section_names): Likewise.
* xcoff.c (xcoff_add): Clear dwarf_sections before setting
fields.
* configure.ac: Define HAVE_DWARF5 automake conditional.
* Makefile.am (dwarf5_SOURCES): New variable if HAVE_DWARF5.
(dwarf5_CFLAGS, dwarf5_LDADD): Likewise.
(dwarf5_alloc_SOURCES, dwarf5_alloc_CFLAGS): Likewise.
(dwarf5_alloc_LDADD): Likewise.
(BUILDTESTS): Add dwarf5 tests if HAVE_DWARF5.
(CLEANFILES, clean-local): Define.
From-SVN: r279380
Jan Hubicka [Fri, 13 Dec 2019 18:43:20 +0000 (19:43 +0100)]
lto-streamer-in.c (input_function): Add node parameter.
* lto-streamer-in.c (input_function): Add node parameter.
(lto_read_body_or_constructor): Use it.
From-SVN: r279379
Andrew Stubbs [Fri, 13 Dec 2019 17:40:06 +0000 (17:40 +0000)]
Update OpenACC tests for amdgcn
2019-12-13 Andrew Stubbs <ams@codesourcery.com>
libgomp/
* testsuite/libgomp.oacc-c-c++-common/acc_prof-init-1.c: Handle gcn.
* testsuite/libgomp.oacc-c-c++-common/acc_prof-kernels-1.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/acc_prof-parallel-1.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/asyncwait-nop-1.c: Likewise.
* testsuite/libgomp.oacc-c-c++-common/function-not-offloaded.c:
Likewise.
* testsuite/libgomp.oacc-c-c++-common/async_queue-1.c: Disable on GCN.
* testsuite/libgomp.oacc-c-c++-common/tile-1.c: Likewise.
From-SVN: r279378
Roman Zhuykov [Fri, 13 Dec 2019 17:33:38 +0000 (17:33 +0000)]
modulo-sched: fix branch rescheduling issue (PR92591)
PR rtl-optimization/92591
* modulo-sched.c (ps_add_node_check_conflicts): Improve checking
for history > 0 case.
testsuite:
PR rtl-optimization/92591
* gcc.dg/pr92951-1.c: New test.
* gcc.dg/pr92951-2.c: New test.
From-SVN: r279377
Roman Zhuykov [Fri, 13 Dec 2019 17:17:31 +0000 (17:17 +0000)]
modulo-sched: fix parameters usage and their ranges
* modulo-sched.c (sms_schedule): Use param_sms_max_ii_factor
value instead of macro. Adjust comment.
(sms_schedule_by_order): Use parameter value without macro.
* params.opt: Add ranges for modulo scheduler parameters,
set param_sms_max_ii_factor = 2 by default.
From-SVN: r279376
Roman Zhuykov [Fri, 13 Dec 2019 17:02:53 +0000 (17:02 +0000)]
modulo-sched: speed up DDG analysis (PR90001)
PR rtl-optimization/90001
* ddg.c (create_ddg): Init max_dist array for each node.
(free_ddg): Free max_dist array.
(create_ddg_edge): Use bool field instead of aux union.
(set_recurrence_length): Use prepared max_dist information instead
of calling longest_simple_path.
(create_scc): Remove graph argument, fill node's aux.count with
SCC id, and move set_recurrence_length call to...
(create_ddg_all_sccs): ...here, after filling all max_dist arrays
using Floyd–Warshall-like algorithm.
(update_dist_to_successors): Remove the whole function.
(longest_simple_path): Likewise.
* ddg.h (struct ddg_node): Add max_dist pointer.
(struct ddg_edge): Use bool field instead of unused aux union.
From-SVN: r279375
Andrew Stubbs [Fri, 13 Dec 2019 16:37:17 +0000 (16:37 +0000)]
Sub-dword vector multiply for amdgcn
2019-12-13 Andrew Stubbs <ams@codesourcery.com>
gcc/
* config/gcn/gcn-valu.md (mulv64si3<exec>): Rename to ...
(mul<mode>3<exec>): ... this, and implement sub-dword patterns.
(mulv64si3_dup<exec>): Rename to ...
(mul<mode>3_dup<exec>): ... this, and implement sub-dword patterns.
From-SVN: r279374
Jan Hubicka [Fri, 13 Dec 2019 15:41:55 +0000 (16:41 +0100)]
Fix merging of common traget info.
* ipa-utils.c (ipa_merge_profiles): Improve dumping; merge common
targets.
From-SVN: r279373
Andrew Stubbs [Fri, 13 Dec 2019 15:29:26 +0000 (15:29 +0000)]
Sub-dword vector extend and truncate for amdgcn
2019-12-13 Andrew Stubbs <ams@codesourcery.com>
gcc/
* config/gcn/gcn-valu.md (sdwa): New mode attribute.
(VCVT_FROM_MODE): Rename to ...
(VCVT_MODE): ... this.
(VCVT_TO_MODE): Delete mode iterator.
(VCVT_FMODE): New mode iterator.
(VCVT_IMODE): Likewise.
(<cvt_name><VCVT_FROM_MODE:mode><VCVT_TO_MODE:mode>2<exec>): Change ...
(<cvt_name><VCVT_MODE:mode><VCVT_FMODE:mode>2<exec>): ... to this.
(<cvt_name><VCVT_FMODE:mode><VCVT_IMODE:mode>2<exec>): New.
(zero_convert): New code iterator.
(convop): New code attribute.
(<convop><VEC_ALL1REG_INT_ALT:mode><VEC_ALL1REG_INT_MODE:mode>2<exec>)
: New.
(extend<VEC_ALL1REG_INT_ALT:mode><VEC_ALL1REG_INT_MODE:mode>2<exec>)
: New.
(vec_truncatev64div64si): Rename to ...
(truncv64di<mode>2): ... this and implement sub-dword patterns.
(vec_truncatev64div64si_exec): Rename to ...
(truncv64di<mode>2_exec): ... this and implement sub-dword patterns.
(<convop><mode>v64di2): New insn_and_split.
(<convop><mode>v64di2_exec): Likewise.
(mask_gather_load<mode>): Update truncate names.
(mask_scatter_store<mode>): Likewise.
* config/gcn/gcn.c (gcn_expand_scaled_offsets): Update truncate names.
From-SVN: r279372
Dennis Zhang [Fri, 13 Dec 2019 10:22:39 +0000 (10:22 +0000)]
[AArch64] Enable CLI for Armv8.6-a: armv8.6-a, i8mm and bf16
2019-12-13 Dennis Zhang <dennis.zhang@arm.com>
gcc/
* config/aarch64/aarch64-arches.def (armv8.6-a): New.
* config/aarch64/aarch64-c.c (aarch64_update_cpp_builtins): Define
__ARM_FEATURE_MATMUL_INT8, __ARM_FEATURE_BF16_VECTOR_ARITHMETIC and
__ARM_FEATURE_BF16_SCALAR_ARITHMETIC when enabled.
* config/aarch64/aarch64-option-extensions.def (i8mm, bf16): New.
(fp): Disabling fp also disables i8mm and bf16.
(simd): Disabling simd also disables i8mm.
* config/aarch64/aarch64.h (AARCH64_FL_V8_6): New macro.
(AARCH64_FL_I8MM, AARCH64_FL_BF16, AARCH64_FL_FOR_ARCH8_6): Likewise.
(AARCH64_ISA_V8_6, AARCH64_ISA_I8MM, AARCH64_ISA_BF16): Likewise.
(TARGET_I8MM, TARGET_BF16_FP, TARGET_BF16_SIMD): Likewise.
* doc/invoke.texi (armv8.6-a, i8mm, bf16): Document new options
and add a new table to list permissible values for ARCH.
gcc/testsuite/
* gcc.target/aarch64/pragma_cpp_predefs_2.c: Add tests for i8mm
and bf16 features.
From-SVN: r279370
Jakub Jelinek [Fri, 13 Dec 2019 10:12:55 +0000 (11:12 +0100)]
re PR target/92908 (wrong code with -Og -fno-tree-fre -mavx512bw and vector compare)
PR target/92908
* simplify-rtx.c (simplify_relational_operation): Punt for vector
cmp_mode and scalar mode, if simplify_relational_operation returned
const_true_rtx.
(simplify_const_relational_operation): Change VOID_mode in function
comment to VOIDmode.
* gcc.target/i386/avx512bw-pr92908.c: New test.
From-SVN: r279369
Gary Dismukes [Fri, 13 Dec 2019 09:05:43 +0000 (09:05 +0000)]
[Ada] Minor rewording of one sentence
2019-12-13 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* doc/gnat_rm/implementation_defined_pragmas.rst: Minor
rewording of one sentence.
* gnat_rm.texi: Regenerate.
From-SVN: r279368
Arnaud Charlet [Fri, 13 Dec 2019 09:05:38 +0000 (09:05 +0000)]
[Ada] Unnesting and annex E
2019-12-13 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* exp_unst.adb (Unnest_Subprogram): Account for trees produced
by Annex E constructs.
From-SVN: r279367
Ghjuvan Lacambre [Fri, 13 Dec 2019 09:05:33 +0000 (09:05 +0000)]
[Ada] implementation_defined_pragmas.rst: Update Initialize_Scalars docs
2019-12-13 Ghjuvan Lacambre <lacambre@adacore.com>
gcc/ada/
* doc/gnat_rm/implementation_defined_pragmas.rst: Update
Initialize_Scalars documentation.
* gnat_rm.texi: Regenerate.
From-SVN: r279366
Javier Miranda [Fri, 13 Dec 2019 09:05:28 +0000 (09:05 +0000)]
[Ada] Spurious error on precondition of subprogram instantiation
2019-12-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* sem_ch13.adb (Analyze_Aspect_Specification): Processing a
precondition, if the expression is of the form A and then B, do
not generate separate Pre/Post aspects for the separate clases
when we are processing a generic unit. Required to avoid
reporting spurious visibility errors on the instantiations.
From-SVN: r279365
Eric Botcazou [Fri, 13 Dec 2019 09:05:23 +0000 (09:05 +0000)]
[Ada] Better error message for aliased formal and atomic actual
2019-12-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Actuals): Give canonical error for
illegal case of atomic/volatile parameter also if the formal is
aliased.
From-SVN: r279364
Eric Botcazou [Fri, 13 Dec 2019 09:05:18 +0000 (09:05 +0000)]
[Ada] Clear confusion about subcomponents of atomic object
2019-12-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_util.ads (Is_Atomic_Object): Mention relevant RM clauses.
* sem_util.adb (Is_Atomic_Object): For an indexed component,
only look at the Has_Atomic_Components aspect of the prefix and
do not recurse on it; for a selected component, do not look at
the prefix.
(Is_Atomic_Or_VFA_Object): Minor tweak.
From-SVN: r279363
Arnaud Charlet [Fri, 13 Dec 2019 09:05:13 +0000 (09:05 +0000)]
[Ada] Fix support for > 24 hours image in Ada.Calendar.Formatting
2019-12-13 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* libgnat/a-calfor.ads, libgnat/a-calfor.adb (Split_Duration):
New procedure.
(Split, Image): Use Split_Duration. Update Image spec.
From-SVN: r279362
Javier Miranda [Fri, 13 Dec 2019 09:05:08 +0000 (09:05 +0000)]
[Ada] Adding support for unsupported type conversions in CCG
2019-12-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_unst.adb (Unnest_Subprogram): Generate an extra temporary
to facilitate the C backend processing dereferences.
From-SVN: r279361
Javier Miranda [Fri, 13 Dec 2019 09:05:03 +0000 (09:05 +0000)]
[Ada] Pragma Linker_Section in subprogram instantiations in CCG
2019-12-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma): Propagate the
Linker_Section_Attribute to the ultimate alias of the subprogram
to facilitate the C backend processing this attribute.
From-SVN: r279360
Yannick Moy [Fri, 13 Dec 2019 09:04:58 +0000 (09:04 +0000)]
[Ada] Avoid spurious mismatch error of assertion policy in generics
2019-12-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb (Original_Aspect_Pragma_Name): Go through
Original_Node for pragma.
From-SVN: r279359
Piotr Trojanek [Fri, 13 Dec 2019 09:04:53 +0000 (09:04 +0000)]
[Ada] Minor fix typo in comment
2019-12-13 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* exp_aggr.adb, exp_unst.adb: Minor fix typo in comment.
From-SVN: r279358
Steve Baird [Fri, 13 Dec 2019 09:04:48 +0000 (09:04 +0000)]
[Ada] Detect illegal implicit type conversions
2019-12-13 Steve Baird <baird@adacore.com>
gcc/ada/
* sem_res.adb (Resolve, Valid_Conversion): Add Base_Type call
when testing whether a type is a general access type.
From-SVN: r279357
Javier Miranda [Fri, 13 Dec 2019 09:04:43 +0000 (09:04 +0000)]
[Ada] Adding support for unsupported type conversion in CCG
2019-12-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Unchecked_Type_Conversion): Generate an
extra temporary for cases unsupported by the C backend.
From-SVN: r279356
Steve Baird [Fri, 13 Dec 2019 09:04:38 +0000 (09:04 +0000)]
[Ada] Implement AI12-0109 (prohibit some "early" derivations)
2019-12-13 Steve Baird <baird@adacore.com>
gcc/ada/
* einfo.ads: Correct comment for Derived_Type_Link to reflect
that fact that this function is now used for more than just
generation of warnings.
* sem_ch3.adb (Build_Derived_Type): Do not call
Set_Derived_Type_Link if the derived type and the parent type
are in different compilation units. Such a derivation cannot be
a problematic "early" derivation (identifying these is what the
Derived_Type_Link attribute is used for) and we don't like
inter-unit references that go in the opposite direction of
semantic dependencies.
* sem_ch13.adb (Is_Type_Related_Rep_Item): A new function,
analogous to the existing function Is_Operational_Item.
(Rep_Item_Too_Late): Generate a hard error (with same text as
the warning that was previously being generated) if the
AI12-0109 legality rule is violated.
From-SVN: r279355
Eric Botcazou [Fri, 13 Dec 2019 09:04:33 +0000 (09:04 +0000)]
[Ada] Minor tweak to Volatile_Full_Access wording in GNAT RM
2019-12-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* doc/gnat_rm/implementation_defined_pragmas.rst: Minor tweak to
Volatile_Full_Access wording in GNAT RM.
* gnat_rm.texi: Regenerate.
From-SVN: r279354
Gary Dismukes [Fri, 13 Dec 2019 09:04:28 +0000 (09:04 +0000)]
[Ada] Suppress Base_Address call on init of activation record components
2019-12-13 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_attr.adb (Expand_N_Attribute_Reference,
Attribute_Address): Suppress generation of a call to
Base_Address in the case where the Address attribute is being
used to initialize a corresponding component of an activation
record.
(Is_Unnested_Component_Init): New function to determine whether
an attribute reference for Address is used to initialized a
component of an activation record object that corresponds to the
object denoted by the prefix of the attribute (an assignment
used in support of unnesting for back ends like LLVM).
From-SVN: r279353
Ed Schonberg [Fri, 13 Dec 2019 09:04:23 +0000 (09:04 +0000)]
[Ada] Crash on implicit dereference not made explicit
2019-12-13 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_res.adb (Resolve): IF an entity reference is overloaded
because its type has an Implicit_Dereference aspect, we must
examine the discriminants of the type to determine whether an
explicit dereference must be inserted for use in code
generation. Previously this was done for other expressions but
not for entity references by themselves. This was sufficient to
handle uses of the aspect in container handling and iteration,
but not more generally.
From-SVN: r279352
Javier Miranda [Fri, 13 Dec 2019 09:04:18 +0000 (09:04 +0000)]
[Ada] Deallocation of controlled type implementing interface types
2019-12-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_disp.ads (Expand_Interface_Thunk): Adding one formal (the
interface type).
* exp_disp.adb (Expand_Interface_Thunk): Using the added formal
to ensure the correct profile of the thunk generated for
predefined primitives; in addition, the added formal is also
used to perform a check that ensures that the controlling type
of the thunk is the one expected by the GCC backend.
(Make_Secondary_DT, Register_Primitive): Adding the new formal
to the calls to Expand_Interface_Thunk.
* exp_ch6.adb (Register_Predefined_DT_Entry): Adding the new
formal to the call to Expand_Interface_Thunk.
* exp_intr.adb (Expand_Unc_Deallocation): When deallocating a
controlled type and the call to unchecked deallocation is
performed with a pointer to one of the convered interface types,
displace the pointer to the object to reference the base of the
object to deallocate its memory.
* gcc-interface/trans.c (maybe_make_gnu_thunk): Assert that the
controlling type of the thunk is an interface type.
From-SVN: r279351
Bob Duff [Fri, 13 Dec 2019 09:04:12 +0000 (09:04 +0000)]
[Ada] Remove Is_Available function
2019-12-13 Bob Duff <duff@adacore.com>
gcc/ada/
* exp_attr.adb (Is_Available): Remove this function, and replace
all calls with RTE_Available. RTE_Available will return True if
"not Configurable_Run_Time_Mode". Remove the "???" comment.
From-SVN: r279350
Ed Schonberg [Fri, 13 Dec 2019 09:04:06 +0000 (09:04 +0000)]
[Ada] Crash on inherited private operation in child package
2019-12-13 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch7.adb (Analyze_Package_Body_Helper): Do not call
Declare_Inherited_Private_Subprograms on s child body: the
required operations have already been created when analyzing the
corresponding package declaration. This prevents a redeclaration
of inehrited operation, and a crash when inserting the new
operation in the current scope.
From-SVN: r279349
Yannick Moy [Fri, 13 Dec 2019 09:04:01 +0000 (09:04 +0000)]
[Ada] Avoid spurious errors on Global/Depends in instantiations
2019-12-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Depends_In_Decl_Part,
Analyze_Global_In_Decl_Part,
Analyze_Refined_Depends_In_Decl_Part,
Analyze_Refined_Global_In_Decl_Part, Check_Missing_Part_Of):
Skip redundant checking involving visibility inside
instantiations.
From-SVN: r279348
Yannick Moy [Fri, 13 Dec 2019 09:03:56 +0000 (09:03 +0000)]
[Ada] Prevent inlining inside condition of while loop in GNATprove
2019-12-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Call): Prevent inlining inside while loop
conditions.
* sem_util.adb, sem_util.ads (In_While_Loop_Condition): New
query function.
From-SVN: r279347
Bob Duff [Fri, 13 Dec 2019 09:03:50 +0000 (09:03 +0000)]
[Ada]
Ada2020: Update Impunit for Ada 202X
2019-12-13 Bob Duff <duff@adacore.com>
gcc/ada/
* impunit.ads: Add Ada_202X_Unit.
* impunit.adb: Add a table Non_Imp_File_Names_2X analogous to
the other tables. Add code to search this table.
* opt.ads: Add Warn_On_Ada_202X_Compatibility flag, currently
always True.
* sem_ch10.adb (Analyze_With_Clause): Give a warning if an Ada
2020 unit is with-ed when Ada_Version < Ada_2020. Change 'if'
to 'case': Full coverage rules rule.
From-SVN: r279346
Bob Duff [Fri, 13 Dec 2019 09:03:45 +0000 (09:03 +0000)]
[Ada] Rtsfind: minor comment fixes
2019-12-13 Bob Duff <duff@adacore.com>
gcc/ada/
* rtsfind.ads: Minor comment fix.
From-SVN: r279345
Gary Dismukes [Fri, 13 Dec 2019 09:03:40 +0000 (09:03 +0000)]
[Ada] Up-level addressing problems with private tasks and selective accept procs
2019-12-13 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_util.adb (Scope_Within): For the case of checking for a
task type procedure, check the Implementation_Base_Type of Curr.
(Scope_Within_Or_Same): For the case of checking for a task type
procedure, check the Implementation_Base_Type of Curr.
From-SVN: r279344
Arnaud Charlet [Fri, 13 Dec 2019 09:03:34 +0000 (09:03 +0000)]
[Ada] Add Ada.Containers.Vectors.Generic_Parallel_Sorting to known units
2019-12-13 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* impunit.adb (Non_Imp_File_Names_12): Add
Ada.Containers.Vectors.Generic_Parallel_Sorting.
From-SVN: r279343
Justin Squirek [Fri, 13 Dec 2019 09:03:28 +0000 (09:03 +0000)]
[Ada] Missing accessibility checks on conditionals
2019-12-13 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Allocator): Add calls to
Check_Cond_Expr_Accessibility when a conditional expression is
found.
(Check_Allocator_Discrim_Accessibility_Exprs): Created to
recursively traverse a potentially compound conditional
expression and perform accessibility checks for each
alternative.
* sem_util.adb (Dynamic_Accessibility_Level): Avoid use of
original node of the expression in question so we can handle
dynamic accessibility in the limited case of a constant folded
conditional expression.
From-SVN: r279342
Steve Baird [Fri, 13 Dec 2019 09:03:23 +0000 (09:03 +0000)]
[Ada] Implement AI12-0101
2019-12-13 Steve Baird <baird@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Op_Eq.Is_Equality): Move this function
from within Expand_N_Op_Eq.Find_Equality out to immediately
within Expand_N_Op_Eq in order to give it greater visibility.
Add a new Typ parameter (defaulted to Empty) which, if
non-empty, means the function will return False in the case of
an equality op for some other type.
* (Expand_N_Op_Eq.User_Defined_Primitive_Equality_Op): A new
function. Given an untagged record type, finds the corresponding
user-defined primitive equality op (if any). May return Empty.
Ignores visibility.
* (Expand_N_Op): For
Ada2012 or later, check for presence of a
user-defined primitive equality op before falling back on the
usual predefined component-by-component comparison. If found,
then call the user-defined op instead.
From-SVN: r279341
Justin Squirek [Fri, 13 Dec 2019 09:03:18 +0000 (09:03 +0000)]
[Ada] Spurious error on overriding controlled primitive
2019-12-13 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_ch6.adb (Check_Overriding_Indicator): Modify condition to
take into account the modification of the Is_Hidden flag within
generic instances.
(Verify_Overriding_Indicator): Add an exception for controlled
primitives within an instance.
From-SVN: r279340
Ed Schonberg [Fri, 13 Dec 2019 09:03:02 +0000 (09:03 +0000)]
[Ada] New flag to indicate whether aspect appears on partial view
2019-12-13 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sinfo.ads, sinfo.adb (Aspect_On_Partial_View,
Set_Aspect_On_Partial_View): New flag for use by SPARK, to
indicate whether an aspect that appears on a type declaration
applies to the partial view of that type.
* sem_ch13.adb (Analyze_Aspect_Specification): Set new flag
appropriately.
From-SVN: r279339
Andrew Pinski [Fri, 13 Dec 2019 08:31:42 +0000 (08:31 +0000)]
Add C testcases for PR 86659
testsuite/ChangeLog:
2019-12-13 Andrew Pinski <apinski@marvell.com>
* gcc.c-torture/execute/pr86659-1.c: New test.
* gcc.c-torture/execute/pr86659-2.c: New test.
From-SVN: r279338
Tobias Burnus [Fri, 13 Dec 2019 07:58:53 +0000 (07:58 +0000)]
libgomp/openacc.f90 – clean-up public/private attributes
libgomp/
* openacc.f90 (module openacc_kinds): Use 'PUBLIC' to mark all symbols
as public except for the 'use …, only' imported symbol, which is
private.
(module openacc): Default to 'PRIVATE' to exclude openacc_internal; mark
all symbols from module openacc_kinds as PUBLIC; add missing PUBLIC
attributes for acc_copyout_finalize and acc_delete_finalize.
From-SVN: r279337
Kewen Lin [Fri, 13 Dec 2019 06:00:53 +0000 (06:00 +0000)]
[rs6000] Adjust vectorization cost for scalar COND_EXPR
We found that the vectorization cost modeling on scalar COND_EXPR is a bit off
on rs6000. One typical case is 548.exchange2_r, -Ofast -mcpu=power9 -mrecip
-fvect-cost-model=unlimited is better than -Ofast -mcpu=power9 -mrecip (the
default is -fvect-cost-model=dynamic) by 1.94%. Scalar COND_EXPR is expanded
into compare + branch or compare + isel normally, either of them should be
priced more than the simple FXU operation. This patch is to add additional
vectorization cost onto scalar COND_EXPR on top of builtin_vectorization_cost.
The idea to use additional cost value 2 instead of the others: 1) try various
possible value candidates from 1 to 5, 2 is the best measured on Power9. 2)
from latency view, compare takes 3 cycles and isel takes 2 on Power9, it's
2.5 times of simple FXU instruction which takes cost 1 in the current
modeling, it's close. 3) get fine SPEC2017 ratio on Power8 as well.
gcc/ChangeLog
* config/rs6000/rs6000.c (adjust_vectorization_cost): New function.
(rs6000_add_stmt_cost): Call adjust_vectorization_cost and update
stmt_cost.
From-SVN: r279336
Jason Merrill [Fri, 13 Dec 2019 05:05:51 +0000 (00:05 -0500)]
PR c++/92496 - ICE with <=> and no #include <compare>.
* typeck.c (cp_build_binary_op): Handle error from spaceship_type.
From-SVN: r279331
GCC Administrator [Fri, 13 Dec 2019 00:16:22 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279330
Jakub Jelinek [Fri, 13 Dec 2019 00:09:34 +0000 (01:09 +0100)]
re PR target/92904 (varargs for __int128 is placed at an unaligned location and uses movdqa for the load)
PR target/92904
* config/i386/i386.c (ix86_gimplify_va_arg): If need_intregs and
not need_temp, decrease alignment of the read because the GPR save
area only guarantees 8-byte alignment.
* gcc.c-torture/execute/pr92904.c: New test.
From-SVN: r279327
Harald Anlauf [Thu, 12 Dec 2019 20:39:48 +0000 (20:39 +0000)]
re PR fortran/92898 (ICE in gfc_check_is_contiguous, at fortran/check.c:7157)
2019-12-12 Harald Anlauf <anlauf@gmx.de>
PR fortran/92898
* check.c (gfc_check_is_contiguous): Simplify check to handle
arbitrary NULL() argument.
PR fortran/92898
* gfortran.dg/pr92898.f90: New test.
From-SVN: r279314
Sudakshina Das [Thu, 12 Dec 2019 18:01:18 +0000 (18:01 +0000)]
[Committed, testsuite] Fix PR92870
With my recent commit, I added a test that is not passing on all targets.
My change was valid for targets that have a vector/scalar shift/rotate optabs
(optab that supports vector shifted by scalar).
Since it does not seem to be easy to find out which targets would support it,
I am limiting the test to the targets that I know pass.
gcc/testsuite/ChangeLog
2019-12-12 Sudakshina Das <sudi.das@arm.com>
PR testsuite/92870
* gcc.dg/vect/vect-shift-5.c: Add target to scan-tree-dump.
From-SVN: r279310
Georg-Johann Lay [Thu, 12 Dec 2019 17:00:46 +0000 (17:00 +0000)]
Add support for some more AVR devices from avrxmega3 family.
* config/avr/avr-mcus.def (attiny1604, attiny1606, attiny1607)
(attiny402, attiny404, attiny406)
(attiny804, attiny806, attiny807)
(attiny202, attiny204): Add AVR_MCU lines to support them.
* doc/avr-mmcu.texi: Regenerate.
From-SVN: r279309
Jonathan Wakely [Thu, 12 Dec 2019 14:35:55 +0000 (14:35 +0000)]
libstdc++: Simplify std::common_comparison_category
* libsupc++/compare (common_comparison_category): Define without using
concepts and optimise for compilation time.
(__detail::__cmp_cat_ids): Remove.
(__detail::__common_cmp_cat): Replace class template and
specializations with constexpr function.
From-SVN: r279307
Jan Hubicka [Thu, 12 Dec 2019 14:32:48 +0000 (15:32 +0100)]
ipa-prop.c (read_ipcp_transformation_info): Fix undefined ordering of execution of function call parameters.
* ipa-prop.c (read_ipcp_transformation_info): Fix undefined ordering
of execution of function call parameters.
From-SVN: r279306
Ed Schonberg [Thu, 12 Dec 2019 10:03:53 +0000 (10:03 +0000)]
[Ada] Spurious warning about change of representastion in call
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch13.adb (Same_Reprewentation): if the actual in a call is
a generic actual type, use its bsae type to determine whether a
change of representastion may be necessary for proper parameter
passing.
From-SVN: r279305
Ed Schonberg [Thu, 12 Dec 2019 10:03:48 +0000 (10:03 +0000)]
[Ada] Spurious error on universal access equality operator
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_type.adb (Find_Unique_Type): A call to the universal
access equality operator requires one operand to be a universal
access, and the other to be an access type. There is no
requirement, as previously implied by this routine, that
pool-specific access types were illegal in this context.
From-SVN: r279304
Steve Baird [Thu, 12 Dec 2019 10:03:43 +0000 (10:03 +0000)]
[Ada] Tighten up semantic checking for protected subprogram declarations
2019-12-12 Steve Baird <baird@adacore.com>
gcc/ada/
* sem_ch6.adb
(New_Overloaded_Entity.Check_Conforming_Paramters): Add new
Conformance_Type parameter. With the value of
Subtype_Conformant, the behavior of Check_Conforming_Parameters
is unchanged. The call in Matching_Entry_Or_Subprogram to
instead passes in Type_Conformant. This corresponds to the use
of "type conformant" in Ada RM 9.4(11.4/3).
(New_Overloaded_Entity.Has_Matching_Entry_Or_Subprogram): Add
new Normalized_First_Parameter_Type function to help in ignoring
the distinction between protected and access-to-protected first
parameters when checking prefixed-view profile matching. Replace
computations of the type of the first parameter with calls to
this function as appropriate.
From-SVN: r279303
Ed Schonberg [Thu, 12 Dec 2019 10:03:39 +0000 (10:03 +0000)]
[Ada] Missing dereference in bound of slice in element iterator
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch5.adb: (Analyze_Iterator_Specification): If the
iteration is over a slice, complete the resolution of its
bounds, which may be aebitrary expressions. The previous
pre-analysis may have created itypes for the slice but has not
performed the expansion that for example may introduce actions
that specify explicit dereferences and run-time checks.
From-SVN: r279302
Ed Schonberg [Thu, 12 Dec 2019 10:03:35 +0000 (10:03 +0000)]
[Ada] Improve error message for dispatching subprogram formals
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch8.adb: Improve error message for dispatching subprogram
formals.
From-SVN: r279301
Gary Dismukes [Thu, 12 Dec 2019 10:03:30 +0000 (10:03 +0000)]
[Ada] Fix related to handling up-level references in protected entries
2019-12-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_ch9.adb (Build_Protected_Entry): Set the Scope of the new
block to be the entity of the procedure created for the entry.
From-SVN: r279300
Steve Baird [Thu, 12 Dec 2019 10:03:26 +0000 (10:03 +0000)]
[Ada] Improved handling of circular compilation dependencies
2019-12-12 Steve Baird <baird@adacore.com>
gcc/ada/
* sem_ch10.adb (Install_With_Clause): Check for the case of a
circular dependency involving a predefined (or GNAT-defined)
unit and handle that case by generating an appropropriate error
message.
From-SVN: r279299
Gary Dismukes [Thu, 12 Dec 2019 10:03:20 +0000 (10:03 +0000)]
[Ada] Fix various typos, plus minor reformatting
2019-12-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_ch4.adb, sem_res.adb: Minor reformatting.
From-SVN: r279298
Justin Squirek [Thu, 12 Dec 2019 10:03:16 +0000 (10:03 +0000)]
[Ada] Broken privacy on Controlled type extensions
2019-12-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_ch4.adb (Analyze_One_Call): Add condition to check for
incorrectly resolved hidden controlled primitives.
From-SVN: r279297
Ed Schonberg [Thu, 12 Dec 2019 10:03:11 +0000 (10:03 +0000)]
[Ada] Fix processing of standard predefined operators
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_res.adb: Fix processing of standard predefined operators.
From-SVN: r279296
Piotr Trojanek [Thu, 12 Dec 2019 10:03:06 +0000 (10:03 +0000)]
[Ada] Fix Global contract for the predefined Yield procedure
2019-12-12 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* libgnarl/a-dispat.ads (Yield): Update Global contract.
From-SVN: r279295
Piotr Trojanek [Thu, 12 Dec 2019 10:03:01 +0000 (10:03 +0000)]
[Ada] Fix repeated words and typos in doc and comments
2019-12-12 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* libgnat/g-altive.ads: Fix typo in comment.
* bindo-graphs.adb: Fix repeated words in comment.
* exp_ch4.adb: Likewise.
* exp_ch5.adb: Likewise.
* exp_ch7.adb: Likewise.
* exp_pakd.adb: Likewise.
* exp_unst.adb: Likewise.
* exp_util.adb: Likewise.
* freeze.adb: Likewise.
* inline.adb: Likewise.
* layout.adb: Likewise.
* sem_ch12.adb: Likewise.
* sem_ch13.adb: Likewise.
* sem_ch4.adb: Likewise.
* sem_ch9.adb: Likewise.
* sem_elab.adb: Likewise.
* doc/gnat_ugn/gnat_and_program_execution.rst: Fix repeated
words in user documentation.
* gnat_ugn.texi: Regenerate.
From-SVN: r279294
Eric Botcazou [Thu, 12 Dec 2019 10:02:55 +0000 (10:02 +0000)]
[Ada] Fix wrong value of 'Size for slices of bit-packed arrays (2)
2019-12-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_attr.adb (Expand_Size_Attribute): Look directly at the
prefix to detect the bit-packed slices. Apply the checks last
in case the attribute needs to be processed by the back-end.
* exp_ch4.adb (Expand_N_Slice): Do not create a temporary for
a prefix of the Size attribute.
From-SVN: r279293
Steve Baird [Thu, 12 Dec 2019 10:02:51 +0000 (10:02 +0000)]
[Ada] Implement AI12-0036 (a new legality check for instantiations)
2019-12-12 Steve Baird <baird@adacore.com>
gcc/ada/
* sem_ch12.adb
(Instantiate_Type.Validate_Derived_Type_Instance): Implement the
legality check of AI12-0036
From-SVN: r279292
Ed Schonberg [Thu, 12 Dec 2019 10:02:47 +0000 (10:02 +0000)]
[Ada] Spurious visibility error on subunit with optimization
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch10.adb (Analyze_Subunit): Fix spurious visibility error
on subunit with optimization.
From-SVN: r279291
Arnaud Charlet [Thu, 12 Dec 2019 10:02:42 +0000 (10:02 +0000)]
[Ada] Define __gnat_personality_v0 for SEH
2019-12-12 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* raise-gcc.c (__gnat_personality_v0): Define for SEH.
From-SVN: r279290
Gary Dismukes [Thu, 12 Dec 2019 10:02:38 +0000 (10:02 +0000)]
[Ada] Handling up-level references in protected entries and freeze nodes
2019-12-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_ch9.adb (Build_Protected_Entry): Analyze the block created
to hold the declarations and statements of the protected entry
body right after it's created, and then call Reset_Scopes_To on
that block to reset the Scope of nested entities to the block
scope.
(Reset_Scope): Add handling for N_Freeze_Entity nodes, calling
Reset_Scopes recursively on the Actions of such nodes. Also, for
subprogram bodies that are encountered that might not have a
separate declaration (such as type init procedures), reset the
Scope of the subprogram's entity.
From-SVN: r279289
Justin Squirek [Thu, 12 Dec 2019 10:02:32 +0000 (10:02 +0000)]
[Ada] Missing error on incorrect use of Result attribute
2019-12-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_attr.adb (Analyze_Attribute): Add error message for
invalid usage of Attribute_Result.
From-SVN: r279288
Bob Duff [Thu, 12 Dec 2019 10:02:27 +0000 (10:02 +0000)]
[Ada] Crash on Descriptor_Size attribute
2019-12-12 Bob Duff <duff@adacore.com>
gcc/ada/
* sem_attr.adb (Eval_Attribute): Never mark T'Descriptor_Size as
static, even if T is a static subtype, because otherwise we will
request the value of the attribute, which will crash because we
have not evaluated it.
From-SVN: r279287
Ed Schonberg [Thu, 12 Dec 2019 10:02:23 +0000 (10:02 +0000)]
[Ada] Missing length check on private type with unknown discriminants
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch5.adb (Expand_N_Assognment_Statement): Extend the
processing involving private types with unknown discriminants to
handle the case where the full view of the type is an
unconstrained array type.
From-SVN: r279286
Bob Duff [Thu, 12 Dec 2019 10:02:19 +0000 (10:02 +0000)]
[Ada] Compiler crash on prefix call in generic body
2019-12-12 Bob Duff <duff@adacore.com>
gcc/ada/
* sem_ch4.adb (Transform_Object_Operation): Deal properly with
prefix notation in instances.
From-SVN: r279285
Claire Dross [Thu, 12 Dec 2019 10:02:14 +0000 (10:02 +0000)]
[Ada] Use correct subtype for call to Last in formal vectors
2019-12-12 Claire Dross <dross@adacore.com>
gcc/ada/
* libgnat/a-cofove.adb, libgnat/a-cfinve.adb (Find_Index): Use
Extended_Index for call to Last.
From-SVN: r279284
Gary Dismukes [Thu, 12 Dec 2019 10:02:09 +0000 (10:02 +0000)]
[Ada] Fix a number of typos, plus minor reformatting
2019-12-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_ch3.adb, sem_util.adb: Minor reformatting.
From-SVN: r279283
Bob Duff [Thu, 12 Dec 2019 10:02:05 +0000 (10:02 +0000)]
[Ada] Update gnatmetric documentation for average lengths
2019-12-12 Bob Duff <duff@adacore.com>
gcc/ada/
* doc/gnat_ugn/gnat_utility_programs.rst: Update gnatmetric
documentation for average lengths
From-SVN: r279282
Ed Schonberg [Thu, 12 Dec 2019 10:02:00 +0000 (10:02 +0000)]
[Ada] Constraint is ignored on constrained access record component
2019-12-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch3.adb (Constrain_Access): Remove obsolete comments and
warning concerning component types of an access type whose
designated type is a constrained record type. (Such constraints
were previously ignored). Set scope of itype for component to
the scope of the enclosing record.
* sem_ch4.adb: Remove call to Set_Ekind.
* sem_util.adb (Build_Actual_Subtype_Of_Component): Handle
components whose type is an access to a constrained
discriminant, where the constraints may be given by the
discriminants of the enclosing type. New subprogram
Build_Access_Record_Constraint.
gcc/testsuite/
* gnat.dg/warn24.adb: Remove expected warning.
From-SVN: r279281
Justin Squirek [Thu, 12 Dec 2019 10:01:55 +0000 (10:01 +0000)]
[Ada] Crash on use of Loop_Entry, Result, and Old as actuals
2019-12-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* exp_ch6.adb (Expand_Call_Helper): Added null case for
'Loop_Entry, 'Old, and 'Result when calculating whether to
create extra accessibility parameters.
* sem_util.adb (Dynamic_Accessibility_Level): Added null case
for 'Loop_Entry, 'Old, and 'Result when calculating
accessibility level based on access-valued attributes. Also
added special handling for uses of 'Loop_Entry when used in its
indexed component form.
From-SVN: r279280
Arnaud Charlet [Thu, 12 Dec 2019 10:01:51 +0000 (10:01 +0000)]
[Ada] Remove references to VMS
2019-12-12 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* raise-gcc.c: Remove references to VMS
From-SVN: r279279
Eric Botcazou [Thu, 12 Dec 2019 10:01:46 +0000 (10:01 +0000)]
[Ada] Mark Ada subprograms and variables referenced from gigi
2019-12-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* atree.ads, comperr.ads, debug.ads, einfo.ads, elists.ads,
err_vars.ads, errout.ads, exp_ch11.ads, exp_code.ads,
exp_dbug.ads, exp_tss.ads, exp_util.ads, lib.ads, namet.ads,
nlists.ads, opt.ads, repinfo.ads, restrict.ads, scos.ads,
sem_aggr.ads, sem_aux.ads, sem_eval.ads, sem_util.ads,
sinfo.ads, sinput.ads, stringt.ads, targparm.ads, types.ads,
urealp.ads warnsw.ads: Add WARNING line(s) in commentary.
* atree.h, elists.h, namet.h, nlists.h, repinfo.h, scos.h,
stringt.h, types.h, uintp.h, urealp.h: Tidy up.
* fe.h: Likewise. Document WARNING mark.
From-SVN: r279278
Dmitriy Anisimkov [Thu, 12 Dec 2019 10:01:41 +0000 (10:01 +0000)]
[Ada] Improve end of command line arguments detection
2019-12-12 Dmitriy Anisimkov <anisimko@adacore.com>
gcc/ada/
* libgnat/g-comlin.ads (Get_Argument): New routine similar to
original Get_Argument but with one more out parameter
End_Of_Arguments.
(Get_Arguments): Comment improved.
* libgnat/g-comlin.adb (Get_Argument): Implementation taken from
original Get_Argument and improved.
(Get_Argument): Calls new routine Get_Argument with additional
parameter.
From-SVN: r279277
Pierre-Marie de Rodat [Thu, 12 Dec 2019 10:01:36 +0000 (10:01 +0000)]
[Ada] Remove implicit anonymous access conversion in testcase
2019-12-12 Pierre-Marie de Rodat <derodat@adacore.com>
gcc/testsuite/
* gnat.dg/subp_inst_pkg.adb: Remove implicit anonymous access
conversion.
From-SVN: r279276
Vineet Gupta [Thu, 12 Dec 2019 08:42:21 +0000 (08:42 +0000)]
[ARC] generate signaling FDCMPF for hard float comparisons
PR 92846:
ARC gcc generates FDCMP instructions which raises Invalid operation for
signaling NaN only. This causes glibc iseqsig() primitives to fail (in
the current ongoing glibc port to ARC)
So break up the hard float compares into tw categories and for unordered
compares generate the FDCMPF instructions which raised exception for
either NaNs.
With this fix testsuite/gcc.dg/torture/pr52451.c passes for ARC.
Also no regressions for the glibc math testsuite, only 6 additional
passes for test*iseqsig
gcc/
xxxx-xx-xx Vineet Gupta <vgupta@synopsys.com>
* config/arc/arc-modes.def (CC_FPUE): New Mode CC_FPUE which
helps codegen generate exceptions even for quiet NaN.
* config/arc/arc.c (arc_init_reg_tables): Handle New CC_FPUE mode.
(get_arc_condition_code): Likewise.
(arc_select_cc_mode): LT, LE, GT, GE to use the New CC_FPUE mode.
* config/arc/arc.h (REVERSE_CONDITION): Handle New CC_FPUE mode.
* config/arc/predicates.md (proper_comparison_operator): Likewise.
* config/arc/fpu.md (cmpsf_fpu_trap): New Pattern for CC_FPUE.
(cmpdf_fpu_trap): Likewise.
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
From-SVN: r279274
Claudiu Zissulescu [Thu, 12 Dec 2019 08:42:10 +0000 (09:42 +0100)]
[ARC] Use hardware support for double-precision compare instructions.
Allow the compiler to use the double-precision compare instructions.
xxxx-xx-xx Claudiu Zissulescu <claziss@synopsys.com>
* config/arc/arc.md (iterator SDF): Check TARGET_FP_DP_BASE.
(cstoredi4): Use TARGET_HARD_FLOAT.
From-SVN: r279273
François Dumont [Thu, 12 Dec 2019 07:23:34 +0000 (07:23 +0000)]
libstdc++: Fix tr1 definition ambiguity in versioned namespace
* include/tr1/cctype: Add _GLIBCXX_BEGIN_VERSION_NAMESPACE and
_GLIBCXX_END_VERSION_NAMESPACE.
* include/tr1/cfenv: Likewise.
* include/tr1/cinttypes: Likewise.
* include/tr1/cstdint: Likewise.
* include/tr1/cstdio: Likewise.
* include/tr1/cstdlib: Likewise.
* include/tr1/cwchar: Likewise.
* include/tr1/cwctype: Likewise.
From-SVN: r279272
François Dumont [Thu, 12 Dec 2019 07:14:55 +0000 (07:14 +0000)]
libstdc++: Qualify isdigit call to fix versioned namespace build.
* src/c++11/random.cc: Include <cctype>.
(random_devise::_M_init_pretr1): Qualify isdigit call.
From-SVN: r279271
GCC Administrator [Thu, 12 Dec 2019 00:16:21 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279270