vbo: avoid including wingdi.h on win32

On Windows, main/glheader.h ends up including windows.h which in turn
includes wingdi.h unless the NOGDI macro is defined. And wingdi.h
defines a macro called "ERROR", which we end up redefining below.

To avoid a warning on the redefinition, we can define NOGDI to prevent
wingdi.h from implicitly being included.

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4577>

mesa: fixup cast expression

This cast-expression was meant to cast the result of the terniary
expression, but it just casted the condition expression instead. Let's
correct this, to silence a compiler-warning.

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4577>

util/tests: initialize variable

This just silences a compiler-warning about a potentially uninitialized
variable. It's not uninitialized, but it's a bit hard for the compiler
to see. So let's just initialize it to zero.

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4577>

wgl: silence some cast-warnings

These casts cause warnings on x64. We're passing integers through
pointers, which works fine.

So let's make the casts a bit more explicit, to silence that warning.

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4577>

meson: use override_options to change warning-level

This pevents MSVC from complaining about multiple warning-levels on the
command-line.

Reviewed-by: Brian Paul <brianp@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4577>

turnip: image_view rework

Instead of exposing various layout functions, move image-related logic
into tu_image.c and have the image_view pre-fill relevant register values.

This changes the clear/blit code to use image_view.

This will make it much easier to deal with aspect masks, in particular for
planar formats and D32_S8.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4581>

turnip: don't limit framebuffer size to image size

Minor cleanup, I couldn't find anything that suggests this should be done,
and anv doesn't do it either.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4581>

turnip: compute render_components/srgb_cntl at renderpass creation time

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4581>

winsys/amdgpu: Retrieve WC flags from imported buffers.

Otherwise reading from an imported mapped GTT+WC linear texture
is painfully slow.

Sadly no radeon winsys implementation, as I don't know a suitable
kernel driver operation.

Hit this  in vaGetImage with an image imported from minigbm (which
we are switching to allocate WC for SCANOUT images).

Cc: <mesa-stable@lists.freedesktop.org>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4542>

st/mesa: fix a crash due to passing a draw vertex shader into the driver

Fixes: bc99b22a305be5e5a5f
Closes: #2754
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4527>

CI: Disable Windows/VS2019 builds

An update seems to have poisoned gitlab-runner, and it can no longer
resolve DNS even though the host system can.

Disable this until we can figure out what's going on.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4589>

meson: Make shared-llvm into a tri-state boolean

Choosing LLVM's link mode is legitimate on UNIX systems, but only static
actually really works under Windows.

Give shared-llvm a default 'auto' mode which will pick the previous
default of true (shared) on UNIX systems, but newly defaulting to false
(static) on Windows.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Suggested-by: Dylan Baker <dylan@pnwbakers.com>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4555>

tu: Align GMEM resolve blit scissor

Even though we normally use the CP_BLIT path with resolves that aren't
aligned, there's a special case when we're resolving the entire image
and there's enough padding so that we can still use CP_EVENT_WRITE::BLIT
when the render area isn't aligned. The hardware seems to not like
unaligned scissors when not clearing, and sometimes hangs rather than
silently round the scissor. This causes hangs in e.g.
dEQP-VK.glsl.derivate.dfdx.texture.msaa4.float_highp.

There was some concern that the CP_BLIT path might use this scissor
also, but I confirmed that this isn't the case by setting it to 0 before
resolving and then noting that CP_BLIT still works (but CP_EVENT_WRITE
doesn't). Furthermore, this is actually impossible because of how the 2D
engine is set up: it gets its own pair of register banks, which can be
switched independently of the 3D register banks, so that 2D events
(CP_BLIT) normally aren't synchronized relative to 3D events
(CP_EVENT_WRITE, CP_DRAW_*, and CP_EXEC_CS) and therefore they can't
share any registers except for non-pipelined registers like RB_CCU_CNTL
that don't use the register bank mechanism at all.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4585>

.mailmap: add an alias for Zhongmin Wu

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add alias for Zhaowei Yuan

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Yaakov Selkowitz

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Xavier Bouchoux

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Wladimir J. van der Laan

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Vivek Kasireddy

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Varad Gautam

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Vadym Shovkoplias

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Topi Pohjolainen

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Tomasz Figa

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Tom Stellard

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Tim Wiederhake

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a couple of aliases for Timothy Arceri

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Timo Aaltonen

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Thierry Reding

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a couple of aliases for Suresh Guttula

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a couple of aliases for Steinar H. Gunderson

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Sonny Jiang

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Sergii Romantsov

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Samuel Li

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Rodrigo Vivi

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Rob Clark

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Renato Caldas

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Randy Xu

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Qiang Yu

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Plamena Manolova

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: update aliases for Pierre-Eric Pelloux-Prayer

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Philipp Zabel

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: update aliases for Nicolai Hähnle

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Nicholas Bishop

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Nian Wu

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Neil Roberts

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Neha Bhende

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add alias for Matthias Groß

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: update aliases for Marc-André Lureau

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Liviu Prodea

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Lionel Landwerlin

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a few aliases for Kristian Høgsberg

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a few aliases for Kevin Rogovin

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a few aliases for Karol Herbst

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Julien Isorce

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: clean up aliases for Jeremy Huddleston

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Jan Beich

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for James Zhu

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Illia Iorin

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Igor Gnatenko

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Henri Verbeet

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Heinrich Fink

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Harish Krupo

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Haihao Xiang

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Gurchetan Singh

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Francesco Ansanelli

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Erik Faye-Lund

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Emmanuel Gil Peyrot

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a couple of aliases for Dylan Noblesmith

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Dylan Baker

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Dave Airlie

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Danylo Piliaiev

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Daniel Schürmann

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Craig Stout

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: specify spelling for Constantine Kharlamov

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Colin McDonald

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a few aliases for Christoph Haag

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Christian Inci

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Christian Gmeiner

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add alias for Chenglei Ren

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add a couple of aliases for Chandu Babu Namburu

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Chad Versace

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: update aliases for Carl-Philip Hänsch

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Bruce Cherniak

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Boris Brezillon

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Axel Davy

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Anuj Phogat

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Andrii Simiklit

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Alyssa Rosenzweig

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

.mailmap: add an alias for Alan Swanson

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/1999>

mesa/st: initialize all winsys_handle fields for memory objects

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reported-by: Eduardo Lima Mitev <elima@igalia.com>
Reviewed-by: Eduardo Lima Mitev <elima@igalia.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: <mesa-stable@lists.freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4547>

amd/addrlib: Use enum instead of sparse chars to identify dimensions

The enum values can be used directly as indices into arrays, simplifying
the code.

This significantly cuts down the number of CPU cycles spent inside

* Addr::V2::Gfx9Lib::HwlComputeDccAddrFromCoord:

+------------------------------------------------------------------------+
|+         +++    +                                                x x xx|
|    |_____AM____|                                                 |_A__||
+------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5         14.89         15.44         15.14        15.156    0.24704251
+   5          8.26          9.96          9.37         9.282     0.6262747
Difference at 95.0% confidence
-5.874 +/- 0.694294
-38.7569% +/- 4.58098%
(Student's t, pooled s = 0.476051)

* Addr::V2::CoordEq::solve:

+------------------------------------------------------------------------+
| +                                                                x     |
| + +   +   +                                       x           x  x    x|
||__MA____|                                              |______A__M____||
+------------------------------------------------------------------------+
    N           Min           Max        Median           Avg        Stddev
x   5          8.11          9.59          9.21          9.02    0.55605755
+   5          4.28          5.05          4.48         4.564    0.32867917
Difference at 95.0% confidence
-4.456 +/- 0.666135
-49.4013% +/- 7.38509%
(Student's t, pooled s = 0.456744)

(The measured numbers are the percentages of samples inside the
respective function and its calles for
`perf record --call-graph=fp kitty -e false`, measured on a Lenovo
Thinkpad E595 (Picasso))

v2:
* Add missed 'coords[dim] |= bit << ord;' (Pierre-Eric Pelloux-Prayer)
* Put 'ADDR_ASSERT(dim < DIM_S);' where the code previous had
  'ADDR_ASSERT_ALWAYS()' for the s/m dimensions.
* Use 1u for BitsValid (since it's 32-bit unsigned values).
* Use parens in 'BitsValid[dim] & (1u << ord)' for clarity.

Acked-by: Marek Olšák <marek.olsak@amd.com> # v1
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4523>

gbm/dri: Propagate queryDmaBufModifiers return value

We were treating count == 0 as the format not being supported at all,
but queryDmaBufModifiers would return false in that case.

Fixes spuriously reporting all formats as unsupported with radeonsi
(which doesn't support modifiers yet), which would e.g. cause mutter
to think the HW cursor format isn't supported and fall back to SW
cursor.

Suggested-by: Daniel Stone <daniels@collabora.com>
Fixes: 4e3a7dcf6ee4 "gallium: enable
                     EGL_EXT_image_dma_buf_import_modifiers
                     unconditionally"

Reviewed-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4532>

zink: be less picky about tiled resources

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2678>

st/dri: make sure software color-buffers are linear

Otherwise, we might end up with a tiling-capable driver creating a
tiled resource here instead of linear. This is currently possible with
Zink, although we currently force all display-targets to be linear.

But that doesn't seem like a good idea in the long run, so let's loosen
this restriction.

Acked-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/2678>

virgl: Use ETC2 formats directly when possible.

Don't emulate them with uncompressed formats if the host
support them since uncompressed formats like GL_R16 could
be not available on GLES hosts.

Signed-off-by: Lepton Wu <lepton@chromium.org>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>

radeonsi: use thread_context::bytes_mapped_limit

Limit the amount of "in-flight" mapping to 1/4 of the total RAM.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2735
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4508>

gallium/u_threaded: flush batch when hitting mapping limit

tc_transfer_map maps buffers directly, but the unmap operation is executed
in the driver thread.
When an application does a lot of map/unmap operations, without flushing,
this increase the RAM used (and eventually get the app killed by the oom-killer).

This commit allows tc to keep track of how many bytes were mapped during
the current batch. When this estimation becomes higher than a threshold,
we flush the batch.

See: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2735
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4508>

radv: do not abort with unknown/unimplemented descriptor types

To workaround a crash with Wolfeinstein Younglood because the
games creates one descriptor with
VK_DESCRIPTOR_TYPE_ACCELERATION_STRUCTURE_NV...

I reported the problem to Machine Games, but still no answer, so
let's remove the unreachable calls (which are technically not
unreachable for buggy apps) to help gamers.

Note that AMDVLK and AMDGPU-PRO don't crash because they ignore
unsupported descriptor types.

Cc: <mesa-stable@lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4571>

aco: fix emitting stream output with tess eval shaders

Fixes dEQP-VK.transform_feedback.simple.winding_patch_list_12.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4553>

aco: implement nir_op_f2i8/nir_op_f2u8

I think we should really refactor the conversions path.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4551>