gcc.git
5 years agoImplement P1286R2, Contra CWG1778
Jason Merrill [Wed, 23 Oct 2019 20:41:26 +0000 (16:41 -0400)]
Implement P1286R2, Contra CWG1778

The C++11 requirement that an explicit exception-specification on a
defaulted function match the implicit one was found to be problematic for
std::atomic.  This paper, adopted in February, simply removes that
requirement: if an explicitly defaulted function has a different
exception-specification, that now works just like a user-written function:
either it isn't noexcept when it could be, or it is noexcept and will call
terminate if an exception is thrown.

* method.c (defaulted_late_check): Don't check explicit
exception-specification on defaulted function.
(after_nsdmi_defaulted_late_checks): Remove.
* parser.h (struct cp_unparsed_functions_entry): Remove classes.
* parser.c (unparsed_classes): Remove.
(push_unparsed_function_queues, cp_parser_class_specifier_1):
Adjust.

From-SVN: r277351

5 years agoReformat some code; Add support for generating PLWA with offsets whose bottom 2 bits...
Michael Meissner [Wed, 23 Oct 2019 20:09:27 +0000 (20:09 +0000)]
Reformat some code; Add support for generating PLWA with offsets whose bottom 2 bits are non-zero.

2019-10-23  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/rs6000.md (mov<mode>_64bit_dm): Reformat.
(movtd_64bit_nodm): Reformat.
(mov<mode>_32bit): Reformat.
(mov<mode>_softfloat): Reformat.
(FMOVE128_GPR splitter): Reformat.
(DIFD splitter): Reformat.
(TI2 splitter): Reformat.
* config/rs6000/predicates.md (lwa_operand): If the bottom two
bits of the offset for the memory address are non-zero, use PLWA
if prefixed instructions are available.

From-SVN: r277349

5 years agolto-streamer-out.c (cmp_symbol_files): Watch for overflow.
Jan Hubicka [Wed, 23 Oct 2019 20:01:25 +0000 (22:01 +0200)]
lto-streamer-out.c (cmp_symbol_files): Watch for overflow.

* lto-streamer-out.c (cmp_symbol_files): Watch for overflow.

From-SVN: r277348

5 years agoipa-reference.c (varpool_removal_hook, [...]): Fix previous patch.
Jan Hubicka [Wed, 23 Oct 2019 19:03:42 +0000 (21:03 +0200)]
ipa-reference.c (varpool_removal_hook, [...]): Fix previous patch.

* ipa-reference.c (varpool_removal_hook, ipa_reference_c_finalize): Fix
previous patch.

From-SVN: r277347

5 years agolto-streamer-out.c (output_constructor): Push CTORS_OUT timevar.
Jan Hubicka [Wed, 23 Oct 2019 18:22:40 +0000 (20:22 +0200)]
lto-streamer-out.c (output_constructor): Push CTORS_OUT timevar.

* lto-streamer-out.c (output_constructor): Push CTORS_OUT timevar.
(cmp_symbol_files): New.
(lto_output): Copy sections in file order.
* lto-streamer.h (lto_file_decl_data): Add field order.
* lto-common.c (lto_file_finalize): Add order attribute.
(lto_create_files_from_ids): Pass order.
(lto_file_read): UPdate call of lto_create_files_from_ids.

From-SVN: r277346

5 years agoipa-reference.h (ipa_reference_var_uid): Move offline.
Jan Hubicka [Wed, 23 Oct 2019 18:18:31 +0000 (20:18 +0200)]
ipa-reference.h (ipa_reference_var_uid): Move offline.

* ipa-reference.h (ipa_reference_var_uid): Move offline.
* ipa-reference.c (reference_vars_map_t): new type.
(ipa_reference_vars_map, ipa_reference_vars_uids): New static vars.
(ipa_reference_var_uid): Implement.
(varpool_node_hooks): New static var.
(varpool_removal_hook): New function.
(is_improper): Do not check bitmap for id==-1
(get_static_name): Update.
(ipa_init): Initialize new datastructures.
(analyze_function): Do not recompute ids.
(propagate): Free reference_vars_to_consider.
(stream_out_bitmap): Update.
(ipa_reference_read_optimization_summary): Update.

From-SVN: r277345

5 years agore PR gcov-profile/91971 (Profile directory concatenated with object file path)
Qing Zhao [Wed, 23 Oct 2019 18:12:39 +0000 (18:12 +0000)]
re PR gcov-profile/91971 (Profile directory concatenated with object file path)

2019-10-23  qing zhao  <qing.zhao@oracle.com>

PR gcov-profile/91971
* coverage.c (coverage_init): Mangle the full path of filename when
filename is a absolute path.

From-SVN: r277344

5 years agoMake std::invoke usable in constant expressions
Jonathan Wakely [Wed, 23 Oct 2019 17:42:16 +0000 (18:42 +0100)]
Make std::invoke usable in constant expressions

* include/std/functional (invoke): Add constexpr for C++20.
* include/std/version (__cpp_lib_constexpr_invoke): Define.
* testsuite/20_util/function_objects/invoke/constexpr.cc: New test.

From-SVN: r277343

5 years agoPR c++/91369 Implement P0784R7 changes to allocation and construction
Jonathan Wakely [Wed, 23 Oct 2019 17:42:11 +0000 (18:42 +0100)]
PR c++/91369 Implement P0784R7 changes to allocation and construction

This patch is the first part of library support for constexpr
std::vector and std::string. This only includes the changes to
std::allocator, std::allocator_traits, std::construct_at,
std::destroy_at, std::destroy and std::destroy_n.

std::allocator::allocate and std::allocator::deallocate need to be
added so that they can be intercepted by the compiler during constant
evaluation. Outside of constant evaluation those new member functions
just forward to the existing implementation in the base class.

PR c++/91369 Implement P0784R7 changes to allocation and construction
* include/bits/alloc_traits.h: Include <bits/stl_construct.h>.
(allocator_traits::_S_allocate, allocator_traits::_S_construct)
(allocator_traits::_S_destroy, allocator_traits::_S_max_size)
(allocator_traits::_S_select, allocator_traits::allocate)
(allocator_traits::deallocate, allocator_traits::construct)
(allocator_traits::destroy, allocator_traits::max_size)
(allocator_traits::select_on_container_copy_construction)
(allocator_traits<allocator<T>>): Add constexpr specifier for C++20.
(allocator_traits<allocator<T>>::construct): Use construct_at.
(allocator_traits<allocator<T>>::destroy): Use destroy_at.
(__alloc_on_copy, __alloc_on_move, __alloc_on_swap): Add constexpr
specifier.
(_Destroy(ForwardIterator, ForwardIterator, Alloc&))
(_Destroy(ForwardIterator, ForwardIterator, allocator<T>&)): Move here
from <bits/stl_construct.h>.
* include/bits/allocator.h (allocator::~allocator): Remove for C++20.
(allocator::allocate, allocate::deallocate): Define for C++20 and up.
(operator==, operator!=): Add constexpr specifier for C++20.
* include/bits/stl_construct.h: Don't include <ext/alloc_traits.h>.
(destroy_at): For C++20 add constexpr specifier and support for
destroying arrays.
(construct_at): Define new function for C++20.
(_Construct): Return result of placement new-expression. For C++11 and
up add constexpr. For C++20 dispatch to std::construct_at during
constant evaluation.
(_Destroy(pointer)): Add constexpr specifier. For C++20 dispatch to
std::destroy_at during constant evaluation.
(_Destroy_aux::__destroy, _Destroy_n_aux::__destroy_n): Add constexpr
specifier for C++20.
(_Destroy(ForwardIterator, ForwardIterator))
(_Destroy(ForwardIterator, Size)): Likewise. Do not elide trivial
destructors during constant evaluation.
(destroy, destroy_n): Add constexpr specifier for C++20.
(_Destroy(ForwardIterator, ForwardIterator, Alloc&))
(_Destroy(ForwardIterator, ForwardIterator, allocator<T>&)): Move to
<bits/alloc_traits.h>, to remove dependency on allocators.
* include/bits/stl_uninitialized.h: Include <ext/alloc_traits.h>.
Include <bits/stl_pair.h> instead of <utility>.
* include/ext/alloc_traits.h: Always include <bits/alloc_traits.h>.
(__alloc_traits::construct, __alloc_traits::destroy)
(__alloc_traits::_S_select_on_copy, __alloc_traits::_S_on_swap): Add
constexpr specifier.
* include/ext/malloc_allocator.h  (operator==, operator!=): Add
constexpr specifier for C++20.
* include/ext/new_allocator.h (operator==, operator!=): Likewise.
* testsuite/20_util/headers/memory/synopsis.cc: Add constexpr.
* testsuite/20_util/scoped_allocator/69293_neg.cc: Ignore additional
errors due to constexpr function called after failed static_assert.
* testsuite/20_util/specialized_algorithms/construct_at/1.cc: New test.
* testsuite/23_containers/vector/cons/destructible_debug_neg.cc:
Ignore additional errors due to constexpr function called after failed
static_assert.
* testsuite/23_containers/vector/cons/destructible_neg.cc: Likewise.

From-SVN: r277342

5 years agomsp430-protos.h (msp430_has_hwmult): New.
Jozef Lawrynowicz [Wed, 23 Oct 2019 16:55:44 +0000 (16:55 +0000)]
msp430-protos.h (msp430_has_hwmult): New.

2019-10-23  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* config/msp430/msp430-protos.h (msp430_has_hwmult): New.
* config/msp430/msp430.c (msp430_no_hwmult): Remove.
(msp430_has_hwmult): New.
(msp430_output_labelref):
s/msp430_hwmult_type != MSP430_HWMULT_NONE/msp430_has_hwmult ()/
* config/msp430/msp430.md (mulhisi3): Likewise.
(umulhisi3): Likewise.
(mulsidi3): Likewise.
(umulsidi3): Likewise.

From-SVN: r277341

5 years agolib2hw_mul.S: Fix wrong syntax in branch instruction.
Jozef Lawrynowicz [Wed, 23 Oct 2019 16:52:47 +0000 (16:52 +0000)]
lib2hw_mul.S: Fix wrong syntax in branch instruction.

2019-10-23  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* config/msp430/lib2hw_mul.S: Fix wrong syntax in branch instruction.
s/RESULT_LO/RESLO, s/RESULT_HI/RESHI, s/MPY_OP1/MPY,
s/MPY_OP1_S/MPYS, s/MAC_OP1/MAC, s/MPY_OP2/OP2, s/MAC_OP2/OP2.
Define symbols for 32-bit and f5series hardware multiply
register addresses.
Replace hard-coded register addresses with symbols.
Fix "_mspabi*" typo.
Fix whitespace.
* config/msp430/lib2mul.c: Add comment.

From-SVN: r277340

5 years agoReplace C++14 feature used in C++11 test
Jonathan Wakely [Wed, 23 Oct 2019 16:14:54 +0000 (17:14 +0100)]
Replace C++14 feature used in C++11 test

* testsuite/20_util/bind/91371.cc: Fix test to compile as C++11.

From-SVN: r277339

5 years agoOnly qualify function as constexpr for C++14 and later
Jonathan Wakely [Wed, 23 Oct 2019 16:14:50 +0000 (17:14 +0100)]
Only qualify function as constexpr for C++14 and later

This helper function is not a valid constexpr function in C++11, so
should only be marked constexpr for C++14 and later.

* include/debug/helper_functions.h (__valid_range): Change
_GLIBCXX_CONSTEXPR to _GLIBCXX14_CONSTEXPR.

From-SVN: r277338

5 years agoQualify type names in <ext/throw_allocator.h>
Jonathan Wakely [Wed, 23 Oct 2019 16:14:47 +0000 (17:14 +0100)]
Qualify type names in <ext/throw_allocator.h>

* include/ext/throw_allocator.h (throw_allocator_base): Qualify
size_t and ptrdiff_t.

From-SVN: r277337

5 years agoAdjust pb_ds extensions to use allocator_traits
Jonathan Wakely [Wed, 23 Oct 2019 16:14:43 +0000 (17:14 +0100)]
Adjust pb_ds extensions to use allocator_traits

These changes are largely useless, because most of them are simply
allowing 'reference' and 'const_reference' types to be obtained from an
allocator, and since C++11 allocators don't define reference types (they
just use plain lvalue references. Pretending to support C++98 allocators
with user-defined reference types is a waste of time (especially as
several of the pb_ds types appear to use a static allocator object which
means stateful allocators are not supported).

* include/ext/pb_ds/detail/bin_search_tree_/bin_search_tree_.hpp:
Use detail::rebind_traits.
* include/ext/pb_ds/detail/bin_search_tree_/node_iterators.hpp:
Likewise.
* include/ext/pb_ds/detail/bin_search_tree_/traits.hpp: Likewise.
* include/ext/pb_ds/detail/binary_heap_/binary_heap_.hpp: Likewise.
* include/ext/pb_ds/detail/binary_heap_/entry_cmp.hpp: Likewise.
* include/ext/pb_ds/detail/binary_heap_/entry_pred.hpp: Likewise.
* include/ext/pb_ds/detail/binary_heap_/point_const_iterator.hpp:
Likewise.
* include/ext/pb_ds/detail/binomial_heap_base_/binomial_heap_base_.hpp:
Likewise.
* include/ext/pb_ds/detail/branch_policy/branch_policy.hpp: Likewise.
* include/ext/pb_ds/detail/cc_hash_table_map_/cc_ht_map_.hpp: Likewise.
* include/ext/pb_ds/detail/cond_dealtor.hpp: Likewise.
* include/ext/pb_ds/detail/eq_fn/hash_eq_fn.hpp (has_eq_fn): Likewise.
* include/ext/pb_ds/detail/gp_hash_table_map_/gp_ht_map_.hpp: Likewise.
* include/ext/pb_ds/detail/hash_fn/ranged_hash_fn.hpp: Likewise.
* include/ext/pb_ds/detail/hash_fn/ranged_probe_fn.hpp: Likewise.
* include/ext/pb_ds/detail/left_child_next_sibling_heap_/
left_child_next_sibling_heap_.hpp: Likewise.
* include/ext/pb_ds/detail/left_child_next_sibling_heap_/node.hpp:
Likewise.
* include/ext/pb_ds/detail/left_child_next_sibling_heap_/
point_const_iterator.hpp: Likewise.
* include/ext/pb_ds/detail/list_update_map_/lu_map_.hpp: Likewise.
* include/ext/pb_ds/detail/ov_tree_map_/
constructors_destructor_fn_imps.hpp: Likewise.
* include/ext/pb_ds/detail/ov_tree_map_/node_iterators.hpp: Likewise.
* include/ext/pb_ds/detail/ov_tree_map_/ov_tree_map_.hpp: Likewise.
* include/ext/pb_ds/detail/pairing_heap_/pairing_heap_.hpp: Likewise.
* include/ext/pb_ds/detail/pat_trie_/pat_trie_.hpp: Likewise.
* include/ext/pb_ds/detail/pat_trie_/pat_trie_base.hpp: Likewise.
* include/ext/pb_ds/detail/rb_tree_map_/node.hpp: Likewise.
* include/ext/pb_ds/detail/rc_binomial_heap_/rc.hpp: Likewise.
* include/ext/pb_ds/detail/splay_tree_/node.hpp: Likewise.
* include/ext/pb_ds/detail/thin_heap_/thin_heap_.hpp: Likewise.
* include/ext/pb_ds/detail/trie_policy/sample_trie_access_traits.hpp:
Likewise.
* include/ext/pb_ds/detail/type_utils.hpp: Fix typo in comment.
* include/ext/pb_ds/detail/types_traits.hpp (stored_value): Add
bool parameter to control whether the hash value is stored.
(select_base_type): New class template and partial specialization.
(maybe_null_type): Likewise.
(rebind_traits): New class template.
(type_base): Remove four nearly identical specializations.
(type_dispatch): Remove.
(type_traits): Use select_base_type and maybe_null_type instead of
type_base to control differences between specializations.
* include/ext/pb_ds/list_update_policy.hpp: Use detail::rebind_traits.
* include/ext/pb_ds/priority_queue.hpp: Likewise.
* include/ext/pb_ds/tree_policy.hpp: Likewise.
* include/ext/pb_ds/trie_policy.hpp: Likewise.

From-SVN: r277336

5 years agoAdjust extension types to use allocator_traits
Jonathan Wakely [Wed, 23 Oct 2019 16:14:28 +0000 (17:14 +0100)]
Adjust extension types to use allocator_traits

This makes these extensions work with types meeting the Cpp17Allocator
requirements as well as the C++98 Allocator requirements.

* include/backward/hash_set (hash_set): Use __alloc_traits.
* include/backward/hashtable.h (_Hashtable): Likewise.
* include/ext/alloc_traits.h (__alloc_traits::allocate): Add overload
taking a hint.
* include/ext/extptr_allocator.h (_ExtPtr_allocator::allocate): Ignore
hint.
* include/ext/slist (_Slist_base): Use __alloc_traits.
* include/tr1/hashtable.h (_Hashtable): Likewise.
* include/tr1/regex (match_results): Use vector::const_reference
instead of assuming the allocator defines it.
* testsuite/backward/hash_map/23528.cc: Use allocator_traits in C++11.
* testsuite/tr1/6_containers/unordered_map/capacity/29134-map.cc: Use
__gnu_test::max_size.
* testsuite/tr1/6_containers/unordered_multimap/capacity/
29134-multimap.cc: Likewise.
* testsuite/tr1/6_containers/unordered_multiset/capacity/
29134-multiset.cc: Likewise.
* testsuite/tr1/6_containers/unordered_set/capacity/29134-set.cc:
Likewise.

From-SVN: r277335

5 years agore PR ipa/92074 (26% performance regression on Spec2017 548.exchange2_r)
Jan Hubicka [Wed, 23 Oct 2019 14:45:24 +0000 (16:45 +0200)]
re PR ipa/92074 (26% performance regression on Spec2017 548.exchange2_r)

PR ipa/92074
* params.def (inline-heuristics-hint-percent): Set to 600.

From-SVN: r277333

5 years agoFix a bug with type constraints in constructors.
Andrew Sutton [Wed, 23 Oct 2019 13:05:32 +0000 (13:05 +0000)]
Fix a bug with type constraints in constructors.

gcc/cp/
* parser.c (cp_parser_constructor_declarator_p): Pass an empty
decl-specifier-seq to make sure we parse type constraints as part
of a type-specifier.

gcc/testsuite/
* g++.dg/cpp2a/concepts5.C: New test.

From-SVN: r277323

5 years agore PR tree-optimization/65930 (Reduction with sign-change not handled)
Richard Biener [Wed, 23 Oct 2019 12:41:49 +0000 (12:41 +0000)]
re PR tree-optimization/65930 (Reduction with sign-change not handled)

2019-10-23  Richard Biener  <rguenther@suse.de>

PR tree-optimization/65930
* tree-vect-loop.c (check_reduction_path): Allow conversions
that only change the sign.
(vectorizable_reduction): Relax latch def stmts we handle further.

* gcc.dg/vect/vect-reduc-2char-big-array.c: Adjust.
* gcc.dg/vect/vect-reduc-2char.c: Likewise.
* gcc.dg/vect/vect-reduc-2short.c: Likewise.
* gcc.dg/vect/vect-reduc-dot-s8b.c: Likewise.
* gcc.dg/vect/vect-reduc-pattern-2c.c: Likewise.

From-SVN: r277322

5 years agore PR debug/90231 (ivopts causes <optimized away> iterator in the loop)
Jakub Jelinek [Wed, 23 Oct 2019 12:38:03 +0000 (14:38 +0200)]
re PR debug/90231 (ivopts causes <optimized away> iterator in the loop)

PR debug/90231
* tree-ssa-loop-ivopts.c (get_debug_computation_at): New function.
(remove_unused_ivs): Use it instead of get_computation_at.  When
choosing best candidate, only consider candidates where
get_debug_computation_at actually returns non-NULL.

From-SVN: r277321

5 years agoconstexpr.c (cxx_eval_constant_expression): Temporarily change input_location to...
Jakub Jelinek [Wed, 23 Oct 2019 12:35:00 +0000 (14:35 +0200)]
constexpr.c (cxx_eval_constant_expression): Temporarily change input_location to CLEANUP_STMT location.

* constexpr.c (cxx_eval_constant_expression) <case CLEANUP_STMT>:
Temporarily change input_location to CLEANUP_STMT location.

* g++.dg/cpp2a/constexpr-dtor3.C: Expect in 'constexpr' expansion of
message on the line with variable declaration.
* g++.dg/ext/constexpr-attr-cleanup1.C: Likewise.

From-SVN: r277320

5 years agore PR tree-optimization/92131 (incorrect assumption that (ao >= 0) is always false)
Eric Botcazou [Wed, 23 Oct 2019 11:34:48 +0000 (11:34 +0000)]
re PR tree-optimization/92131 (incorrect assumption that (ao >= 0) is always false)

PR tree-optimization/92131
* tree-vrp.c (extract_range_from_plus_minus_expr): If the resulting
range would be symbolic, drop to varying for any explicit overflow
in the constant part or if neither range is a singleton.

From-SVN: r277314

5 years agoInitialize a field in fibonacci_node.
Martin Liska [Wed, 23 Oct 2019 11:29:10 +0000 (13:29 +0200)]
Initialize a field in fibonacci_node.

2019-10-23  Martin Liska  <mliska@suse.cz>

PR middle-end/81669
* fibonacci_heap.h (fibonacci_node::fibonacci_node):
Initialize m_data.

From-SVN: r277313

5 years ago[AArch64] Don't apply mode_for_int_vector to scalars
Richard Sandiford [Wed, 23 Oct 2019 10:31:01 +0000 (10:31 +0000)]
[AArch64] Don't apply mode_for_int_vector to scalars

aarch64_emit_approx_sqrt handles both vectors and scalars and was using
mode_for_int_vector even for the scalar case.  Although that happened
to work, it isn't how mode_for_int_vector is supposed to be used.

2019-10-23  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/aarch64/aarch64.c (aarch64_emit_approx_sqrt): Use
int_mode_for_mode rather than mode_for_int_vector for scalars.

From-SVN: r277311

5 years agore PR tree-optimization/92179 (r277288 causes ICEs compiling several test cases)
Richard Biener [Wed, 23 Oct 2019 10:29:36 +0000 (10:29 +0000)]
re PR tree-optimization/92179 (r277288 causes ICEs compiling several test cases)

2019-10-23  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92179
* tree-vect-stmts.c (vectorizable_shift): For shift args
that are all the same remove type restriction in the SLP case.
Adjust SLP code to handle converting of the shift arg to
only apply in case the modes are different.

From-SVN: r277310

5 years agoDo not ICE in IPA inliner.
Martin Liska [Wed, 23 Oct 2019 08:55:05 +0000 (10:55 +0200)]
Do not ICE in IPA inliner.

2019-10-23  Martin Liska  <mliska@suse.cz>

PR ipa/91969
* ipa-inline.c (recursive_inlining): Do not print
when curr->count is not initialized.
2019-10-23  Martin Liska  <mliska@suse.cz>

PR ipa/91969
* g++.dg/ipa/pr91969.C: New test.

From-SVN: r277309

5 years agotree-vect-slp.c (vect_build_slp_tree_2): Do not build op from scalars in case there...
Richard Biener [Wed, 23 Oct 2019 06:45:03 +0000 (06:45 +0000)]
tree-vect-slp.c (vect_build_slp_tree_2): Do not build op from scalars in case there's a constant operand in its definition.

2019-10-23  Richard Biener  <rguenther@suse.de>

* tree-vect-slp.c (vect_build_slp_tree_2): Do not build
op from scalars in case there's a constant operand in its
definition.

From-SVN: r277308

5 years ago[Darwin, PPC] Check for out of range asm values.
Iain Sandoe [Wed, 23 Oct 2019 05:39:32 +0000 (05:39 +0000)]
[Darwin, PPC] Check for out of range asm values.

There are some cases in which the value for the max skip to a p2align
directive can be negative.  The older assembler just ignores these cases
where newer tools produce an error.  To preserve behaviour, we avoid
emitting out of range values.

gcc/ChangeLog:

2019-10-23  Iain Sandoe  <iain@sandoe.co.uk>

* config/rs6000/darwin.h (ASM_OUTPUT_MAX_SKIP_ALIGN): Guard
against out of range max skip or log values.

From-SVN: r277307

5 years agoDaily bump.
GCC Administrator [Wed, 23 Oct 2019 00:16:24 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r277306

5 years agoRestore use of tr1::unordered_map in testsuite
Jonathan Wakely [Tue, 22 Oct 2019 21:48:57 +0000 (22:48 +0100)]
Restore use of tr1::unordered_map in testsuite

My recent change to this file broke running the testsuite with
-std=c++98 because std::unordered_map isn't available. This fixes it.

* testsuite/util/testsuite_abi.h: Restore use of tr1/unordered_map
when compiled as C++98.

From-SVN: r277302

5 years agoDo not declare std::uses_allocator before C++11
Jonathan Wakely [Tue, 22 Oct 2019 21:48:53 +0000 (22:48 +0100)]
Do not declare std::uses_allocator before C++11

* include/bits/memoryfwd.h (uses_allocator): Do not declare for C++98.
* testsuite/17_intro/names.cc: Check uses_allocator in C++98.

From-SVN: r277301

5 years agoRemove redundant std::allocator members for C++20
Jonathan Wakely [Tue, 22 Oct 2019 21:48:39 +0000 (22:48 +0100)]
Remove redundant std::allocator members for C++20

C++20 removes a number of std::allocator members that have correct
defaults provided by std::allocator_traits, so aren't needed.

Several extensions including __gnu_cxx::hash_map and tr1 containers are
no longer usable with std::allocator in C++20 mode. They need to be
updated to use __gnu_cxx::__alloc_traits in a follow-up patch.

* include/bits/alloc_traits.h
(allocator_traits<allocator<T>>::allocate): Ignore hint for C++20.
(allocator_traits<allocator<T>>::construct): Perform placement new
directly for C++20, instead of calling allocator<T>::construct.
(allocator_traits<allocator<T>>::destroy): Call destructor directly
for C++20, instead of calling allocator<T>::destroy.
(allocator_traits<allocator<T>>::max_size): Return value directly
for C++20, instead of calling std::allocator<T>::max_size().
(__do_alloc_on_copy, __do_alloc_on_move, __do_alloc_on_swap): Do not
define for C++17 and up.
(__alloc_on_copy, __alloc_on_move, __alloc_on_swap): Use if-constexpr
for C++17 and up, instead of tag dispatching.
* include/bits/allocator.h (allocator<void>): Remove for C++20.
(allocator::pointer, allocator::const_pointer, allocator::reference)
(allocator::const_reference, allocator::rebind): Remove for C++20.
* include/bits/basic_string.h (basic_string): Use __alloc_traits to
rebind allocator.
* include/bits/memoryfwd.h (allocator<void>): Remove for C++20.
* include/ext/debug_allocator.h: Use __alloc_traits for rebinding.
* include/ext/malloc_allocator.h (malloc_allocator::~malloc_allocator)
(malloc_allocator::pointer, malloc_allocator::const_pointer)
(malloc_allocator::reference, malloc_allocator::const_reference)
(malloc_allocator::rebind, malloc_allocator::max_size)
(malloc_allocator::construct, malloc_allocator::destroy): Do not
define for C++20.
(malloc_allocator::_M_max_size): Define new function.
* include/ext/new_allocator.h (new_allocator::~new_allocator)
(new_allocator::pointer, new_allocator::const_pointer)
(new_allocator::reference, new_allocator::const_reference)
(new_allocator::rebind, new_allocator::max_size)
(new_allocator::construct, new_allocator::destroy): Do not
define for C++20.
(new_allocator::_M_max_size): Define new function.
* include/ext/rc_string_base.h (__rc_string_base::_Rep): Use
__alloc_traits to rebind allocator.
* include/ext/rope (_Rope_rep_base, _Rope_base): Likewise.
(rope::rope(CharT, const allocator_type&)): Use __alloc_traits
to construct character.
* include/ext/slist (_Slist_base): Use __alloc_traits to rebind
allocator.
* include/ext/sso_string_base.h (__sso_string_base::_M_max_size):
Use __alloc_traits.
* include/ext/throw_allocator.h (throw_allocator): Do not use optional
members of std::allocator, use __alloc_traits members instead.
* include/ext/vstring.h (__versa_string): Use __alloc_traits.
* include/ext/vstring_util.h (__vstring_utility): Likewise.
* include/std/memory: Include <bits/alloc_traits.h>.
* testsuite/20_util/allocator/8230.cc: Use __gnu_test::max_size.
* testsuite/20_util/allocator/rebind_c++20.cc: New test.
* testsuite/20_util/allocator/requirements/typedefs.cc: Do not check
for pointer, const_pointer, reference, const_reference or rebind in
C++20.
* testsuite/20_util/allocator/requirements/typedefs_c++20.cc: New test.
* testsuite/23_containers/deque/capacity/29134.cc: Use
__gnu_test::max_size.
* testsuite/23_containers/forward_list/capacity/1.cc: Likewise.
* testsuite/23_containers/list/capacity/29134.cc: Likewise.
* testsuite/23_containers/map/capacity/29134.cc: Likewise.
* testsuite/23_containers/multimap/capacity/29134.cc: Likewise.
* testsuite/23_containers/multiset/capacity/29134.cc: Likewise.
* testsuite/23_containers/set/capacity/29134.cc: Likewise.
* testsuite/23_containers/vector/capacity/29134.cc: Likewise.
* testsuite/ext/malloc_allocator/variadic_construct.cc: Do not run
test for C++20.
* testsuite/ext/new_allocator/variadic_construct.cc: Likewise.
* testsuite/ext/vstring/capacity/29134.cc: Use __gnu_test::max_size.
* testsuite/util/replacement_memory_operators.h: Do not assume
Alloc::pointer exists.
* testsuite/util/testsuite_allocator.h (__gnu_test::max_size): Define
helper to call max_size for any allocator.

From-SVN: r277300

5 years agoFix incorrect merge of conflictant names in `dump_graphviz`
Giuliano Belinassi [Tue, 22 Oct 2019 19:05:49 +0000 (19:05 +0000)]
Fix incorrect merge of conflictant names in `dump_graphviz`

When using lto-dump -callgraph with two or more .o files containing distinct
functions with the same name, dump_graphviz incorrectly merged those functions
into a single node. This patch fixes this issue by calling `dump_name` instead
of `name`, therefore concat'ing the function name with the node's id.

To understeand what was the issue, let's say you have two files:

a.c: static void foo (void) { do_something (); }

b.c: static void foo (void) { do_something_else (); }

These are distinct functions and should be represented as distinct nodes in the
callgraph dump.

2019-10-22  Giuliano Belinassi  <giuliano.belinassi@usp.br>

* cgraph.c (dump_graphviz): Change name to dump_name

From-SVN: r277299

5 years agore PR fortran/92174 (runtime error: index 15 out of bounds for type 'gfc_expr *[15])
Steven G. Kargl [Tue, 22 Oct 2019 18:18:59 +0000 (18:18 +0000)]
re PR fortran/92174 (runtime error: index 15 out of bounds for type 'gfc_expr *[15])

2019-10-22  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/92174
* decl.c (attr_decl1): Move check for F2018:C822 from here ...
* array.c (gfc_set_array_spec): ... to here.

From-SVN: r277297

5 years agore PR tree-optimization/85887 (Missing DW_TAG_lexical_block PC range)
Jakub Jelinek [Tue, 22 Oct 2019 14:52:52 +0000 (16:52 +0200)]
re PR tree-optimization/85887 (Missing DW_TAG_lexical_block PC range)

PR tree-optimization/85887
* decl.c (expand_static_init): Drop ECF_LEAF from __cxa_guard_acquire
and __cxa_guard_release.

From-SVN: r277293

5 years agoPR c++/85746: Don't fold __builtin_constant_p prematurely
Marc Glisse [Tue, 22 Oct 2019 14:42:38 +0000 (16:42 +0200)]
PR c++/85746: Don't fold __builtin_constant_p prematurely

2019-10-22  Marc Glisse  <marc.glisse@inria.fr>

gcc/cp/
* constexpr.c (cxx_eval_builtin_function_call): Only set
force_folding_builtin_constant_p if manifestly_const_eval.

gcc/testsuite/
* g++.dg/pr85746.C: New file.

From-SVN: r277292

5 years agoArm: Fix arm libsanitizer bootstrap failure
Tamar Christina [Tue, 22 Oct 2019 14:25:38 +0000 (14:25 +0000)]
Arm: Fix arm libsanitizer bootstrap failure

Glibc has recently introduced changed to the mode field in ipc_perm
in commit 2f959dfe849e0646e27403f2e4091536496ac0f0. For Arm this
means that the mode field no longer has the same size.

This causes an assert failure against libsanitizer's internal copy
of ipc_perm.  Since this change can't be easily detected I am adding
arm to the list of targets that are excluded from this check.  libsanitizer
doesn't use this field (and others, it in fact uses only 1 field) so this check
can be ignored.

Padding bits were used by glibc when the field was changed so sizeof and offsets
of the remaining fields should be the same.

libsanitizer/ChangeLog:

PR sanitizer/92154
* sanitizer_common/sanitizer_platform_limits_posix.cpp (defined):
Cherry-pick compiler-rt revision r375220.

From-SVN: r277291

5 years ago[arm] Match subtraction from carry_operation
Richard Earnshaw [Tue, 22 Oct 2019 13:19:15 +0000 (13:19 +0000)]
[arm] Match subtraction from carry_operation

On Arm we have both carry and borrow operations, but borrow is
essentially '~carry'.  Of course, with boolean logic ~carry is also
1-carry.

GCC transforms

(1 - X - LTU (cc, 0))

into

(GEU (cc, 0) - X)

Now the former matches a real insn in Arm state, using the RSC
instruction with #1 as the immediate, but we currently do not
recognize the canonicalized form.  Nevertheless, given the above
logic, this turns out to be quite straight forward as the original
expression matches arm_borrow_operation and the revised form can be
used with arm_carry_operation.  Since we match this new pattern we
also update rtx_costs to handle it.

* config/arm/arm.md (rsbsi_carryin_reg): New pattern.
* config/arm/arm.c (arm_rtx_costs_internal, case MINUS): Handle
subtraction from a carry operation.

From-SVN: r277290

5 years ago[arm] make arm_carry_operation and arm_borrow_operation duals
Richard Earnshaw [Tue, 22 Oct 2019 13:16:42 +0000 (13:16 +0000)]
[arm] make arm_carry_operation and arm_borrow_operation duals

Arm_carry_operation and arm_borrow_operation are duals: given that we
have a comparison that returns a result that relies solely in the
carry flag one is the inverse of the other.  So there's no reason for
one to have a CC mode that the other does not have.  This patch
restores that equivalence.

* config/arm/predicates.md (arm_borrow_operation): Handle CC_ADCmode.

From-SVN: r277289

5 years agore PR tree-optimization/92173 (ICE in optab_for_tree_code, at optabs-tree.c:81)
Richard Biener [Tue, 22 Oct 2019 13:08:53 +0000 (13:08 +0000)]
re PR tree-optimization/92173 (ICE in optab_for_tree_code, at optabs-tree.c:81)

2019-10-22  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92173
* tree-vect-loop.c (vectorizable_reduction): If
vect_transform_reduction cannot handle code-generation try without
the single-def-use-cycle optimization.  Pass optab_vector to
optab_for_tree_code to get vector shifts as that's what we'd
generate.

* gcc.dg/torture/pr92173.c: New testcase.

From-SVN: r277288

5 years agore PR middle-end/90796 (GCC: O2 vs O3 output differs on simple test)
Michael Matz [Tue, 22 Oct 2019 12:25:03 +0000 (12:25 +0000)]
re PR middle-end/90796 (GCC: O2 vs O3 output differs on simple test)

Fix PR middle-end/90796

        PR middle-end/90796
        * gimple-loop-jam.c (any_access_function_variant_p): New function.
        (adjust_unroll_factor): Use it to constrain safety, new parameter.
        (tree_loop_unroll_and_jam): Adjust call and profitable unroll factor.

testsuite/
        * gcc.dg/unroll-and-jam.c: Add three invalid and one valid case.

From-SVN: r277287

5 years agore PR tree-optimization/92173 (ICE in optab_for_tree_code, at optabs-tree.c:81)
Richard Biener [Tue, 22 Oct 2019 11:51:52 +0000 (11:51 +0000)]
re PR tree-optimization/92173 (ICE in optab_for_tree_code, at optabs-tree.c:81)

2019-10-22  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92173
* tree-vect-loop.c (vectorizable_reduction): If
vect_transform_reduction cannot handle code-generation try without
the single-def-use-cycle optimization.  Pass optab_vector to
optab_for_tree_code to get vector shifts as that's what we'd
generate.

* gcc.dg/torture/pr92173.c: New testcase.

From-SVN: r277286

5 years ago* config/abi/post/aarch64-linux-gnu/baseline_symbols.txt: Update.
Andreas Schwab [Tue, 22 Oct 2019 10:32:52 +0000 (10:32 +0000)]
* config/abi/post/aarch64-linux-gnu/baseline_symbols.txt: Update.

From-SVN: r277285

5 years agoCome up with json::integer_number and use it in GCOV.
Martin Liska [Tue, 22 Oct 2019 09:58:27 +0000 (11:58 +0200)]
Come up with json::integer_number and use it in GCOV.

2019-10-22  Martin Liska  <mliska@suse.cz>

* diagnostic-format-json.cc (json_from_expanded_location):
Use json::integer_number.
* gcov.c (output_intermediate_json_line): Use new
json::integer_number.
(output_json_intermediate_file): Likewise.
* json.cc (number::print): Move to ...
(float_number::print): ... this.
(integer_number::print): New.
(test_writing_numbers): Move to ...
(test_writing_float_numbers): ... this.
(test_writing_integer_numbers): New.
(json_cc_tests): Register test_writing_integer_numbers.
* json.h (class value): Add forward declaration
for float_number and integer_number.
(enum kind): Add JSON_INTEGER and JSON_FLOAT.
(class number): Move to ...
(class float_number): ... this.
(class integer_number): New.
* optinfo-emit-json.cc (optrecord_json_writer::impl_location_to_json):
Use json::integer_number.
(optrecord_json_writer::location_to_json): Likewise.
(optrecord_json_writer::profile_count_to_json): Likewise.
(optrecord_json_writer::pass_to_json): Likewise.

From-SVN: r277284

5 years agoFix PR reference in ChangeLog.
Martin Liska [Tue, 22 Oct 2019 09:29:52 +0000 (09:29 +0000)]
Fix PR reference in ChangeLog.

From-SVN: r277283

5 years agoFix use after free in vector_size change
Richard Sandiford [Tue, 22 Oct 2019 08:43:01 +0000 (08:43 +0000)]
Fix use after free in vector_size change

r277235 was a bit too mechanical and ended up introducing use
after free bugs in both loop and SLP vectorisation.

2019-10-22  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-slp.c (vect_slp_bb_region): Check whether
autodetected_vector_size rather than vector_size is zero.
* tree-vect-loop.c (vect_analyze_loop): Likewise.
Set autodetected_vector_size immediately after calling
vect_analyze_loop_2.  Check for a fatal error before advancing
next_size.

From-SVN: r277282

5 years ago[C++] Avoid exposing internal details in aka types
Richard Sandiford [Tue, 22 Oct 2019 07:47:07 +0000 (07:47 +0000)]
[C++] Avoid exposing internal details in aka types

This patch extends r276951 to work for C++ too.

2019-10-22  Richard Sandiford  <richard.sandiford@arm.com>

gcc/cp/
* cp-tree.h (STF_USER_VISIBLE): New constant.
(strip_typedefs, strip_typedefs_expr): Take a flags argument.
* tree.c (strip_typedefs, strip_typedefs_expr): Likewise,
updating mutual calls accordingly.  When STF_USER_VISIBLE is true,
only look through typedefs if user_facing_original_type_p.
* error.c (dump_template_bindings, type_to_string): Pass
STF_USER_VISIBLE to strip_typedefs.
(dump_type): Likewise, unless pp_c_flag_gnu_v3 is set.

gcc/testsuite/
* g++.dg/diagnostic/aka5.h: New test.
* g++.dg/diagnostic/aka5a.C: Likewise.
* g++.dg/diagnostic/aka5b.C: Likewise.
* g++.target/aarch64/diag_aka_1.C: Likewise.

From-SVN: r277281

5 years ago[testsuite] Make the Wnonnull independent of system headers.
Iain Sandoe [Tue, 22 Oct 2019 03:40:26 +0000 (03:40 +0000)]
[testsuite] Make the Wnonnull independent of system headers.

To avoid the result of this test depending on the implementation of
the system 'string.h', provide prototypes for the two functions used
in the test.

gcc/testsuite/ChangeLog:

2019-10-22  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.dg/Wnonnull.c: Provide prototypes for strlen and memcpy.
Use __SIZE_TYPE__ instead of size_t.

From-SVN: r277280

5 years ago* lock-and-run.sh: Tweak command order.
Jason Merrill [Tue, 22 Oct 2019 03:30:48 +0000 (23:30 -0400)]
* lock-and-run.sh: Tweak command order.

From-SVN: r277279

5 years ago* .gitattributes: Also check ChangeLog whitespace.
Jason Merrill [Tue, 22 Oct 2019 03:12:04 +0000 (23:12 -0400)]
* .gitattributes: Also check ChangeLog whitespace.

From-SVN: r277278

5 years agolock-and-run.sh: Check for process existence rather than timeout.
Jason Merrill [Tue, 22 Oct 2019 03:09:41 +0000 (23:09 -0400)]
lock-and-run.sh: Check for process existence rather than timeout.

* lock-and-run.sh: Check for process existence rather than timeout.

Matthias Klose noted that on less powerful targets, a link might take more
than 5 minutes; he mentions a figure of 3 hours for an LTO link.  So this
patch changes the timeout to a check for whether the locking process still
exists.  If the lock exists in an erroneous state (no pid file or can't
signal the pid) for 30 sec, steal it.

From-SVN: r277277

5 years agoDaily bump.
GCC Administrator [Tue, 22 Oct 2019 00:16:18 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r277276

5 years agoexpr.c (expand_expr_real_2): Don't widen constant op1 when expanding widening multipl...
Jozef Lawrynowicz [Mon, 21 Oct 2019 20:44:16 +0000 (20:44 +0000)]
expr.c (expand_expr_real_2): Don't widen constant op1 when expanding widening multiplication.

2019-10-21  Jozef Lawrynowicz  <jozef.l@mittosystems.com>

* expr.c (expand_expr_real_2): Don't widen constant op1 when expanding
widening multiplication.

From-SVN: r277271

5 years agoPR c++/83434 - typeinfo for noexcept function lacks noexcept information
Kamlesh Kumar [Mon, 21 Oct 2019 20:19:28 +0000 (20:19 +0000)]
PR c++/83434 - typeinfo for noexcept function lacks noexcept information

2019-10-21  Kamlesh Kumar  <kamleshbhalui@gmail.com>

        * rtti.c (get_tinfo_decl_dynamic): Do not call
        TYPE_MAIN_VARIANT for function.
        (get_typeid): Likewise.

        * g++.dg/rtti/pr83534.C: New Test.

Reviewed-by: Jason Merrill <jason@redhat.com>
Co-Authored-By: Jason Merrill <jason@redhat.com>
From-SVN: r277270

5 years agoparser.c (cp_parser_class_head): Improve error recovery upon extra qualification...
Paolo Carlini [Mon, 21 Oct 2019 19:29:41 +0000 (19:29 +0000)]
parser.c (cp_parser_class_head): Improve error recovery upon extra qualification error.

/cp
2019-10-21  Paolo Carlini  <paolo.carlini@oracle.com>

* parser.c (cp_parser_class_head): Improve error recovery upon
extra qualification error.

/testsuite
2019-10-21  Paolo Carlini  <paolo.carlini@oracle.com>

* g++.dg/parse/qualified2.C: Tighten dg-error directive.
* g++.old-deja/g++.other/decl5.C: Don't expect redundant error.

From-SVN: r277268

5 years agore PR c++/92015 (internal compiler error: in cxx_eval_array_reference, at cp/constexp...
Jakub Jelinek [Mon, 21 Oct 2019 18:51:43 +0000 (20:51 +0200)]
re PR c++/92015 (internal compiler error: in cxx_eval_array_reference, at cp/constexpr.c:2568)

PR c++/92015
* constexpr.c (cxx_eval_component_reference, cxx_eval_bit_field_ref):
Use STRIP_ANY_LOCATION_WRAPPER on CONSTRUCTOR elts.

* g++.dg/cpp0x/constexpr-92015.C: New test.

From-SVN: r277267

5 years agoPR c++/92062 - ODR-use ignored for static member of class template.
Marek Polacek [Mon, 21 Oct 2019 18:45:45 +0000 (18:45 +0000)]
PR c++/92062 - ODR-use ignored for static member of class template.

has_value_dependent_address wasn't stripping location wrappers so it
gave the wrong answer for "&x" in the static_assert.  That led us to
thinking that the expression isn't instantiation-dependent, and we
skipped static initialization of A<0>::x.

This patch adds stripping so that has_value_dependent_address gives the
same answer as it used to before the location wrappers addition.

* pt.c (has_value_dependent_address): Strip location wrappers.

* g++.dg/cpp0x/constexpr-odr1.C: New test.
* g++.dg/cpp0x/constexpr-odr2.C: New test.

From-SVN: r277266

5 years agoPR c++/92106 - ICE with structured bindings and -Wreturn-local-addr.
Marek Polacek [Mon, 21 Oct 2019 18:22:41 +0000 (18:22 +0000)]
PR c++/92106 - ICE with structured bindings and -Wreturn-local-addr.

* typeck.c (maybe_warn_about_returning_address_of_local): Avoid
recursing on null initializer and return false instead.

* g++.dg/cpp1z/decomp50.C: New test.

From-SVN: r277264

5 years ago[arm] clean up alu+shift patterns
Richard Earnshaw [Mon, 21 Oct 2019 15:52:58 +0000 (15:52 +0000)]
[arm] clean up alu+shift patterns

My DImode arithmetic patches introduced a bug on thumb2 where we could
generate a register controlled shift into an ALU operation.  In
fairness the bug was always present, but latent.

As part of cleaning this up (and auditing to ensure I've caught them
all this time) I've gone through all the shift generating patterns in
the MD files and cleaned them up, reducing some duplicate patterns
between the arm and thumb2 descriptions where we can now share the
same pattern.  In some cases we were missing the shift attribute; in
most cases I've eliminated an ugly attribute setting using the fact
that we normally need separate alternatives for shift immediate and
shift reg to simplify the logic.

* config/arm/iterators.md (t2_binop0): Fix typo in comment.
* config/arm/arm.md (addsi3_carryin_shift): Simplify selection of the
type attribute.
(subsi3_carryin_shift): Separate into register and constant controlled
alternatives.  Use shift_amount_operand for operand 4.  Set shift
attribute and simplify type attribute.
(subsi3_carryin_shift_alt): Likewise.
(rsbsi3_carryin_shift): Likewise.
(rsbsi3_carryin_shift_alt): Likewise.
(andsi_not_shiftsi_si): Enable for TARGET_32BIT.  Separate constant
and register controlled shifts into distinct alternatives.
(andsi_not_shiftsi_si_scc_no_reuse): Likewise.
(andsi_not_shiftsi_si_scc): Likewise.
(arm_cmpsi_negshiftsi_si): Likewise.
(not_shiftsi): Remove redundant M constraint from alternative 1.
(not_shiftsi_compare0): Likewise.
(arm_cmpsi_insn): Remove redundant alternative 2.
(cmpsi_shift_swp): Likewise.
(sub_shiftsi): Likewise.
(sub_shiftsi_compare0_scratch): Likewise.
* config/arm/thumb2.md (thumb_andsi_not_shiftsi_si): Delete pattern.
(thumb2_cmpsi_neg_shiftsi): Likewise.

From-SVN: r277262

5 years agore PR tree-optimization/92162 (ICE in vect_create_epilog_for_reduction, at tree-vect...
Richard Biener [Mon, 21 Oct 2019 13:43:19 +0000 (13:43 +0000)]
re PR tree-optimization/92162 (ICE in vect_create_epilog_for_reduction, at tree-vect-loop.c:4252)

2019-10-21  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92162
* tree-vect-loop.c (vect_create_epilog_for_reduction): Lookup
STMT_VINFO_REDUC_IDX in reduc_info.
* tree-vect-stmts.c (vectorizable_condition): Likewise.

* gcc.dg/pr92162.c: New testcase.

From-SVN: r277261

5 years agocontrib: Add KPASS support to dg-extract-results.{sh,py}
Andrew Burgess [Mon, 21 Oct 2019 12:41:29 +0000 (13:41 +0100)]
contrib: Add KPASS support to dg-extract-results.{sh,py}

Extend dg-extract-results.sh and dg-extract-results.py to support the
KPASS test result status.  This is required by GDB which uses a copy
of the dg-extract-results.{sh,py} scripts that it tries to keep in
sync with GCC.

ChangeLog:

        * contrib/dg-extract-results.sh: Add support for KPASS.
        * contrib/dg-extract-results.py: Likewise.

From-SVN: r277260

5 years agotree-vectorizer.h (_slp_tree::ops): New member.
Richard Biener [Mon, 21 Oct 2019 11:34:00 +0000 (11:34 +0000)]
tree-vectorizer.h (_slp_tree::ops): New member.

2019-10-21  Richard Biener  <rguenther@suse.de>

* tree-vectorizer.h (_slp_tree::ops): New member.
(SLP_TREE_SCALAR_OPS): New.
(vect_get_slp_defs): Adjust prototype.
* tree-vect-slp.c (vect_free_slp_tree): Release
SLP_TREE_SCALAR_OPS.
(vect_create_new_slp_node): Initialize it.  New overload for
initializing by an operands array.
(_slp_oprnd_info::ops): New member.
(vect_create_oprnd_info): Initialize it.
(vect_free_oprnd_info): Release it.
(vect_get_and_check_slp_defs): Populate the operands array.
Do not swap operands in the IL when not necessary.
(vect_build_slp_tree_2): Build SLP nodes for invariant operands.
Record SLP_TREE_SCALAR_OPS for all invariant nodes.  Also
swap operands in the operands array.  Do not swap operands in
the IL.
(vect_slp_rearrange_stmts): Re-arrange SLP_TREE_SCALAR_OPS as well.
(vect_gather_slp_loads): Fix.
(vect_detect_hybrid_slp_stmts): Likewise.
(vect_slp_analyze_node_operations_1): Search for a internal
def child for computing reduction SLP_TREE_NUMBER_OF_VEC_STMTS.
(vect_slp_analyze_node_operations): Skip ops-only stmts for
the def-type push/pop dance.
(vect_get_constant_vectors): Compute number_of_vectors here.
Use SLP_TREE_SCALAR_OPS and simplify greatly.
(vect_get_slp_vect_defs): Use gimple_get_lhs also for PHIs.
(vect_get_slp_defs): Simplify greatly.
* tree-vect-loop.c (vectorize_fold_left_reduction): Simplify.
(vect_transform_reduction): Likewise.
* tree-vect-stmts.c (vect_get_vec_defs): Simplify.
(vectorizable_call): Likewise.
(vectorizable_operation): Likewise.
(vectorizable_load): Likewise.
(vectorizable_condition): Likewise.
(vectorizable_comparison): Likewise.

From-SVN: r277241

5 years agore PR tree-optimization/92161 (ICE in vect_get_vec_def_for_stmt_copy, at tree-vect...
Richard Biener [Mon, 21 Oct 2019 11:32:25 +0000 (11:32 +0000)]
re PR tree-optimization/92161 (ICE in vect_get_vec_def_for_stmt_copy, at tree-vect-stmts.c:1687)

2019-10-21  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92161
* tree-vect-loop.c (vect_analyze_loop_2): Reset stmts def-type
for reductions.

* gfortran.dg/pr92161.f: New testcase.

From-SVN: r277240

5 years ago[AArch64] Implement __rndr, __rndrrs intrinsics
Kyrylo Tkachov [Mon, 21 Oct 2019 10:52:05 +0000 (10:52 +0000)]
[AArch64] Implement __rndr, __rndrrs intrinsics

This patch implements the recently published[1] __rndr and __rndrrs
intrinsics used to access the RNG in Armv8.5-A.
The __rndrrs intrinsics can be used to reseed the generator too.
They are guarded by the __ARM_FEATURE_RNG feature macro.
A quirk with these intrinsics is that they store the random number in
their pointer argument and return a status
code if the generation succeeded.

The instructions themselves write the CC flags indicating the success of
the operation that we can then read with a CSET.
Therefore this implementation makes use of the IGNORE indicator to the
builtin expand machinery to avoid generating
the CSET if its result is unused (the CC reg clobbering effect is still
reflected in the pattern).
I've checked that using unspec_volatile prevents undesirable CSEing of
the instructions.

[1] https://developer.arm.com/docs/101028/latest/data-processing-intrinsics

* config/aarch64/aarch64.md (UNSPEC_RNDR, UNSPEC_RNDRRS): Define.
(aarch64_rndr): New define_insn.
(aarch64_rndrrs): Likewise.
* config/aarch64/aarch64.h (AARCH64_ISA_RNG): Define.
(TARGET_RNG): Likewise.
* config/aarch64/aarch64.c (aarch64_expand_builtin): Use IGNORE
argument.
* config/aarch64/aarch64-protos.h (aarch64_general_expand_builtin):
Add fourth argument in prototype.
* config/aarch64/aarch64-builtins.c (enum aarch64_builtins):
Add AARCH64_BUILTIN_RNG_RNDR, AARCH64_BUILTIN_RNG_RNDRRS.
(aarch64_init_rng_builtins): Define.
(aarch64_general_init_builtins): Call aarch64_init_rng_builtins.
(aarch64_expand_rng_builtin): Define.
(aarch64_general_expand_builtin): Use IGNORE argument, handle
RNG builtins.
* config/aarch64/aarch64-c.c (aarch64_update_cpp_builtins): Define
__ARM_FEATURE_RNG when TARGET_RNG.
* config/aarch64/arm_acle.h (__rndr, __rndrrs): Define.

* gcc.target/aarch64/acle/rng_1.c: New test.

From-SVN: r277239

5 years ago[vect] Only change base alignment if more restrictive
Andre Vieira [Mon, 21 Oct 2019 10:12:18 +0000 (10:12 +0000)]
[vect] Only change base alignment if more restrictive

This patch makes sure ensure_base_align only changes alignment if the new
alignment is more restrictive.  It already did this if we were dealing with
symbols, but it now does it for all types of declarations.

gcc/ChangeLog:
2019-10-21  Andre Vieira  <andre.simoesdiasvieira@arm.com>

* tree-vect-stmts (ensure_base_align): Only change alignment if new
alignment is more restrictive.

From-SVN: r277238

5 years agore PR tree-optimization/91532 ([SVE] Redundant predicated store in gcc.target/aarch64...
Prathamesh Kulkarni [Mon, 21 Oct 2019 07:31:45 +0000 (07:31 +0000)]
re PR tree-optimization/91532 ([SVE] Redundant predicated store in gcc.target/aarch64/fmla_2.c)

2019-10-21  Prathamesh Kulkarni  <prathamesh.kulkarni@linaro.org>

PR tree-optimization/91532
* gcc.target/aarch64/sve/fmla_2.c: Add dg-scan check for two st1d
insns.

From-SVN: r277237

5 years agoFix some fallout for small targets.
Georg-Johann Lay [Mon, 21 Oct 2019 06:54:42 +0000 (06:54 +0000)]
Fix some fallout for small targets.

PR testsuite/52641
* gcc.dg/torture/pr86034.c: Use 32-bit base type for a bitfield of
width > 16 bits.
* gcc.dg/torture/pr90972.c [avr]: Add option "-w".
* gcc.dg/torture/pr87693.c: Same.
* gcc.dg/torture/pr91178.c: Add dg-require-effective-target size32plus.
* gcc.dg/torture/pr91178-2.c: Same.
* gcc.dg/torture/20181024-1.c
* gcc.dg/torture/pr86554-1.c: Use 32-bit integers.
* gcc.dg/tree-ssa/pr91091-1.c: Same.

From-SVN: r277236

5 years agoReplace current_vector_size with vec_info::vector_size
Richard Sandiford [Mon, 21 Oct 2019 06:41:36 +0000 (06:41 +0000)]
Replace current_vector_size with vec_info::vector_size

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (vec_info::vector_size): New member variable.
(vect_update_max_nunits): Update comment.
(current_vector_size): Delete.
* tree-vect-stmts.c (current_vector_size): Likewise.
(get_vectype_for_scalar_type): Use vec_info::vector_size instead
of current_vector_size.
(get_mask_type_for_scalar_type): Likewise.
* tree-vectorizer.c (try_vectorize_loop_1): Likewise.
* tree-vect-loop.c (vect_update_vf_for_slp): Likewise.
(vect_analyze_loop, vect_halve_mask_nunits): Likewise.
(vect_double_mask_nunits, vect_transform_loop): Likewise.
* tree-vect-slp.c (can_duplicate_and_interleave_p): Likewise.
(vect_make_slp_decision, vect_slp_bb_region): Likewise.

From-SVN: r277235

5 years agoPass a vec_info to vect_double_mask_nunits
Richard Sandiford [Mon, 21 Oct 2019 06:41:31 +0000 (06:41 +0000)]
Pass a vec_info to vect_double_mask_nunits

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (vect_double_mask_nunits): Take a vec_info.
* tree-vect-loop.c (vect_double_mask_nunits): Likewise.
* tree-vect-stmts.c (supportable_narrowing_operation):  Update call
accordingly.

From-SVN: r277234

5 years agoPass a vec_info to vect_halve_mask_nunits
Richard Sandiford [Mon, 21 Oct 2019 06:41:25 +0000 (06:41 +0000)]
Pass a vec_info to vect_halve_mask_nunits

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (vect_halve_mask_nunits): Take a vec_info.
* tree-vect-loop.c (vect_halve_mask_nunits): Likewise.
* tree-vect-loop-manip.c (vect_maybe_permute_loop_masks): Update
call accordingly.
* tree-vect-stmts.c (supportable_widening_operation): Likewise.

From-SVN: r277233

5 years agoPass a loop_vec_info to vect_maybe_permute_loop_masks
Richard Sandiford [Mon, 21 Oct 2019 06:41:21 +0000 (06:41 +0000)]
Pass a loop_vec_info to vect_maybe_permute_loop_masks

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-loop-manip.c (vect_maybe_permute_loop_masks): Take
a loop_vec_info.
(vect_set_loop_condition_masked): Update call accordingly.

From-SVN: r277232

5 years agoPass a vec_info to supportable_narrowing_operation
Richard Sandiford [Mon, 21 Oct 2019 06:41:15 +0000 (06:41 +0000)]
Pass a vec_info to supportable_narrowing_operation

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (supportable_narrowing_operation): Take a vec_info.
* tree-vect-stmts.c (supportable_narrowing_operation): Likewise.
(simple_integer_narrowing): Update call accordingly.
(vectorizable_conversion): Likewise.

From-SVN: r277231

5 years agoPass a vec_info to simple_integer_narrowing
Richard Sandiford [Mon, 21 Oct 2019 06:41:10 +0000 (06:41 +0000)]
Pass a vec_info to simple_integer_narrowing

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-stmts.c (simple_integer_narrowing): Take a vec_info.
(vectorizable_call): Update call accordingly.

From-SVN: r277230

5 years agoPass a vec_info to can_duplicate_and_interleave_p
Richard Sandiford [Mon, 21 Oct 2019 06:41:05 +0000 (06:41 +0000)]
Pass a vec_info to can_duplicate_and_interleave_p

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (can_duplicate_and_interleave_p): Take a vec_info.
* tree-vect-slp.c (can_duplicate_and_interleave_p): Likewise.
(duplicate_and_interleave): Update call accordingly.
* tree-vect-loop.c (vectorizable_reduction): Likewise.

From-SVN: r277229

5 years agoPass a vec_info to duplicate_and_interleave
Richard Sandiford [Mon, 21 Oct 2019 06:41:01 +0000 (06:41 +0000)]
Pass a vec_info to duplicate_and_interleave

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (duplicate_and_interleave): Take a vec_info.
* tree-vect-slp.c (duplicate_and_interleave): Likewise.
(vect_get_constant_vectors): Update call accordingly.
* tree-vect-loop.c (get_initial_defs_for_reduction): Likewise.

From-SVN: r277228

5 years agoPass a vec_info to get_vectype_for_scalar_type
Richard Sandiford [Mon, 21 Oct 2019 06:40:53 +0000 (06:40 +0000)]
Pass a vec_info to get_vectype_for_scalar_type

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (get_vectype_for_scalar_type): Take a vec_info.
* tree-vect-stmts.c (get_vectype_for_scalar_type): Likewise.
(vect_prologue_cost_for_slp_op): Update call accordingly.
(vect_get_vec_def_for_operand, vect_get_gather_scatter_ops)
(vect_get_strided_load_store_ops, vectorizable_simd_clone_call)
(vect_supportable_shift, vect_is_simple_cond, vectorizable_comparison)
(get_mask_type_for_scalar_type): Likewise.
(vect_get_vector_types_for_stmt): Likewise.
* tree-vect-data-refs.c (vect_analyze_data_refs): Likewise.
* tree-vect-loop.c (vect_determine_vectorization_factor): Likewise.
(get_initial_def_for_reduction, build_vect_cond_expr): Likewise.
* tree-vect-patterns.c (vect_supportable_direct_optab_p): Likewise.
(vect_split_statement, vect_convert_input): Likewise.
(vect_recog_widen_op_pattern, vect_recog_pow_pattern): Likewise.
(vect_recog_over_widening_pattern, vect_recog_mulhs_pattern): Likewise.
(vect_recog_average_pattern, vect_recog_cast_forwprop_pattern)
(vect_recog_rotate_pattern, vect_recog_vector_vector_shift_pattern)
(vect_synth_mult_by_constant, vect_recog_mult_pattern): Likewise.
(vect_recog_divmod_pattern, vect_recog_mixed_size_cond_pattern)
(check_bool_pattern, adjust_bool_pattern_cast, adjust_bool_pattern)
(search_type_for_mask_1, vect_recog_bool_pattern): Likewise.
(vect_recog_mask_conversion_pattern): Likewise.
(vect_add_conversion_to_pattern): Likewise.
(vect_recog_gather_scatter_pattern): Likewise.
* tree-vect-slp.c (vect_build_slp_tree_2): Likewise.
(vect_analyze_slp_instance, vect_get_constant_vectors): Likewise.

From-SVN: r277227

5 years agoPass a vec_info to get_mask_type_for_scalar_type
Richard Sandiford [Mon, 21 Oct 2019 06:40:49 +0000 (06:40 +0000)]
Pass a vec_info to get_mask_type_for_scalar_type

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (get_mask_type_for_scalar_type): Take a vec_info.
* tree-vect-stmts.c (get_mask_type_for_scalar_type): Likewise.
(vect_check_load_store_mask): Update call accordingly.
(vect_get_mask_type_for_stmt): Likewise.
* tree-vect-patterns.c (check_bool_pattern): Likewise.
(search_type_for_mask_1, vect_recog_mask_conversion_pattern): Likewise.
(vect_convert_mask_for_vectype): Likewise.

From-SVN: r277226

5 years agoPass a vec_info to vect_supportable_direct_optab_p
Richard Sandiford [Mon, 21 Oct 2019 06:40:44 +0000 (06:40 +0000)]
Pass a vec_info to vect_supportable_direct_optab_p

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-patterns.c (vect_supportable_direct_optab_p): Take
a vec_info.
(vect_recog_dot_prod_pattern): Update call accordingly.
(vect_recog_sad_pattern, vect_recog_pow_pattern): Likewise.
(vect_recog_widen_sum_pattern): Likewise.

From-SVN: r277225

5 years agoPass a vec_info to vect_supportable_shift
Richard Sandiford [Mon, 21 Oct 2019 06:40:41 +0000 (06:40 +0000)]
Pass a vec_info to vect_supportable_shift

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (vect_supportable_shift): Take a vec_info.
* tree-vect-stmts.c (vect_supportable_shift): Likewise.
* tree-vect-patterns.c (vect_synth_mult_by_constant): Update call
accordingly.

From-SVN: r277224

5 years agoAvoid setting current_vector_size in get_vec_alignment_for_array_type
Richard Sandiford [Mon, 21 Oct 2019 06:40:36 +0000 (06:40 +0000)]
Avoid setting current_vector_size in get_vec_alignment_for_array_type

The increase_alignment pass was using get_vectype_for_scalar_type
to get the preferred vector type for each array element type.
This has the effect of carrying over the vector size chosen by
the first successful call to all subsequent calls, whereas it seems
more natural to treat each array type independently and pick the
"best" vector type for each element type.

2019-10-21  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.c (get_vec_alignment_for_array_type): Use
get_vectype_for_scalar_type_and_size instead of
get_vectype_for_scalar_type.

From-SVN: r277223

5 years agoDaily bump.
GCC Administrator [Mon, 21 Oct 2019 00:16:16 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r277221

5 years agocommon.opt (-fcommon): Fix description.
Bernd Edlinger [Sun, 20 Oct 2019 21:29:27 +0000 (21:29 +0000)]
common.opt (-fcommon): Fix description.

2019-10-20  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * common.opt (-fcommon): Fix description.

From-SVN: r277217

5 years agoi386-protos.h (ix86_pre_reload_split): Declare.
Jakub Jelinek [Sun, 20 Oct 2019 20:44:26 +0000 (22:44 +0200)]
i386-protos.h (ix86_pre_reload_split): Declare.

* config/i386/i386-protos.h (ix86_pre_reload_split): Declare.
* config/i386/i386.c (ix86_pre_reload_split): New function.
* config/i386/i386.md (*fix_trunc<mode>_i387_1, *add<mode>3_eq,
*add<mode>3_ne, *add<mode>3_eq_0, *add<mode>3_ne_0, *add<mode>3_eq,
*add<mode>3_ne, *add<mode>3_eq_1, *add<mode>3_eq_0, *add<mode>3_ne_0,
*anddi3_doubleword, *andndi3_doubleword, *<code>di3_doubleword,
*one_cmpldi2_doubleword, *ashl<dwi>3_doubleword_mask,
*ashl<dwi>3_doubleword_mask_1, *ashl<mode>3_mask, *ashl<mode>3_mask_1,
*<shift_insn><mode>3_mask, *<shift_insn><mode>3_mask_1,
*<shift_insn><dwi>3_doubleword_mask,
*<shift_insn><dwi>3_doubleword_mask_1, *<rotate_insn><mode>3_mask,
*<rotate_insn><mode>3_mask_1, *<btsc><mode>_mask, *<btsc><mode>_mask_1,
*btr<mode>_mask, *btr<mode>_mask_1, *jcc_bt<mode>, *jcc_bt<mode>_1,
*jcc_bt<mode>_mask, *popcounthi2_1, frndintxf2_<rounding>,
*fist<mode>2_<rounding>_1, *<code><mode>3_1, *<code>di3_doubleword):
Use ix86_pre_reload_split instead of can_create_pseudo_p in condition.
* config/i386/sse.md (*sse4_1_<code>v8qiv8hi2<mask_name>_2,
*avx2_<code>v8qiv8si2<mask_name>_2,
*sse4_1_<code>v4qiv4si2<mask_name>_2,
*sse4_1_<code>v4hiv4si2<mask_name>_2,
*avx512f_<code>v8qiv8di2<mask_name>_2,
*avx2_<code>v4qiv4di2<mask_name>_2, *avx2_<code>v4hiv4di2<mask_name>_2,
*sse4_1_<code>v2hiv2di2<mask_name>_2,
*sse4_1_<code>v2siv2di2<mask_name>_2, sse4_2_pcmpestr,
sse4_2_pcmpistr): Likewise.

From-SVN: r277216

5 years agoinstall.texi (Configuration, [...]): hboehm.info now defaults to https.
Gerald Pfeifer [Sun, 20 Oct 2019 20:15:28 +0000 (20:15 +0000)]
install.texi (Configuration, [...]): hboehm.info now defaults to https.

* doc/install.texi (Configuration, --enable-objc-gc): hboehm.info
now defaults to https.

From-SVN: r277215

5 years agotree-ssa-alias.c (nonoverlapping_refs_since_match_p): Do not skip non-zero array...
Jan Hubicka [Sun, 20 Oct 2019 18:53:37 +0000 (20:53 +0200)]
tree-ssa-alias.c (nonoverlapping_refs_since_match_p): Do not skip non-zero array accesses.

* tree-ssa-alias.c (nonoverlapping_refs_since_match_p): Do not
skip non-zero array accesses.

* gcc.c-torture/execute/alias-access-path-2.c: New testcase.
* gcc.dg/tree-ssa/alias-access-path-11.c: xfail.

From-SVN: r277214

5 years agoMove code out of vect_slp_analyze_bb_1
Richard Sandiford [Sun, 20 Oct 2019 12:59:45 +0000 (12:59 +0000)]
Move code out of vect_slp_analyze_bb_1

After the previous patch, it seems more natural to apply the
PARAM_SLP_MAX_INSNS_IN_BB threshold as soon as we know what
the region is, rather than delaying it to vect_slp_analyze_bb_1.
(But rather than carve out the biggest region possible and then
reject it, wouldn't it be better to stop when the region gets
too big, to at least give us a chance of vectorising something?)

It also seems more natural for vect_slp_bb_region to create the
bb_vec_info itself rather than (a) having to pass bits of data down
for the initialisation and (b) forcing vect_slp_analyze_bb_1 to free
on every failure return.

2019-10-20  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-slp.c (vect_slp_analyze_bb_1): Take a bb_vec_info
and return a boolean success value.  Move the allocation and
initialization of the bb_vec_info to...
(vect_slp_bb_region): ...here.  Update call accordingly.
(vect_slp_bb): Apply PARAM_SLP_MAX_INSNS_IN_BB here rather
than in vect_slp_analyze_bb_1.

From-SVN: r277211

5 years agoAvoid recomputing data references in BB SLP
Richard Sandiford [Sun, 20 Oct 2019 12:58:22 +0000 (12:58 +0000)]
Avoid recomputing data references in BB SLP

If the first attempt at applying BB SLP to a region fails, the main loop
in vect_slp_bb recomputes the region's bounds and datarefs for the next
vector size.  AFAICT this isn't needed any more; we should be able
to reuse the datarefs from the first attempt instead.

2019-10-20  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-slp.c (vect_slp_analyze_bb_1): Call save_datarefs
when processing the given datarefs for the first time and
check_datarefs subsequently.
(vect_slp_bb_region): New function, split out of...
(vect_slp_bb): ...here.  Don't recompute the region bounds and
dataref sets when retrying with a different vector size.

From-SVN: r277210

5 years agoDaily bump.
GCC Administrator [Sun, 20 Oct 2019 00:16:28 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r277209

5 years agonodiscard-reason-only-one.C: In dg-error or dg-warning remove (?n) uses and replace...
Jakub Jelinek [Sat, 19 Oct 2019 22:27:10 +0000 (00:27 +0200)]
nodiscard-reason-only-one.C: In dg-error or dg-warning remove (?n) uses and replace .* with \[^\n\r]*.

* g++.dg/cpp2a/nodiscard-reason-only-one.C: In dg-error or dg-warning
remove (?n) uses and replace .* with \[^\n\r]*.
* g++.dg/cpp2a/nodiscard-reason.C: Likewise.
* g++.dg/cpp2a/nodiscard-once.C: Likewise.
* g++.dg/cpp2a/nodiscard-reason-nonstring.C: Likewise.

From-SVN: r277205

5 years agore PR fortran/91926 (assumed rank optional)
Paul Thomas [Sat, 19 Oct 2019 16:44:06 +0000 (16:44 +0000)]
re PR fortran/91926 (assumed rank optional)

2019-10-19  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/91926
* runtime/ISO_Fortran_binding.c (cfi_desc_to_gfc_desc): Revert
the change made on 2019-10-05.

From-SVN: r277204

5 years agore PR target/92140 (clang vs gcc optimizing with adc/sbb)
Jakub Jelinek [Sat, 19 Oct 2019 12:46:57 +0000 (14:46 +0200)]
re PR target/92140 (clang vs gcc optimizing with adc/sbb)

PR target/92140
* config/i386/predicates.md (int_nonimmediate_operand): New special
predicate.
* config/i386/i386.md (*add<mode>3_eq, *add<mode>3_ne,
*add<mode>3_eq_0, *add<mode>3_ne_0, *sub<mode>3_eq, *sub<mode>3_ne,
*sub<mode>3_eq_1, *sub<mode>3_eq_0, *sub<mode>3_ne_0): New
define_insn_and_split patterns.

* gcc.target/i386/pr92140.c: New test.
* gcc.c-torture/execute/pr92140.c: New test.

Co-Authored-By: Uros Bizjak <ubizjak@gmail.com>
From-SVN: r277203

5 years ago[Darwin, testsuite] Fix Wnonnull on Darwin.
Iain Sandoe [Sat, 19 Oct 2019 07:44:49 +0000 (07:44 +0000)]
[Darwin, testsuite] Fix Wnonnull on Darwin.

Darwin does not mark entries in string.h with nonnull attributes
so the test fails.  Since the purpose of the test is to check that
the warnings are issued for an inlined function, not that the target
headers are marked up, we can provide marked up headers for Darwin.

gcc/testsuite/ChangeLog:

2019-10-19  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.dg/Wnonnull.c: Add attributed function declarations for
memcpy and strlen for Darwin.

From-SVN: r277202

5 years ago[PPC] Delete out of date comment.
Iain Sandoe [Sat, 19 Oct 2019 07:34:23 +0000 (07:34 +0000)]
[PPC] Delete out of date comment.

Removes a comment that's no longer relevant.

gcc/ChangeLog:

2019-10-19  Iain Sandoe  <iain@sandoe.co.uk>

* config/rs6000/rs6000.md: Delete out--of-date comment about
special-casing integer loads.

From-SVN: r277201

5 years agoImplement C++20 P1301 [[nodiscard("should have a reason")]].
JeanHeyd Meneide [Sat, 19 Oct 2019 04:51:59 +0000 (04:51 +0000)]
Implement C++20 P1301 [[nodiscard("should have a reason")]].

2019-10-17  JeanHeyd Meneide  <phdofthehouse@gmail.com>

gcc/
        * escaped_string.h (escaped_string): New header.
        * tree.c (escaped_string): Remove escaped_string class.

gcc/c-family
        * c-lex.c (c_common_has_attribute): Update nodiscard value.

gcc/cp/
        * tree.c (handle_nodiscard_attribute) Added C++2a nodiscard
string message.
        (std_attribute_table) Increase nodiscard argument handling
max_length from 0 to 1.
        * parser.c (cp_parser_check_std_attribute): Add requirement
that nodiscard only be seen once in attribute-list.
        (cp_parser_std_attribute): Check that empty parenthesis lists are
        not specified for attributes that have max_length > 0 (e.g.
[[attr()]]).
        * cvt.c (maybe_warn_nodiscard): Add nodiscard message to
output, if applicable.
(convert_to_void): Allow constructors to be nodiscard-able (P1771).

gcc/testsuite/g++.dg/cpp0x
        * gen-attrs-67.C: Test new error message for empty-parenthesis-list.

gcc/testsuite/g++.dg/cpp2a
        * nodiscard-construct.C: New test.
        * nodiscard-once.C: New test.
        * nodiscard-reason-nonstring.C: New test.
        * nodiscard-reason-only-one.C: New test.
        * nodiscard-reason.C: New test.

Reviewed-by: Jason Merrill <jason@redhat.com>
From-SVN: r277200

5 years agoDaily bump.
GCC Administrator [Sat, 19 Oct 2019 00:18:25 +0000 (00:18 +0000)]
Daily bump.

From-SVN: r277199

5 years agoPR tree-optimization/92157 - incorrect strcmp() == 0 result for unknown strings
Martin Sebor [Fri, 18 Oct 2019 22:26:39 +0000 (22:26 +0000)]
PR tree-optimization/92157 - incorrect strcmp() == 0 result for unknown strings

gcc/testsuite/ChangeLog:

PR tree-optimization/92157
* gcc.dg/strlenopt-69.c: Disable test failing due to PR 92155.
* gcc.dg/strlenopt-87.c: New test.

gcc/ChangeLog:

PR tree-optimization/92157
* tree-ssa-strlen.c (handle_builtin_string_cmp): Be prepared for
compute_string_length to return a negative result.

From-SVN: r277194

5 years ago[arm] Fix testsuite nit when compiling for thumb2
Richard Earnshaw [Fri, 18 Oct 2019 19:05:25 +0000 (19:05 +0000)]
[arm] Fix testsuite nit when compiling for thumb2

In thumb2 we now generate a NEGS instruction rather than RSBS, so this
test needs updating.

* gcc.target/arm/negdi-3.c: Update expected output to allow NEGS.

From-SVN: r277192

5 years ago[arm] Improvements to negvsi4 and negvdi4.
Richard Earnshaw [Fri, 18 Oct 2019 19:05:16 +0000 (19:05 +0000)]
[arm] Improvements to negvsi4 and negvdi4.

The generic expansion code for negv does not try the subv patterns,
but instead emits a sub and a compare separately.  Fortunately, the
patterns can make use of the new subv operations, so just call those.
We can also rewrite this using an iterator to simplify things further.
Finally, we can now make negvdi4 work on Thumb2 as well as Arm.

* config/arm/arm.md (negv<SIDI:mode>3): New expansion rule.
(negvsi3, negvdi3): Delete.
(negdi2_compare): Delete.

From-SVN: r277191

5 years ago[arm] Early expansion of subvdi4
Richard Earnshaw [Fri, 18 Oct 2019 19:05:09 +0000 (19:05 +0000)]
[arm] Early expansion of subvdi4

This patch adds early expansion of subvdi4.  The expansion sequence
is broadly based on the expansion of usubvdi4.

* config/arm/arm.md (subvdi4): Decompose calculation into 32-bit
operations.
(subdi3_compare1): Delete pattern.
(subvsi3_borrow): New insn pattern.
(subvsi3_borrow_imm): Likewise.

From-SVN: r277190

5 years ago[arm] Improve constant handling for subvsi4.
Richard Earnshaw [Fri, 18 Oct 2019 19:05:01 +0000 (19:05 +0000)]
[arm] Improve constant handling for subvsi4.

This patch addresses constant handling in subvsi4.  Either operand may
be a constant.  If the second input (operand[2]) is a constant, then
we can canonicalize this into an addition form, providing we take care
of the INT_MIN case.  In that case the negation has to handle the fact
that -INT_MIN is still INT_MIN and we need to ensure that a subtract
operation is performed rather than an addition.  The remaining cases
are largely duals of the usubvsi4 expansion.

This patch also fixes a technical correctness bug in the old
expansion, where we did not realy describe the test for overflow in
the RTL.  We seem to have got away with that, however...

* config/arm/arm.md (subv<mode>4): Delete.
(subvdi4): New expander pattern.
(subvsi4): Likewise.  Handle some immediate values.
(subvsi3_intmin): New insn pattern.
(subvsi3): Likewise.
(subvsi3_imm1): Likewise.
* config/arm/arm.c (select_cc_mode): Also allow minus for CC_V
idioms.

From-SVN: r277189