Richard Earnshaw [Thu, 3 Nov 2016 18:08:19 +0000 (18:08 +0000)]
[arm] Eliminate SUBTARGET_CPU_DEFAULT
* config.gcc (arm-wrs-vxworks): Set target_cpu_cname.
(arm*-freebsd*): Likewise.
(arm*-*-netbsdelf*): Likewise.
(arm*-*-linux*): Likewise.
(arm*-*-uclinux*eabi*): Likewise.
(arm*-*-phoenix*): Likewise.
(arm*-*-eabi*, arm*-*-symbianelf*, arm*-*-rtems*): Likewise.
(arm*-*-*): Don't clobber target_cpu_cname when --with-cpu is not
specified. Default to arm6 if target_cpu_cname is not set.
* arm/arm.c (arm_option_override): Simplify logic. Assert that the
default cpu has been correctly configured.
* arm/arm.h (TARGET_CPU_DEFAULT): Delete.
(target_cpus): Delete TARGET_CPU_generic, add TARGET_CPU_num_cores.
* arm/freebsd.h (SUBTARGET_CPU_DEFAULT): Delete.
* arm/linux-eabi.h (SUBTARGET_CPU_DEFAULT): Delete.
* arm/linux-elf.h (SUBTARGET_CPU_DEFAULT): Delete.
* arm/symbian.h (SUBTARGET_CPU_DEFAULT): Delete.
* arm/unknown-elf.h (SUBTARGET_CPU_DEFAULT): Delete.
From-SVN: r241827
Jiong Wang [Thu, 3 Nov 2016 17:32:03 +0000 (17:32 +0000)]
[DWARF] Enable DW_CFA_VAL_EXPRESSION support
gcc/
* reg-notes.def (CFA_VAL_EXPRESSION): New entry.
* dwarf2cfi.c (dwarf2out_frame_debug_cfa_val_expression): New function.
(dwarf2out_frame_debug): Support REG_CFA_VAL_EXPRESSION.
(output_cfa_loc): Support DW_CFA_val_expression.
(output_cfa_loc_raw): Likewise.
(output_cfi): Likewise.
(output_cfi_directive): Likewise.
* dwarf2out.c (dw_cfi_oprnd1_desc): Support DW_CFA_val_expression.
(dw_cfi_oprnd2_desc): Likewise.
(mem_loc_descriptor): Recognize new pattern generated for value
expression.
From-SVN: r241826
Segher Boessenkool [Thu, 3 Nov 2016 16:04:22 +0000 (17:04 +0100)]
combine lhs zero_extract fix (PR78186)
PR rtl-optimization/78186
* combine.c (change_zero_ext): Mask the RHS of a zero_extract as
well, when converting to IOR.
From-SVN: r241824
Fritz O. Reese [Thu, 3 Nov 2016 16:00:58 +0000 (16:00 +0000)]
Support legacy PARAMETER statements with -std=legacy.
gcc/fortran/
* decl.c (gfc_match_parameter): Allow omitted '()' with -std=legacy.
* parse.c (decode_statement): Match "parameter" before assignments.
* gfortran.texi: Document.
gcc/testsuite/gfortran.dg/
* dec_parameter_1.f: New test.
* dec_parameter_2.f90: Likewise.
* dec_parameter_3.f90: Likewise.
* dec_parameter_4.f90: Likewise.
From-SVN: r241823
Eric Botcazou [Thu, 3 Nov 2016 16:00:55 +0000 (16:00 +0000)]
sparc.md (vec_interleave_lowv8qi): Delete.
* config/sparc/sparc.md (vec_interleave_lowv8qi): Delete.
(vec_interleave_highv8qi): Likewise.
From-SVN: r241822
Martin Liska [Thu, 3 Nov 2016 15:24:22 +0000 (16:24 +0100)]
Make direct emission of time profiler counter
* libgcov-profiler.c (__gcov_time_profiler): Remove.
(__gcov_time_profiler_atomic): Likewise.
* profile.c (instrument_values): Fix coding style.
(branch_prob): Use renamed function.
* tree-profile.c (init_ic_make_global_vars): Likewise.
(gimple_init_edge_profiler): Rename to
gimple_init_gcov_profiler.
tree_time_profiler_counter variable declaration.
(gimple_gen_time_profiler): Rewrite to do a direct gimple code
emission.
* value-prof.h: Remove an argument.
* gcc.dg/no_profile_instrument_function-attr-1.c: Update scanned
output.
* gcc.dg/tree-prof/time-profiler-3.c: New test.
From-SVN: r241821
Bernd Edlinger [Thu, 3 Nov 2016 12:52:19 +0000 (12:52 +0000)]
re PR libgcc/78067 (libgcc2 calls count_leading_zero with 0)
2016-11-03 Bernd Edlinger <bernd.edlinger@hotmail.de>
PR libgcc/78067
* libgcc2.c (__floatdisf, __floatdidf): Avoid undefined results from
count_leading_zeros.
testsuite:
2016-11-03 Bernd Edlinger <bernd.edlinger@hotmail.de>
PR libgcc/78067
* gcc.dg/torture/fp-int-convert.h: Add more conversion tests.
From-SVN: r241817
Richard Biener [Thu, 3 Nov 2016 12:31:10 +0000 (12:31 +0000)]
rs6000.c (rs6000_xcoff_declare_object_name): Use symtab_node::get_create.
2016-11-03 Richard Biener <rguenther@suse.de>
* config/rs6000/rs6000.c (rs6000_xcoff_declare_object_name): Use
symtab_node::get_create.
From-SVN: r241816
Kyrylo Tkachov [Thu, 3 Nov 2016 12:08:26 +0000 (12:08 +0000)]
[rtlanal] Fix WORD_REGISTER_OPERATIONS condition in nonzero_bits
* rtlanal.c (nonzero_bits1): Fix WORD_REGISTER_OPERATIONS condition.
Move comments into more natural position.
From-SVN: r241815
Vineet Gupta [Thu, 3 Nov 2016 10:52:52 +0000 (10:52 +0000)]
[ARC] Define SIZE_TYPE and PTRDIFF_TYPE correctly.
This silences tons of -Wformat= warnings when building ARC Linux kernel
with gcc 6.x (and restores the ARC gcc 4.8.x behaviour) which had
similar fix.
gcc/
2016-11-03 Vineet Gupta <vgupta@synopsys.com>
* config/arc/arc.h (SIZE_TYPE): Define as unsigned int.
(PTRDIFF_TYPE): Define as int.
From-SVN: r241812
Trevor Saunders [Thu, 3 Nov 2016 09:27:55 +0000 (09:27 +0000)]
make targetm.gen_ccmp{first,next} take rtx_insn **
gcc/ChangeLog:
2016-11-03 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* ccmp.c (expand_ccmp_expr_1): Adjust.
(expand_ccmp_expr): Likewise.
(expand_ccmp_next): Likewise.
* config/aarch64/aarch64.c (aarch64_gen_ccmp_next): Likewise.
(aarch64_gen_ccmp_first): Likewise.
* doc/tm.texi: Regenerate.
* target.def (gen_ccmp_first): Change argument types to rtx_insn *.
(gen_ccmp_next): Likewise.
From-SVN: r241811
Bin Cheng [Thu, 3 Nov 2016 09:15:45 +0000 (09:15 +0000)]
tree-vect-loop.c (destroy_loop_vec_info): Handle cond_expr.
* tree-vect-loop.c (destroy_loop_vec_info): Handle cond_expr.
(vect_is_simple_reduction): Swap cond_reduction by inversion.
From-SVN: r241810
Senthil Kumar Selvaraj [Thu, 3 Nov 2016 08:04:40 +0000 (08:04 +0000)]
Fix bougs PR 78170 failure for avr
The test defines int bitfields that are more than 16 bits wide, and this
fails for the avr with its 16 bit integer size. Therefore, require
effective target int32plus.
gcc/testsuite/
2016-11-03 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
* gcc.c-torture/execute/pr78170.c: Require int32plus.
From-SVN: r241809
GCC Administrator [Thu, 3 Nov 2016 00:16:18 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r241808
Uros Bizjak [Wed, 2 Nov 2016 22:25:44 +0000 (23:25 +0100)]
i386.c (ix86_init_libfuncs): New.
* config/i386/i386.c (ix86_init_libfuncs): New. Call
darwin_rename_builtins here.
(ix86_expand_divmod_libfunc): New.
(TARGET_INIT_LIBFUNCS): Unconditionally define to ix86_init_libfuncs.
(TARGET_EXPAND_DIVMOD_LIBFUNC): Define.
From-SVN: r241805
Uros Bizjak [Wed, 2 Nov 2016 22:23:13 +0000 (23:23 +0100)]
Makefile.in (LIB2_DIVMOD_FUNCS): Add _divmoddi4.
* Makefile.in (LIB2_DIVMOD_FUNCS): Add _divmoddi4.
* libgcc2.c (__divmoddi4): New function.
* libgcc2.h (__divmoddi4): Declare.
* libgcc-std.ver.in (GCC_7.0.0): New. Add __PFX_divmoddi4
and __PFX_divmodti4.
From-SVN: r241804
Cesar Philippidis [Wed, 2 Nov 2016 22:10:02 +0000 (15:10 -0700)]
nvptx.c (PTX_GANG_DEFAULT): Set to zero.
gcc/
* config/nvptx/nvptx.c (PTX_GANG_DEFAULT): Set to zero.
libgomp/
* plugin/plugin-nvptx.c (nvptx_exec): Interrogate board attributes
to determine default geometry.
* testsuite/libgomp.oacc-c-c++-common/loop-auto-1.c: Set gang
dimension.
Co-Authored-By: Nathan Sidwell <nathan@acm.org>
From-SVN: r241803
Max Filippov [Wed, 2 Nov 2016 18:36:52 +0000 (18:36 +0000)]
xtensa: don't xfail gcc.c-torture/compile/
20001226-1.c
With jump trampolines implemented in binutils since 2.25 and enabled by
default this test no longer fails on xtensa.
2016-11-02 Max Filippov <jcmvbkbc@gmail.com>
gcc/testsuite/
* gcc.c-torture/compile/
20001226-1.c: Don't xfail on xtensa.
From-SVN: r241801
Max Filippov [Wed, 2 Nov 2016 18:34:43 +0000 (18:34 +0000)]
xtensa: fix ICE on pr59037.c test
xtensa gcc gets ICE on pr59037.c test because its xtensa_output_literal
function cannot handle integer literals of sizes other than 4 and 8,
whereas the test uses 16-byte int vector.
Split integer literal formatting into the recursive function
xtensa_output_integer_literal_parts capable of handling literals of any
power of 2 size not less than 4.
2016-11-02 Max Filippov <jcmvbkbc@gmail.com>
gcc/
* config/xtensa/xtensa.c (xtensa_output_integer_literal_parts):
New function.
(xtensa_output_literal): Use xtensa_output_integer_literal_parts
to format MODE_INT and MODE_PARTIAL_INT literals.
From-SVN: r241800
Segher Boessenkool [Wed, 2 Nov 2016 17:06:04 +0000 (18:06 +0100)]
rs6000: Disable shrink-wrap-separate for abi=spe (PR78168)
With the SPE ABI, if we wrap GPRs we need to handle the upper half of the
extended 64-bit registers as well, which we cannot easily do. So, this
patch disables separate shrink-wrapping for the SPE ABI.
PR target/78168
* config/r6000/rs6000.c (rs6000_get_separate_components): Return
NULL if TARGET_SPE_ABI.
From-SVN: r241799
Kyrylo Tkachov [Wed, 2 Nov 2016 16:03:13 +0000 (16:03 +0000)]
Fix for big-endian gcc.c-torture/execute/pr55750.c
* gimple-ssa-store-merging.c (encode_tree_to_bitpos): Don't forget to
clear padding bits even when they're less than a byte.
From-SVN: r241798
Tamar Christina [Wed, 2 Nov 2016 15:57:11 +0000 (15:57 +0000)]
Fix failing vminnm/vmaxnm test on ARM.
* gcc.target/arm/simd/vmaxnm_f32_1.c (dg-require-effective-target):
Check for arm_v8_neon_hw.
* gcc.target/arm/simd/vmaxnmq_f32_1.c (dg-require-effective-target):
Likewise.
* gcc.target/arm/simd/vminnm_f32_1.c (dg-require-effective-target):
Likewise.
* gcc.target/arm/simd/vminnmq_f32_1.c(dg-require-effective-target):
Likewise.
From-SVN: r241797
Richard Biener [Wed, 2 Nov 2016 15:00:48 +0000 (15:00 +0000)]
gimple-ssa-store-merging.c: Include gimplify-me.h.
2016-11-02 Richard Biener <rguenther@suse.de>
* gimple-ssa-store-merging.c: Include gimplify-me.h.
(imm_store_chain_info::output_merged_stores): Force base_addr
to be proper GIMPLE for a MEM_REF address.
(pass_store_merging::execute): Restrict negative bitpos
handling to non-MEM_REF bases. Remove TREE_THIS_VOLATILE
check. Take into account non-NULL_TREE offset if the base
is already addressable.
* gcc.dg/store_merging_8.c: New testcase.
From-SVN: r241796
Fritz O. Reese [Wed, 2 Nov 2016 14:56:41 +0000 (14:56 +0000)]
New warning -Wargument-mismatch for function argument mismatches.
gcc/fortran/
* lang.opt, invoke.texi: New argument -Wargument-mismatch.
* interface.c (compare_parameter, compare_actual_formal,
gfc_check_typebound_override, argument_rank_mismatch): Control argument
mismatch warnings with -Wargument-mismatch.
* resolve.c (resolve_structure_cons, resolve_global_procedure): Ditto.
gcc/testsuite/gfortran.dg/
* warn_argument_mismatch_1.f90: New test.
From-SVN: r241795
Fritz Reese [Wed, 2 Nov 2016 14:46:33 +0000 (14:46 +0000)]
Allow warning flags to associate through gfc_error.
gcc/fortran/
* gfortran.h (gfc_error): New declaration for gfc_error with 'opt'.
* error.c (gfc_error): Add optional 'opt' argument.
* error.c (gfc_notify_std): Call fully-qualified gfc_error.
From-SVN: r241794
Wilco Dijkstra [Wed, 2 Nov 2016 14:00:22 +0000 (14:00 +0000)]
Add LE/BE SHA1H patterns with a V2SI input.
Add LE/BE SHA1H patterns with a V2SI input. This avoids unnecessary
DUPs when using intrinsics like vsha1h_u32 (vgetq_lane_u32 (x, 0)).
gcc/
* config/aarch64/aarch64-simd.md (aarch64_crypto_sha1hv4si):
New pattern.
(aarch64_be_crypto_sha1hv4si): New pattern.
From-SVN: r241791
Wilco Dijkstra [Wed, 2 Nov 2016 13:56:07 +0000 (13:56 +0000)]
The add expander still contains some expansion code that was required for the previous prolog/epilog code...
The add expander still contains some expansion code that was required for the
previous prolog/epilog code, but which is no longer needed. I also noticed
that the current version splits off immediates from frame addressing
instructions, which doesn't seem a good idea. Avoiding this resulted in small
codesize improvements.
gcc/
* config/aarch64/aarch64.md (add<mode>3): Remove
redundant code. Don't split frame based additions.
From-SVN: r241790
Richard Biener [Wed, 2 Nov 2016 13:05:07 +0000 (13:05 +0000)]
gimple-ssa-store-merging.c (struct store_immediate_info): Remove redundant val and dest members.
2016-11-02 Richard Biener <rguenther@suse.de>
* gimple-ssa-store-merging.c (struct store_immediate_info): Remove
redundant val and dest members.
(store_immediate_info::store_immediate_info): Adjust.
(merged_store_group::merged_store_group): Adjust.
(merged_store_group::apply_stores): Likewise.
(struct imm_store_chain_info): Add base_addr field.
(imm_store_chain_info::imm_store_chain_info): New constructor.
(imm_store_chain_info::terminate_and_process_chain): Do not pass base.
(imm_store_chain_info::output_merged_store): Likewise. Use
addr_base which is already the address.
(imm_store_chain_info::output_merged_stores): Likewise.
(pass_tree_store_merging::terminate_all_aliasing_chains): Take
imm_store_chain_info instead of base. Fix alias check.
(pass_tree_store_merging::terminate_and_release_chain): Likewise.
(imm_store_chain_info::coalesce_immediate_stores): Adjust.
(pass_store_merging::execute): Refuse to operate on TARGET_MEM_REF.
use the address of the base and adjust for other changes.
From-SVN: r241789
David Edelsohn [Wed, 2 Nov 2016 12:42:19 +0000 (12:42 +0000)]
prod-options.c: XFAIL AIX.
* gcc.dg/debug/dwarf2/prod-options.c: XFAIL AIX.
* gcc.dg/debug/dwarf2/pr71855.c: XFAIL AIX.
* gcc.dg/addr_equal_1.c: XFAIL AIX.
* gcc.dg/pr65779.c: XFAIL AIX.
* gcc.dg/pr70405.c: XFAIL AIX.
From-SVN: r241787
David Edelsohn [Wed, 2 Nov 2016 12:39:06 +0000 (12:39 +0000)]
inline-var-1.C: XFAIL AIX.
* g++.dg/debug/dwarf2/inline-var-1.C: XFAIL AIX.
* g++.dg/debug/dwarf2/ref-2.C: XFAIL AIX.
* g++.dg/debug/dwarf2/constexpr-var-1.C: XFAIL AIX.
From-SVN: r241786
Rainer Orth [Wed, 2 Nov 2016 10:27:23 +0000 (10:27 +0000)]
Fix linker detection in check_gc_sections_available
* lib/target-supports.exp (check_gc_sections_available): Use
-print-prog-name=ld to determine linker used.
From-SVN: r241783
Martin Liska [Wed, 2 Nov 2016 09:56:04 +0000 (10:56 +0100)]
Fix host_size_t_cst_p predicat
* fold-const-call.c (host_size_t_cst_p): Test whether
t is convertible to size_t.
* gcc.dg/tree-ssa/builtins-folding-gimple-ub.c (main): Add
test case.
From-SVN: r241780
Kyrylo Tkachov [Wed, 2 Nov 2016 09:28:35 +0000 (09:28 +0000)]
PR tree-optimization/78170: Truncate sign-extended padding when encoding bitfields
PR tree-optimization/78170
* gimple-ssa-store-merging.c (encode_tree_to_bitpos): Truncate padding
introduced by native_encode_expr on little-endian as well.
* gcc.c-torture/execute/pr78170.c: New test.
From-SVN: r241779
Kyrylo Tkachov [Wed, 2 Nov 2016 09:25:22 +0000 (09:25 +0000)]
PR tree-optimization/78162: Reject negative offsets in store merging early
PR tree-optimization/78162
* gimple-ssa-store-merging.c (execute): Mark stores with bitpos < 0
as invalid.
* gcc.c-torture/compile/pr78162.c: New test.
From-SVN: r241778
Kyrylo Tkachov [Wed, 2 Nov 2016 08:57:08 +0000 (08:57 +0000)]
[AArch64] Add function comments to some prologue/epilogue helpers
* config/aarch64/aarch64.c (aarch64_register_saved_on_entry): Add
function comment.
(aarch64_next_callee_save): Likewise.
(aarch64_pushwb_single_reg): Likewise.
(aarch64_gen_storewb_pair): Likewise.
(aarch64_push_regs): Likewise.
(aarch64_gen_loadwb_pair): Likewise.
(aarch64_pop_regs): Likewise.
(aarch64_gen_store_pair): Likewise.
(aarch64_gen_load_pair): Likewise.
(aarch64_save_callee_saves): Likewise.
(aarch64_restore_callee_saves): Likewise.
From-SVN: r241777
Richard Biener [Wed, 2 Nov 2016 08:29:48 +0000 (08:29 +0000)]
re PR tree-optimization/78035 (Inconsistency between address comparison and alias analysis)
2016-11-02 Richard Biener <rguenther@suse.de>
PR tree-optimization/78035
PR tree-optimization/77964
* gimple-pretty-print.c (pp_points_to_solution): Print
vars_contains_interposable.
* tree-ssa-alias.c: Include varasm.h.
(ptrs_compare_unequal): Check vars_contains_interposable and
decl_binds_to_current_def_p.
(dump_points_to_solution): Dump vars_contains_interposable.
* tree-ssa-alias.h (struct pt_solution): Add vars_contains_interposable
flag.
* tree-ssa-structalias.c: Include varasm.h.
(set_uids_in_ptset): Record whether vars contains a
not decl_binds_to_current_def_p variable in vars_contains_interposable.
(ipa_escaped_pt): Update initializer.
* gcc.target/i386/pr78035.c: New testcase.
From-SVN: r241776
Richard Biener [Wed, 2 Nov 2016 08:13:29 +0000 (08:13 +0000)]
re PR middle-end/78047 (Chromium apparently gets miscompiled)
2016-11-02 Richard Biener <rguenther@suse.de>
PR tree-optimization/78047
* tree-ssa-structalias.c (push_fields_onto_fieldstack): Initialize
fake field at offset zero conservatively regarding to may_have_pointers.
From-SVN: r241775
Richard Biener [Wed, 2 Nov 2016 08:11:48 +0000 (08:11 +0000)]
tree-vrp.c (evrp_dom_walker::before_dom_children): Call infer_value_range on stmt ops and update value-ranges.
2016-11-02 Richard Biener <rguenther@suse.de>
* tree-vrp.c (evrp_dom_walker::before_dom_children): Call
infer_value_range on stmt ops and update value-ranges.
Dump visited stmts and blocks.
(evrp_dom_walker::push_value_range): Dump changes.
(evrp_dom_walker::pop_value_range): Likewise.
(evrp_dom_walker::try_find_new_range): Avoid noop changes.
* gcc.dg/tree-ssa/vrp111.c: New testcase.
* gcc.dg/tree-ssa/pr20702.c: Disable EVRP.
* gcc.dg/tree-ssa/pr21086.c: Likewise.
* gcc.dg/tree-ssa/pr58480.c: Likewise.
* gcc.dg/tree-ssa/vrp08.c: Likewise.
From-SVN: r241774
Trevor Saunders [Wed, 2 Nov 2016 03:46:17 +0000 (03:46 +0000)]
remove cast from prev_nonnote_insn_bb
gcc/ChangeLog:
2016-11-01 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* emit-rtl.c (prev_nonnote_insn_bb): Change argument type to
rtx_insn *.
* rtl.h (prev_nonnote_insn_bb): Adjust prototype.
From-SVN: r241773
Trevor Saunders [Wed, 2 Nov 2016 03:46:10 +0000 (03:46 +0000)]
remove cast in delete_insn_chain
gcc/ChangeLog:
2016-11-01 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* cfgrtl.c (delete_insn_chain): Change argument type to rtx_insn *
and adjust for that.
* cfgrtl.h (delete_insn_chain): Adjust prototype.
From-SVN: r241772
Trevor Saunders [Wed, 2 Nov 2016 03:45:59 +0000 (03:45 +0000)]
remove cast to rtx_insn * in remove_note
gcc/ChangeLog:
2016-11-01 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* config/rl78/rl78.c (gen-and_emit_move): Change argument type
to rtx_insn *.
(transcode_memory_rtx): Likewise.
(move_to_acc): Likewise.
(move_from_acc): Likewise.
(move_acc_to_reg): Likewise.
(move_to_x): Likewise.
(move_to_hl): Likewise.
(move_to_de): Likewise.
* config/rs6000/rs6000.c (emit_frame_save): Likewise.
(rs6000_emit_savres_rtx): Likewise.
(rs6000_emit_prologue): Likewise.
* reorg.c (update_reg_unused_notes): Likewise.
* rtl.h (remove_note): Adjust prototype.
* rtlanal.c (remove_note): Make argument type rtx_insn *.
From-SVN: r241771
Trevor Saunders [Wed, 2 Nov 2016 03:45:45 +0000 (03:45 +0000)]
split up some variables to use rtx_insn * more
gcc/ChangeLog:
2016-11-01 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* config/alpha/alpha.c (alpha_legitimize_address_1): Split up
variables so some can be rtx_insn *.
(alpha_emit_xfloating_libcall): Likewise.
* config/mips/mips.c (mips_call_tls_get_addr): Likewise.
(mips_legitimize_tls_address): Likewise.
* optabs.c (expand_binop): Likewise.
* reload1.c (gen_reload): Likewise.
From-SVN: r241770
Trevor Saunders [Wed, 2 Nov 2016 03:45:29 +0000 (03:45 +0000)]
split up the trial variable in reorg.c:relax_delay_slots to use rtx_insn * more
gcc/ChangeLog:
2016-11-01 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* reorg.c (relax_delay_slots): Split up the trial variable.
From-SVN: r241769
Trevor Saunders [Wed, 2 Nov 2016 03:44:50 +0000 (03:44 +0000)]
use rtx_insn * in various places where it is obvious
gcc/ChangeLog:
2016-11-01 Trevor Saunders <tbsaunde+gcc@tbsaunde.org>
* config/arc/arc.c (arc_emit_call_tls_get_addr): Make the type
of variables rtx_insn *.
* config/arm/arm.c (arm_call_tls_get_addr): Likewise.
(legitimize_tls_address): Likewise.
* config/bfin/bfin.c (hwloop_optimize): Likewise.
(bfin_gen_bundles): Likewise.
* config/c6x/c6x.c (reorg_split_calls): Likewise.
(c6x_reorg): Likewise.
* config/frv/frv.c (frv_reorder_packet): Likewise.
* config/i386/i386.c (ix86_split_idivmod): Likewise.
* config/ia64/ia64.c (ia64_expand_compare): Likewise.
* config/m32c/m32c.c (m32c_prepare_shift): Likewise.
* config/mn10300/mn10300.c: Likewise.
* config/rl78/rl78.c: Likewise.
* config/s390/s390.c (s390_fix_long_loop_prediction): Likewise.
* config/sh/sh-mem.cc (sh_expand_cmpstr): Likewise.
(sh_expand_cmpnstr): Likewise.
(sh_expand_strlen): Likewise.
(sh_expand_setmem): Likewise.
* config/sh/sh.md: Likewise.
* emit-rtl.c (emit_pattern_before): Likewise.
* except.c: Likewise.
* final.c: Likewise.
* jump.c: Likewise.
From-SVN: r241768
Josh Conner [Wed, 2 Nov 2016 02:10:45 +0000 (02:10 +0000)]
MAINTAINERS (Write After Approval): Update email address,
2016-11-01 Josh Conner <joshconner@google.com>
* MAINTAINERS (Write After Approval): Update email address,
From-SVN: r241767
Jason Merrill [Wed, 2 Nov 2016 02:10:38 +0000 (22:10 -0400)]
c-cppbuiltin.c (c_cpp_builtins): Update __cpp_inheriting_constructors.
* c-cppbuiltin.c (c_cpp_builtins): Update
__cpp_inheriting_constructors.
From-SVN: r241766
Jason Merrill [Wed, 2 Nov 2016 01:50:29 +0000 (21:50 -0400)]
Implement P0136R1, Rewording inheriting constructors.
gcc/c-family/
* c.opt (-fnew-inheriting-ctors): New.
* c-opts.c: Default to on for ABI 11+.
gcc/cp/
* call.c (enum rejection_reason_code): Add rr_inherited_ctor.
(inherited_ctor_rejection): New.
(add_function_candidate): Reject inherited ctors for copying.
(enforce_access): Use strip_inheriting_ctors.
(print_z_candidate): Likewise. Handle rr_inherited_ctor.
(convert_like_real): Avoid copying inheriting ctor parameters.
(build_over_call): Likewise. A base ctor inheriting from vbase
has no parms. Sorry about varargs.
(joust): A local constructor beats inherited with the same convs.
* class.c (add_method): Handle hiding inheriting ctors.
(one_inherited_ctor): Handle new semantics.
(add_implicitly_declared_members): Pass using_decl down.
(build_clone): A base ctor inheriting from vbase has no parms.
* cp-tree.h (DECL_INHERITED_CTOR): Store this instead of the base.
(SET_DECL_INHERITED_CTOR): Likewise.
(DECL_INHERITED_CTOR_BASE): Adjust.
* constexpr.c: Adjust.
* error.c (dump_function_decl): Decorate inheriting ctors.
* init.c (emit_mem_initializers): Suppress access control in
inheriting ctor.
* mangle.c (write_special_name_constructor): Handle new inheriting
ctor mangling.
* method.c (strip_inheriting_ctors, inherited_ctor_binfo)
(ctor_omit_inherited_parms, binfo_inherited_from): New.
(synthesized_method_walk): Use binfo_inherited_from. Suppress
access control in inheriting ctor.
(deduce_inheriting_ctor): Deleted if ambiguous ctor inheritance.
(maybe_explain_implicit_delete): Explain ambigous ctor inheritance.
(add_one_base_init, do_build_copy_constructor): Adjust.
(locate_fn_flags, explain_implicit_non_constexpr): Adjust.
(implicitly_declare_fn): Adjust.
(get_inherited_ctor): Remove.
* name-lookup.c (do_class_using_decl): Check for indirect ctor
inheritance.
* optimize.c (cdtor_comdat_group): Adjust for new mangling.
(maybe_clone_body): Handle omitted parms in base clone.
(maybe_thunk_body): Don't thunk if base clone omits parms.
* pt.c (tsubst_decl): Adjust.
(instantiate_template_1): Suppress access control in inheriting
ctor.
(fn_type_unification): Do deduction with inherited ctor.
* tree.c (special_function_p): Adjust.
gcc/
* tree-inline.c (copy_tree_body_r): Only copy the taken branch of
a COND_EXPR with constant condition.
libiberty/
* cp-demangle.c (d_ctor_dtor_name): Handle inheriting constructor.
From-SVN: r241765
GCC Administrator [Wed, 2 Nov 2016 00:16:21 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r241764
David Edelsohn [Tue, 1 Nov 2016 23:31:44 +0000 (23:31 +0000)]
* gfortran.dg/pr70937.f90: require-effective-target lto.
From-SVN: r241761
Mark Wielaard [Tue, 1 Nov 2016 23:13:10 +0000 (23:13 +0000)]
libiberty: Fix memory leak in ada_demangle when symbol cannot be demangled.
When a symbol cannot be demangled in ada_demangle a new demangled VEC
will be allocated without deleting the demangled VEC already in use.
Running testsuite/test-demangle under valgrind will show the leak for
this entry in testsuite/demangle-expected:
# Elaborated flag (not demangled)
--format=gnat
x_E
<x_E>
11 bytes in 1 blocks are definitely lost in loss record 1 of 1
at 0x4C27BE3: malloc (vg_replace_malloc.c:299)
by 0x413FE7: xmalloc (xmalloc.c:148)
by 0x4025EC: ada_demangle (cplus-dem.c:930)
by 0x402C59: cplus_demangle (cplus-dem.c:892)
by 0x400FEC: main (test-demangle.c:317)
libiberty/ChangeLog:
* cplus-dem.c (ada_demangle): Initialize demangled to NULL and
XDELETEVEC demangled when unknown.
From-SVN: r241760
Jakub Jelinek [Tue, 1 Nov 2016 22:56:48 +0000 (23:56 +0100)]
dwarf2out.c (gen_variable_die): Remove again origin_die variable and its initialization.
* dwarf2out.c (gen_variable_die): Remove again origin_die variable
and its initialization.
From-SVN: r241759
Rainer Orth [Tue, 1 Nov 2016 22:20:58 +0000 (22:20 +0000)]
Fix dwarf2out.c non-HAVE_AS_LEB128 bootstrap failure
* dwarf2out.c (output_rnglists): Wrap basebuf, len in
HAVE_AS_LEB128.
From-SVN: r241758
Ian Lance Taylor [Tue, 1 Nov 2016 21:45:32 +0000 (21:45 +0000)]
libgo: fix GOARCH_PHYSPAGESIZE for ia64
From Andreas Schwab.
Reviewed-on: https://go-review.googlesource.com/32537
From-SVN: r241757
Thomas Koenig [Tue, 1 Nov 2016 21:16:46 +0000 (21:16 +0000)]
re PR fortran/78178 (ICE in WHERE statement with diagnostic)
2016-11-01 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/78178
* match.c (match_simple_where): Fill in locus for assigment
in simple WHERE statement.
2016-11-01 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/69544
* gfortran.dg/where_6.f90: New test.
From-SVN: r241756
Jakub Jelinek [Tue, 1 Nov 2016 18:35:06 +0000 (19:35 +0100)]
dwarf2out.c (add_name_and_src_coords_attributes): Add NO_LINKAGE_NAME argument, don't call add_linkage_name if it is true.
* dwarf2out.c (add_name_and_src_coords_attributes): Add NO_LINKAGE_NAME
argument, don't call add_linkage_name if it is true.
(gen_variable_die): For C++ inline static data members, consider the
initial call when old_die is NULL to be declaration and call
add_name_and_src_coords_attributes in that case with true as
NO_LINKAGE_NAME. Add DW_AT_inline attribute if needed.
(gen_member_die): For C++ inline static data members, emit a
definition DIE right away in DW_TAG_compile_unit context.
cp/
* cp-objcp-common.c (cp_decl_dwarf_attribute): Handle DW_AT_inline.
testsuite/
* g++.dg/debug/dwarf2/inline-var-1.C: New test.
From-SVN: r241753
John David Anglin [Tue, 1 Nov 2016 18:15:57 +0000 (18:15 +0000)]
re PR target/78166 (hash.c:1887:1: error: unrecognizable insn)
PR target/78166
* config/pa/pa.md: Add new shift/add patterns to handle
(plus (mult (reg) (mem_shadd_operand)) (reg)) source operand.
From-SVN: r241749
Max Filippov [Tue, 1 Nov 2016 17:16:33 +0000 (17:16 +0000)]
xtensa: Fix PR target/78118
It started failing after the following commit:
32e90dc6a0cda45 ("PR
rtl-optimization/61047").
The change that made xtensa backend go ICE looks completely unrelated,
and indeed, the issue is caused by the side effect of
compute_frame_size() function call hidden in the
INITIAL_ELIMINATION_OFFSET macro. This call updates the value of the
xtensa_current_frame_size static variable, used in "return" instruction
predicate. Prior to the change the value of xtensa_current_frame_size was
set to 0 after the end of epilogue generation, which enabled the "return"
instruction for the CALL0 ABI, but after the change the additional
INITIAL_ELIMINATION_OFFSET calls make xtensa_current_frame_size non-zero
and "return" pattern unavailable.
Get rid of the global xtensa_current_frame_size and
xtensa_callee_save_size variables by moving them into the
machine_function structure. Implement predicate for the "return" pattern
as a function. Don't communicate completion of epilogue generation
through zeroing of xtensa_current_frame_size, add explicit epilogue_done
variable to the machine_function structure. Don't update stack frame
layout after the completion of reload.
2016-11-01 Max Filippov <jcmvbkbc@gmail.com>
gcc/
* config/xtensa/xtensa-protos.h
(xtensa_use_return_instruction_p): New prototype.
* config/xtensa/xtensa.c (xtensa_current_frame_size,
xtensa_callee_save_size): Remove.
(struct machine_function): Add new fields: current_frame_size,
callee_save_size, frame_laid_out and epilogue_done.
(compute_frame_size, xtensa_expand_prologue,
xtensa_expand_epilogue): Replace xtensa_callee_save_size with
cfun->machine->callee_save_size and xtensa_current_frame_size
with cfun->machine->current_frame_size.
(compute_frame_size): Update cfun->machine->frame_laid_out and
don't update frame layout after reload completion.
(xtensa_expand_epilogue): Set cfun->machine->epilogue_done
instead of zeroing xtensa_current_frame_size.
(xtensa_use_return_instruction_p): New function.
* config/xtensa/xtensa.h (xtensa_current_frame_size): Remove
declaration.
(INITIAL_ELIMINATION_OFFSET): Use return value of
compute_frame_size instead of xtensa_current_frame_size value.
* config/xtensa/xtensa.md ("return" pattern): Use new predicate
function xtensa_use_return_instruction_p instead of inline code.
From-SVN: r241748
Jakub Jelinek [Tue, 1 Nov 2016 16:54:49 +0000 (17:54 +0100)]
tree.h (BLOCK_IN_COLD_SECTION_P): Define.
* tree.h (BLOCK_IN_COLD_SECTION_P): Define.
* final.c (final_scan_insn): Set BLOCK_IN_COLD_SECTION_P.
* dwarf2out.c (rnglist_idx): New variable.
(struct dw_ranges): Add label, idx and maybe_new_sec fields.
(DEBUG_RNGLISTS_SECTION): Define.
(ranges_base_label): New variable.
(size_of_die) <case dw_val_class_range_list>: If using
DW_FORM_rnglistx, count size of uleb128 of range list index.
(value_format) <case dw_val_class_range_list>: For
-gdwarf-5 -gsplit-dwarf return DW_FORM_rnglistx.
(output_range_list_offset): Handle -gdwarf-5 .debug_rnglists
offsets. Multiply dwarf < 5 offsets by 2 * DWARF_ADDR_SIZE.
(add_ranges_num): Remove useless prototype. Don't multiply
by 2 * DWARF2_ADDR_SIZE. Add maybe_new_sec argument, adjust
for new fields added to dw_ranges struct.
(add_ranges): Add maybe_new_sec argument and pass it
through to add_ranges_num.
(note_rnglist_head): New function.
(add_ranges_by_labels): Pass true as maybe_new_sec to
add_ranges_num, call note_rnglist_head on the head of the list.
(output_ranges): Add function comment. Switch to
.debug_ranges section here and emit .Ldebug_ranges0 label.
(index_rnglists, output_rnglists): New functions.
(gen_subprogram_die): Formatting fixes.
(add_high_low_attributes): Don't divide offsets
by 2 * DWARF2_ADDR_SIZE. Call note_rnglist_head on the
first list element or when pointing into the middle of
a list. Pass true as second argument to add_ranges on the
first block fragment after cold/hot section switch.
(init_sections_and_labels): For -gdwarf-5 use .debug_rnglists
section instead of .debug_ranges. Initialize
ranges_base_label if -gdwarf-5 -gsplit-dwarf.
(dwarf2out_finish): For -gdwarf-5 -gsplit-dwarf call
index_rnglists and add DW_AT_rnglists_base attr. Don't switch
to dwarf_ranges_section here or emit .Ldebug_ranges0 label.
Call output_rnglists for -gdwarf-5.
(dwarf2out_c_finalize): Clear rnglist_idx.
From-SVN: r241747
Jakub Jelinek [Tue, 1 Nov 2016 16:47:50 +0000 (17:47 +0100)]
hashtab.h: Use standard GPLv3 with runtime exception boilerplate.
* hashtab.h: Use standard GPLv3 with runtime exception
boilerplate.
From-SVN: r241746
Thomas Koenig [Tue, 1 Nov 2016 16:18:18 +0000 (16:18 +0000)]
re PR fortran/69544 (Internal compiler error with -Wall and where)
2016-11-01 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/69544
* match.c (gfc_match_where): Fill in locus for assigment
in simple WHERE statement.
2016-11-01 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/69544
* gfortran.dg/where_5.f90: New test.
From-SVN: r241745
Fritz Reese [Tue, 1 Nov 2016 15:29:51 +0000 (15:29 +0000)]
Mark fallthrough cases with gcc_fallthrough.
* gcc/combine.c (simplify_compare_const): Add gcc_fallthrough.
From-SVN: r241744
Ian Lance Taylor [Tue, 1 Nov 2016 14:07:43 +0000 (14:07 +0000)]
runtime: recreate function called by cgo -gccgo
When using cgo -gccgo calls to C.GoString, C.GoStringN, and C.GoBytes
are turned into calls to __go_byte_array_to_string and
__go_string_to_byte_array. Those functions were removed when the string
code was copied from Go 1.7, but we still need them for cgo. While cgo
should be updated, old versions will exist for some time.
Reviewed-on: https://go-review.googlesource.com/32474
From-SVN: r241743
Ian Lance Taylor [Tue, 1 Nov 2016 13:54:21 +0000 (13:54 +0000)]
libgo: only rebuild package if dependent .gox has changed
Use mvifdiff and stamp files to track whether a .gox file has changed.
When package A depends on package B, and we rebuild package B, only
rebuild package A if package B's .gox file changes. This is safe
because when package A imports package B it only reads package B's .gox
file. This means that changes that do not affect export information
will not cause dependent packages to be recompiled.
Reviewed-on: https://go-review.googlesource.com/32476
From-SVN: r241742
Ian Lance Taylor [Tue, 1 Nov 2016 13:50:03 +0000 (13:50 +0000)]
libgo: minor Makefile improvements
Suggested by Ralph Corderoy.
Reviewed-on: https://go-review.googlesource.com/32414
From-SVN: r241741
Ian Lance Taylor [Tue, 1 Nov 2016 13:46:10 +0000 (13:46 +0000)]
re PR go/78145 (Several go.test tests fail with error: integer constant overflow on 32bit targets)
PR go/78145
compiler: don't put print/println constants into temporaries
It's not necessary, and it breaks setting their type to int64/uint64
when appropriate.
This fixes GCC PR 78145.
Reviewed-on: https://go-review.googlesource.com/32475
From-SVN: r241740
Jason Merrill [Tue, 1 Nov 2016 13:41:50 +0000 (09:41 -0400)]
* class.c (declared_access): Split out from handle_using_decl.
From-SVN: r241739
Joseph Myers [Tue, 1 Nov 2016 12:52:49 +0000 (12:52 +0000)]
* es.po: Update.
From-SVN: r241737
Bilyan Borisov [Tue, 1 Nov 2016 12:48:32 +0000 (12:48 +0000)]
arm-c.c (arm_cpu_builtins): New macro definition.
gcc/
2016-09-30 Bilyan Borisov <bilyan.borisov@arm.com>
Tamar Christina <tamar.christina@arm.com>
* config/arm/arm-c.c (arm_cpu_builtins): New macro definition.
* config/arm/arm_neon.h (vmaxnm_f32): New intrinsinc.
(vmaxnmq_f32): Likewise.
(vminnm_f32): Likewise.
(vminnmq_f32): Likewise.
* config/arm/arm_neon_builtins.def (vmaxnm): New builtin.
(vminnm): Likewise.
* config/arm/neon.md (neon_<fmaxmin_op><mode>, VCVTF): New
expander.
gcc/testsuite/
2016-09-30 Bilyan Borisov <bilyan.borisov@arm.com>
* gcc.target/arm/simd/vmaxnm_f32_1.c: New.
* gcc.target/arm/simd/vmaxnmq_f32_1.c: Likewise.
* gcc.target/arm/simd/vminnm_f32_1.c: Likewise.
* gcc.target/arm/simd/vminnmq_f32_1.c: Likewise.
Co-Authored-By: Tamar Christina <tamar.christina@arm.com>
From-SVN: r241736
Eric Botcazou [Tue, 1 Nov 2016 09:36:04 +0000 (09:36 +0000)]
Minor tweaks
From-SVN: r241734
Uros Bizjak [Tue, 1 Nov 2016 09:03:21 +0000 (10:03 +0100)]
target-supports.exp: Normalize order of i?86 and x86_64 targets.
* lib/target-supports.exp: Normalize order of i?86 and x86_64 targets.
Whitespace fixes.
(check_effective_target_vect_cmdline_needed): Check
is-effective-target ia32 for x86 targets.
(check_effective_target_vect_simd_clones): Simplify condition.
(check_effective_target_vect_double): Ditto.
(check_effective_target_vect_aligned_arrays): Check
is-effective-target ia32 for x86 targets. Simplify condition.
(check_effective_target_vect_multiple_sizes): Simplify condition.
(check_effective_target_sqrt_insn): Add i?86-*-* target.
(check_effective_target_sync_int_128): Simplify condition.
(check_effective_target_sync_int_128_runtime): Ditto.
(check_effective_target_sync_long_long_runtime): Ditto.
(check_effective_target_divmod): Add i?86-*-* target.
From-SVN: r241733
Michael Meissner [Tue, 1 Nov 2016 00:41:30 +0000 (00:41 +0000)]
vsx.md (VSX_EXTRACT_FL): New iterator for all binary floating point types supported by the hardware...
[gcc]
2016-10-31 Michael Meissner <meissner@linux.vnet.ibm.com>
* config/rs6000/vsx.md (VSX_EXTRACT_FL): New iterator for all
binary floating point types supported by the hardware except for
double.
(vsx_xvcvsxwdp_df): Provide scalar result alternative to the
vector instruction for optimizing extracting a SImode from a
V4SImode vector and converting it to floating point.
(vsx_xvcvuxwdp_df): Likewise.
(vsx_extract_si): On ISA 3.0, allow extract target and temporary
registers to be any VSX register. Move stores to the end of the
constraints.
(vsx_extract_si_<uns>float_df): New combiner pattern and splitter
to optimize extracting a SImode from a V4SImode vector and
converting it to a binary floating point type supported by the
hardware. Use the vector converts instead of extracting the
element, sign extending it, and then converting it to double.
Other floating point types than double first convert to double,
then the double is converted to that type.
(vsx_extract_si_<uns>float_<mode>): Likewise.
[gcc/testsuite]
2016-10-31 Michael Meissner <meissner@linux.vnet.ibm.com>
* gcc.target/powerpc/vsx-extract-4.c: New test.
* gcc.target/powerpc/vsx-extract-5.c: Likewise.
From-SVN: r241731
GCC Administrator [Tue, 1 Nov 2016 00:16:20 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r241730
Andrew Pinski [Mon, 31 Oct 2016 22:20:52 +0000 (22:20 +0000)]
driver-aarch64.c (host_detect_local_cpu): Rewrite handling of part num to handle the case where multiple implementers...
2016-10-31 Andrew Pinski <apinski@cavium.com>
* config/aarch64/driver-aarch64.c (host_detect_local_cpu):
Rewrite handling of part num to handle the case where
multiple implementers share the same part num.
From-SVN: r241726
Jan Kratochvil [Mon, 31 Oct 2016 21:46:33 +0000 (21:46 +0000)]
dwarf2out.c (DWARF_COMPILE_UNIT_HEADER_SIZE): Adjust for -gdwarf-5.
* dwarf2out.c (DWARF_COMPILE_UNIT_HEADER_SIZE): Adjust for -gdwarf-5.
(DWARF_COMDAT_TYPE_UNIT_HEADER_SIZE): Likewise.
Co-Authored-By: Jakub Jelinek <jakub@redhat.com>
From-SVN: r241725
Jakub Jelinek [Mon, 31 Oct 2016 21:45:51 +0000 (22:45 +0100)]
dwarf2out.c (dwarf_AT): Handle DW_AT_dwo_name.
* dwarf2out.c (dwarf_AT): Handle DW_AT_dwo_name.
(use_debug_types): Adjust comment for DWARF5 DW_UT_type units.
(new_die): Handle DW_TAG_skeleton_unit like DW_TAG_compile_unit.
(is_cu_die, is_unit_die): Likewise.
(should_move_die_to_comdat, break_out_comdat_types): Adjust
comments for DWARF5 DW_UT_type units.
(output_compilation_unit_header): Add UT argument, output
start of DWARF5 .debug_info section header.
(output_comp_unit): Add dwo_id argument. Adjust
output_compilation_unit_header caller, for DW_UT_split_compile
emit dwo_id field, otherwise padding1. Emit padding2 field.
(add_top_level_skeleton_die_attrs): Add DW_AT_dwo_name
rather than DW_AT_GNU_dwo_name attr for -gdwarf-5.
(output_skeleton_debug_sections): Add dwo_id argument, for
-gdwarf-5 emit DWARF 5 DW_UT_skeleton header.
(output_comdat_type_unit): For -gdwarf-5 emit .debug_info
DW_UT_type or DW_UT_split_type units rather than .debug_types.
(dwarf2out_finish): Use DW_TAG_skeleton_unit rather than
DW_TAG_compile_unit for skeleton unit die. Don't add
DW_AT_GNU_dwo_id attributes for -gdwarf-5, instead pass checksum
address to output_comp_unit and output_skeleton_debug_sections.
From-SVN: r241724
Jakub Jelinek [Mon, 31 Oct 2016 21:44:53 +0000 (22:44 +0100)]
dwarf2out.c (debug_line_str_section): New variable.
* dwarf2out.c (debug_line_str_section): New variable.
(debug_line_str_hash): Likewise.
(DEBUG_LINE_STR_SECTION): Define.
(set_indirect_string): Handle DW_FORM_line_strp like
DW_FORM_strp.
(find_string_form): Fix up formatting.
(size_of_die): Handle DW_FORM_line_strp like DW_FORM_strp.
Fix up indentation.
(output_die): Handle DW_FORM_line_strp.
(DWARF5_USE_DEBUG_LINE_STR): Define.
(output_line_string): New function.
(output_file_names): Add -gdwarf-5 support.
(output_line_info): Likewise.
(init_sections_and_labels): Initialize debug_line_str_section.
(output_indirect_string): Change 2nd argument from void *
to enum dwarf_form form, compare with form rather than
DW_FORM_strp.
(output_indirect_strings): Pass DW_FORM_strp to
output_indirect_string traversion.
(dwarf2out_finish): Output .debug_line_str strings.
(dwarf2out_c_finalize): Clear debug_line_str_section and
debug_line_str_hash.
From-SVN: r241723
Tom Tromey [Mon, 31 Oct 2016 20:08:44 +0000 (20:08 +0000)]
re PR debug/77315 (emit DW_OP_form_tls_address)
PR debug/77315:
* dwarf2out.c (mem_loc_descriptor): Use DW_OP_form_tls_address.
(resolve_args_picking_1): Move DW_OP_form_tls_address case next to
DW_OP_GNU_push_tls_address case.
(loc_list_from_tree_1): Use DW_OP_form_tls_address.
From-SVN: r241721
Jerry DeLisle [Mon, 31 Oct 2016 19:59:04 +0000 (19:59 +0000)]
re PR fortran/54679 (Erroneous "Expected P edit descriptor" in conjunction with L descriptor)
2016-10-31 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/54679
* io.c (check_format): Adjust checks for FMT_L to treat a zero
width as an extension, giving warnings or error as appropriate.
Improve messages.
PR libgfortran/54679
* io/format.c (parse_format_list): Adjust checks for FMT_L to
treat a zero width as an extension, giving warnings or error
as appropriate. Improve messages.
PR fortran/54679
* gfortran.dg/fmt_l.f90: Update test.
* gfortran.dg/fmt_l0.f90: New test.
From-SVN: r241720
Jakub Jelinek [Mon, 31 Oct 2016 19:35:47 +0000 (20:35 +0100)]
dwarf2out.h (struct dw_loc_descr_node): Adjust comment for frame_offset_rel bit.
* dwarf2out.h (struct dw_loc_descr_node): Adjust comment
for frame_offset_rel bit.
(struct array_descr_info): Add rank field.
* dwarf2out.c (struct loc_descr_context): Add placeholder_arg
and placeholder_seen fields.
(resolve_args_picking_1): Handle also frame_offset_rel DW_OP_dup
and DW_OP_over. Optimize DW_OP_pick 0 into DW_OP_dup and
DW_OP_pick 1 into DW_OP_over.
(function_to_dwarf_procedure, type_byte_size, field_byte_offset,
gen_variant_part): Clear placeholder_{arg,seen}.
(loc_list_from_tree_1): Drop const from context argument.
Handle integral PLACEHOLDER_EXPR if context->placeholder_arg.
(loc_list_for_address_of_addr_expr_of_indirect_ref,
loc_list_from_tree, loc_descriptor_from_tree): Drop const from
context argument.
(add_scalar_info): Drop const from context argument. Handle
context->placeholder_arg.
(add_bound_info): Drop const from context argument.
(gen_descr_array_type_die): Drop const from ctx variable.
Initialize placeholder_arg and placeholder_seen. Add DW_AT_rank
attribute and use a single DW_TAG_generic_subrange instead of
7 DW_TAG_subrange_type for assumed rank arrays.
fortran/
* trans-types.c (gfc_get_array_descr_info): For -gdwarf-5 or
-gno-strict-dwarf, handle assumed rank arrays the way dwarf2out
expects.
ada/
* gcc-interface/misc.c (gnat_get_array_descr_info): Clear rank
field.
From-SVN: r241719
Jakub Jelinek [Mon, 31 Oct 2016 19:25:40 +0000 (20:25 +0100)]
dwarf2out.h (enum dw_val_class): Add dw_val_class_loclistsptr.
* dwarf2out.h (enum dw_val_class): Add dw_val_class_loclistsptr.
* dwarf2out.c (struct dw_loc_list_struct): Change emitted field
from bool to 1-bit uchar bitfield. Add num_assigned and
offset_emitted bitfields.
(dw_val_equal_p): Compare v.val_lbl_id rather than v.val_unsigned
for dw_val_class_lineptr and dw_val_class_macptr. Handle
dw_val_class_loclistsptr.
(new_addr_loc_descr): Fix up formatting.
(DEBUG_LOCLISTS_SECTION, DEBUG_DWO_LOCLISTS_SECTION): Define.
(add_AT_low_high_pc): Fix up formatting.
(add_AT_loclistsptr): New function.
(AT_lbl): Allow dw_val_class_loclistsptr.
(print_dw_val, attr_checksum, attr_checksum_ordered, same_dw_val_p):
Handle dw_val_class_loclistsptr.
(loc_list_idx): New variable.
(output_loclists_offsets, assign_location_list_indexes): New
functions.
(size_of_die): For dw_val_class_loc_list -gsplit-dwarf -gdwarf-5
add size_of_uleb128 of the index. Drop never used
dwarf_split_debug_info AT_index handling. Handle
dw_val_class_loclistsptr.
(value_format): Return DW_FORM_loclistsx for dw_val_class_loc_list
if -gsplit-dwarf -gdwarf-5. Handle dw_val_class_loclistsptr.
(output_loc_list): Handle DWARF 5 .debug_loclists* format.
(output_loc_list_offset): Handle -gsplit-dwarf -gdwarf-5
DW_FORM_loclistx indexes.
(output_attr_index_or_value): Fix up formatting. Don't handle
dw_val_class_loc_list here.
(output_die): Formatting fixes. Handle dw_val_class_loclistsptr.
For dw_val_class_loc_list call output_loc_list_offset rather than
output_attr_index_or_value.
(init_sections_and_labels): For -gdwarf-5 use .debug_loclists
or .debug_loclists.dwo section name for debug_loc_section.
(resolve_addr_in_expr): Formatting fix.
(index_location_lists): Likewise.
(dwarf2out_finish): If there are any location lists, for
-gsplit-dwarf -gdwarf-5 add DW_AT_loclists_base attribute. Call
index_location_lists only if have_location_lists. Call
assign_location_list_indexes for -gsplit-dwarf -gdwarf-5. Emit
.debug_loclists{,.dwo} section header for -gdwarf-5, for -gdwarf-5
-gsplit-dwarf also emit offset table.
From-SVN: r241718
Jakub Jelinek [Mon, 31 Oct 2016 17:22:30 +0000 (18:22 +0100)]
dwarf2out.c (DWARF_LARGEST_DATA_FORM_BITS): Define.
* dwarf2out.c (DWARF_LARGEST_DATA_FORM_BITS): Define.
(size_of_die, value_format, output_die): Use
DW_FORM_data16 for 128-bit dw_val_class_const_double or
dw_val_class_wide_int.
From-SVN: r241714
Jakub Jelinek [Mon, 31 Oct 2016 17:14:29 +0000 (18:14 +0100)]
dwarf2out.c (dwarf_op): Renamed to ...
* dwarf2out.c (dwarf_op): Renamed to ...
(dwarf_OP): ... this.
(convert_descriptor_to_mode, scompare_loc_descriptor,
minmax_loc_descriptor, typed_binop, mem_loc_descriptor,
implicit_ptr_descriptor, optimize_one_addr_into_implicit_ptr): Adjust
callers.
(dwarf_AT, dwarf_TAG): New functions.
(check_die): Disallow DW_AT_call_all_calls next to
DW_AT_GNU_all_call_sites.
(gen_call_site_die): Use dwarf_TAG and dwarf_AT with DWARF 5 tag
and attributes instead of the corresponding GNU tag and attributes.
(gen_subprogram_die): Likewise. Emit call site information even
for -gdwarf-5 -gstrict-dwarf. Replace DW_AT_GNU_defaulted with
DW_AT_defaulted in comment.
(resolve_addr): Handle DW_AT_call_origin attribute on
DW_TAG_call_site DIE like DW_AT_abstract_origin on
DW_TAG_GNU_call_site DIE.
From-SVN: r241713
Jakub Jelinek [Mon, 31 Oct 2016 17:12:56 +0000 (18:12 +0100)]
dwarf2out.c (dwarf_op): New function.
* dwarf2out.c (dwarf_op): New function.
(size_of_loc_descr): Handle DW_OP_{implicit_pointer,entry_value},
DW_OP_{const,regval,deref}_type and DW_OP_{convert,reinterpret}.
(output_loc_operands, output_loc_operands_raw): Likewise.
(resolve_args_picking_1, prune_unused_types_walk_loc_descr,
mark_base_types, hash_loc_operands, compare_loc_operands): Likewise.
(resolve_addr_in_expr): Likewise. Only punt for !dwarf_strict
if dwarf_version < 5.
(convert_descriptor_to_mode): Use dwarf_op (DW_OP_xxx) instead of
DW_OP_GNU_xxx.
(scompare_loc_descriptor, ucompare_loc_descriptor,
minmax_loc_descriptor, typed_binop, mem_loc_descriptor,
implicit_ptr_descriptor, optimize_one_addr_into_implicit_ptr,
optimize_location_into_implicit_ptr): Likewise. Only punt for
!dwarf_strict if dwarf_version < 5.
(string_cst_pool_decl): Adjust comment.
(non_dwarf_expression): Handle DW_OP_implicit_pointer.
From-SVN: r241712
Jakub Jelinek [Mon, 31 Oct 2016 17:10:30 +0000 (18:10 +0100)]
re PR c++/77886 (-Wimplicit-fallthrough: breaks duff's device (in function templates))
PR c++/77886
* pt.c (tsubst_expr) <case CASE_LABEL_EXPR> Copy over
FALLTHROUGH_LABEL_P flag to the new LABEL_DECL.
(tsubst_expr) <case LABEL_EXPR>: Likewise.
* g++.dg/warn/Wimplicit-fallthrough-2.C: New test.
From-SVN: r241711
Jakub Jelinek [Mon, 31 Oct 2016 17:08:36 +0000 (18:08 +0100)]
re PR c++/78089 (__builtin_shuffle parsing bug)
PR c++/78089
* parser.c (cp_parser_postfix_expression): Replace return statement in
the first switch with setting postfix_expression to the return
expression and break;.
* c-c++-common/builtin-shuffle-1.c: New test.
* g++.dg/cpp0x/addressof3.C: New test.
From-SVN: r241710
Jakub Jelinek [Mon, 31 Oct 2016 16:59:21 +0000 (17:59 +0100)]
dwarf2out.h (enum dw_val_class): Add dw_val_class_const_implicit...
* dwarf2out.h (enum dw_val_class): Add dw_val_class_const_implicit,
dw_val_class_unsigned_const_implicit and dw_val_class_file_implicit.
(struct dw_val_node): Add val_file_implicit field.
* dwarf2out.c (dw_val_equal_p, print_dw_val, attr_checksum,
attr_checksum_ordered, same_dw_val_p, size_of_die, value_format,
output_die): Handle dw_val_class_const_implicit,
dw_val_class_unsigned_const_implicit and dw_val_class_file_implicit.
(abbrev_die_table): Change into va_gc vec.
(abbrev_die_table_allocated, abbrev_die_table_in_use,
ABBREV_DIE_TABLE_INCREMENT): Remove.
(AT_int, AT_unsigned, AT_file): Allow dw_val_class_*_implicit.
(abbrev_opt_start, abbrev_usage_count, sorted_abbrev_dies): New
variables.
(build_abbrev_table): Adjust for abbrev_die_table being a va_gc vec.
If abbrev_opt_start, fill in abbrev_usage_count and abbrev_dies
vectors.
(die_abbrev_cmp, optimize_implicit_const, optimize_abbrev_table): New
functions.
(output_die_abbrevs): For DW_FORM_implicit_const emit sleb128 with
the implicit value.
(output_abbrev_section): Adjust for abbrev_die_table being a va_gc
vec.
(output_comp_unit): Initialize abbrev_opt_start if emitting the main
unit. Call optimize_abbrev_table.
(dwarf2out_init, dwarf2out_finish, dwarf2out_c_finalize): Adjust for
abbrev_die_table being a va_gc vec.
From-SVN: r241709
Ville Voutilainen [Mon, 31 Oct 2016 16:52:23 +0000 (18:52 +0200)]
Add tests for a const member and a reference member for launder.
* g++.dg/cpp1z/launder3.C: New.
* g++.dg/cpp1z/launder4.C: Likewise.
* g++.dg/cpp1z/launder5.C: Likewise.
* g++.dg/cpp1z/launder5.cc: Likewise.
* g++.dg/cpp1z/launder5.h: Likewise.
* g++.dg/cpp1z/launder6.C: Likewise.
* g++.dg/cpp1z/launder6.cc: Likewise.
* g++.dg/cpp1z/launder6.h: Likewise.
From-SVN: r241708
Jakub Jelinek [Mon, 31 Oct 2016 16:38:21 +0000 (17:38 +0100)]
re PR c++/77948 (Option processing of -std=c++11 -std=gnu++11 doesn't reset ext_numeric_literals)
PR c++/77948
* c.opt (fext-numeric-literals): Add Var and Init.
* c-opts.c (c_common_handle_option): Don't clear
cpp_opts->ext_numeric_literals for -std=c++{11,14,1z}.
(c_common_post_options): Clear it here if not set
explicitly.
* g++.dg/cpp0x/pr77948-1.C: New test.
* g++.dg/cpp0x/pr77948-2.C: New test.
* g++.dg/cpp0x/pr77948-3.C: New test.
* g++.dg/cpp0x/pr77948-4.C: New test.
* g++.dg/cpp0x/pr77948-5.C: New test.
* g++.dg/cpp0x/pr77948-6.C: New test.
From-SVN: r241707
Jakub Jelinek [Mon, 31 Oct 2016 16:36:53 +0000 (17:36 +0100)]
re PR tree-optimization/77860 (ICE in gimple_build_assign_1, at gimple.c:420)
PR tree-optimization/77860
* tree-ssa-reassoc.c (eliminate_using_constants): Handle
also integral complex and vector constants.
* gcc.dg/pr77860.c: New test.
From-SVN: r241706
Jakub Jelinek [Mon, 31 Oct 2016 16:32:20 +0000 (17:32 +0100)]
dwarf2out.c (dwarf2out_define, [...]): Replace DW_MACRO_GNU_* constants with corresponding DW_MACRO_* constants.
* dwarf2out.c (dwarf2out_define, dwarf2out_undef, output_macinfo_op,
optimize_macinfo_range, save_macinfo_strings): Replace
DW_MACRO_GNU_* constants with corresponding DW_MACRO_* constants.
(output_macinfo): Likewise. Emit .debug_macro* rather than
.debug_macinfo* even for -gstrict-dwarf -gdwarf-5.
(init_sections_and_labels): Use .debug_macro* labels rather than
.debug_macinfo* labels even for -gstrict-dwarf -gdwarf-5.
(dwarf2out_finish): Use DW_AT_macros instead of DW_AT_macro_info
or DW_AT_GNU_macros for -gdwarf-5.
From-SVN: r241705
Waldemar Brodkorb [Mon, 31 Oct 2016 15:04:21 +0000 (15:04 +0000)]
linux.h (UCLIBC_DYNAMIC_LINKER): Define.
2016-10-31 Waldemar Brodkorb <wbx@openadk.org>
* config/microblaze/linux.h (UCLIBC_DYNAMIC_LINKER): Define.
From-SVN: r241704
Carl Love [Mon, 31 Oct 2016 15:01:13 +0000 (15:01 +0000)]
Index...
Index: ChangeLog
===================================================================
--- ChangeLog (revision 241702)
+++ ChangeLog (working copy)
@@ -1,5 +1,10 @@
2016-10-27 Carl Love <cel@us.ibm.com>
+ * MAINTAINERS (Write After Approval): Fix my entry in the Write After
+ Approval list to make it alphabetical.
+
+2016-10-27 Carl Love <cel@us.ibm.com>
+
* MAINTAINERS (Write After Approval): Add myself.
2016-10-27 Andrew Burgess <andrew.burgess@embecosm.com>
Index: MAINTAINERS
===================================================================
--- MAINTAINERS (revision 241702)
+++ MAINTAINERS (working copy)
@@ -477,9 +477,9 @@
Gabor Loki <loki@inf.u-szeged.hu>
Sandra Loosemore <sandra@codesourcery.com>
Manuel López-Ibáñez <manu@gcc.gnu.org>
+Carl Love <cel@us.ibm.com>
Martin v. Löwis <loewis@informatik.hu-berlin.de>
H.J. Lu <hjl.tools@gmail.com>
-Carl Love <cel@us.ibm.com>
Christophe Lyon <christophe.lyon@st.com>
Luis Machado <luisgpm@br.ibm.com>
Ziga Mahkovec <ziga.mahkovec@klika.si>
From-SVN: r241703
Uros Bizjak [Mon, 31 Oct 2016 14:56:49 +0000 (15:56 +0100)]
alpha-passes.def: Swap pass_convert_to_eh_region_ranges and pass_shorten_branches positions.
* config/alpha/alpha-passes.def: Swap pass_convert_to_eh_region_ranges
and pass_shorten_branches positions.
From-SVN: r241702
Senthil Kumar Selvaraj [Mon, 31 Oct 2016 14:06:04 +0000 (14:06 +0000)]
Skip gcc.dg/lto/pr60449_0.c for avr
The testcase requires gettimeofday to be available for the target. The avr
target doesn't have an implementation, so the test always fails with a
linker error.
gcc/testsuite
2016-10-31 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
* gcc.dg/lto/pr60449_0.c: Skip for avr.
From-SVN: r241701
Jakub Jelinek [Mon, 31 Oct 2016 13:39:49 +0000 (14:39 +0100)]
re PR c++/77886 (-Wimplicit-fallthrough: breaks duff's device (in function templates))
PR c++/77886
* pt.c (tsubst_expr) <case CASE_LABEL_EXPR> Copy over
FALLTHROUGH_LABEL_P flag to the new LABEL_DECL.
(tsubst_expr) <case LABEL_EXPR>: Likewise.
* g++.dg/warn/Wimplicit-fallthrough-2.C: New test.
From-SVN: r241700
Le-Chun Wu [Mon, 31 Oct 2016 13:21:59 +0000 (13:21 +0000)]
Add -Wshadow=global -Wshadow=local and -Wshadow=compatible-local.
This patch from Le-Chun Wu adds two new shadow warning flags for
C and C++:
-Wshadow=local which warns if a local variable shadows another local
variable or parameter,
-Wshadow=compatible-local which warns if a local variable shadows
another local variable or parameter whose type is compatible with
that of the shadowing variable.
It is already on the google/main branch (Google ref 39127) and was
previously submitted by Diego Novillo and reviewed on
http://codereview.appspot.com/
4452058
I addressed the review comments and made the following changes:
- Add -Wshadow=global (the default alias for -Wshadow).
- Make the documented options -Wshadow=global, -Wshadow=local
and -Wshadow=compatible-local (with hidden undocumented aliases
-Wshadow-local and -Wshadow-compatible-local for compatibility).
- The -Wshadow=global, -Wshadow=local and -Wshadow=compatible-local
relationships are expressed in common.opt instead of in opts.c
and documented in invoke.texi.
- The "previous declaration" warnings were turned into notes and use
the (now) existing infrastructure instead of duplicating the warnings.
The testcases have been adjusted to expect the notes.
- The conditional change in name-lookup.c for non-locals (where we
don't want to change the warnings, but just check the global ones)
has been dropped.
- Use warning_at in c-decl.c (warn_if_shadowing).
gcc/ChangeLog:
2016-10-30 Le-Chun Wu <lcwu@google.com>
Mark Wielaard <mjw@redhat.com>
* doc/invoke.texi: Document Wshadow-local and Wshadow-compatible-local.
* common.opt (Wshadow=global): New option. Default for -Wshadow.
(Wshadow=local): New option.
(Wshadow-local): Hidden alias for -Wshadow=local.
(Wshadow=compatible-local): New option.
(Wshadow-compatible-local): Hidden alias for
-Wshadow=compatible-local.
* doc/invoke.texi: Document Wshadow=global, Wshadow=local and
Wshadow=compatible-local.
gcc/c/ChangeLog:
2016-10-30 Le-Chun Wu <lcwu@google.com>
Mark Wielaard <mjw@redhat.com>
* c-decl.c (warn_if_shadowing): Use the warning code corresponding
to the given -Wshadow= variant. Use warning_at.
gcc/cp/ChangeLog:
2016-10-30 Le-Chun Wu <lcwu@google.com>
Mark Wielaard <mjw@redhat.com>
* name-lookup.c (pushdecl_maybe_friend): When emitting a
shadowing warning, use the code corresponding to the
given -Wshadow= variant.
gcc/testsuite/ChangeLog
2016-10-30 Le-Chun Wu <lcwu@google.com>
Mark Wielaard <mjw@redhat.com>
* gcc.dg/Wshadow-compatible-local-1.c: New test.
* gcc.dg/Wshadow-local-1.c: Likewise.
* gcc.dg/Wshadow-local-2.c: Likewise.
* g++.dg/warn/Wshadow-compatible-local-1.C: Likewise.
* g++.dg/warn/Wshadow-local-1.C: Likewise.
* g++.dg/warn/Wshadow-local-2.C: Likewise.
Co-Authored-By: Mark Wielaard <mjw@redhat.com>
From-SVN: r241699
Richard Biener [Mon, 31 Oct 2016 12:52:23 +0000 (12:52 +0000)]
re PR lto/78129 (-Werror=suggest-final-types leads to -ENOSPC.)
2016-10-31 Richard Biener <rguenther@suse.de>
PR lto/78129
* lto.c (do_whole_program_analysis): Bail out after errors
from WPA analysis.
From-SVN: r241698
Bin Cheng [Mon, 31 Oct 2016 09:30:47 +0000 (09:30 +0000)]
tree-vect-slp.c (vect_get_and_check_slp_defs): New parameter SWAP.
* tree-vect-slp.c (vect_get_and_check_slp_defs): New parameter SWAP.
Check slp defs for COND_EXPR by swapping/inverting operands if the
new parameter SWAP indicates so.
(vect_build_slp_tree_1): New parameter SWAP. Check COND_EXPR stmt
is isomorphic to the first stmt via swapping/inverting. Store swap
information in the new parameter SWAP.
(vect_build_slp_tree): New local array SWAP and pass it to function
vect_build_slp_tree_1. Cleanup result handling code for function
call to vect_get_and_check_slp_defs. Skip operand swapping if the
order of operands has been fixed as indicated by SWAP[i].
From-SVN: r241697
Bin Cheng [Mon, 31 Oct 2016 09:27:31 +0000 (09:27 +0000)]
tree-vect-data-refs.c (vect_slp_analyze_node_dependences): Skip unnecessary data dependence check after visited store stmt.
* tree-vect-data-refs.c (vect_slp_analyze_node_dependences): Skip
unnecessary data dependence check after visited store stmt.
From-SVN: r241696
Bill Schmidt [Mon, 31 Oct 2016 03:04:59 +0000 (03:04 +0000)]
re PR tree-optimization/71915 (A missed opportunity for SLSR)
[gcc]
2016-10-30 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
PR tree-optimization/71915
PR tree-optimization/71490
* gimple-ssa-strength-reduction.c (struct slsr_cand_d): Add
stride_type field.
(find_basis_for_base_expr): Require stride types to match when
seeking a basis.
(alloc_cand_and_find_basis): Record the stride type.
(slsr_process_phi): Pass stride type to alloc_cand_and_find_basis.
(backtrace_base_for_ref): Pass types to legal_cast_p_1 rather than
the expressions having those types.
(slsr_process_ref): Pass stride type to alloc_cand_and_find_basis.
(create_mul_ssa_cand): Likewise.
(create_mul_imm_cand): Likewise.
(create_add_ssa_cand): Likewise.
(create_add_imm_cand): Likewise.
(legal_cast_p_1): Change interface to accept types rather than the
expressions having those types.
(legal_cast_p): Pass types to legal_cast_p_1.
(slsr_process_cast): Pass stride type to
alloc_cand_and_find_basis.
(slsr_process_copy): Likewise.
(dump_candidate): Display stride type when a cast exists.
(create_add_on_incoming_edge): Introduce a cast when necessary for
the stride type.
(analyze_increments): Change the code checking for invalid casts
to rely on the stride type, and update the documentation and
example. Change the code checking for pointer multiplies to rely
on the stride type.
(insert_initializers): Introduce a cast when necessary for the
stride type. Use the stride type for the type of the initializer.
[gcc/testsuite]
2016-10-30 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
PR tree-optimization/71915
PR tree-optimization/71490
* gcc.dg/tree-ssa/pr54245.c: Delete.
* gcc.dg/tree-ssa/slsr-8.c: Adjust for new optimization and
document why.
From-SVN: r241695