Jakub Jelinek [Thu, 31 May 2018 19:49:54 +0000 (21:49 +0200)]
re PR target/85984 (ICE in create_pseudo_cfg, at dwarf2cfi.c:2874)
PR target/85984
* bb-reorder.c (pass_partition_blocks::gate): Return false for
functions with naked attribute.
* gcc.target/i386/pr85984.c: New test.
From-SVN: r261037
Uros Bizjak [Thu, 31 May 2018 19:45:54 +0000 (21:45 +0200)]
re PR target/85591 (__builtin_cpu_is() is not detecting bdver2 with Model = 0x02)
PR target/85591
* config/i386/cpuinfo.c (get_amd_cpu): Return
AMDFAM15H_BDVER2 for AMDFAM15H model 0x2.
From-SVN: r261036
Jonathan Wakely [Thu, 31 May 2018 19:20:24 +0000 (20:20 +0100)]
PR libstdc++/78870 support std::filesystem on Windows
PR libstdc++/78870 support std::filesystem on Windows
* config.h.in: Regenerate.
* configure: Regenerate.
* configure.ac: Check for link, readlink and symlink.
* include/bits/fs_path.h (path::operator/=(const path&)): Move
definition out of class body.
(path::is_absolute(), path::_M_append(path)): Likewise.
(operator<<(basic_ostream, const path&)): Use std::quoted directly.
(operator>>(basic_istream, path&)): Likewise.
(u8path): Reorder definitions and fix Windows implementation.
(path::is_absolute()): Define inline and fix for Windows.
[!_GLIBCXX_FILESYSTEM_IS_WINDOWS] (path::operator/=(const path&)):
Define POSIX version inline.
(path::_M_append(path)): Define inline.
* include/experimental/bits/fs_path.h (path::is_absolute()): Move
definition out of class body.
(operator<<(basic_ostream, const path&)): Fix type of delimiter and
escape characters.
(operator>>(basic_istream, path&)): Likewise.
(path::is_absolute()): Define inline and fix for Windows.
* src/filesystem/dir-common.h (__gnu_posix): New namespace.
(__gnu_posix::char_type, __gnu_posix::DIR, __gnu_posix::dirent)
(__gnu_posix::opendir, __gnu_posix::readdir, __gnu_posix::closedir):
Define as adaptors for Windows functions/types or as
using-declarations for POSIX functions/types.
(_Dir_base, get_file_type): Qualify names to use declarations from
__gnu_posix namespace.
(_Dir_base::is_dor_or_dotdot): New helper functions.
* src/filesystem/dir.cc (_Dir, recursive_directory_iterator): Qualify
names to use declarations from __gnu_posix namespace.
* src/filesystem/ops-common.h (__gnu_posix): New nested namespace.
(__gnu_posix::open, __gnu_posix::close, __gnu_posix::stat_type)
(__gnu_posix::stat, __gnu_posix::lstat, __gnu_posix::mode_t)
(__gnu_posix::chmod, __gnu_posix::mkdir, __gnu_posix::getcwd)
(__gnu_posix::chdir, __gnu_posix::utimbuf, __gnu_posix::utime)
(__gnu_posix::rename, __gnu_posix::truncate, __gnu_posix::char_type):
Define as adaptors for Windows functions/types or as
using-declarations for POSIX functions/types.
(stat_type, do_copy_file): Qualify names to use declarations from
__gnu_posix namespace.
(do_space): Declare new function.
(make_file_type): Only use S_ISLNK if defined.
* src/filesystem/ops.cc (char_ptr, filesystem::canonical): Use
path::value_type not char.
(filesystem::copy, create_dir, filesystem::create_directory): Qualify
names to use declarations from __gnu_posix namespace.
(filesystem::create_hard_link): Check HAVE_LINK autoconf macro and
add implementation for Windows.
(filesystem::create_symlink): Check HAVE_SYMLINK autoconf macro.
(filesystem::current_path(error_code&)): Use __gnu_posix::getcwd.
[!_PC_PATH_MAX]: Don't use pathconf.
[PATH_MAX]: Use if defined.
(filesystem::current_path(const path&, error_code&))
(filesystem::equivalent, do_stat, filesystem::hard_link_count)
(filesystem::last_write_time, filesystem::permissions): Use names
from __gnu_posix.
(filesystem::read_symlink): Check HAVE_READLINK autoconf macro.
(filesystem::remove) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Add
implementation for Windows.
(filesystem::rename, filesystem::resize_file): Use names from
__gnu_posix.
(filesystem::space): Use do_space.
[_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Get absolute path to directory.
(filesystem::status, filesystem::symlink_status): Use names from
__gnu_posix.
(filesystem::temp_directory_path): Add implementation for Windows.
* src/filesystem/path.cc (dot): Define constant.
(path::replace_extension): Use dot.
(path::_M_find_extension): Likewise. Use path::string_type not
std::string.
(path::_M_split_cmpts): Use dot.
(filesystem_error::_M_get_what): Use u8string() not native().
* src/filesystem/std-dir.cc (_Dir, recursive_directory_iterator):
Qualify names to use declarations from __gnu_posix namespace.
* src/filesystem/std-ops.cc (filesystem::absolute(const path&)): Use
correct error_code.
(filesystem::absolute(const path&, error_code&)): Add implementation
for Windows.
(char_ptr, filesystem::canonical): Use path::value_type not char.
(do_copy_file): Use names from __gnu_posix.
[_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Do not use fchmod, fchmodat or
sendfile.
(filesystem::copy, create_dir, filesystem::create_directory): Qualify
names to use declarations from __gnu_posix namespace.
(filesystem::create_hard_link): Check HAVE_LINK autoconf macro and
add implementation for Windows.
(filesystem::create_symlink): Check HAVE_SYMLINK autoconf macro.
(filesystem::current_path(error_code&)): Use __gnu_posix::getcwd.
[!_PC_PATH_MAX]: Don't use pathconf.
[PATH_MAX]: Use if defined.
(filesystem::current_path(const path&, error_code&))
(filesystem::equivalent, do_stat, filesystem::hard_link_count)
(filesystem::last_write_time, filesystem::permissions): Use names
from __gnu_posix.
(filesystem::read_symlink): Check HAVE_READLINK autoconf macro.
(filesystem::remove) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Add
implementation for Windows.
(filesystem::rename, filesystem::resize_file): Use names from
__gnu_posix.
(do_space): Define.
(filesystem::space): Use do_space.
(filesystem::status, filesystem::symlink_status): Use names from
__gnu_posix.
(filesystem::temp_directory_path): Add implementation for Windows.
* src/filesystem/std-path.cc
[_GLIBCXX_FILESYSTEM_IS_WINDOWS] (path::operator/=(const path&)):
Define for Windows.
(dot): Define constant.
(path::replace_extension, is_dot): Use dot.
(path::lexically_normal): Check _M_type instead of calling
non-existent function.
(path::_M_find_extension): Use dot. Use path::string_type not
std::string.
(path::_M_split_cmpts): Use dot.
(filesystem_error::_M_get_what): Use u8string() not native().
* testsuite/27_io/filesystem/iterators/directory_iterator.cc: Do not
use symlinks.
* testsuite/27_io/filesystem/iterators/recursive_directory_iterator.cc:
Likewise.
* testsuite/27_io/filesystem/operations/absolute.cc: Use
__gnu_test::root_path() instead of "/" and add Windows-specific tests.
* testsuite/27_io/filesystem/operations/canonical.cc: Use
path::string() to get narrow string, not path::native().
* testsuite/27_io/filesystem/operations/copy.cc: Construct fstreams
with std::filesystem::path not std::basic_string.
* testsuite/27_io/filesystem/operations/copy_file.cc: Likewise.
* testsuite/27_io/filesystem/operations/exists.cc: Use
__gnu_test::root_path() instead of "/".
* testsuite/27_io/filesystem/operations/is_empty.cc: Construct
fstreams with std::filesystem::path not std::basic_string.
* testsuite/27_io/filesystem/operations/last_write_time.cc: Use
path::string() to get narrow string.
* testsuite/27_io/filesystem/operations/space.cc: Check results for
errors, expect sensible values otherwise.
* testsuite/27_io/filesystem/operations/temp_directory_path.cc: Add
helpers for adjusting the environment on Windows.
* testsuite/27_io/filesystem/path/append/path.cc: Test
Windows-specific behaviour.
* testsuite/27_io/filesystem/path/construct/format.cc: Fix creation
of path::string_type objects.
* testsuite/27_io/filesystem/path/construct/locale.cc: Compare native
string to wide string on Windows.
* testsuite/27_io/filesystem/path/decompose/root_directory.cc: Allow
for backslash as root-directory.
* testsuite/27_io/filesystem/path/decompose/stem.cc: Use
path::string() to get narrow string.
* testsuite/27_io/filesystem/path/itr/traversal.cc: Test Windows-style
paths.
* testsuite/27_io/filesystem/path/native/string.cc: Use string_type
not std::string.
* testsuite/27_io/filesystem/path/query/is_absolute.cc: Adjust for
different definintion of absolute paths on Windows.
* testsuite/experimental/filesystem/iterators/directory_iterator.cc:
Do not use symlinks.
* testsuite/experimental/filesystem/operations/absolute.cc: Test
Windows behaviour.
* testsuite/experimental/filesystem/operations/copy.cc: Construct
fstreams with NTCTS not std::basic_string.
* testsuite/experimental/filesystem/operations/copy_file.cc: Likewise.
* testsuite/experimental/filesystem/operations/exists.cc: Use
__gnu_test::root_path() instead of "/".
* testsuite/experimental/filesystem/operations/is_empty.cc: Construct
fstreams with NTCTS not std::basic_string.
* testsuite/experimental/filesystem/operations/last_write_time.cc:
Use path::string() to get narrow string.
* testsuite/experimental/filesystem/operations/space.cc: Use
__gnu_test::root_path() instead of "/".
* testsuite/experimental/filesystem/operations/temp_directory_path.cc:
Add helpers for adjusting the environment on Windows.
* testsuite/experimental/filesystem/path/append/path.cc: Use
path::string() to get narrow strings for comparisons.
* testsuite/experimental/filesystem/path/concat/path.cc: Likewise.
* testsuite/experimental/filesystem/path/decompose/root_directory.cc:
Likewise.
* testsuite/experimental/filesystem/path/decompose/stem.cc: Likewise.
* testsuite/experimental/filesystem/path/native/string.cc: Use
string_type not std::string.
* testsuite/experimental/filesystem/path/query/is_absolute.cc:
Adjust for different definintion of absolute paths on Windows.
* testsuite/util/testsuite_fs.h (__gnu_test::root_path()): New
function.
(__gnu_test::scoped_file): Construct fstreams with NTCTS not
std::basic_string.
From-SVN: r261034
Uros Bizjak [Thu, 31 May 2018 17:51:27 +0000 (19:51 +0200)]
sse.md (avx_vec_concat<mode>): Substitute concat_tg_mode mode attribute with xtg_mode.
* config/i386/sse.md (avx_vec_concat<mode>):
Substitute concat_tg_mode mode attribute with xtg_mode.
(<mask_codefor>avx512dq_broadcast<mode><mask_name>_1): Ditto.
(concat_tg_mode): Remove mode attribute.
From-SVN: r261031
Martin Sebor [Thu, 31 May 2018 17:04:43 +0000 (17:04 +0000)]
PR c/82063 - issues with arguments enabled by -Wall
gcc/c-family/ChangeLog:
PR c/82063
* c.opt (-Wno-alloc-size-larger-than): New option.
* doc/invoke.texi (-Walloc-size-larger-than): Update.
gcc/ChangeLog:
PR c/82063
* calls.c (alloc_max_size): Correct a logic error/typo.
Treat excessive arguments as infinite. Warn for invalid arguments.
gcc/testsuite/ChangeLog:
PR c/82063
* gcc.dg/Walloc-size-larger-than-1.c: New test.
* gcc.dg/Walloc-size-larger-than-10.c: New test.
* gcc.dg/Walloc-size-larger-than-11.c: New test.
* gcc.dg/Walloc-size-larger-than-12.c: New test.
* gcc.dg/Walloc-size-larger-than-13.c: New test.
* gcc.dg/Walloc-size-larger-than-14.c: New test.
* gcc.dg/Walloc-size-larger-than-15.c: New test.
* gcc.dg/Walloc-size-larger-than-16.c: New test.
* gcc.dg/Walloc-size-larger-than-17.c: New test.
* gcc.dg/Walloc-size-larger-than-2.c: New test.
* gcc.dg/Walloc-size-larger-than-3.c: New test.
* gcc.dg/Walloc-size-larger-than-4.c: New test.
* gcc.dg/Walloc-size-larger-than-5.c: New test.
* gcc.dg/Walloc-size-larger-than-6.c: New test.
* gcc.dg/Walloc-size-larger-than-7.c: New test.
* gcc.dg/Walloc-size-larger-than-8.c: New test.
* gcc.dg/Walloc-size-larger-than-9.c: New test.
* gcc.dg/Walloc-size-larger-than.c: New test.
From-SVN: r261030
H.J. Lu [Thu, 31 May 2018 15:37:22 +0000 (15:37 +0000)]
x86: Re-enable partial_reg_dependency and movx for Haswell
r254152 disabled partial_reg_dependency and movx for Haswell and newer
Intel processors. r258972 restored them for skylake-avx512. For Haswell,
movx improves performance. But partial_reg_stall may be better than
partial_reg_dependency in theory. We will investigate performance impact
of partial_reg_stall vs partial_reg_dependency on Haswell for GCC 9. In
the meantime, this patch restores both partial_reg_dependency and mox for
Haswell in GCC 8.
On Haswell, improvements for EEMBC benchmarks with
-mtune-ctrl=movx,partial_reg_dependency -Ofast -march=haswell
vs
-Ofast -mtune=haswell
are
automotive
=========
aifftr01 (default) - goodperf: Runtime improvement of 2.6% (time).
aiifft01 (default) - goodperf: Runtime improvement of 2.2% (time).
networking
=========
ip_pktcheckb1m (default) - goodperf: Runtime improvement of 3.8% (time).
ip_pktcheckb2m (default) - goodperf: Runtime improvement of 5.2% (time).
ip_pktcheckb4m (default) - goodperf: Runtime improvement of 4.4% (time).
ip_pktcheckb512k (default) - goodperf: Runtime improvement of 4.2% (time).
telecom
=========
fft00data_1 (default) - goodperf: Runtime improvement of 8.4% (time).
fft00data_2 (default) - goodperf: Runtime improvement of 8.6% (time).
fft00data_3 (default) - goodperf: Runtime improvement of 9.0% (time).
PR target/85829
* config/i386/x86-tune.def: Re-enable partial_reg_dependency
and movx for Haswell.
From-SVN: r261028
Chung-Lin Tang [Thu, 31 May 2018 14:10:10 +0000 (14:10 +0000)]
re PR middle-end/85879 (ICE in expand_debug_locations, at cfgexpand.c:5405)
Fix PR middle-end/85879
gcc/
* gimplify.c (gimplify_adjust_omp_clauses): Add 'remove = true'
when emitting error on private/firstprivate reductions.
* omp-low.c (lower_omp_target): Avoid reference-type processing
on pointers for firstprivate clause.
gcc/testsuite/
* gfortran.dg/goacc/pr77371-1.f90: New test.
* gfortran.dg/goacc/pr77371-2.f90: New test.
* gfortran.dg/goacc/pr85879.f90: New test.
Co-Authored-By: Cesar Philippidis <cesar@codesourcery.com>
From-SVN: r261025
Jonathan Wakely [Thu, 31 May 2018 12:18:19 +0000 (13:18 +0100)]
PR libstdc++/85951 for make_signed/make_unsigned for character types
Because the wide character types are neither signed integer types nor
unsigned integer types they need to be transformed to an integral type
of the correct size and the lowest rank (which is not necessarily the
underlying type). Reuse the helpers for enumeration types to select the
correct integer.
The refactoring of __make_unsigned_selector and __make_signed_selector
slightly reduces the number of template instantiations and so reduces
memory usage.
PR libstdc++/85951
* include/std/type_traits [_GLIBCXX_USE_C99_STDINT_TR1]: Do not define
uint_least16_t and uint_least32_t.
(__make_unsigned<wchar_t>): Define unconditionally.
(__make_unsigned_selector<_Tp, true, false>): Remove intermediate
typedefs.
(__make_unsigned_selector_base): New type to provide helper templates.
(__make_unsigned_selector<_Tp, false, true>): Reimplement using
__make_unsigned_selector_base helpers.
(__make_unsigned<char16_t>, __make_unsigned<char32_t>): Define.
(__make_signed_selector<_Tp, true, false>): Remove intermediate
typedefs.
(__make_signed<wchar_t>, __make_signed<char16_t>)
(__make_signed<char32_t>)): Define unconditionally.
* testsuite/20_util/make_signed/requirements/typedefs-3.cc: Check
wchar_t, char16_t and char32_t are transformed correctly.
* testsuite/20_util/make_signed/requirements/typedefs_neg.cc: Adjust
dg-error lineno.
* testsuite/20_util/make_unsigned/requirements/typedefs-3.cc: Check
wchar_t, char16_t and char32_t are transformed correctly.
* testsuite/20_util/make_unsigned/requirements/typedefs_neg.cc: Adjust
dg-error lineno.
From-SVN: r261023
Eric Botcazou [Thu, 31 May 2018 11:30:46 +0000 (11:30 +0000)]
stack_usage1.adb: Replace -fstack-usage with -Wstack-usage.
* gnat.dg/stack_usage1.adb: Replace -fstack-usage with -Wstack-usage.
* gnat.dg/stack_usage1b.adb: Likewise.
* gnat.dg/stack_usage1c.adb: Likewise.
* gnat.dg/stack_usage3.adb: Likewise.
* gnat.dg/stack_usage1_pkg.adb: Delete.
From-SVN: r261021
Eric Botcazou [Thu, 31 May 2018 11:20:34 +0000 (11:20 +0000)]
store_merging_10.c: Turn dg-do compile into dg-do run.
* gcc.dg/store_merging_10.c: Turn dg-do compile into dg-do run.
* gcc.dg/store_merging_11.c: Likewise.
* gcc.dg/store_merging_13.c: Likewise.
* gcc.dg/store_merging_14.c: Likewise.
* gcc.dg/store_merging_15.c: Likewise.
* gcc.dg/store_merging_16.c: Likewise. Remove local variable.
From-SVN: r261019
Pierre-Marie de Rodat [Thu, 31 May 2018 10:47:50 +0000 (10:47 +0000)]
[Ada] Remove obsolete figure in documentation
2018-05-31 Pierre-Marie de Rodat <derodat@adacore.com>
gcc/ada/
* doc/gnat_ugn/project-manager-figure.png: Delete.
From-SVN: r261018
Pierre-Marie de Rodat [Thu, 31 May 2018 10:47:45 +0000 (10:47 +0000)]
[Ada] Add missing spec files for VxWorks runtimes
2018-05-31 Pierre-Marie de Rodat <derodat@adacore.com>
gcc/ada/
* vxworks-arm-link.spec, vxworks-e500-link.spec,
vxworks-gnat-crtbe-link.spec, vxworks-smp-arm-link.spec,
vxworks-smp-e500-link.spec, vxworks-smp-ppc-link.spec,
vxworks-smp-x86-link.spec: New files.
From-SVN: r261017
Pierre-Marie de Rodat [Thu, 31 May 2018 10:47:39 +0000 (10:47 +0000)]
[Ada] Minor copyright header adjustments
2018-05-31 Pierre-Marie de Rodat <derodat@adacore.com>
gcc/ada/
* gnatvsn.adb: Re-center the copyright header.
* indepsw-darwin.adb: Adjust the starting copyright year to 2011.
From-SVN: r261016
Fedor Rybin [Thu, 31 May 2018 10:47:34 +0000 (10:47 +0000)]
[Ada] Document Stubs_Subdir in gnattest section on user guide
2018-05-31 Fedor Rybin <frybin@adacore.com>
gcc/ada/
* doc/gnat_ugn/gnat_utility_programs.rst: Document Stubs_Subdir in
gnattest section on user guide.
From-SVN: r261015
Ed Schonberg [Thu, 31 May 2018 10:47:29 +0000 (10:47 +0000)]
[Ada] Static predicate check on characters of a string literal
This patch implements the rule given in R< 4.2 (11): if the component type of
a string literal is a character type with a static predicate, that predicate
must be applied to each character in the string.
Compiling the example below must yield:
gcc -c -gnata main.adb
main.adb:4:23: warning: static expression fails static predicate check on "C"
main.adb:4:23: warning: expression is no longer considered static
main.adb:4:24: warning: static expression fails static predicate check on "C"
main.adb:4:24: warning: expression is no longer considered static
main.adb:4:25: warning: static expression fails static predicate check on "C"
main.adb:4:25: warning: expression is no longer considered static
Execution must yield:
raised SYSTEM.ASSERTIONS.ASSERT_FAILURE :
Static_Predicate failed at main.adb:4
----
procedure Main is
subtype C is Character with Static_Predicate => C in 'A' | 'B' | 'C';
type S is array (Positive range <>) of C;
X : constant S := "abc";
begin
null;
end;
2018-05-31 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_String_Literal): If the type is a string type
whose component subtype has a static predicate, ensure that the
predicate is applied to each character by expanding the string into the
equivalent aggregate. This is also done if the component subtype is
constrained.
From-SVN: r261014
Eric Botcazou [Thu, 31 May 2018 10:47:24 +0000 (10:47 +0000)]
[Ada] Remove obsolete code in trans.c
2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/trans.c (Call_to_gnu): Remove obsolete code.
From-SVN: r261013
Piotr Trojanek [Thu, 31 May 2018 10:47:19 +0000 (10:47 +0000)]
[Ada] Detect returning procedures annotated with No_Return
GNAT was emitting a warning about procedures with No_Return aspect on the
spec and a returning body, but failed to handle similar procedures with
no explicit spec. Now fixed.
This was also affecting GNATprove, where an undetected mismatch between
No_Return aspect and the body was a soundness bug, i.e. GNATprove was
silently accept code that raise a runtime exception.
------------
-- Source --
------------
procedure P (X : Boolean) with No_Return is
begin
if X then
raise Program_Error;
end if;
end;
-----------------
-- Compilation --
-----------------
$ gcc -c p.adb
p.adb:3:04: warning: implied return after this statement will raise
Program_Error
p.adb:3:04: warning: procedure "P" is marked as No_Return
2018-05-31 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* sem_ch6.adb (Check_Missing_Return): Handle procedures with no
explicit spec.
From-SVN: r261012
Eric Botcazou [Thu, 31 May 2018 10:47:14 +0000 (10:47 +0000)]
[Ada] Fix wrong value returned for unconstrained packed array
2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/trans.c (Call_to_gnu): In the by-reference case, if
the type of the parameter is an unconstrained array type, convert
to the type of the actual before the type of the formal only if the
conversion was suppressed earlier. Use in_param and gnu_actual_type
local variables throughout, and uniform spelling for In Out or Out.
Also remove dead code in the component-by-reference case.
From-SVN: r261011
Frederic Konrad [Thu, 31 May 2018 10:47:08 +0000 (10:47 +0000)]
[Ada] Fix __gnat_backtrace for VxWorks7 on x86
A STORAGE ERROR is raised in __gnat_backtrace:
adainit: 0x00400DBC
Execution of ce.vxe terminated by unhandled exception
raised STORAGE_ERROR : SIGSEGV: possible stack overflow
Call stack traceback locations:
0x4082f1 0x408323 0x4080c9
It was passing with vxsim because the WRS_RTP_BASE is set to a different
place hence the (CURRENT) < (TOP_STACK) was stopping the backtrace at the
right time. So let's stop at the main symbol when RTS=rtp.
2018-05-31 Frederic Konrad <konrad@adacore.com>
gcc/ada/
* tracebak.c (STOP_FRAME): Harden condition.
(is_return_from, EXTRA_STOP_CONDITION): New helpers for VxWorks in RTP
mode.
From-SVN: r261010
Ed Schonberg [Thu, 31 May 2018 10:47:03 +0000 (10:47 +0000)]
[Ada] Illegal copy of limited object
This patch fixes a spurious copy of a limited object, when that object
is a discriminated record component of a limited type LT, and the enclosing
record is initialized by means of an aggregate, one of whose components is a
call to a build-in-place function that returns an unconstrained object of
type T.
2018-05-31 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* checks.adb (Apply_Discriminant_Check): Do not apply discriminant
check to a call to a build-in-place function, given that the return
object is limited and cannot be copied.
gcc/testsuite/
* gnat.dg/limited1.adb, gnat.dg/limited1_inner.adb,
gnat.dg/limited1_inner.ads, gnat.dg/limited1_outer.adb,
gnat.dg/limited1_outer.ads: New testcase.
From-SVN: r261009
Olivier Hainque [Thu, 31 May 2018 10:46:58 +0000 (10:46 +0000)]
[Ada] Update comment on __atomic_compare_exchange in s-atomic_primitives
Remove mention of unavailability, long obsolete, and reword suggestion of use
to indicate that we might want to switch to an internal interface using them.
The current wording suggests just that we should bind the current
Sync_Compare_And_Swap Ada subprograms to __atomic_compare builtins instead of
__sync_compare, which would be highly confusing.
2018-05-31 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* libgnat/s-atopri.ads: Update comment on __atomic_compare_exchange
builtins.
From-SVN: r261008
Eric Botcazou [Thu, 31 May 2018 10:46:52 +0000 (10:46 +0000)]
[Ada] Fix internal error on allocator with function call
2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/trans.c (Call_to_gnu): If this is a function call and
there is no target, also create a temporary for the return value for
an allocator if the type is an unconstrained record type with default
discriminant.
From-SVN: r261007
Hristian Kirtchev [Thu, 31 May 2018 10:46:48 +0000 (10:46 +0000)]
[Ada] Spurious tampering check failure
This patch modifies the transient scope mechanism to create a scope when the
condition of an iteration scheme returns a controlled result or involves the
secondary stack. As a result, a while loop which iterates over a container
properly manages the tampering bit at each iteration of the loop.
2018-05-31 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* exp_ch7.adb (Find_Transient_Context): An iteration scheme is a valid
boudary for a transient scope.
gcc/testsuite/
* gnat.dg/tampering_check1.adb, gnat.dg/tampering_check1_ivectors.ads,
gnat.dg/tampering_check1_trim.adb, gnat.dg/tampering_check1_trim.ads:
New testcase.
From-SVN: r261006
Valentine Reboul [Thu, 31 May 2018 10:46:43 +0000 (10:46 +0000)]
[Ada] Rename "GPL" version to "Community"
2018-05-31 Valentine Reboul <reboul@adacore.com>
gcc/ada/
* gnatvsn.ads: Rename "GPL" version to "Community".
From-SVN: r261005
Ed Schonberg [Thu, 31 May 2018 10:46:39 +0000 (10:46 +0000)]
[Ada] Minor comment improvement
2018-05-31 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* einfo.ads: Improve documentation for the Is_Unsigned_Type entity
flag.
From-SVN: r261004
Piotr Trojanek [Thu, 31 May 2018 10:46:34 +0000 (10:46 +0000)]
[Ada] Simplify call to Unique_Defining_Entity on protected entry declarations
Calling Unique_Defining_Entity on protectected entry declarations is
equivalent to calling a simpler Defining_Entity; use the simpler routine.
Simplification only; semantics unaffected, so no test provided.
2018-05-31 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma): Replace call to Unique_Defining_Entity
with a semantically equivalent call to Defining_Entity.
From-SVN: r261003
Piotr Trojanek [Thu, 31 May 2018 10:46:17 +0000 (10:46 +0000)]
[Ada] Set Etype on rewriteen Max_Queue_Length expressions
Rewriting of Max_Queue_Length expression into N_Integer_Literal should probably
be done in expansion and not in analysis, but anyway it should not strip the
expression from its Etype because backends (e.g. GNATprove) expect that Etype
to be present.
No frontend test is provided, because GNAT doesn't care about the missing
Etype decoration. This patch allows to simplify AST processing in GNATprove.
2018-05-31 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma): Set Etype on the rewritten
Max_Queue_Length expression.
From-SVN: r261002
Sergey Rybin [Thu, 31 May 2018 10:46:12 +0000 (10:46 +0000)]
[Ada] Update gnatelim documentation wrt. compilation of main unit
2018-05-31 Sergey Rybin <rybin@adacore.com>
gcc/ada/
* doc/gnat_ugn/gnat_and_program_execution.rst: gnatelim does not need
that the main unit to be built before the call, now it computes the
closure of the main unit itself.
* gnat_ugn.texi: Regenerate.
From-SVN: r261001
Eric Botcazou [Thu, 31 May 2018 10:46:07 +0000 (10:46 +0000)]
[Ada] Fix tracking of the first item in Repinfo
2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.adb (List_Structural_Record_Layout): Set First to false
after having listed the fields of the parent type, if any.
From-SVN: r261000
Eric Botcazou [Thu, 31 May 2018 10:46:02 +0000 (10:46 +0000)]
[Ada] Fix strange behavior of Object_Size for packed array subtype
2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/decl.c (gnat_to_gnu_entity) <discrete_type>: Do not
deal with the ___XP suffix for packed array types here...
<E_Array_Subtype>: ...or here when processing the implementation type
but when processing the original type instead. Do not reuse the DECL
of the implementation type for the original type. Tidy up.
From-SVN: r260999
Eric Botcazou [Thu, 31 May 2018 10:45:57 +0000 (10:45 +0000)]
[Ada] Post warning on object size clause for subtype
This ensures that a warning for an object size clause present on a subtype
is posted on the clause and not on a size clause present on the type.
2018-05-31 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* einfo.ads (Object_Size_Clause): Declare.
* einfo.adb (Object_Size_Clause): New function.
* gcc-interface/utils.c (maybe_pad_type): Test Has_Size_Clause before
retrieving Size_Clause and post the warning on the object size clause
if Has_Object_Size_Clause is true.
gcc/testsuite/
* gnat.dg/size_clause1.adb: New testcase.
From-SVN: r260998
Javier Miranda [Thu, 31 May 2018 10:45:51 +0000 (10:45 +0000)]
[Ada] Fix compiler crash for tagged private types
2018-05-31 Javier Miranda <miranda@adacore.com>
gcc/ada/
* sem_util.ads, sem_util.adb (Find_Primitive_Eq): New subprogram.
* exp_ch4.adb (Expand_Composite_Equality): Use the new subprogram
Find_Primitive_Eq to search for the primitive of types whose underlying
type is a tagged type.
gcc/testsuite/
* gnat.dg/tagged1.adb, gnat.dg/tagged1.ads: New testcase.
From-SVN: r260997
Yannick Moy [Thu, 31 May 2018 10:45:05 +0000 (10:45 +0000)]
[Ada] Fix check on placement of multiple loop (in)variant pragmas
Loop (in)variants should appear next to each other, which is checked by GNAT
frontend. As statements inserted during expansion may break this contiguity,
GNAT recognizes specially such statements which originate in loop pragmas. In
some cases, this special treatment was not properly put in place, which lead to
spurious errors being issued.
2018-05-31 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma.Check_Loop_Pragma_Placement): Inverse
order of treatment between nodes recognized as loop pragmas (or
generated from one) and block statements.
From-SVN: r260996
Doug Rupp [Thu, 31 May 2018 10:44:56 +0000 (10:44 +0000)]
[Ada] Posix 2008: reimplement System.OS_Primitives.Clock using clock_gettime
gettimeofday is deprecated in Posix 2008, clock_gettime is the recommended
replacement.
2018-05-31 Doug Rupp <rupp@adacore.com>
gcc/ada/
* libgnat/s-osprim__posix2008.adb (Clock): Implement using
clock_gettime.
From-SVN: r260995
Ed Schonberg [Thu, 31 May 2018 10:44:51 +0000 (10:44 +0000)]
[Ada] Unnesting: add a predicate to help expansion of task and protected types
2018-05-31 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.ads, exp_unst.adb (In_Synchronized_Unit): New predicate to
mark subprograms that cannot be eliminated because they must be treated
as reachable from outside the current unit. This includes entry bodies
and protected operations.
From-SVN: r260994
Ed Schonberg [Thu, 31 May 2018 10:44:45 +0000 (10:44 +0000)]
[Ada] Convert operands of generated code to Standard.Unsigned for modular ops.
2018-05-31 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_Modular_Addition, Expand_Modular_Subtraction):
Convert all operands of the generated code to Standard.Unsigned, to
prevent spurious visibility errors. This is needed when the generated
expansion involves a modular index type of an array type, and the index
type is not immediately visible.
From-SVN: r260993
Matthias Klose [Thu, 31 May 2018 09:57:33 +0000 (09:57 +0000)]
re PR sanitizer/86012 (libsanitizer build failure on sparc64-linux-gnu)
2018-05-31 Matthias Klose <doko@ubuntu.com>
PR sanitizer/86012
* sanitizer_common/sanitizer_platform_limits_posix.cc: Define
SIZEOF_STRUCT_USTAT for 32bit sparc.
From-SVN: r260990
Sameera Deshpande [Thu, 31 May 2018 08:46:20 +0000 (08:46 +0000)]
Patch implementing vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics for AARCH64 for all types.
From-SVN: r260989
GCC Administrator [Thu, 31 May 2018 00:16:46 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r260988
Jozef Lawrynowicz [Wed, 30 May 2018 23:33:49 +0000 (23:33 +0000)]
msp430.c (msp430_output_labelref): Prepend user_label_prefix to name.
* config/msp430/msp430.c (msp430_output_labelref): Prepend
user_label_prefix to name.
From-SVN: r260983
Jozef Lawrynowicz [Wed, 30 May 2018 23:32:31 +0000 (23:32 +0000)]
tree-core.h: Update comment about the format of NAME string passed to handler in attribute_spec.
* tree-core.h: Update comment about the format of NAME string
passed to handler in attribute_spec.
From-SVN: r260982
Jozef Lawrynowicz [Wed, 30 May 2018 23:26:03 +0000 (23:26 +0000)]
msp430.md: Remove erroneous subreg expression from zero_extendqisi2 insn pattern.
* gcc/config/msp430/msp430.md: Remove erroneous subreg expression from
zero_extendqisi2 insn pattern. Remove msp430x ISA restriction on
zero_extend{q,h}isi2.
From-SVN: r260981
Rasmus Villemoes [Wed, 30 May 2018 23:21:48 +0000 (01:21 +0200)]
* crtstuff.c: Remove declaration of _Jv_RegisterClasses.
From-SVN: r260980
Jonathan Wakely [Wed, 30 May 2018 23:13:48 +0000 (00:13 +0100)]
PR c++/77777 improve location for diagnostic
Pass in the location of the invalid expression, not the next input
location (which might be a comma or closing parenthesis on a different
line).
gcc/cp:
PR c++/77777
* call.c (resolve_args): Use location of expression, not current input
location.
gcc/testsuite:
PR c++/77777
* g++.dg/diagnostic/pr77777.C: New test.
From-SVN: r260979
David Pagan [Wed, 30 May 2018 22:55:38 +0000 (22:55 +0000)]
re PR c/55976 (-Werror=return-type should error on returning a value from a void function)
2018-05-30 David Pagan <dave.pagan@oracle.com>
PR c/55976
* c-decl.c (grokdeclarator): Update check for return type warnings.
(start_function): Likewise.
(finish_function): Likewise.
* c-typeck.c (c_finish_return): Update check for return type warnings.
Pass OPT_Wreturn_type to pedwarn when appropriate.
PR c/55976
* c-opts.c (c_common_post_options): Set default for warn_return_type
for C++/C++ with ObjC extensions only. For C, makes it possible to
differentiate between default (no option), -Wreturn-type, and
-Wno-return-type.
PR c/55976
* gcc.dg/noncompile/pr55976-1.c: New test.
* gcc.dg/noncompile/pr55976-2.c: New test.
From-SVN: r260978
Borislav Petkov [Wed, 30 May 2018 22:49:25 +0000 (22:49 +0000)]
extend.texi: Document some architecture specific constraints and sort entries.
* doc/extend.texi: Document some architecture specific
constraints and sort entries.
From-SVN: r260977
Martin Sebor [Wed, 30 May 2018 22:24:43 +0000 (22:24 +0000)]
PR middle-end/85369 - no -Wstringop-overflow for a strcpy / stpcpy call with a nonstring pointer when providing movstr pattern
gcc/ChangeLog:
PR middle-end/85369
* builtins.c (expand_builtin_stpcpy_1): New function.
(expand_builtin_stpcpy): Call it, and call maybe_warn_nonstring_arg
only if the former succeeds.
From-SVN: r260976
Jason Merrill [Wed, 30 May 2018 19:42:52 +0000 (15:42 -0400)]
ChangeLog fix
From-SVN: r260974
Ville Voutilainen [Wed, 30 May 2018 19:33:38 +0000 (22:33 +0300)]
Do not warn about zero-as-null when NULL is used.
gcc/cp/
Do not warn about zero-as-null when NULL is used.
* call.c (conversion_null_warnings): Check for pointer
types converted from zero constants.
(convert_like_real): Add a warning sentinel at the end.
* tree.c (maybe_warn_zero_as_null_pointer_constant): Also
check null_node_p.
testsuite/
Do not warn about zero-as-null when NULL is used.
* g++.dg/warn/Wzero-as-null-pointer-constant-7.C: New.
From-SVN: r260973
Jason Merrill [Wed, 30 May 2018 19:31:11 +0000 (15:31 -0400)]
PR c++/85807 - ICE with call in template NSDMI.
* init.c (get_nsdmi): Use push_to/pop_from_top_level.
* tree.c (bot_manip): Don't set_flags_from_callee in a template.
From-SVN: r260972
Sameera Deshpande [Wed, 30 May 2018 18:40:03 +0000 (18:40 +0000)]
patch to add support of ARMv8.4 in saphira
From-SVN: r260971
Jan Hubicka [Wed, 30 May 2018 17:57:50 +0000 (19:57 +0200)]
simple-object.h (simple_object_copy_lto_debug_sections): Add rename parameter.
* simple-object.h (simple_object_copy_lto_debug_sections): Add rename
parameter.
From-SVN: r260970
Jason Merrill [Wed, 30 May 2018 17:33:06 +0000 (13:33 -0400)]
PR c++/85873 - constant initializer_list array not in .rodata.
* tree.c (build_target_expr): Set TREE_READONLY.
* call.c (set_up_extended_ref_temp): Set TREE_READONLY.
From-SVN: r260969
Jason Merrill [Wed, 30 May 2018 17:32:54 +0000 (13:32 -0400)]
Improve error recovery for structured binding in condition.
* parser.c (cp_parser_check_condition_declarator): Handle
cp_error_declarator.
From-SVN: r260968
Jan Hubicka [Wed, 30 May 2018 17:10:03 +0000 (17:10 +0000)]
Remove accidental commit.
From-SVN: r260967
Jan Hubicka [Wed, 30 May 2018 17:07:36 +0000 (19:07 +0200)]
20111213-1_0.c: Fix template.
* gcc.dg/lto/
20111213-1_0.c: Fix template.
* gcc.dg/lto/
20100603-1_0.c: Fix template.
* gcc.dg/lto/
20100603-2_0.c: Fix template.
* gcc.dg/lto/
20100603-3_0.c: Fix template.
From-SVN: r260966
Jan Hubicka [Wed, 30 May 2018 16:43:59 +0000 (18:43 +0200)]
* doc/invoke.texi (-flinker-output): Document
From-SVN: r260965
Jan Hubicka [Wed, 30 May 2018 16:43:11 +0000 (16:43 +0000)]
passes.c (ipa_write_summaries): Only modify statements if body is in memory.
* passes.c (ipa_write_summaries): Only modify statements if body
is in memory.
* cgraphunit.c (ipa_passes): Also produce intermeidate code when
incrementally linking.
(ipa_passes): Likewise.
* lto-cgraph.c (lto_output_node): When incrementally linking do not
pass down resolution info.
* common.opt (flag_incremental_link): Update info.
* gcc.c (plugin specs): Turn flinker-output=* to
-plugin-opt=-linker-output-known
* toplev.c (compile_file): Also cut compilation when doing incremental
link.
* flag-types. (enum lto_partition_model): Add
LTO_LINKER_OUTPUT_NOLTOREL.
(invoke.texi): Add -flinker-output docs.
* ipa.c (symbol_table::remove_unreachable_nodes): Handle LTO incremental
link same way as WPA; do not stream in dead initializers.
From-SVN: r260964
Jan Hubicka [Wed, 30 May 2018 16:42:41 +0000 (18:42 +0200)]
passes.c (ipa_write_summaries): Only modify statements if body is in memory.
* passes.c (ipa_write_summaries): Only modify statements if body
is in memory.
* cgraphunit.c (ipa_passes): Also produce intermeidate code when
incrementally linking.
(ipa_passes): Likewise.
* lto-cgraph.c (lto_output_node): When incrementally linking do not
pass down resolution info.
* common.opt (flag_incremental_link): Update info.
* gcc.c (plugin specs): Turn flinker-output=* to
-plugin-opt=-linker-output-known
* toplev.c (compile_file): Also cut compilation when doing incremental
link.
* flag-types. (enum lto_partition_model): Add
LTO_LINKER_OUTPUT_NOLTOREL.
(invoke.texi): Add -flinker-output docs.
* ipa.c (symbol_table::remove_unreachable_nodes): Handle LTO incremental
link same way as WPA; do not stream in dead initializers.
* dwarf2out.c (dwarf2out_die_ref_for_decl,
darf2out_register_external_decl): Support incremental link.
* lang.opt (lto_linker_output): Add nolto-rel.
* lto-lang.c (lto_post_options): Handle LTO_LINKER_OUTPUT_REL
and LTO_LINKER_OUTPUT_NOLTOREL.
(lto_init): Generate lto when doing incremental link.
* lto.c (lto_precess_name): Add lto1-inclink.
* testsuite/g++.dg/lto/
20081109-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/20081118_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20081119-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20081120-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20081120-2_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/20081123_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20081204-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/20081219_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/20090302_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/20090313_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20091002-2_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20091002-3_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20091026-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20100724-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20101010-4_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20101015-2_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/
20110311-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/pr45621_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/pr48042_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/pr48354-1_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/pr54625-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/pr54625-2_0.c: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/lto/pr68811_0.C: Add -flinker-output=nolto-rel.
* testsuite/g++.dg/torture/pr43760.C: New test. Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20081120-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20081120-2_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/20081126_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20081204-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20081204-2_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20081212-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/20081224_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/20090116_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20090126-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20090126-2_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20090206-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/20090219_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20091013-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20091014-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20091015-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20091016-1_0.c: Add -flinker-output=nolto-rel.
* testsuite/gcc.dg/lto/
20091020-1_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20091020-2_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20091027-1_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/20100426_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20100430-1_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20100603-1_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20100603-2_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20100603-3_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/
20111213-1_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr45736_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr52634_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr54702_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr59323-2_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr59323_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr60820_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr81406_0.c: Add -flinker-output-nolto-rel.
* testsuite/gcc.dg/lto/pr83388_0.c: Add -flinker-output-nolto-rel.
* testsuite/gfortran.dg/lto/
20091016-1_0.f90: Add -flinker-output-nolto-rel.
* testsuite/gfortran.dg/lto/
20091028-1_0.f90: Add -flinker-output-nolto-rel.
* testsuite/gfortran.dg/lto/
20091028-2_0.f90: Add -flinker-output-nolto-rel.
* testsuite/gfortran.dg/lto/pr46911_0.f: Add -flinker-output-nolto-rel.
* testsuite/gfortran.dg/lto/pr47839_0.f90: Add -flinker-output-nolto-rel.
From-SVN: r260963
Jan Hubicka [Wed, 30 May 2018 16:37:53 +0000 (18:37 +0200)]
* lto-opts.c (lto_write_options): Skip OPT_dumpdir, OPT_fresolution_.
From-SVN: r260962
Jan Hubicka [Wed, 30 May 2018 16:36:55 +0000 (18:36 +0200)]
lto-wrapper.c (debug_objcopy): Add rename parameter; pass it down to simple_object_copy_lto_debug_sections.
* lto-wrapper.c (debug_objcopy): Add rename parameter; pass
it down to simple_object_copy_lto_debug_sections.
(run_gcc): Determine incremental LTO link time and configure
lto1 into non-wpa mode, disable renaming of debug sections.
From-SVN: r260961
Jan Hubicka [Wed, 30 May 2018 16:34:54 +0000 (18:34 +0200)]
lto-plugin.c: (non_claimed_files): New static var.
* lto-plugin.c: (non_claimed_files): New static var.
(linker_ouput_known): New static var.
(all_symbols_read_handler): When user specifies linker output do not
imply it; output warning when nonlto-rel mode is forced.
(claim_file_header): Record number of nonclaimed files.
(process_option): Remember if linker output is known
From-SVN: r260960
Kelvin Nilsen [Wed, 30 May 2018 16:20:16 +0000 (16:20 +0000)]
extend.texi (PowerPC AltiVec Built-in Functions): Remove descriptions of various incorrectly documented functions.
gcc/ChangeLog:
2018-05-30 Kelvin Nilsen <kelvin@gcc.gnu.org>
* doc/extend.texi (PowerPC AltiVec Built-in Functions): Remove
descriptions of various incorrectly documented functions.
From-SVN: r260959
Andre Vieira [Wed, 30 May 2018 16:04:03 +0000 (16:04 +0000)]
Fixing ChangeLog entry for earlier commit.
From-SVN: r260958
Andre Vieira [Wed, 30 May 2018 15:59:14 +0000 (15:59 +0000)]
Reverting r260635
gcc
2018-05-30 Andre Vieira <andre.simoesdiasvieira@arm.com>
2018-05-24 Andre Vieira <andre.simoesdiasvieira@arm.com>
PR target/83009
Revert:
* config/aarch64/predicates.md (aarch64_mem_pair_lanes_operand): Make
address check not strict.
gcc/testsuite
2018-05-30 Andre Vieira <andre.simoesdiasvieira@arm.com>
2018-05-24 Andre Vieira <andre.simoesdiasvieira@arm.com>
Revert
PR target/83009
* gcc/target/aarch64/store_v2vec_lanes.c: Add extra tests.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@260635
138bc75d-0d04-0410-961f-
82ee72b054a4
From-SVN: r260957
Jan Hubicka [Wed, 30 May 2018 15:26:26 +0000 (17:26 +0200)]
simple-object.h (simple_object_copy_lto_debug_sections): Add rename parameter.
* simple-object.h (simple_object_copy_lto_debug_sections): Add rename
parameter.
* simple-object.c (handle_lto_debug_sections): Add rename parameter.
(handle_lto_debug_sections_rename): New function.
(handle_lto_debug_sections_norename): New function.
(simple_object_copy_lto_debug_sections): Add rename parameter.
From-SVN: r260956
Richard Biener [Wed, 30 May 2018 14:55:04 +0000 (14:55 +0000)]
re PR tree-optimization/85964 (compile time hog w/ -O3 -ftracer -fno-guess-branch-probability)
2018-05-30 Richard Biener <rguenther@suse.de>
PR tree-optimization/85964
* tracer.c (better_p): Drop initialized count check, we only
call the function with initialized counts now.
(find_best_successor): Do find a best edge if one
has uninitialized count.
(find_best_predecessor): Likewise. Do BB frequency check only
if count is initialized.
From-SVN: r260954
Jackson Woodruff [Wed, 30 May 2018 10:59:25 +0000 (10:59 +0000)]
[AArch64] Improve LDP/STP generation that requires a base register
This patch generalizes the formation of LDP/STP that require a base register.
In AArch64, LDP/STP instructions have different sized immediate offsets than
normal LDR/STR instructions. This part of the backend attempts to spot groups
of four LDR/STR instructions that can be turned into LDP/STP instructions by
using a base register.
Previously, we would only accept address pairs that were ordered in ascending
or descending order, and only strictly sequential loads/stores. In fact, the
instructions that we generate from this should be able to consider any order
of loads or stores (provided that they can be re-ordered). They should also be
able to accept non-sequential loads and stores provided that the two pairs of
addresses are amenable to pairing. The current code is also overly restrictive
on the range of addresses that are accepted, as LDP/STP instructions may take
negative offsets as well as positive ones.
This patch improves that by allowing us to accept all orders of loads/stores
that are valid, and extending the range that the LDP/STP addresses can reach.
2017-05-30 Jackson Woodruff <jackson.woodruff@arm.com>
* config/aarch64/aarch64.c (aarch64_host_wide_int_compare): New.
(aarch64_ldrstr_offset_compare): New.
(aarch64_operands_adjust_ok_for_ldpstp): Update to consider all
load/store orderings.
(aarch64_gen_adjusted_ldpstp): Likewise.
* gcc.target/aarch64/simd/ldp_stp_9: New.
* gcc.target/aarch64/simd/ldp_stp_10: New.
* gcc.target/aarch64/simd/ldp_stp_11: New.
* gcc.target/aarch64/simd/ldp_stp_12: New.
From-SVN: r260952
Wilco Dijkstra [Wed, 30 May 2018 10:31:21 +0000 (10:31 +0000)]
[AArch64] Fix aarch64_ira_change_pseudo_allocno_class
A recent commit removing '*' from the md files caused a large regression in
h264ref. It turns out aarch64_ira_change_pseudo_allocno_class is no longer
effective after the SVE changes, and the combination results in the regression.
This patch fixes it by explicitly checking for a subset of GENERAL_REGS and
FP_REGS. Add a missing ? to aarch64_get_lane to fix a failure in the testsuite.
gcc/
* config/aarch64/aarch64.c (aarch64_ira_change_pseudo_allocno_class):
Check for subset of GENERAL_REGS and FP_REGS.
* config/aarch64/aarch64-simd.md (aarch64_get_lane): Increase cost of
r=w alternative.
From-SVN: r260951
Piotr Trojanek [Wed, 30 May 2018 08:59:03 +0000 (08:59 +0000)]
[Ada] Update documentation of Sinfo.Package_Instantiation field
This was forgotten when renaming Get_Package_Instantiation_Node to
Get_Unit_Instantiation_Node.
2018-05-30 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* einfo.ads (Package_Instantiation): Update comment after a routine
that uses this field has been renamed.
From-SVN: r260950
Ed Schonberg [Wed, 30 May 2018 08:58:57 +0000 (08:58 +0000)]
[Ada] Unnesting: always transform local Raise statements
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch11.adb (Replace_Raise_By_Goto): The transfomation is legal even
if the local raise statement includes a string expression. This
expression might be picked up by an outer handler or discarded, but
plays no role in this transformation.
From-SVN: r260949
Hristian Kirtchev [Wed, 30 May 2018 08:58:51 +0000 (08:58 +0000)]
[Ada] Minor reformatting
2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* exp_aggr.adb, exp_unst.adb, freeze.adb, libgnat/a-direct.adb: Minor
reformatting.
From-SVN: r260948
Ed Schonberg [Wed, 30 May 2018 08:58:46 +0000 (08:58 +0000)]
[Ada] Unnesting: handle the semantic of Procedure_To_Call field
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb (Visit_Node): Handle the semantic Procedure_To_Call
field in relevant nodes: Allocate, Free, and return statements.
From-SVN: r260947
Ed Schonberg [Wed, 30 May 2018 08:58:40 +0000 (08:58 +0000)]
[Ada] Unnesting: skip unanalyzed Component_Assocation
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb (Visit_Node): Do not traverse a Component_Association
that has not been analyzed, as will be the case for a nested aggregate
that is expanded into individual assignments.
From-SVN: r260946
Justin Squirek [Wed, 30 May 2018 08:58:33 +0000 (08:58 +0000)]
[Ada] Implement pragma Max_Entry_Queue_Depth
This patch implements AI12-0164-1 for the aspect/pragma Max_Entry_Queue_Depth.
Previously, the GNAT specific pragma Max_Queue_Length fulfilled this role, but
was not named to match the standard and thus was insufficent.
------------
-- Source --
------------
-- pass.ads
with System;
package Pass is
SOMETHING : constant Integer := 5;
Variable : Boolean := False;
protected type Protected_Example is
entry A (Item : Integer)
with Max_Entry_Queue_Depth => 2; -- OK
entry B (Item : Integer);
pragma Max_Entry_Queue_Depth (SOMETHING); -- OK
entry C (Item : Integer); -- OK
entry D (Item : Integer)
with Max_Entry_Queue_Depth => 4; -- OK
entry D (Item : Integer; Item_B : Integer)
with Max_Entry_Queue_Depth => Float'Digits; -- OK
entry E (Item : Integer);
pragma Max_Entry_Queue_Depth (SOMETHING * 2); -- OK
entry E (Item : Integer; Item_B : Integer);
pragma Max_Entry_Queue_Depth (11); -- OK
entry F (Item : Integer; Item_B : Integer);
pragma Pre (Variable = True);
pragma Max_Entry_Queue_Depth (11); -- OK
entry G (Item : Integer; Item_B : Integer)
with Pre => (Variable = True),
Max_Entry_Queue_Depth => 11; -- OK
private
Data : Boolean := True;
end Protected_Example;
Prot_Ex : Protected_Example;
end Pass;
-- fail.ads
package Fail is
-- Not near entry
pragma Max_Entry_Queue_Depth (40); -- ERROR
-- Task type
task type Task_Example is
entry Insert (Item : in Integer)
with Max_Entry_Queue_Depth => 10; -- ERROR
-- Entry family in task type
entry A (Positive) (Item : in Integer)
with Max_Entry_Queue_Depth => 10; -- ERROR
end Task_Example;
Task_Ex : Task_Example;
-- Aspect applied to protected type
protected type Protected_Failure_0
with Max_Entry_Queue_Depth => 50 is -- ERROR
entry A (Item : Integer);
private
Data : Integer := 0;
end Protected_Failure_0;
Protected_Failure_0_Ex : Protected_Failure_0;
protected type Protected_Failure is
pragma Max_Entry_Queue_Depth (10); -- ERROR
-- Duplicates
entry A (Item : Integer)
with Max_Entry_Queue_Depth => 10; -- OK
pragma Max_Entry_Queue_Depth (4); -- ERROR
entry B (Item : Integer);
pragma Max_Entry_Queue_Depth (40); -- OK
pragma Max_Entry_Queue_Depth (4); -- ERROR
entry C (Item : Integer)
with Max_Entry_Queue_Depth => 10, -- OK
Max_Entry_Queue_Depth => 40; -- ERROR
-- Duplicates with the same value
entry AA (Item : Integer)
with Max_Entry_Queue_Depth => 10; -- OK
pragma Max_Entry_Queue_Depth (10); -- ERROR
entry BB (Item : Integer);
pragma Max_Entry_Queue_Depth (40); -- OK
pragma Max_Entry_Queue_Depth (40); -- ERROR
entry CC (Item : Integer)
with Max_Entry_Queue_Depth => 10, -- OK
Max_Entry_Queue_Depth => 10; -- ERROR
-- On subprogram
procedure D (Item : Integer)
with Max_Entry_Queue_Depth => 10; -- ERROR
procedure E (Item : Integer);
pragma Max_Entry_Queue_Depth (4); -- ERROR
function F (Item : Integer) return Integer
with Max_Entry_Queue_Depth => 10; -- ERROR
function G (Item : Integer) return Integer;
pragma Max_Entry_Queue_Depth (4); -- ERROR
-- Bad parameters
entry H (Item : Integer)
with Max_Entry_Queue_Depth => 0; -- ERROR
entry I (Item : Integer)
with Max_Entry_Queue_Depth => -1; -- ERROR
entry J (Item : Integer)
with Max_Entry_Queue_Depth => 16#FFFF_FFFF_FFFF_FFFF_FFFF#; -- ERROR
entry K (Item : Integer)
with Max_Entry_Queue_Depth => False; -- ERROR
entry L (Item : Integer)
with Max_Entry_Queue_Depth => "JUNK"; -- ERROR
entry M (Item : Integer)
with Max_Entry_Queue_Depth => 1.0; -- ERROR
entry N (Item : Integer)
with Max_Entry_Queue_Depth => Long_Integer'(3); -- ERROR
-- Entry family
entry O (Boolean) (Item : Integer)
with Max_Entry_Queue_Depth => 5; -- ERROR
private
Data : Integer := 0;
end Protected_Failure;
I : Positive := 1;
Protected_Failure_Ex : Protected_Failure;
end Fail;
-- dtest.adb
with Ada.Text_IO; use Ada.Text_IO;
procedure Dtest is
protected Prot is
entry Wait;
pragma Max_Entry_Queue_Depth (2);
procedure Wakeup;
private
Barrier : Boolean := False;
end Prot;
protected body Prot is
entry Wait when Barrier is
begin
null;
end Wait;
procedure Wakeup is
begin
Barrier := True;
end Wakeup;
end Prot;
task type T;
task body T is
begin
Put_Line ("Waiting...");
Prot.Wait;
exception
when others =>
Put_Line ("Got exception");
end T;
T1, T2 : T;
begin
delay 0.1;
Prot.Wait;
Put_Line ("Done");
exception
when others =>
Put_Line ("Main got exception");
Prot.Wakeup;
end Dtest;
----------------------------
-- Compilation and output --
----------------------------
& gcc -c -g -gnatDG pass.ads
& gcc -c -g fail.ads
& grep -c "(2, 5, 0, 4, 6, 10, 11, 11, 11)" pass.ads.dg
& gnatmake -g -q dtest
fail.ads:5:04: pragma "Max_Queue_Length" must apply to a protected entry
fail.ads:12:15: aspect "Max_Queue_Length" cannot apply to task entries
fail.ads:17:15: aspect "Max_Queue_Length" cannot apply to task entries
fail.ads:26:12: aspect "Max_Queue_Length" must apply to a protected entry
fail.ads:36:07: pragma "Max_Queue_Length" must apply to a protected entry
fail.ads:42:07: pragma "Max_Queue_Length" duplicates aspect declared at line 41
fail.ads:46:07: pragma "Max_Queue_Length" duplicates pragma declared at line 45
fail.ads:50:15: aspect "Max_Queue_Length" for "C" previously given at line 49
fail.ads:56:07: pragma "Max_Queue_Length" duplicates aspect declared at line 55
fail.ads:60:07: pragma "Max_Queue_Length" duplicates pragma declared at line 59
fail.ads:64:15: aspect "Max_Queue_Length" for "CC" previously given at line 63
fail.ads:69:15: aspect "Max_Queue_Length" must apply to a protected entry
fail.ads:72:07: pragma "Max_Queue_Length" must apply to a protected entry
fail.ads:75:15: aspect "Max_Queue_Length" must apply to a protected entry
fail.ads:78:07: pragma "Max_Queue_Length" must apply to a protected entry
fail.ads:83:35: entity for aspect "Max_Queue_Length" must be positive
fail.ads:86:35: entity for aspect "Max_Queue_Length" must be positive
fail.ads:89:35: entity for aspect "Max_Queue_Length" out of range of Integer
fail.ads:92:35: expected an integer type
fail.ads:92:35: found type "Standard.Boolean"
fail.ads:95:35: expected an integer type
fail.ads:95:35: found a string type
fail.ads:98:35: expected an integer type
fail.ads:98:35: found type universal real
2018-05-30 Justin Squirek <squirek@adacore.com>
gcc/ada/
* aspects.adb, aspects.ads: Register new aspect.
* par-prag.adb (Prag): Register new pragma.
* sem_ch13.adb (Analyze_Aspect_Specifications): Add processing for new
aspect similar to Aspect_Max_Queue_Length.
* sem_prag.adb, sem_prag.ads (Analyze_Pragma): Register new pragma and
set it to use the same processing as Pragma_Max_Queue_Length.
* snames.ads-tmpl: Move definition of Name_Max_Entry_Queue_Depth so
that it can be processed as a pragma in addition to a restriction and
add an entry for the pragma itself.
From-SVN: r260945
Ed Schonberg [Wed, 30 May 2018 08:58:27 +0000 (08:58 +0000)]
[Ada] Extend the applicability of Thread_Local_Storage to composite types
This patch allows the GNAT-specific Thread_Local_Storage to be applied
to variables of a composite type initiallized with an aggregate with
static components that requires no elaboration code.
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* freeze.adb (Freeze_Object_Declaration): A pragma Thread_Local_Storage
is now legal on a variable of composite type initialized with an
aggregate that is fully static and requires no elaboration code.
* exp_aggr.adb (Convert_To_Positional): Recognize additional cases of
nested aggregates that are compile-time static, so they can be used to
initialize variables declared with Threqd_Local_Storage.
* doc/gnat_rm/implementation_defined_pragmas.rst: Add documentation on
Thread_Local_Storage.
* gnat_rm.texi: Regenerate.
gcc/testsuite/
* gnat.dg/tls1.adb, gnat.dg/tls1_pkg.ads: New testcase.
From-SVN: r260944
Yannick Moy [Wed, 30 May 2018 08:58:17 +0000 (08:58 +0000)]
[Ada] Correctly ignore Assertion_Policy in modes CodePeer and GNATprove
In the modes for static analysis with CodePeer or formal verification with
GNATprove, the value of Assertion_Policy for a given policy is ignored if
it's not Disable, as CodePeer/GNATprove are meant to check assertions even
when not enabled at run time. This was not done consistently, which could
lead to spurious errors on policy mismatch on ghost code inside assertions.
There is no impact on compilation.
2018-05-30 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb (Policy_In_Effect): Take into account CodePeer and
GNATprove modes.
From-SVN: r260943
Justin Squirek [Wed, 30 May 2018 08:58:12 +0000 (08:58 +0000)]
[Ada] ACATS 4.1G - CXAG003 - Name_Case_Equivalence doesn't exist
Implement a missing portion of Ada 2005's AI05-0049-1 for subprogram
Ada.Directories.Name_Case_Equivalence so that user programs can account for
operating system differences in case sensitivity.
------------
-- Source --
------------
-- main.adb
with Ada.Directories; use Ada.Directories;
with Ada.Text_IO; use Ada.Text_IO;
procedure Main is
begin
-- Directory layout:
-- /empty +-- Nothing...
--
-- /mutliplefiles +-- "TEST1.TXT"
-- |
-- "test1.txt"
--
-- /singlefile +-- "test1.txt"
--
-- /noncasable +-- "!"
--
Put_Line (Name_Case_Equivalence ("./empty")'Image);
Put_Line (Name_Case_Equivalence ("./multiplefiles")'Image);
Put_Line (Name_Case_Equivalence ("./singlefile")'Image);
Put_Line (Name_Case_Equivalence ("./multiplefiles/test1.txt")'Image);
Put_Line (Name_Case_Equivalence ("./singlefile/test1.txt")'Image);
Put_Line (Name_Case_Equivalence ("./noncaseable/!")'Image);
end;
----------------------------
-- Compilation and Output --
----------------------------
& gnatmake -q main.adb
& main
CASE_SENSITIVE
CASE_SENSITIVE
CASE_SENSITIVE
CASE_SENSITIVE
CASE_SENSITIVE
CASE_SENSITIVE
2018-05-30 Justin Squirek <squirek@adacore.com>
gcc/ada/
* libgnat/a-direct.adb, libgnat/a-direct.ads (Name_Case_Equivalence):
Add implementation.
(Start_Search): Modify to use Start_Search_Internal
(Start_Search_Internal): Add to break out an extra flag for searching
case insensative due to the potential for directories within the same
OS to allow different casing schemes.
* sysdep.c (__gnat_name_case_equivalence): Add as a default fallback
for when the more precise solution fails.
From-SVN: r260942
Hristian Kirtchev [Wed, 30 May 2018 08:58:05 +0000 (08:58 +0000)]
[Ada] Minor reformatting
2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* checks.adb, exp_ch5.adb, exp_ch7.adb, exp_unst.adb, sem_eval.adb:
Minor reformatting.
From-SVN: r260941
Pascal Obry [Wed, 30 May 2018 08:58:00 +0000 (08:58 +0000)]
[Ada] Add support for Define_Switch with a callback in GNAT.Command_Line
Add support for Define_Switch with a callback in GNAT.Command_Line.
The callback is called for every instance of the switch found on the
command line. This make it possible to have full control over the
switch value and chain multiple actions if needed.
2018-05-30 Pascal Obry <obry@adacore.com>
gcc/ada/
* libgnat/g-comlin.ads (Value_Callback, Define_Switch): New.
* libgnat/g-comlin.adb: Add corresponding implementation.
From-SVN: r260940
Gary Dismukes [Wed, 30 May 2018 08:57:55 +0000 (08:57 +0000)]
[Ada] Fix several typos
2018-05-30 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_res.adb, sem_util.adb: Fix several typos.
From-SVN: r260939
Olivier Hainque [Wed, 30 May 2018 08:57:50 +0000 (08:57 +0000)]
[Ada] Craft .ctors/.dtors sections manually for VxWorks EH registration
Temporary change for experimental purposes. Further cleanups will
be needed if this sheme works as we hope.
2018-05-30 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* vx_crtbegin_attr.c (CTOR_ATTRIBUTE, DTOR_ATTRIBUTE): Empty.
(eh_registration_ctors, eh_registration_tors): New static variables,
forced in a .ctors/.dtors section, respectively, with priority.
From-SVN: r260938
Bob Duff [Wed, 30 May 2018 08:57:44 +0000 (08:57 +0000)]
[Ada] Spell preanalysis, preanalyze correctly
2018-05-30 Bob Duff <duff@adacore.com>
gcc/ada/
* aspects.ads, contracts.adb, exp_util.adb, expander.adb, expander.ads,
freeze.adb, inline.adb, lib-xref.adb, sem.ads, sem_aggr.adb,
sem_attr.adb, sem_ch13.adb, sem_ch3.adb, sem_ch5.adb, sem_ch6.adb,
sem_ch8.adb, sem_dim.adb, sem_elab.adb, sem_res.adb, sem_res.ads,
sinfo.ads: Spell preanalysis, preanalyze correctly.
From-SVN: r260937
Bob Duff [Wed, 30 May 2018 08:57:38 +0000 (08:57 +0000)]
[Ada] Minor comment rework in GNAT.Secondary_Stack_Info
2018-05-30 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/g-sestin.ads: Rework documentation comments.
From-SVN: r260936
Piotr Trojanek [Wed, 30 May 2018 08:57:33 +0000 (08:57 +0000)]
[Ada] Reuse Is_Rewrite_Substitution where possible
Use a high-level Is_Rewrite_Substitution instead of a low-level inequality,
with the intention to improve the code easier to read. Semantics unaffected,
so no test provided.
2018-05-30 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* errout.adb, exp_aggr.adb, exp_ch7.adb, exp_util.adb, lib.adb,
sem_ch13.adb, sem_ch4.adb, sem_res.adb, sem_util.adb
(Has_Original_Node): Refactor to use Is_Rewrite_Substitution.
From-SVN: r260935
Piotr Trojanek [Wed, 30 May 2018 08:57:26 +0000 (08:57 +0000)]
[Ada] Simplify conditions by removing always true conjuncts
Checking "Original_Node (N) /= N" is equivalent to "Is_Rewrite_Substitution
(N)", which is checked just two lines before. Trivial simplification,
semantics unaffected.
2018-05-30 Piotr Trojanek <trojanek@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma): Remove conjuncts that are always true.
From-SVN: r260934
Hristian Kirtchev [Wed, 30 May 2018 08:57:21 +0000 (08:57 +0000)]
[Ada] Spurious error on legal synchronized constituent
This patch corrects the predicate which determines whether an entity denotes a
synchronized object as per SPARK RM 9.1. to account for a case where the object
is not atomic, but its type is.
The patch also cleans up various atomic object-related predicates.
2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* sem_util.adb (Is_Atomic_Object): Cleaned up. Split the entity logic
in a separate routine.
(Is_Atomic_Object_Entity): New routine.
(Is_Atomic_Prefix): Cleaned up.
(Is_Synchronized_Object): Check that the object is atomic, or its type
is atomic.
(Object_Has_Atomic_Components): Removed.
* sem_util.ads (Is_Atomic_Object): Reword the comment on usage.
(Is_Atomic_Object_Entity): New routine.
gcc/testsuite/
* gnat.dg/synchronized1.adb, gnat.dg/synchronized1.ads: New testcase.
From-SVN: r260933
Ed Schonberg [Wed, 30 May 2018 08:57:11 +0000 (08:57 +0000)]
[Ada] Refine logic to set Needs_Activation_Record on subprogram types
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch3.adb (Access_Subprogram_Declaration): The flag
Needs_Activation_Record is only needed on a subprogram type, not on a
pointer to such.
* sem_res.adb (Resolve_Selected_Component): If the context type and the
component type are anonymous access to subprograms, use the component
type to obtain the proper value of Needs_Activation_Record flag for the
expression.
From-SVN: r260932
Eric Botcazou [Wed, 30 May 2018 08:57:05 +0000 (08:57 +0000)]
[Ada] Minor comment addition
2018-05-30 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/trans.c (gnat_to_gnu) <N_Assignment_Statement>: Add
comment about the memset case.
From-SVN: r260931
Bob Duff [Wed, 30 May 2018 08:56:59 +0000 (08:56 +0000)]
[Ada] Secondary stack leak in "for X of ..." loops
This patch fixes a memory leak bug. In particular, in a loop of the form "for X
of ...", with a type that has the Iterable aspect specified, if the result of
the Element function is returned on the secondary stack (e.g. the result
subtype has caller-unknown size), then memory for the secondary stack could
leak.
2018-05-30 Bob Duff <duff@adacore.com>
gcc/ada/
* exp_ch5.adb (Expand_Formal_Container_Element_Loop): Remove the code
to analyze the Elmt_Decl, because it gets analyzed in the wrong scope.
We need to analyze it as part of analyzing the block, so that if the
call to Element that initializes Elmt_Decl returns on the secondary
stack, the block will ss_mark/ss_release. This block is inside the
loop; we don't want to leak memory until the loop exits. The purpose
of analyzing Elmt_Decl first was to catch the error of modifying it,
which is illegal because it's a loop parameter. The above causes us to
miss that error. Therefore, we add a flag Is_Loop_Parameter, and set
it on the Element entity, so we end up with an E_Variable node with the
flag set.
* einfo.ads, einfo.adb (Is_Loop_Parameter): New flag.
* sem_ch5.adb (Diagnose_Non_Variable_Lhs): Give the "assignment to loop
parameter not allowed" error if Is_Loop_Parameter.
* sem_util.adb (Is_Variable): Return False if Is_Loop_Parameter, to
trigger the call to Diagnose_Non_Variable_Lhs.
From-SVN: r260930
Arnaud Charlet [Wed, 30 May 2018 08:56:54 +0000 (08:56 +0000)]
[Ada] Ignore out of range values for System.Priority in CodePeer mode
2018-05-30 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* checks.adb (Apply_Scalar_Range_Check):
* sem_eval.adb (Check_Non_Static_Context, Out_Of_Range): Ignore out of
range values for System.Priority in CodePeer mode since the actual
target compiler may provide a wider range.
From-SVN: r260929
Ed Schonberg [Wed, 30 May 2018 08:56:49 +0000 (08:56 +0000)]
[Ada] Unnesting: look for specification of main unit
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb: Search specification of main unit as well, for
unnesting.
From-SVN: r260928
Ed Schonberg [Wed, 30 May 2018 08:56:44 +0000 (08:56 +0000)]
[Ada] Unnesting: properly handle local subprogram in declare blocks
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch7.adb (Check_Unnesting_Elaboration_Code): The statement part of
a package body that is a compilation unit may contain blocks that
declare local subprograms. In Subprogram_Unnesting Mode such
subprograms must be handled as nested inside the (implicit) elaboration
procedure that executes that statement part. To handle properly uplevel
references we construct that subprogram explicitly, to contain blocks
and inner subprograms, The statement part of the compilation unit
becomes a call to this subprogram. This is only done if blocks are
present in the statement list of the body.
From-SVN: r260927
Bob Duff [Wed, 30 May 2018 08:56:35 +0000 (08:56 +0000)]
[Ada] Minor comment fix
2018-05-30 Bob Duff <duff@adacore.com>
gcc/ada/
* exp_ch7.adb: Minor comment fix.
From-SVN: r260926
Ed Schonberg [Wed, 30 May 2018 08:56:29 +0000 (08:56 +0000)]
[Ada] Unnesting: properly handle subprogram instantiations
2018-05-30 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb (Visit_Node): Handle properly subprogram instantiations
that have no corresponding body and appear as attributes of the
corresponding wrapper package declaration.
(Register_Subprogram): New subprogram, used for subprogram bodies and
for subprogram instantiations to enter callable entity into Subp table.
From-SVN: r260925
Hristian Kirtchev [Wed, 30 May 2018 08:56:23 +0000 (08:56 +0000)]
[Ada] Secondary stack implementation clean up
This patch reimplements the secondary stack runtime support as follows:
* The compiler interface remains unchanged. This applies to both types and
subprograms used by the compiler to create and manage secondary stacks.
* The secondary stack is no longer a doubly linked list of chunks.
* Various allocation scenarios are now handled by the same mechanism.
In addition, the patch introduces a lightweight private interface for testing
purposes.
------------
-- Source --
------------
-- comparator.ads
generic
type Field_Typ is private;
-- The type of the field being compared
with function Image (Val : Field_Typ) return String;
-- Field-to-String converted
procedure Comparator
(Field_Nam : String;
Actual_Val : Field_Typ;
Expected_Val : Field_Typ);
-- Compare actual value Actual_Val against expected value Expected_Val for
-- field Field_Nam. Emit an error if this is not the case.
-- comparator.adb
with Ada.Text_IO; use Ada.Text_IO;
procedure Comparator
(Field_Nam : String;
Actual_Val : Field_Typ;
Expected_Val : Field_Typ)
is
begin
if Actual_Val /= Expected_Val then
Put_Line (Field_Nam);
Put_Line (" Actual :" & Image (Actual_Val));
Put_Line (" Expected :" & Image (Expected_Val));
end if;
end Comparator;
-- debugger.ads
package Debugger is
Verbouse : constant Boolean := False;
-- Set to True in order to obtain verbouse output
procedure Output (Msg : String);
-- Emit Msg to standard output if Verbouse is True
end Debugger;
-- debugger.adb
with Ada.Text_IO; use Ada.Text_IO;
package body Debugger is
------------
-- Output --
------------
procedure Output (Msg : String) is
begin
if Verbouse then
Put_Line (Msg);
end if;
end Output;
end Debugger;
-- s-sestte.ads
package System.Secondary_Stack.Tester is
procedure Test_Dynamic_Stack_Dynamic_Chunks;
-- Test various properties of a dynamic stack's dynamic chunks
procedure Test_Dynamic_Stack_Illegal_Allocations;
-- Test whether illegal allocations on a dynamic stack are properly
-- detected and reported.
procedure Test_Dynamic_Stack_Static_Chunk;
-- Test various properties of a dynamic stack's static chunk
procedure Test_Dynamic_Stack_Zero_Chunk_Size;
-- Test various properties of a dynamic stack with default chunk size of
-- zero.
procedure Test_Static_Stack_Illegal_Allocations;
-- Test whether illegal allocations on a static stack are properly
-- detected and reported.
procedure Test_Static_Stack_Overflow;
-- Test whether overflow of a static stack's static chunk is properly
-- detected and reported.
procedure Test_Static_Stack_Static_Chunk;
-- Test various properties of a static chunk's static chunk
end System.Secondary_Stack.Tester;
-- s-sestte.adb
with Ada.Assertions; use Ada.Assertions;
with Ada.Text_IO; use Ada.Text_IO;
with System; use System;
with System.Parameters; use System.Parameters;
with System.Soft_Links; use System.Soft_Links;
with System.Storage_Elements; use System.Storage_Elements;
with Comparator;
with Debugger; use Debugger;
package body System.Secondary_Stack.Tester is
Units : constant := Standard'Maximum_Alignment;
-- Each allocation of the secondary stack is rouded up to the nearest
-- multiple of the maximum alignment. This value is called a "unit" in
-- order to facilitate further allocations.
-----------------------
-- Local subprograms --
-----------------------
procedure Compare_Boolean is
new Comparator
(Field_Typ => Boolean,
Image => Boolean'Image);
procedure Compare_Chunk_Count is
new Comparator
(Field_Typ => Chunk_Count,
Image => Chunk_Count'Image);
procedure Compare_Chunk_Id is
new Comparator
(Field_Typ => Chunk_Id,
Image => Chunk_Id'Image);
procedure Compare_Memory_Index is
new Comparator
(Field_Typ => Memory_Index,
Image => Memory_Index'Image);
procedure Compare_Memory_Size is
new Comparator
(Field_Typ => Memory_Size,
Image => Memory_Size'Image);
procedure Compare_MSWI is
new Comparator
(Field_Typ => Memory_Size_With_Invalid,
Image => Memory_Size_With_Invalid'Image);
procedure Initialize_Stack (Size : Memory_Size);
-- Create a new secondary stack for the calling task where the default
-- chunk size is Size.
procedure Match_Chunk
(Match_Nam : String;
Actual : Chunk_Info;
Expected : Chunk_Info);
-- Check whether actual chunk info Actual matches expected chunk info
-- Expected. Match_Nam is the name of the match.
procedure Match_Pointer
(Actual : Stack_Pointer_Info;
Expected : Stack_Pointer_Info);
-- Check whether actual pointer info Actual matches expected pointer info
-- Expected.
procedure Match_Stack
(Match_Nam : String;
Actual : Stack_Info;
Expected : Stack_Info);
-- Check whether actual stack info Stack matches expected stack info
-- Expected. Match_Nam is the name of the match.
procedure Test_Static_Chunk (Def_Chunk_Size : Memory_Size);
-- Common testing for properties of the static chunk for both static and
-- dynamic secondary stacks. Def_Chunk_Size denotes the default size of a
-- secondary stack chunk. This routine assumes that the secondary stack
-- can fit 12 * Units.
----------------------
-- Initialize_Stack --
----------------------
procedure Initialize_Stack (Size : Memory_Size) is
Stack : SS_Stack_Ptr;
begin
-- Obtain the secondary stack of the calling task
Stack := Get_Sec_Stack.all;
-- If the calling task has an existing secodnary stack, destroy it
-- because this scenario utilizes a custom secondary stack.
if Stack /= null then
-- Destroy the existing secondary stack because it will be replaced
-- with a new one.
SS_Free (Stack);
pragma Assert (Stack = null);
end if;
-- Create a brand new empty secondary stack
SS_Init (Stack, Size);
pragma Assert (Stack /= null);
-- Associate the secondary stack with the calling task
Set_Sec_Stack (Stack);
end Initialize_Stack;
-----------------
-- Match_Chunk --
-----------------
procedure Match_Chunk
(Match_Nam : String;
Actual : Chunk_Info;
Expected : Chunk_Info)
is
begin
Output (Match_Nam);
Compare_MSWI
("Size", Actual.Size,
Expected.Size);
Compare_MSWI
("Size_Up_To_Chunk", Actual.Size_Up_To_Chunk,
Expected.Size_Up_To_Chunk);
end Match_Chunk;
-------------------
-- Match_Pointer --
-------------------
procedure Match_Pointer
(Actual : Stack_Pointer_Info;
Expected : Stack_Pointer_Info)
is
begin
Compare_Memory_Index
("Byte", Actual.Byte,
Expected.Byte);
Compare_Chunk_Id
("Chunk", Actual.Chunk,
Expected.Chunk);
end Match_Pointer;
-----------------
-- Match_Stack --
-----------------
procedure Match_Stack
(Match_Nam : String;
Actual : Stack_Info;
Expected : Stack_Info)
is
begin
Output (Match_Nam);
Compare_Memory_Size
("Default_Chunk_Size", Actual.Default_Chunk_Size,
Expected.Default_Chunk_Size);
Compare_Boolean
("Freeable", Actual.Freeable,
Expected.Freeable);
Compare_Memory_Size
("High_Water_Mark", Actual.High_Water_Mark,
Expected.High_Water_Mark);
Compare_Chunk_Count
("Number_Of_Chunks", Actual.Number_Of_Chunks,
Expected.Number_Of_Chunks);
Match_Pointer (Actual.Top, Expected.Top);
end Match_Stack;
---------------------------------------
-- Test_Dynamic_Stack_Dynamic_Chunks --
---------------------------------------
procedure Test_Dynamic_Stack_Dynamic_Chunks is
Def_Chunk_Size : constant Memory_Size := 4 * Units;
Dummy_1 : Address;
Dummy_2 : Address;
Dummy_3 : Address;
Dummy_4 : Address;
Mark : Mark_Id;
begin
Output ("#### Test_DSDCs ####");
-- Create a brand new empty secondary stack
--
-- 1 2 3 4
-- +------------+
-- | |
-- +------------+
Initialize_Stack (Def_Chunk_Size);
Match_Stack
(Match_Nam => "Empty stack",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 0,
Number_Of_Chunks => 1,
Top => (Byte => 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "Empty stack, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Mark
-- |
-- 1 2 3 4
-- +------------+
-- | |
-- +------------+
Mark := SS_Mark;
-- Mark Top.Byte
-- | |
-- 1 2 3 4 1 2 3 4 5 6
-- +------------+ +---------------+
-- | |->|###############|
-- +------------+ +---------------+
-- 1 2 3 4 5 6 7 8 9
-- |
-- HWM
SS_Allocate (Dummy_1, 5 * Units);
Match_Stack
(Match_Nam => "After 5u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 9 * Units,
Number_Of_Chunks => 2,
Top => (Byte => (5 * Units) + 1, Chunk => 2)));
Match_Chunk
(Match_Nam => "After 5u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 5u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 5 * Units,
Size_Up_To_Chunk => 4 * Units));
-- Mark Top.Byte
-- | |
-- 1 2 3 4 1 2 3 4 5 1 2 3 4
-- +------------+ +---------------+ +------------+
-- | |->|###############|->|###### |
-- +------------+ +---------------+ +------------+
-- 1 2 3 4 5 6 7 8 9 10 11 12 13
-- |
-- HWM
--
-- Note that the size of Chunk 3 defaults to 4 because the request is
-- smaller than the default chunk size.
SS_Allocate (Dummy_2, 2 * Units);
Match_Stack
(Match_Nam => "After 2u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 11 * Units,
Number_Of_Chunks => 3,
Top => (Byte => (2 * Units) + 1, Chunk => 3)));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 5 * Units,
Size_Up_To_Chunk => 4 * Units));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 3",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 3),
Expected =>
(Size => 4 * Units,
Size_Up_To_Chunk => 9 * Units));
-- Top.Byte
-- |
-- 1 2 3 4 1 2 3 4 5 1 2 3 4
-- +------------+ +---------------+ +------------+
-- | | --> |###############| --> |###### |
-- +------------+ +---------------+ +------------+
-- 1 2 3 4 5 6 7 8 9 10 11 12 13
-- |
-- HWM
SS_Release (Mark);
-- Top.Byte
-- |
-- 1 2 3 4 1 2 3 4 5 1 2 3 4
-- +------------+ +---------------+ +------------+
-- |######### | --> |###############| --> |###### |
-- +------------+ +---------------+ +------------+
-- 1 2 3 4 5 6 7 8 9 10 11 12 13
-- |
-- HWM
SS_Allocate (Dummy_3, 3 * Units);
Match_Stack
(Match_Nam => "After 3u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 11 * Units,
Number_Of_Chunks => 3,
Top => (Byte => (3 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After 3u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 3u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 5 * Units,
Size_Up_To_Chunk => 4 * Units));
Match_Chunk
(Match_Nam => "After 3u allocation, chunk 3",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 3),
Expected =>
(Size => 4 * Units,
Size_Up_To_Chunk => 9 * Units));
-- Top.Byte
-- |
-- 1 2 3 4 1 2 3 4 5 6 7 8 9
-- +------------+ +------------------------+
-- |######### | --> |########################|
-- +------------+ +------------------------+
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- |
-- HWM
SS_Allocate (Dummy_4, 8 * Units);
Match_Stack
(Match_Nam => "After 8u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 12 * Units,
Number_Of_Chunks => 2,
Top => (Byte => (8 * Units) + 1, Chunk => 2)));
Match_Chunk
(Match_Nam => "After 8u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 8u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 8 * Units,
Size_Up_To_Chunk => 4 * Units));
exception
when others =>
Put_Line ("Test_DSDCs: unexpected exception");
end Test_Dynamic_Stack_Dynamic_Chunks;
--------------------------------------------
-- Test_Dynamic_Stack_Illegal_Allocations --
--------------------------------------------
procedure Test_Dynamic_Stack_Illegal_Allocations is
Def_Chunk_Size : constant Memory_Size := 4 * Units;
Dummy_1 : Address;
Dummy_2 : Address;
begin
Output ("#### Test_DSIA ####");
-- Create a brand new empty secondary stack
--
-- 1 2 3 4
-- +------------+
-- | |
-- +------------+
Initialize_Stack (Def_Chunk_Size);
Match_Stack
(Match_Nam => "Empty stack",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 0,
Number_Of_Chunks => 1,
Top => (Byte => 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "Empty stack, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- It should not be possible to allocate an object of size zero
Zero_Allocation : begin
SS_Allocate (Dummy_1, 0);
Put_Line ("Test_DSIA: ERROR: zero allocation succeeded");
exception
when Assertion_Error =>
Match_Stack
(Match_Nam => "After zero allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 0,
Number_Of_Chunks => 1,
Top => (Byte => 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After zero allocation",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
when others =>
Put_Line ("Test_DSIA: zero allocation: unexpected exception");
end Zero_Allocation;
-- It should not be possible to allocate an object of negative size
Negative_Allocation : begin
SS_Allocate (Dummy_2, -8);
Put_Line ("Test_DSIA: ERROR: negative allocation succeeded");
exception
when Assertion_Error =>
Match_Stack
(Match_Nam => "After negative allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 0,
Number_Of_Chunks => 1,
Top => (Byte => 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After negative allocation",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
when others =>
Put_Line ("Test_DSIA: negative allocation: unexpected exception");
end Negative_Allocation;
exception
when others =>
Put_Line ("Test_DSIA: unexpected exception");
end Test_Dynamic_Stack_Illegal_Allocations;
-------------------------------------
-- Test_Dynamic_Stack_Static_Chunk --
-------------------------------------
procedure Test_Dynamic_Stack_Static_Chunk is
Def_Chunk_Size : constant Memory_Size := 12 * Units;
Dummy_1 : Address;
Dummy_2 : Address;
Dummy_3 : Address;
Dummy_4 : Address;
Mark_1 : Mark_Id;
Mark_2 : Mark_Id;
begin
Output ("#### Test_DSSC ####");
-- Create a brand new empty secondary stack
--
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------+
-- | |
-- +------------------------------------+
Initialize_Stack (Def_Chunk_Size);
Test_Static_Chunk (Def_Chunk_Size);
exception
when others =>
Put_Line ("Test_DSSC: unexpected exception");
end Test_Dynamic_Stack_Static_Chunk;
----------------------------------------
-- Test_Dynamic_Stack_Zero_Chunk_Size --
----------------------------------------
procedure Test_Dynamic_Stack_Zero_Chunk_Size is
Def_Chunk_Size : constant Memory_Size := 0;
Dummy_1 : Address;
Dummy_2 : Address;
Mark : Mark_Id;
begin
Output ("#### Test_DSZCS ####");
-- Create a brand new empty secondary stack
--
-- ++
-- ||
-- ++
Initialize_Stack (Def_Chunk_Size);
Match_Stack
(Match_Nam => "Empty stack",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 0,
Number_Of_Chunks => 1,
Top => (Byte => 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "Empty stack, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Mark
-- |
-- 1
-- ++
-- ||
-- ++
Mark := SS_Mark;
-- Mark Top.Byte
-- | |
-- | 1 2 3 4
-- ++ +---------+
-- ||->|#########|
-- ++ +---------+
-- 1 2 3
-- |
-- HWM
SS_Allocate (Dummy_1, 3 * Units);
Match_Stack
(Match_Nam => "After 3u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 3 * Units,
Number_Of_Chunks => 2,
Top => (Byte => (3 * Units) + 1, Chunk => 2)));
Match_Chunk
(Match_Nam => "After 3u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 3u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 3 * Units,
Size_Up_To_Chunk => 0));
-- Mark Top.Byte
-- | |
-- | 1 2 3 1 2 3
-- ++ +---------+ +------+
-- ||->|#########|->|######|
-- ++ +---------+ +------+
-- 1 2 3 4 5
-- |
-- HWM
SS_Allocate (Dummy_2, 2 * Units);
Match_Stack
(Match_Nam => "After 2u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 5 * Units,
Number_Of_Chunks => 3,
Top => (Byte => (2 * Units) + 1, Chunk => 3)));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 3 * Units,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 3",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 3),
Expected =>
(Size => 2 * Units,
Size_Up_To_Chunk => 3 * Units));
-- Top.Byte
-- |
-- | 1 2 3 1 2
-- ++ +---------+ +------+
-- ||->|#########|->|######|
-- ++ +---------+ +------+
-- 1 2 3 4 5
-- |
-- HWM
SS_Release (Mark);
-- Top.Byte
-- |
-- 1 2 3 4 5 6 7
-- ++ +------------------+
-- ||->|##################|
-- ++ +------------------+
-- 1 2 3 4 5 6
-- |
-- HWM
SS_Allocate (Dummy_2, 6 * Units);
Match_Stack
(Match_Nam => "After 6u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 6 * Units,
Number_Of_Chunks => 2,
Top => (Byte => (6 * Units) + 1, Chunk => 2)));
Match_Chunk
(Match_Nam => "After 6u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
Match_Chunk
(Match_Nam => "After 6u allocation, chunk 2",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 2),
Expected =>
(Size => 6 * Units,
Size_Up_To_Chunk => 0));
exception
when others =>
Put_Line ("Test_DSZCS: unexpected exception");
end Test_Dynamic_Stack_Zero_Chunk_Size;
-----------------------
-- Test_Static_Chunk --
-----------------------
procedure Test_Static_Chunk (Def_Chunk_Size : Memory_Size) is
Dummy_1 : Address;
Dummy_2 : Address;
Dummy_3 : Address;
Dummy_4 : Address;
Mark_1 : Mark_Id;
Mark_2 : Mark_Id;
begin
-- This routine assumes an empty secondary stack
Match_Stack
(Match_Nam => "Empty stack",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 0,
Number_Of_Chunks => 1,
Top => (Byte => 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "Empty stack, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Top.Byte
-- |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |############
-- +------------------------------------. . .
-- |
-- HWM
SS_Allocate (Dummy_1, 4 * Units);
Match_Stack
(Match_Nam => "After 4u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 4 * Units,
Number_Of_Chunks => 1,
Top => (Byte => (4 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After 4u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Mark_1
-- Top.Byte
-- |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |############
-- +------------------------------------. . .
-- |
-- HWM
Mark_1 := SS_Mark;
-- Mark_1
-- | Top.Byte
-- | |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |###########################
-- +------------------------------------. . .
-- |
-- HWM
SS_Allocate (Dummy_2, 5 * Units);
Match_Stack
(Match_Nam => "After 5u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 9 * Units,
Number_Of_Chunks => 1,
Top => (Byte => (9 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After 5u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Mark_1 Mark_2
-- | Top.Byte
-- | |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |###########################
-- +------------------------------------. . .
-- |
-- HWM
Mark_2 := SS_Mark;
-- Mark_1 Mark_2
-- | | Top.Byte
-- | | |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |#################################
-- +------------------------------------. . .
-- |
-- HWM
SS_Allocate (Dummy_3, 2 * Units);
Match_Stack
(Match_Nam => "After 2u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 11 * Units,
Number_Of_Chunks => 1,
Top => (Byte => (11 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After 2u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Mark_1
-- | Top.Byte
-- | |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |#################################
-- +------------------------------------. . .
-- |
-- HWM
SS_Release (Mark_2);
Match_Stack
(Match_Nam => "After Mark_2 release",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 11 * Units,
Number_Of_Chunks => 1,
Top => (Byte => (9 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After Mark_2 release, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Top.Byte
-- |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |#################################
-- +------------------------------------. . .
-- |
-- HWM
SS_Release (Mark_1);
Match_Stack
(Match_Nam => "After Mark_1 release",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 11 * Units,
Number_Of_Chunks => 1,
Top => (Byte => (4 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After Mark_1 release, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
-- Top.Byte
-- |
-- 1 2 3 4 5 6 7 8 9 10 11 12
-- +------------------------------------. . .
-- |#################################
-- +------------------------------------. . .
-- |
-- HWM
SS_Allocate (Dummy_4, 6 * Units);
Match_Stack
(Match_Nam => "After 6u allocation",
Actual => Get_Stack_Info (Get_Sec_Stack.all),
Expected =>
(Default_Chunk_Size => Def_Chunk_Size,
Freeable => True,
High_Water_Mark => 11 * Units,
Number_Of_Chunks => 1,
Top => (Byte => (10 * Units) + 1, Chunk => 1)));
Match_Chunk
(Match_Nam => "After 6u allocation, chunk 1",
Actual => Get_Chunk_Info (Get_Sec_Stack.all, 1),
Expected =>
(Size => Def_Chunk_Size,
Size_Up_To_Chunk => 0));
end Test_Static_Chunk;
-------------------------------------------
-- Test_Static_Stack_Illegal_Allocations --
-------------------------------------------
procedure Test_Static_Stack_Illegal_Allocations is
Dummy_1 : Address;
Dummy_2 : Address;
begin
Output ("#### Test_SSIA ####");
-- It should not be possible to allocate an object of size zero
Zero_Allocation : begin
SS_Allocate (Dummy_1, 0);
Put_Line ("Test_SSIA: ERROR: zero allocation succeeded");
exception
when Assertion_Error =>
Output ("After zero allocation");
when others =>
Put_Line ("Test_SSIA: zero allocation: unexpected exception");
end Zero_Allocation;
-- It should not be possible to allocate an object of negative size
Negative_Allocation : begin
SS_Allocate (Dummy_2, -8);
Put_Line ("Test_SSIA: ERROR: negative allocation succeeded");
exception
when Assertion_Error =>
Output ("After negative allocation");
when others =>
Put_Line ("Test_SSIA: negative allocation: unexpected exception");
end Negative_Allocation;
exception
when others =>
Put_Line ("Test_SSIA: unexpected exception");
end Test_Static_Stack_Illegal_Allocations;
--------------------------------
-- Test_Static_Stack_Overflow --
--------------------------------
procedure Test_Static_Stack_Overflow is
Info : constant Stack_Info := Get_Stack_Info (Get_Sec_Stack.all);
Dummy : Address;
begin
Output ("#### Test_SSO ####");
-- Try to overflow the static chunk
Overflow : begin
SS_Allocate (Dummy, Storage_Offset (Info.Default_Chunk_Size));
Put_Line ("Test_SSO: ERROR: Overflow not detected");
exception
when Storage_Error =>
Output ("After overflow");
when others =>
Put_Line ("Test_SSO: overflow: unexpected exception");
end Overflow;
exception
when others =>
Put_Line ("Test_SSO: unexpected exception");
end Test_Static_Stack_Overflow;
------------------------------------
-- Test_Static_Stack_Static_Chunk --
------------------------------------
procedure Test_Static_Stack_Static_Chunk is
Info : Stack_Info;
begin
Output ("#### Test_SSSC ####");
Info := Get_Stack_Info (Get_Sec_Stack.all);
Test_Static_Chunk (Info.Default_Chunk_Size);
exception
when others =>
Put_Line ("Test_SSSC: unexpected exception");
end Test_Static_Stack_Static_Chunk;
end System.Secondary_Stack.Tester;
-- main.adb
with Ada.Text_IO; use Ada.Text_IO;
with System.Parameters; use System.Parameters;
with System.Secondary_Stack.Tester; use System.Secondary_Stack.Tester;
procedure Main is
task Tester;
-- The various scenarios are tested within a task because this guarantees
-- that on a normal compilation, the task's secondary stack is created on
-- the heap and can be safely freed and replaced with a custom one.
task body Tester is
begin
if Sec_Stack_Dynamic then
Test_Dynamic_Stack_Static_Chunk;
Test_Dynamic_Stack_Dynamic_Chunks;
Test_Dynamic_Stack_Zero_Chunk_Size;
Test_Dynamic_Stack_Illegal_Allocations;
else
Test_Static_Stack_Static_Chunk;
Test_Static_Stack_Overflow;
Test_Static_Stack_Illegal_Allocations;
end if;
end Tester;
begin null; end Main;
-----------------
-- Compilation --
-----------------
$ gnatmake -a -f -q -gnata -gnatws main.adb
$ ./main
2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* libgnat/s-secsta.adb: Reimplement the secondary stack support.
* libgnat/s-secsta.ads: Update the documentation of all routines in the
public part of the package. Reimplement the private part of the
package to account for the new secondary stack structure. Add types
and subprograms for testing purposes. Add several documentation
sections.
From-SVN: r260924
Hristian Kirtchev [Wed, 30 May 2018 08:56:18 +0000 (08:56 +0000)]
[Ada] Minor reformatting
2018-05-30 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* exp_aggr.adb, exp_ch3.adb, exp_ch4.adb, exp_ch7.adb, exp_unst.adb,
exp_util.adb, exp_util.ads, libgnat/a-calcon.adb, libgnat/a-calcon.ads,
libgnat/s-os_lib.adb, repinfo.adb, sem_ch3.adb, sem_disp.adb,
sem_disp.ads, sem_util.adb: Minor reformatting.
From-SVN: r260923
Arnaud Charlet [Wed, 30 May 2018 08:56:12 +0000 (08:56 +0000)]
[Ada] Move special flags for Ada runtime files from Makefile.in to Makefile.rtl
2018-05-30 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* gcc-interface/Makefile.in: Move special flags for Ada runtime files
from here...
* Makefile.rtl: ... to here. Update comments. Protect call to
"GCC_FOR_TARGET" in case target_os isn't defined.
From-SVN: r260922
Arnaud Charlet [Wed, 30 May 2018 08:56:05 +0000 (08:56 +0000)]
[Ada] Move target pair settings in Makefiles
2018-05-30 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* gcc-interface/Makefile.in: Move target pair settings from here...
* Makefile.rtl: ... to here.
(setup-rts): New target.
From-SVN: r260921
Jonathan Wakely [Wed, 30 May 2018 08:18:33 +0000 (09:18 +0100)]
Replace dead store with early return
* typeck.c (cxx_sizeof_or_alignof_type): Return size_one_node instead
of using it in dead store.
From-SVN: r260920
projects / gcc.git / log