gcc.git
4 years agoAlways use name from c_interop_kinds_table for -fc-prototypes.
Thomas Koenig [Sun, 19 Jul 2020 15:27:45 +0000 (17:27 +0200)]
Always use name from c_interop_kinds_table for -fc-prototypes.

When a user specified a KIND that was a parameter taking the value
of an iso_c_binding KIND, the code used the name of that parameter
to look up the type name.  Corrected by always looking it up in
the table of C interop kinds (which was previously done for
non-C-interop types, anyway).

gcc/fortran/ChangeLog:

PR fortran/96220
* dump-parse-tree.c (get_c_type_name): Always use the entries from
c_interop_kinds_table to find the correct C type.

4 years agox86: Add __cpuidex and include guard to <cpuid.h>
H.J. Lu [Sat, 18 Jul 2020 11:43:10 +0000 (04:43 -0700)]
x86: Add __cpuidex and include guard to <cpuid.h>

Add

void __cpuidex (int __cpuid_info[4], int __leaf, int __subleaf);

as well as include guard to <cpuid.h>.

gcc/

PR target/95973
PR target/96238
* config/i386/cpuid.h: Add include guard.
(__cpuidex): New.

gcc/testsuite/

PR target/95973
PR target/96238
* gcc.target/i386/pr95973.c: New test.

4 years agoFix handling of implicit_pure by checking if non-pure procedures are called.
Thomas Koenig [Sun, 19 Jul 2020 10:23:43 +0000 (12:23 +0200)]
Fix handling of implicit_pure by checking if non-pure procedures are called.

Procedures are marked as implicit_pure if they fulfill the criteria of
pure procedures.  In this case, a procedure was not marked as not being
implicit_pure which called another procedure, which had not yet been
marked as not being implicit_impure.

Fixed by iterating over all procedures, setting callers of procedures
which are non-pure and non-implicit_pure as non-implicit_pure and
doing this until no more procedure has been changed.

gcc/fortran/ChangeLog:

2020-07-19  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/96018
* frontend-passes.c (gfc_check_externals): Adjust formatting.
(implicit_pure_call): New function.
(implicit_pure_expr): New function.
(gfc_fix_implicit_pure): New function.
* gfortran.h (gfc_fix_implicit_pure): New prototype.
* parse.c (translate_all_program_units): Call gfc_fix_implicit_pure.

4 years agogcc.dg/attr-copy-6.c: Require visibility.
Hans-Peter Nilsson [Sun, 19 Jul 2020 03:55:18 +0000 (05:55 +0200)]
gcc.dg/attr-copy-6.c: Require visibility.

Another trivial one.

gcc/testsuite:
* gcc.dg/attr-copy-6.c: Require visibility.

4 years agogcc.dg/Wno-frame-address.c: Skip for cris and mmix.
Hans-Peter Nilsson [Sun, 19 Jul 2020 03:18:57 +0000 (05:18 +0200)]
gcc.dg/Wno-frame-address.c: Skip for cris and mmix.

Long-standing FAIL remedied; committed.  Maybe better to list
the targets that *do* support arbitrary frame access?

gcc/testsuite:
* gcc.dg/Wno-frame-address.c: Skip for cris and mmix.

4 years agoDaily bump.
GCC Administrator [Sun, 19 Jul 2020 00:16:22 +0000 (00:16 +0000)]
Daily bump.

4 years agotestsuite: Fix pragma-eof.c failure due to added line to the test.
Jakub Jelinek [Sat, 18 Jul 2020 21:09:56 +0000 (23:09 +0200)]
testsuite: Fix pragma-eof.c failure due to added line to the test.

2020-07-18  Jakub Jelinek  <jakub@redhat.com>

* c-c++-common/cpp/pragma-eof.c: Use .+3 instead of 6 in
dg-error.

4 years agofortran: Restore translation to hint.
David Edelsohn [Thu, 2 Jul 2020 20:03:03 +0000 (16:03 -0400)]
fortran: Restore translation to hint.

This patch restore translation for the variable hint.  The translation
tag conflicted with the previous declaration of hint as char[] and
broke bootstrap, so the translation tags were removed.  The
declaration was changed to char *.  This patch restores the translation
tags to the string.

gcc/fortran/ChangeLog

2020-07-18  David Edelsohn  <dje.gcc@gmail.com>

* check.c (gfc_invalid_boz): Mark hint for translation using _().

4 years agotestsuite: fix goacc/finalize-1.f "original" regex for 32 bits.
David Edelsohn [Fri, 17 Jul 2020 23:38:35 +0000 (19:38 -0400)]
testsuite: fix goacc/finalize-1.f "original" regex for 32 bits.

The "bias" portion of the regex for "original" expects

bias: (integer(kind=<N>) parm.0.data - (integer(kind=<N>)) del_f_p.data

(or cpo_f_p.data)

on 32 bit platforms, the dump file can show (signed int) instead of
(integer(kind=8)... .  This patch adjusts the regex to allow any content
containing the word int between the parentheses.

2020-07-18  David Edelsohn  <dje.gcc@gmail.com>

gcc/testsuite/ChangeLog

* gfortran.dg/goacc/finalize-1.f: Adjust regex for 32 bits.

4 years agox86-64: Define ASM_OUTPUT_ALIGNED_DECL_LOCAL
H.J. Lu [Fri, 26 Jun 2020 20:59:31 +0000 (13:59 -0700)]
x86-64: Define ASM_OUTPUT_ALIGNED_DECL_LOCAL

Define ASM_OUTPUT_ALIGNED_DECL_LOCAL for large local common symbol.

gcc/

PR target/95620
* config/i386/x86-64.h (ASM_OUTPUT_ALIGNED_DECL_LOCAL): New.

libgomp/

PR target/95620
* testsuite/libgomp.c/pr95620.c: New test.

4 years agotestsuite/c-c++-common/cpp/pragma-eof.c: Add missing require fopenmp
Hans-Peter Nilsson [Sat, 18 Jul 2020 03:24:46 +0000 (05:24 +0200)]
testsuite/c-c++-common/cpp/pragma-eof.c: Add missing require fopenmp

Committed as obvious.  Gets rid of a spurious failure for mmix.

gcc/testsuite:
* c-c++-common/cpp/pragma-eof.c: Require fopenmp.

4 years agors6000: Generate _Decimal128 to _Decimal32 hardware conversion instructions
Peter Bergner [Sat, 18 Jul 2020 02:06:30 +0000 (21:06 -0500)]
rs6000: Generate _Decimal128 to _Decimal32 hardware conversion instructions

We do not currently generate hardware conversion instructions when
converting from _Decimal128 to _Decimal32.  There is no one instruction
that does the conversion, so we currently call the __dpd_trunctdsd2
lib function to do the conversion for us.  However, there is a short
sequence of dfp hardware instructions that will do the conversion
correctly.

2020-07-17  Peter Bergner  <bergner@linux.ibm.com>

gcc/
PR target/92488
* config/rs6000/dfp.md (trunctdsd2): New define_insn.
* config/rs6000/rs6000.md (define_attr "isa"): Add p9.
(define_attr "enabled"): Handle p9.

gcc/testsuite/
PR target/92488
* gcc.target/powerpc/convert-fp-128.c (bl, drsp, drdpq): Update counts.
(__dpd_trunctdsd2): Make conditional on !hard_dfp.
(__dpd_extendsddd2, __dpd_extendsdtd2, __dpd_truncddsd2,
__dpd_extendddtd2, __dpd_trunctddd2): Use !hard_dfp.
* gcc.target/powerpc/pr92488.c: New test.

4 years agoDaily bump.
GCC Administrator [Sat, 18 Jul 2020 00:16:24 +0000 (00:16 +0000)]
Daily bump.

4 years agolibgo: update to Go 1.14.6 release
Ian Lance Taylor [Fri, 17 Jul 2020 19:30:51 +0000 (12:30 -0700)]
libgo: update to Go 1.14.6 release

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/243317

4 years agolibstdc++, coroutine: Add missing constexpr markers.
Iain Sandoe [Sun, 12 Jul 2020 19:16:21 +0000 (20:16 +0100)]
libstdc++, coroutine: Add missing constexpr markers.

The methods of the trivial awaitables are intended to
be constexpr.

libstdc++-v3/ChangeLog:

* include/std/coroutine: Mark the methods of the
trivial awaitables as constexpr.

4 years agoc++: Diagnose cv-qualified decltype(auto) [PR79815]
Marek Polacek [Wed, 8 Jul 2020 23:45:34 +0000 (19:45 -0400)]
c++: Diagnose cv-qualified decltype(auto) [PR79815]

"If the placeholder is the decltype(auto) type-specifier, T shall be the
placeholder alone." but we weren't detecting "const decltype(auto)".

I've just expanded the existing diagnostic detecting "decltype(auto) &"
and similar.

gcc/cp/ChangeLog:

PR c++/79815
* decl.c (grokdeclarator): Detect cv-qual decltype(auto).
* pt.c (do_auto_deduction): Likewise.

gcc/testsuite/ChangeLog:

PR c++/79815
* g++.dg/cpp1y/auto-fn59.C: New test.

4 years agomiddle-end: Prefer TRULY_NOOP_TRUNCATION_MODES_P over raw target hook.
Roger Sayle [Fri, 17 Jul 2020 13:06:45 +0000 (14:06 +0100)]
middle-end: Prefer TRULY_NOOP_TRUNCATION_MODES_P over raw target hook.

2020-07-16  Roger Sayle  <roger@nextmovesoftware.com>

gcc/ChangeLog
* function.c (assign_parm_setup_block): Use the macro
TRULY_NOOP_TRUNCATION_MODES_P instead of calling
targetm.truly_noop_truncation directly.

4 years agox86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256
H.J. Lu [Mon, 13 Jul 2020 16:07:00 +0000 (09:07 -0700)]
x86: Rename VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256

Since ix86_emit_swsqrtsf shouldn't be called with DF vector modes, rename
VF_AVX512VL_VF1_128_256 to VF1_AVX512ER_128_256 and drop DF vector modes.

gcc/

PR target/96186
PR target/88713
* config/i386/sse.md (VF_AVX512VL_VF1_128_256): Renamed to ...
(VF1_AVX512ER_128_256): This.  Drop DF vector modes.
(rsqrt<mode>2): Replace VF_AVX512VL_VF1_128_256 with
VF1_AVX512ER_128_256.

gcc/testsuite/

PR target/96186
PR target/88713
* gcc.target/i386/pr88713-3.c: New test.

4 years agoAArch64: Add test for -mcpu=native
Tamar Christina [Fri, 17 Jul 2020 12:13:12 +0000 (13:13 +0100)]
AArch64: Add test for -mcpu=native

This adds some tests to the GCC testsuite for testing the
-mcpu=native code.

gcc/testsuite/ChangeLog:

* gcc.target/aarch64/cpunative/aarch64-cpunative.exp: New test.
* gcc.target/aarch64/cpunative/info_0: New test.
* gcc.target/aarch64/cpunative/info_1: New test.
* gcc.target/aarch64/cpunative/info_10: New test.
* gcc.target/aarch64/cpunative/info_11: New test.
* gcc.target/aarch64/cpunative/info_12: New test.
* gcc.target/aarch64/cpunative/info_13: New test.
* gcc.target/aarch64/cpunative/info_14: New test.
* gcc.target/aarch64/cpunative/info_15: New test.
* gcc.target/aarch64/cpunative/info_2: New test.
* gcc.target/aarch64/cpunative/info_3: New test.
* gcc.target/aarch64/cpunative/info_4: New test.
* gcc.target/aarch64/cpunative/info_5: New test.
* gcc.target/aarch64/cpunative/info_6: New test.
* gcc.target/aarch64/cpunative/info_7: New test.
* gcc.target/aarch64/cpunative/info_8: New test.
* gcc.target/aarch64/cpunative/info_9: New test.
* gcc.target/aarch64/cpunative/native_cpu_0.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_1.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_10.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_11.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_12.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_13.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_14.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_15.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_2.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_3.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_4.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_5.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_6.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_7.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_8.c: New test.
* gcc.target/aarch64/cpunative/native_cpu_9.c: New test.

4 years agoTestuite: Document environment setting directives
Tamar Christina [Fri, 17 Jul 2020 12:12:46 +0000 (13:12 +0100)]
Testuite: Document environment setting directives

This document some of the existing DejaGnu directives to modify
environment variables before test or compiler invocations.

gcc/ChangeLog:

* doc/sourcebuild.texi (dg-set-compiler-env-var,
dg-set-target-env-var): Document.

4 years agoTestsuite: Make it easier to debug environment setting functions
Tamar Christina [Fri, 17 Jul 2020 12:12:23 +0000 (13:12 +0100)]
Testsuite: Make it easier to debug environment setting functions

This adds verbose output to dg-set-compiler-env-var and dg-set-target-env-var
so you can actually see what they're setting when you add -v -v.

gcc/testsuite/ChangeLog:

* lib/gcc-dg.exp (dg-set-compiler-env-var, dg-set-target-env-var): Add
verbose output.

4 years agoArm: Add GCC_CPUINFO override
Tamar Christina [Fri, 17 Jul 2020 12:12:00 +0000 (13:12 +0100)]
Arm: Add GCC_CPUINFO override

This adds an in intentionally undocumented environment variable
GCC_CPUINFO which can be used to test -mcpu=native.

Tests using these are added later on.

gcc/ChangeLog:

* config/arm/driver-arm.c (host_detect_local_cpu): Add GCC_CPUINFO.

4 years agoAArch64: Add GCC_CPUINFO override
Tamar Christina [Fri, 17 Jul 2020 12:10:53 +0000 (13:10 +0100)]
AArch64: Add GCC_CPUINFO override

This adds an in intentionally undocumented environment variable
GCC_CPUINFO which can be used to test -mcpu=native.

Tests using this are added later on.

gcc/ChangeLog:

* config/aarch64/driver-aarch64.c (host_detect_local_cpu):
Add GCC_CPUINFO.

4 years agoAArch64: Fix bugs in -mcpu=native detection.
Tamar Christina [Fri, 17 Jul 2020 12:10:28 +0000 (13:10 +0100)]
AArch64: Fix bugs in -mcpu=native detection.

This patch fixes a couple of issues in AArch64's -mcpu=native processing:

The buffer used to read the lines from /proc/cpuinfo is 128 bytes long.  While
this was enough in the past with the increase in architecture extensions it is
no longer enough.   It results in two bugs:

1) No option string longer than 127 characters is correctly parsed.  Features
   that are supported are silently ignored.

2) It incorrectly enables features that are not present on the machine:
  a) It checks for substring matching instead of full word matching.  This makes
     it incorrectly detect sb support when ssbs is provided instead.
  b) Due to the truncation at the 127 char border it also incorrectly enables
     features due to the full feature being cut off and the part that is left
     accidentally enables something else.

This breaks -mcpu=native detection on some of our newer system.

The patch fixes these issues by reading full lines up to the \n in a string.
This gives us the full feature line.  Secondly it creates a set from this string
to:

 1) Reduce matching complexity from O(n*m) to O(n*logm).
 2) Perform whole word matching instead of substring matching.

To make this code somewhat cleaner I also changed from using char* to using
std::string and std::set.

Note that I have intentionally avoided the use of ifstream and stringstream
to make it easier to backport.  I have also not change the substring matching
for the initial line classification as I cannot find a documented cpuinfo format
which leads me to believe there may be kernels out there that require this which
may be why the original code does this.

I also do not want this to break if the kernel adds a new line that is long and
indents the file by two tabs to keep everything aligned.  In short I think an
imprecise match is the right thing here.

Test for this is added as the last thing in this series as it requires some
changes to be made to be able to test this.

gcc/ChangeLog:

* config/aarch64/driver-aarch64.c (INCLUDE_SET): New.
(parse_field): Use std::string.
(split_words, readline, find_field): New.
(host_detect_local_cpu): Fix truncation issues.

4 years agoamdgcn: Fix elf.h build issue
Andrew Stubbs [Fri, 17 Jul 2020 10:45:34 +0000 (11:45 +0100)]
amdgcn: Fix elf.h build issue

Allow building on systems with elf.h that includes AMDGPU definitions,
partially or completely.

gcc/ChangeLog:

* config/gcn/mkoffload.c (EM_AMDGPU): Undefine before defining.
(ELFOSABI_AMDGPU_HSA): Likewise.
(ELFABIVERSION_AMDGPU_HSA): Likewise.
(EF_AMDGPU_MACH_AMDGCN_GFX803): Likewise.
(EF_AMDGPU_MACH_AMDGCN_GFX900): Likewise.
(EF_AMDGPU_MACH_AMDGCN_GFX906): Likewise.
(reserved): Delete.

4 years agovector creation from two parts of two vectors produces TBL rather than ins (PR 93720)
Dmitrij Pochepko [Fri, 17 Jul 2020 09:24:46 +0000 (10:24 +0100)]
vector creation from two parts of two vectors produces TBL rather than ins (PR 93720)

The following patch enables vector permutations optimization by trying
to use ins instruction instead of slow and generic tbl.

example:

vector float f0(vector float a, vector float b)
{
  return __builtin_shuffle (a, a, (vector int){3, 1, 2, 3});
}

was compiled into:
...
adrp    x0, .LC0
ldr     q1, [x0, #:lo12:.LC0]
tbl     v0.16b, {v0.16b}, v1.16b
...

and after patch:
...
ins     v0.s[0], v0.s[3]
...

bootstrapped and tested on aarch64-linux-gnu with no regressions

gcc/ChangeLog:

2020-07-17  Andrew Pinski  <apinksi@marvell.com>

PR target/93720
* config/aarch64/aarch64.c (aarch64_evpc_ins): New function.
(aarch64_expand_vec_perm_const_1): Call it.
* config/aarch64/aarch64-simd.md (aarch64_simd_vec_copy_lane): Make
public, and add a "@" prefix.

gcc/testsuite/ChangeLog:

2020-07-17  Andrew Pinski  <apinksi@marvell.com>

PR target/93720
* gcc.target/aarch64/vins-1.c: New test.
* gcc.target/aarch64/vins-2.c: New test.
* gcc.target/aarch64/vins-3.c: New test.

Co-Authored-By: Dmitrij Pochepko <dmitrij.pochepko@bell-sw.com>
4 years ago__builtin_shuffle sometimes should produce zip1 rather than TBL (PR82199)
Dmitrij Pochepko [Fri, 17 Jul 2020 09:20:12 +0000 (10:20 +0100)]
__builtin_shuffle sometimes should produce zip1 rather than TBL (PR82199)

The following patch enables vector permutations optimization by using
another vector element size when applicable.  It allows usage of simpler
instructions in applicable cases.

example:

vector float f(vector float a, vector float b)
{
  return __builtin_shuffle  (a, b, (vector int){0, 1, 4,5});
}

was compiled into:
...
adrp    x0, .LC0
ldr     q2, [x0, #:lo12:.LC0]
tbl     v0.16b, {v0.16b - v1.16b}, v2.16b
...

and after patch:
...
zip1    v0.2d, v0.2d, v1.2d
...

bootstrapped and tested on aarch64-linux-gnu with no regressions

gcc/ChangeLog:

2020-07-17  Andrew Pinski  <apinksi@marvell.com>

PR target/82199
* config/aarch64/aarch64.c (aarch64_evpc_reencode): New function.
(aarch64_expand_vec_perm_const_1): Call it.

gcc/testsuite/ChangeLog:

2020-07-17  Andrew Pinski  <apinksi@marvell.com>

PR target/82199
* gcc.target/aarch64/vdup_n_3.c: New test.
* gcc.target/aarch64/vzip_1.c: New test.
* gcc.target/aarch64/vzip_2.c: New test.
* gcc.target/aarch64/vzip_3.c: New test.
* gcc.target/aarch64/vzip_4.c: New test.

Co-Authored-By: Dmitrij Pochepko <dmitrij.pochepko@bell-sw.com>
4 years agoAArch64: Add flags in built-in functions [PR94442]
xiezhiheng [Fri, 17 Jul 2020 09:00:37 +0000 (10:00 +0100)]
AArch64: Add flags in built-in functions [PR94442]

2020-07-17  Zhiheng Xie  <xiezhiheng@huawei.com>

gcc/ChangeLog:

* config/aarch64/aarch64-builtins.c (enum aarch64_type_qualifiers):
Add new field flags.
(VAR1): Add new field FLAG in macro.
(VAR2): Likewise.
(VAR3): Likewise.
(VAR4): Likewise.
(VAR5): Likewise.
(VAR6): Likewise.
(VAR7): Likewise.
(VAR8): Likewise.
(VAR9): Likewise.
(VAR10): Likewise.
(VAR11): Likewise.
(VAR12): Likewise.
(VAR13): Likewise.
(VAR14): Likewise.
(VAR15): Likewise.
(VAR16): Likewise.
(aarch64_general_fold_builtin): Likewise.
(aarch64_general_gimple_fold_builtin): Likewise.
* config/aarch64/aarch64-simd-builtins.def: Add default flag for
each built-in function.
* config/aarch64/geniterators.sh: Add new field in BUILTIN macro.

4 years agogcc-changelog: Fix typo in output
Jonathan Wakely [Fri, 17 Jul 2020 08:53:19 +0000 (09:53 +0100)]
gcc-changelog: Fix typo in output

contrib/ChangeLog:

* gcc-changelog/git_update_version.py: Fix typo.

4 years agoFix PR96127
Andreas Krebbel [Fri, 17 Jul 2020 06:49:29 +0000 (08:49 +0200)]
Fix PR96127

In s390_expand_insv the movstrict patterns are always generated with a
CC clobber although only movstricthi actually needs one.  The patch
invokes the expanders instead of constructing the pattern by hand.

Bootstrapped and regression tested on s390x.

gcc/ChangeLog:

PR target/96127
* config/s390/s390.c (s390_expand_insv): Invoke the movstrict
expanders to generate the pattern.
* config/s390/s390.md ("*movstricthi", "*movstrictqi"): Remove the
'*' to have callable expanders.

gcc/testsuite/ChangeLog:

PR target/96127
* gcc.target/s390/pr96127.c: New test.

4 years agors6000/test: Add -fno-vect-cost-model to conv-vectorize-[12].c
Kewen Lin [Fri, 17 Jul 2020 05:31:03 +0000 (00:31 -0500)]
rs6000/test: Add -fno-vect-cost-model to conv-vectorize-[12].c

In my testing with cost tweaking for vector with length, I found
two cases below didn't get the expected output.  Since the expected
instructions reply on the vectorization occurrence, we don't expect
vectorization gets disabled by cost model.

To make it not fragile, the fix is to force it without vect cost model.

gcc/testsuite/ChangeLog:

* gcc.target/powerpc/conv-vectorize-1.c: Add option
-fno-vect-cost-model.
* gcc.target/powerpc/conv-vectorize-2.c: Likewise.

4 years agoDaily bump.
GCC Administrator [Fri, 17 Jul 2020 00:16:27 +0000 (00:16 +0000)]
Daily bump.

4 years agocombine: Use single_set for is_just_move
Segher Boessenkool [Thu, 16 Jul 2020 23:42:46 +0000 (23:42 +0000)]
combine: Use single_set for is_just_move

Since we now only call is_just_move on the original instructions, we
always have an rtx_insn* (not just a pattern), so we can use single_set
on it.  This makes no detectable difference at all on all thirty Linux
targets I test, but it does help cris, and it is simpler, cleaner code
anyway.

2020-07-16  Hans-Peter Nilsson  <hp@axis.com>
    Segher Boessenkool  <segher@kernel.crashing.org>

PR target/93372
* combine.c (is_just_move): Take an rtx_insn* as argument.  Use
single_set on it.

4 years agoopenacc: Fix standalone attach for Fortran assumed-shape array pointers
Julian Brown [Tue, 9 Jun 2020 22:53:39 +0000 (15:53 -0700)]
openacc: Fix standalone attach for Fortran assumed-shape array pointers

This patch makes it so that an "attach" operation for a Fortran pointer
with an array descriptor copies that array descriptor to the target,
and similarly that detach operations release the array descriptor.

2020-07-16  Julian Brown  <julian@codesourcery.com>
    Thomas Schwinge  <thomas@codesourcery.com>

gcc/fortran/
* trans-openmp.c (gfc_trans_omp_clauses): Rework OpenACC
attach/detach handling for arrays with descriptors.

gcc/testsuite/
* gfortran.dg/goacc/attach-descriptor.f90: New test.

libgomp/
* testsuite/libgomp.oacc-fortran/attach-descriptor-1.f90: New test.
* testsuite/libgomp.oacc-fortran/attach-descriptor-2.f90: New test.

Co-Authored-By: Thomas Schwinge <thomas@codesourcery.com>
4 years agocoroutines: Correct frame capture of compiler temps [PR95591+4].
Iain Sandoe [Sat, 11 Jul 2020 07:49:33 +0000 (08:49 +0100)]
coroutines: Correct frame capture of compiler temps [PR95591+4].

When a full expression contains a co_await (or co_yield), this means
that it might be suspended; which would destroy temporary variables
(on a stack for example).  However the language guarantees that such
temporaries are live until the end of the expression.

In order to preserve this, we 'promote' temporaries where necessary
so that they are saved in the coroutine frame (which allows them to
remain live potentially until the frame is destroyed).  In addition,
sub-expressions that produce control flow (such as TRUTH_AND/OR_IF
or COND_EXPR) must be handled specifically to ensure that await
expressions are properly expanded.

This patch corrects two mistakes in which we were (a) failing to
promote some temporaries and (b) we we failing to sequence DTORs for
the captures properly. This manifests in a number of related (but not
exact duplicate) PRs.

The revised code collects the actions into one place and maps all the
control flow into one form - a benefit of this is that co_returns are
now expanded earlier (which provides an opportunity to address PR95517
in some future patch).

We replace a statement that contains await expression(s) with a bind
scope that has a variable list describing the temporaries that have
been 'promoted' and a statement list that contains a series of cleanup
expressions for each of those.  Where we encounter nested conditional
expressions, these are wrapped in a try-finally block with a guard var
for each sub-expression variable that needs a DTOR.  The guards are all
declared and initialized to false before the first conditional sub-
expression.  The 'finally' block contains a series of if blocks (one
per guard variable) enclosing the relevant DTOR.

Variables listed in a bind scope in this manner are automatically moved
to a coroutine frame version by existing code (so we re-use that rather
than having a separate mechanism).

gcc/cp/ChangeLog:

PR c++/95591
PR c++/95599
PR c++/95823
PR c++/95824
PR c++/95895
* coroutines.cc (struct coro_ret_data): Delete.
(coro_maybe_expand_co_return): Delete.
(co_return_expander): Delete.
(expand_co_returns): Delete.
(co_await_find_in_subtree): Remove unused name.
(build_actor_fn): Remove unused parm, remove handling
for co_return expansion.
(register_await_info): Demote duplicate info message to a
warning.
(coro_make_frame_entry): Move closer to use site.
(struct susp_frame_data): Add fields for final suspend label
and a flag to indicate await expressions with initializers.
(captures_temporary): Delete.
(register_awaits): Remove unused code, update comments.
(find_any_await): New.
(tmp_target_expr_p): New.
(struct interesting): New.
(find_interesting_subtree): New.
(struct var_nest_node): New.
(flatten_await_stmt): New.
(handle_nested_conditionals): New.
(process_conditional): New.
(replace_statement_captures): Rename to...
(maybe_promote_temps): ... this.
(maybe_promote_captured_temps): Delete.
(analyze_expression_awaits): Check for await expressions with
initializers.  Simplify handling for truth-and/or-if.
(expand_one_truth_if): Simplify (map cases that need expansion
to COND_EXPR).
(await_statement_walker): Handle CO_RETURN_EXPR. Simplify the
handling for truth-and/or-if expressions.
(register_local_var_uses): Ensure that we create names in the
implementation namespace.
(morph_fn_to_coro): Add final suspend label to suspend frame
callback data and remove it from the build_actor_fn call.

gcc/testsuite/ChangeLog:

PR c++/95591
PR c++/95599
PR c++/95823
PR c++/95824
PR c++/95895
* g++.dg/coroutines/pr95591.C: New test.
* g++.dg/coroutines/pr95599.C: New test.
* g++.dg/coroutines/pr95823.C: New test.
* g++.dg/coroutines/pr95824.C: New test.

4 years agoanalyzer: Use noexcept instead of throw() for C++11 and later (PR 96014)
Jonathan Wakely [Thu, 16 Jul 2020 10:44:32 +0000 (11:44 +0100)]
analyzer: Use noexcept instead of throw() for C++11 and later (PR 96014)

gcc/testsuite/ChangeLog:

PR testsuite/96014
* g++.dg/analyzer/pr94028.C: Replace dynamic exception
specification with noexcept-specifier for C++11 and later.

4 years agoi386: Additional peephole2 to use flags from CMPXCHG more [PR96189]
Uros Bizjak [Thu, 16 Jul 2020 18:11:43 +0000 (20:11 +0200)]
i386: Additional peephole2 to use flags from CMPXCHG more [PR96189]

CMPXCHG instruction sets ZF flag if the values in the destination operand
and EAX register are equal; otherwise the ZF flag is cleared and value
from destination operand is loaded to EAX. Following assembly:

        xorl    %eax, %eax
        lock cmpxchgl   %edx, (%rdi)
        testl   %eax, %eax
        sete    %al

can be optimized by removing the unneeded comparison, since set ZF flag
signals that no update to EAX happened.  This patch adds peephole2
pattern to also handle XOR zeroing and load of -1 by OR.

2020-07-16  Uroš Bizjak  <ubizjak@gmail.com>

gcc/ChangeLog:
PR target/96189
* config/i386/sync.md
(peephole2 to remove unneded compare after CMPXCHG):
New pattern, also handle XOR zeroing and load of -1 by OR.

gcc/testsuite/ChangeLog:
PR target/96189
* gcc.target/i386/pr96189-1.c: New test.

4 years agoReunify x86 stack checking implementation
Eric Botcazou [Thu, 16 Jul 2020 15:50:26 +0000 (17:50 +0200)]
Reunify x86 stack checking implementation

The stack clash protection mechanism in the x86 back-end was implemented
by largely duplicating the existing stack checking implementation.  Now
the only significant difference between them is the probing window, which
is shifted by 1 probing interval (not 2 as documented in explow.c), but we
can certainly do 1 more probe for stack checking even if it is redundant
in almost all cases.

gcc/ChangeLog:
* config/i386/i386.c (ix86_compute_frame_layout): Minor tweak.
(ix86_adjust_stack_and_probe): Delete.
(ix86_adjust_stack_and_probe_stack_clash): Rename to above and add
PROTECTION_AREA parameter.  If it is true, probe PROBE_INTERVAL plus
a small dope beyond SIZE bytes.
(ix86_emit_probe_stack_range): Use local variable.
(ix86_expand_prologue): Adjust calls to ix86_adjust_stack_and_probe
and tidy up the stack checking code.
* explow.c (get_stack_check_protect): Fix head comment.
(anti_adjust_stack_and_probe_stack_clash): Likewise.
(allocate_dynamic_stack_space): Add comment.

* tree-nested.c (lookup_field_for_decl): Set the DECL_IGNORED_P and
TREE_NO_WARNING but not TREE_ADDRESSABLE flags on the field.

4 years agoc++: Add test for DR 188.
Marek Polacek [Thu, 16 Jul 2020 16:11:25 +0000 (12:11 -0400)]
c++: Add test for DR 188.

gcc/testsuite/ChangeLog:

DR 188
* g++.dg/DRs/dr188.C: New test.

4 years agoamdgcn: Handle early debug info in mkoffload
Andrew Stubbs [Thu, 9 Jul 2020 21:48:39 +0000 (22:48 +0100)]
amdgcn: Handle early debug info in mkoffload

Forward the early debug information from the input LTO file to the output
HSACO file, in the same way lto-wrapper does.  This is a little more
complicated, however, because the ELF file containing the debug needs to be
converted from x86_64 to amdgcn, and because the offloaded code will have less
content than the host program the debug info describes.

gcc/ChangeLog:

* config/gcn/mkoffload.c: Include simple-object.h and elf.h.
(EM_AMDGPU): New macro.
(ELFOSABI_AMDGPU_HSA): New macro.
(ELFABIVERSION_AMDGPU_HSA): New macro.
(EF_AMDGPU_MACH_AMDGCN_GFX803): New macro.
(EF_AMDGPU_MACH_AMDGCN_GFX900): New macro.
(EF_AMDGPU_MACH_AMDGCN_GFX906): New macro.
(R_AMDGPU_NONE): New macro.
(R_AMDGPU_ABS32_LO): New macro.
(R_AMDGPU_ABS32_HI): New macro.
(R_AMDGPU_ABS64): New macro.
(R_AMDGPU_REL32): New macro.
(R_AMDGPU_REL64): New macro.
(R_AMDGPU_ABS32): New macro.
(R_AMDGPU_GOTPCREL): New macro.
(R_AMDGPU_GOTPCREL32_LO): New macro.
(R_AMDGPU_GOTPCREL32_HI): New macro.
(R_AMDGPU_REL32_LO): New macro.
(R_AMDGPU_REL32_HI): New macro.
(reserved): New macro.
(R_AMDGPU_RELATIVE64): New macro.
(gcn_s1_name): Delete global variable.
(gcn_s2_name): Delete global variable.
(gcn_o_name): Delete global variable.
(gcn_cfile_name): Delete global variable.
(files_to_cleanup): New global variable.
(offload_abi): New global variable.
(tool_cleanup): Use files_to_cleanup, not explicit list.
(copy_early_debug_info): New function.
(main): New local variables gcn_s1_name, gcn_s2_name, gcn_o_name,
gcn_cfile_name.
Create files_to_cleanup obstack.
Recognize -march options.
Copy early debug info from input .o files.

4 years agoFix ChangeLog PR number.
Uros Bizjak [Thu, 16 Jul 2020 14:37:04 +0000 (16:37 +0200)]
Fix ChangeLog PR number.

4 years agoc++: Get rid of convert_like* macros.
Marek Polacek [Wed, 15 Jul 2020 20:40:54 +0000 (16:40 -0400)]
c++: Get rid of convert_like* macros.

The convert_like* macros were introduced in

  2000-03-05  Nathan Sidwell  <nathan@codesourcery.com>

        * call.c (convert_like): Macrofy.
        (convert_like_with_context): New macro.

but now we can use overloading so we can do away with the macros.
I've also taken this chance to rename _real to _internal to make it
clear that it should not be called directly.

No functional change intended.

gcc/cp/ChangeLog:

* call.c (convert_like): Remove macro and introduce a new
wrapper instead.
(convert_like_with_context): Likewise.
(convert_like_real): Rename to convert_like.
(convert_like_real_1): Rename to convert_like_internal.  Call
convert_like instead of convert_like_real therein.
(perform_direct_initialization_if_possible): Call convert_like
instead of convert_like_real.

4 years agocoroutines: Spelling corrections in comments [NFC].
Iain Sandoe [Thu, 16 Jul 2020 10:49:55 +0000 (11:49 +0100)]
coroutines: Spelling corrections in comments [NFC].

Correct some typos.

gcc/cp/ChangeLog:

* coroutines.cc: Correct some spelling errors
in comments.

4 years agobuild: Fix TAGS target in gcc/Makefile.in
Andrea Corallo [Thu, 16 Jul 2020 09:20:28 +0000 (10:20 +0100)]
build: Fix TAGS target in gcc/Makefile.in

gcc/ChangeLog:

2020-07-16  Andrea Corallo  <andrea.corallo@arm.com>

* Makefile.in (TAGS): Remove 'params.def'.

4 years agodoc: Document TARGET_TRULY_NOOP_TRUNCATION requires trunc?i?i2 patterns.
Roger Sayle [Thu, 16 Jul 2020 10:47:47 +0000 (11:47 +0100)]
doc: Document TARGET_TRULY_NOOP_TRUNCATION requires trunc?i?i2 patterns.

2020-07-16  Roger Sayle  <roger@nextmovesoftware.com>

gcc/ChangeLog:
* target.def (TARGET_TRULY_NOOP_TRUNCATION): Clarify that
targets that return false, indicating SUBREGs shouldn't be
used, also need to provide a trunc?i?i2 optab that performs this
truncation.
* doc/tm.texi: Regenerate.

4 years ago[Ada] Misplace of internal master renaming declaration
Javier Miranda [Sat, 13 Jun 2020 12:21:19 +0000 (08:21 -0400)]
[Ada] Misplace of internal master renaming declaration

gcc/ada/

* exp_ch3.adb (Expand_N_Full_Type_Declaration): Ensure a _master
declaration on limited types that might have tasks.
* exp_ch9.adb (Build_Master_Renaming): For private types, if we
are processing declarations in the private part, ensure that
master is inserted before its full declaration; otherwise the
master renaming may be inserted in the public part of the
package (and hence before the declaration of its _master
variable).

4 years ago[Ada] AI12-0132 Freezing of renames_as_body
Arnaud Charlet [Thu, 11 Jun 2020 18:31:54 +0000 (14:31 -0400)]
[Ada] AI12-0132 Freezing of renames_as_body

gcc/ada/

* sem_ch8.adb (Analyze_Subprogram_Renaming): A renames-as-body
freezes the expression of any expression function that it
renames.

4 years ago[Ada] Ongoing work for AI12-0212 : container aggregates
Ed Schonberg [Fri, 12 Jun 2020 18:57:02 +0000 (14:57 -0400)]
[Ada] Ongoing work for AI12-0212 : container aggregates

gcc/ada/

* sem_aggr.adb (Resolve_Container_Aggregate): Add semantic
checks for indexed aggregates, including component associations
and iterated component associations.
* exp_aggr.adb (Expand_Iterated_Component): New subprogram,
subsidiary of Expand_Container_Aggreggate, used for positional,
named, and indexed aggregates.
(Aggregate_Size): New subprogram to precompute the size of an
indexed aggregate prior to call to allocate it.
(Expand_Range_Component): New subprogram so generate loop for a
component association given by a range or a subtype name in an
indexed aggregate.

4 years ago[Ada] gnatbind: Fix No_Entry_Calls_In_Elaboration_Code message
Bob Duff [Fri, 12 Jun 2020 13:58:24 +0000 (09:58 -0400)]
[Ada] gnatbind: Fix No_Entry_Calls_In_Elaboration_Code message

gcc/ada/

* bindo-diagnostics.adb (Output_Invocation_Related_Suggestions):
Use Cumulative_Restrictions.Set, because Restriction_Active only
works at compile time.

4 years ago[Ada] Ada2020: AI12-0117 Restriction No_Tasks_Unassigned_To_CPU
Bob Duff [Thu, 11 Jun 2020 18:05:55 +0000 (14:05 -0400)]
[Ada] Ada2020: AI12-0117 Restriction No_Tasks_Unassigned_To_CPU

gcc/ada/

* gnatbind.adb (Gnatbind): For No_Tasks_Unassigned_To_CPU, check
that CPU has been set on the main subprogram.
(Restriction_Could_Be_Set): Don't print
No_Tasks_Unassigned_To_CPU if it would violate the
above-mentioned rule. Up to now, all restrictions were checked
by the compiler, with the binder just checking for consistency.
But the compiler can't know which subprogram is the main, so
it's impossible to check this one at compile time.
* restrict.ads, restrict.adb: Misc refactoring. Change Warning
to Warn, for consistency, since most already use Warn.
(Set_Restriction): New convenience routine.
* sem_ch13.adb (Attribute_CPU): Check
No_Tasks_Unassigned_To_CPU.
* sem_prag.adb (Pragma_CPU): Check No_Tasks_Unassigned_To_CPU.
Misc refactoring.
* tbuild.ads, tbuild.adb (Sel_Comp): New functions for building
selected components.

4 years ago[Ada] Remove duplicated line
Eric Botcazou [Thu, 11 Jun 2020 23:22:29 +0000 (01:22 +0200)]
[Ada] Remove duplicated line

gcc/ada/

* impunit.adb (Non_Imp_File_Names_95): Remove duplicate entry.

4 years ago[Ada] Wrong execution of Tan on large argument
Arnaud Charlet [Thu, 11 Jun 2020 12:49:58 +0000 (08:49 -0400)]
[Ada] Wrong execution of Tan on large argument

gcc/ada/

* Makefile.rtl: replace a-numaux__x86.ads by
a-numaux__libc-x86.ads and a-numaux__x86.adb by
a-numaux__dummy.adb.
* libgnat/a-numaux__x86.ads, libgnat/a-numaux__x86.adb: Removed.
* libgnat/a-numaux__dummy.adb: New.

4 years ago[Ada] Spurious error in instance nested in formal package
Ed Schonberg [Thu, 11 Jun 2020 15:34:26 +0000 (11:34 -0400)]
[Ada] Spurious error in instance nested in formal package

gcc/ada/

* sem_ch12.adb (Load_Parent_Of_Generic): If an ancestor is an
instance whose source appears within a formal package of the
current unit, there is no body of the ancestor needed to
complete the current generic compilation.

4 years ago[Ada] v7r2cert: minor refactoring
Doug Rupp [Mon, 8 Jun 2020 19:17:26 +0000 (12:17 -0700)]
[Ada] v7r2cert: minor refactoring

gcc/ada/

* libgnat/s-thread__ae653.adb (taskVarAdd): Defunct, so remove.
(Current_ATSD):  Make it a TLS variable.
(OK): Move to package scope.
(System.Storage_Elements): Import and Use.

4 years ago[Ada] Set missing Parent field of block entity
Eric Botcazou [Thu, 11 Jun 2020 13:25:44 +0000 (15:25 +0200)]
[Ada] Set missing Parent field of block entity

gcc/ada/

* exp_ch9.adb (Expand_N_Accept_Statement): Set Parent of the
created block entity to the created block statement.

4 years ago[Ada] AI12-0004 Normalization and allowed characters
Arnaud Charlet [Wed, 10 Jun 2020 12:26:06 +0000 (08:26 -0400)]
[Ada] AI12-0004 Normalization and allowed characters

gcc/ada/

* scng.adb (Scan): Detect wide characters not in NFKC.
* libgnat/a-chahan.adb, libgnat/a-chahan.ads,
libgnat/a-wichha.adb, libgnat/a-wichha.ads,
libgnat/a-wichun.adb, libgnat/a-wichun.ads,
libgnat/a-zchhan.adb, libgnat/a-zchhan.ads,
libgnat/a-zchuni.adb, libgnat/a-zchuni.ads (Is_NFKC): New.
* libgnat/s-utf_32.ads, libgnat/s-utf_32.adb (Is_UTF_32_NFKC):
New.

4 years ago[Ada] Ada2020: AI12-0117 Restriction No_Tasks_Unassigned_To_CPU
Bob Duff [Wed, 10 Jun 2020 19:55:32 +0000 (15:55 -0400)]
[Ada] Ada2020: AI12-0117 Restriction No_Tasks_Unassigned_To_CPU

gcc/ada/

* libgnat/s-rident.ads (Restriction_Id): Add
No_Tasks_Unassigned_To_CPU.

4 years ago[Ada] Adjust heuristics about size of static aggregates
Bob Duff [Tue, 9 Jun 2020 23:04:56 +0000 (19:04 -0400)]
[Ada] Adjust heuristics about size of static aggregates

gcc/ada/

* exp_aggr.adb (Max_Aggregate_Size): Use the small size of 64
when copying is needed (for example, for the initialization of a
local variable, and for assignment statements). Use the larger
size when static allocation can be done without copying.

4 years ago[Ada] Ada2020: AI12-0055 No_Dynamic_CPU_Assignment restriction
Bob Duff [Tue, 9 Jun 2020 14:53:23 +0000 (10:53 -0400)]
[Ada] Ada2020: AI12-0055 No_Dynamic_CPU_Assignment restriction

gcc/ada/

* libgnat/s-rident.ads (No_Dynamic_CPU_Assignment): New
restriction. Add it to all relevant profiles.
* sem_ch13.adb (Attribute_CPU): Check No_Dynamic_CPU_Assignment
restriction.
(Attribute_CPU, Attribute_Dispatching_Domain,
Attribute_Interrupt_Priority): Remove error checks -- these are
checked in the parser.
* sem_prag.adb (Pragma_CPU): Check No_Dynamic_CPU_Assignment
restriction.  We've got a little violation of DRY here.
* sem.ads, sem_ch3.ads: Minor comment fix.

4 years ago[Ada] Implicit dereferencing in container indexing
Gary Dismukes [Sun, 7 Jun 2020 23:41:15 +0000 (19:41 -0400)]
[Ada] Implicit dereferencing in container indexing

gcc/ada/

* sem_ch4.adb (Try_Container_Indexing): When the prefix type is
an access type, change it to the designated type, change the
prefix to an explicit dereference, and emit a ?d? warning for
the implicit dereference. Include a ??? comment questioning
whether this is the right context in which to perform the
implicit dereferencing.

4 years ago[Ada] AI12-0373 Additional check on Integer_Literal function
Arnaud Charlet [Mon, 8 Jun 2020 18:28:52 +0000 (14:28 -0400)]
[Ada] AI12-0373 Additional check on Integer_Literal function

gcc/ada/

* sem_ch13.adb (Validate_Literal_Aspect): Ensure that the
parameter is not aliased. Minor reformatting.
* sem_util.adb (Statically_Names_Object): Update comment.

4 years ago[Ada] Handle N_Others_Choice case in range-building function
Ghjuvan Lacambre [Fri, 5 Jun 2020 16:00:08 +0000 (18:00 +0200)]
[Ada] Handle N_Others_Choice case in range-building function

gcc/ada/

* sem_case.adb (Build_Choice): Set Is_Static_Expression flag.
(Lit_Of): Update specification to mention Is_Static_Expression
flag.
* sem_ch13.adb (Membership_Entry): Check for N_Others_Choice.

4 years ago[Ada] Ada2020: AI12-0289 Implicitly null excluding anon access
Bob Duff [Mon, 8 Jun 2020 17:54:27 +0000 (13:54 -0400)]
[Ada] Ada2020: AI12-0289 Implicitly null excluding anon access

gcc/ada/

* sem_ch6.adb (Null_Exclusions_Match): New function to check
that the null exclusions match, including in the case addressed
by this AI.
(Check_Conformance): Remove calls to Comes_From_Source
when calling Null_Exclusions_Match. These are not
needed, as indicated by an ancient "???" comment.

4 years ago[Ada] Spurious accessibility error on allocator in generic instance
Justin Squirek [Fri, 5 Jun 2020 19:41:33 +0000 (15:41 -0400)]
[Ada] Spurious accessibility error on allocator in generic instance

gcc/ada/

* exp_ch4.adb (Expand_N_Type_Conversion): Remove flawed test for
whether "statically deeper" accessibility rules apply to a given
target type and instead use the new routine
Statically_Deeper_Relation_Applies.
(Statically_Deeper_Relation_Applies): Created to centralize the
calculation of whether a target type within a conversion must
have static accessibility checks.
* sem_ch13.adb (Check_One_Function): Minor comment revision.

4 years ago[Ada] Small cleanup in interface with GCC back-end
Eric Botcazou [Mon, 8 Jun 2020 19:21:39 +0000 (21:21 +0200)]
[Ada] Small cleanup in interface with GCC back-end

gcc/ada/

* fe.h (Is_OK_Static_Expression): Delete.
* sem_eval.ads (Is_OK_Static_Expression): Remove WARNING note.

4 years ago[Ada] Incorrect static accessibility error in return aggregate
Justin Squirek [Fri, 22 May 2020 20:25:00 +0000 (16:25 -0400)]
[Ada] Incorrect static accessibility error in return aggregate

gcc/ada/

* einfo.adb, einfo.ads (Is_Named_Access_Type): Created for
readability.
* sem_ch6.adb (Check_Return_Construct_Accessibility): Add
special cases for formals.
* sem_util.adb (Object_Access_Level): Add handling of access
attributes and named access types in the general case.

4 years ago[Ada] Simplify detection of others choice with just one value
Piotr Trojanek [Mon, 8 Jun 2020 12:33:08 +0000 (14:33 +0200)]
[Ada] Simplify detection of others choice with just one value

gcc/ada/

* sem_case.adb (Build_Choice): Simplify.

4 years ago[Ada] Disable Initialize_Scalars on runtime files
Arnaud Charlet [Mon, 8 Jun 2020 08:10:29 +0000 (10:10 +0200)]
[Ada] Disable Initialize_Scalars on runtime files

gcc/ada/

* frontend.adb: Disable Initialize_Scalars on runtime files.

4 years ago[Ada] Do not perform null exclusion static checks on generated entities
Ghjuvan Lacambre [Fri, 5 Jun 2020 07:46:15 +0000 (09:46 +0200)]
[Ada] Do not perform null exclusion static checks on generated entities

gcc/ada/

* sem_ch3.adb (Analyze_Object_Declaration): Add
Comes_From_Source call.

4 years ago[Ada] Avoid false positive reported by CodePeer
Javier Miranda [Sat, 6 Jun 2020 15:26:18 +0000 (11:26 -0400)]
[Ada] Avoid false positive reported by CodePeer

gcc/ada/

* exp_attr.adb (Expand_Access_To_Protected_Op): Initialize
variable Sub to Empty to avoid false positive reported by
Codepeer.

4 years ago[Ada] Spurious redundant use clause warning
Arnaud Charlet [Fri, 5 Jun 2020 18:45:23 +0000 (14:45 -0400)]
[Ada] Spurious redundant use clause warning

gcc/ada/

* sem_ch8.adb (Note_Redundant_Use): Add missing warning tag.
Do not check for redundant use clauses in predefined units to avoid
misleading warnings that may occur as part of a rtsfind load.

4 years ago[Ada] Ada2020: AI12-0107 convention of By_Protected_Procedure
Javier Miranda [Wed, 3 Jun 2020 18:07:27 +0000 (14:07 -0400)]
[Ada] Ada2020: AI12-0107 convention of By_Protected_Procedure

gcc/ada/

* exp_attr.adb (Has_By_Protected_Procedure_Prefixed_View): New
subprogram.
(Expand_Access_To_Protected_Op): Adding support for prefixed
class-wide view with By_Protected_Procedure convention.
* sem_attr.adb (Get_Convention): New subprogram.
(Get_Kind): Adapted to use Get_Convention.
* sem_ch4.adb (Try_By_Protected_Procedure_Prefixed_View): New
subprogram.
(Analyze_Selected_Component): Invoke
Try_By_Protected_Procedure_Prefixed_View.
* sem_util.ads (Is_By_Protected_Procedure): New subprogram.
* sem_util.adb (Is_By_Protected_Procedure): New subprogram.

4 years ago[Ada] Overflow in string streaming
Arnaud Charlet [Fri, 5 Jun 2020 15:50:16 +0000 (11:50 -0400)]
[Ada] Overflow in string streaming

gcc/ada/

* libgnat/s-ststop.ads: Fix typo.
* libgnat/s-ststop.adb (Read, Write): Fix block number
computation to avoid overflows in case of large strings.

4 years ago[Ada] Add centralized capacity check in Generic_Bignums
Arnaud Charlet [Fri, 5 Jun 2020 09:40:55 +0000 (05:40 -0400)]
[Ada] Add centralized capacity check in Generic_Bignums

gcc/ada/

* libgnat/s-genbig.adb ("**"): Remove capacity limit check.
Improve code by using an extended return.
(Normalize): Perform capacity limit check here instead which is
the centralized place where (potentially large) big integers are
allocated.

4 years ago[Ada] AI12-0042: Type invariant checking rules
Gary Dismukes [Wed, 3 Jun 2020 23:53:33 +0000 (19:53 -0400)]
[Ada] AI12-0042: Type invariant checking rules

gcc/ada/

* exp_ch4.adb (Expand_N_Type_Conversion): Handle the case of
applying an invariant check for a conversion to a class-wide
type whose root type has a type invariant, when the conversion
appears within the immediate scope of the type and the
expression is of a specific tagged type.
* sem_ch3.adb (Is_Private_Primitive): New function to determine
whether a primitive subprogram is a private operation.
(Check_Abstract_Overriding): Enforce the restriction imposed by
AI12-0042 of requiring overriding of an inherited nonabstract
private operation when the ancestor has a class-wide type
invariant and the ancestor's private operation is visible.
(Derive_Subprogram): Set Requires_Overriding on a subprogram
inherited from a visible private operation of an ancestor to
which a Type_Invariant'Class expression applies.

4 years agolibsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86
Rainer Orth [Thu, 16 Jul 2020 08:38:48 +0000 (10:38 +0200)]
libsanitizer: Fix GetPcSpBp determination of SP on 32-bit Solaris/x86

The latest Solaris 11.4/x86 update uncovered a libsanitizer bug that
caused one test to FAIL for 32-bit:

+FAIL: c-c++-common/asan/null-deref-1.c   -O0  output pattern test
+FAIL: c-c++-common/asan/null-deref-1.c   -O1  output pattern test
+FAIL: c-c++-common/asan/null-deref-1.c   -O2  output pattern test
+FAIL: c-c++-common/asan/null-deref-1.c   -O2 -flto  output pattern test
+FAIL: c-c++-common/asan/null-deref-1.c -O2 -flto -flto-partition=none
output pattern test
+FAIL: c-c++-common/asan/null-deref-1.c   -O3 -g  output pattern test
+FAIL: c-c++-common/asan/null-deref-1.c   -Os  output pattern test

I've identified the problem and the fix has just landed in upstream
llvm-project:

https://reviews.llvm.org/D83664

Tested on i386-pc-solaris2.11 and x86_64-pc-linux.gnu.

libsanitizer:
* sanitizer_common/sanitizer_linux.cpp: Cherry-pick llvm-project
revision f0e9b76c3500496f8f3ea7abe6f4bf801e3b41e7.

4 years agoDaily bump.
GCC Administrator [Thu, 16 Jul 2020 00:16:34 +0000 (00:16 +0000)]
Daily bump.

4 years agoi386: Introduce peephole2 to use flags from CMPXCHG more [PR96189]
Uros Bizjak [Wed, 15 Jul 2020 19:27:00 +0000 (21:27 +0200)]
i386: Introduce peephole2 to use flags from CMPXCHG more [PR96189]

CMPXCHG instruction sets ZF flag if the values in the destination operand
and EAX register are equal; otherwise the ZF flag is cleared and value
from destination operand is loaded to EAX. Following assembly:

        movl    %esi, %eax
        lock cmpxchgl   %edx, (%rdi)
        cmpl    %esi, %eax
        sete    %al

can be optimized by removing the unneeded comparison, since set ZF flag
signals that no update to EAX happened.

2020-15-07  Uroš Bizjak  <ubizjak@gmail.com>

gcc/ChangeLog:
PR target/95355
* config/i386/sync.md
(peephole2 to remove unneded compare after CMPXCHG): New pattern.

gcc/testsuite/ChangeLog:
PR target/95355
* gcc.target/i386/pr96189.c: New test.

4 years agolibgomp.fortran/alloc-1.F90: Fix testcase for 32bit size_t
Tobias Burnus [Wed, 15 Jul 2020 15:23:04 +0000 (17:23 +0200)]
libgomp.fortran/alloc-1.F90: Fix testcase for 32bit size_t

libgomp/ChangeLog:

* testsuite/libgomp.fortran/alloc-1.F90: Use c_size_t to
avoid conversion on 32bit systems from 32bit to 64bit due
to -fdefault-integer-8.

4 years agoopenmp: Fix up loop-21.c
Jakub Jelinek [Wed, 15 Jul 2020 14:34:54 +0000 (16:34 +0200)]
openmp: Fix up loop-21.c

I've missed
+FAIL: libgomp.c/loop-21.c execution test
during testing of the recent patch.  The problem is that while
for the number of iterations computation it doesn't matter if we compute
min_inner_iterations as (m2 * first + n2 + (adjusted step) + m1 * first + n1) / step
or (m2 * last + n2 + (adjusted step) + m1 * last + n1) / step provided that
in the second case we use as factor (m1 - m2) * ostep / step rather than
(m2 - m1) * ostep / step, for the logical to actual iterator values computation
it does matter and in my hand written C implementations of all the cases (outer
vs. inner loop with increasing vs. decreasing iterator) I'm using the same computation
and it worked well for all the pseudo-random iterators testing it was doing.

It also means min_inner_iterations is misnamed, because it is not really
minimum number of inner iterations, whether the first or last outer iteration
results in the smaller or larger value of this can be (sometimes) only
determined at runtime.
So this patch also renames it to first_inner_iterations.

2020-07-15  Jakub Jelinek  <jakub@redhat.com>

PR libgomp/96198
* omp-general.h (struct omp_for_data): Rename min_inner_iterations
member to first_inner_iterations, adjust comment.
* omp-general.c (omp_extract_for_data): Adjust for the above change.
Always use n1first and n2first to compute it, rather than depending
on single_nonrect_cond_code.  Similarly, always compute factor
as (m2 - m1) * outer_step / inner_step rather than sometimes m1 - m2
depending on single_nonrect_cond_code.
* omp-expand.c (expand_omp_for_init_vars): Rename min_inner_iterations
to first_inner_iterations and min_inner_iterationsd to
first_inner_iterationsd.

4 years agoc++: refactor some parser code
Nathan Sidwell [Wed, 15 Jul 2020 14:38:35 +0000 (07:38 -0700)]
c++: refactor some parser code

cp_parser_declaration copies tokens to local variables, before inspecting
(some of) their fields.  There's no need.  Just point at them in the token
buffer -- they don't move.  Also, we never look at the second token if the
first is EOF, so no need for some kind of dummy value in that case.

gcc/cp/
* parser.c (cp_parser_declaration): Avoid copying tokens.
(cp_parser_block_declaration): RAII token pointer.

4 years ago[Ada] Cleanup code related to object overlays
Piotr Trojanek [Fri, 5 Jun 2020 11:30:54 +0000 (13:30 +0200)]
[Ada] Cleanup code related to object overlays

gcc/ada/

* sem_util.adb (Find_Overlaid_Entity): Fix style in comment.
(Note_Possible_Modification): Simplify repeated calls to Ekind.

4 years ago[Ada] Cleanup in Convert_To_Positional after previous work
Eric Botcazou [Fri, 5 Jun 2020 09:35:25 +0000 (11:35 +0200)]
[Ada] Cleanup in Convert_To_Positional after previous work

gcc/ada/

* exp_aggr.adb (Flatten): Adjust description.
(Convert_To_Positional): Remove obsolete ??? comment and use
Compile_Time_Known_Value in the final test.

4 years ago[Ada] Ongoing work for AI12-0212: container aggregates
Arnaud Charlet [Wed, 3 Jun 2020 07:42:19 +0000 (03:42 -0400)]
[Ada] Ongoing work for AI12-0212: container aggregates

gcc/ada/

* par-ch4.adb (P_Iterated_Component_Association): Extended to
recognzize the similar Iterated_Element_Association. This node
is only generated when an explicit Key_Expression is given.
Otherwise the distinction between the two iterated forms is done
during semantic analysis.
* sinfo.ads: New node N_Iterated_Element_Association, for
Ada202x container aggregates.  New field Key_Expression.
* sinfo.adb: Subprograms for new node and newn field.
* sem_aggr.adb (Resolve_Iterated_Component_Association): Handle
the case where the Iteration_Scheme is an
Iterator_Specification.
* exp_aggr.adb (Wxpand_Iterated_Component): Handle a component
with an Iterated_Component_Association, generate proper loop
using given Iterator_Specification.
* exp_util.adb (Insert_Axtions): Handle new node as other
aggregate components.
* sem.adb, sprint.adb: Handle new node.
* tbuild.adb (Make_Implicit_Loop_Statement): Handle properly a
loop with an Iterator_ specification.

4 years ago[Ada] Fix logic in Allocate_Any_Controlled
Arnaud Charlet [Thu, 4 Jun 2020 18:18:18 +0000 (14:18 -0400)]
[Ada] Fix logic in Allocate_Any_Controlled

gcc/ada/

* libgnat/s-stposu.adb (Allocate_Any_Controlled): Fix logic in
lock/unlock.

4 years ago[Ada] Target name is an object reference
Piotr Trojanek [Thu, 28 May 2020 18:28:28 +0000 (20:28 +0200)]
[Ada] Target name is an object reference

gcc/ada/

* sem_util.adb (Is_Object_Reference): Return True on
N_Target_Name.

4 years ago[Ada] Spurious error on Predicate_Failure aspect
Arnaud Charlet [Thu, 4 Jun 2020 09:09:59 +0000 (05:09 -0400)]
[Ada] Spurious error on Predicate_Failure aspect

gcc/ada/

* sem_ch13.adb (Check_Aspect_At_End_Of_Declarations): Add proper
handling of Aspect_Predicate_Failure, consistent with
Check_Aspect_At_Freeze_Point.

4 years ago[Ada] Mention -gnat2020 in error message
Arnaud Charlet [Thu, 4 Jun 2020 08:13:16 +0000 (10:13 +0200)]
[Ada] Mention -gnat2020 in error message

gcc/ada/

* sem_ch13.adb (Check_Aspect_Too_Late): Mention -gnat2020 switch
in error message.

4 years ago[Ada] Do not generate elaboration code for alignment aspect
Eric Botcazou [Thu, 4 Jun 2020 08:15:33 +0000 (10:15 +0200)]
[Ada] Do not generate elaboration code for alignment aspect

gcc/ada/

* einfo.ads (Delayed Freezing and Elaboration): Adjust description.
* freeze.adb (Freeze_Object_Declaration): Likewise.
* sem_ch3.adb (Delayed_Aspect_Present): Likewise.  Do not return
true for Alignment.
* sem_ch13.adb (Analyze_Aspect_Specifications): Do not always delay
for Alignment.  Moreover, for Alignment and various Size aspects,
do not delay if the expression is an attribute whose prefix is the
Standard package.

4 years ago[Ada] Do not generate extra copies inside initialization procedures
Eric Botcazou [Thu, 4 Jun 2020 07:56:02 +0000 (09:56 +0200)]
[Ada] Do not generate extra copies inside initialization procedures

gcc/ada/

* exp_ch6.adb (Requires_Atomic_Or_Volatile_Copy): Return false
inside an initialization procedure.

4 years ago[Ada] Guard against access to wrong fields in Is_Renaming
Ghjuvan Lacambre [Wed, 3 Jun 2020 09:09:20 +0000 (11:09 +0200)]
[Ada] Guard against access to wrong fields in Is_Renaming

gcc/ada/

* sem_util.adb (Is_Renaming): Add ekind checks.

4 years ago[Ada] Remove doc on obsolete tools
Arnaud Charlet [Wed, 3 Jun 2020 20:14:38 +0000 (16:14 -0400)]
[Ada] Remove doc on obsolete tools

gcc/ada/

* doc/gnat_ugn/gnat_utility_programs.rst: Remove doc on obsolete
tools.
* gnat_ugn.texi: Regenerate.

4 years ago[Ada] Assert failure with -gnatwr
Arnaud Charlet [Wed, 3 Jun 2020 16:27:43 +0000 (12:27 -0400)]
[Ada] Assert failure with -gnatwr

gcc/ada/

* sem_res.adb (Resolve_Type_Conversion): Protect against null
entity.  Add proper tag for -gnatwr warning.

4 years ago[Ada] Missing error on operator call
Arnaud Charlet [Wed, 3 Jun 2020 07:42:19 +0000 (03:42 -0400)]
[Ada] Missing error on operator call

gcc/ada/

* sem_ch6.adb (Analyze_Procedure_Call): Detect use of operators
in a procedure call.
* sem_util.adb: Minor edit.

4 years ago[Ada] Fix for possibly null ranges in 'Update and delta_aggregate
Piotr Trojanek [Tue, 2 Jun 2020 22:17:21 +0000 (00:17 +0200)]
[Ada] Fix for possibly null ranges in 'Update and delta_aggregate

gcc/ada/

* exp_spark.adb (Expand_SPARK_Delta_Or_Update): Apply scalar
range checks against the base type of an index type, not against
the index type itself.

4 years ago[Ada] Small addition and tweaks in documentation on freezing
Eric Botcazou [Wed, 3 Jun 2020 08:30:09 +0000 (10:30 +0200)]
[Ada] Small addition and tweaks in documentation on freezing

gcc/ada/

* einfo.ads (Delayed Freezing and Elaboration): Minor tweaks.
Document the discrepancy between the aspect and the non-aspect
cases for alignment settings in object declarations.

4 years ago[Ada] ACATS 4.1P [BDB4001] - 13.11.4(22-23/3) not enforced
Arnaud Charlet [Sat, 30 May 2020 18:04:33 +0000 (14:04 -0400)]
[Ada] ACATS 4.1P [BDB4001] - 13.11.4(22-23/3) not enforced

gcc/ada/

* exp_ch3.adb (Freeze_Type): Remove warning in expander,
replaced by a corresponding error in sem_ch13.adb. Replace
RTE_Available by RTU_Loaded to avoid adding unnecessary
dependencies.
* sem_ch13.adb (Associate_Storage_Pool): New procedure.
(Analyze_Attribute_Definition_Clause
[Attribute_Simple_Storage_Pool| Attribute_Storage_Pool]): Call
Associate_Storage_Pool to add proper legality checks on
subpools.

4 years ago[Ada] Mark standard containers as not in SPARK
Yannick Moy [Tue, 2 Jun 2020 12:16:25 +0000 (14:16 +0200)]
[Ada] Mark standard containers as not in SPARK

gcc/ada/

* libgnat/a-cbdlli.adb, libgnat/a-cbdlli.ads,
libgnat/a-cbhama.adb, libgnat/a-cbhama.ads,
libgnat/a-cbhase.adb, libgnat/a-cbhase.ads,
libgnat/a-cbmutr.adb, libgnat/a-cbmutr.ads,
libgnat/a-cborma.adb, libgnat/a-cborma.ads,
libgnat/a-cborse.adb, libgnat/a-cborse.ads,
libgnat/a-cbprqu.adb, libgnat/a-cbprqu.ads,
libgnat/a-cbsyqu.adb, libgnat/a-cbsyqu.ads,
libgnat/a-cdlili.adb, libgnat/a-cdlili.ads,
libgnat/a-cidlli.adb, libgnat/a-cidlli.ads,
libgnat/a-cihama.adb, libgnat/a-cihama.ads,
libgnat/a-cihase.adb, libgnat/a-cihase.ads,
libgnat/a-cimutr.adb, libgnat/a-cimutr.ads,
libgnat/a-ciorma.adb, libgnat/a-ciorma.ads,
libgnat/a-ciormu.adb, libgnat/a-ciormu.ads,
libgnat/a-ciorse.adb, libgnat/a-ciorse.ads,
libgnat/a-cohama.adb, libgnat/a-cohama.ads,
libgnat/a-cohase.adb, libgnat/a-cohase.ads,
libgnat/a-coinve.adb, libgnat/a-coinve.ads,
libgnat/a-comutr.adb, libgnat/a-comutr.ads,
libgnat/a-convec.adb, libgnat/a-convec.ads,
libgnat/a-coorma.adb, libgnat/a-coorma.ads,
libgnat/a-coormu.adb, libgnat/a-coormu.ads,
libgnat/a-coorse.adb, libgnat/a-coorse.ads: Add SPARK_Mode =>
Off.

4 years ago[Ada] Fix oversight in Delayed_Aspect_Present predicate
Eric Botcazou [Tue, 2 Jun 2020 22:08:17 +0000 (00:08 +0200)]
[Ada] Fix oversight in Delayed_Aspect_Present predicate

gcc/ada/

* sem_ch3.adb (Delayed_Aspect_Present): Fix oversight in loop.
* freeze.adb (Freeze_Object_Declaration): Use Declaration_Node
instead of Parent for the sake of consistency.

4 years ago[Ada] Wrong resolution of 'access in protected subprogram
Javier Miranda [Tue, 2 Jun 2020 19:46:10 +0000 (15:46 -0400)]
[Ada] Wrong resolution of 'access in protected subprogram

gcc/ada/

* sem_attr.adb (Resolve_Attribute): Resolve overloaded
N_Selected_Component prefix of 'Access. Required to handle
overloaded prefixed view of protected subprograms.