binutils-gdb.git
9 years agoUpdate year range in copyright notice of all files owned by the GDB project.
Joel Brobecker [Thu, 1 Jan 2015 09:32:14 +0000 (13:32 +0400)]
Update year range in copyright notice of all files owned by the GDB project.

gdb/ChangeLog:

        Update year range in copyright notice of all files.

9 years agoUpdate copyright year printed by gdb, gdbserver and gdbreplay.
Joel Brobecker [Thu, 1 Jan 2015 09:24:41 +0000 (13:24 +0400)]
Update copyright year printed by gdb, gdbserver and gdbreplay.

gdb/ChangeLog:

        * top.c (print_gdb_version): Update copyright year to 2015.

gdbserver/ChangeLog:

        * gdbreplay.c (gdbreplay_version): Update copyright year to 2015.
        * server.c (gdbserver_version): Likewise.

9 years agoYearly gdb/ChangeLog rotation.
Joel Brobecker [Thu, 1 Jan 2015 09:21:14 +0000 (13:21 +0400)]
Yearly gdb/ChangeLog rotation.

This patch renames gdb/'s ChangeLog to ChangeLog-2014 and creates
a new one for 2015. config/djgpp/fnchange.lst is updated accordingly.

gdb/ChangeLog:

  * config/djgpp/fnchange.lst: Add entry for gdb/ChangeLog-2014.

9 years agoAutomatic date update in version.in
GDB Administrator [Thu, 1 Jan 2015 00:00:10 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoRemove "add-shared-symbol-files", "dll-symbols" and "assf" commands doc.
Joel Brobecker [Tue, 30 Dec 2014 07:36:53 +0000 (11:36 +0400)]
Remove "add-shared-symbol-files", "dll-symbols" and "assf" commands doc.

This patch removes documentation from some commands whose support has
been recently removed.

gdb/ChangeLog:

        * NEWS: Document removal of "dll-symbols", "add-shared-symbol-files"
        and "assf" commands.

gdb/doc/ChangeLog:

        * gdb.texinfo (Files): Remove documentation of the
        "add-shared-symbol-files" and "assf" commands.
        (Cygwin Native): Remove documentation of the "dll-symbols"
        command.

9 years agoAssign file position for .strtab only if needed
H.J. Lu [Wed, 31 Dec 2014 03:09:11 +0000 (19:09 -0800)]
Assign file position for .strtab only if needed

bfd/

PR ld/17773
* elflink.c (bfd_elf_final_link): Assign the file position for
the symbol string table only there are symbols to be emitted.

ld/testsuite/

PR ld/17773
* ld-elf/binutils.exp (binutils_test): Add an optional
readelf_options.  Replace -l with $readelf_options.  Add a
gap test.
* ld/testsuite/ld-elf/gap.s: New file.

9 years agoAutomatic date update in version.in
GDB Administrator [Wed, 31 Dec 2014 00:00:24 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoFix executable indicator in file name completion on Windows.
Eli Zaretskii [Tue, 30 Dec 2014 19:14:25 +0000 (21:14 +0200)]
Fix executable indicator in file name completion on Windows.

* complete.c (stat_char) [_WIN32]: Don't use 'access' and X_OK on
Windows, they don't work.  Instead, look at the file-name
extension to determine whether the file is executable.

9 years agoRemove "dll-symbols", "add-shared-symbol-files" and assf" commands.
Joel Brobecker [Tue, 30 Dec 2014 07:30:01 +0000 (11:30 +0400)]
Remove "dll-symbols", "add-shared-symbol-files" and assf" commands.

This patch removes a set of commands that have been deprecated for
a while, and which we agreed to remove after the GDB 7.8 release.

gdb/ChangeLog:

* windows-nat.c (safe_symbol_file_add_stub)
(safe_symbol_file_add_cleanup, safe_symbol_file_add)
(dll_symbol_command): Delete.
(_initialize_windows_nat): Delete local variable "c".
Remove "dll-symbols", "add-shared-symbol-files" and assf"
commands.

Tested by rebuilding GDB on x86-windows.

9 years agoAutomatic date update in version.in
GDB Administrator [Tue, 30 Dec 2014 00:00:13 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoSanitize input_interrupt output
Sergio Durigan Junior [Mon, 29 Dec 2014 19:22:20 +0000 (14:22 -0500)]
Sanitize input_interrupt output

Hi,

This patch is a follow-up of the following discussions:

  <https://sourceware.org/ml/gdb-patches/2014-12/msg00421.html>
  <https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01293.html>

input_interrupt is currently emiting non-printable characters, which
is confusing the dg-extract-results.sh script.  This is obviously not
a good thing, and, by following Pedro's advices here:

  <https://gcc.gnu.org/ml/gcc-patches/2014-12/msg01320.html>

I adapted the function to print "client connection closed" when it
receives a NUL character, or use the "isprint" function to decide how
to print the received char.  I tested it by running the testcases that
were printing the non-printable chars before:

  gdb.base/gdb-sigterm.exp
  gdb.threads/non-ldr-exc-1.exp
  gdb.threads/non-ldr-exc-2.exp
  gdb.threads/non-ldr-exc-3.exp
  gdb.threads/non-ldr-exc-4.exp
  gdb.threads/thread-execl.exp

and confirming that they print the right message.  I tried a bit to
come up with a testcase for this, but failed, and since I did not want
to spend too much time on it, I'm sending the patch anyway.

Comments are welcome, as usual.

gdb/gdbserver/ChangeLog:
2014-12-29  Sergio Durigan Junior  <sergiodj@redhat.com>

* remote-utils.c: Include ctype.h.
(input_interrupt): Explicitly handle the case when the char
received is the NUL byte.  Improve the printing of non-ASCII
characters.

9 years ago[PATCH] Remove cast in Tag_ABI_VFP_args switch case stmts
Jiong Wang [Mon, 29 Dec 2014 14:56:36 +0000 (14:56 +0000)]
[PATCH] Remove cast in Tag_ABI_VFP_args switch case stmts

  2014-12-29  Thomas Preud'homme  <thomas.preudhomme@arm.com>

  gdb/
    * arm-tdep.c (arm_gdbarch_init): Remove casts in Tag_ABI_VFP_args
    switch case statements.

9 years agoClean up gdb.trace/entry-values.exp
Yao Qi [Mon, 29 Dec 2014 03:56:51 +0000 (11:56 +0800)]
Clean up gdb.trace/entry-values.exp

This patch is to clean up gdb.trace/entry-values.exp as a preparation
of the next patch.  It updates the comments to reflect the code.

One DIE generated in dwarf assembler is

  GNU_call_site {
    {low_pc "$bar_start + $bar_call_foo" addr}
      {abstract_origin :$foo_label}

the DW_AT_low_pc attribute is the return address after the call, so I
rename variable bar_call_foo to returned_from_foo.

gdb/testsuite:

2014-12-29  Yao Qi  <yao@codesourcery.com>

* gdb.trace/entry-values.exp: Update comments.  Rename variable
bar_call_foo to returned_from_foo.

9 years agoAdd moxiebox target support
Anthony Green [Mon, 29 Dec 2014 05:42:55 +0000 (00:42 -0500)]
Add moxiebox target support

9 years agoAutomatic date update in version.in
GDB Administrator [Mon, 29 Dec 2014 00:00:14 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoMisplaced parenthesis calculates two too few bytes for string
Alan Modra [Sun, 28 Dec 2014 04:58:19 +0000 (15:28 +1030)]
Misplaced parenthesis calculates two too few bytes for string

Factor out strlen to give better code and less likelihood of a repeat
of this problem.

PR 17766
* pei-x86_64.c (pex64_bfd_print_pdata_section): Correct string
length.  Use memcpy rather than strcpy.

9 years agoFix small spelling mistake in gdb/ChangeLog.
Joel Brobecker [Sun, 28 Dec 2014 03:44:49 +0000 (07:44 +0400)]
Fix small spelling mistake in gdb/ChangeLog.

9 years agoAutomatic date update in version.in
GDB Administrator [Sun, 28 Dec 2014 00:00:09 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoUpdate for moxie ISA changes
Anthony Green [Sat, 27 Dec 2014 23:37:58 +0000 (18:37 -0500)]
Update for moxie ISA changes

9 years agoUpdate sto/ldo implementations with 16 bit offsets
Anthony Green [Sat, 27 Dec 2014 23:19:49 +0000 (18:19 -0500)]
Update sto/ldo implementations with 16 bit offsets

9 years agoLimit moxie sto/ldo offsets to 16 bits
Anthony Green [Sat, 27 Dec 2014 15:57:04 +0000 (10:57 -0500)]
Limit moxie sto/ldo offsets to 16 bits

9 years agoAutomatic date update in version.in
GDB Administrator [Sat, 27 Dec 2014 00:00:12 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoUpdate two sh64 ld test's expected output
Alan Modra [Fri, 26 Dec 2014 11:40:52 +0000 (22:10 +1030)]
Update two sh64 ld test's expected output

At some stage someone fixed a bug in ld -r output, preserving
SHF_INFO_LINK from input objects.  These two tests expected the old
wrong output.

* ld-sh/sh64/crangerel1.rd: Update.
* ld-sh/sh64/crangerel2.rd: Update.

9 years agoDelete unnecessary code copying SHF_SH5_ISA32 flag
Alan Modra [Fri, 26 Dec 2014 07:56:38 +0000 (18:26 +1030)]
Delete unnecessary code copying SHF_SH5_ISA32 flag

Since 2006, commit d270463e9, _bfd_elf_copy_private_section_data has
copied over SHF_MASKOS and SHF_MASKPROC flags.  That makes the buggy
code in sh_elf64_copy_private_data_internal redundant.

bfd/
PR 17755
* elf64-sh64.c (sh_elf64_copy_private_data_internal): Delete code
copying SHF_SH5_ISA32.
binutils/testsuite/
* binutils-all/strip-11.d: New test.
* binutils-all/objcopy.exp: Run it.

9 years agoAutomatic date update in version.in
GDB Administrator [Fri, 26 Dec 2014 00:00:09 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoWhitespace cleanup
Anthony Green [Thu, 25 Dec 2014 13:26:57 +0000 (08:26 -0500)]
Whitespace cleanup

9 years agoWhitespace cleanup
Anthony Green [Thu, 25 Dec 2014 13:26:57 +0000 (08:26 -0500)]
Whitespace cleanup

9 years agoARM: Add support for value 3 of Tag_ABI_VFP_args attribute
Alan Modra [Thu, 25 Dec 2014 11:45:14 +0000 (22:15 +1030)]
ARM: Add support for value 3 of Tag_ABI_VFP_args attribute

Missing from 5c294fee

elfcpp/
* arm.h: Add enums for Tag_ABI_FP_number_model and Tag_ABI_VFP_args.
gold/
* arm.cc (Target_arm::do_adjust_elf_header): Provide namespace on
new enums.
(Target_arm::merge_object_attributes, ): Likewise.

9 years agoDon't pass unadorned zeros to varargs functions
Yaakov Selkowitz [Thu, 25 Dec 2014 10:55:38 +0000 (21:25 +1030)]
Don't pass unadorned zeros to varargs functions

PR gas/17753
* config/tc-mep.c (md_begin): Specify types of vararg literals.

9 years agoARM: Add support for value 3 of Tag_ABI_VFP_args attribute
Terry Guo [Thu, 25 Dec 2014 01:50:48 +0000 (09:50 +0800)]
ARM: Add support for value 3 of Tag_ABI_VFP_args attribute

*** bfd/ChangeLog ***

2014-12-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

* elf32-arm.c (elf32_arm_merge_eabi_attributes): Handle new
Tag_ABI_VFP_args value and replace hardcoded values by enum
values.
(elf32_arm_post_process_headers): Set e_flags in ELF header
as hard float only when Tag_ABI_VFP_args is 1, using new enum
value AEABI_VFP_args_vfp to check that.

*** binutils/ChangeLog ***

2014-12-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

* readelf.c (arm_attr_tag_ABI_VFP_args): Add "compatible".

*** gdb/ChangeLog ***

2014-12-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

* arm-tdep.c (arm_gdbarch_init): Explicitely handle value 3 of
Tag_ABI_VFP_args. Also replace hardcoded values by enum values
in the switch handling the different values of Tag_ABI_VFP_args.

*** gold/ChangeLog ***

2014-12-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

* arm.cc (Target_arm::do_adjust_elf_header): Set e_flags in ELF
header as hard float only when Tag_ABI_VFP_args is 1, using new
enum value AEABI_VFP_args_vfp to check that.
(Target_arm::merge_object_attributes): Handle new Tag_ABI_VFP_args
value and replace hardcoded values by enum values.

*** include/elf/ChangeLog ***

2014-12-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

* arm.h: New AEABI_FP_number_model_* and AEABI_VFP_args_* enum
values.

*** ld/testsuite/ChangeLog ***

2014-12-25  Thomas Preud'homme  <thomas.preudhomme@arm.com>

* ld-arm/attr-merge-2a.s: Add Tag_ABI_VFP_args.
* ld-arm/attr-merge-2b.s: Likewise.
* ld-arm/attr-merge-2.attr: Likewise.
* ld-arm/attr-merge-4a.s: Add Tag_ABI_FP_number_model and
Tag_ABI_VFP_args.
* ld-arm/attr-merge-4b.s: Likewise.
* ld-arm/attr-merge-4.attr: Likewise.
* ld-arm/attr-merge-6a.s: Likewise.
* ld-arm/attr-merge-6b.s: Likewise.
* ld-arm/attr-merge-6.attr: Add Tag_ABI_FP_number_model.

9 years agoAutomatic date update in version.in
GDB Administrator [Thu, 25 Dec 2014 00:00:09 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoAdd cast to unsigned long
H.J. Lu [Wed, 24 Dec 2014 22:14:14 +0000 (14:14 -0800)]
Add cast to unsigned long

* pei-x86_64.c (pex64_bfd_print_pdata_section): Add cast to
unsigned long.

9 years agoAVR: Document linker relaxation related options.
Andrew Burgess [Tue, 23 Dec 2014 17:46:45 +0000 (17:46 +0000)]
AVR: Document linker relaxation related options.

Adds documentation describing the -mlink-relax and -mno-link-relax
command line options.

gas/ChangeLog:

* doc/c-avr.texi: Document -mlink-relax and -mno-link-relax.

9 years agoAVR: Assembler now prepares for linker relaxation by default.
Andrew Burgess [Mon, 27 Oct 2014 10:51:17 +0000 (10:51 +0000)]
AVR: Assembler now prepares for linker relaxation by default.

Have the assembler prepare for linker relaxation by default.  This
means that users will be able to make use of linker relaxation without
having to adjust the assembler flags, this can make life easier when
compiling libraries.

Having this on by default in the assembler should make no difference to
the assembler code produced, however, some of the debug information will
be slightly less compressed.

A few tests needed to be updated as a result of this change as they
relied on linker relaxation support being off by default.

I've tightened up the definition of which sections can be relaxed on AVR
as part of this commit, the assembler used to think that all
non-debugging sections could be relaxed, when in reality only code
sections can be relaxed for AVR.  The previous definition was not
dangerous, just over cautious.  The new tighter definition allows an
extra test (gas/testsuite/gas/all/forward.d) to continue to pass.

gas/ChangeLog:

* config/tc-avr.c (struct avr_opt_s): Change link_relax to
no_link_relax, extend comment.
(enum options): Add new OPTION_NO_LINK_RELAX.
(md_longopts): Add entry for -mno-link-relax.
(md_parse_option): Handle OPTION_NO_LINK_RELAX, and update
OPTION_LINK_RELAX.
(md_begin): Initialise linkrelax from no_link_relax.
(md_show_usage): Include -mno-link-relax option.
(relaxable_section): Only allocatable code sections can be
relaxed.
* config/tc-avr.h (TC_LINKRELAX_FIXUP): Define.

gas/testsuite/ChangeLog:

* gas/all/gas.exp: Test will not pass on AVR due to linker
relaxation support.
* gas/avr/noreloc_withoutrelax.d: Add -mno-link-relax option.
* gas/avr/link-relax-elf-flag-clear.d: Likewise.

ld/testsuite/ChangeLog:

* ld/testsuite/ld-avr/relax-elf-flags-02.d: Add -mno-link-relax
option.
* ld/testsuite/ld-avr/relax-elf-flags-03.d: Likewise.
* ld/testsuite/ld-avr/relax-elf-flags-04.d: Likewise.
* ld/testsuite/ld-avr/relax-elf-flags-05.d: Likewise.
* ld/testsuite/ld-avr/relax-elf-flags-06.d: Likewise.

9 years agoThis patch fixes a snafu where the -D and -U short versions of the
Alexander Cherepanov [Wed, 24 Dec 2014 14:50:53 +0000 (14:50 +0000)]
This patch fixes a snafu where the -D and -U short versions of the
--enable-deterministic-archives and --disable-deteministic-archive
options were not being accepted.

PR binutils/17671
* objcopy.c (copy_main, strip_main): Add D and U to the list of
accepted short versions of long options.

9 years agoAdd support for moxie's mul.x and umul.x instructions
Anthony Green [Wed, 24 Dec 2014 13:37:16 +0000 (08:37 -0500)]
Add support for moxie's mul.x and umul.x instructions

9 years agoAdd mul.x and umul.x instructions to moxie port
Anthony Green [Wed, 24 Dec 2014 13:34:23 +0000 (08:34 -0500)]
Add mul.x and umul.x instructions to moxie port

9 years agoDon't create .eh_frame_hdr on shared lib bfd
Alan Modra [Wed, 24 Dec 2014 11:37:42 +0000 (22:07 +1030)]
Don't create .eh_frame_hdr on shared lib bfd

If no object files have .eh_frame, but some shared library does, then
ld creates a .eh_frame_hdr section using the shared library bfd.  This
is silly since shared library .eh_frame sections don't contribute to
the output .eh_frame and thus no .eh_frame_hdr is needed.

Also, the bfd section list and count is cleared for shared libraries,
and a zero section count used as a flag in lang_check to omit a call
to bfd_merge_private_bfd_data for shared libraries.  If we create a
section on a shared lib bfd then ld will wrongly attempt to merge the
shared library private bfd data.

PR 17742
* ld/emultempl/elf32.em (gld${EMULATION_NAME}_after_open): Exclude
shared libraries in loop looking for .eh_frame sections.
Similarly for build-id loop.

9 years agoThis patch adds support for printing out the pdata section of PE objects.
Pierre Muller [Wed, 24 Dec 2014 10:06:57 +0000 (10:06 +0000)]
This patch adds support for printing out the pdata section of PE objects.

* pe-x86_64.c (pex64_bfd_print_pdata): Add external
declaration.
(bfd_pe_print_data): Set macro to pex64_bfd_print_data.
* pei-x86_64.c (pex64_bfd_print_pdata): Changed to
global function. Now handles multiple .pdata sections.
(pex_bfd_print_pdata_section): New static helper function,
using most of old pex_bfd_print_pdata function code, but adding
support for coff pe objects, which might have some fields
starting at zero offset.
(pex64_print_all_pdata_sections) : New static helper function,
used in call to bfd_map_over_sections inside new
pex66_bfd_print_pdata function.
(bfd_boolean pdata_count): New static variable, used to return
bfd_boolean value for pex64_bfd_print_pdata function.

9 years agoReverts an "enhancement" made in a previous delta which complained of
Nick Clifton [Wed, 24 Dec 2014 08:21:50 +0000 (08:21 +0000)]
Reverts an "enhancement" made in a previous delta which complained of
unprocessed augmentation data at the end of a CIE.

* dwarf.c (read_cie): Revert check for unused augmentation data -
it was bogus.

9 years agoFix generic linker symbol output when weak is overridden by strong
Alan Modra [Wed, 24 Dec 2014 01:22:26 +0000 (11:52 +1030)]
Fix generic linker symbol output when weak is overridden by strong

Yes, I know this also affects bfd_link_hash_indirect, but output of
indirect and warning symbols looks quite broken anyway.

* linker.c (_bfd_generic_link_output_symbols): Remove BSF_WEAK
flag from bfd_link_hash_defined symbols.

9 years agoYet another DEFINED testcase
Alan Modra [Tue, 23 Dec 2014 14:33:44 +0000 (01:03 +1030)]
Yet another DEFINED testcase

* ld-scripts/defined6.s,
* ld-scripts/defined6.t,
* ld-scripts/defined6.d: New test.
* ld-scripts/defined.exp: Run it.

9 years agoAutomatic date update in version.in
GDB Administrator [Wed, 24 Dec 2014 00:00:10 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoClarify strip docs.
Andrew Stubbs [Tue, 23 Dec 2014 20:28:16 +0000 (20:28 +0000)]
Clarify strip docs.

binutils/
* objcopy.c (strip_usage): Reword --remove-section description.
* doc/binutils.texi (strip): Likewise.

9 years agoLook up primitive types as symbols.
Doug Evans [Tue, 23 Dec 2014 15:55:39 +0000 (07:55 -0800)]
Look up primitive types as symbols.

gdb/ChangeLog:

* ada-lang.c (user_select_syms): Only fetch symtab if symbol is
objfile-owned.
(cache_symbol): Ignore symbols that are not objfile-owned.
* block.c (block_objfile): New function.
(block_gdbarch): New function.
* block.h (block_objfile): Declare.
(block_gdbarch): Declare.
* c-exp.y (classify_name): Remove call to
language_lookup_primitive_type.  No longer necessary.
* gdbtypes.c (lookup_typename): Call lookup_symbol_in_language.
Remove call to language_lookup_primitive_type.  No longer necessary.
* guile/scm-symbol.c (syscm_gdbarch_data_key): New static global.
(syscm_gdbarch_data): New struct.
(syscm_init_arch_symbols): New function.
(syscm_get_symbol_map): Renamed from syscm_objfile_symbol_map.
All callers updated.  Handle symbols owned by arches.
(gdbscm_symbol_symtab): Handle symbols owned by arches.
(gdbscm_initialize_symbols): Initialize syscm_gdbarch_data_key.
* language.c (language_lookup_primitive_type_1): New function.
(language_lookup_primitive_type): Call it.
(language_alloc_type_symbol): New function.
(language_init_primitive_type_symbols): New function.
(language_lookup_primitive_type_as_symbol): New function.
* language.h (struct language_arch_info) <primitive_type_symbols>:
New member.
(language_lookup_primitive_type): Add function comment.
(language_lookup_primitive_type_as_symbol): Declare.
* printcmd.c (address_info): Handle arch-owned symbols.
* python/py-symbol.c (sympy_get_symtab): Ditto.
(set_symbol): Ditto.
(sympy_dealloc): Ditto.
* symmisc.c (print_symbol): Ditto.
* symtab.c (fixup_symbol_section): Ditto.
(lookup_symbol_aux): Initialize block_found.
(basic_lookup_symbol_nonlocal): Try looking up the symbol as a
primitive type.
(initialize_objfile_symbol_1): New function.
(initialize_objfile_symbol): Call it.
(allocate_symbol): Call it.
(allocate_template_symbol): Call it.
(symbol_objfile): Assert symbol is objfile-owned.
(symbol_arch, symbol_symtab, symbol_set_symtab): Ditto.
* symtab.h (struct symbol) <owner>: Replaces member "symtab".
(struct symbol) <is_objfile_owned>: New member.
(SYMBOL_OBJFILE_OWNED): New macro.
* cp-namespace.c (cp_lookup_bare_symbol): New arg langdef.
All callers updated.  Try to find the symbol as a primitive type.
(lookup_namespace_scope): New arg langdef.  All callers updated.
Call cp_lookup_bare_symbol directly for simple bare symbols.

9 years agoAVR/ld: Propagate link-relax elf header flag correctly.
Andrew Burgess [Sat, 22 Nov 2014 23:25:17 +0000 (23:25 +0000)]
AVR/ld: Propagate link-relax elf header flag correctly.

The AVR target has an elf header flag to indicate if an object was
assembler ready for linker relaxation.  If a partial link is performed
then it is important that the link-relax flag in the output object is
set correctly, otherwise, during the final link, we might try to perform
linker relaxation on code that was not assembled suitably.

As the link-relax elf header covers the entire object file we must be
conservative when setting the flag in the output object, so, for a
partial link, any input object that does not have the link-relax flag
set will cause the output object to also not have the link-relax flag
set.

This conservative approach could be softened in future, we only need to
disable the link relax flag if an input file is not marked link-relax
ready, and the input file contains a relaxable section.  However, I've
left this optimisation for a later day.

For the final link I've overloaded the use of the link-relax elf header
flag, in a final executable, the flag now indicates if the executable
was built with linker relaxation on or not.

ld/ChangeLog:

* emultempl/avrelf.em: Add include of elf/avr.h.
(avr_finish): New function.
(LDEMUL_FINISH): Added.

ld/testsuite/ChangeLog:

* ld-avr/relax-elf-flags-01.d: New file.
* ld-avr/relax-elf-flags-02.d: New file.
* ld-avr/relax-elf-flags-03.d: New file.
* ld-avr/relax-elf-flags-04.d: New file.
* ld-avr/relax-elf-flags-05.d: New file.
* ld-avr/relax-elf-flags-06.d: New file.
* ld-avr/relax-elf-flags-07.d: New file.
* ld-avr/relax-elf-flags-08.d: New file.
* ld-avr/relax-elf-flags-a.s: New file.
* ld-avr/relax-elf-flags-b.s: New file.

9 years agoAVR: Only set link-relax elf flag when appropriate.
Andrew Burgess [Sat, 22 Nov 2014 23:19:31 +0000 (23:19 +0000)]
AVR: Only set link-relax elf flag when appropriate.

The AVR target uses a bit in the elf header flags to indicate if the
object was assembled ready for linker relaxation.  Previously this flag
was always set, even when the object was not assembled ready for linker
relaxation.

This patch moves setting of the flag into the assembler, and sets it
only when the assembler is preparing the file for linker relaxation.

bfd/ChangeLog:

* elf32-avr.c (bfd_elf_avr_final_write_processing): Don't set
EF_AVR_LINKRELAX_PREPARED unconditionally.

gas/ChangeLog:

* config/tc-avr.c: Add include for elf/avr.h.
(avr_elf_final_processing): New function.
* config/tc-avr.h (elf_tc_final_processing): Define.
(avr_elf_final_processing): Declare

gas/testsuite/ChangeLog:

* gas/avr/link-relax-elf-flag-clear.d: New file.
* gas/avr/link-relax-elf-flag-set.d: New file.
* gas/avr/link-relax-elf-flag.s: New file.

9 years agosymtab.h (SYMBOL_DOMAIN_BITS): New macro.
Doug Evans [Tue, 23 Dec 2014 15:31:00 +0000 (07:31 -0800)]
symtab.h (SYMBOL_DOMAIN_BITS): New macro.

gdb/ChangeLog:

* symtab.h (SYMBOL_DOMAIN_BITS): New macro.
(struct symbol) <domain>: Use it.

9 years agoinitialize_objfile_symbol: Renamed from initialize_symbol.
Doug Evans [Tue, 23 Dec 2014 15:28:28 +0000 (07:28 -0800)]
initialize_objfile_symbol: Renamed from initialize_symbol.

gdb/ChangeLog:

* symtab.c (initialize_objfile_symbol): Renamed from initialize_symbol.
All callers updated.

9 years agoAdd langdef arg to la_lookup_symbol_nonlocal.
Doug Evans [Tue, 23 Dec 2014 15:24:48 +0000 (07:24 -0800)]
Add langdef arg to la_lookup_symbol_nonlocal.

gdb/ChangeLog:

* language.h (struct language_defn) <la_lookup_symbol_nonlocal>:
New arg language_defn.  All uses updated.

9 years agoReplace some symbol accessor macros with functions.
Doug Evans [Tue, 23 Dec 2014 15:21:10 +0000 (07:21 -0800)]
Replace some symbol accessor macros with functions.

gdb/ChangeLog:

* symtab.h (SYMBOL_SYMTAB): Delete
(SYMBOL_OBJFILE): Delete.
(symbol_symtab, symbol_set_symtab): Declare.
(symbol_objfile, symbol_arch): Declare.
* symtab.c (symbol_symtab): Replaces SYMBOL_SYMTAB.  All uses updated.
All references to symbol->symtab redirected through here.
(symbol_set_symtab): New function.  All assignments to SYMBOL_SYMTAB
redirected through here.
(symbol_arch): New function.
(symbol_objfile): New function.  Replaces SYMBOL_OBJFILE.
All uses updated.
* cp-namespace.c (cp_lookup_symbol_imports_or_template): Call
symbol_arch.
* findvar.c (default_read_var_value): Call symbol_arch.
* guile/scm-frame.c (gdbscm_frame_block): Call symbol_objfile.
* jv-lang.c (add_class_symtab_symbol): Call symbol_arch.
* printcmd.c (address_info): Call symbol_arch.
* tracepoint.c (scope_info): Call symbol_arch.

9 years agoThis patch add support for cpu marvell-whitney.
Nick Clifton [Tue, 23 Dec 2014 13:41:13 +0000 (13:41 +0000)]
This patch add support for cpu marvell-whitney.

         * gas/config/tc-arm.c (arm_cpus): Add core marvell-whitney.

9 years agoReformat the objdump.1 man output to avoid overlong lines.
Nick Clifton [Tue, 23 Dec 2014 13:11:10 +0000 (13:11 +0000)]
Reformat the objdump.1 man output to avoid overlong lines.

9 years agoReport an error for script multiply defined symbols
Alan Modra [Mon, 22 Dec 2014 00:41:50 +0000 (11:11 +1030)]
Report an error for script multiply defined symbols

or maybe not just yet, but this is better than a FIXME.

* ldexp.c (update_definedness): Return false if script symbol is
redefining a strong symbol in an object.
(exp_fold_tree_1 <etree_assign>): Set up for reporting a multiple
definition error, but for now leave disabled.

9 years agoUse a symbol flag bit to mark linker defined symbols
Alan Modra [Tue, 23 Dec 2014 08:37:23 +0000 (19:07 +1030)]
Use a symbol flag bit to mark linker defined symbols

Trying to use the SEC_LINKER_CREATED section flag to determine whether
a symbol is linker defined fails to work on targets like alpha that
define special SEC_COMMON sections.  These might contain symbols that
originated in an object file.

include/
* bfdlink.h (struct bfd_link_hash_entry): Comment non_ir_ref.  Add
linker_def.
bfd/
* elflink.c (_bfd_elf_define_linkage_sym): Set linker_def.
* linker.c (_bfd_generic_link_add_one_symbol): Clear linker_def
for CDEF, DEF, DEFW, COM.
ld/
* ldexp.c (exp_fold_tree_1 <etree_provide>): Test linker_def.
ld/testsuite/
* ld-powerpc/sdabase.s,
* ld-powerpc/sdabase.t,
* ld-powerpc/sdabase.d: New test.
* ld-powerpc/sdabase2.t,
* ld-powerpc/sdabase2.d: New test.
* ld-powerpc/powerpc.exp: Run them.

9 years agoDon't PROVIDE over top of common symbols
Alan Modra [Mon, 22 Dec 2014 00:19:23 +0000 (10:49 +1030)]
Don't PROVIDE over top of common symbols

This:
  int end[100000];
  int main(void) { end[99999] = 0; return 0; }
should not segfault.

ld/
* ldexp.c (exp_fold_tree_1 <etree_provide>): Leave bfd_link_hash_common
symbols alone.
ld/testsuite/
* ld-elf/endsym.s, *ld-elf/endsym.d: New test.

9 years agoCorrect logic for "defined by object"
Alan Modra [Mon, 22 Dec 2014 04:13:49 +0000 (14:43 +1030)]
Correct logic for "defined by object"

The old code missed testing bfd_link_hash_undefweak, and wrongly
excluded bfd_link_hash_common symbols.  It is also clearer to invert
the set of enum bfd_link_hash_type values tested.
bfd_link_hash_indirect and bfd_link_hash_warning will never appear
here.

* ldexp.c (update_definedness): Correct logic setting by_object.

9 years agoMove support code for linker script DEFINED to ldexp.c
Alan Modra [Mon, 22 Dec 2014 00:15:13 +0000 (10:45 +1030)]
Move support code for linker script DEFINED to ldexp.c

This moves support code for DEFINED to ldexp.c where it is used,
losing the lang_ prefix on identifiers.  Two new functions are needed
to initialize and clean up to hash table, but other than that there
are no functional changes here.

* ldexp.c (struct definedness_hash_entry, definedness_table)
(definedness_newfunc, symbol_defined, update_definedness): Move
and rename from..
* ldlang.h (struct lang_definedness_hash_entry): ..here,..
* ldlang.c (lang_definedness_table, lang_definedness_newfunc)
(lang_symbol_defined, lang_update_definedness): ..and here.
* ldexp.c (ldexp_init, ldexp_finish): New functions, extracted from..
* ldlang.c (lang_init, lang_finish): ..here.
* ldexp.h (ldexp_init, ldexp_finish): Declare.
* ldlang.h (lang_symbol_defined, lang_update_definedness): Delete.
* ldmain.c (main): Call ldexp_init and ldexp_finish.

9 years agoUpdated translations for the gas and gprof tools.
Nick Clifton [Tue, 23 Dec 2014 12:39:34 +0000 (12:39 +0000)]
Updated translations for the gas and gprof tools.

* po/es.po: Updated Esperanto translation.
* po/fr.po: Updated French translation.
* po/uk.po: Updated Ukrainian translation.

9 years agoAutomatic date update in version.in
GDB Administrator [Tue, 23 Dec 2014 00:00:12 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoCast size to long to warn
H.J. Lu [Mon, 22 Dec 2014 23:29:21 +0000 (15:29 -0800)]
Cast size to long to warn

* dwarf.c (read_cie): Cast size to long to warn.

9 years agoMore fixes for invalid memory accesses exposed by fuzzed binaries.
Nick Clifton [Mon, 22 Dec 2014 22:44:34 +0000 (22:44 +0000)]
More fixes for invalid memory accesses exposed by fuzzed binaries.

PR binutils/17531
* dwarf.c (decode_location_expression): Check for an out of range
value for a DW_OP_GNU_entry_value expression.
(display_debug_lines_raw): Check for a partial
.debug_line. section being encountered without a prior, full
.debug.line section.
(display_debug_lines_decoded): Likewise.  Also check for
li_line_range being zero.
(display_debug_pubnames_worker): Check for an invalid pn_length
field.
(read_cie): Add range checks.
* elfcomm.c (setup_archive): Check for a negative longnames_size.

9 years agoMore fixes for memory access violations exposed by fuzzed binaries.
Nick Clifton [Mon, 22 Dec 2014 20:59:00 +0000 (20:59 +0000)]
More fixes for memory access violations exposed by fuzzed binaries.

PR binutils/17512
* archive.c (do_slurp_bsd_armap): Return if the parsed_size is
zero.
(bfd_slurp_armap): Zero terminate the name.
(bfd_generic_stat_arch_elt): If there is no header, fail.
* elf32-arc.c (arc_info_to_howto_rel): Replace BFD_ASSERT with
error message.
* elf32-avr.c (avr_info_to_howto_rela): Likewise.
* elf32-cr16c.c (elf_cr16c_info_to_howto_rel): Likewise.
* elf32-cris.c (cris_info_to_howto_rela): Likewise.
* elf32-d10v.c (d10v_info_to_howto_rel): Likewise.
* elf32-d30v.c (d30v_info_to_howto_rel): Likewise.
* elf32-dlx.c (dlx_rtype_to_howto): Likewise.
* elf32-epiphany.c (epiphany_info_to_howto_rela): Likewise.
* elf32-fr30.c (fr30_info_to_howto_rela): Likewise.
* elf32-frv.c (frv_info_to_howto_rela): Likewise.
* elf32-i960.c (elf32_i960_info_to_howto_rel): Likewise.
* elf32-ip2k.c (ip2k_info_to_howto_rela): Likewise.
* elf32-iq2000.c (iq2000_info_to_howto_rela): Likewise.
* elf32-lm32.c (lm32_info_to_howto_rela): Likewise.
* elf32-m32c.c (m32c_info_to_howto_rela): Likewise.
* elf32-m32r.c (m32r_info_to_howto_rel): Likewise.
* elf32-m68hc11.c (m68hc11_info_to_howto_rel): Likewise.
* elf32-m68hc12.c (m68hc11_info_to_howto_rel): Likewise.
* elf32-mep.c (mep_info_to_howto_rela): Likewise.
* elf32-metag.c (metag_info_to_howto_rela): Likewise.
* elf32-moxie.c (moxie_info_to_howto_rela): Likewise.
* elf32-msp430.c (msp430_info_to_howto_rela): Likewise.
* elf32-mt.c (mt_info_to_howto_rela): Likewise.
* elf32-nds32.c (nds32_info_to_howto_rel): Likewise.
* elf32-or1k.c (or1k_info_to_howto_rela): Likewise.
* elf32-rl78.c (rl78_info_to_howto_rela): Likewise.
* elf32-rx.c (rx_info_to_howto_rela): Likewise.
* elf32-v850.c (v850_elf_info_to_howto_rel): Likewise.
* elf32-visium.c (visium_info_to_howto_rela): Likewise.
* elf32-xgate.c (xgate_info_to_howto_rel): Likewise.
* elf32-xtensa.c (elf_xtensa_info_to_howto_rela): Likewise.
* elf64-mmix.c (mmix_info_to_howto_rela): Likewise.
* elf64-x86-64.c (elf_x86_64_reloc_type_lookup): Likewise.
* elfnn-aarch64.c (elfNN_aarch64_bfd_reloc_from_type): Likewise.
* elf64-sparc.c (elf64_sparc_slurp_one_reloc_table): Add range
checking of reloc symbol index.
* mach-o.c (bfd_mach_o_canonicalize_one_reloc): If no symbols have
been provided then set the reloc's symbol to undefined.
* reloc.c (bfd_generic_get_relocated_section_contents): Add range
checking of the reloc to be applied.
* versados.c (process_otr): Add more range checks.
(versados_canonicalize_reloc): If the section is unknown, set the
symbol to undefined.
* vms-alpha.c (_bfd_vms_slurp_eisd): Add range checks.
(alpha_vms_object_p): Likewise.

9 years agogold/
Cary Coutant [Mon, 22 Dec 2014 18:13:37 +0000 (10:13 -0800)]
gold/
* powerpc.cc (Target_powerpc::relocate): Fix overflow check.

9 years agocp-namespace.c (cp_lookup_symbol_via_all_imports): New function.
Doug Evans [Mon, 22 Dec 2014 17:29:25 +0000 (09:29 -0800)]
cp-namespace.c (cp_lookup_symbol_via_all_imports): New function.

gdb/ChangeLog:

* cp-namespace.c (cp_lookup_symbol_via_all_imports): New function.
(cp_lookup_symbol_namespace): Call it.
(cp_lookup_symbol_nonlocal): Ditto.

9 years agocp-namespace.c (cp_lookup_symbol_via_imports): New arg "search_scope_first".
Doug Evans [Mon, 22 Dec 2014 17:20:50 +0000 (09:20 -0800)]
cp-namespace.c (cp_lookup_symbol_via_imports): New arg "search_scope_first".

gdb/ChangeLog:

* cp-namespace.c (cp_lookup_symbol_via_imports): New arg
"search_scope_first".  All callers updated.

9 years agocp-namespace.c (cp_lookup_nested_symbol_1): New function.
Doug Evans [Mon, 22 Dec 2014 17:11:44 +0000 (09:11 -0800)]
cp-namespace.c (cp_lookup_nested_symbol_1): New function.

gdb/ChangeLog:

* cp-namespace.c (cp_lookup_nested_symbol_1): New function.
(cp_basic_lookup_symbol): Renamed from lookup_symbol_file.  Delete
arg "search".  All callers updated.
(cp_lookup_bare_symbol): New function.
(cp_search_static_and_baseclasses): New function.
(cp_lookup_symbol_in_namespace): Rewrite, move more logic here.
(find_symbol_in_baseclass): Simplify, call cp_lookup_nested_symbol_1.
(cp_lookup_nested_symbol): Ditto.

9 years agocp-namespace.c (cp_lookup_symbol_in_namespace): Simplify.
Doug Evans [Mon, 22 Dec 2014 16:44:50 +0000 (08:44 -0800)]
cp-namespace.c (cp_lookup_symbol_in_namespace): Simplify.

gdb/ChangeLog:

* cp-namespace.c (cp_lookup_symbol_in_namespace): Simplify.

9 years agocp-namespace.c: Whitespace cleanup.
Doug Evans [Mon, 22 Dec 2014 16:42:02 +0000 (08:42 -0800)]
cp-namespace.c: Whitespace cleanup.

gdb/ChangeLog:

* cp-namespace.c: Whitespace cleanup.

9 years agoAutomatic date update in version.in
GDB Administrator [Mon, 22 Dec 2014 00:00:10 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoAutomatic date update in version.in
GDB Administrator [Sun, 21 Dec 2014 00:00:16 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agogdb/17394: cannot put breakpoint only in selected ASM file.
Mihail-Marian Nistor [Sat, 20 Dec 2014 16:04:44 +0000 (11:04 -0500)]
gdb/17394: cannot put breakpoint only in selected ASM file.

This patch fixes a problem when trying to insert a breakpoint on
a specific symbol defined in a specific file, eg:

    break foo.c:func

This currently works for files in C/C++/Ada, etc, but doesn't always
work for Asm files. Analysis of the problem showed that this related
to a limitation in gas, which does not generate debug info for functions/
symbols.  Thus, we have a symtab for the file ("info sources" shows
the file), but it contains no symbols.

When find_linespec_symbols is called in linespec_parse_basic, it calls
find_function_symbols, which uses add_matching_symbols_to_info to
collect all matching symbols.

That function does [pardon any mangled formatting]:

  for (ix = 0; VEC_iterate (symtab_ptr, info->file_symtabs, ix, elt); ++ix)
    {
      if (elt == NULL)
        {
          iterate_over_all_matching_symtabs (info->state, name, VAR_DOMAIN,
                                             collect_symbols, info,
                                             pspace, 1);
          search_minsyms_for_name (info, name, pspace);
        }
      else if (pspace == NULL || pspace == SYMTAB_PSPACE (elt))
        {
          /* Program spaces that are executing startup should have
             been filtered out earlier.  */
          gdb_assert (!SYMTAB_PSPACE (elt)->executing_startup);
          set_current_program_space (SYMTAB_PSPACE (elt));
          iterate_over_file_blocks (elt, name, VAR_DOMAIN,
                                    collect_symbols, info);
        }
    }

This iterates over the symtabs. In the failing use case, ELT is
non-NULL (points to the symtab for the .s file), so it calls
iterate_over_file_blocks. Herein is where the problem exists: it is
assumed that if NAME exists, it must exist in the given symtab -- a
reasonable assumption for "normal" (non-asm) cases. It never searches
minimal symbols (or in the global default symtab).

This patch fixes the problem by doing so. It is important to note that
iterating over minsyms is fairly expensive, so this patch only adds
that extra search if the language is language_asm and
iterate_over_file_blocks returns no symbols.

gdb/ChangeLog:
2014-12-20  Keith Seitz  <keiths@redhat.com>
            Mihail-Marian Nistor  <mihail.nistor@freescale.com>

        PR gdb/17394
        * linespec.c (struct collect_minsyms): Add new member `symtab'.
        (add_minsym): Handle cases where info.symtab is non-NULL.
        (search_minsyms_for_name): Add new parameter `symtab'.
        Handle limiting searches to a specific symtab.
        (add_matching_symtabs_to_info): Search through minimal symbols
        for language_asm files for which no new symbols are found.

gdb/testsuite/ChangeLog:
2014-12-20  Mihail-Marian Nistor  <mihail.nistor@freescale.com>

        PR gdb/17394
        * gdb.linespec/break-asm-file.c: New file.
        * gdb.linespec/break-asm-file.exp: New file.
        * gdb.linespec/break-asm-file0.s: New file.
        * gdb.linespec/break-asm-file1.s: New file.

9 years agoChange SometimesInlineFunction to "return i * i * 3;"
H.J. Lu [Sat, 20 Dec 2014 16:05:45 +0000 (08:05 -0800)]
Change SometimesInlineFunction to "return i * i * 3;"

The debug_msg test has 2 implementations of SometimesInlineFunction:

int SometimesInlineFunction(int i) { return i; }
int SometimesInlineFunction(int i) { return i * i; }

and One Definition Rule (ODR) violation detection expects they will be
compiled into functions of different sizes.  Hower, on x86, GCC 4.7 and
newer compile them into functions of the same size and ODR violation
detection test fails.  This patch changes

int SometimesInlineFunction(int i) { return i; }

to

int SometimesInlineFunction(int i) { return i * i * 3; }

so that it will be compiled into a function of larger size.

PR gold/14608
* testsuite/debug_msg.cc (SometimesInlineFunction): Changed
to "return i * i * 3;".

9 years agoAutomatic date update in version.in
GDB Administrator [Sat, 20 Dec 2014 00:00:12 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoRework the alignment check for BFD_RELOC_MIPS_18_PCREL_S3.
Matthew Fortune [Tue, 16 Dec 2014 12:39:22 +0000 (12:39 +0000)]
Rework the alignment check for BFD_RELOC_MIPS_18_PCREL_S3.

gas/

* config/tc-mips.c (md_apply_fix): Apply alignment check
to the symbol and offset rather than *valP for
BFD_RELOC_MIPS_18_PCREL_S3.  Also update the error message
for BFD_RELOC_MIPS_19_PCREL_S2.

gas/testsuite/

* gas/mips/r6-64.s: Remove .align directives from LDPC
instructions and add further tests for LDPC.
* gas/mips/r6-64-n32.d: remove the NOPs from LDPC expected
output and update for new tests.
* gas/mips/r6-64-n64.d: Likewise.
* gas/mips/ldpc-unalign.l: New file.
* gas/mips/ldpc-unalign.s: Likewise.
* gas/mips/mips.exp: Run ldpc-unalign test.

9 years agoFix octeon3 tests for targets with default abi != n32
Matthew Fortune [Thu, 18 Dec 2014 22:04:02 +0000 (22:04 +0000)]
Fix octeon3 tests for targets with default abi != n32

gas/testsuite/

* gas/mips/octeon3.d: Switch to use numeric register names.

9 years agoFix all failing FPXX tests for tx39-elf.
Matthew Fortune [Thu, 18 Dec 2014 21:28:07 +0000 (21:28 +0000)]
Fix all failing FPXX tests for tx39-elf.

ld/testsuite/

* ld-mips-elf/attr-gnu-4-00.d: Relax check for ISA extension.
* ld-mips-elf/attr-gnu-4-01.d: Likewise.
* ld-mips-elf/attr-gnu-4-02.d: Likewise.
* ld-mips-elf/attr-gnu-4-03.d: Likewise.
* ld-mips-elf/attr-gnu-4-08.d: Likewise.
* ld-mips-elf/attr-gnu-4-10.d: Likewise.
* ld-mips-elf/attr-gnu-4-11.d: Likewise.
* ld-mips-elf/attr-gnu-4-18.d: Likewise.
* ld-mips-elf/attr-gnu-4-20.d: Likewise.
* ld-mips-elf/attr-gnu-4-22.d: Likewise.
* ld-mips-elf/attr-gnu-4-28.d: Likewise.
* ld-mips-elf/attr-gnu-4-30.d: Likewise.
* ld-mips-elf/attr-gnu-4-33.d: Likewise.
* ld-mips-elf/attr-gnu-4-38.d: Likewise.
* ld-mips-elf/attr-gnu-4-44.d: Likewise.

9 years agoFix undefined weak symbol reloc tests
Matthew Fortune [Thu, 18 Dec 2014 20:08:38 +0000 (20:08 +0000)]
Fix undefined weak symbol reloc tests

ld/testsuite/

* ld-mips-elf/mips-elf.exp: Update undefweak-overflow tests.
* ld-mips-elf/undefweak-overflow-n32.d: Remove.
* ld-mips-elf/undefweak-overflow-n64.d: Likewise.
* ld-mips-elf/undefweak-overflow.s: Set mips64r6, noreorder and
add a label to mark the micromips region.
* ld-mips-elf/undefweak-overflow.d: Update expected output.

9 years agoMIPS SDE OS ABI support
Yao Qi [Fri, 19 Dec 2014 05:13:07 +0000 (13:13 +0800)]
MIPS SDE OS ABI support

This patch is to add SDE OS ABI support in GDB, which has been used in
codesourcery gdb tree for some years.

gdb:

2014-12-19  Maciej W. Rozycki  <macro@codesourcery.com>
    Nigel Stephens  <nigel@mips.com>
    Chris Dearman  <chris@mips.com>
    Luis Machado  <lgustavo@codesourcery.com>

* Makefile.in (ALL_TARGET_OBS): Add mips-sde-tdep.o.
(ALLDEPFILES): Add mips-sde-tdep.c.
* mips-sde-tdep.c: New file containg SDE specific code.
* configure.tgt (mips*-sde*-elf*): Add mips-sde-dep.o to
gdb_target_obs.
* defs.h (gdb_osabi): Add GDB_OSABI_SDE.
* osabi.c (gdb_osabi_names): Add SDE.
* NEWS: Mention the change.

9 years agoAutomatic date update in version.in
GDB Administrator [Fri, 19 Dec 2014 00:00:12 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoSet ppc COMMONPAGESIZE to 64k
Richard Henderson [Thu, 18 Dec 2014 21:40:25 +0000 (15:40 -0600)]
Set ppc COMMONPAGESIZE to 64k

bfd/
* elf32-ppc.c (ELF_COMMONPAGESIZE): Set to 64k.
* elf64-ppc.c (ELF_COMMONPAGESIZE): Likewise.

9 years agoA few comment cleanups
Simon Marchi [Thu, 18 Dec 2014 16:39:44 +0000 (11:39 -0500)]
A few comment cleanups

I stumbled upon a few comments that I think are outdated.

Comment for elfread.c (elf_symfile_init): As far as history goes in git,
I don't see anything related to that.

Comment for elfread.c (elf_symfile_read): References a parameter that was
removed in 1999.

Comment for struct sym_fns/sym_offsets: References a parameter that was
changed in 1999.

gdb/ChangeLog:

* elfread.c (elf_symfile_init): Remove stale comment.
(elf_symfile_read): Same.
* symfile.h (struct sym_fns): Same.

9 years agoMIPS: Provide FPU info and decode FCSR in `info float'
Yao Qi [Thu, 18 Dec 2014 12:47:28 +0000 (20:47 +0800)]
MIPS: Provide FPU info and decode FCSR in `info float'

This patch is the V2.  V1 can be found in
https://sourceware.org/ml/gdb-patches/2012-05/msg00938.html
V2 is to address Joel's comment
<https://sourceware.org/ml/gdb-patches/2012-06/msg00289.html> about
keeping dumping floating point registers.  Additionally, command
'info float' prints bits on nan2008 and abs2008.

------------------------------------------------------------------

 The change below provides a MIPS-specific handler for the:

(gdb) info float

command.  It provides information about the FPU type available (if any),
the FPU register width, and decodes the CP1 Floating Point Control and
Status Register (FCSR):

(gdb) print /x $fsr
$1 = 0xff83ffff
(gdb) info float
fpu type: double-precision
reg size: 32 bits
cond    : 0 1 2 3 4 5 6 7
cause   : inexact uflow oflow div0 inval unimp
mask    : inexact uflow oflow div0 inval
flags   : inexact uflow oflow div0 inval
rounding: -inf
flush   : zero

 One point to note about CP1.FCSR are the non-standard Flush-to-Nearest
and Flush-Override bits.  They are not a part of the MIPS architecture and
take two positions reserved for an implementation-dependent use in the
architecture.  They are present in all the FPU implementations made by
MIPS Technologies since the spin-off from SGI.

 I haven't been able to track down a single other MIPS FPU implementation
that would make any use of these bits and they are required to be
hardwired to zero by the architecture specification if unimplemented.
Therefore I think it makes sense to report them in the current way.

 GDB has no guaranteed access to the CP0 Processor Identification (PRId)
register to validate this feature properly and the ID information stored
in the CP1 Floating Point Implementation Register (FIR) is from my
experience not reliable enough (there's no Company ID available there for
once unlike in CP0.PRId and Processor ID is not guaranteed to be unique).

 As a side note we should probably dump CP1.FIR information as well, as
there's useful stuff indicating some FPU features there.  That's material
for another change however.

gdb/

2014-12-18  Nigel Stephens  <nigel@mips.com>
            Maciej W. Rozycki  <macro@codesourcery.com>

* mips-tdep.c (print_fpu_flags): New function.
(mips_print_float_info): Likewise.
(mips_gdbarch_init): Install mips_print_float_info as gdbarch
print_float_info routine.

gdb/testsuite/

2014-12-18  Nigel Stephens  <nigel@mips.com>
            Maciej W. Rozycki  <macro@codesourcery.com>

* gdb.base/float.exp: Handle the new output from "info float" on
MIPS targets.

9 years agoRefactor gdbarch method print_float_info
Yao Qi [Thu, 18 Dec 2014 12:47:28 +0000 (20:47 +0800)]
Refactor gdbarch method print_float_info

This patch is to change print_float_info gdbarch method for the
following two reasons,

 1. we want to add a default implementation of print_float_info to
    dump the float pointer registers.  It can be reused by backend to
    print something more than float point registers.
 2. we want to simplify the caller of print_float_info,
    infcmd.c:print_float_info.

gdb:

2014-12-18  Yao Qi  <yao@codesourcery.com>

  * gdbarch.sh (print_float_info): Change its type from 'M' to 'm'.
* gdbarch.c: Re-generated.
* gdbarch.h: Likewise.
* infcmd.c (default_print_float_info): New function.
(print_float_info): Removed.  Move code to
default_print_float_info.
(float_info): Adjust to call gdbarch_print_float_info.
* inferior.h (default_print_float_info): Declare it.

9 years agoRemove h8300_print_float_info
Yao Qi [Thu, 18 Dec 2014 12:47:27 +0000 (20:47 +0800)]
Remove h8300_print_float_info

In infcmd.c:print_float_info, if the architecture doesn't have gdbarch
method print_float_info implemented and doesn't float reggroup, GDB
will prints "No floating-point info available for this processor."
The h8300 port doesn't have float registers, and don't need to
implement print_float_info.  This patch is to remove it.

gdb:

2014-12-18  Yao Qi  <yao@codesourcery.com>

* h8300-tdep.c (h8300_print_float_info): Remove.
(h8300_gdbarch_init): Remove the call to
set_gdbarch_print_float_info.

9 years agoinfcmd.c (jump_command): Minor simplification.
Doug Evans [Thu, 18 Dec 2014 09:32:59 +0000 (01:32 -0800)]
infcmd.c (jump_command): Minor simplification.

gdb/ChangeLog:

* infcmd.c (jump_command): Minor simplification.

9 years agolanguage_lookup_primitive_type: Renamed from language_lookup_primitive_type_by_name.
Doug Evans [Thu, 18 Dec 2014 09:10:34 +0000 (01:10 -0800)]
language_lookup_primitive_type: Renamed from language_lookup_primitive_type_by_name.

gdb/ChangeLog:

* language.c (language_lookup_primitive_type): Renamed from
language_lookup_primitive_type_by_name.  All callers updated.

9 years agoFix file name in earlier entry.
Doug Evans [Thu, 18 Dec 2014 08:52:40 +0000 (00:52 -0800)]
Fix file name in earlier entry.

9 years agoDisplay DW_LANG_C11 as (C11).
Mark Wielaard [Thu, 18 Dec 2014 02:35:53 +0000 (13:05 +1030)]
Display DW_LANG_C11 as (C11).

* dwarf.c (read_and_display_attr_value): Change display name of
DW_LANG_C11 from (ANSI C11) to (C11).

9 years agoAutomatic date update in version.in
GDB Administrator [Thu, 18 Dec 2014 00:00:09 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoFix MinGW compilation
Jan Kratochvil [Wed, 17 Dec 2014 19:09:02 +0000 (20:09 +0100)]
Fix MinGW compilation

On Sun, 14 Dec 2014 07:00:28 +0100, Yao Qi wrote:
The build on mingw host is broken because mingw has no mkdtemp.

../../../git/gdb/compile/compile.c: In function 'get_compile_file_tempdir':
../../../git/gdb/compile/compile.c:194:3: error: implicit declaration of function 'mkdtemp' [-Werror=implicit-function-declaration]
   tempdir_name = mkdtemp (tname);
   ^
../../../git/gdb/compile/compile.c:194:16: error: assignment makes pointer from integer without a cast [-Werror]
   tempdir_name = mkdtemp (tname);
                ^
cc1: all warnings being treated as errors

In the end I have managed to test it by Wine myself:

$ wine build_win32/gdb/gdb.exe -q build_win32/gdb/gdb.exe -ex start -ex 'compile code 1' -ex 'set confirm no' -ex quit
[...]
Temporary breakpoint 1, main (argc=1, argv=0x241418) at ../../gdb/gdb.c:29
29        args.argc = argc;
Could not load libcc1.so: Module not found.

Even if it managed to load libcc1.so (it needs host-dependent name libcc1.dll)
then it would soon end up at least on:

default_infcall_mmap:
  error (_("This target does not support inferior memory allocation by mmap."));

As currently there is only:

linux-tdep.c:
  set_gdbarch_infcall_mmap (gdbarch, linux_infcall_mmap);

While one could debug Linux targets from MS-Windows host I find it somehow
overcomplicated now when we are trying to get it running at least on native
Linux x86*.

The 'compile' project needs a larger port effort to run on MS-Windows.

gdb/ChangeLog
2014-12-17  Jan Kratochvil  <jan.kratochvil@redhat.com>

Fix MinGW compilation.
* compile/compile.c (get_compile_file_tempdir): Call error if
!HAVE_MKDTEMP.
* config.in: Regenerate.
* configure: Regenerate.
* configure.ac (AC_CHECK_FUNCS): Add mkdtemp.

gdb/testsuite/ChangeLog
2014-12-17  Jan Kratochvil  <jan.kratochvil@redhat.com>

Fix MinGW compilation.
* gdb.compile/compile-ops.exp: Update untested message if
!skip_compile_feature_tests.
* gdb.compile/compile-setjmp.exp: Likewise.
* gdb.compile/compile-tls.exp: Likewise.
* gdb.compile/compile.exp: Likewise.
* lib/gdb.exp (skip_compile_feature_tests): Check also "Command not
supported on this host".

9 years agovalue_maybe_namespace_elt: Remove redundant call to lookup_static_symbol.
Doug Evans [Wed, 17 Dec 2014 08:30:29 +0000 (00:30 -0800)]
value_maybe_namespace_elt: Remove redundant call to lookup_static_symbol.

Anytime you can remove a symbol lookup that loops over all objfiles
is A Good Thing.

The call to lookup_static_symbol in valops.c:value_maybe_namespace_elt
is redundant with this call in cp_lookup_nested_symbol:

/* Now search all static file-level symbols.  We have to do this
   for things like typedefs in the class.  We do not try to
   guess any imported namespace as even the fully specified
   namespace search is already not C++ compliant and more
   assumptions could make it too magic.  */

size = strlen (parent_name) + 2 + strlen (nested_name) + 1;
concatenated_name = alloca (size);
xsnprintf (concatenated_name, size, "%s::%s",
 parent_name, nested_name);
sym = lookup_static_symbol (concatenated_name, VAR_DOMAIN);
if (sym != NULL)
  return sym;

Earlier in value_maybe_namespace_elt we do this:

  sym = cp_lookup_symbol_namespace (namespace_name, name,
    get_selected_block (0), VAR_DOMAIN);

That sequence goes like:

value_maybe_namespace_elt
-> cp_lookup_symbol_namespace
-> cp_lookup_symbol_in_namespace
-> lookup_symbol_file
-> cp_lookup_nested_symbol
-> lookup_static_symbol

The call was added in commit 41f62f3939b1c69e68ef5652feb44fef90eb85c9.
https://sourceware.org/ml/gdb-patches/2010-06/msg00663.html
With a part 2 here:
https://sourceware.org/ml/gdb-patches/2010-06/msg00664.html

At the time the call to lookup_static_symbol (spelled
lookup_static_symbol_aux at the time) was needed.

However, this patch, 8dea366bbed7986295681c101dcfbd35aeb6dfc4,
https://sourceware.org/ml/gdb-patches/2012-11/msg00387.html
augmented lookup_symbol_file to call cp_lookup_nested_symbol
and introduced the redundancy.

It's kinda buried, so it's totally not unexpected that this happened.

gdb/ChangeLog:

* valops.c (value_maybe_namespace_elt): Remove redundant call to
lookup_static_symbol.

9 years agoNew parameter "debug symbol-lookup".
Doug Evans [Wed, 17 Dec 2014 08:17:27 +0000 (00:17 -0800)]
New parameter "debug symbol-lookup".

gdb/ChangeLog:

New parameter "debug symbol-lookup".
* NEWS: Mention it.
* cp-namespace.c (cp_lookup_symbol_imports_or_template): Add debug
output.
(cp_lookup_symbol_namespace, cp_lookup_symbol_nonlocal): Ditto.
(cp_lookup_nested_symbol): Ditto.
* language.c (language_lookup_primitive_type_by_name): Add debug
output.
* minsyms.c (lookup_minimal_symbol): Add debug output.
* objfiles.c (objfile_debug_name): Moved here, and renamed ...
* symfile-debug.c (debug_objfile_name): ... from here.  All callers
updated.
* objfiles.h (objfile_debug_name): Declare.
* symtab.h (symbol_lookup_debug): Declare.
* symtab.c (symbol_lookup_debug): New global.
(lookup_language_this): Add debug output.
(lookup_symbol_aux, lookup_symbol_in_block): Ditto.
(lookup_symbol_in_objfile_symtabs, lookup_symbol_via_quick_fns): Ditto.
(lookup_symbol_in_static_block, lookup_symbol_in_objfile): Ditto.
(_initialize_symtab): Add new parameter "debug symbol-lookup".

gdb/doc/ChangeLog:

* gdb.texinfo (Debugging Output): Document "debug symbol-lookup".

9 years agoMake buildsym set-up/tear-down more consistent, and document it.
Doug Evans [Wed, 17 Dec 2014 08:00:14 +0000 (00:00 -0800)]
Make buildsym set-up/tear-down more consistent, and document it.

gdb/ChangeLog:

* buildsym.c: Add comments describing how the buildsym machinery
is used by the various file formats.
(really_free_pendings): Enhance function comment.
See pending_macros to NULL.  Simplify resetting pending_addrmap.
Call free_buildsym_compunit.
(free_buildsym_compunit): Set current_subfile to NULL.
(prepare_for_building): New function.
(start_symtab): Call it.  Remove call to set_last_source_file.
(restart_symtab): New arg "cust".  All callers updated.
Simplify, call prepare_for_building.  Re-initialize buildsym_compunit.
(reset_symtab_globals): Enhance function comment.
Set local_symbols, file_symbols, global_symbols to NULL.
Set pending_macros to NULL.  Simplify resetting pending_addrmap.
Call free_buildysym_compunit.
(end_symtab_without_blockvector): Delete.  All callers updated.
(end_symtab_with_blockvector): Remove redundant call to
free_buildsym_compunit.
(augment_type_symtab): Remove arg "cust".  All callers updated.
(buildsym_init): Remove resetting of free_pendings, file_symbols,
global_symbols, pending_blocks, pending_macros.  Instead make
handling consistent with pending_addrmap: Assert value was reset
at end of previous symtab building.  Initialize context_stack here.

9 years agoboards/stabs.exp: New file.
Doug Evans [Wed, 17 Dec 2014 07:10:54 +0000 (23:10 -0800)]
boards/stabs.exp: New file.

gdb/ChangeLog:

* boards/stabs.exp: New file.

9 years agocp_lookup_symbol_via_imports: Renamed from cp_lookup_symbol_imports.
Doug Evans [Wed, 17 Dec 2014 06:19:15 +0000 (22:19 -0800)]
cp_lookup_symbol_via_imports: Renamed from cp_lookup_symbol_imports.

gdb/ChangeLog:

* cp-namespace.c (cp_lookup_symbol_via_imports): Renamed from
cp_lookup_symbol_imports.  All callers updated.

9 years agocp_find_type_baseclass_by_name: Renamed from find_type_baseclass_by_name.
Doug Evans [Wed, 17 Dec 2014 06:13:57 +0000 (22:13 -0800)]
cp_find_type_baseclass_by_name: Renamed from find_type_baseclass_by_name.

gdb/ChangeLog:

* cp-namespace.c (cp_find_type_baseclass_by_name): Renamed from
find_type_baseclass_by_name.  All callers updated.

9 years agosymtab.h (struct symbol_search) <symtab>: Delete, unnecessary.
Doug Evans [Wed, 17 Dec 2014 06:00:13 +0000 (22:00 -0800)]
symtab.h (struct symbol_search) <symtab>: Delete, unnecessary.

gdb/ChangeLog:

* symtab.h (struct symbol_search) <symtab>: Delete.  All uses updated.
* symtab.c (compare_search_syms): Use SYMBOL_SYMTAB accessor.
(print_symbol_info): Delete arg symtab.  All callers updated.
(symtab_symbol_info): Use SYMBOL_SYMTAB accessor.

9 years agoAutomatic date update in version.in
GDB Administrator [Wed, 17 Dec 2014 00:00:08 +0000 (00:00 +0000)]
Automatic date update in version.in

9 years agoFix internal error in gold when -Map and --compress-debug-sections are used
Cary Coutant [Tue, 16 Dec 2014 22:57:17 +0000 (14:57 -0800)]
Fix internal error in gold when -Map and --compress-debug-sections are used
together.

gold/
* mapfile.cc (Mapfile::print_input_section): Print uncompressed sizes.
(Mapfile::print_output_data): Use current_data_size() to avoid
assert for sections requiring postprocessing; if address is not valid,
print 0.
(Mapfile::print_output_section): Use current_data_size(); print note
that addresses and sizes are before compression.