infinite recursion with ada_check_typedef

When trying to resolve an incomplete type, if there is no complete
version of that type available, GDB can go in an infinite loop.

This is because ada_check_typedef makes a recursive call to itself,
in an attempt to make sure that the returned type is never a typedef.
However, when no complete type is found, the current logic causes us
to keep going indefinitely through the same path...

This patch fixes the problem by performing the recursive call to
ada_check_typedef only when a TYPE_CODE_TYPDEF layer needs to be
stripped.

gdb/ChangeLog:

        * ada-lang.c (ada_check_typedef): Call ada_check_typedef only
        if type1 is a typedef.

Add `_finalizer' to the list of known GNAT auxilary routines.

This is a new routine that is being generated by the expander in
the context of controlled types.  This patch adds it to the list of such
routines so that the debugger does not show it when selecting the first
"user" frame (when switching tasks for instance).

gdb/ChangeLog:

        * ada-lang.h (ADA_KNOWN_AUXILIARY_FUNCTION_NAME_PATTERNS): Add
        "_finalizer" to the list.

Remove commented-out code in symfile.c

This patch removes some code that has been `#if 0'-ed since at least
1999 or 2000...

gdb/ChangeLog:

        * symfile.c: Remove all "#if 0"/"#endif" blocks.

symfile.c: Add missing second space after period.

gdb/ChangeLog:

        * symfile.c: Add missing second space after period in various comments.

Minor comment reformatting in ada-typeprint.c

gdb/ChangeLog:

        * ada-typeprint.c (print_array_type): Fix formatting in comment.
        (print_selected_record_field_types): Fix formatting in function
        documentation.

copy/paste typo when registering the `show ravenscar' prefix command

gdb/ChangeLog:

        * ravenscar-thread.c (_initialize_ravenscar): Fix copy/paste typo
        in name of "show ravenscar" prefix command name.

Add missing \n in `show ravenscar task-switching' output

A new-line was missing at the end of the output of the `show ravenscar
task-switching' command.  For instance:

    (gdb) show ravenscar task-switching
    Support for Ravenscar task/thread switching is enabled(gdb)

This patch fixes it.

gdb/ChangeLog:

        * ravenscar-thread.c (show_ravenscar_task_switching_command):
        Add missing '\n' in output.

[Ada/ravenscar] New name for active-thread symbol

The GNAT Ravenscar implementation has recently been enhanced to allow
programs using that runtime to run on multi-cpu systems.  One of the
changes that were made is that the name of the symbol we use to
determine which task is the currently-running task has changed.

This patch enhances the debugger to use the new name, and fallback on
the old name if not found (this is for compatibility with older versions
of the compiler/runtime).

gdb/ChangeLog:

        * ravenscar-thread.c (running_thread_name): Change value.
        (read_thread_id): Remove advance declaration.
        (get_running_thread_msymbol): New function.
        (has_ravenscar_runtime): Use get_running_thread_msymbol to
        compute msym_running_thread.
        (get_running_thread_id): Renames read_thread_id. Slight modifications
        to not take any argument anymore, using get_running_thread_msymbol
        to determine which symbol to use instead.
        (ravenscar_running_thread): Use get_running_thread_id instead of
        read_thread_id.

Move ChangeLog entry to the correct ChangeLog file.

ravenscar/sparc: cannot fetch registers from non-active thread

gdb/ChangeLog:

        * ravenscar-sparc-thread.c (supply_register_at_address):
        Fix passing of buf in call to regcache_raw_supply.

*** empty log message ***

daily update

* doc/as.texinfo: Refer to or include c-alpha.texi for Alpha
options.  Refer to or include c-tic6x.texi for C6X options instead
of duplicating documentation here.
* doc/c-alpha.texi, doc/c-tic6x.texi: Add markup for use in
manpage generation.

gdb/
* dwarf2read.c (dwarf2_read_index): Ignore higher .gdb_index versions.

* Makefile.in (.PRECIOUS): Reference ada-lex.c.

*** empty log message ***

daily update

Add and use elfcomm.c/elfcomm.h.

2010-11-21  H.J. Lu  <hongjiu.lu@intel.com>

PR binutils/12235
* elfcomm.c: New.
* elfcomm.h: Likewise.

* Makefile.am (HFILES): Add elfcomm.h.
(CFILES): Add elfcomm.c.
(ELFLIBS): New.
(readelf_SOURCES): Add $(ELFLIBS).
(elfedit_SOURCES): Likewise.
(objdump_SOURCES): Likewise.
* Makefile.in: Regenerated.

* dwarf.c: Include "elfcomm.h".
(byte_get): Removed.
(byte_get_little_endian): Likewise.
(byte_get_big_endian): Likewise.
(byte_get_signed): Likewise.
(error): Likewise.
(warn): Likewise.

* dwarf.h (dwarf_vma): Defined with HOST_WIDEST_INT.
(dwarf_size_type): Likewise.
(byte_get): Removed.
(byte_get_signed): Likewise.
(byte_get_little_endian): Likewise.
(byte_get_big_endian): Likewise.
(error): Likewise.
(warn): Likewise.

* elfedit.c: Include "elfcomm.h".  Don't include "aout/ar.h".
Call error () instead of non_fatal ().
(streq): Removed.
(strneq): Likewise.
(const_strneq): Likewise.
(non_fatal): Likewise.
(BYTE_GET): Likewise.
(BYTE_PUT): Likewise.
(byte_get): Likewise.
(byte_put): Likewise.
(byte_get_little_endian): Likewise.
(byte_get_big_endian): Likewise.
(byte_put_little_endian): Likewise.
(byte_put_big_endian): Likewise.
(adjust_relative_path): Likewise.
(archive_info): Likewise.
(setup_archive): Likewise.
(release_archive): Likewise.
(setup_nested_archive): Likewise.
(get_archive_member_name): Likewise.
(get_archive_member_name_at): Likewise.
(make_qualified_name): Likewise.

* objdump.c: Include "elfcomm.h".

* readelf.c: Include "elfcomm.h".  Don't include "aout/ar.h".
(BYTE_GET): Removed.
(BYTE_GET_SIGNED): Removed.
(streq): Likewise.
(strneq): Likewise.
(const_strneq): Likewise.
(byte_put): Likewise.
(byte_put_little_endian): Likewise.
(byte_put_big_endian): Likewise.
(adjust_relative_path): Likewise.
(archive_info): Likewise.
(setup_archive): Likewise.
(release_archive): Likewise.
(setup_nested_archive): Likewise.
(get_archive_member_name): Likewise.
(get_archive_member_name_at): Likewise.
(make_qualified_name): Likewise.

Re-indent plugin code.

2010-11-21  H.J. Lu  <hongjiu.lu@intel.com>

* ldfile.c: Re-indent plugin code.
* ldlang.c: Likewise.
* ldmain.c: Likewise.
* plugin.c: Likewise.

merge from gcc

* configure.ac: Only disable a language library if no language needs
it.  Don't let --disable-libgcj uncondtionally disable libffi.
* configure: Rebuild.

Also moved ChangeLog entry to correct file.

*** empty log message ***

daily update

sync toplevel with gcc

PR other/46202: implement install-strip.

/:
PR other/46202
* configure.ac: Fix just-built in-tree STRIP name to be
binutils/strip-new.
* configure: Regenerate.
* Makefile.def (install-strip-gcc, install-strip-binutils)
(install-strip-opcodes, install-strip-ld, install-strip-itcl)
(install-strip-sid): Mirror dependencies on non-strip variants
of these targets on the respective -strip prerequisites.
* Makefile.tpl (install-strip, install-strip-host)
(install-strip-target): New targets.
(install-strip-[+module+], install-strip-target-[+module+]):
New targets.
* Makefile.in: Regenerate.

etc/:
* Makefile.in (install-strip): New target.

libiberty/:
PR other/46202
* Makefile.in (install-strip): New phony target.
(install): Also mark as phony.

Set alignment of common plugin symbol to 1 for For ELF targets.

2010-11-20  H.J. Lu  <hongjiu.lu@intel.com>

PR ld/12246
* plugin.c (asymbol_from_plugin_symbol): Set alignment of
common symbol to 1 for For ELF targets.

Properly report loading plugin error.

2010-11-20  H.J. Lu  <hongjiu.lu@intel.com>

PR ld/12247
* lexsup.c (parse_args): Properly report loading plugin error.

binutils/testsuite/
* lib/binutils-common.exp (regexp_diff): New procedure.
* lib/utils-lib.exp (regexp_diff): Delete.

gas/testsuite/
* lib/gas-defs.exp (regexp_diff): Delete.
(run_dump_test): Remove final "" argument in call to regexp_diff.
(run_list_test): Likewise.
(run_list_test_stdin): Likewise.
* gas/all/gas.exp (test_cond): Likewise.
* gas/elf/elf.exp (run_elf_list_test): Likewise.
* gas/m68k/all.exp: Likewise.
* gas/mep/complex-relocs.exp (regexp_test): Likewise.
* gas/mt/relocs.exp (regexp_test): Likewise.
* gas/symver/symver.exp (run_error_test): Likewise.

ld/testsuite/
* lib/ld-lib.exp (regexp_diff, simple_diff): Delete.

binutils/testsuite/
* lib/binutils-common.exp: New file.
* lib/utils-lib.exp (load_common_lib): New function.  Load
binutils-common.exp.
(is_elf_format): Delete.

gas/testsuite/
* lib/gas-defs.exp (load_common_lib): New function.  Load
binutils-common.exp.
(is_elf_format, is_aout_format, is_pecoff_format): Delete.

ld/testsuite/
* lib/ld-lib.exp (load_common_lib): New function.  Load
binutils-common.exp.
(is_elf_format, is_elf64, is_aout_format, is_pecoff_format): Delete.

gdb/testsuite/
* gdb.dwarf2/dw2-stack-boundary.exp: New file.
* gdb.dwarf2/dw2-stack-boundary.S: New file.

gdb/testsuite/
* gdb.dwarf2/dw2-ada-ffffffff.S: New file.
* gdb.dwarf2/dw2-ada-ffffffff.exp: New file.

*** empty log message ***

* data-directory/Makefile.in (SYSCALLS_INSTALL_DIR):
Remove extraneous '/' after $(DESTDIR).
(PYTHON_INSTALL_DIR): Likewise.

daily update

gdb/
Fix stale memory references.
* elfread.c (elf_symfile_read): Replace xmalloc by bfd_alloc, drop
xfree, new comment.

Merge from gcc top-level.

./:
* configure.ac: Add target-libgo to target_libraries.  Set
and substitute GOC_FOR_BUILD and GOC_FOR_TARGET.
* Makefile.tpl (BUILD_EXPORTS): Add GOC and GOCFLAGS.
(HOST_EXPORTS): Add GOC.
(BASE_TARGET_EXPORTS): Add GOC.
(GOC_FOR_BUILD, GOCFLAGS, GOC_FOR_TARGET): New variables.
(GOCFLAGS_FOR_TARGET): New variable.
(EXTRA_HOST_FLAGS): Add GOC.
(EXTRA_TARGET_FLAGS): Add GOC and GOCFLAGS.
* Makefile.def (target_modules): Add libgo.
(flags_to_pass): Add GOC_FOR_TARGET and GOCFLAGS_FOR_TARGET.
(dependencies): Add dependency from configure-target-libgo to
configure-target-libffi and all-target-libstdc++-v3.  Add
dependencies from all-target-libgo to all-target-libffi.
(languages): Add go.
* configure: Rebuild.
* Makefile.in: Rebuild.

* config-ml.in: Add Go support: treat GOC and GOCFLAGS like other
compiler/flag environment variables.

* configure.ac: Check for lang_requires_boot_languages in
config-lang.in files.
* configure: Rebuild.

PR fortran/32049
* Makefile.def: Add libquadmath; build it with language=fortran.
* configure.ac: Add libquadmath.
* Makefile.tpl: Handle multiple libs in check-[+language+].
* Makefile.in: Regenerate.
* configure: Regenerate.

* configure.ac: Fix spelling in option names.
* configure: Regenerated.

PR bootstrap/39622
* configure.ac (FLAGS_FOR_TARGET): Add include-fixed path.
* configure: Regenerated.

* config/cloog.m4: Add -enable-cloog-backend=(isl|ppl|ppl-legacy) to
define the cloog backend to use. Furthermore, only pass the ppllibs to
the configure checks, if necessary.
* configure: Regenerate.

* config/cloog.m4: Use CLooG predefined macro to check for CLooG PPL.
* configure: regenerate

* config/cloog.m4: Fix typo.  verison -> version.
* configure: Regenerate.

* config/cloog.m4: Pass ppl libraries to the CLooG version check.
* configure: Regenerate.

* configure.ac: Support official CLooG.org versions.
* configure: Regenerate.
* config/cloog.m4: New.

* configure.ac (*-*-darwin*): Use mh-darwin for all Darwin variants.
* configure: Regenerate.

config/:
* cloog.m4 (CLOOG_INIT_FLAGS): Fix spelling in option names.

* bootstrap-lto: Use -flto.

* mh-darwin: Renamed from mh-ppc-darwin.

2010-11-19  Jan Kratochvil  <jan.kratochvil@redhat.com>
    Tom Tromey  <tromey@redhat.com>

* Makefile.in (.y.c): Directly create $@ from YLWRAP.
(.PHONY): Remove for .y outputs.

2010-11-19  Will Drewry  <wad@google.com>
    Tavis Ormandy  <taviso@google.com>
    Jan Kratochvil  <jan.kratochvil@redhat.com>

* dwarf2read.c (decode_locdesc): Enforce location description stack
boundaries.

* plugin.c (is_visible_from_outside): New function.
(get_symbols): Use it.

PR 2606
* configure.in: Disable emulations for PE targets.
* configure: Regenerate.

*** empty log message ***

2010-11-18  Doug Kwan  <dougkwan@google.com>

* expression.cc (BINARY_EXPRESSION): Initialize left_alignment
and right_alignment to be zero.  Store result alignment only if it is
greater than existing alignment.

daily update

* gdb.server/ext-run.exp: Fix intermittent failures.

* arm-tdep.c (arm_in_function_epilogue_p): Fix code when "MOV SP"
instruction is found.

PR gas/12181
* config/obj-elf.c (elf_adjust_symtab) [TE_SOLARIS]: Make sy
weak hidden.

PR binutils/11742
* readelf.c (get_archive_member_name): Formatting.  Properly
handle full size ar_name.

* ld-elf/binutils.exp: Correct x86 gnu target match.
* ld-i386/i386.exp: Likewise.
* ld-ifunc/binutils.exp: Likewise.
* ld-ifunc/ifunc.exp: Likewise.
* ld-discard/discard.exp: Remove unnecessary line continuations.
* ld-elfvers/vers.exp: Likewise.  Simplify linuxaout and linuxoldld
test.
* ld-elfweak/elfweak.exp: Likewise.

*** empty log message ***

daily update

* value.c (value_entirely_optimized_out): Check the
'check_any_valid' field.

start a gitignore

2010-11-17  Tristan Gingold  <gingold@adacore.com>

* vms-lib.c (vms_write_index): Add comments.
Partially revert previous patch.  Free blocks later.

* input-file.c (input_file_open): Check for empty input files.
(input_file_get): Check for end of file before reading any more
data.
(input_file_give_next_buffer): Likewise.

PR ld/12161
* elf32-avr.c (elf32_avr_check_relocs): Delete.
(elf_backend_check_relocs): Delete.

oops - acccidentally omitted from loongson 3a check-in.

* ar.c (print_contents): Don't internationalize strings without words.
* dwarf.c (process_extended_line_op): Likewise.
(process_debug_info): Likwise.
(display_debug_lines_raw): Likewise.
(display_debug_lines_decoded): Likewise.
(display_debug_abbrev): Likewise.
* readelf.c (process_file_header): Likewise.
(GET_OP): Likewise.
(decode_arm_unwind): Likewise.
(process_mips_specific): Likewise.
* resrc.c (run_cmd): Likewise.
(rcparse_warning): Likewise.
* objdump.c (dump_headers): Don't print "Pg".

merge from gcc

* dwarf_reader.cc (Sized_dwarf_line_info::Sized_dwarf_line_info):
Check for ".zdebug_line".

*** empty log message ***

* ld/testsuite/ld-gc/pr11218-2.c: Declare
unresolved_detected_at_runtime_not_at_linktime.

* ld-plugin/plugin.exp: Define printf and puts as main.

daily update

gdb/
* ada-lang.c (modify_general_field): Remove.
(make_array_descriptor): Replace all modify_general_field calls by
modify_field.
* value.c (modify_field): Update comment.  New variable bytesize.
Normalize BITPOS.  Initialize BYTESIZE, use it.

gdb/
* dwarf2read.c (dw2_forget_cached_source_info): Clear the FULL_NAMES
elements after xfree.

* output.h (Output_segment::set_section_addresses): Pass increase_relro
by reference; adjust all callers.
* output.cc (Output_segment::set_section_addresses): Adjust references
to increase_relro. Add padding to *increase_relro when ORDER_RELRO_LAST
list is empty.
(Output_segment::set_offset): Assert if PT_GNU_RELRO segment does not
end at page boundary.

sim: dv-sockser: add a write buffer variant

Rather than having to bang out chunks of data one byte at a time over
the socket interface, add a write variant that accepts an arbitrarily
long buffer.  This speeds things up considerably when we have many
chars to send out at once.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

PR gold/12220
* layout.cc (Layout::choose_output_section): Transform names of
compressed sections even when using a script with a SECTIONS clause.
(Layout::output_section_name): Remove code to transform
compressed debug section names.
* output.cc (Output_section::add_input_section): Use uncompressed
section size when tracking input sections.

Properly demangle a global constructor symbol.

2010-11-16  H.J. Lu  <hongjiu.lu@intel.com>

PR other/42670
PR binutils/11137
* cp-demangle.c (d_make_demangle_mangled_name): New.
(d_demangle_callback): Use it on DCT_GLOBAL_XTORS.

* testsuite/demangle-expected: Updated.

* gdb-add-index.sh: Really remove.

gdb/
Code cleanup.
* dwarf2read.c (alloc_one_comp_unit): Rename prototype to ...
(init_one_comp_unit): ... this one.
(prepare_one_comp_unit): New prototype.
(dw2_require_line_header, process_psymtab_comp_unit): Use
init_one_comp_unit.
(process_psymtab_comp_unit): Use prepare_one_comp_unit.
(load_partial_comp_unit): Remove variable attr.  Use
init_one_comp_unit with xmalloc.  Use prepare_one_comp_unit.
(load_full_comp_unit): Use init_one_comp_unit with xmalloc.  Use
prepare_one_comp_unit.
(read_signatured_type): Remove variable attr.  Use init_one_comp_unit.
Use prepare_one_comp_unit.
(alloc_one_comp_unit): Rename to ...
(init_one_comp_unit): ... here and remove there calloc, new parameter
cu.
(prepare_one_comp_unit): New function.

blackfin: add support for L1 code/data flags

forgot to `cvs add` this file

gdbserver: fix warning in nommu clone

Building gdbserver for nommu targets atm fails with:
linux-low.c: In function 'linux_tracefork_child':
linux-low.c:4151: error: pointer of type 'void *' used in arithmetic

So cast the void* to a char*.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

*** empty log message ***

* windmc.c: ,%s' -> `%s' in a number of strings.

daily update

blackfin: add support for L1 code/data flags

Add new linker options for marking programs to load into L1 memory
at runtime.  This needs new EF flag bits, so declare them.

Signed-off-by: Jie Zhang <jie.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>

* emultempl/pe.em (_list_options): Correct typo.
* emultempl/pep.em (_list_options): Likewise.

Use binutils_assemble_flags for --nocompress-debug-sections.

2010-11-15  H.J. Lu  <hongjiu.lu@intel.com>

* binutils-all/compress.exp: Replace binutils_assemble with
binutils_assemble_flags for --nocompress-debug-sections.

Also expect .zdebug in DWARF debug section name.

binutils/testsuite/

2010-11-15  H.J. Lu  <hongjiu.lu@intel.com>

* binutils-all/compress.exp: Pass --nocompress-debug-sections to
assembler for uncompressed debug sections.

* binutils-all/testranges.d: Also expect .zdebug in section name.

gas/testsuite/

2010-11-15  H.J. Lu  <hongjiu.lu@intel.com>

* gas/elf/dwarf2-3.d: Also expect .zdebug in section name.
* gas/i386/debug1.d: Likewise.
* gas/lns/lns-common-1.d: Likewise.
* gas/lns/lns-duplicate.d: Likewise.

Mark parameters of elf_process_stab as ATTRIBUTE_UNUSED.

2010-11-15  H.J. Lu  <hongjiu.lu@intel.com>

* config/obj-elf.c (elf_process_stab): Mark parameters as
ATTRIBUTE_UNUSED.

revert previous patch

* gdb.base/maint.exp (maint print statistics): Increase timeout for
all targets.  Restore old timeout afterwards.

* config/obj-elf.c (elf_generate_asm_lineno): New function.
(elf_process_stab): New function.
(elf_format_ops): Always use them as generate_asm_lineno,
process_stab members.

PR gas/12198
* gas/config/tc-arm.c (arm_arch_v6m_only): New variable.
(aeabi_set_public_attributes): Ensure we only set the Operating System
Extension when we are on an M-profile core.
* gas/testsuite/gas/arm/pr12198-1.d: New test.
* gas/testsuite/gas/arm/pr12918-1.s: Likewise.
* gas/testsuite/gas/arm/pr12198-2.d: Likewise.
* gas/testsuite/gas/arm/pr12918-2.s: Likewise.
* include/opcode/arm.h (ARM_AEXT_V6M_ONLY): New define.
(ARM_AEXT_V6M): Rewrite in terms of ARM_AEXT_V6M_ONLY.
(ARM_ARCH_V6M_ONLY): New define.

bfd: bfin: drop needless symbol flag handling imported from FRV

The Blackfin bfd merged some FRV code recently, and then removed pieces
that didn't make sense.  In the FRV code, it outputs a "_gp" symbol in
its BFD whereas in the Blackfin code, we don't.  So while on the FRV
side it fiddles with the "flags" variable (sometimes using it for section
flags and sometimes using it for symbol flags), we don't need any of
that.  This lead to BZ 12177 where the Blackfin code is a bit confusing.
So to fix things up, remove more stuff we don't need.  Shouldn't change
the behavior at all.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

*** empty log message ***

daily update

merge from gcc

* arm-tdep.c (arm_in_function_epilogue_p): Fix code to avoid
possible used of uninitialized variable.

*** empty log message ***

daily update

gas/
* config/tc-mips.c (macro_build): Remove gas_assert from 'o' case.
Use a restricted gas_assert for 'i' and 'j'.

gas/testsuite/
* gas/mips/elf-rel28.s, gas/mips/elf-rel28-n32.d,
gas/mips/elf-rel28-n64.d: New test.
* gas/mips/mips.exp: Run it.

merge from gcc

*** empty log message ***

daily update

Properly copy BFD_COMPRESS and BFD_DECOMPRESS to archive element.

2010-11-12  H.J. Lu  <hongjiu.lu@intel.com>

* archive.c (_bfd_get_elt_at_filepos): Copy BFD_COMPRESS and
BFD_DECOMPRESS.
(bfd_openr_next_archived_file): Revert the last change.

gdb/
* rs6000-tdep.c (bfd_uses_spe_extensions): New function.
(rs6000_gdbarch_init): Call it.

gdb/
* rs6000-tdep.c (gdb_print_insn_powerpc): Disassemble e500
instructions if debugging an E500 binary.

gdb/testsuite/
* gdb.stabs/gdb11479.exp: Use runto_main.