2010-07-28  Oleg Nesterov  <oleg@redhat.com>

* remote.c (readchar): Call pop_target in case of SERIAL_ERROR.

* dwarf2read.c (dwarf2_const_value_data): Never sign extend.

2010-07-28  Daniel Jacobowitz  <dan@codesourcery.com>

gdb/
* dwarf2read.c (read_subroutine_type): Improve THIS detection,
handling DW_AT_object_pointer, and workaround GCC PR 43053.

gdb/testsuite/
* gdb.cp/member-ptr.exp, gdb.cp/printmethod.exp,
gdb.dwarf2/member-ptr-forwardref.exp: Adjust.

* Makefile.in (HFILES_NO_SRCDIR): Remove link-warning.h.

Add missing gettext markup.

gdb/ChangeLog:

        * remote.c (remote_download_tracepoint): Add missing gettext markup.
        * tracepoint.c (parse_static_tracepoint_marker_definition): Likewise.

[PATCH] breakpoint_re_set fails while connecting to gdbserver.

This is a problem that I noticed on GNU/Linux, when using both GDB
and GDBserver to debug an Ada program.  To reproduce, use any Ada
program, built with debug info ("gnatmake -g ...").

Then start the program with gdbserver:

        % gdbserver :4444 simple_main

And then insert a breakpoint using the name of an Ada function,
followed by connecting to the target server:

        (gdb) b simple.test_simple
        Breakpoint 1 at 0x401f28: file simple.adb, line 16.
        (gdb) tar rem :4444
        Remote debugging using :4444
        Reading symbols from /lib64/ld-linux-x86-64.so.2...
        Reading symbols from /usr/lib/debug/lib/ld-2.11.1.so...done.
        done.
        Loaded symbols for /lib64/ld-linux-x86-64.so.2
!! ->   Error in re-setting breakpoint 1: Can't find member of namespace, class,
!! ->    struct, or union named "simple.test_simple"
!! ->   Hint: try 'simple.test_simple<TAB> or 'simple.test_simple<ESC-?>
!! ->   (Note leading single quote.)
        0x00007f4db3cf2af0 in _start () from /lib64/ld-linux-x86-64.so.2
        Created trace state variable $trace_timestamp for target's variable 1.

The problem is related to the fact that GDB found debug symbols for
ld.so in /usr/lib/debug.  For debugger configured with a prefix that
is different from /usr, one way to force the problem to reproduce is
to use:

        (gdb) set debug-file-directory /usr/lib/debug

(assuming that debug info has been installed at that location).

The problem is that the wrong language is used to parse the breakpoint
location because it gets changed from under us as a side effect of
some of the code that we do in prepration for re-parsing.  In particular,
breakpoint_re_set_one reads:

      set_language (b->language);
      input_radix = b->input_radix;
      s = b->addr_string;

      save_current_space_and_thread ();
      switch_to_program_space_and_thread (b->pspace);

      marker_spec = b->type == bp_static_tracepoint && is_marker_spec (s);
      [if (marker_spec) decode_tracepoint_spec (...) else decode_line_1]

What happens in our case is that debugging information gets found
for ld.so.  As a result, the current_frame language is C whereas it
would have been unknown if we did not have debugging info. And
save_current_space_and_thread() implicitly causes the current frame
to be selected, which changes the language automatically if the new
language is not uknown and the the language mode is auto.

The fix, until all parsing routines (including decode_line_1) get upgraded
to take a language, is to select the breakpoint language as late as possible.
In this case, we don't need to do that until we actually try to parse
the breakpoint addr_string.

gdb/ChangeLog:

        * breakpoint.c (breakpoint_re_set_one): Move call to set_language
        down, just before the block that parse the breakpoint addr_string.

gdb
PR c++/9946:
* symfile.c (reread_symbols): Clear template_symbols.
* symtab.h (struct symbol) <is_cplus_template_function>: New
field.
(SYMBOL_IS_CPLUS_TEMPLATE_FUNCTION): New macro.
(struct template_symbol): New.
* symtab.c (lookup_symbol_aux_local): Use
cp_lookup_symbol_imports_or_template.
* objfiles.h (struct objfile) <template_symbols>: New field.
* objfiles.c (relocate_one_symbol): New function.
(objfile_relocate1): Use it.  Relocate isolated symbols.
* gdbtypes.h (struct cplus_struct_type) <n_template_arguments,
template_arguments>: New fields.
(TYPE_N_TEMPLATE_ARGUMENTS): New macro.
(TYPE_TEMPLATE_ARGUMENTS): Likewise.
(TYPE_TEMPLATE_ARGUMENT): Likewise.
(lookup_typename): Update.
* gdbtypes.c (lookup_typename): Constify "block" argument.
* dwarf2read.c: Include vec.h.
(symbolp): New typedef.
(read_func_scope): Read template arguments.  Allocate a
template_symbol when needed.
(read_structure_type): Read template arguments.
(new_symbol_full): New function, from new_symbol.  Handle
DW_TAG_template_type_param and DW_TAG_template_value_param.
(new_symbol): Rewrite as wrapper.
* cp-support.h (cp_lookup_symbol_imports_or_template): Declare.
* cp-namespace.c: Include language.h.
(search_symbol_list): New function.
(cp_lookup_symbol_imports_or_template): Likewise.
gdb/testsuite
PR c++/9946:
* gdb.cp/temargs.exp: New file.
* gdb.cp/temargs.cc: New file.

Correct date.

Xfail dw2-compress-2 and x86-64-dw2-compress-2.

2010-07-27  H.J. Lu  <hongjiu.lu@intel.com>

* gas/i386/i386.exp: Xfail dw2-compress-2 and
x86-64-dw2-compress-2.

2010-07-28  Balazs Kezes  <rlblaster@gmail.com>

* tui/tui-win.c (make_visible_with_new_height): Resize and move
the command window to the new size and position.

tabs vs spaces

    * tui/tui-win.c (tui_resize_all): Update the locator's origin's
coordinates.

2010-07-28  Balazs Kezes  <rlblaster@gmail.com>

        * tui/tui-io.c (tui_handle_resize_during_io): Call tui_resize_all
after a detecting a resize.
        * tui/tui-win.c (tui_resize_all): Remove tui_set_win_resized_to
call.

* configure.ac: Check for resize_term.
* configure, config.in: Regenerate.

PR gas/11841
* symbols.c (symbol_clone): Correct typo in previous patch.

PR gas/11841
* symbols.c (symbol_clone): Clear BSF_SECTION_SYM flag.

* ldexp.c (exp_print_tree): Print function-like binary nodes as
functions rather than in-fix operators.  Use fputs and fputc
where appropriate.

* config/tc-ppc.c (md_assemble): Don't attempt to print NUL in
syntax error message.

misordered names in Write After Approval list

This patch moves a couple of write-after-approval names up to keep
the list in alphabetical order.

2010-07-27  Joel Brobecker  <brobecker@adacore.com>

* MAINTAINERS (Write After Approval): Reorder a couple of entries.

Minor (space) reformatting.

* rx-decode.opc (store_flags): Remove, replace with F_* macros.
(rx_decode_opcode): Likewise.
* rx-decode.c: Regenerate.

*** empty log message ***

daily update

gdb/testsuite/
* gdb.base/help.exp (help disassemble): Update the content.

* dwarf2read.c (read_string): Rename to ...
(read_direct_string): ... this.
(skip_one_die, read_attribute_value, dwarf_decode_line_header)
(dwarf_decode_lines, dwarf_decode_macros): Adjust.

gdb/
* linux-nat.c (linux_nat_lp_status_is_event): New function.
(count_events_callback, select_event_lwp_callback)
(cancel_breakpoints_callback, linux_nat_wait_1): Use it.

* elfxx-mips.h: Include "elf/mips.h".
(gprel16_reloc_p): New static inline function.
* elfxx-mips.c (_bfd_mips_elf_check_relocs)
[R_MIPS16_GOT16, R_MIPS_GOT16, R_MIPS_GOT_HI16, R_MIPS_GOT_LO16]:
Use got16_reloc_p.
(_bfd_mips_elf_relocate_section)[bfd_reloc_overflow]: Use
gprel16_reloc_p.
* elf32-mips.c (mips_info_to_howto_rel): Likewise.
* elfn32-mips.c (mips_info_to_howto_rel): Likewise.

Fix up last ChangeLog entry in gas/ and bfd/.

* elf64-mips.c (mips_elf64_howto_table_rela)
[R_MIPS_TLS_DTPMOD64]: Clear partial_inplace.
[R_MIPS_TLS_DTPREL64, R_MIPS_TLS_GD, R_MIPS_TLS_LDM]: Likewise.
[R_MIPS_TLS_DTPREL_HI16, R_MIPS_TLS_DTPREL_LO16]: Likewise.
[R_MIPS_TLS_GOTTPREL, R_MIPS_TLS_TPREL64]: Likewise.
[R_MIPS_TLS_TPREL_HI16, R_MIPS_TLS_TPREL_LO16]: Likewise.
* elfn32-mips.c (elf_mips_howto_table_rela)
[R_MIPS_TLS_DTPMOD32]: Likewise.
[R_MIPS_TLS_DTPREL32, R_MIPS_TLS_GD, R_MIPS_TLS_LDM]: Likewise.
[R_MIPS_TLS_DTPREL_HI16, R_MIPS_TLS_DTPREL_LO16]: Likewise.
[R_MIPS_TLS_GOTTPREL, R_MIPS_TLS_TPREL32]: Likewise.
[R_MIPS_TLS_TPREL_HI16, R_MIPS_TLS_TPREL_LO16]: Likewise.

* config/tc-mips.c (mips16_macro_build): Pass "args" by
reference rather than value.
(macro_build): Update accordingly.

* config/tc-mips.c (mips_ip): Use symbol_temp_new_now to create
a fake label.

gdb/
* ia64-linux-nat.c (ia64_linux_status_is_event): New function.
(_initialize_ia64_linux_nat): Install it.
* linux-nat.c (sigtrap_is_event, linux_nat_status_is_event)
(linux_nat_set_status_is_event): New.
(stop_wait_callback, count_events_callback, select_event_lwp_callback)
cancel_breakpoints_callback, linux_nat_filter_event)
(linux_nat_wait_1): Use linux_nat_status_is_event.
* linux-nat.h (linux_nat_set_status_is_event): New prototype.

gdb/testsuite/
* gdb.threads/ia64-sigill.exp: New file.
* gdb.threads/ia64-sigill.c: New file.

* NEWS: Mention labels, .gdb_index.

* cli/cli-cmds.c (disassemble_command): Add support of disassemble
"start,+length" form of arguments.

gdb/
* top.c (input_from_terminal_p): Return 0 on BATCH_FLAG.
* utils.c (defaulted_query): Do not explicitly check for BATCH_FLAG.
(fputs_maybe_filtered): Do not do filtering also on
! INPUT_FROM_TERMINAL_P.

Fix file name mentioned in this entry:

2010-07-27  Ken Werner  <ken.werner@de.ibm.com>

* dwarf2read.c (dwarf2_read_index): Initialize the types_list and
types_list_elements variables.

* gdb.opt/inline-cmds.c (ATTR): New define.
(func1): Use it.
(func2): Likewise.
(func3): Likewise.
(outer_inline1): Likewise.
(outer_inline2): Likewise.
* gdb.opt/inline-bt.c (ATTR): New define.
(func1): Use it.
(func2): Likewise.
* gdb.opt/inline-locals.c (ATTR): New define.
(func1): Use it.
(func2): Likewise.

* gdb.stabs/gdb11479.c (hack): New function.
(test): Use it.
(test2): Use it.
* gdb.python/py-inferior.c (int8_search_buf, int16_search_buf)
(int32_search_buf, int64_search_buf): No longer static.
(x): Remove.
* gdb.base/relocate.c (hack): New function.

ARI fix (trailing newline in warning message).

        * dwarf2read.c (dw2_find_pc_sect_symtab): Remove trailing newline
        in warning message.

2010-07-27  Phil Muldoon  <pmuldoon@redhat.com>

* python/py-value.c (valpy_call): New Function.

2010-07-27  Phil Muldoon  <pmuldoon@redhat.com>

* gdb.python/py-value.exp (test_inferior_function_call): New function.
* gdb.python/py-value.c (func1): New function.
(func2): Likewise.

2010-07-27  Phil Muldoon  <pmuldoon@redhat.com>

* gdb.texinfo (Values From Inferior): Add value inferior function
call description.

* testsuite/debug_msg.sh: Test mixed weak/strong symbol behavior.
* gold/testsuite/debug_msg.cc: Likewise.
* gold/testsuite/odr_violation1.cc
* gold/testsuite/odr_violation2.cc

* valops.c (dwarf2_read_index): Initialize the types_list and types_list_elements variables.

*** empty log message ***

* dwarf2loc.c (locexpr_describe_location_piece): Also recognize
TLS with DW_OP_const4u or DW_OP_const8u.

* ppc-linux-nat.c (store_vsx_register): Use PTRACE_GETVSXREGS to get
VSX registers contents.

* gdb.asm/xstormy16.inc (gdbasm_startup): Fix beginning of stack so
as not to clash with .data section.

gdb/testsuite/
* gdb.base/code_elim.exp: New file.
* gdb.base/code_elim1.c: New file.
* gdb.base/code_elim2.c: New file.

gdb/
* dwarf2read.c (add_partial_symbol): Do not add a global variable if
its adress is null. Add comment to explain why.
(new_symbol): Ditto.

daily update

*** empty log message ***

gdb/gdbserver/
* server.c (handle_target_event): Use target_signal_to_host for
resume_info.sig initialization.
* target.h (struct thread_resume) <sig>: New comment.

gdb/
* linux-nat.c (linux_nat_do_thread_registers): Convert STOP_SIGNAL to
the host signal first.

daily update

*** empty log message ***

gas/
* config/tc-mips.c (macro)[M_JAL_1, M_JAL_2]: Handle the JALR
delay slot in the noreorder mode with the o32 ABI.

gas/testsuite/
* gas/mips/jal-svr4pic-noreorder.d: New test case.
* gas/mips/mips1@jal-svr4pic-noreorder.d: New test
subarchitecture.
* gas/mips/r3000@jal-svr4pic-noreorder.d: Likewise.
* gas/mips/jal-svr4pic-noreorder.s: Source for the new test
case.
* gas/mips/mips.exp: Run the new test case.

* gas/mips/jal-svr4pic.d: Rename to...
* gas/mips/mips1@jal-svr4pic.d: ... this.
* gas/mips/r3000@jal-svr4pic.d: New test subarchitecture.
* gas/mips/jal-svr4pic.d: New default subarchitecture patterns.
* gas/mips/mips.exp: Run jal-svr4pic with run_dump_test_arches
rather than run_dump_test.

* gas/mips/jal-svr4pic.d: Reformat.  Use --show-raw-insn with
`objdump'.
* gas/mips/jal-svr4pic.s: Reformat.  Fix up trailing zeroes.

* lib/gas-defs.exp (run_dump_test): Handle the "dump" option.

daily update

*** empty log message ***

* dwarf2read.c (struct dwarf2_per_objfile) <n_type_comp_units,
type_comp_units>: New fields.
(dw2_get_cu): New function.
(create_cus_from_index): Remove unused argument.
(create_signatured_type_hash_from_index): New function.
(create_addrmap_from_index): Update.
(dwarf2_read_index): Handle version 2.
(dw2_find_last_source_symtab, dw2_forget_cached_source_info)
(dw2_lookup_symtab, dw2_do_expand_symtabs_matching)
(dw2_print_stats, dw2_expand_all_symtabs)
(dw2_expand_symtabs_with_filename, dw2_find_symbol_file)
(dw2_expand_symtabs_matching, dw2_map_symbol_filenames): Update.
(dwarf2_initialize_objfile): Call create_debug_types_hash_table.
(allocate_signatured_type_hash_table): New function.
(add_signatured_type_cu_to_list): Likewise.
(create_debug_types_hash_table): Use them.  Set type_comp_units.
(read_signatured_type): Ensure section data is available.
(add_address_entry): Don't record empty ranges.
(struct signatured_type_index_data): New.
(write_one_signatured_type): New function.
(write_psymtabs_to_index): Write type CUs.
(save_gdb_index_command): Update comment.
(process_type_comp_unit): Move inititalization of
from_debug_types...
(create_debug_types_hash_table): ... here.

gdb/
* gdb_gcore.sh (tmpfile): Remove the variable, its initialization,
cleanup and generating of gdb script to it.
(gdb): Use redirection from /dev/null.  Use --nx.  Turn off pagination
and terminal size.  Convert $tmpfile to a series of -ex-es.

* symtab.c (basic_lookup_transparent_type): Call pre-expand
hook for STATIC_BLOCK types, too.

Add support for v850E2 and v850E2V3

* dwarf2read.c: Remove unused typedef dwarf2_cu_per_cu_data_ptr
and vector definition.

gdb/
* linux-nat.c (cancel_breakpoint): Remove unused forward declaration.

PR gas/11834
* macro.c (macro_expand): Recover gracefully from named args that
don't match params.

daily update

*** empty log message ***

gdb/
* dwarf2read.c: Include completer.h.
(save_gdb_index_command): Use matching usage command name.
(_initialize_dwarf2_read): New variable c, initialize it by add_cmd.
Set filename_completer for it.

* dwarf2read.c (create_debug_types_hash_table): Set objfile on
type signature's per-CU data.

* archive.c (_bfd_archive_bsd44_construct_extended_name_table):
Correct format specifier.

* ecoff.c: Don't include aout/ranlib.h.
(_bfd_ecoff_slurp_armap): Use correct struct for ardata->symdefs.
(_bfd_ecoff_write_armap): Output ar_date and ar_size using
_bfd_ar_spacepad.

* aoutx.h (some_aout_object_p): Don't set EXEC_P for files with
relocs.

* NEWS: Mention target reported shared libraries support by
default.

2010-07-22  Thomas Schwinge  <thomas@codesourcery.com>

Switch MIPS to 32-bit DWARF format.
* config/tc-mips.h (DWARF2_FORMAT): Only define for [TE_IRIX].
* config/tc-mips.c (mips_dwarf2_format): Likewise.

* readelf.c: Add Moxie support.

* gas/arm/mapdir.s: Don't specify attr/type for .fini_array.
* gas/elf/dwarf2-3.s: Don't specify attr for .init_array.
* gas/elf/dwarf2-3.d: Don't run on h8300.

daily update

*** empty log message ***

* merge.h (Output_merge_string::Merged_string): Remove object, shndx,
string, and length fields.
(Output_merge_string::Merged_strings_list): New type.
(Output_merge_string::Merged_strings_lists): New typedef.
(Output_merge_string): Replace merged_strings_ with
merged_strings_lists_.
* merge.cc (Output_merge_string::do_add_input_section): Allocate new
Merged_strings_list per input object and section.  Don't store pointer
to the string.  Don't store length with each merged string entry.
(Output_merge_string::finalize_merged_data): Loop over list of merged
strings lists.  Recompute length of each merged string.

gdb/
2010-07-21  Pedro Alves  <pedro@codesourcery.com>

PR symtab/11827

Revert:
2010-05-21  Pierre Muller  <muller@ics.u-strasbg.fr>
* dwarf2read.c (process_die): Also allow DW_TAG_const_type
and DW_TAG_volatile_type.
(new_symbol): Likewise.

gdb/testsuite/
2010-07-21  Pedro Alves  <pedro@codesourcery.com>

PR symtab/11827

* gdb.base/printcmds.c (enum some_volatile_enum): New enum.
(some_volatile_enum): New variable.
* gdb.base/printcmds.exp (test_print_enums): New.
<top level>: Call it.

merge from gcc

Corrected pre-overload-resolution function evaluation.

2010-07-21  Sami Wagiaalla  <swagiaal@redhat.com>

* eval.c (evaluate_subexp_standard): Disabled evaluation of C++
function symbols before overload resolution.

2010-07-21  Sami Wagiaalla  <swagiaal@redhat.com>

* gdb.cp/fpointer.cc: New test.
* gdb.cp/fpointer.exp: New test.

* breakpoint.c (bptype_string): New, abstracted out from
print_one_breakpoint_location.
(print_one_breakpoint_location): Adjust.
(breakpoint_1): Adjust the type column width dynamically.

*** empty log message ***

daily update

gdb/
* symfile.c (find_separate_debug_file_by_debuglink): Remove
a gdb_assert call, new comment.

gdb/testsuite/
* gdb.base/solib-nodir.exp: New file.
* lib/gdb.exp (runto): New case for a GDB internal error.

gdb/testsuite/
* gdb.base/charset-malloc.c: New file.
* gdb.base/charset.c (malloc_stub): New prototype.
(main): Call it instead of malloc itself.
* gdb.base/charset.exp: Use only prepare_for_testing.
(binfile): Remove the variable.

Add missing ChangeLog entry.

ld: improve linker script section

The example version script in the manual currently suggests:
extern "C++" { "int f(int, double)"; }

But a C++ function like that doesn't encode the return type into the
mangled  name, so when the linker demangles things, it ends up with
"f(int, double)"  and so it never matches.

The example also lacks a trailing semicolon after the brace, so the
linker always complains about a syntax error in the file.

While the language section documents the possibilities, it isn't clear
as to which is the default language.  So explicitly state that the C
language is the default.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

* gdb/gdbserver/server.c (handle_query): strcpy() the returned string from
paddress() instead of sprintf().

* gdb/gdbserver/utils.c (paddress): Return phex_nz().

include/elf/
* internal.h (ELF_TBSS_SPECIAL): New macro, extracted from..
(ELF_SECTION_SIZE): ..here.
(ELF_SECTION_IN_SEGMENT_1): Add "strict" arg.
(ELF_SECTION_IN_SEGMENT_STRICT): New macro.
bfd/
* elf.c (assign_file_positions_for_load_sections): Check that
zero size sections are allocated in segments too.
(assign_file_positions_for_non_load_sections): Warn if zero
size alloc sections are found here.
(copy_elf_program_header): Don't drop zero size sections from
segment map.
(copy_private_bfd_data): Check for changes in zero size sections.
binutils/
* readelf.c (process_program_headers): Don't ignore all zero size
sections.
ld/testsuite/
* ld-powerpc/tlsexe.r: Update.
* ld-powerpc/tlsexetoc.r: Update.
* ld-powerpc/tlsso.r: Update.
* ld-powerpc/tlstocso.r: Update.

gdb/
* linux-nat.c (linux_handle_extended_wait): Handle case when
event == PTRACE_EVENT_CLONE && stopping && WSTOPSIG (status) != SIGSTOP.

gdb/
Code cleanup.
* linux-nat.c (linux_nat_wait_1): Reset STATUS after calling
linux_nat_wait_1.  Use always LP->STATUS afterwards.

* ld-powerpc/vxworks-relax.s: Add branches to match expected output.
* ld-powerpc/vxworks-relax-2.s: Likewise.
* ld-powerpc/vxworks1-lib.rd: Reorder reloc sections.

2010-07-20  Hui Zhu  <teawater@gmail.com>

* inf-ptrace.c (inf_ptrace_create_inferior): Initialize back_to.
(inf_ptrace_attach): Ditto.

* config/tc-ppc.c (ppc_setup_opcodes): Add all macros for -many.

*** empty log message ***