gcc.git
5 years agoUse v2 map syntax in libgcc-unwind.map if Solaris ld supports it
Rainer Orth [Tue, 18 Sep 2018 07:04:15 +0000 (07:04 +0000)]
Use v2 map syntax in libgcc-unwind.map if Solaris ld supports it

* configure.ac (solaris_ld_v2_maps): New test.
* configure: Regenerate.
* Makefile.in (solaris_ld_v2_maps): New variable.
* config/t-slibgcc-sld (libgcc-unwind.map): Emit v2 mapfile syntax
if supported.

From-SVN: r264382

5 years agoHandle a library implementation of ffs calling __builtin_ffs.
Hans-Peter Nilsson [Tue, 18 Sep 2018 02:42:15 +0000 (02:42 +0000)]
Handle a library implementation of ffs calling __builtin_ffs.

* config/mmix/mmix.c (TARGET_INIT_LIBFUNCS): Override with...
(mmix_init_libfuncs): New function: make __builtin_ffs expand
to __ffsdi2.

From-SVN: r264381

5 years agoDaily bump.
GCC Administrator [Tue, 18 Sep 2018 00:16:45 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264380

5 years agoAdd range_idx param to range_label::get_text
David Malcolm [Mon, 17 Sep 2018 23:32:12 +0000 (23:32 +0000)]
Add range_idx param to range_label::get_text

This patch updates the pure virtual function range_label::get_text
(and its implementations) so that the index of the range is passed
in, allowing for one label instance to be shared by multiple ranges.

gcc/c-family/ChangeLog:
* c-format.c (range_label_for_format_type_mismatch::get_text):
Update for new param.

gcc/c/ChangeLog:
* c-objc-common.c (range_label_for_type_mismatch::get_text):
Update for new param.
* c-typeck.c (maybe_range_label_for_tree_type_mismatch::get_text):
Likewise.

gcc/cp/ChangeLog:
* error.c (range_label_for_type_mismatch::get_text): Update for
new param.

gcc/ChangeLog:
* diagnostic-show-locus.c (class layout_range): Add field
"m_original_idx".
(layout_range::layout_range): Add "original_idx" param and use it
to initialize new field.
(make_range): Use 0 for original_idx.
(layout::layout): Pass in index to calls to
maybe_add_location_range.
(layout::maybe_add_location_range): Add param "original_idx" and
pass it on to layout_range.
(layout::print_any_labels): Pass on range->m_original_idx to
get_text call.
(gcc_rich_location::add_location_if_nearby): Use 0 for
original_idx.
* gcc-rich-location.h (text_range_label::get_text): Update for new
param.
(range_label_for_type_mismatch::get_text): Likewise.

libcpp/ChangeLog:
* include/line-map.h (range_label::get_text): Add param
"range_idx".

From-SVN: r264376

5 years agoi386.c (ix86_emit_i387_log1p): Emit fldln2 earlier.
Uros Bizjak [Mon, 17 Sep 2018 20:33:04 +0000 (22:33 +0200)]
i386.c (ix86_emit_i387_log1p): Emit fldln2 earlier.

* config/i386/i386.c (ix86_emit_i387_log1p): Emit fldln2 earlier.

From-SVN: r264373

5 years agosubstring-locations: add class format_string_diagnostic_t
David Malcolm [Mon, 17 Sep 2018 20:31:01 +0000 (20:31 +0000)]
substring-locations: add class format_string_diagnostic_t

With the addition of ranges in r263564, format_warning_at_substring_n
has 10 arguments.

Reduce the number of args by bundling the shared ones into a
class format_string_diagnostic_t.

gcc/c-family/ChangeLog:
* c-format.c (format_warning_at_char): Update for introduction of
format_string_diagnostic_t.
(format_type_warning): Likewise.

gcc/ChangeLog:
* gimple-ssa-sprintf.c (fmtwarn): Update for introduction of
format_string_diagnostic_t.
(fmtwarn_n): Likewise.
* substring-locations.c
(format_string_diagnostic_t::format_string_diagnostic_t) New ctor.
(format_warning_n_va): Convert to...
(format_string_diagnostic_t::emit_warning_n_va): ...this.
(format_warning_va): Convert to...
(format_string_diagnostic_t::emit_warning_va): ...this.
(format_warning_at_substring): Convert to...
(format_string_diagnostic_t::emit_warning): ...this.
(format_warning_at_substring_n): Convert to...
(format_string_diagnostic_t::emit_warning_n): ...this.
* substring-locations.h (class format_string_diagnostic_t): New
class.
(format_warning_va): Convert to
format_string_diagnostic_t::emit_warning_va.
(format_warning_n_va): Convert to
format_string_diagnostic_t::emit_warning_n_va.
(format_warning_at_substring): Convert to
format_string_diagnostic_t::emit_warning.
(format_warning_at_substring_n): Convert to
format_string_diagnostic_t::emit_warning_n.

From-SVN: r264372

5 years ago[nvptx] Add atomic_fetch* support for SImode arguments.
Cesar Philippidis [Mon, 17 Sep 2018 19:59:19 +0000 (12:59 -0700)]
[nvptx] Add atomic_fetch* support for SImode arguments.

gcc/
* config/nvptx/nvptx.md (atomic_fetch_<logic><mode>): Enable with
SImode args.

gcc/testsuite/
* gcc.target/nvptx/atomic-fetch-2.c: Rename to ...
* gcc.target/nvptx/atomic_fetch-2.c: ... this.
* gcc.target/nvptx/atomic_fetch-3.c: New test.

Co-Authored-By: Bernd Schmidt <bernds_cb1@t-online.de>
From-SVN: r264371

5 years agoi386.md (truncxf<mode>2_i387_noop_unspec): Change operand 0 predicate to nonimmediate...
Uros Bizjak [Mon, 17 Sep 2018 15:00:57 +0000 (17:00 +0200)]
i386.md (truncxf<mode>2_i387_noop_unspec): Change operand 0 predicate to nonimmediate operand.

* config/i386/i386.md (truncxf<mode>2_i387_noop_unspec): Change
operand 0 predicate to nonimmediate operand.
(rint<mode>2_frndint): Remove insn pattern.
(rint<mode>2): Change operand 1 predicate to general_operand.
Extend operand 1 to XFmode and generate rintxf2 insn.
(frndintxf2_<rounding>): Rename from frndint<mode>2_<rounding>.
Do not use X87MODEF mode macro.
(frndintxf2_<rounding>_i387): Rename from
frndint<mode>2_<rounding>_i387.  Do not use X87MODEF mode macro.
(<rounding_insn><mode>2): For non-SSE modes, extend operand 1
to XFmode and generate significandxf3 insn.

From-SVN: r264370

5 years agore PR tree-optimization/87328 (ICE in do_rpo_vn, at tree-ssa-sccvn.c:6566)
Richard Biener [Mon, 17 Sep 2018 13:28:04 +0000 (13:28 +0000)]
re PR tree-optimization/87328 (ICE in do_rpo_vn, at tree-ssa-sccvn.c:6566)

2018-09-17  Richard Biener  <rguenther@suse.de>

PR tree-optimization/87328
* tree-ssa-sccvn.c (process_bb): Remove assertion about not
visiting unexecutable backedges when not iterating.
(do_rpo_vn): Mark all edges not executable even when not
iterating.

* gcc.dg/torture/pr87328.c: New testcase.

From-SVN: r264369

5 years agoAdd -Wabsolute-value
Martin Jambor [Mon, 17 Sep 2018 13:12:12 +0000 (15:12 +0200)]
Add -Wabsolute-value

2018-09-17  Martin Jambor  <mjambor@suse.cz>

gcc/
* doc/invoke.texi (Warning Options): Likewise.

gcc/c-family/
* c.opt (Wabsolute-value): New.

gcc/c/
* c-parser.c: (warn_for_abs): New function.
(c_parser_postfix_expression_after_primary): Call it.

testsuite/
* gcc.dg/warn-abs-1.c: New test.
* gcc.dg/dfp/warn-abs-2.c: Likewise.

From-SVN: r264368

5 years agoms-sysv.exp: Don't pass TEST_ALWAYS_FLAGS to HOSTCXX.
Bernd Edlinger [Mon, 17 Sep 2018 12:41:58 +0000 (12:41 +0000)]
ms-sysv.exp: Don't pass TEST_ALWAYS_FLAGS to HOSTCXX.

2018-09-17  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * gcc.target/x86_64/abi/ms-sysv/ms-sysv.exp: Don't pass
        TEST_ALWAYS_FLAGS to HOSTCXX.

From-SVN: r264367

5 years agore PR fortran/64120 ([F03] Wrong handling of allocatable character string)
Paul Thomas [Mon, 17 Sep 2018 11:22:27 +0000 (11:22 +0000)]
re PR fortran/64120 ([F03] Wrong handling of allocatable character string)

2018-09-17  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/64120
* trans-decl.c (gfc_get_symbol_decl): Flag allocatable, scalar
characters with a variable length expression for deferred init.
(gfc_trans_deferred_vars): Perform the assignment for these
symbols by calling gfc_conv_string_length.

2018-09-17  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/64120
* gfortran.dg/allocatable_scalar_14.f90 : New test.

From-SVN: r264365

5 years agore PR tree-optimization/87301 (ICE: verify_gimple failed (error: statement marked...
Richard Biener [Mon, 17 Sep 2018 10:21:21 +0000 (10:21 +0000)]
re PR tree-optimization/87301 (ICE: verify_gimple failed (error: statement marked for throw, but doesn't))

2018-09-17  Richard Biener  <rguenther@suse.de>

PR tree-optimization/87301
* tree-ssa-sccvn.c (eliminate_dom_walker::eliminate_cleanup): Properly
clean EH info from leftover copy assignments.

* gcc.dg/torture/pr87301.c: New testcase.

From-SVN: r264364

5 years agoFix out-of-bounds in gcov.c (PR gcov-profile/85871).
Martin Liska [Mon, 17 Sep 2018 10:19:02 +0000 (12:19 +0200)]
Fix out-of-bounds in gcov.c (PR gcov-profile/85871).

2018-09-17  Martin Liska  <mliska@suse.cz>

PR gcov-profile/85871
* gcov.c (output_intermediate_file): Fix out of bounds
access.

From-SVN: r264363

5 years ago[ARC] Enable DBNZ for core3 and newer CPUs.
Vineet Gupta [Mon, 17 Sep 2018 08:52:22 +0000 (08:52 +0000)]
[ARC] Enable DBNZ for core3 and newer CPUs.

2018-09-17  Vineet Gupta  <vgupta@synopsys.com>

* config/arc/arc.c: Object attributes for core4 not reflected
correctly.
* config/arc/arc.h: Don't restrict DBNZ to core3 (core4 includes
core3).

From-SVN: r264362

5 years ago[ARC] Update LINK_EH_SPEC linker spec.
Alexey Brodkin [Mon, 17 Sep 2018 08:52:10 +0000 (08:52 +0000)]
[ARC] Update LINK_EH_SPEC linker spec.

With no trailing space in LINK_EH_SPEC linker spec gets generated as:
------------------------>8---------------------
%{!r:--build-id} --eh-frame-hdr%{h*} ...
------------------------>8---------------------

or even worse if hash style is added:
------------------------>8---------------------
%{!r:--build-id} --eh-frame-hdr--hash-style=sysv %{h*} ...
------------------------>8---------------------

Now if that spec is really used by LD then it fails inevitably
saying that it doesn't know option "--eh-frame-hdr--hash-style=sysv".

2018-09-17  Alexey Brodkin  <abrodkin@synopsys.com>

* config/arc/linux.h (LINK_EH_SPEC): Add missing space.

From-SVN: r264361

5 years agogcov: emit hotness colors to easily find hot code.
Martin Liska [Mon, 17 Sep 2018 08:49:09 +0000 (10:49 +0200)]
gcov: emit hotness colors to easily find hot code.

2018-09-17  Martin Liska  <mliska@suse.cz>

* doc/gcov.texi: Document new option --use-hotness-colors.
* gcov.c (struct source_info): Declare new field.
(source_info::source_info): Set default for maximum_count.
(print_usage): Add new -q option.
(process_args): Process it.
(accumulate_line_info): Save src->maximum_count.
(output_line_beginning): Make color line number if
flag_use_hotness_colors is set.
(output_line_details): Pass default argument value.
(output_lines): Pass src->maximum_count.

From-SVN: r264360

5 years agoi386: move alignment defaults to processor_costs.
Martin Liska [Mon, 17 Sep 2018 08:47:38 +0000 (10:47 +0200)]
i386: move alignment defaults to processor_costs.

2018-09-17  Martin Liska  <mliska@suse.cz>

* common/config/i386/i386-common.c (ix86_get_valid_option_values):
Use processor_names table.
* config/i386/i386.c (ix86_default_align): Use
processor_cost_table for alignment values.
(ix86_option_override_internal): Use processor_names.
(ix86_function_specific_print): Likewise.
* config/i386/i386.h (struct processor_costs):
Add alignment values.
(struct ptt): Remove and replace with const char *.
* config/i386/x86-tune-costs.h (struct processor_costs):
Declare default alignments for all costs.

From-SVN: r264359

5 years agore PR fortran/85954 (ICE in make_ssa_name_fn, at tree-ssanames.c:266)
Paul Thomas [Mon, 17 Sep 2018 07:18:17 +0000 (07:18 +0000)]
re PR fortran/85954 (ICE in make_ssa_name_fn, at tree-ssanames.c:266)

2018-09-17  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/85954
* resolve.c (resolve_assoc_var): If the target expression is a
deferred charlen dummy and the associate name shares the
charlen, generate a new one. Make sure that new charlens are in
the namespace list so that they get cleaned up.
* trans-array.c (gfc_is_reallocatable_lhs): Associate names are
not reallocatable.
* trans-decl.c (gfc_get_symbol_decl): Put deferred character
length dummy and result arrays on the deferred initialization
list so that the variable length arrays can be correctly dealt
with.
* trans-expr.c (gfc_conv_string_length): Return if 'expr' is
NULL rather than ICEing..

2018-09-17  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/85954
* gfortran.dg/deferred_character_21.f90 : New test.

From-SVN: r264358

5 years agotree-vrp.c (extract_range_from_unary_expr): Do not special case symbolics or VR_VARYI...
Aldy Hernandez [Mon, 17 Sep 2018 06:07:52 +0000 (06:07 +0000)]
tree-vrp.c (extract_range_from_unary_expr): Do not special case symbolics or VR_VARYING ranges for ABS_EXPR.

* tree-vrp.c (extract_range_from_unary_expr): Do not special case
symbolics or VR_VARYING ranges for ABS_EXPR.
* wide-int-range.cc (wide_int_range_abs): Return positive numbers
when range will wrap.

From-SVN: r264356

5 years agoDaily bump.
GCC Administrator [Mon, 17 Sep 2018 00:16:33 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264355

5 years agofix PR 86484 and PR 84543
Janus Weil [Sun, 16 Sep 2018 19:57:52 +0000 (21:57 +0200)]
fix PR 86484 and PR 84543

2018-09-16  Janus Weil  <janus@gcc.gnu.org>

PR fortran/86484
PR fortran/84543
* match.c (gfc_match_assignment): For a polymorphic assignment,
make sure that the vtab for the rhs type is generated.

2018-09-16  Janus Weil  <janus@gcc.gnu.org>

PR fortran/86484
PR fortran/84543
* gfortran.dg/class_assign_2.f90: New test case.
* gfortran.dg/class_assign_3.f90: New test case.

From-SVN: r264350

5 years agore PR fortran/37802 (Improve wording for matmul bound checking)
Thomas Koenig [Sun, 16 Sep 2018 19:37:44 +0000 (19:37 +0000)]
re PR fortran/37802 (Improve wording for matmul bound checking)

2018-09-16  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/37802
* frontend-passes.c (B_ERROR): New macro for matmul bounds
checking error messages.
(C_ERROR): Likewise.
(inline_matmul_assign): Reorganize bounds checking, use B_ERROR
and C_ERROR macros.

2018-09-16  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/37802
* gfortran.dg/matmul_bounds_13.f90: New test case.
* gfortran.dg/inline_matmul_15.f90:  Adjust test for runtime
error.
* gfortran.dg/matmul_5.f90: Likewise.
* gfortran.dg/matmul_bounds_10.f90: Likewise.
* gfortran.dg/matmul_bounds_11.f90: Likewise.
* gfortran.dg/matmul_bounds_2.f90: Likewise.
* gfortran.dg/matmul_bounds_4.f90: Likewise.
* gfortran.dg/matmul_bounds_5.f90: Likewise.

2018-09-16  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/37802
* m4/matmul_internal.m4: Adjust error messages.
        * generated/matmul_c10.c: Regenerated.
        * generated/matmul_c16.c: Regenerated.
        * generated/matmul_c4.c: Regenerated.
        * generated/matmul_c8.c: Regenerated.
        * generated/matmul_i1.c: Regenerated.
        * generated/matmul_i16.c: Regenerated.
        * generated/matmul_i2.c: Regenerated.
        * generated/matmul_i4.c: Regenerated.
        * generated/matmul_i8.c: Regenerated.
        * generated/matmul_r10.c: Regenerated.
        * generated/matmul_r16.c: Regenerated.
        * generated/matmul_r4.c: Regenerated.
        * generated/matmul_r8.c: Regenerated.
        * generated/matmulavx128_c10.c: Regenerated.
        * generated/matmulavx128_c16.c: Regenerated.
        * generated/matmulavx128_c4.c: Regenerated.
        * generated/matmulavx128_c8.c: Regenerated.
        * generated/matmulavx128_i1.c: Regenerated.
        * generated/matmulavx128_i16.c: Regenerated.
        * generated/matmulavx128_i2.c: Regenerated.
        * generated/matmulavx128_i4.c: Regenerated.
        * generated/matmulavx128_i8.c: Regenerated.
        * generated/matmulavx128_r10.c: Regenerated.
        * generated/matmulavx128_r16.c: Regenerated.
        * generated/matmulavx128_r4.c: Regenerated.
        * generated/matmulavx128_r8.c: Regenerated.

From-SVN: r264349

5 years agoDaily bump.
GCC Administrator [Sun, 16 Sep 2018 00:16:43 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264346

5 years agore PR middle-end/86864 (ICE in commit_one_edge_insertion on switch construct)
Eric Botcazou [Sat, 15 Sep 2018 09:21:09 +0000 (09:21 +0000)]
re PR middle-end/86864 (ICE in commit_one_edge_insertion on switch construct)

PR middle-end/86864
* cfgexpand.c (expand_gimple_basic_block): Be prepared for a BARRIER
before and after a JUMP_TABLE_DATA.

From-SVN: r264342

5 years agoDaily bump.
GCC Administrator [Sat, 15 Sep 2018 00:16:27 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264341

5 years agore PR middle-end/87188 (Function pointer canonicalization optimized away)
John David Anglin [Fri, 14 Sep 2018 23:26:12 +0000 (23:26 +0000)]
re PR middle-end/87188 (Function pointer canonicalization optimized away)

PR middle-end/87188
* dojump.c (do_compare_and_jump): Canonicalize function pointers
when one operand is a function pointer.  Use POINTER_TYPE_P and
FUNC_OR_METHOD_TYPE_P.
* expr.c (do_store_flag): Use POINTER_TYPE_P and FUNC_OR_METHOD_TYPE_P.
* fold-const.c (build_range_check): Likewise.
* match.pd (simple_comparison): Likewise.

From-SVN: r264336

5 years agoFix overeager spelling corrections (PR c/82967)
David Malcolm [Fri, 14 Sep 2018 22:02:58 +0000 (22:02 +0000)]
Fix overeager spelling corrections (PR c/82967)

This patch tunes class best_match's cutoff for rejecting meaningless
spelling suggestions.

Previously, we allowed an edit distance of up to half of the length of the
longer of the goal string and closest candidate strings, rounded down.

With this patch, we now allow only up to a third - with some tuning of
rounding (and for very short strings), to ensure that:
(a) everything that worked before still works (with the removal of a
couple of cases that shouldn't), and that
(b) the new threshold is always at least as conservative as the old
threshold and thus shouldn't offer new nonsensical suggestions (with
the possible exception of cases where transposition has helped; see
r261521 aka Damerau-Levenshtein; PR other/69968).

In particular, all of the bogus suggestions from PR c/82967 are now
no longer offered.

gcc/ChangeLog:
PR c/82967
* spellcheck.c (get_edit_distance_cutoff): New function.
(selftest::test_edit_distance_unit_test_oneway): Rename to...
(selftest::test_get_edit_distance_one_way): ...this.
(selftest::test_get_edit_distance_unit): Rename to...
(selftest::test_get_edit_distance_both_ways): ...this.
(selftest::test_edit_distances): Move tests to this new function,
and test some more pairs of strings.  Update for above renaming.
(selftest::get_old_cutoff): New function.
(selftest::test_get_edit_distance_cutoff): New function.
(selftest::assert_suggested_for): New function.
(ASSERT_SUGGESTED_FOR): New macro.
(selftest::assert_not_suggested_for): New function.
(ASSERT_NOT_SUGGESTED_FOR): New macro.
(selftest::test_suggestions): New function.
(selftest::spellcheck_c_tests): Move test_get_edit_distance_unit
tests to selftest::test_edit_distances and call it.  Add calls to
selftest::test_get_edit_distance_cutoff and
selftest::test_suggestions.
* spellcheck.h (get_edit_distance_cutoff): New function declaration.
(best_match::consider): Replace hard-coded cutoff calculation with
a call to...
(best_match::get_cutoff): New declaration.
(best_match::get_best_meaningful_candidate): Likewise.

gcc/testsuite/ChangeLog:
PR c/82967
* c-c++-common/attributes-1.c: Remove bogus suggestion from
dg-prune-output.
* gcc.dg/diagnostic-token-ranges.c (undeclared_identifier): Remove
bogus suggestion.
* gcc.dg/spellcheck-identifiers-4.c: New test.

From-SVN: r264335

5 years agobuiltins.c (fold_builtin_strlen): Remove TODO comment.
Bernd Edlinger [Fri, 14 Sep 2018 20:36:19 +0000 (20:36 +0000)]
builtins.c (fold_builtin_strlen): Remove TODO comment.

2018-09-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * builtins.c (fold_builtin_strlen): Remove TODO comment.

testsuite:
2018-09-14  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * gcc.dg/warn-strlen-no-nul.c: Add some missing test cases.

From-SVN: r264334

5 years agofix previous commit message
Bernd Edlinger [Fri, 14 Sep 2018 20:14:20 +0000 (20:14 +0000)]
fix previous commit message

From-SVN: r264333

5 years ago2018-09-14 Bernd Edlinger msebor@redhat.com>
Bernd Edlinger [Fri, 14 Sep 2018 19:56:32 +0000 (19:56 +0000)]
2018-09-14  Bernd Edlinger msebor@redhat.com>

        revert:
        2018-07-30  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * tree-ssa-forwprop.c (simplify_builtin_call): Don't create a not NUL
        terminated string literal.

From-SVN: r264332

5 years agocmd/go: correct gccgo buildid file on ARM
Ian Lance Taylor [Fri, 14 Sep 2018 19:42:01 +0000 (19:42 +0000)]
cmd/go: correct gccgo buildid file on ARM

    Bring in https://golang.org/cl/135297 from the gc repository to fix a
    GCC bug report.

    Original CL description:

        The GNU assembler for ARM treats @ as a comment character, so section
        types must be written using % instead.

        Fixes https://gcc.gnu.org/PR87260.

    Reviewed-on: https://go-review.googlesource.com/135360

From-SVN: r264330

5 years agobuiltins.c (unterminated_array): Handle ARRAY_REF.
Martin Sebor [Fri, 14 Sep 2018 18:35:26 +0000 (18:35 +0000)]
builtins.c (unterminated_array): Handle ARRAY_REF.

* builtins.c (unterminated_array): Handle ARRAY_REF.
(expand_builtin_stpcpy_1): Detect unterminated char arrays.
* builtins.h (unterminated_array): Declare extern.
* gimple-fold.c (gimple_fold_builtin_stpcpy): Detect unterminated
  arrays.
(gimple_fold_builtin_sprintf): Propagate NO_WARNING to transformed
calls.

* gcc.dg/warn-stpcpy-no-nul.c: New test.

From-SVN: r264328

5 years agobuiltins.c (unterminated_array): New.
Martin Sebor [Fri, 14 Sep 2018 18:23:58 +0000 (18:23 +0000)]
builtins.c (unterminated_array): New.

* builtins.c (unterminated_array): New.
(expand_builtin_strcpy): Adjust.
(expand_builtin_strcpy_args): Detect unterminated arrays.
* gimple-fold.c (get_maxval_strlen): Add argument.  Detect
unterminated arrays.
* gimple-fold.h (get_maxval_strlen): Add argument.
(gimple_fold_builtin_strcpy): Detec unterminated arrays.

* gimple-fold.c (get_range_strlen): Add argument.
(get_maxval_strlen): Adjust.
* gimple-fold.h (get_range_strlen): Add argument.

* gcc.dg/warn-strcpy-no-nul.c: New test.

Co-Authored-By: Jeff Law <law@redhat.com>
From-SVN: r264327

5 years ago* config/i386/movdirintrin.h: Fix copyright year.
Wei Xiao [Fri, 14 Sep 2018 17:03:09 +0000 (17:03 +0000)]
* config/i386/movdirintrin.h: Fix copyright year.

From-SVN: r264326

5 years agocompiler: don't use address of temporary for deferred delete
Ian Lance Taylor [Fri, 14 Sep 2018 16:55:41 +0000 (16:55 +0000)]
compiler: don't use address of temporary for deferred delete

    This CL corrects the handling of a deferred delete in a loop, to not
    use a temporary whose value will, at deferred execution time, wind up
    being the last value in the loop.

    The test for this is TestDeferDeleteSlow in the 1.11 runtime package.

    Reviewed-on: https://go-review.googlesource.com/135358

From-SVN: r264325

5 years agoc++/61941 - Mis-parsing of warn_unused_result function with ref-qualifiers
Martin Sebor [Fri, 14 Sep 2018 16:41:37 +0000 (16:41 +0000)]
c++/61941 - Mis-parsing of warn_unused_result function with ref-qualifiers

gcc/testsuite/ChangeLog:
* g++.dg/pr61941.C: New test.

From-SVN: r264324

5 years ago[AArch64][committed] Fix gcc.target/aarch64/combine_bfi_1.c
Kyrylo Tkachov [Fri, 14 Sep 2018 16:05:42 +0000 (16:05 +0000)]
[AArch64][committed] Fix gcc.target/aarch64/combine_bfi_1.c

This test started failing because some of the functions in the combine dump that it scans uses a different pattern to match the same instruction: insv_regsi rather than aarch64_bfi.
The code generation is still the same.
The patch changes the scan to look for the actual instruction we want in the assembly.

This fixes the test.
Committing to trunk as obvious.

     * gcc.target/aarch64/combine_bfi_1.c: Scan for bfi instruction
     rather than pattern name in combine dump.

From-SVN: r264323

5 years agoreg-stack.c: Include regs.h.
Uros Bizjak [Fri, 14 Sep 2018 15:52:04 +0000 (17:52 +0200)]
reg-stack.c: Include regs.h.

* reg-stack.c: Include regs.h.
(replace_reg): Assert that mode is MODE_FLOAT or MODE_COMPLEX_FLOAT.
(emit_pop_insn): Default pop insn mode to the reg_raw_mode of
FIRST_STACK_REG, not DFmode.
(emit_swap_insn): Default swap insn mode to the reg_raw_mode of
FIRST_STACK_REG, not XFmode.  Explicitly construct swap RTX.
(change stack): Default register mode to the reg_raw_mode of
FIRST_STACK_REG, not DFmode.
* config/i386/i386.md (*swap<mode>): Remove insn pattern.
(*swapxf): Rename from swapxf.

From-SVN: r264319

5 years agoemmintrin.h: Add _MM_SHUFFLE2.
Carl Love [Fri, 14 Sep 2018 15:36:52 +0000 (15:36 +0000)]
emmintrin.h: Add _MM_SHUFFLE2.

gcc/ChangeLog:

2018-09-14  Carl Love  <cel@us.ibm.com>

* config/rs6000/emmintrin.h: Add _MM_SHUFFLE2.
* config/rs6000/xmmintrin.h: Add _MM_SHUFFLE.

From-SVN: r264317

5 years agors6000: Add another Z to go with Y (PR87224)
Segher Boessenkool [Fri, 14 Sep 2018 15:24:47 +0000 (17:24 +0200)]
rs6000: Add another Z to go with Y (PR87224)

This is another case where we ICE because Y does not allow reg+reg, we
need Z for that.

PR target/87224
* config/rs6000/rs6000.md (*mov<mode>_hardfloat64): Add Z to the Y
alternatives.

From-SVN: r264316

5 years ago[Aarch64] Added pattern to match zero extended bfxil
Sam Tebbs [Fri, 14 Sep 2018 15:16:17 +0000 (15:16 +0000)]
[Aarch64] Added pattern to match zero extended bfxil

gcc/
2018-07-31  Sam Tebbs  <sam.tebbs@arm.com>

PR target/85628
* config/aarch64/aarch64.md (*aarch64_bfxilsi_uxtw): Define.

gcc/testsuite
2018-07-31  Sam Tebbs  <sam.tebbs@arm.com>

PR target/85628
* gcc.target/aarch64/combine_bfxil.c (combine_zero_extended_int, foo6):
New functions.

From-SVN: r264315

5 years agoFix --enable-gather-detailed-mem-stats.
Jason Merrill [Fri, 14 Sep 2018 13:26:27 +0000 (09:26 -0400)]
Fix --enable-gather-detailed-mem-stats.

* hash-table.c (hash_table_usage): Change from variable to function.
* hash-table.h: Adjust.
* Makefile.in: Add missing dependencies on hash-table.h.

From-SVN: r264313

5 years ago[tree-ssa-mathopts] PR tree-optimization/87259: Call execute_cse_reciprocals_1 before...
Kyrylo Tkachov [Fri, 14 Sep 2018 13:13:14 +0000 (13:13 +0000)]
[tree-ssa-mathopts] PR tree-optimization/87259: Call execute_cse_reciprocals_1 before trying optimize_recip_sqrt

PR tree-optimization/87259
PR lto/87283
(pass_cse_reciprocals::execute): Run optimize_recip_sqrt after
execute_cse_reciprocals_1 has tried transforming.

PR tree-optimization/87259
* gcc.dg/pr87259.c: New test.

From-SVN: r264312

5 years agotree-vrp.c (extract_range_from_binary_expr_1): Normalize VR_VARYING for PLUS/MINUS_EXPR.
Aldy Hernandez [Fri, 14 Sep 2018 10:46:35 +0000 (10:46 +0000)]
tree-vrp.c (extract_range_from_binary_expr_1): Normalize VR_VARYING for PLUS/MINUS_EXPR.

* tree-vrp.c (extract_range_from_binary_expr_1): Normalize
VR_VARYING for PLUS/MINUS_EXPR.

From-SVN: r264307

5 years agopatching file gcc/config/s390/s390-passes.def
Ilya Leoshkevich [Fri, 14 Sep 2018 10:15:46 +0000 (10:15 +0000)]
patching file gcc/config/s390/s390-passes.def
S/390: Improve s390-passes.def formatting

The result looks nicer in the generated pass-instances.def.

gcc/ChangeLog:

2018-09-14  Ilya Leoshkevich  <iii@linux.ibm.com>

* config/s390/s390-passes.def (INSERT_PASS_BEFORE): Improve
formatting.

From-SVN: r264306

5 years ago[libgfortran] Fix uninitialized variable use in fallback_access
Kyrylo Tkachov [Fri, 14 Sep 2018 09:22:01 +0000 (09:22 +0000)]
[libgfortran] Fix uninitialized variable use in fallback_access

I've been tracking down a bug in a Fortran program on a newlib target and it boils down to fallback_access doing something bad.
The unconditional calls to close cause havoc when open doesn't get called due to the short-circuiting in the if-statement above
because the fd is uninitialised. In my environment GCC ends up calling close on file descriptor 0, thus trying to close stdin.

This patch tightens up the calling so that close is called only when the corresponding open call succeeded.
With this my runtime failure disappears.

Bootstrapped and tested on aarch64-none-linux-gnu.
Though that doesn't exercise this call I hope it's an obviously correct change.

* io/unix.c (fallback_access): Avoid calling close on
uninitialized file descriptor.

From-SVN: r264305

5 years agore PR middle-end/63155 (memory hog)
Richard Biener [Fri, 14 Sep 2018 06:59:21 +0000 (06:59 +0000)]
re PR middle-end/63155 (memory hog)

2018-09-14  Richard Biener  <rguenther@suse.de>

PR middle-end/63155
* tree-ssa-coalesce.c (ssa_conflicts_merge): Remove conflict
bits for the merged partition.

From-SVN: r264304

5 years agobuiltins.h (c_srlen): Add argument.
Martin Sebor [Fri, 14 Sep 2018 03:34:19 +0000 (03:34 +0000)]
builtins.h (c_srlen): Add argument.

* builtins.h (c_srlen): Add argument.
* builtins.c (warn_string_no_nul): New function.
(c_strlen): Add argument and use it.  Update recursive calls.
Pass DECL argument to string_constant to get info on non
terminated strings.  Update *NONSTR as needed.
(fold_builtin_strlen): Add argument to calls to c_strlen.
Warn for unterminated arrays.
(warn_string_no_null): Add prototype.
* expr.c (string_constant): Update arguments.  Update recursive
calls appropriately.  Detect missing NUL terminator and outermost
declaration its missing in.
Improve checks for arrays with nonzero lower bound or elements
that are not a single byte.  Simplify offset computation.
Simplify checks for non-NUL terminated strings.
* gimple-fold.c (get_range_strlen): Add argument to c_strlen call.
* gimple-ssa-sprintf.c (get_string_length): Remove unnecessary code.

* gcc.dg/warn-strlen-no-nul.c: New test.

Co-Authored-By: Bernd Edlinger <bernd.edlinger@hotmail.de>
Co-Authored-By: Jeff Law <law@redhat.com>
From-SVN: r264302

5 years agobuiltins.c (c_strlen): Handle not zero terminated STRING_CSTs correctly.
Bernd Edlinger [Fri, 14 Sep 2018 01:49:38 +0000 (01:49 +0000)]
builtins.c (c_strlen): Handle not zero terminated STRING_CSTs correctly.

* builtins.c (c_strlen): Handle not zero terminated STRING_CSTs
correctly.
* fold-const.c (c_getstr): Fix function comment.  Remove unused third
argument.  Fix range checks.
* fold-const.h (c_getstr): Adjust protoype.
* gimple-fold.c (gimple_fold_builtin_memory_op): Avoid folding when
string is constant but contains no NUL byte.

From-SVN: r264301

5 years agoexpr.c (string_constant): Adjust function comment.
Bernd Edlinger [Fri, 14 Sep 2018 01:42:56 +0000 (01:42 +0000)]
expr.c (string_constant): Adjust function comment.

* expr.c (string_constant): Adjust function comment.
Remove bogus check for zero termination.

From-SVN: r264300

5 years agoDaily bump.
GCC Administrator [Fri, 14 Sep 2018 00:16:45 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264299

5 years agocompiler, runtime: call gcWriteBarrier instead of writebarrierptr
Ian Lance Taylor [Thu, 13 Sep 2018 22:25:58 +0000 (22:25 +0000)]
compiler, runtime: call gcWriteBarrier instead of writebarrierptr

    In 1.11 writebarrierptr is going away, so change the compiler to call
    gcWriteBarrier instead.  We weren't using gcWriteBarrier before;
    adjust the implementation to use the putFast method.

    This revealed a problem in the kickoff function.  When using cgo,
    kickoff can be called on the g0 of an m allocated by newExtraM.  In
    that case the m will generally have a p, but systemstack may be called
    by wbBufFlush as part of flushing the write barrier buffer.  At that
    point the buffer is full, so we can not do a write barrier.  So adjust
    the existing code in kickoff so that in the case where we are g0,
    don't do any write barrier at all.

    Reviewed-on: https://go-review.googlesource.com/131395

From-SVN: r264295

5 years agoruntime: correct counters in sweep
Ian Lance Taylor [Thu, 13 Sep 2018 22:06:16 +0000 (22:06 +0000)]
runtime: correct counters in sweep

    In the sweep code we can sometimes see incorrect counts when
    conservative stack scanning causes us to grey an object that we
    earlier decided could be freed.  We already ignored this check, but
    adjust this case to maintain correct span counts when it happens.
    This gives us slightly more correct numbers in MemStats, and helps
    avoid a rare failure in TestReadMemStats.

    Also fix the free index, and cope with finding a full span when
    allocating a new one.

    Reviewed-on: https://go-review.googlesource.com/134216

From-SVN: r264294

5 years ago* fold-const.c (c_getstr): Clamp STRING_LENGTH to STRING_SIZE.
Bernd Edlinger [Thu, 13 Sep 2018 22:00:56 +0000 (22:00 +0000)]
* fold-const.c (c_getstr): Clamp STRING_LENGTH to STRING_SIZE.

From-SVN: r264293

5 years agovarasm.c (compare_constant): Compare type size of STRING_CSTs.
Bernd Edlinger [Thu, 13 Sep 2018 21:43:16 +0000 (21:43 +0000)]
varasm.c (compare_constant): Compare type size of STRING_CSTs.

* varasm.c (compare_constant): Compare type size of STRING_CSTs.
(get_constant_size): Don't make STRING_CSTs larger than they are.
(check_string_literal): New check function for STRING_CSTs.
(output_constant): Use it.

From-SVN: r264292

5 years ago* c-typeck.c (digest_init): Shorten overlength strings.
Bernd Edlinger [Thu, 13 Sep 2018 21:40:38 +0000 (21:40 +0000)]
* c-typeck.c (digest_init): Shorten overlength strings.

From-SVN: r264291

5 years agocompiler, runtime: open code select
Ian Lance Taylor [Thu, 13 Sep 2018 21:32:24 +0000 (21:32 +0000)]
compiler, runtime: open code select

    This is the gofrontend version of https://golang.org/cl/37933,
    https://golang.org/cl/37934, and https://golang.org/cl/37935.
    Open code the initialization of select cases.

    This is a step toward updating libgo to the 1.11 release.

    Reviewed-on: https://go-review.googlesource.com/135000

From-SVN: r264290

5 years agoFix the previous ChangeLog
Bernd Edlinger [Thu, 13 Sep 2018 18:56:49 +0000 (18:56 +0000)]
Fix the previous ChangeLog

From-SVN: r264287

5 years agotypeck2.c (digest_init_r): Fix overlength strings.
Bernd Edlinger [Thu, 13 Sep 2018 18:43:44 +0000 (18:43 +0000)]
typeck2.c (digest_init_r): Fix overlength strings.

* typeck2.c (digest_init_r): Fix overlength strings.
* vtable-class-hierarchy.c (build_key_buffer_arg): Make string literal
NUL terminated.

From-SVN: r264286

5 years agotrans-array.c (gfc_conv_array_initializer): Remove excess precision from overlength...
Bernd Edlinger [Thu, 13 Sep 2018 18:42:16 +0000 (18:42 +0000)]
trans-array.c (gfc_conv_array_initializer): Remove excess precision from overlength string initializers.

* trans-array.c (gfc_conv_array_initializer): Remove excess precision
from overlength string initializers.

From-SVN: r264285

5 years agocompiler: implement //go:nowritebarrierrec
Ian Lance Taylor [Thu, 13 Sep 2018 17:49:07 +0000 (17:49 +0000)]
compiler: implement //go:nowritebarrierrec

    Reviewed-on: https://go-review.googlesource.com/134228

From-SVN: r264283

5 years agoruntime: avoid write barriers with traceback info
Ian Lance Taylor [Thu, 13 Sep 2018 17:30:00 +0000 (17:30 +0000)]
runtime: avoid write barriers with traceback info

    Unlike the gc runtime, libgo stores traceback information in location
    structs, which contain strings.  Therefore, copying location structs
    around appears to require write barriers, although in fact write
    barriers are never important because the strings are never allocated
    in Go memory.  They come from libbacktrace.

    Some of the generated write barriers come at times when write barriers
    are not permitted.  For example, exitsyscall, marked
    nowritebarrierrec, calls exitsyscallfast which calls traceGoSysExit
    which calls traceEvent which calls traceStackID which calls
    trace.stackTab.put which copies location values into memory allocated
    by tab.newStack.  This write barrier can be invoked when there is no
    p, causing a crash.

    This change fixes the problem by ensuring that location values are
    copied around in the tracing code with no write barriers.

    This was found by fixing the compiler to fully implement
    //go:nowritebarrierrec; CL to follow.

    Reviewed-on: https://go-review.googlesource.com/134226

From-SVN: r264282

5 years agore PR target/86812 (visium port needs updating for CVE-2017-5753)
Eric Botcazou [Thu, 13 Sep 2018 17:27:00 +0000 (17:27 +0000)]
re PR target/86812 (visium port needs updating for CVE-2017-5753)

PR target/86812
* config/visium/visium.c (TARGET_HAVE_SPECULATION_SAFE_VALUE): Define.

From-SVN: r264281

5 years ago* Makefile.rtl (arm% linux-gnueabi%): Always set EH_MECHANISM to -arm.
Eric Botcazou [Thu, 13 Sep 2018 17:13:05 +0000 (17:13 +0000)]
* Makefile.rtl (arm% linux-gnueabi%): Always set EH_MECHANISM to -arm.

From-SVN: r264278

5 years agore PR ada/81103 (gcc/ada/terminals.c: please remove unused termio.h)
Eric Botcazou [Thu, 13 Sep 2018 17:05:40 +0000 (17:05 +0000)]
re PR ada/81103 (gcc/ada/terminals.c: please remove unused termio.h)

PR ada/81103
* terminals.c: Do not include termio.h.

From-SVN: r264277

5 years agolibgo: build roots index to speed up bulkBarrierPreWrite
Ian Lance Taylor [Thu, 13 Sep 2018 16:44:43 +0000 (16:44 +0000)]
libgo: build roots index to speed up bulkBarrierPreWrite

    To reduce the amount of time spent in write barrier processing
    (specifically runtime.bulkBarrierPreWrite), add support for building a
    'GC roots index', basically a sorted list of all roots, so as to
    allow more efficient lookups of gcdata structures for globals. The
    previous implementation worked on the raw (unsorted) roots list
    itself, which did not scale well.

    Reviewed-on: https://go-review.googlesource.com/132595

From-SVN: r264276

5 years agoAdd self to maintainers list.
Matthew Malcomson [Thu, 13 Sep 2018 16:11:29 +0000 (16:11 +0000)]
Add self to maintainers list.

2018-09-13  Matthew Malcomson  <matthew.malcomson@arm.com>

* MAINTAINERS (Write After Approval): Add self.

From-SVN: r264275

5 years agoMAINTAINERS (write_after_approval): Add myself.
Sam Tebbs [Thu, 13 Sep 2018 16:03:05 +0000 (16:03 +0000)]
MAINTAINERS (write_after_approval): Add myself.

2018-09-13  Sam Tebbs  <sam.tebbs@arm.com>

* MAINTAINERS (write_after_approval): Add myself.

From-SVN: r264274

5 years agore PR tree-optimization/87263 (ICE on valid code at -O1: verify_ssa failed)
Richard Biener [Thu, 13 Sep 2018 14:15:41 +0000 (14:15 +0000)]
re PR tree-optimization/87263 (ICE on valid code at -O1: verify_ssa failed)

2018-09-13  Richard Biener  <rguenther@suse.de>

PR tree-optimization/87263
* tree-ssa-sccvn.c (visit_phi): Revert some earlier changes.
(struct unwind_state): Add max_rpo field.
(do_rpo_vn): Allow up-to-date loop state to be used when not iterating.
Compute max_rpo, the max RPO number a block can be backwards reached
from.  Re-write non-iterating mode to a RPO ordered worklist approach,
separating it from the iterating mode.

* gcc.dg/torture/pr87263.c: New testcase.
* gcc.dg/torture/ssa-fre-2.c: Likewise.
* gcc.dg/torture/ssa-fre-3.c: Likewise.
* gcc.dg/torture/ssa-fre-4.c: Likewise.

From-SVN: r264273

5 years agoLimit workaround for Clang bug to __clang_major__ <= 7
Jonathan Wakely [Thu, 13 Sep 2018 13:47:14 +0000 (14:47 +0100)]
Limit workaround for Clang bug to __clang_major__ <= 7

The bug https://bugs.llvm.org/show_bug.cgi?id=33222 is now fixed on
Clang trunk, so the workaround won't be needed for Clang 8.0 and later.

* include/std/variant (variant) [__clang__]: Limit workaround to
Clang 7 and older.

From-SVN: r264271

5 years agoSchedule by INSN_COST in case of tie
Vlad Lazar [Thu, 13 Sep 2018 13:43:48 +0000 (13:43 +0000)]
Schedule by INSN_COST in case of tie

2018-09-13  Vlad Lazar  <vlad.lazar@arm.com>

* haifa-sched.c (rank_for_schedule): Schedule by INSN_COST.
(rfs_decision): New scheduling decision.

From-SVN: r264270

5 years agore PR bootstrap/87134 (SEGV in cc1 caused by r263875)
Richard Biener [Thu, 13 Sep 2018 11:31:58 +0000 (11:31 +0000)]
re PR bootstrap/87134 (SEGV in cc1 caused by r263875)

2018-09-13  Richard Biener  <rguenther@suse.de>

PR bootstrap/87134
* tree-ssa-sccvn.c (vn_nary_op_insert_into): Fix assert.
(vn_nary_op_insert_pieces_predicated): Do not write useless
valid_dominated_by_p entry outside of the allocated storage.

From-SVN: r264268

5 years ago[debug] DWARF: add DW_AT_count to zero-length arrays
Omar Sandoval [Thu, 13 Sep 2018 10:27:12 +0000 (10:27 +0000)]
[debug] DWARF: add DW_AT_count to zero-length arrays

2018-09-13  Omar Sandoval  <osandov@osandov.com>
    Tom de Vries  <tdevries@suse.de>

PR debug/86985
* dwarf2out.c (is_c): New function.
(add_subscript_info): Add DW_AT_count of 0 for C zero-length arrays.

* gcc.dg/guality/zero-length-array.c: New test.

Co-Authored-By: Tom de Vries <tdevries@suse.de>
From-SVN: r264267

5 years ago[Aarch64] Exploiting BFXIL when OR-ing two AND-operations with appropriate bitmasks
Sam Tebbs [Thu, 13 Sep 2018 09:46:55 +0000 (09:46 +0000)]
[Aarch64] Exploiting BFXIL when OR-ing two AND-operations with appropriate bitmasks

2018-09-13  Sam Tebbs  <sam.tebbs@arm.com>

PR target/85628
* config/aarch64/aarch64.md (*aarch64_bfxil):
Define.
* config/aarch64/constraints.md (Ulc): Define.
* config/aarch64/aarch64-protos.h (aarch64_high_bits_all_ones_p):
Define.
* config/aarch64/aarch64.c (aarch64_high_bits_all_ones_p):
New function.

* gcc.target/aarch64/combine_bfxil.c: New file.
* gcc.target/aarch64/combine_bfxil_2.c: New file.

From-SVN: r264264

5 years ago[AArch64] Add support for TARGET_COMPUTE_FRAME_LAYOUT
Vlad Lazar [Thu, 13 Sep 2018 09:36:58 +0000 (09:36 +0000)]
[AArch64] Add support for TARGET_COMPUTE_FRAME_LAYOUT

The patch adds support for the TARGET_COMPUTE_FRAME_LAYOUT hook on AArch64
and removes unneeded frame layout recalculation.

2018-09-13  Vlad Lazar  <vlad.lazar@arm.com>

* config/aarch64/aarch64.h (TARGET_COMPUTE_FRAME_LAYOUT): Define.
* config/aarch64/aarch64.c (aarch64_expand_prologue): Remove
aarch64_layout_frame call.
(aarch64_expand_epilogue): Likewise.
(aarch64_initial_elimination_offset): Likewise.
(aarch64_get_separate_components): Likewise.
(aarch64_use_return_insn_p): Likewise.
(aarch64_layout_frame): Remove unneeded check.

From-SVN: r264263

5 years agoconfigure.ac: Only append " ...
Jakub Jelinek [Thu, 13 Sep 2018 07:43:29 +0000 (09:43 +0200)]
configure.ac: Only append " ...

* configure.ac: Only append
" : (reconfigured) $TOPLEVEL_CONFIGURE_ARGUMENTS" to
gcc_config_arguments if it was never reconfigured or last reconfigure
was with different arguments.
* configure: Regenerated.

From-SVN: r264262

5 years agore PR middle-end/87290 (Optimize signed x % pow2p == cst)
Jakub Jelinek [Thu, 13 Sep 2018 07:42:55 +0000 (09:42 +0200)]
re PR middle-end/87290 (Optimize signed x % pow2p == cst)

PR middle-end/87290
* expr.c (maybe_optimize_pow2p_mod_cmp): New function.
(maybe_optimize_mod_cmp): Use it if integer_pow2p treeop1.

* gcc.target/i386/pr87290.c: New test.
* gcc.c-torture/execute/pr87290.c: New test.

Co-Authored-By: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
From-SVN: r264261

5 years agore PR tree-optimization/87287 (Move signed (x % pow2) == 0 optimization to gimple)
Jakub Jelinek [Thu, 13 Sep 2018 07:36:50 +0000 (09:36 +0200)]
re PR tree-optimization/87287 (Move signed (x % pow2) == 0 optimization to gimple)

PR tree-optimization/87287
* fold-const.c (fold_binary_loc) <case EQ_EXPR>: Move signed modulo
X % C == 0 to X % (unsigned) C == 0 optimization to ...
* match.pd (X % C == 0): ... here.  New optimization.

* gcc.dg/tree-ssa/pr87287.c: New test.

From-SVN: r264260

5 years agocompiler: omit a couple of write barriers
Ian Lance Taylor [Thu, 13 Sep 2018 00:45:55 +0000 (00:45 +0000)]
compiler: omit a couple of write barriers

    Omit a write barrier for
        s = s[0:]
    for a slice s.  In this case the pointer is not changing and no write
    barrier is required.

    Omit a write barrier for
        s = append(s, v)
    in the case where len(s) < cap(s) (and similarly when appending more
    values).  When the slice has enough capacity the pointer is not
    changing and no write barrier is required.

    These changes are required to avoid write barriers in the method
    randomOrder.reset in the runtime package.  That method is called from
    procresize, at a point where we do not want to allocate memory.
    Otherwise that method can use a write barrier, allocate memory, and
    break TestReadMemStats.

    Reviewed-on: https://go-review.googlesource.com/134219

From-SVN: r264259

5 years agoDaily bump.
GCC Administrator [Thu, 13 Sep 2018 00:16:32 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264258

5 years agore PR c++/87093 (is_constructible (__is_constructible() instrinsic) explicitly instan...
Ville Voutilainen [Wed, 12 Sep 2018 21:10:43 +0000 (00:10 +0300)]
re PR c++/87093 (is_constructible (__is_constructible() instrinsic) explicitly instantiates conversion member function of source)

PR c++/87093

gcc/cp

PR c++/87093
* method.c (constructible_expr): We're in an unevaluated context
in all cases, not just for class targets.

testsuite/

PR c++/87093
* g++.dg/ext/is_constructible2.C: New.

From-SVN: r264253

5 years agoC++: special-case single non-viable candidate (more PR c++/85110)
David Malcolm [Wed, 12 Sep 2018 18:50:08 +0000 (18:50 +0000)]
C++: special-case single non-viable candidate (more PR c++/85110)

I broke out the "no viable candidates" case in build_new_method_call_1
into a subroutine, and added special-case handling for when there's
a single non-viable candidate where there's an argument conversion
error.  I turned the error-handling from convert_for_assignment into
a subroutine, calling it from this new special-case.

This converts:

demo.cc: In function 'int test_4(int, const char*, float)':
demo.cc:5:44: error: no matching function for call to 's4::member_1(int&, const char*&, float&)'
5 |   return s4::member_1 (first, second, third);
  |                                            ^
demo.cc:1:24: note: candidate: 'static int s4::member_1(int, const char**, float)'
1 | struct s4 { static int member_1 (int one, const char **two, float three); };
  |                        ^~~~~~~~
demo.cc:1:56: note:   no known conversion for argument 2 from 'const char*' to 'const char**'
1 | struct s4 { static int member_1 (int one, const char **two, float three); };
  |                                           ~~~~~~~~~~~~~^~~

to:

demo.cc: In function 'int test_4(int, const char*, float)':
demo.cc:5:31: error: cannot convert 'const char*' to 'const char**'
5 |   return s4::member_1 (first, second, third);
  |                               ^~~~~~
  |                               |
  |                               const char*
demo.cc:1:56: note:   initializing argument 2 of 'static int s4::member_1(int, const char**, float)'
1 | struct s4 { static int member_1 (int one, const char **two, float three); };
  |                                           ~~~~~~~~~~~~~^~~

thus highlighting the problematic argument at the callsite (and its type).

gcc/cp/ChangeLog:
PR c++/85110
* call.c (struct conversion_info): Add "loc" field.
(arg_conversion_rejection): Add "loc" param, using it to
initialize the new field.
(bad_arg_conversion_rejection): Likewise.
(explicit_conversion_rejection): Initialize the new field to
UNKNOWN_LOCATION.
(template_conversion_rejection): Likewise.
(add_function_candidate): Pass on the argument location to the new
param of arg_conversion_rejection.
(add_conv_candidate): Likewise.
(build_builtin_candidate): Likewise.
(build_user_type_conversion_1): Likewise.
(single_z_candidate): New function.
(maybe_get_bad_conversion_for_unmatched_call): New function.
(complain_about_bad_argument): New function, based on part of
convert_for_assignment.
(build_new_method_call_1): Split out handling of the "no viable
candidates" case into...
(complain_about_no_candidates_for_method_call): ...this new
function, and use the new functions above to special-case the
handling of a single non-viable candidate due to a bad argument.
* cp-tree.h (complain_about_bad_argument): New decl.
* typeck.c (convert_for_assignment): Split out one error-handling
case into complain_about_bad_argument.

gcc/testsuite/ChangeLog:
PR c++/85110
* g++.dg/cpp0x/explicit4.C: Update expected output to reflect
special-casing of diagnostic for a single non-viable candidate due
to a bad argument.
* g++.dg/diagnostic/param-type-mismatch-2.C: Likewise.
Add test coverage for an unmatched overloaded operator.
* g++.dg/expr/pmf-1.C: Likewise.
* g++.old-deja/g++.bugs/900330_02.C: Likewise.
* g++.old-deja/g++.jason/conversion11.C: Likewise.
* g++.old-deja/g++.law/arg11.C: Likewise.
* g++.old-deja/g++.law/arm9.C: Likewise.
* g++.old-deja/g++.robertl/eb131.C: Likewise.

From-SVN: r264250

5 years agore PR fortran/87284 (Allocation of class arrays with mold results in "conditional...
Paul Thomas [Wed, 12 Sep 2018 18:33:13 +0000 (18:33 +0000)]
re PR fortran/87284 (Allocation of class arrays with mold results in "conditional jump or move depends on uninitialised value")

2018-09-12  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/87284
* trans-expr.c (gfc_trans_class_init_assign): Access to
to array elements of the dynamic type requires that the array
reference be added to the class expression and not the _data
component, unlike scalar expressions.

2018-09-12  Paul Thomas  <pault@gcc.gnu.org>

PR fortran/87284
* gfortran.dg/allocate_with_mold_2.f90: New test.

From-SVN: r264249

5 years agore PR middle-end/82853 (Optimize x % 3 == 0 without modulo)
Jakub Jelinek [Wed, 12 Sep 2018 18:28:20 +0000 (20:28 +0200)]
re PR middle-end/82853 (Optimize x % 3 == 0 without modulo)

PR middle-end/82853
* expr.h (maybe_optimize_mod_cmp): Declare.
* expr.c (mod_inv): New function.
(maybe_optimize_mod_cmp): New function.
(do_store_flag): Use it.
* cfgexpand.c (expand_gimple_cond): Likewise.

* gcc.target/i386/pr82853-1.c: New test.
* gcc.target/i386/pr82853-2.c: New test.

From-SVN: r264248

5 years ago[OpenACC] C++ reference mapping
Cesar Philippidis [Wed, 12 Sep 2018 15:21:19 +0000 (08:21 -0700)]
[OpenACC] C++ reference mapping

2018-09-09  Cesar Philippidis  <cesar@codesourcery.com>
    Julian Brown  <julian@codesourcery.com>

PR middle-end/86336

gcc/cp/
* semantics.c (finish_omp_clauses): Treat C++ references the same in
OpenACC as OpenMP.

gcc/
* gimplify.c (gimplify_scan_omp_clauses): Set
target_firstprivatize_array_bases in OpenACC parallel and kernels
region contexts.  Remove GOMP_MAP_FIRSTPRIVATE_REFERENCE clauses from
OpenACC data regions.

libgomp/
* testsuite/libgomp.oacc-c++/non-scalar-data.C: Remove XFAIL.

Co-Authored-By: Julian Brown <julian@codesourcery.com>
From-SVN: r264244

5 years agoi386.md (sqrt_extend<mode>xf3_i387): Remove.
Uros Bizjak [Wed, 12 Sep 2018 15:04:41 +0000 (17:04 +0200)]
i386.md (sqrt_extend<mode>xf3_i387): Remove.

* config/i386/i386.md (sqrt_extend<mode>xf3_i387): Remove.
(sqrt<mode>2): Extend operand 1 to XFmode and generate sqrtxf3 insn.

From-SVN: r264243

5 years agore PR tree-optimization/87280 (ICE in set_ssa_val_to, at tree-ssa-sccvn.c:3647)
Richard Biener [Wed, 12 Sep 2018 14:03:21 +0000 (14:03 +0000)]
re PR tree-optimization/87280 (ICE in set_ssa_val_to, at tree-ssa-sccvn.c:3647)

2018-09-12  Richard Biener  <rguenther@suse.de>

PR tree-optimization/87280
* tree-ssa-sccvn.c (process_bb): Handle the case of executable
edge but unreachable target.
(do_rpo_vn): For conservatively handling a PHI only mark
the backedge executable but not the block reachable.

* gcc.dg/torture/pr87280.c: New testcase.

From-SVN: r264241

5 years agoFix interleaving of Fortran STOP messages
Kwok Cheung Yeung [Wed, 12 Sep 2018 13:53:34 +0000 (13:53 +0000)]
Fix interleaving of Fortran STOP messages

Fortran STOP and ERROR STOP use a different function to print the "STOP" string
and the message string.  On GCN this results in out-of-order output, such as
"<msg>ERROR STOP ".

This patch fixes the problem by making estr_write use the proper Fortran write,
not C printf, so both parts are now output the same way.  This also ensures
that both parts are output to STDERR (not that that means anything on GCN).

2018-09-12  Kwok Cheung Yeung  <kcy@codesourcery.com>

libgfortran/
* runtime/minimal.c (estr_write): Define in terms of write.

From-SVN: r264239

5 years agoFix Fortran STOP.
Andrew Stubbs [Wed, 12 Sep 2018 13:53:32 +0000 (13:53 +0000)]
Fix Fortran STOP.

The minimal libgfortran setup was created for NVPTX, but will also be used by
AMD GCN.

This patch simply removes an assumption that NVPTX is the only user.
Specifically, NVPTX exit is broken, but AMD GCN exit works just fine.

2018-09-12  Andrew Stubbs  <ams@codesourcery.com>

libgfortran/
* runtime/minimal.c (exit): Only work around nvptx bugs on nvptx.

From-SVN: r264238

5 years agore PR tree-optimization/87266 (ICE: Segmentation fault (in useless_type_conversion_p...
Richard Biener [Wed, 12 Sep 2018 12:14:27 +0000 (12:14 +0000)]
re PR tree-optimization/87266 (ICE: Segmentation fault (in useless_type_conversion_p, tree_nop_conversion_p, or is_gimple_reg_type))

2018-09-12  Richard Biener  <rguenther@suse.de>

PR tree-optimization/87266
* tree-ssa-sccvn.c (do_rpo_vn): Always iterate to not yet
visited blocks.

* gcc.dg/torture/pr87266-1.c: New testcase.
* gcc.dg/torture/pr87266-2.c: Likewise.
* gcc.dg/torture/pr87266-3.c: Likewise.
* gcc.dg/torture/pr87266-4.c: Likewise.

From-SVN: r264237

5 years agoS/390: Use proper rounding mode for DFP to BFD conversions
Andreas Krebbel [Wed, 12 Sep 2018 10:58:42 +0000 (10:58 +0000)]
S/390: Use proper rounding mode for DFP to BFD conversions

According to IEEE 754 2008 4.3 'Rounding-direction attributes' the
rounding mode of the target format needs to be used. By not setting
the value so far we have always used the DFP rounding mode.

gcc/ChangeLog:

2018-09-12  Andreas Krebbel  <krebbel@linux.ibm.com>

* config/s390/s390.md (PFPO_RND_MODE_DFP, PFPO_RND_MODE_BFP): New
constants.
("trunc<BFP:mode><DFP_ALL:mode>2")
("trunc<DFP_ALL:mode><BFP:mode>2")
("extend<BFP:mode><DFP_ALL:mode>2")
("extend<DFP_ALL:mode><BFP:mode>2"): Set proper rounding mode
according to the target operand type.

gcc/testsuite/ChangeLog:

2018-09-12  Andreas Krebbel  <krebbel@linux.ibm.com>

* gcc.target/s390/dfp_to_bfp_rounding.c: New test.

From-SVN: r264234

5 years agoAdd quotes for -fconstexpr-depth= in an error message.
Martin Liska [Wed, 12 Sep 2018 10:39:45 +0000 (12:39 +0200)]
Add quotes for -fconstexpr-depth= in an error message.

From-SVN: r264233

5 years agore PR tree-optimization/86844 (wrong code caused by store merging pass)
Jakub Jelinek [Wed, 12 Sep 2018 09:25:07 +0000 (11:25 +0200)]
re PR tree-optimization/86844 (wrong code caused by store merging pass)

PR tree-optimization/86844
* gimple-ssa-store-merging.c
(imm_store_chain_info::coalesce_immediate): For overlapping stores, if
there are any overlapping stores in between them, make sure they are
also coalesced or we give up completely.

* gcc.c-torture/execute/pr86844.c: New test.
* gcc.dg/store_merging_22.c: New test.
* gcc.dg/store_merging_23.c: New test.

Co-Authored-By: Andreas Krebbel <krebbel@linux.ibm.com>
From-SVN: r264232

5 years agore PR middle-end/87248 (Bad code for masked operations involving signed ints)
Jakub Jelinek [Wed, 12 Sep 2018 09:18:55 +0000 (11:18 +0200)]
re PR middle-end/87248 (Bad code for masked operations involving signed ints)

PR middle-end/87248
* fold-const.c (fold_ternary_loc) <case COND_EXPR>: Verify also that
BIT_AND_EXPR's second operand is a power of two.  Formatting fix.

* c-c++-common/torture/pr87248.c: New test.

From-SVN: r264230

5 years ago[debug] Add -gdescribe-dies
Tom de Vries [Wed, 12 Sep 2018 07:27:26 +0000 (07:27 +0000)]
[debug] Add -gdescribe-dies

This patch adds option -gdescribe-dies.  It sets the DW_AT_description
attribute of dies that do not get a DW_AT_name attribute, to make it easier
to figure out what the die is describing.

The option exports the names of artificial variables:
...
 DIE    0: DW_TAG_variable (0x7fa934dd54b0)
+  DW_AT_description: "D.1922"
   DW_AT_type: die -> 0 (0x7fa934dd0d70)
   DW_AT_artificial: 1

...
which can be traced back to gimple dumps:
...
  char a[0:D.1922] [value-expr: *a.0];
...

Furthermore, it adds names to external references:
...
 DIE    0: DW_TAG_subprogram (0x7fa88b9650f0)
+DW_AT_description: "main"
 DW_AT_abstract_origin: die -> label: vla_1.c.6719312a + 29 (0x7fa88b965140)
...
and likewise to DW_TAG_call_site_parameter DIEs.

Bootstrapped and reg-tested on x86_64.

2018-09-12  Tom de Vries  <tdevries@suse.de>

* common.opt (gdescribe-dies): Add option.
* dwarf2out.c (add_name_and_src_coords_attributes): Add description
attribute for artifical and nameless decls.
(dwarf2out_register_external_die): Add description attribute to
external reference die.
(add_desc_attribute): New functions.
(gen_subprogram_die): Add description attribute to
DW_TAG_call_site_parameter.
* tree-pretty-print.c (print_generic_expr_to_str): New function.
* tree-pretty-print.h (print_generic_expr_to_str): Declare.
* doc/invoke.texi (@item Debugging Options): Add -gdescribe-dies and
-gno-describe-dies.
(@item -gdescribe-dies): Add.

From-SVN: r264229

5 years agotree-vrp.c (vrp_shift_undefined_p): Remove.
Aldy Hernandez [Wed, 12 Sep 2018 07:04:19 +0000 (07:04 +0000)]
tree-vrp.c (vrp_shift_undefined_p): Remove.

* tree-vrp.c (vrp_shift_undefined_p): Remove.
(extract_range_from_binary_expr_1: Call
wide_int_range_shift_undefined_p instead of vrp_shift_undefined_p.
* wide-int-range.h (wide_int_range_shift_undefined_p): Do not
depend on sign.

From-SVN: r264228

5 years ago* gimple-ssa-warn-alloca.c
Aldy Hernandez [Wed, 12 Sep 2018 06:50:34 +0000 (06:50 +0000)]
* gimple-ssa-warn-alloca.c
(alloca_type_and_limit::alloca_type_and_limit): Initialize limit
field for ALLOCA_BOUND_*_LARGE.

From-SVN: r264227

5 years agoDaily bump.
GCC Administrator [Wed, 12 Sep 2018 00:16:47 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r264226

5 years ago* gcc.c (load_specs, execute, run_attempt): Use %qs not '%s'.
Nathan Sidwell [Tue, 11 Sep 2018 21:34:14 +0000 (21:34 +0000)]
* gcc.c (load_specs, execute, run_attempt): Use %qs not '%s'.

From-SVN: r264217