mesa.git
9 years agor600g,radeonsi: Set RADEON_GEM_NO_CPU_ACCESS flag for tiled BOs
Michel Dänzer [Tue, 9 Sep 2014 00:55:07 +0000 (09:55 +0900)]
r600g,radeonsi: Set RADEON_GEM_NO_CPU_ACCESS flag for tiled BOs

This lets the kernel know that such BOs can be pinned outside of the CPU
accessible part of VRAM.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
9 years agofreedreno/a3xx: enable hw primitive-restart
Rob Clark [Tue, 9 Sep 2014 15:20:40 +0000 (11:20 -0400)]
freedreno/a3xx: enable hw primitive-restart

Since software primitive-restart emulation is going to be removed (and
anyways, mostly seemed to be crash prone in combination with
u_primconvert and oddball scenarios (like PIPE_PRIM_POLYGON with only a
single vertex), might as well do it in hardware (which fortunately
didn't turn out to be too hard to figure out).

Signed-off-by: Rob Clark <robclark@freedesktop.org>
9 years agofreedreno: update generated headers
Rob Clark [Tue, 9 Sep 2014 15:11:24 +0000 (11:11 -0400)]
freedreno: update generated headers

Signed-off-by: Rob Clark <robclark@freedesktop.org>
9 years agofreedreno/ir3: fix potential segfault in RA
Rob Clark [Mon, 8 Sep 2014 17:42:54 +0000 (13:42 -0400)]
freedreno/ir3: fix potential segfault in RA

Triggered by shaders like:

  FRAG
  PROPERTY FS_COLOR0_WRITES_ALL_CBUFS 1
  DCL OUT[0], COLOR
  DCL CONST[0]
  DCL TEMP[0..2], LOCAL
    0: IF CONST[0].xxxx :0
    1:   MOV TEMP[0], TEMP[1]
    2: ELSE :0
    3:   MOV TEMP[0], TEMP[2]
    4: ENDIF
    5: MOV OUT[0], TEMP[0]
    6: END

not really a sane shader, although driver segfaulting is probably
not the appropriate response.

Signed-off-by: Rob Clark <robclark@freedesktop.org>
9 years agofreedreno: don't overflow cmdstream buffer so much
Rob Clark [Mon, 8 Sep 2014 15:18:01 +0000 (11:18 -0400)]
freedreno: don't overflow cmdstream buffer so much

We currently aren't too clever about dealing with running out of
cmdstream buffer space.  Since we use a single buffer for both drawing
and tiling commands, we need to ensure there is enough space at the tail
of the cmdstream buffer to fit the tiling commands.

Until we get more clever, the easy solution is a threshold to trigger
flushing rendering even if the application does not trigger flush (swap,
changing render target, etc).  This way we at least don't crash for apps
that do several thousand draw calls (like some piglit tests do).

Signed-off-by: Rob Clark <robclark@freedesktop.org>
9 years agofreedreno/ir3: add no-copy-propagate fallback step
Rob Clark [Sat, 6 Sep 2014 16:45:17 +0000 (12:45 -0400)]
freedreno/ir3: add no-copy-propagate fallback step

Most of the things the new compiler still has trouble with basically
amount to cp stage removing too many copies.  But without the cp stage,
the shaders the new compiler produces are still better (perf and
correctness) than the old compiler.  So a simple thing to do until I
have more time to work on it is first trying falling back to new
compiler without cp, before finally falling back to old compiler.

Signed-off-by: Rob Clark <robclark@freedesktop.org>
9 years agoilo: add ilo_builder.h to the sources list
Emil Velikov [Tue, 9 Sep 2014 21:17:39 +0000 (22:17 +0100)]
ilo: add ilo_builder.h to the sources list

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoir_to_mesa: Stop converting uniform booleans.
Kenneth Graunke [Mon, 8 Sep 2014 21:28:39 +0000 (14:28 -0700)]
ir_to_mesa: Stop converting uniform booleans.

Excess conversions considered harmful.

Recently Matt reworked the boolean uniform handling to use the value of
UniformBooleanTrue, rather than integer 1, when uploading uniforms:

    mesa: Upload boolean uniforms using UniformBooleanTrue.
    glsl: Use UniformBooleanTrue value for uniform initializers.

Marek then set the default to 1.0f for drivers without native integer
support:

    mesa: set UniformBooleanTrue = 1.0f by default

However, ir_to_mesa was assuming a value of integer 1, and arranging for
it to be converted to 1.0f on upload.  Since Marek's commit, we were
uploading 1.0f = 0x3f800000 which was being interpreted as the integer
value 1065353216 and converted to float as 1.06535322E9, which broke
assumptions in ir_to_mesa that "true" was exactly 1.0f.

+13 Piglits on classic swrast (fs-bool-less-compare-true,
{vs,fs}-op-not-bool-using-if, glsl-1.20/execution/uniform-initializer).

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83573
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
9 years agoconfigure.ac: strip _GNU_SOURCE from llvm-config output
Jonathan Gray [Fri, 5 Sep 2014 15:44:41 +0000 (01:44 +1000)]
configure.ac: strip _GNU_SOURCE from llvm-config output

Mesa already defines _GNU_SOURCE for glibc based systems and defining
_GNU_SOURCE will break the Mesa build on other systems such as OpenBSD.

_GNU_SOURCE only seems to be included in llvm-config output when
LLVM is built via autoconf and not when it is built by cmake.

Cc: "10.2 10.3" <mesa-stable@lists.freedesktop.org>
Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
9 years agoxmlconfig: suppress libGL warnings when LIBGL_DEBUG == "quiet"
Stefan Dirsch [Tue, 26 Aug 2014 20:47:51 +0000 (22:47 +0200)]
xmlconfig: suppress libGL warnings when LIBGL_DEBUG == "quiet"

Let's handle LIBGL_DEBUG env. variable in Mesa in a consistent way.

Fixes: https://bugzilla.novell.com/show_bug.cgi?id=895730
Signed-off-by: Stefan Dirsch <sndirsch@suse.de>
Reviewed-by: Courtney Goeltzenleuchter <courtney@lunarg.com>
9 years agoautomake: remove obsolete NEED_GALLIUM_LOADER
Emil Velikov [Mon, 8 Sep 2014 22:52:47 +0000 (23:52 +0100)]
automake: remove obsolete NEED_GALLIUM_LOADER

Superseded by HAVE_LOADER_GALLIUM. The latter has a *DRM* brethren
making the whose easier on which one to keep.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoconfigure: enable the gallium loader only when needed
Emil Velikov [Mon, 8 Sep 2014 22:52:46 +0000 (23:52 +0100)]
configure: enable the gallium loader only when needed

With the gallium megadrivers we've converted most ST to optionally
use either statically linked in or shared pipe-drivers.

The hardcoded switch forgot to conditionally enable the build of the
shared pipe-drivers which resulted in them being constantly build.

Cc: "10.3" <mesa-stable@lists.freedesktop.org>
Cc: James Ausmus <james.ausmus@intel.com>
Reported-by: James Ausmus <james.ausmus@intel.com>
Tested-by: James Ausmus <james.ausmus@intel.com>
Bugzilla: https://code.google.com/p/chromium/issues/detail?id=412089
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoconfigure: inform the user when we're building sw/kms-dri
Emil Velikov [Fri, 5 Sep 2014 13:06:23 +0000 (14:06 +0100)]
configure: inform the user when we're building sw/kms-dri

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoconfigure: kill off NEED_WINSYS_WRAPPER
Emil Velikov [Fri, 5 Sep 2014 13:06:22 +0000 (14:06 +0100)]
configure: kill off NEED_WINSYS_WRAPPER

Just drop the conditional and simplify our build. This means that
it'll build every time, but it does not require any dependencies nor
does it take that long to compile 200 lines of boilerplate code.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoconfigure: kill off NEED_NONNULL_WINSYS
Emil Velikov [Fri, 5 Sep 2014 13:06:21 +0000 (14:06 +0100)]
configure: kill off NEED_NONNULL_WINSYS

The variable was unused and gave false information. The need for nonnull
winsys currently does not relate as it used to. Nowadays one can mix and
match more freely with plenty of winsys' to make your head spin.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoconfigure: bail out if building svga without libdrm
Emil Velikov [Fri, 5 Sep 2014 13:06:20 +0000 (14:06 +0100)]
configure: bail out if building svga without libdrm

With recent commit we removed the NEED_NONNULL_WINSYS checks when
selecting the hardware (inc svga) winsys. svga has only one winsys
that explicitly requires libdrm (via it's bundled version of
vmwgfx_drm.h) but configure.ac never really checks for it.

Add the check early to prevent people from shooting themselves when
they select the driver but lack libdrm.

$ ./autogen.sh --disable-dri --disable-egl --disable-gallium-llvm
--with-dri-drivers=swrast --with-gallium-drivers=svga,swrast

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82539
Cc: "10.2 10.3" <mesa-stable@lists.freedesktop.org>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agovc4: Fix segfaults when rendering with no color render target.
Eric Anholt [Sun, 7 Sep 2014 19:29:41 +0000 (12:29 -0700)]
vc4: Fix segfaults when rendering with no color render target.

9 years agovc4: Fill out the stencil clear field.
Eric Anholt [Fri, 5 Sep 2014 21:38:13 +0000 (14:38 -0700)]
vc4: Fill out the stencil clear field.

The rest of stencil handling isn't done yet, but it documents an extra
cl_u8(0) and helps make it obvious why we don't need to format clear_depth
the same way the depth/stencil buffer is formatted.

9 years agovc4: Flip around the depth/stencil fields.
Eric Anholt [Fri, 5 Sep 2014 21:23:04 +0000 (14:23 -0700)]
vc4: Flip around the depth/stencil fields.

After implementing depth stores, it looks like this is the way things
actually are, according to hiz-depth-read-fbo-d24-s0's probes.

9 years agovc4: Add support for loading/storing the depth buffer.
Eric Anholt [Fri, 22 Aug 2014 20:32:50 +0000 (13:32 -0700)]
vc4: Add support for loading/storing the depth buffer.

For now it still requires the color buffer to be present -- we're relying
on the store of color buffer contents to end the frame, and we have to do
something with color buffers in the rendering config packet.

9 years agovc4: Don't forget to do initial tile clearing for depth/stencil.
Eric Anholt [Fri, 5 Sep 2014 20:16:25 +0000 (13:16 -0700)]
vc4: Don't forget to do initial tile clearing for depth/stencil.

9 years agovc4: Ignore non-address bits of the offset for load/store.
Eric Anholt [Fri, 5 Sep 2014 20:11:05 +0000 (13:11 -0700)]
vc4: Ignore non-address bits of the offset for load/store.

These only get used for full buffer dumps, which we don't support yet
anyway.

9 years agovc4: Add a debug flag for flushing after every draw.
Eric Anholt [Fri, 5 Sep 2014 21:17:27 +0000 (14:17 -0700)]
vc4: Add a debug flag for flushing after every draw.

It was useful on i965, but it's even more useful for debugging tiled
renderers.

9 years agovc4: Add missing null terminator to the debug options list.
Eric Anholt [Tue, 9 Sep 2014 14:28:12 +0000 (07:28 -0700)]
vc4: Add missing null terminator to the debug options list.

So far, apparently there's been some NULL laying at the address just after
the options anyway, but the next commit changed that.

9 years agoconfigure.ac: Fix build with git-svn llvm version string
Tom Stellard [Tue, 9 Sep 2014 11:04:20 +0000 (07:04 -0400)]
configure.ac: Fix build with git-svn llvm version string

Reviewed-and-tested-by: Jan Vesely <jan.vesely@rutgers.edu>
9 years agoLinking fails when not writing gl_Position.
Kalyan Kondapally [Mon, 8 Sep 2014 08:10:42 +0000 (11:10 +0300)]
Linking fails when not writing gl_Position.

According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined
after the vertex processing stage if we don't write gl_Position. However,
GLSL 1.10 Spec mentions that writing to gl_Position is mandatory. In case
of GLSL-ES, it's not an error and atleast the linking should pass.
Currently, Mesa throws an linker error in case we dont write to gl_position
and Version is less then 140(GLSL) and 300(GLSL-ES). This patch changes
it so that we don't report an error in case of GLSL-ES.

Signed-off-by: Kalyan Kondapally <kalyan.kondapally@intel.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83380

9 years agoilo: remove unused ilo_cp functions
Chia-I Wu [Sun, 7 Sep 2014 19:37:54 +0000 (03:37 +0800)]
ilo: remove unused ilo_cp functions

Remove

  ilo_cp_begin()
  ilo_cp_steal()
  ilo_cp_write()
  ilo_cp_write_multi()
  ilo_cp_write_bo()
  ilo_cp_end()
  ilo_cp_steal_ptr()
  ilo_cp_assert_no_implicit_flush()

9 years agoilo: convert GPE GEN6 command functions to use ilo_builder
Chia-I Wu [Sun, 7 Sep 2014 15:45:03 +0000 (23:45 +0800)]
ilo: convert GPE GEN6 command functions to use ilo_builder

Similar to the changes to GEN7 command functions, but to GEN6 this time.

As every GPE function has been converted, remove
ilo_cp_assert_no_implicit_flush() calls.

9 years agoilo: convert GPE GEN7 command functions to use ilo_builder
Chia-I Wu [Sun, 7 Sep 2014 15:45:03 +0000 (23:45 +0800)]
ilo: convert GPE GEN7 command functions to use ilo_builder

Make these changes

  ilo_cp_begin()    -> ilo_builder_batch_pointer()
  ilo_cp_write()    -> direct memory set
  ilo_cp_write_bo() -> ilo_builder_batch_reloc()

and use this chance to drop the "_emit_" infix.

9 years agoilo: convert GPE state functions to use ilo_builder
Chia-I Wu [Sat, 6 Sep 2014 17:10:01 +0000 (01:10 +0800)]
ilo: convert GPE state functions to use ilo_builder

Make these changes

  ilo_cp_steal_ptr() and memcpy() -> ilo_builder_state_write()
  ilo_cp_steal_ptr()              -> ilo_builder_state_pointer()

and use this chance to drop the "_emit_" infix.

9 years agoilo: convert GPE surface functions to use ilo_builder
Chia-I Wu [Sat, 6 Sep 2014 17:10:01 +0000 (01:10 +0800)]
ilo: convert GPE surface functions to use ilo_builder

Make these changes

  ilo_cp_steal_ptr() and memcpy()   -> ilo_builder_surface_write()
  ilo_cp_steal() and ilo_cp_write() -> ilo_builder_surface_write()
  ilo_cp_write_bo()                 -> ilo_builder_surface_reloc()

and use this chance to drop the "_emit_" infix.

9 years agoilo: convert BLT to use ilo_builder
Chia-I Wu [Sat, 6 Sep 2014 16:42:53 +0000 (00:42 +0800)]
ilo: convert BLT to use ilo_builder

Make these changes

  ilo_cp_begin()    -> ilo_builder_batch_pointer()
  ilo_cp_write()    -> direct memory set
  ilo_cp_write_bo() -> ilo_builder_batch_reloc()

and make sure there is no implicit flush.  Use this chance to drop the
"_emit_" infix.

9 years agoilo: use ilo_builder for kernels and STATE_BASE_ADDRESS
Chia-I Wu [Sat, 6 Sep 2014 04:20:55 +0000 (12:20 +0800)]
ilo: use ilo_builder for kernels and STATE_BASE_ADDRESS

Remove instruction buffer management from ilo_3d and adapt ilo_shader_cache to
upload kernels to ilo_builder.  To be able to do that, we also let ilo_builder
manage STATE_BASE_ADDRESS.

9 years agoilo: make ilo_cp based on ilo_builder
Chia-I Wu [Thu, 4 Sep 2014 05:56:32 +0000 (13:56 +0800)]
ilo: make ilo_cp based on ilo_builder

This makes ilo_cp use the builder to manage batch buffers, and use
ilo_builder_decode() to replace ilo_3d_pipeline_dump().

9 years agoilo: add a builder for building BOs for submission
Chia-I Wu [Mon, 1 Sep 2014 04:25:53 +0000 (12:25 +0800)]
ilo: add a builder for building BOs for submission

Comparing to how we manage batch and instruction buffers, the new builder

 - does not flush
 - manages both types of buffers
 - manages STATE_BASE_ADDRESS
 - uploads kernels using unsynchronized mapping
 - has its own decoder for the buffers
 - provides more helpers

9 years agoilo: make toy_compiler_disassemble() more useful
Chia-I Wu [Fri, 5 Sep 2014 04:01:34 +0000 (12:01 +0800)]
ilo: make toy_compiler_disassemble() more useful

Do not require a toy_compiler so that it can be used in other places, such as
state dumping.  Add a bool to control whether the raw instruction words are
shown.

9 years agonv50/ir: accomodate all file types, there are now more than 8
Ilia Mirkin [Sat, 6 Sep 2014 16:26:07 +0000 (12:26 -0400)]
nv50/ir: accomodate all file types, there are now more than 8

Reported by Coverity

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonvc0/ir: uses was always null at that point in the code
Ilia Mirkin [Sat, 6 Sep 2014 16:14:18 +0000 (12:14 -0400)]
nvc0/ir: uses was always null at that point in the code

Reported by Coverity

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonv50/ir: avoid array overrun when checking for supported mods
Ilia Mirkin [Sat, 6 Sep 2014 15:41:36 +0000 (11:41 -0400)]
nv50/ir: avoid array overrun when checking for supported mods

Reported by Coverity

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: "10.2 10.3" <mesa-stable@lists.freedesktop.org>
9 years agonouveau: buffer can never be null
Ilia Mirkin [Sat, 6 Sep 2014 15:34:28 +0000 (11:34 -0400)]
nouveau: buffer can never be null

Reported by Coverity

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonvc0/ir: insn can never be null
Ilia Mirkin [Sat, 6 Sep 2014 15:30:57 +0000 (11:30 -0400)]
nvc0/ir: insn can never be null

Reported by Coverity.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonvc0: size is a uint16_t, remove unnecessary assertion
Ilia Mirkin [Sat, 6 Sep 2014 15:11:58 +0000 (11:11 -0400)]
nvc0: size is a uint16_t, remove unnecessary assertion

Reported by Coverity.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonvc0: avoid null deref of screen when collecting stats
Ilia Mirkin [Sat, 6 Sep 2014 15:05:20 +0000 (11:05 -0400)]
nvc0: avoid null deref of screen when collecting stats

Reported by Coverity

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonvc0: use 64-bit math when scaling the query results
Ilia Mirkin [Sat, 6 Sep 2014 15:03:00 +0000 (11:03 -0400)]
nvc0: use 64-bit math when scaling the query results

Reported by Coverity.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agogallivm: (trivial) don't try to use rcp when the division 1/x is integer
Roland Scheidegger [Mon, 8 Sep 2014 11:56:13 +0000 (13:56 +0200)]
gallivm: (trivial) don't try to use rcp when the division 1/x is integer

This would just crash. Noticed by accident while checking int divisions by zero
with a quickly hacked piglit test.

Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
9 years agodocs: (trivial) mark softpipe, llvmpipe as done for GL_ARB_base_instance
Roland Scheidegger [Mon, 1 Sep 2014 14:08:12 +0000 (16:08 +0200)]
docs: (trivial) mark softpipe, llvmpipe as done for GL_ARB_base_instance

Forgot to add it when I fixed up the start instance handling in (llvm) draw.

Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
9 years agogallivm: (trivial) fix min / max variable names
Roland Scheidegger [Sat, 30 Aug 2014 02:58:58 +0000 (04:58 +0200)]
gallivm: (trivial) fix min / max variable names

Calling the variable min when it's really max and vice versa seems a bit
confusing.

Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
9 years agoi965: Handle ir_binop_ubo_load in boolean expression code.
Kenneth Graunke [Thu, 4 Sep 2014 07:18:45 +0000 (00:18 -0700)]
i965: Handle ir_binop_ubo_load in boolean expression code.

UBO loads can be boolean-valued expressions, too, so we need to handle
them in emit_bool_to_cond_code() and emit_if_gen6().

However, unlike most expressions, it doesn't make sense to evaluate
their operands, then do something with the results.  We just want to
evaluate the UBO load as a whole---which performs the read from
memory---then load the boolean result into the flag register.

Instead of adding code to handle it, we can simply bypass the
ir_expression handling, and fall through to the default code, which will
do exactly that.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83468
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Cc: mesa-stable@lists.freedesktop.org
9 years agoi965/fs: Make emit_if_gen6 never fall back to emit_bool_to_cond_code.
Kenneth Graunke [Thu, 4 Sep 2014 07:18:44 +0000 (00:18 -0700)]
i965/fs: Make emit_if_gen6 never fall back to emit_bool_to_cond_code.

Matt and I believe that Sandybridge actually uses 0xFFFFFFFF for a
"true" comparison result, similar to Ivybridge.  This matches the
internal documentation, and empirical results, but contradicts the PRM.

So, the comment is inaccurate, and we can actually just handle these
directly without ever needing to fall through to the condition code
path.

Also, the vec4 backend has always done it this way, and has apparently
been working fine.  This patch makes the FS backend match the vec4
backend's behavior.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
9 years agoi965: Handle ir_triop_csel in emit_if_gen6().
Kenneth Graunke [Thu, 4 Sep 2014 07:18:43 +0000 (00:18 -0700)]
i965: Handle ir_triop_csel in emit_if_gen6().

ir_triop_csel can return a boolean expression, so we need to handle it
here; we simply forgot when we added ir_triop_csel, and forgot again
when adding it to emit_bool_to_cond_code.

Fixes Piglit's EXT_shader_integer_mix/{vs,fs}-mix-if-bool on Sandybridge.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Cc: mesa-stable@lists.freedesktop.org
9 years agomesa/st: don't advertise NV_vdpau_interop if it doesn't work.
Christian König [Fri, 29 Aug 2014 09:46:06 +0000 (11:46 +0200)]
mesa/st: don't advertise NV_vdpau_interop if it doesn't work.

As long as we don't have a workaround for frame based
decoding in VDPAU we should not advertise NV_vdpau_interop.

v2: fix commit message, check if get_video_param is present

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: mesa-stable@lists.freedesktop.org
9 years agodocs: add news link to 10.2.7 release notes
Brian Paul [Mon, 8 Sep 2014 14:08:46 +0000 (08:08 -0600)]
docs: add news link to 10.2.7 release notes

9 years agoi965/fs: Remove direct fs_visitor gl_fragment_program dependence
Jordan Justen [Fri, 29 Aug 2014 19:50:46 +0000 (12:50 -0700)]
i965/fs: Remove direct fs_visitor gl_fragment_program dependence

Instead we cast backend_visitor::prog for fragment shader specific code paths.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agogallivm: Fix Altivec pack intrinsics for little-endian
Ulrich Weigand [Mon, 4 Aug 2014 16:41:00 +0000 (18:41 +0200)]
gallivm: Fix Altivec pack intrinsics for little-endian

This patch fixes use of Altivec pack intrinsics on little-endian PowerPC
systems.  Since little-endian operation only affects the load and store
instructions, the semantics of pack (and other) instructions that take
two input vectors implicitly change: the pack instructions still fill
a register placing values from the first operand into the "high" parts
of the register, and values from the second operand into the "low" parts
of the register, but since vector loads and stores perform an endian swap,
the high parts end up at high memory addresses.

To still achieve the desired effect, we have to swap the two inputs to
the pack instruction on little-endian systems.  This is done automatically
by the back-end for instructions generated by LLVM, but needs to be done
manually when emitting intrisincs (which still result in that instruction
being emitted directly).

Signed-off-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
Signed-off-by: Maarten Lankhorst <dev@mblankhorst.nl>
9 years agoi965/fs: Remove direct fs_generator brw_wm_prog_key dependence
Jordan Justen [Fri, 29 Aug 2014 19:50:46 +0000 (12:50 -0700)]
i965/fs: Remove direct fs_generator brw_wm_prog_key dependence

Instead we store a void pointer to the key, and cast it to
brw_wm_prog_key for fragment shader specific code paths.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agoi965/fs: Remove direct fs_generator brw_wm_prog_data dependence
Jordan Justen [Fri, 29 Aug 2014 19:50:46 +0000 (12:50 -0700)]
i965/fs: Remove direct fs_generator brw_wm_prog_data dependence

Instead we store a brw_stage_prog_data pointer, and cast it to
brw_wm_prog_data for fragment shader specific code paths.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agoi965/fs: Don't store gl_fragment_program* in fs_generator
Jordan Justen [Fri, 29 Aug 2014 19:50:46 +0000 (12:50 -0700)]
i965/fs: Don't store gl_fragment_program* in fs_generator

gl_program* is named prog similar to backend_visitor.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agoi965: Add uses_kill to brw_wm_prog_data
Jordan Justen [Fri, 29 Aug 2014 18:33:34 +0000 (11:33 -0700)]
i965: Add uses_kill to brw_wm_prog_data

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agoi965/fs: Rename fs_generator::prog to shader_prog
Jordan Justen [Wed, 3 Sep 2014 03:41:48 +0000 (20:41 -0700)]
i965/fs: Rename fs_generator::prog to shader_prog

This matches backend_visitor, and will allow gl_program to be named prog.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agoi965/fs: Add stage variable to fs_generator
Jordan Justen [Wed, 3 Sep 2014 05:50:44 +0000 (22:50 -0700)]
i965/fs: Add stage variable to fs_generator

This will allow for stage specific code paths.

Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agoi965: Adjust fast-clear resolve rect for BDW
Kristian Høgsberg [Fri, 5 Sep 2014 17:53:48 +0000 (10:53 -0700)]
i965: Adjust fast-clear resolve rect for BDW

The scale factors for the resolve rectangle change for BDW and we have
to look at brw->gen now to figure out how big it should be.

Fixes: https://bugs.freedesktop.org/attachment.cgi?id=105777
Cc: "10.3" <mesa-stable@lists.freedesktop.org>
Signed-off-by: Kristian Høgsberg <krh@bitplanet.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
9 years agonvc0/ir: clarify recursion fix to finding first tex uses
Christoph Bumiller [Fri, 5 Sep 2014 23:36:48 +0000 (01:36 +0200)]
nvc0/ir: clarify recursion fix to finding first tex uses

This is a simple shader for reproducing the case mentioned:

FRAG
DCL IN[0], GENERIC[0], PERSPECTIVE
DCL OUT[0], COLOR
DCL SAMP[0]
DCL CONST[0]
DCL TEMP[0..1], LOCAL
IMM[0] FLT32 {    0.0000,    -1.0000,     1.0000,     0.0000}
  0: MOV TEMP[0].x, CONST[0].wwww
  1: MOV TEMP[1].x, CONST[0].wwww
  2: BGNLOOP
  3:   IF TEMP[0].xxxx
  4:     BRK
  5:   ENDIF
  6:   ADD TEMP[0].x, TEMP[0], IMM[0].zzzz
  7:   IF CONST[0].xxxx
  8:     TEX TEMP[1].x, CONST[0], SAMP[0], 2D
  9:   ENDIF
 10:   IF CONST[0].zzzz
 11:     MOV TEMP[1].x, CONST[0].zzzz
 12:   ENDIF
 13: ENDLOOP
 14: MOV OUT[0], TEMP[1].xxxx
 15: END

Cc: "10.2 10.3" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonv50/ir/util: fix BitSet issues
Christoph Bumiller [Fri, 5 Sep 2014 21:52:45 +0000 (23:52 +0200)]
nv50/ir/util: fix BitSet issues

BitSet::allocate() is being used with the expectation that it would
leave the bitfield untouched if its size hasn't changed, however,
the function always zeroed the last word, which led to obscure bugs
with live set computation.

This also fixes BitSet::resize(), which was broken, but luckily not
being used.

Cc: "10.2 10.3" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonvc0: remove nvc0_push, replaced with nvc0_vbo_translate
Ilia Mirkin [Sat, 6 Sep 2014 02:58:43 +0000 (22:58 -0400)]
nvc0: remove nvc0_push, replaced with nvc0_vbo_translate

Fixes build.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agonv50,nvc0: get rid of draw module support
Ilia Mirkin [Sat, 6 Sep 2014 02:55:01 +0000 (22:55 -0400)]
nv50,nvc0: get rid of draw module support

This hasn't been enabled in a long time and is completely stale and
unnecessary. Remove, esp since it doesn't build.

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
9 years agoi965/fs: Don't look at virtual_grf_sizes for uniforms
Jason Ekstrand [Sat, 6 Sep 2014 00:07:16 +0000 (17:07 -0700)]
i965/fs: Don't look at virtual_grf_sizes for uniforms

Uniform values are in the UNIFORM register file, not the GRF register file.
Looking in virtual_grf_sizes makes no sense and only makes the output of
dump_instructions confusing.

Signed-off-by: Jason Ekstrand <jason.ekstrand@intel.com>
Reviewed-by: Matt Turner <mattst88@gmail.com>
9 years agoloader: fds can be 0
Dave Airlie [Mon, 1 Sep 2014 09:44:19 +0000 (19:44 +1000)]
loader: fds can be 0

Possible resource leak reported by coverity.

Reported-by: Coverity scanner.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Dave Airlie <airlied@redhat.com>
9 years agodocs: Import 10.2.7 release notes, add news item.
Emil Velikov [Sat, 6 Sep 2014 00:18:45 +0000 (01:18 +0100)]
docs: Import 10.2.7 release notes, add news item.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agogallium/vc4: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:33:42 +0000 (23:33 +0100)]
gallium/vc4: ship all files in the tarball

 - include all headers in Makefile.sources

Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/trace: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:31:12 +0000 (23:31 +0100)]
gallium/trace: ship all files in the tarball

 - include all headers in Makefile.sources
 - bundle the scons buildscript, README and trace.xsl

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/svga: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:28:04 +0000 (23:28 +0100)]
gallium/svga: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android & scons buildscript
 - include the headers' README & svga_dump.py

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/softpipe: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:21:17 +0000 (23:21 +0100)]
gallium/softpipe: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android & scons buildscript

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/rbug: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:19:13 +0000 (23:19 +0100)]
gallium/rbug: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android buildscript & README

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/radeonsi: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:17:37 +0000 (23:17 +0100)]
gallium/radeonsi: ship all files in the tarball

 - include all headers in Makefile.sources
 - bundle the android buildscript

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/radeon: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:15:01 +0000 (23:15 +0100)]
gallium/radeon: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android buildscript & LLVM note

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/r600: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:11:47 +0000 (23:11 +0100)]
gallium/r600: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android buildscript & custom include

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/r300: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:06:57 +0000 (23:06 +0100)]
gallium/r300: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android buildscript & the tests

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/nouveau: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:01:08 +0000 (23:01 +0100)]
gallium/nouveau: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android buildscript

v2: Don't double-include the compiler sources.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/noop: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 21:51:16 +0000 (22:51 +0100)]
gallium/noop: ship all files in the tarball

 - include all headers in Makefile.sources
 - bundle the scons buildscript

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/llvmpipe: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 21:49:19 +0000 (22:49 +0100)]
gallium/llvmpipe: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the scons buildscript

v2: Don't double include the test sources.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/identity: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 21:47:12 +0000 (22:47 +0100)]
gallium/identity: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the scons buildscript

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/ilo: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 22:57:36 +0000 (23:57 +0100)]
gallium/ilo: ship all files in the tarball

 - include all headers in Makefile.sources
 - bundle the android buildscript

Cc: Chia-I Wu <olvaffe@gmail.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/i915: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 21:45:15 +0000 (22:45 +0100)]
gallium/i915: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android buildscript & TODO

Cc: Stephane Marchesin <stephane.marchesin@gmail.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/galahad: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 21:41:52 +0000 (22:41 +0100)]
gallium/galahad: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the scons buildscript

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/freedreno: ship all files in the tarball
Emil Velikov [Fri, 29 Aug 2014 21:38:45 +0000 (22:38 +0100)]
gallium/freedreno: ship all files in the tarball

 - include all headers in Makefile.sources
 - sort the list(s)
 - bundle the android build

Cc: freedreno@lists.freedesktop.org
Cc: Rob Clark <robclark@freedesktop.org>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/tools: pick up the tools for distribution
Emil Velikov [Fri, 29 Aug 2014 19:43:57 +0000 (20:43 +0100)]
gallium/tools: pick up the tools for distribution

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium/tests: ship all the tests in the release tarball
Emil Velikov [Fri, 29 Aug 2014 19:42:34 +0000 (20:42 +0100)]
gallium/tests: ship all the tests in the release tarball

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agost/vega: ship the final headers
Emil Velikov [Fri, 29 Aug 2014 19:40:21 +0000 (20:40 +0100)]
st/vega: ship the final headers

Commit 60d772cd9d1(st/vega: add headers and SConscript in
the tarball) meant to pick all the headers to be included in
the release tarball yet it missed a few.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agost/egl: include the remaining files in the tarball
Emil Velikov [Fri, 29 Aug 2014 19:33:09 +0000 (20:33 +0100)]
st/egl: include the remaining files in the tarball

A few files were missing, namely:
 - a few of the common headers
 - the android + gdi sources

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agost/glx/xlib: ship the SConscript in the release tarball
Emil Velikov [Fri, 29 Aug 2014 19:31:43 +0000 (20:31 +0100)]
st/glx/xlib: ship the SConscript in the release tarball

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agost/dri: ship the scons buildscript in the release tarball
Emil Velikov [Fri, 29 Aug 2014 18:48:49 +0000 (19:48 +0100)]
st/dri: ship the scons buildscript in the release tarball

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agost/clover: ship Doxyfile in the release tarball
Emil Velikov [Fri, 29 Aug 2014 18:47:58 +0000 (19:47 +0100)]
st/clover: ship Doxyfile in the release tarball

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium: ship state-tracker/README in the release tarball
Emil Velikov [Fri, 29 Aug 2014 18:47:01 +0000 (19:47 +0100)]
gallium: ship state-tracker/README in the release tarball

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agogallium: ship the non-automaked state-trackers & targets
Emil Velikov [Thu, 28 Aug 2014 21:18:10 +0000 (22:18 +0100)]
gallium: ship the non-automaked state-trackers & targets

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agowinsys/intel: drop intel_winsys.h from makefile.sources
Emil Velikov [Fri, 29 Aug 2014 18:22:10 +0000 (19:22 +0100)]
winsys/intel: drop intel_winsys.h from makefile.sources

With the last revisions of commit 664c2d76947(gallium/ilo: cleanup
intel_winsys.h) we moved the header from winsys to drivers, but we
forgot to update the makefile.sources to reflect this.

Cc: Chia-I Wu <olvaffe@gmail.com>
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Chia-I Wu <olvaffe@gmail.com>
Acked-by: Matt Turner <mattst88@gmail.com>
9 years agometa: Store precompiled msaa shaders for all supported sample counts
Anuj Phogat [Sat, 23 Aug 2014 00:12:28 +0000 (17:12 -0700)]
meta: Store precompiled msaa shaders for all supported sample counts

Currently, BLIT_MSAA_SHADER_2D_MULTISAMPLE_RESOLVE* and
BLIT_MSAA_SHADER_2D_MULTISAMPLE_ARRAY_RESOLVE* shaders
in setup_glsl_msaa_blit_shader() are not recompiled
when the source buffer sample count changes. For example,
implementation continued using a 4X msaa shader, even if
source buffer changes from 4X msaa to 8x msaa. It causes
incorrect rendering.

This patch adds new enums in blit_msaa_shader, one for
each supported sample count, and uses them to store
msaa shaders.

Fixes following piglit tests on Broadwell:
ext_framebuffer_multisample-accuracy all_samples color
ext_framebuffer_multisample-accuracy all_samples depth_draw
ext_framebuffer_multisample-accuracy all_samples depth_resolve
ext_framebuffer_multisample-accuracy all_samples stencil_draw
ext_framebuffer_multisample-accuracy all_samples stencil_resolve
ext_framebuffer_multisample-formats all_samples

Signed-off-by: Anuj Phogat <anuj.phogat@gmail.com>
Reviewed-by: Jason Ekstarnd <jason@jlekstrand.net>
9 years agoconfigure: check for core xcb and link the VL targets against it
Emil Velikov [Fri, 11 Jul 2014 23:09:57 +0000 (00:09 +0100)]
configure: check for core xcb and link the VL targets against it

Make sure to check the presence of the module in order to pick the
correct libs flag and before feeding them to the compiler/linker.

Current libXvMC*, libvdpau* and libomx_mesa depends unconditionally
upon xcb, due to their usage of the aux/vl gallium module.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
9 years agoconfigure: check for core xcb and link libEGL against it
Emil Velikov [Fri, 11 Jul 2014 23:05:56 +0000 (00:05 +0100)]
configure: check for core xcb and link libEGL against it

Make sure to check the presence of the module in order to pick the
correct libs flag and before feeding them to the compiler/linker.

Current libEGL depends conditionally (when building with x11 platform)
upon xcb.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoconfigure: check for core xcb and link libGL against it
Emil Velikov [Fri, 11 Jul 2014 22:17:48 +0000 (23:17 +0100)]
configure: check for core xcb and link libGL against it

Make sure to check the presence of the module in order to pick the
correct libs flag and before feeding them to the compiler/linker.

Current libGL depends conditionally (when building with dri3) upon
xcb 1.9.3 and unconditionally on ancient xcb functions -
xcb_generate_id and xcb_request_check amongst others.

v2: Use PKG_CHECK_EXISTS() when checking for dri3 xcb.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=80848
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
9 years agoi965/blorp: Pass image formats seperately from the miptree
Jason Ekstrand [Wed, 3 Sep 2014 20:53:33 +0000 (13:53 -0700)]
i965/blorp: Pass image formats seperately from the miptree

When a texture is wrapped in a texture view, we can't trust the format in
the miptree itself.  This patch allows us to pass the format seperately
through blorp so we can proprerly handled wrapped textures.

It's worth noting here that we can use the miptree format directly for
depth/stencil formats because they cannot be reinterpreted by a texture
view.

Signed-off-by: Jason Ekstrand <jason.ekstrand@intel.com>
CC: "10.3" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Kristian Høgsberg <krh@bitplanet.net>