gcc.git
4 years agoc++: Delegating constructor in constexpr init [PR94772]
Patrick Palka [Mon, 27 Apr 2020 21:06:35 +0000 (17:06 -0400)]
c++: Delegating constructor in constexpr init [PR94772]

In the first testcase below, the call to the target constructor foo{} from foo's
delegating constructor is encoded as the INIT_EXPR

  *(struct foo *) this = AGGR_INIT_EXPR <4, __ct_comp, D.2140, ...>;

During initialization of the variable 'bar', we prematurely set TREE_READONLY on
bar's CONSTRUCTOR in two places before the outer delegating constructor has
returned: first, at the end of cxx_eval_call_expression after evaluating the RHS
of the above INIT_EXPR, and second, at the end of cxx_eval_store_expression
after having finished evaluating the above INIT_EXPR.  This then prevents the
rest of the outer delegating constructor from mutating 'bar'.

This (hopefully minimally risky) patch makes cxx_eval_call_expression refrain
from setting TREE_READONLY when evaluating the target constructor of a
delegating constructor.  It also makes cxx_eval_store_expression refrain from
setting TREE_READONLY when the object being initialized is "*this', on the basis
that it should be the responsibility of the routine that set 'this' in the first
place to set the object's TREE_READONLY appropriately.

gcc/cp/ChangeLog:

PR c++/94772
* constexpr.c (cxx_eval_call_expression): Don't set new_obj if we're
evaluating the target constructor of a delegating constructor.
(cxx_eval_store_expression): Don't set TREE_READONLY if the LHS of the
INIT_EXPR is '*this'.

gcc/testsuite/ChangeLog:

PR c++/94772
* g++.dg/cpp1y/constexpr-tracking-const23.C: New test.
* g++.dg/cpp1y/constexpr-tracking-const24.C: New test.
* g++.dg/cpp1y/constexpr-tracking-const25.C: New test.

4 years agoUpdate gcc fr.po, sv.po.
Joseph Myers [Mon, 27 Apr 2020 21:01:41 +0000 (21:01 +0000)]
Update gcc fr.po, sv.po.

4 years agoFix warning URLs for Fortran and analyzer [PR 92830]
David Malcolm [Thu, 5 Dec 2019 19:47:35 +0000 (14:47 -0500)]
Fix warning URLs for Fortran and analyzer [PR 92830]

PR 92830 reports that we always use "gcc/Warning-Options.html" when we
emit escaped documentation URLs when printing "[-Wname-of-option]" for
a warning.

This page is wrong for most Fortran warnings, and for analyzer warnings.

I considered various schemes involving adding extra tags to the .opt
format to capture where options are documented, but for now this patch
fixes the issue by introducing some special-casing logic.
It only fixes the URLs for warning options, not for other command-line
options, but those are the only options for which get_option_url is
currently called.

gcc/ChangeLog:
PR 92830
* configure.ac (DOCUMENTATION_ROOT_URL): Drop trailing "gcc/" from
default value, so that it can by supplied by get_option_html_page.
* configure: Regenerate.
* opts.c: Include "selftest.h".
(get_option_html_page): New function.
(get_option_url): Use it.  Reformat to place comments next to the
expressions they refer to.
(selftest::test_get_option_html_page): New.
(selftest::opts_c_tests): New.
* selftest-run-tests.c (selftest::run_tests): Call
selftest::opts_c_tests.
* selftest.h (selftest::opts_c_tests): New decl.

4 years agodemangler: Handle <=> operator in the demangler [PR94797]
Jakub Jelinek [Mon, 27 Apr 2020 18:59:25 +0000 (20:59 +0200)]
demangler: Handle <=> operator in the demangler [PR94797]

The demangler didn't handle spaceship operator.

2020-04-27  Jakub Jelinek  <jakub@redhat.com>

PR demangler/94797
* cp-demangle.c (cplus_demangle_operators): Add ss <=> operator.
* testsuite/demangle-expected: Add operator<=> test.

4 years agoaarch64: disable test on ilp32 [PR94697]
Szabolcs Nagy [Mon, 27 Apr 2020 17:07:59 +0000 (18:07 +0100)]
aarch64: disable test on ilp32 [PR94697]

branch-protection=pac-ret is not supported on ilp32 now and
the test requires it via branch-protection=standard.

committed as obvious.

gcc/testsuite/ChangeLog:

PR target/94697
* gcc.target/aarch64/pr94697.c: Require lp64.

4 years agoarm: Fix an rtl checking failure in cde-errors.c
Richard Sandiford [Mon, 27 Apr 2020 16:25:20 +0000 (17:25 +0100)]
arm: Fix an rtl checking failure in cde-errors.c

cde-errors.c and cde-mve-error-2.c were failing with an rtl checking
failure because we applied UINTVAL to a nonconstant argument
(specifically a REG).

2020-04-27  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/arm/arm-builtins.c (arm_expand_builtin_args): Only apply
UINTVAL to CONST_INTs.

4 years ago[GCC][PATCH][ARM]: Change arm constraint name from "e" to "Te".
Srinath Parvathaneni [Mon, 27 Apr 2020 15:50:58 +0000 (16:50 +0100)]
[GCC][PATCH][ARM]: Change arm constraint name from "e" to "Te".

This patches changes the constraint "e" to "Te".

gcc/ChangeLog:

2020-04-24  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

* config/arm/constraints.md (e): Remove constraint.
(Te): Define constraint.
* config/arm/mve.md (vaddvq_<supf><mode>): Modify constraint in
operand 0 from "e" to "Te".
(vaddvaq_<supf><mode>): Likewise.
(vaddvq_p_<supf><mode>): Likewise.
(vmladavq_<supf><mode>): Likewise.
(vmladavxq_s<mode>): Likewise.
(vmlsdavq_s<mode>): Likewise.
(vmlsdavxq_s<mode>): Likewise.
(vaddvaq_p_<supf><mode>): Likewise.
(vmladavaq_<supf><mode>): Likewise.
(vmladavq_p_<supf><mode>): Likewise.
(vmladavxq_p_s<mode>): Likewise.
(vmlsdavq_p_s<mode>): Likewise.
(vmlsdavxq_p_s<mode>): Likewise.
(vmlsdavaxq_s<mode>): Likewise.
(vmlsdavaq_s<mode>): Likewise.
(vmladavaxq_s<mode>): Likewise.
(vmladavaq_p_<supf><mode>): Likewise.
(vmladavaxq_p_s<mode>): Likewise.
(vmlsdavaq_p_s<mode>): Likewise.
(vmlsdavaxq_p_s<mode>): Likewise.

4 years agoc-family: Fix ICE on __builtin_speculation_safe_value () [PR94755]
Jakub Jelinek [Mon, 27 Apr 2020 14:05:03 +0000 (16:05 +0200)]
c-family: Fix ICE on __builtin_speculation_safe_value () [PR94755]

When this builtin has no parameters, speculation_safe_value_resolve_call
returns BUILT_IN_NONE, but resolve_overloaded_builtin uselessly
dereferences the first param just to return error_mark_node immediately.

The following patch rearranges it so that we only read the first parameter
if fncode is not BUILT_IN_NONE.

2020-04-27  Jakub Jelinek  <jakub@redhat.com>

PR c/94755
* c-common.c (resolve_overloaded_builtin): Return error_mark_node for
fncode == BUILT_IN_NONE before initialization of first_param.

* c-c++-common/pr94755.c: New test.

4 years agoarm: Fix bootstrap failure with rtl-checking
Andre Vieira [Mon, 27 Apr 2020 13:54:46 +0000 (14:54 +0100)]
arm: Fix bootstrap failure with rtl-checking

The code change that caused this regression was not meant to affect neon
code-gen, however I missed the REG fall through.  This patch makes sure we only
get the left-hand of the PLUS if it is indeed a PLUS expr.

gcc/ChangeLog:
2020-04-27  Andre Vieira  <andre.simoesdiasvieira@arm.com>

* config/arm/arm.c (output_move_neon): Only get the first operand if
addr is PLUS.

4 years agoforwprop: Fix ICE when building an identity constructor [PR94784]
Fei Yang [Mon, 27 Apr 2020 10:08:04 +0000 (11:08 +0100)]
forwprop: Fix ICE when building an identity constructor [PR94784]

In the testcase for PR94784, we have two vectors with the same ABI identity
but with different TYPE_MODEs. It would be better to flip the assert around
so that it checks that the two vectors have equal TYPE_VECTOR_SUBPARTS and
that converting the corresponding element types is a useless_type_conversion_p.

2020-04-27  Felix Yang  <felix.yang@huawei.com>

gcc/
PR tree-optimization/94784
* tree-ssa-forwprop.c (simplify_vector_constructor): Flip the
assert around so that it checks that the two vectors have equal
TYPE_VECTOR_SUBPARTS and that converting the corresponding element
types is a useless_type_conversion_p.

gcc/testsuite/
PR tree-optimization/94784
* gcc.dg/pr94784.c: New test.

4 years agoaarch64: Fix .cfi_window_save with pac-ret [PR94515]
Szabolcs Nagy [Mon, 27 Apr 2020 08:07:15 +0000 (09:07 +0100)]
aarch64: Fix .cfi_window_save with pac-ret [PR94515]

On aarch64 -mbranch-protection=pac-ret reuses the dwarf
opcode for window_save to mean "toggle the return address
mangle state", but in the dwarf2cfi internal logic the
state was not updated when an opcode was emitted, the
currently present update logic is only valid for the
original sparc use of window_save so a separate bool is
used on aarch64 to track the state.

This bug can cause the unwinder not to authenticate return
addresses that were signed (or vice versa) which means a
runtime crash on a pauth enabled system.

Currently only aarch64 pac-ret uses REG_CFA_TOGGLE_RA_MANGLE.

This should be backported to gcc-9 and gcc-8 branches.

gcc/ChangeLog:

PR target/94515
* dwarf2cfi.c (struct GTY): Add ra_mangled.
(cfi_row_equal_p): Check ra_mangled.
(dwarf2out_frame_debug_cfa_window_save): Remove the argument,
this only handles the sparc logic now.
(dwarf2out_frame_debug_cfa_toggle_ra_mangle): New function for
the aarch64 specific logic.
(dwarf2out_frame_debug): Update to use the new subroutines.
(change_cfi_row): Check ra_mangled.

gcc/testsuite/ChangeLog:

PR target/94515
* g++.target/aarch64/pr94515-1.C: New test.
* g++.target/aarch64/pr94515-2.C: New test.

4 years agos390: Fix C++14 vs. C++17 ABI incompatibility on s390{,x} [PR94704]
Jakub Jelinek [Mon, 27 Apr 2020 07:11:57 +0000 (09:11 +0200)]
s390: Fix C++14 vs. C++17 ABI incompatibility on s390{,x} [PR94704]

The following patch fixes the C++14 vs. C++17 ABI passing incompatibility
on s390x-linux.

Bootstrapped/regtested on s390x-linux without and with the patch, the
difference being:
-FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_alt.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_tst.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_tst.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t055 cp_compat_x_alt.o-cp_compat_y_alt.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t055 cp_compat_x_alt.o-cp_compat_y_tst.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t055 cp_compat_x_tst.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t055 cp_compat_x_tst.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t056 cp_compat_x_alt.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t056 cp_compat_x_alt.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t056 cp_compat_x_tst.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t056 cp_compat_x_tst.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t057 cp_compat_x_alt.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t057 cp_compat_x_alt.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t057 cp_compat_x_tst.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t057 cp_compat_x_tst.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_alt.o-cp_compat_y_alt.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_alt.o-cp_compat_y_tst.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_tst.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_tst.o-cp_compat_y_tst.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_alt.o-cp_compat_y_alt.o execute
 FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_alt.o-cp_compat_y_tst.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_tst.o-cp_compat_y_alt.o execute
-FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_tst.o-cp_compat_y_tst.o execute
when performing ALT_CXX_UNDER_TEST=g++ testing with a system GCC 10 compiler
from a week ago.  So, the alt vs. alt FAILs are all expected (we know before
this patch there is an ABI incompatibility) and some alt vs. tst (or tst vs.
alt) FAILs too - that depends on if the particular x or y test is compiled
with -std=c++14 or -std=c++17 - if x_tst is compiled with -std=c++14 and
y_alt is compiled with -std=c++17, then it should FAIL, similarly if x_alt
is compiled with -std=c++17 and y_tst is compiled with -std=c++14.

2020-04-27  Jakub Jelinek  <jakub@redhat.com>

PR target/94704
* config/s390/s390.c (s390_function_arg_vector,
s390_function_arg_float): Ignore cxx17_empty_base_field_p fields.

4 years agors6000: enable -fweb for small loops unrolling
guojiufu [Mon, 27 Apr 2020 06:08:20 +0000 (14:08 +0800)]
rs6000: enable -fweb for small loops unrolling

Previously -fweb was disabled if only unroll small loops.  After that
we find there is cases where it could help to rename pseudos and avoid
some anti-dependence which may occur after unroll.

This patch enables -fweb for small loops unrolling.

2020-04-27  Jiufu Guo   <guojiufu@cn.ibm.com>

* common/config/rs6000/rs6000-common.c
(rs6000_option_optimization_table) [OPT_LEVELS_ALL]: Remove turn off
-fweb.
* config/rs6000/rs6000.c (rs6000_option_override_internal): Avoid to
set flag_web.

4 years agoRS6000: Use .machine ppc for some CRT files
Sebastian Huber [Mon, 6 Apr 2020 20:30:21 +0000 (22:30 +0200)]
RS6000: Use .machine ppc for some CRT files

Since commit e154242724b084380e3221df7c08fcdbd8460674 the flag -many is
sometimes not passed to the assembler.  Use .machine ppc to prevent
errors if these files are assembled for an ISA which does not support
FPRs.

libgcc/

* config/rs6000/crtresfpr.S: Use .machine ppc.
* config/rs6000/crtresxfpr.S: Likewise.
* config/rs6000/crtsavfpr.S: Likewise.

4 years agoDo not remove ifunc_resolver in LTO.
Martin Liska [Mon, 27 Apr 2020 04:44:29 +0000 (06:44 +0200)]
Do not remove ifunc_resolver in LTO.

PR lto/94659
* cgraph.h (cgraph_node::can_remove_if_no_direct_calls_and_refs_p):
Do not remove ifunc_resolvers in remove unreachable nodes in LTO.

4 years agors6000: Don't use HARD_FRAME_POINTER_REGNUM if it's not live in pro_and_epilogue...
Xionghu Luo [Mon, 27 Apr 2020 01:37:27 +0000 (20:37 -0500)]
rs6000: Don't use HARD_FRAME_POINTER_REGNUM if it's not live in pro_and_epilogue (PR91518)

This bug is exposed by FRE refactor of r263875.  Comparing the fre
dump file shows no obvious change of the segment fault function proves
it to be a target issue.
frame_pointer_needed is set to true in reload pass setup_can_eliminate,
but regs_ever_live[31] is false, pro_and_epilogue uses it without live
check causing CPU2006 465.tonto segment fault of loading from invalid
addresses due to r31 not saved/restored.  Thus, add HARD_FRAME_POINTER_REGNUM
live check with frame_pointer_needed_indeed when generating pro_and_epilogue
instructions.

gcc/ChangeLog

2020-04-27  Xiong Hu Luo  <luoxhu@linux.ibm.com>

PR target/91518
* config/rs6000/rs6000-logue.c (frame_pointer_needed_indeed):
New variable.
(rs6000_emit_prologue_components):
Check with frame_pointer_needed_indeed.
(rs6000_emit_epilogue_components): Likewise.
(rs6000_emit_prologue): Likewise.
(rs6000_emit_epilogue): Set frame_pointer_needed_indeed.

4 years agoFix CL dates.
Marek Polacek [Mon, 27 Apr 2020 01:17:18 +0000 (21:17 -0400)]
Fix CL dates.

4 years agoc++: Explicit constructor called in copy-initialization [PR90320]
Marek Polacek [Thu, 23 Apr 2020 00:12:47 +0000 (20:12 -0400)]
c++: Explicit constructor called in copy-initialization [PR90320]

This test is rejected with a bogus "use of deleted function" error
starting with r225705 whereby convert_like_real/ck_base no longer
sets LOOKUP_ONLYCONVERTING for user_conv_p conversions.  This does
not seem to be always correct.  To recap, when we have something like
T t = x where T is a class type and the type of x is not T or derived
from T, we perform copy-initialization, something like:
  1. choose a user-defined conversion to convert x to T, the result is
     a prvalue,
  2. use this prvalue to direct-initialize t.

In the second step, explicit constructors should be considered, since
we're direct-initializing.  This is what r225705 fixed.

In this PR we are dealing with the first step, I think, where explicit
constructors should be skipped.  [over.match.copy] says "The converting
constructors of T are candidate functions" which clearly eliminates
explicit constructors.  But we also have to copy-initialize the argument
we are passing to such a converting constructor, and here we should
disregard explicit constructors too.

In this testcase we have

  V v = m;

and we choose V::V(M) to convert m to V.  But we wrongly choose
the explicit M::M<M&>(M&) to copy-initialize the argument; it's
a better match for a non-const lvalue than the implicit M::M(const M&)
but because it's explicit, we shouldn't use it.

When convert_like is processing the ck_user conversion -- the convfn is
V::V(M) -- it can see that cand->flags contains LOOKUP_ONLYCONVERTING,
but then when we're in build_over_call for this convfn, we have no way
to pass the flag to convert_like for the argument 'm', because convert_like
doesn't take flags.  Fixed by creating a new conversion flag, copy_init_p,
set in ck_base/ck_rvalue to signal that explicit constructors should be
skipped.

LOOKUP_COPY_PARM looks relevant, but again, it's a LOOKUP_* flag, so
can't pass it to convert_like.  DR 899 also seemed related, but that
deals with direct-init contexts only.

PR c++/90320
* call.c (struct conversion): Add copy_init_p.
(standard_conversion): Set copy_init_p in ck_base and ck_rvalue
if FLAGS demands LOOKUP_ONLYCONVERTING.
(convert_like_real) <case ck_base>: If copy_init_p is set, or
LOOKUP_ONLYCONVERTING into FLAGS.

* g++.dg/cpp0x/explicit13.C: New test.
* g++.dg/cpp0x/explicit14.C: New test.

4 years agolibphobos: Add hppa-*-linux* as a supported target
Iain Buclaw [Mon, 27 Apr 2020 00:41:08 +0000 (02:41 +0200)]
libphobos: Add hppa-*-linux* as a supported target

libphobos/ChangeLog:

2020-04-27  Iain Buclaw  <ibuclaw@gdcproject.org>

* configure.tgt: Add hppa-*-linux* as a supported target.

4 years agolibphobos: Remove AC_CACHE_CHECK from network library tests.
Iain Buclaw [Mon, 27 Apr 2020 00:09:43 +0000 (02:09 +0200)]
libphobos: Remove AC_CACHE_CHECK from network library tests.

libphobos/ChangeLog:

* configure: Regenerate.
* m4/druntime/libraries.m4 (DRUNTIME_LIBRARIES_NET): Remove
AC_CACHE_CHECK, simplify by setting LIBS directly.

4 years agod: Merge upstream dmd f8a1a5153, druntime 2b5c0b27
Iain Buclaw [Sun, 26 Apr 2020 23:43:34 +0000 (01:43 +0200)]
d: Merge upstream dmd f8a1a5153, druntime 2b5c0b27

Adds a new test directive COMPILABLE_MATH_TEST, and support has been
added for it in gdc-convert-test so that they are skipped if phobos is
not present on the target.

Only change in D runtime is a small documentation fix.

Reviewed-on: https://github.com/dlang/druntime/pull/3067
     https://github.com/dlang/dmd/pull/11060

gcc/testsuite/ChangeLog:

PR d/89418
* lib/gdc-utils.exp (gdc-convert-test): Add dg-skip-if for compilable
tests that depend on the phobos standard library.

4 years agod: Fix ICE in assign_temp, at function.c:984 (PR94777)
Iain Buclaw [Sun, 26 Apr 2020 21:39:32 +0000 (23:39 +0200)]
d: Fix ICE in assign_temp, at function.c:984 (PR94777)

Named arguments were being passed around by invisible reference, just
not variadic arguments.  There is a need to de-duplicate the routines
that handle declaration/parameter promotion and reference checking.
However for now, the parameter helper functions have just been renamed
to parameter_reference_p and parameter_type, to make it more clear that
it is the Parameter equivalent to declaration_reference_p and
declaration_type.

On writing the tests, a forward-reference bug was discovered on x86_64
during va_list type semantic.  This was due to fields not having their
parent set-up correctly.

gcc/d/ChangeLog:

PR d/94777
* d-builtins.cc (build_frontend_type): Set parent for generated
fields of built-in types.
* d-codegen.cc (argument_reference_p): Rename to ...
(parameter_reference_p): ... this.
(type_passed_as): Rename to ...
(parameter_type): ... this.  Make TREE_ADDRESSABLE types restrict.
(d_build_call): Move handling of non-POD types here from ...
* d-convert.cc (convert_for_argument): ... here.
* d-tree.h (argument_reference_p): Rename declaration to ...
(parameter_reference_p): ... this.
(type_passed_as): Rename declaration to ...
(parameter_type): ... this.
* types.cc (TypeVisitor::visit (TypeFunction *)): Update caller.

gcc/testsuite/ChangeLog:

PR d/94777
* gdc.dg/pr94777a.d: New test.
* gdc.dg/pr94777b.d: New test.

4 years agoDaily bump.
GCC Administrator [Mon, 27 Apr 2020 00:16:17 +0000 (00:16 +0000)]
Daily bump.

4 years agocoroutines: Do not assume parms are named [PR94752].
Iain Sandoe [Sun, 26 Apr 2020 18:34:50 +0000 (19:34 +0100)]
coroutines: Do not assume parms are named [PR94752].

Parameters to user-defined coroutines might be unnamed.
In that case, we must synthesize a name for the coroutine
frame copy.

gcc/cp/ChangeLog:

2020-04-26  Iain Sandoe  <iain@sandoe.co.uk>

PR c++/94752
* coroutines.cc (morph_fn_to_coro): Ensure that
unnamed function params have a usable and distinct
frame field name.

gcc/testsuite/ChangeLog:

2020-04-26  Iain Sandoe  <iain@sandoe.co.uk>

PR c++/94752
* g++.dg/coroutines/pr94752.C: New test.

4 years agoAdded test case from PR 94737.
Thomas Koenig [Sun, 26 Apr 2020 12:57:16 +0000 (14:57 +0200)]
Added test case from PR 94737.

2020-04-26  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/94737
* gfortran.dg/binding_label_tests_34.f90: New test case.

4 years agoAdd ChangeLog changes from previous commit, r10-7920.
Thomas Koenig [Sun, 26 Apr 2020 12:51:01 +0000 (14:51 +0200)]
Add ChangeLog changes from previous commit, r10-7920.

PR fortran/93956

4 years agolibphobos: Add power*-*-linux* as a supported target
Iain Buclaw [Sun, 26 Apr 2020 09:32:57 +0000 (11:32 +0200)]
libphobos: Add power*-*-linux* as a supported target

libphobos/ChangeLog:

* configure: Regenerate.
* configure.tgt: Add power*-*-linux* as a supported target, only
building libdruntime.
* m4/druntime/cpu.m4 (DRUNTIME_CPU_SOURCES): Add cases for powerpcle
and powerpc64le target cpus.

4 years agoAdd changelog entry for previous commit
Iain Buclaw [Sun, 26 Apr 2020 09:32:39 +0000 (11:32 +0200)]
Add changelog entry for previous commit

4 years agod: Recognize pragma(inline) in the code generator.
Iain Buclaw [Mon, 30 Mar 2020 22:19:18 +0000 (00:19 +0200)]
d: Recognize pragma(inline) in the code generator.

Pragma inline affects whether functions are inlined or not.  If at the
declaration level, it affects the functions declared in the block it
controls.  If inside a function, it affects the function it is enclosed
by.  Support has been in the front-end for some time, but the
information was not leveraged by the code generation pass.

gcc/d/ChangeLog:

* decl.cc (get_symbol_decl): Set DECL_DECLARED_INLINE_P or
DECL_UNINLINABLE for declarations with pragma(inline).
* toir.cc (IRVisitor::visit (GccAsmStatement *)): Set ASM_INLINE_P if
in function decorated with pragma(inline).

4 years agors6000: Don't push stack frame for AIX when debugging and -fcompare-debug.
David Edelsohn [Thu, 9 Apr 2020 16:43:22 +0000 (12:43 -0400)]
rs6000: Don't push stack frame for AIX when debugging and -fcompare-debug.

AIX pushes a stack frame when debugging is enabled.  With -fcompare-debug
this generates comparison failures because code geneation is different.
This patch disables the stack push for -fcompare-debug that only is used
for internal testing and not for normal debug information generation that
will be consumed by AIX tools.

This patch also removes xfails from testsuite testcases that use
-fcompare-debug and no longer fail on AIX without the stack push difference.

        * config/rs6000/rs6000-logue.c (rs6000_stack_info): Don't push a
        stack frame when debugging and flag_compare_debug is enabled.

testsuite/
        * g++.dg/debug/dwarf2/pr61433.C: Unfail AIX.
        * g++.dg/opt/pr48549.C: Same.
        * g++.dg/opt/pr60002.C: Same.
        * g++.dg/opt/pr80436.C: Same.
        * g++.dg/opt/pr83084.C: Same.
        * g++.dg/other/pr42685.C: Same.
        * gcc.dg/pr41241.c: Same.
        * gcc.dg/pr42629.c: Same.
        * gcc.dg/pr42630.c: Same.
        * gcc.dg/pr42719.c: Same.
        * gcc.dg/pr42728.c: Same.
        * gcc.dg/pr42889.c: Same.
        * gcc.dg/pr42916.c: Same.
        * gcc.dg/pr43084.c: Same.
        * gcc.dg/pr43670.c: Same.
        * gcc.dg/pr44023.c: Same.
        * gcc.dg/pr44971.c: Same.
        * gcc.dg/pr45449.c: Same.
        * gcc.dg/pr46771.c: Same.
        * gcc.dg/pr47684.c: Same.
        * gcc.dg/pr47881.c: Same.
        * gcc.dg/pr48768.c: Same.
        * gcc.dg/pr50017.c: Same.
        * gcc.dg/pr56023.c: Same.
        * gcc.dg/pr64935-1.c: Same.
        * gcc.dg/pr64935-2.c: Same.
        * gcc.dg/pr65521.c: Same.
        * gcc.dg/pr65779.c: Same.
        * gcc.dg/pr65980.c: Same.
        * gcc.dg/pr66688.c: Same.
        * gcc.dg/pr70405.c: Same.
        * gcc.dg/vect/pr49352.c: Same.

4 years agoDaily bump.
GCC Administrator [Sun, 26 Apr 2020 00:16:21 +0000 (00:16 +0000)]
Daily bump.

4 years agotestsuite: Add -Wno-psabi option for ipa-sra-19.c on AIX.
David Edelsohn [Sat, 25 Apr 2020 23:27:14 +0000 (19:27 -0400)]
testsuite: Add -Wno-psabi option for ipa-sra-19.c on AIX.

ipa-sra-19.c uses a vector type that elicits a non-standard ABI warning
on AIX causing a spurious testsuite failure.

        * gcc.dg/ipa/ipa-sra-19.c: Add -Wno-psabi option on AIX.

4 years agotestsuite: spellcheck-options-21.c requires LTO
David Edelsohn [Sat, 25 Apr 2020 23:03:33 +0000 (19:03 -0400)]
testsuite: spellcheck-options-21.c requires LTO

spellcheck-options-21.c requires LTO supported on the target.

        * gcc.dg/spellcheck-options-21.c: Require LTO.

4 years agotestsuite: Skip pr82718-1.c and pr82718-2.c DWARF 5 tests on AIX.
David Edelsohn [Sat, 25 Apr 2020 21:11:54 +0000 (17:11 -0400)]
testsuite: Skip pr82718-1.c and pr82718-2.c DWARF 5 tests on AIX.

AIX 7.2 XCOFF does not support DWARF 5 sections.  Skip the explicit
DWARF 5 tests that emit the new loc_lists and range_lists sections.

        * gcc.dg/debug/dwarf2/pr82718-1.c: Skip on AIX.
        * gcc.dg/debug/dwarf2/pr82718-2.c: Skip on AIX.

4 years agolibffi/test: Fix compilation for build sysroot
Maciej W. Rozycki [Sat, 25 Apr 2020 20:27:14 +0000 (21:27 +0100)]
libffi/test: Fix compilation for build sysroot

Fix a problem with the libffi testsuite using a method to determine the
compiler to use resulting in the tool being different from one the
library has been built with, and causing a catastrophic failure from the
inability to actually choose any compiler at all in a cross-compilation
configuration.

Address this problem by providing a DejaGNU configuration file defining
the compiler to use, via the CC_FOR_TARGET TCL variable, set from $CC by
autoconf, which will have all the required options set for the target
compiler to build executables in the environment configured, removing
failures like:

FAIL: libffi.call/closure_fn0.c -W -Wall -Wno-psabi -O0 (test for excess errors)
Excess errors:
default_target_compile: No compiler to compile with
UNRESOLVED: libffi.call/closure_fn0.c -W -Wall -Wno-psabi -O0 compilation failed to produce executable

and bringing overall test results for the `riscv64-linux-gnu' target
(here with the `x86_64-linux-gnu' host and RISC-V QEMU in the Linux user
emulation mode as the target board) from:

=== libffi Summary ===

# of unexpected failures 708
# of unresolved testcases 708
# of unsupported tests 30

to:

=== libffi Summary ===

# of expected passes 1934
# of unsupported tests 28

This is a combined backport of the relevant parts of upstream libffi
changes as follows:

- commit 8308984e479e ("[PATCH] Make sure we're running dejagnu tests
  with the right compiler."),

- commit 2d9b3939751b ("[PATCH] Fix for closures with sunpro compiler"),

- commit 0c3824702d3d ("[PATCH] Always set CC_FOR_TARGET for dejagnu, to
  make the testsuite respect $CC"),

- commit 7d698125b1f0 ("[PATCH] Use the proper C++ compiler to run C++
  tests"),

- commit 6b6df1a7bb37 ("[PATCH] Adds `local.exp` to CLEANFILES"),

- commit 6cf0dea78a5a ("[PATCH] Change CLEANFILES to DISTCLEANFILES")

libffi/
* Makefile.am (DISTCLEANFILES): New variable.
* configure.ac: Produce `local.exp'.
* Makefile.in: Regenerate.
* configure: Regenerate.
* testsuite/Makefile.am (EXTRA_DEJAGNU_SITE_CONFIG): New
variable.
* testsuite/Makefile.in: Regenerate.

4 years agoEnable Intel CET in liblto_plugin.so on Intel CET enabled host
H.J. Lu [Sat, 25 Apr 2020 17:06:59 +0000 (10:06 -0700)]
Enable Intel CET in liblto_plugin.so on Intel CET enabled host

Since ld is Intel CET enabled on Intel CET enabled host, dlopen fails on
liblto_plugin.so if it isn't Intel CET enabled.  Add GCC_CET_HOST_FLAGS
to cet.m4, use it in libiberty and lto-plugin to always enable Intel
CET in liblto_plugin.so on Intel CET enabled host.

On Linux/x86 host, enable Intel CET by default if assembler and compiler
support Intel CET so that the generated liblto_plugin.so can be used on
both CET and non-CET machines.  It is an error to disable Intel CET in
liblto_plugin.so on Intel CET enabled host.

config/

PR bootstrap/94739
* cet.m4 (GCC_CET_HOST_FLAGS): New.

libiberty/

PR bootstrap/94739
* Makefile.in (COMPILE.c): Add @CET_HOST_FLAGS@.
(configure_deps): Add $(srcdir)/../config/cet.m4 and
$(srcdir)/../config/enable.m4.
* aclocal.m4: Include ../config/cet.m4 and ../config/enable.m4.
* configure.ac: Add GCC_CET_HOST_FLAGS(CET_HOST_FLAGS) and
AC_SUBST(CET_HOST_FLAGS).
* configure: Regenerated.

lto-plugin/

PR bootstrap/94739
* Makefile.am (AM_CFLAGS): Add $(CET_HOST_FLAGS).
* configure.ac: Add GCC_CET_HOST_FLAGS(CET_HOST_FLAGS) and
AC_SUBST(CET_HOST_FLAGS).
* Makefile.in: Regenerated.
* aclocal.m4: Likewise.
* configure: Likewise.

4 years agoFix PR 94578.
Thomas König [Sat, 25 Apr 2020 10:28:15 +0000 (12:28 +0200)]
Fix PR 94578.

Our intrinsics do not handle spans on their return values (yet),
so this creates a temporary for subref array pointers.

2020-04-25  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/94578
* trans-expr.c (arrayfunc_assign_needs_temporary): If the
LHS is a subref pointer, we also need a temporary.

2020-04-25  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/94578
* gfortran.dg/pointer_assign_14.f90: New test.
* gfortran.dg/pointer_assign_15.f90: New test.

4 years agocoroutines, testsuite: Enable a test.
Iain Sandoe [Sat, 25 Apr 2020 09:55:10 +0000 (10:55 +0100)]
coroutines, testsuite: Enable a test.

This just enables a test that can now be run since we've
resolved the PRs blocking it.

2020-04-25  Iain Sandoe  <iain@sandoe.co.uk>

* g++.dg/coroutines/torture/co-ret-16-simple-control-flow.C:
Enable test.

4 years agoTurn on -mpcrel by default for -mcpu=future
Michael Meissner [Sat, 25 Apr 2020 06:43:10 +0000 (02:43 -0400)]
Turn on -mpcrel by default for -mcpu=future

2020-04-25  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/linux64.h (PCREL_SUPPORTED_BY_OS): Define to
enable PC-relative addressing for -mcpu=future.
* config/rs6000/rs6000-cpus.def (ISA_FUTURE_MASKS_SERVER): Move
after OTHER_FUTURE_MASKS.  Use OTHER_FUTURE_MASKS.
* config/rs6000/rs6000.c (PCREL_SUPPORTED_BY_OS): If not defined,
suppress PC-relative addressing.
(rs6000_option_override_internal): Split up error messages
checking for -mprefixed and -mpcrel.  Enable -mpcrel if the target
system supports it.

4 years agoc++: implicit operator== with previous decl [PR94583]
Jason Merrill [Fri, 24 Apr 2020 20:27:26 +0000 (16:27 -0400)]
c++: implicit operator== with previous decl [PR94583]

P2085 clarified that a defaulted comparison operator must be the first
declaration of the function.  Rejecting that avoids the ICE trying to
compare the noexcept-specifications.

gcc/cp/ChangeLog
2020-04-24  Jason Merrill  <jason@redhat.com>

PR c++/94583
* decl.c (redeclaration_error_message): Reject defaulted comparison
operator that has been previously declared.

4 years agoc++: add "'requires' only available with ..." note
Patrick Palka [Sat, 25 Apr 2020 01:16:59 +0000 (21:16 -0400)]
c++: add "'requires' only available with ..." note

This adds a note suggesting to enable concepts whenever 'requires' is parsed as
an invalid type name with concepts disabled.

gcc/cp/ChangeLog:

* parser.c (cp_parser_diagnose_invalid_type_name): Suggest enabling
concepts if the invalid identifier is 'requires'.

gcc/testsuite/ChangeLog:

* g++.dg/concepts/diagnostic11.C: New test.

4 years agod: Merge upstream dmd 09db0c41e, druntime e68a5ae3.
Iain Buclaw [Sat, 25 Apr 2020 00:19:04 +0000 (02:19 +0200)]
d: Merge upstream dmd 09db0c41e, druntime e68a5ae3.

* New core.math.toPrec templates have been added as an intrinsic.

  Some floating point algorithms, such as Kahan-Babuska-Neumaier
  Summation, require rounding to specific precisions. Rounding to
  precision after every operation, however, loses overall precision in
  the general case and is a runtime performance problem.

  Adding these functions guarantee the rounding at required points in
  the code, and document where in the algorithm the requirement exists.

* Support IBM long double types in core.internal.convert.

* Add missing aliases for 64-bit vectors in core.simd.

* RUNNABLE_PHOBOS_TEST directive has been properly integrated into the
  D2 language testsuite.

Reviewed-on: https://github.com/dlang/druntime/pull/3063
     https://github.com/dlang/dmd/pull/11054

gcc/d/ChangeLog:

* intrinsics.cc (expand_intrinsic_toprec): New function.
(maybe_expand_intrinsic): Handle toPrec intrinsics.
* intrinsics.def (TOPRECF, TOPREC, TOPRECL): Add toPrec intrinsics.

4 years agoDaily bump.
GCC Administrator [Sat, 25 Apr 2020 00:16:17 +0000 (00:16 +0000)]
Daily bump.

4 years agoc++: Avoid -Wreturn-type warning if a template fn calls noreturn template fn [PR94742]
Jakub Jelinek [Fri, 24 Apr 2020 22:11:35 +0000 (00:11 +0200)]
c++: Avoid -Wreturn-type warning if a template fn calls noreturn template fn [PR94742]

finish_call_expr already has code to set current_function_returns_abnormally
if a template calls a noreturn function, but on the following testcase it
doesn't call a FUNCTION_DECL, but TEMPLATE_DECL instead, in which case
we didn't check noreturn at all and just assumed it could return.

2020-04-25  Jakub Jelinek  <jakub@redhat.com>

PR c++/94742
* semantics.c (finish_call_expr): When looking if all overloads
are noreturn, use STRIP_TEMPLATE to look through TEMPLATE_DECLs.

* g++.dg/warn/Wreturn-type-12.C: New test.

4 years agocselim: Don't assume it is safe to cstore replace a store to a local variable with...
Jakub Jelinek [Fri, 24 Apr 2020 22:10:01 +0000 (00:10 +0200)]
cselim: Don't assume it is safe to cstore replace a store to a local variable with unknown offset [PR94734]

As the new testcase shows, it is not safe to assume we can optimize
a conditional store into an automatic non-addressable var, we can do it
only if we can prove that the unconditional load or store actually will
not be outside of the boundaries of the variable.
If the offset and size are constant, we can, but this is already all
checked in !tree_could_trap_p, otherwise we really need to check for
a dominating unconditional store, or for the specific case of automatic
non-addressable variables, it is enough if there is a dominating load
(that is what those 4 testcases have).  tree-ssa-phiopt.c has some
infrastructure for this already, see the add_or_mark_expr method etc.,
but right now it handles only MEM_REFs with SSA_NAME first operand
and some integral offset.  So, I think it can be for GCC11 extended
to handle other memory references, possibly up to just doing
get_inner_reference and hasing based on the base, offset expressions
and bit_offset and bit_size, and have also a special case that for
!TREE_ADDRESSABLE automatic variables it could ignore whether something
is a load or store because the local stack should be always writable.
But it feels way too dangerous to do this this late for GCC10, so this
patch just restricts the optimization to the safe case (where lhs doesn't
trap), and on Richi's request also ignores TREE_ADDRESSABLE bit if
flag_store_data_races, because my understanding the reason for
TREE_ADDRESSABLE check is that we want to avoid introducing
store data races (if address of an automatic var escapes, some other thread
could be accessing it concurrently).

2020-04-25  Jakub Jelinek  <jakub@redhat.com>
    Richard Biener  <rguenther@suse.de>

PR tree-optimization/94734
PR tree-optimization/89430
* tree-ssa-phiopt.c: Include tree-eh.h.
(cond_store_replacement): Return false if an automatic variable
access could trap.  If -fstore-data-races, don't return false
just because an automatic variable is addressable.

* gcc.dg/tree-ssa/pr89430-1.c: Add xfail.
* gcc.dg/tree-ssa/pr89430-2.c: Add xfail.
* gcc.dg/tree-ssa/pr89430-5.c: Add xfail.
* gcc.dg/tree-ssa/pr89430-6.c: Add xfail.
* gcc.c-torture/execute/pr94734.c: New test.

4 years agod: Fix order of precedence for -defaultlib and -debuglib
Iain Buclaw [Fri, 24 Apr 2020 21:39:32 +0000 (23:39 +0200)]
d: Fix order of precedence for -defaultlib and -debuglib

The order of precedence used by the upstream reference compiler for
determining what library to link against is:
- No library if -nophoboslib or -fno-druntime was seen.
- The library passed to -debuglib if -g was also seen.
- The library passed to -defaultlib
- The in-tree libgphobos library.

This aligns the D language driver to follow the same rules.

gcc/d/ChangeLog:

* d-spec.cc (need_phobos): Remove.
(lang_specific_driver): Replace need_phobos with phobos_library.
Reorder -debuglib and -defaultlib to have precedence over libphobos.
(lang_specific_pre_link): Remove test for need_phobos.

4 years agoamdgcn: Fix wrong-code bug in 64-bit masked add
Andrew Stubbs [Thu, 19 Mar 2020 17:44:59 +0000 (17:44 +0000)]
amdgcn: Fix wrong-code bug in 64-bit masked add

2020-04-24  Andrew Stubbs  <ams@codesourcery.com>

gcc/
* config/gcn/gcn-valu.md (add<mode>_zext_dup2_exec): Fix merge
of high-part.
(add<mode>_sext_dup2_exec): Likewise.

4 years agors6000: Properly handle LE index munging in vec_shr (PR94710)
Segher Boessenkool [Fri, 24 Apr 2020 13:33:14 +0000 (13:33 +0000)]
rs6000: Properly handle LE index munging in vec_shr (PR94710)

The PR shows the compiler crashing with -mvsx -mlittle -O0.  This turns
out to be caused by a failure to make of the higher bits in an index
endian conversion.

2020-04-24  Segher Boessenkool  <segher@kernel.crashing.org>

PR target/94710
* config/rs6000/vector.md (vec_shr_<mode> for VEC_L): Correct little
endian byteshift_val calculation.

4 years agotestsuite: C++14 vs. C++17 struct-layout-1.exp testing with ALT_CXX_UNDER_TEST [PR94383]
Jakub Jelinek [Fri, 24 Apr 2020 17:14:27 +0000 (19:14 +0200)]
testsuite: C++14 vs. C++17 struct-layout-1.exp testing with ALT_CXX_UNDER_TEST [PR94383]

> I haven't added (yet) checks if the alternate compiler does support these
> options (I think that can be done incrementally), so for now this testing is
> done only if the alternate compiler is not used.

This patch does that, so now when testing against not too old compiler
it can do the -std=c++14 vs. -std=c++17 testing also between under test and
alt compilers.

2020-04-24  Jakub Jelinek  <jakub@redhat.com>

PR c++/94383
* g++.dg/compat/struct-layout-1.exp: Use the -std=c++14 vs. -std=c++17
ABI compatibility testing even with ALT_CXX_UNDER_TEST, as long as
that compiler accepts -std=c++14 and -std=c++17 options.

4 years agoamdgcn: Split 64-bit constant loads post-reload
Andrew Stubbs [Thu, 19 Mar 2020 17:43:12 +0000 (17:43 +0000)]
amdgcn: Split 64-bit constant loads post-reload

This helps avoid spilling 64-bit constant loads to stack by simplifying the
code that LRA sees.

2020-04-24  Andrew Stubbs  <ams@codesourcery.com>

gcc/
* config/gcn/gcn.md (*mov<mode>_insn): Only split post-reload.

4 years agoamdgcn: Testsuite tweaks
Andrew Stubbs [Thu, 16 Apr 2020 19:20:22 +0000 (20:20 +0100)]
amdgcn: Testsuite tweaks

The vector size chosen here is for V64DImode. The concept of this setting is
not well adapted for GCN, in which the vector size varies with the number of
lanes, not the other way around, but this is ok for now.

2020-04-24  Andrew Stubbs  <ams@codesourcery.com>

gcc/testsuite/
* lib/target-supports.exp (available_vector_sizes): Add amdgcn.
(check_effective_target_vect_cmdline_needed): Disable for amdgcn.
(check_effective_target_vect_pack_trunc): Add amdgcn.

4 years agolibstdc++: Make net::service_already_exists default constructible
Jonathan Wakely [Fri, 24 Apr 2020 13:15:51 +0000 (14:15 +0100)]
libstdc++: Make net::service_already_exists default constructible

The LWG issue I created is Tentatively Ready and proposes to declare a
public default constructor, rather than the private one I added
recently.

* include/experimental/executor (service_already_exists): Make default
constructor public (LWG 3414).
* testsuite/experimental/net/execution_context/make_service.cc: Check
the service_already_exists can be default constructed.

4 years agocoroutines, testsuite: Add test for fixed pr [PR94288]
Iain Sandoe [Fri, 24 Apr 2020 08:17:06 +0000 (09:17 +0100)]
coroutines, testsuite: Add test for fixed pr [PR94288]

This is a version of the reproducer in the PR, usable on
multiple platforms.

4 years agointroduce target fileio and require it in tests that use tmpnam
Alexandre Oliva [Fri, 24 Apr 2020 11:32:10 +0000 (08:32 -0300)]
introduce target fileio and require it in tests that use tmpnam

Some target C libraries that aren't recognized as freestanding don't
have filesystem support, so calling tmpnam, fopen/open and
remove/unlink fails to link.

This patch introduces a fileio effective target to the testsuite, and
requires it in the tests that call tmpnam.

for  gcc/testsuite/ChangeLog

* lib/target-supports.exp (check_effective_target_fileio): New.
* gcc.c-torture/execute/fprintf-2.c: Require it.
* gcc.c-torture/execute/printf-2.c: Likewise.
* gcc.c-torture/execute/user-printf.c: Likewise.

4 years agoaarch64: Add an extra comment to arm_sve.h
Richard Sandiford [Fri, 24 Apr 2020 10:58:19 +0000 (11:58 +0100)]
aarch64: Add an extra comment to arm_sve.h

I've had a couple of conversations now in which the shortness
of arm_sve.h was causing confusion, with people thinking that
the types and intrinsics were missing.  It seems worth adding
a comment to explain what's going on.

2020-04-24  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/aarch64/arm_sve.h: Add a comment.

4 years agortl combine should consider NaNs when generate fp min/max [PR94708]
Haijian Zhang [Fri, 24 Apr 2020 00:56:25 +0000 (08:56 +0800)]
rtl combine should consider NaNs when generate fp min/max [PR94708]

    As discussed on PR94708, it's unsafe for rtl combine to generate fp
    min/max under -funsafe-math-optimizations, considering NaNs. In
    addition to flag_unsafe_math_optimizations check, we also need to
    do extra mode feature testing here: && !HONOR_NANS (mode)
    && !HONOR_SIGNED_ZEROS (mode)

    2020-04-24  Haijian Zhang <z.zhanghaijian@huawei.com>

    gcc/
PR rtl-optimization/94708
* combine.c (simplify_if_then_else): Add check for
!HONOR_NANS (mode) && !HONOR_SIGNED_ZEROS (mode).
    gcc/testsuite/
PR fortran/94708
* gfortran.dg/pr94708.f90: New test.

4 years agoRemove CHECKING_P in coroutines.cc for release checking.
Martin Liska [Fri, 24 Apr 2020 06:46:29 +0000 (08:46 +0200)]
Remove CHECKING_P in coroutines.cc for release checking.

* coroutines.cc: Fix compilation error for release checking
where we miss declaration of ‘coro_body_contains_bind_expr_p’.

4 years agogotest: increase the test timeout
eric fang [Mon, 20 Apr 2020 07:35:43 +0000 (07:35 +0000)]
gotest: increase the test timeout

The default test timeout duration of the gc compiler is 10 minutes,
and the current default timeout duration of gofrontend is 240 seconds,
which is not long enough for some big tests. This CL changes it to
600s, so that all tests have enough time to complete.

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/229657

4 years agotestsuite: Skip 90020.c on AIX.
David Edelsohn [Fri, 24 Apr 2020 02:54:07 +0000 (22:54 -0400)]
testsuite: Skip 90020.c on AIX.

Like HP/UX, AIX does not support undefined weak, so skip this test
in the testsuite.

* gcc.dg/torture/pr90020.c: Skip on AIX..

4 years agotestsuite: Require LTO support for pr94426-1.C
David Edelsohn [Fri, 24 Apr 2020 02:36:10 +0000 (22:36 -0400)]
testsuite: Require LTO support for pr94426-1.C

The testcase uses the -flto option but does not ensure that LTO support
is enabled. This patch adds the test to the testcase.

        * g++.dg/cpp0x/lambda/pr94426-1.C: Require LTO.

4 years agoDaily bump.
GCC Administrator [Fri, 24 Apr 2020 00:16:16 +0000 (00:16 +0000)]
Daily bump.

4 years agolibstdc++: Fix constructor constraints for std::any (PR 90415)
Jonathan Wakely [Thu, 23 Apr 2020 23:54:20 +0000 (00:54 +0100)]
libstdc++: Fix constructor constraints for std::any  (PR 90415)

This removes a non-standard extension to std::any which causes errors
for valid code, due to recursive instantiation of a trait that isn't
supposed to be in the constraints.

It also removes some incorrect constraints on the in_place_type<T>
constructors and emplace members, which were preventing creating a
std::any object with another std::any as the contained value.

2020-04-24  Kamlesh Kumar  <kamleshbhalui@gmail.com>
    Jonathan Wakely  <jwakely@redhat.com>

PR libstdc++/90415
PR libstdc++/92156
* include/std/any (any): Rename template parameters for consistency
with the standard.
(any::_Decay): Rename to _Decay_if_not_any.
(any::any(T&&):: Remove is_constructible from constraints. Remove
non-standard overload.
(any::any(in_place_type_t<T>, Args&&...))
(any::any(in_place_type_t<T>, initializer_list<U>, Args&&...))
(any::emplace(Args&&...))
(any::emplace(initializer_list<U>, Args&&...)):
Use decay_t instead of _Decay.
* testsuite/20_util/any/cons/90415.cc: New test.
* testsuite/20_util/any/cons/92156.cc: New Test.
* testsuite/20_util/any/misc/any_cast_neg.cc: Make dg-error directives
more robust.
* testsuite/20_util/any/modifiers/92156.cc: New test.

4 years agoPR driver/90983 - manual documents `-Wno-stack-usage` flag but it is unrecognized
Martin Sebor [Thu, 23 Apr 2020 23:49:01 +0000 (17:49 -0600)]
PR driver/90983 - manual documents `-Wno-stack-usage` flag but it is unrecognized

gcc/ChangeLog:

PR driver/90983
* common.opt (-Wno-frame-larger-than): New option.
(-Wno-larger-than, -Wno-stack-usage): Same.

gcc/testsuite/ChangeLog:

PR driver/90983
* gcc.dg/Wframe-larger-than-3.c: New test.
* gcc.dg/Wlarger-than4.c: New test.
* gcc.dg/Wstack-usage.c: New test.

4 years agoc++: zero_init_expr_p of dependent expression
Patrick Palka [Thu, 23 Apr 2020 21:26:46 +0000 (17:26 -0400)]
c++: zero_init_expr_p of dependent expression

This fixes an ICE coming from mangle.c:write_expression when building the
testsuite of range-v3; the added testcase is a reduced reproducer for the ICE.

gcc/cp/ChangeLog:

* tree.c (zero_init_expr_p): Use uses_template_parms instead of
dependent_type_p.

gcc/testsuite/ChangeLog:

* g++.dg/cpp0x/dependent3.C: New test.

4 years agoc++: Lambda in friend of constrained class [PR94645]
Patrick Palka [Thu, 23 Apr 2020 21:29:55 +0000 (17:29 -0400)]
c++: Lambda in friend of constrained class [PR94645]

In the testcase below, when grokfndecl processes the operator() decl for the
lambda inside the friend function foo, processing_template_decl is rightly 1,
but template_class_depth on the lambda's closure type incorrectly returns 0
instead of 1.

Since processing_template_decl > template_class_depth, this makes grokfndecl
think that the operator() has its own set of template arguments, and so we
attach the innermost set of constraints -- those belonging to struct l -- to the
operator() decl.  We then get confused when checking constraints_satisfied_p on
the operator() because it doesn't have template information and yet has
constraints associated with it.

This patch fixes template_class_depth to return the correct template nesting
level in cases like these, in that when it hits a friend function it walks into
the DECL_FRIEND_CONTEXT of the friend rather than into the CP_DECL_CONTEXT.

gcc/cp/ChangeLog:

PR c++/94645
* pt.c (template_class_depth): Walk into the DECL_FRIEND_CONTEXT of a
friend declaration rather than into its CP_DECL_CONTEXT.

gcc/testsuite/ChangeLog:

PR c++/94645
* g++.dg/cpp2a/concepts-lambda6.C: New test.

4 years agoamdgcn: Swap mov<mode>_exec operands
Andrew Stubbs [Thu, 26 Mar 2020 20:58:51 +0000 (20:58 +0000)]
amdgcn: Swap mov<mode>_exec operands

Every other *_exec insn has the exec operand last.  This being the other way
around is a cause of bugs, and prevents use in macro templates.

2020-04-23  Andrew Stubbs  <ams@codesourcery.com>

gcc/
* config/gcn/gcn-valu.md (mov<mode>_exec): Swap the numbers on operands
2 and 3.
(mov<mode>_exec): Likewise.
(trunc<vndi><mode>2_exec): Swap parameters to gen_mov<mode>_exec.
(<convop><mode><vndi>2_exec): Likewise.

4 years agolibstdc++: Mark experimental::net::system_context ctor deleted
Thomas Rodgers [Thu, 23 Apr 2020 20:42:46 +0000 (13:42 -0700)]
libstdc++: Mark experimental::net::system_context ctor deleted

           * include/experimental/net/executor (system_context): Mark
           system_context::system_context() = delete.
           * testsuite/experimental/net/executor/1.cc: Add new
           test to check system_context is not default constructible.

4 years agolibstdc++: Update C++20 library status docs
Jonathan Wakely [Thu, 23 Apr 2020 20:39:33 +0000 (21:39 +0100)]
libstdc++: Update C++20 library status docs

This reorganises the C++20 status table, grouping the proposals by
category. It also adds more proposals, and documents all the feature
test macros for C++20 library changes.

* doc/xml/manual/status_cxx2020.xml: Update C++20 status table.
* doc/html/*: Regenerate.

4 years agolibstdc++: Change __cpp_lib_array_constexpr for C++17 again
Jonathan Wakely [Thu, 23 Apr 2020 20:39:33 +0000 (21:39 +0100)]
libstdc++: Change __cpp_lib_array_constexpr for C++17 again

This partially reverts my previous change related to this macro. The
C++20 constexpr iterator requirements are always met by array:iterator,
because it's just a pointer. So the macro can be set to 201803 even in
C++17 mode.

* include/bits/stl_iterator.h (__cpp_lib_array_constexpr): Revert
value for C++17 to 201803L because P0858R0 is supported for C++17.
* include/std/version (__cpp_lib_array_constexpr): Likewise.
* testsuite/23_containers/array/element_access/constexpr_c++17.cc:
Check for value corresponding to P0031R0 features being tested.
* testsuite/23_containers/array/requirements/constexpr_iter.cc:
Check for value corresponding to P0858R0 features being tested.

4 years agolibstdc++: Define __cpp_lib_three_way_comparison for freestanding
Jonathan Wakely [Thu, 23 Apr 2020 20:39:33 +0000 (21:39 +0100)]
libstdc++: Define __cpp_lib_three_way_comparison for freestanding

The <compare> header is always supported, not only for hosted configs.

* include/std/version (__cpp_lib_three_way_comparison): Define for
freestanding builds.

4 years agoFix segfault with -O2 -fnon-call-exceptions -ftracer
Eric Botcazou [Thu, 23 Apr 2020 20:25:04 +0000 (22:25 +0200)]
Fix segfault with -O2 -fnon-call-exceptions -ftracer

The GIMPLE SSA store merging pass blows up when it is rewriting the
stores because it didn't realize that they don't belong to the same
EH region.  Fixed by refusing to merge them.

PR tree-optimization/94717
* gimple-ssa-store-merging.c (try_coalesce_bswap): Return false if
one of the stores doesn't have the same landing pad number as the
first.
(coalesce_immediate_stores): Do not try to coalesce the store using
bswap if it doesn't have the same landing pad number as the first.

4 years agors6000: Replace outdated link to ELFv2 ABI
Bill Schmidt [Thu, 23 Apr 2020 20:03:34 +0000 (15:03 -0500)]
rs6000: Replace outdated link to ELFv2 ABI

A user reported that we are still referring to a public review
draft of the ELFv2 ABI specification.  Replace that by a permalink.

2020-04-24  Bill Schmidt  <wschmidt@linux.ibm.com>

* gcc/doc/extend.texi (PowerPC AltiVec/VSX Built-in Functions):
Replace outdated link to ELFv2 ABI.

4 years agoShortcut identity VEC_PERM expansion [PR94710]
Jakub Jelinek [Thu, 23 Apr 2020 19:57:50 +0000 (21:57 +0200)]
Shortcut identity VEC_PERM expansion [PR94710]

This PR is about the rs6000 backend emitting wrong assembly
for whole vector shift by 0, and while I think it is desirable
to fix the backend, I don't see a point why the expander should
try to emit that, whole vector shift by 0 is identity, we can just
return the operand.

2020-04-23  Jakub Jelinek  <jakub@redhat.com>

PR target/94710
* optabs.c (expand_vec_perm_const): For shift_amt const0_rtx
just return v2.

4 years agocoroutines: Fix handling of conditional statements [PR94288]
Iain Sandoe [Thu, 23 Apr 2020 15:59:00 +0000 (16:59 +0100)]
coroutines: Fix handling of conditional statements [PR94288]

Normally, when we find a statement containing an await expression
this will be expanded to a statement list implementing the control
flow implied.  The expansion process successively replaces each
await expression in a statement with the result of its await_resume().

In the case of conditional statements (if, while, do, switch) the
expansion of the condition (or expression in the case of do-while)
cannot take place 'inline', leading to the PR.

The solution is to evaluate the expression separately, and to
transform while and do-while loops into endless loops with a break
on the required condition.

In fixing this, I realised that I'd also made a thinko in the case
of expanding truth-and/or-if expressions, where one arm of the
expression might need to be short-circuited.  The mechanism for
expanding via the tree walk will not work correctly in this case and
we need to pre-expand any truth-and/or-if with an await expression
on its conditionally-taken arm.  This applies to any statement with
truth-and/or-if expressions, so can be handled generically.

gcc/cp/ChangeLog:

2020-04-23  Iain Sandoe  <iain@sandoe.co.uk>

PR c++/94288
* coroutines.cc (await_statement_expander): Simplify cases.
(struct susp_frame_data): Add fields for truth and/or if
cases, rename one field.
(analyze_expression_awaits): New.
(expand_one_truth_if): New.
(add_var_to_bind): New helper.
(coro_build_add_if_not_cond_break): New helper.
(await_statement_walker): Handle conditional expressions,
handle expansion of truth-and/or-if cases.
(bind_expr_find_in_subtree): New, checking-only.
(coro_body_contains_bind_expr_p): New, checking-only.
(morph_fn_to_coro): Ensure that we have a top level bind
expression.

gcc/testsuite/ChangeLog:

2020-04-23  Iain Sandoe  <iain@sandoe.co.uk>

PR c++/94288
* g++.dg/coroutines/torture/co-await-18-if-cond.C: New test.
* g++.dg/coroutines/torture/co-await-19-while-cond.C: New test.
* g++.dg/coroutines/torture/co-await-20-do-while-cond.C: New test.
* g++.dg/coroutines/torture/co-await-21-switch-value.C: New test.
* g++.dg/coroutines/torture/co-await-22-truth-and-of-if.C: New test.
* g++.dg/coroutines/torture/co-ret-16-simple-control-flow.C: New test.

4 years agoc-family: Fix ICE on attribute with -fgnu-tm [PR94733]
Marek Polacek [Thu, 23 Apr 2020 18:38:58 +0000 (14:38 -0400)]
c-family: Fix ICE on attribute with -fgnu-tm [PR94733]

find_tm_attribute was using TREE_PURPOSE to get the attribute name,
which is breaking now that we preserve the C++11-style attribute
format past decl_attributes.  So use get_attribute_name which can
handle both formats of attributes.

PR c++/94733
* c-attribs.c (find_tm_attribute): Use get_attribute_name instead of
TREE_PURPOSE.

* g++.dg/tm/attrib-5.C: New test.

4 years agotree: Fix up get_narrower [PR94724]
Jakub Jelinek [Thu, 23 Apr 2020 19:11:36 +0000 (21:11 +0200)]
tree: Fix up get_narrower [PR94724]

In the recent get_narrower change, I wanted it to be efficient and avoid
recursion if there are many nested COMPOUND_EXPRs.  That builds the
COMPOUND_EXPR nest with the right arguments, but as build2_loc computes some
flags like TREE_SIDE_EFFECTS, TREE_CONSTANT and TREE_READONLY, when it
is called with something that will not be the argument in the end, those
flags are computed incorrectly.
So, this patch instead uses an auto_vec and builds them in the reverse order
so when they are built, they are built with the correct operands.

2020-04-23  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/94724
* tree.c (get_narrower): Instead of creating COMPOUND_EXPRs
temporarily with non-final second operand and updating it later,
push COMPOUND_EXPRs into a vector and process it in reverse,
creating COMPOUND_EXPRs with the final operands.

* gcc.c-torture/execute/pr94724.c: New test.

4 years agoFix PR 93956, wrong pointer when returned via function.
Thomas König [Thu, 23 Apr 2020 18:30:01 +0000 (20:30 +0200)]
Fix PR 93956, wrong pointer when returned via function.

This one took a bit of detective work.  When array pointers point
to components of derived types, we currently set the span field
and then create an array temporary when we pass the array
pointer to a procedure as a non-pointer or non-target argument.
(This is inefficient, but that's for another release).

Now, the compiler detected this case when there was a direct assignment
like p => a%b, but not when p was returned either as a function result
or via an argument.  This patch fixes that.

2020-04-23  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/93956
* expr.c (gfc_check_pointer_assign): Also set subref_array_pointer
when a function returns a pointer.
* interface.c (gfc_set_subref_array_pointer_arg): New function.
(gfc_procedure_use): Call it.

2020-04-23  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/93956
* gfortran.dg/pointer_assign_13.f90: New test.

4 years agocoroutines, libstdc++-v3: Update to n4861 C++20 DIS.
Iain Sandoe [Thu, 23 Apr 2020 14:36:29 +0000 (15:36 +0100)]
coroutines, libstdc++-v3: Update to n4861 C++20 DIS.

Update the inline namespace to __n4861.
Add '__cpp_lib_coroutine' defined to 201902L per n4861.

libstdc++-v3/ChangeLog:

2020-04-23  Iain Sandoe  <iain@sandoe.co.uk>

* include/std/coroutine: Update the inline namespace to __n4861.
Add the __cpp_lib_coroutine define, set to 201902L.
* include/std/version: Add __cpp_lib_coroutine, set to 201902L.

gcc/testsuite/ChangeLog:

2020-04-23  Iain Sandoe  <iain@sandoe.co.uk>

* g++.dg/coroutines/coro-bad-alloc-00-bad-op-new.C: Adjust for
changed inline namespace.
* g++.dg/coroutines/coro-bad-alloc-01-bad-op-del.C: Likewise.
* g++.dg/coroutines/coro-bad-alloc-02-no-op-new-nt.C: Likewise
* g++.dg/coroutines/coro.h: Likewise

4 years agoaarch64: ensure bti c is emitted at function start [PR94697]
Szabolcs Nagy [Fri, 17 Apr 2020 15:54:12 +0000 (16:54 +0100)]
aarch64: ensure bti c is emitted at function start [PR94697]

The bti pass currently first emits bti c at function start
if there is no paciasp (which also acts as indirect call
landing pad), then bti j is emitted at jump labels, however
if there is a label right before paciasp then the function
start can end up like

  foo:
  label:
    bti j
    paciasp
    ...

This patch is a minimal fix that just moves the bti c handling
after the bti j handling so we end up with

  foo:
    bti c
  label:
    bti j
    paciasp
    ...

This could be improved by emitting bti jc in this case, or by
detecting that the label is not in fact an indirect jump target
and then this situation would be much less common.

Needs to be backported to gcc-9 branch.

gcc/ChangeLog:

PR target/94697
* config/aarch64/aarch64-bti-insert.c (rest_of_insert_bti): Swap
bti c and bti j handling.

gcc/testsuite/ChangeLog:

PR target/94697
* gcc.target/aarch64/pr94697.c: New test.

4 years agotestsuite: Add extra aarch64 predefine tests
Fei Yang [Thu, 23 Apr 2020 15:08:03 +0000 (16:08 +0100)]
testsuite: Add extra aarch64 predefine tests

Add extra testing in the following two tests to make sure CPP predefines
redefinitions on #pragma works as expected when -mgeneral-regs-only
option is specified (See PR94678):
gcc.target/aarch64/pragma_cpp_predefs_2.c
gcc.target/aarch64/pragma_cpp_predefs_3.c

2020-04-23  Felix Yang  <felix.yang@huawei.com>

gcc/testsuite/
PR target/94678
* gcc.target/aarch64/pragma_cpp_predefs_2.c: Fix typos, pop_pragma ->
pop_options. Add tests for general-regs-only.
* gcc.target/aarch64/pragma_cpp_predefs_3.c: Add tests for
general-regs-only.

4 years agoOpenACC: Avoid ICE in type-cast 'async', 'wait' clauses
Andrew Stubbs [Thu, 30 Jan 2020 18:25:15 +0000 (18:25 +0000)]
OpenACC: Avoid ICE in type-cast 'async', 'wait' clauses

2020-04-23  Andrew Stubbs  <ams@codesourcery.com>
    Thomas Schwinge  <thomas@codesourcery.com>

PR middle-end/93488

gcc/
* omp-expand.c (expand_omp_target): Use force_gimple_operand_gsi on
t_async and the wait arguments.

gcc/testsuite/
* c-c++-common/goacc/pr93488.c: New file.

Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
4 years agovect: Fix comparisons between invariant booleans [PR94727]
Richard Sandiford [Thu, 23 Apr 2020 14:45:43 +0000 (15:45 +0100)]
vect: Fix comparisons between invariant booleans [PR94727]

This PR was caused by mismatched expectations between
vectorizable_comparison and SLP.  We had a "<" comparison
between two booleans that were leaves of the SLP tree, so
vectorizable_comparison fell back on:

  /* Invariant comparison.  */
  if (!vectype)
    {
      vectype = get_vectype_for_scalar_type (vinfo, TREE_TYPE (rhs1),
                                             slp_node);
      if (maybe_ne (TYPE_VECTOR_SUBPARTS (vectype), nunits))
        return false;
    }

rhs1 and rhs2 were *unsigned* boolean types, so we got back a vector
of unsigned integers.  This in itself was OK, and meant that "<"
worked as expected without the need for the boolean fix-ups:

  /* Boolean values may have another representation in vectors
     and therefore we prefer bit operations over comparison for
     them (which also works for scalar masks).  We store opcodes
     to use in bitop1 and bitop2.  Statement is vectorized as
       BITOP2 (rhs1 BITOP1 rhs2) or
       rhs1 BITOP2 (BITOP1 rhs2)
     depending on bitop1 and bitop2 arity.  */
  bool swap_p = false;
  if (VECTOR_BOOLEAN_TYPE_P (vectype))
    {

However, vectorizable_comparison then used vect_get_slp_defs to get
the actual operands.  The request went to vect_get_constant_vectors,
which also has logic to calculate the vector type.  The problem was
that this type was different from the one chosen above:

  if (VECT_SCALAR_BOOLEAN_TYPE_P (TREE_TYPE (op))
      && vect_mask_constant_operand_p (stmt_vinfo))
    vector_type = truth_type_for (stmt_vectype);
  else
    vector_type = get_vectype_for_scalar_type (vinfo, TREE_TYPE (op), op_node);

So the function gave back a vector of mask types, which here are vectors
of *signed* booleans.  This meant that "<" gave:

  true (-1) < false (0)

and so the boolean fixup above was needed after all.

Fixed by making vectorizable_comparison also pick a mask type in
this case.

2020-04-23  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR tree-optimization/94727
* tree-vect-stmts.c (vectorizable_comparison): Use mask_type when
comparing invariant scalar booleans.

gcc/testsuite/
PR tree-optimization/94727
* gcc.dg/vect/pr94727.c: New test.

4 years ago[AArch64] (PR94383) Avoid C++17 empty base field checking for HVA/HFA
Matthew Malcomson [Thu, 23 Apr 2020 14:33:55 +0000 (15:33 +0100)]
[AArch64] (PR94383) Avoid C++17 empty base field checking for HVA/HFA

In C++17, an empty class deriving from an empty base is not an
aggregate, while in C++14 it is.  In order to implement this, GCC adds
an artificial field to such classes.

This artificial field has no mapping to Fundamental Data Types in the
AArch64 PCS ABI and hence should not count towards determining whether an
object can be passed using the vector registers as per section
"6.4.2 Parameter Passing Rules" in the AArch64 PCS.
https://github.com/ARM-software/abi-aa/blob/master/aapcs64/aapcs64.rst#the-base-procedure-call-standard

This patch avoids counting this artificial field in
aapcs_vfp_sub_candidate, and hence calculates whether such objects
should be passed in vector registers in the same manner as C++14 (where
the artificial field does not exist).

Before this change, the test below would pass the arguments to `f` in
general registers.  After this change, the test passes the arguments to
`f` using the vector registers.

The new behaviour matches the behaviour of `armclang`, and also matches
the behaviour when run with `-std=gnu++14`.

> gcc -std=gnu++17 test.cpp

``` test.cpp
struct base {};

struct pair : base
{
  float first;
  float second;
  pair (float f, float s) : first(f), second(s) {}
};

void f (pair);
int main()
{
  f({3.14, 666});
  return 1;
}
```

We add a `-Wpsabi` warning to catch cases where this fix has changed the ABI for
some functions.  Unfortunately this warning is not emitted twice for multiple
calls to the same function, but I feel this is not much of a problem and can be
fixed later if needs be.

(i.e. if `main` called `f` twice in a row we only emit a diagnostic for the
first).

Testing:
    Bootstrap and regression test on aarch64-linux.
    All struct-layout-1 tests now pass.

gcc/ChangeLog:

2020-04-23  Matthew Malcomson  <matthew.malcomson@arm.com>
    Jakub Jelinek  <jakub@redhat.com>

PR target/94383
* config/aarch64/aarch64.c (aapcs_vfp_sub_candidate): Account for C++17
empty base class artificial fields.
(aarch64_vfp_is_call_or_return_candidate): Warn when ABI PCS decision is
different after this fix.

4 years agoProtect the trigd functions in libgfortran from unavailable math functions.
Fritz Reese [Wed, 22 Apr 2020 15:45:22 +0000 (11:45 -0400)]
Protect the trigd functions in libgfortran from unavailable math functions.

libgfortran/ChangeLog:

2020-04-22  Fritz Reese  <foreese@gcc.gnu.org>

PR libfortran/94694
PR libfortran/94586
* intrinsics/trigd.c, intrinsics/trigd_lib.inc, intrinsics/trigd.inc:
Guard against unavailable math functions.
Use suffixes from kinds.h based on the REAL kind.

gcc/fortran/ChangeLog:

2020-04-22  Fritz Reese  <foreese@gcc.gnu.org>

* trigd_fe.inc: Use mpfr to compute cosd(30) rather than a host-
precision floating point literal based on an invalid macro.

4 years agoamdgcn: Check HSA return codes [PR94629]
Andrew Stubbs [Mon, 20 Apr 2020 14:25:31 +0000 (15:25 +0100)]
amdgcn: Check HSA return codes [PR94629]

Ensure that the returned status values are not ignored.  The old code was
not broken, but this is both safer and satisfies static analysis.

2020-04-23  Andrew Stubbs  <ams@codesourcery.com>

PR other/94629

libgomp/
* plugin/plugin-gcn.c (init_hsa_context): Check return value from
hsa_iterate_agents.
(GOMP_OFFLOAD_init_device): Check return values from both calls to
hsa_agent_iterate_regions.

4 years agoaarch64: disable tests on ilp32 [PR94514]
Szabolcs Nagy [Thu, 23 Apr 2020 10:26:10 +0000 (11:26 +0100)]
aarch64: disable tests on ilp32 [PR94514]

branch-protection=pac-ret is only supported with lp64 abi.

gcc/testsuite/ChangeLog:

PR target/94514
* g++.target/aarch64/pr94514.C: Require lp64.
* gcc.target/aarch64/pr94514.c: Likewise.

4 years agors6000: Small improvement to the C++17 ABI fix [PR94707]
Jakub Jelinek [Thu, 23 Apr 2020 12:43:18 +0000 (14:43 +0200)]
rs6000: Small improvement to the C++17 ABI fix [PR94707]

Anyway, based on IRC discussion with Richard Sandiford on IRC, we should
probably test type uids instead of type pointers because type uids aren't
reused, but type pointers in a very bad luck case could be, and having the
static var at filescope and GTY((deletable)) is an overkill (and with costs
during GC time).

2020-04-23  Jakub Jelinek  <jakub@redhat.com>

PR target/94707
* config/rs6000/rs6000-call.c (rs6000_discover_homogeneous_aggregate):
Use TYPE_UID (TYPE_MAIN_VARIANT (type)) instead of type to check
if the same type has been diagnosed most recently already.

4 years agoModify the MVE polymorphic variant arguments to match the MVE intrinsic definition.
Srinath Parvathaneni [Thu, 23 Apr 2020 09:53:59 +0000 (10:53 +0100)]
Modify the MVE polymorphic variant arguments to match the MVE intrinsic definition.

When MVE intrinsic's are called, few implicit typecasting are done on the formal arguments to match the intrinsic parameters.
But when same intrinsics are called through MVE polymorphic variants, _Generic feature used here does strict type checking and fails to match the exact intrinsic.
This patch corrects the behaviour of polymorphic variants and match the expected intrinsic by explicitly typecasting the polymorphic variant's arguments.

Please refer to M-profile Vector Extension (MVE) intrinsics [1]  for more details.
[1] https://developer.arm.com/architectures/instruction-sets/simd-isas/helium/mve-intrinsics

Regression tested on arm-none-eabi and found no regressions.

Ok for trunk?

Thanks,
Srinath.

gcc/ChangeLog:

2020-04-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

* config/arm/arm_mve.h (__arm_vbicq_n_u16): Modify function parameter's
datatype.
(__arm_vbicq_n_s16): Likewise.
(__arm_vbicq_n_u32): Likewise.
(__arm_vbicq_n_s32): Likewise.
(__arm_vbicq): Likewise.
(__arm_vbicq_n_s16): Modify MVE polymorphic variant argument's datatype.
(__arm_vbicq_n_s32): Likewise.
(__arm_vbicq_n_u16): Likewise.
(__arm_vbicq_n_u32): Likewise.
(__arm_vdupq_m_n_s8): Likewise.
(__arm_vdupq_m_n_s16): Likewise.
(__arm_vdupq_m_n_s32): Likewise.
(__arm_vdupq_m_n_u8): Likewise.
(__arm_vdupq_m_n_u16): Likewise.
(__arm_vdupq_m_n_u32): Likewise.
(__arm_vdupq_m_n_f16): Likewise.
(__arm_vdupq_m_n_f32): Likewise.
(__arm_vldrhq_gather_offset_s16): Likewise.
(__arm_vldrhq_gather_offset_s32): Likewise.
(__arm_vldrhq_gather_offset_u16): Likewise.
(__arm_vldrhq_gather_offset_u32): Likewise.
(__arm_vldrhq_gather_offset_f16): Likewise.
(__arm_vldrhq_gather_offset_z_s16): Likewise.
(__arm_vldrhq_gather_offset_z_s32): Likewise.
(__arm_vldrhq_gather_offset_z_u16): Likewise.
(__arm_vldrhq_gather_offset_z_u32): Likewise.
(__arm_vldrhq_gather_offset_z_f16): Likewise.
(__arm_vldrhq_gather_shifted_offset_s16): Likewise.
(__arm_vldrhq_gather_shifted_offset_s32): Likewise.
(__arm_vldrhq_gather_shifted_offset_u16): Likewise.
(__arm_vldrhq_gather_shifted_offset_u32): Likewise.
(__arm_vldrhq_gather_shifted_offset_f16): Likewise.
(__arm_vldrhq_gather_shifted_offset_z_s16): Likewise.
(__arm_vldrhq_gather_shifted_offset_z_s32): Likewise.
(__arm_vldrhq_gather_shifted_offset_z_u16): Likewise.
(__arm_vldrhq_gather_shifted_offset_z_u32): Likewise.
(__arm_vldrhq_gather_shifted_offset_z_f16): Likewise.
(__arm_vldrwq_gather_offset_s32): Likewise.
(__arm_vldrwq_gather_offset_u32): Likewise.
(__arm_vldrwq_gather_offset_f32): Likewise.
(__arm_vldrwq_gather_offset_z_s32): Likewise.
(__arm_vldrwq_gather_offset_z_u32): Likewise.
(__arm_vldrwq_gather_offset_z_f32): Likewise.
(__arm_vldrwq_gather_shifted_offset_s32): Likewise.
(__arm_vldrwq_gather_shifted_offset_u32): Likewise.
(__arm_vldrwq_gather_shifted_offset_f32): Likewise.
(__arm_vldrwq_gather_shifted_offset_z_s32): Likewise.
(__arm_vldrwq_gather_shifted_offset_z_u32): Likewise.
(__arm_vldrwq_gather_shifted_offset_z_f32): Likewise.
(__arm_vdwdupq_x_n_u8): Likewise.
(__arm_vdwdupq_x_n_u16): Likewise.
(__arm_vdwdupq_x_n_u32): Likewise.
(__arm_viwdupq_x_n_u8): Likewise.
(__arm_viwdupq_x_n_u16): Likewise.
(__arm_viwdupq_x_n_u32): Likewise.
(__arm_vidupq_x_n_u8): Likewise.
(__arm_vddupq_x_n_u8): Likewise.
(__arm_vidupq_x_n_u16): Likewise.
(__arm_vddupq_x_n_u16): Likewise.
(__arm_vidupq_x_n_u32): Likewise.
(__arm_vddupq_x_n_u32): Likewise.
(__arm_vldrdq_gather_offset_s64): Likewise.
(__arm_vldrdq_gather_offset_u64): Likewise.
(__arm_vldrdq_gather_offset_z_s64): Likewise.
(__arm_vldrdq_gather_offset_z_u64): Likewise.
(__arm_vldrdq_gather_shifted_offset_s64): Likewise.
(__arm_vldrdq_gather_shifted_offset_u64): Likewise.
(__arm_vldrdq_gather_shifted_offset_z_s64): Likewise.
(__arm_vldrdq_gather_shifted_offset_z_u64): Likewise.
(__arm_vidupq_m_n_u8): Likewise.
(__arm_vidupq_m_n_u16): Likewise.
(__arm_vidupq_m_n_u32): Likewise.
(__arm_vddupq_m_n_u8): Likewise.
(__arm_vddupq_m_n_u16): Likewise.
(__arm_vddupq_m_n_u32): Likewise.
(__arm_vidupq_n_u16): Likewise.
(__arm_vidupq_n_u32): Likewise.
(__arm_vidupq_n_u8): Likewise.
(__arm_vddupq_n_u16): Likewise.
(__arm_vddupq_n_u32): Likewise.
(__arm_vddupq_n_u8): Likewise.

gcc/testsuite/ChangeLog:

2020-04-23  Srinath Parvathaneni  <srinath.parvathaneni@arm.com>

* gcc.target/arm/mve/intrinsics/mve_vddupq_m_n_u16.c: New test.
* gcc.target/arm/mve/intrinsics/mve_vddupq_m_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_m_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_x_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_x_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vddupq_x_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vdwdupq_x_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vdwdupq_x_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vdwdupq_x_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_m_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_m_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_m_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_x_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_x_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vidupq_x_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_viwdupq_x_n_u16.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_viwdupq_x_n_u32.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_viwdupq_x_n_u8.c: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_offset_s64.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_offset_u64.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_offset_z_s64.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_offset_z_u64.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_shifted_offset_s64.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_shifted_offset_u64.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_shifted_offset_z_s64.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrdq_gather_shifted_offset_z_u64.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_f16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_s16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_s32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_u16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_u32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_z_f16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_z_s16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_z_s32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_z_u16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_offset_z_u32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_f16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_s16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_s32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_u16.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_u32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_z_f16.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_z_s16.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_z_s32.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_z_u16.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrhq_gather_shifted_offset_z_u32.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_offset_f32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_offset_s32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_offset_u32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_offset_z_f32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_offset_z_s32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_offset_z_u32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_shifted_offset_f32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_shifted_offset_s32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_shifted_offset_u32.c:
Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_shifted_offset_z_f32.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_shifted_offset_z_s32.c
: Likewise.
* gcc.target/arm/mve/intrinsics/mve_vldrwq_gather_shifted_offset_z_u32.c
: Likewise.

4 years agodoc: Document all D-specific configuration options.
Iain Buclaw [Thu, 23 Apr 2020 08:02:46 +0000 (10:02 +0200)]
doc: Document all D-specific configuration options.

gcc/ChangeLog:

* doc/install.texi (D-Specific Options): Document
--enable-libphobos-checking and --with-libphobos-druntime-only.

4 years agors6000: Fix C++14 vs. C++17 ABI bug on powerpc64le [PR94707]
Jakub Jelinek [Thu, 23 Apr 2020 07:59:57 +0000 (09:59 +0200)]
rs6000: Fix C++14 vs. C++17 ABI bug on powerpc64le [PR94707]

As mentioned in the PR and on IRC, the recently added struct-layout-1.exp
new tests FAIL on powerpc64le-linux (among other targets).
FAIL: tmpdir-g++.dg-struct-layout-1/t032 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t058 cp_compat_x_tst.o-cp_compat_y_tst.o execute
FAIL: tmpdir-g++.dg-struct-layout-1/t059 cp_compat_x_tst.o-cp_compat_y_tst.o execute
in particular.  The problem is that the presence or absence of the C++17
artificial empty base fields, which have non-zero TYPE_SIZE, but zero
DECL_SIZE, change the ABI decisions, if it is present (-std=c++17), the type
might not be considered homogeneous, while if it is absent (-std=c++14), it
can be.

The following patch fixes that and emits a -Wpsabi inform; perhaps more
often than it could, because the fact that rs6000_discover_homogeneous_aggregate
returns true when it didn't in in GCC 7/8/9 with -std=c++17 doesn't still
mean it will make a different ABI decision, but the warning triggered only
on the test I've changed (the struct-layout-1.exp tests use -w -Wno-psabi
already).

2020-04-23  Jakub Jelinek  <jakub@redhat.com>

PR target/94707
* config/rs6000/rs6000-call.c (rs6000_aggregate_candidate): Add
cxx17_empty_base_seen argument.  Pass it to recursive calls.
Ignore cxx17_empty_base_field_p fields after setting
*cxx17_empty_base_seen to true.
(rs6000_discover_homogeneous_aggregate): Adjust
rs6000_aggregate_candidate caller.  With -Wpsabi, diagnose homogeneous
aggregates with C++17 empty base fields.

* g++.dg/tree-ssa/pr27830.C: Use -Wpsabi -w for -std=c++17 and higher.

4 years agoattribs: Don't diagnose attribute exclusions during error recovery [PR94705]
Jakub Jelinek [Thu, 23 Apr 2020 07:54:14 +0000 (09:54 +0200)]
attribs: Don't diagnose attribute exclusions during error recovery [PR94705]

On the following testcase GCC ICEs, because last_decl is error_mark_node,
and diag_attr_exclusions assumes that if it is not NULL, it must be a decl.

The following patch just doesn't diagnose attribute exclusions if the
other decl is erroneous (and thus we've already reported errors for it).

2020-04-23  Jakub Jelinek  <jakub@redhat.com>

PR c/94705
* attribs.c (decl_attribute): Don't diagnose attribute exclusions
if last_decl is error_mark_node or has such a TREE_TYPE.

* gcc.dg/pr94705.c: New test.

4 years agoDaily bump.
GCC Administrator [Thu, 23 Apr 2020 00:16:19 +0000 (00:16 +0000)]
Daily bump.

4 years agoc++: Change -Weffc++ diagnostic to use "declare" (PR 94698)
Jonathan Wakely [Wed, 22 Apr 2020 22:18:06 +0000 (23:18 +0100)]
c++: Change -Weffc++ diagnostic to use "declare" (PR 94698)

Change the wording again, for the reasons given by Jason in
https://gcc.gnu.org/pipermail/gcc-patches/2020-April/544362.html

PR translation/94698
* class.c (check_field_decls): Change "define" to "declare" in
-Weffc++ diagnostics.

4 years agolibstdc++: Define __cpp_lib_execution feature test macro
Jonathan Wakely [Wed, 22 Apr 2020 21:54:35 +0000 (22:54 +0100)]
libstdc++: Define __cpp_lib_execution feature test macro

This macro has never been defined by libstdc++, despite supporting the
parallel algorithms. It should have a different value for C++17 and
C++20, because P1001R2 should not be supported in C++17, but
unsequenced_policy is defined for C++17 (see PR p4702).

* include/std/execution (__cpp_lib_execution): Define to indicate
support for P0024R2 and P1001R2.
* include/std/version (__cpp_lib_execution): Define.
* testsuite/25_algorithms/pstl/feature_test.cc: Only test macro
defined by <algorithm>, move other tests to new tests ...
* testsuite/25_algorithms/pstl/feature_test-2.cc: New test.
* testsuite/25_algorithms/pstl/feature_test-3.cc: New test.
* testsuite/25_algorithms/pstl/feature_test-4.cc: New test.
* testsuite/25_algorithms/pstl/feature_test-5.cc: New test.

4 years agolibstdc++: Update (and revert) value of __cpp_lib_array_constexpr
Jonathan Wakely [Wed, 22 Apr 2020 21:54:35 +0000 (22:54 +0100)]
libstdc++: Update (and revert) value of __cpp_lib_array_constexpr

This macro should have been updated to 201811 when the last C++20
changes were implemented. However those changes are not enabled for
C++17 mode, so the macro should only have the new value in C++20 mode.

This change ensures that the macro is defined to 201603 for C++17 and
201811 for C++20.

* include/bits/stl_iterator.h (__cpp_lib_array_constexpr): Define
different values for C++17 and C++20, to indicate different feature
sets. Update value for C++20 to indicate P1032R1 support.
* include/std/version (__cpp_lib_array_constexpr): Likewise.
* testsuite/23_containers/array/comparison_operators/constexpr.cc:
Check feature test macro.
* testsuite/23_containers/array/element_access/constexpr_c++17.cc:
New test.
* testsuite/23_containers/array/requirements/constexpr_fill.cc: Check
feature test macro.
* testsuite/23_containers/array/requirements/constexpr_iter.cc: Test
in C++17 mode and check feature test macro.

4 years agolibstdc++: Do not define __cpp_lib_constexpr_algorithms in <utility>
Jonathan Wakely [Wed, 22 Apr 2020 21:54:35 +0000 (22:54 +0100)]
libstdc++: Do not define __cpp_lib_constexpr_algorithms in <utility>

The C++20 draft and SD-6 both say this should only be in <version> and
<algorithm>, not in <utility>.

* include/std/utility (__cpp_lib_constexpr_algorithms): Do not define
here.
* testsuite/20_util/exchange/constexpr.cc: Do not expect macro to be
defined by <utility>.

4 years agolibstdc++: Update __cpp_lib_concepts value
Jonathan Wakely [Wed, 22 Apr 2020 21:54:34 +0000 (22:54 +0100)]
libstdc++: Update __cpp_lib_concepts value

* include/std/functional (__cpp_lib_concepts): Update macro value to
indicate P1964R2 support.
* include/std/version (__cpp_lib_concepts): Likewise.
* testsuite/std/concepts/1.cc: Adjust expected value.
* testsuite/std/concepts/2.cc: Likewise.

4 years agolibstdc++: Rename __cpp_lib_constexpr_invoke macro
Jonathan Wakely [Wed, 22 Apr 2020 21:54:34 +0000 (22:54 +0100)]
libstdc++: Rename __cpp_lib_constexpr_invoke macro

This macro was renamed after it was added to the working draft, but we
never renamed it  in libstdc++. We haven't made a release with the old
macro name, so I see no need to keep it around.

* include/std/functional (__cpp_lib_constexpr_invoke): Rename to
__cpp_lib_constexpr_functional.
* include/std/version (__cpp_lib_constexpr_invoke): Likewise.
* testsuite/20_util/function_objects/invoke/constexpr.cc: Adjust.

4 years agolibstdc++: Add missing feature test macros
Jonathan Wakely [Wed, 22 Apr 2020 21:54:34 +0000 (22:54 +0100)]
libstdc++: Add missing feature test macros

These macros all correspond to features that are already supported, but
the macro was not defined when the feature was implemented.

* include/bits/ptr_traits.h (__cpp_lib_constexpr_memory): Define to
indicate P1006R1 support.
(__cpp_lib_to_address): Define to indicate P0653R2 support.
* include/bits/range_access.h (__cpp_lib_ssize): Define to indicate
P1227R2 support.
* include/bits/ranges_algo.h (__cpp_lib_shift): Define to indicate
P0769R2 support.
* include/std/atomic (__cpp_lib_atomic_float): Define to indicate
P0020R6 support.
* include/std/memory (__cpp_lib_assume_aligned): Define to indicate
P1007R3 support.
* include/std/memory_resource (__cpp_lib_polymorphic_allocator):
Define to indicate P0339R6 support.
* include/std/string_view (__cpp_lib_starts_ends_with): Define to
indicate P0457R2 support.
* include/std/type_traits (__cpp_lib_is_nothrow_convertible): Define
to indicate P0758R1 support.
(__cpp_lib_remove_cvref): Define to indicate P0550R2 support.
(__cpp_lib_type_identity): Define to indicate P0887R1 support.
* include/std/version (__cpp_lib_atomic_float)
(__cpp_lib_is_nothrow_convertible, __cpp_lib_remove_cvref)
(__cpp_lib_type_identity, __cpp_lib_assume_aligned)
(__cpp_lib_constexpr_memory, __cpp_lib_polymorphic_allocator)
(__cpp_lib_shift, __cpp_lib_ssize, __cpp_lib_starts_ends_with)
(__cpp_lib_to_address): Define.
* testsuite/20_util/to_address/1_neg.cc: Adjust dg-error line number.

4 years agolibstdc++: Remove non-standard feature test macros
Jonathan Wakely [Wed, 22 Apr 2020 21:54:34 +0000 (22:54 +0100)]
libstdc++: Remove non-standard feature test macros

These macros were replaced by __cpp_lib_map_try_emplace and
__cpp_lib_unordered_map_try_emplace, because those names are more
descriptive. We've kept both old and new names so far, but I think we
can remove the old ones now.

* include/bits/stl_map.h (__cpp_lib_map_insertion): Remove old
macro.
* include/bits/unordered_map.h (__cpp_lib_unordered_map_insertion):
Likewise.
* include/std/version (__cpp_lib_map_insertion)
(__cpp_lib_unordered_map_insertion): Remove.