gcc.git
5 years ago[Ada] GNAT.Sockets: fix timeout computations for sockets
Dmitriy Anisimkov [Tue, 11 Dec 2018 11:10:53 +0000 (11:10 +0000)]
[Ada] GNAT.Sockets: fix timeout computations for sockets

2018-12-11  Dmitriy Anisimkov  <anisimko@adacore.com>

gcc/ada/

* libgnat/g-socket.ads, libgnat/g-socket.adb: Fix duration
computations to be compatible with the type for socket timeouts
on Windows.

From-SVN: r266998

5 years ago[Ada] Minor reformattings
Gary Dismukes [Tue, 11 Dec 2018 11:10:48 +0000 (11:10 +0000)]
[Ada] Minor reformattings

2018-12-11  Gary Dismukes  <dismukes@adacore.com>

gcc/ada/

* exp_util.ads: Use preferred U.S. spelling of "honored".
* sem_spark.adb: Remove extra whitespace.

From-SVN: r266997

5 years ago[Ada] Crash on ignored Ghost expression function
Hristian Kirtchev [Tue, 11 Dec 2018 11:10:42 +0000 (11:10 +0000)]
[Ada] Crash on ignored Ghost expression function

This patch updates freezing to ensure that freeze nodes are inserted
into the tree when the entity being frozen is non-Ghost, and the context
is an ignored Ghost spec expression.

2018-12-11  Hristian Kirtchev  <kirtchev@adacore.com>

gcc/ada/

* exp_util.adb (Insert_Action): Add new formal parameter
Spec_Expr_OK.
(Insert_Actions): Add new formal parameter Spec_Expr_OK. Update
all calls to Insert_Actions where relevant. Honour an insertion
from a spec expression context when requested by the caller.
* exp_util.ads (Insert_Action): Add new formal parameter
Spec_Expr_OK.
(Insert_Actions): Add new formal parameter Spec_Expr_OK.
* freeze.adb (Add_To_Result): Force the insertion of the freeze
node even when the context is a spec expression.

gcc/testsuite/

* gnat.dg/ghost2.adb, gnat.dg/ghost2.ads: New testcase.

From-SVN: r266996

5 years ago[Ada] Remove vxlink and vxaddr2line from this repository
Jerome Lambourg [Tue, 11 Dec 2018 11:10:37 +0000 (11:10 +0000)]
[Ada] Remove vxlink and vxaddr2line from this repository

Those tools need a dedicated repository as they're VxWorks specific and
not related with the Ada front-end.

2018-12-11  Jerome Lambourg  <lambourg@adacore.com>

gcc/ada/

* vxaddr2line.adb, vxlink-bind.adb, vxlink-bind.ads,
vxlink-link.adb, vxlink-link.ads, vxlink-main.adb, vxlink.adb,
vxlink.ads: Remove.
* gcc-interface/Make-lang.in, gcc-interface/Makefile.in: Remove
bits for vxaddr2line.

From-SVN: r266995

5 years ago[Ada] Minor reformatting
Hristian Kirtchev [Tue, 11 Dec 2018 11:10:32 +0000 (11:10 +0000)]
[Ada] Minor reformatting

2018-12-11  Hristian Kirtchev  <kirtchev@adacore.com>

gcc/ada/

* exp_aggr.adb, exp_ch7.adb, gnat1drv.adb, sem_ch10.adb,
sem_ch13.adb, sem_ch6.adb, sem_ch7.adb, sem_util.adb: Minor
reformatting.

From-SVN: r266994

5 years ago[Ada] Complete implementation of RM C.6(19) clause
Eric Botcazou [Tue, 11 Dec 2018 11:10:27 +0000 (11:10 +0000)]
[Ada] Complete implementation of RM C.6(19) clause

This ensures that the compiler fully implements the C.6(19) clause of
the Ada Reference Manual and gives a warning when the clause does change
the passing mechanism of the affected parameter.

2018-12-11  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* fe.h (Is_Atomic_Object): Declare.
(Is_Volatile_Object): Likewise.
* gcc-interface/trans.c (atomic_or_volatile_copy_required_p):
New.
(Call_to_gnu): Generate a copy for an actual parameter passed by
reference if the conditions set forth by RM C.6(19) are met and
specificially deal with an atomic actual parameter.

gcc/testsuite/

* gnat.dg/atomic11.adb, gnat.dg/atomic11_pkg1.ads,
gnat.dg/atomic11_pkg2.ads: New testcase.

From-SVN: r266993

5 years ago[Ada] Stubs that complete generic subprogram do have a "prior declaration"
Piotr Trojanek [Tue, 11 Dec 2018 11:10:22 +0000 (11:10 +0000)]
[Ada] Stubs that complete generic subprogram do have a "prior declaration"

The intuition behind the Is_Subprogram_Stub_Without_Prior_Declaration
utility routine is to detect stubs that act as subprogram declarations
and False on stubs that act as completions. This behaviour is now fixed
for stubs that correspond to generic subprogram declarations.

This patch affects a routine that is only used in GNATprove, so no
frontend test provided. An example where the result changed from True to
False is:

-----------
-- p.ads --
-----------

package P is
   generic
   procedure Proc;
end P;

-----------
-- p.adb --
-----------

package body P is
   procedure Proc is separate; -- now we return False for this stub
end P;

----------------
-- p-proc.adb --
----------------

separate (P)
procedure Proc is
begin
   null;
end;

2018-12-11  Piotr Trojanek  <trojanek@adacore.com>

gcc/ada/

* sem_util.adb (Is_Subprogram_Stub_Without_Prior_Declaration):
Return False on stubs that complete a generic subprogram.
* sem_util.ads: Update corresponding comment.

From-SVN: r266992

5 years ago[Ada] GNATprove: improve proofs for uninitialized constrained objects
Ed Schonberg [Tue, 11 Dec 2018 11:10:17 +0000 (11:10 +0000)]
[Ada] GNATprove: improve proofs for uninitialized constrained objects

2018-12-11  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_ch4.adb (Analyze_Allocator): In GNATprove mode build a
subtype declaration if the allocator has a subtype indication
with a constraint. This allows additional proofs to be applied
to allocators that designate uninitialized constrained objects.

From-SVN: r266991

5 years ago[Ada] Support access types in GNATprove
Yannick Moy [Tue, 11 Dec 2018 11:10:12 +0000 (11:10 +0000)]
[Ada] Support access types in GNATprove

SPARK RM has been updated to support access types in SPARK. Part of this
support is that now SPARK RM 3.1 lists access types as having full
default initialization. Now updated.

There is no impact on compilation.

2018-12-11  Yannick Moy  <moy@adacore.com>

gcc/ada/

* sem_util.adb (Has_Full_Default_Initialization): Consider
access types as having full default initialization.

From-SVN: r266990

5 years ago[Ada] Better error message from GNATprove on illegal switch
Yannick Moy [Tue, 11 Dec 2018 11:10:07 +0000 (11:10 +0000)]
[Ada] Better error message from GNATprove on illegal switch

When a compilation switch is wrongly passed to GNATprove without the
leading hyphen, this patch issues a clear error message instead of the
obscure 'usage' message previously displayed.

There is no impact on compilation.

2018-12-11  Yannick Moy  <moy@adacore.com>

gcc/ada/

* gnat1drv.adb (Gnat1drv): Issue specific error message in
GNATprove mode when multiple file names on the command line.
* osint.adb, osint.ads (Dump_Command_Line_Source_File_Names):
New procedure to print file names on the command line.

From-SVN: r266989

5 years ago[Ada] Fix runtime stack overflow for out/in-out actuals without discr.
Javier Miranda [Tue, 11 Dec 2018 11:10:02 +0000 (11:10 +0000)]
[Ada] Fix runtime stack overflow for out/in-out actuals without discr.

2018-12-11  Javier Miranda  <miranda@adacore.com>

gcc/ada/

* exp_aggr.adb (Convert_To_Assignments): When gnerating C, do
not declare a temporary to initialize an aggregate assigned to
Out or In_Out parameters whose type has no discriminants. This
avoids stack overflow errors at runtime.

From-SVN: r266988

5 years ago[Ada] Additionsal trasformations for unnesting in package bodies
Ed Schonberg [Tue, 11 Dec 2018 11:09:57 +0000 (11:09 +0000)]
[Ada] Additionsal trasformations for unnesting in package bodies

This patch extends the previous algorithm for creating an explicit
elaboration procedure for a package body when expansion generates
subprograms in the statement part of the body. For unnesting to work
properly, these subprograms must appear within an explicit subprogram
body so that uplevel references can be placed in the proper activation
record.

Ongoing work for LLVM generation.

2018-12-11  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* exp_ch7.adb (Check_Unnesting_Elaboration_Code): Extend
algorithm to cover subprograms generated in nested loops and in
exception handlers, in order to build an explicit elaboration
procedure in more complex cases.

From-SVN: r266987

5 years ago[Ada] Remove vxworks*-crtbe-link.spec
Jerome Lambourg [Tue, 11 Dec 2018 11:09:52 +0000 (11:09 +0000)]
[Ada] Remove vxworks*-crtbe-link.spec

The VxWorks crtbe are now part of libgcc, needed to support C++ on this
target.

2018-12-11  Jerome Lambourg  <lambourg@adacore.com>

gcc/ada/

* Makefile.rtl, gcc-interface/Makefile.in: Remove crtbe bits for
VxWorks.
* libgnat/system-vxworks-arm-rtp-smp.ads,
libgnat/system-vxworks-arm-rtp.ads,
libgnat/system-vxworks-arm.ads,
libgnat/system-vxworks-e500-kernel.ads,
libgnat/system-vxworks-e500-rtp-smp.ads,
libgnat/system-vxworks-e500-rtp.ads,
libgnat/system-vxworks-ppc-kernel.ads,
libgnat/system-vxworks-ppc-rtp-smp.ads,
libgnat/system-vxworks-ppc-rtp.ads,
libgnat/system-vxworks-ppc.ads,
libgnat/system-vxworks-x86-kernel.ads,
libgnat/system-vxworks-x86-rtp-smp.ads,
libgnat/system-vxworks-x86-rtp.ads,
libgnat/system-vxworks7-aarch64-rtp-smp.ads,
libgnat/system-vxworks7-aarch64.ads,
libgnat/system-vxworks7-arm-rtp-smp.ads,
libgnat/system-vxworks7-e500-kernel.ads,
libgnat/system-vxworks7-e500-rtp-smp.ads,
libgnat/system-vxworks7-e500-rtp.ads,
libgnat/system-vxworks7-ppc-kernel.ads,
libgnat/system-vxworks7-ppc-rtp-smp.ads,
libgnat/system-vxworks7-ppc-rtp.ads,
libgnat/system-vxworks7-ppc64-kernel.ads,
libgnat/system-vxworks7-ppc64-rtp-smp.ads,
libgnat/system-vxworks7-x86-kernel.ads,
libgnat/system-vxworks7-x86-rtp-smp.ads,
libgnat/system-vxworks7-x86-rtp.ads,
libgnat/system-vxworks7-x86_64-kernel.ads,
libgnat/system-vxworks7-x86_64-rtp-smp.ads: Remove pragma
Linker_Options for --specs.
* vx_crtbegin.c, vx_crtbegin.inc, vx_crtbegin_array.c,
vx_crtbegin_attr.c, vx_crtend.c, vxworks-gnat-crtbe-link.spec:
Remove.

From-SVN: r266986

5 years ago[Ada] Spurious visibility error on aspect Predicate
Ed Schonberg [Tue, 11 Dec 2018 11:09:46 +0000 (11:09 +0000)]
[Ada] Spurious visibility error on aspect Predicate

The GNAT-defined aspect Predicate has the same semantics as the Ada
aspect Dynamic_Predicate, including direct visibility to the components
of a record type to which the aspect applies.

The following must compile quietly:

   gcc -c integer_stacks.ads

----
pragma SPARK_Mode (On);

with Bounded_Stacks;
package Integer_Stacks is
     new Bounded_Stacks (Element => Integer, Default_Element => 0);
----
generic
   type Element is private;
   Default_Element : Element;
package Bounded_Stacks is

   type Stack (Capacity : Positive) is tagged private
      with Default_Initial_Condition => Empty (Stack);

   function "=" (Left, Right : Stack) return Boolean;

   function Extent (This : Stack) return Natural;

   function Empty (This : Stack) return Boolean;

   function Full (This : Stack) return Boolean;

   procedure Reset (This : out Stack) with
     Post'Class => Empty (This) and
                   not Full (This),
     Global     => null,
     Depends    => (This =>+ null);

   procedure Push (This : in out Stack;  Item : Element) with
     Pre'Class  => not Full (This) and
                   Extent (This) < This.Capacity,
     Post'Class => not Empty (This) and
                   Extent (This) = Extent (This'Old) + 1,
     Global     => null,
     Depends    => (This =>+ Item);

   procedure Pop (This : in out Stack;  Item : out Element) with
     Pre'Class  => not Empty (This),
     Post'Class => not Full (This) and
                   Extent (This) = Extent (This'Old) - 1,
     Global     => null,
     Depends    => (This =>+ null, Item => This);

   function Peek (This : Stack) return Element with
     Pre'Class => not Empty (This),
     Global    => null,
     Depends   => (Peek'Result => This);

private

   type Contents is array (Positive range <>) of Element;

   type Stack (Capacity : Positive) is tagged record
      Values : Contents (1 .. Capacity); -- := (others => Default_Element);
--        Top    : Natural;
      Top    : Natural := 0;
   end record with Predicate => Top <= Capacity,
     Annotate => (GNATprove,
                  Intentional,
                  "type ""Stack"" is not fully initialized",
                  "Because zeroing Top is sufficient");

end Bounded_Stacks;
----
package body Bounded_Stacks is

   ------------
   -- Extent --
   ------------

   function Extent (This : Stack) return Natural is
     (This.Top);

   -----------
   -- Empty --
   -----------

   function Empty (This : Stack) return Boolean is
     (This.Top = 0);

   ----------
   -- Full --
   ----------

   function Full (This : Stack) return Boolean is
     (This.Top = This.Capacity);

   -----------
   -- Reset --
   -----------

   procedure Reset (This : out Stack) is
   begin
      This := (This.Capacity, Top => 0, others => <>);
--        This.Top := 0;
   end Reset;

   ----------
   -- Push --
   ----------

   procedure Push (This : in out Stack;  Item : Element) is
   begin
      This.Top := This.Top + 1;
      This.Values (This.Top) := Item;
   end Push;

   ---------
   -- Pop --
   ---------

   procedure Pop (This : in out Stack;  Item : out Element) is
   begin
      Item := This.Values (This.Top);
      This.Top := This.Top - 1;
   end Pop;

   ----------
   -- Peek --
   ----------

   function Peek (This : Stack) return Element is
     (This.Values (This.Top));

   ---------
   -- "=" --
   ---------

   function "=" (Left, Right : Stack) return Boolean is
   begin
      if Left.Top /= Right.Top then
         return False;
      else
         for K in 1 .. Left.Top loop
            if Left.Values (K) /= Right.Values (K) then
               return False;
            end if;
         end loop;
         return True;
      end if;
   end "=";

end Bounded_Stacks;
----

2018-12-11  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_ch13.adb (Check_Aspect_At_End_Of_Declarations,
Freeze_Entity_Checks): Process aspect Predicate in the same
fashion as aspect Dynamic_Predicate.

From-SVN: r266985

5 years ago[Ada] Fix an ICE on instantiated subprogram with -gnatc
Eric Botcazou [Tue, 11 Dec 2018 11:09:41 +0000 (11:09 +0000)]
[Ada] Fix an ICE on instantiated subprogram with -gnatc

The following should compile quietly:

$ gcc -c p-proc.ads -gnatc

procedure P.Proc is new G;

with Q;

package P is

  generic procedure G;

end P;

with System;
with Unchecked_Conversion;

package Q is

  generic package Inner_G is

    type T is access all Integer;

    function Cnv is new Unchecked_Conversion (System.Address, T);

  end Inner_G;

end Q;

2018-12-11  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* gcc-interface/trans.c (elaborate_all_entities_for_package):
Skip aliasing subprograms.

From-SVN: r266984

5 years ago[Ada] Update gnatmetric documentation for the Libadalang-based version
Bob Duff [Tue, 11 Dec 2018 11:09:36 +0000 (11:09 +0000)]
[Ada] Update gnatmetric documentation for the Libadalang-based version

2018-12-11  Bob Duff  <duff@adacore.com>

gcc/ada/

* doc/gnat_ugn/gnat_utility_programs.rst: Update gnatmetric
documentation for the Libadalang-based version.

From-SVN: r266983

5 years ago[Ada] Fix an ACATS regression with CCG
Javier Miranda [Tue, 11 Dec 2018 11:09:29 +0000 (11:09 +0000)]
[Ada] Fix an ACATS regression with CCG

2018-12-11  Javier Miranda  <miranda@adacore.com>

gcc/ada/

* exp_aggr.adb (In_Object_Declaration): Removed.
(Is_CCG_Supported_Aggregate): New subprogram that replaces
In_Object_Declaration extending its functionality to indicate if
an aggregate is in a context supported by the CCG backend.

From-SVN: r266982

5 years ago[Ada] Update gnatstub documentation for the Libadalang-based version
Bob Duff [Tue, 11 Dec 2018 11:09:24 +0000 (11:09 +0000)]
[Ada] Update gnatstub documentation for the Libadalang-based version

2018-12-11  Bob Duff  <duff@adacore.com>

gcc/ada/

* doc/gnat_ugn/gnat_utility_programs.rst: Update gnatstub
documentation for the Libadalang-based version.
* gnat_ugn.texi: Regenerate.

From-SVN: r266981

5 years ago[Ada] Spurious errors on aspect specifications in generic units
Ed Schonberg [Tue, 11 Dec 2018 11:09:19 +0000 (11:09 +0000)]
[Ada] Spurious errors on aspect specifications in generic units

This patch fixes spurious errors on aspect specifications on record
types when the aspect expression references a component of the type that
is not a discriminant. The patch also cleans up the legality checks on
aspect specifications, and improves error message on illegal aspect
specifications whose expressions are not conformant between
specification and freeze point, because of changes in visibility.

2018-12-11  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_ch13.adb (Push_Type, Pop_Type): New procedures, used for
analysis of aspect expressions for record types, whose
components (not only discriminants) may be referenced in aspect
expressions.
(Analyze_Aspect_Specifications, Analyze_Aspects_At_Freeze_Point,
Analyze_Aspect_At_End-Of_Declarations,
Resolve_Aspect_Expressions): Use the new subprograms.
(Check_Aspect_At_End_Of_Declarations): Improve error message.
(Build_Predicate_Functions): Do not build their bodies in a
generic unit.
(Is_Derived_Type_With_Constraint): New subprogram to uncover and
reject aspect specificationss on types that appear after the
type is frozen.
* sem_ch13.ads (Push_Scope_And_Install_Discriminants,
Uninstall_Discriminants_And_Pop_Scope): Remove.
* sem_ch6.adb, sem_ch6.ads (Fully_Conformant_Expressions):
Additional parameter to improve error message on illegal aspect
specifications whose resolution differ between aspect
specification and freeze point.
* freeze.adb: Remove references to
Install/Uninstall_Discriminants.

gcc/testsuite/

* gnat.dg/aspect1.adb, gnat.dg/aspect1_horizontal.adb,
gnat.dg/aspect1_horizontal.ads, gnat.dg/aspect1_vectors_2d.ads:
New testcase.
* gnat.dg/static_pred1.adb: Expect an error message.

From-SVN: r266980

5 years ago[Ada] Document the -fgnat-encodings switch
Pierre-Marie de Rodat [Tue, 11 Dec 2018 11:09:13 +0000 (11:09 +0000)]
[Ada] Document the -fgnat-encodings switch

2018-12-11  Pierre-Marie de Rodat  <derodat@adacore.com>

gcc/ada/

* doc/gnat_ugn/building_executable_programs_with_gnat.rst:
Document the -fgnat-encodings switch.
* gnat_ugn.texi: Regenerate.

From-SVN: r266979

5 years ago[Ada] Crash on nesting of subunits with bodies acting as specs
Justin Squirek [Tue, 11 Dec 2018 11:09:08 +0000 (11:09 +0000)]
[Ada] Crash on nesting of subunits with bodies acting as specs

This patch corrects an issue whereby a set of nested subunits including
subprogram subunits acting as bodies would cause a crash when a child
subunit "withs" an ansestor in certain instances due to a mismanagment
of the scope stack.

------------
-- Source --
------------

--  w.ads

package W is
end;

--  w-b.ads

package W.B is
  pragma Elaborate_Body;
end;

--  w-b.adb

with W.B.C;

package body w.B is end;

--  w-b-c.adb

with W;
procedure W.B.C is
  package D is
    procedure E;
  end;
  package body D is separate;
begin
  null;
end;

--  w-b-c-d.adb

separate (W.B.C)
package body D is
  procedure E is separate;
end;

--  w-b-c-d-e.adb

with W;

separate (W.B.C.D)
procedure E is
begin
  null;
end;

-----------------
-- Compilation --
-----------------

$ gnatmake -q w-b.adb

2018-12-11  Justin Squirek  <squirek@adacore.com>

gcc/ada/

* sem_ch10.adb (Analyze_Subunit): Modify conditional to fully
remove parent contexts from library-level subprogram bodies in
addition to package bodies.

From-SVN: r266978

5 years ago[Ada] Suppress call to Initial_Condition when the annotation is ignored
Hristian Kirtchev [Tue, 11 Dec 2018 11:09:04 +0000 (11:09 +0000)]
[Ada] Suppress call to Initial_Condition when the annotation is ignored

This patch suppresses the generation of the Initial_Condition procedure
tasked with verifying the run-time semantics of the pragma when the
pragma is ignored by means of -gnata, pragma Assertion_Policy, etc.

------------
-- Source --
------------

--  all_asserts_off.adc

pragma Assertion_Policy (Ignore);

--  all_asserts_on.adc

pragma Assertion_Policy (Check);

--  ic_off.adc

pragma Assertion_Policy (Initial_Condition => Ignore);

--  ic_on.adc

pragma Assertion_Policy (Initial_Condition => Check);

--  init_cond.ads

package Init_Cond
  with SPARK_Mode,
       Initial_Condition => Flag = False
is
   Flag : Boolean := True;

   procedure Set_Flag;
end Init_Cond;

--  init_cond.adb

package body Init_Cond
  with SPARK_Mode
is
   procedure Set_Flag is
   begin
      Flag := True;
   end Set_Flag;
end Init_Cond;

----------------------------
-- Compilation and output --
----------------------------

& gcc  -c -S -gnatDG init_cond.adb -gnatec=all_asserts_on.adc
& grep -c "Initial_Condition;" init_cond.adb.dg
& grep -c "_elabb" init_cond.s
& gcc  -c -S -gnatDG init_cond.adb -gnatec=ic_on.adc
& grep -c "Initial_Condition;" init_cond.adb.dg
& grep -c "_elabb" init_cond.s
& gcc  -c -S -gnatDG init_cond.adb -gnatec=all_asserts_off.adc
& grep -c "Initial_Condition;" init_cond.adb.dg
& grep -c "_elabb" init_cond.s
& gcc  -c -S -gnatDG init_cond.adb -gnatec=ic_off.adc
& grep -c "Initial_Condition;" init_cond.adb.dg
& grep -c "_elabb" init_cond.s
2
4
2
4
0
0
0
0

2018-12-11  Hristian Kirtchev  <kirtchev@adacore.com>

gcc/ada/

* exp_prag.adb (Expand_Pragma_Initial_Condition): Do not
generate an Initial_Condition procedure and a call to it when
the associated pragma is ignored.
* sem_ch10.adb (Analyze_Compilation_Unit): Minor cleanup.

From-SVN: r266977

5 years ago[Ada] Almost always inline init. procedure of small and simple records
Eric Botcazou [Tue, 11 Dec 2018 11:08:45 +0000 (11:08 +0000)]
[Ada] Almost always inline init. procedure of small and simple records

2018-12-11  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* fe.h (Debug_Generated_Code): Declare.
* gcc-interface/gigi.h (enum inline_status_t): Rename
is_disabled to is_default, is_enabled to is_requested and add
is_prescribed.
* gcc-interface/decl.c (inline_status_for_subprog): New function.
(gnat_to_gnu_entity) <E_Subprogram_Type>: Use it to get the
inlining status of the subprogram.
* gcc-interface/trans.c (gigi): Adjust to above renaming.
(build_raise_check): Likewise.
(Compilation_Unit_to_gnu): Likewise.
(gnat_to_gnu): Likewise.
* gcc-interface/utils.c (create_subprog_decl): Likewise.  Deal
with is_prescribed status by setting
DECL_DISREGARD_INLINE_LIMITS.  Do not set the
DECL_NO_INLINE_WARNING_P flag if Debug_Generated_Code is true.

From-SVN: r266976

5 years agoccmp.c (ccmp_candidate_p): Use GIMPLE API properly.
Richard Biener [Tue, 11 Dec 2018 11:07:24 +0000 (11:07 +0000)]
ccmp.c (ccmp_candidate_p): Use GIMPLE API properly.

2018-12-11  Richard Biener  <rguenther@suse.de>

* ccmp.c (ccmp_candidate_p): Use GIMPLE API properly.

From-SVN: r266975

5 years agore PR lto/86004 (Several lto test cases begin failing with r260963)
Jakub Jelinek [Tue, 11 Dec 2018 10:28:39 +0000 (11:28 +0100)]
re PR lto/86004 (Several lto test cases begin failing with r260963)

PR lto/86004
* doc/sourcebuild.texi (lto_incremental): Document new effective
target.

* lib/target-supports.exp (check_effective_target_lto_incremental):
New.
* g++.dg/lto/pr69137_0.C: Require lto_incremental effective target.
* g++.dg/lto/pr65316_0.C: Likewise.
* g++.dg/lto/pr85176_0.C: Likewise.
* g++.dg/lto/pr79000_0.C: Likewise.
* g++.dg/lto/pr66180_0.C: Likewise.
* g++.dg/lto/pr65193_0.C: Likewise.
* g++.dg/lto/pr69077_0.C: Likewise.
* g++.dg/lto/pr68057_0.C: Likewise.
* g++.dg/lto/pr66705_0.C: Likewise.
* g++.dg/lto/pr65302_0.C: Likewise.
* g++.dg/lto/20091002-1_0.C: Likewise.
* g++.dg/lto/pr81940_0.C: Likewise.
* g++.dg/lto/pr64043_0.C: Likewise.
* g++.dg/lto/pr65549_0.C: Likewise.
* g++.dg/lto/pr69133_0.C: Likewise.
* gfortran.dg/lto/pr79108_0.f90: Likewise.

From-SVN: r266974

5 years agors6000: Don't use rs6000_isa_flags_explicit for soft float tests (PR88145)
Segher Boessenkool [Tue, 11 Dec 2018 08:30:36 +0000 (09:30 +0100)]
rs6000: Don't use rs6000_isa_flags_explicit for soft float tests (PR88145)

...specifically, those for builtins.  Soft float can be enabled
implicitly, too (for certain CPUs for example).  We should use
rs6000_isa_flags instead, to decide whether to expand a builtin or
to bail out with an error instead.

PR target/88145
* config/rs6000/rs6000.c (rs6000_expand_zeroop_builtin): Use
rs6000_isa_flags instead of rs6000_isa_flags_explicit to decide
whether soft float is enabled.
(rs6000_expand_mtfsb_builtin): Ditto.
(rs6000_expand_set_fpscr_rn_builtin): Ditto.
(rs6000_expand_set_fpscr_drn_builtin): Ditto.

From-SVN: r266973

5 years agore PR c/88430 (-Wmissing-attributes warnings when including libquadmath headers)
Jakub Jelinek [Tue, 11 Dec 2018 07:45:47 +0000 (08:45 +0100)]
re PR c/88430 (-Wmissing-attributes warnings when including libquadmath headers)

PR c/88430
* quadmath_weak.h (__qmath2): Add __quadmath_throw.

From-SVN: r266972

5 years agore PR tree-optimization/80520 (Performance regression from missing if-conversion)
Jeff Law [Tue, 11 Dec 2018 04:56:54 +0000 (21:56 -0700)]
re PR tree-optimization/80520 (Performance regression from missing if-conversion)

PR tree-optimization/80520
* gimple-ssa-split-paths.c (is_feasible_trace): Recognize half
diamonds that are likely if convertable.

* gcc.dg/tree-ssa/split-path-5.c: Update expected output.
* gcc.dg/tree-ssa/split-path-11.c: New test.

From-SVN: r266971

5 years agodocumentation_hacking.xml: Update reference to epubcheck.
Gerald Pfeifer [Tue, 11 Dec 2018 04:00:00 +0000 (04:00 +0000)]
documentation_hacking.xml: Update reference to epubcheck.

* doc/xml/manual/documentation_hacking.xml: Update reference
to epubcheck.

From-SVN: r266970

5 years ago2018-12-10 Steven G. Kargl <kargl@gcc.gnu.org>
Steven G. Kargl [Tue, 11 Dec 2018 01:39:23 +0000 (01:39 +0000)]
2018-12-10  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/97922
* io.c (gfc_match_open): Additional checks on ASYNCHRONOUS.

2018-12-10  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/97922
* gfortran.dg/io_constraints_8.f90: Update error message.
* gfortran.dg/pr87922.f90: New test.

From-SVN: r266968

5 years agoPR tree-optimization/86196 - Bogus -Wrestrict on memcpy between array elements at...
Martin Sebor [Tue, 11 Dec 2018 01:22:08 +0000 (01:22 +0000)]
PR tree-optimization/86196 - Bogus -Wrestrict on memcpy between array elements at unequal indices

gcc/ChangeLog:

PR tree-optimization/86196
* gimple-ssa-warn-restrict.c (builtin_memref::builtin_memref): Use
base size only of arrays.

gcc/testsuite/ChangeLog:

PR tree-optimization/86196
* gcc.dg/Wrestrict-18.c: New test.

From-SVN: r266967

5 years agoDaily bump.
GCC Administrator [Tue, 11 Dec 2018 00:16:43 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r266966

5 years agosinatan-1.c: Use dg-add-options ieee.
Uros Bizjak [Mon, 10 Dec 2018 20:35:28 +0000 (21:35 +0100)]
sinatan-1.c: Use dg-add-options ieee.

* gcc.dg/sinatan-1.c: Use dg-add-options ieee.

From-SVN: r266963

5 years agoDelete powerpcspe
Segher Boessenkool [Mon, 10 Dec 2018 19:40:27 +0000 (20:40 +0100)]
Delete powerpcspe

This deletes powerpcspe, which was deprecated for GCC 8.

This does not change the testsuite, or libgcc for rs6000 (which still
is shared code with powerpcspe, so can use some cleanup after this).

/
* contrib/config-list.mk: Remove powerpc-eabispe and powerpc-linux_spe.

gcc/
* config.gcc (Obsolete configurations): Delete powerpc*-*-*spe*.
(Unsupported targets): Add powerpc*-*-*spe*.
(powerpc*-*-*spe*): Delete.
(powerpc-*-eabispe*): Delete.
(powerpc-*-rtems*spe*): Delete.
(powerpc*-*-linux*spe*): Delete.
(powerpc*-*-linux*): Do not handle the linux*spe* targets.
(powerpc-wrs-vxworks*spe): Delete.
(with_cpu setting code): Delete powerpc*-*-*spe* handling.
* config.host (target powerpc*-*-*spe*): Delete.
* doc/invoke.texi (PowerPC SPE Options): Delete.
(PowerPC SPE Options): Delete.
* config/powerpcspe: Delete.

From-SVN: r266961

5 years agore PR fortran/88269 (ICE in gfc_format_decoder, at fortran/error.c:947)
Steven G. Kargl [Mon, 10 Dec 2018 18:05:37 +0000 (18:05 +0000)]
re PR fortran/88269 (ICE in gfc_format_decoder, at fortran/error.c:947)

2018-12-10  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88269
* io.c (io_constraint): Update macro. If locus line buffer is NULL,
use gfc_current_locus in error messages.
(check_io_constraints): Catch missing IO UNIT in write and read
statements.  io_constraint macro is incompatible here.

2018-12-10  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88269
* gfortran.dg/pr88269.f90: New test.

From-SVN: r266959

5 years agore PR target/88418 (ICE in extract_insn, at recog.c:2305 (error: unrecognizable insn))
Uros Bizjak [Mon, 10 Dec 2018 15:47:16 +0000 (16:47 +0100)]
re PR target/88418 (ICE in extract_insn, at recog.c:2305 (error: unrecognizable insn))

PR target/88418
* config/i386/i386.c (ix86_expand_sse_cmp): For vector modes,
check operand 1 with vector_operand predicate.
(ix86_expand_sse_movcc): For vector modes, check op_true with
vector_operand, not nonimmediate_operand.

testsuite/ChangeLog:

PR target/88418
* gcc.target/i386/pr88418.c: New test.

From-SVN: r266958

5 years agoMake test for Filesystem TS actually use the Filesystem TS
Jonathan Wakely [Mon, 10 Dec 2018 15:25:02 +0000 (15:25 +0000)]
Make test for Filesystem TS actually use the Filesystem TS

This test was copied from 27_io/filesystem/path/query/is_absolute.cc but
should have been modified to test the path type from the TS instead of
std::filesystem::path.

* testsuite/experimental/filesystem/path/query/is_absolute.cc: Fix
test to use TS, not C++17.

From-SVN: r266957

5 years agotree-affine.c (tree_to_aff_combination): Remove unreachable MEM_REF case.
Richard Biener [Mon, 10 Dec 2018 14:20:18 +0000 (14:20 +0000)]
tree-affine.c (tree_to_aff_combination): Remove unreachable MEM_REF case.

2018-12-10  Richard Biener  <rguenther@suse.de>

* tree-affine.c (tree_to_aff_combination): Remove unreachable
MEM_REF case.
(aff_combination_expand): Cache on SSA names, not possibly
on conversion trees.  Avoid expanding cases we do not handle.

From-SVN: r266956

5 years agore PR tree-optimization/88427 (ICE: tree check: expected integer_cst, have plus_expr...
Richard Biener [Mon, 10 Dec 2018 13:56:51 +0000 (13:56 +0000)]
re PR tree-optimization/88427 (ICE: tree check: expected integer_cst, have plus_expr in get_len, at tree.h:5617)

2018-12-10  Richard Biener  <rguenther@suse.de>

PR tree-optimization/88427
* vr-values.c (vr_values::extract_range_from_phi_node):
Handle symbolic ranges conservatively when trying to drop
to Inf +- 1.

* gcc.dg/pr88427.c: New testcase.

From-SVN: r266955

5 years agore PR ipa/87955 (ICE in cl_target_option_print_diff at gcc/options-save.c:3803 since...
Jakub Jelinek [Mon, 10 Dec 2018 13:30:49 +0000 (14:30 +0100)]
re PR ipa/87955 (ICE in cl_target_option_print_diff at gcc/options-save.c:3803 since r265920)

PR ipa/87955
* gcc.target/i386/pr87955.c: Add -msse2 -mfpmath=sse to dg-options.

From-SVN: r266954

5 years ago[PR 88214] Check that an argument is a pointer
Martin Jambor [Mon, 10 Dec 2018 12:45:47 +0000 (13:45 +0100)]
[PR 88214] Check that an argument is a pointer

2018-12-10  Martin Jambor  <mjambor@suse.cz>

PR ipa/88214
* ipa-prop.c (determine_locally_known_aggregate_parts): Make sure
we check pointers against pointers.

testsuite/
* gcc.dg/ipa/pr88214.c: New test.

From-SVN: r266953

5 years agore PR testsuite/88369 (g++.dg/vect/pr33426-ivdep.cc etc. FAIL)
Jakub Jelinek [Mon, 10 Dec 2018 12:42:05 +0000 (13:42 +0100)]
re PR testsuite/88369 (g++.dg/vect/pr33426-ivdep.cc etc. FAIL)

PR testsuite/88369
* gcc.dg/vect/vect-ivdep-1.c: Prune versioning for alignment messages.
* gcc.dg/vect/vect-ivdep-2.c: Likewise.
* gcc.dg/vect/nodump-vect-opt-info-1.c: Likewise.
* g++.dg/vect/pr33426-ivdep.cc: Likewise.
* g++.dg/vect/pr33426-ivdep-2.cc: Likewise.
* g++.dg/vect/pr33426-ivdep-3.cc: Likewise.
* g++.dg/vect/pr33426-ivdep-4.cc: Likewise.

From-SVN: r266952

5 years agore PR tree-optimization/88415 (ICE: verify_gimple failed (error: dead STMT in EH...
Richard Biener [Mon, 10 Dec 2018 12:39:07 +0000 (12:39 +0000)]
re PR tree-optimization/88415 (ICE: verify_gimple failed (error: dead STMT in EH table))

2018-12-10  Richard Biener  <rguenther@suse.de>

PR middle-end/88415
* gimple.c (gimple_assign_set_rhs_with_ops): Transfer EH
info to a newly allocated stmt.

* gcc.dg/gomp/pr88415.c: New testcase.

From-SVN: r266951

5 years agolibphobos: Fix modify immutable error on Solaris.
Iain Buclaw [Mon, 10 Dec 2018 12:11:55 +0000 (12:11 +0000)]
libphobos: Fix modify immutable error on Solaris.

Backported from upstream druntime 2.079.

Reviewed-on: https://github.com/dlang/druntime/pull/2089

From-SVN: r266950

5 years agopatchable_function_entry-decl.c: Pass -mcpu=gr6 for Visium and remove other specific...
Eric Botcazou [Mon, 10 Dec 2018 11:16:47 +0000 (11:16 +0000)]
patchable_function_entry-decl.c: Pass -mcpu=gr6 for Visium and remove other specific handling.

* c-c++-common/patchable_function_entry-decl.c: Pass -mcpu=gr6 for
Visium and remove other specific handling.
* c-c++-common/patchable_function_entry-default.c: Likewise.
* c-c++-common/patchable_function_entry-definition.c: Likewise.

From-SVN: r266948

5 years agoAdd missing def of TARGET_VXWORKS_HAVE_CTORS_DTORS for VxWorksAE
Jerome Lambourg [Mon, 10 Dec 2018 10:44:28 +0000 (10:44 +0000)]
Add missing def of TARGET_VXWORKS_HAVE_CTORS_DTORS for VxWorksAE

* config/vxworksae.h (TARGET_VXWORKS_HAVE_CTORS_DTORS): Define.

From-SVN: r266947

5 years agoDon't try to use libgcc-unwind.map with --disable-shared (PR bootstrap/65725)
Fredrik Nyström [Mon, 10 Dec 2018 09:49:02 +0000 (10:49 +0100)]
Don't try to use libgcc-unwind.map with --disable-shared (PR bootstrap/65725)

2018-12-10  Fredrik Nyström  <fredrik@lysator.liu.se>

PR bootstrap/65725
* config/sol2.h: Only use libgcc-unwind.map if
ENABLE_SHARED_LIBGCC.

From-SVN: r266946

5 years agoauto-profile.c (afdo_calculate_branch_prob): Convert profile_count to afdo precision...
Bin Cheng [Mon, 10 Dec 2018 07:02:49 +0000 (07:02 +0000)]
auto-profile.c (afdo_calculate_branch_prob): Convert profile_count to afdo precision quality.

* auto-profile.c (afdo_calculate_branch_prob): Convert profile_count
to afdo precision quality.
(afdo_callsite_hot_enough_for_early_inline): Likewise.
(afdo_annotate_cfg): Set profile_count for exit basic block.

From-SVN: r266943

5 years ago* auto-profile.c (string_table::get_index_by_decl)
Bin Cheng [Mon, 10 Dec 2018 06:54:02 +0000 (06:54 +0000)]
* auto-profile.c (string_table::get_index_by_decl)
(function_instance::get_function_instance_by_decl): Avoid infinite
recursion by using DECL_FROM_INLINE.

From-SVN: r266942

5 years agoDaily bump.
GCC Administrator [Mon, 10 Dec 2018 00:16:47 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r266939

5 years agore PR fortran/88205 (ICE in gfc_wide_strncasecmp, at fortran/scanner.c:249)
Steven G. Kargl [Sun, 9 Dec 2018 23:49:14 +0000 (23:49 +0000)]
re PR fortran/88205 (ICE in gfc_wide_strncasecmp, at fortran/scanner.c:249)

2018-12-09  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88205
* io.c (gfc_match_open): Move NEWUNIT checks to after STATUS checks.

2018-12-09  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88205
* gfortran.dg/pr88205.f90: New unit.

From-SVN: r266936

5 years agolibphobos: Add druntime bindings for SPARC/Solaris
Iain Buclaw [Sun, 9 Dec 2018 23:46:45 +0000 (23:46 +0000)]
libphobos: Add druntime bindings for SPARC/Solaris

Backported from upstream druntime master.

Initial patch by Rainer Orth.

Reviewed-on: https://github.com/dlang/druntime/pull/2344

From-SVN: r266935

5 years agoGenerate and scan documentation output in Ddoc tests.
Iain Buclaw [Sun, 9 Dec 2018 19:55:54 +0000 (19:55 +0000)]
Generate and scan documentation output in Ddoc tests.

The tests in gdc.test/compilable/ddoc*.d don't require the module to be
compiled all the way down to object code.  Instead, only compile the
test sources with -fdoc, and scan the generated html content.

gcc/testsuite/ChangeLog:

PR d/88039
* gdc.test/gdc-test.exp (gdc-convert-args): Handle -D.
(dmd2dg): Check generated html in ddoc tests.
(gdc-do-test): Set dg-do-what-default to compile for ddoc tests.

From-SVN: r266933

5 years agoconfig.gcc (hppa*-*-linux*): Add pa/t-pa to tmake_file.
John David Anglin [Sun, 9 Dec 2018 19:41:39 +0000 (19:41 +0000)]
config.gcc (hppa*-*-linux*): Add pa/t-pa to tmake_file.

* config.gcc (hppa*-*-linux*): Add pa/t-pa to tmake_file.  Define
d_target_objs.
* config/pa/pa-protos.h (pa_d_target_versions): New prototype.
* config/pa/pa.h (TARGET_D_CPU_VERSIONS): Define.
* config/pa/pa-d.c: New file.
* config/pa/t-pa: New file.

From-SVN: r266931

5 years agore PR fortran/88206 (ICE in gfc_match_type_spec, at fortran/match.c:2229)
Steven G. Kargl [Sun, 9 Dec 2018 19:10:57 +0000 (19:10 +0000)]
re PR fortran/88206 (ICE in gfc_match_type_spec, at fortran/match.c:2229)

2018-12-09  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88206
* match.c (gfc_match_type_spec): REAL can be an intrinsic function.

2018-12-09  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88206
* gfortran.dg/pr88206.f90: New test.

From-SVN: r266930

5 years agore PR libfortran/88411 (Random crashes for ASYNCHRONOUS writes (bad locking?))
Thomas Koenig [Sun, 9 Dec 2018 18:54:47 +0000 (18:54 +0000)]
re PR libfortran/88411 (Random crashes for ASYNCHRONOUS writes (bad locking?))

2018-12-09  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/88411
* io/transfer.c (dta_transfer_init): Do not treat as an
asynchronous statement unless the statement has
ASYNCHRONOUS="YES".
(st_write_done): Likewise.
(st_read_done): Do not perform async_wait for synchronous I/O
on an async unit.
(st_read_done): Likewise.

2018-12-09  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/88411
* testsuite/libgomp.fortran/async_io_8.f90: New test.

From-SVN: r266929

5 years ago[multiple changes]
Steven G. Kargl [Sun, 9 Dec 2018 16:32:48 +0000 (16:32 +0000)]
[multiple changes]

2018-12-09  Fritz Reese  <fritzoreese@gmail.com>

PR fortran/88228
* resolve.c (resolve_operator):  Do not call resolve_function.
Break like other cases.

2018-12-09  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88228
* gfortran.dg/pr88228.f90: New test.

From-SVN: r266926

5 years agoMerge dmd upstream e2fe2687b
Iain Buclaw [Sun, 9 Dec 2018 15:06:22 +0000 (15:06 +0000)]
Merge dmd upstream e2fe2687b

Backports VRP fixes from the D front-end implementation to the C++ port,
and fixes errors reported by ubsan build where the conversion from D
didn't include adjusting integer suffixes from 'UL' to 'ULL'.

Fixes https://gcc.gnu.org/PR88366

Reviewed-on: https://github.com/dlang/dmd/pull/9046

From-SVN: r266925

5 years agoCorrect the reported line number in Fortran combined OpenACC directives
Thomas Schwinge [Sun, 9 Dec 2018 12:49:20 +0000 (13:49 +0100)]
Correct the reported line number in Fortran combined OpenACC directives

gcc/fortran/
* trans-openmp.c (gfc_trans_oacc_combined_directive): Set the
location of combined acc loops.
gcc/testsuite/
* gfortran.dg/goacc/combined-directives-3.f90: New file.

Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
From-SVN: r266924

5 years agoCorrect the reported line number in C++ combined OpenACC directives
Cesar Philippidis [Sun, 9 Dec 2018 12:48:26 +0000 (04:48 -0800)]
Correct the reported line number in C++ combined OpenACC directives

The C++ FE doesn't set the expr_location of the split acc loop in combined acc
parallel/kernels loop directives. This only happens for with combined
directives, otherwise cp_parser_omp_construct would be responsible for setting
the location. After fixing this bug, I was able to resolve a couple of long
standing diagnostics discrepancies between the C/C++ FEs in the test suite.

gcc/cp/
* parser.c (cp_parser_oacc_kernels_parallel): Adjust EXPR_LOCATION
on the combined acc loop.
gcc/testsuite/
* c-c++-common/goacc/combined-directives-3.c: New test.
* c-c++-common/goacc/loop-2-kernels.c (void K): Adjust test.
* c-c++-common/goacc/loop-2-parallel.c (void P): Adjust test.
* c-c++-common/goacc/loop-3.c (void p2): Adjust test.

Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
From-SVN: r266923

5 years agoUse existing middle end checking for Fortran OpenACC loop clauses
Thomas Schwinge [Sun, 9 Dec 2018 12:47:58 +0000 (13:47 +0100)]
Use existing middle end checking for Fortran OpenACC loop clauses

Don't duplicate in the Fortran front end what's generically being checked in
the middle end.

gcc/fortran/
* openmp.c (resolve_oacc_loop_blocks): Remove checking of OpenACC
loop clauses.
gcc/testsuite/
* gfortran.dg/goacc/loop-2-kernels.f95: Update.
* gfortran.dg/goacc/loop-2-parallel.f95: Likewise.
* gfortran.dg/goacc/nested-parallelism.f90: Likewise.

From-SVN: r266922

5 years agoSplit up "gfortran.dg/goacc/loop-2.f95"
Thomas Schwinge [Sun, 9 Dec 2018 12:47:47 +0000 (13:47 +0100)]
Split up "gfortran.dg/goacc/loop-2.f95"

gcc/testsuite/
* gfortran.dg/goacc/loop-2.f95: Split into...
* gfortran.dg/goacc/loop-2-kernels-nested.f95: ... this new
file...
* gfortran.dg/goacc/loop-2-kernels-tile.f95: ..., and this new
file...
* gfortran.dg/goacc/loop-2-kernels.f95: ..., and this new file...
* gfortran.dg/goacc/loop-2-parallel-3.f95: ..., and this new
file...
* gfortran.dg/goacc/loop-2-parallel-nested.f95: ..., and this new
file...
* gfortran.dg/goacc/loop-2-parallel-tile.f95: ..., and this new
file...
* gfortran.dg/goacc/loop-2-parallel.f95: ..., and this new file.

From-SVN: r266921

5 years ago[PR88420] Fortran OpenACC "Clause SEQ conflicts with INDEPENDENT"
Thomas Schwinge [Sun, 9 Dec 2018 12:47:35 +0000 (13:47 +0100)]
[PR88420] Fortran OpenACC "Clause SEQ conflicts with INDEPENDENT"

The Fortran front end declares that the OpenACC "Clause SEQ conflicts with
INDEPENDENT".  While that combination doesn't make too much sense indeed, it's
still valid; these are orthogonal concepts.

gcc/fortran/
PR fortran/88420
* openmp.c (resolve_oacc_loop_blocks): Remove "Clause SEQ
conflicts with INDEPENDENT" diagnostic.
gcc/testsuite/
PR fortran/88420
* gfortran.dg/goacc/loop-1-2.f95: Update.
* gfortran.dg/goacc/loop-1.f95: Likewise.

From-SVN: r266920

5 years agoCoalesce host to device transfers in libgomp: not for link pointer
Thomas Schwinge [Sun, 9 Dec 2018 12:47:23 +0000 (13:47 +0100)]
Coalesce host to device transfers in libgomp: not for link pointer

libgomp/
* target.c (gomp_map_vars): Call gomp_copy_host2dev instead of
devicep->host2dev_func.

Co-Authored-By: Jakub Jelinek <jakub@redhat.com>
From-SVN: r266919

5 years agoipa-cp.c (update_profiling_info): Call adjust_for_ipa_scaling for zero profile count.
Bin Cheng [Sun, 9 Dec 2018 06:37:56 +0000 (06:37 +0000)]
ipa-cp.c (update_profiling_info): Call adjust_for_ipa_scaling for zero profile count.

* ipa-cp.c (update_profiling_info): Call adjust_for_ipa_scaling for
zero profile count.

From-SVN: r266918

5 years agore PR fortran/88048 (ICE in check_data_variable, at fortran/resolve.c:15491)
Steven G. Kargl [Sun, 9 Dec 2018 06:09:47 +0000 (06:09 +0000)]
re PR fortran/88048 (ICE in check_data_variable, at fortran/resolve.c:15491)

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88048
* resolve.c (check_data_variable): Named constant cannot be a
data object.

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88048
* gfortran.dg/pr88048.f90: New test.

From-SVN: r266916

5 years ago20180-12-08 Steven G. Kargl <kargl@gcc.gnu.org>
Steven G. Kargl [Sun, 9 Dec 2018 04:02:44 +0000 (04:02 +0000)]
20180-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/87945
* decl.c (var_element): Inquiry parameters cannit be data objects.

20180-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/87945
* gfortran.dg/pr87945_1.f90: New test.
* gfortran.dg/pr87945_2.f90: New test.

From-SVN: r266915

5 years agore PR fortran/88025 (ICE in gfc_apply_init, at fortran/expr.c:4468)
Steven G. Kargl [Sun, 9 Dec 2018 01:02:41 +0000 (01:02 +0000)]
re PR fortran/88025 (ICE in gfc_apply_init, at fortran/expr.c:4468)

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88025
* expr.c (gfc_apply_init):  Remove asserts that cannot trigger.
Check for a NULL pointer.

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88025
* gfortran.dg/pr88025.f90: New test.

From-SVN: r266913

5 years agoDaily bump.
GCC Administrator [Sun, 9 Dec 2018 00:16:33 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r266912

5 years agoc: Delete a stray line in asm inline
Segher Boessenkool [Sat, 8 Dec 2018 22:31:09 +0000 (23:31 +0100)]
c: Delete a stray line in asm inline

I noticed I accidentally copied a line too many from the "volatile"
handling to the "inline" handling.  This fixes it.

gcc/c/
* c-parser (c_parser_asm_statement) [RID_INLINE]: Delete stray line
setting "quals".

From-SVN: r266909

5 years agore PR fortran/88357 (ICE in parse_associate, at fortran/parse.c:4568)
Steven G. Kargl [Sat, 8 Dec 2018 18:09:05 +0000 (18:09 +0000)]
re PR fortran/88357 (ICE in parse_associate, at fortran/parse.c:4568)

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/88357
* class.c (insert_component_ref): Check for NULL pointer and
previous error message issued.
* parse.c (parse_associate): Check for NULL pointer.
* resolve.c (resolve_assoc_var): Check for NULL pointer.

2018-12-08  Steven G. Kargl  <kargl@gcc.gnu.org>

* gfortran.dg/pr88357_1.f90: New test.
* gfortran.dg/pr88357_2.f90: New test.

From-SVN: r266908

5 years agore PR fortran/88304 (ICE in use_pointer_in_frame, at tree-nested.c:267)
Jakub Jelinek [Sat, 8 Dec 2018 13:37:49 +0000 (14:37 +0100)]
re PR fortran/88304 (ICE in use_pointer_in_frame, at tree-nested.c:267)

PR fortran/88304
* tree-nested.c (convert_local_reference_stmt): Handle clobbers where
lhs is not a decl normally, don't call use_pointer_in_frame on that
lhs.

* gfortran.fortran-torture/compile/pr88304-2.f90: New test.

From-SVN: r266907

5 years agore PR rtl-optimization/88390 (g++.dg/tree-prof/pr57451.C FAILs)
Eric Botcazou [Sat, 8 Dec 2018 11:07:53 +0000 (11:07 +0000)]
re PR rtl-optimization/88390 (g++.dg/tree-prof/pr57451.C FAILs)

PR rtl-optimization/88390
* dwarf2cfi.c (struct dw_cfi_row): Add window_save field.
(cfi_row_equal_p): Compare it.
(dwarf2out_frame_debug_cfa_window_save): Add FAKE parameter.
If FAKE is false, set window_save of the current row.
(dwarf2out_frame_debug) <REG_CFA_TOGGLE_RA_MANGLE>: Call above
function with FAKE parameter set to true.
<REG_CFA_WINDOW_SAVE>: Likewise but with FAKE parameter set to false.
(change_cfi_row): Emit a DW_CFA_GNU_window_save if necessary.

From-SVN: r266906

5 years agoPass GDCFLAGS and CCASFLAGS to libphobos subdirs
Rainer Orth [Sat, 8 Dec 2018 10:02:19 +0000 (10:02 +0000)]
Pass GDCFLAGS and CCASFLAGS to libphobos subdirs

* Makefile.am (AM_MAKEFLAGS): Pass CCASFLAGS, GDCFLAGS.
* Makefile.in: Regenerate.

From-SVN: r266905

5 years agore PR libgomp/87995 (libgomp.c/../libgomp.c-c++-common/cancel-taskgroup-3.c fails...
Jakub Jelinek [Sat, 8 Dec 2018 08:58:24 +0000 (09:58 +0100)]
re PR libgomp/87995 (libgomp.c/../libgomp.c-c++-common/cancel-taskgroup-3.c fails consistently after r265930)

PR libgomp/87995
* testsuite/libgomp.c-c++-common/cancel-taskgroup-3.c: Require
tls_runtime effective target.
(t): New threadprivate variable.
(main): Set t in threads which execute iterations of the worksharing
loop.  Propagate that to the task after the loop and don't abort
if the current taskgroup hasn't been cancelled.

From-SVN: r266904

5 years agoDaily bump.
GCC Administrator [Sat, 8 Dec 2018 00:16:34 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r266903

5 years agodecl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages about bit-fields...
Paolo Carlini [Fri, 7 Dec 2018 17:48:39 +0000 (17:48 +0000)]
decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages about bit-fields with function type...

/cp
2018-12-07  Paolo Carlini  <paolo.carlini@oracle.com>

* decl2.c (grokbitfield): Use DECL_SOURCE_LOCATION in error messages
about bit-fields with function type, warn_if_not_aligned type, and
static bit-fields; avoid DECL_NAME for unnamed declarations.

/testsuite
2018-12-07  Paolo Carlini  <paolo.carlini@oracle.com>

* g++.dg/other/bitfield7.C: New.
* g++.dg/parse/bitfield8.C: Likewise.
* g++.dg/parse/bitfield9.C: Likewise.
* g++.dg/pr53037-4.C: Test the locations too.

From-SVN: r266900

5 years agore PR target/87496 (ICE in aggregate_value_p at gcc/function.c:2046)
Peter Bergner [Fri, 7 Dec 2018 17:33:55 +0000 (17:33 +0000)]
re PR target/87496 (ICE in aggregate_value_p at gcc/function.c:2046)

gcc/
PR target/87496
* config/rs6000/rs6000.c (rs6000_option_override_internal): Disallow
-mabi=ieeelongdouble and -mabi=ibmlongdouble without -mlong-double-128.
Do not error for -mabi=ibmlongdouble and no ISA 2.06 support.
* doc/invoke.texi: Document -mabi=ibmlongdouble and -mabi=ieeelongdouble
require -mlong-double-128.

gcc/testsuite/
PR target/87496
* gcc.target/powerpc/pr87496.c: Rename from this...
* gcc.target/powerpc/pr87496-1.c: ...to this.  Update comment.
* gcc.target/powerpc/pr87496-2.c: New test.
* gcc.target/powerpc/pr87496-3.c: New test.

From-SVN: r266899

5 years ago[AArch64][2/2] Add sve_width -moverride tunable
Kyrylo Tkachov [Fri, 7 Dec 2018 17:05:21 +0000 (17:05 +0000)]
[AArch64][2/2] Add sve_width -moverride tunable

On top of the previous patch that implements TARGET_ESTIMATED_POLY_VALUE
and adds an sve_width tuning field to the CPU structs, this patch implements
an -moverride knob to adjust this sve_width field to allow for experimentation.
Again, reminder that this only has an effect when compiling for VLA-SVE that is,
without msve-vector-bits=<foo>. This just adjusts tuning heuristics in the compiler,,
like profitability thresholds for vectorised versioned loops, and others.

It can be used, for example like -moverride=sve_width=256 to set the sve_width
tuning field to 256. Widths outside of the accepted SVE widths [128 - 2048] are rejected
as you'd expect.

    * config/aarch64/aarch64.c (aarch64_tuning_override_functions): Add
    sve_width entry.
    (aarch64_parse_sve_width_string): Define.

    * gcc.target/aarch64/sve/override_sve_width_1.c: New test.

From-SVN: r266898

5 years agogimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add m_update_global_ranges...
Jeff Law [Fri, 7 Dec 2018 17:02:11 +0000 (10:02 -0700)]
gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add m_update_global_ranges member.

* gimple-ssa-evrp-analyze.h (class evrp_range_analyzer): Add
m_update_global_ranges member.  Add corresponding argument to ctor.
* gimple-ssa-evrp-analyze.c
(evrp_range_analyzer::evrp_range_analyzer): Add new argument and
initialize m_update_global_ranges.
(evrp_range_analyzer::set_ssa_range_info): Assert that we are
updating global ranges.
(evrp_range_analyzer::record_ranges_from_incoming_edge): Only
update global ranges if explicitly requested.
(evrp_range_analyzer::record_ranges_from_phis): Similarly.
(evrp_range_analyzer::record_ranges_from_stmt): Similarly.
* gimple-ssa-evrp.c (evrp_dom_walker): Pass new argument to
evrp_range_analyzer ctor.
* gimple-ssa-sprintf.c (sprintf_dom_walker): Similarly.
* tree-ssa-dom.c (dom_opt_dom_walker): Similarly.

* gcc.c-torture/builtins/strnlen.x: New file to filter -Og from
options to test.

From-SVN: r266897

5 years ago[AArch64][1/2] Implement TARGET_ESTIMATED_POLY_VALUE
Kyrylo Tkachov [Fri, 7 Dec 2018 16:48:39 +0000 (16:48 +0000)]
[AArch64][1/2] Implement TARGET_ESTIMATED_POLY_VALUE

The hook TARGET_ESTIMATED_POLY_VALUE allows a target to give an estimate for a poly_int run-time value.
It is used exclusively in tuning decisions, things like estimated loop iterations, probabilities etc.
It is not relied on for correctness.

If we know the SVE width implemented in hardware we can make more more
informed decisions in the implementation of TARGET_ESTIMATED_POLY_VALUE,
even when compiling for VLA vectorisation.

This patch adds an sve_width field to our tuning structs and sets it for
the current CPU tunings.

A new value is introduced to the aarch64_sve_vector_bits_enum enum that indicates
that SVE is not available: SVE_NOT_IMPLEMENTED. I set it to the same value as SVE_SCALABLE
so that parts of the aarch64 backend that follow the pattern:
if (vector_width == SVE_SCALABLE)
  do_vla_friendly_action ()
else
  assume_specific_width_for_correctness ()

continue to work without change, but the CPU tuning structs can use a more
appropriate moniker for indicating the absence of SVE.

This sets sve_width to SVE_NOT_IMPLEMENTED for all cores.
I aim to add an -moverride switch in the next patch that allows a power user to experiment
with different values of it for investigations.

* config/aarch64/aarch64-opts.h (aarch64_sve_vector_bits_enum):
Add SVE_NOT_IMPLEMENTED value.
* config/aarch64/aarch64-protos.h (struct tune_params): Add sve_width
field.
* config/aarch64/aarch64.c (generic_tunings,cortexa35_tunings,
cortexa53_tunings, cortexa57_tunings, cortexa72_tunings,
cortexa73_tunings, exynosm1_tunings, thunderx_tunings,
thunderx_tunings, tsv110_tunings, xgene1_tunings, qdf24xx_tunings,
saphira_tunings, thunderx2t99_tunings, emag_tunings):
Specify sve_width.
(aarch64_estimated_poly_value): Define.
(TARGET_ESTIMATED_POLY_VALUE): Define.

From-SVN: r266896

5 years ago[rs6000] mmintrin.h: fix use of "vector"
Paul A. Clarke [Fri, 7 Dec 2018 16:32:34 +0000 (16:32 +0000)]
[rs6000] mmintrin.h: fix use of "vector"

A recent patch inadvertently added the use of "vector" to mmintrin.h
when all such uses should be "__vector".

[gcc]

2018-12-07  Paul A. Clarke  <pc@us.ibm.com>

PR target/88408
* config/rs6000/mmintrin.h (_mm_packs_pu16): Correctly use "__vector".

From-SVN: r266895

5 years agore PR rtl-optimization/88349 ([MIPS] Redundant store instructions generated start...
Vladimir Makarov [Fri, 7 Dec 2018 16:08:17 +0000 (16:08 +0000)]
re PR rtl-optimization/88349 ([MIPS]  Redundant store instructions generated start with r266385)

2018-12-07  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/88349
* ira-costs.c (record_operand_costs): Check bigger reg class on
NO_REGS.

2018-12-07  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/88349
* gcc.target/mips/pr88349.c: New.

From-SVN: r266894

5 years agore PR c++/86669 (Complete object constructor clone omits length for a c++11 braced...
Jakub Jelinek [Fri, 7 Dec 2018 15:20:04 +0000 (16:20 +0100)]
re PR c++/86669 (Complete object constructor clone omits length for a c++11 braced initialiser)

PR c++/86669
* call.c (make_temporary_var_for_ref_to_temp): Call pushdecl even for
automatic vars.

* g++.dg/cpp0x/initlist105.C: New test.
* g++.dg/cpp0x/initlist106.C: New test.
* g++.dg/other/pr86669.C: New test.

From-SVN: r266893

5 years ago[AArch64][SVE] Remove unnecessary PTRUEs from integer arithmetic
Richard Sandiford [Fri, 7 Dec 2018 15:03:15 +0000 (15:03 +0000)]
[AArch64][SVE] Remove unnecessary PTRUEs from integer arithmetic

When using the unpredicated immediate forms of MUL, LSL, LSR and ASR,
the rtl patterns would still have the predicate operand we created for
the other forms.  This patch splits the patterns after reload in order
to get rid of the predicate, like we already do for WHILE.

2018-12-07  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/aarch64/aarch64-sve.md (*mul<mode>3, *v<optab><mode>3):
Split the patterns after reload if we don't need the predicate
operand.
(*post_ra_mul<mode>3, *post_ra_v<optab><mode>3): New patterns.

gcc/testsuite/
* gcc.target/aarch64/sve/pred_elim_2.c: New test.

From-SVN: r266892

5 years ago[AArch64][SVE] Remove unnecessary PTRUEs from FP arithmetic
Richard Sandiford [Fri, 7 Dec 2018 15:01:47 +0000 (15:01 +0000)]
[AArch64][SVE] Remove unnecessary PTRUEs from FP arithmetic

When using the unpredicated all-register forms of FADD, FSUB and FMUL,
the rtl patterns would still have the predicate operand we created for
the other forms.  This patch splits the patterns after reload in order
to get rid of the predicate, like we already do for WHILE.

2018-12-07  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* config/aarch64/iterators.md (SVE_UNPRED_FP_BINARY): New code
iterator.
(sve_fp_op): Handle minus and mult.
* config/aarch64/aarch64-sve.md (*add<mode>3, *sub<mode>3)
(*mul<mode>3): Split the patterns after reload if we don't
need the predicate operand.
(*post_ra_<sve_fp_op><mode>3): New pattern.

gcc/testsuite/
* gcc.target/aarch64/sve/pred_elim_1.c: New test.

From-SVN: r266891

5 years agoruntime: add missing return for non-GNU/Linux version of tgkill
Ian Lance Taylor [Fri, 7 Dec 2018 14:22:55 +0000 (14:22 +0000)]
runtime: add missing return for non-GNU/Linux version of tgkill

    Path from Rainer Orth.

    Reviewed-on: https://go-review.googlesource.com/c/153118

From-SVN: r266890

5 years agoAdd forgotten PR marker.
Rainer Orth [Fri, 7 Dec 2018 13:56:17 +0000 (13:56 +0000)]
Add forgotten PR marker.

From-SVN: r266889

5 years agoBuild gcc.target/i386/ipa-stack-alignment-2.c with -fomit-frame-pointer
Rainer Orth [Fri, 7 Dec 2018 13:01:20 +0000 (13:01 +0000)]
Build gcc.target/i386/ipa-stack-alignment-2.c with -fomit-frame-pointer

* gcc.target/i386/ipa-stack-alignment-2.c: Add
-fomit-frame-pointer to dg-options.

From-SVN: r266888

5 years agoAdd a recursion limit to libiberty's demangling code. The limit is enabled by defaul...
Nick Clifton [Fri, 7 Dec 2018 10:33:30 +0000 (10:33 +0000)]
Add a recursion limit to libiberty's demangling code.  The limit is enabled by default, but can be disabled via a new demangling option.

include * demangle.h (DMGL_NO_RECURSE_LIMIT): Define.
        (DEMANGLE_RECURSION_LIMIT): Define

PR 87681
PR 87675
PR 87636
PR 87350
PR 87335
libiberty * cp-demangle.h (struct d_info): Add recursion_level field.
* cp-demangle.c (d_function_type): Add recursion counter.
If the recursion limit is reached and the check is not disabled,
then return with a failure result.
(cplus_demangle_init_info): Initialise the recursion_level field.
        (d_demangle_callback): If the recursion limit is enabled, check
for a mangled string that is so long that there is not enough
stack space for the local arrays.
        * cplus-dem.c (struct work): Add recursion_level field.
(squangle_mop_up): Set the numb and numk fields to zero.
(work_stuff_copy_to_from): Handle the case where a btypevec or
ktypevec field is NULL.
(demangle_nested_args): Add recursion counter.  If
the recursion limit is not disabled and reached, return with a
failure result.

From-SVN: r266886

5 years agoprofile-count.h (profile_count::oeprator>=): Fix typo by inverting return condition...
Bin Cheng [Fri, 7 Dec 2018 09:49:13 +0000 (09:49 +0000)]
profile-count.h (profile_count::oeprator>=): Fix typo by inverting return condition when *this is precise zero.

* profile-count.h (profile_count::oeprator>=): Fix typo by inverting
return condition when *this is precise zero.

From-SVN: r266885

5 years agoDaily bump.
GCC Administrator [Fri, 7 Dec 2018 00:16:25 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r266884

5 years agore PR target/85593 (GCC on ARM allocates R3 for local variable when calling naked...
Jakub Jelinek [Thu, 6 Dec 2018 23:41:04 +0000 (00:41 +0100)]
re PR target/85593 (GCC on ARM allocates R3 for local variable when calling naked function with O2 optimizations enabled)

PR target/85593
* final.c (rest_of_handle_final): Don't call collect_fn_hard_reg_usage
for functions with naked attribute.

* gcc.target/i386/pr85593.c: New test.

From-SVN: r266881

5 years agore PR rtl-optimization/85770 (ICE: in lra_eliminate, at lra-eliminations.c:1439 with...
Jakub Jelinek [Thu, 6 Dec 2018 23:39:12 +0000 (00:39 +0100)]
re PR rtl-optimization/85770 (ICE: in lra_eliminate, at lra-eliminations.c:1439 with -march=nano-1000)

PR rtl-optimization/85770
* gcc.target/i386/pr85770.c: Require int128 effective target.

From-SVN: r266880

5 years agore PR fortran/88377 (ICE in gfc_omp_clause_copy_ctor, at fortran/trans-openmp.c:614)
Jakub Jelinek [Thu, 6 Dec 2018 23:29:04 +0000 (00:29 +0100)]
re PR fortran/88377 (ICE in gfc_omp_clause_copy_ctor, at fortran/trans-openmp.c:614)

PR fortran/88377
* trans-openmp.c (gfc_omp_clause_default_ctor,
gfc_omp_clause_copy_ctor, gfc_omp_clause_assign_op,
gfc_omp_clause_linear_ctor, gfc_omp_clause_dtor): Only consider
GFC_DECL_GET_SCALAR_ALLOCATABLE vars as scalar allocatables if they
have pointer type.

* gfortran.dg/gomp/pr88377.f90: New test.

From-SVN: r266879

5 years agore PR tree-optimization/88367 (-fno-delete-null-pointer-checks doesn't work properly)
Jakub Jelinek [Thu, 6 Dec 2018 23:28:04 +0000 (00:28 +0100)]
re PR tree-optimization/88367 (-fno-delete-null-pointer-checks doesn't work properly)

PR c/88367
* tree-vrp.c (extract_range_from_binary_expr): For POINTER_PLUS_EXPR
with -fno-delete-null-pointer-checks, set_nonnull only if the pointer
is non-NULL and offset is known to have most significant bit clear.
* vr-values.c (vr_values::vrp_stmt_computes_nonzero): For ADDR_EXPR
of MEM_EXPR, return true if the MEM_EXPR has non-zero offset with
most significant bit clear.  If offset does have most significant bit
set and -fno-delete-null-pointer-checks, don't return true even if
the base pointer is non-NULL.

* gcc.dg/tree-ssa/pr88367.c: New test.

From-SVN: r266878

5 years agore PR c++/87506 (ICE with inherited constexpr constructor with const argument)
Jakub Jelinek [Thu, 6 Dec 2018 23:25:10 +0000 (00:25 +0100)]
re PR c++/87506 (ICE with inherited constexpr constructor with const argument)

PR c++/87506
* constexpr.c (adjust_temp_type): Handle EMPTY_CLASS_EXPR.

* g++.dg/cpp0x/constexpr-87506.C: New test.

From-SVN: r266877

5 years agoclass.c (check_bitfield_decl): In error message about non-integral type print the...
Paolo Carlini [Thu, 6 Dec 2018 23:20:16 +0000 (23:20 +0000)]
class.c (check_bitfield_decl): In error message about non-integral type print the type itself too.

/cp
2018-12-06  Paolo Carlini  <paolo.carlini@oracle.com>

* class.c (check_bitfield_decl): In error message about non-integral
type print the type itself too.
* decl.c (grokdeclarator): Do not ICE on unnamed bit-fields declared
friends; when calling build_decl for a FIELD_DECL possibly pass the
declarator->id_loc.

/testsuite
2018-12-06  Paolo Carlini  <paolo.carlini@oracle.com>

* g++.dg/parse/bitfield7.C: New.
* g++.dg/other/bitfield2.C: Check location and type.
* g++.dg/parse/bitfield1.C: Likewise.
* g++.dg/parse/bitfield2.C: Likewise.

From-SVN: r266876

5 years ago[PR86747] tsubst friend tpl ctxt before looking it up for dupes
Alexandre Oliva [Thu, 6 Dec 2018 23:18:40 +0000 (23:18 +0000)]
[PR86747] tsubst friend tpl ctxt before looking it up for dupes

When a member template is redeclared as a friend, we enter the context
of the member before looking it up, and then we check that the decls
are compatible.  However, when the member template references template
types of the enclosing context, say an enclosing template class, the
compare fails because the friend decl is already tsubsted, whereas the
looked up name isn't.

The problem is that the enclosing context is taken from the friend
declaration before tsubsting it, so we look up in the context of the
generic template instead of that of the tsubsted one we're
specializing.  The solution is to tsubst the enclosing context when
it's a non-namespace scope.

for  gcc/cp/ChangeLog

PR c++/86747
* pt.c (tsubst_friend_class): Enter tsubsted class context.

for  gcc/testsuite/ChangeLog

PR c++/86747
* g++.dg/pr86747.C: New.

From-SVN: r266875

5 years ago[PR86397] resolve nondependent noexcept specs early in C++1[14]
Alexandre Oliva [Thu, 6 Dec 2018 23:18:30 +0000 (23:18 +0000)]
[PR86397] resolve nondependent noexcept specs early in C++1[14]

build_noexcept_spec refrained from resolving nondependent noexcept
expressions when they were not part of the function types (C++ 11 and
14).  This caused problems during mangling: canonical_eh_spec, when
called on the template function type, would find an unresolved but not
explicitly deferred expression, and nothrow_spec_p would reject it.

We could relax the mangling logic to skip canonical_eh_spec, but since
-Wnoexcept-type warns when mangling function names that change as
noexcept specs become part of types and of mangling in C++17, and the
test at mangling time may give incorrect results if the spec is not
resolved, we might as well keep things simple and resolve nondependent
noexcept specs sooner rather than later.  This is what this patch does.

for  gcc/cp/ChangeLog

PR c++/86397
* except.c (build_noexcept_spec): Resolve nondependent
expressions.

for gcc/testsuite/ChangeLog

PR c++/86397
* g++.dg/cpp0x/pr86397-1.C: New.
* g++.dg/cpp0x/pr86397-2.C: New.

From-SVN: r266874