gcc.git
4 years agoRefactor IPA devirt a bit.
Martin Liska [Mon, 2 Dec 2019 11:18:31 +0000 (12:18 +0100)]
Refactor IPA devirt a bit.

2019-12-02  Martin Liska  <mliska@suse.cz>

* ipa-devirt.c (warn_types_mismatch): Use get_odr_name_for_type
function.
(debug_tree_odr_name): New.
* ipa-utils.h (get_odr_name_for_type): New.
2019-12-02  Martin Liska  <mliska@suse.cz>

* g++.dg/lto/odr-7_0.C: New test.
* g++.dg/lto/odr-7_1.C: New test.

From-SVN: r278898

4 years agoFix dg failure
Jan Hubicka [Mon, 2 Dec 2019 11:11:34 +0000 (12:11 +0100)]
Fix dg failure

* g++.dg/lto/inline-crossmodule-1_0.C: fix template.

From-SVN: r278897

4 years agore PR tree-optimization/92742 (ICE in info_for_reduction, at tree-vect-loop.c:4367)
Richard Biener [Mon, 2 Dec 2019 10:50:45 +0000 (10:50 +0000)]
re PR tree-optimization/92742 (ICE in info_for_reduction, at tree-vect-loop.c:4367)

2019-12-02  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92742
* tree-vect-loop.c (vect_fixup_reduc_chain): Do not
touch the def-type but verify it is consistent with the
original stmts.

* gcc.dg/torture/pr92742.c: New testcase.

From-SVN: r278896

4 years agore PR tree-optimization/92712 (Performance regression with assumed values)
Jakub Jelinek [Mon, 2 Dec 2019 08:51:49 +0000 (09:51 +0100)]
re PR tree-optimization/92712 (Performance regression with assumed values)

PR tree-optimization/92712
* match.pd ((A * B) +- A -> (B +- 1) * A,
A +- (A * B) -> (1 +- B) * A): Allow optimizing signed integers
even when we don't know anything about range of A, but do know
something about range of B and the simplification won't introduce
new UB.

* gcc.dg/tree-ssa/pr92712-1.c: New test.
* gcc.dg/tree-ssa/pr92712-2.c: New test.
* gcc.dg/tree-ssa/pr92712-3.c: New test.
* gfortran.dg/loop_versioning_1.f90: Adjust expected number of
likely to be innermost dimension messages.
* gfortran.dg/loop_versioning_10.f90: Likewise.
* gfortran.dg/loop_versioning_6.f90: Likewise.

From-SVN: r278894

4 years agoEnable recursive function versioning
Feng Xue [Mon, 2 Dec 2019 06:37:30 +0000 (06:37 +0000)]
Enable recursive function versioning

2019-12-02  Feng Xue <fxue@os.amperecomputing.com>

        PR ipa/92133
        * doc/invoke.texi (ipa-cp-max-recursive-depth): Document new option.
        (ipa-cp-min-recursive-probability): Likewise.
        * params.opt (ipa-cp-max-recursive-depth): New.
        (ipa-cp-min-recursive-probability): Likewise.
        * ipa-cp.c (ipcp_lattice<valtype>::add_value): Add two new parameters
        val_p and unlimited.
        (self_recursively_generated_p): New function.
        (get_val_across_arith_op): Likewise.
        (propagate_vals_across_arith_jfunc): Add constant propagation for
        self-recursive function.
        (incorporate_penalties): Do not penalize pure self-recursive function.
        (good_cloning_opportunity_p): Dump node_is_self_scc flag.
        (propagate_constants_topo): Set node_is_self_scc flag for cgraph node.
        (get_info_about_necessary_edges): Relax hotness check for edge to
        self-recursive function.
        * ipa-prop.h (ipa_node_params): Add new field node_is_self_scc.

2019-12-02  Feng Xue  <fxue@os.amperecomputing.com>

        PR ipa/92133
        * gcc.dg/ipa/ipa-clone-2.c: New test.

From-SVN: r278893

4 years agoFix bugs relating to flexibly-sized objects in nios2 backend.
Sandra Loosemore [Mon, 2 Dec 2019 03:52:15 +0000 (22:52 -0500)]
Fix bugs relating to flexibly-sized objects in nios2 backend.

2019-12-01  Sandra Loosemore  <sandra@codesourcery.com>

Fix bugs relating to flexibly-sized objects in nios2 backend.

PR target/92499

gcc/c/
* c-decl.c (flexible_array_type_p): Move to common code.

gcc/
* config/nios2/nios2.c (nios2_in_small_data_p): Do not consider
objects of flexible types to be small if they have internal linkage
or are declared extern.
* config/nios2/nios2.h (ASM_OUTPUT_ALIGNED_LOCAL): Replace with...
(ASM_OUTPUT_ALIGNED_DECL_LOCAL): ...this.  Use targetm.in_small_data_p
instead of the size of the object initializer.
* tree.c (flexible_array_type_p): Move from C front end, and
generalize to handle fields in non-C structures.
* tree.h (flexible_array_type_p): Declare.

gcc/testsuite/
* gcc.target/nios2/pr92499-1.c: New.
* gcc.target/nios2/pr92499-2.c: New.
* gcc.target/nios2/pr92499-3.c: New.

From-SVN: r278891

4 years agoPR92398: Fix testcase failure of pr72804.c
Luo Xiong Hu [Mon, 2 Dec 2019 01:59:26 +0000 (01:59 +0000)]
PR92398: Fix testcase failure of pr72804.c

P9LE generated instruction is not worse than P8LE.
mtvsrdd;xxlnot;stxv vs. not;not;std;std.
It can have longer latency, but latency via memory is not so critical,
and this does save decode and other resources.  It's hard to choose
which is best.  Update the test case to fix failures.

gcc/testsuite/ChangeLog:

2019-12-02  Luo Xiong Hu  <luoxhu@linux.ibm.com>

PR testsuite/92398
* gcc.target/powerpc/pr72804.c: Split the store function to...
* gcc.target/powerpc/pr92398.h: ... this one.  New.
* gcc.target/powerpc/pr92398.p9+.c: New.
* gcc.target/powerpc/pr92398.p9-.c: New.
* lib/target-supports.exp (check_effective_target_p8): New.
(check_effective_target_p9+): New.

From-SVN: r278890

4 years agoDaily bump.
GCC Administrator [Mon, 2 Dec 2019 00:16:12 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r278889

4 years agore PR libfortran/90374 (Fortran 2018: Support d0.d, e0.d, es0.d, en0.d, g0.d and...
Jerry DeLisle [Sun, 1 Dec 2019 22:29:43 +0000 (22:29 +0000)]
re PR libfortran/90374 (Fortran 2018: Support d0.d, e0.d, es0.d, en0.d, g0.d and ew.d e0 edit descriptors for output)

2019-12-01  Jerry DeLisle  <jvdelisle@gcc.ngu.org>

PR fortran/90374
* io/format.c (parse_format_list): Add braces to disambiguate
conditional.

From-SVN: r278886

4 years agoprofile-count.h (profile_count::operator<): Use IPA value for comparsion.
Jan Hubicka [Sun, 1 Dec 2019 15:12:52 +0000 (16:12 +0100)]
profile-count.h (profile_count::operator<): Use IPA value for comparsion.

* profile-count.h (profile_count::operator<): Use IPA value for
comparsion.
(profile_count::operator>): Likewise.
(profile_count::operator<=): Likewise.
(profile_count::operator>=): Likewise.
* predict.c (maybe_hot_count_p): Do not convert to gcov_type.

From-SVN: r278885

4 years agoDaily bump.
GCC Administrator [Sun, 1 Dec 2019 00:16:25 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r278883

4 years agoipa-inline.c (compute_max_insns): Return int64_t.
Jan Hubicka [Sat, 30 Nov 2019 23:19:58 +0000 (00:19 +0100)]
ipa-inline.c (compute_max_insns): Return int64_t.

* ipa-inline.c (compute_max_insns): Return int64_t.
(inline_small_functions): Simplify.

From-SVN: r278880

4 years agoUpdate max_bb_count in execute_fixup_cfg
Jan Hubicka [Sat, 30 Nov 2019 21:25:24 +0000 (22:25 +0100)]
Update max_bb_count in execute_fixup_cfg

* tree-cfg.c (execute_fixup_cfg): Update also max_bb_count when
scaling happen.

From-SVN: r278879

4 years agocgraph.h (symtab_node): Add symver flag.
Jan Hubicka [Sat, 30 Nov 2019 21:03:25 +0000 (22:03 +0100)]
cgraph.h (symtab_node): Add symver flag.

2019-11-30  Jan Hubicka  <hubicka@ucw.cz>

* cgraph.h (symtab_node): Add symver flag.
* cgraphunit.c (process_symver_attribute): New.
(process_common_attributes): Use process_symver_attribute.
* lto-cgraph.c (lto_output_node): Stream symver.
(lto_output_varpool_node): Stream symver.
(input_overwrite_node): Stream symver.
(input_varpool_node): Stream symver.
* output.h (do_assemble_symver): Decalre.
* symtab.c (symtab_node::dump_base): Dump symver.
(symtab_node::verify_base): Verify symver.
(symtab_node::resolve_alias): Handle symver.
* varasm.c (do_assemble_symver): New function.
* varpool.c (varpool_node::assemble_aliases): Use it.
* doc/extend.texi: (symver attribute): Document.
* config/elfos.h (ASM_OUTPUT_SYMVER_DIRECTIVE): New.

c-family/ChangeLog:

2019-11-30  Jan Hubicka  <hubicka@ucw.cz>

* c-attribs.c (handle_symver_attribute): New function
(c_common_attributes): Add symver.

From-SVN: r278878

4 years ago[C] Add a target hook that allows targets to verify type usage
Richard Sandiford [Sat, 30 Nov 2019 18:50:06 +0000 (18:50 +0000)]
[C] Add a target hook that allows targets to verify type usage

This patch adds a new target hook to check whether there are any
target-specific reasons why a type cannot be used in a certain
source-language context.  It works in a similar way to existing
hooks like TARGET_INVALID_CONVERSION and TARGET_INVALID_UNARY_OP.

The reason for adding the hook is to report invalid uses of SVE types.
Throughout a TU, the SVE vector and predicate types represent values
that can be stored in an SVE vector or predicate register.  At certain
points in the TU we might be able to generate code that assumes the
registers have a particular size, but often we can't.  In some cases
we might even make multiple different assumptions in the same TU
(e.g. when implementing an ifunc for multiple vector lengths).

But SVE types themselves are the same type throughout.  The register
size assumptions change how we generate code, but they don't change
the definition of the types.

This means that the types do not have a fixed size at the C level
even when -msve-vector-bits=N is in effect.  It also means that the
size does not work in the same way as for C VLAs, where the abstract
machine evaluates the size at a particular point and then carries that
size forward to later code.

The SVE ACLE deals with this by making it invalid to use C and C++
constructs that depend on the size or layout of SVE types.  The spec
refers to the types as "sizeless" types and defines their semantics as
edits to the standards.  See:

  https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00868.html

for a fuller description and:

  https://gcc.gnu.org/ml/gcc/2019-11/msg00088.html

for a recent update on the status.

However, since all current sizeless types are target-specific built-in
types, there's no real reason for the frontends to handle them directly.
They can just hand off the checks to target code instead.  It's then
possible for the errors to refer to "SVE types" rather than "sizeless
types", which is likely to be more meaningful to users.

There is a slight overlap between the new tests and the ones for
gnu_vector_type_p in r277950, but here the emphasis is on testing
sizelessness.

2019-11-30  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* target.h (type_context_kind): New enum.
(verify_type_context): Declare.
* target.def (verify_type_context): New target hook.
* doc/tm.texi.in (TARGET_VERIFY_TYPE_CONTEXT): Likewise.
* doc/tm.texi: Regenerate.
* tree.c (verify_type_context): New function.
* config/aarch64/aarch64-protos.h (aarch64_sve::verify_type_context):
Declare.
* config/aarch64/aarch64-sve-builtins.cc (verify_type_context):
New function.
* config/aarch64/aarch64.c (aarch64_verify_type_context): Likewise.
(TARGET_VERIFY_TYPE_CONTEXT): Define.

gcc/c-family/
* c-common.c (pointer_int_sum): Use verify_type_context to check
whether the target allows pointer arithmetic for the types involved.
(c_sizeof_or_alignof_type, c_alignof_expr): Use verify_type_context
to check whether the target allows sizeof and alignof operations
for the types involved.

gcc/c/
* c-decl.c (start_decl): Allow initialization of variables whose
size is a POLY_INT_CST.
(finish_decl): Use verify_type_context to check whether the target
allows variables with a particular type to have static or thread-local
storage duration.  Don't raise a second error if such variables do
not have a constant size.
(grokdeclarator): Use verify_type_context to check whether the
target allows fields or array elements to have a particular type.
* c-typeck.c (pointer_diff): Use verify_type_context to test whether
the target allows pointer difference for the types involved.
(build_unary_op): Likewise for pointer increment and decrement.

gcc/testsuite/
* gcc.target/aarch64/sve/acle/general-c/sizeless-1.c: New test.
* gcc.target/aarch64/sve/acle/general-c/sizeless-2.c: Likewise.

From-SVN: r278877

4 years agocgraph.c (cgraph_node::dump): Dump unit_id and merged_extern_inline.
Jan Hubicka [Sat, 30 Nov 2019 16:56:45 +0000 (17:56 +0100)]
cgraph.c (cgraph_node::dump): Dump unit_id and merged_extern_inline.

* cgraph.c (cgraph_node::dump): Dump unit_id and merged_extern_inline.
* cgraph.h (cgraph_node): Add unit_id and
merged_extern_inline.
(symbol_table): Add max_unit.
(symbol_table::symbol_table): Initialize it.
* cgraphclones.c (duplicate_thunk_for_node): Copy unit_id.
merged_comdat, merged_extern_inline.
(cgraph_node::create_clone): Likewise.
(cgraph_node::create_version_clone): Likewise.
* ipa-fnsummary.c (dump_ipa_call_summary): Dump info about cross module
calls.
* ipa-fnsummary.h (cross_module_call_p): New inline function.
* ipa-inline-analyssi.c (simple_edge_hints): Use it.
* ipa-inline.c (inline_small_functions): Likewise.
* lto-symtab.c (lto_cgraph_replace_node): Record merged_extern_inline;
copy merged_comdat and merged_extern_inline.
* lto-cgraph.c (lto_output_node): Stream out merged_comdat,
merged_extern_inline and unit_id.
(input_overwrite_node): Stream in these.
(input_cgraph_1): Set unit_base.
* lto-streamer.h (lto_file_decl_data): Add unit_base.
* symtab.c (symtab_node::make_decl_local): Record former_comdat.

* g++.dg/lto/inline-crossmodule-1.h: New testcase.
* g++.dg/lto/inline-crossmodule-1_0.C: New testcase.
* g++.dg/lto/inline-crossmodule-1_1.C: New testcase.

From-SVN: r278876

4 years agoDo not look at _data component in gfc_dep_resolver.
Thomas Koenig [Sat, 30 Nov 2019 15:02:50 +0000 (15:02 +0000)]
Do not look at _data component in gfc_dep_resolver.

2019-11-30  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/91783
* dependency.c (gfc_dep_resolver): Do not look at _data
component if present.

2019-11-30  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/91783
* gfortran.dg/dependency_56.f90: New test.

From-SVN: r278873

4 years agodriver: Do not warn about ineffective `-x' option if no inputs were given
Maciej W. Rozycki [Sat, 30 Nov 2019 11:10:50 +0000 (11:10 +0000)]
driver: Do not warn about ineffective `-x' option if no inputs were given

Fix an issue with the GCC driver and the `-x' option where a warning is
issued in an invocation like:

$ riscv64-linux-gnu-gcc -print-multi-directory -x c++
riscv64-linux-gnu-gcc: warning: '-x c++' after last input file has no effect
lib64/lp64d
$

where no inputs were given and hence the use of `-x' is irrelevant.
The statement printed is also untrue as the `-x' does not come after the
last input file given that none was given.  Do not print it then if no
inputs were supplied.

* gcc.c (process_command): Only warn about an ineffective `-x'
option if any input files have actually been supplied.

From-SVN: r278872

4 years agodoc: Correct `--enable-version-specific-runtime-libs' support information
Maciej W. Rozycki [Sat, 30 Nov 2019 11:06:59 +0000 (11:06 +0000)]
doc: Correct `--enable-version-specific-runtime-libs' support information

The `--enable-version-specific-runtime-libs' configuration option is now
supported throughout all of our target library subdirectories, so update
installation documentation accordingly and also mention that the default
for the option is `yes' for libada and `no' for the remaining libraries.

gcc/
* doc/install.texi (Options specification): Remove the list of
target library subdirectories supporting
`--enable-version-specific-runtime-libs'.  Document defaults for
the option.

From-SVN: r278871

4 years agolibstdc++: Default to --enable-libstdcxx-filesystem-ts for *-*-mingw*
Jonathan Wakely [Sat, 30 Nov 2019 01:03:40 +0000 (01:03 +0000)]
libstdc++: Default to --enable-libstdcxx-filesystem-ts for *-*-mingw*

* acinclude.m4 (GLIBCXX_ENABLE_FILESYSTEM_TS): Enable by default for
mingw targets.
* configure: Regenerate.

From-SVN: r278870

4 years agolibstdc++: Fix experimental::filesystem::u8path(const Source&) for Windows
Jonathan Wakely [Sat, 30 Nov 2019 01:03:36 +0000 (01:03 +0000)]
libstdc++: Fix experimental::filesystem::u8path(const Source&) for Windows

This function failed to compile when called with a std::string.

Also, constructing a path with a char8_t string did not correctly treat
the string as already UTF-8 encoded.

* include/bits/fs_path.h (u8path(InputIterator, InputIterator))
(u8path(const Source&)) [_GLIBCXX_FILESYSTEM_IS_WINDOWS]: Simplify
conditions.
* include/experimental/bits/fs_path.h [_GLIBCXX_FILESYSTEM_IS_WINDOWS]
(__u8path(const Source&, char)): Add overloads for std::string and
types convertible to std::string.
(_Cvt::_S_wconvert): Add a new overload for char8_t strings and use
codecvt_utf8_utf16 to do the correct conversion.

From-SVN: r278869

4 years agoDaily bump.
GCC Administrator [Sat, 30 Nov 2019 00:16:20 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r278868

4 years agore PR rtl-optimization/92283 (454.calculix miscomparison since r276645 with -O2 ...
Vladimir Makarov [Fri, 29 Nov 2019 22:04:21 +0000 (22:04 +0000)]
re PR rtl-optimization/92283 (454.calculix miscomparison since r276645 with -O2 -march=znver2)

2019-11-29  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/92283
* lra.c (lra): Update reg notes after inheritance sub-pass and
before constraint sub-pass.

From-SVN: r278865

4 years agore PR fortran/91003 (ICE when compiling LAPACK (CGEGV) with optimization)
Richard Biener [Fri, 29 Nov 2019 19:54:25 +0000 (19:54 +0000)]
re PR fortran/91003 (ICE when compiling LAPACK (CGEGV) with optimization)

2019-11-29  Richard Biener  <rguenther@suse.de>

PR tree-optimization/91003
* tree-vect-slp.c (vect_mask_constant_operand_p): Pass in the
operand number, avoid handling the non-condition operands of
COND_EXPRs as comparisons.
(vect_get_constant_vectors): Pass down the operand number.
(vect_get_slp_defs): Likewise.

* gfortran.dg/pr91003.f90: New testcase.

From-SVN: r278860

4 years agolibstdc++: Adjust some function templates for coding conventions
Jonathan Wakely [Fri, 29 Nov 2019 17:43:55 +0000 (17:43 +0000)]
libstdc++: Adjust some function templates for coding conventions

* include/bits/fs_path.h (path::operator/=): Change template-head to
use typename instead of class.
* include/experimental/bits/fs_path.h (path::operator/=): Likewise.
* include/std/ostream (operator<<): Likewise.

From-SVN: r278859

4 years agolibstdc++: P1423R3 char8_t remediation (4/4)
Tom Honermann [Fri, 29 Nov 2019 17:43:51 +0000 (17:43 +0000)]
libstdc++: P1423R3 char8_t remediation (4/4)

New tests

This patch adds new tests to validate new deleted overloads of wchar_t,
char8_t, char16_t, and char32_t for ordinary and wide formatted character and
string ostream inserters.

Additionally, new tests are added to validate invocations of u8path with
sequences of char8_t for both the C++17 and filesystem TS implementations.

2019-11-29  Tom Honermann  <tom@honermann.net>

New tests
* testsuite/27_io/basic_ostream/inserters_character/char/deleted.cc:
New test to validate deleted overloads of character and string
inserters for narrow ostreams.
* testsuite/27_io/basic_ostream/inserters_character/wchar_t/deleted.cc:
New test to validate deleted overloads of character and string
inserters for wide ostreams.
* testsuite/27_io/filesystem/path/factory/u8path-char8_t.cc: New test
to validate u8path invocations with sequences of char8_t.
* testsuite/experimental/filesystem/path/factory/u8path-char8_t.cc:
New test to validate u8path invocations with sequences of char8_t.

From-SVN: r278858

4 years agolibstdc++: P1423R3 char8_t remediation (3/4)
Tom Honermann [Fri, 29 Nov 2019 17:43:46 +0000 (17:43 +0000)]
libstdc++: P1423R3 char8_t remediation (3/4)

Updates to existing tests

This patch updates existing tests to validate the new value for the
__cpp_lib_char8_t feature test macros and to exercise u8path factory
function invocations with std::string, std::string_view, and interator
pair arguments.

2019-11-29  Tom Honermann  <tom@honermann.net>

Updates to existing tests
* testsuite/experimental/feat-char8_t.cc: Updated the expected
__cpp_lib_char8_t feature test macro value.
* testsuite/27_io/filesystem/path/factory/u8path.cc: Added testing of
u8path invocation with std::string, std::string_view, and iterators
thereof.
* testsuite/experimental/filesystem/path/factory/u8path.cc: Added
testing of u8path invocation with std::string, std::string_view, and
iterators thereof.

From-SVN: r278857

4 years agolibstdc++: P1423R3 char8_t remediation (2/4)
Tom Honermann [Fri, 29 Nov 2019 17:43:42 +0000 (17:43 +0000)]
libstdc++: P1423R3 char8_t remediation (2/4)

Update feature test macro, add deleted operators, update u8path

This patch increments the __cpp_lib_char8_t feature test macro, adds deleted
operator<< overloads for basic_ostream, and modifies u8path to accept
sequences of char8_t for both the C++17 implementation of std::filesystem, and
the filesystem TS implementation.

The implementation mechanism used for u8path differs between the C++17 and
filesystem TS implementations.  The changes to the former take advantage of
C++17 'if constexpr'.  The changes to the latter retain C++11 compatibility
and rely on tag dispatching.

2019-11-29  Tom Honermann  <tom@honermann.net>

Update feature test macro, add deleted operators, update u8path
* include/bits/c++config: Bumped the value of the __cpp_lib_char8_t
feature test macro.
* include/bits/fs_path.h (u8path): Modified u8path to accept sequences
of char8_t.
* include/experimental/bits/fs_path.h (u8path): Modified u8path to
accept sequences of char8_t.
* include/std/ostream: Added deleted overloads of wchar_t, char8_t,
char16_t, and char32_t for ordinary and wide formatted character and
string inserters.

From-SVN: r278856

4 years agolibstdc++: P1423R3 char8_t remediation (1/4)
Tom Honermann [Fri, 29 Nov 2019 17:43:37 +0000 (17:43 +0000)]
libstdc++: P1423R3 char8_t remediation (1/4)

Decouple constraints for u8path from path constructors

This patch moves helper classes and functions for std::filesystem::path out of
the class definition to a detail namespace so that they are available to the
implementations of std::filesystem::u8path.  Prior to this patch, the SFINAE
constraints for those implementations were specified via delegation to the
overloads of path constructors with a std::locale parameter; it just so
happened that those overloads had the same constraints.  As of P1423R3, u8path
and those overloads no longer have the same constraints, so this dependency
must be broken.

This patch also updates the experimental implementation of the filesystem TS
to add SFINAE constraints to its implementations of u8path.  These functions
were previously unconstrained and marked with a TODO comment.

This patch does not provide any intentional behavioral changes other than the
added constraints to the experimental filesystem TS implementation of u8path.

Alternatives to this refactoring would have been to make the u8path overloads
friends of class path, or to make the helpers public members. Both of those
approaches struck me as less desirable than this approach, though this
approach does require more code changes and will affect implementation detail
portions of mangled names for path constructors and inline member functions
(mostly function template specializations).

2019-11-29  Tom Honermann  <tom@honermann.net>

Decouple constraints for u8path from path constructors
* include/bits/fs_path.h: Moved helper utilities out of
std::filesystem::path into a detail namespace to make them
available for use by u8path.
* include/experimental/bits/fs_path.h: Moved helper utilities out
of std::experimental::filesystem::v1::path into a detail
namespace to make them available for use by u8path.

From-SVN: r278855

4 years agoFix ICE in re-simplification of VEC_COND_EXPR
Frederik Harwath [Fri, 29 Nov 2019 15:02:35 +0000 (15:02 +0000)]
Fix ICE in re-simplification of VEC_COND_EXPR

The function maybe_resimplify_conditional_op uses operation_could_trap_p to
check if the resulting operation of a simplification can trap.  Because of the
changes introduced by revision r276659, this results in an ICE due to a
violated assertion in operation_could_trap_p if the operation is a COND_EXPR or
a VEC_COND_EXPR.  The changes have allowed those expressions to trap and
whether they do cannot be determined without considering their condition
which is not available to operation_could_trap_p.

Change maybe_resimplify_conditional_op to inspect the condition of
COND_EXPRs and VEC_COND_EXPRs to determine if they can trap.

From-SVN: r278853

4 years agoFix DR_GROUP_GAP for strided accesses (PR 92677)
Richard Sandiford [Fri, 29 Nov 2019 14:48:30 +0000 (14:48 +0000)]
Fix DR_GROUP_GAP for strided accesses (PR 92677)

When dissolving an SLP-only group of accesses, we should only set
the gap to group_size - 1 for normal non-strided groups.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR tree-optimization/92677
* tree-vect-loop.c (vect_dissolve_slp_only_groups): Set the gap
to zero when dissolving a group of strided accesses.

gcc/testsuite/
PR tree-optimization/92677
* gcc.dg/vect/pr92677.c: New test.

From-SVN: r278852

4 years agoDon't defer choice of vector type for bools (PR 92596)
Richard Sandiford [Fri, 29 Nov 2019 14:47:44 +0000 (14:47 +0000)]
Don't defer choice of vector type for bools (PR 92596)

Now that stmt_vec_info records the choice between vector mask
types and normal nonmask types, we can use that information in
vect_get_vector_types_for_stmt instead of deferring the choice
of vector type till later.

vect_get_mask_type_for_stmt used to check whether the boolean inputs
to an operation:
(a) consistently used mask types or consistently used nonmask types; and
(b) agreed on the number of elements.

(b) shouldn't be a problem when (a) is met.  If the operation
consistently uses mask types, tree-vect-patterns.c will have corrected
any mismatches in mask precision.  (This is because we only use mask
types for a small well-known set of operations and tree-vect-patterns.c
knows how to handle any that could have different mask precisions.)
And if the operation consistently uses normal nonmask types, there's
no reason why booleans should need extra vector compatibility checks
compared to ordinary integers.

So the potential difficulties all seem to come from (a).  Now that
we've chosen the result type ahead of time, we also have to consider
whether the outputs and inputs consistently use mask types.

Taking each vectorizable_* routine in turn:

- vectorizable_call

    vect_get_vector_types_for_stmt only handled booleans specially
    for gassigns, so vect_get_mask_type_for_stmt never had chance to
    handle calls.  I'm not sure we support any calls that operate on
    booleans, but as things stand, a boolean result would always have
    a nonmask type.  Presumably any vector argument would also need to
    use nonmask types, unless it corresponds to internal_fn_mask_index
    (which is already a special case).

    For safety, I've added a check for mask/nonmask combinations here
    even though we didn't check this previously.

- vectorizable_simd_clone_call

    Again, vect_get_mask_type_for_stmt never had chance to handle calls.
    The result of the call will always be a nonmask type and the patch
    for PR 92710 rejects mask arguments.  So all booleans should
    consistently use nonmask types here.

- vectorizable_conversion

    The function already rejects any conversion between booleans in which
    one type isn't a mask type.

- vectorizable_operation

    This function definitely needs a consistency check, e.g. to handle
    & and | in which one operand is loaded from memory and the other is
    a comparison result.  Ideally we'd handle this via pattern stmts
    instead (like we do for the all-mask case), but that's future work.

- vectorizable_assignment

    VECT_SCALAR_BOOLEAN_TYPE_P requires single-bit precision, so the
    current code already rejects problematic cases.

- vectorizable_load

    Loads always produce nonmask types and there are no relevant inputs
    to check against.

- vectorizable_store

    vect_check_store_rhs already rejects mask/nonmask combinations
    via useless_type_conversion_p.

- vectorizable_reduction
- vectorizable_lc_phi

    PHIs always have nonmask types.  After the change above, attempts
    to combine the PHI result with a mask type would be rejected by
    vectorizable_operation.  (Again, it would be better to handle
    this using pattern stmts.)

- vectorizable_induction

    We don't generate inductions for booleans.

- vectorizable_shift

    The function already rejects boolean shifts via type_has_mode_precision_p.

- vectorizable_condition

    The function already rejects mismatches via useless_type_conversion_p.

- vectorizable_comparison

    The function already rejects comparisons between mask and nonmask types.
    The result is always a mask type.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR tree-optimization/92596
* tree-vect-stmts.c (vectorizable_call): Punt on hybrid mask/nonmask
operations.
(vectorizable_operation): Likewise, instead of relying on
vect_get_mask_type_for_stmt to do this.
(vect_get_vector_types_for_stmt): Always return a vector type
immediately, rather than deferring the choice for boolean results.
Use a vector mask type instead of a normal vector if
vect_use_mask_type_p.
(vect_get_mask_type_for_stmt): Delete.
* tree-vect-loop.c (vect_determine_vf_for_stmt_1): Remove
mask_producers argument and special boolean_type_node handling.
(vect_determine_vf_for_stmt): Remove mask_producers argument and
update calls to vect_determine_vf_for_stmt_1.  Remove doubled call.
(vect_determine_vectorization_factor): Update call accordingly.
* tree-vect-slp.c (vect_build_slp_tree_1): Remove special
boolean_type_node handling.
(vect_slp_analyze_node_operations_1): Likewise.

gcc/testsuite/
PR tree-optimization/92596
* gcc.dg/vect/bb-slp-pr92596.c: New test.
* gcc.dg/vect/bb-slp-43.c: Likewise.

From-SVN: r278851

4 years agoRecord the vector mask precision in stmt_vec_info
Richard Sandiford [Fri, 29 Nov 2019 14:47:39 +0000 (14:47 +0000)]
Record the vector mask precision in stmt_vec_info

search_type_for_mask uses a worklist to search a chain of boolean
operations for a natural vector mask type.  This patch instead does
that in vect_determine_stmt_precisions, where we also look for
overpromoted integer operations.  We then only need to compute
the precision once and can cache it in the stmt_vec_info.

The new function vect_determine_mask_precision is supposed
to handle exactly the same cases as search_type_for_mask_1,
and in the same way.  There's a lot we could improve here,
but that's not stage 3 material.

I wondered about sharing mask_precision with other fields like
operation_precision, but in the end that seemed too dangerous.
We have patterns to convert between boolean and non-boolean
operations and it would be very easy to get mixed up about
which case the fields are describing.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (stmt_vec_info::mask_precision): New field.
(vect_use_mask_type_p): New function.
* tree-vect-patterns.c (vect_init_pattern_stmt): Copy the
mask precision to the pattern statement.
(append_pattern_def_seq): Add a scalar_type_for_mask parameter
and use it to initialize the new stmt's mask precision.
(search_type_for_mask_1): Delete.
(search_type_for_mask): Replace with...
(integer_type_for_mask): ...this new function.  Use the information
cached in the stmt_vec_info.
(vect_recog_bool_pattern): Update accordingly.
(build_mask_conversion): Pass the scalar type associated with the
mask type to append_pattern_def_seq.
(vect_recog_mask_conversion_pattern): Likewise.  Call
integer_type_for_mask instead of search_type_for_mask.
(vect_convert_mask_for_vectype): Call integer_type_for_mask instead
of search_type_for_mask.
(possible_vector_mask_operation_p): New function.
(vect_determine_mask_precision): Likewise.
(vect_determine_stmt_precisions): Call it.

From-SVN: r278850

4 years agoMake vect_get_mask_type_for_stmt take a group size
Richard Sandiford [Fri, 29 Nov 2019 14:47:34 +0000 (14:47 +0000)]
Make vect_get_mask_type_for_stmt take a group size

This patch makes vect_get_mask_type_for_stmt and
get_mask_type_for_scalar_type take a group size instead of
the SLP node, so that later patches can call it before an
SLP node has been built.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vectorizer.h (get_mask_type_for_scalar_type): Replace
the slp_tree parameter with a group size parameter.
(vect_get_mask_type_for_stmt): Likewise.
* tree-vect-stmts.c (get_mask_type_for_scalar_type): Likewise.
(vect_get_mask_type_for_stmt): Likewise.
* tree-vect-slp.c (vect_slp_analyze_node_operations_1): Update
call accordingly.

From-SVN: r278849

4 years agoMake vectorizable_operation punt early on codes it doesn't handle
Richard Sandiford [Fri, 29 Nov 2019 14:47:28 +0000 (14:47 +0000)]
Make vectorizable_operation punt early on codes it doesn't handle

vectorizable_operation returned false for codes that are handled by
vectorizable_shift, but only after it had already done a lot of work.
Checking earlier should be more efficient and avoid polluting the logs
with duplicate info.

Also, there was no such early-out for comparisons or COND_EXPRs.
Fixing that avoids a false scan-tree-dump hit with a later patch.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* tree-vect-stmts.c (vectorizable_operation): Punt early
on codes that are handled elsewhere.

From-SVN: r278848

4 years agoImprove tree-vect-patterns.c handling of boolean comparisons
Richard Sandiford [Fri, 29 Nov 2019 14:47:20 +0000 (14:47 +0000)]
Improve tree-vect-patterns.c handling of boolean comparisons

vect_recog_bool_pattern assumed that a comparison between two booleans
should always become a comparison of vector mask types (implemented as an
XOR_EXPR).  But if the booleans in question are generated as data values
(e.g. because they're loaded directly from memory), we should treat them
like ordinary integers instead, just as we do for boolean logic ops whose
operands are loaded from memory.  vect_get_mask_type_for_stmt already
handled this case:

      /* We may compare boolean value loaded as vector of integers.
 Fix mask_type in such case.  */
      if (mask_type
  && !VECTOR_BOOLEAN_TYPE_P (mask_type)
  && gimple_code (stmt) == GIMPLE_ASSIGN
  && TREE_CODE_CLASS (gimple_assign_rhs_code (stmt)) == tcc_comparison)
mask_type = truth_type_for (mask_type);

and not handling it here complicated later patches.

The initial list of targets for vect_bool_cmp is deliberately conservative.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* doc/sourcebuild.texi (vect_bool_cmp): Document.
* tree-vect-patterns.c (search_type_for_mask_1): If neither
operand to a boolean comparison is a natural vector mask,
handle both operands like normal integers instead.

gcc/testsuite/
* gcc.dg/vect/vect-bool-cmp-2.c: New test.
* lib/target-supports.exp (check_effective_target_vect_bool_cmp): New
effective target procedure.

From-SVN: r278847

4 years agolibstdc++:: improve how pretty printers find node types (PR 91997)
Jonathan Wakely [Fri, 29 Nov 2019 14:47:03 +0000 (14:47 +0000)]
libstdc++:: improve how pretty printers find node types (PR 91997)

This fixes two related problems.

The iterators for node-based containers use nested typedefs such as
std::list<T>::iterator::_Node to denote their node types. As reported in
https://bugzilla.redhat.com/show_bug.cgi?id=1053438 those typedefs are
not always present in the debug info. That means the pretty printers
cannot find them using gdb.lookup_type (via the find_type helper).
Instead of looking up the nested typedefs this patch makes the printers
look up the actual class templates directly.

A related problem (and the original topic of PR 91997) is that GDB fails
to find types via gdb.lookup_type when printing a backtrace from a
non-C++ functiion: https://sourceware.org/bugzilla/show_bug.cgi?id=25234
That is also solved by not looking up the nested typedef.

PR libstdc++/91997
* python/libstdcxx/v6/printers.py (find_type): Fail more gracefully
if we run out of base classes to look at.
(llokup_templ_spec, lookup_node_type): New utilities to find node
types for node-based containers.
(StdListPrinter.children, NodeIteratorPrinter.__init__)
(NodeIteratorPrinter.to_string, StdSlistPrinter.children)
(StdSlistIteratorPrinter.to_string, StdRbtreeIteratorPrinter.__init__)
(StdMapPrinter.children, StdSetPrinter.children)
(StdForwardListPrinter.children): Use lookup_node_type instead of
find_type.
(StdListIteratorPrinter.__init__, StdFwdListIteratorPrinter.__init__):
Pass name of node type to NodeIteratorPrinter constructor.
(Tr1HashtableIterator.__init__): Rename argument.
(StdHashtableIterator.__init__): Likewise. Use lookup_templ_spec
instead of find_type.
* testsuite/libstdc++-prettyprinters/59161.cc: Remove workaround for
_Node typedef not being present in debuginfo.
* testsuite/libstdc++-prettyprinters/91997.cc: New test.

From-SVN: r278846

4 years agoFortran] OpenACC – permit common blocks in some clauses
Tobias Burnus [Fri, 29 Nov 2019 13:59:21 +0000 (13:59 +0000)]
Fortran] OpenACC â€“ permit common blocks in some clauses

        * testsuite/libgomp.oacc-fortran/declare-5.f90: Extend by
        adding a common-block test case.

From-SVN: r278845

4 years agotree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Bail out early for too large...
Richard Biener [Fri, 29 Nov 2019 13:53:10 +0000 (13:53 +0000)]
tree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Bail out early for too large objects.

2019-11-29  Richard Biener  <rguenther@suse.de>

* tree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Bail
out early for too large objects.

From-SVN: r278844

4 years agoFortran] OpenACC – permit common blocks in some clauses
Tobias Burnus [Fri, 29 Nov 2019 13:49:44 +0000 (14:49 +0100)]
Fortran] OpenACC â€“ permit common blocks in some clauses

        * fortran.dg/goacc/common-block-3.f90: Check that unused common-block
        variables do not get mapped.

Reviewed-by: Thomas Schwinge <thomas@codesourcery.com>
From-SVN: r278843

4 years agoAdd an x86_64 test for PR 92476
Martin Jambor [Fri, 29 Nov 2019 13:36:47 +0000 (14:36 +0100)]
Add an x86_64 test for PR 92476

2019-11-29  Martin Jambor  <mjambor@suse.cz>

PR ipa/92476
        * g++.dg/lto/pr92476_[01].C: New test.

From-SVN: r278842

4 years agoipa-cp: Avoid ICEs when looking at expanded thunks and unoptimized functions
Martin Jambor [Fri, 29 Nov 2019 13:29:35 +0000 (14:29 +0100)]
ipa-cp: Avoid ICEs when looking at expanded thunks and unoptimized functions

2019-11-29  Martin Jambor  <mjambor@suse.cz>

PR ipa/92476
* ipa-cp.c (set_single_call_flag): Set node_calling_single_call in
the summary only if the summary exists.
(find_more_scalar_values_for_callers_subset): Check node_dead in
the summary only if the summary exists.
(ipcp_store_bits_results): Ignore nodes without lattices.
(ipcp_store_vr_results): Likewise.
* cgraphclones.c: Include ipa-fnsummary.h and ipa-prop.h and the
header files required by them.
(cgraph_node::expand_all_artificial_thunks): Analyze expanded thunks.

From-SVN: r278841

4 years agoDon't pass booleans as mask types to simd clones (PR 92710)
Richard Sandiford [Fri, 29 Nov 2019 13:04:56 +0000 (13:04 +0000)]
Don't pass booleans as mask types to simd clones (PR 92710)

In this PR we assigned a vector mask type to the result of a comparison
and then tried to pass that mask type to a simd clone, which expected
a normal (non-mask) type instead.

This patch simply punts on call arguments that have a mask type.
A better fix would be to pattern-match the comparison to a COND_EXPR,
like we would if the comparison was stored to memory, but doing that
isn't gcc 9 or 10 material.

Note that this doesn't affect x86_64-linux-gnu because the ABI promotes
bool arguments to ints.

2019-11-29  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR tree-optimization/92710
* tree-vect-stmts.c (vectorizable_simd_clone_call): Reject
vector mask arguments.

gcc/testsuite/
PR tree-optimization/92710
* gcc.dg/vect/pr92710.c: New test.

From-SVN: r278839

4 years agogcc/testsuite/ChangeLog - fix date in date line
Tobias Burnus [Fri, 29 Nov 2019 12:24:27 +0000 (13:24 +0100)]
gcc/testsuite/ChangeLog - fix date in date line

From-SVN: r278837

4 years agoFix testcase - was missing -fopenacc
Tobias Burnus [Fri, 29 Nov 2019 12:18:50 +0000 (12:18 +0000)]
Fix testcase - was missing -fopenacc

        PR ipa/84963
        * gfortran.dg/goacc/pr84963.f90: Use dg-additional-options not
        dg-options as otherwise -fopenacc is not used.

From-SVN: r278836

4 years agoprofile-count.c (profile_count::to_cgraph_frequency, [...]): Check for compaibility...
Jan Hubicka [Fri, 29 Nov 2019 10:29:44 +0000 (11:29 +0100)]
profile-count.c (profile_count::to_cgraph_frequency, [...]): Check for compaibility of counts.

* profile-count.c (profile_count::to_cgraph_frequency,
profile_count::to_sreal_scale): Check for compaibility of counts.
* profile-count.h (compatible_p): Make public; add checking for
global0 versus global types.
* cgraph.c (cgraph_node::verify_node): Verify count compatibility.

From-SVN: r278835

4 years agoTestsuite: Turn off vect-epilogue-nomask for slp-rect-3
Tamar Christina [Fri, 29 Nov 2019 09:22:15 +0000 (09:22 +0000)]
Testsuite: Turn off vect-epilogue-nomask for slp-rect-3

Without epiloque no mask it would only try HI modes, but thanks to the
epiloques nomask It tries QI mode as well which succeeds.  The xfail
then generates an xpass since the condition on it checks for HI to SI
and not QI.

So I disabled the epiloque mask since it seems to violate the conditions
the test actually wanted to test for.

gcc/testsuite/ChangeLog:

* gcc.dg/vect/slp-reduc-3.c: Turn off epilogue-nomask.

From-SVN: r278834

4 years agore PR tree-optimization/92715 (error: position plus size exceeds size of referenced...
Richard Biener [Fri, 29 Nov 2019 09:18:48 +0000 (09:18 +0000)]
re PR tree-optimization/92715 (error: position plus size exceeds size of referenced object in  â€˜bit_field_ref’)

2019-11-29  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92715
* tree-ssa-forwprop.c (simplify_vector_constructor): Bail
out for uniform vectors and source vectors with less elements
than the destination.

* gcc.dg/torture/pr92715.c: New testcase.

From-SVN: r278833

4 years agore PR c++/60228 (ICE using lambda in #pragma omp declare reduction)
Jakub Jelinek [Fri, 29 Nov 2019 09:10:44 +0000 (10:10 +0100)]
re PR c++/60228 (ICE using lambda in #pragma omp declare reduction)

PR c++/60228
* parser.c (cp_parser_omp_declare_reduction_exprs): If
processing_template_decl, wrap the combiner or initializer
into EXPR_STMT.
* decl.c (start_preparsed_function): Don't start a lambda scope
for DECL_OMP_DECLARE_REDUCTION_P functions.
(finish_function): Don't finish a lambda scope for
DECL_OMP_DECLARE_REDUCTION_P functions, nor cp_fold_function
them nor cp_genericize them.
* mangle.c (decl_mangling_context): Look through
DECL_OMP_DECLARE_REDUCTION_P functions.
* semantics.c (expand_or_defer_fn_1): For DECL_OMP_DECLARE_REDUCTION_P
functions, use tentative linkage, don't keep their bodies with
-fkeep-inline-functions and return false at the end.

* g++.dg/gomp/openmp-simd-2.C: Don't expect bodies for
DECL_OMP_DECLARE_REDUCTION_P functions.

* testsuite/libgomp.c++/udr-20.C: New test.
* testsuite/libgomp.c++/udr-21.C: New test.

From-SVN: r278832

4 years agore PR c++/60228 (ICE using lambda in #pragma omp declare reduction)
Jakub Jelinek [Fri, 29 Nov 2019 09:08:46 +0000 (10:08 +0100)]
re PR c++/60228 (ICE using lambda in #pragma omp declare reduction)

PR c++/60228
* parser.c (cp_parser_omp_declare_reduction_exprs): If
processing_template_decl, wrap the combiner or initializer
into EXPR_STMT.
* decl.c (start_preparsed_function): Don't start a lambda scope
for DECL_OMP_DECLARE_REDUCTION_P functions.
(finish_function): Don't finish a lambda scope for
DECL_OMP_DECLARE_REDUCTION_P functions, nor cp_fold_function
them nor cp_genericize them.
* mangle.c (decl_mangling_context): Look through
DECL_OMP_DECLARE_REDUCTION_P functions.
* semantics.c (expand_or_defer_fn_1): For DECL_OMP_DECLARE_REDUCTION_P
functions, use tentative linkage, don't keep their bodies with
-fkeep-inline-functions and return false at the end.

* g++.dg/gomp/openmp-simd-2.C: Don't expect bodies for
DECL_OMP_DECLARE_REDUCTION_P functions.

* testsuite/libgomp.c++/udr-20.C: New test.
* testsuite/libgomp.c++/udr-21.C: New test.

From-SVN: r278831

4 years agoCheck for TYPE_NAME in type_with_linkage_p.
Martin Liska [Fri, 29 Nov 2019 09:03:25 +0000 (10:03 +0100)]
Check for TYPE_NAME in type_with_linkage_p.

2019-11-29  Martin Liska  <mliska@suse.cz>

PR lto/91574
* ipa-devirt.c (types_same_for_odr): Check for existence
of TYPE_NAMEs first.
2019-11-29  Martin Liska  <mliska@suse.cz>

PR lto/91574
* g++.dg/lto/pr91574_0.C: New test.

From-SVN: r278829

4 years agore PR tree-optimization/92704 (ICE: Segmentation fault (in process_bb))
Richard Biener [Fri, 29 Nov 2019 08:05:03 +0000 (08:05 +0000)]
re PR tree-optimization/92704 (ICE: Segmentation fault (in process_bb))

2019-11-29  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92704
* tree-if-conv.c (combine_blocks): Deal with virtual PHIs
in loops performing only loads.

* gcc.dg/torture/pr92704.c: New testcase.

From-SVN: r278828

4 years agoHandle C2x attributes in Objective-C.
Joseph Myers [Fri, 29 Nov 2019 01:06:57 +0000 (01:06 +0000)]
Handle C2x attributes in Objective-C.

When adding the initial support for C2x attributes, I deferred the
unbounded lookahead support required to support such attributes in
Objective-C (except for the changes to string literal handling, which
were the riskier piece of preparation for such lookahead support).
This patch adds that remaining ObjC support.

For C, the parser continues to work exactly as it did before.  For
ObjC, however, when checking for whether '[[' starts attributes, it
lexes however many tokens are needed to check for a matching ']]', but
in a raw mode that omits all the context-sensitive processing that
c_lex_with_flags normally does, so that that processing can be done
later when the right context-sensitive flags are set.  Those tokens
are saved in a separate raw_tokens vector in the parser, and normal
c_lex_one_token calls will get tokens from there and perform the
remaining processing on them, if any tokens are found there, so all
parsing not using the new interfaces gets the same tokens as it did
before.  (For C, this raw lexing never occurs and the vector of raw
tokens is always NULL.)

Bootstrapped with no regressions for x86_64-pc-linux-gnu.

gcc/c:
* c-parser.c (struct c_parser): Add members raw_tokens and
raw_tokens_used.
(c_lex_one_token): Add argument raw.  Handle lexing raw tokens and
using previously-lexed raw tokens.
(c_parser_peek_nth_token_raw)
(c_parser_check_balanced_raw_token_sequence): New functions.
(c_parser_nth_token_starts_std_attributes): Use
c_parser_check_balanced_raw_token_sequence for Objective-C.

gcc/testsuite:
* objc.dg/attributes/gnu2x-attr-syntax-1.m: New test.

From-SVN: r278827

4 years agoRemove unused decimal floating-point pointer types
Julian Brown [Fri, 29 Nov 2019 00:58:35 +0000 (00:58 +0000)]
Remove unused decimal floating-point pointer types

gcc/
* builtin-types.def (BT_DFLOAT32_PTR, BT_DFLOAT64_PTR,
BT_DFLOAT128_PTR) Remove.
* tree-core.h (TI_DFLOAT32_PTR_TYPE, TI_DFLOAT64_PTR_TYPE,
TI_DFLOAT128_PTR_TYPE): Remove.
* tree.c (build_common_type_nodes): Remove dfloat32_ptr_type_node,
dfloat64_ptr_type_node and dfloat128_ptr_type_node initialisation.
* tree.h (dfloat32_ptr_type_node, dfloat64_ptr_type_node,
dfloat128_ptr_type_node): Remove macros.

gcc/jit/
* jit-builtins.c (BT_DFLOAT32_PTR, BT_DFLOAT64_PTR, BT_DFLOAT128_PTR):
Remove commented-out cases.

Reviewed-by: Joseph Myers <joseph@codesourcery.com>
From-SVN: r278826

4 years agoDaily bump.
GCC Administrator [Fri, 29 Nov 2019 00:16:20 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r278825

4 years agors6000: Fix formatting of *mov{si,di}_internal.*
Segher Boessenkool [Thu, 28 Nov 2019 23:50:06 +0000 (00:50 +0100)]
rs6000: Fix formatting of *mov{si,di}_internal.*

* config/rs6000/rs6000.md (*movsi_internal1): Fix formatting.  Improve
formatting.
(*movdi_internal64): Ditto.

From-SVN: r278822

4 years agors6000: Use memory_operand for all simple {l,st}*brx instructions
Segher Boessenkool [Thu, 28 Nov 2019 22:28:59 +0000 (23:28 +0100)]
rs6000: Use memory_operand for all simple {l,st}*brx instructions

We run fwprop before combine, very early even in the case of fwprop1;
and fwprop1 will change memory addressing to what it considers cheaper.
After the "common" change, it now changes the indexed store instruction
in the testcase to be to a constant address.  But that is not an
improvement at all: the byte reverse instructions only exist in the
indexed form, so they will not match anymore.

This patch changes the patterns for the byte reverse instructions to
allow plain memory_operand, letting reload fix this up.

PR target/92602
* config/rs6000/rs6000.md (bswap<mode>2_load for HSI): Change the
indexed_or_indirect_operand to be memory_operand.
(bswap<mode>2_store for HSI): Ditto.
(bswapdi2_load): Ditto.
(bswapdi2_store): Ditto.

From-SVN: r278821

4 years agoTranslate header for -fdbg-cnt-list.
Martin Liska [Thu, 28 Nov 2019 20:56:51 +0000 (21:56 +0100)]
Translate header for -fdbg-cnt-list.

2019-11-28  Martin Liska  <mliska@suse.cz>

PR debug/46558
* dbgcnt.c (dbg_cnt_list_all_counters): Mark table
headers for translation.

From-SVN: r278820

4 years agoProperly use TYPE_MAIN_VARIANT in warn_types_mismatch.
Martin Liska [Thu, 28 Nov 2019 20:56:23 +0000 (21:56 +0100)]
Properly use TYPE_MAIN_VARIANT in warn_types_mismatch.

2019-11-28  Martin Liska  <mliska@suse.cz>

PR lto/92609
* ipa-devirt.c (warn_types_mismatch): Use TYPE_MAIN_VARIANT
consistently.
2019-11-28  Martin Liska  <mliska@suse.cz>

PR lto/92609
* g++.dg/lto/pr92609_0.C: New test.
* g++.dg/lto/pr92609_1.C: New test.

From-SVN: r278819

4 years ago[Darwin, X86, testsuite] Update tests for common section use.
Iain Sandoe [Thu, 28 Nov 2019 19:41:55 +0000 (19:41 +0000)]
[Darwin, X86, testsuite] Update tests for common section use.

The switch to default of no-common means that we no longer
indirect the accesses to 'xxx' in this test.  Adjust the scan-
assembler tests to reflect this.

gcc/testsuite/ChangeLog:

2019-11-28  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/i386/pr32219-2.c: Adjust scan-assembler entries
for revised common default.

From-SVN: r278818

4 years agore PR libfortran/90374 (Fortran 2018: Support d0.d, e0.d, es0.d, en0.d, g0.d and...
Jerry DeLisle [Thu, 28 Nov 2019 18:33:20 +0000 (18:33 +0000)]
re PR libfortran/90374 (Fortran 2018: Support d0.d, e0.d, es0.d, en0.d, g0.d and ew.d e0 edit descriptors for output)

PR fortran/90374
* io.c (check_format): Allow zero width expoenent with e0.

* io/format.c (parse_format_list): Relax format checking to allow
e0 exponent specifier.

* gfortran.dg/fmt_zero_width.f90: Update test.

From-SVN: r278817

4 years agoRemove leftover optimize checks.
Jan Hubicka [Thu, 28 Nov 2019 17:51:40 +0000 (18:51 +0100)]
Remove leftover optimize checks.

* ipa-inline.c (want_early_inline_function_p): Remove leftover optimize
checks.

From-SVN: r278816

4 years agoprofile-count.c (profile_count::combine_with_ipa_count): Return uninitialized count...
Jan Hubicka [Thu, 28 Nov 2019 17:04:41 +0000 (18:04 +0100)]
profile-count.c (profile_count::combine_with_ipa_count): Return uninitialized count if called on ininitialized count.

* profile-count.c (profile_count::combine_with_ipa_count): Return
uninitialized count if called on ininitialized count.

From-SVN: r278815

4 years agoPrevent inconsistent profiles to be created in inlin_transform
Jan Hubicka [Thu, 28 Nov 2019 16:59:43 +0000 (17:59 +0100)]
Prevent inconsistent profiles to be created in inlin_transform

* ipa-inline-transform.c (inline_transform): Scale profile before
redirecting.

From-SVN: r278814

4 years agoprofile-count.h (profile_count::max): Work on profiles of different type.
Jan Hubicka [Thu, 28 Nov 2019 16:58:24 +0000 (17:58 +0100)]
profile-count.h (profile_count::max): Work on profiles of different type.

* profile-count.h (profile_count::max): Work on profiles of different
type.
(profile_count::apply_scale): Be sure that ret is not local or global0
type if num is global.

From-SVN: r278813

4 years agocgraph: ifunc resolvers cannot be made local (PR 92697)
Martin Jambor [Thu, 28 Nov 2019 15:39:48 +0000 (16:39 +0100)]
cgraph: ifunc resolvers cannot be made local (PR 92697)

2019-11-28  Martin Jambor  <mjambor@suse.cz>

PR ipa/92697
* cgraph.c (cgraph_node_cannot_be_local_p_1): Return true for
ifunc_resolvers.
* symtab.c (symtab_node::dump_base): Dump ifunc_resolver flag.
Removed trailig whitespace.

testsuite/
* g++.dg/ipa/pr92697.C: New.

From-SVN: r278812

4 years agoFix previous commit (that included unrelated changes)
Jan Hubicka [Thu, 28 Nov 2019 14:50:19 +0000 (14:50 +0000)]
Fix previous commit (that included unrelated changes)

This patch fixes profile updates while cloning.  When new clone is produced
its global profile is subtracted from the original function.  If the original
function profile drops to 0 we want to switch from global profiles to global0
profiles which is implemented by combine_with_ipa_count_within.

However this is done on all edges independnetly and it may happen that we end
up combining global and globa0 profiles in one functions which is not a good
idea.

This implements profile_count::combine_with_ipa_count_within which is able
to take into account that the counter is inside function with a given count.

* profile-count.h (profile_count::combine_with_ipa_count_within):
Declare.
* profile-count.c (profile_count::combine_with_ipa_count_within):
New.
* cgraphclones.c (cgraph_edge::clone, cgraph_node::create_clone): Use
it.

From-SVN: r278811

4 years agoFix profile adjusments while cloning
Jan Hubicka [Thu, 28 Nov 2019 14:44:08 +0000 (15:44 +0100)]
Fix profile adjusments while cloning

This patch fixes profile updates while cloning.  When new clone is produced
its global profile is subtracted from the original function.  If the original
function profile drops to 0 we want to switch from global profiles to global0
profiles which is implemented by combine_with_ipa_count_within.

However this is done on all edges independnetly and it may happen that we end
up combining global and globa0 profiles in one functions which is not a good
idea.

This implements profile_count::combine_with_ipa_count_within which is able
to take into account that the counter is inside function with a given count.

* profile-count.h (profile_count::combine_with_ipa_count_within):
Declare.
* profile-count.c (profile_count::combine_with_ipa_count_within):
New.
* cgraphclones.c (cgraph_edge::clone, cgraph_node::create_clone): Use
it.

From-SVN: r278810

4 years agoipa-utils.c (ipa_merge_profiles): Be sure that all type transtions of counters are...
Jan Hubicka [Thu, 28 Nov 2019 14:21:08 +0000 (15:21 +0100)]
ipa-utils.c (ipa_merge_profiles): Be sure that all type transtions of counters are done same way.

* ipa-utils.c (ipa_merge_profiles): Be sure that all type transtions
of counters are done same way.

From-SVN: r278809

4 years ago* ipa-cp.c (update_profiling_info): Fix scaling.
Jan Hubicka [Thu, 28 Nov 2019 14:16:29 +0000 (15:16 +0100)]
* ipa-cp.c (update_profiling_info): Fix scaling.

From-SVN: r278808

4 years agore PR tree-optimization/92645 (Hand written vector code is 450 times slower when...
Richard Biener [Thu, 28 Nov 2019 12:26:50 +0000 (12:26 +0000)]
re PR tree-optimization/92645 (Hand written vector code is 450 times slower when compiled with GCC compared to Clang)

2019-11-28  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92645
* tree-inline.c (remap_gimple_stmt): When the return value
is not wanted, elide GIMPLE_RETURN.

* gcc.dg/tree-ssa/inline-12.c: New testcase.

From-SVN: r278807

4 years agore PR tree-optimization/92645 (Hand written vector code is 450 times slower when...
Richard Biener [Thu, 28 Nov 2019 12:22:04 +0000 (12:22 +0000)]
re PR tree-optimization/92645 (Hand written vector code is 450 times slower when compiled with GCC compared to Clang)

2019-11-28  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92645
* tree-ssa-forwprop.c (get_bit_field_ref_def): Also handle
conversions inside a mode class.  Remove restriction on
preserving the element size.
(simplify_vector_constructor): Deal with the above and for
identity permutes also try using VEC_UNPACK_[FLOAT_]LO_EXPR
and VEC_PACK_TRUNC_EXPR.

* gcc.target/i386/pr92645-4.c: New testcase.

From-SVN: r278806

4 years agoMust use push insn to pass varargs arguments of DFmode because otherwise the middle...
Georg-Johann Lay [Thu, 28 Nov 2019 10:29:30 +0000 (10:29 +0000)]
Must use push insn to pass varargs arguments of DFmode because otherwise the middle-end generates wrong code.

Must use push insn to pass varargs arguments of DFmode because
otherwise the middle-end generates wrong code.
PR target/92055
* config/avr/avr.md (MPUSH) [DF, DC]: Add modes to mode iterator.

From-SVN: r278805

4 years ago[testsuite][arm] Force use of -mfloat-abi=softfp in asm-flag-4.c
Christophe Lyon [Thu, 28 Nov 2019 09:16:55 +0000 (09:16 +0000)]
[testsuite][arm] Force use of -mfloat-abi=softfp in asm-flag-4.c

The asm-flag-4.c test forces the generation of Thumb code for armv4t,
which is not supported when using the 'hard' FP ABI. This patch
ensures the test uses -mfloat-abi=softfp safely, to avoid irrelevant
failures.

2019-11-28  Christophe Lyon  <christophe.lyon@linaro.org>

* gcc.target/arm/asm-flag-4.c: Use -mfloat-abi=softfp.

From-SVN: r278804

4 years agore PR tree-optimization/92691 (ICE in strlen_dom_walker::before_dom_children at gcc...
Jakub Jelinek [Thu, 28 Nov 2019 08:36:06 +0000 (09:36 +0100)]
re PR tree-optimization/92691 (ICE in strlen_dom_walker::before_dom_children at gcc/tree-ssa-strlen.c:5177 since r274933)

PR tree-optimization/92691
* tree-ssa-strlen.c (handle_store): Clarify return value meaning
in function comment.
(strlen_check_and_optimize_call): Likewise.  For handle_printf_call
calls, return !handle_printf_call rather than always returning true.
(check_and_optimize_stmt): Describe return value meaning in function
comment.  Formatting fix.

* gcc.dg/tree-ssa/builtin-snprintf-10.c: New test.

From-SVN: r278803

4 years agore PR c++/92695 (P1064R0 - virtual constexpr fails if object taken from array)
Jakub Jelinek [Thu, 28 Nov 2019 08:06:09 +0000 (09:06 +0100)]
re PR c++/92695 (P1064R0 - virtual constexpr fails if object taken from array)

PR c++/92695
* decl2.c (mark_used): Don't call note_vague_linkage_fn for pure
virtual functions, even if they are declared inline.

* g++.dg/warn/inline3.C: New test.

From-SVN: r278802

4 years agoHandle correctly global0 and global counters in profile_count::to_sreal_scale
Jan Hubicka [Thu, 28 Nov 2019 07:31:26 +0000 (08:31 +0100)]
Handle correctly global0 and global counters in profile_count::to_sreal_scale

This patch fixes problem in profile_count::to_sreal_scale.  We our porfile
counters can be function local, global (ipa) or function local but globally 0.
The last is used to hold static estimates for functions executed 0 times in
profile.  Now only one 64bit value is stored and if we compute frequency
of global0 counter in global counter we mix them up and return non-zero value
incorrectly.

I also implemented unit test, but will commit sanity checking separately from
fixes: there are multiple bugs in this area I tracked down.

* profile-count.c (profile_count::to_sreal_scale): Handle correctly
combination of globa0 and global counters..

From-SVN: r278801

4 years ago[rs6000] Fix PR92566 by checking VECTOR_UNIT_NONE_P
Kewen Lin [Thu, 28 Nov 2019 06:34:31 +0000 (06:34 +0000)]
[rs6000] Fix PR92566 by checking VECTOR_UNIT_NONE_P

As Segher pointed out in PR92566, we shouldn't offer some vector modes which
aren't supported under current setting.  This patch is to make it check by
VECTOR_UNIT_NONE_P which is initialized as current architecture masks.

2019-11-28  Kewen Lin  <linkw@gcc.gnu.org>

    PR target/92566
    * gcc/config/rs6000/rs6000.c (rs6000_preferred_simd_mode): Check by
    VECTOR_UNIT_NONE_P instead.

From-SVN: r278800

4 years agosse.md (avx512f_maskcmp<mode>3): Refine VF to VF_AVX512VL.
Hongtao Liu [Thu, 28 Nov 2019 05:20:37 +0000 (05:20 +0000)]
sse.md (avx512f_maskcmp<mode>3): Refine VF to VF_AVX512VL.

* gcc/config/i386/sse.md (avx512f_maskcmp<mode>3):
 Refine VF to VF_AVX512VL.

From-SVN: r278799

4 years agoDaily bump.
GCC Administrator [Thu, 28 Nov 2019 00:16:21 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r278794

4 years agoReformat movdi_internal64.
Michael Meissner [Thu, 28 Nov 2019 00:11:28 +0000 (00:11 +0000)]
Reformat movdi_internal64.

2019-11-26  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/rs6000.md (movdi_internal64): Reformat.

From-SVN: r278788

4 years agoReformat movsi_internal.
Michael Meissner [Wed, 27 Nov 2019 23:04:04 +0000 (23:04 +0000)]
Reformat movsi_internal.

2019-11-27  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/rs6000.md (movsi_internal): Reformat.

From-SVN: r278787

4 years agoImplement P1814R0, CTAD for alias templates.
Jason Merrill [Wed, 27 Nov 2019 22:05:53 +0000 (17:05 -0500)]
Implement P1814R0, CTAD for alias templates.

This patch implements C++20 class template argument deduction for alias
templates, which works by a moderately arcane transformation of the
deduction guides for the underlying class template.  When implementing it,
it seemed that I could simplify the rules in the draft a bit and get
essentially the same effect; I'll be emailing the committee to that effect
soon.

gcc/cp/
* pt.c (rewrite_tparm_list): Factor out of build_deduction_guide.
(maybe_aggr_guide): Check for copy-init here.
(alias_ctad_tweaks, deduction_guides_for): New.
(ctor_deduction_guides_for): Factor out of do_class_deduction.
(ctad_template_p): New.
* parser.c (cp_parser_simple_type_specifier): Use it.
* constraint.cc (append_constraint): New.
gcc/c-family/
* c-cppbuiltin.c (c_cpp_builtins): Update __cpp_deduction_guides.

From-SVN: r278786

4 years agoFix constrained alias template transparency.
Jason Merrill [Wed, 27 Nov 2019 22:05:47 +0000 (17:05 -0500)]
Fix constrained alias template transparency.

A constrained alias template can't be treated as equivalent to its
underlying template/type for much the same reason that an alias template
like void_t can't; we're relying on checking during substitution.

* cxx-pretty-print.c (pp_cxx_unqualified_id): Handle alias
template-id.
* pt.c (complex_alias_template_p): True if constraints.
(get_underlying_template, tsubst): Check alias constraints.
(push_template_decl_real): Set alias constraints here.
* parser.c (cp_parser_alias_declaration): Not here.
* constraint.cc (get_constraints): Take const_tree.

From-SVN: r278785

4 years agoPR c++/92206 - ICE with typedef to dependent alias.
Jason Merrill [Wed, 27 Nov 2019 22:05:41 +0000 (17:05 -0500)]
PR c++/92206 - ICE with typedef to dependent alias.

rsandifo's patch for 92206 demonstrated a problem with the existing checking
for alias template specializations: they were returning false for a typedef
to an alias template specialization.  Which is sometimes what the caller
wants, and sometimes not: Sometimes we're interested in whether the type was
written as an alias template-id, and sometimes whether it represents one.

The testcase illustrates a case that remained wrong with the earlier patch:
if the typedef is itself an alias template specialization, we can't strip an
underlying dependent alias.

* pt.c (dependent_alias_template_spec_p)
(alias_template_specialization_p): Add transparent_typedefs
parameter.
(iterative_hash_template_arg, any_template_parm_r)
(primary_template_specialization_p, tsubst, dependent_type_p_r):
Adjust.
* decl.c (check_elaborated_type_specifier): Adjust.
* error.c (dump_template_bindings, dump_aggr_type): Adjust.

From-SVN: r278784

4 years agoDo not define DFP builtin functions, if DFP has been disabled.
Peter Bergner [Wed, 27 Nov 2019 20:55:56 +0000 (20:55 +0000)]
Do not define DFP builtin functions, if DFP has been disabled.

PR bootstrap/92661
* config/rs6000/rs6000-call.c: (def_builtin): Do not define the
builtin if we don't have an actual type.
(builtin_function_type): If the builtin function uses a DFP type
and decimal float has been disabled, then return NULL_TREE.

From-SVN: r278783

4 years agoFix 'libgomp.fortran/target-print-1.f90', 'libgomp.oacc-fortran/print-1.f90' for...
Thomas Schwinge [Wed, 27 Nov 2019 17:50:55 +0000 (18:50 +0100)]
Fix 'libgomp.fortran/target-print-1.f90', 'libgomp.oacc-fortran/print-1.f90' for offload target nvptx

libgomp/
* testsuite/lib/libgomp.exp
(check_effective_target_offload_target_nvptx): New proc.
* testsuite/libgomp.fortran/target-print-1.f90: Use it with
'dg-skip-if'.
* testsuite/libgomp.oacc-fortran/print-1.f90: Likewise.
* testsuite/libgomp.fortran/target-print-1-nvptx.f90: New file.
* testsuite/libgomp.oacc-fortran/print-1-nvptx.f90: Likewise.

From-SVN: r278779

4 years agore PR rtl-optimization/92510 (ICE in native_encode_rtx, at simplify-rtx.c:6272)
Jakub Jelinek [Wed, 27 Nov 2019 16:32:54 +0000 (17:32 +0100)]
re PR rtl-optimization/92510 (ICE in native_encode_rtx, at simplify-rtx.c:6272)

PR rtl-optimization/92510
* combine.c (gen_lowpart_for_combine): Only transform lowpart subreg
of comparison into a comparison with different mode if both imode and
omode are scalar integral modes.

* gcc.dg/pr92510.c: New test.

From-SVN: r278777

4 years agore PR c++/92236 ([concepts] Explain non-satisfaction in static_assert)
Andrew Sutton [Wed, 27 Nov 2019 15:23:02 +0000 (15:23 +0000)]
re PR c++/92236 ([concepts] Explain non-satisfaction in static_assert)

2019-11-27  Andrew Sutton  <asutton@lock3software.com>

PR c++/92236
Defer evaluation of concept checks so that static assertions can
emit more detailed diagnostics.

gcc/cp/
* constexpr.c (cxx_eval_call_expression): Handle concept checks.
(cxx_eval_constant_expression): Diagnose misuse of function concepts
as template-id expressions. Follow the usual return path for results.
(cxx_eval_outermost_constant_expr): Avoid calling
cp_get_callee_fndecl_nofold for function concepts.
* constraint.cc (build_function_check): Fully type the concept check
so that we don't ICE in conversions.
* cp-gimplify.c (cp_genericize_r) [CALL_EXPR]: Handle concept checks.
[TEMPLATE_ID_EXPR] Likewise.
* cvt.c (convert_to_void): Always evaluate concept checks so we don't
accidentally ignore them. Substitution during satisfaction can make
a program ill-formed (example in g++.dg/cpp2a/concepts6.C).
* pt.c (tsubst_copy_and_build): [CALL_EXPR]: Don't evaluate concepts.
[TEMPLATE_ID_EXPR]: Likewise.
* semantics.c (finish_call_expr): Don't evaluate concepts.
(finish_id_expression_1): Likewise.
(finish_static_assert): Preserve the original condition so we can
diagnose concept errors when a check returns false.

gcc/testsuite/
* g++.dg/cpp2a/concepts-iconv1.C: Update diagnostics.
* g++.dg/cpp2a/concepts-requires5.C: Likewise.
* g++.dg/cpp2a/concepts6.C: New test.

From-SVN: r278775

4 years agore PR c++/92439 ([concepts] trunk crashes on constraint satisfaction failure)
Andrew Sutton [Wed, 27 Nov 2019 15:16:37 +0000 (15:16 +0000)]
re PR c++/92439 ([concepts] trunk crashes on constraint satisfaction failure)

2019-11-27  Andrew Sutton  <asutton@lock3software.com>

PR c++/92439
Improve quality of diagnostics for subexpressions that need parens.

gcc/cp/
* parser.c (cp_parser_requires_clause_opt): Add a flag to indicate
when parsing a requires-clause before lambda parameters, and...
(cp_parser_lambda_declarator_opt): ... use that here ...
(cp_parser_type_parameter): ... and here ...
(cp_parser_late_return_type_opt): ... and here ...
(cp_parser_explicit_template_declaration): ... and here.
(cp_parser_diagnose_ungrouped_constraint_plain): Adjust the message
because this can apply to subexpressions that are not immediately
after a requires-clause.
(cp_parser_diagnose_ungrouped_constraint_rich): Likewise.
(primary_constraint_error): New.
(cp_parser_constraint_requires_parens): New.
(cp_parser_unary_constraint_requires_parens): New.
(cp_parser_constraint_primary_expression): Check for unary expressions
before parsing the primary expression. Also check for binary and
postfix operators after a successful parse of the primary expression.
Force a re-parse if the result would form a lower-precedence string.
(cp_parser_constraint_logical_and_expression): Propagate lambda flag;
move checks for ill-formed constraints into the constraint primary
expression.
(cp_parser_constraint_logical_or_expression): Likewise.
(cp_parser_requires_clause_expression): Propagate lambda flag.

gcc/testsuite/
* g++.dg/cpp2a/concepts-requires20.C: New.

From-SVN: r278774

4 years agore PR c++/88395 (ICE: Segmentation fault signal terminated program cc1plus, with...
Andrew Sutton [Wed, 27 Nov 2019 15:09:22 +0000 (15:09 +0000)]
re PR c++/88395 (ICE: Segmentation fault signal terminated program cc1plus, with -std=c++2a -fconcepts)

2019-11-27  Andrew Sutton  <asutton@lock3software.com>

PR c++/88395
Prevent recursive satisfaction by adding requests to the instantiation
stack.

gcc/cp/
* constraint.cc (satisfy_declaration_constraints): Push tinst levels
around satisfaction.

gcc/testsuite/
* g++.dg/cpp2a/concepts-pr88395.C: New.
* g++.dg/cpp2a/concepts-recursive-sat1.C: New.
* g++.dg/cpp2a/concepts-recursive-sat2.C: New.
* g++.dg/cpp2a/concepts-recursive-sat3.C: New.

From-SVN: r278773

4 years agore PR rtl-optimization/90007 (ICE in extract_constrain_insn_cached, at recog.c:2223)
Vladimir Makarov [Wed, 27 Nov 2019 14:24:47 +0000 (14:24 +0000)]
re PR rtl-optimization/90007 (ICE in extract_constrain_insn_cached, at recog.c:2223)

2019-11-27  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/90007
* recog.c (constrain_operands): Permit hard registers too for
memory when LRA is used.

2019-11-27  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/90007
* gcc.target/i386/pr90007.c: New test.

From-SVN: r278770

4 years agoDiagnose certain constraint errors as hard errors, but otherwise treat them the same...
Andrew Sutton [Wed, 27 Nov 2019 14:02:49 +0000 (14:02 +0000)]
Diagnose certain constraint errors as hard errors, but otherwise treat them the same as normal SFINAE-type errors.

2019-11-27  Andrew Sutton  <asutton@lock3software.com>

Diagnose certain constraint errors as hard errors, but otherwise treat
them the same as normal SFINAE-type errors. Also, generally clean up
the satisfaction functions.

gcc/cp/
* constexpr.c (cxx_eval_constant_expression): Use
evaluate_concept_check.
* constraint.cc (normalize_concept_definition): Accept a diagnostic
flag and only cache when not diagnosing errors.
(decl_satisfied_cache): Map to trees instead of bools.
(satisfy_atom): Guarantee a location for the errors, propagate complain
flags to force_rvalue, and emit errors for non-boolean constraints.
(get_normalized_constraints_and_args): New overloads. Factored out of
satisfy_constraint_expression and satisfy_declaration_constraints.
(satisfy_constraint_expression): Propagate diagnostic info to
normalization.
(satisfy_declaration_constraints): New. Factored out of
constraints_satisfied_p.
(constraint_satisfaction_value): New. Calls
satisfy_constraint_expression or satisfy_declaration_constraints.
(constraints_satisfied_p): Call constraint_satisfaction_value.
(evaluate_concept_check): Don't take tsubst_falgs_t. Replay
satisfaction if an error is encountered.
(current_failed_constraint): Moved from pt.c.
(diagnose_constraints): Call constraint_satisfaction_value.
* cp-tree.h: Update declarations.
* pt.c (current_failed_constraint): Moved to constraint.cc.
* semantics.c (finish_id_expression_1): Remove a duplicate case.

gcc/testsuite/
* g++.dg/concepts/pr84330.C: Update diagnostics.
* g++.dg/cpp2a/concepts-requires2.C: Likewise.

From-SVN: r278768

4 years agom68k.c (m68k_output_compare_fp): Restore differences between Coldfire and regular...
Bernd Schmidt [Wed, 27 Nov 2019 13:07:44 +0000 (13:07 +0000)]
m68k.c (m68k_output_compare_fp): Restore differences between Coldfire and regular m68k.

* config/m68k/m68k.c (m68k_output_compare_fp): Restore differences
between Coldfire and regular m68k.
* config/m68k/m68k.md (cmp1_cf_constraints): Disallow constants.

From-SVN: r278767

4 years agotarget.def (TARGET_VECTORIZE_BUILTIN_CONVERSION): Remove.
Richard Biener [Wed, 27 Nov 2019 12:22:02 +0000 (12:22 +0000)]
target.def (TARGET_VECTORIZE_BUILTIN_CONVERSION): Remove.

2019-11-27  Richard Biener  <rguenther@suse.de>

* target.def (TARGET_VECTORIZE_BUILTIN_CONVERSION): Remove.
* targhooks.c (default_builtin_vectorized_conversion): Likewise.
* targhooks.h (default_builtin_vectorized_conversion): Likewise.
* optabs-tree.c (supportable_convert_operation): Do not call
targetm.vectorize.builtin_conversion.  Remove unused decl parameter.
* optabs-tree.h (supportable_convert_operation): Adjust.
* doc/tm.texi.in (TARGET_VECTORIZE_BUILTIN_CONVERSION): Remove.
* doc/tm.texi: Regenerate.
* tree-ssa-forwprop.c (simplify_vector_constructor): Adjust.
* tree-vect-generic.c (expand_vector_conversion): Likewise.
* tree-vect-stmts.c (vect_gen_widened_results_half): Remove
unused decl parameter and adjust.
(vect_create_vectorized_promotion_stmts): Likewise.
(vectorizable_conversion): Adjust.

From-SVN: r278765

4 years agore PR tree-optimization/92690 (vector CTOR optimization performs invalid conversion)
Richard Biener [Wed, 27 Nov 2019 12:16:54 +0000 (12:16 +0000)]
re PR tree-optimization/92690 (vector CTOR optimization performs invalid conversion)

2019-11-27  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92690
* tree-ssa-forwprop.c (simplify_vector_constructor): Avoid
converting elements not originally converted.

* gcc.dg/torture/pr92690.c: New testcase.
* gcc.dg/tree-ssa/forwprop-35.c: Adjust.

From-SVN: r278764

4 years agore PR fortran/91944 (ICE in gfc_conv_array_initializer, at fortran/trans-array.c...
Jakub Jelinek [Wed, 27 Nov 2019 10:00:50 +0000 (11:00 +0100)]
re PR fortran/91944 (ICE in gfc_conv_array_initializer, at fortran/trans-array.c:6156)

PR fortran/91944
* simplify.c (gfc_simplify_spread): Check gfc_init_expr_flag instead
of gfc_current_ns->sym_root->n.sym->attr.flavor == FL_PARAMETER.

* gfortran.dg/spread_size_limit_2.f90: New test.

From-SVN: r278762

4 years agoPR 92463 - Cleanups due to minimum MPFR version bump to 3.1.0
Tobias Burnus [Wed, 27 Nov 2019 09:16:24 +0000 (10:16 +0100)]
PR 92463 - Cleanups due to minimum MPFR version bump to 3.1.0

        PR middle-end/92463
        * configure.ac: Use MPFR_RNDN instead of GMP's MP_RNDN.
        * configure: Regenerate

        gcc/
        PR middle-end/92463
        * builtins.c (do_mpfr_ckconv, do_mpc_ckconv, do_mpfr_remquo,
        do_mpfr_lgamma_r, do_mpc_arg2): Use MPFR_RNDx instead of GMP_RNDx,
        mpfr_rnd_t instead of mp_rnd_t.
        * fold-const-call.c (do_mpfr_ckconv, do_mpfr_arg1, do_mpfr_sincos,
        do_mpfr_arg2, do_mpfr_arg3, do_mpc_arg1, do_mpc_arg2): Likewise.
        * gimple-ssa-sprintf.c (format_floating_max, format_floating):
        Use mpfr_exp_t instead of mp_exp_t.
        * real.c (real_from_string, dconst_e_ptr, dconst_sqrt2_ptr): Use
        MPFR_RNDx instead of GMP_RNDx.
        * realmpfr.c (real_from_mpfr, mpfr_from_real): Use mpfr_rnd_t and
        mpfr_exp_t instead mp_rnd_t and mp_exp_t, respectively.
        * realmpfr.h (real_from_mpfr, mpfr_from_real): Use mpfr_rnd_t instead
        of mp_rnd_t and remove MPFR_RNDx poisoning.
        * ubsan.c (ubsan_instrument_float_cast): MPFR_RNDx instead of GMP_RNDx.

        fortran/
        PR middle-end/92463
        * arith.c (gfc_check_real_range): Replace mp_exp_t by mpfr_exp_t.

From-SVN: r278761

4 years ago[PATCH] Fix PR91790 by considering different first_stmt_info for realign
Kewen Lin [Wed, 27 Nov 2019 09:08:20 +0000 (09:08 +0000)]
[PATCH] Fix PR91790 by considering different first_stmt_info for realign

As PR91790 exposed, when we have one slp node whose first_stmt_info_for_drptr
is different from first_stmt_info, it's possible that the first_stmt DR isn't
initialized yet before stmt SLP_TREE_SCALAR_STMTS[0] of slp node. So we
shouldn't use first_stmt_info for vect_setup_realignment, instead we can use
the one based on first_stmt_info_for_drptr DR with additional adjustment by
bumping the distance from first_stmt DR.

gcc/ChangeLog

2019-11-27  Kewen Lin  <linkw@gcc.gnu.org>

    PR tree-optimization/91790
    * gcc/tree-vect-stmts.c (vectorizable_load): Use the adjusted DR for
    vect_setup_realignment when first_stmt_info is different from
    first_stmt_info_for_drptr.

From-SVN: r278760

4 years agore PR c++/92524 (ICE in short program with constexpr and std::array)
Jakub Jelinek [Wed, 27 Nov 2019 09:04:40 +0000 (10:04 +0100)]
re PR c++/92524 (ICE in short program with constexpr and std::array)

PR c++/92524
* tree.c (replace_placeholders_r): Don't walk constructor elts with
RANGE_EXPR indexes.

* g++.dg/cpp0x/pr92524.C: New test.

From-SVN: r278759