Richard Biener [Thu, 17 Oct 2019 07:39:37 +0000 (07:39 +0000)]
re PR tree-optimization/92129 (ICE in vectorizable_reduction, at tree-vect-loop.c:5869)
2019-10-17 Richard Biener <rguenther@suse.de>
PR tree-optimization/92129
* tree-vect-loop.c (vectorizable_reduction): Also fail
on GIMPLE_SINGLE_RHS.
From-SVN: r277094
Jakub Jelinek [Thu, 17 Oct 2019 07:21:24 +0000 (09:21 +0200)]
re PR tree-optimization/92056 (ice in expr_object_size, at tree-object-si ze.c:675 with -O3)
PR tree-optimization/92056
* tree-object-size.c (cond_expr_object_size): Return early if then_
processing resulted in unknown size.
* gcc.c-torture/compile/pr92056.c: New test.
From-SVN: r277093
Jakub Jelinek [Thu, 17 Oct 2019 07:20:36 +0000 (09:20 +0200)]
re PR tree-optimization/92115 (ICE in gimple_cond_get_ops_from_tree, at gimple-expr.c:577)
PR tree-optimization/92115
* tree-ssa-ifcombine.c (ifcombine_ifandif): Force condition into
temporary if it could trap.
* gcc.dg/pr92115.c: New test.
From-SVN: r277092
Jakub Jelinek [Thu, 17 Oct 2019 06:46:53 +0000 (08:46 +0200)]
re PR fortran/87752 (ICE in omp_add_variable, at gimplify.c:6776)
PR fortran/87752
* gfortran.dg/gomp/pr87752.f90: New test.
From-SVN: r277091
Richard Biener [Thu, 17 Oct 2019 06:16:50 +0000 (06:16 +0000)]
re PR debug/91887 (-fdebug-types-section ICE building chromium)
2019-10-17 Richard Biener <rguenther@suse.de>
PR debug/91887
* dwarf2out.c (gen_formal_parameter_die): Also try to match
context_die against a DW_TAG_GNU_formal_parameter_pack parent.
* g++.dg/debug/dwarf2/pr91887.C: New testcase.
From-SVN: r277090
Luis Machado [Thu, 17 Oct 2019 00:37:05 +0000 (00:37 +0000)]
Fix old file reference in gcc/cp/cp-gimplify.c
I've found this stale reference while looking at cp-gimplify.c. tree-gimple.c
no longer exists and its contents were merged into gimple.c.
Seems obvious enough.
gcc/cp/ChangeLog:
2019-10-16 Luis Machado <luis.machado@linaro.org>
* cp-gimplify.c: Fix reference to non-existing tree-gimple.c file.
From-SVN: r277089
GCC Administrator [Thu, 17 Oct 2019 00:16:16 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r277088
Jakub Jelinek [Wed, 16 Oct 2019 22:19:13 +0000 (00:19 +0200)]
decl.c (cxx_maybe_build_cleanup): When clearing location of cleanup...
* decl.c (cxx_maybe_build_cleanup): When clearing location of cleanup,
if cleanup is a nop, clear location of its operand too.
From-SVN: r277084
Jakub Jelinek [Wed, 16 Oct 2019 22:18:31 +0000 (00:18 +0200)]
tree-ssa-strlen.c (maybe_invalidate): Use HOST_WIDE_INT_PRINT_UNSIGNED instead of "%zu".
* tree-ssa-strlen.c (maybe_invalidate): Use
HOST_WIDE_INT_PRINT_UNSIGNED instead of "%zu".
From-SVN: r277083
Andrew Burgess [Wed, 16 Oct 2019 21:01:25 +0000 (22:01 +0100)]
RISC-V: Include more registers in SIBCALL_REGS.
This finishes the part 1 of 2 patch submitted by Andrew Burgess on Aug 19.
This adds the argument registers but not t0 (aka x5) to SIBCALL_REGS. It
also adds the missing riscv_regno_to_class change.
Tested with cross riscv32-elf and riscv64-linux toolchain build and check.
There were no regressions. I see about a 0.01% code size reduction for the
C and libstdc++ libraries.
gcc/
* config/riscv/riscv.h (REG_CLASS_CONTENTS): Add argument passing
regs to SIBCALL_REGS.
* config/riscv/riscv.c (riscv_regno_to_class): Change argument
passing regs to SIBCALL_REGS.
Co-Authored-By: Jim Wilson <jimw@sifive.com>
From-SVN: r277082
Martin Sebor [Wed, 16 Oct 2019 19:24:36 +0000 (19:24 +0000)]
PR tree-optimization/83821 - local aggregate initialization defeats strlen optimization
gcc/ChangeLog:
PR tree-optimization/83821
* tree-ssa-strlen.c (maybe_invalidate): Add argument. Consider
the length of a string when available.
(handle_builtin_memset) Add argument.
(handle_store, strlen_check_and_optimize_call): Same.
(check_and_optimize_stmt): Same. Pass it to callees.
gcc/testsuite/ChangeLog:
PR tree-optimization/83821
* c-c++-common/Warray-bounds-4.c: Remove XFAIL.
* gcc.dg/strlenopt-82.c: New test.
* gcc.dg/strlenopt-83.c: Same.
* gcc.dg/strlenopt-84.c: Same.
* gcc.dg/strlenopt-85.c: Same.
* gcc.dg/strlenopt-86.c: Same.
* gcc.dg/tree-ssa/calloc-4.c: Same.
* gcc.dg/tree-ssa/calloc-5.c: Same.
From-SVN: r277080
Martin Sebor [Wed, 16 Oct 2019 17:18:57 +0000 (17:18 +0000)]
PR tree-optimization/91996 - fold non-constant strlen relational expressions
gcc/testsuite/ChangeLog:
PR tree-optimization/91996
* gcc.dg/strlenopt-80.c: New test.
* gcc.dg/strlenopt-81.c: New test.
gcc/ChangeLog:
PR tree-optimization/91996
* tree-ssa-strlen.c (maybe_warn_pointless_strcmp): Improve location
information.
(compare_nonzero_chars): Add an overload.
(count_nonzero_bytes): Add an argument. Call overload above.
Handle non-constant lengths in some range.
(handle_store): Add an argument.
(check_and_optimize_stmt): Pass an argument to handle_store.
From-SVN: r277076
Richard Earnshaw [Wed, 16 Oct 2019 16:44:34 +0000 (16:44 +0000)]
[arm] fix bootstrap failure due to uninitialized warning
The Arm port is failing bootstrap because GCC is now warning about an
unitialized array.
The code is complex enough that I certainly can't be sure the compiler
is wrong, so perhaps the best fix here is just to memset the entire
array before use.
* config/arm/arm.c (neon_valid_immediate): Clear bytes before use.
From-SVN: r277073
Mihailo Stojanovic [Wed, 16 Oct 2019 15:14:17 +0000 (15:14 +0000)]
mips.c (mips_expand_builtin_insn): Force the operands which correspond to the same input-output register to have...
* config/mips/mips.c (mips_expand_builtin_insn): Force the
operands which correspond to the same input-output register to
have the same pseudo assigned to them.
* gcc.target/mips/msa-dpadd-dpsub.c: New test.
From-SVN: r277071
Ilya Leoshkevich [Wed, 16 Oct 2019 15:00:38 +0000 (15:00 +0000)]
find_partition_fixes: remove unused bbs_in_cold_partition variable
gcc/ChangeLog:
2019-10-16 Ilya Leoshkevich <iii@linux.ibm.com>
* cfgrtl.c (find_partition_fixes): Remove bbs_in_cold_partition.
From-SVN: r277070
Wilco Dijkstra [Wed, 16 Oct 2019 14:24:41 +0000 (14:24 +0000)]
[AArch64] Fix symbol offset limit
In aarch64_classify_symbol symbols are allowed large offsets on relocations.
This means the offset can use all of the +/-4GB offset, leaving no offset
available for the symbol itself. This results in relocation overflow and
link-time errors for simple expressions like &global_array + 0xffffff00.
To avoid this, unless the offset_within_block_p is true, limit the offset
to +/-1MB so that the symbol needs to be within a 3.9GB offset from its
references. For the tiny code model use a 64KB offset, allowing most of
the 1MB range for code/data between the symbol and its references.
gcc/
* config/aarch64/aarch64.c (aarch64_classify_symbol):
Apply reasonable limit to symbol offsets.
testsuite/
* gcc.target/aarch64/symbol-range.c: Improve testcase.
* gcc.target/aarch64/symbol-range-tiny.c: Likewise.
From-SVN: r277068
Richard Biener [Wed, 16 Oct 2019 14:21:06 +0000 (14:21 +0000)]
tree-vect-loop.c (vect_valid_reduction_input_p): Remove.
2019-10-16 Richard Biener <rguenther@suse.de>
* tree-vect-loop.c (vect_valid_reduction_input_p): Remove.
(vect_is_simple_reduction): Delay checking to
vectorizable_reduction and relax the checking.
(vectorizable_reduction): Check we have a simple use. Check
for bogus condition reductions.
* tree-vect-stmts.c (vect_transform_stmt): Make sure we
are looking at the last stmt in a pattern sequence when
filling in backedge PHI values.
* gcc.dg/vect/vect-cond-reduc-3.c: New testcase.
* gcc.dg/vect/vect-cond-reduc-4.c: Likewise.
From-SVN: r277067
Peter Bergner [Wed, 16 Oct 2019 13:35:41 +0000 (13:35 +0000)]
In PR70010, a function is marked with target(no-vsx) to disable VSX code generation.
In PR70010, a function is marked with target(no-vsx) to disable VSX code
generation. To avoid VSX code generation, this function should not be
inlined into VSX function. To fix the bug, in the current logic when
checking whether the caller's ISA flags supports the callee's ISA flags, we
just need to add a test that enforces that the caller's ISA flags match
exactly the callee's flags, for those flags that were explicitly set in the
callee. If caller without target attribute then using options from command
line.
gcc/
2019-10-16 Peter Bergner <bergner@linux.ibm.com>
Jiufu Guo <guojiufu@linux.ibm.com>
PR target/70010
* config/rs6000/rs6000.c (rs6000_can_inline_p): Prohibit inlining if
the callee explicitly disables some isa_flags the caller is using.
gcc.testsuite/
2019-10-16 Peter Bergner <bergner@linux.ibm.com>
Jiufu Guo <guojiufu@linux.ibm.com>
PR target/70010
* gcc.target/powerpc/pr70010.c: New test.
* gcc.target/powerpc/pr70010-1.c: New test.
* gcc.target/powerpc/pr70010-2.c: New test.
* gcc.target/powerpc/pr70010-3.c: New test.
* gcc.target/powerpc/pr70010-4.c: New test.
Co-Authored-By: Jiufu Guo <guojiufu@linux.ibm.com>
From-SVN: r277065
Richard Sandiford [Wed, 16 Oct 2019 10:58:55 +0000 (10:58 +0000)]
Assert for POINTER_TYPE_P in expr_callee_abi
2019-10-16 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* function-abi.cc (expr_callee_abi): Assert for POINTER_TYPE_P.
From-SVN: r277063
Richard Sandiford [Wed, 16 Oct 2019 10:53:40 +0000 (10:53 +0000)]
[AArch64] Add partial SVE vector modes
This patch adds extra vector modes that represent a half, quarter or
eighth of what an SVE vector can hold. This is useful for describing
the memory vector involved in an extending load or truncating store.
It might also be useful in future for representing "unpacked" SVE
registers, i.e. registers that contain values in the low bits of a
wider containing element.
The new modes could have the same width as an Advanced SIMD mode for
certain -msve-vector-bits=N options, so we need to ensure that they
come later in the mode list and that Advanced SIMD modes always "win".
2019-10-16 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* genmodes.c (mode_data::order): New field.
(blank_mode): Update accordingly.
(VECTOR_MODES_WITH_PREFIX): Add an order parameter.
(make_vector_modes): Likewise.
(VECTOR_MODES): Update use accordingly.
(cmp_modes): Sort by the new order field ahead of sorting by size.
* config/aarch64/aarch64-modes.def (VNx2QI, VN2xHI, VNx2SI)
(VNx4QI, VNx4HI, VNx8QI): New partial vector modes.
* config/aarch64/aarch64.c (VEC_PARTIAL): New flag value.
(aarch64_classify_vector_mode): Handle the new partial modes.
(aarch64_vl_bytes): New function.
(aarch64_hard_regno_nregs): Use it instead of BYTES_PER_SVE_VECTOR
when counting the number of registers in an SVE mode.
(aarch64_class_max_nregs): Likewise.
(aarch64_hard_regno_mode_ok): Don't allow partial vectors
in registers yet.
(aarch64_classify_address): Treat partial vectors analogously
to full vectors.
(aarch64_print_address_internal): Consolidate the printing of
MUL VL addresses, using aarch64_vl_bytes as the number of
bytes represented by "VL".
(aarch64_vector_mode_supported_p): Reject partial vector modes.
From-SVN: r277062
Richard Sandiford [Wed, 16 Oct 2019 10:50:53 +0000 (10:50 +0000)]
[AArch64] Improve poly_int handling in aarch64_layout_frame
I'd used known_lt when converting these conditions to poly_int,
but on reflection that was a bad choice. The code isn't just
doing a range check; it specifically needs constants that will
fit in a certain encoding.
2019-10-16 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64.c (aarch64_layout_frame): Use is_constant
rather than known_lt when choosing frame layouts.
From-SVN: r277061
Richard Sandiford [Wed, 16 Oct 2019 10:48:00 +0000 (10:48 +0000)]
[AArch64] Add an assert to aarch64_layout_frame
This patch adds an assert that all the individual *_adjust allocations
add up to the full frame size. With that safety net, it seemed slightly
clearer to use crtl->outgoing_args_size as the final adjustment where
appropriate, to match what's used in the comments.
This is a bit overkill on its own, but I need to add more cases for SVE.
2019-10-16 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64.c (aarch64_layout_frame): Assert
that all the adjustments add up to the full frame size.
Use crtl->outgoing_args_size directly as the final adjustment
where appropriate.
From-SVN: r277060
Richard Sandiford [Wed, 16 Oct 2019 10:44:31 +0000 (10:44 +0000)]
[AArch64] Use frame reference in aarch64_layout_frame
Using the full path "cfun->machine->frame" in aarch64_layout_frame
led to awkward formatting in some follow-on patches, so it seemed
worth using a local reference instead.
2019-10-16 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64.c (aarch64_layout_frame): Use a local
"frame" reference instead of always referring directly to
"cfun->machine->frame".
From-SVN: r277059
Jonathan Wakely [Wed, 16 Oct 2019 10:26:05 +0000 (11:26 +0100)]
Only use GCC-specific __is_same_as built-in conditionally
Clang doesn't support __is_same_as but provides __is_same instead.
Restore the original implementation (pre r276891) when neither of those
built-ins is available.
* include/bits/c++config (_GLIBCXX_BUILTIN_IS_SAME_AS): Define to
one of __is_same_as or __is_same when available.
* include/std/concepts (__detail::__same_as): Use std::is_same_v.
* include/std/type_traits (is_same) [_GLIBCXX_BUILTIN_IS_SAME_AS]:
Use new macro instead of __is_same_as.
(is_same) [!_GLIBCXX_BUILTIN_IS_SAME_AS]: Restore partial
specialization.
(is_same_v) [_GLIBCXX_BUILTIN_IS_SAME_AS]: Use new macro.
(is_same_v) [!_GLIBCXX_BUILTIN_IS_SAME_AS]: Use std::is_same.
From-SVN: r277058
Richard Biener [Wed, 16 Oct 2019 10:05:21 +0000 (10:05 +0000)]
re PR tree-optimization/92119 (ICE: SIGSEGV in contains_struct_check (tree.h:3380) with -Os -fno-tree-dce -fno-tree-dse -ftree-slp-vectorize)
2019-10-16 Richard Biener <rguenther@suse.de>
PR tree-optimization/92119
* tree-vect-patterns.c (vect_recog_rotate_pattern): Guard
against missing bswap lhs.
From-SVN: r277057
Richard Sandiford [Wed, 16 Oct 2019 09:50:44 +0000 (09:50 +0000)]
Deal with incoming POLY_INT_CST ranges (PR92033)
This patch makes value_range_base::set convert POLY_INT_CST bounds
into the worst-case INTEGER_CST bounds. The main case in which this
gives useful ranges is a lower bound of A + B * X becoming A when B >= 0.
E.g.:
[32 + 16X, 100] -> [32, 100]
[32 + 16X, 32 + 16X] -> [32, MAX]
But the same thing can be useful for the upper bound with negative
X coefficients.
2019-10-16 Richard Sandiford <richard.sandiford@arm.com>
gcc/
PR middle-end/92033
* poly-int.h (constant_lower_bound_with_limit): New function.
(constant_upper_bound_with_limit): Likewise.
* doc/poly-int.texi: Document them.
* tree-vrp.c (value_range_base::set): Convert POLY_INT_CST bounds
into the worst-case INTEGER_CST bounds.
From-SVN: r277056
Feng Xue [Wed, 16 Oct 2019 07:27:50 +0000 (07:27 +0000)]
Generalized IPA predicate on parameter reference
2019-10-16 Feng Xue <fxue@os.amperecomputing.com>
PR ipa/91088
* doc/invoke.texi (ipa-max-param-expr-ops): Document new option.
* params.def (PARAM_IPA_MAX_PARAM_EXPR_OPS): New.
* ipa-predicat.h (struct expr_eval_op): New struct.
(expr_eval_ops): New typedef.
(struct condition): Add type and param_ops fields, remove size field.
(add_condition): Replace size parameter with type parameter, add
param_ops parameter.
* ipa-predicat.c (expr_eval_ops_equal_p): New function.
(predicate::add_clause): Add comparisons on type and param_ops.
(dump_condition): Add debug dump for param_ops.
(remap_after_inlining): Adjust call arguments to add_condition.
(add_condition): Replace size parameter with type parameter, add
param_ops parameter. Unshare constant value used in conditions.
* ipa-fnsummary.c (evaluate_conditions_for_known_args): Fold
parameter expressions using param_ops.
(decompose_param_expr): New function.
(set_cond_stmt_execution_predicate): Use call to decompose_param_expr
to replace call to unmodified_parm_or_parm_agg_item.
(set_switch_stmt_execution_predicate): Likewise.
(will_be_nonconstant_expr_predicate): Likewise. Replace usage of size
with type.
(inline_read_section): Read param_ops from summary stream.
(ipa_fn_summary_write): Write param_ops to summary stream.
2019-10-16 Feng Xue <fxue@os.amperecomputing.com>
PR ipa/91088
* gcc.dg/ipa/pr91088.c: New test.
* gcc.dg/ipa/pr91089.c: Add sub-test for range analysis.
* g++.dg/tree-ssa/ivopts-3.C: Force a function to be noinline.
From-SVN: r277054
François Dumont [Wed, 16 Oct 2019 05:05:27 +0000 (05:05 +0000)]
[_GLIBCXX_DEBUG] Clarify constness and state <unknown> entries.
* src/c++11/debug.cc (print_field): Replace constness_names <unknown>
entry with <unknown constness>. Replace state_names <unknown> entry with
<unknown state>.
From-SVN: r277049
GCC Administrator [Wed, 16 Oct 2019 00:16:15 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r277033
Segher Boessenkool [Tue, 15 Oct 2019 23:47:47 +0000 (01:47 +0200)]
genattrtab: Parenthesize expressions correctly (PR92107)
As PR92107 shows, genattrtab doesn't parenthesize expressions correctly
(or at all, even). This fixes it.
PR rtl-optimization/92107
* genattrtab.c (write_attr_value) <do_operator>: Parenthesize the
expression written.
From-SVN: r277023
John David Anglin [Tue, 15 Oct 2019 22:17:14 +0000 (22:17 +0000)]
fptr.c (_dl_read_access_allowed): Change argument to unsigned int.
* config/pa/fptr.c (_dl_read_access_allowed): Change argument to
unsigned int. Adjust callers.
(__canonicalize_funcptr_for_compare): Change plabel type to volatile
unsigned int *. Load relocation offset before function pointer.
Add barrier to ensure ordering.
From-SVN: r277015
Andrew Pinski [Tue, 15 Oct 2019 21:06:55 +0000 (21:06 +0000)]
20191015-1.c: New test.
2019-10-15 Andrew Pinski <apinski@marvell.com>
* gcc.c-torture/compile/
20191015-1.c: New test.
* gcc.c-torture/compile/
20191015-2.c: New test.
From-SVN: r277011
Iain Sandoe [Tue, 15 Oct 2019 20:28:02 +0000 (20:28 +0000)]
[Darwin] Clarify fix and continue support (NFC).
This updates the description of the support for fix and continue
debugging.
gcc/ChangeLog:
2019-10-15 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.c: Update description of fix and continue.
From-SVN: r277010
Iain Sandoe [Tue, 15 Oct 2019 20:15:38 +0000 (20:15 +0000)]
[Darwin] Update darwin_binds_local_p.
The use of default_binds_local_p had got out of sync with the varasm
changes, this restores the call to be direct. In practice, we add some
further tests to determine local binding - but this callback is used for
the initial assessments made by default_encode_section_info().
gcc/ChangeLog:
2019-10-15 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.c (darwin_binds_local_p): Update to call
default_binds_local_p_3 () directly. amend comments.
From-SVN: r277009
Martin Sebor [Tue, 15 Oct 2019 19:16:51 +0000 (19:16 +0000)]
PR testsuite/92016 - Excess errors in Wstringop-overflow-17.c
gcc/testsuite/ChangeLog:
* gcc.dg/Wstringop-overflow-17.c: Expect an additional warning.
From-SVN: r277008
Richard Biener [Tue, 15 Oct 2019 18:30:15 +0000 (18:30 +0000)]
lto-streamer-out.c (lto_variably_modified_type_p): New.
2019-10-15 Richard Biener <rguenther@suse.de>
* lto-streamer-out.c (lto_variably_modified_type_p): New.
(tree_is_indexable): Use it.
* tree-streamer-out.c (pack_ts_type_common_value_fields):
Stream variably_modified_type_p as TYPE_LANG_FLAG_0.
* tree-streamer-in.c (unpack_ts_type_common_value_fields): Likewise.
From-SVN: r277005
James Norris [Tue, 15 Oct 2019 14:13:01 +0000 (14:13 +0000)]
[Fortran] OpenMP+OpenACC: Remove bogus contigous-pointer check
gcc/fortran
PR fortran/65438
* openmp.c (check_array_not_assumed): Remove pointer check.
Co-Authored-By: Tobias Burnus <tobias@codesourcery.com>
From-SVN: r277000
Bill Schmidt [Tue, 15 Oct 2019 12:44:25 +0000 (12:44 +0000)]
re PR testsuite/92093 (New test case gcc.target/powerpc/pr91275.c from r276410 fails on BE)
2019-10-15 Bill Schmidt <wschmidt@linux.ibm.com>
PR target/92093
* gcc.target/powerpc/pr91275.c: Fix type and endian issues.
From-SVN: r276999
Nathan Sidwell [Tue, 15 Oct 2019 12:27:21 +0000 (12:27 +0000)]
[C++ PATCH] clone_function_decl breakup
https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01083.html
This patch, from the modules branch, breaks out function cloning from the
method vector updating. We have a new function, build_clones,
which does the building, returning a count of the number of clones
(2 or 3). clone_function_decl separately adds them to the method
vector, if they should be added. I suppose this could have used
FOR_EVERY_CLONE, but I went with the counting scheme.
* class.c (build_clones): Break out of clone_function_decl. Just
build the clones.
(clone_function_decl): Call build_clones, then maybe add them to
the method vector.
From-SVN: r276998
Jozef Lawrynowicz [Tue, 15 Oct 2019 12:24:53 +0000 (12:24 +0000)]
msp430.md (zero_extendqipsi2): New.
2019-10-15 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* config/msp430/msp430.md (zero_extendqipsi2): New.
(zero_extendqisi2): Optimize case where src register and base dst
register are the same.
(zero_extendhipsi2): Don't use 430X insn for rYs->r case.
(zero_extendpsisi2): Optimize r->m case.
Add unnamed insn patterns to catch insns combine searches for when
optimizing pointer manipulation.
From-SVN: r276997
Jozef Lawrynowicz [Tue, 15 Oct 2019 12:19:51 +0000 (12:19 +0000)]
msp430.md: Group zero_extend* insns together.
2019-10-15 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* config/msp430/msp430.md: Group zero_extend* insns together.
From-SVN: r276996
Jozef Lawrynowicz [Tue, 15 Oct 2019 12:14:55 +0000 (12:14 +0000)]
constraints.md: Allow post_inc operand for "Ya" constraint.
2019-10-15 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* config/msp430/constraints.md: Allow post_inc operand for "Ya"
constraint.
* config/msp430/msp430.c (msp430_legitimate_address_p): Handle
POST_INC.
(msp430_subreg): Likewise.
(msp430_split_addsi): Likewise.
(msp430_print_operand_addr): Likewise.
* config/msp430/msp430.h (HAVE_POST_INCREMENT): Define.
(USE_STORE_POST_INCREMENT): Define.
* config/msp430/msp430.md: Use the msp430_general_dst_operand or
msp430_general_dst_nonv_operand predicates for the lvalues of insns.
* config/msp430/predicates.md (msp430_nonpostinc_operand): New.
(msp430_general_dst_operand): New.
(msp430_general_dst_nonv_operand): New.
(msp430_nonsubreg_operand): Remove.
(msp430_nonsubreg_dst_operand): New.
(msp430_nonsubreg_or_imm_operand): Allow reg or mem operands in place
of defunct msp430_nonsubreg_operand.
(msp430_nonsubregnonpostinc_or_imm_operand): New.
From-SVN: r276995
Nathan Sidwell [Tue, 15 Oct 2019 12:03:04 +0000 (12:03 +0000)]
[linemap PATCH] Constify lookup
https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01080.html
looking up a line map takes a non-constant line_maps object, which is confusing.
This makes the caching fields mutable, so permits a constant object, as one might expect for a lookup.
* include/line-map.h (struct maps_info_ordinary): Make cache
mutable.
(struct maps_info_macro): Likewise.
(LINEMAPS_CACHE): Remove non-ref accessor. Constify ref accessor.
(LINEMAPS_ORDINARY_CACHE, LINEMAPS_MACRO_CACHE): Likewise.
(LINEMAPS_ORDINARY_MAP_AT, LINEMAPS_MACRO_MAP_AT): Use
LINEMAPS_USED and LINEMAPS_MAP_AT.
(linemap_lookup): Constify line_map arg.
linemap.c (linemap_ordinary_map_lookup, linemap_macro_map_lookup):
Constify line_map arg.
From-SVN: r276994
Richard Biener [Tue, 15 Oct 2019 11:47:27 +0000 (11:47 +0000)]
re PR debug/91929 (missing inline subroutine information in build using sin/cos)
2019-10-15 Richard Biener <rguenther@suse.de>
PR tree-optimization/91929
* tree-ssa-pre.c (pre_expr_d::loc): New member.
(get_or_alloc_expr_for_name): Initialize it.
(get_or_alloc_expr_for_constant): Likewise.
(phi_translate_1): Copy it.
(create_expression_by_pieces): Use the original location
of the expression for the inserted stmt.
(compute_avail): Record the location of the stmt for the
expressions created.
From-SVN: r276993
Nathan Sidwell [Tue, 15 Oct 2019 11:20:06 +0000 (11:20 +0000)]
[C++ PATCH] build_clone cleanup
https://gcc.gnu.org/ml/gcc-patches/2019-10/msg01069.html
build_clone is recursive when applied to a template, but I found the control flow confusing. this makes it clearer and moves some decls to their initializers.
* class.c (build_clone): Refactor to clarify recursiveness.
From-SVN: r276992
Richard Biener [Tue, 15 Oct 2019 10:47:48 +0000 (10:47 +0000)]
re PR target/92048 (armeb regression after r276645)
2019-10-15 Richard Biener <rguenther@suse.de>
PR testsuite/92048
* gcc.dg/vect/fast-math-vect-pr29925.c: Avoid unrolling of
inner loop.
From-SVN: r276991
Richard Sandiford [Tue, 15 Oct 2019 10:29:53 +0000 (10:29 +0000)]
Fix unchecked use of tree_to_uhwi in tree-ssa-strlen.c
r273783 introduced an unchecked use of tree_to_uhwi. This is
tested by the SVE ACLE patches, but could potentially trigger
in non-SVE cases too.
2019-10-15 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* tree-ssa-strlen.c (count_nonzero_bytes): Check tree_fits_uhwi_p
before using tree_to_uhwi.
From-SVN: r276990
Ilya Leoshkevich [Tue, 15 Oct 2019 10:22:35 +0000 (10:22 +0000)]
[PATCH] S/390: Run %a0:DI splitters only after reload
gcc/ChangeLog:
2019-10-15 Ilya Leoshkevich <iii@linux.ibm.com>
* config/s390/s390.md: Run %a0:DI splitters only after reload.
gcc/testsuite/ChangeLog:
2019-10-15 Ilya Leoshkevich <iii@linux.ibm.com>
* gcc.target/s390/load-thread-pointer-once.c: New test.
From-SVN: r276989
Arnaud Charlet [Tue, 15 Oct 2019 10:12:15 +0000 (10:12 +0000)]
Makefile.rtl (a-except.o): Put -O1 earlier so that it can be overriden if needed by other variables.
* Makefile.rtl (a-except.o): Put -O1 earlier so that it can be
overriden if needed by other variables.
From-SVN: r276988
Richard Biener [Tue, 15 Oct 2019 10:09:10 +0000 (10:09 +0000)]
re PR fortran/92094 (ice in vect_transform_stmt at tree-vect-stmts.c:10921)
2019-10-15 Richard Biener <rguenther@suse.de>
PR tree-optimization/92094
* tree-vect-loop.c (vectorizable_reduction): For nested cycles
do not adjust the reduction definition def type.
* tree-vect-stmts.c (vect_transform_stmt): Verify the scalar stmt
defines the latch argument of the PHI.
* gfortran.dg/pr92094.f90: New testcase.
From-SVN: r276987
Hongtao Liu [Tue, 15 Oct 2019 07:44:15 +0000 (07:44 +0000)]
Add missing mask[z]_roundscale_[round]_s[d,s] intrinsics
gcc/
* config/i386/avx512fintrin.h (_mm_mask_roundscale_ss,
_mm_maskz_roundscale_ss, _mm_maskz_roundscale_round_ss,
_mm_maskz_roundscale_round_ss, _mm_mask_roundscale_sd,
_mm_maskz_roundscale_sd, _mm_mask_roundscale_round_sd,
_mm_maskz_roundscale_round_sd): New intrinsics.
(_mm_roundscale_ss, _mm_roundscale_round_ss): Use
__builtin_ia32_rndscales?_mask_round builtins instead of
__builtin_ia32_rndscales?_round.
* config/i386/i386-builtin.def (__builtin_ia32_rndscaless_round,
__builtin_ia32_rndscalesd_round): Remove.
(__builtin_ia32_rndscaless_mask_round,
__builtin_ia32_rndscalesd_mask_round): New intrinsics.
* config/i386/sse.md
(avx512f_rndscale<mode><round_saeonly_name>): Renamed to ...
(avx512f_rndscale<mode><mask_scalar_name><round_saeonly_scalar_name>):
... this, adjust and add subst atrributes to make it maskable.
gcc/testsuite/
* gcc.target/i386/avx512f-vrndscaless-1.c: Add scan-assembler-times
directives for newly expected instructions.
* gcc.target/i386/avx512f-vrndscalesd-1.c: Likewise.
* gcc.target/i386/avx512f-vrndscaless-2.c
(avx512f_test): Add tests for new intrinsics.
* gcc.target/i386/avx512f-vrndscalesd-2.c: Likewise.
* gcc.target/i386/avx-1.c (__builtin_ia32_rndscalefss_round,
__builtin_ia32_rndscalefsd_round): Remove.
(__builtin_ia32_rndscalefss_mask_round,
__builtin_ia32_rndscalefsd_mask_round): Define.
* gcc.target/i386/sse-13.c: Ditto.
* gcc.target/i386/sse-23.c: Ditto.
From-SVN: r276986
Richard Biener [Tue, 15 Oct 2019 07:28:26 +0000 (07:28 +0000)]
re PR middle-end/92046 (Command line options (that are per-functions) are affecting --params which are global.)
2019-10-15 Richard Biener <rguenther@suse.de>
PR middle-end/92046
* common.opt (fallow-store-data-races): New.
* params.def (PARAM_ALLOW_STORE_DATA_RACES): Remove.
* params.h (ALLOW_STORE_DATA_RACES): Likewise.
* doc/invoke.texi (fallow-store-data-races): Document.
(--param allow-store-data-races): Remove docs.
* opts.c (default_options_table): Enable -fallow-store-data-races
at -Ofast.
(default_options_optimization): Do not enable --param
allow-store-data-races at -Ofast.
* tree-if-conv.c (ifcvt_memrefs_wont_trap): Use flag_store_data_races
instead of PARAM_ALLOW_STORE_DATA_RACES.
* tree-ssa-loop-im.c (execute_sm): Likewise.
* c-c++-common/cxxbitfields-3.c: Adjust.
* c-c++-common/cxxbitfields-6.c: Likewise.
* c-c++-common/simulate-thread/bitfields-1.c: Likewise.
* c-c++-common/simulate-thread/bitfields-2.c: Likewise.
* c-c++-common/simulate-thread/bitfields-3.c: Likewise.
* c-c++-common/simulate-thread/bitfields-4.c: Likewise.
* g++.dg/simulate-thread/bitfields-2.C: Likewise.
* g++.dg/simulate-thread/bitfields.C: Likewise.
* gcc.dg/lto/pr52097_0.c: Likewise.
* gcc.dg/simulate-thread/speculative-store-2.c: Likewise.
* gcc.dg/simulate-thread/speculative-store-3.c: Likewise.
* gcc.dg/simulate-thread/speculative-store-4.c: Likewise.
* gcc.dg/simulate-thread/speculative-store.c: Likewise.
* gcc.dg/tree-ssa/
20050314-1.c: Likewise.
From-SVN: r276985
Prathamesh Kulkarni [Tue, 15 Oct 2019 07:19:41 +0000 (07:19 +0000)]
re PR tree-optimization/92085 (ICE: tree check: expected class 'type', have 'exceptional' (error_mark) in useless_type_conversion_p, at gimple-expr.c:86)
2019-10-15 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR tree-optimization/92085
* tree-if-conv.c (ifcvt_local_dce): Call gsi_next in else clause,
instead of calling it unconditionally after
delete_dead_or_redundant_assignment and fix indentation.
testsuite/
* gcc.dg/tree-ssa/pr92085-1.c: New test.
* gcc.dg/tree-ssa/pr92085-2.c: Likewise.
From-SVN: r276984
Steven G. Kargl [Tue, 15 Oct 2019 00:28:47 +0000 (00:28 +0000)]
re PR fortran/89943 (Submodule functions are not allowed to have C binding)
2019-10-14 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/89943
decl.c (gfc_match_function_decl): Ignore duplicate BIND(C) for function
declaration in submodule. Implement at check for F2018 C1550.
(gfc_match_entry): Use temporary for locus, which allows removal of
one gfc_error_now().
(gfc_match_subroutine): Ignore duplicate BIND(C) for subroutine
declaration in submodule. Implement at check for F2018 C1550.
2019-10-14 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/89943
* gfortran.dg/pr89943_1.f90: New test.
* gfortran.dg/pr89943_2.f90: Ditto.
* gfortran.dg/pr89943_3.f90: Ditto.
* gfortran.dg/pr89943_4.f90: Ditto.
From-SVN: r276983
GCC Administrator [Tue, 15 Oct 2019 00:16:17 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r276982
Joseph Myers [Tue, 15 Oct 2019 00:12:49 +0000 (01:12 +0100)]
Rename attribute-related functions and productions in C parser.
The C2x attribute syntax, [[ ]], appears in different places in the
syntax from GNU __attribute__, and, where they can appear in the same
place in the syntax, they do not always appertain to the same entity.
(For example, in "int func(void) ATTRS;", GNU attributes appertain to
the declaration but C2x attributes appertain to the function type.)
Thus, the C parser needs to handle the two kinds of attributes
separately, with each place in the syntax accepting whatever kinds of
attributes are appropriate there and applying them to the relevant
entities. This patch prepares for this by renaming parser functions
relating to attributes to make clear they are specifically about GNU
attributes and renaming syntax productions likewise to avoid confusing
with the C2x attributes syntax productions.
Where comments refer to attributes, this has only be changed where it
is clear that in the context they are referring specifically to the
gnu-attributes syntax. There may be other places that also end up
changing to refer to gnu-attributes as part of the C2x attributes
implementation, if more detailed examination of those places shows
they are also specific to gnu-attributes. (I do not expect code
dealing with semantics of attributes outside of the parser to need to
change; as for C++, it will be possible to use existing attributes
inside [[]] with the gnu:: form of the attribute name.)
Bootstrapped with no regressions on x86_64-pc-linux-gnu.
* c-parser.c (c_parser_attribute_any_word): Rename to
c_parser_gnu_attribute_any_word. All callers changed.
(c_parser_attribute): Rename to c_parser_gnu_attribute. All
callers changed.
(c_parser_attributes): Rename to c_parser_gnu_attributes. All
callers changed.
(c_parser_declaration_or_fndef, c_parser_declspecs)
(c_parser_enum_specifier, c_parser_struct_or_union_specifier)
(c_parser_struct_declaration, c_parser_declarator)
(c_parser_gnu_attribute, c_parser_compound_statement)
(c_parser_label, c_parser_statement, c_parser_objc_method_decl)
(c_parser_transaction_attributes): Add "gnu-" prefix to names of
attribute-related syntax productions.
From-SVN: r276978
Kugan Vivekanandarajah [Mon, 14 Oct 2019 23:33:17 +0000 (23:33 +0000)]
vfp.md (fma<SDF:mode>4): Enable DF only when TARGET_VFP_DOUBLE.
gcc/ChangeLog:
2019-10-15 Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
* config/arm/vfp.md (fma<SDF:mode>4): Enable DF only when
TARGET_VFP_DOUBLE.
(*fmsub<SDF:mode>4): Likewise.
*fnmsub<SDF:mode>4): Likewise.
(*fnmadd<SDF:mode>4): Likewise.
From-SVN: r276977
Ian Lance Taylor [Mon, 14 Oct 2019 23:12:33 +0000 (23:12 +0000)]
compiler: revise exportdata fix for processing constant types
This patch is an addendum to the fix for issue 34577, which was not
sufficiently general. During export data processing, when looking at
the types of constants mentioned in inlinable function bodies, include
both locally defined constants and constant imported from other
packages.
Testcase for this bug is in CL 201017.
Fixes golang/go#34852.
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/201018
From-SVN: r276976
Thomas Koenig [Mon, 14 Oct 2019 21:37:34 +0000 (21:37 +0000)]
re PR fortran/92004 (Rejection of different ranks for dummy array argument where actual argument is an element)
2019-10-14 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92004
* array.c (expand_constructor): Set from_constructor on
expression.
* gfortran.h (gfc_symbol): Add maybe_array.
(gfc_expr): Add from_constructor.
* interface.c (maybe_dummy_array_arg): New function.
(compare_parameter): If the formal argument is generated from a
call, check the conditions where an array element could be
passed to an array. Adjust error message for assumed-shape
or pointer array. Use correct language for assumed shaped arrays.
(gfc_get_formal_from_actual_arglist): Set maybe_array on the
symbol if the actual argument is an array element fulfilling
the conditions of 15.5.2.4.
2019-10-14 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92004
* gfortran.dg/argument_checking_24.f90: New test.
* gfortran.dg/abstract_type_6.f90: Add error message.
* gfortran.dg/argument_checking_11.f90: Correct wording
in error message.
* gfortran.dg/argumeent_checking_13.f90: Likewise.
* gfortran.dg/interface_40.f90: Add error message.
From-SVN: r276972
Maya Rashish [Mon, 14 Oct 2019 21:14:16 +0000 (21:14 +0000)]
* gcc.c-torture/compile/pr85401: New test.
From-SVN: r276971
Joel Hutton [Mon, 14 Oct 2019 21:09:45 +0000 (21:09 +0000)]
* doc/tree-ssa.texi: Update renamed macro name.
From-SVN: r276970
Mihailo Stojanovic [Mon, 14 Oct 2019 21:07:56 +0000 (21:07 +0000)]
mips.c (mips_cannot_force_const_mem): Reject vector constants.
* config/mips/mips.c (mips_cannot_force_const_mem): Reject
vector constants.
* gcc.target/mips/constant-spill.c: New test.
From-SVN: r276969
Jason Merrill [Mon, 14 Oct 2019 20:13:49 +0000 (16:13 -0400)]
PR c++/91930 - ICE with constrained inherited default ctor.
The testcase was crashing because lazily_declare_fn was failing to add a
defaulted constructor, because the implicit declaration was less constrained
than the inherited default constructor. But when we have an inherited
constructor, we shouldn't be trying to declare a default constructor in the
first place, because it counts as "a user-declared constructor". With that
fixed I needed to adjust a couple of inherited constructor testcases that
previously had been diagnosing the default constructor as deleted rather
than not declared.
* name-lookup.c (do_class_using_decl): Set TYPE_HAS_USER_CONSTRUCTOR
for inherited constructor.
From-SVN: r276968
Iain Sandoe [Mon, 14 Oct 2019 19:18:34 +0000 (19:18 +0000)]
[Darwin, machopic 9/n] Minor code clean-ups.
Improve some comments, replace some asserts that have been in the code
base for years with checking-asserts.
gcc/ChangeLog:
2019-10-14 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.c: Use unsigned ints for the picbase label
counters, initialise the vars explicitly.
(update_pic_label_number_if_needed): Move a variable declaration
to where it's needed.
(machopic_output_function_base_name): Use a more strict checking
assert, and and unsigned int for the picbase label counter.
(machopic_get_function_picbase): Likewise.
From-SVN: r276967
Ian Lance Taylor [Mon, 14 Oct 2019 14:10:16 +0000 (14:10 +0000)]
runtime: correct facilities names in s390 CPU support
Patch from Andreas Krebbel.
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/201038
From-SVN: r276964
Richard Biener [Mon, 14 Oct 2019 14:03:35 +0000 (14:03 +0000)]
re PR middle-end/92046 (Command line options (that are per-functions) are affecting --params which are global.)
2019-10-14 Richard Biener <rguenther@suse.de>
PR middle-end/92046
* dse.c (scan_insn): Use param max_active_local_stores.
(dse_step1): Get PARAM_MAX_DSE_ACTIVE_LOCAL_STORES and adjust
based on optimization level.
* loop-invariant.c (move_loop_invariants): Adjust
LOOP_INVARIANT_MAX_BBS_IN_LOOP based on optimization level.
* opts.c (default_options_optimization): Do not adjust
PARAM_MAX_DSE_ACTIVE_LOCAL_STORES and
LOOP_INVARIANT_MAX_BBS_IN_LOOP here.
From-SVN: r276963
Ian Lance Taylor [Mon, 14 Oct 2019 14:01:15 +0000 (14:01 +0000)]
internal/cpu: define kdsaQuery for s390
Patch from Andreas Krebbel.
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/201037
From-SVN: r276962
Wilco Dijkstra [Mon, 14 Oct 2019 12:25:00 +0000 (12:25 +0000)]
[ARM] Enable arm_legitimize_address for Thumb-2
Currently arm_legitimize_address doesn't handle Thumb-2 at all, resulting in
inefficient code. Since Thumb-2 supports similar address offsets use the Arm
legitimization code for Thumb-2 to get significant codesize and performance
gains. SPECINT2006 shows 0.4% gain on Cortex-A57, while SPECFP improves 0.2%.
gcc/
* config/arm/arm.c (arm_legitimize_address): Remove Thumb-2 bailout.
From-SVN: r276961
Wilco Dijkstra [Mon, 14 Oct 2019 12:21:14 +0000 (12:21 +0000)]
[ARM] Switch to default sched pressure algorithm
Currently the Arm backend selects the alternative sched pressure algorithm.
The issue is that this doesn't take register pressure into account, and so
it causes significant additional spilling on Arm where there are only 14
allocatable registers. Building SPEC2006 showed significant codesize gains
with the default pressure algorithm, so switch back to that. PR77308 shows
~800 fewer instructions.
SPECINT2006 is ~0.6% faster on Cortex-A57 together with the other DImode
patches. Overall SPEC codesize is 1.1% smaller.
gcc/
* config/arm/arm.c (arm_option_override): Don't override sched
pressure algorithm.
From-SVN: r276960
Richard Biener [Mon, 14 Oct 2019 11:47:15 +0000 (11:47 +0000)]
re PR tree-optimization/92069 (ice in vect_analyze_scalar_cycles_1, at tree-vect-loop.c:560)
2019-10-14 Richard Biener <rguenther@suse.de>
PR tree-optimization/92069
* tree-vect-loop.c (vect_analyze_scalar_cycles_1): For nested
cycles do not set vect_nested_cycle on the latch definition.
* gcc.dg/torture/pr92069.c: New testcase.
From-SVN: r276959
Paolo Carlini [Mon, 14 Oct 2019 11:29:33 +0000 (11:29 +0000)]
decl.c (check_tag_decl): Use DECL_SOURCE_LOCATION.
/cp
2019-10-14 Paolo Carlini <paolo.carlini@oracle.com>
* decl.c (check_tag_decl): Use DECL_SOURCE_LOCATION.
/testsuite
2019-10-14 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/cpp0x/constexpr-union5.C: Test location(s) too.
* g++.dg/diagnostic/bitfld2.C: Likewise.
* g++.dg/ext/anon-struct1.C: Likewise.
* g++.dg/ext/anon-struct6.C: Likewise.
* g++.dg/ext/flexary19.C: Likewise.
* g++.dg/ext/flexary9.C: Likewise.
* g++.dg/template/error17.C: Likewise.
From-SVN: r276958
Jakub Jelinek [Mon, 14 Oct 2019 08:48:42 +0000 (10:48 +0200)]
re PR libgomp/92081 (FAIL: libgomp.fortran/target-simd.f90 execution test)
PR libgomp/92081
* testsuite/libgomp.fortran/target-simd.f90: Iterate from 1 rather
than 0.
From-SVN: r276956
Tobias Burnus [Mon, 14 Oct 2019 08:28:11 +0000 (08:28 +0000)]
Fix previous commit
* error.c: Remove debug pragma added in previous commit.
From-SVN: r276955
Jakub Jelinek [Mon, 14 Oct 2019 08:28:05 +0000 (10:28 +0200)]
re PR c++/92084 (ICE: tree check: expected tree that contains 'decl minimal' structure, have 'compound_expr' in gimplify_scan_omp_clauses, at gimplify.c:9039)
PR c++/92084
* semantics.c (handle_omp_array_sections_1): Temporarily disable
-fstrong-eval-order also for in_reduction and task_reduction clauses.
* g++.dg/gomp/pr92084.C: New test.
From-SVN: r276954
Tobias Burnus [Mon, 14 Oct 2019 08:14:23 +0000 (08:14 +0000)]
[Fortran] PR 92072 – fix %C corner case
PR fortran/92072
* error.c (error_print, gfc_format_decoder): Fix %C column-
offset handling.
From-SVN: r276953
Richard Sandiford [Mon, 14 Oct 2019 08:06:06 +0000 (08:06 +0000)]
Add expr_callee_abi
This turned out to be useful for the SVE PCS support, and is a natural
tree-level analogue of insn_callee_abi.
2019-10-14 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* function-abi.h (expr_callee_abi): Declare.
* function-abi.cc (expr_callee_abi): New function.
From-SVN: r276952
Richard Sandiford [Mon, 14 Oct 2019 08:05:52 +0000 (08:05 +0000)]
[C] Avoid exposing internal details in aka types
The current aka diagnostics can sometimes leak internal details that
seem more likely to be distracting than useful. E.g. on aarch64:
void f (va_list *va) { *va = 1; }
gives:
incompatible types when assigning to type ‘va_list’ {aka ‘__va_list’} from type ‘int’
where __va_list isn't something the user is expected to know about.
A similar thing happens for C++ on the arm_neon.h-based:
float x;
int8x8_t y = x;
which gives:
cannot convert ‘float’ to ‘int8x8_t’ {aka ‘__Int8x8_t’} in initialization
This is accurate -- and __Int8x8_t is defined by the AArch64 PCS --
but it's not going to be meaningful to most users.
This patch stops the aka code looking through typedefs if all of
the following are true:
(1) the typedef is built into the compiler or comes from a system header
(2) the target of the typedef is anonymous or has a name in the
implementation namespace
(3) the target type is a tag type or vector type, which have in common that:
(a) we print their type names if they have one
(b) what we print for anonymous types isn't all that useful
("struct <anonymous>" etc. for tag types, pseudo-C "__vector(N) T"
for vector types)
The patch does this by recursively looking for the aka type, like the
C++ frontend already does. This in turn makes "aka" work for distinct type
copies like __Int8x8_t on aarch64, fixing the ??? in aarch64/diag_aka_1.c.
2019-10-14 Richard Sandiford <richard.sandiford@arm.com>
gcc/c-family/
* c-common.h (user_facing_original_type_p): Declare.
* c-common.c: Include c-spellcheck.h.
(user_facing_original_type_p): New function.
gcc/c/
* c-objc-common.c (useful_aka_type_p): Replace with...
(get_aka_type): ...this new function. Given the original type,
decide which aka type to print (if any). Only look through typedefs
if user_facing_original_type_p.
(print_type): Update accordingly.
gcc/testsuite/
* gcc.dg/diag-aka-5.h: New test.
* gcc.dg/diag-aka-5a.c: Likewise.
* gcc.dg/diag-aka-5b.c: Likewise.
* gcc.target/aarch64/diag_aka_1.c (f): Expect an aka to be printed
for myvec.
From-SVN: r276951
Jakub Jelinek [Mon, 14 Oct 2019 06:52:46 +0000 (08:52 +0200)]
c-parser.c (c_parser_omp_all_clauses): Change bool NESTED_P argument into int NESTED...
c/
* c-parser.c (c_parser_omp_all_clauses): Change bool NESTED_P argument
into int NESTED, if it is 2, diagnose missing commas in between
clauses.
(c_parser_omp_context_selector): Pass 2 as last argument to
c_parser_omp_all_clauses.
cp/
* parser.c (cp_parser_omp_all_clauses): Change bool NESTED_P argument
into int NESTED, if it is 2, diagnose missing commas in between
clauses.
(cp_parser_omp_context_selector): Pass 2 as last argument to
cp_parser_omp_all_clauses.
testsuite/
* c-c++-common/gomp/declare-variant-7.c: Add tests for clauses not
separated by commas in simd selector trait properties.
From-SVN: r276950
Aldy Hernandez [Mon, 14 Oct 2019 06:43:03 +0000 (06:43 +0000)]
Normalize unsigned ~[0,0] into [1,MAX].
From-SVN: r276949
Xiong Hu Luo [Mon, 14 Oct 2019 02:04:04 +0000 (02:04 +0000)]
Fix dump message issue
'}' is missed at the end.
gcc/ChangeLog:
2019-10-14 Xiong Hu Luo <luoxhu@linux.ibm.com>
* tree-sra.c (dump_access): Add missing braces.
From-SVN: r276948
GCC Administrator [Mon, 14 Oct 2019 00:16:16 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r276947
Iain Sandoe [Sun, 13 Oct 2019 18:58:50 +0000 (18:58 +0000)]
[Darwin, machopic 8/n] Back out part of PR71767 fix.
We applied a conservative, but fairly large, hammer to fix PR71767.
However, ideally, we want minimise the number of symbols visible to
ld64 and to match the cases emitted by clang (since that's what ld64
is expecting). Now we've improved the handling of indirections, we
can make the indirection symbols local when they are in the regular
non-lazy symbol pointers section. We will continue to make any
indirections in the data section visible (since right now we have no
way to track if a given symbol follows a weak global).
This change makes no difference to handling of labels for constants
(to be revised in a future patch).
There's a mechanical change to a number of tests (allowing 'l' or 'L'
as the indirection symbol prefix).
gcc/ChangeLog:
2019-10-13 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.c (machopic_indirection_name): Rework the
function to emit linker-visible symbols only for indirections
in the data section. Clean up the code and update comments.
gcc/testsuite/ChangeLog:
2019-10-13 Iain Sandoe <iain@sandoe.co.uk>
* gcc.target/i386/indirect-thunk-1.c: Allow 'l' or 'L' in
indirection label prefix, for Darwin.
* gcc.target/i386/indirect-thunk-2.c: Likewise.
* gcc.target/i386/indirect-thunk-3.c: Likewise.
* gcc.target/i386/indirect-thunk-4.c: Likewise.
* gcc.target/i386/indirect-thunk-attr-1.c: Likewise.
* gcc.target/i386/indirect-thunk-attr-2.c: Likewise.
* gcc.target/i386/indirect-thunk-attr-3.c: Likewise.
* gcc.target/i386/indirect-thunk-attr-4.c: Likewise.
* gcc.target/i386/indirect-thunk-attr-5.c: Likewise.
* gcc.target/i386/indirect-thunk-attr-6.c: Likewise.
* gcc.target/i386/indirect-thunk-extern-1.c: Likewise.
* gcc.target/i386/indirect-thunk-extern-2.c: Likewise.
* gcc.target/i386/indirect-thunk-extern-3.c: Likewise.
* gcc.target/i386/indirect-thunk-extern-4.c: Likewise.
* gcc.target/i386/indirect-thunk-inline-1.c: Likewise.
* gcc.target/i386/indirect-thunk-inline-2.c: Likewise.
* gcc.target/i386/indirect-thunk-inline-3.c: Likewise.
* gcc.target/i386/indirect-thunk-inline-4.c: Likewise.
* gcc.target/i386/pr32219-2.c: Likewise.
* gcc.target/i386/pr32219-3.c: Likewise.
* gcc.target/i386/pr32219-4.c: Likewise.
* gcc.target/i386/pr32219-7.c: Likewise.
* gcc.target/i386/pr32219-8.c: Likewise.
* gcc.target/i386/ret-thunk-14.c: Likewise.
* gcc.target/i386/ret-thunk-15.c: Likewise.
* gcc.target/i386/ret-thunk-9.c: Likewise.
From-SVN: r276943
Iain Sandoe [Sun, 13 Oct 2019 18:30:25 +0000 (18:30 +0000)]
[Darwin, machopic 7/n] Remove code that should be dead.
This code fragment was imported from the Apple branch (it was never
applied to mainline). It is stated to fix up a problem sometimes
created by reload (before that had been extended to have greater
flexibility in assigning the pic registers). In any event, reload
is no longer in use for the port.
gcc/ChangeLog:
2019-10-13 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.c (machopic_indirect_data_reference): Remove
redundant code.
From-SVN: r276942
Damian Rouson [Sun, 13 Oct 2019 17:16:40 +0000 (17:16 +0000)]
re PR fortran/91513 (Non-standard terminology in error message for pointer component assignment in pure procedure)
2019-10-13 Damian Rouson <damain@sourceryinstitue.org>
PR fortran/91513
* resolve.c (resolve_ordinary_assign): Improved error message.
2019-10-13 Damian Rouson <damain@sourceryinstitue.org>
PR fortran/91513
* gfortran.dg/impure_assignment_2.f90: Update dg-error regex.
From-SVN: r276941
Steven G. Kargl [Sun, 13 Oct 2019 16:51:33 +0000 (16:51 +0000)]
re PR fortran/90297 (gcc/fortran/resolve.c: 2 * possibly redundant code ?)
2019-10-13 Steven G. Kargl <kargl@gcc.gnu.org>
PR fortran/90297
* resolve.c (resolve_typebound_function): Remove code with no
functional effect.
From-SVN: r276940
Nathan Sidwell [Sun, 13 Oct 2019 14:46:45 +0000 (14:46 +0000)]
[PATCH] teach gengtype about 'mutable'
https://gcc.gnu.org/ml/gcc-patches/2019-10/msg00942.html
In constifying some more of line-map I discovered gengtype didn't know mutable. Added thusly.
* gengtype-lex.l (CXX_KEYWORD): Add 'mutable'.
From-SVN: r276939
Thomas Koenig [Sun, 13 Oct 2019 13:42:30 +0000 (13:42 +0000)]
re PR fortran/92017 (ICE in gfc_expr_attr, at fortran/primary.c:2674)
2019-10-13 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92017
* expr.c (simplify_parameter_variable): Set the character length
of the result expression from the original expression if
necessary.
2019-10-13 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92017
* gfortran.dg/minmaxloc_14.f90: New test.
From-SVN: r276938
Rainer Orth [Sun, 13 Oct 2019 11:42:15 +0000 (11:42 +0000)]
Remove dg-add-options c99_runtime
gcc:
* doc/sourcebuild.texi (Test Directives, Add Options): Remove
c99_runtime.
gcc/testsuite:
* lib/target-supports.exp (add_options_for_c99_runtime): Remove.
(check_effective_target_c99_runtime): Remove call to
add_options_for_c99_runtime.
* gcc.dg/builtins-18.c: Remove dg-add-options c99_runtime.
* gcc.dg/builtins-20.c: Likewise.
* gcc.dg/builtins-53.c: Likewise.
* gcc.dg/builtins-55.c: Likewise.
* gcc.dg/builtins-67.c: Likewise.
* gcc.dg/c99-tgmath-1.c: Likewise.
* gcc.dg/c99-tgmath-2.c: Likewise.
* gcc.dg/c99-tgmath-3.c: Likewise.
* gcc.dg/c99-tgmath-4.c: Likewise.
* gcc.dg/ipa/inline-8.c: Likewise.
* gcc.dg/ipa/ipa-icf-5.c: Likewise.
* gcc.dg/ipa/ipa-icf-7.c: Likewise.
* gcc.dg/nextafter-2.c: Likewise.
* gcc.dg/pr42427.c: Likewise.
* gcc.dg/pr78965.c: Likewise.
* gcc.dg/single-precision-constant.c: Likewise.
* gcc.dg/torture/builtin-convert-1.c: Likewise.
* gcc.dg/torture/builtin-convert-2.c: Likewise.
* gcc.dg/torture/builtin-convert-3.c: Likewise.
* gcc.dg/torture/builtin-convert-4.c: Likewise.
* gcc.dg/torture/builtin-fp-int-inexact.c: Likewise.
* gcc.dg/torture/builtin-fp-int-inexact-c2x.c: Likewise.
* gcc.dg/torture/builtin-integral-1.c: Likewise.
* gcc.dg/torture/builtin-power-1.c: Likewise.
* gcc.dg/tree-ssa/copy-sign-1.c: Likewise.
* gcc.dg/tree-ssa/minmax-2.c: Likewise.
* gcc.dg/tree-ssa/mult-abs-2.c: Likewise.
* gcc.target/i386/387-builtin-fp-int-inexact.c: Likewise.
* gcc.target/i386/387-rint-inline-1.c: Likewise.
* gcc.target/i386/387-rint-inline-2.c: Likewise.
* gcc.target/i386/conversion.c: Likewise.
* gcc.target/i386/pr47312.c: Likewise.
* gcc.target/i386/sse2-builtin-fp-int-inexact.c: Likewise.
* gcc.target/i386/sse2-rint-inline-1.c: Likewise.
* gcc.target/i386/sse2-rint-inline-2.c: Likewise.
* gcc.target/i386/sse4_1-builtin-fp-int-inexact.c: Likewise.
* gcc.target/i386/sse4_1-rint-inline.c: Likewise.
From-SVN: r276937
Jan Hubicka [Sun, 13 Oct 2019 11:25:57 +0000 (13:25 +0200)]
lto-common.c (read_cgraph_and_symbols): Grow ggc memory use after summary streaming.
* lto-common.c (read_cgraph_and_symbols): Grow ggc memory use after
summary streaming.
From-SVN: r276936
Jan Hubicka [Sun, 13 Oct 2019 08:34:10 +0000 (10:34 +0200)]
* lto.c (lto_wpa_write_files): Do not update bodies of clones.
From-SVN: r276935
Jan Hubicka [Sun, 13 Oct 2019 07:34:31 +0000 (09:34 +0200)]
lto-streamer-out.c (collect_block_tree_leafs): Renumber statements so non-virutal are before virutals.
* lto-streamer-out.c (collect_block_tree_leafs): Renumber statements
so non-virutal are before virutals.
(output_function): Avoid body modifications.
From-SVN: r276934
GCC Administrator [Sun, 13 Oct 2019 00:16:44 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r276933
John David Anglin [Sat, 12 Oct 2019 20:37:37 +0000 (20:37 +0000)]
pa.c (pa_output_call): Load descriptor address to register %r22.
* config/pa/pa.c (pa_output_call): Load descriptor address to register
%r22. Load function address before global pointer.
(pa_attr_length_indirect_call): Adjust length of inline versions of
$$dyncall.
(pa_output_indirect_call): Remove fast inline version of $$dyncall
before normal cases. Update inline $$dyncall sequences to preserve
function descriptor address in register %r22.
(TRAMPOLINE_CODE_SIZE): Adjust.
(pa_asm_trampoline_template): Revise 32-bit trampoline. Don't assume
register %r22 contains trampoline address.
(pa_trampoline_init): Adjust offsets.
(pa_trampoline_adjust_address): Likewise.
* config/pa/pa.h (TRAMPOLINE_SIZE): Adjust 32-bit size.
From-SVN: r276928
Iain Sandoe [Sat, 12 Oct 2019 19:41:50 +0000 (19:41 +0000)]
[Darwin, machopic 6/n] Fix for 67183
When we're using the LLVM-based assembler (the default on modern Darwin)
the ordering of stubs and non-lazy symbol pointers is important.
Interleaving the output (current GCC behaviour) leads to crashes which
prevents us from building code with symbol stubs.
To resolve this, we order the output of stubs and symbol indirections:
1. Any indirections in the data section
2. Symbol stubs.
3. Non-lazy symbol pointers.
At present, we still emit LTO sections after these.
gcc/ChangeLog:
2019-10-12 Iain Sandoe <iain@sandoe.co.uk>
PR target/67183
* config/darwin.c (machopic_indirection): New field to flag
non-lazy-symbol-pointers in the data section.
(machopic_indirection_name): Compute if an indirection should
appear in the data section.
(machopic_output_data_section_indirection): New callback split
from machopic_output_indirection.
(machopic_output_stub_indirection): Likewise.
(machopic_output_indirection): Retain the code for non-lazy
symbol pointers in their regular section.
(machopic_finish): Use the new callbacks to order the indirection
output.
From-SVN: r276926
John David Anglin [Sat, 12 Oct 2019 19:40:42 +0000 (19:40 +0000)]
lib2funcs.S (__gcc_plt_call): Load branch target to %r21.
* config/pa/lib2funcs.S (__gcc_plt_call): Load branch target to %r21.
Load PIC register after branch target. Fix white space.
* config/pa/milli64.S ($$dyncall): Separate LINUX and non LINUX
implementations. Load PIC register after branch target. Don't
clobber function pointer when it points to function descriptor.
Use nullification instead of branch in LINUX implementation.
From-SVN: r276925
Iain Sandoe [Sat, 12 Oct 2019 19:24:48 +0000 (19:24 +0000)]
[Darwin, machopic 5/n] Make machopic_finish() static.
It's only called from darwin.c.
gcc/ChangeLog:
2019-10-12 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin-protos.h (machopic_finish): Delete.
* config/darwin.c (machopic_finish): Make static.
From-SVN: r276924
Iain Sandoe [Sat, 12 Oct 2019 19:20:43 +0000 (19:20 +0000)]
[Darwin] Suppress emitting empty ctor/dtor sections.
Older versions of GCC emit empty .constructor/.destructor sections
whenever building for C++. In fact, these sections are only used for
kernel mode code - so don't emit them unless that's what we're
building.
gcc/ChangeLog:
2019-10-12 Iain Sandoe <iain@sandoe.co.uk>
* config/darwin.c (darwin_file_end): Only emit empty CTOR/DTOR
sections when building kernel extension code.
From-SVN: r276923
Palmer Dabbelt [Sat, 12 Oct 2019 19:07:16 +0000 (19:07 +0000)]
Fix the ChangeLog for my previous commit
Fixes: 66ce32bb2a8 ("Fix the ChangeLog for my previous commit")
From-SVN: r276922
Palmer Dabbelt [Sat, 12 Oct 2019 19:05:38 +0000 (19:05 +0000)]
The inline keyword is supported in all new C standards
The documentation used to indicate that the inline keyword was only
supported by c99 and c11, whereas in fact it is supported by c99 and all
newer standards.
gcc/ChangeLog
2019-10-12 Palmer Dabbelt <palmer@sifive.com>
* doc/extend.texi (Alternate Keywords): Change "-std=c11" to "a
later standard."
From-SVN: r276921
John David Anglin [Sat, 12 Oct 2019 18:31:42 +0000 (18:31 +0000)]
pa.c (pa_option_override): Remove trailing comma from warning.
* gcc/config/pa/pa.c (pa_option_override): Remove trailing comma
from warning.
From-SVN: r276920