Martin Liska [Thu, 4 Oct 2018 14:44:53 +0000 (16:44 +0200)]
Error about alias attribute with body definition (PR c/87483).
2018-10-04 Martin Liska <mliska@suse.cz>
PR c/87483
* cgraphunit.c (process_function_and_variable_attributes):
Warn about a function with alias attribute and a body.
2018-10-04 Martin Liska <mliska@suse.cz>
PR c/87483
* gcc.dg/pr87483.c: New test.
From-SVN: r264846
Martin Liska [Thu, 4 Oct 2018 14:36:55 +0000 (16:36 +0200)]
Redirect call within specific target attribute among MV clones (PR ipa/82625).
2018-10-04 Martin Liska <mliska@suse.cz>
PR ipa/82625
* multiple_target.c (redirect_to_specific_clone): New function.
(ipa_target_clone): Use it.
* tree-inline.c: Fix comment.
2018-10-04 Martin Liska <mliska@suse.cz>
PR ipa/82625
* g++.dg/ext/pr82625.C: New test.
From-SVN: r264845
David Malcolm [Thu, 4 Oct 2018 14:33:47 +0000 (14:33 +0000)]
Fix -fopt-info for plugin passes
Attempts to dump via -fopt-info from a plugin pass fail, due
to the dfi->alt_state for such passes never being set.
This is because the -fopt-info options were being set up per-pass
during option-parsing (via gcc::dump_manager::opt_info_enable_passes),
but this data was not retained or used it for passes created later
(for plugins and target-specific passes).
This patch fixes the issue by storing the -fopt-info options into
gcc::dump_manager, refactoring the dfi-setup code out of
opt_info_enable_passes, and reusing it for such passes, fixing the
issue. The patch adds a demo plugin to test that dumping from a
plugin works.
gcc/ChangeLog:
* dumpfile.c (gcc::dump_manager::dump_manager): Initialize new
fields.
(gcc::dump_manager::~dump_manager): Free m_optinfo_filename.
(gcc::dump_manager::register_pass): New member function, adapted
from loop body in gcc::pass_manager::register_pass, adding a
call to update_dfi_for_opt_info.
(gcc::dump_manager::opt_info_enable_passes): Store the
-fopt-info options into the new fields. Move the loop
bodies into...
(gcc::dump_manager::update_dfi_for_opt_info): ...this new member
function.
* dumpfile.h (struct opt_pass): New forward decl.
(gcc::dump_manager::register_pass): New decl.
(gcc::dump_manager::update_dfi_for_opt_info): New decl.
(class gcc::dump_manager): Add fields "m_optgroup_flags",
"m_optinfo_flags", and "m_optinfo_filename".
* passes.c (gcc::pass_manager::register_pass): Move all of the
dump-handling code to gcc::dump_manager::register_pass.
gcc/testsuite/ChangeLog:
* gcc.dg/plugin/dump-1.c: New test.
* gcc.dg/plugin/dump_plugin.c: New test plugin.
* gcc.dg/plugin/plugin.exp (plugin_test_list): Add the above.
From-SVN: r264844
Peter Bergner [Thu, 4 Oct 2018 13:38:51 +0000 (08:38 -0500)]
Add missing ChangeLog entry for previous commit
From-SVN: r264843
Peter Bergner [Thu, 4 Oct 2018 13:36:20 +0000 (08:36 -0500)]
re PR rtl-optimization/87466 (IRA and LRA spill all pseudos that are live across setjmp calls)
gcc/
PR rtl-optimization/87466
* target.def (setjmp_preserves_nonvolatile_regs_p): New target hook.
* doc/tm.texi.in (TARGET_SETJMP_PRESERVES_NONVOLATILE_REGS_P): New hook.
* doc/tm.texi: Regenerate.
* ira-lives.c (process_bb_node_lives): Use the new target hook.
* lra-lives.c (process_bb_lives): Likewise.
* config/rs6000/rs6000.c (TARGET_SETJMP_PRESERVES_NONVOLATILE_REGS_P):
Define.
gcc/testsuite/
PR rtl-optimization/87466
* gcc.target/powerpc/pr87466.c: New test.
From-SVN: r264842
Tamar Christina [Thu, 4 Oct 2018 13:06:59 +0000 (13:06 +0000)]
Remove superfluous assignment in add_params.
This fixes the superfluous assignment that Coverity reported in add_params,
and changes the starting index from 0 to num_params - n in order for it to
work properly if add_params is called multiple times.
validate_params calls error so it doesn't matter that we don't check the
results here. The results is checked in individual parameter updates after
front-end initialization.
2018-10-04 Tamar Christina <tamar.christina@arm.com>
* params.c (add_params): Fix initialization.
From-SVN: r264841
Martin Liska [Thu, 4 Oct 2018 12:41:14 +0000 (14:41 +0200)]
Fix divergence in indirect profiling (PR gcov-profile/84107).
2018-10-04 Martin Liska <mliska@suse.cz>
PR gcov-profile/84107
* tree-profile.c (init_ic_make_global_vars):
Remove ic_void_ptr_var and ic_gcov_type_ptr_var.
Come up with new ic_tuple* variables. Emit
__gcov_indirect_call{,_topn} variables.
(gimple_gen_ic_profiler): Access the variable
and emit gimple.
(gimple_gen_ic_func_profiler): Access
__gcov_indirect_call.callee field.
(gimple_init_gcov_profiler): Use ptr_type_node.
* value-prof.c (gimple_ic): Use ptr_type_node.
2018-10-04 Martin Liska <mliska@suse.cz>
PR gcov-profile/84107
* libgcov-profiler.c (__gcov_indirect_call):
Change type to indirect_call_tuple.
(struct indirect_call_tuple): New struct.
(__gcov_indirect_call_topn_profiler): Change type.
(__gcov_indirect_call_profiler_v2): Use the new
variables.
* libgcov.h (struct indirect_call_tuple): New struct
definition.
From-SVN: r264840
Nathan Sidwell [Thu, 4 Oct 2018 11:36:15 +0000 (11:36 +0000)]
[C++ PATCH] String concatenation is a thing
https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00248.html
* lang-specs.h: Use string contatenation, not line splicing.
From-SVN: r264839
Prathamesh Kulkarni [Thu, 4 Oct 2018 11:06:24 +0000 (11:06 +0000)]
re PR tree-optimization/85787 (malloc_candidate_p fails to detect malloc attribute on nested phis)
2018-10-04 Prathamesh Kulkarni <prathamesh.kulkarni@linaro.org>
PR tree-optimization/85787
* ipa-pure-const.c (malloc_candidate_p_1): Move most of malloc_candidate_p
into this function and add support for detecting multiple phis.
(DUMP_AND_RETURN): Move from malloc_candidate_p into top-level macro.
testsuite/
* gcc.dg/ipa/propmalloc-4.c: New test.
From-SVN: r264838
Bernhard Reutner-Fischer [Thu, 4 Oct 2018 08:59:12 +0000 (10:59 +0200)]
contrib: Add unused_functions.py script
For a set of object-files, determine symbols that are
- public but should be static
2018-10-04 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
* unused_functions.py: New file.
From-SVN: r264837
Richard Biener [Thu, 4 Oct 2018 08:59:12 +0000 (08:59 +0000)]
cunroll-15.c: Add XFAILs for arm and powerpc.
2018-10-04 Richard Biener <rguenther@suse.de>
* gcc.dg/tree-ssa/cunroll-15.c: Add XFAILs for arm and powerpc.
From-SVN: r264836
Martin Liska [Thu, 4 Oct 2018 08:06:52 +0000 (10:06 +0200)]
Call ultimate_alias_target for node being inlined (PR ipa/87491).
2018-10-04 Martin Liska <mliska@suse.cz>
PR ipa/87491
* ipa-inline.c (inline_to_all_callers_1):
Call ultimate_alias_target for node being inlined.
From-SVN: r264835
Thomas Preud'homme [Thu, 4 Oct 2018 07:55:02 +0000 (07:55 +0000)]
Never reload fixed form constraints memory operand
The unconditional reload of address operand for recognized instruction
in process_address_1 prevent the patch fixing PR85434 from working as
expected. The code in that patch attempts to control which registers are
used to make PIC access but the reload performed by process_address_1
will use generic PIC access. This patch removes the test for the
instruction to be unrecognized to do the reload, thus always avoiding to
reload address operand for fixed constraints (such as "X" used in the
patch).
2018-10-04 Thomas Preud'homme <thomas.preudhomme@linaro.org>
gcc/
* lra-constraints.c (process_address_1): Bail out for all
satisfied fixed constraints.
From-SVN: r264834
Jeff Law [Thu, 4 Oct 2018 02:55:10 +0000 (20:55 -0600)]
gimple-ssa-sprintf.c (format_string): Do not hardcode size of target's wchar_t.
* gimple-ssa-sprintf.c (format_string): Do not hardcode size of
target's wchar_t.
* tree.c (get_typenode_from_name): Moved from fortran/trans-types.c.
* tree.h (get_typenode_from_name): Prototype.
* trans-types.c (get_typenode_from_name): Moved into gcc/tree.c.
From-SVN: r264833
GCC Administrator [Thu, 4 Oct 2018 00:16:46 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264831
Uros Bizjak [Wed, 3 Oct 2018 21:51:50 +0000 (23:51 +0200)]
i386.md (*cmp<X87MODEF:mode>_<SWI24:mode>_i387): Change operand 2 predicate to nonimmediate_operand.
* config/i386/i386.md (*cmp<X87MODEF:mode>_<SWI24:mode>_i387):
Change operand 2 predicate to nonimmediate_operand.
(*cmp<X87MODEF:mode>_<SWI24:mode>_cc_i387): Ditto.
From-SVN: r264827
Ian Lance Taylor [Wed, 3 Oct 2018 21:03:50 +0000 (21:03 +0000)]
* go.test/go-test.exp (go-set-goarch): Use amd64p32 on x32.
From-SVN: r264825
Uros Bizjak [Wed, 3 Oct 2018 20:29:10 +0000 (22:29 +0200)]
libgcc2.c (isnan): Use __builtin_isnan.
* libgcc2.c (isnan): Use __builtin_isnan.
(isfinite): Use __builtin_isfinite.
(isinf): Use __builtin_isinf.
From-SVN: r264823
Martin Sebor [Wed, 3 Oct 2018 20:00:46 +0000 (20:00 +0000)]
gimple-ssa-sprintf.c (struct fmtresult): Add new member and initialize it.
* gimple-ssa-sprintf.c (struct fmtresult): Add new member and
initialize it.
(get_string_length): Detect unterminated arrays.
(format_string): Same.
(format_directive): Warn about unterminated arrays.
(handle_gimple_call): Mark statements with no_warning as needed.
* gcc.dg/warn-sprintf-no-nul.c: New test.
Co-Authored-By: Jeff Law <law@redhat.com>
From-SVN: r264822
Jim Wilson [Wed, 3 Oct 2018 19:09:32 +0000 (19:09 +0000)]
RISC-V: Add macro for ilp32e ABI. Cleanup white space.
gcc/
* config/riscv/riscv-c.c (riscv_cpu_cpp_builtins): For ABI_ILP32E,
also define __riscv_abi_rve. Delete trailing white space.
From-SVN: r264821
Paul Koning [Wed, 3 Oct 2018 18:46:51 +0000 (14:46 -0400)]
Enable LRA register allocator for PDP11.
Enable LRA register allocator for PDP11. -- missed checking in
ChangeLog.
From-SVN: r264820
Paul Koning [Wed, 3 Oct 2018 18:31:52 +0000 (14:31 -0400)]
Enable LRA register allocator for PDP11.
* config/pdp11/constraints.md (Q): Use define_memory_constraints.
(R): Likewise.
(D): Likewise.
* config/pdp11/pdp11.c (pdp11_lra_p): New function.
* config/pdp11/pdp11.opt (-mlra): New option.
* doc/invoke.texi (PDP-11 Options): Document -mlra.
From-SVN: r264819
Uros Bizjak [Wed, 3 Oct 2018 18:28:16 +0000 (20:28 +0200)]
i386.md (*<absneg:code>extendsfdf2): Remove.
* config/i386/i386.md (*<absneg:code>extendsfdf2): Remove.
(*<absneg:code>extend<mode>xf2): Ditto.
From-SVN: r264818
Aldy Hernandez [Wed, 3 Oct 2018 17:36:29 +0000 (17:36 +0000)]
re PR tree-optimization/87415 (wrong code at -O1 and above on x86_64-linux-gnu)
PR tree-optimization/87415
* tree-vrp.c (set_value_range_with_overflow): Special case one bit
precision fields.
From-SVN: r264817
Jeff Law [Wed, 3 Oct 2018 17:23:15 +0000 (11:23 -0600)]
gimple-fold.c (get_range_strlen): Only set *nonstr when an unterminated string is discovered.
* gimple-fold.c (get_range_strlen): Only set *nonstr when
an unterminated string is discovered. Bubble up range
even for unterminated strings.
(gimple_fold_builtin_strlen): Do not fold if get_range_strlen
indicates the string was not terminated via NONSTR.
From-SVN: r264816
Aldy Hernandez [Wed, 3 Oct 2018 17:18:52 +0000 (17:18 +0000)]
tree-vrp.c (extract_range_from_unary_expr): Special case all pointer conversions.
* tree-vrp.c (extract_range_from_unary_expr): Special case all
pointer conversions.
Do not do anything special for anti-ranges.
From-SVN: r264815
Jason Merrill [Wed, 3 Oct 2018 15:56:29 +0000 (11:56 -0400)]
Implement P0840, language support for empty objects.
The [[no_unique_address]] attribute on a non-static data member
enables the equivalent of the empty base optimization.
gcc/cp/
* tree.c (handle_no_unique_addr_attribute): New.
(cxx_attribute_table): Add [[no_unique_address]].
* class.c (field_poverlapping_p): New.
(layout_class_type): Check it. Adjust DECL_SIZE of potentially
overlapping fields.
(layout_empty_base_or_field): Rename from layout_empty_base, handle
FIELD_DECL as well.
(build_base_field, record_subobject_offsets): Adjust.
c-family/
* c-lex.c (c_common_has_attribute): Add no_unique_address.
From-SVN: r264813
Jonathan Wakely [Wed, 3 Oct 2018 11:27:40 +0000 (12:27 +0100)]
PR libstdc++/59439 optimize uses of classic ("C") std::locale
The global locale::_Impl that represents the "C" locale is never
destroyed, so there is no need to keep track of reference count updates
for that object. This greatly reduce contention between threads that
refer to the classic locale. Since the global std::locale initially uses
the classic locale, this benefits the common case for any code using the
global locale, such as construction/destruction of iostream objects.
All these updates are done inside libstdc++.so so there's no need to
worry about users' objects having inlined old versions of the code which
still update the reference count for the classic locale.
PR libstdc++/59439
* src/c++98/locale.cc (locale::locale(const locale&)): Bypass
reference count updates for the classic locale.
(locale::~locale()): Likewise.
(locale::operator=(const locale&)): Likewise.
* src/c++98/locale_init.cc (locale::locale()): Likewise.
(locale::global(const locale&)): Likewise.
From-SVN: r264811
Jerome Lambourg [Wed, 3 Oct 2018 09:31:36 +0000 (09:31 +0000)]
Fix ARM_TARGET2_DWARF_FORMAT for vxworks
2018-10-03 Jérôme Lambourg <lambourg@adacore.com>
* config/arm/vxworks.h (ARM_TARGET2_DWARF_FORMAT): Adjust to
DW_EH_PE_pcrel | DW_EH_PE_indirect for RTPs.
From-SVN: r264808
Martin Liska [Wed, 3 Oct 2018 08:30:10 +0000 (10:30 +0200)]
Properly mark lambdas in GCOV (PR gcov-profile/86109).
2018-10-03 Martin Liska <mliska@suse.cz>
PR gcov-profile/86109
* coverage.c (coverage_begin_function): Do not
mark lambdas as artificial.
* tree-core.h (struct GTY): Remove tm_clone_flag
and introduce new lambda_function.
* tree.h (DECL_LAMBDA_FUNCTION): New macro.
2018-10-03 Martin Liska <mliska@suse.cz>
PR gcov-profile/86109
* parser.c (cp_parser_lambda_declarator_opt):
Set DECL_LAMBDA_FUNCTION for lambdas.
2018-10-03 Martin Liska <mliska@suse.cz>
PR gcov-profile/86109
* g++.dg/gcov/pr86109.C: New test.
From-SVN: r264806
François Dumont [Wed, 3 Oct 2018 05:50:01 +0000 (05:50 +0000)]
2018-10-03 François Dumont <fdumont@gcc.gnu.org>
* include/debug/map.h
(map<>::emplace<>(_Args&&...)): Use C++11 direct initialization.
(map<>::emplace_hint<>(const_iterator, _Args&&...)): Likewise.
(map<>::insert(value_type&&)): Likewise.
(map<>::insert<>(_Pair&&)): Likewise.
(map<>::insert<>(const_iterator, _Pair&&)): Likewise.
(map<>::try_emplace): Likewise.
(map<>::insert_or_assign): Likewise.
(map<>::insert(node_type&&)): Likewise.
(map<>::insert(const_iterator, node_type&&)): Likewise.
(map<>::erase(const_iterator)): Likewise.
(map<>::erase(const_iterator, const_iterator)): Likewise.
* include/debug/multimap.h
(multimap<>::emplace<>(_Args&&...)): Use C++11 direct initialization.
(multimap<>::emplace_hint<>(const_iterator, _Args&&...)): Likewise.
(multimap<>::insert<>(_Pair&&)): Likewise.
(multimap<>::insert<>(const_iterator, _Pair&&)): Likewise.
(multimap<>::insert(node_type&&)): Likewise.
(multimap<>::insert(const_iterator, node_type&&)): Likewise.
(multimap<>::erase(const_iterator)): Likewise.
(multimap<>::erase(const_iterator, const_iterator)): Likewise.
* include/debug/set.h
(set<>::emplace<>(_Args&&...)): Use C++11 direct initialization.
(set<>::emplace_hint<>(const_iterator, _Args&&...)): Likewise.
(set<>::insert(value_type&&)): Likewise.
(set<>::insert<>(const_iterator, value_type&&)): Likewise.
(set<>::insert(const_iterator, node_type&&)): Likewise.
(set<>::erase(const_iterator)): Likewise.
(set<>::erase(const_iterator, const_iterator)): Likewise.
* include/debug/multiset.h
(multiset<>::emplace<>(_Args&&...)): Use C++11 direct initialization.
(multiset<>::emplace_hint<>(const_iterator, _Args&&...)): Likewise.
(multiset<>::insert<>(value_type&&)): Likewise.
(multiset<>::insert<>(const_iterator, value_type&&)): Likewise.
(multiset<>::insert(node_type&&)): Likewise.
(multiset<>::insert(const_iterator, node_type&&)): Likewise.
(multiset<>::erase(const_iterator)): Likewise.
(multiset<>::erase(const_iterator, const_iterator)): Likewise.
From-SVN: r264805
GCC Administrator [Wed, 3 Oct 2018 00:16:59 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264804
Gerald Pfeifer [Tue, 2 Oct 2018 20:02:03 +0000 (20:02 +0000)]
* io/close.c [!HAVE_UNLINK_OPEN_FILE]: Include <string.h>.
From-SVN: r264800
Aaron Sawdey [Tue, 2 Oct 2018 17:31:53 +0000 (17:31 +0000)]
re PR target/87474 (ICE in extract_insn, at recog.c:2305)
2018-10-02 Aaron Sawdey <acsawdey@linux.ibm.com>
PR target/87474
* config/rs6000/rs6000-string.c (expand_strn_compare): Check that both
P8_VECTOR and VSX are enabled.
From-SVN: r264799
Ian Lance Taylor [Tue, 2 Oct 2018 16:45:51 +0000 (16:45 +0000)]
internal/bytealg: support systems that don't have memmem
Reviewed-on: https://go-review.googlesource.com/138839
From-SVN: r264798
Andreas Krebbel [Tue, 2 Oct 2018 15:36:49 +0000 (15:36 +0000)]
S/390: Support IBM z14 Model ZR1 with -march=native
This adds the CPU model number of the IBM z14 Model ZR1 machine to
-march=native. The patch doesn't actually change anything since we
anyway default to z14 for unknown CPU model numbers. So this is just
for the sake of completeness.
2018-10-02 Andreas Krebbel <krebbel@linux.ibm.com>
* config/s390/driver-native.c (s390_host_detect_local_cpu): Add
0x3907 as CPU model number.
From-SVN: r264797
Andreas Krebbel [Tue, 2 Oct 2018 15:35:52 +0000 (15:35 +0000)]
S/390: Rename arch12 to z14
This is a mechanical change not impacting code generation. With that
patch I try to hide the artificial CPU name arch12 which we had to use
before the announcement of the IBM z14 machine. arch12 of course
stays a valid option to -march and -mtune. So this is just about
making the code somewhat easier to read.
gcc/ChangeLog:
2018-10-02 Andreas Krebbel <krebbel@linux.ibm.com>
* common/config/s390/s390-common.c: Rename PF_ARCH12 to PF_Z14.
* config/s390/s390.h (enum processor_flags): Rename PF_ARCH12 to
PF_Z14. Rename TARGET_CPU_ARCH12 to TARGET_CPU_Z14,
TARGET_CPU_ARCH12_P to TARGET_CPU_Z14_P, TARGET_ARCH12 to
TARGET_Z14, and TARGET_ARCH12_P to TARGET_Z14_P.
* config/s390/s390.md: Likewise. Rename also the cpu attribute
value from arch12 to z14.
From-SVN: r264796
Uros Bizjak [Tue, 2 Oct 2018 15:27:07 +0000 (17:27 +0200)]
i386.md (fxam<mode>2_i387_with_temp): Remove.
* config/i386/i386.md (fxam<mode>2_i387_with_temp): Remove.
(isinfxf2): Ditto.
(isinf<mode>2): Ditto.
From-SVN: r264795
Uros Bizjak [Tue, 2 Oct 2018 15:12:30 +0000 (17:12 +0200)]
i386.c (ix86_emit_i387_round): Extend op1 to XFmode before emitting fxam.
* config/i386/i386.c (ix86_emit_i387_round): Extend op1 to XFmode
before emitting fxam. Perform calculations in XFmode.
From-SVN: r264794
Ian Lance Taylor [Tue, 2 Oct 2018 15:07:14 +0000 (15:07 +0000)]
net: don't fail test if splice fails because pipe2 is missing
This reportedly happens on CentOS 5.11. The real code will work fine;
this test is assuming that the unexported slice function will handle
the splice, but if pipe2 does not work then it doesn't. The relevant
code in internal/poll/splice_linux.go says "Falling back to pipe is
possible, but prior to 2.6.29 splice returns -EAGAIN instead of 0 when
the connection is closed."
Reviewed-on: https://go-review.googlesource.com/138838
From-SVN: r264793
Marc Glisse [Tue, 2 Oct 2018 15:02:13 +0000 (17:02 +0200)]
((X /[ex] A) +- B) * A --> X +- A * B
2018-10-02 Marc Glisse <marc.glisse@inria.fr>
gcc/
* match.pd (((X /[ex] A) +- B) * A): New transformation.
gcc/testsuite/
* gcc.dg/tree-ssa/muldiv-1.c: New file.
* gcc.dg/tree-ssa/muldiv-2.c: Likewise.
From-SVN: r264792
Marc Glisse [Tue, 2 Oct 2018 14:59:25 +0000 (16:59 +0200)]
vector<bool> _M_start and 0 offset
2018-10-02 Marc Glisse <marc.glisse@inria.fr>
PR libstdc++/87258
* include/bits/stl_bvector.h (vector::begin(), vector::cbegin()):
Rebuild _M_start with an explicit 0 offset.
From-SVN: r264791
Marc Glisse [Tue, 2 Oct 2018 14:55:39 +0000 (16:55 +0200)]
No a*x+b*x factorization for signed vectors
2018-10-02 Marc Glisse <marc.glisse@inria.fr>
PR middle-end/87319
* fold-const.c (fold_plusminus_mult_expr): Handle complex and vectors.
* tree.c (signed_or_unsigned_type_for): Handle complex.
From-SVN: r264790
Segher Boessenkool [Tue, 2 Oct 2018 14:19:49 +0000 (16:19 +0200)]
rs6000: Fix vec-init-6.c (PR87081)
Since a while we use a rldimi instead of rldicl/rldicr/or to combine
two words to one.
PR target/87081
* gcc.target/powerpc/vec-init-6.c: Fix expected asm.
From-SVN: r264789
Jeff Law [Tue, 2 Oct 2018 14:10:16 +0000 (08:10 -0600)]
* gimple-fold.c (get_range_strlen): Remove dead code.
From-SVN: r264788
Martin Sebor [Tue, 2 Oct 2018 14:08:53 +0000 (14:08 +0000)]
builtins.c (unterminated_array): Add new arguments.
* builtins.c (unterminated_array): Add new arguments.
If argument is not terminated, bubble up size and exact
state to callers.
(expand_builtin_strnlen): Detect, avoid expanding
and diagnose unterminated arrays.
(c_strlen): Fill in offset of start of unterminated strings.
* builtins.h (unterminated_array): Update prototype.
* gcc.dg/warn-strnlen-no-nul.c: New.
Co-Authored-By: Jeff Law <law@redhat.com>
From-SVN: r264787
Jonathan Wakely [Tue, 2 Oct 2018 14:00:50 +0000 (15:00 +0100)]
Avoid redundant runtime checks in std::visit
Calling std::get will check some static assertions and also do a runtime
check for a valid index before calling __detail::__variant::__get. The
std::visit function already handles the case where any variant has an
invalid index, so __get can be used directly in __visit_invoke.
* include/std/variant (__gen_vtable_impl::__visit_invoke): Call __get
directly instead of get, as caller ensures correct index is used.
(holds_alternative, get, get_if): Remove redundant inline specifiers.
(_VARIANT_RELATION_FUNCTION_TEMPLATE): Likewise.
From-SVN: r264786
Richard Biener [Tue, 2 Oct 2018 13:06:54 +0000 (13:06 +0000)]
sse.md (reduc_plus_scal_v4df): Avoid the use of haddv4df...
2018-10-02 Richard Biener <rguenther@suse.de>
* config/i386/sse.md (reduc_plus_scal_v4df): Avoid the use
of haddv4df, first reduce to SSE width and exploit the fact
that we only need element zero with the reduction result.
(reduc_plus_scal_v2df): Likewise.
From-SVN: r264785
Joseph Myers [Tue, 2 Oct 2018 12:46:32 +0000 (13:46 +0100)]
Use -fno-show-column in libstdc++ installed testing.
<https://gcc.gnu.org/ml/libstdc++/2016-08/msg00006.html> arranged for
libstdc++ tests to use -fno-show-column by default, but only for
build-tree testing. This patch adds it to the options used for
installed testing as well.
Tested with installed testing for a cross to x86_64-linux-gnu, where
it fixes various test failures.
* testsuite/lib/libstdc++.exp (libstdc++_init): Use
-fno-show-column in default cxxflags.
From-SVN: r264784
Bernhard Reutner-Fischer [Tue, 2 Oct 2018 12:35:42 +0000 (14:35 +0200)]
config: Remove unused define for os uClibc
__NO_STRING_INLINES was removed from uClibc around 2004 so has no
effect.
libstdc++-v3/ChangeLog:
2018-10-01 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
* config/os/uclibc/os_defines.h (__NO_STRING_INLINES): Delete.
From-SVN: r264783
Eric Botcazou [Tue, 2 Oct 2018 10:55:33 +0000 (10:55 +0000)]
dojump.h (do_jump): Delete.
* dojump.h (do_jump): Delete.
(do_jump_1): Likewise.
(split_comparison): Move around.
* dojump.c (do_jump): Make static.
(do_jump_1): Likewise.
(jumpifnot): Move around.
(jumpifnot_1): Likewise.
(jumpif): Likewise.
(jumpif_1): Likewise.
* expr.c (expand_expr_real_1): Call jumpif[not] instead of do_jump.
From-SVN: r264781
Eric Botcazou [Tue, 2 Oct 2018 10:20:08 +0000 (10:20 +0000)]
reorg.c (make_return_insns): Use emit_copy_of_insn_after for the insns in the delay slot and add_insn_after...
* reorg.c (make_return_insns): Use emit_copy_of_insn_after for the
insns in the delay slot and add_insn_after for the jump insn.
From-SVN: r264780
Richard Biener [Tue, 2 Oct 2018 10:08:22 +0000 (10:08 +0000)]
c-decl.c (warn_if_shadowing): Do not test DECL_FROM_INLINE.
2018-10-02 Richard Biener <rguenther@suse.de>
c/
* c-decl.c (warn_if_shadowing): Do not test DECL_FROM_INLINE.
cp/
* name-lookup.c (check_local_shadow): Do not test DECL_FROM_INLINE.
From-SVN: r264779
Richard Biener [Tue, 2 Oct 2018 10:07:29 +0000 (10:07 +0000)]
tree-inline.c (expand_call_inline): Use the location of the callee declaration for the inline-entry marker.
2018-10-02 Richard Biener <rguenther@suse.de>
* tree-inline.c (expand_call_inline): Use the location of
the callee declaration for the inline-entry marker.
* final.c (notice_source_line): Remove special-casing of
NOTE_INSN_INLINE_ENTRY.
From-SVN: r264778
GCC Administrator [Tue, 2 Oct 2018 00:16:36 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264777
Ian Lance Taylor [Mon, 1 Oct 2018 22:25:52 +0000 (22:25 +0000)]
compiler: use the underlying type to build placeholder type for alias
When asking for a placeholder type of an alias type, build a
placeholder for the underlying type, instead of treating the
alias as a named type and calling get_backend. The latter may
fail as we may not be ready to build a complete backend type. We
have already used a unified backend type for alias type and its
underlying type. Do the same for placeholders as well.
Reviewed-on: https://go-review.googlesource.com/138635
From-SVN: r264773
Ian Lance Taylor [Mon, 1 Oct 2018 20:17:11 +0000 (20:17 +0000)]
libgo: support x32 as GOARCH=amd64p32 GOOS=linux
This is enough to let libgo build when configured using
--with-multilib-list=m64,m32,mx32. I don't have an x32-enabled kernel
so I haven't tested whether it executes correctly.
For https://gcc.gnu.org/PR87470
Reviewed-on: https://go-review.googlesource.com/138817
From-SVN: r264772
Ian Lance Taylor [Mon, 1 Oct 2018 20:14:29 +0000 (20:14 +0000)]
runtime: add arm64 version of AES hash code
Rewrite the arm64 AES hashing code from gc assembler to C code using
intrinsics. The resulting code generates the same hash code for the
same input as the gc code--that doesn't matter as such, but testing it
ensures that the C code does something useful.
Reviewed-on: https://go-review.googlesource.com/138535
From-SVN: r264771
Nathan Sidwell [Mon, 1 Oct 2018 18:46:51 +0000 (18:46 +0000)]
[libiberty] Use pipe inside pex_run
https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00039.html
* configure.ac (checkfuncs): Add pipe2.
* config.in, configure: Rebuilt.
* pex-unix.c (pex_unix_exec_child): Comminicate errors from child
to parent with a pipe, when possible.
From-SVN: r264769
Joseph Myers [Mon, 1 Oct 2018 17:11:46 +0000 (18:11 +0100)]
* ru.po: Update.
From-SVN: r264766
Carl Love [Mon, 1 Oct 2018 15:57:13 +0000 (15:57 +0000)]
Update, forgot to put the PR number in the Change Log.
gcc/ChangeLog:
2018-10-01 Carl Love <cel@us.ibm.com>
PR 69431
* config/rs6000/rs6000-builtin.def (__builtin_mffsl): New.
(__builtin_mtfsb0): New.
(__builtin_mtfsb1): New.
( __builtin_set_fpscr_rn): New.
(__builtin_set_fpscr_drn): New.
* config/rs6000/rs6000.c (rs6000_expand_mtfsb_builtin): Add.
(rs6000_expand_set_fpscr_rn_builtin): Add.
(rs6000_expand_set_fpscr_drn_builtin): Add.
(rs6000_expand_builtin): Add case statement entries for
RS6000_BUILTIN_MTFSB0, RS6000_BUILTIN_MTFSB1,
RS6000_BUILTIN_SET_FPSCR_RN, RS6000_BUILTIN_SET_FPSCR_DRN,
RS6000_BUILTIN_MFFSL.
(rs6000_init_builtins): Add ftype initialization and def_builtin
calls for __builtin_mffsl, __builtin_mtfsb0, __builtin_mtfsb1,
__builtin_set_fpscr_rn, __builtin_set_fpscr_drn.
* config/rs6000.md (rs6000_mtfsb0, rs6000_mtfsb1, rs6000_mffscrn,
rs6000_mffscdrn): Add define_insn.
(rs6000_set_fpscr_rn, rs6000_set_fpscr_drn): Add define_expand.
* doc/extend.texi: Add documentation for the builtins.
gcc/testsuite/ChangeLog:
2018-10-01 Carl Love <cel@us.ibm.com>
PR 69431
* gcc.target/powerpc/test_mffsl-p9.c: New file.
* gcc.target/powerpc/test_fpscr_rn_builtin.c: New file.
* gcc.target/powerpc/test_fpscr_drn_builtin.c: New file.
* gcc.target/powerpc/test_fpscr_rn_builtin_error.c: New file.
* gcc.target/powerpc/test_fpscr_drn_builtin_error.c: New file.
From-SVN: r264764
Carl Love [Mon, 1 Oct 2018 15:41:24 +0000 (15:41 +0000)]
rs6000-builtin.def (__builtin_mffsl): New.
gcc/ChangeLog:
2018-10-01 Carl Love <cel@us.ibm.com>
* config/rs6000/rs6000-builtin.def (__builtin_mffsl): New.
(__builtin_mtfsb0): New.
(__builtin_mtfsb1): New.
( __builtin_set_fpscr_rn): New.
(__builtin_set_fpscr_drn): New.
* config/rs6000/rs6000.c (rs6000_expand_mtfsb_builtin): Add.
(rs6000_expand_set_fpscr_rn_builtin): Add.
(rs6000_expand_set_fpscr_drn_builtin): Add.
(rs6000_expand_builtin): Add case statement entries for
RS6000_BUILTIN_MTFSB0, RS6000_BUILTIN_MTFSB1,
RS6000_BUILTIN_SET_FPSCR_RN, RS6000_BUILTIN_SET_FPSCR_DRN,
RS6000_BUILTIN_MFFSL.
(rs6000_init_builtins): Add ftype initialization and def_builtin
calls for __builtin_mffsl, __builtin_mtfsb0, __builtin_mtfsb1,
__builtin_set_fpscr_rn, __builtin_set_fpscr_drn.
* config/rs6000.md (rs6000_mtfsb0, rs6000_mtfsb1, rs6000_mffscrn,
rs6000_mffscdrn): Add define_insn.
(rs6000_set_fpscr_rn, rs6000_set_fpscr_drn): Add define_expand.
* doc/extend.texi: Add documentation for the builtins.
gcc/testsuite/ChangeLog:
2018-10-01 Carl Love <cel@us.ibm.com>
* gcc.target/powerpc/test_mffsl-p9.c: New file.
* gcc.target/powerpc/test_fpscr_rn_builtin.c: New file.
* gcc.target/powerpc/test_fpscr_drn_builtin.c: New file.
* gcc.target/powerpc/test_fpscr_rn_builtin_error.c: New file.
* gcc.target/powerpc/test_fpscr_drn_builtin_error.c: New file.
From-SVN: r264762
Gerald Pfeifer [Mon, 1 Oct 2018 15:17:15 +0000 (15:17 +0000)]
allocator.xml: Adjust link to "Reconsidering Custom Memory Allocation".
* doc/xml/manual/allocator.xml: Adjust link to "Reconsidering
Custom Memory Allocation".
From-SVN: r264761
Jonathan Wakely [Mon, 1 Oct 2018 14:28:36 +0000 (15:28 +0100)]
Regenerate libstdc++ HTML pages
* doc/html/*: Regenerate.
From-SVN: r264760
Paul Thomas [Mon, 1 Oct 2018 14:27:17 +0000 (14:27 +0000)]
re PR fortran/65677 (Incomplete assignment on deferred-length character variable)
2018-10-01 Paul Thomas <pault@gcc.gnu.org>
PR fortran/65677
* trans-expr.c (gfc_trans_assignment_1): Set the 'identical'
flag in the call to gfc_check_dependency.
2018-10-01 Paul Thomas <pault@gcc.gnu.org>
PR fortran/65677
* gfortran.dg/dependency_52.f90 : Expand the test to check both
the call to adjustl and direct assignment of the substring.
From-SVN: r264759
Richard Biener [Mon, 1 Oct 2018 13:10:48 +0000 (13:10 +0000)]
re PR tree-optimization/87465 (Loop removal regression)
2018-10-01 Richard Biener <rguenther@suse.de>
PR tree-optimization/87465
* tree-ssa-loop-ivcanon.c (tree_estimate_loop_size): Fix typo
causing branch miscounts.
* gcc.dg/tree-ssa/cunroll-15.c: New testcase.
From-SVN: r264758
Tamar Christina [Mon, 1 Oct 2018 13:09:29 +0000 (13:09 +0000)]
Validate and set default parameters for stack-clash.
This patch defines the default parameters and validation for the aarch64
stack clash probing interval and guard sizes. It cleans up the previous
implementation and insures that at no point the invalidate arguments are
present in the pipeline for AArch64. Currently they are only corrected once
cc1 initalizes the back-end.
The default for AArch64 is 64 KB for both of these and we only support 4 KB and 64 KB
probes. We also enforce that any value you set here for the parameters must be
in sync.
If an invalid value is specified an error will be generated and compilation aborted.
gcc/
* common/config/aarch64/aarch64-common.c (TARGET_OPTION_DEFAULT_PARAM,
aarch64_option_default_param): New.
(params.h): Include.
(TARGET_OPTION_VALIDATE_PARAM, aarch64_option_validate_param): New.
* config/aarch64/aarch64.c (aarch64_override_options_internal): Simplify
stack-clash protection validation code.
From-SVN: r264757
Tamar Christina [Mon, 1 Oct 2018 13:08:10 +0000 (13:08 +0000)]
Update options framework for parameters to properly handle and validate configure time params.
This patch changes it so that default parameters are validated during
initialization. This change is needed to ensure parameters set via by the
target specific common initialization routines still keep the parameters within
the valid range.
gcc/
* params.c (validate_param): New.
(add_params): Use it.
(set_param_value): Refactor param validation into validate_param.
(diagnostic.h): Include.
* diagnostic.h (diagnostic_ready_p): New.
From-SVN: r264756
Tamar Christina [Mon, 1 Oct 2018 13:06:53 +0000 (13:06 +0000)]
Allow back-ends to be able to do custom validations on params.
This patch adds the ability for backends to add custom constrains to the param
values by defining a new hook option_validate_param.
This hook is invoked on every set_param_value which allows the back-end to
ensure that the parameters are always within it's desired state.
gcc/
* params.c (set_param_value):
Add index of parameter being validated.
* common/common-target.def (option_validate_param): New.
* common/common-targhooks.h (default_option_validate_param): New.
* common/common-targhooks.c (default_option_validate_param): New.
* doc/tm.texi.in (TARGET_OPTION_VALIDATE_PARAM): New.
* doc/tm.texi: Regenerate.
From-SVN: r264755
Tamar Christina [Mon, 1 Oct 2018 13:05:30 +0000 (13:05 +0000)]
Cleanup the AArch64 testsuite when stack-clash is on.
This patch cleans up the testsuite when a run is done with stack clash
protection turned on.
Concretely this switches off -fstack-clash-protection for a couple of tests:
* assembler scan: some tests are quite fragile in that they check for exact
assembly output, e.g. check for exact amount of sub etc. These won't
match now.
* vla: Some of the ubsan tests negative array indices. Because the arrays weren't
used before the incorrect $sp wouldn't have been used. The correct value is
restored on ret. Now however we probe the $sp which causes a segfault.
* params: When testing the parameters we have to skip these on AArch64 because of our
custom constraints on them. We already test them separately so this isn't a
loss.
Note that the testsuite is not entire clean due to gdb failure caused by alloca with
stack clash. On AArch64 we output an incorrect .loc directive, but this is already the
case with the current implementation in GCC and is a bug unrelated to this patch series.
gcc/testsuite/
PR target/86486
* gcc.dg/pr82788.c: Skip for AArch64.
* gcc.dg/guality/vla-1.c: Turn off stack-clash.
* gcc.target/aarch64/subsp.c: Likewise.
* gcc.dg/params/blocksort-part.c: Skip stack-clash checks
on AArch64.
* gcc.dg/stack-check-10.c: Add AArch64 specific checks.
* gcc.dg/stack-check-12.c: ILP32 fixup.
* gcc.dg/stack-check-5.c: Add AArch64 specific checks.
* gcc.dg/stack-check-6a.c: Skip on AArch64, we don't support this.
* testsuite/lib/target-supports.exp
(check_effective_target_frame_pointer_for_non_leaf): AArch64 does not
require frame pointer for non-leaf functions.
From-SVN: r264754
Tamar Christina [Mon, 1 Oct 2018 13:03:31 +0000 (13:03 +0000)]
Set default values for stack-clash and do basic validation in back-end.
This patch enforces that the default guard size for stack-clash protection for
AArch64 be 64KB unless the user has overriden it via configure in which case
the user value is used as long as that value is within the valid range.
It also does some basic validation to ensure that the guard size is only 4KB or
64KB and also enforces that for aarch64 the stack-clash probing interval is
equal to the guard size.
gcc/
PR target/86486
* config/aarch64/aarch64.c (aarch64_override_options_internal):
Add validation for stack-clash parameters and set defaults.
From-SVN: r264753
Tamar Christina [Mon, 1 Oct 2018 13:02:21 +0000 (13:02 +0000)]
Allow setting of stack-clash via configure options.
This patch defines a configure option to allow the setting of the default
guard size via configure flags when building the target.
The new flag is:
* --with-stack-clash-protection-guard-size=<num>
The patch defines a new macro DEFAULT_STK_CLASH_GUARD_SIZE which targets need
to use explicitly is they want to support this configure flag and values that
users may have set.
gcc/
PR target/86486
* configure.ac: Add stack-clash-protection-guard-size.
* doc/install.texi: Document it.
* config.in (DEFAULT_STK_CLASH_GUARD_SIZE): New.
* params.def: Update comment for guard-size.
(PARAM_STACK_CLASH_PROTECTION_GUARD_SIZE,
PARAM_STACK_CLASH_PROTECTION_PROBE_INTERVAL): Update description.
* configure: Regenerate.
From-SVN: r264752
Tamar Christina [Mon, 1 Oct 2018 13:00:58 +0000 (13:00 +0000)]
Ensure that outgoing argument size is at least 8 bytes when alloca and stack-clash.
This patch adds a requirement that the number of outgoing arguments for a
function is at least 8 bytes when using stack-clash protection and alloca.
By using this condition we can avoid a check in the alloca code and so have
smaller and simpler code there.
A simplified version of the AArch64 stack frames is:
+-----------------------+
| |
| |
| |
+-----------------------+
|LR |
+-----------------------+
|FP |
+-----------------------+
|dynamic allocations | ---- expanding area which will push the outgoing
+-----------------------+ args down during each allocation.
|padding |
+-----------------------+
|outgoing stack args | ---- safety buffer of 8 bytes (aligned)
+-----------------------+
By always defining an outgoing argument, alloca(0) effectively is safe to probe
at $sp due to the reserved buffer being there. It will never corrupt the stack.
This is also safe for alloca(x) where x is 0 or x % page_size == 0. In the
former it is the same case as alloca(0) while the latter is safe because any
allocation pushes the outgoing stack args down:
|FP |
+-----------------------+
| |
|dynamic allocations | ---- alloca (x)
| |
+-----------------------+
|padding |
+-----------------------+
|outgoing stack args | ---- safety buffer of 8 bytes (aligned)
+-----------------------+
Which means when you probe for the residual, if it's 0 you'll again just probe
in the outgoing stack args range, which we know is non-zero (at least 8 bytes).
gcc/
PR target/86486
* config/aarch64/aarch64.h (STACK_CLASH_MIN_BYTES_OUTGOING_ARGS,
STACK_DYNAMIC_OFFSET): New.
* config/aarch64/aarch64.c (aarch64_layout_frame):
Update outgoing args size.
(aarch64_stack_clash_protection_alloca_probe_range,
TARGET_STACK_CLASH_PROTECTION_ALLOCA_PROBE_RANGE): New.
gcc/testsuite/
PR target/86486
* gcc.target/aarch64/stack-check-alloca-1.c: New.
* gcc.target/aarch64/stack-check-alloca-10.c: New.
* gcc.target/aarch64/stack-check-alloca-2.c: New.
* gcc.target/aarch64/stack-check-alloca-3.c: New.
* gcc.target/aarch64/stack-check-alloca-4.c: New.
* gcc.target/aarch64/stack-check-alloca-5.c: New.
* gcc.target/aarch64/stack-check-alloca-6.c: New.
* gcc.target/aarch64/stack-check-alloca-7.c: New.
* gcc.target/aarch64/stack-check-alloca-8.c: New.
* gcc.target/aarch64/stack-check-alloca-9.c: New.
* gcc.target/aarch64/stack-check-alloca.h: New.
* gcc.target/aarch64/stack-check-14.c: New.
* gcc.target/aarch64/stack-check-15.c: New.
From-SVN: r264751
Tamar Christina [Mon, 1 Oct 2018 12:58:21 +0000 (12:58 +0000)]
Add a hook to support telling the mid-end when to probe the stack.
This patch adds a hook to tell the mid-end about the probing requirements of the
target. On AArch64 we allow a specific range for which no probing needs to
be done. This same range is also the amount that will have to be probed up when
a probe is needed after dropping the stack.
Defining this probe comes with the extra requirement that the outgoing arguments
size of any function that uses alloca and stack clash be at the very least 8
bytes. With this invariant we can skip doing the zero checks for alloca and
save some code.
A simplified version of the AArch64 stack frame is:
+-----------------------+
| |
| |
| |
+-----------------------+
|LR |
+-----------------------+
|FP |
+-----------------------+
|dynamic allocations | -\ probe range hook effects these
+-----------------------+ --\ and ensures that outgoing stack
|padding | -- args is always > 8 when alloca.
+-----------------------+ ---/ Which means it's always safe to probe
|outgoing stack args |-/ at SP
+-----------------------+
This allows us to generate better code than without the hook without affecting
other targets.
With this patch I am also removing the stack_clash_protection_final_dynamic_probe
hook which was added specifically for AArch64 but that is no longer needed.
gcc/
PR target/86486
* explow.c (anti_adjust_stack_and_probe_stack_clash): Support custom
probe ranges.
* target.def (stack_clash_protection_alloca_probe_range): New.
(stack_clash_protection_final_dynamic_probe): Remove.
* targhooks.h (default_stack_clash_protection_alloca_probe_range) New.
(default_stack_clash_protection_final_dynamic_probe): Remove.
* targhooks.c: Likewise.
* doc/tm.texi.in (TARGET_STACK_CLASH_PROTECTION_ALLOCA_PROBE_RANGE): New.
(TARGET_STACK_CLASH_PROTECTION_FINAL_DYNAMIC_PROBE): Remove.
* doc/tm.texi: Regenerate.
From-SVN: r264750
Tamar Christina [Mon, 1 Oct 2018 12:56:40 +0000 (12:56 +0000)]
Add support for SVE stack clash probing.
This patch adds basic support for SVE stack clash protection.
It is a first implementation and will use a loop to do the
probing and stack adjustments.
An example sequence is:
.cfi_startproc
mov x15, sp
cntb x16, all, mul #11
add x16, x16, 304
.cfi_def_cfa_register 15
.SVLPSPL0:
cmp x16, 61440
b.lt .SVLPEND0
sub sp, sp, 61440
str xzr, [sp, 0]
sub x16, x16, 61440
b .SVLPSPL0
.SVLPEND0:
sub sp, sp, x16
.cfi_escape 0xf,0xc,0x8f,0,0x92,0x2e,0,0x8,0x58,0x1e,0x23,0xb0,0x2,0x22
for a 64KB guard size, and for a 4KB guard size
.cfi_startproc
mov x15, sp
cntb x16, all, mul #11
add x16, x16, 304
.cfi_def_cfa_register 15
.SVLPSPL0:
cmp x16, 3072
b.lt .SVLPEND0
sub sp, sp, 3072
str xzr, [sp, 0]
sub x16, x16, 3072
b .SVLPSPL0
.SVLPEND0:
sub sp, sp, x16
.cfi_escape 0xf,0xc,0x8f,0,0x92,0x2e,0,0x8,0x58,0x1e,0x23,0xb0,0x2,0x22
This has about the same semantics as alloca, except we prioritize the common case
where no probe is required. We also change the amount we adjust the stack and
the probing interval to be the nearest value to `guard size - abi buffer` that
fits in the 12-bit shifted immediate used by cmp.
While this would mean we probe a bit more often than we require, in practice the
amount of SVE vectors you'd need to spill is significant. Even more so to enter the
loop more than once.
gcc/
PR target/86486
* config/aarch64/aarch64-protos.h (aarch64_output_probe_sve_stack_clash): New.
* config/aarch64/aarch64.c (aarch64_output_probe_sve_stack_clash,
aarch64_clamp_to_uimm12_shift): New.
(aarch64_allocate_and_probe_stack_space): Add SVE specific section.
* config/aarch64/aarch64.md (probe_sve_stack_clash): New.
gcc/testsuite/
PR target/86486
* gcc.target/aarch64/stack-check-prologue-16.c: New test
* gcc.target/aarch64/stack-check-cfa-3.c: New test.
* gcc.target/aarch64/sve/struct_vect_24.c: New test.
* gcc.target/aarch64/sve/struct_vect_24_run.c: New test.
From-SVN: r264749
Tamar Christina [Mon, 1 Oct 2018 12:53:34 +0000 (12:53 +0000)]
stack-clash: Add LR assert to layout_frame.
Since stack clash depends on the LR being saved for non-leaf functions this
patch adds an assert such that if this changes we would notice this.
gcc/
PR target/86486
* config/aarch64/aarch64.c (aarch64_layout_frame): Add assert.
From-SVN: r264748
Jeff Law [Mon, 1 Oct 2018 12:49:35 +0000 (06:49 -0600)]
Updated stack-clash implementation supporting 64k probes.
This patch implements the use of the stack clash mitigation for aarch64.
In Aarch64 we expect both the probing interval and the guard size to be 64KB
and we enforce them to always be equal.
We also probe up by 1024 bytes in the general case when a probe is required.
AArch64 has the following probing conditions:
1a) Any initial adjustment less than 63KB requires no probing. An ABI defined
safe buffer of 1Kbytes is used and a page size of 64k is assumed.
b) Any final adjustment residual requires a probe at SP + 1KB.
We know this to be safe since you would have done at least one page worth
of allocations already to get to that point.
c) Any final adjustment more than remainder (total allocation amount) larger
than 1K - LR offset requires a probe at SP.
safe buffer mentioned in 1a is maintained by the storing of FP/LR.
In the case of -fomit-frame-pointer we can still count on LR being stored
if the function makes a call, even if it's a tail call. The AArch64 frame
layout code guarantees this and tests have been added to check against
this particular case.
2) Any allocations larger than 1 page size, is done in increments of page size
and probed up by 1KB leaving the residuals.
3a) Any residual for initial adjustment that is less than guard-size - 1KB
requires no probing. Essentially this is a sliding window. The probing
range determines the ABI safe buffer, and the amount to be probed up.
Incrementally allocating less than the probing thresholds, e.g. recursive functions will
not be an issue as the storing of LR counts as a probe.
+-------------------+
| ABI SAFE REGION |
+------------------------------
| | |
| | |
| | |
| | |
| | |
| | |
maximum amount | | |
not needing a | | |
probe | | |
| | |
| | |
| | |
| | | Probe offset when
| ---------------------------- probe is required
| | |
+-------- +-------------------+ -------- Point of first probe
| ABI SAFE REGION |
---------------------
| |
| |
| |
Bootstrapped Regtested on aarch64-none-linux-gnu and no issues.
Target was tested with stack clash on and off by default.
GLIBC testsuite also ran with stack clash on by default and no new
regressions.
Co-Authored-By: Richard Sandiford <richard.sandiford@linaro.org>
Co-Authored-By: Tamar Christina <tamar.christina@arm.com>
From-SVN: r264747
Tamar Christina [Mon, 1 Oct 2018 12:34:05 +0000 (12:34 +0000)]
Fix caching of tests for multiple variant runs and update existing target-supports tests.
Currently some target supports checks such as vect_int cache their
results in a manner that would cause them not to be rechecked when
running the same tests against a different variant in a multi variant
run. This causes tests to be skipped or run when they shouldn't be.
there is already an existing caching mechanism in place that does the
caching correctly, but presumably these weren't used because some of these
tests originally only contained static data. e.g. only checked if the target is
aarch64*-*-* etc.
This patch changes every function that needs to do any caching at all to use
check_cached_effective_target which will cache per variant instead of globally.
For those tests that already parameterize over et_index I have created
check_cached_effective_target_indexed to handle this common case by creating a list
containing the property name and the current value of et_index.
These changes result in a much simpler implementation for most tests and a large
reduction in lines for target-supports.exp.
Regtested on
aarch64-none-elf
x86_64-pc-linux-gnu
powerpc64-unknown-linux-gnu
arm-none-eabi
and no testsuite errors. Difference would depend on your site.exp.
On arm we get about 4500 new testcases and on aarch64 the low 10s.
On PowerPC and x86_64 no changes as expected since the default exp for these
just test the default configuration.
What this means for new target checks is that they should always use either
check_cached_effective_target or check_cached_effective_target_indexed if the
result of the check is to be cached.
As an example the new vect_int looks like
proc check_effective_target_vect_int { } {
return [check_cached_effective_target_indexed <name> {
expr {
<condition>
}}]
}
The debug information that was once there is now all hidden in
check_cached_effective_target, (called from check_cached_effective_target_indexed)
and so the only thing you are required to do is give it a unique cache name and a condition.
The condition doesn't need to be an if statement so simple boolean expressions are enough here:
[istarget i?86-*-*] || [istarget x86_64-*-*]
|| ([istarget powerpc*-*-*]
&& ![istarget powerpc-*-linux*paired*])
|| ...
From-SVN: r264745
MCC CS [Mon, 1 Oct 2018 11:25:45 +0000 (11:25 +0000)]
re PR tree-optimization/87261 (Optimize bool expressions)
2018-10-01 MCC CS <deswurstes@users.noreply.github.com>
PR tree-optimization/87261
* match.pd: Remove trailing whitespace.
Add (x & y) | ~(x | y) -> ~(x ^ y),
(~x | y) ^ (x ^ y) -> x | ~y and (x ^ y) | ~(x | y) -> ~(x & y)
* gcc.dg/pr87261.c: New test.
From-SVN: r264744
Eric Botcazou [Mon, 1 Oct 2018 09:39:28 +0000 (09:39 +0000)]
c-ada-spec.c (get_underlying_decl): Get to the main type variant.
* c-ada-spec.c (get_underlying_decl): Get to the main type variant.
(dump_ada_node): Add const keyword.
From-SVN: r264738
Claudiu Zissulescu [Mon, 1 Oct 2018 09:37:46 +0000 (11:37 +0200)]
[ARC] Avoid specific constants to end in limm field.
Avoid constants to end up in the limm field for particular
instructions when compiling for size.
gcc/
xxxx-xx-xx Claudiu Zissulescu <claziss@synopsys.com>
* config/arc/arc.md (*add_n): Clean up pattern, update instruction
constraints.
(ashlsi3_insn): Update instruction constraints.
(ashrsi3_insn): Likewise.
(rotrsi3): Likewise.
(add_shift): Likewise.
* config/arc/constraints.md (Csz): New 32 bit constraint. It
avoids placing in the limm field small constants which, otherwise,
could end into a small instruction.
testsuite/
xxxx-xx-xx Claudiu Zissulescu <claziss@synopsys.com>
* gcc.target/arc/tph_addx.c: New test.
From-SVN: r264737
Claudiu Zissulescu [Mon, 1 Oct 2018 09:37:33 +0000 (11:37 +0200)]
[ARC] Check for odd-even register when emitting double mac ops.
gcc/
Claudiu Zissulescu <claziss@synopsys.com>
* config/arc/arc.md (maddsidi4_split): Don't use dmac if the
destination register is not odd-even.
(umaddsidi4_split): Likewise.
gcc/testsuite/
Claudiu Zissulescu <claziss@synopsys.com>
* gcc.target/arc/tmac-3.c: New file.
From-SVN: r264736
Richard Biener [Mon, 1 Oct 2018 07:48:51 +0000 (07:48 +0000)]
tree-inline.c (expand_call_inline): Store origin of fn in BLOCK_ABSTRACT_ORIGIN for the inline BLOCK.
2018-10-01 Richard Biener <rguenther@suse.de>
* tree-inline.c (expand_call_inline): Store origin of fn
in BLOCK_ABSTRACT_ORIGIN for the inline BLOCK.
* tree.c (block_ultimate_origin): Simplify and do some
checking.
From-SVN: r264734
Alexandre Oliva [Mon, 1 Oct 2018 00:27:45 +0000 (00:27 +0000)]
[Ada] use -gnatd_A to disable .ali on -fcompare-debug recompile
for gcc/ada/ChangeLog
* gcc-interface/lang-specs.h (default_compilers): When given
fcompare-debug-second, adjust auxbase like cc1, and pass
gnatd_A.
* gcc-interface/misc.c (flag_compare_debug): Remove variable.
(gnat_post_options): Do not set it.
* lib-writ.adb (flag_compare_debug): Remove import.
(Write_ALI): Do not test it.
From-SVN: r264732
GCC Administrator [Mon, 1 Oct 2018 00:16:42 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264731
Uros Bizjak [Sun, 30 Sep 2018 22:13:36 +0000 (00:13 +0200)]
mmx.md (EMMS): New int iterator.
* config/i386/mmx.md (EMMS): New int iterator.
(emms): New int attribute.
(mmx_<emms>): Macroize insn from *mmx_emms and *mmx_femms using
EMMS int iterator. Explicitly declare clobbers.
(mmx_emms): Remove expander.
(mmx_femms): Ditto.
* config/i386/predicates.md (emms_operation): Remove predicate.
(vzeroall_pattern): New predicate.
(vzeroupper_pattern): Rename from vzeroupper_operation.
* config/i386/i386.c (ix86_avx_u128_mode_after): Use
vzeroupper_pattern and vzeroall_pattern predicates.
From-SVN: r264727
Peter Bergner [Sun, 30 Sep 2018 20:03:14 +0000 (20:03 +0000)]
re PR rtl-optimization/86939 (IRA incorrectly creates an interference between a pseudo register and a hard register)
gcc/
PR rtl-optimization/86939
* ira-lives.c (make_hard_regno_born): Rename from this...
(make_hard_regno_live): ... to this. Remove update to conflict
information. Update function comment.
(make_hard_regno_dead): Add conflict information update. Update
function comment.
(make_object_born): Rename from this...
(make_object_live): ... to this. Remove update to conflict information.
Update function comment.
(make_object_dead): Add conflict information update. Update function
comment.
(mark_pseudo_regno_live): Call make_object_live.
(mark_pseudo_regno_subword_live): Likewise.
(mark_hard_reg_dead): Update function comment.
(mark_hard_reg_live): Call make_hard_regno_live.
(process_bb_node_lives): Likewise.
* lra-lives.c (make_hard_regno_born): Rename from this...
(make_hard_regno_live): ... to this. Remove update to conflict
information. Remove now uneeded check_pic_pseudo_p argument.
Update function comment.
(make_hard_regno_dead): Add check_pic_pseudo_p argument and add update
to conflict information. Update function comment.
(mark_pseudo_live): Remove update to conflict information. Update
function comment.
(mark_pseudo_dead): Add conflict information update.
(mark_regno_live): Call make_hard_regno_live.
(mark_regno_dead): Call make_hard_regno_dead with new arguement.
(process_bb_lives): Call make_hard_regno_live and make_hard_regno_dead.
From-SVN: r264726
Paul Thomas [Sun, 30 Sep 2018 13:52:55 +0000 (13:52 +0000)]
re PR fortran/87359 (pointer being freed was not allocated)
2018-09-30 Paul Thomas <pault@gcc.gnu.org>
PR fortran/87359
* trans-array.c (gfc_is_reallocatable_lhs): Correct the problem
introduced by r264358, which prevented components of associate
names from being reallocated on assignment.
2018-09-30 Paul Thomas <pault@gcc.gnu.org>
PR fortran/87359
* gfortran.dg/associate_40.f90 : New test.
From-SVN: r264725
Paul Thomas [Sun, 30 Sep 2018 12:22:07 +0000 (12:22 +0000)]
re PR fortran/70752 (Incorrect LEN for ALLOCATABLE CHARACTER)
2018-09-30 Paul Thomas <pault@gcc.gnu.org>
PR fortran/70752
PR fortran/72709
* trans-array.c (gfc_conv_scalarized_array_ref): If this is a
deferred type and the info->descriptor is present, use the
info->descriptor
(gfc_conv_array_ref): Is the se expr is a descriptor type, pass
it as 'decl' rather than the symbol backend_decl.
(gfc_array_allocate): If the se string_length is a component
reference, fix it and use it for the expression string length
if the latter is not a variable type. If it is a variable do
an assignment. Make use of component ref string lengths to set
the descriptor 'span'.
(gfc_conv_expr_descriptor): For pointer assignment, do not set
the span field if gfc_get_array_span returns zero.
* trans.c (get_array_span): If the upper bound a character type
is zero, use the descriptor span if available.
2018-09-30 Paul Thomas <pault@gcc.gnu.org>
PR fortran/70752
PR fortran/72709
* gfortran.dg/deferred_character_25.f90 : New test.
* gfortran.dg/deferred_character_26.f90 : New test.
* gfortran.dg/deferred_character_27.f90 : New test to verify
that PR82617 remains fixed.
From-SVN: r264724
Gerald Pfeifer [Sun, 30 Sep 2018 11:41:31 +0000 (11:41 +0000)]
messages.xml: Switch link to oracle.com to https.
* doc/xml/manual/messages.xml: Switch link to www.oracle.com
to https.
From-SVN: r264723
Gerald Pfeifer [Sun, 30 Sep 2018 10:53:14 +0000 (10:53 +0000)]
policy_data_structures_biblio.xml: Update link to Microsoft Component Model Object Technologies.
* doc/xml/manual/policy_data_structures_biblio.xml: Update
link to Microsoft Component Model Object Technologies.
From-SVN: r264722
Paul Thomas [Sun, 30 Sep 2018 07:02:49 +0000 (07:02 +0000)]
re PR fortran/70149 ([F08] Character pointer initialization causes ICE)
2018-09-30 Paul Thomas <pault@gcc.gnu.org>
PR fortran/70149
* trans-decl.c (gfc_get_symbol_decl): A deferred character
length pointer that is initialized needs the string length to
be initialized as well.
2018-09-30 Paul Thomas <pault@gcc.gnu.org>
PR fortran/70149
* gfortran.dg/deferred_character_24.f90 : New test.
From-SVN: r264721
GCC Administrator [Sun, 30 Sep 2018 00:16:20 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264720
H.J. Lu [Sat, 29 Sep 2018 21:59:59 +0000 (21:59 +0000)]
i386: Use TImode for BLKmode values in 2 integer registers
When passing and returning BLKmode values in 2 integer registers, use
1 TImode register instead of 2 DImode registers. Otherwise, V1TImode
may be used to move and store such BLKmode values, which prevent RTL
optimizations.
gcc/
PR target/87370
* config/i386/i386.c (construct_container): Use TImode for
BLKmode values in 2 integer registers.
gcc/testsuite/
PR target/87370
* gcc.target/i386/pr87370.c: New test.
From-SVN: r264716
Paul Thomas [Sat, 29 Sep 2018 17:17:09 +0000 (17:17 +0000)]
re PR fortran/65677 (Incomplete assignment on deferred-length character variable)
2018-09-29 Paul Thomas <pault@gcc.gnu.org>
PR fortran/65667
* trans-expr.c (gfc_trans_assignment_1): If there is dependency
fix the rse stringlength.
2018-09-29 Paul Thomas <pault@gcc.gnu.org>
PR fortran/65667
* gfortran.dg/dependency_52.f90 : New test.
From-SVN: r264715
Jeff Law [Sat, 29 Sep 2018 16:06:09 +0000 (10:06 -0600)]
builtins.c (unterminated_array): Pass in c_strlen_data * to c_strlen rather than just a tree *.
* builtins.c (unterminated_array): Pass in c_strlen_data * to
c_strlen rather than just a tree *.
(c_strlen): Change NONSTR argument to a c_strlen_data pointer.
Update recursive calls appropriately. If caller did not provide a
suitable data pointer, create a local one. When a non-terminated
string is discovered, bubble up information about the string via the
c_strlen_data object.
* builtins.h (c_strlen): Update prototype.
(c_strlen_data): New structure.
* gimple-fold.c (get_range_strlen): Update calls to c_strlen.
For a type 2 call, if c_strlen indicates a non-terminated string
use the length of the non-terminated string.
(gimple_fold_builtin_stpcpy): Update calls to c_strlen.
From-SVN: r264712
Jakub Jelinek [Sat, 29 Sep 2018 16:04:09 +0000 (18:04 +0200)]
re PR target/87467 (Incorrect function parameter for _mm512_abs_pd in `include/avx512fintrin.h`)
PR target/87467
* config/i386/avx512fintrin.h (_mm512_abs_pd, _mm512_mask_abs_pd): Use
__m512d type for __A argument rather than __m512.
* gcc.target/i386/avx512f-abspd-1.c (SIZE): Divide by two.
(CALC): Use double instead of float.
(TEST): Adjust to test _mm512_abs_pd and _mm512_mask_abs_pd rather than
_mm512_abs_ps and _mm512_mask_abs_ps.
From-SVN: r264711
Gerald Pfeifer [Sat, 29 Sep 2018 11:25:57 +0000 (11:25 +0000)]
fdl-1.3.xml: The Free Software Foundation web site now uses https.
* doc/xml/gnu/fdl-1.3.xml: The Free Software Foundation web
site now uses https. Also omit the unnecessary trailing slash.
* doc/xml/gnu/gpl-3.0.xml: Ditto.
From-SVN: r264710
GCC Administrator [Sat, 29 Sep 2018 00:16:19 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264709
John David Anglin [Fri, 28 Sep 2018 23:13:10 +0000 (23:13 +0000)]
match.pd (simple_comparison): Don't optimize if either operand is a function pointer when...
* match.pd (simple_comparison): Don't optimize if either operand is
a function pointer when target needs function pointer canonicalization.
From-SVN: r264705
projects / gcc.git / log