Luke Kenneth Casson Leighton [Thu, 18 Aug 2022 20:48:58 +0000 (21:48 +0100)]
selectable_int: fix check on SI constructor
Specifying the number of bits *is* allowed, it should mean "override
the length". More unit tests need running to confirm.
Dmitry Selyutin [Thu, 18 Aug 2022 11:44:38 +0000 (14:44 +0300)]
selectable_int: refactor fields mappings
Dmitry Selyutin [Thu, 18 Aug 2022 09:00:06 +0000 (12:00 +0300)]
power_insn: decouple instruction classes
Dmitry Selyutin [Thu, 18 Aug 2022 08:58:38 +0000 (11:58 +0300)]
selectable_int: canonicalize indentation
Dmitry Selyutin [Wed, 17 Aug 2022 20:55:31 +0000 (23:55 +0300)]
pysvp64dis: provide BC mode sketch
Dmitry Selyutin [Wed, 17 Aug 2022 20:43:04 +0000 (23:43 +0300)]
selectable_int: allow further fields slicing
Dmitry Selyutin [Wed, 17 Aug 2022 20:32:48 +0000 (23:32 +0300)]
selectable_int: support fields boolean check
Dmitry Selyutin [Wed, 17 Aug 2022 20:18:12 +0000 (23:18 +0300)]
selectable_int: allow multi-level fields
Dmitry Selyutin [Wed, 17 Aug 2022 19:35:35 +0000 (22:35 +0300)]
pysvp64asm: clean import directives
Dmitry Selyutin [Wed, 17 Aug 2022 17:03:20 +0000 (20:03 +0300)]
pysvp64dis: refactor inheritance model
Dmitry Selyutin [Wed, 17 Aug 2022 14:18:55 +0000 (17:18 +0300)]
pysvp64dis: introduce disassemble routine
Dmitry Selyutin [Wed, 17 Aug 2022 12:13:06 +0000 (15:13 +0300)]
pysvp64dis: consider instruction name
Dmitry Selyutin [Wed, 17 Aug 2022 11:55:26 +0000 (14:55 +0300)]
pysvp64dis: consult the instruction database
Dmitry Selyutin [Wed, 17 Aug 2022 11:52:52 +0000 (14:52 +0300)]
pysvp64dis: accept SelectableInt as an Instruction
Dmitry Selyutin [Wed, 17 Aug 2022 11:51:30 +0000 (14:51 +0300)]
selectable_int: support int casts
Dmitry Selyutin [Wed, 17 Aug 2022 11:50:52 +0000 (14:50 +0300)]
power_insn: rename Instruction to Record
Dmitry Selyutin [Wed, 17 Aug 2022 11:48:50 +0000 (14:48 +0300)]
power_insn: fix opcode-based lookups
Dmitry Selyutin [Wed, 17 Aug 2022 10:40:32 +0000 (13:40 +0300)]
pysvp64dis: introduce Suffix helper class
Dmitry Selyutin [Wed, 17 Aug 2022 10:29:07 +0000 (13:29 +0300)]
pysvp64dis: introduce global cached insn database
Dmitry Selyutin [Wed, 17 Aug 2022 09:53:33 +0000 (12:53 +0300)]
pysvp64dis: refactor prefix handling
Dmitry Selyutin [Wed, 17 Aug 2022 08:42:03 +0000 (11:42 +0300)]
selectable_int: fix multi-dimensional mappings
Luke Kenneth Casson Leighton [Tue, 16 Aug 2022 23:56:20 +0000 (00:56 +0100)]
add some debug logs to SelectableInt to help track down what is going on
Luke Kenneth Casson Leighton [Tue, 16 Aug 2022 23:39:11 +0000 (00:39 +0100)]
whitespace - keep to under 80 chars
Dmitry Selyutin [Tue, 16 Aug 2022 21:40:39 +0000 (00:40 +0300)]
pysvp64dis: introduce Prefix and RM classes
Dmitry Selyutin [Tue, 16 Aug 2022 21:33:28 +0000 (00:33 +0300)]
selectable_int: refactor mappings
Dmitry Selyutin [Tue, 16 Aug 2022 18:43:26 +0000 (21:43 +0300)]
pysvp64dis: dump to output file; use explicit arguments
Dmitry Selyutin [Tue, 16 Aug 2022 18:21:32 +0000 (21:21 +0300)]
selectable_int: allow fields-based instantiation
Dmitry Selyutin [Tue, 16 Aug 2022 18:10:49 +0000 (21:10 +0300)]
selectable_int: inherit mapping bits
Dmitry Selyutin [Tue, 16 Aug 2022 17:58:26 +0000 (20:58 +0300)]
selectable_int: strengthen type checks
Dmitry Selyutin [Tue, 16 Aug 2022 14:55:56 +0000 (17:55 +0300)]
pysvp64dis: refactor classes; use fields helpers
Dmitry Selyutin [Tue, 16 Aug 2022 18:29:57 +0000 (21:29 +0300)]
pysvp64dis: fix prefix/suffix properties
Dmitry Selyutin [Tue, 16 Aug 2022 14:54:55 +0000 (17:54 +0300)]
selectable_int: support fields comparisons
Dmitry Selyutin [Mon, 29 Aug 2022 16:14:04 +0000 (19:14 +0300)]
pysvp64asm: uncomment the remapped instructions
Luke Kenneth Casson Leighton [Mon, 29 Aug 2022 11:36:33 +0000 (12:36 +0100)]
add setvl and other sv* management instructions to the list
for which OE is ignored.
https://bugs.libre-soc.org/show_bug.cgi?id=914
really the solution here is to add a new CSV column, OE
Luke Kenneth Casson Leighton [Mon, 29 Aug 2022 11:13:34 +0000 (12:13 +0100)]
add logging into ISACaller.handle_overflow to see what gets set
Luke Kenneth Casson Leighton [Mon, 29 Aug 2022 11:09:33 +0000 (12:09 +0100)]
switch off XER.so reading on "setvl.", it makes no sense
https://bugs.libre-soc.org/show_bug.cgi?id=914
Luke Kenneth Casson Leighton [Mon, 29 Aug 2022 09:45:44 +0000 (10:45 +0100)]
Revert "support assembling svp64 instructions with custom suffixes, like sv.maxu"
This reverts commit
0e80cab3b809d432354ca05464e95dc53db11b64.
"sv.ffmadds." is inserted as a 32-bit operation instead of as a ".long"
"sv.ffmadds" on the other hand is correctly converted to ".long"
Luke Kenneth Casson Leighton [Mon, 29 Aug 2022 09:45:41 +0000 (10:45 +0100)]
add two instructions demoing broken commit
0e80cab3b809d43
Jacob Lifshay [Mon, 29 Aug 2022 08:04:31 +0000 (01:04 -0700)]
fix issue with cpython 3.7
Jacob Lifshay [Mon, 29 Aug 2022 07:32:55 +0000 (00:32 -0700)]
svp64_utf_8_validation.py works!
Jacob Lifshay [Mon, 29 Aug 2022 07:28:33 +0000 (00:28 -0700)]
support assembling svp64 instructions with custom suffixes, like sv.maxu
Jacob Lifshay [Mon, 29 Aug 2022 07:27:12 +0000 (00:27 -0700)]
allow tests to pass None in order to not have to match so, ca, and ov
Jacob Lifshay [Mon, 29 Aug 2022 07:25:36 +0000 (00:25 -0700)]
log memory in a more fancy format, like hexdump -C
Jacob Lifshay [Sun, 28 Aug 2022 17:49:47 +0000 (10:49 -0700)]
stop printing log silence state
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 18:39:05 +0000 (19:39 +0100)]
initialise overflow to zero in setvl, unconditionally.
add two new CTR-mode/Rc=1 setvl. tests, to confirm that overflow
does/does-not occur correctly when CTR is used as input to set VL
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 15:02:18 +0000 (16:02 +0100)]
sigh, update setvl tests, to spec, and ISACaller
https://libre-soc.org/openpower/sv/setvl/
see Rc=1 section: it is possible to have Rc=1, RT=0, RA!=0 which
means "set VL but do not set RT" which *still* requires that Rc=1
be updated - not from RT but from VL
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 14:40:01 +0000 (15:40 +0100)]
add setvl unit tests for overflow condition.
TODO, update spec to match: when VL attempted to be set > MAXVL
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 14:18:32 +0000 (15:18 +0100)]
put back overflow in setvl, TODO actually set an overflow variable
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 14:17:26 +0000 (15:17 +0100)]
okaaaay, long story. using GPR(_RT) <- something will *not* get
detected by parser.py as an output register. therefore, the modified
registers were (SVSTATE, CTR) *not* (RT, SVSTATE, CTR).
this resulted in *SVSTATE* being tested for Rc=1, not RT.
added unit tests to catch "setvl."
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 13:51:16 +0000 (14:51 +0100)]
Revert "fix setvl. not setting CR0 properly"
This reverts commit
f48aefa37b06a398e953ce3bd877d7b2bbfb6213.
the approach of explicitly setting CR0 in pseudocode is not ok.
ISACaller.handle_comparison is the correct place to do it - and
i am not certain that there are special-cases needed (unlike svstep)
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 01:41:21 +0000 (02:41 +0100)]
code-shuffle on if/elif/nots in sv/trans/svp64.py
Jacob Lifshay [Fri, 26 Aug 2022 08:49:05 +0000 (01:49 -0700)]
working on svp64_utf_8_validation.py -- still broken, though an empty string works now!
Jacob Lifshay [Fri, 26 Aug 2022 08:47:57 +0000 (01:47 -0700)]
add more logging
Jacob Lifshay [Fri, 26 Aug 2022 08:46:41 +0000 (01:46 -0700)]
add original instruction as a comment, improving debuggability
Jacob Lifshay [Fri, 26 Aug 2022 08:46:06 +0000 (01:46 -0700)]
add support for comments in instructions
Jacob Lifshay [Fri, 26 Aug 2022 08:44:39 +0000 (01:44 -0700)]
add some logging
Jacob Lifshay [Fri, 26 Aug 2022 08:42:40 +0000 (01:42 -0700)]
fix setvl. not setting CR0 properly
Jacob Lifshay [Fri, 26 Aug 2022 05:37:21 +0000 (22:37 -0700)]
convert more `print`s to `log`s
Jacob Lifshay [Fri, 26 Aug 2022 05:36:09 +0000 (22:36 -0700)]
include original svp64 instruction in comment on prefix
makes it much nicer when reading instruction traces
Jacob Lifshay [Fri, 26 Aug 2022 05:35:26 +0000 (22:35 -0700)]
log rather than print SKIPPED
Jacob Lifshay [Fri, 26 Aug 2022 05:31:40 +0000 (22:31 -0700)]
make logging more configurable
Jacob Lifshay [Fri, 26 Aug 2022 04:07:26 +0000 (21:07 -0700)]
fix typo
Luke Kenneth Casson Leighton [Fri, 26 Aug 2022 01:35:58 +0000 (02:35 +0100)]
update comments
Jacob Lifshay [Thu, 25 Aug 2022 10:00:54 +0000 (03:00 -0700)]
add qemu-system-ppc to .gitlab-ci.yml
Jacob Lifshay [Thu, 25 Aug 2022 09:34:58 +0000 (02:34 -0700)]
mark all known-broken tests so CI passes
Jacob Lifshay [Thu, 25 Aug 2022 09:33:52 +0000 (02:33 -0700)]
skip gdb tests when gdb isn't found
Jacob Lifshay [Thu, 25 Aug 2022 09:32:10 +0000 (02:32 -0700)]
allow crtl tests to run in parallel
Luke Kenneth Casson Leighton [Thu, 25 Aug 2022 09:23:40 +0000 (10:23 +0100)]
nmigen.info is being cyber-squatted, has to be removed for now
Jacob Lifshay [Thu, 25 Aug 2022 06:53:44 +0000 (23:53 -0700)]
add XFAIL because the file improperly accesses pdecode2.e.imm_data
Jacob Lifshay [Thu, 25 Aug 2022 06:52:33 +0000 (23:52 -0700)]
add more generated output to .gitignore
Jacob Lifshay [Thu, 25 Aug 2022 06:45:38 +0000 (23:45 -0700)]
add missing assemblers to .gitlab-ci.yml
Jacob Lifshay [Thu, 25 Aug 2022 06:44:36 +0000 (23:44 -0700)]
add missing on_SmtExpr methods
Jacob Lifshay [Thu, 25 Aug 2022 06:09:55 +0000 (23:09 -0700)]
fix assembling `sv.add.`
Jacob Lifshay [Thu, 25 Aug 2022 06:02:16 +0000 (23:02 -0700)]
format .../trans/svp64.py
Jacob Lifshay [Thu, 25 Aug 2022 05:36:38 +0000 (22:36 -0700)]
make pytest ignore non-test classes, these're the last pytest collection warnings
Jacob Lifshay [Thu, 25 Aug 2022 05:33:51 +0000 (22:33 -0700)]
convert all test_caller*.py to work with pytest/unittest test discovery
all the removed code had no benefit because each file only tested
one *TestCase* class, the removed code was only useful for
selecting between multiple *TestCase* classes
Jacob Lifshay [Thu, 25 Aug 2022 05:07:00 +0000 (22:07 -0700)]
fix deprecated imports
Jacob Lifshay [Thu, 25 Aug 2022 04:19:36 +0000 (21:19 -0700)]
remove last uses of soc
Jacob Lifshay [Thu, 25 Aug 2022 04:18:45 +0000 (21:18 -0700)]
format test/runner.py
Jacob Lifshay [Thu, 25 Aug 2022 04:14:21 +0000 (21:14 -0700)]
change test cases to use TestRunnerBase in order to not need soc
Luke Kenneth Casson Leighton [Wed, 24 Aug 2022 12:30:00 +0000 (13:30 +0100)]
remove non-orthogonal ldst_shift
Luke Kenneth Casson Leighton [Wed, 24 Aug 2022 12:29:01 +0000 (13:29 +0100)]
fix annoying typo, comment-out asm_process()
Luke Kenneth Casson Leighton [Wed, 24 Aug 2022 12:20:50 +0000 (13:20 +0100)]
duplicate RM CSV entries gone after re-run of sv_analysis.py
due to corrections in CSV files, using patterns instead of repeated binary
Luke Kenneth Casson Leighton [Wed, 24 Aug 2022 12:16:46 +0000 (13:16 +0100)]
hmm tdi/twi are kinda valid as svp64 prefixable
Luke Kenneth Casson Leighton [Wed, 24 Aug 2022 12:14:00 +0000 (13:14 +0100)]
ha ha very funny, sv.andi does not exist, only "sv.andi."
fix assumption in sv/trans/svp64.py on that one
(also correct mistaken change)
Jacob Lifshay [Wed, 24 Aug 2022 11:36:25 +0000 (04:36 -0700)]
working on svp64 utf-8 validation -- still broken
Jacob Lifshay [Wed, 24 Aug 2022 11:35:10 +0000 (04:35 -0700)]
fix translation of instructions that require Rc=True, like `sv.andi.`
Jacob Lifshay [Wed, 24 Aug 2022 11:33:27 +0000 (04:33 -0700)]
add self.subTest and src_loc_at support to TestAccumulatorBase
Jacob Lifshay [Wed, 24 Aug 2022 11:31:43 +0000 (04:31 -0700)]
misc cleanup
Jacob Lifshay [Wed, 24 Aug 2022 05:14:25 +0000 (22:14 -0700)]
finished writing svp64 utf-8 validation algorithm -- still buggy
Jacob Lifshay [Tue, 23 Aug 2022 09:19:19 +0000 (02:19 -0700)]
add WIP svp64 utf-8 validation algorithm
Luke Kenneth Casson Leighton [Thu, 18 Aug 2022 00:00:12 +0000 (01:00 +0100)]
use bitpattern in minor_30.csv to give a single match for
rldic and others. two lines were being used 0000 and 0001,
replaced with 000-
Dmitry Selyutin [Wed, 17 Aug 2022 19:15:24 +0000 (22:15 +0300)]
sv_binutils: support functions
Dmitry Selyutin [Wed, 17 Aug 2022 19:13:11 +0000 (22:13 +0300)]
power_insn: support function property
Dmitry Selyutin [Wed, 17 Aug 2022 18:43:58 +0000 (21:43 +0300)]
power_insn: fix sv_extra algorithm
Dmitry Selyutin [Wed, 17 Aug 2022 18:43:37 +0000 (21:43 +0300)]
power_enums: fix conversion from selector to reg
Luke Kenneth Casson Leighton [Wed, 17 Aug 2022 16:18:09 +0000 (17:18 +0100)]
again part of the removal of LD/ST-with-shift, take out
the early detection of a LD/ST operation that was formerly needed
for the SVP64.RM decoding to use a completely different 32-bit encoding.
we established with the whole LD/ST-with-shift experiment that this
was a really, really bad idea
Dmitry Selyutin [Tue, 16 Aug 2022 14:00:22 +0000 (17:00 +0300)]
pysvp64dis: rename the script due to name conflicts
Dmitry Selyutin [Mon, 15 Aug 2022 20:02:56 +0000 (23:02 +0300)]
pysvp64dis: switch to SelectableInt class
Dmitry Selyutin [Mon, 15 Aug 2022 19:30:32 +0000 (22:30 +0300)]
pysvp64dis: introduce disassembler script