gcc.git
4 years agolibstdc++: Micro-optimisations for lexicographical_compare_three_way
Jonathan Wakely [Tue, 3 Mar 2020 11:06:26 +0000 (11:06 +0000)]
libstdc++: Micro-optimisations for lexicographical_compare_three_way

As noted in LWG 3410 the specification in the C++20 draft performs more
iterator comparisons than necessary when the end of either range is
reached. Our implementation followed that specification. This removes
the redundant comparisons so that we do no unnecessary work as soon as
we find that we've reached the end of either range.

The odd-looking return statement is because it generates better code
than the original version that copied the global constants.

* include/bits/stl_algobase.h (lexicographical_compare_three_way):
Avoid redundant iterator comparisons (LWG 3410).

4 years agosccvn: Improve handling of load masked with integer constant [PR93582]
Jakub Jelinek [Tue, 3 Mar 2020 10:24:33 +0000 (11:24 +0100)]
sccvn: Improve handling of load masked with integer constant [PR93582]

As mentioned in the PR and discussed on IRC, the following patch is the
patch that fixes the originally reported issue.
We have there because of the premature bitfield comparison -> BIT_FIELD_REF
optimization:
  s$s4_19 = 0;
  s.s4 = s$s4_19;
  _10 = BIT_FIELD_REF <s, 8, 0>;
  _13 = _10 & 8;
and no other s fields are initialized.  If they would be all initialized with
constants, then my earlier PR93582 bitfield handling patches would handle it
already, but if at least one bit we ignore after the BIT_AND_EXPR masking
is not initialized or is initialized earlier to non-constant, we aren't able
to look through it until combine, which is too late for the warnings on the
dead code.
This patch handles BIT_AND_EXPR where the first operand is a SSA_NAME
initialized with a memory load and second operand is INTEGER_CST, by trying
a partial def lookup after pushing the ranges of 0 bits in the mask as
artificial initializers.  In the above case on little-endian, we push
offset 0 size 3 {} partial def and offset 4 size 4 (the result is unsigned
char) and then perform normal partial def handling.
My initial version of the patch failed miserably during bootstrap, because
data->finish (...) called vn_reference_lookup_or_insert_for_pieces
which I believe tried to remember the masked value rather than real for the
reference, or for failed lookup visit_reference_op_load called
vn_reference_insert.  The following version makes sure we aren't calling
either of those functions in the masked case, as we don't know anything
better about the reference from whatever has been discovered when the load
stmt has been visited, the patch just calls vn_nary_op_insert_stmt on
failure with the lhs (apparently calling it with the INTEGER_CST doesn't
work).

2020-03-03  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/93582
* tree-ssa-sccvn.h (vn_reference_lookup): Add mask argument.
* tree-ssa-sccvn.c (struct vn_walk_cb_data): Add mask and masked_result
members, initialize them in the constructor and if mask is non-NULL,
artificially push_partial_def {} for the portions of the mask that
contain zeros.
(vn_walk_cb_data::finish): If mask is non-NULL, set masked_result to
val and return (void *)-1.  Formatting fix.
(vn_reference_lookup_pieces): Adjust vn_walk_cb_data initialization.
Formatting fix.
(vn_reference_lookup): Add mask argument.  If non-NULL, don't call
fully_constant_vn_reference_p nor vn_reference_lookup_1 and return
data.mask_result.
(visit_nary_op): Handle BIT_AND_EXPR of a memory load and INTEGER_CST
mask.
(visit_stmt): Formatting fix.

* gcc.dg/tree-ssa/pr93582-10.c: New test.
* gcc.dg/pr93582.c: New test.
* gcc.c-torture/execute/pr93582.c: New test.

4 years agotree-optimization/93946 - fix bogus redundant store removal in FRE, DSE and DOM
Richard Biener [Tue, 3 Mar 2020 10:01:09 +0000 (11:01 +0100)]
tree-optimization/93946 - fix bogus redundant store removal in FRE, DSE and DOM

This fixes a common mistake in removing a store that looks redudnant but
is not because it changes the dynamic type of the memory and thus makes
a difference for following loads with TBAA.

2020-03-03  Richard Biener  <rguenther@suse.de>

PR tree-optimization/93946
* alias.h (refs_same_for_tbaa_p): Declare.
* alias.c (refs_same_for_tbaa_p): New function.
* tree-ssa-alias.c (ao_ref_alias_set): For a NULL ref return
zero.
* tree-ssa-scopedtables.h
(avail_exprs_stack::lookup_avail_expr): Add output argument
giving access to the hashtable entry.
* tree-ssa-scopedtables.c (avail_exprs_stack::lookup_avail_expr):
Likewise.
* tree-ssa-dom.c: Include alias.h.
(dom_opt_dom_walker::optimize_stmt): Validate TBAA state before
removing redundant store.
* tree-ssa-sccvn.h (vn_reference_s::base_set): New member.
(ao_ref_init_from_vn_reference): Adjust prototype.
(vn_reference_lookup_pieces): Likewise.
(vn_reference_insert_pieces): Likewise.
* tree-ssa-sccvn.c: Track base alias set in addition to alias
set everywhere.
(eliminate_dom_walker::eliminate_stmt): Also check base alias
set when removing redundant stores.
(visit_reference_op_store): Likewise.
* dse.c (record_store): Adjust valdity check for redundant
store removal.

* gcc.dg/torture/pr93946-1.c: New testcase.
* gcc.dg/torture/pr93946-2.c: Likewise.

4 years agos390: Fix --with-arch=... --with-tune=... [PR26877]
Jakub Jelinek [Tue, 3 Mar 2020 09:44:24 +0000 (10:44 +0100)]
s390: Fix --with-arch=... --with-tune=... [PR26877]

In Fedora we configure GCC with --with-arch=zEC12 --with-tune=z13 right now
and furthermore redhat-rpm-config adds to rpm packages -march=zEC12 -mtune=z13
options (among others).  While looking at the git compilation, I've been
surprised that -O2 actually behaves differently from -O2 -mtune=z13 in this
configuration, and indeed, seems --with-tune= is completely ignored on s390
if --with-arch= is specified.

i386 had the same problem, but got that fixed in 2006, see PR26877.
The thing is that for tune, we add -mtune=%(VALUE) only if neither -mtune=
nor -march= is present, but as arch is processed first, it adds
-march=%(VALUE) first and then -march= is always present and so -mtune= is
never added.
By reordering it in OPTION_DEFAULT_SPECS, we process tune first, add the
default -mtune=%(VALUE) if -mtune= or -march= isn't seen, and then
add -march=%(VALUE) if -march= isn't seen.  It is true that cc1 etc.
will be then invoked with -mtune=z13 -march=zEC12, but like if the user
specifies it in that order, it should still use z13 tuning and zEC12
ISA set.

2020-03-03  Jakub Jelinek  <jakub@redhat.com>

PR target/26877
* config/s390/s390.h (OPTION_DEFAULT_SPECS): Reorder.

4 years agoexplow: Fix ICE caused by plus_constant [PR94002]
Jakub Jelinek [Tue, 3 Mar 2020 09:42:34 +0000 (10:42 +0100)]
explow: Fix ICE caused by plus_constant [PR94002]

The following testcase ICEs in cross to riscv64-linux.  The problem is
that we have a DImode integral constant (that doesn't fit into SImode),
which is pushed into a constant pool and later access just the first half of
it using a MEM.  When plus_constant is called on such a MEM, if the constant
has mode, we verify the mode, but if it doesn't, we don't and ICE later on
when we think the CONST_INT is a valid SImode constant.

2020-03-03  Jakub Jelinek  <jakub@redhat.com>

PR rtl-optimization/94002
* explow.c (plus_constant): Punt if cst has VOIDmode and
get_pool_mode is different from mode.

* gcc.dg/pr94002.c: New test.

4 years agoarc: Update legitimate small data address.
Claudiu Zissulescu [Tue, 3 Mar 2020 08:34:50 +0000 (10:34 +0200)]
arc: Update legitimate small data address.

All ARC's small data adressing is using address scaling feature of the
load/store instructions (i.e., the address is made of a general
pointer plus a shifted offset. The shift amount depends on the
addressing mode).  This patch is checking the offset of an address if
it fits the scalled constraint.  If so, a small data access is
generated.  This patch fixes execute' pr93249 failure.

gcc/
xxxx-xx-xx  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.c (leigitimate_small_data_address_p): Check if an
address has an offset which fits the scalling constraint for a
load/store operation.
(legitimate_scaled_address_p): Update use
leigitimate_small_data_address_p.
(arc_print_operand): Likewise.
(arc_legitimate_address_p): Likewise.
(legitimate_small_data_address_p): Likewise.

Signed-off-by: Claudiu Zissulescu <claziss@gmail.com>
4 years agoarc: Use accl_operand predicate for fma instructions.
Claudiu Zissulescu [Tue, 3 Mar 2020 08:34:50 +0000 (10:34 +0200)]
arc: Use accl_operand predicate for fma instructions.

With the refurbish of ARC600' accumulator support, the mlo_operand
doesn't reflect the proper low accumulator register for the newer
ARCv2 accumulator register used by the fma instructions.  Hence,
replace it with accl_operand predicate.

gcc/
xxxx-xx-xx  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.md (fmasf4_fpu): Use accl_operand predicate.
(fnmasf4_fpu): Likewise.

4 years agoarc: Improve code gen for 64bit add/sub operations.
Claudiu Zissulescu [Tue, 3 Mar 2020 08:34:50 +0000 (10:34 +0200)]
arc: Improve code gen for 64bit add/sub operations.

Early expand ADDDI3 and SUBDI3 for better code gen.

gcc/
xxxx-xx-xx  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.md (adddi3): Early expand the 64bit operation into
32bit ops.
(subdi3): Likewise.
(adddi3_i): Remove pattern.
(subdi3_i): Likewise.

4 years agoarc: Add length attribute to eh_return pattern.
Claudiu Zissulescu [Tue, 3 Mar 2020 08:34:49 +0000 (10:34 +0200)]
arc: Add length attribute to eh_return pattern.

gcc/
xxxx-xx-xx  Claudiu Zissulescu  <claziss@synopsys.com>

* config/arc/arc.md (eh_return): Add length info.

4 years agotestsuite: Add testcases for already fixed PR [PR93927]
Jakub Jelinek [Tue, 3 Mar 2020 06:58:12 +0000 (07:58 +0100)]
testsuite: Add testcases for already fixed PR [PR93927]

2020-03-03  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/93927
* gcc.c-torture/compile/pr93927-1.c: New test.
* gcc.c-torture/compile/pr93927-2.c: New test.

4 years agoBuild coroutine expression with unknown_type in processing_template_decl phase.
JunMa [Wed, 5 Feb 2020 05:46:59 +0000 (13:46 +0800)]
Build coroutine expression with unknown_type in processing_template_decl phase.

gcc/cp
        * coroutines.cc (finish_co_await_expr): Build co_await_expr
        with unknown_type_node.
        (finish_co_yield_expr): Ditto.
        *pt.c (type_dependent_expression_p): Set co_await/yield_expr
        with unknown type as dependent.

gcc/testsuite
        * g++.dg/coroutines/torture/co-await-14-template-traits.C: New test.

4 years agoDaily bump.
GCC Administrator [Tue, 3 Mar 2020 00:16:38 +0000 (00:16 +0000)]
Daily bump.

4 years agoanalyzer: don't print the duplicate count by default
David Malcolm [Fri, 28 Feb 2020 15:06:57 +0000 (10:06 -0500)]
analyzer: don't print the duplicate count by default

The note about duplicates attached to analyzer diagnostics feels like an
implementation detail; it's likely just noise from the perspective of an
end-user.

This patch disables it by default, introducing a flag to re-enable it.

gcc/analyzer/ChangeLog:
* analyzer.opt (fanalyzer-show-duplicate-count): New option.
* diagnostic-manager.cc
(diagnostic_manager::emit_saved_diagnostic): Use the above to
guard the printing of the duplicate count.

gcc/ChangeLog:
* doc/invoke.texi (-fanalyzer-show-duplicate-count): New.

gcc/testsuite/ChangeLog:
* gcc.dg/analyzer/CVE-2005-1689-dedupe-issue.c: Add
-fanalyzer-show-duplicate-count.

4 years agoinvoke.texi: add missing option to -fanalyzer list
David Malcolm [Fri, 28 Feb 2020 13:55:55 +0000 (08:55 -0500)]
invoke.texi: add missing option to -fanalyzer list

gcc/ChangeLog:
* doc/invoke.texi (Static Analyzer Options): Add
-Wanalyzer-stale-setjmp-buffer to the list of options enabled
by -fanalyzer.

4 years agoanalyzer: detect malloc, free, calloc within "std" [PR93959]
David Malcolm [Thu, 27 Feb 2020 19:19:33 +0000 (14:19 -0500)]
analyzer: detect malloc, free, calloc within "std" [PR93959]

PR analyzer/93959 reported that g++.dg/analyzer/malloc.C was failing
with no output on Solaris.

The issue is that <stdlib.h> there has "using std::free;", converting
all the "free" calls to std::free, which fails the name-matching via
is_named_call_p.

This patch implements an is_std_named_call_p variant of is_named_call_p
to check for the name within "std", and uses it in sm-malloc.c to check
for std::malloc, std::calloc, and std::free.

gcc/analyzer/ChangeLog:
PR analyzer/93959
* analyzer.cc (is_std_function_p): New function.
(is_std_named_call_p): New functions.
* analyzer.h (is_std_named_call_p): New decl.
* sm-malloc.cc (malloc_state_machine::on_stmt): Check for "std::"
variants when checking for malloc, calloc and free.

gcc/testsuite/ChangeLog:
PR analyzer/93959
* g++.dg/analyzer/cstdlib-2.C: New test.
* g++.dg/analyzer/cstdlib.C: New test.

4 years agocoroutines: Update lambda capture handling to n4849.
Iain Sandoe [Mon, 2 Mar 2020 20:29:32 +0000 (20:29 +0000)]
coroutines: Update lambda capture handling to n4849.

In the absence of specific comment on the handling of closures I'd
implemented something more than was intended (extending the lifetime
of lambda capture-by-copy vars to the duration of the coro).

After discussion at WG21 in February and by email, the correct handling
is to treat the closure "this" pointer the same way as for a regular one,
and thus it is the user's responsibility to ensure that the lambda capture
object has suitable lifetime for the coroutine.  It is noted that users
frequently get this wrong, so it would be a good thing to revisit for C++23.

This patch removes the additional copying behaviour for lambda capture-by-
copy vars.

gcc/cp/ChangeLog:

2020-03-02  Iain Sandoe  <iain@sandoe.co.uk>

* coroutines.cc (struct local_var_info): Adjust to remove the
reference to the captured var, and just to note that this is a
lambda capture proxy.
(transform_local_var_uses): Handle lambda captures specially.
(struct param_frame_data): Add a visited set.
(register_param_uses): Also check for param uses in lambda
capture proxies.
(struct local_vars_frame_data): Remove captures list.
(register_local_var_uses): Handle lambda capture proxies by
noting and bypassing them.
(morph_fn_to_coro): Update to remove lifetime extension of
lambda capture-by-copy vars.

gcc/testsuite/ChangeLog:

2020-03-02  Iain Sandoe  <iain@sandoe.co.uk>
    Jun Ma <JunMa@linux.alibaba.com>

* g++.dg/coroutines/torture/class-05-lambda-capture-copy-local.C:
* g++.dg/coroutines/torture/lambda-09-init-captures.C: New test.
* g++.dg/coroutines/torture/lambda-10-mutable.C: New test.

4 years agoi386: Allow only registers with VALID_INT_MODE_P modes in movstrict<mode> [PR93997]
Uros Bizjak [Mon, 2 Mar 2020 20:13:36 +0000 (21:13 +0100)]
i386: Allow only registers with VALID_INT_MODE_P modes in movstrict<mode> [PR93997]

*movstrict<mode>_1 insn pattern allows only general registers,
so we have to reject modes not suitable for general regs in
corresponding movstrict<mode> expander.

PR target/93997
* config/i386/i386.md (movstrict<mode>): Allow only
registers with VALID_INT_MODE_P modes.

testsuite/ChangeLog:

PR target/93997
* gcc.target/i386/pr93997.c: New test.

4 years agoAdd new test for PR tree-optimization/92982.
Martin Sebor [Mon, 2 Mar 2020 18:49:01 +0000 (11:49 -0700)]
Add new test for PR tree-optimization/92982.

gcc/testsuite/ChangeLog:
PR tree-optimization/92982
* gcc.dg/strlenopt-94.c: New test.

4 years agoc++: Add -std=gnu++20 option [PR93958]
Marek Polacek [Sat, 29 Feb 2020 19:50:19 +0000 (14:50 -0500)]
c++: Add -std=gnu++20 option [PR93958]

One missing bit from r10-6656.  The docs and target-supports.exp
already handle -std=gnu++20.

2020-03-02  Marek Polacek  <polacek@redhat.com>

PR c++/93958 - add missing -std=gnu++20.
* c.opt: Add -std=gnu++20.

4 years agoEnsure sufficient size of variables used for module+submodule names.
Andrew Benson [Mon, 2 Mar 2020 17:28:35 +0000 (17:28 +0000)]
Ensure sufficient size of variables used for module+submodule names.

        PR fortran/93486
        * module.c: Increase size of variables used to read module names
        when loading interfaces from module files to permit cases where
        the name is the concatenation of a module and submodule name.
        * gfortran.dg/pr93486.f90: New test.

4 years agolibstdc++: Fix std::lexicographic_compare for unsigned char (PR 93972)
Jonathan Wakely [Mon, 2 Mar 2020 17:03:28 +0000 (17:03 +0000)]
libstdc++: Fix std::lexicographic_compare for unsigned char (PR 93972)

The new 25_algorithms/lexicographical_compare/93972.cc test fails on
targets where char is unsigned, revealing an existing regression with
the std::__memcmp helper that had gone unnoticed in
std::lexicographical_compare. When comparing char and unsigned char, the
memcmp optimisation is enabled, but the new std::__memcmp function fails
to compile for mismatched types.

PR libstdc++/93972
* include/bits/stl_algobase.h (__memcmp): Allow pointer types to
differ.
* testsuite/25_algorithms/lexicographical_compare/uchar.cc: New test.

4 years agolibstdc++: Rename __detail::__maybe_empty_t alias template
Jonathan Wakely [Mon, 2 Mar 2020 17:03:28 +0000 (17:03 +0000)]
libstdc++: Rename __detail::__maybe_empty_t alias template

The key property of this alias is not that it may be an empty type, but
that the type argument may not be used. The fact it's replaced by an
empty type is just an implementation detail.  The name was also
backwards with respect to the bool argument.

This patch changes the name to better reflect its purpose.

* include/std/ranges (__detail::__maybe_empty_t): Rename to
__maybe_present_t.
(__adaptor::_RangeAdaptor, join_view, split_view): Use new name.

4 years agocoroutines: Don't make duplicate frame copies of awaitables.
Iain Sandoe [Mon, 2 Mar 2020 15:35:45 +0000 (15:35 +0000)]
coroutines: Don't make duplicate frame copies of awaitables.

In general, we need to manage the lifetime of compiler-
generated awaitable instances in the coroutine frame, since
these must persist across suspension points.

However, it is quite possible that the user might provide the
awaitable instances, either as function params or as a local
variable.  We will already generate a frame entry for these as
required.

At present, under this circumstance, we are duplicating these,
awaitable, initialising a second frame copy for them (which we
then subsequently destroy manually after the suspension point).
That's not efficient - so an undesirable thinko in the first place.
However, there is also an actual bug; if the compiler elects to
elide the copy (which is perfectly legal), it does not have visibility
of the manual management of the post-suspend destruction
- this subsequently leads to double-free errors.

The solution is not to make the second copy (as noted, params
and local vars already have frame copies with managed lifetimes).

gcc/cp/ChangeLog:

2020-03-02  Iain Sandoe  <iain@sandoe.co.uk>

* coroutines.cc (build_co_await): Do not build frame
proxy vars when the co_await expression is a function
parameter or local var.
(co_await_expander): Do not initialise a frame var with
itself.
(transform_await_expr): Only substitute the awaitable
frame var if it's needed.
(register_awaits): Do not make frame copies for param
or local vars that are awaitables.

gcc/testsuite/ChangeLog:

2020-03-02  Iain Sandoe  <iain@sandoe.co.uk>

* g++.dg/coroutines/torture/func-params-09-awaitable-parms.C: New test.
* g++.dg/coroutines/torture/local-var-5-awaitable.C: New test.

4 years agoamdgcn: Extend reductions to all types
Andrew Stubbs [Fri, 7 Feb 2020 11:14:43 +0000 (11:14 +0000)]
amdgcn: Extend reductions to all types

Add support for V64DFmode addition, and V64DImode min, max.  There's no
direct hardware support for these, so we use regular vector instructions
and separate lane shift instructions.

Also add support for V64QI and V64HI reductions. Some of these require
additional extends and truncates, because AMD GCN has 32-bit vector lanes.

2020-03-02  Andrew Stubbs  <ams@codesourcery.com>

gcc/
* config/gcn/gcn-valu.md (dpp_move<mode>): New.
(reduc_insn): Use 'U' and 'B' operand codes.
(reduc_<reduc_op>_scal_<mode>): Allow all types.
(reduc_<reduc_op>_scal_v64di): Delete.
(*<reduc_op>_dpp_shr_<mode>): Allow all 1reg types.
(*plus_carry_dpp_shr_v64si): Change to ...
(*plus_carry_dpp_shr_<mode>): ... this and allow all 1reg int types.
(mov_from_lane63_v64di): Change to ...
(mov_from_lane63_<mode>): ... this, and allow all 64-bit modes.
* config/gcn/gcn.c (gcn_expand_dpp_shr_insn): Increase buffer size.
Support UNSPEC_MOV_DPP_SHR output formats.
(gcn_expand_reduc_scalar): Add "use_moves" reductions.
Add "use_extends" reductions.
(print_operand_address): Add 'I' and 'U' codes.
* config/gcn/gcn.md (unspec): Add UNSPEC_MOV_DPP_SHR.

4 years agoFix testsuite regression due to recent IRA changes.
Jeff Law [Mon, 2 Mar 2020 15:44:28 +0000 (08:44 -0700)]
Fix testsuite regression due to recent IRA changes.

* gcc.target/arm/fuse-caller-save.c: Update expected output.

4 years agoFix changelog typo
Segher Boessenkool [Mon, 2 Mar 2020 13:24:20 +0000 (13:24 +0000)]
Fix changelog typo

4 years agolibstdc++: Add 'typename' to fix compilation with Clang
Jonathan Wakely [Mon, 2 Mar 2020 12:18:45 +0000 (12:18 +0000)]
libstdc++: Add 'typename' to fix compilation with Clang

* include/bits/ranges_algo.h (shift_right): Add 'typename' to
dependent type.

4 years agoUpdate comment to reflect optimization.
Martin Liska [Mon, 2 Mar 2020 12:11:56 +0000 (13:11 +0100)]
Update comment to reflect optimization.

* gcc.dg/vect/bb-slp-19.c: The comment
does not align with fact that we started
to SLP the testcase.

4 years agoRemove duplicate declaration.
Martin Liska [Mon, 2 Mar 2020 12:08:49 +0000 (13:08 +0100)]
Remove duplicate declaration.

* libgcov-interface.c: Remove duplicate
declaration of __gcov_flush_mx.

4 years agoFix a libiberty testsuite failure
Nick Clifton [Mon, 2 Mar 2020 11:50:34 +0000 (03:50 -0800)]
Fix a libiberty testsuite failure

* testsuite/demangle-expected: Update expected demangling of
enable_if pattern.

4 years agolto: Also copy .note.gnu.property section
H.J. Lu [Mon, 2 Mar 2020 11:08:57 +0000 (03:08 -0800)]
lto: Also copy .note.gnu.property section

When generating the separate file with LTO debug sections, we should
also copy .note.gnu.property section.

PR lto/93966
* simple-object.c (handle_lto_debug_sections): Also copy
.note.gnu.property section.

4 years agoFix typo in C++ standard version.
Martin Liska [Mon, 2 Mar 2020 10:05:02 +0000 (11:05 +0100)]
Fix typo in C++ standard version.

* lto-wrapper.c: Fix typo in comment about
C++ standard version.

4 years ago[testsuites] Update several scev/IVOPTs cases
Kewen Lin [Mon, 2 Mar 2020 09:36:30 +0000 (03:36 -0600)]
[testsuites] Update several scev/IVOPTs cases

Several scev/IVOPTs cases aim to check some array references are sceved and
later marked as REFERENCE ADDRESS IV groups. With IV group type dumping
improving, these check strings can be improved. Otherwise, they become fragile
with dumping changes.

This patch is to keep check strings concise, meanwhile recover the coverage of
case scev-8.c.

gcc/testsuite/ChangeLog

2020-03-02  Kewen Lin  <linkw@gcc.gnu.org>

  * gcc.dg/tree-ssa/scev-8.c: Revise check string.
  * gcc.dg/tree-ssa/scev-9.c: Ditto.
  * gcc.dg/tree-ssa/scev-10.c: Ditto.
  * gcc.dg/tree-ssa/scev-11.c: Ditto.
  * gcc.dg/tree-ssa/scev-12.c: Ditto.

4 years agoPR middle-end/92721 - checking ICE on attribute access redeclaration
Martin Sebor [Mon, 2 Mar 2020 00:58:45 +0000 (17:58 -0700)]
PR middle-end/92721 - checking ICE on attribute access redeclaration

gcc/c-family/ChangeLog:

PR c++/92721
* c-attribs.c (append_access_attrs): Correctly handle attribute.
(handle_access_attribute): Same.

gcc/ChangeLog:

PR c++/92721
* calls.c (init_attr_rdwr_indices): Correctly handle attribute.

gcc/testsuite/ChangeLog:

PR c++/92721
g++.dg/ext/attr-access.C: New test.

4 years agoPR middle-end/93926 - ICE on a built-in redeclaration returning an integer instead...
Martin Sebor [Mon, 2 Mar 2020 00:52:44 +0000 (17:52 -0700)]
PR middle-end/93926 - ICE on a built-in redeclaration returning an integer instead of a pointer

gcc/c/ChangeLog:

PR middle-end/93926
* c-decl.c (types_close_enough_to_match): New function.
(match_builtin_function_types):
(diagnose_mismatched_decls): Add missing inform call to a warning.

gcc/testsuite/ChangeLog:

PR middle-end/93926
* gcc.dg/Wbuiltin-declaration-mismatch-13.c: New test.

4 years agoPR c/93812 - ICE on redeclaration of an attribute format function without protoype
Martin Sebor [Mon, 2 Mar 2020 00:41:45 +0000 (17:41 -0700)]
PR c/93812 - ICE on redeclaration of an attribute format function without protoype

gcc/c/ChangeLog:

PR c/93812
* c-typeck.c (build_functype_attribute_variant): New function.
(composite_type): Call it.

gcc/testsuite/ChangeLog:

PR c/93812
* gcc.dg/format/proto.c: New test.

4 years agoPR middle-end/93829 - bogus -Wstringop-overflow on memcpy of a struct with a pointer...
Martin Sebor [Mon, 2 Mar 2020 00:35:49 +0000 (17:35 -0700)]
PR middle-end/93829 - bogus -Wstringop-overflow on memcpy of a struct with a pointer member from another with a long string

gcc/testsuite/ChangeLog:

PR middle-end/93829
* gcc.dg/Wstringop-overflow-32.c: New test.

gcc/ChangeLog:

PR middle-end/93829
* tree-ssa-strlen.c (count_nonzero_bytes): Set the size to that
  of a pointer in the outermost ADDR_EXPRs.

4 years agoDaily bump.
GCC Administrator [Mon, 2 Mar 2020 00:16:33 +0000 (00:16 +0000)]
Daily bump.

4 years agoFix test for pr68805.
Segher Boessenkool [Sun, 1 Mar 2020 18:17:30 +0000 (11:17 -0700)]
Fix test for pr68805.

PR testsuite/91797
* gcc.target/pwoerpc/pr68805.c: Update expected output.

4 years agoFix test for pr88233.
Segher Boessenkool [Sun, 1 Mar 2020 18:13:18 +0000 (11:13 -0700)]
Fix test for pr88233.

PR testsuite/91799
* gcc.target/powerpc/pr88233.c: Update expected output and
add target selector.

4 years agocoroutines: Test that we correctly use class data members.
Iain Sandoe [Sun, 23 Feb 2020 15:44:20 +0000 (15:44 +0000)]
coroutines: Test that we correctly use class data members.

Improve test coverage, NFC.

gcc/testsuite/ChangeLog:

2020-03-01 Iain Sandoe <iain@sandoe.co.uk>

* g++.dg/coroutines/torture/class-07-data-member.C: New test.

4 years agoPatch and ChangeLogs for PR92976
Paul Thomas [Sun, 1 Mar 2020 16:15:28 +0000 (16:15 +0000)]
Patch and ChangeLogs for PR92976

4 years agoChangeLogs for PR92959
Paul Thomas [Sun, 1 Mar 2020 16:08:32 +0000 (16:08 +0000)]
ChangeLogs for PR92959

4 years agoPatch for PR92959
Paul Thomas [Sun, 1 Mar 2020 16:04:38 +0000 (16:04 +0000)]
Patch for PR92959

4 years agoDarwin, libsanitizer: Adjust minimum supported Darwin version (PR93731).
Iain Sandoe [Sun, 1 Mar 2020 14:40:57 +0000 (14:40 +0000)]
Darwin, libsanitizer: Adjust minimum supported Darwin version (PR93731).

The current imported libsanitizer code produces kernel panics for
Darwin 11 (macOS 10.7) and is unsupported for earlier versions already.

It is not clear if the current sources are even intended to be supported
on Darwin 11, so this patch causes the default to be build without
sanitizers for Darwin <= 11.

2020-03-01  Iain Sandoe  <iain@sandoe.co.uk>

PR sanitizer/93731
* configure.tgt (x86_64-*-darwin*, i?86-*-darwin*): Enable by
default only for Darwin versions greater than 12 (macOS 10.8).

4 years ago[Darwin, libsanitizer] Default to no sanitizer for Darwin <= 10
Iain Sandoe [Fri, 7 Jun 2019 12:20:07 +0000 (13:20 +0100)]
[Darwin, libsanitizer] Default to no sanitizer for Darwin <= 10

Darwin10 is no longer supported upstream and will not build without
additional patches.

4 years agox32: Update baseline_symbols.txt
H.J. Lu [Sun, 1 Mar 2020 14:13:28 +0000 (06:13 -0800)]
x32: Update baseline_symbols.txt

* config/abi/post/x86_64-linux-gnu/x32/baseline_symbols.txt: Updated.

4 years agoDaily bump.
GCC Administrator [Sun, 1 Mar 2020 00:16:37 +0000 (00:16 +0000)]
Daily bump.

4 years agocoroutines: Add a test for non-trivial await_resume return type.
Iain Sandoe [Sat, 29 Feb 2020 20:45:31 +0000 (20:45 +0000)]
coroutines: Add a test for non-trivial await_resume return type.

Improve test coverage.

gcc/testsuite/ChangeLog:

2020-02-29  Iain Sandoe  <iain@sandoe.co.uk>

* g++.dg/coroutines/coro1-ret-int-yield-int.h: Add templated
awaitable.
* g++.dg/coroutines/torture/co-await-15-return-non-triv.C: New test.

4 years agoMake STATIC_CHAIN_REGNUM a call used register.
Jeff Law [Sat, 29 Feb 2020 20:45:37 +0000 (13:45 -0700)]
Make STATIC_CHAIN_REGNUM a call used register.

* config/v850/v850.h (STATIC_CHAIN_REGNUM): Change to r19.
* config/v850/v850.c (v850_asm_trampoline_template): Update
accordingly.

4 years agoDisable gnat.dg/socket1.adb on hppa*-*-hpux*.
John David Anglin [Sat, 29 Feb 2020 20:36:49 +0000 (20:36 +0000)]
Disable gnat.dg/socket1.adb on hppa*-*-hpux*.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

PR ada/91100
* gnat.dg/socket1.adb: Disable on hppa*-*-hpux*.

4 years agoFix/skip various tests for hppa*-*-hpux*.
John David Anglin [Sat, 29 Feb 2020 20:16:39 +0000 (20:16 +0000)]
Fix/skip various tests for hppa*-*-hpux*.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

* g++.dg/pr90981.C: Skip on hppa*-*-hpux*.
* gcc.dg/gnu2x-attrs-1.c: Add dg-require-alias.
* gcc.dg/pr90756.c: Add -fno-common option on hppa*-*-hpux*.
* gcc.dg/torture/20190327-1.c: Likewise.
* gcc.dg/spellcheck-options-21.c: Skip on 32-bit hppa*-*-hpux*.
* gcc.dg/strlenopt-68.c: Skip on hppa*-*-hpux*.
* gcc.dg/torture/pr90020.c: Likewise.
* gcc.dg/ucnid-16-utf8.c: Add dg-require-iconv "latin1".

4 years agoXFAIL IPA tests that are not supported on 32-bit hppa*-*-hpux*.
John David Anglin [Sat, 29 Feb 2020 19:23:02 +0000 (19:23 +0000)]
XFAIL IPA tests that are not supported on 32-bit hppa*-*-hpux*.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

PR ipa/92548
* gcc.dg/ipa/ipa-sra-12.c: xfail parameter split test on 32-bit
hppa*-*-hpux*.
* gcc.dg/ipa/ipa-sra-14.c: Likewise.
* gcc.dg/ipa/ipcp-agg-12.c: xfail adding extra caller test.

4 years agoSkip charset.cc tests on *-*-hpux*.
John David Anglin [Sat, 29 Feb 2020 18:28:40 +0000 (18:28 +0000)]
Skip charset.cc tests on *-*-hpux*.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

* testsuite/17_intro/headers/c++1998/charset.cc: Skip on *-*-hpux*.
* testsuite/17_intro/headers/c++2011/charset.cc: Likewise.
* testsuite/17_intro/headers/c++2014/charset.cc: Likewise.
* testsuite/17_intro/headers/c++2017/charset.cc: Likewise.
* testsuite/17_intro/headers/c++2020/charset.cc: Likewise.

4 years agoExplicitly link with libatomic when needed.
John David Anglin [Sat, 29 Feb 2020 17:46:12 +0000 (17:46 +0000)]
Explicitly link with libatomic when needed.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

* testsuite/30_threads/condition_variable_any/stop_token/wait_on.cc:
Add libatomic option.
* testsuite/30_threads/jthread/jthread.cc: Likewise.

4 years agolibstdc++ Hastable: Move std::is_permutation to limit includes
François Dumont [Thu, 27 Feb 2020 18:08:40 +0000 (19:08 +0100)]
libstdc++ Hastable: Move std::is_permutation to limit includes

Move std::is_permutation algorithm with associated helpers to stl_algobase.h
to remove stl_algo.h include from hashtable_policy.h and so reduce preprocess
size of unordered_map and unordered_set headers.

* include/bits/stl_algo.h
(__find_if, __count_if, __is_permutation, std::is_permutation): Move...
* include/bits/stl_algobase.h: ...here.
* include/bits/hashtable_policy.h: Remove <bits/stl_algo.h> include.

4 years agoExplicitly link with libatomic when needed.
John David Anglin [Sat, 29 Feb 2020 17:32:24 +0000 (17:32 +0000)]
Explicitly link with libatomic when needed.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

* testsuite/30_threads/stop_token/stop_callback.cc: Add libatomic
option.
* testsuite/30_threads/stop_token/stop_callback/deadlock-mt.cc:
Likewise.
* testsuite/30_threads/stop_token/stop_callback/deadlock.cc: Likewise.
* testsuite/30_threads/stop_token/stop_callback/destroy.cc: Likewise.
* testsuite/30_threads/stop_token/stop_callback/invoke.cc: Likewise.
* testsuite/30_threads/stop_token/stop_source.cc: Likewise.
* testsuite/30_threads/stop_token/stop_source/assign.cc: Likewise.
* testsuite/30_threads/stop_token/stop_token.cc: Likewise.
* testsuite/30_threads/stop_token/stop_token/stop_possible.cc:
Likewise.

4 years agoFix typo in last entry.
John David Anglin [Sat, 29 Feb 2020 17:05:47 +0000 (17:05 +0000)]
Fix typo in last entry.

4 years agoAdd dg-require-visibility to tests that require visibility support.
John David Anglin [Sat, 29 Feb 2020 16:56:07 +0000 (16:56 +0000)]
Add dg-require-visibility to tests that require visibility support.

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

* /g++.dg/ext/visibility/ref-temp1.C: Require visibility.
* gfortran.dg/pr90988_4.f: Likewise.
* gfortran.dg/pr91372.f90: Likewise.

4 years agoFix baseline symbols on hppa-linux-gnu
John David Anglin [Sat, 29 Feb 2020 16:13:23 +0000 (16:13 +0000)]
Fix baseline symbols on hppa-linux-gnu

2020-02-29  John David Anglin  <danglin@gcc.gnu.org>

PR libstdc++/92906
* config/abi/post/hppa-linux-gnu/baseline_symbols.txt: Update.

4 years agoFix trivial regression from recent IRA changes
Jeff Law [Sat, 29 Feb 2020 16:01:46 +0000 (09:01 -0700)]
Fix trivial regression from recent IRA changes

* gcc.target/or1k/return-2.c: Update expected output.

4 years agoUpdate cpplib ru.po.
Joseph Myers [Sat, 29 Feb 2020 15:54:49 +0000 (15:54 +0000)]
Update cpplib ru.po.

* ru.po: Update.

4 years agoFix regression reported by tester due to recent IRA changes
Jeff Law [Sat, 29 Feb 2020 15:30:20 +0000 (08:30 -0700)]
Fix regression reported by tester due to recent IRA changes

* gcc.target/xstormy16/sfr/06_sfrw_to_var.c: Update expected output.

4 years agoc++: implement C++20 Disambiguating Nested-Requirements (P2092R0)
Jason Merrill [Fri, 28 Feb 2020 22:39:42 +0000 (17:39 -0500)]
c++: implement C++20 Disambiguating Nested-Requirements (P2092R0)

The rule change in the title matches GCC's current behavior, so no change
was needed.  But the paper also makes 'typename' optional in a
requirement-parameter-list, so this implements that.

gcc/cp/ChangeLog
2020-02-28  Jason Merrill  <jason@redhat.com>

Implement P2092R0, Disambiguating Nested-Requirements
* parser.c (cp_parser_requirement_parameter_list): Pass
CP_PARSER_FLAGS_TYPENAME_OPTIONAL.

4 years agoDaily bump.
GCC Administrator [Sat, 29 Feb 2020 00:16:37 +0000 (00:16 +0000)]
Daily bump.

4 years agolibstdc++: Fix bogus use of memcmp in ranges::lexicographical_compare (PR 93972)
Patrick Palka [Fri, 28 Feb 2020 19:16:06 +0000 (14:16 -0500)]
libstdc++: Fix bogus use of memcmp in ranges::lexicographical_compare (PR 93972)

We were enabling the memcmp optimization in ranges::lexicographical_compare for
signed integral types and for integral types wider than a byte.  But memcmp
gives the wrong answer for arrays of such types.  This patch fixes this issue by
refining the condition that enables the memcmp optimization.  It's now
consistent with the corresponding condition used in
std::lexicographical_compare.

libstdc++-v3/ChangeLog:

PR libstdc++/93972
* include/bits/ranges_algo.h (__lexicographical_compare_fn::operator()):
Fix condition for when to use memcmp, making it consistent with the
corresponding condition used in std::lexicographical_compare.
* testsuite/25_algorithms/lexicographical_compare/93972.cc: New test.

4 years agocoroutines: Update func-params-08.C to suspend three times.
Iain Sandoe [Fri, 28 Feb 2020 13:51:43 +0000 (13:51 +0000)]
coroutines: Update func-params-08.C to suspend three times.

The awaitable initially committed was returning "always ready"
which meant that the suspension code was not used.  Update
the test to suspend at each co_await, since this exercises more
of the infrastructure.

gcc/testsuite/ChangeLog:

2020-02-28  Iain Sandoe  <iain@sandoe.co.uk>

* g++.dg/coroutines/torture/func-params-08.C: Update
to suspend for each co_await operation.

4 years agoruntime: handle linux/arm64 signal register
eric fang [Fri, 21 Feb 2020 09:01:02 +0000 (09:01 +0000)]
runtime: handle linux/arm64 signal register

Set sigpc and implement dumpregs for linux/arm64.
Without this change, cmd/vet tool test will fail randomly.

Updates golang/go#20931

Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/220543

4 years agolibstdc++: Update the <numeric> synopsis test to latest standard
Patrick Palka [Fri, 28 Feb 2020 17:43:14 +0000 (12:43 -0500)]
libstdc++: Update the <numeric> synopsis test to latest standard

Tested with

  make check RUNTESTFLAGS="conformance.exp=*numeric*synopsis* --target_board=unix/-std=$std"

for std in {c++98, c++11, c++17, c++2a}.

libstdc++-v3/ChangeLog:

* testsuite/26_numerics/headers/numeric/synopsis.cc: Add signatures for
functions introduced in C++11, C++17 and C++2a.  Add 'constexpr' to
existing signatures for C++2a.

4 years agoc++: Fix constrained conversion op.
Jason Merrill [Fri, 28 Feb 2020 18:43:55 +0000 (13:43 -0500)]
c++: Fix constrained conversion op.

We don't want to promote a conversion from viable == 0 to viable == -1.
Found in ranges-v3.

gcc/cp/ChangeLog
2020-02-28  Jason Merrill  <jason@redhat.com>

* call.c (build_user_type_conversion_1): Don't look at the second
conversion of a non-viable candidate.

4 years agolibstdc++: test for failing assertion should use 'run' not 'compile'
Jonathan Wakely [Fri, 28 Feb 2020 17:05:45 +0000 (17:05 +0000)]
libstdc++: test for failing assertion should use 'run' not 'compile'

And it only needs to define _GLIBCXX_ASSERTIONS not _GLIBCXX_DEBUG.

* testsuite/24_iterators/range_operations/advance_debug_neg.cc: Run
test instead of just compiling it.

4 years agoCommit for PR92785
Paul Thomas [Fri, 28 Feb 2020 18:30:57 +0000 (18:30 +0000)]
Commit for PR92785

4 years agoFix target/93937
Michael Meissner [Fri, 28 Feb 2020 18:28:45 +0000 (13:28 -0500)]
Fix target/93937

2020-02-28  Michael Meissner  <meissner@linux.ibm.com>

PR target/93937
* config/rs6000/vsx.md (vsx_extract_<mode>_<VS_scalar>mode_var):
Delete, the insn will never work.

4 years agolibstdc++: Also disable caching of reverse_view::begin() for common_ranges
Patrick Palka [Fri, 28 Feb 2020 15:47:26 +0000 (10:47 -0500)]
libstdc++: Also disable caching of reverse_view::begin() for common_ranges

When the underlying range models common_range, then reverse_view::begin() is
already O(1) without caching.  So we should disable the cache in this case too.

libstdc++-v3/ChangeLog:

* include/std/ranges (reverse_view::_S_needs_cached_begin): Set to false
whenever the underlying range models common_range.

4 years agoImprove detection of ld_date.
Martin Liska [Fri, 28 Feb 2020 16:52:57 +0000 (17:52 +0100)]
Improve detection of ld_date.

PR other/93965
* configure.ac: Improve detection of ld_date by requiring
either two dashes or none.
* configure: Regenerate.

4 years agoc++: Further tweak for P1937R2 - const{expr,eval} inconsistencies
Jakub Jelinek [Fri, 28 Feb 2020 16:35:32 +0000 (17:35 +0100)]
c++: Further tweak for P1937R2 - const{expr,eval} inconsistencies

Seems I've missed one thing, as the first hunk in
https://github.com/cplusplus/draft/commit/c8e68ed202b4a9260616bcee8a9768b5dca4bbca
changes the wording so that only potentially-evaluated id-expressions that
denote immediate functions must appear only in the specified contexts.
That IMO means that in unevaluated contexts there aren't such restrictions
anymore, so I think in unevaluated contexts one should be able to take the
address of an immediate function.

2020-02-28  Jakub Jelinek  <jakub@redhat.com>

P1937R2 - Fixing inconsistencies between const{expr,eval} functions
* typeck.c (cp_build_addr_expr_1): Allow taking address of immediate
functions in unevaluated contexts.

* g++.dg/cpp2a/consteval3.C: Change dg-error about taking address of
immediate function in unevaluated contexts into dg-bogus.
* g++.dg/cpp2a/consteval16.C: New test.

4 years agoOne more patch for PR93564: Prefer smaller hard regno when we do not honor reg alloc...
Vladimir N. Makarov [Fri, 28 Feb 2020 16:27:30 +0000 (11:27 -0500)]
One more patch for PR93564: Prefer smaller hard regno when we do not honor reg alloc order.

2020-02-28  Vladimir Makarov  <vmakarov@redhat.com>

PR rtl-optimization/93564
* ira-color.c (assign_hard_reg): Prefer smaller hard regno when we
do not honor reg alloc order.

4 years agoFix misleading aarch64 mcpu/march warning string
Joel Hutton [Fri, 28 Feb 2020 14:46:26 +0000 (14:46 +0000)]
Fix misleading aarch64 mcpu/march warning string

The message for conflicting mcpu and march previously printed the
architecture of the CPU instead of the CPU name, as well as omitting the
extensions to the march string. This patch corrects both errors. This
patch fixes PR target/87612.

2020-02-27  Joel Hutton  <Joel.Hutton@arm.com>

        PR target/87612
        * config/aarch64/aarch64.c (aarch64_override_options): Fix
        misleading warning string.

4 years agolibstdc++: Memoize {drop,drop_while,filter,reverse}_view::begin
Patrick Palka [Tue, 11 Feb 2020 22:14:22 +0000 (17:14 -0500)]
libstdc++: Memoize {drop,drop_while,filter,reverse}_view::begin

This patch adds memoization to these four views so that their begin() has the
required amortized constant time complexity.

The cache is enabled only for forward_ranges and above because we need the
underlying iterator to be copyable and multi-pass in order for the cache to be
usable.  In the general case we represent the cached result of begin() as a bare
iterator.  This takes advantage of the fact that value-initialized forward
iterators can be compared to as per N3644, so we can use a value-initialized
iterator to denote the "empty" state of the cache.

As a special case, when the underlying range models random_access_range and when
it's profitable size-wise, then we cache the offset of the iterator from the
beginning of the range instead of caching the iterator itself.

Additionally, in drop_view and reverse_view we disable the cache when the
underlying range models random_access_range, because in these cases recomputing
begin() takes O(1) time anyway.

libstdc++-v3/ChangeLog:

* include/std/ranges (__detail::_CachedPosition): New struct.
(views::filter_view::_S_needs_cached_begin): New member variable.
(views::filter_view::_M_cached_begin): New member variable.
(views::filter_view::begin): Use _M_cached_begin to cache its
result.
(views::drop_view::_S_needs_cached_begin): New static member variable.
(views::drop_view::_M_cached_begin): New member variable.
(views::drop_view::begin): Use _M_cached_begin to cache its result
when _S_needs_cached_begin.
(views::drop_while_view::_M_cached_begin): New member variable.
(views::drop_while_view::begin): Use _M_cached_begin to cache its
result.
(views::reverse_view::_S_needs_cached_begin): New static member
variable.
(views::reverse_view::_M_cached_begin): New member variable.
(views::reverse_view::begin): Use _M_cached_begin to cache its result
when _S_needs_cached_begin.
* testsuite/std/ranges/adaptors/drop.cc: Augment test to check that
drop_view::begin caches its result.
* testsuite/std/ranges/adaptors/drop_while.cc: Augment test to check
that drop_while_view::begin caches its result.
* testsuite/std/ranges/adaptors/filter.cc: Augment test to check that
filter_view::begin caches its result.
* testsuite/std/ranges/adaptors/reverse.cc: Augment test to check that
reverse_view::begin caches its result.

4 years agolibstdc++: Fix FS-dependent filesystem tests
Jonathan Wakely [Thu, 27 Feb 2020 16:38:00 +0000 (16:38 +0000)]
libstdc++: Fix FS-dependent filesystem tests

These tests were failing on XFS because it doesn't support setting file
timestamps past 2038, so the expected overflow when reading back a huge
timestamp into a file_time_type didn't happen.

Additionally, the std::filesystem::file_time_type::clock has an
epoch that is out of range of 32-bit time_t so testing times around that
epoch may also fail.

This fixes the tests to give up gracefully if the filesystem doesn't
support times that can't be represented in 32-bit time_t.

* testsuite/27_io/filesystem/operations/last_write_time.cc: Fixes for
filesystems that silently truncate timestamps.
* testsuite/experimental/filesystem/operations/last_write_time.cc:
Likewise.

4 years agolibstdc++: Fix failing test in debug mode
Jonathan Wakely [Thu, 27 Feb 2020 17:22:50 +0000 (17:22 +0000)]
libstdc++: Fix failing test in debug mode

This fixes a failure due to a (correct) warning seen when testing with
-D_GLIBCXX_USE_CXX11_ABI=0 -D_GLIBCXX_ASSERTIONS:

include/bits/char_traits.h:365: warning: 'void* __builtin_memcpy(void*, const void*, long unsigned int)'
specified bound 18446744073709551615 exceeds maximum object size 9223372036854775807 [-Wstringop-overflow=]

FAIL: 21_strings/basic_string/cons/char/1.cc (test for excess errors)

* testsuite/21_strings/basic_string/cons/char/1.cc: Disable
-Wstringop-overflow warnings.

4 years agoAdd myself to MAINTAINERS
Joel Hutton [Fri, 28 Feb 2020 11:06:05 +0000 (11:06 +0000)]
Add myself to MAINTAINERS

2020-02-28  Joel Hutton  <joel.hutton@arm.com>

* MAINTAINERS (Write After Approval) : Add myself.

4 years agotestsuite: Fix up g++.dg/torture/pr92152.C test for ilp32 targets
Jakub Jelinek [Fri, 28 Feb 2020 08:44:53 +0000 (09:44 +0100)]
testsuite: Fix up g++.dg/torture/pr92152.C test for ilp32 targets

2020-02-28  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/92152
* g++.dg/torture/pr92152.C (size_t): Use decltype (sizeof (0)) instead
of hardcoding unsigned long.
(uint64_t): Use unsigned long long instead of unsigned long.

4 years agoDaily bump.
GCC Administrator [Fri, 28 Feb 2020 00:16:33 +0000 (00:16 +0000)]
Daily bump.

4 years agoDocument that -Wbuiltin-declaration-mismatch is enabled by default.
Martin Sebor [Thu, 27 Feb 2020 23:53:01 +0000 (16:53 -0700)]
Document that -Wbuiltin-declaration-mismatch is enabled by default.

gcc/ChangeLog:

* doc/invoke.texi (-Wbuiltin-declaration-mismatch): Fix a typo.

4 years agoUpdate gcc fr.po.
Joseph Myers [Thu, 27 Feb 2020 22:11:17 +0000 (22:11 +0000)]
Update gcc fr.po.

* fr.po: Update.

4 years agolibstdc++: Disable diagnostic URLs in testsuite
Jonathan Wakely [Thu, 27 Feb 2020 17:45:06 +0000 (17:45 +0000)]
libstdc++: Disable diagnostic URLs in testsuite

* testsuite/lib/libstdc++.exp (v3_target_compile): Add
-fdiagnostics-urls=never to options.

4 years agoFix PR target/93932
Michael Meissner [Thu, 27 Feb 2020 19:41:39 +0000 (14:41 -0500)]
Fix PR target/93932

[gcc]
2020-02-27  Michael Meissner  <meissner@linux.ibm.com>

PR target/93932
* config/rs6000/vsx.md (vsx_extract_<mode>_var, VSX_D iterator):
Split the insn into two parts.  This insn only does variable
extract from a register.
(vsx_extract_<mode>_var_load, VSX_D iterator): New insn, do
variable extract from memory.
(vsx_extract_v4sf_var): Split the insn into two parts.  This insn
only does variable extract from a register.
(vsx_extract_v4sf_var_load): New insn, do variable extract from
memory.
(vsx_extract_<mode>_var, VSX_EXTRACT_I iterator): Split the insn
into two parts.  This insn only does variable extract from a
register.
(vsx_extract_<mode>_var_load, VSX_EXTRACT_I iterator): New insn,
do variable extract from memory.

[gcc/testsuite]
2020-02-27  Michael Meissner  <meissner@linux.ibm.com>

PR target/93932
* gcc.target/powerpc/fold-vec-extract-longlong.p8.c: Adjust
instruction counts.

4 years agoCompare ARGUMENT_PACKS [pr93933]
Nathan Sidwell [Thu, 27 Feb 2020 18:50:36 +0000 (10:50 -0800)]
Compare ARGUMENT_PACKS [pr93933]

This implements Jason's suggested approach: 'I'd think that the bug is
that we're treating them as types in the first place; they aren't
types, so they shouldn't reach comptypes.  I'd lean toward adding an
assert to that effect and fixing the caller to use
e.g. template_args_equal.'

PR c++/93933
* pt.c (template_args_equal): Pass ARGUMENT_PACKS through to
cp_tree_equal.
* tree.c (cp_tree_equal): Compare ARGUMENT_PACKS here,
* typeck.c (comptypes): Assert we don't get any argument packs.

4 years agolibstdc++: Add missing friend declarations in some range adaptors
Patrick Palka [Wed, 26 Feb 2020 17:31:01 +0000 (12:31 -0500)]
libstdc++: Add missing friend declarations in some range adaptors

Some of the range adaptors have distinct constant and non-constant
iterator/sentinel types, along with converting constructors that can convert a
non-constant iterator/sentinel to a constant iterator/sentinel.  This patch adds
the missing appropriate friend declarations in order to make these converting
constructors well formed.

Strictly speaking it seems the friendship relations don't need to go both ways
-- we could get away with declaring e.g. friend _Iterator<false>; instead of
friend _Iterator<!_Const>; but both reference implementations seem to use the
latter symmetric form anyway.

libstdc++-v3/ChangeLog:

* include/std/ranges (transform_view::_Iterator<_Const>): Befriend
_Iterator<!_Const>.
(transform_view::_Sentinel<_Const>): Befriend _Sentinel<!_Const>.
(take_view::_Sentinel<_Const>): Likewise.
(take_while_view::_Sentinel<_Const>): Likewise.
(split_view::_OuterIter<_Const>): Befriend _OuterIter<!_Const>.
* testsuite/std/ranges/adaptors/split.cc: Augment test.
* testsuite/std/ranges/adaptors/take.cc: Augment test.
* testsuite/std/ranges/adaptors/take_while.cc: Augment test.
* testsuite/std/ranges/adaptors/transform.cc: Augment test.

4 years agolibstdc++: -D_GLIBCXX_DEBUG fixes in the constrained algos tests
Patrick Palka [Thu, 27 Feb 2020 15:35:08 +0000 (10:35 -0500)]
libstdc++: -D_GLIBCXX_DEBUG fixes in the constrained algos tests

This fixes the failures in the constrained algos tests when they are run in
debug mode.

libstdc++-v3/ChangeLog:

* testsuite/25_algorithms/copy/constrained.cc: Don't assume that the
base() of a vector<>::iterator is a pointer.
* testsuite/25_algorithms/copy_backward/constrained.cc: Likewise.
* testsuite/25_algorithms/move/constrained.cc: Likewise.
* testsuite/25_algorithms/move_backward/constrained.cc: Likewise.
* testsuite/25_algorithms/inplace_merge/constrained.cc: Use foo.data()
instead of &foo[0].
* testsuite/25_algorithms/partial_sort/constrained.cc: Likewise.
* testsuite/25_algorithms/partial_sort_copy/constrained.cc: Likewise.
* testsuite/25_algorithms/shuffle/constrained.cc: Likewise.
* testsuite/25_algorithms/sort/constrained.cc: Likewise.
* testsuite/25_algorithms/stable_sort/constrained.cc: Likewise.

4 years agoipa-cp: Avoid an ICE processing self-recursive cloned edges (PR 93707)
Martin Jambor [Thu, 27 Feb 2020 17:43:05 +0000 (18:43 +0100)]
ipa-cp: Avoid an ICE processing self-recursive cloned edges (PR 93707)

2020-02-27  Martin Jambor  <mjambor@suse.cz>
    Feng Xue  <fxue@os.amperecomputing.com>

PR ipa/93707
* ipa-cp.c (same_node_or_its_all_contexts_clone_p): Replaced with
new function calls_same_node_or_its_all_contexts_clone_p.
(cgraph_edge_brings_value_p): Use it.
(cgraph_edge_brings_value_p): Likewise.
(self_recursive_pass_through_p): Return false if caller is a clone.
(self_recursive_agg_pass_through_p): Likewise.

testsuite/
* gcc.dg/ipa/pr93707.c: New test.

4 years agomiddle-end: Fix wrong code caused by disagreemed between FRE and access path oracle...
Jan Hubicka [Thu, 27 Feb 2020 17:36:39 +0000 (18:36 +0100)]
middle-end: Fix wrong code caused by disagreemed between FRE and access path oracle [PR 92152]

FRE is checking stores for equivalence based on their address, value and
base+ref alias sets.  Because ref alias set is not always the alias set of
innermost type, but it may be one of refs in the access path (as decided by
component_uses_parent_alias_set_from) it means that we can not really rely on
the remaining part of access path to be meaningful in any way except for
offset+size computation.

The patch makes alias (which is used by FRE to validate transform) and
tree-ssa-alias to share same logic for ending the access path relevant for
TBAA. tree-ssa-alias previously ended access paths on VIEW_CONVERT_EXPR and
BIT_FIELD_REF so it is not hard to wire in common predicate.  However it led to
additional issues (I tried to read the code quite carefully for possible extra
fun, so I hope I found it all):

  1) alias_component_refs_walk compares base and reference sizes to see
     if one access path may continue by another.  This check can be confused
     by an union containing structure with zero sized array.  In this case we
     no longer see the refernece to zero sized array and think that ref size
     is 0.

     In an access path there can be at most one (valid) trailing/zero sized
     array access, so the sizes in the access path are decreasing with the
     this exception. This is already handled by the logic, however the access
     is not expected to happen past the end of TBAA segment.  I suppose this
     was kind of latent problem before because one can think of access path
     doing traling array past VIEW_CONVERT_EXPR, but since in C code we don't
     VCE and in non-C we don't do trailing arrays, we did not hit the problem.

     I fixed this by tracking if the trailing array references appearing after
     the end of TBAA access path and mostly punt in the second case (because we
     need to support kind of all type puning here). I do not think we can assume
     much of sanity here, in particular, we no longer know there is only one
     because FRE may mix things up.

     An exception is the walk that looks for occurence of basetype of path1
     within TBAA relevant part of path2.  Here we realy care about TBAA
     relevant parts of paths and thus do not need to give up.

     I broke out the logic into ends_tbaa_access_path_p to avoid duplication and
     to let me stick some detailed comments. This became much more complex
     than I originally imagined (still it is useful to make oracle both faster
     and more precise).

     Note that logic in aliasing_component_refs_walk is safe since it works
     on TBAA relevant segments of paths only.
  2) nonoverlapping_refs_since_match_p is using TBAA only in the corner case
     that the paths got out of sync and re-synchronize of types of same size
     are found.  I thus extended it to whole paths (not only TBAA relevant
     parts) and track if the TBAA part can be used by counting of number of
     TBAA relevant res on the stack.

     I have noticed that in one case we call nonoverlapping_refs_since_match_p
     before checking for view converting MEM_REFs and in others we check
     after.  I think we want to just disable TBAA part if view convert
     is in there but still disambiguate.  I will do this incrementaly.
  3) nonoverlapping_component_refs_p uses TBAA so it needs to punt on
     end of TBAA path. It deals with no sizes and thus there is not the issue
     as in 1).

I am also attaching one (most probably) valid C++ testcase (by Mark Williams)
where we incorrectly disambiguated while the code is valid by the common
initial sequence rule.  This happens to be fixed by same patch. Here one access
goes through union and follows by access path trhough one filed, while other
access path start by different field of the union with common initial sequence.
This made aliasing_component_refs_p to not find the overlapping type (because
there is none) and disambiguate.  Now we cut the first access path by the union
reference and this makes us to find the path continuation in
alias_component_refs_walk.

If FRE is ever made more careful about access paths past the fist union
reference (I think that would be good idea since unions are quite common in C++
and we throw away quite useful info) then we will need to teach access path
oracle about the common initial sequence rule (which, as Mark pointed out, is
part of both C and C++ standards).

Only argument that can possibly invalidate this testcase is that I do not see
that stadnard is clear about the situation where one access path contains the
union but other starts after the union.

Clearly if both start after the union reference we are right to disambiguate
(since there is no union unvolved).  If both starts before union then there is
common initial sequence and by standard it is defined. This case works on current
trunk because aliasing_component_refs_p resorts to base+offset after finding
the match. But even that is more or less an accident I would say.

I had to xfail three testcases.  While alias-access-path ones are artificial
and odd, 20030807-7 is derived from gcc and shows that we give up on
disambiguations of tree_node union, so this patch disables useful transform
in real world code.

I am still planning to collect some data on the effect of this change to TBAA,
but unless we want to reorganize FRE, I do not think there is better solution.

gcc/ChangeLog:

2020-02-26  Jan Hubicka  <hubicka@ucw.cz>

PR middle-end/92152
* alias.c (ends_tbaa_access_path_p): Break out from ...
(component_uses_parent_alias_set_from): ... here.
* alias.h (ends_tbaa_access_path_p): Declare.
* tree-ssa-alias.c (access_path_may_continue_p): Break out from ...;
handle trailing arrays past end of tbaa access path.
(aliasing_component_refs_p): ... here; likewise.
(nonoverlapping_refs_since_match_p): Track TBAA segment of the access
path; disambiguate also past end of it.
(nonoverlapping_component_refs_p): Use only TBAA segment of the access
path.

gcc/testsuite/ChangeLog:

2020-02-26  Jan Hubicka  <hubicka@ucw.cz>

PR middle-end/92152
* gcc.dg/tree-ssa/alias-access-path-12.c: New testcase.
* g++.dg/torture/pr92152.C: New testcase.
* gcc.dg/torture/pr92152.c: New testcase.
* gcc.dg/tree-ssa/20030807-7.c: xfail.
* gcc.dg/tree-ssa/alias-access-path-4.c: xfail one case.
* gcc.dg/tree-ssa/alias-access-path-5.c: xfail one case.

4 years ago [GCC][PATCH][ARM] Add vreinterpret, vdup, vget and vset bfloat16 intrinsics
Mihail Ionescu [Thu, 27 Feb 2020 16:00:48 +0000 (16:00 +0000)]
 [GCC][PATCH][ARM] Add vreinterpret, vdup, vget and vset bfloat16 intrinsics

This patch adds support for the bf16 vector create, get, set,
duplicate and reinterpret intrinsics.
ACLE documents are at https://developer.arm.com/docs/101028/latest
ISA documents are at https://developer.arm.com/docs/ddi0596/latest

gcc/ChangeLog:

2020-02-27  Mihail Ionescu  <mihail.ionescu@arm.com>

* (__ARM_NUM_LANES, __arm_lane, __arm_lane_q): Move to the
beginning of the file.
(vcreate_bf16, vcombine_bf16): New.
(vdup_n_bf16, vdupq_n_bf16): New.
(vdup_lane_bf16, vdup_laneq_bf16): New.
(vdupq_lane_bf16, vdupq_laneq_bf16): New.
(vduph_lane_bf16, vduph_laneq_bf16): New.
(vset_lane_bf16, vsetq_lane_bf16): New.
(vget_lane_bf16, vgetq_lane_bf16): New.
(vget_high_bf16, vget_low_bf16): New.
(vreinterpret_bf16_u8, vreinterpretq_bf16_u8): New.
(vreinterpret_bf16_u16, vreinterpretq_bf16_u16): New.
(vreinterpret_bf16_u32, vreinterpretq_bf16_u32): New.
(vreinterpret_bf16_u64, vreinterpretq_bf16_u64): New.
(vreinterpret_bf16_s8, vreinterpretq_bf16_s8): New.
(vreinterpret_bf16_s16, vreinterpretq_bf16_s16): New.
(vreinterpret_bf16_s32, vreinterpretq_bf16_s32): New.
(vreinterpret_bf16_s64, vreinterpretq_bf16_s64): New.
(vreinterpret_bf16_p8, vreinterpretq_bf16_p8): New.
(vreinterpret_bf16_p16, vreinterpretq_bf16_p16): New.
(vreinterpret_bf16_p64, vreinterpretq_bf16_p64): New.
(vreinterpret_bf16_f32, vreinterpretq_bf16_f32): New.
(vreinterpret_bf16_f64, vreinterpretq_bf16_f64): New.
(vreinterpretq_bf16_p128): New.
(vreinterpret_s8_bf16, vreinterpretq_s8_bf16): New.
(vreinterpret_s16_bf16, vreinterpretq_s16_bf16): New.
(vreinterpret_s32_bf16, vreinterpretq_s32_bf16): New.
(vreinterpret_s64_bf16, vreinterpretq_s64_bf16): New.
(vreinterpret_u8_bf16, vreinterpretq_u8_bf16): New.
(vreinterpret_u16_bf16, vreinterpretq_u16_bf16): New.
(vreinterpret_u32_bf16, vreinterpretq_u32_bf16): New.
(vreinterpret_u64_bf16, vreinterpretq_u64_bf16): New.
(vreinterpret_p8_bf16, vreinterpretq_p8_bf16): New.
(vreinterpret_p16_bf16, vreinterpretq_p16_bf16): New.
(vreinterpret_p64_bf16, vreinterpretq_p64_bf16): New.
(vreinterpret_f32_bf16, vreinterpretq_f32_bf16): New.
(vreinterpretq_p128_bf16): New.
* config/arm/arm_neon_builtins.def (VDX): Add V4BF.
(V_elem): Likewise.
(V_elem_l): Likewise.
(VD_LANE): Likewise.
(VQX) Add V8BF.
(V_DOUBLE): Likewise.
(VDQX): Add V4BF and V8BF.
(V_two_elem, V_three_elem, V_four_elem): Likewise.
(V_reg): Likewise.
(V_HALF): Likewise.
(V_double_vector_mode): Likewise.
(V_cmp_result): Likewise.
(V_uf_sclr): Likewise.
(V_sz_elem): Likewise.
(Is_d_reg): Likewise.
(V_mode_nunits): Likewise.
* config/arm/neon.md (neon_vdup_lane): Enable for BFloat.

gcc/testsuite/ChangeLog:

2020-02-27  Mihail Ionescu  <mihail.ionescu@arm.com>

* gcc.target/arm/bf16_dup.c: New test.
* gcc.target/arm/bf16_reinterpret.c: Likewise.

4 years agoamdgcn: sub-dword vector min/max/shift/bit operators
Andrew Stubbs [Tue, 25 Feb 2020 15:41:57 +0000 (15:41 +0000)]
amdgcn: sub-dword vector min/max/shift/bit operators

2020-02-27  Andrew Stubbs  <ams@codesourcery.com>

gcc/
* config/gcn/gcn-valu.md (VEC_SUBDWORD_MODE): New mode iterator.
(<expander><mode>2<exec>): Change modes to VEC_ALL1REG_INT_MODE.
(<expander><mode>3<exec>): Likewise.
(<expander><mode>3): New.
(v<expander><mode>3): New.
(<expander><mode>3): New.
(<expander><mode>3<exec>): Rename to ...
(<expander>v64si3<exec>): ... this, and change modes to V64SI.
* config/gcn/gcn.md (mnemonic): Use '%B' for not.

4 years agoPowerPC Add has_arch_pwr* checks
Will Schmidt [Thu, 27 Feb 2020 17:01:20 +0000 (11:01 -0600)]
PowerPC Add has_arch_pwr* checks

testsuite/

2020-02-25 Will Schmidt  <will_schmidt@vnet.ibm.com>

      * lib/target_supports.exp (check_effective_target_has_arch_pwr5): New.
      (check_effective_target_has_arch_pwr6): New.
      (check_effective_target_has_arch_pwr7): New.
      (check_effective_target_has_arch_pwr8): New.
      (check_effective_target_has_arch_pwr9): New.
      * gcc.target/powerpc/pr92132-fp-1.c: Add target check.

4 years agoUse -mno-pcrel for tests requiring TOC.
Bill Schmidt [Mon, 24 Feb 2020 21:01:59 +0000 (15:01 -0600)]
Use -mno-pcrel for tests requiring TOC.

2020-02-27  Bill Schmidt  <wschmidt@linux.ibm.com>

        * gcc.target/powerpc/ppc64-abi-1.c: Compile with -mno-pcrel.
        * gcc.target/powerpc/ppc64-abi-2.c: Likewise.

4 years agodefine NO_DOT_IN_LABEL only in vxworks6
Alexandre Oliva [Thu, 27 Feb 2020 16:34:47 +0000 (13:34 -0300)]
define NO_DOT_IN_LABEL only in vxworks6

There was a mistake in forward-porting and contributing some
vxworks7r2 changes, that caused a conditional to be dropped around a
couple of preprocessor directives, needed only up to vxworks6, that
change the compiler's behavior WRT introducing dollars and dots in
symbol names.

This deviates GCC's behavior from the native system compiler, in a way
that appears to have ABI implications, so we'd like to correct that,
even at this late stage in the development cycle.

for  gcc/ChangeLog

* config/vx-common.h (NO_DOLLAR_IN_LABEL, NO_DOT_IN_LABEL): Leave
them alone on vx7.

4 years agowork-around system header namespace pollution
Alexandre Oliva [Thu, 27 Feb 2020 16:34:44 +0000 (13:34 -0300)]
work-around system header namespace pollution

Including limits.h on vxworks pollutes the global namespace with SH
and many other platform names; work around it.

for  gcc/testsuite/ChangeLog

* gcc.target/aarch64/vect-mull.x (SH): Undefine.

4 years agolibstdc++: Define <=> for Debug Mode array
Jonathan Wakely [Thu, 27 Feb 2020 15:13:16 +0000 (15:13 +0000)]
libstdc++: Define <=> for Debug Mode array

This fixes a test failure with -D_GLIBCXX_DEBUG:

FAIL: 23_containers/array/comparison_operators/constexpr.cc (test for excess errors)

* include/debug/array (operator<=>): Define for C++20.
* testsuite/23_containers/array/tuple_interface/get_debug_neg.cc:
Adjust dg-error line numbers.
* testsuite/23_containers/array/tuple_interface/
tuple_element_debug_neg.cc: Likewise.