Andreas Hansson [Thu, 27 Sep 2012 07:24:21 +0000 (03:24 -0400)]
Configs: Fix memtest.py by moving the system port
The memtest.py script used to connect the system port directly to the
SimpleMemory, but the latter is now single ported. Since the system
port is not used for anything in this particular example, a quick fix
is to attach it to the functional bus instead.
Ali Saidi [Tue, 25 Sep 2012 16:49:41 +0000 (11:49 -0500)]
ARM: update stats for bp and squash fixes.
Djordje Kovacevic [Tue, 25 Sep 2012 16:49:41 +0000 (11:49 -0500)]
MEM: Put memory system document into doxygen
Mrinmoy Ghosh [Tue, 25 Sep 2012 16:49:41 +0000 (11:49 -0500)]
Cache: add a response latency to the caches
In the current caches the hit latency is paid twice on a miss. This patch lets
a configurable response latency be set of the cache for the backward path.
Sascha Bischoff [Tue, 25 Sep 2012 16:49:41 +0000 (11:49 -0500)]
Statistics: Add a function to configure periodic stats dumping
This patch adds a function, periodicStatDump(long long period), which will dump
and reset the statistics every period. This function is designed to be called
from the python configuration scripts. This allows the periodic stats dumping to
be configured more easilly at run time.
The period is currently specified as a long long as there are issues passing
Tick into the C++ from the python as they have conflicting definitions. If the
period is less than curTick, the first occurance occurs at curTick. If the
period is set to 0, then the event is descheduled and the stats are not
periodically dumped.
Due to issues when resumung from a checkpoint, the StatDump event must be moved
forward such that it occues AFTER the current tick. As the function is called
from the python, the event is scheduled before the system resumes from the
checkpoint. Therefore, the event is moved using the updateEvents() function.
This is called from simulate.py once the system has resumed from the checkpoint.
NOTE: It should be noted that this is a fairly temporary patch which re-adds the
capability to extract temporal information from the communication monitors. It
should not be used at the same time as anything that relies on dumping the
statistics based on in simulation events i.e. a context switch.
Dam Sunwoo [Tue, 25 Sep 2012 16:49:41 +0000 (11:49 -0500)]
ARM: added support for flattened device tree blobs
Newer Linux kernels require DTB (device tree blobs) to specify platform
configurations. The input DTB filename can be specified through gem5 parameters
in LinuxArmSystem.
Ali Saidi [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
O3: Pack the comm structures a bit better to reduce their size.
Ali Saidi [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
mem: Add a gasket that allows memory ranges to be re-mapped.
For example if DRAM is at two locations and mirrored this patch allows the
mirroring to occur.
Ali Saidi [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
ARM: Squash outstanding walks when instructions are squashed.
Sascha Bischoff [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
Util: Added script to semantically diff two config.ini files
This script (util/diff_config.pl) takes two config.ini files and compares them.
It highlights value changes, as well as displaying which parts are unique to
a specific config.ini file. This is useful when trying to replicate an earlier
experiment and when trying to make small changes to an existing configuration.
Andreas Sandberg [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
arm: Use a static_assert to test that miscRegName[] is complete
Instead of statically defining miscRegName to contain NUM_MISCREGS
elements, let the compiler determine the length of the array. This
allows us to use a static_assert to test that all registers are listed
in the name vector.
Andreas Sandberg [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
base: Check for static_assert support and provide fallback
C++11 has support for static_asserts to provide compile-time assertion
checking. This is very useful when testing, for example, structure
sizes to make sure that the compiler got the right alignment or vector
sizes.
Andreas Sandberg [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
sim: Move CPU-specific methods from SimObject to the BaseCPU class
Andreas Sandberg [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
sim: Remove SimObject::setMemoryMode
Remove SimObject::setMemoryMode from the main SimObject class since it
is only valid for the System class. In addition to removing the method
from the C++ sources, this patch also removes getMemoryMode and
changeTiming from SimObject.py and updates the simulation code to call
the (get|set)MemoryMode method on the System object instead.
Djordje Kovacevic [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
CPU: Add abandoned instructions to O3 Pipe Viewer
Nathanael Premillieu [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
ARM: Inst writing to cntrlReg registers not set as control inst
Deletion of the fact that instructions that writes to registers of type
"cntrlReg" are not set as control instruction (flag IsControl not set).
Ali Saidi [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
ARM: Predict target of more instructions that modify PC.
Ali Saidi [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
gem5: Update the README file to be a bit less out-of-date.
Andreas Sandberg [Tue, 25 Sep 2012 16:49:40 +0000 (11:49 -0500)]
build: Add missing dependencies when building param SWIG interfaces
This patch adds an explicit dependency between param_%s.i and the
Python source file defining the object. Previously, the build system
didn't rebuild SWIG interfaces correctly when an object's Python
sources were updated.
Andreas Hansson [Mon, 24 Sep 2012 22:03:43 +0000 (18:03 -0400)]
Stats: Update stats for twosys-tsunami after setting CPU clock
This patch updates the stats to reflect the addition of a clock
period other than the default 1 Tick.
Andreas Hansson [Mon, 24 Sep 2012 22:03:41 +0000 (18:03 -0400)]
Regression: Set the clock for twosys-tsunami CPUs
This patch merely adds a clock other than the default 1 Tick for the
CPUs of both the test system and drive system for the twosys-tsunami
regression.
The CPU frequency of the driver system is choosed to be twice that of
the test system to ensure it is not the bottleneck (although in this
case it mostly serves as a demonstration of a two-system setup),
Joel Hestness [Sun, 23 Sep 2012 18:57:08 +0000 (13:57 -0500)]
RubyPort and Sequencer: Fix draining
Fix the drain functionality of the RubyPort to only call drain on child ports
during a system-wide drain process, instead of calling each time that a
ruby_hit_callback is executed.
This fixes the issue of the RubyPort ports being reawakened during the drain
simulation, possibly with work they didn't previously have to complete. If
they have new work, they may call process on the drain event that they had
not registered work for, causing an assertion failure when completing the
drain event.
Also, in RubyPort, set the drainEvent to NULL when there are no events
to be drained. If not set to NULL, the drain loop can result in stale
drainEvents used.
Andreas Hansson [Fri, 21 Sep 2012 15:48:14 +0000 (11:48 -0400)]
SimpleDRAM: A basic SimpleDRAM regression
--HG--
rename : tests/configs/tgen-simple-mem.py => tests/configs/tgen-simple-dram.py
rename : tests/quick/se/70.tgen/tgen-simple-mem.cfg => tests/quick/se/70.tgen/tgen-simple-dram.cfg
rename : tests/quick/se/70.tgen/tgen-simple-mem.trc => tests/quick/se/70.tgen/tgen-simple-dram.trc
Andreas Hansson [Fri, 21 Sep 2012 15:48:13 +0000 (11:48 -0400)]
DRAM: Introduce SimpleDRAM to capture a high-level controller
This patch introduces a high-level model of a DRAM controller, with a
basic read/write buffer structure, a selectable and customisable
arbiter, a few address mapping options, and the basic DRAM timing
constraints. The parameters make it possible to turn this model into
any desired DDRx/LPDDRx/WideIOx memory controller.
The intention is not to be cycle accurate or capture every aspect of a
DDR DRAM interface, but rather to enable exploring of the high-level
knobs with a good simulation speed. Thus, contrary to e.g. DRAMSim
this module emphasizes simulation speed with a good-enough accuracy.
This module is merely a starting point, and there are plenty additions
and improvements to come. A notable addition is the support for
address-striping in the bus to enable a multi-channel DRAM
controller. Also note that there are still a few "todo's" in the code
base that will be addressed as we go along.
A follow-up patch will add basic performance regressions that use the
traffic generator to exercise a few well-defined corner cases.
Andreas Hansson [Fri, 21 Sep 2012 15:48:11 +0000 (11:48 -0400)]
TrafficGen: Add a basic traffic generator regression
This patch adds a basic regression for the traffic generator. The
regression also serves as an example of the file formats used. More
complex regressions that make use of a DRAM controller model will
follow shortly.
Andreas Hansson [Fri, 21 Sep 2012 15:48:08 +0000 (11:48 -0400)]
TrafficGen: Add a basic traffic generator
This patch adds a traffic generator to the code base. The generator is
aimed to be used as a black box model to create appropriate use-cases
and benchmarks for the memory system, and in particular the
interconnect and the memory controller.
The traffic generator is a master module, where the actual behaviour
is captured in a state-transition graph where each state generates
some sort of traffic. By constructing a graph it is possible to create
very elaborate scenarios from basic generators. Currencly the set of
generators include idling, linear address sweeps, random address
sequences and playback of traces (recording will be done by the
Communication Monitor in a follow-up patch). At the moment the graph
and the states are described in an ad-hoc line-based format, and in
the future this should be aligned with our used of e.g. the Google
protobufs. Similarly for the traces, the format is currently a
simplistic ad-hoc line-based format that merely serves as a starting
point.
In addition to being used as a black-box model for system components,
the traffic generator is also useful for creating test cases and
regressions for the interconnect and memory system. In future patches
we will use the traffic generator to create DRAM test cases for the
controller model.
The patch following this one adds a basic regressions which also
contains an example configuration script and trace file for playback.
Andreas Hansson [Fri, 21 Sep 2012 14:11:24 +0000 (10:11 -0400)]
Mem: Tidy up bus member variables types
This patch merely tidies up the types used for the bus member
variables. It also makes the constant ones const.
Andreas Hansson [Fri, 21 Sep 2012 14:11:22 +0000 (10:11 -0400)]
Scons: Verbose messages when dependencies are not installed
This patch adds a few more checks to ensure that a compiler is present
on the system, along with swig. It references the relevant packages on
Ubuntu/RedHat, and also adds a similar line for the Python headers.
Lluc Alvarez [Fri, 21 Sep 2012 08:51:18 +0000 (04:51 -0400)]
SE: Ignore FUTEX_PRIVATE_FLAG of sys_futex
This patch ignores the FUTEX_PRIVATE_FLAG of the sys_futex system call
in SE mode.
With this patch, when sys_futex with the options FUTEX_WAIT_PRIVATE or
FUTEX_WAKE_PRIVATE is emulated, the FUTEX_PRIVATE_FLAG is ignored and
so their behaviours are the regular FUTEX_WAIT and FUTEX_WAKE.
Emulating FUTEX_WAIT_PRIVATE and FUTEX_WAKE_PRIVATE as if they were
non-private is safe from a functional point of view. The
FUTEX_PRIVATE_FLAG does not change the semantics of the futex, it's
just a mechanism to improve performance under certain circunstances
that can be ignored in SE mode.
Anthony Gutierrez [Thu, 20 Sep 2012 21:25:52 +0000 (17:25 -0400)]
bus: removed outdated warn regarding 64 B block sizes
this warn is outdated as 64 B blocks are very common, and even
the default size for some CPU types. E.g., arm_detailed.
Andreas Hansson [Wed, 19 Sep 2012 10:15:46 +0000 (06:15 -0400)]
Mem: Remove the file parameter from AbstractMemory
This patch removes the unused file parameter from the
AbstractMemory. The patch serves to make it easier to transition to a
separation of the actual contigious host memory backing store, and the
gem5 memory controllers.
Without the file parameter it becomes easier to hide the creation of
the mmap in the PhysicalMemory, as there are no longer any reasons to
expose the actual contigious ranges to the user.
To the best of my knowledge there is no use of the parameter, so the
change should not affect anyone.
Andreas Hansson [Wed, 19 Sep 2012 10:15:44 +0000 (06:15 -0400)]
AddrRange: Transition from Range<T> to AddrRange
This patch takes the final plunge and transitions from the templated
Range class to the more specific AddrRange. In doing so it changes the
obvious Range<Addr> to AddrRange, and also bumps the range_map to be
AddrRangeMap.
In addition to the obvious changes, including the removal of redundant
includes, this patch also does some house keeping in preparing for the
introduction of address interleaving support in the ranges. The Range
class is also stripped of all the functionality that is never used.
--HG--
rename : src/base/range.hh => src/base/addr_range.hh
rename : src/base/range_map.hh => src/base/addr_range_map.hh
Andreas Hansson [Wed, 19 Sep 2012 10:15:43 +0000 (06:15 -0400)]
AddrRange: Simplify Range by removing stream input/output
This patch simplifies the Range class in preparation for the
introduction of a more specific AddrRange class that allows
interleaving/striping.
The only place where the parsing was used was in the unit test.
Andreas Hansson [Wed, 19 Sep 2012 10:15:42 +0000 (06:15 -0400)]
AddrRange: Remove unused range_multimap
This patch simply removes the unused range_multimap in preparation for
a more specific AddrRangeMap that also allows interleaving in addition
to pure ranges.
Andreas Hansson [Wed, 19 Sep 2012 10:15:41 +0000 (06:15 -0400)]
AddrRange: Simplify AddrRange params Python hierarchy
This patch simplifies the Range object hierarchy in preparation for an
address range class that also allows striping (e.g. selecting a few
bits as matching in addition to the range).
To extend the AddrRange class to an AddrRegion, the first step is to
simplify the hierarchy such that we can make it as lean as possible
before adding the new functionality. The only class using Range and
MetaRange is AddrRange, and the three classes are now collapsed into
one.
Nilay Vaish [Wed, 19 Sep 2012 03:49:12 +0000 (22:49 -0500)]
ruby: eliminate typedef integer_t
Nilay Vaish [Wed, 19 Sep 2012 03:46:34 +0000 (22:46 -0500)]
ruby: avoid using g_system_ptr for event scheduling
This patch removes the use of g_system_ptr for event scheduling. Each consumer
object now needs to specify upfront an EventManager object it would use for
scheduling events. This makes the ruby memory system more amenable for a
multi-threaded simulation.
Andreas Hansson [Tue, 18 Sep 2012 14:30:04 +0000 (10:30 -0400)]
Stats: Update stats to reflect SimpleMemory bandwidth
This patch simply bumps the stats to reflect the introduction of a
bandwidth limit of 12.8GB/s for SimpleMemory.
Andreas Hansson [Tue, 18 Sep 2012 14:30:02 +0000 (10:30 -0400)]
Mem: Add a maximum bandwidth to SimpleMemory
This patch makes a minor addition to the SimpleMemory by enforcing a
maximum data rate. The bandwidth is configurable, and a reasonable
value (12.8GB/s) has been choosen as the default.
The changes do add some complexity to the SimpleMemory, but they
should definitely be justifiable as this enables a far more realistic
setup using even this simple memory controller.
The rate regulation is done for reads and writes combined to reflect
the bidirectional data busses used by most (if not all) relevant
memories. Moreover, the regulation is done per packet as opposed to
long term, as it is the short term data rate (data bus width times
frequency) that is the limiting factor.
A follow-up patch bumps the stats for the regressions.
Andreas Hansson [Fri, 14 Sep 2012 16:13:22 +0000 (12:13 -0400)]
gcc: Enable Link-Time Optimization for gcc >= 4.6
This patch adds Link-Time Optimization when building the fast target
using gcc >= 4.6, and adds a scons flag to disable it (-no-lto). No
check is performed to guarantee that the linker supports LTO and use
of the linker plugin, so the user has to ensure that binutils GNU ld
>= 2.21 or the gold linker is available. Typically, if gcc >= 4.6 is
available, the latter should not be a problem. Currently the LTO
option is only useful for gcc >= 4.6, due to the limited support on
clang and earlier versions of gcc. The intention is to also add
support for clang once the LTO integration matures.
The same number of jobs is used for the parallel phase of LTO as the
jobs specified on the scons command line, using the -flto=n flag that
was introduced with gcc 4.6. The gold linker also supports concurrent
and incremental linking, but this is not used at this point.
The compilation and linking time is increased by almost 50% on
average, although ARM seems to be particularly demanding with an
increase of almost 100%. Also beware when using this as gcc uses a
tremendous amount of memory and temp space in the process. You have
been warned.
After some careful consideration, and plenty discussions, the flag is
only added to the fast target, and the warning that was issued in an
earlier version of this patch is now removed. Similarly, the flag used
to enable LTO, now the default is to use it, and the flag has been
modified to disable LTO. The rationale behind this decision is that
opt is used for development, whereas fast is only used for long runs,
e.g. regressions or more elaborate experiments where the additional
compile and link time is amortized by a much larger run time.
When it comes to the return on investment, the regression seems to be
roughly 15% faster with LTO. For a bit more detail, I ran twolf on
ARM.fast, with three repeated runs, and they all finish within 42
minutes (+- 25 seconds) without LTO and 31 minutes (+- 25 seconds)
with LTO, i.e. LTO gives an impressive >25% speed-up for this case.
Without LTO (ARM.fast twolf)
real 42m37.632s
user 42m34.448s
sys 0m0.390s
real 41m51.793s
user 41m50.384s
sys 0m0.131s
real 41m45.491s
user 41m39.791s
sys 0m0.139s
With LTO (ARM.fast twolf)
real 30m33.588s
user 30m5.701s
sys 0m0.141s
real 31m27.791s
user 31m24.674s
sys 0m0.111s
real 31m25.500s
user 31m16.731s
sys 0m0.106s
Andreas Hansson [Fri, 14 Sep 2012 16:13:21 +0000 (12:13 -0400)]
scons: Add a target for google-perftools profiling
This patch adds a new target called 'perf' that facilitates profiling
using google perftools rather than gprof. The perftools CPU profiler
offers plenty useful information in addition to gprof, and the latter
is kept mostly to offer profiling also on non-Linux hosts.
Andreas Hansson [Fri, 14 Sep 2012 16:13:20 +0000 (12:13 -0400)]
scons: Restructure ccflags and ldflags
This patch restructures the ccflags such that the common parts are
defined in a single location, also capturing all the target types in a
single place.
The patch also adds a corresponding ldflags in preparation for
google-perf profiling support and the addition of Link-Time
Optimization.
Andreas Hansson [Fri, 14 Sep 2012 16:13:18 +0000 (12:13 -0400)]
scons: Use c++0x with gcc >= 4.4 instead of 4.6
This patch shifts the version of gcc for which we enable c++0x from
4.6 to 4.4 The more long term plan is to see what the c++0x features
can bring and what level of support would be enabled simply by bumping
the required version of gcc from 4.3 to 4.4.
A few minor things had to be fixed in the code base, most notably the
choice of a hashmap implementation. In the Ruby Sequencer there were
also a few minor issues that gcc 4.4 was not too happy about.
Andreas Hansson [Thu, 13 Sep 2012 12:02:55 +0000 (08:02 -0400)]
Stats: Remove the reference stats that are no longer present
This patch simply removes the commitCommittedInsts and
commitCommittedOps from the reference statistics, following their
removal from the CPU.
Joel Hestness [Thu, 13 Sep 2012 02:42:57 +0000 (21:42 -0500)]
se.py Ruby: Connect TLB walker ports
In order to ensure correct functionality of switch CPUs, the TLB walker ports
must be connected to the Ruby system in x86 simulation.
This fixes x86 assertion failures that the TLB walker ports are not connected
during the CPU switch process.
Joel Hestness [Thu, 13 Sep 2012 02:41:37 +0000 (21:41 -0500)]
Standard Switch: Drain the system before switching CPUs
When switching from an atomic CPU to any of the timing CPUs, a drain is
unnecessary since no events are scheduled in atomic mode. However, when
trying to switch CPUs starting with a timing CPU, there may be events
scheduled. This change ensures that all events are drained from the system
by calling m5.drain before switching CPUs.
Joel Hestness [Thu, 13 Sep 2012 02:40:28 +0000 (21:40 -0500)]
Base CPU: Initialize profileEvent to NULL
The profileEvent pointer is tested against NULL in various places, but
it is not initialized unless running in full-system mode. In SE mode, this
can result in segmentation faults when profileEvent default intializes to
something other than NULL.
Jason Power [Wed, 12 Sep 2012 19:52:04 +0000 (14:52 -0500)]
Ruby: Modify Scons so that we can put .sm files in extras
Also allows for header files which are required in slicc generated
code to be in a directory other than src/mem/ruby/slicc_interface.
Anthony Gutierrez [Wed, 12 Sep 2012 15:35:52 +0000 (11:35 -0400)]
stats: remove duplicate instruction stats from the commit stage
these stats are duplicates of insts/opsCommitted, cause
confusion, and are poorly named.
Nilay Vaish [Tue, 11 Sep 2012 22:47:21 +0000 (17:47 -0500)]
se.py: removes error in passing options to a binary
Andreas Hansson [Tue, 11 Sep 2012 18:15:47 +0000 (14:15 -0400)]
clang: Fix issues identified by the clang static analyzer
This patch addresses a few minor issues reported by the clang static
analyzer.
The analysis was run with:
scan-build -disable-checker deadcode \
-enable-checker experimental.core \
-disable-checker experimental.core.CastToStruct \
-enable-checker experimental.cpluscplus
Andreas Hansson [Tue, 11 Sep 2012 18:14:51 +0000 (14:14 -0400)]
Checkpoint: Pass maxtick to avoid undefined variable
This patch fixes a bug in scriptCheckpoints, where maxtick was used
undefined. The bug caused checkpointing by means of --take-checkpoints
to fail.
Lena Olson [Tue, 11 Sep 2012 18:14:49 +0000 (14:14 -0400)]
Cache: Split invalidateBlk up to seperate block vs. tags
This seperates the functionality to clear the state in a block into
blk.hh and the functionality to udpate the tag information into the
tags. This gets rid of the case where calling invalidateBlk on an
already-invalid block does something different than calling it on a
valid block, which was confusing.
Nilay Vaish [Tue, 11 Sep 2012 14:34:40 +0000 (09:34 -0500)]
x86 Regressions: Update stats due to register predication
Nilay Vaish [Tue, 11 Sep 2012 14:33:42 +0000 (09:33 -0500)]
X86: make use of register predication
The patch introduces two predicates for condition code registers -- one
tests if a register needs to be read, the other tests whether a register
needs to be written to. These predicates are evaluated twice -- during
construction of the microop and during its execution. Register reads
and writes are elided depending on how the predicates evaluate.
Nilay Vaish [Tue, 11 Sep 2012 14:25:43 +0000 (09:25 -0500)]
x86: Add a separate register for D flag bit
The D flag bit is part of the cc flag bit register currently. But since it
is not being used any where in the implementation, it creates an unnecessary
dependency. Hence, it is being moved to a separate register.
Nilay Vaish [Sun, 3 Jun 2012 15:59:04 +0000 (10:59 -0500)]
ISA Parser: Allow predication of source and destination registers
This patch is meant for allowing predicated reads and writes. Note that this
predication is different from the ISA provided predication. They way we
currently provide the ISA description for X86, we read/write registers that
do not need to be actually read/written. This is likely to be true for other
ISAs as well. This patch allows for read and write predicates to be associated
with operands. It allows for the register indices for source and destination
registers to be decided at the time when the microop is constructed. The
run time indicies come in to play only when the at least one of the
predicates has been provided. This patch will not affect any of the ISAs that
do not provide these predicates. Also the patch assumes that the order in
which operands appear in any function of the microop is same across all the
functions of the microops. A subsequent patch will enable predication for the
x86 ISA.
Nilay Vaish [Tue, 11 Sep 2012 14:24:45 +0000 (09:24 -0500)]
Ruby: Use uint32_t instead of uint32 everywhere
Nilay Vaish [Tue, 11 Sep 2012 14:23:56 +0000 (09:23 -0500)]
Ruby: Use uint8_t instead of uint8 everywhere
Nilay Vaish [Mon, 10 Sep 2012 17:44:03 +0000 (12:44 -0500)]
Regression: Updates due to changes to Ruby memory controller
Nilay Vaish [Mon, 10 Sep 2012 17:21:01 +0000 (12:21 -0500)]
Ruby System: Convert to Clocked Object
This patch moves Ruby System from being a SimObject to recently introduced
ClockedObject.
Nilay Vaish [Mon, 10 Sep 2012 17:20:34 +0000 (12:20 -0500)]
Ruby Slicc: remove the call to cin.get() function
If I understand correctly, this was put in place so that a debugger can be
attached when the protocol aborts. While this sounds useful, it is a problem
when the simulation is not being actively monitored. I think it is better to
remove this.
Andreas Hansson [Mon, 10 Sep 2012 15:57:47 +0000 (11:57 -0400)]
Ruby: Bump the stats after recent memory controller changes
This patch simply bumps the stats to avoid having failing
regressions. Someone with more insight in the changes should verify
that these differences all make sense.
Marco Elver [Mon, 10 Sep 2012 15:57:43 +0000 (11:57 -0400)]
Mem: Allow serializing of more than INT_MAX bytes
Despite gzwrite taking an unsigned for length, it returns an int for
bytes written; gzwrite fails if (int)len < 0. Because of this, call
gzwrite with len no larger than INT_MAX: write in blocks of INT_MAX if
data to be written is larger than INT_MAX.
Palle Lyckegaard [Mon, 10 Sep 2012 15:57:42 +0000 (11:57 -0400)]
NetBSD: Build on NetBSD
Minor patch against so building on NetBSD is possible.
Andreas Hansson [Mon, 10 Sep 2012 15:57:40 +0000 (11:57 -0400)]
AddrRange: Remove the unused range_ops header
This patch prunes the range_ops header that is no longer used. The
bridge used it to do filtering of address ranges, but this is changed
since quite some time.
Ultimately this patch aims to simplify the handling of ranges before
specialising the AddrRange to an AddrRegion that also allows striping
bits to be selected.
Andreas Hansson [Mon, 10 Sep 2012 15:57:39 +0000 (11:57 -0400)]
Inet: Remove the SackRange and its use
This patch aims to simplify the use of the Range class before
introducing a more elaborate AddrRegion to replace the AddrRange. The
SackRange is the only use of the range class besides address ranges,
and the removal of this use makes for an easier modification of the
range class.
The functionlity that is removed with this patch is not used anywhere
throughout the code base.
Andreas Hansson [Mon, 10 Sep 2012 15:57:37 +0000 (11:57 -0400)]
Device: Update stats for PIO and PCI latency change
This patch merely updates the regression stats to reflect the change
in PIO and PCI latency.
Andreas Hansson [Mon, 10 Sep 2012 15:57:36 +0000 (11:57 -0400)]
Device: Bump PIO and PCI latencies to more reasonable values
This patch addresses a previously highlighted issue with the default
latencies used for PIO and PCI devices. The values are merely educated
guesses and might not represent the particular system you want to
model. However, the values in this patch are definitely far more
realistic than the previous ones.
In i8254xGBe, the writeConfig method is updated to use configDelay
instead of pioDelay.
A follow-up patch will update the regression stats.
Nilay Vaish [Sun, 9 Sep 2012 14:33:45 +0000 (09:33 -0500)]
se.py: support specifying multiple programs via command line
This patch allows for specifying multiple programs via command line. It also
adds an option for specifying whether to use of SMT. But SMT does not work for
the o3 cpu as of now.
Andreas Sandberg [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
sim: Update the SimObject documentation
Includes a small change in sim_object.cc that adds the name space to
the output stream parameter in serializeAll. Leaving out the name
space unfortunately confuses Doxygen.
Andreas Sandberg [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
sim: Remove the unused SimObject::regFormulas method
Simulation objects normally register derived statistics, presumably
what regFormulas originally was meant for, in regStats(). This patch
removes regRegformulas since there is no need to have a separate
method call to register formulas.
Ali Saidi [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
O3: Get rid of incorrect assert in RAS.
Ali Saidi [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
dev: Fix bifield definition in timer_cpulocal.hh
Bitfield definition in the local timer model for ARM had the bitfield
range numbers reversed which could lead to buggy behavior.
Ali Saidi [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
ARM: Fix the compiler and platform identification for building on ARM.
Ali Saidi [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
ARM: fix m5 op binary to properly convert 64bit operands
Matt Evans [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
ARM: Fix issue with with way MPIDR is read to include affinity levels.
The simple_bootloader checks for CPU0 in a manner incompatible with systems
actually using affinity levels -- just looking at MPIDR[7:0]. However, in
future we may wish to use real affinity levels and this method will be in danger
of matching several CPUs with affinity0 = 0.
Match affinity2 == affinity1 == affinity0 == 0 instead.
Ali Saidi [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
Igbe: Newer kernels seem to allow TSO headers and packet data to be in one desc
Implement some code we used to panic on as it actually does happen with the
e1000 driver in Linux 3.3+. We used to assume that a TSO header would never
be part of a larger payload, however it appears as though it now can be.
Djordje Kovacevic [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
CPU: O3-PipeView.py doesn't display the end of timelines.
Insts' timeline that stretches over multiple lines doesn't always get printed.
Krishnendra Nathella [Fri, 7 Sep 2012 19:20:53 +0000 (14:20 -0500)]
sim: add validation to make sure there is memory where we're loading the kernel
Ali Saidi [Fri, 7 Sep 2012 19:20:52 +0000 (14:20 -0500)]
loader: initialize all memory in the ObjectFile objects.
Some bare metal build flows seem to build binaries that we aren't necessarily
expecting. Initialize everything to 0, so we don't make any assumptions about
what is or isn't in the binary.
Ali Saidi [Fri, 7 Sep 2012 19:20:52 +0000 (14:20 -0500)]
ARM: Fix one of the timers used in the VExpress EMM platform.
Andreas Hansson [Fri, 7 Sep 2012 16:34:38 +0000 (12:34 -0400)]
Param: Transition to Cycles for relevant parameters
This patch is a first step to using Cycles as a parameter type. The
main affected modules are the CPUs and the Ruby caches. There are
definitely plenty more places that are affected, but this patch serves
as a starting point to making the transition.
An important part of this patch is to actually enable parameters to be
specified as Param.Cycles which involves some changes to params.py.
Joel Hestness [Thu, 6 Sep 2012 01:53:34 +0000 (20:53 -0500)]
stats: Update Ruby regressions for memory controller fix
Joel Hestness [Thu, 6 Sep 2012 01:51:41 +0000 (20:51 -0500)]
Ruby Memory Controller: Fix clocking
Jason Power [Tue, 28 Aug 2012 22:57:51 +0000 (17:57 -0500)]
Ruby: Correct DataBlock =operator
The =operator for the DataBlock class was incorrectly interpreting the class
member m_alloc. This variable stands for whether the assigned memory for the
data block needs to be freed or not by the class itself. It seems that the
=operator interpreted the variable as whether the memory is assigned to the
data block. This wrong interpretation was causing values not to propagate
to RubySystem::m_mem_vec_ptr. This caused major issues with restoring from
checkpoints when using a protocol which verified that the cache data was
consistent with the backing store (i.e. MOESI-hammer).
Andreas Hansson [Tue, 28 Aug 2012 18:30:33 +0000 (14:30 -0400)]
Clock: Add a Cycles wrapper class and use where applicable
This patch addresses the comments and feedback on the preceding patch
that reworks the clocks and now more clearly shows where cycles
(relative cycle counts) are used to express time.
Instead of bumping the existing patch I chose to make this a separate
patch, merely to try and focus the discussion around a smaller set of
changes. The two patches will be pushed together though.
This changes done as part of this patch are mostly following directly
from the introduction of the wrapper class, and change enough code to
make things compile and run again. There are definitely more places
where int/uint/Tick is still used to represent cycles, and it will
take some time to chase them all down. Similarly, a lot of parameters
should be changed from Param.Tick and Param.Unsigned to
Param.Cycles.
In addition, the use of curTick is questionable as there should not be
an absolute cycle. Potential solutions can be built on top of this
patch. There is a similar situation in the o3 CPU where
lastRunningCycle is currently counting in Cycles, and is still an
absolute time. More discussion to be had in other words.
An additional change that would be appropriate in the future is to
perform a similar wrapping of Tick and probably also introduce a
Ticks class along with suitable operators for all these classes.
Andreas Hansson [Tue, 28 Aug 2012 18:30:31 +0000 (14:30 -0400)]
Clock: Rework clocks to avoid tick-to-cycle transformations
This patch introduces the notion of a clock update function that aims
to avoid costly divisions when turning the current tick into a
cycle. Each clocked object advances a private (hidden) cycle member
and a tick member and uses these to implement functions for getting
the tick of the next cycle, or the tick of a cycle some time in the
future.
In the different modules using the clocks, changes are made to avoid
counting in ticks only to later translate to cycles. There are a few
oddities in how the O3 and inorder CPU count idle cycles, as seen by a
few locations where a cycle is subtracted in the calculation. This is
done such that the regression does not change any stats, but should be
revisited in a future patch.
Another, much needed, change that is not done as part of this patch is
to introduce a new typedef uint64_t Cycle to be able to at least hint
at the unit of the variables counting Ticks vs Cycles. This will be
done as a follow-up patch.
As an additional follow up, the thread context still uses ticks for
the book keeping of last activate and last suspend and this should
probably also be changed into cycles as well.
Andreas Hansson [Tue, 28 Aug 2012 18:30:27 +0000 (14:30 -0400)]
Port: Stricter port bind/unbind semantics
This patch tightens up the semantics around port binding and checks
that the ports that are being bound are currently not connected, and
similarly connected before unbind is called.
The patch consequently also changes the order of the unbind and bind
for the switching of CPUs to ensure that the rules are adhered
to. Previously the ports would be "over-written" without any check.
There are no changes in behaviour due to this patch, and the only
place where the unbind functionality is used is in the CPU.
Andreas Hansson [Tue, 28 Aug 2012 18:30:25 +0000 (14:30 -0400)]
Checker: Bump the realview-o3-checker regression
This patch bumps the stats for the realview-o3-checker after fixing
the checker CPU in the previous patch.
Andreas Hansson [Tue, 28 Aug 2012 18:30:24 +0000 (14:30 -0400)]
Checker: Fix checker CPU ports
This patch updates how the checker CPU handles the ports such that the
regressions will once again run without causing a panic.
A minor amount of tidying up was also done as part of this patch.
Andreas Hansson [Tue, 28 Aug 2012 18:30:22 +0000 (14:30 -0400)]
swig: Disable unused value warning with llvm 3.1 compilers
This patch disables a warning for unused values which causes problems
when compiling the swig-generated sources using recent llvm-based
compilers like llvm-gcc and clang.
Anthony Gutierrez [Tue, 28 Aug 2012 00:53:20 +0000 (20:53 -0400)]
sim: fix overflow check in simulate because Tick is now unsigned
Nilay Vaish [Mon, 27 Aug 2012 19:57:46 +0000 (14:57 -0500)]
Ruby: remove README.debugging and Decommissioning_note
These files were relevant when Ruby was part of GEMS. They are not required
any longer.
Nilay Vaish [Mon, 27 Aug 2012 06:14:46 +0000 (01:14 -0500)]
System: Remove redundant call to startupCPU
Nilay Vaish [Mon, 27 Aug 2012 06:00:55 +0000 (01:00 -0500)]
Ruby: Remove RubyEventQueue
This patch removes RubyEventQueue. Consumer objects now rely on RubySystem
or themselves for scheduling events.
Nilay Vaish [Mon, 27 Aug 2012 06:00:54 +0000 (01:00 -0500)]
Ruby Memory Vector: Allow more than 4GB of memory
The memory size variable was a 32-bit int. This meant that the size of the
memory was limited to 4GB. This patch changes the type of the variable to
64-bit to support larger memory sizes. Thanks to Raghuraman Balasubramanian
for bringing this to notice.
Nilay Vaish [Sat, 25 Aug 2012 20:49:07 +0000 (15:49 -0500)]
Regression: updates ruby.stats due to change in virtual network
Nilay Vaish [Sat, 25 Aug 2012 20:49:06 +0000 (15:49 -0500)]
MESI Protocol: Correct the virtual network in profile functions
The virtual network in a couple of places was incorrectly mentioned
as 3 in place of 1. This is being corrected.
Nilay Vaish [Sat, 25 Aug 2012 18:16:45 +0000 (13:16 -0500)]
MESI Coherence Protocol: Add copyright notice