gcc.git
5 years ago[Darwin, machopic 5/n] Make machopic_finish() static.
Iain Sandoe [Sat, 12 Oct 2019 19:24:48 +0000 (19:24 +0000)]
[Darwin, machopic 5/n] Make machopic_finish() static.

It's only called from darwin.c.

gcc/ChangeLog:

2019-10-12  Iain Sandoe  <iain@sandoe.co.uk>

* config/darwin-protos.h (machopic_finish): Delete.
* config/darwin.c (machopic_finish): Make static.

From-SVN: r276924

5 years ago[Darwin] Suppress emitting empty ctor/dtor sections.
Iain Sandoe [Sat, 12 Oct 2019 19:20:43 +0000 (19:20 +0000)]
[Darwin] Suppress emitting empty ctor/dtor sections.

Older versions of GCC emit empty .constructor/.destructor sections
whenever building for C++. In fact, these sections are only used for
kernel mode code - so don't emit them unless that's what we're
building.

gcc/ChangeLog:

2019-10-12  Iain Sandoe  <iain@sandoe.co.uk>

* config/darwin.c (darwin_file_end): Only emit empty CTOR/DTOR
sections when building kernel extension code.

From-SVN: r276923

5 years agoFix the ChangeLog for my previous commit
Palmer Dabbelt [Sat, 12 Oct 2019 19:07:16 +0000 (19:07 +0000)]
Fix the ChangeLog for my previous commit

Fixes: 66ce32bb2a8 ("Fix the ChangeLog for my previous commit")
From-SVN: r276922

5 years agoThe inline keyword is supported in all new C standards
Palmer Dabbelt [Sat, 12 Oct 2019 19:05:38 +0000 (19:05 +0000)]
The inline keyword is supported in all new C standards

The documentation used to indicate that the inline keyword was only
supported by c99 and c11, whereas in fact it is supported by c99 and all
newer standards.

gcc/ChangeLog

2019-10-12  Palmer Dabbelt  <palmer@sifive.com>

        * doc/extend.texi (Alternate Keywords): Change "-std=c11" to "a
        later standard."

From-SVN: r276921

5 years agopa.c (pa_option_override): Remove trailing comma from warning.
John David Anglin [Sat, 12 Oct 2019 18:31:42 +0000 (18:31 +0000)]
pa.c (pa_option_override): Remove trailing comma from warning.

* gcc/config/pa/pa.c (pa_option_override): Remove trailing comma
from warning.

From-SVN: r276920

5 years agore PR ada/91995 (gnat miscompilation and bootstrap failure on m68k-linux)
Eric Botcazou [Sat, 12 Oct 2019 14:47:34 +0000 (14:47 +0000)]
re PR ada/91995 (gnat miscompilation and bootstrap failure on m68k-linux)

PR ada/91995
* sem_ch8.adb (Chain_Use_Clause): Remove second argument in calls
to Defining_Entity.
* sem_elab.adb (Find_Unit_Entity): Likewise.  Deal with N_Subunit
here in lieu of in Defining_Entity.
* sem_util.ads (Defining_Entity): Remove 2nd and 3th parameters.
* sem_util.adb (Defining_Entity): Remove 2nd and 3th parameters,
and adjust accordingly.  Deal with N_Compilation_Unit.

From-SVN: r276916

5 years agore PR middle-end/92063 (ICE in operation_could_trap_p, at tree-eh.c:2528 when compili...
Jakub Jelinek [Sat, 12 Oct 2019 12:21:45 +0000 (14:21 +0200)]
re PR middle-end/92063 (ICE in operation_could_trap_p, at tree-eh.c:2528 when compiling Python's Python/_warnings.c)

PR middle-end/92063
* tree-eh.c (operation_could_trap_helper_p) <case COND_EXPR>
<case VEC_COND_EXPR>: Return false with *handled = false.
(tree_could_trap_p): For {,VEC_}COND_EXPR return false instead of
recursing on the first operand.
* fold-const.c (simple_operand_p_2): Use generic_expr_could_trap_p
instead of tree_could_trap_p.
* tree-ssa-sccvn.c (vn_nary_may_trap): Formatting fixes.

* gcc.c-torture/compile/pr92063.c: New test.

From-SVN: r276915

5 years agoc-common.h (c_omp_mark_declare_variant, [...]): Declare.
Jakub Jelinek [Sat, 12 Oct 2019 08:27:36 +0000 (10:27 +0200)]
c-common.h (c_omp_mark_declare_variant, [...]): Declare.

c-family/
* c-common.h (c_omp_mark_declare_variant,
c_omp_context_selector_matches): Declare.
* c-omp.c: Include attribs.h, gimplify.h, cgraph.h, symbol-summary.h
and hsa-common.h.
(c_omp_get_context_selector): Support second argument NULL.
(c_omp_mark_declare_variant, c_omp_context_selector_matches): New
functions.
* c-attribs.c (c_common_attribute_table): Remove "omp declare variant"
attribute, add "omp declare variant base" and
"omp declare variant variant" attributes.
c/
* c-parser.c (c_parser_omp_context_selector): Improve error recovery.
For simd properties, put them directly into TREE_VALUE.
(c_finish_omp_declare_variant): Call c_omp_mark_declare_variant.
If c_omp_context_selector_matches is 0, don't add attribute, otherwise
add "omp declare variant base" attribute rather than
"omp declare variant".
cp/
* parser.c (cp_parser_omp_context_selector): Improve error recovery.
For simd properties, put them directly into TREE_VALUE.
(cp_finish_omp_declare_variant): Add "omp declare variant base"
attribute rather than "omp declare variant".
testsuite/
* c-c++-common/gomp/declare-variant-2.c: Adjust for error recovery
improvements.  Add new tests.
* c-c++-common/gomp/declare-variant-4.c: New test.
* c-c++-common/gomp/declare-variant-5.c: New test.
* c-c++-common/gomp/declare-variant-6.c: New test.
* c-c++-common/gomp/declare-variant-7.c: New test.

From-SVN: r276914

5 years agocompiler: mangle dots in pkgpath
Ian Lance Taylor [Sat, 12 Oct 2019 01:06:43 +0000 (01:06 +0000)]
compiler: mangle dots in pkgpath

    We need to mangle dots to avoid problems with -fgo-pkgpath=a.0.
    That will confuse the name mangling, which assumes that names
    entering the mangling cannot contain arbitrary dot characters.
    We don't need to mangle other characters; go_encode_id will handle them.

    Fixes golang/go#33871

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/200838

From-SVN: r276913

5 years agoDaily bump.
GCC Administrator [Sat, 12 Oct 2019 00:16:16 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r276912

5 years agoSupport decimal floating-point constants in C2x.
Joseph Myers [Fri, 11 Oct 2019 22:22:52 +0000 (23:22 +0100)]
Support decimal floating-point constants in C2x.

ISO C2x adds decimal floating point as an optional standard feature.
This patch accordingly makes GCC accept DFP constants (DF, DD, DL, df,
dd, dl suffixes) in strict C2X mode, with a pedwarn-if-pedantic for
older standards and a warning with -Wc11-c2x-compat even in C2x mode
(which in turn requires -Wc11-c2x-compat to be newly passed through to
libcpp).

Bootstrapped with no regressions on x86_64-pc-linux-gnu.

gcc/c-family:
* c.opt (Wc11-c2x-compat): Add CPP(cpp_warn_c11_c2x_compat)
CppReason(CPP_W_C11_C2X_COMPAT).

gcc/testsuite:
* gcc.dg/dfp/c11-constants-1.c, gcc.dg/dfp/c11-constants-2.c,
gcc.dg/dfp/c2x-constants-1.c, gcc.dg/dfp/c2x-constants-2.c: New
tests.
* gcc.dg/dfp/constants-pedantic.c: Use -std=gnu17 explicitly.
Update expected diagnostics.

libcpp:
* include/cpplib.h (struct cpp_options): Add dfp_constants and
cpp_warn_c11_c2x_compat.
(enum cpp_warning_reason): Add CPP_W_C11_C2X_COMPAT.
* init.c (struct lang_flags): Add dfp_constants.
(lang_defaults): Set dfp_constants to 1 for GNUC2X and STDC2X and
0 for other languages.
(cpp_set_lang): Set dfp_constants from language.
(cpp_create_reader): Set cpp_warn_c11_c2x_compat to -1.
* expr.c (interpret_float_suffix): Mention DFP constants as C2X in
comment.
(cpp_classify_number): Do not diagnose DFP constants for languages
setting dfp_constants, unless cpp_warn_c11_c2x_compat.

From-SVN: r276908

5 years agoPR c++/92070 - bogus error with -fchecking=2.
Marek Polacek [Fri, 11 Oct 2019 20:53:26 +0000 (20:53 +0000)]
PR c++/92070 - bogus error with -fchecking=2.

* g++.dg/expr/cond17.C: New test.

From-SVN: r276907

5 years agoPR c++/92049 - extra error with -fchecking=2.
Marek Polacek [Fri, 11 Oct 2019 20:44:02 +0000 (20:44 +0000)]
PR c++/92049 - extra error with -fchecking=2.

The concepts merge brought this bit

@@ -26326,9 +26559,9 @@ build_non_dependent_expr (tree expr)
     unexpected recursive instantiations.  */
       && !parsing_nsdmi ()
       /* Don't do this during concept expansion either and for
-         the same reason.  */
-      && !expanding_concept ())
-    fold_non_dependent_expr (expr, tf_none);
+    the same reason.  */
+      && !parsing_constraint_expression_p ())
+    fold_non_dependent_expr (expr);

   STRIP_ANY_LOCATION_WRAPPER (expr);

(which I'm not finding in the ChangeLog).  Dropping tf_none means that
fold_non_dependent_expr will use tf_warning_or_error by default, and in
this test that causes an error:

  template<bool> struct cond;

  template<int> struct S {
    void f(int i) {
      cond<__builtin_constant_p(i)>();
    }
  };

  S<1> s;

where it complains that cond<false> is incomplete.  Which it is, but we're
not actually instantiating the function f, so issuing an error seems
overzealous (though not wrong), and it breaks a bunch of tests.  This patch
brings that tf_none back.  We will still complain if we do instantiate f.

* pt.c (build_non_dependent_expr): Call fold_non_dependent_expr
with tf_none.

* g++.dg/template/builtin2.C: New test.

From-SVN: r276906

5 years agotypeck.c (cp_build_binary_op): Do not handle RROTATE_EXPR and LROTATE_EXPR.
Paolo Carlini [Fri, 11 Oct 2019 19:18:13 +0000 (19:18 +0000)]
typeck.c (cp_build_binary_op): Do not handle RROTATE_EXPR and LROTATE_EXPR.

2019-10-10  Paolo Carlini  <paolo.carlini@oracle.com>

* typeck.c (cp_build_binary_op): Do not handle RROTATE_EXPR and
LROTATE_EXPR.
* constexpr.c (cxx_eval_constant_expression): Likewise.
(potential_constant_expression_1): Likewise.
* cp-gimplify.c (cp_fold): Likewise.
* pt.c (tsubst_copy): Likewise.

From-SVN: r276903

5 years agoPreserve the location of explicitly defaulted functions.
Jason Merrill [Fri, 11 Oct 2019 18:55:14 +0000 (14:55 -0400)]
Preserve the location of explicitly defaulted functions.

* decl2.c (mark_used): Don't clobber DECL_SOURCE_LOCATION on
explicitly defaulted functions.
* method.c (synthesize_method): Likewise.

From-SVN: r276902

5 years agoExtend subst to simplify CONST_INT inside SIGN_EXTEND.
Jim Wilson [Fri, 11 Oct 2019 18:41:35 +0000 (18:41 +0000)]
Extend subst to simplify CONST_INT inside SIGN_EXTEND.

This addresses PR 91860 which has four testcases triggering internal errors.
The problem here is that in combine when handling debug insns, we are trying
to substitute
(sign_extend:DI (const_int 8160 [0x1fe0]))
as the value for
(reg:DI 78 [ _9 ])
in the debug insn
(debug_insn 29 28 30 2 (var_location:QI d (subreg:QI (reg:DI 78 [ _9 ]) 0)) "tmp4.c":11:5 -1
     (nil))
This eventually triggers an abort because 8160 is not a sign-extended
QImode value.

In subst there is already code check for a CONST_INT inside a ZERO_EXTEND and
simplify it.  This needs to be extended to also handle a SIGN_EXTEND the same
way.

gcc/
PR rtl-optimization/91860
* combine.c (subst): If new_rtx is a constant, also check for
SIGN_EXTEND when deciding whether to call simplify_unary_operation.

gcc/testsuite/
PR rtl-optimization/91860
* gcc.dg/pr91860-1.c: New testcase.
* gcc.dg/pr91860-2.c: New testcase.
* gcc.dg/pr91860-3.c: New testcase.
* gcc.dg/pr91860-4.c: New testcase.

From-SVN: r276901

5 years agore PR fortran/91649 (ICE in gfc_resolve_findloc, at fortran/iresolve.c:1827)
Steven G. Kargl [Fri, 11 Oct 2019 18:05:35 +0000 (18:05 +0000)]
re PR fortran/91649 (ICE in gfc_resolve_findloc, at fortran/iresolve.c:1827)

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/91649
check.c (gfc_check_findloc): Additional checking for valid arguments

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/91649
* gfortran.dg/pr91649.f90: New test.

From-SVN: r276900

5 years agore PR fortran/91715 (ICE in resolve_fntype, at fortran/resolve.c:16884)
Steven G. Kargl [Fri, 11 Oct 2019 17:59:09 +0000 (17:59 +0000)]
re PR fortran/91715 (ICE in resolve_fntype, at fortran/resolve.c:16884)

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/91715
* decl.c (gfc_match_prefix): If matching a type-spec returns an error,
it's an error so re-act correctly.

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/91715
* gfortran.dg/function_kinds_5.f90: Prune run-on error.
* gfortran.dg/pr85543.f90: Ditto.
* gfortran.dg/pr91715.f90: New test.

From-SVN: r276899

5 years agore PR fortran/92018 (ICE in gfc_conv_constant_to_tree, at fortran/trans-const.c:370)
Steven G. Kargl [Fri, 11 Oct 2019 17:52:27 +0000 (17:52 +0000)]
re PR fortran/92018 (ICE in gfc_conv_constant_to_tree, at fortran/trans-const.c:370)

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/92018
* check.c (reset_boz): New function.
(illegal_boz_arg, boz_args_check, gfc_check_complex, gfc_check_float,
gfc_check_transfer): Use it.
(gfc_check_dshift): Use reset_boz, and re-arrange the checking to
help suppress possible run-on errors.
(gfc_check_and): Restore checks for valid argument types.  Use
reset_boz, and re-arrange the checking to help suppress possible
  un-on errors.
* resolve.c (resolve_function): Actual arguments cannot be BOZ in
a function reference.

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/92018
* gfortran.dg/gnu_logical_2.f90: Update dg-error regex.
* gfortran.dg/pr81509_2.f90: Ditto.
* gfortran.dg/pr92018.f90: New test.

From-SVN: r276898

5 years agore PR fortran/92019 (ICE in find_inquiry_ref, at expr.c:1790)
Steven G. Kargl [Fri, 11 Oct 2019 17:41:29 +0000 (17:41 +0000)]
re PR fortran/92019 (ICE in find_inquiry_ref, at expr.c:1790)

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/92019
* array.c (match_subscript): BOZ cannot be an array subscript.

2019-10-11  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/92019
* gfortran.dg/pr92019.f90: New test.

From-SVN: r276897

5 years agoSupport _Decimal* keywords for C2x.
Joseph Myers [Fri, 11 Oct 2019 17:32:48 +0000 (18:32 +0100)]
Support _Decimal* keywords for C2x.

ISO C2x adds decimal floating point as an optional standard feature.
This patch accordingly makes GCC accept the _Decimal* keywords in
strict C2x mode, using pedwarn_c11 to get a warning for
-Wc11-c2x-compat.  (Constants, where the pedwarn is in libcpp, will be
dealt with separately.)

The _Decimal* keywords are marked with D_EXT, meaning they are not
considered keywords at all in strict conformance modes.  This is
contrary to the normal practice for most implementation-namespace
keywords, which are accepted in all standards modes but with
appropriate pedwarns for older standards.  This patch removes D_EXT
from those keywords so they are accepted as keywords for all
standards, consequently removing the gcc.dg/dfp/keywords-ignored-c99.c
test that is no longer valid.

(A new D_C2X for keywords will still be needed if any new keywords get
added that aren't in the implementation namespace for older standards;
there are proposals for such keywords, albeit as predefined macros
that might not actually need new keywords in the compiler in all
cases.  If the DFP keywords end up as decimal32 etc., of course
appropriate compiler and testcase changes will be needed, and a
version of keywords-ignored-c99.c would make sense again with such
spellings.)

Bootstrapped with no regressions on x86_64-pc-linux-gnu.

gcc/c:
* c-decl.c (declspecs_add_type): Use pedwarn_c11 for DFP types.

gcc/c-family:
* c-common.c (c_common_reswords): Do not use D_EXT for _Decimal32,
_Decimal64 and _Decimal128.

gcc/testsuite:
* gcc.dg/dfp/c11-keywords-1.c, gcc.dg/dfp/c11-keywords-2.c,
gcc.dg/dfp/c2x-keywords-1.c, gcc.dg/dfp/c2x-keywords-2.c: New
tests.
* gcc.dg/dfp/keywords-ignored-c99.c: Remove test.
* gcc.dg/dfp/constants-c99.c, gcc.dg/dfp/keywords-c89.c,
gcc.dg/dfp/keywords-c99.c: Use -pedantic-errors.

From-SVN: r276896

5 years ago* fi.po: Update.
Joseph Myers [Fri, 11 Oct 2019 17:23:50 +0000 (18:23 +0100)]
* fi.po: Update.

From-SVN: r276894

5 years agoImplement <concepts> header for C++20
Jonathan Wakely [Fri, 11 Oct 2019 15:53:52 +0000 (16:53 +0100)]
Implement <concepts> header for C++20

There are currently no tests for [concepts.compare], but they will be
added ASAP.

* include/Makefile.am: Add new header.
* include/Makefile.in: Regenerate.
* include/precompiled/stdc++.h: Include <concepts>.
* include/std/concepts: New header for C++20.
* include/std/version (__cpp_lib_concepts): Define.
* scripts/create_testsuite_files: Look for test files in new std
directory.
* testsuite/libstdc++-dg/conformance.exp: Likewise.
* testsuite/std/concepts/concepts.callable/invocable.cc: New test.
* testsuite/std/concepts/concepts.callable/regular_invocable.cc: New
test.
* testsuite/std/concepts/concepts.callable/relation.cc: New test.
* testsuite/std/concepts/concepts.callable/strictweakorder.cc: New
test.
* testsuite/std/concepts/concepts.lang/concept.arithmetic/
floating_point.cc: New test.
* testsuite/std/concepts/concepts.lang/concept.arithmetic/integral.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.arithmetic/
signed_integral.cc: New test.
* testsuite/std/concepts/concepts.lang/concept.arithmetic/
unsigned_integral.cc: New test.
* testsuite/std/concepts/concepts.lang/concept.assignable/1.cc: New
test.
* testsuite/std/concepts/concepts.lang/concept.common/1.cc: New test.
* testsuite/std/concepts/concepts.lang/concept.commonref/1.cc: New
test.
* testsuite/std/concepts/concepts.lang/concept.constructible/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.convertible/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.copyconstructible/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.defaultconstructible/
1.cc: New test.
* testsuite/std/concepts/concepts.lang/concept.derived/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.destructible/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.moveconstructible/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.same/1.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.swappable/swap.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.swappable/swappable.cc:
New test.
* testsuite/std/concepts/concepts.lang/concept.swappable/
swappable_with.cc: New test.
* testsuite/std/concepts/concepts.object/copyable.cc: New test.
* testsuite/std/concepts/concepts.object/movable.cc: New test.
* testsuite/std/concepts/concepts.object/regular.cc: New test.
* testsuite/std/concepts/concepts.object/semiregular.cc: New test.

From-SVN: r276892

5 years agoUse __is_same_as for std::is_same and std::is_same_v
Jonathan Wakely [Fri, 11 Oct 2019 15:53:44 +0000 (16:53 +0100)]
Use __is_same_as for std::is_same and std::is_same_v

By using the built-in we don't need to match a partial specialization
for std::is_same and don't need to instantiate std::is_same at all for
uses of std::is_same_v.

* include/std/type_traits (is_same): Replace partial specialization
by using __is_same_as built-in in primary template.
(is_same_v): Use __is_same_as built-in instead of instantiating the
is_same trait.

From-SVN: r276891

5 years agoPR libstdc++/92059 fix several bugs in tr2::dynamic_bitset
Jonathan Wakely [Fri, 11 Oct 2019 15:29:55 +0000 (16:29 +0100)]
PR libstdc++/92059 fix several bugs in tr2::dynamic_bitset

PR libstdc++/92059
* include/tr2/dynamic_bitset (__dynamic_bitset_base): Define all
special member functions as defaulted. Add noexcept to most members.
(__dynamic_bitset_base(size_t, unsigned long long, const _Alloc&)):
Mask off unwanted bits in the __val parameter. Avoid undefined left
shifts.
(__dynamic_bitset_base::_M_assign): Remove.
(__dynamic_bitset_base::_M_do_reset): Use std::fill.
(__dynamic_bitset_base::_M_are_all_aux): Avoid integer promotion when
block_type has lower rank than int.
(dynamic_bitset): Add noexcept to most members. Use injected-class-name
in return types and parameter types.
(dynamic_bitset::_M_Nb): Add default member initializer.
(dynamic_bitset(), dynamic_bitset(const dynamic_bitset&)): Define as
defaulted.
(dynamic_bitset(dynamic_bitset&&)): Clear source object after move.
(dynamic_bitset::operator=(const dynamic_bitset&)): Define as
defaulted.
(dynamic_bitset::operator=(dynamic_bitset&&)): Add noexcept-specifier.
Define without using swap, to propagate allocator correctly.
(dynamic_bitset(const char*, const _Alloc&)): Use strlen.
(dynamic_bitset::_M_do_sanitize, dynamic_bitset::_M_do_fill): Use
casts to avoid unwanted integer promotions.
(dynamic_bitset::_M_copy_from_ptr): Rearrange template parameters and
add default template arguments and default argument to simplify usage.
(dynamic_bitset::_M_copy_from_string): Adjust call to _M_copy_from_ptr.
(operator==(const dynamic_bitset&, const dynamic_bitset&))
(operator<(const dynamic_bitset&, const dynamic_bitset&)): Use _M_Nb.
* include/tr2/dynamic_bitset.tcc (dynamic_bitset::_M_copy_from_ptr):
Adjust template parameters to match declaration.
* testsuite/tr2/dynamic_bitset/cmp.cc: New test.
* testsuite/tr2/dynamic_bitset/cons.cc: New test.
* testsuite/tr2/dynamic_bitset/copy.cc: New test.
* testsuite/tr2/dynamic_bitset/move.cc: New test.
* testsuite/tr2/dynamic_bitset/pr92059.cc: New test.

From-SVN: r276890

5 years agoAvoid warnings in <charconv>
Jonathan Wakely [Fri, 11 Oct 2019 15:29:50 +0000 (16:29 +0100)]
Avoid warnings in <charconv>

* include/bits/charconv.h (__to_chars_len): Avoid -Wsign-compare
warnings.

From-SVN: r276889

5 years agoRelax store_bit_field call in store_expr
Richard Sandiford [Fri, 11 Oct 2019 14:44:13 +0000 (14:44 +0000)]
Relax store_bit_field call in store_expr

store_bit_field already takes a poly_uint64 size, so we can relax the
INTVAL to rtx_to_poly_int64.  This is tested by the SVE ACLE patches.

2019-10-11  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
* expr.c (store_expr): Use rtx_to_poly_int64 rather than
INTVAL when calling store_bit_field.

From-SVN: r276888

5 years ago[ARM] Tweak HONOR_REG_ALLOC_ORDER
Wilco Dijkstra [Fri, 11 Oct 2019 14:23:28 +0000 (14:23 +0000)]
[ARM] Tweak HONOR_REG_ALLOC_ORDER

Setting HONOR_REG_ALLOC_ORDER improves codesize with -Os, however it generates
slower and larger code with -O2 and higher.  So only set it when optimizing for
size.  On Cortex-A57 this improves SPECINT2006 by 0.15% and SPECFP2006 by 0.25%
while reducing codesize.

    gcc/
* config/arm/arm.h (HONOR_REG_ALLOC_ORDER): Set when optimizing for
size.

From-SVN: r276887

5 years agotree-vect-loop.c (vect_analyze_loop_operations): Adjust call to vectorizable_live_ope...
Bernd Edlinger [Fri, 11 Oct 2019 14:17:32 +0000 (14:17 +0000)]
tree-vect-loop.c (vect_analyze_loop_operations): Adjust call to vectorizable_live_operation.

2019-10-11  Bernd Edlinger  <bernd.edlinger@hotmail.de>

        * tree-vect-loop.c (vect_analyze_loop_operations): Adjust call to
        vectorizable_live_operation.
        (vectorizable_live_operation): Adjust parameters.
        * tree-vect-stmts.c (vect_init_vector,
        vect_gen_widened_results_half): Fix typo in function comment.
        (can_vectorize_live_stmts): Adjust function comment.
        Adjust parameters.  Adjust call to vectorizable_live_operation.
        (vect_analyze_stmt): Adjust call to can_vectorize_live_stmts.
        (vect_transform_stmt): Adjust function comment.  Adjust call to
        can_vectorize_live_stmts.
        * tree-vectorizer.h (vectorizable_live_operation): Adjust parameters.

From-SVN: r276886

5 years agoFortran] PR 92050 - fix ICE with -fcheck=all
Tobias Burnus [Fri, 11 Oct 2019 13:41:13 +0000 (13:41 +0000)]
Fortran] PR 92050 - fix ICE with -fcheck=all

        gcc/fortran/
        PR fortran/92050
        * trans-expr.c (gfc_conv_procedure_call): Handle code generated
        by -fcheck=all.

        gcc/testsuite/
        PR fortran/92050
        * gfortran.dg/pr92050.f90: New.

From-SVN: r276885

5 years agore PR tree-optimization/90883 (Generated code is worse if returned struct is unnamed)
Richard Biener [Fri, 11 Oct 2019 13:10:15 +0000 (13:10 +0000)]
re PR tree-optimization/90883 (Generated code is worse if returned struct is unnamed)

2019-10-11  Richard Biener  <rguenther@suse.de>

PR tree-optimization/90883
PR tree-optimization/91091
* tree-ssa-sccvn.c (vn_reference_lookup_3): Use correct
alias-sets both for recording VN table entries and continuing
walking after translating through copies.  Handle same-sized
reads from SSA names by returning the plain SSA name.
(eliminate_dom_walker::eliminate_stmt): Properly handle
non-size precision stores in redundant store elimination.

* gcc.dg/torture/20191011-1.c: New testcase.
* gcc.dg/tree-ssa/ssa-fre-82.c: Likewise.
* gcc.dg/tree-ssa/ssa-fre-83.c: Likewise.
* gcc.dg/tree-ssa/redundant-assign-zero-1.c: Disable FRE.
* gcc.dg/tree-ssa/redundant-assign-zero-2.c: Likewise.

From-SVN: r276882

5 years agoggc-page.c (release_pages): Output statistics when !quiet_flag.
Jan Hubicka [Fri, 11 Oct 2019 11:53:40 +0000 (13:53 +0200)]
ggc-page.c (release_pages): Output statistics when !quiet_flag.

* ggc-page.c (release_pages): Output statistics when !quiet_flag.
(ggc_collect): Dump later to not interfere with release_page dump.
(ggc_trim): New function.
* ggc-none.c (ggc_trim): New.
* ggc.h (ggc_trim): Declare.

* lto.c (lto_wpa_write_files): Call ggc_trim.

From-SVN: r276878

5 years agore PR tree-optimization/92066 (Many vectorization tests FAIL)
Richard Biener [Fri, 11 Oct 2019 10:45:48 +0000 (10:45 +0000)]
re PR tree-optimization/92066 (Many vectorization tests FAIL)

2019-10-11  Richard Biener  <rguenther@suse.de>

PR tree-optimization/92066
PR tree-optimization/92046
* tree-vect-data-refs.c (vect_enhance_data_refs_alignment):
Fix bogus cost model check.

From-SVN: r276876

5 years ago[OpenMP,Fortran] Fix several OpenMP use_device_addr/map/update errors
Tobias Burnus [Fri, 11 Oct 2019 09:17:49 +0000 (09:17 +0000)]
[OpenMP,Fortran] Fix several OpenMP use_device_addr/map/update errors

gcc/fortran/
* f95-lang.c (LANG_HOOKS_OMP_IS_ALLOCATABLE_OR_PTR): Re-define to
gfc_omp_is_allocatable_or_ptr.
* trans-decl.c (create_function_arglist): Set GFC_DECL_OPTIONAL_ARGUMENT
only if not passed by value.
* trans-openmp.c (gfc_omp_is_allocatable_or_ptr): New.
(gfc_trans_omp_clauses): For MAP, handle (present) optional arguments;
for target update, handle allocatable/pointer scalars.
* trans.h (gfc_omp_is_allocatable_or_ptr): Declare.

gcc/
* langhooks-def.h (LANG_HOOKS_OMP_IS_ALLOCATABLE_OR_PTR): Define.
(LANG_HOOKS_DECLS): Add it.
* langhooks.h (lang_hooks_for_decls): Add omp_is_allocatable_or_ptr;
update comment for omp_is_optional_argument.
* omp-general.c (omp_is_allocatable_or_ptr): New.
* omp-general.h (omp_is_allocatable_or_ptr): Declare.
* omp-low.c (scan_sharing_clauses, lower_omp_target): Handle
Fortran's optional arguments and allocatable/pointer scalars
with use_device_addr.

libgomp/
* testsuite/libgomp.fortran/use_device_addr-1.f90: New.
* testsuite/libgomp.fortran/use_device_addr-2.f90: New.

From-SVN: r276875

5 years agodecl.c (elaborate_reference_1): Specifically deal with pointer displacement.
Eric Botcazou [Fri, 11 Oct 2019 09:17:23 +0000 (09:17 +0000)]
decl.c (elaborate_reference_1): Specifically deal with pointer displacement.

* gcc-interface/decl.c (elaborate_reference_1): Specifically deal with
pointer displacement.

* gcc-interface/decl.c (components_to_record): Use proper name.

* gcc-interface/trans.c (Sloc_to_locus): Use standard types.

From-SVN: r276874

5 years agodecl.c (gnat_to_gnu_field): Adjust again the packing for a field without strict align...
Eric Botcazou [Fri, 11 Oct 2019 09:09:40 +0000 (09:09 +0000)]
decl.c (gnat_to_gnu_field): Adjust again the packing for a field without strict alignment and with an...

* gcc-interface/decl.c (gnat_to_gnu_field): Adjust again the packing
for a field without strict alignment and with an oversized clause.

From-SVN: r276873

5 years agoS/390: Test signaling FP comparison instructions
Ilya Leoshkevich [Fri, 11 Oct 2019 09:03:00 +0000 (09:03 +0000)]
S/390: Test signaling FP comparison instructions

gcc/testsuite/ChangeLog:

2019-10-11  Ilya Leoshkevich  <iii@linux.ibm.com>

PR target/77918
* gcc.target/s390/s390.exp: Enable Fortran tests.
* gcc.target/s390/zvector/autovec-double-quiet-eq.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-ge.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-gt.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-le.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-lt.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-ordered.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-uneq.c: New test.
* gcc.target/s390/zvector/autovec-double-quiet-unordered.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-eq-z13-finite.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-eq-z13.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-eq.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-ge-z13-finite.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-ge-z13.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-ge.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-gt-z13-finite.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-gt-z13.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-gt.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-le-z13-finite.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-le-z13.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-le.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-lt-z13-finite.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-lt-z13.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-lt.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-ltgt-z13-finite.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-ltgt-z13.c: New test.
* gcc.target/s390/zvector/autovec-double-signaling-ltgt.c: New test.
* gcc.target/s390/zvector/autovec-double-smax-z13.F90: New test.
* gcc.target/s390/zvector/autovec-double-smax.F90: New test.
* gcc.target/s390/zvector/autovec-double-smin-z13.F90: New test.
* gcc.target/s390/zvector/autovec-double-smin.F90: New test.
* gcc.target/s390/zvector/autovec-float-quiet-eq.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-ge.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-gt.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-le.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-lt.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-ordered.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-uneq.c: New test.
* gcc.target/s390/zvector/autovec-float-quiet-unordered.c: New test.
* gcc.target/s390/zvector/autovec-float-signaling-eq.c: New test.
* gcc.target/s390/zvector/autovec-float-signaling-ge.c: New test.
* gcc.target/s390/zvector/autovec-float-signaling-gt.c: New test.
* gcc.target/s390/zvector/autovec-float-signaling-le.c: New test.
* gcc.target/s390/zvector/autovec-float-signaling-lt.c: New test.
* gcc.target/s390/zvector/autovec-float-signaling-ltgt.c: New test.
* gcc.target/s390/zvector/autovec-fortran.h: New test.
* gcc.target/s390/zvector/autovec-long-double-signaling-ge.c: New test.
* gcc.target/s390/zvector/autovec-long-double-signaling-gt.c: New test.
* gcc.target/s390/zvector/autovec-long-double-signaling-le.c: New test.
* gcc.target/s390/zvector/autovec-long-double-signaling-lt.c: New test.
* gcc.target/s390/zvector/autovec.h: New test.

From-SVN: r276872

5 years agoS/390: Use signaling FP comparison instructions
Ilya Leoshkevich [Fri, 11 Oct 2019 09:00:26 +0000 (09:00 +0000)]
S/390: Use signaling FP comparison instructions

dg-torture.exp=inf-compare-1.c is failing, because (qNaN > +Inf)
comparison is compiled to CDB instruction, which does not signal an
invalid operation exception. KDB should have been used instead.

This patch introduces a new CCmode and a new pattern in order to
generate signaling instructions in this and similar cases.

gcc/ChangeLog:

2019-10-11  Ilya Leoshkevich  <iii@linux.ibm.com>

PR target/77918
* config/s390/2827.md: Add new opcodes.
* config/s390/2964.md: Likewise.
* config/s390/3906.md: Likewise.
* config/s390/8561.md: Likewise.
* config/s390/s390-builtins.def (s390_vfchesb): Use
the new vec_cmpgev4sf_quiet_nocc.
(s390_vfchedb): Use the new vec_cmpgev2df_quiet_nocc.
(s390_vfchsb): Use the new vec_cmpgtv4sf_quiet_nocc.
(s390_vfchdb): Use the new vec_cmpgtv2df_quiet_nocc.
(vec_cmplev4sf): Use the new vec_cmplev4sf_quiet_nocc.
(vec_cmplev2df): Use the new vec_cmplev2df_quiet_nocc.
(vec_cmpltv4sf): Use the new vec_cmpltv4sf_quiet_nocc.
(vec_cmpltv2df): Use the new vec_cmpltv2df_quiet_nocc.
* config/s390/s390-modes.def (CCSFPS): New mode.
* config/s390/s390.c (s390_match_ccmode_set): Support CCSFPS.
(s390_select_ccmode): Return CCSFPS for LT, LE, GT, GE and LTGT.
(s390_branch_condition_mask): Reuse CCS for CCSFPS.
(s390_expand_vec_compare): Use non-signaling patterns where
necessary.
(s390_reverse_condition): Support CCSFPS.
* config/s390/s390.md (*cmp<mode>_ccsfps): New pattern.
* config/s390/vector.md: (VFCMP_HW_OP): Remove.
(asm_fcmp_op): Likewise.
(*smaxv2df3_vx): Use pattern for quiet comparison.
(*sminv2df3_vx): Likewise.
(*vec_cmp<VFCMP_HW_OP:code><mode>_nocc): Remove.
(*vec_cmpeq<mode>_quiet_nocc): New pattern.
(vec_cmpgt<mode>_quiet_nocc): Likewise.
(vec_cmplt<mode>_quiet_nocc): New expander.
(vec_cmpge<mode>_quiet_nocc): New pattern.
(vec_cmple<mode>_quiet_nocc): New expander.
(*vec_cmpeq<mode>_signaling_nocc): New pattern.
(*vec_cmpgt<mode>_signaling_nocc): Likewise.
(*vec_cmpgt<mode>_signaling_finite_nocc): Likewise.
(*vec_cmpge<mode>_signaling_nocc): Likewise.
(*vec_cmpge<mode>_signaling_finite_nocc): Likewise.
(vec_cmpungt<mode>): New expander.
(vec_cmpunge<mode>): Likewise.
(vec_cmpuneq<mode>): Use quiet patterns.
(vec_cmpltgt<mode>): Allow only on z14+.
(vec_cmpordered<mode>): Use quiet patterns.
(vec_cmpunordered<mode>): Likewise.
(VEC_CMP_EXPAND): Add ungt and unge.

gcc/testsuite/ChangeLog:

2019-10-11  Ilya Leoshkevich  <iii@linux.ibm.com>

* gcc.target/s390/vector/vec-scalar-cmp-1.c: Adjust
expectations.

From-SVN: r276871

5 years agoDo not allocate ggc during streaming.
Jan Hubicka [Fri, 11 Oct 2019 08:59:16 +0000 (10:59 +0200)]
Do not allocate ggc during streaming.

* gimple-streamer-out.c (output_gimple_stmt): Add explicit function
parameter.
* lto-streamer-out.c: Include tree-dfa.h.
(output_cfg): Do not use cfun.
(lto_prepare_function_for_streaming): New.
(output_function): Do not push cfun; do not initialize loop optimizer.
* lto-streamer.h (lto_prepare_function_for_streaming): Declare.
* passes.c (ipa_write_summaries): Use it.
(ipa_write_optimization_summaries): Do not modify bodies.
* tree-dfa.c (renumber_gimple_stmt_uids): Add function parameter.
* tree.dfa.h (renumber_gimple_stmt_uids): Update prototype.
* tree-ssa-dse.c (pass_dse::execute): Update use of
renumber_gimple_stmt_uids.
* tree-ssa-math-opts.c (pass_optimize_widening_mul::execute): Likewise.

* lto.c (lto_wpa_write_files): Prepare all bodies for streaming.

From-SVN: r276870

5 years agodecl.c (annotate_value): Really test the sign of the value when deciding to build...
Eric Botcazou [Fri, 11 Oct 2019 08:57:18 +0000 (08:57 +0000)]
decl.c (annotate_value): Really test the sign of the value when deciding to build a NEGATE_EXPR.

* gcc-interface/decl.c (annotate_value) <INTEGER_CST>: Really test the
sign of the value when deciding to build a NEGATE_EXPR.
<PLUS_EXPR>: Remove redundant line.
<BIT_AND_EXPR>: Do the negation here.

From-SVN: r276866

5 years agodecl.c (Gigi_Equivalent_Type): New case.
Eric Botcazou [Fri, 11 Oct 2019 08:33:03 +0000 (08:33 +0000)]
decl.c (Gigi_Equivalent_Type): New case.

* gcc-interface/decl.c (Gigi_Equivalent_Type) <E_Array_Subtype>: New
case.  Return the base type if the subtype is not constrained.

From-SVN: r276865

5 years agodecl.c (gnat_to_gnu_entity): New case to deal with the definition of named numbers.
Eric Botcazou [Fri, 11 Oct 2019 08:19:03 +0000 (08:19 +0000)]
decl.c (gnat_to_gnu_entity): New case to deal with the definition of named numbers.

* gcc-interface/decl.c (gnat_to_gnu_entity) <E_Named_{Integer|Real}>:
New case to deal with the definition of named numbers.
<E_Variable>: Minor tweaks.  Set DECL_IGNORED_P on the CONST_DECL
if a corresponding variable is built.
* gcc-interface/trans.c (gnat_to_gnu) <N_Integer_Literal>: Return
error_mark_node instead of aborting on overflow for named numbers.
<N_Number_Declaration>: Reuse the <N_Object_Declaration> case and
deal with error_mark_node specifically.
* gcc-interface/utils.c (create_var_decl): Do not set DECL_IGNORED_P
on CONST_DECLs.
(gnat_write_global_declarations): Output global constants.

From-SVN: r276864

5 years ago[Ada] Repair ChangeLog entries
Pierre-Marie de Rodat [Fri, 11 Oct 2019 07:56:41 +0000 (07:56 +0000)]
[Ada] Repair ChangeLog entries

My scripts and I unexpectedly erased gcc/ada/ChangeLog yesterday. This
commit restores the ChangeLog file to its previous state and adds the
entries for my commits yesterday.

From-SVN: r276861

5 years agore PR c++/91987 (-fstrict-eval-order issues)
Jakub Jelinek [Fri, 11 Oct 2019 07:36:07 +0000 (09:36 +0200)]
re PR c++/91987 (-fstrict-eval-order issues)

PR c++/91987
cp/
* decl2.c (grok_array_decl): For -fstrong-eval-order, when array ref
operands have been swapped and at least one operand has side-effects,
revert the swapping before calling build_array_ref.
* typeck.c (cp_build_array_ref): For non-ARRAY_TYPE array ref with
side-effects on the index operand, if -fstrong-eval-order use
save_expr around the array operand.
(cp_build_binary_op): For shifts with side-effects in the second
operand, wrap first operand into SAVE_EXPR and evaluate it before
the shift.
* semantics.c (handle_omp_array_sections_1): Temporarily disable
flag_strong_eval_order during OMP_CLAUSE_REDUCTION array section
processing.
* cp-gimplify.c (gimplify_to_rvalue): New function.
(cp_gimplify_expr): Use it.
testsuite/
* g++.dg/cpp1z/eval-order6.C: New test.
* g++.dg/cpp1z/eval-order7.C: New test.
* g++.dg/cpp1z/eval-order8.C: New test.
* c-c++-common/gomp/pr91987.c: New test.

From-SVN: r276860

5 years agovec_promote_demote cost to 1 for non-Power7 VSX architectures
Kewen Lin [Fri, 11 Oct 2019 06:01:30 +0000 (06:01 +0000)]
vec_promote_demote cost to 1 for non-Power7 VSX architectures

2019-10-11  Kewen Lin  <linkw@gcc.gnu.org>

    * config/rs6000/rs6000.c (rs6000_builtin_vectorization_cost): Lower
    vec_promote_demote cost to 1 for non-Power7 VSX architectures.

From-SVN: r276859

5 years agoDaily bump.
GCC Administrator [Fri, 11 Oct 2019 00:16:43 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r276858

5 years agoUpdate DFP macros in float.h for C2x and TS 18661-2.
Joseph Myers [Thu, 10 Oct 2019 22:54:33 +0000 (23:54 +0100)]
Update DFP macros in float.h for C2x and TS 18661-2.

GCC's <float.h> includes various macros for decimal floating-point
types, defined if __STDC_WANT_DEC_FP__, as defined in TS 24732.

TS 18661-2 and C2X make some changes to those macros.  In TS 18661-2,
they are to be defined if __STDC_WANT_IEC_60559_DFP_EXT__, and the
*_SUBNORMAL_MIN macros are renamed to *_TRUE_MIN.  In C2X, the macros
are to be defined whenever DFP is supported, without needing any
feature test macro to be defined.

This patch updates the header accordingly.  There is no existing
predefined macro for whether the target supports DFP; rather than
adding a new macro for that purpose, this patch changes the predefined
macros used in <float.h> so that they are only defined when DFP is
supported and thus can be used as conditionals; this is the same way
predefined macros for _FloatN and _FloatNx types work.  Although
formally TR 24732 and TS 18661-2 say nothing about implementations
lacking DFP support, it seems appropriate to avoid defining the macros
in <float.h>, in the absence of DFP support, even if the respective
feature test macros are defined.

Bootstrapped with no regressions on x86_64-pc-linux-gnu.  Also tested
the c2x-float-no-dfp-* tests for aarch64-linux-gnu to make sure they
do pass in a no-DFP configuration.

gcc:
* ginclude/float.h [!__DEC32_MANT_DIG__]: Do not define DFP
macros.
[__STDC_WANT_IEC_60559_DFP_EXT__ || __STDC_VERSION__ > 201710L]:
Also define DFP macros for these conditions.
[!__STDC_WANT_DEC_FP__] (DEC32_SUBNORMAL_MIN, DEC64_SUBNORMAL_MIN,
DEC128_SUBNORMAL_MIN): Do not define.
[__STDC_WANT_IEC_60559_DFP_EXT__ || __STDC_VERSION__ > 201710L]
(DEC32_TRUE_MIN, DEC64_TRUE_MIN, DEC128_TRUE_MIN): New macros.

gcc/c-family:
* c-cppbuiltin.c (c_cpp_builtins): Do not define macros for DFP
types if DFP not supported.

gcc/testsuite:
* gcc.dg/c11-float-dfp-1.c, gcc.dg/c2x-float-no-dfp-1.c,
gcc.dg/c2x-float-no-dfp-2.c, gcc.dg/dfp/c2x-float-dfp-1.c,
gcc.dg/dfp/c2x-float-dfp-2.c, gcc.dg/dfp/c2x-float-dfp-3.c,
gcc.dg/dfp/tr24732-float-dfp-1.c,
gcc.dg/dfp/ts18661-2-float-dfp-1.c: New tests.

From-SVN: r276854

5 years agore PR middle-end/26241 (None of the IPA passes are documented in passes.texi)
Xiong Hu Luo [Thu, 10 Oct 2019 19:44:26 +0000 (19:44 +0000)]
re PR middle-end/26241 (None of the IPA passes are documented in passes.texi)

2019-10-10  Xiong Hu Luo  <luoxhu@linux.ibm.com>
    Sandra Loosemore  <sandra@codesourcery.com>

gcc/

PR middle-end/26241
* doc/lto.texi (IPA): Reference to the IPA passes.
* doc/passes.texi (Pass manager): Add node IPA passes and
  description for each IPA pass.

Co-Authored-By: Sandra Loosemore <sandra@codesourcery.com>
From-SVN: r276851

5 years agoipa-reference.c: Do not include splay-tree.h
Jan Hubicka [Thu, 10 Oct 2019 19:31:58 +0000 (21:31 +0200)]
ipa-reference.c: Do not include splay-tree.h

* ipa-reference.c: Do not include splay-tree.h
(reference_vars_to_consider): Turn to hash map.
(get_static_name, ipa_init, analyze_function, propagate,
stream_out_bitmap, ipa_reference_write_optimization_summary,
ipa_reference_write_optimization_summary): Update.

From-SVN: r276850

5 years ago* ipa-reference.c (propagate): Fix releasing of IPA summaries.
Jan Hubicka [Thu, 10 Oct 2019 19:20:01 +0000 (21:20 +0200)]
* ipa-reference.c (propagate): Fix releasing of IPA summaries.

From-SVN: r276849

5 years ago[Darwin, machopic 4/n] Arrange to indirect IVARs when needed.
Iain Sandoe [Thu, 10 Oct 2019 19:14:07 +0000 (19:14 +0000)]
[Darwin, machopic 4/n] Arrange to indirect IVARs when needed.

Objective C V2 (m64) IVAR offset refs from Apple GCC-4.x have an indirection
for m64 code on PPC (which is the only 64b user for Mach-O PIC).  Apple GCC
4.x places the indirections in the .data section, however this seems to have
been unintentional - and we are placing the indirections in the non-lazy
symbol pointers section.

gcc/ChangeLog:

2019-10-10  Iain Sandoe  <iain@sandoe.co.uk>

* config/darwin.c: Lookup Objective C metadata and force indirection
for IVAR refs.

From-SVN: r276848

5 years ago[Objective-C, NeXT ABI] Identify V2 IVAR refs by metadata.
Iain Sandoe [Thu, 10 Oct 2019 19:04:33 +0000 (19:04 +0000)]
[Objective-C, NeXT ABI]  Identify V2 IVAR refs by metadata.

For the NeXT 64b ABI, IVAR refs are supposed to be indirected for
Mach-O PIC.  Identify them so that we can act as needed.

gcc/objc/ChangeLog:

2019-10-10  Iain Sandoe  <iain@sandoe.co.uk>

* objc-next-metadata-tags.h (OCTI_RT_META_IVAR_REF): New.
(meta_ivar_ref): New.
* objc-next-runtime-abi-02.c
(next_runtime_abi_02_init_metadata_attributes): Create the
IVAR ref metadata identifier.
(ivar_offset_ref): Tag IVAR refs with specific metadata.

From-SVN: r276847

5 years agoAdd check for prefixed addresses.
Michael Meissner [Thu, 10 Oct 2019 18:54:50 +0000 (18:54 +0000)]
Add check for prefixed addresses.

2019-10-10  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/rs6000.c (quad_address_p): Add check for prefixed
addresses.
(mem_operand_gpr): Add check for prefixed addresses.
(mem_operand_ds_form): Add check for prefixed addresses.
(rs6000_legitimate_offset_address_p): If we support prefixed
addresses, check for a 34-bit offset instead of 16-bit.
(rs6000_legitimate_address_p): Add check for prefixed addresses.
Do not allow load/store with update if the address is prefixed.
(rs6000_mode_dependent_address):  If we support prefixed
addresses, check for a 34-bit offset instead of 16-bit.

From-SVN: r276846

5 years agoDocumentation hyperlinks for [-Wname-of-option] (PR 87488)
David Malcolm [Thu, 10 Oct 2019 17:03:46 +0000 (17:03 +0000)]
Documentation hyperlinks for [-Wname-of-option] (PR 87488)

This patch uses the support for pretty-printing escaped URLs added in
the previous patch (PR 87488) so that in a sufficiently capable terminal
the [-Wname-of-option] emitted at the end of each diagnostic becomes a
hyperlink to the documentation for that option on the GCC website.

I've tested it with Fedora 30's GNOME Terminal (3.32.2 with VTE 0.56.3);
the option text is printed with a dotted underline, hovering shows the
URL, and on right-clicking it offers menu items to visit/copy the URL.

gcc/ChangeLog:
PR 87488
* Makefile.in (CFLAGS-opts.o): Pass in DOCUMENTATION_ROOT_URL via
-D.
* configure.ac (--with-documentation-root-url): New option.
* configure: Regenerate.
* diagnostic-format-json.cc (json_end_diagnostic): If there is an
option URL, add it as a new string field of the diagnostic option.
* diagnostic.c (diagnostic_initialize): Initialize get_option_url.
(print_option_information): If get_option_url is non-NULL, call
it, and if the result is non-NULL, potentially emit an escape
sequence to markup the option text with the resulting URL.
* diagnostic.h (diagnostic_context::get_option_url): New callback.
* doc/invoke.texi (-fdiagnostics-format=): Add "option_url" to
example of JSON output.
* opts-diagnostic.h (get_option_url): New decl.
* opts.c (get_option_url): New function.
* toplev.c (general_init): Initialize the get_option_url callback.

gcc/testsuite/ChangeLog:
PR 87488
* c-c++-common/diagnostic-format-json-2.c: Expect an "option_url"
field.
* c-c++-common/diagnostic-format-json-3.c: Likewise.
* gfortran.dg/diagnostic-format-json-2.F90: Likewise.
* gfortran.dg/diagnostic-format-json-3.F90: Likewise.
* jit.dg/test-error-array-bounds.c (create_code): Ensure that
error messages don't contain escaped URLs.

From-SVN: r276843

5 years ago[PATCH 1/3] S/390: Do not use signaling vector comparisons on z13
Ilya Leoshkevich [Thu, 10 Oct 2019 17:00:29 +0000 (17:00 +0000)]
[PATCH 1/3] S/390: Do not use signaling vector comparisons on z13

z13 supports only non-signaling vector comparisons.  This means we
cannot vectorize LT, LE, GT, GE and LTGT when compiling for z13.  Notify
middle-end about this by using more restrictive operator predicate in
vcond<V_HW:mode><V_HW2:mode>.

gcc/ChangeLog:

2019-10-10  Ilya Leoshkevich  <iii@linux.ibm.com>

PR target/77918
* config/s390/vector.md (vcond_comparison_operator): New
predicate.
(vcond<V_HW:mode><V_HW2:mode>): Use vcond_comparison_operator.

From-SVN: r276842

5 years agopretty-print: support URL escape sequences (PR 87488)
David Malcolm [Thu, 10 Oct 2019 16:57:30 +0000 (16:57 +0000)]
pretty-print: support URL escape sequences (PR 87488)

https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda
describes an emerging standard for embedding URLs in escape sequences
for marking up text output.  This is supported e.g. by recent releases
of GNOME Terminal.

This patch adds support to our pretty-printing framework for emitting
URLs.

A followup patch uses this to add URLs to the pertinent documentation
for the output of -fdiagnostics-show-option.

gcc/ChangeLog:
PR 87488
* common.opt (fdiagnostics-urls=): New option.
(diagnostic-url.h): Add SourceInclude.
(diagnostic_url_rule): New enum.
* diagnostic-color.c: Include "diagnostic-url.h".
(diagnostic_urls_enabled_p): New function.
* diagnostic-url.h: New file.
* diagnostic.c: Include "diagnostic-url.h".
(diagnostic_urls_init): New function.
* diagnostic.h (diagnostic_urls_init): New decl.
* doc/invoke.texi (Diagnostic Message Formatting Options): Add
-fdiagnostics-urls to the list.
(-fdiagnostics-urls): New option.
* gcc.c (driver_handle_option): Handle OPT_fdiagnostics_urls_.
(driver::global_initializations): Call diagnostic_urls_init.
* opts-global.c (init_options_once): Likewise.
* opts.c (common_handle_option): Handle OPT_fdiagnostics_urls_.
* pretty-print.c (pretty_printer::pretty_printer): Initialize
show_urls.
(pp_begin_url): New function.
(pp_end_url): New function.
(selftest::test_urls): New selftest.
(selftest::pretty_print_c_tests): Call it.
* pretty-print.h (pretty_printer::show_urls): New field.
(pp_begin_url): New decl.
(pp_end_url): New decl.

gcc/testsuite/ChangeLog:
PR 87488
* lib/prune.exp (TEST_ALWAYS_FLAGS): Add -fdiagnostics-urls=never.

From-SVN: r276841

5 years agoPR libstdc++/91057 fix bootstrap failure on powerpc
Jonathan Wakely [Thu, 10 Oct 2019 16:16:17 +0000 (17:16 +0100)]
PR libstdc++/91057 fix bootstrap failure on powerpc

PR libstdc++/91057
* src/c++98/locale.cc [_GLIBCXX_LONG_DOUBLE_COMPAT]
(find_ldbl_sync_facet): Fix parameter type and missing return.

From-SVN: r276840

5 years agore PR target/92022 (ICE in alpha_handle_trap_shadows, at config/alpha/alpha.c:8847)
Uros Bizjak [Thu, 10 Oct 2019 16:11:10 +0000 (18:11 +0200)]
re PR target/92022 (ICE in alpha_handle_trap_shadows, at config/alpha/alpha.c:8847)

PR target/92022
* config/alpha/alpha.c (alpha_handle_trap_shadows): Skip DEBUG_INSN.

testsuite/ChangeLog:

PR target/92022
* g++.dg/pr92022.C: New test.

From-SVN: r276839

5 years ago[Ada] Handling up-level references in loops within library-level declarations
Gary Dismukes [Thu, 10 Oct 2019 15:25:36 +0000 (15:25 +0000)]
[Ada] Handling up-level references in loops within library-level declarations

2019-10-10  Gary Dismukes  <dismukes@adacore.com>

gcc/ada/

* exp_ch7.adb (Check_Unnesting_In_Decls_Or_Stmts): When
encountering a loop at the top level of a package declaration
list (that is, within the declarations of a package spec or
body) that has nested subprograms, call Unnest_Loop to create a
new library-level procedure that will contain the loop, to allow
for proper handling of up-level references from within nested
subprograms, such as to loop parameters.
(Unnest_Loop): New procedure that takes a loop statement and
creates a new procedure body to enclose the loop statement,
along with generating a call to the procedure.

From-SVN: r276836

5 years ago[Ada] Ensure constructor is a C++ constructor
Arnaud Charlet [Thu, 10 Oct 2019 15:25:32 +0000 (15:25 +0000)]
[Ada] Ensure constructor is a C++ constructor

2019-10-10  Arnaud Charlet  <charlet@adacore.com>

gcc/ada/

* freeze.adb (Freeze_Subprogram): Ensure constructor is a C++
constructor.

From-SVN: r276835

5 years ago[Ada] Add pragma Preelaborable_Initialization to Stream_IO.File_Type
Gary Dismukes [Thu, 10 Oct 2019 15:25:27 +0000 (15:25 +0000)]
[Ada] Add pragma Preelaborable_Initialization to Stream_IO.File_Type

2019-10-10  Gary Dismukes  <dismukes@adacore.com>

gcc/ada/

* libgnat/a-ststio.ads (File_Type): Apply pragma
Preelaborable_Initialization to the type.

From-SVN: r276834

5 years ago[Ada] Fix inlining of subprograms with deep param/result in GNATprove
Yannick Moy [Thu, 10 Oct 2019 15:25:22 +0000 (15:25 +0000)]
[Ada] Fix inlining of subprograms with deep param/result in GNATprove

2019-10-10  Yannick Moy  <moy@adacore.com>

gcc/ada/

* inline.adb (Can_Be_Inlined_In_GNATprove_Mode): Do not peek
under private types whose completion is SPARK_Mode Off.

From-SVN: r276833

5 years ago[Ada] Various minor typo fixes
Gary Dismukes [Thu, 10 Oct 2019 15:25:18 +0000 (15:25 +0000)]
[Ada] Various minor typo fixes

2019-10-10  Gary Dismukes  <dismukes@adacore.com>

gcc/ada/

* exp_ch4.adb, sem_cat.adb, sem_ch12.adb, sem_ch3.adb,
sem_ch6.adb, sem_prag.adb, sem_util.adb, sem_util.ads: Minor
typo fixes.

From-SVN: r276832

5 years ago[Ada] Spurious warning on call with out parameter in expression function
Ed Schonberg [Thu, 10 Oct 2019 15:25:13 +0000 (15:25 +0000)]
[Ada] Spurious warning on call with out parameter in expression function

2019-10-10  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_warn.adb (Warn_On_Useless_Assignment): Do not warn if the
second assignment is at the same source position as the first.

From-SVN: r276831

5 years ago[Ada] Unnesting issues with entry families and accept statements
Gary Dismukes [Thu, 10 Oct 2019 15:25:08 +0000 (15:25 +0000)]
[Ada] Unnesting issues with entry families and accept statements

2019-10-10  Gary Dismukes  <dismukes@adacore.com>

gcc/ada/

* sem_util.adb (Enclosing_Subprogram): Handle the case of
E_Entry_Family, returning the entry family's associated
Protected_Body_Subprogram (as was already done for E_Entry).
* exp_ch9.adb (Expand_N_Accept_Statement): Call Reset_Scopes_To
on the block created for an accept statement to reset the scopes
of any local entities to the block scope.

From-SVN: r276830

5 years ago[Ada] Spurious visibility error on formal package with Abstract_State
Ed Schonberg [Thu, 10 Oct 2019 15:25:03 +0000 (15:25 +0000)]
[Ada] Spurious visibility error on formal package with Abstract_State

2019-10-10  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_ch12.adb (Analyze_Formal_Package_Declaration): Propagate
an aspect specification for Abstract_State from generic package
to formal package, so that it is available when analyzing the
constructed formal.

From-SVN: r276829

5 years ago[Ada] Fix awkward placement of freeze node for actual subtype
Eric Botcazou [Thu, 10 Oct 2019 15:24:38 +0000 (15:24 +0000)]
[Ada] Fix awkward placement of freeze node for actual subtype

2019-10-10  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* sem_ch6.adb (Set_Actual_Subtypes): Put the freeze node of the
actual subtype after its declaration when the type of the formal
has a predicate.

From-SVN: r276828

5 years ago[Ada] Get rid of spurious error for _Tag on extension with reverse bit order
Eric Botcazou [Thu, 10 Oct 2019 15:24:26 +0000 (15:24 +0000)]
[Ada] Get rid of spurious error for _Tag on extension with reverse bit order

2019-10-10  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* sem_ch13.adb (Adjust_Record_For_Reverse_Bit_Order): Do not use
the Esize of the component to compute its layout, but only the
Component_Clause.  Do not issue a warning for the _Tag
component.  Also set the Esize of the component at the end of
the layout.
(Analyze_Record_Representation_Clause): Remove Hbit local
variable.  Lay out the Original_Record_Component only if it's
distinct from the component.
(Check_Record_Representation_Clause): Fix off-by-one bug for the
Last_Bit of the artificial clause built for the _Tag component.

From-SVN: r276827

5 years ago[Ada] Debug procedure for printing ancestors
Bob Duff [Thu, 10 Oct 2019 15:24:06 +0000 (15:24 +0000)]
[Ada] Debug procedure for printing ancestors

2019-10-10  Bob Duff  <duff@adacore.com>

gcc/ada/

* treepr.ads, treepr.adb (ppar): New procedure.

From-SVN: r276826

5 years ago[Ada] 'others' in conditional_expressions
Bob Duff [Thu, 10 Oct 2019 15:24:01 +0000 (15:24 +0000)]
[Ada] 'others' in conditional_expressions

2019-10-10  Bob Duff  <duff@adacore.com>

gcc/ada/

* sem_aggr.adb (Resolve_Aggregate): Add missing cases in the
Others_Allowed => True case -- N_Case_Expression_Alternative and
N_If_Expression.  Use Nkind_In.
* atree.adb, atree.ads, sinfo.adb, sinfo.ads (Nkind_In): New
16-parameter version.

From-SVN: r276824

5 years ago[Ada] Missing Predicated_Parent link on array Itype
Ed Schonberg [Thu, 10 Oct 2019 15:23:56 +0000 (15:23 +0000)]
[Ada] Missing Predicated_Parent link on array Itype

2019-10-10  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_aggr.adb (Resolve_Array_Aggregate): Set properly the
Predicated_Parent link of an itype created for an aggregate, so
that the predicate_function of the parent can support proofs on
the object that it initializes.

From-SVN: r276823

5 years ago[Ada] Plug minor loophole for integer named number
Eric Botcazou [Thu, 10 Oct 2019 15:23:51 +0000 (15:23 +0000)]
[Ada] Plug minor loophole for integer named number

2019-10-10  Eric Botcazou  <ebotcazou@adacore.com>

gcc/ada/

* sem_ch3.adb (Analyze_Number_Declaration): Set
Debug_Info_Needed in the case where the expression is an integer
literal.

From-SVN: r276822

5 years ago[Ada] Do not inline subprograms with deep parameter/result in GNATprove
Yannick Moy [Thu, 10 Oct 2019 15:23:47 +0000 (15:23 +0000)]
[Ada] Do not inline subprograms with deep parameter/result in GNATprove

2019-10-10  Yannick Moy  <moy@adacore.com>

gcc/ada/

* inline.adb (Can_Be_Inlined_In_GNATprove_Mode): Add subprograms
with deep parameter or result type as not candidates for
inlining.

From-SVN: r276821

5 years ago[Ada] Define default value for Process field
Vadim Godunko [Thu, 10 Oct 2019 15:23:42 +0000 (15:23 +0000)]
[Ada] Define default value for Process field

2019-10-10  Vadim Godunko  <godunko@adacore.com>

gcc/ada/

* libgnat/g-exptty.ads (TTY_Process_Descriptor): Set default
value for Process.

From-SVN: r276820

5 years ago[Ada] T'Size in pragma Compile_Time_Error
Bob Duff [Thu, 10 Oct 2019 15:23:37 +0000 (15:23 +0000)]
[Ada] T'Size in pragma Compile_Time_Error

2019-10-10  Bob Duff  <duff@adacore.com>

gcc/ada/

* sem_prag.adb (Defer_Compile_Time_Warning_Error_To_BE): In
addition to saving the pragma for further processing, copy the
pragma into the main unit if necessary.

From-SVN: r276819

5 years ago[Ada] Assertion_Policy (Ignore) ignores invariants
Bob Duff [Thu, 10 Oct 2019 15:23:33 +0000 (15:23 +0000)]
[Ada] Assertion_Policy (Ignore) ignores invariants

2019-10-10  Bob Duff  <duff@adacore.com>

gcc/ada/

* einfo.ads, einfo.adb (Invariants_Ignored): New flag on types.
This leaves just one unused flag.
* sem_prag.adb (Invariant): Set the flag if appropriate.
* exp_util.adb (Make_Invariant_Call): Check the flag.

From-SVN: r276818

5 years ago[Ada] Fix handling of -gnatceg on incomplete unit
Arnaud Charlet [Thu, 10 Oct 2019 15:23:28 +0000 (15:23 +0000)]
[Ada] Fix handling of -gnatceg on incomplete unit

2019-10-10  Arnaud Charlet  <charlet@adacore.com>

gcc/ada/

* gnat1drv.adb (Gnat1drv): Skip code generation when handling an
incomplete unit with -gnatceg.

From-SVN: r276817

5 years ago[Ada] Generation of procedures for blocks occurring in elaboration code for LLVM
Gary Dismukes [Thu, 10 Oct 2019 15:23:24 +0000 (15:23 +0000)]
[Ada] Generation of procedures for blocks occurring in elaboration code for LLVM

2019-10-10  Gary Dismukes  <dismukes@adacore.com>

gcc/ada/

* exp_ch7.adb (Check_Unnesting_Elaboration_Code): Various
cleanups.
(Set_Elab_Proc): New procedure to create the defining identifier
for a procedure created to encapsulate top-level blocks
occurring as a part of library package elaboration.
(First_Local_Scope): Function replaced by
Reset_Scopes_To_Elab_Proc.
(Reset_Scopes_To_Elab_Proc): New recursive procedure based on
First_Local_Scope, which it replaces, that is called to traverse
the statements of a library package body to locate top-level
blocks and determine whether they contain nested subprograms
that might address library-level objects of the package. Such
blocks (and loops) and certain top-level subprograms within the
statements will have their Scope reset here to match an
encapsulating procedure created by
Check_Unnesting_Elaboration_Code that will contain the
statements.
(Check_Unnesting_In_Decls_Or_Stmts): Code for handling blocks
factored out into Unnest_Block. Add handling for package
declarations and bodies, making recursive calls for
visible/private declarations, body declarations, statements, and
exception handlers. Also remove test for Is_Compilation_Unit:
caller tests for Is_Library_Level_Entity instead.  Also, this
proc's name was changed from Check_Unnesting_In_Declarations.
(Check_Unnesting_In_Handlers): New procedure to traverse a
sequence of exception handlers, calling
Check_Unnesting_In_Decls_Or_Stmts on the statements of each
handler.
(Expand_N_Package_Body): Call Check_Unnesting_* routines only
when Unnest_Subprogram_Mode is set and the current scope is a
library-level entity (which includes packages and instantiations
nested directly within a library unit).
(Expand_N_Package_Declaration): Call Check_Unnesting_* routines
only when Unnest_Subprogram_Mode is set and the current scope is
a library-level entity (which includes packages and
instantiations nested directly within a library unit).
(Unnest_Block): New procedure factored out of
Check_Unnesting_In_Decls_Or_Stmts, for creating a new procedure
to replace a block statement and resetting the Scope fields of
the block's top-level entities.

From-SVN: r276816

5 years ago[Ada] Mention GNAT Studio instead of GPS
Anthony Leonardo Gracio [Thu, 10 Oct 2019 15:23:19 +0000 (15:23 +0000)]
[Ada] Mention GNAT Studio instead of GPS

2019-10-10  Anthony Leonardo Gracio  <leonardo@adacore.com>

gcc/ada/

* doc/gnat_ugn/about_this_guide.rst,
doc/gnat_ugn/building_executable_programs_with_gnat.rst,
doc/gnat_ugn/getting_started_with_gnat.rst,
doc/gnat_ugn/gnat_and_program_execution.rst, errout.ads,
exp_ch3.adb, gnatls.adb, impunit.adb, lib-writ.ads, opt.ads,
sem_ch7.adb, sem_prag.adb, sem_res.adb, sem_warn.adb,
terminals.c: Replace GPS by GNAT Studio.
* gnat_ugn.texi: Regenerate.

From-SVN: r276815

5 years ago[Ada] Spurious restriction violation on Ghost code
Ed Schonberg [Thu, 10 Oct 2019 15:23:14 +0000 (15:23 +0000)]
[Ada] Spurious restriction violation on Ghost code

2019-10-10  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* exp_ch6.adb (Expand_Simple_Function_Return_Statement): If the
function to which the return statement applies is an
Ignored_Ghost_Function, do not indicate that it uses the
secondary stack when the return type is unconstrained.

From-SVN: r276814

5 years ago[Ada] Replace in Ordered_Maps gets tampering failure
Bob Duff [Thu, 10 Oct 2019 15:23:08 +0000 (15:23 +0000)]
[Ada] Replace in Ordered_Maps gets tampering failure

2019-10-10  Bob Duff  <duff@adacore.com>

gcc/ada/

* libgnat/a-cbdlli.adb, libgnat/a-cbhama.adb,
libgnat/a-cbhase.adb, libgnat/a-cbmutr.adb,
libgnat/a-cborma.adb, libgnat/a-cborse.adb,
libgnat/a-cdlili.adb, libgnat/a-cidlli.adb,
libgnat/a-cihama.adb, libgnat/a-cihase.adb,
libgnat/a-cimutr.adb, libgnat/a-ciorma.adb,
libgnat/a-ciorse.adb, libgnat/a-cobove.adb,
libgnat/a-cohama.adb, libgnat/a-cohase.adb,
libgnat/a-coinve.adb, libgnat/a-comutr.adb,
libgnat/a-conhel.adb, libgnat/a-convec.adb,
libgnat/a-coorma.adb, libgnat/a-coorse.adb (Reference,
Constant_Reference): Use Busy instead of Lock, so we forbid
tampering with cursors, rather than tampering with elements.

From-SVN: r276813

5 years ago[Ada] Spurious visibility error in predicate in generic instance
Ed Schonberg [Thu, 10 Oct 2019 15:23:01 +0000 (15:23 +0000)]
[Ada] Spurious visibility error in predicate in generic instance

2019-10-10  Ed Schonberg  <schonberg@adacore.com>

gcc/ada/

* sem_cat.adb (Set_Categorization_From_Pragma): Do not modify
any visibility settings if there are no compilation_unit pragmas
following the package declaration. Add comments for future
cleanup.

From-SVN: r276812

5 years ago[Ada] Flag Sec_Stack_Used incorrectly set by ghost code
Patrick Bernardi [Thu, 10 Oct 2019 15:22:55 +0000 (15:22 +0000)]
[Ada] Flag Sec_Stack_Used incorrectly set by ghost code

2019-10-10  Patrick Bernardi  <bernardi@adacore.com>

gcc/ada/

* bindgen.adb (System_Secondary_Stack_Package_In_Closure):
Renamed flag System_Secondary_Stack_Used to be clearer of what
it represents.
(Gen_Adainit): Refactor secondary stack related code to make it
clearer.
* rtsfind.adb (Load_RTU): Don't set Sec_Stack_Used flag here
(RTE): Set Sec_Stack_Used if the System.Secondary_Stack is
referenced, but not if we're ignoring ghost code.

From-SVN: r276811

5 years ago[Ada] Use declared type for deciding on SPARK pointer rules
Piotr Trojanek [Thu, 10 Oct 2019 15:22:38 +0000 (15:22 +0000)]
[Ada] Use declared type for deciding on SPARK pointer rules

2019-10-10  Piotr Trojanek  <trojanek@adacore.com>

gcc/ada/

* sem_prag.adb (Analyze_Global_In_Decl_Part): Simplify previous
test, just like in a recent commit we simplified a similar test
for Depends contract.

From-SVN: r276810

5 years agore PR target/88630 (Incorrect float negating together with convertion to int on ST-40)
Oleg Endo [Thu, 10 Oct 2019 15:21:27 +0000 (15:21 +0000)]
re PR target/88630 (Incorrect float negating together with convertion to int on ST-40)

gcc/
PR target/88630
* config/sh/sh.h (TARGET_FPU_SH4_300): New macro.
* config/sh/sh.c (sh_option_override): Enable fsca and fsrra insns
also for TARGET_FPU_SH4_300.
(sh_emit_mode_set): Check for TARGET_FPU_SH4_300 instead of
TARGET_SH4_300.
* config/sh/sh.md (toggle_pr): Add TARGET_FPU_SH4_300 condition.
(negsf2): Expand to either negsf2_fpscr or negsf2_no_fpscr.
(*negsf2_i): Split into ...
(negsf2_fpscr, negsf2_no_fpscr): ... these new patterns.
(abssf2): Expand to either abssf2_fpsc or abssf2_no_fpsc.
(**abssf2_i): Split into ...
(abssf2_fpscr, abssf2_no_fpscr): ... these new patterns.
(negdf2): Expand to either negdf2_fpscr or negdf2_no_fpscr.
(*negdf2_i): Split into ...
(negdf2_fpscr, negdf2_no_fpscr): ... these new patterns.
(absdf2): Expand to either absdf2_fpscr or absdf2_no_fpsc.
(**abssf2_i): Split into ...
(absdf2_fpscr, absdf2_no_fpscr): ... these new patterns.

From-SVN: r276809

5 years agoMake comp_ptr_ttypes_real return bool.
Marek Polacek [Thu, 10 Oct 2019 14:37:36 +0000 (14:37 +0000)]
Make comp_ptr_ttypes_real return bool.

comp_ptr_ttypes_real could use bool instead of int since it only returns
0 or 1.

* typeck.c (comp_ptr_ttypes_real): Change the return type to bool.
Use false instead of 0.

From-SVN: r276808

5 years agore PR middle-end/92046 (Command line options (that are per-functions) are affecting...
Richard Biener [Thu, 10 Oct 2019 14:02:25 +0000 (14:02 +0000)]
re PR middle-end/92046 (Command line options (that are per-functions) are affecting --params which are global.)

2019-10-10  Richard Biener  <rguenther@suse.de>

PR middle-end/92046
* opts.c (finish_options): Do not influence global --params
from options that are adjustable per function.
* tree-vect-data-refs.c (vect_enhance_data_refs_alignment):
Apply --param adjustment based on active cost-model.
* tree-ssa-phiopt.c (cond_if_else_store_replacement): Disable
further store-sinking when vectorization or if-conversion
are not enabled.

From-SVN: r276807

5 years agore PR middle-end/92037 (LTO bootstrap broken in selftests)
Jan Hubicka [Thu, 10 Oct 2019 13:04:44 +0000 (15:04 +0200)]
re PR middle-end/92037 (LTO bootstrap broken in selftests)

PR middle-end/92037
* cgraph.c (symbol_table_test::symbol_table_test): Use ggc_alloc
rather than ggc_alloc_cleared to alloc symbol table.
* toplev.c (general_init): Likewise.
* cgraph.h (symbol_table): Explicitly construct every field.

From-SVN: r276804

5 years agolto-common.c (unify_scc): Do not merge anonymous NAMESPACE_DECLs.
Richard Biener [Thu, 10 Oct 2019 09:56:35 +0000 (09:56 +0000)]
lto-common.c (unify_scc): Do not merge anonymous NAMESPACE_DECLs.

2019-10-10  Richard Biener  <rguenther@suse.de>

* lto-common.c (unify_scc): Do not merge anonymous NAMESPACE_DECLs.

From-SVN: r276796

5 years agoS/390: Add support for z15 as CPU name.
Andreas Krebbel [Thu, 10 Oct 2019 09:04:02 +0000 (09:04 +0000)]
S/390: Add support for z15 as CPU name.

So far z15 was identified as arch13. After the machine has been
announced we can now add the real name.

gcc/ChangeLog:

2019-10-10  Andreas Krebbel  <krebbel@linux.ibm.com>

* common/config/s390/s390-common.c (PF_ARCH13): Rename to...
(PF_Z15): ... this.
* config.gcc: Add z15 as option for --with-arch and --with-tune
configure switches.
* config/s390/s390-c.c (s390_resolve_overloaded_builtin): Add
error reporting for unsupported builtins.
* config/s390/s390-opts.h (enum processor_type): Rename
PROCESSOR_8561_ARCH13 to PROCESSOR_8561_Z15.
* config/s390/8561.md: Rename arch13 to z15 throughout the file.
* config/s390/driver-native.c (s390_host_detect_local_cpu):
Likewise.
* config/s390/s390-builtins.def: Likewise.
* config/s390/s390.c (processor_table): Add z15 as option and keep arch13 as alternative.
(s390_expand_builtin): Add missing check for unsupported builtins.
(s390_canonicalize_comparison): Rename TARGET_ARCH13 to TARGET_Z15.
(s390_rtx_costs): Likewise.
(s390_get_sched_attrmask): Rename arch13 to z15.
(s390_get_unit_mask): Likewise.
(s390_is_fpd): Likewise.
(s390_is_fxd): Likewise.
* config/s390/s390.h (enum processor_flags): Likewise.
* config/s390/s390.md: Likewise.
* config/s390/vector.md: Likewise.
* config/s390/vx-builtins.md: Likewise.
* config/s390/s390.opt: Add z15 to processor_type value.

From-SVN: r276792

5 years ago[Fortran, OpenMP] Actually pass use_device_addr on to the middle end
Tobias Burnus [Thu, 10 Oct 2019 08:48:14 +0000 (08:48 +0000)]
[Fortran, OpenMP] Actually pass use_device_addr on to the middle end

        * trans-openmp.c (gfc_trans_omp_clauses): Actually pass
        use_device_addr on to the middle end.

From-SVN: r276791

5 years agoS/390: PR91035 Fix call to __morestack
Andreas Krebbel [Thu, 10 Oct 2019 07:56:25 +0000 (07:56 +0000)]
S/390: PR91035 Fix call to __morestack

For the call to __morestack we use a special ABI in the S/390 back-end
which requires us to emit a parameter block to the .rodata section.
It contains the label whereto __morestack needs to return.  The
parameter block needs to be explicit in RTL since we also need to take
the address of it loaded into r1 in order to pass its address to
__morestack.  In order to express correctly what __morestack does its
RTX also contained the return label. Hence we had the return label to
occur twice in the insn stream.  This is problematic when it comes to
redirecting edges.  The correlation between these two occurrences of
the label cannot be expressed so when doing a redirect only the label
in the jump RTX gets modified while the parameter block label stays as
is.

The patch avoids having two instancs of the label by merging the
parameter block generation and the __morestack call RTX into one. By
doing this I could also get rid of the unspec which was required for
the parameter block generation so far.

gcc/ChangeLog:

2019-10-10  Andreas Krebbel  <krebbel@linux.ibm.com>

PR target/91035
* config/s390/s390-protos.h (s390_output_split_stack_data): Add
prototype.
* config/s390/s390.md (UNSPECV_SPLIT_STACK_DATA): Remove.
("split_stack_data", "split_stack_call")
("split_stack_call_<mode>", "split_stack_cond_call")
("split_stack_cond_call_<mode>"): Remove.
("@split_stack_call<mode>", "@split_stack_cond_call<mode>"): New
insn definition.
* config/s390/s390.c (s390_output_split_stack_data): New function.
(s390_expand_split_stack_prologue): Use the merged expander.

From-SVN: r276790

5 years agoc-common.h (c_omp_check_context_selector, [...]): Declare.
Jakub Jelinek [Thu, 10 Oct 2019 07:07:30 +0000 (09:07 +0200)]
c-common.h (c_omp_check_context_selector, [...]): Declare.

c-family/
* c-common.h (c_omp_check_context_selector,
c_omp_get_context_selector): Declare.
* c-omp.c (c_omp_declare_simd_clauses_to_numbers): Fix spelling
in diagnostic message.
(c_omp_check_context_selector, c_omp_get_context_selector): New
functions.
* c-attribs.c (c_common_attribute_table): Add "omp declare variant"
attribute.
(handle_omp_declare_variant_attribute): New function.
c/
* c-parser.c (c_parser_omp_all_clauses): Add NESTED_P argument, if
true, terminate processing on closing paren and don't skip to end of
pragma line.
(c_parser_omp_declare_simd): Handle also declare variant.
(omp_construct_selectors, omp_device_selectors,
omp_implementation_selectors, omp_user_selectors): New variables.
(c_parser_omp_context_selector,
c_parser_omp_context_selector_specification,
c_finish_omp_declare_variant): New functions.
(c_finish_omp_declare_simd): Handle both declare simd and
declare variant.
(c_parser_omp_declare): Handle declare variant.
cp/
* parser.h (struct cp_omp_declare_simd_data): Add variant_p member.
* parser.c (cp_ensure_no_omp_declare_simd): Handle both declare simd
and declare variant.
(cp_parser_oacc_all_clauses): Formatting fix.
(cp_parser_omp_all_clauses): Add NESTED_P argument, if true, terminate
processing on closing paren and don't skip to end of pragma line.
(cp_parser_omp_declare_simd): Add VARIANT_P argument.  Handle also
declare variant.
(omp_construct_selectors, omp_device_selectors,
omp_implementation_selectors, omp_user_selectors): New variables.
(cp_parser_omp_context_selector,
cp_parser_omp_context_selector_specification,
cp_finish_omp_declare_variant): New functions.
(cp_parser_late_parsing_omp_declare_simd): Handle also declare variant.
(cp_parser_omp_declare): Handle declare variant.
testsuite/
* c-c++-common/gomp/declare-variant-1.c: New test.
* c-c++-common/gomp/declare-variant-2.c: New test.
* c-c++-common/gomp/declare-variant-3.c: New test.
* g++.dg/gomp/this-1.C: Adjust for diagnostic message spelling fix.
* gcc.dg/gomp/declare-variant-1.c: New test.
* gcc.dg/gomp/declare-variant-2.c: New test.

From-SVN: r276789

5 years ago* cp-tree.h (template_info_decl_check): Check ENABLE_TREE_CHECKING.
Jason Merrill [Thu, 10 Oct 2019 04:10:17 +0000 (00:10 -0400)]
* cp-tree.h (template_info_decl_check): Check ENABLE_TREE_CHECKING.

From-SVN: r276787

5 years agoDaily bump.
GCC Administrator [Thu, 10 Oct 2019 00:16:19 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r276786

5 years agoPR tree-optimization/90879 - fold zero-equality of strcmp between a longer string...
Martin Sebor [Wed, 9 Oct 2019 21:35:11 +0000 (21:35 +0000)]
PR tree-optimization/90879 - fold zero-equality of strcmp between a longer string and a smaller array

gcc/c-family/ChangeLog:

PR tree-optimization/90879
* c.opt (-Wstring-compare): New option.

gcc/testsuite/ChangeLog:

PR tree-optimization/90879
* gcc.dg/Wstring-compare-2.c: New test.
* gcc.dg/Wstring-compare.c: New test.
* gcc.dg/strcmpopt_3.c: Scan the optmized dump instead of strlen.
* gcc.dg/strcmpopt_6.c: New test.
* gcc.dg/strlenopt-65.c: Remove uinnecessary declarations, add
test cases.
* gcc.dg/strlenopt-66.c: Run it.
* gcc.dg/strlenopt-68.c: New test.

gcc/ChangeLog:

PR tree-optimization/90879
* builtins.c (check_access): Avoid using maxbound when null.
* calls.c (maybe_warn_nonstring_arg): Adjust to get_range_strlen change.
* doc/invoke.texi (-Wstring-compare): Document new warning option.
* gimple-fold.c (get_range_strlen_tree): Make setting maxbound
conditional.
(get_range_strlen): Overwrite initial maxbound when non-null.
* gimple-ssa-sprintf.c (get_string_length): Adjust to get_range_strlen
changes.
* tree-ssa-strlen.c (maybe_diag_stxncpy_trunc): Same.
(used_only_for_zero_equality): New function.
(handle_builtin_memcmp): Call it.
(determine_min_objsize): Return an integer instead of tree.
(get_len_or_size, strxcmp_eqz_result): New functions.
(maybe_warn_pointless_strcmp): New function.
(handle_builtin_string_cmp): Call it.  Fold zero-equality of strcmp
between a longer string and a smaller array.
(get_range_strlen_dynamic): Overwrite initial maxbound when non-null.

From-SVN: r276773

5 years agoImplement C++20 P0388R4, DR 1307, and DR 330.
Marek Polacek [Wed, 9 Oct 2019 20:58:00 +0000 (20:58 +0000)]
Implement C++20 P0388R4, DR 1307, and DR 330.

This patch implements P0388R4, Permit conversions to arrays of unknown bound,
<http://wg21.link/p0388r4>.  CWG 393 allowed references to arrays of unknown
bound and this C++20 feature allows conversions like

  void f(int(&)[]);
  int arr[1];

  void g() { f(arr); }
  int(&r)[] = arr;

The proposal seemed fairly straightforward but it turned out to be quite
shifty.  I found out that I needed to implement DR 2352 (done), and also
DR 1307 (done in this patch).  The latter DR added wording for
list-initialization ranking of references to arrays which this proposal
extends.  DR 330 was also implemented in this patch.

PR c++/91364 - P0388R4: Permit conversions to arrays of unknown bound.
PR c++/69531 - DR 1307: Differently bounded array parameters.
PR c++/88128 - DR 330: Qual convs and pointers to arrays of pointers.
* call.c (build_array_conv): Build ck_identity at the beginning
of the conversion.
(standard_conversion): Pass bounds_none to comp_ptr_ttypes_const.
(maybe_warn_array_conv): New.
(convert_like_real): Call it.  Add an error message about converting
from arrays of unknown bounds.
(conv_get_original_expr): New.
(nelts_initialized_by_list_init): New.
(conv_binds_to_array_of_unknown_bound): New.
(compare_ics): Implement list-initialization ranking based on
array sizes, as specified in DR 1307 and P0388R.
* cp-tree.h (comp_ptr_ttypes_const): Adjust declaration.
(compare_bounds_t): New enum.
* typeck.c (comp_array_types): New bool and compare_bounds_t
parameters.  Use them.
(structural_comptypes): Adjust the call to comp_array_types.
(similar_type_p): Handle ARRAY_TYPE.
(build_const_cast_1): Pass bounds_none to comp_ptr_ttypes_const.
(comp_ptr_ttypes_real): Don't check cv-quals of ARRAY_TYPEs.  Use
comp_array_types to compare array types.  Look through arrays as per
DR 330.
(comp_ptr_ttypes_const): Use comp_array_types to compare array types.
Look through arrays as per DR 330.

* g++.dg/conversion/qual1.C: New test.
* g++.dg/conversion/qual2.C: New test.
* g++.dg/conversion/qual3.C: New test.
* g++.dg/conversion/ref2.C: New test.
* g++.dg/conversion/ref3.C: New test.
* g++.dg/cpp0x/initlist-array3.C: Remove dg-error.
* g++.dg/cpp0x/initlist-array7.C: New test.
* g++.dg/cpp0x/initlist-array8.C: New test.
* g++.dg/cpp2a/array-conv1.C: New test.
* g++.dg/cpp2a/array-conv10.C: New test.
* g++.dg/cpp2a/array-conv11.C: New test.
* g++.dg/cpp2a/array-conv12.C: New test.
* g++.dg/cpp2a/array-conv13.C: New test.
* g++.dg/cpp2a/array-conv14.C: New test.
* g++.dg/cpp2a/array-conv15.C: New test.
* g++.dg/cpp2a/array-conv16.C: New test.
* g++.dg/cpp2a/array-conv17.C: New test.
* g++.dg/cpp2a/array-conv2.C: New test.
* g++.dg/cpp2a/array-conv3.C: New test.
* g++.dg/cpp2a/array-conv4.C: New test.
* g++.dg/cpp2a/array-conv5.C: New test.
* g++.dg/cpp2a/array-conv6.C: New test.
* g++.dg/cpp2a/array-conv7.C: New test.
* g++.dg/cpp2a/array-conv8.C: New test.
* g++.dg/cpp2a/array-conv9.C: New test.
* g++.old-deja/g++.bugs/900321_01.C: Adjust dg-error.

* testsuite/23_containers/span/lwg3255.cc: Adjust test to match the
post-P0388R4 behavior.

From-SVN: r276771

5 years agoFix typo in test name.
Marek Polacek [Wed, 9 Oct 2019 20:38:13 +0000 (20:38 +0000)]
Fix typo in test name.

From-SVN: r276770

5 years ago[Darwin] Improve Objective-C NeXT ABI version check.
Iain Sandoe [Wed, 9 Oct 2019 18:48:38 +0000 (18:48 +0000)]
[Darwin] Improve Objective-C NeXT ABI version check.

We were missing a check for the case that user's ABI was > 2 and the
codegen was for 64 bit.

gcc/ChangeLog:

2019-10-09  Iain Sandoe  <iain@sandoe.co.uk>

* config/darwin.c (darwin_override_options): Make the check for
Objective-C ABI version more specific for 64bit code.

From-SVN: r276768

5 years ago[Darwin, machopic 3/n] Set a SYMBOL flag for indirections.
Iain Sandoe [Wed, 9 Oct 2019 18:43:36 +0000 (18:43 +0000)]
[Darwin, machopic 3/n] Set a SYMBOL flag for indirections.

We are able to treat these specially where needed in legitimate address
tests (specifically, they are guaranteed to be pointer-aligned).

gcc/ChangeLog:

2019-10-09  Iain Sandoe  <iain@sandoe.co.uk>

* config/darwin.c (machopic_indirect_data_reference): Set flag to
indicate that the new symbol is an indirection.
(machopic_indirect_call_target): Likewise.
* config/darwin.h (MACHO_SYMBOL_FLAG_INDIRECTION): New.
(MACHO_SYMBOL_INDIRECTION_P): New.
(MACHO_SYMBOL_FLAG_STATIC): Adjust bit number.

From-SVN: r276767