gcc.git
13 years agoVisit basic blocks using the work-list based algorithm.
H.J. Lu [Mon, 24 Jan 2011 17:29:58 +0000 (17:29 +0000)]
Visit basic blocks using the work-list based algorithm.

2011-01-24  H.J. Lu  <hongjiu.lu@intel.com>

PR target/46519
* config/i386/i386.c: Include sbitmap.h and fibheap.h.
(block_info): Add scanned and prev.
(move_or_delete_vzeroupper_2): Return if the basic block
has been scanned and the upper 128bit state is unchanged
from the last scan.
(move_or_delete_vzeroupper_1): Return true if the exit
state is changed.
(move_or_delete_vzeroupper): Visit basic blocks using the
work-list based algorithm based on vt_find_locations in
var-tracking.c.

* config/i386/t-i386: Also depend on sbitmap.h and $(FIBHEAP_H).

From-SVN: r169173

13 years agore PR libstdc++/47433 (libstdc++ parallel mode calls std::swap explicitely)
Johannes Singler [Mon, 24 Jan 2011 17:07:35 +0000 (17:07 +0000)]
re PR libstdc++/47433 (libstdc++ parallel mode calls std::swap explicitely)

2011-01-24  Johannes Singler  <singler@kit.edu>

        PR libstdc++/47433
        * include/parallel/losertree.h
        (_LoserTree<>::__delete_min_insert):
        Do not qualify swap with std:: for value type,
        but include a using directive instead.
        (_LoserTreeUnguarded<>::__delete_min_insert): Likewise.
        * include/parallel/balanced_quicksort.h (__qsb_divide):
        Use std::iter_swap instead of std::swap.
        (__qsb_local_sort_with_helping): Likewise.
        * include/parallel/partition.h (__parallel_partition):
        Likewise. (__parallel_nth_element): Likewise.

From-SVN: r169171

13 years agov850.opt (mv850es): New option - alias for -mv850e1.
Nick Clifton [Mon, 24 Jan 2011 17:00:28 +0000 (17:00 +0000)]
v850.opt (mv850es): New option - alias for -mv850e1.

* config/v850/v850.opt (mv850es): New option - alias for -mv850e1.
* config/v850/v850.h (ASM_SPEC): If -mv850es is specified pass
-mv850e1 to the assembler.  If -mv850e1 or -mv850es is specified
then define __v850e1__.
* doc/invoke.texi: Document -mv850es.

From-SVN: r169170

13 years agorx: Uncomplicate fp comparisons.
Richard Henderson [Mon, 24 Jan 2011 16:59:15 +0000 (08:59 -0800)]
rx: Uncomplicate fp comparisons.

It turns out that the middle-end will happily take care of
doing the swapping and splitting of compound fp comparisons.
No need for us to replicate that here.

From-SVN: r169169

13 years agoFix PR 47408 and 47385
Michael Meissner [Mon, 24 Jan 2011 16:47:16 +0000 (16:47 +0000)]
Fix PR 47408 and 47385

From-SVN: r169167

13 years agore PR libstdc++/47437 (libstdc++ parallel mode: multiway_merge does not compile)
Johannes Singler [Mon, 24 Jan 2011 16:44:30 +0000 (16:44 +0000)]
re PR libstdc++/47437 (libstdc++ parallel mode: multiway_merge does not compile)

2011-01-24  Johannes Singler  <singler@kit.edu>

        PR libstdc++/47437
        * include/parallel/multiway_merge.h (_UnguardedIterator):
        Remove useless "mutable" from reference declaration.

From-SVN: r169166

13 years ago* lib/scanasm.exp (dg-function-on-line): Handle mips-sgi-irix*.
Rainer Orth [Mon, 24 Jan 2011 11:45:49 +0000 (11:45 +0000)]
* lib/scanasm.exp (dg-function-on-line): Handle mips-sgi-irix*.

From-SVN: r169157

13 years agocray_pointers_2.f90: Avoid cycling through optimization options.
Rainer Orth [Mon, 24 Jan 2011 09:35:13 +0000 (09:35 +0000)]
cray_pointers_2.f90: Avoid cycling through optimization options.

* gfortran.dg/cray_pointers_2.f90: Avoid cycling through
optimization options.

From-SVN: r169155

13 years agore PR target/45988 (gfortran.dg/vect/fast-math-pr38968.f90 times out on 32-bit Solari...
Rainer Orth [Mon, 24 Jan 2011 09:30:31 +0000 (09:30 +0000)]
re PR target/45988 (gfortran.dg/vect/fast-math-pr38968.f90 times out on 32-bit Solaris 10/x86)

* gfortran.dg/array_constructor_33.f90: Use dg-timeout-factor 4.

PR testsuite/45988
* gfortran.dg/vect/fast-math-pr38968.f90: Use dg-timeout-factor 2.

From-SVN: r169153

13 years agoFix long line
Eric Botcazou [Mon, 24 Jan 2011 08:02:01 +0000 (08:02 +0000)]
Fix long line

From-SVN: r169152

13 years agoDaily bump.
GCC Administrator [Mon, 24 Jan 2011 00:18:17 +0000 (00:18 +0000)]
Daily bump.

From-SVN: r169150

13 years agore PR fortran/47421 (Wrong-code: Value of scalar ALLOCATABLE CHARACTER(len=n) dummy...
Tobias Burnus [Sun, 23 Jan 2011 22:26:27 +0000 (23:26 +0100)]
re PR fortran/47421 (Wrong-code: Value of scalar ALLOCATABLE CHARACTER(len=n) dummy is mangled)

2011-01-23  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47421
        * trans-decl.c (gfc_trans_deferred_vars): Do not nullify
        scalar allocatable dummy arguments.

2011-01-23  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47421
        * gfortran.dg/allocatable_scalar_12.f90: New.

From-SVN: r169145

13 years agore PR rtl-optimization/47166 (SpecCpu2000 Ammp segfaults for ARM with -O3 -mthumb)
Bernd Schmidt [Sun, 23 Jan 2011 21:11:24 +0000 (21:11 +0000)]
re PR rtl-optimization/47166 (SpecCpu2000 Ammp segfaults for ARM with -O3 -mthumb)

PR rtl-optimization/47166
* reload1.c (emit_reload_insns): Disable the spill_reg_store
mechanism for PRE_MODIFY and POST_MODIFY.
(inc_for_reload): For PRE_MODIFY, return the insn that sets the
reloadreg.

Co-Authored-By: Richard Sandiford <rdsandiford@googlemail.com>
From-SVN: r169144

13 years agocompare-elim.c (maybe_select_cc_mode): Add ATTRIBUTE_UNUSED markers.
Andreas Schwab [Sun, 23 Jan 2011 14:27:33 +0000 (14:27 +0000)]
compare-elim.c (maybe_select_cc_mode): Add ATTRIBUTE_UNUSED markers.

* compare-elim.c (maybe_select_cc_mode): Add ATTRIBUTE_UNUSED
markers.

From-SVN: r169143

13 years agocostmodel-vect-33.c: Expect vectorization to be not profitable if...
Ira Rosen [Sun, 23 Jan 2011 08:20:22 +0000 (08:20 +0000)]
costmodel-vect-33.c: Expect vectorization to be not profitable if...

        * gcc.dg/vect/costmodel/spu/costmodel-vect-33.c: Expect
        vectorization to be not profitable if peeling is used
        to realign the memory access.
        * gcc.dg/vect/costmodel/spu/costmodel-vect-76a.c:
        Increase loop bound to avoid loop unrolling.
        * gcc.dg/vect/costmodel/spu/costmodel-vect-76c.c:
        Likewise.

From-SVN: r169142

13 years agoDaily bump.
GCC Administrator [Sun, 23 Jan 2011 00:18:24 +0000 (00:18 +0000)]
Daily bump.

From-SVN: r169141

13 years agore PR target/47333 (g++.dg/lto/20091219 FAILs on Solaris 2 with SUN as)
Jan Hubicka [Sat, 22 Jan 2011 23:45:45 +0000 (00:45 +0100)]
re PR target/47333 (g++.dg/lto/20091219 FAILs on Solaris 2 with SUN as)

PR lto/47333
* g++.dg/lto/pr47333.C: New file.
* lto-cgraph.c (reachable_from_this_partition_p): Fix pasto.

From-SVN: r169137

13 years agore PR target/43884 (Performance degradation for simple fibonacci numbers calculation)
Jan Hubicka [Sat, 22 Jan 2011 21:47:40 +0000 (22:47 +0100)]
re PR target/43884 (Performance degradation for simple fibonacci numbers calculation)

PR tree-optimization/43884
PR lto/44334
* predict.c (maybe_hot_frequency_p): Use entry block frequency as an base.
* doc/invoke.texi (hot-bb-frequency-fraction): Update docs.
* gcc.dg/autopar/outer-2.c: Increase array size.
* gcc.dg/tree-ssa/ldist-pr45948.c: Update test.

From-SVN: r169136

13 years agos390.h (REGISTER_MOVE_COST, [...]): Remove.
Anatoly Sokolov [Sat, 22 Jan 2011 21:38:39 +0000 (00:38 +0300)]
s390.h (REGISTER_MOVE_COST, [...]): Remove.

* config/s390/s390.h (REGISTER_MOVE_COST, MEMORY_MOVE_COST): Remove.
* config/s390/s390.c (s390_register_move_cost,
s390_memory_move_cost): New.
(TARGET_REGISTER_MOVE_COST, TARGET_MEMORY_MOVE_COST): Define.

From-SVN: r169135

13 years agore PR middle-end/47401 (Support for must-not-throw regions with SJLJ exceptions broken)
Ulrich Weigand [Sat, 22 Jan 2011 21:24:54 +0000 (21:24 +0000)]
re PR middle-end/47401 (Support for must-not-throw regions with SJLJ exceptions broken)

PR middle-end/47401
* except.c (sjlj_assign_call_site_values): Move setting the
crtl->uses_eh_lsda flag to ...
(sjlj_mark_call_sites): ... here.
(sjlj_emit_function_enter): Support NULL dispatch label.
(sjlj_build_landing_pads): In a function with no landing pads
that still has must-not-throw regions, generate code to register
a personality function with empty LSDA.

From-SVN: r169134

13 years agorx: Enable the compare-elim pass.
Richard Henderson [Sat, 22 Jan 2011 19:39:36 +0000 (11:39 -0800)]
rx: Enable the compare-elim pass.

From-SVN: r169133

13 years agomn10300: Enable the compare-elim pass.
Richard Henderson [Sat, 22 Jan 2011 19:37:55 +0000 (11:37 -0800)]
mn10300: Enable the compare-elim pass.

From-SVN: r169132

13 years agoNew -fcompare-elim pass.
Richard Henderson [Sat, 22 Jan 2011 19:35:10 +0000 (11:35 -0800)]
New -fcompare-elim pass.

Version 3, with two rounds of comments from Paolo Bonzini.

From-SVN: r169131

13 years agore PR fortran/38536 (ICE with C_LOC in resolve.c due to not properly going through...
Thomas Koenig [Sat, 22 Jan 2011 17:30:22 +0000 (17:30 +0000)]
re PR fortran/38536 (ICE with C_LOC in resolve.c due to not properly going through expr->ref)

2011-01-22  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/38536
* resolve.c (gfc_iso_c_func_interface):  For C_LOC,
check for array sections followed by component references
which are illegal.  Also check for coindexed arguments.

2011-01-22  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/38536
* gfortran.dg/c_loc_tests_16.f90:  New test.

From-SVN: r169130

13 years agorx.md (cstoresf4): Pass comparison operator to rx_split_fp_compare.
Nick Clifton [Sat, 22 Jan 2011 16:09:52 +0000 (16:09 +0000)]
rx.md (cstoresf4): Pass comparison operator to rx_split_fp_compare.

* config/rx/rx.md (cstoresf4): Pass comparison operator to
rx_split_fp_compare.

From-SVN: r169129

13 years agorx.md (UNSPEC_CONST): New.
Nick Clifton [Sat, 22 Jan 2011 16:05:49 +0000 (16:05 +0000)]
rx.md (UNSPEC_CONST): New.

* config/rx/rx.md (UNSPEC_CONST): New.
(deallocate_and_return): Wrap the amount popped off the stack in
an UNSPEC_CONST in order to stop it being rejected by
-mmax-constant-size.
(pop_and_return): Add a "(return)" rtx.
(call): Drop the immediate operand.
(call_internal): Likewise.
(call_value): Likewise.
(call_value_internal): Likewise.
(sibcall_internal): Likewise.
(sibcall_value_internal): Likewise.
(sibcall): Likewise.  Generate an explicit call using
sibcall_internal.
(sibcall_value): Likewise.
(mov<>): FAIL if a constant operand is not legitimate.
(addsi3_unpsec): New pattern.
* config/rx/rx.c (rx_print_operand_address): Handle UNPSEC
CONSTs.
(ok_for_max_constant): New function.
(gen_safe_add): New function.
(rx_expand_prologue): Use gen_safe_add.
(rx_expand_epilogue): Likewise.
(rx_is_legitimate_constant): Use ok_for_max_constant.  Handle
UNSPEC CONSTs.

From-SVN: r169128

13 years agore PR fortran/47399 ([OOP] ICE with TBP of a PARAMETER)
Tobias Burnus [Sat, 22 Jan 2011 13:50:25 +0000 (14:50 +0100)]
re PR fortran/47399 ([OOP] ICE with TBP of a PARAMETER)

2011-01-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47399
        * primary.c (gfc_match_varspec): Relax gcc_assert to allow for
        PARAMETER TBP.

2011-01-22  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47399
        * gfortran.dg/typebound_proc_19.f90: New.

From-SVN: r169126

13 years agore PR tree-optimization/47053 (ICE: verify_flow_info failed: BB 2 can not throw but...
Jeff Law [Sat, 22 Jan 2011 04:09:44 +0000 (21:09 -0700)]
re PR tree-optimization/47053 (ICE: verify_flow_info failed: BB 2 can not throw but has an EH edge with -O -fnon-call-exceptions)

PR tree-optimization/47053
* tree-ssa-dse.c (need_eh_cleanup): New bitmap.
(dse_optimize_stmt): Set the appropriate bit in NEED_EH_CLEANUP when
statements are deleted.
(tree_ssa_dse): Allocate & free NEED_EH_CLEANUP.  If NEED_EH_CLEANUP
is nonempty, then purge dead edges and cleanup the CFG.

PR tree-optimization/47053
* g++.dg/pr47053.C: New test.

From-SVN: r169123

13 years agoAvoid crash when M structure free just before thread exit.
Ian Lance Taylor [Sat, 22 Jan 2011 02:59:24 +0000 (02:59 +0000)]
Avoid crash when M structure free just before thread exit.

From-SVN: r169121

13 years agolibgo: Adjust deadlock avoidance.
Ian Lance Taylor [Sat, 22 Jan 2011 02:15:01 +0000 (02:15 +0000)]
libgo: Adjust deadlock avoidance.

From-SVN: r169120

13 years agosyscalls: Add SPARC RTEMS specific file.
Ian Lance Taylor [Sat, 22 Jan 2011 02:01:38 +0000 (02:01 +0000)]
syscalls: Add SPARC RTEMS specific file.

From-SVN: r169119

13 years agoDaily bump.
GCC Administrator [Sat, 22 Jan 2011 00:18:41 +0000 (00:18 +0000)]
Daily bump.

From-SVN: r169118

13 years agoAvoid deadlock creating new thread.
Ian Lance Taylor [Sat, 22 Jan 2011 00:12:00 +0000 (00:12 +0000)]
Avoid deadlock creating new thread.

From-SVN: r169114

13 years agoAvoid deadlock when finalizer lock is held during gc.
Ian Lance Taylor [Fri, 21 Jan 2011 23:33:52 +0000 (23:33 +0000)]
Avoid deadlock when finalizer lock is held during gc.

From-SVN: r169112

13 years agoPR 46267 strerror thread safety
Janne Blomqvist [Fri, 21 Jan 2011 22:42:17 +0000 (00:42 +0200)]
PR 46267 strerror thread safety

From-SVN: r169110

13 years agore PR c++/47041 (Internal compiler error in build_data_member_initialization, add...
Jason Merrill [Fri, 21 Jan 2011 22:30:26 +0000 (17:30 -0500)]
re PR c++/47041 (Internal compiler error in build_data_member_initialization, add cp/semantics.c:5483)

PR c++/47041
* semantics.c (build_constexpr_constructor_member_initializers):
Handle trivial copy.

From-SVN: r169108

13 years agore PR bootstrap/47402 (Bootstrap comparison failure)
Alexandre Oliva [Fri, 21 Jan 2011 22:11:24 +0000 (22:11 +0000)]
re PR bootstrap/47402 (Bootstrap comparison failure)

PR debug/47402
Temporarily revert:
2011-01-21  Alexandre Oliva  <aoliva@redhat.com>
PR debug/47106
* tree-dfa.c (create_var_ann): Mark variable as used.

From-SVN: r169107

13 years agoFix race condition in test case.
Ian Lance Taylor [Fri, 21 Jan 2011 22:01:02 +0000 (22:01 +0000)]
Fix race condition in test case.

Brought over from master repository.

From-SVN: r169106

13 years agore PR c++/47388 (ICE: in begin_for_stmt, at cp/semantics.c:863 with -fno-for-scope...
Jakub Jelinek [Fri, 21 Jan 2011 21:34:25 +0000 (22:34 +0100)]
re PR c++/47388 (ICE: in begin_for_stmt, at cp/semantics.c:863 with -fno-for-scope and for(;;) inside a template)

PR c++/47388
* semantics.c (begin_for_stmt): If -fno-for-scope, don't
assume init must be NULL if scope is NULL.
(begin_range_for_stmt): Likewise.

* g++.dg/cpp0x/range-for10.C: New test.
* g++.dg/template/for1.C: New test.

From-SVN: r169105

13 years agore PR fortran/47394 (Internal compiler error when error count limit is reached)
Tobias Burnus [Fri, 21 Jan 2011 20:33:10 +0000 (21:33 +0100)]
re PR fortran/47394 (Internal compiler error when error count limit is reached)

2011-01-21  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47394
        * error.c (gfc_error_now, gfc_fatal_error, gfc_error_check):
        Use defined instead of magic number exit status codes.
        * scanner.c (include_line, gfc_new_file): Ditto.

From-SVN: r169104

13 years agoc++config (_GLIBCXX_EXPORT_TEMPLATE): Remove.
Benjamin Kosnik [Fri, 21 Jan 2011 19:41:13 +0000 (19:41 +0000)]
c++config (_GLIBCXX_EXPORT_TEMPLATE): Remove.

2011-01-21  Benjamin Kosnik  <bkoz@redhat.com>

* include/bits/c++config (_GLIBCXX_EXPORT_TEMPLATE): Remove.
* include/debug/safe_sequence.h: Same.
* include/debug/safe_iterator.h: Same.
* include/std/forward_list: Same.
* include/std/deque: Same.
* include/std/list: Same.
* include/std/random: Same.
* include/std/streambuf: Same.
* include/std/fstream: Same.
* include/std/istream: Same.
* include/std/string: Same.
* include/std/ostream: Same.
* include/std/sstream: Same.
* include/ext/vstring.h: Same.
* include/bits/basic_ios.h: Same.
* include/bits/locale_classes.h: Same.
* include/bits/locale_facets.h: Same.
* include/bits/valarray_array.h: Same.
* include/bits/locale_facets_nonio.h: Same.
* include/tr1/random: Same.

From-SVN: r169102

13 years agore PR middle-end/45566 (ICE: in convert_to_eh_region_ranges, at except.c:2446 with...
Jakub Jelinek [Fri, 21 Jan 2011 19:35:42 +0000 (20:35 +0100)]
re PR middle-end/45566 (ICE: in convert_to_eh_region_ranges, at except.c:2446 with -freorder-blocks-and-partition -fnon-call-exceptions -fprofile-use)

PR middle-end/45566
* except.c (convert_to_eh_region_ranges): Emit queued no-region
notes from other section in hot/cold partitioning even if
last_action is -3.  Increment call_site_base.

* g++.dg/tree-prof/partition3.C: New test.

* g++.dg/tree-prof/tree-prof.exp: Fix a comment.

From-SVN: r169101

13 years agore PR rtl-optimization/47366 (ICE: verify_flow_info failed: missing REG_EH_REGION...
Jakub Jelinek [Fri, 21 Jan 2011 19:34:03 +0000 (20:34 +0100)]
re PR rtl-optimization/47366 (ICE: verify_flow_info failed: missing REG_EH_REGION note in the end of bb 3 with -fnon-call-exceptions -fno-tree-ccp -fno-tree-forwprop)

PR rtl-optimization/47366
* fwprop.c (forward_propagate_into): Return bool.  If
any changes are made, -fnon-call-exceptions is used and
REG_EH_REGION note is present, call purge_dead_edges
and return true if it purged anything.
(fwprop_addr): Adjust callers, call cleanup_cfg (0) if
any EH edges were purged.

* g++.dg/opt/pr47366.C: New test.

From-SVN: r169100

13 years agore PR c++/46552 ([C++0x] Internal compiler error on pointer to member variable with...
Jason Merrill [Fri, 21 Jan 2011 18:59:40 +0000 (13:59 -0500)]
re PR c++/46552 ([C++0x] Internal compiler error on pointer to member variable with template)

PR c++/46552
* semantics.c (cxx_eval_constant_expression): Handle OFFSET_REF.

From-SVN: r169099

13 years agoRemove the types float and complex.
Ian Lance Taylor [Fri, 21 Jan 2011 18:19:03 +0000 (18:19 +0000)]
Remove the types float and complex.

Update to current version of Go library.

Update testsuite for removed types.

* go-lang.c (go_langhook_init): Omit float_type_size when calling
go_create_gogo.
* go-c.h: Update declaration of go_create_gogo.

From-SVN: r169098

13 years agore PR c++/46977 ([C++0x] ICE: SIGSEGV in htab_find_slot_with_hash (hashtab.c:650))
Jason Merrill [Fri, 21 Jan 2011 17:38:02 +0000 (12:38 -0500)]
re PR c++/46977 ([C++0x] ICE: SIGSEGV in htab_find_slot_with_hash (hashtab.c:650))

PR c++/46977
* semantics.c (potential_constant_expression_1): Split out from
potential_constant_expression.  Add want_rval parm.  Handle
template expression forms.  Don't enforce restriction on address
of automatic variable here.  Add a couple of diagnostics that
had been missing.
(require_potential_constant_expression): New entry point.
(build_data_member_initialization, register_constexpr_fundef): Adjust.
(maybe_constant_value): Check potential_constant_expression.
* pt.c (fold_non_dependent_expr_sfinae): Likewise.
* tree.c (build_vec_init_expr): Adjust.

From-SVN: r169096

13 years agore PR rtl-optimization/41619 (ICE in insert_save (caller-save.c) for SPEC CPU2000...
Jeff Law [Fri, 21 Jan 2011 16:49:31 +0000 (09:49 -0700)]
re PR rtl-optimization/41619 (ICE in insert_save (caller-save.c) for SPEC CPU2000's 252.eon)

PR rtl-optimization/41619
* caller-save.c (setup_save_areas): Break out code to determine
which hard regs are live across calls by examining the reload chains
so that it is always used.
Eliminate code which checked REG_N_CALLS_CROSSED.

PR rtl-optimization/41619
* gcc.dg/pr41619.c: New.

From-SVN: r169095

13 years agore PR tree-optimization/47355 (ICE: verify_ssa failed with -O2 -fipa-cp-clone)
Jakub Jelinek [Fri, 21 Jan 2011 15:15:40 +0000 (16:15 +0100)]
re PR tree-optimization/47355 (ICE: verify_ssa failed with -O2 -fipa-cp-clone)

PR tree-optimization/47355
* tree-eh.c (cleanup_empty_eh_merge_phis): Give up if
NOP has non-debug uses beyond PHIs in new_bb.

* g++.dg/opt/pr47355.C: New test.

From-SVN: r169094

13 years agore PR debug/47106 (-fcompare-debug failure (length) with -fpartial-inlining -flto...
Alexandre Oliva [Fri, 21 Jan 2011 14:57:33 +0000 (14:57 +0000)]
re PR debug/47106 (-fcompare-debug failure (length) with  -fpartial-inlining -flto -fconserve-stack)

PR debug/47106
* cfgexpand.c (account_used_vars_for_block): Only account vars
that are annotated as used.
(estimated_stack_frame_size): Don't set TREE_USED.
* tree-dfa.c (create_var_ann): Mark variable as used.

From-SVN: r169093

13 years agore PR other/47395 (the tree code WIDEN_MULT_MINUS_EXPR has a mismatching name)
Richard Guenther [Fri, 21 Jan 2011 14:14:12 +0000 (14:14 +0000)]
re PR other/47395 (the tree code WIDEN_MULT_MINUS_EXPR has a mismatching name)

2011-01-21  Richard Guenther  <rguenther@suse.de>

PR middle-end/47395
* tree.def (WIDEN_MULT_MINUS_EXPR): Fix printed name.

From-SVN: r169092

13 years agopr47392.c: Make test non-static instead of making main hot.
Richard Guenther [Fri, 21 Jan 2011 14:08:26 +0000 (14:08 +0000)]
pr47392.c: Make test non-static instead of making main hot.

2011-01-21  Richard Guenther  <rguenther@suse.de>

        * gcc.dg/tree-ssa/pr47392.c: Make test non-static instead of
        making main hot.

From-SVN: r169091

13 years agore PR tree-optimization/47365 (wrong code with -O -ftree-pre)
Richard Guenther [Fri, 21 Jan 2011 14:02:41 +0000 (14:02 +0000)]
re PR tree-optimization/47365 (wrong code with -O -ftree-pre)

2011-01-21  Richard Guenther  <rguenther@suse.de>

PR tree-optimization/47365
* tree-ssa-sccvn.h (vn_lookup_kind): Declare.
(vn_reference_lookup_pieces): Adjust.
(vn_reference_lookup): Likewise.
* tree-ssa-sccvn.c (vn_walk_kind): New static global.
(vn_reference_lookup_3): Only look through kills if in
VN_WALKREWRITE mode.
(vn_reference_lookup_pieces): Adjust.
(vn_reference_lookup): Likewise.
(visit_reference_op_load): Likewise.
(visit_reference_op_store): Likewise.
* tree-ssa-pre.c (phi_translate_1): Use VN_WALK mode.
(compute_avail): Likewise.
(eliminate): Likewise.

* gcc.dg/torture/pr47365.c: New testcase.
* gcc.dg/tree-ssa/pr47392.c: Likewise.

From-SVN: r169089

13 years agoconfigure.ac: Use AS_HELP_STRING throughout.
Andreas Schwab [Fri, 21 Jan 2011 13:18:23 +0000 (13:18 +0000)]
configure.ac: Use AS_HELP_STRING throughout.

* configure.ac: Use AS_HELP_STRING throughout.
* configure: Regenerate.

From-SVN: r169088

13 years ago* g++.dg/other/anon5.C: Skip on mips-sgi-irix*.
Rainer Orth [Fri, 21 Jan 2011 13:02:39 +0000 (13:02 +0000)]
* g++.dg/other/anon5.C: Skip on mips-sgi-irix*.

From-SVN: r169085

13 years agore PR tree-optimization/47391 (read from const volatile incorrectly eliminated)
Jakub Jelinek [Fri, 21 Jan 2011 12:57:52 +0000 (13:57 +0100)]
re PR tree-optimization/47391 (read from const volatile incorrectly eliminated)

PR tree-optimization/47391
* varpool.c (const_value_known_p): Return false if
decl is volatile.

* gcc.dg/pr47391.c: New test.

From-SVN: r169084

13 years agotree-ssa-live.c (remove_unused_scope_block_p): Don't remove DECL_IGNORED_P non-reg...
Jakub Jelinek [Fri, 21 Jan 2011 12:51:18 +0000 (13:51 +0100)]
tree-ssa-live.c (remove_unused_scope_block_p): Don't remove DECL_IGNORED_P non-reg vars if they are used.

* tree-ssa-live.c (remove_unused_scope_block_p): Don't remove
DECL_IGNORED_P non-reg vars if they are used.

From-SVN: r169083

13 years ago* g++.dg/template/char1.C: Use signed char.
Rainer Orth [Fri, 21 Jan 2011 11:36:53 +0000 (11:36 +0000)]
* g++.dg/template/char1.C: Use signed char.

From-SVN: r169082

13 years agore PR bootstrap/47215 (Failed to bootstrap)
Kai Tietz [Fri, 21 Jan 2011 09:05:14 +0000 (09:05 +0000)]
re PR bootstrap/47215 (Failed to bootstrap)

2011-01-21  Kai Tietz  <kai.tietz@onevision.com>

        PR bootstrap/47215
        * decl.c (java_init_decl_processing): Remove
        va_list_type_node related type initializations.

2011-01-21  Kai Tietz  <kai.tietz@onevision.com>

PR bootstrap/47215
* config/i386/i386.c (ix86_local_alignment): Handle
case for va_list_type_node is nil.
(ix86_canonical_va_list_type): Likewise.

From-SVN: r169080

13 years agore PR fortran/47377 (internal compiler error: in fold_convert_loc, at fold-const...
Tobias Burnus [Fri, 21 Jan 2011 07:11:05 +0000 (08:11 +0100)]
re PR fortran/47377 (internal compiler error: in fold_convert_loc, at fold-const.c:1906)

2011-01-21  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47377
        * expr.c (gfc_check_pointer_assign): Reject expr data-targets
        without pointer attribute.

2011-01-21  Tobias Burnus  <burnus@net-b.de>

        PR fortran/47377
        * gfortran.dg/pointer_target_4.f90: New.

From-SVN: r169079

13 years agoFix typo in comment.
Mike Stump [Fri, 21 Jan 2011 05:03:44 +0000 (05:03 +0000)]
Fix typo in comment.

From-SVN: r169078

13 years agors6000-c.c (rs6000_cpu_cpp_builtins): Add builtin_define __CMODEL_MEDIUM__ and __CMOD...
Alan Modra [Fri, 21 Jan 2011 02:13:52 +0000 (12:43 +1030)]
rs6000-c.c (rs6000_cpu_cpp_builtins): Add builtin_define __CMODEL_MEDIUM__ and __CMODEL_LARGE__.

* config/rs6000/rs6000-c.c (rs6000_cpu_cpp_builtins): Add
builtin_define __CMODEL_MEDIUM__ and __CMODEL_LARGE__.

From-SVN: r169077

13 years agoDaily bump.
GCC Administrator [Fri, 21 Jan 2011 00:18:42 +0000 (00:18 +0000)]
Daily bump.

From-SVN: r169076

13 years agore PR libstdc++/36104 (gnu-versioned-namespace is broken)
Benjamin Kosnik [Thu, 20 Jan 2011 23:41:24 +0000 (23:41 +0000)]
re PR libstdc++/36104 (gnu-versioned-namespace is broken)

2011-01-20  Benjamin Kosnik  <bkoz@redhat.com>

PR libstdc++/36104
* acinclude.m4 (LIBGOMP_ENABLE_SYMVERS): Accept gnu variants.

From-SVN: r169072

13 years agoRename f_load to f_fpa_loads patch
Ramana Radhakrishnan [Thu, 20 Jan 2011 22:03:29 +0000 (22:03 +0000)]
Rename f_load to f_fpa_loads patch

2011-01-20  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

* config/arm/arm.md (define_attr type): Rename f_load
and f_store to f_fpa_load and f_fpa_store. Update.
(write_conflict): Deal with rename fallout.
(*push_fp_multi): Likewise.
* config/arm/fpa.md (f_load): Use f_fpa_load.
(f_store): Use f_fpa_store.
(*movsf_fpa): Likewise.
(*movdf_fpa): Likewise.
(*movxf_fpa): Likewise.
(*thumb2_movsf_fpa): Likewise.
(*thumb2_movdf_fpa): Likewise.
(*thumb2_movxf_fpa): Likewise.
* config/arm/vfp.md (*thumb2_movdf_vfp): Fix attribute to
f_loadd and f_stored.
(*thumb2_movdi_vfp): Likewise.
(*thumb2_movsf_vfp): Fix attribute to f_loads.
(*thumb2_movsi_vfp): Likewise.
* config/arm/cortex-m4-fpu.md (cortex_m4_f_load):
Use f_loads instead of f_load.
* config/arm/cortex-a5.md (cortex_a5_f_loads): Remove f_load.

From-SVN: r169071

13 years agoRefix test for PR47251
Michael Meissner [Thu, 20 Jan 2011 21:19:30 +0000 (21:19 +0000)]
Refix test for PR47251

From-SVN: r169067

13 years agore PR libstdc++/47380 (concept checking and incomplete types)
Jonathan Wakely [Thu, 20 Jan 2011 20:18:29 +0000 (20:18 +0000)]
re PR libstdc++/47380 (concept checking and incomplete types)

2011-01-20  Jonathan Wakely  <jwakely.gcc@gmail.com>

        PR libstdc++/47380
* doc/xml/manual/diagnostics.xml: Replace note about C++0x concepts.

From-SVN: r169064

13 years agoPR libstdc++/36104 part three
Benjamin Kosnik [Thu, 20 Jan 2011 20:04:25 +0000 (20:04 +0000)]
PR libstdc++/36104 part three

2011-01-20  Benjamin Kosnik  <bkoz@redhat.com>

PR libstdc++/36104 part three
* src/hashtable_c++0x.cc: Adjust namespace macros.
* testsuite/util/testsuite_rvalref.h: Don't forward declare hash.
* config/abi/pre/gnu-versioned-namespace.ver: Update.

From-SVN: r169063

13 years agohash_load_check_resize_trigger_imp.hpp: Adjust assert condition.
Benjamin Kosnik [Thu, 20 Jan 2011 18:26:33 +0000 (18:26 +0000)]
hash_load_check_resize_trigger_imp.hpp: Adjust assert condition.

2011-01-20  Benjamin Kosnik  <bkoz@redhat.com>

* include/ext/pb_ds/detail/resize_policy/
hash_load_check_resize_trigger_imp.hpp: Adjust assert condition.
* include/ext/pb_ds/detail/pat_trie_/
constructors_destructor_fn_imps.hpp: Same.
* include/ext/pb_ds/detail/binary_heap_/erase_fn_imps.hpp: Format.
* include/ext/pb_ds/detail/ov_tree_map_/debug_fn_imps.hpp: Same.
* include/ext/pb_ds/detail/debug_map_base.hpp: Use never_adjustor.

* testsuite/ext/pb_ds/regression/hash_data_map_rand.cc: Adjust
iterations downward when testing in debug mode.
* testsuite/ext/pb_ds/regression/trie_data_map_rand.cc: Same.
* testsuite/ext/pb_ds/regression/tree_no_data_map_rand.cc: Same.
* testsuite/ext/pb_ds/regression/hash_no_data_map_rand.cc: Same.
* testsuite/ext/pb_ds/regression/tree_data_map_rand.cc: Same.
* testsuite/ext/pb_ds/regression/trie_no_data_map_rand.cc: Same.
* testsuite/ext/pb_ds/example/hash_illegal_resize.cc: Use SIZE,
reduce in debug mode.

From-SVN: r169061

13 years agoxtensa.h (GO_IF_MODE_DEPENDENT_ADDRESS): Remove.
Anatoly Sokolov [Thu, 20 Jan 2011 17:37:13 +0000 (20:37 +0300)]
xtensa.h (GO_IF_MODE_DEPENDENT_ADDRESS): Remove.

* config/xtensa/xtensa.h (GO_IF_MODE_DEPENDENT_ADDRESS): Remove.
* config/xtensa/xtensa-protos.h (constantpool_address_p): Remove.
* config/xtensa/xtensa.c (TARGET_MODE_DEPENDENT_ADDRESS_P): Define.
(xtensa_mode_dependent_address_p): New function.
(constantpool_address_p): Make static. Change return type to bool.
Change argument type to const_rtx. Use CONST_INT_P predicate.

From-SVN: r169060

13 years agore PR tree-optimization/46583 (-fcompare-debug failure with -O -fno-inline -fipa...
Alexandre Oliva [Thu, 20 Jan 2011 16:56:25 +0000 (16:56 +0000)]
re PR tree-optimization/46583 (-fcompare-debug failure with -O -fno-inline -fipa-cp -fipa-cp-clone)

gcc/ChangeLog:
PR debug/46583
* tree-ssa-live.c (remove_unused_scope_block_p): Keep type decls.
gcc/testsuite/ChangeLog:
PR debug/46583
* g++.dg/debug/pr46583.C: New.

From-SVN: r169058

13 years agore PR debug/47283 (ICE in refs_may_alias_p_1, at tree-ssa-alias.c)
Jakub Jelinek [Thu, 20 Jan 2011 16:40:36 +0000 (17:40 +0100)]
re PR debug/47283 (ICE in refs_may_alias_p_1, at tree-ssa-alias.c)

PR debug/47283
* cfgexpand.c (expand_debug_expr): Instead of generating
(mem (debug_implicit_ptr)) for MEM_REFs use COMPONENT_REF
etc. handling.

* g++.dg/debug/pr47283.C: New test.

From-SVN: r169057

13 years agore PR testsuite/47371 (FAIL: gcc.target/i386/headmerge-[12].c)
Jakub Jelinek [Thu, 20 Jan 2011 16:37:28 +0000 (17:37 +0100)]
re PR testsuite/47371 (FAIL: gcc.target/i386/headmerge-[12].c)

PR testsuite/47371
* gcc.target/i386/headmerge-1.c: Tighten up scan-assembler regex.
* gcc.target/i386/headmerge-2.c: Likewise.

From-SVN: r169056

13 years agore PR middle-end/47370 (error: invalid first operand of MEM_REF)
Richard Guenther [Thu, 20 Jan 2011 14:42:20 +0000 (14:42 +0000)]
re PR middle-end/47370 (error: invalid first operand of MEM_REF)

2011-01-20  Richard Guenther  <rguenther@suse.de>

PR middle-end/47370
* tree-inline.c (remap_gimple_op_r): Recurse manually for
the pointer operand of MEM_REFs.

* gcc.dg/torture/pr47370.c: New testcase.

From-SVN: r169055

13 years agore PR tree-optimization/46130 (ICE: SIGSEGV in walk_stmt_load_store_addr_ops (gimple...
Jakub Jelinek [Thu, 20 Jan 2011 12:02:33 +0000 (13:02 +0100)]
re PR tree-optimization/46130 (ICE: SIGSEGV in walk_stmt_load_store_addr_ops (gimple.c:4894) with -O2 -fno-tree-dce)

PR tree-optimization/46130
* ipa-split.c (consider_split): If return_bb contains non-virtual
PHIs other than for retval or if split_function would not adjust it,
refuse to split.

* gcc.dg/pr46130-1.c: New test.
* gcc.dg/pr46130-2.c: New test.

From-SVN: r169052

13 years agore PR other/47167 (Performance regression in numerical code)
Richard Guenther [Thu, 20 Jan 2011 10:33:15 +0000 (10:33 +0000)]
re PR other/47167 (Performance regression in numerical code)

2011-01-20  Richard Guenther  <rguenther@suse.de>

PR tree-optimization/47167
* tree-ssa-copyrename.c (copy_rename_partition_coalesce):
Revert previous change, only avoid enumeral type changes.

From-SVN: r169050

13 years agotm.texi.in (BRANCH_COST): Englishify.
Mike Stump [Thu, 20 Jan 2011 00:19:07 +0000 (00:19 +0000)]
tm.texi.in (BRANCH_COST): Englishify.

* doc/tm.texi.in (BRANCH_COST): Englishify.
* doc/tm.texi (BRANCH_COST): Likewise.

From-SVN: r169043

13 years agoDaily bump.
GCC Administrator [Thu, 20 Jan 2011 00:18:46 +0000 (00:18 +0000)]
Daily bump.

From-SVN: r169042

13 years agoFixup formatting.
Mike Stump [Wed, 19 Jan 2011 23:52:57 +0000 (23:52 +0000)]
Fixup formatting.

From-SVN: r169038

13 years agolibgo/Makefile.am: Fix typo naming socket_bsd.go.
Ian Lance Taylor [Wed, 19 Jan 2011 23:03:33 +0000 (23:03 +0000)]
libgo/Makefile.am: Fix typo naming socket_bsd.go.

From-SVN: r169037

13 years agore PR c++/47291 (ICE: SIGSEGV in size_binop_loc (fold-const.c:1427) with -g)
Dodji Seketeli [Wed, 19 Jan 2011 22:57:47 +0000 (22:57 +0000)]
re PR c++/47291 (ICE: SIGSEGV in size_binop_loc (fold-const.c:1427) with -g)

Fix PR c++/47291

gcc/
PR c++/47291
* dwarf2out.c (generic_type_p, schedule_generic_params_dies_gen)
(gen_scheduled_generic_parms_dies): New functions.
(gen_struct_or_union_type_die): Schedule template parameters DIEs
generation for the end of CU compilation.
(dwarf2out_finish): Generate template parameters DIEs here.

gcc/testsuite/

PR c++/47291
* g++.dg/debug/dwarf2/template-params-10.C: New test.

From-SVN: r169036

13 years agore PR debug/46240 (ice in maybe_register_def)
Alexandre Oliva [Wed, 19 Jan 2011 22:07:14 +0000 (22:07 +0000)]
re PR debug/46240 (ice in maybe_register_def)

gcc/ChangeLog:
PR debug/46240
* tree-into-ssa.c (maybe_register_def): Do not attempt to add
debug bind stmt on merge edges.
gcc/testsuite/ChangeLog:
PR debug/46240
* g++.dg/debug/pr46240.cc: New.

From-SVN: r169035

13 years agore PR debug/47079 (FAIL: gcc.dg/guality/nrv-1.c)
Alexandre Oliva [Wed, 19 Jan 2011 22:00:00 +0000 (22:00 +0000)]
re PR debug/47079 (FAIL: gcc.dg/guality/nrv-1.c)

PR debug/47079
PR debug/46724
* function.c (instantiate_expr): Instantiate incoming rtl of
implicit arguments, and recurse on VALUE_EXPRs.
(instantiate_decls): Instantiate rtl and VALUE_EXPR of result.
* var-tracking.c (adjust_mems): Reject virtual_incoming_args_rtx.

From-SVN: r169034

13 years agoc-parser.c (c_parser_for_statement): Initialize collection_expression.
Alexandre Oliva [Wed, 19 Jan 2011 21:59:47 +0000 (21:59 +0000)]
c-parser.c (c_parser_for_statement): Initialize collection_expression.

* c-parser.c (c_parser_for_statement): Initialize
collection_expression.

From-SVN: r169033

13 years agoRemember erroneous type when creating GENERIC for named type.
Ian Lance Taylor [Wed, 19 Jan 2011 20:54:30 +0000 (20:54 +0000)]
Remember erroneous type when creating GENERIC for named type.

From-SVN: r169030

13 years ago* config/spu/spu-elf.h (ASM_SPEC): Remove %{w:-W}.
Joseph Myers [Wed, 19 Jan 2011 20:51:32 +0000 (20:51 +0000)]
* config/spu/spu-elf.h (ASM_SPEC): Remove %{w:-W}.

From-SVN: r169028

13 years agoDon't crash on reference to field with erroneous type.
Ian Lance Taylor [Wed, 19 Jan 2011 20:47:21 +0000 (20:47 +0000)]
Don't crash on reference to field with erroneous type.

From-SVN: r169027

13 years agosysv4.h (LINK_PATH_SPEC): Remove.
Joseph Myers [Wed, 19 Jan 2011 20:45:30 +0000 (20:45 +0000)]
sysv4.h (LINK_PATH_SPEC): Remove.

* config/rs6000/sysv4.h (LINK_PATH_SPEC): Remove.
(LINK_SHLIB_SPEC): Don't use %(link_path).
(SUBTARGET_EXTRA_SPECS): Remove link_path.

From-SVN: r169026

13 years agosysv4.h (SHARED_LIB_SUPPORT): Remove conditional.
Joseph Myers [Wed, 19 Jan 2011 20:41:37 +0000 (20:41 +0000)]
sysv4.h (SHARED_LIB_SUPPORT): Remove conditional.

* config/rs6000/sysv4.h (SHARED_LIB_SUPPORT): Remove conditional.
(NO_SHARED_LIB_SUPPORT): Remove.
(LINK_SHLIB_SPEC): Remove one conditional definition.

From-SVN: r169025

13 years agolinux64.h (LINK_SPEC): Remove %{non_shared} %{call_shared}.
Joseph Myers [Wed, 19 Jan 2011 20:39:09 +0000 (20:39 +0000)]
linux64.h (LINK_SPEC): Remove %{non_shared} %{call_shared}.

* config/mips/linux64.h (LINK_SPEC): Remove %{non_shared}
%{call_shared}.
* config/mips/mips.h (LINK_SPEC): Remove %{non_shared}.
* config/mips/netbsd.h (LINK_SPEC): Remove %{call_shared}.
* config/mips/openbsd.h (LINK_SPEC): Remove %{non_shared}
%{call_shared} and conditionals on these options not being passed.
* config/mips/sde.h (LINK_SPEC): Remove %{non_shared}
%{call_shared}.

From-SVN: r169024

13 years agoGenerate an init function if any global variable needs a preinit.
Ian Lance Taylor [Wed, 19 Jan 2011 20:37:50 +0000 (20:37 +0000)]
Generate an init function if any global variable needs a preinit.

From-SVN: r169023

13 years agoPR libstdc++/36104 part two
Benjamin Kosnik [Wed, 19 Jan 2011 20:00:47 +0000 (20:00 +0000)]
PR libstdc++/36104 part two

2011-01-19  Benjamin Kosnik  <bkoz@redhat.com>

PR libstdc++/36104 part two
* include/bits/hashtable.h: Revert to non-nested macro usage.
* include/bits/hashtable_policy.h: Same.

From-SVN: r169021

13 years agoipa-split.c (find_return_bb): Use single_pred_p/single_pred_edge, simplify.
Jakub Jelinek [Wed, 19 Jan 2011 19:58:37 +0000 (20:58 +0100)]
ipa-split.c (find_return_bb): Use single_pred_p/single_pred_edge, simplify.

* ipa-split.c (find_return_bb): Use single_pred_p/single_pred_edge,
simplify.

From-SVN: r169020

13 years ago* ipa-split.c: Spelling fixes.
Jakub Jelinek [Wed, 19 Jan 2011 19:57:54 +0000 (20:57 +0100)]
* ipa-split.c: Spelling fixes.

From-SVN: r169019

13 years agomn10300: Add support in longlong.h.
Richard Henderson [Wed, 19 Jan 2011 19:36:42 +0000 (11:36 -0800)]
mn10300: Add support in longlong.h.

This greatly helps out the DImode division, and to a lesser
extent the DImode multiplication routines in libgcc2.c.

From-SVN: r169018

13 years agomn10300: Use reg_or_am33_const_operand in mulsi3.
Richard Henderson [Wed, 19 Jan 2011 19:33:44 +0000 (11:33 -0800)]
mn10300: Use reg_or_am33_const_operand in mulsi3.

From-SVN: r169017

13 years ago* config/spu/spu.h (MOVE_RATIO): Return 4 in the !speed case.
Ulrich Weigand [Wed, 19 Jan 2011 19:05:14 +0000 (19:05 +0000)]
* config/spu/spu.h (MOVE_RATIO): Return 4 in the !speed case.

From-SVN: r169015

13 years agomn10300: Implement adddi3, subdi3.
Richard Henderson [Wed, 19 Jan 2011 18:55:12 +0000 (10:55 -0800)]
mn10300: Implement adddi3, subdi3.

Via expander, pre- and post-reload patterns.  The pre-reload
pattern is defined to allow lower_subregs totally split the
DImode values.

From-SVN: r169014

13 years agomn10300: Emit retf instruction
Richard Henderson [Wed, 19 Jan 2011 18:50:52 +0000 (10:50 -0800)]
mn10300: Emit retf instruction

Now that we properly track the life of MDR, we can emit
the RETF instruction if MDR has not been modified.  This
insn is 3-4 cycles faster since the return address is
already loaded.

From-SVN: r169013

13 years agomn10300: tidy pic address loading
Richard Henderson [Wed, 19 Jan 2011 18:46:30 +0000 (10:46 -0800)]
mn10300: tidy pic address loading

There's little reason to greatly complicate things by splitting
the pic_load patterns and using complex rtl to make it work out.
Instead, use the %= marker to generate unique numbers and emit
the entire load_pic sequence at once.

At the same time, collect all references to outgoing_args_size
into mn10300_frame_size, and all computations of register save
area size into mn10300_initial_offset.

From-SVN: r169012

13 years agomn10300: Cleanup all arithmetic.
Richard Henderson [Wed, 19 Jan 2011 18:38:56 +0000 (10:38 -0800)]
mn10300: Cleanup all arithmetic.

For addition and logicals, define an operation-plus-flags update pattern
in preparation for compare elimination.  In addition, clean up the way
we compare and validate CC_MODEs.  Define NEG in terms of NOT; this is
smaller and allows a non-clobbering destination alternative.

From-SVN: r169010