Simon Marchi [Mon, 27 Feb 2023 01:13:54 +0000 (20:13 -0500)]
gdb: remove invalid / dead code from gdbarch.py
My editor flagged that the variable `c` (in the lines removed by this
patch) was unknown. I guess it ends up working because there is a `c`
variable in the global scope. I tried putting `assert False` inside
that if, and it is not hit, showing that we never enter this if. So,
remove it. There is no change in the generated files.
Change-Id: Id3b9f67719e88cada7c6fde673c8d7842ab13617
Reviewed-By: Tom Tromey <tom@tromey.com>
Reviewed-By: Andrew Burgess <aburgess@redhat.com>
Tom Tromey [Thu, 9 Feb 2023 19:12:42 +0000 (12:12 -0700)]
Fix crash with "finish" in Rust
PR rust/30090 points out that a certain "finish" in a Rust program
will cause gdb to crash. This happens due to some confusion about
field indices in rust_language::print_enum. The fix is to use
value_primitive_field so that the correct type can be passed; other
spots in rust-lang.c already do this.
Note that the enclosed test case comes with an xfail. This is needed
because for this function, rustc doesn't follow the platform ABI.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30090
Tom Tromey [Wed, 8 Feb 2023 18:26:24 +0000 (11:26 -0700)]
Remove old GNU indent directives
Now that gdb_indent.sh has been removed, I think it makes sense to
also remove the directives intended for GNU indent.
Tom Tromey [Wed, 4 Jan 2023 16:36:59 +0000 (09:36 -0700)]
Handle range types in ax-gdb.c
A range type can usually be treated the same as its underlying integer
type, at least for the purposes of agent expressions. This patch
arranges for range types to be handled this way in ax-gdb.c, letting a
somewhat larger subset of Ada expressions be compiled.
Tom Tromey [Wed, 21 Dec 2022 18:52:37 +0000 (11:52 -0700)]
Implement some agent expressions for Ada
Ada historically has not implemented agent expressions, and some Ada
constructs probably cannot reasonably be converted to agent
expressions. However, a subset of simple operations can be, and this
patch represents a first step in that direction.
On one internal AdaCore test case, this improves the performance of a
conditional breakpoint from 5 minutes to 5 seconds.
The main tricky part in this patch is ensuring the converted
expressions detect the cases that will not work. This is done by
examining the code in the corresponding evaluation methods.
Pedro Alves [Fri, 24 Feb 2023 18:58:31 +0000 (18:58 +0000)]
Regenerate Linux syscall group info
This commit makes use of the new script to regenerate the Linux
syscall group info against strace git hash
e88e5e9ae6da68f22d15f9be3193b1412ac9aa02.
Like so:
$ cd gdb/syscalls/
$ ./update-linux-defaults.sh ~/strace.git/
Generating linux-defaults.xml.in
$ make
for f in aarch64-linux.xml amd64-linux.xml arm-linux.xml bfin-linux.xml \
i386-linux.xml mips-n32-linux.xml mips-n64-linux.xml \
mips-o32-linux.xml ppc64-linux.xml ppc-linux.xml s390-linux.xml \
s390x-linux.xml sparc64-linux.xml sparc-linux.xml; do \
xsltproc --output $f apply-defaults.xsl $f.in; \
done
The result is that a lot more syscalls end up assigned to groups.
Some lose their group info, but that just mirrors what strace does.
The gdb/syscalls/linux-defaults.xml.in file shows a large diff because
the new version is ASCII sorted, while the current version was
somewhat (but not consistently) sorted by "family" of syscalls.
If I sort the old file and diff against the new, the difference is
like this:
<syscall name="accept4" groups="network"/>
<syscall name="accept" groups="network"/>
<syscall name="access" groups="file"/>
<syscall name="acct" groups="file"/>
- <syscall name="arch_prctl" groups="process"/>
<syscall name="bind" groups="network"/>
+ <syscall name="bpf" groups="descriptor"/>
<syscall name="break" groups="memory"/>
<syscall name="brk" groups="memory"/>
+ <syscall name="bsd43_fstatfs" groups="descriptor"/>
+ <syscall name="bsd43_fstat" groups="descriptor"/>
+ <syscall name="bsd43_killpg" groups="process"/>
+ <syscall name="bsd43_kill" groups="process"/>
+ <syscall name="bsd43_lstat" groups="file"/>
+ <syscall name="bsd43_madvise" groups="memory"/>
+ <syscall name="bsd43_mincore" groups="memory"/>
+ <syscall name="bsd43_mmap" groups="descriptor,memory"/>
+ <syscall name="bsd43_mprotect" groups="memory"/>
+ <syscall name="bsd43_mremap" groups="memory"/>
+ <syscall name="bsd43_munmap" groups="memory"/>
+ <syscall name="bsd43_oldfstat" groups="descriptor"/>
+ <syscall name="bsd43_oldstat" groups="file"/>
+ <syscall name="bsd43_quotactl" groups="file"/>
+ <syscall name="bsd43_sbreak" groups="memory"/>
+ <syscall name="bsd43_sbrk" groups="memory"/>
+ <syscall name="bsd43_statfs" groups="file"/>
+ <syscall name="bsd43_stat" groups="file"/>
+ <syscall name="cacheflush" groups="memory"/>
<syscall name="chdir" groups="file"/>
<syscall name="chmod" groups="file"/>
<syscall name="chown32" groups="file"/>
<syscall name="chown" groups="file"/>
<syscall name="chroot" groups="file"/>
+ <syscall name="clone2" groups="process"/>
+ <syscall name="clone3" groups="process"/>
<syscall name="clone" groups="process"/>
<syscall name="close" groups="descriptor"/>
<syscall name="connect" groups="network"/>
+ <syscall name="copy_file_range" groups="descriptor"/>
<syscall name="creat" groups="descriptor,file"/>
<syscall name="dup2" groups="descriptor"/>
<syscall name="dup3" groups="descriptor"/>
@@ -28,14 +52,17 @@
<syscall name="epoll_create1" groups="descriptor"/>
<syscall name="epoll_create" groups="descriptor"/>
<syscall name="epoll_ctl" groups="descriptor"/>
+ <syscall name="epoll_pwait2" groups="descriptor"/>
<syscall name="epoll_pwait" groups="descriptor"/>
<syscall name="epoll_wait" groups="descriptor"/>
<syscall name="eventfd2" groups="descriptor"/>
<syscall name="eventfd" groups="descriptor"/>
+ <syscall name="execveat" groups="descriptor,file,process"/>
<syscall name="execve" groups="file,process"/>
<syscall name="execv" groups="file,process"/>
<syscall name="exit_group" groups="process"/>
<syscall name="exit" groups="process"/>
+ <syscall name="faccessat2" groups="descriptor,file"/>
<syscall name="faccessat" groups="descriptor,file"/>
<syscall name="fadvise64_64" groups="descriptor"/>
<syscall name="fadvise64" groups="descriptor"/>
@@ -57,7 +84,11 @@
<syscall name="flock" groups="descriptor"/>
<syscall name="fork" groups="process"/>
<syscall name="fremovexattr" groups="descriptor"/>
+ <syscall name="fsconfig" groups="descriptor,file"/>
<syscall name="fsetxattr" groups="descriptor"/>
+ <syscall name="fsmount" groups="descriptor"/>
+ <syscall name="fsopen" groups="descriptor"/>
+ <syscall name="fspick" groups="descriptor,file"/>
<syscall name="fstat64" groups="descriptor"/>
<syscall name="fstatat64" groups="descriptor,file"/>
<syscall name="fstatfs64" groups="descriptor"/>
@@ -72,16 +103,26 @@
<syscall name="getdents" groups="descriptor"/>
<syscall name="get_mempolicy" groups="memory"/>
<syscall name="getpeername" groups="network"/>
+ <syscall name="getpmsg" groups="network"/>
<syscall name="getsockname" groups="network"/>
<syscall name="getsockopt" groups="network"/>
<syscall name="getxattr" groups="file"/>
- <syscall name="inotify_add_watch" groups="descriptor"/>
+ <syscall name="inotify_add_watch" groups="descriptor,file"/>
<syscall name="inotify_init1" groups="descriptor"/>
<syscall name="inotify_init" groups="descriptor"/>
<syscall name="inotify_rm_watch" groups="descriptor"/>
<syscall name="ioctl" groups="descriptor"/>
+ <syscall name="io_destroy" groups="memory"/>
+ <syscall name="io_setup" groups="memory"/>
+ <syscall name="io_uring_enter" groups="descriptor,signal"/>
+ <syscall name="io_uring_register" groups="descriptor,memory"/>
+ <syscall name="io_uring_setup" groups="descriptor"/>
<syscall name="ipc" groups="ipc"/>
- <syscall name="kill" groups="signal"/>
+ <syscall name="kexec_file_load" groups="descriptor"/>
+ <syscall name="kill" groups="signal,process"/>
+ <syscall name="landlock_add_rule" groups="descriptor"/>
+ <syscall name="landlock_create_ruleset" groups="descriptor"/>
+ <syscall name="landlock_restrict_self" groups="descriptor"/>
<syscall name="lchown32" groups="file"/>
<syscall name="lchown" groups="file"/>
<syscall name="lgetxattr" groups="file"/>
@@ -98,19 +139,31 @@
<syscall name="lstat" groups="file"/>
<syscall name="madvise" groups="memory"/>
<syscall name="mbind" groups="memory"/>
+ <syscall name="memfd_create" groups="descriptor"/>
+ <syscall name="memfd_secret" groups="descriptor"/>
<syscall name="migrate_pages" groups="memory"/>
<syscall name="mincore" groups="memory"/>
<syscall name="mkdirat" groups="descriptor,file"/>
<syscall name="mkdir" groups="file"/>
<syscall name="mknodat" groups="descriptor,file"/>
<syscall name="mknod" groups="file"/>
+ <syscall name="mlock2" groups="memory"/>
<syscall name="mlockall" groups="memory"/>
<syscall name="mlock" groups="memory"/>
<syscall name="mmap2" groups="descriptor,memory"/>
<syscall name="mmap" groups="descriptor,memory"/>
+ <syscall name="mount_setattr" groups="descriptor,file"/>
<syscall name="mount" groups="file"/>
+ <syscall name="move_mount" groups="descriptor,file"/>
<syscall name="move_pages" groups="memory"/>
<syscall name="mprotect" groups="memory"/>
+ <syscall name="mq_getsetattr" groups="descriptor"/>
+ <syscall name="mq_notify" groups="descriptor"/>
+ <syscall name="mq_open" groups="descriptor"/>
+ <syscall name="mq_timedreceive" groups="descriptor"/>
+ <syscall name="mq_timedreceive_time64" groups="descriptor"/>
+ <syscall name="mq_timedsend" groups="descriptor"/>
+ <syscall name="mq_timedsend_time64" groups="descriptor"/>
<syscall name="mremap" groups="memory"/>
<syscall name="msgctl" groups="ipc"/>
<syscall name="msgget" groups="ipc"/>
@@ -126,45 +179,98 @@
<syscall name="oldfstat" groups="descriptor"/>
<syscall name="oldlstat" groups="file"/>
<syscall name="oldstat" groups="file"/>
+ <syscall name="oldumount" groups="file"/>
+ <syscall name="openat2" groups="descriptor,file"/>
<syscall name="openat" groups="descriptor,file"/>
<syscall name="open_by_handle_at" groups="descriptor"/>
<syscall name="open" groups="descriptor,file"/>
+ <syscall name="open_tree" groups="descriptor,file"/>
+ <syscall name="osf_fstatfs64" groups="descriptor"/>
+ <syscall name="osf_fstatfs" groups="descriptor"/>
+ <syscall name="osf_fstat" groups="descriptor"/>
+ <syscall name="osf_lstat" groups="file"/>
+ <syscall name="osf_mincore" groups="memory"/>
+ <syscall name="osf_mremap" groups="memory"/>
+ <syscall name="osf_old_fstat" groups="descriptor"/>
+ <syscall name="osf_old_killpg" groups="process"/>
+ <syscall name="osf_old_lstat" groups="file"/>
+ <syscall name="osf_old_stat" groups="file"/>
+ <syscall name="osf_sbrk" groups="memory"/>
+ <syscall name="osf_select" groups="descriptor"/>
+ <syscall name="osf_shmat" groups="ipc,memory"/>
+ <syscall name="osf_sigprocmask" groups="signal"/>
+ <syscall name="osf_statfs64" groups="file"/>
+ <syscall name="osf_statfs" groups="file"/>
+ <syscall name="osf_stat" groups="file"/>
+ <syscall name="osf_utimes" groups="file"/>
+ <syscall name="osf_wait4" groups="process"/>
<syscall name="pause" groups="signal"/>
<syscall name="perf_event_open" groups="descriptor"/>
+ <syscall name="pidfd_getfd" groups="descriptor"/>
+ <syscall name="pidfd_open" groups="descriptor"/>
+ <syscall name="pidfd_send_signal" groups="descriptor,signal,process"/>
<syscall name="pipe2" groups="descriptor"/>
<syscall name="pipe" groups="descriptor"/>
<syscall name="pivot_root" groups="file"/>
+ <syscall name="pkey_mprotect" groups="memory"/>
<syscall name="poll" groups="descriptor"/>
+ <syscall name="posix_fstatfs" groups="descriptor"/>
+ <syscall name="posix_fstat" groups="descriptor"/>
+ <syscall name="posix_kill" groups="process"/>
+ <syscall name="posix_lstat" groups="file"/>
+ <syscall name="posix_madvise" groups="memory"/>
+ <syscall name="posix_mmap" groups="descriptor,memory"/>
+ <syscall name="posix_munmap" groups="memory"/>
+ <syscall name="posix_sbreak" groups="memory"/>
+ <syscall name="posix_SGI_madvise" groups="memory"/>
+ <syscall name="posix_SGI_mmap" groups="descriptor,memory"/>
+ <syscall name="posix_SGI_mprotect" groups="memory"/>
+ <syscall name="posix_SGI_msync" groups="memory"/>
+ <syscall name="posix_SGI_munmap" groups="memory"/>
+ <syscall name="posix_statfs" groups="file"/>
+ <syscall name="posix_stat" groups="file"/>
<syscall name="ppoll" groups="descriptor"/>
+ <syscall name="ppoll_time64" groups="descriptor"/>
<syscall name="pread64" groups="descriptor"/>
<syscall name="pread" groups="descriptor"/>
+ <syscall name="preadv2" groups="descriptor"/>
<syscall name="preadv" groups="descriptor"/>
+ <syscall name="process_madvise" groups="descriptor"/>
+ <syscall name="process_mrelease" groups="descriptor"/>
<syscall name="pselect6" groups="descriptor"/>
+ <syscall name="pselect6_time64" groups="descriptor"/>
+ <syscall name="putpmsg" groups="network"/>
<syscall name="pwrite64" groups="descriptor"/>
<syscall name="pwrite" groups="descriptor"/>
+ <syscall name="pwritev2" groups="descriptor"/>
<syscall name="pwritev" groups="descriptor"/>
+ <syscall name="quotactl_fd" groups="descriptor"/>
<syscall name="quotactl" groups="file"/>
<syscall name="readahead" groups="descriptor"/>
<syscall name="readdir" groups="descriptor"/>
- <syscall name="read" groups="descriptor"/>
<syscall name="readlinkat" groups="descriptor,file"/>
<syscall name="readlink" groups="file"/>
+ <syscall name="read" groups="descriptor"/>
<syscall name="readv" groups="descriptor"/>
<syscall name="recvfrom" groups="network"/>
- <syscall name="recv" groups="network"/>
+ <syscall name="recvmmsg_time64" groups="network"/>
<syscall name="recvmmsg" groups="network"/>
<syscall name="recvmsg" groups="network"/>
+ <syscall name="recv" groups="network"/>
<syscall name="remap_file_pages" groups="memory"/>
<syscall name="removexattr" groups="file"/>
+ <syscall name="renameat2" groups="descriptor,file"/>
<syscall name="renameat" groups="descriptor,file"/>
<syscall name="rename" groups="file"/>
+ <syscall name="riscv_flush_icache" groups="memory"/>
<syscall name="rmdir" groups="file"/>
<syscall name="rt_sigaction" groups="signal"/>
<syscall name="rt_sigpending" groups="signal"/>
<syscall name="rt_sigprocmask" groups="signal"/>
- <syscall name="rt_sigqueueinfo" groups="signal"/>
+ <syscall name="rt_sigqueueinfo" groups="signal,process"/>
<syscall name="rt_sigreturn" groups="signal"/>
<syscall name="rt_sigsuspend" groups="signal"/>
+ <syscall name="rt_sigtimedwait_time64" groups="signal"/>
<syscall name="rt_sigtimedwait" groups="signal"/>
<syscall name="rt_tgsigqueueinfo" groups="process,signal"/>
<syscall name="select" groups="descriptor"/>
@@ -172,12 +278,14 @@
<syscall name="semget" groups="ipc"/>
<syscall name="semop" groups="ipc"/>
<syscall name="semtimedop" groups="ipc"/>
+ <syscall name="semtimedop_time64" groups="ipc"/>
<syscall name="sendfile64" groups="descriptor,network"/>
<syscall name="sendfile" groups="descriptor,network"/>
- <syscall name="send" groups="network"/>
<syscall name="sendmmsg" groups="network"/>
<syscall name="sendmsg" groups="network"/>
+ <syscall name="send" groups="network"/>
<syscall name="sendto" groups="network"/>
+ <syscall name="set_mempolicy_home_node" groups="memory"/>
<syscall name="set_mempolicy" groups="memory"/>
<syscall name="setns" groups="descriptor"/>
<syscall name="setsockopt" groups="network"/>
@@ -198,38 +306,78 @@
<syscall name="sigreturn" groups="signal"/>
<syscall name="sigsuspend" groups="signal"/>
<syscall name="socketcall" groups="descriptor"/>
- <syscall name="socket" groups="network"/>
<syscall name="socketpair" groups="network"/>
+ <syscall name="socket" groups="network"/>
<syscall name="splice" groups="descriptor"/>
<syscall name="ssetmask" groups="signal"/>
<syscall name="stat64" groups="file"/>
<syscall name="statfs64" groups="file"/>
<syscall name="statfs" groups="file"/>
<syscall name="stat" groups="file"/>
+ <syscall name="statx" groups="descriptor,file"/>
+ <syscall name="svr4_fstatfs" groups="descriptor"/>
+ <syscall name="svr4_fstat" groups="descriptor"/>
+ <syscall name="svr4_fstatvfs" groups="descriptor"/>
+ <syscall name="svr4_fxstat" groups="descriptor"/>
+ <syscall name="svr4_kill" groups="process"/>
+ <syscall name="svr4_lstat" groups="file"/>
+ <syscall name="svr4_lxstat" groups="file"/>
+ <syscall name="svr4_mincore" groups="memory"/>
+ <syscall name="svr4_mmap" groups="descriptor,memory"/>
+ <syscall name="svr4_mprotect" groups="memory"/>
+ <syscall name="svr4_munmap" groups="memory"/>
+ <syscall name="svr4_sbreak" groups="memory"/>
+ <syscall name="svr4_statfs" groups="file"/>
+ <syscall name="svr4_stat" groups="file"/>
+ <syscall name="svr4_statvfs" groups="file"/>
+ <syscall name="svr4_xstat" groups="file"/>
<syscall name="swapoff" groups="file"/>
<syscall name="swapon" groups="file"/>
<syscall name="symlinkat" groups="descriptor,file"/>
<syscall name="symlink" groups="file"/>
+ <syscall name="sync_file_range2" groups="descriptor"/>
<syscall name="sync_file_range" groups="descriptor"/>
<syscall name="syncfs" groups="descriptor"/>
+ <syscall name="sysv_brk" groups="memory"/>
+ <syscall name="sysv_fstatfs" groups="descriptor"/>
+ <syscall name="sysv_fstat" groups="descriptor"/>
+ <syscall name="sysv_fstatvfs" groups="descriptor"/>
+ <syscall name="sysv_fxstat" groups="descriptor"/>
+ <syscall name="sysv_kill" groups="process"/>
+ <syscall name="sysv_lstat" groups="file"/>
+ <syscall name="sysv_lxstat" groups="file"/>
+ <syscall name="sysv_madvise" groups="memory"/>
+ <syscall name="sysv_mmap64" groups="descriptor,memory"/>
+ <syscall name="sysv_mmap" groups="descriptor,memory"/>
+ <syscall name="sysv_mprotect" groups="memory"/>
+ <syscall name="sysv_msync" groups="memory"/>
+ <syscall name="sysv_munmap" groups="memory"/>
+ <syscall name="sysv_quotactl" groups="file"/>
+ <syscall name="sysv_statfs" groups="file"/>
+ <syscall name="sysv_stat" groups="file"/>
+ <syscall name="sysv_statvfs" groups="file"/>
+ <syscall name="sysv_xstat" groups="file"/>
<syscall name="tee" groups="descriptor"/>
- <syscall name="tgkill" groups="signal"/>
+ <syscall name="tgkill" groups="signal,process"/>
<syscall name="timerfd_create" groups="descriptor"/>
+ <syscall name="timerfd_gettime64" groups="descriptor"/>
<syscall name="timerfd_gettime" groups="descriptor"/>
- <syscall name="timerfd" groups="descriptor"/>
+ <syscall name="timerfd_settime64" groups="descriptor"/>
<syscall name="timerfd_settime" groups="descriptor"/>
- <syscall name="tkill" groups="signal"/>
+ <syscall name="timerfd" groups="descriptor"/>
+ <syscall name="tkill" groups="signal,process"/>
<syscall name="truncate64" groups="file"/>
<syscall name="truncate" groups="file"/>
<syscall name="umount2" groups="file"/>
<syscall name="umount" groups="file"/>
<syscall name="unlinkat" groups="descriptor,file"/>
<syscall name="unlink" groups="file"/>
- <syscall name="unshare" groups="process"/>
<syscall name="uselib" groups="file"/>
- <syscall name="utime" groups="file"/>
+ <syscall name="userfaultfd" groups="descriptor"/>
<syscall name="utimensat" groups="descriptor,file"/>
+ <syscall name="utimensat_time64" groups="descriptor,file"/>
<syscall name="utimes" groups="file"/>
+ <syscall name="utime" groups="file"/>
<syscall name="vfork" groups="process"/>
<syscall name="vmsplice" groups="descriptor"/>
<syscall name="wait4" groups="process"/>
Change-Id: I679d59d42fb2a914bf7a99e4c558e9696e5adff1
Pedro Alves [Fri, 24 Feb 2023 18:58:31 +0000 (18:58 +0000)]
Autogenerate gdb/syscalls/linux-defaults.xml.in (groups) from strace sources
I noticed that "catch syscall group:process" doesn't catch clone3,
while it does catch clone.
The catch syscall group information is recorded in the
gdb/syscalls/linux-defaults.xml.in file, which says:
<!-- The group field information was based on strace. -->
So I looked at the strace sources, to confirm that clone3 is in fact
recorded in the "process" group there too, and to check what other
syscalls might be missing groups.
After some digging, I found that strace records the group info in C
arrays, with entries like:
...
[ 61] = { 4, TP, SEN(wait4), "wait4" },
[ 62] = { 2, TS|TP, SEN(kill), "kill" },
[ 63] = { 1, 0, SEN(uname), "uname" },
...
You can see the current master's table for Linux x86-64 here:
https://github.com/strace/strace/blob/
e88e5e9ae6da68f22d15f9be3193b1412ac9aa02/src/linux/x86_64/syscallent.h
The column with TS|TP above is what defines each syscall's groups. So
I wrote a script that extracts this information and generates
linux-defaults.xml.in.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Change-Id: I679d59d42fb2a914bf7a99e4c558e9696e5adff1
Clément Chigot [Mon, 27 Feb 2023 12:57:12 +0000 (13:57 +0100)]
gas/testsuite: adjust another test for case insensitive file systems
As
1fafeaac8503eea2f61c3a35f0eef183b7e7cc65, "line.s" and "Line.s" are
identical in case insensitive file systems. Thus, gas doesn't trigger
an input file switch.
gas/ChangeLog:
* testsuite/gas/elf/dwarf-5-macro.s: Change Line.s to Line2.s.
Andrew Burgess [Mon, 20 Feb 2023 13:14:55 +0000 (13:14 +0000)]
gdb: don't treat empty enums as flag enums
In C++ it is possible to use an empty enum as a strong typedef. For
example, a user could write:
enum class my_type : unsigned char {};
Now my_type can be used like 'unsigned char' except the compiler will
not allow implicit conversion too and from the native 'unsigned char'
type.
This is used in the standard library for things like std::byte.
Currently, when GDB prints a value of type my_type, it looks like
this:
(gdb) print my_var
$1 = (unknown: 0x4)
Which isn't great. This gets worse when we consider something like:
std::vector<my_type> vec;
When using a pretty-printer, this could look like this:
std::vector of length 2, capacity 2 = {(unknown: 0x2), (unknown: 0x4)}
Clearly not great. This is described in PR gdb/30148.
The problem here is in dwarf2/read.c, we assume all enums are flag
enums unless we find an enumerator with a non-flag like value.
Clearly an empty enum contains no non-flag values, so we assume the
enum is a flag enum.
I propose adding an extra check here; that is, an empty enum should
never be a flag enum.
With this the above cases look more like:
(gdb) print my_var
$1 = 4
and:
std::vector of length 2, capacity 2 = {2, 4}
Which look much better.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30148
Reviewed-By: Tom Tromey <tom@tromey.com>
Benson Muite [Mon, 27 Feb 2023 13:35:49 +0000 (13:35 +0000)]
Do not change the timestamp when updating the gas asconfig file.
PR 28909 * doc/local.mk (asconfig.texi): Use "cp -p" to preserve timestamps. * Makefile.in: Regenerate.
Felix Willgerodt [Mon, 27 Feb 2023 13:01:06 +0000 (13:01 +0000)]
Fix missing "Core was generated by" when loading a x32 corefile.
Nick Clifton [Mon, 27 Feb 2023 12:50:31 +0000 (12:50 +0000)]
Updated Serbian translations for gold, gprof and opcodes sub-directories
Bruno Larsen [Tue, 21 Feb 2023 16:10:31 +0000 (17:10 +0100)]
gdb/testsuite: Improve testing of GDB's completion functions
When looking at some failures of gdb.linespec/cp-completion-aliases.exp,
I noticed that when a completion test will fail, it always fails with a
timeout. This is because most completion tests use gdb_test_multiple
and only add a check for the correct output. This commit adds new
options for both, tab and command completion.
For command completion, the new option will check if the prompt was
printed, and fail in this case. This is enough to know that the test has
failed because the check comes after the PASS path. For tab completion,
we have to check if GDB outputted more than just the input line, because
sometimes GDB would have printed a partial line before finishing with
the correct completion.
Approved-By: Tom Tromey <tom@tromey.com>
Tankut Baris Aktemur [Mon, 27 Feb 2023 09:28:40 +0000 (10:28 +0100)]
gdb, python: do minor modernization in execute_gdb_command
Use nullptr instead of NULL and boolify two local variables in
execute_gdb_command.
Approved-By: Tom Tromey <tom@tromey.com>
GDB Administrator [Mon, 27 Feb 2023 00:00:09 +0000 (00:00 +0000)]
Automatic date update in version.in
Tom Tromey [Sun, 26 Feb 2023 16:49:02 +0000 (09:49 -0700)]
Remove expand_symtab_containing_pc
The function expand_symtab_containing_pc is unused; remove it.
Tested by rebuilding.
GDB Administrator [Sun, 26 Feb 2023 00:00:19 +0000 (00:00 +0000)]
Automatic date update in version.in
Andrew Burgess [Thu, 23 Feb 2023 10:34:39 +0000 (10:34 +0000)]
gdb/amd64: replace xmalloc/alloca with gdb::byte_vector
Replace a couple of uses of xmalloc and alloc with a gdb::byte_vector
local variable instead.
There should be no user visible changes after this commit.
Reviewed-By: Tom Tromey <tom@tromey.com>
Andrew Burgess [Sat, 25 Feb 2023 10:16:34 +0000 (10:16 +0000)]
opcodes/m68k: enable libopcodes styling for GDB
The following commit added libopcodes styling for m68k:
commit
c22ff449275c91e4842bb10c650e83c572580f65
Date: Tue Feb 14 18:07:19 2023 +0100
opcodes: style m68k disassembler output
but didn't set disassemble_info::created_styled_output in
disassemble.c, which is needed in order for GDB to start using the
libopcodes based styling.
This commit fixes this small oversight. GDB now styles correctly.
GDB Administrator [Sat, 25 Feb 2023 00:00:12 +0000 (00:00 +0000)]
Automatic date update in version.in
Khem Raj [Thu, 23 Feb 2023 00:28:22 +0000 (16:28 -0800)]
gdbserver/linux-low.cc: Fix a typo in ternary operator
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Tom Tromey [Fri, 16 Dec 2022 19:50:29 +0000 (12:50 -0700)]
Remove struct buffer
I've long wanted to remove 'struct buffer', and thanks to Simon's
earlier patch, I was finally able to do so. My feeling has been that
gdb already has several decent structures available for growing
strings: std::string of course, but also obstack and even objalloc
from BFD and dyn-string from libiberty. The previous patches in this
series removed all the uses of struct buffer, so this one can remove
the code and the remaining #includes.
Tom Tromey [Fri, 16 Dec 2022 19:53:20 +0000 (12:53 -0700)]
Don't use struct buffer in top.c
This changes top.c to use std::string rather than struct buffer. Like
the event-top.c change, this is not completely ideal in that it
requires a copy of the string.
Tom Tromey [Fri, 16 Dec 2022 19:45:40 +0000 (12:45 -0700)]
Don't use struct buffer in event-top.c
This changes event-top.c to use std::string rather than struct buffer.
This isn't completely ideal, in that it requires a copy of the string
to be made.
Tom Tromey [Fri, 16 Dec 2022 14:59:52 +0000 (07:59 -0700)]
Don't use struct buffer in handle_qxfer_threads
This changes handle_qxfer_threads, in gdbserver, to use std::string
rather than struct buffer.
Tom Tromey [Fri, 16 Dec 2022 14:56:57 +0000 (07:56 -0700)]
Don't use struct buffer in handle_qxfer_btrace
This changes handle_qxfer_btrace and handle_qxfer_btrace_conf, in
gdbserver, to use std::string rather than struct buffer.
Tom Tromey [Fri, 16 Dec 2022 14:49:01 +0000 (07:49 -0700)]
Don't use struct buffer in handle_qxfer_traceframe_info
This changes handle_qxfer_traceframe_info, in gdbserver, to use
std::string rather than struct buffer.
Tom Tromey [Fri, 16 Dec 2022 14:42:47 +0000 (07:42 -0700)]
Remove struct buffer from tracefile-tfile.c
This changes tracefile-tfile.c to use std::string rather than struct
buffer.
Tom Tromey [Wed, 13 Apr 2022 17:25:53 +0000 (11:25 -0600)]
Write the DWARF index in the background
The new DWARF cooked indexer interacts poorly with the DWARF index
cache. In particular, the cache will require gdb to wait for the
cooked index to be finalized. As this happens in the foreground, it
means that users with this setting enabled will see a slowdown.
This patch changes gdb to write the cache entry a worker thread. (As
usual, in the absence of threads, this work is simply done immediately
in the main thread.)
Some care is taken to ensure that this can't crash, and that gdb will
not exit before the task is complete.
To avoid use-after-free problems, the DWARF per-BFD object explicitly
waits for the index cache task to complete.
To avoid gdb exiting early, an exit observer is used to wait for all
such pending tasks.
In normal use, neither of these waits will be very visible. For users
using "-batch" to pre-generate the index, though, it would be.
However I don't think there is much to be done about this, as it was
the status quo ante.
Tom Tromey [Wed, 13 Apr 2022 17:21:20 +0000 (11:21 -0600)]
Only use the per-BFD object to write a DWARF index
The DWARF index does not need access to the objfile or per-objfile
objects when writing -- it's entirely based on the objfile-independent
per-BFD data.
This patch implements this idea by changing the entire API to only be
passed the per-BFD object. This simplifies some lifetime reasoning
for the next patch.
This patch removes some code that ensures that the BFD came from a
file. It seems to me that checking for the existence of a build-id is
good enough for the index cache.
Simon Marchi [Fri, 24 Feb 2023 17:31:39 +0000 (12:31 -0500)]
gdb: fix parenthesis position in comment
Change-Id: I535b597ab4482378910570d8dd69c090419941eb
Clément Chigot [Tue, 21 Feb 2023 14:07:58 +0000 (15:07 +0100)]
testsuite: prune DOS drive letter in test outputs
On DOS systems, absolute paths start with the drive letter. This can
trigger failures in the regexp from dump tests, especially for those
checking for warnings or errors. They are usually skipping everything
before the first ":" as it has to be the file path.
| [^:]*: warning: ...
In order to avoid modifying many regexps to allow such drive letters,
prune them from all the outputs if they are found at the beginning of
a line.
binutils/ChangeLog:
* testsuite/lib/binutils-common.exp (prune_dump_output): New
(run_dump_test): Use it.
ld/ChangeLog:
* testsuite/ld-elf/noinit-sections-2.l: Remove DOS drive letter
handler.
Jan Beulich [Fri, 24 Feb 2023 13:00:11 +0000 (14:00 +0100)]
x86: allow to request ModR/M encoding
Several insns have a (typically shorter) non-ModR/M and a (typically
longer) ModR/M encoding. In most cases the former is used by default.
This isn't too dissimilar from register-only insns sometimes having two
encoding forms. In those cases {load} or {store} can be used to control
the encoding used. Extend this to ModR/M-less encodings which have a
ModR/M counterpart (note that BSWAP hasn't). For insn reading and
writing their (explicit) memory operand, both prefixes are honored;
otherwise only the applicable one is.
Note that for some forms of XCHG, {store} has already been performing
this function, apparently as an unnoticed side effect of adding D to
the template.
Jan Beulich [Fri, 24 Feb 2023 12:59:35 +0000 (13:59 +0100)]
x86: MONITOR/MWAIT are not SSE3 insns
These have their own CPUID bit and hence they should also have their own
separate control.
Jan Beulich [Fri, 24 Feb 2023 12:58:35 +0000 (13:58 +0100)]
x86-64: don't permit LAHF/SAHF with "generic64"
The feature isn't universally available on 64-bit CPUs.
Note that in i386-gen.c:isa_dependencies[] I'm only adding it to models
where I'm certain the functionality exists. For Nocona and Core I'm
uncertain in particular.
Jan Beulich [Fri, 24 Feb 2023 12:57:31 +0000 (13:57 +0100)]
x86: have insns acting on segment selector values allow for consistent operands
While MOV to/from segment register as well as selector storing insns
already permit 32- and 64-bit GPR operands, selector loading insns and
ARPL do not. Split templates accordingly.
Jan Beulich [Fri, 24 Feb 2023 12:56:57 +0000 (13:56 +0100)]
x86: restrict insn templates accepting negative 8-bit immediates
For shifts (but not ordinary rotates) and other cases where an immediate
describes e.g. a bit count or position, allowing negative operands is at
best confusing. An extreme example would be the two rotate-through-carry
insns, where a negative value would _not_ mean rotating the
corresponding number of bits in the other direction. To refuse such,
give meaning to the combination of Imm8 and Imm8S in templates (so far
these weren't used together anywhere). The issue was with
smallest_imm_type() blindly setting .imm8 for signed numbers determined
to fit in a byte.
VPROT{B,W,D,Q} is a little special: The rotate count there is a signed
quantity, so Imm8 is replaced by Imm8S. Adjust affected testcases
accordingly as well.
Another small adjustment to the testsuite is necessary: AAM and AAD were
never sensible to use with 0xffffff90 operands. This should have been an
error.
Tom de Vries [Fri, 24 Feb 2023 12:52:12 +0000 (13:52 +0100)]
[gdb/testsuite] Cleanup unnecessary expr from require line
In a recent commit I've added:
...
require {expr [have_compile_flag -fsplit-stack]}
...
but actually the expr bit is unnecessary, and we can just use:
...
require {have_compile_flag -fsplit-stack}
...
Reported-By: Tom Tromey <tom@tromey.com>
Maciej W. Rozycki [Fri, 24 Feb 2023 12:37:22 +0000 (12:37 +0000)]
GDB: Fix out of bounds accesses with limited-length values
Fix accesses to limited-length values in `contents_copy_raw' and
`contents_copy_raw_bitwise' so that they observe the limit of the
original allocation.
Reported by Simon Marchi as a heap-buffer-overflow AddressSanitizer
issue triggered with gdb.ada/limited-length.exp.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Nick Clifton [Fri, 24 Feb 2023 12:25:50 +0000 (12:25 +0000)]
Enhance better_fit() function to prefer function symbols over non-function symbols.
Alan Modra [Thu, 23 Feb 2023 07:53:12 +0000 (18:23 +1030)]
PR30155, ld segfault in _bfd_nearby_section
The segfault was a symptom of messing with the absolute section next
field, confusing bfd_section_removed_from_list in linker.c:fix_syms.
That's not all that was going wrong. The INSERT list of output
sections was being inserted into itself, ie. lost from the main
list of linker statements.
PR 30155
* ldlang.c (process_insert_statements): Handle pathological
case of the insert script being inserted before the first
output section statement in the default script.
(output_prev_sec_find): Don't test section owner here.
(insert_os_after): Change parameter to a list union pointer.
(lang_insert_orphan): Test section owner here and adjust
insert_os_after call.
Fangrui Song [Fri, 24 Feb 2023 06:11:14 +0000 (22:11 -0800)]
RISC-V: Add --[no-]relax-gp to ld
--relax enables all relaxations. --no-relax-gp disables GP relaxation to
allow measuring its effect.
The option can test effectiveness of GP relaxation and support some ABI
variants that use GP for other purposes.
Link: https://github.com/riscv-non-isa/riscv-elf-psabi-doc/issues/298
bfd/
* elfnn-riscv.c (struct riscv_elf_link_hash_table): Add params.
(riscv_elfNN_set_options): New.
(riscv_info_to_howto_rela): Check relax_gp.
(_bfd_riscv_relax_section): Likewise.
* elfxx-riscv.h (struct riscv_elf_params): New.
(riscv_elf32_set_options): New.
(riscv_elf64_set_options): New.
ld/
* emultempl/riscvelf.em: Add option parsing.
* testsuite/ld-riscv-elf/code-model-relax-medlow-01-norelaxgp.d: New.
* testsuite/ld-riscv-elf/pcgp-relax-01-norelaxgp.d: New.
* testsuite/ld-riscv-elf/pcgp-relax-02.d: Test --relax --relax-gp can be
used together.
GDB Administrator [Fri, 24 Feb 2023 00:00:11 +0000 (00:00 +0000)]
Automatic date update in version.in
Palmer Dabbelt [Thu, 26 Jan 2023 23:09:29 +0000 (15:09 -0800)]
gdb/doc: The RISC-V vector registers didn't change
When we merged the GDB vector register support we did it a bit early,
just eating the risk in the very unlikely case that the vector register
names changed. They didn't, so we can now remove the caveat in the docs
that they might.
Simon Marchi [Tue, 14 Feb 2023 16:13:43 +0000 (11:13 -0500)]
gdb: remove --disable-gdbmi configure option
I noticed that the --disable-gdbmi option was broken for almost a year
(since
740b42ceb7c "gdb/python/mi: create MI commands using python").
The problem today is the python/py-cmd.c file. It is included in the
build if Python support is enabled, and it calls into some MI functions
(e.g. insert_mi_cmd_entry). If MI support is disabled, we get some
undefined symbols like:
mold: error: undefined symbol: insert_mi_cmd_entry(std::unique_ptr<mi_command, std::default_delete<mi_command> >)
>>> referenced by py-micmd.c
>>> python/py-micmd.o:(micmdpy_install_command(micmdpy_object*))
The python/py-cmd.c file should be included in the build if both Python
and MI support are enabled. It is not a case we support today, but it
could be done with a bit more configure code. However, I think we
should just remove the --disable-gdbmi option, and just include MI
support unconditionally.
Tom Tromey proposed a while ago to remove this option, but it ended
staying:
https://inbox.sourceware.org/gdb-patches/
20180628172132.28843-1-tom@tromey.com/
However, there was no strong opposition to remove it. The argument was
just "bah, it doesn't hurt anybody".
But given today's case, I would rather remove complexity rather than add
some. I couldn't find anybody caring deeply for that option, and it's
not like MI adds any external dependency. It's just a bit more code.
Removing the option will not break anybody using --disable-gdbmi (it can
be found in many build scripts [1]), since we don't flag invalid
configure flags.
So, remove the option from configure.ac, and adjust Makefile.in
accordingly to always include the MI objects in the build.
[1] https://github.com/search?q=%22--disable-gdbmi%22&type=code
Change-Id: Ifcaa8c9fc4abc6fa686ed5fd984598644f745240
Approved-By: Tom Tromey <tom@tromey.com>
Tom Tromey [Wed, 15 Feb 2023 21:57:10 +0000 (14:57 -0700)]
Fix Tcl quoting in gdb_assert
The gdb_assert proc under-quotes the expression that is passed in.
This leads to weird code in a couple of spots that tries to
compensate:
gdb_assert {{$all_regs eq $completed_regs}} ...
The fix is to add a bit of quoting when evaluating the expression.
Nick Clifton [Thu, 23 Feb 2023 17:27:07 +0000 (17:27 +0000)]
Fix _bfd_elf_find_function so that it can cope with overlapping symbols
Simon Marchi [Thu, 23 Feb 2023 16:27:23 +0000 (11:27 -0500)]
gdb: add AMDGPU header files to HFILES_NO_SRCDIR
Commit
18b4d0736bc5 ("gdb: initial support for ROCm platform (AMDGPU)
debugging") missed adding these header files to the HFILES_NO_SRCDIR
list in the Makefile. Fix that now.
Change-Id: Ifd387096aef3d147b51aefa2037da5bf6373ea64
Tom Tromey [Wed, 22 Feb 2023 22:21:45 +0000 (15:21 -0700)]
Remove 'eval' from gdb_breakpoint
Now that Tcl has the {*} operator, we can remove the use of eval from
gdb_breakpoint. Tested on x86-64 Fedora 36.
Hui Li [Thu, 16 Feb 2023 01:22:25 +0000 (09:22 +0800)]
gdb: LoongArch: Support reg aliases in info reg command
According to LoongArch ELF ABI specification [1], support the register
aliases in "info register" command.
Without this patch:
```
(gdb) info reg a0
Invalid register `a0'
```
With this patch:
```
(gdb) info reg a0
a0 0x1 1
```
[1] https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html#_register_convention
Signed-off-by: Hui Li <lihui@loongson.cn>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Hui Li [Thu, 16 Feb 2023 00:59:10 +0000 (08:59 +0800)]
gdb: LoongArch: Modify the result of the info reg command
The "info register" command should only display general registers,
but it shows the information of all registers in the current code,
add loongarch_register_reggroup_p() so that we can get the expected
result.
Signed-off-by: Hui Li <lihui@loongson.cn>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Alexey Lapshin [Thu, 23 Feb 2023 10:48:16 +0000 (10:48 +0000)]
bfd: xtensa: fix __stop_SECTION literal drop
Nick Clifton [Thu, 23 Feb 2023 09:44:50 +0000 (09:44 +0000)]
Fix the BFD library's find_nearest_line feature to produce consistent results.
PR 30150
* dwarf2.c (comp_unit_contains_address): Renamed to ... (comp_unit_may_contain_address): this,
and added code to return true if the CU's ranges have not yet been computed.
(_bfd_dwarf2_find_nearest_line_with_alt): Use the renamed function, simplifying code in the process.
Alan Modra [Thu, 23 Feb 2023 02:24:09 +0000 (12:54 +1030)]
dwarf1 .line SEC_HAS_CONTENTS
* dwarf1.c (parse_line_table): Ignore .line without SEC_HAS_CONTENTS.
Formatting.
Alan Modra [Wed, 22 Feb 2023 07:41:25 +0000 (18:11 +1030)]
ip2k: don't look at stab sections without relocs
No need to read contents if we won't do anything.
* elf32-ip2k.c (adjust_all_relocations): Skip stab sections
without relocs.
Alan Modra [Wed, 22 Feb 2023 07:07:26 +0000 (17:37 +1030)]
Test SEC_HAS_CONTENTS in relax routines
More places that generally expect instructions, so not zeros.
* coff-sh.c (sh_relax_section, sh_relax_delete_bytes): Exclude
sections without SEC_HAS_CONTENTS set.
* elf-m10200.c (mn10200_elf_relax_section): Likewise.
* elf32-arc.c (arc_elf_relax_section): Likewise.
* elf32-avr.c (elf32_avr_relax_section): Likewise.
* elf32-cr16.c (elf32_cr16_relax_section): Likewise.
* elf32-crx.c (elf32_crx_relax_section): Likewise.
* elf32-epiphany.c (epiphany_elf_relax_section): Likewise.
* elf32-ft32.c (ft32_elf_relax_section): Likewise.
* elf32-h8300.c (elf32_h8_relax_section): Likewise.
* elf32-ip2k.c (ip2k_elf_relax_section): Likewise.
* elf32-m32c.c (m32c_elf_relax_section): Likewise.
* elf32-m68hc11.c (m68hc11_elf_relax_section): Likewise.
* elf32-msp430.c (msp430_elf_relax_section): Likewise.
* elf32-pru.c (pru_elf32_relax_section): Likewise.
* elf32-rl78.c (rl78_elf_relax_section): Likewise.
* elf32-rx.c (elf32_rx_relax_section): Likewise.
* elf32-sh.c (sh_elf_relax_section): Likewise.
(sh_elf_relax_delete_bytes): Likewise.
* elf32-v850.c (v850_elf_relax_section): Likewise.
* elf64-alpha.c (elf64_alpha_relax_section): Likewise.
* elf64-ia64-vms.c (elf64_ia64_relax_section): Likewise.
* elfnn-ia64.c (elfNN_ia64_relax_section): Likewise.
* elfnn-riscv.c (_bfd_riscv_relax_section): Likewise.
* elfxx-mips.c (_bfd_mips_elf_relax_section): Likewise.
Alan Modra [Tue, 21 Feb 2023 21:17:36 +0000 (07:47 +1030)]
Test SEC_HAS_CONTENTS before reading section contents
bfd_malloc_and_get_section does size sanity checking before allocating
memory and reading contents. These size checks are not done for bss
style sections, because they typically don't occupy file space and
thus can't be compared against file size. However, if you are
expecting to look at something other than a whole lot of zeros, don't
allow fuzzers to avoid the size checking.
* cofflink.c (process_embedded_commands): Don't look at
sections without SEC_HAS_CONTENTS set.
* cpu-arm.c (bfd_arm_update_notes): Likewise.
(bfd_arm_get_mach_from_notes): Likewise.
* elf-eh-frame.c (_bfd_elf_parse_eh_frame): Likewise.
* elf-hppa.h (elf_hppa_sort_unwind): Likewise.
* elf-m10300.c (mn10300_elf_relax_section): Likewise.
* elf-sframe.c (_bfd_elf_parse_sframe): Likewise.
* elf.c (_bfd_elf_print_private_bfd_data): Likewise.
* elf32-arm.c (bfd_elf32_arm_process_before_allocation): Likewise.
* elf32-avr.c (avr_elf32_load_property_records): Likewise.
* elf32-ppc.c (_bfd_elf_ppc_set_arch): Likewise.
(ppc_elf_get_synthetic_symtab, ppc_elf_relax_section): Likewise.
* elf64-ppc.c (ppc64_elf_get_synthetic_symtab): Likewise.
(opd_entry_value, ppc64_elf_edit_opd, ppc64_elf_edit_toc): Likewise.
* elf64-x86-64.c (elf_x86_64_get_synthetic_symtab): Likewise.
* elflink.c (elf_link_add_object_symbols): Likewise.
(bfd_elf_get_bfd_needed_list): Likewise.
* elfnn-aarch64.c (get_plt_type): Likewise.
* elfxx-mips.c (_bfd_mips_elf_get_synthetic_symtab): Likewise.
* linker.c (_bfd_handle_already_linked): Likewise.
* opncls.c (bfd_get_debug_link_info_1): Likewise.
(bfd_get_alt_debug_link_info, get_build_id): Likewise.
* peXXigen.c (pe_print_idata, pe_print_pdata): Likewise.
(_bfd_XX_print_ce_compressed_pdata, pe_print_reloc): Likewise.
* pei-x86_64.c (pex64_bfd_print_pdata_section): Likewise.
* stabs.c (_bfd_link_section_stabs): Likewise.
(_bfd_discard_section_stabs): Likewise.
* xcofflink.c (_bfd_xcoff_get_dynamic_symtab_upper_bound): Likewise.
(_bfd_xcoff_canonicalize_dynamic_symtab): Likewise.
(_bfd_xcoff_get_dynamic_reloc_upper_bound): Likewise.
(_bfd_xcoff_canonicalize_dynamic_reloc): Likewise.
(xcoff_link_add_dynamic_symbols): Likewise.
(xcoff_link_check_dynamic_ar_symbols): Likewise.
(bfd_xcoff_build_dynamic_sections): Likewise.
GDB Administrator [Thu, 23 Feb 2023 00:00:26 +0000 (00:00 +0000)]
Automatic date update in version.in
Pedro Alves [Wed, 22 Feb 2023 15:40:58 +0000 (15:40 +0000)]
gdb.reverse/time-reverse.exp: test both time syscall and C time function
Instead of only testing this on systems that have a SYS_time syscall,
test it everywhere using the time(2) C function, and in addition, run
the tests again using the SYS_time syscall.
The C variant ensures that if some platform uses some syscall we are
not aware of yet, we'll still exercise it, and likely fail, at which
point we should teach GDB about the syscall.
The explicit syscall variant is useful on platforms where the C
function does not call a syscall at all by default, e.g., on some
systems the C time function wraps an implementation provided by the
vDSO.
Approved-By: Tom de Vries <tdevries@suse.de>
Change-Id: Id4b755d76577d02c46b8acbfa249d9c31b587633
Jan Beulich [Wed, 22 Feb 2023 13:12:52 +0000 (14:12 +0100)]
x86-64: LAR and LSL don't need REX.W
Just like we suppress emitting REX.W for e.g. MOV from/to segment
register, there's also no need for it for LAR and LSL - these can only
ever return 32-bit values and hence always zero-extend their results
anyway.
While there also drop the redundant Word from the first operand of
the second template each - this is already implied by Reg16.
Jan Beulich [Wed, 22 Feb 2023 13:12:24 +0000 (14:12 +0100)]
x86: optimize BT{,C,R,S} $imm,%reg
In 64-bit mode BT can have REX.W or a data size prefix dropped in
certain cases. Outside of 64-bit mode all 4 insns can have the data
size prefix dropped in certain cases.
Alan Modra [Wed, 22 Feb 2023 01:22:46 +0000 (11:52 +1030)]
set bfd_error on make_tempname or make_tempdir failure
* bucomm.c (make_tempname, make_tempdir): Set bfd_error on error.
GDB Administrator [Wed, 22 Feb 2023 00:00:23 +0000 (00:00 +0000)]
Automatic date update in version.in
Alan Modra [Tue, 21 Feb 2023 23:27:53 +0000 (09:57 +1030)]
Re: objdump read_section_stabs
Also fix ubsan "applying zero offset to null pointer".
* objdump.c (print_section_stabs): Avoid ubsan warning.
Alan Modra [Tue, 21 Feb 2023 22:34:57 +0000 (09:04 +1030)]
Re: objdump read_section_stabs
Commit
f9c36cc99518 changed (and renamed) read_section_stabs with one
difference in overall behaviour. Previously read_section_stabs would
return a NULL for an empty section, which was then treated the same as
a missing section. Now an empty section is recognized and dumped.
This leads to NULL stabp and stabs_end in print_section_stabs. Since
stabs_end - STABSIZE is then a pointer to a very large address, the
test "stabp < stabs_end - STABSIZE" succeeds.
* objdump.c (print_section_stabs): Correct STABSIZE comparison.
Alan Modra [Tue, 21 Feb 2023 21:45:26 +0000 (08:15 +1030)]
debug_link duplicate file size checks
bfd_malloc_and_get_section does these checks.
* opncls.c (bfd_get_debug_link_info_1): Don't check section
size against file size.
(bfd_get_alt_debug_link_info): Likewise.
Tom Tromey [Sat, 18 Feb 2023 00:55:50 +0000 (19:55 -0500)]
Issue error on erroneous expression
A while back I discovered that this does not issue an error:
(gdb) p $x = (void * ) 57
$3 = (void *) 0x39
(gdb) p $x + 7 = 3
$6 = (void *) 0x3
This patch fixes the bug.
Regression tested on x86-64 Fedora 36.
Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19312
Philippe Blain [Sun, 19 Feb 2023 22:37:35 +0000 (17:37 -0500)]
gdb: add --with-curses to --configuration output
'gdb --configuration' does not mention if GDB was built with curses.
Since
b5075fb68d4 (Rename to allow_tui_tests, 2023-01-08) it does show
--enable-tui (or --disable-tui), but one might want to know if GDB was
built with curses independently of the availability of the TUI.
Since configure.ac uses AC_SEARCH_LIBS to check for the curses library,
we do not get an automatically defined HAVE_LIBCURSES symbol in
config.in. We do have symbols defined by AC_CHECK_HEADERS
(HAVE_CURSES_H, etc.) but it would be cumbersome to use those in
print_gdb_configuration because we would have to check for all 6 symbols
corresponding the 6 headers listed. This would also increase the
maintenance burden if support for other variations of curses are added.
Instead, define 'HAVE_LIBCURSES' ourselves by adding an
'action-if-found' argument to AC_SEARCH_LIBS, and use it in
print_gdb_configuration.
While at it, remove the condition on 'ac_cv_search_waddstr' and set
'curses_found' directly in 'action-if-found'.
Change-Id: Id90e3d73990e169cee51bcc3e1d52072cfacd5b8
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Tom de Vries [Tue, 21 Feb 2023 14:26:24 +0000 (15:26 +0100)]
[gdb/testsuite] Require compilation flags in two gdb.arch/aarch64 test-cases
With test-cases gdb.arch/aarch64-mte-core.exp and gdb.arch/aarch64-pauth.exp I
run into compilation errors due to unsupported compilation flags.
Fix this by requiring the compilation flags, such that I have instead:
...
UNSUPPORTED: gdb.arch/aarch64-mte-core.exp: require failed: \
have_compile_flag -march=armv8.5-a+memtag
UNSUPPORTED: gdb.arch/aarch64-pauth.exp: require failed: \
have_compile_flag -mbranch-protection=pac-ret+leaf
...
Tested on aarch64-linux.
Tom de Vries [Tue, 21 Feb 2023 14:06:50 +0000 (15:06 +0100)]
[gdb/testsuite] Require istarget x86* in gdb.reverse/step-indirect-call-thunk.exp
On aarch64-linux, I run into:
...
Running gdb.reverse/step-indirect-call-thunk.exp ...
gdb compile failed, gcc: error: unrecognized command line option \
'-mindirect-branch=thunk'; did you mean '-findirect-inlining'?
gcc: error: unrecognized command line option '-mfunction-return=thunk'; \
did you mean '-Wfunction-elimination'?
UNTESTED: gdb.reverse/step-indirect-call-thunk.exp: failed to prepare
...
Fix this by requiring istarget "x86*", similar to what was added in
gdb.base/step-indirect-call-thunk.exp by commit
43127ae5714 ("Fix
gdb.base/step-indirect-call-thunk.exp"), such that we have instead:
...
UNSUPPORTED: gdb.reverse/step-indirect-call-thunk.exp: require failed: \
istarget "x86*
...
Tested on x86_64-linux and aarch64-linux.
Tom de Vries [Tue, 21 Feb 2023 13:41:14 +0000 (14:41 +0100)]
[gdb/testsuite] Require -fsplit-stack in gdb.base/morestack.exp
On aarch64-linux, I run into:
...
gdb compile failed, cc1: error: '-fsplit-stack' is not supported by this \
compiler configuration
UNTESTED: gdb.base/morestack.exp: failed to prepare
...
Fix this by requiring -fsplit-stack, such that we have instead:
...
UNSUPPORTED: gdb.base/morestack.exp: require failed: \
expr [have_compile_flag -fsplit-stack]
...
Tested on x86_64-linux and aarch64-linux.
Tom de Vries [Tue, 21 Feb 2023 13:10:12 +0000 (14:10 +0100)]
[gdb/testsuite] Require syscall time in gdb.reverse/time-reverse.exp
On aarch64-linux, I run into:
...
Running gdb.reverse/time-reverse.exp ...
gdb compile failed, gdb.reverse/time-reverse.c: In function 'main':
gdb.reverse/time-reverse.c:39:12: error: 'SYS_time' undeclared \
(first use in this function); did you mean 'SYS_times'?
syscall (SYS_time, &time_global);
^~~~~~~~
SYS_times
gdb.reverse/time-reverse.c:39:12: note: each undeclared identifier is \
reported only once for each function it appears in
UNTESTED: gdb.reverse/time-reverse.exp: failed to prepare
...
Fix this by adding a new proc have_syscall, and requiring syscall time, such
that we have instead:
...
UNSUPPORTED: gdb.reverse/time-reverse.exp: require failed: \
expr [have_syscall time]
...
Tested on x86_64-linux and aarch64-linux.
Tom de Vries [Tue, 21 Feb 2023 11:47:28 +0000 (12:47 +0100)]
[gdb/testsuite] Require python in gdb.dap/basic-dap.exp
When running test-case gdb.dap/basic-dap.exp with a gdb without python
support, I run into:
...
builtin_spawn gdb -nw -nx -iex set height 0 -iex set width 0 \
-data-directory data-directory -iex set debug dap-log-file dap.log.1 -q \
-i=dap
>>> {"seq": 1, "type": "request", "command": "initialize"}
Interpreter `dap' unrecognized
ERROR: eof reading json header
...
Fix this by requiring python in the test-case.
Tested on x86_64-linux, both with a gdb without and with python.
Nick Clifton [Tue, 21 Feb 2023 11:15:52 +0000 (11:15 +0000)]
Update the description of the bfd_fill_in_gnu_debuglink_section function
Nick Clifton [Mon, 20 Feb 2023 12:31:56 +0000 (12:31 +0000)]
Updated translatios for the bfd and gprof directories.
Clément Chigot [Wed, 11 Jan 2023 14:12:47 +0000 (15:12 +0100)]
gas/testsuite: adjust a test for case insensitive file systems
When dealing with case insensitive file systems, ".file line.s" and
".file Line.s" are identical and thus gas won't change the current
input file.
However, in line.l test, it's expecting to trigger an input file switch.
As the second filename doesn't matter in it, change it to fit for those
file systems.
gas/ChangeLog:
* testsuite/gas/elf/line.l: Change Line.s to Line2.s.
* testsuite/gas/elf/line.s: Adjust output.
Luis Machado [Sun, 11 Sep 2022 19:47:18 +0000 (20:47 +0100)]
[aarch64] Enable pointer authentication support for aarch64 bare metal/kernel mode addresses
At the moment GDB only handles pointer authentication (pauth) for userspace
addresses and if we're debugging a Linux-hosted program.
The Linux Kernel can be configured to use pauth instructions for some
additional security hardening, but GDB doesn't handle this well.
To overcome this limitation, GDB needs a couple things:
1 - The target needs to advertise pauth support.
2 - The hook to remove non-address bits from a pointer needs to be registered
in aarch64-tdep.c as opposed to aarch64-linux-tdep.c.
There is a patch for QEMU that addresses the first point, and it makes
QEMU's gdbstub expose a couple more pauth mask registers, so overall we will
have up to 4 pauth masks (2 masks or 4 masks):
pauth_dmask
pauth_cmask
pauth_dmask_high
pauth_cmask_high
pauth_dmask and pauth_cmask are the masks used to remove pauth signatures
from userspace addresses. pauth_dmask_high and pauth_cmask_high masks are used
to remove pauth signatures from kernel addresses.
The second point is easily addressed by moving code around.
When debugging a Linux Kernel built with pauth with an unpatched GDB, we get
the following backtrace:
#0 __fput (file=0xffff0000c17a6400) at /repos/linux/fs/file_table.c:296
#1 0xffff8000082bd1f0 in ____fput (work=<optimized out>) at /repos/linux/fs/file_table.c:348
#2 0x30008000080ade30 [PAC] in ?? ()
#3 0x30d48000080ade30 in ?? ()
Backtrace stopped: previous frame identical to this frame (corrupt stack?)
With a patched GDB, we get something a lot more meaningful:
#0 __fput (file=0xffff0000c1bcfa00) at /repos/linux/fs/file_table.c:296
#1 0xffff8000082bd1f0 in ____fput (work=<optimized out>) at /repos/linux/fs/file_table.c:348
#2 0xffff8000080ade30 [PAC] in task_work_run () at /repos/linux/kernel/task_work.c:179
#3 0xffff80000801db90 [PAC] in resume_user_mode_work (regs=0xffff80000a96beb0) at /repos/linux/include/linux/resume_user_mode.h:49
#4 do_notify_resume (regs=regs@entry=0xffff80000a96beb0, thread_flags=4) at /repos/linux/arch/arm64/kernel/signal.c:1127
#5 0xffff800008fb9974 [PAC] in prepare_exit_to_user_mode (regs=0xffff80000a96beb0) at /repos/linux/arch/arm64/kernel/entry-common.c:137
#6 exit_to_user_mode (regs=0xffff80000a96beb0) at /repos/linux/arch/arm64/kernel/entry-common.c:142
#7 el0_svc (regs=0xffff80000a96beb0) at /repos/linux/arch/arm64/kernel/entry-common.c:638
#8 0xffff800008fb9d34 [PAC] in el0t_64_sync_handler (regs=<optimized out>) at /repos/linux/arch/arm64/kernel/entry-common.c:655
#9 0xffff800008011548 [PAC] in el0t_64_sync () at /repos/linux/arch/arm64/kernel/entry.S:586
Backtrace stopped: Cannot access memory at address 0xffff80000a96c0c8
Clément Chigot [Fri, 13 Jan 2023 09:21:07 +0000 (10:21 +0100)]
ld/testsuite: don't output to /dev/null
Mingw doesn't have /dev/null and thus "-o /dev/null" will fail.
Currently, all the options are checked using this "-o /dev/null",
resulting in them being disabled on mingw hosts.
Fix that by outputting to a real file for all targets.
ld/ChangeLog:
* testsuite/config/default.exp: Replace "-o /dev/null" by a
file.
Alan Modra [Tue, 21 Feb 2023 05:45:59 +0000 (16:15 +1030)]
Both FAIL and PASS "check sections 2"?
* testsuite/ld-checks/checks.exp (check sections 2): Don't
continue on with rest of test past first fail.
Alan Modra [Tue, 21 Feb 2023 05:49:51 +0000 (16:19 +1030)]
ld-libs test on alpha-vms
* testsuite/ld-libs/libs.exp: Don't run for alpha-vms.
Alan Modra [Mon, 20 Feb 2023 23:27:49 +0000 (09:57 +1030)]
alpha-*-vms missing libraries
For this:
./ld-new: cannot find -limagelib: No such file or directory
./ld-new: cannot find -lstarlet: No such file or directory
./ld-new: cannot find -lsys$public_vectors: No such file or directory
the logs showed
creating dummy tmpdir/libimagelib:
creating dummy No
creating dummy such
etc.
So rubbish instead of tmpdir/libimagelib.a and the other required libs.
* testsuite/config/default.exp: Correct regex detecting missing
libraries automatically searched by alpha-dec-vms-ld.
GDB Administrator [Tue, 21 Feb 2023 00:00:24 +0000 (00:00 +0000)]
Automatic date update in version.in
Tom Tromey [Fri, 17 Feb 2023 19:12:11 +0000 (12:12 -0700)]
Redefine FUNCTION in doc.str
FUNCTION is identical to func, so simplify doc.str.
2023-02-17 Tom Tromey <tom@tromey.com>
* doc/doc.str (FUNCTION): Call func.
Tom Tromey [Fri, 17 Feb 2023 19:12:11 +0000 (12:12 -0700)]
Hoist the SECTION comment in opncls.c
The opening and closing node in BFD starts:
File: bfd.info, [...]
/* Set to N to open the next N BFDs using an alternate id space. */
extern unsigned int bfd_use_reserved_id;
2.13 Opening and closing BFDs
=============================
That is, there's a stray C comment and declaration before any other
text or subsections.
This occurs because the code fragment for bfd_use_reserved_id comes
before the SECTION comment. Hoisting it makes this a little nicer.
2023-02-17 Tom Tromey <tom@tromey.com>
* opncls.c: Hoist the SECTION comment.
Tom Tromey [Fri, 17 Feb 2023 19:12:11 +0000 (12:12 -0700)]
Don't use chew comments for static functions
I found a few static functions in the BFD manual. These can't be
called by any user of the library, so I don't think it's useful to put
them in the manual. This patch removes the chew markup from their
comments.
2023-02-17 Tom Tromey <tom@tromey.com>
* opncls.c (bfd_get_debug_link_info_1, separate_debug_file_exists)
(separate_alt_debug_file_exists, find_separate_debug_file)
(get_build_id, get_build_id_name, check_build_id_file): Don't use
chew comments.
Tom Tromey [Fri, 17 Feb 2023 19:12:11 +0000 (12:12 -0700)]
Fix formatting of long function description in chew output
Currently, if a function description spans a line, the resulting info
can look like this:
-- Function: long bfd_canonicalize_reloc
(bfd *abfd, asection *sec, arelent **loc, asymbol **syms); Call the
back end associated with the open BFD ABFD and translate the
external form of the relocation information attached to SEC into
the internal canonical form. Place the table into memory at LOC,
That is, the function prototype runs together with the text in an ugly
way. This patch fixes this by introducing a new primitive, so that
the generated Texinfo can be a bit nicer. Now this output looks like:
-- Function: long bfd_canonicalize_reloc (bfd *abfd, asection *sec,
arelent **loc, asymbol **syms);
Call the back end associated with the open BFD ABFD and translate
the external form of the relocation information attached to SEC
2023-02-17 Tom Tromey <tom@tromey.com>
* doc/doc.str (SYNOPSIS): Use collapse_whitespace.
* doc/chew.c (collapse_whitespace): New function.
(main): Register collapse_whitespace.
Andreas Schwab [Tue, 14 Feb 2023 17:07:19 +0000 (18:07 +0100)]
opcodes: style m68k disassembler output
Simon Marchi [Mon, 20 Feb 2023 16:52:40 +0000 (11:52 -0500)]
gdb: revert one erroneous bool-ification change
Commit
42c13555ff88 ("Change value::m_stack to bool") erroneously
changed a `0` to `false` in this call to read_value_memory. This
parameter is `LONGEST bit_offset`, it should stay `0`.
Change-Id: I128df6834cf8055ec6a7051e237e379978d3d651
Clément Chigot [Wed, 18 Jan 2023 13:44:39 +0000 (14:44 +0100)]
ld/testsuite: handle Windows drive letter in a noinit test
The regexp in "noinit sections (ld -r)" is skipping the file path before
the first ":". However, on Windows, a path can start with "C:". Adjust
the regexp to allow such cases.
ld/ChangeLog:
* testsuite/ld-elf/noinit-sections-2.l: Allow Windows paths
(starting with C:).
Clément Chigot [Thu, 12 Jan 2023 10:02:25 +0000 (11:02 +0100)]
ld/testsuite: adjust to Windows path separator.
In some tests, the path reported on Windows will have a \ instead of a
/. This occurs when a file is concatened with the search path in
ldfile.c.: "ld -Ltmpdir -ltext" will result into "tmpdir\libtext.a".
ld/ChangeLog:
* testsuite/ld-elf/retain5.map: Allow \ path separator.
* testsuite/ld-plugin/plugin-10.d: Likewise.
* testsuite/ld-plugin/plugin-11.d: Likewise.
* testsuite/ld-plugin/plugin-18.d: Likewise.
* testsuite/ld-plugin/plugin-19.d: Likewise.
* testsuite/ld-plugin/plugin-20.d: Likewise.
* testsuite/ld-plugin/plugin-22.d: Likewise.
Andrew Burgess [Thu, 16 Feb 2023 09:22:43 +0000 (09:22 +0000)]
gdb/doc: Consistency fixes for GDB/MI documentation
I noticed two inconsistencies in the GDB/MI documentation, which this
commit addresses:
1. Each MI command is introduced like this:
@subheading The @code{-command-name} Command
Except for a few of the tracing command, which just use:
@subheading -command-name
In this commit I've updated all these trace commands to use the
more common format.
2. Each MI command starts with a @subheading, and then the details
of that command are split up using multiple @subsubheading
entries.
Except for a few commands which use @subheading for the top-level
command, and then continue to use @subheading for each part of
the command description.
In this commit I've updated these to use @subsubheading where
appropriate.
Nick Clifton [Mon, 20 Feb 2023 11:32:52 +0000 (11:32 +0000)]
So the linker from producing an export data table when run with --exclude-all-symbols.
PR 30004 * pe-dll.c (pe_dll_build_sections): Do not build an edata section if all symbols are being excluded.
Tom de Vries [Mon, 20 Feb 2023 11:20:14 +0000 (12:20 +0100)]
[gdb/symtab] Trust epilogue unwind info for unknown or non-gcc producer
Currently we only trust epilogue unwind info only for gcc >= 4.5.0.
This has the effect that we don't trust epilogue unwind info for:
- unknown producers (CU without DW_AT_producer attribute)
- non-gcc producers (say, clang).
Instead, only distrust epilogue unwind info only for gcc < 4.5.0.
Tom de Vries [Mon, 20 Feb 2023 11:20:14 +0000 (12:20 +0100)]
[gdb/symtab] Trust epilogue unwind info for unknown producer (-g0 case)
For a -g0 -fasynchronous-unwind-tables exec (without .debug_info but with
.eh_frame section), start using the dwarf2 unwinder instead of the
"amd64 epilogue override" unwinder, by returning true in
compunit_epilogue_unwind_valid for cust == nullptr.
This has effect both on the amd64 and i386 targets, but only add amd64
test-case gdb.base/unwind-on-each-insn-amd64-2.exp.
Tom de Vries [Mon, 20 Feb 2023 11:20:14 +0000 (12:20 +0100)]
[gdb/tdep] Add amd64/i386 epilogue override unwinders
For amd64 the current frame-unwinders are:
...
$ gdb -q -batch -ex "set arch i386:x86-64" -ex "maint info frame-unwinders"
The target architecture is set to "i386:x86-64".
dummy DUMMY_FRAME
dwarf2 tailcall TAILCALL_FRAME
inline INLINE_FRAME
python NORMAL_FRAME
amd64 epilogue NORMAL_FRAME
dwarf2 NORMAL_FRAME
dwarf2 signal SIGTRAMP_FRAME
amd64 sigtramp SIGTRAMP_FRAME
amd64 prologue NORMAL_FRAME
...
For a -g0 -fasynchronous-unwind-tables exec (without .debug_info but with
.eh_frame section), we'd like to start using the dwarf2 unwinder instead of
the "amd64 epilogue" unwinder, by returning true in
compunit_epilogue_unwind_valid for cust == nullptr.
But we'd run into the following problem for a -g0
-fno-asynchronous-unwind-tables (without .debug_info and .eh_frame section)
exec:
- the "amd64 epilogue" unwinder would not run
(because compunit_epilogue_unwind_valid () == true)
- the dwarf2 unwinder would also not run
(because there's no .eh_frame info).
Fix this by:
- renaming the "amd64 epilogue" unwinder to "amd64 epilogue override", and
- adding a fallback "amd64 epilogue" after the dwarf unwinders,
while making sure that only one of the two is active. Likewise for i386. NFC.
For amd64, this results in this change:
...
$ gdb -q -batch -ex "set arch i386:x86-64" -ex "maint info frame-unwinders"
The target architecture is set to "i386:x86-64".
dummy DUMMY_FRAME
dwarf2 tailcall TAILCALL_FRAME
inline INLINE_FRAME
python NORMAL_FRAME
-amd64 epilogue NORMAL_FRAME
+amd64 epilogue override NORMAL_FRAME
dwarf2 NORMAL_FRAME
dwarf2 signal SIGTRAMP_FRAME
+amd64 epilogue NORMAL_FRAME
amd64 sigtramp SIGTRAMP_FRAME
amd64 prologue NORMAL_FRAME
...
And for i386:
...
$ gdb -q -batch -ex "set arch i386" -ex "maint info frame-unwinders"
The target architecture is set to "i386".
dummy DUMMY_FRAME
dwarf2 tailcall TAILCALL_FRAME
iline INLINE_FRAME
-i386 epilogue NORMAL_FRAME
+i386 epilogue override NORMAL_FRAME
dwarf2 NORMAL_FRAME
dwarf2 signal SIGTRAMP_FRAME
+i386 epilogue NORMAL_FRAME
i386 stack tramp NORMAL_FRAME
i386 sigtramp SIGTRAMP_FRAME
i386 prologue NORMAL_FRAME
...
Tom de Vries [Mon, 20 Feb 2023 11:20:14 +0000 (12:20 +0100)]
[gdb/tdep] Fix amd64/i386_stack_frame_destroyed_p
The use of compunit_epilogue_unwind_valid in both amd64_stack_frame_destroyed_p
and i386_stack_frame_destroyed_p is problematic, in the sense that the
functions no longer match their documented behaviour.
Fix this by moving the use of compunit_epilogue_unwind_valid to
amd64_epilogue_frame_sniffer and i386_epilogue_frame_sniffer. No functional
changes.
Tom de Vries [Mon, 20 Feb 2023 11:20:14 +0000 (12:20 +0100)]
[gdb/symtab] Factor out compunit_epilogue_unwind_valid
Factor out compunit_epilogue_unwind_valid from both
amd64_stack_frame_destroyed_p and i386_stack_frame_destroyed_p. No functional
changes.
Also add a comment in the new function about the assumption that in absence of
producer information, epilogue unwind info is invalid.
Approved-By: Tom Tromey <tom@tromey.com>
Tom de Vries [Mon, 20 Feb 2023 10:16:02 +0000 (11:16 +0100)]
[gdb/testsuite] Add xfail case in gdb.python/py-record-btrace.exp
I came across:
...
gdb) PASS: gdb.python/py-record-btrace.exp: prepare record: stepi 100
python insn = r.instruction_history^M
warning: Non-contiguous trace at instruction 1 (offset = 0x3e10).^M
(gdb) FAIL: gdb.python/py-record-btrace.exp: prepare record: python insn = r.i\
nstruction_history
...
I'm assuming it's the same root cause as for the already present XFAIL.
Fix this by recognizing above warning in the xfail regexp.
Tested on x86_64-linux, although sofar I was not able to trigger the warning
again.
Approved-By: Markus T. Metzger <markus.t.metzger@intel.com>
Tom de Vries [Mon, 20 Feb 2023 10:16:02 +0000 (11:16 +0100)]
[gdb/testsuite] Fix gdb.threads/schedlock.exp for gcc 4.8.5
Since commit
9af467b8240 ("[gdb/testsuite] Fix gdb.threads/schedlock.exp on
fast cpu"), the test-case fails for gcc 4.8.5.
The problem is that for gcc 4.8.5, the commit turned a two-line loop:
...
(gdb) next
78 while (*myp > 0)
(gdb) next
81 MAYBE_CALL_SOME_FUNCTION(); (*myp) ++;
(gdb) next
78 while (*myp > 0)
...
into a three-line loop:
...
(gdb) next
83 MAYBE_CALL_SOME_FUNCTION(); (*myp) ++;
(gdb) next
84 cnt++;
(gdb) next
85 }
(gdb) next
83 MAYBE_CALL_SOME_FUNCTION(); (*myp) ++;
(gdb)
...
and the test-case doesn't expect this.
Fix this by reverting back to the original loop shape as much as possible by:
- removing the cnt++ line
- replacing "while (1)" with "while (one)", where one is a volatile variable
set to 1.
Tested on x86_64-linux, using compilers:
- gcc 4.8.5, 7.5.0, 12.2.1
- clang 4.0.1, 13.0.1
Alan Modra [Mon, 20 Feb 2023 00:44:59 +0000 (11:14 +1030)]
In-memory nested archives
alpha-linuxecoff has compressed archives that are decompressed to a
bfd-in-memory. We'd need to handle quite a lot of corner cases to
support nesting of such archives, so just stop it before we run into
segfaults later.
* opncls.c (_bfd_new_bfd_contained_in): Prohibit nested
archives in memory.
projects / binutils-gdb.git / log