Tom Tromey [Mon, 13 May 2013 16:51:52 +0000 (16:51 +0000)]
PR exp/15364:
* eval.c (evaluate_subexp_standard) <STRUCTOP_STRUCT,
STRUCTOP_PTR>: Return a not_lval value for
EVAL_AVOID_SIDE_EFFECTS.
* opencl-lang.c (evaluate_subexp_opencl): Return a not_lval value
for EVAL_AVOID_SIDE_EFFECTS.
gdb/testsuite
* gdb.base/exprs.exp (test_expr): Add regression test.
* gdb.base/exprs.c (null_t_struct): New global.
Nick Clifton [Mon, 13 May 2013 10:52:52 +0000 (10:52 +0000)]
* v850.igen (LDSR): Accept but ignore a selID parameter.
Joel Brobecker [Mon, 13 May 2013 10:27:35 +0000 (10:27 +0000)]
Float parameter passing in funcall on ppc-aix & ppc-lynx178.
Given the following code:
float global_float = 0.0;
void
set_float (float f)
{
global_float = f;
}
GDB incorrectly calls set_float if the set_float function is marked
as prototyped:
(gdb) call set_float (5.0)
(gdb) print global_float
$1 = 2048
What happens, when the function is marked as prototyped, is that
GDB finds that the argument is a float, casts the value given in
the expression to a float, and then gives that float to ppc-aix/
ppc-lynx178's push_dummy_call gdbarch routine. The latter then blindly
copies it as is in the first floating-point register, instead of
making sure that it has the proper format first.
gdb/ChangeLog:
* rs6000-aix-tdep.c (rs6000_push_dummy_call): Convert
floating point registers to register type before storing
value.
* rs6000-lynx178-tdep.c (rs6000_lynx178_push_dummy_call):
Likewise.
Muhammad Bilal [Mon, 13 May 2013 08:49:23 +0000 (08:49 +0000)]
* History saving should stay disabled for test cases *
I saw some test cases in gdb.base/default.exp and gdb.base/setshow.exp
are enabling the history saving.
Hence .gdb_history file is modified with history information even
though, by default, we have History saving disabled.
So we should modify GDB test cases so that history saving should stay
off for all test cases.
ChangeLog:
2013-05-13 Muhammad Bilal <mbilal@codesourcery.com>
* gdb.base/default.exp: Disable history saving.
* gdb.base/setshow.exp: Likewise.
gdbadmin [Mon, 13 May 2013 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Mon, 13 May 2013 00:00:06 +0000 (00:00 +0000)]
daily update
Alan Modra [Sun, 12 May 2013 00:00:06 +0000 (00:00 +0000)]
daily update
gdbadmin [Sun, 12 May 2013 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Sat, 11 May 2013 00:00:06 +0000 (00:00 +0000)]
daily update
gdbadmin [Sat, 11 May 2013 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***
Roland McGrath [Fri, 10 May 2013 22:33:35 +0000 (22:33 +0000)]
gold/
* options.h (General_options): Add --rosegment-gap option.
* options.cc (finalize): --rosegment-gap implies --rosegment.
* layout.cc (set_segment_offsets): Let user option override
target->rosegment_gap().
Roland McGrath [Fri, 10 May 2013 20:35:47 +0000 (20:35 +0000)]
gold/
* options.h (General_options): Remove leading space from help
messages for -nostdlib and --rosegment.
Tom Tromey [Fri, 10 May 2013 17:01:00 +0000 (17:01 +0000)]
2013-05-10 Joel Brobecker <brobecker@adacore.com>
Tom Tromey <tromey@redhat.com>
* common/filestuff.c (mark_fd_no_cloexec, unmark_fd_no_cloexec):
New functions.
* common/filestuff.c (mark_fd_no_cloexec, unmark_fd_no_cloexec):
Declare.
* darwin-nat.c (darwin_pre_ptrace): Use mark_fd_no_cloexec.
(darwin_ptrace_him): Use unmark_fd_no_cloexec.
* inf-ttrace.c (do_cleanup_pfds): Use unmark_fd_no_cloexec.
(inf_ttrace_prepare): Use mark_fd_no_cloexec.
Tom Tromey [Fri, 10 May 2013 16:10:40 +0000 (16:10 +0000)]
gdb
Freddie Chopin <freddie_chopin@op.pl>
PR build/15414:
* configure: Rebuild.
* configure.ac (build_warnings): Do not use -Wformat-nonliteral
with -Wno-format.
sim/common
* acinclude.m4 (SIM_AC_OPTION_WARNINGS): Do not use
-Wformat-nonliteral with -Wno-format.
sim/bfin
* configure: Rebuild.
sim/cr16
* configure: Rebuild.
sim/cris
* configure: Rebuild.
sim/d10v
* configure: Rebuild.
sim/igen
* configure: Rebuild.
sim/m68hc11
* configure: Rebuild.
sim/mips
* configure: Rebuild.
sim/mn10300
* configure: Rebuild.
sim/v850
* configure: Rebuild.
Pedro Alves [Fri, 10 May 2013 14:31:05 +0000 (14:31 +0000)]
Fix typo in "show remote traceframe-info-packet"
I noticed:
(gdb) show remote traceframe-info-packet
Support for the `qXfer:trace-frame-info:read' packet is auto-detected, currently unknown.
^^^^^^^^^^^
The packet is actually qXfer:traceframe-info:read.
gdb/
2013-05-10 Pedro Alves <palves@redhat.com>
* remote.c (_initialize_remote): Fix spelling of
qXfer:traceframe-info:read packet in packet config command.
Pedro Alves [Fri, 10 May 2013 13:59:45 +0000 (13:59 +0000)]
PR remote/15455 - QTro remote packet broken
In the function remote_trace_set_readonly_regions in gdb/remote.c, the
local variable 'offset' does not account for "QTro" at the start of
the packet with the result that if there are any read-only regions,
the packet is sent -- but without the "QTro" -- causing the remote
stub to report that the packet is unsupported:
Sending packet: $:
0000000000400200,(...),
00000000004560a4#ab...Packet received:
vs the expected:
Sending packet: $QTro:
0000000000400200,(...),
00000000004560a4#31...Packet received: OK
We don't see the problem when testing with GDBserver, as that supports
qXfer:trace-frame-info:read, meaning GDBserver never needs to read
from the read-only sections directly itself. This commit adds a test
that explicitly disables qXfer:trace-frame-info:read.
gdb/
2013-05-10 David Taylor <dtaylor@emc.com>
PR remote/15455
* remote.c (remote_trace_set_readonly_regions): Do not overwrite
"QTro" at start of packet.
gdb/testsuite/
2013-05-10 Pedro Alves <palves@redhat.com>
PR remote/15455
* gdb.trace/qtro.c: New file.
* gdb.trace/qtro.exp: New file.
Joel Brobecker [Fri, 10 May 2013 13:25:28 +0000 (13:25 +0000)]
Remove FIXME in solib-aix.c:solib_aix_relocate_section_addresses
This issue should now be fixed thanks to a change in bfd removing
the SEC_ALLOC flag from all sections that do not get mapped to
memory.
gdb/ChangeLog:
* solib-aix.c (solib_aix_relocate_section_addresses):
Remove FIXME comment.
Joel Brobecker [Fri, 10 May 2013 13:08:24 +0000 (13:08 +0000)]
XCOFF/AIX: Remove SEC_ALLOC flags for unmapped sections.
The .except, .loader and .typchk are not mapped to memory,
so do not set their SEC_ALLOC flag.
bfd/ChangeLog:
* coffcode.h (styp_to_sec_flags) [RS6000COFF_C]: Add handling
of STYP_EXCEPT, STYP_LOADER and STYP_TYPCHK sections.
ld/testsuite/ChangeLog:
* ld-powerpc/aix-core-sec-1.hd, ld-powerpc/aix-core-sec-2.hd,
ld-powerpc/aix-core-sec-3.hd: Adjust expected section flags
for section .loader.
Joel Brobecker [Fri, 10 May 2013 12:55:13 +0000 (12:55 +0000)]
AIX: wrong address for shared object's .bss section
gdb/ChangeLog:
* solib-aix.c (solib_aix_relocate_section_addresses):
For the .bss section action, apply the same offset as
the .data section.
Joel Brobecker [Fri, 10 May 2013 12:10:20 +0000 (12:10 +0000)]
move sparc-sol-thread.c back into sol-thread.c.
The routines in sparc-sol-thread used to be SPARC-specific (and
documented as such in the ptrace man page), and therefore hosting them
in a sparc-specific file made sense. However, newer versions of
Solaris now use those callbacks (Solaris 10 Update 10, apparently),
and thus the note about these callbacks being specific to SPARC
was removed.
So this patch deletes sparc-sol-thread.c and moves the code back
inside sol-thread.c.
gdb/ChangeLog:
PR tdep/15420:
* sol-thread.c (ps_lgetxregsize, ps_lgetxregs, ps_lsetxregs):
New functions, directly copied from sparc-sol-thread.c.
* sparc-sol-thread.c: Delete.
* configure.ac: Remove code handling sparc-solaris-thread.c.
* configure: Regenerate.
Phil Muldoon [Fri, 10 May 2013 10:26:03 +0000 (10:26 +0000)]
2013-05-10 Phil Muldoon <pmuldoon@redhat.com>
* stack.c (backtrace_command_1): Add "no-filters", and Python frame
filter logic.
(backtrace_command): Add "no-filters" option parsing.
(_initialize_stack): Alter help to reflect "no-filters" option.
* Makefile.in (SUBDIR_PYTHON_OBS): Add py-framefilter.o
(SUBDIR_PYTHON_SRCS): Add py-framefilter.c
(py-frame.o): Add target
* data-directory/Makefile.in (PYTHON_DIR): Add Python frame
filter files.
* python/python.h: Add new frame filter constants, and flag enum.
(apply_frame_filter): Add definition.
* python/python.c (apply_frame_filter): New non-Python
enabled function.
* python/py-utils.c (py_xdecref): New function.
(make_cleanup_py_xdecref): Ditto.
* python/py-objfile.c: Declare frame_filters dictionary.
(objfpy_dealloc): Add frame_filters dealloc.
(objfpy_new): Initialize frame_filters attribute.
(objfile_to_objfile_object): Ditto.
(objfpy_get_frame_filters): New function.
(objfpy_set_frame_filters): New function.
* python/py-progspace.c: Declare frame_filters dictionary.
(pspy_dealloc): Add frame_filters dealloc.
(pspy_new): Initialize frame_filters attribute.
(pspacee_to_pspace_object): Ditto.
(pspy_get_frame_filters): New function.
(pspy_set_frame_filters): New function.
* python/py-framefilter.c: New file.
* python/lib/gdb/command/frame_filters.py: New file.
* python/lib/gdb/frames.py: New file.
* python/lib/gdb/__init__.py: Initialize global frame_filters
dictionary
* python/lib/gdb/FrameDecorator.py: New file.
* python/lib/gdb/FrameIterator.py: New file.
* mi/mi-cmds.c (mi_cmds): Add frame filters command.
* mi/mi-cmds.h: Declare.
* mi/mi-cmd-stack.c (mi_cmd_stack_list_frames): Add
--no-frame-filter logic, and Python frame filter logic.
(stack_enable_frame_filters): New function.
(parse_no_frame_option): Ditto.
(mi_cmd_stack_list_frames): Add --no-frame-filter and Python frame
filter logic.
(mi_cmd_stack_list_locals): Ditto.
(mi_cmd_stack_list_args): Ditto.
(mi_cmd_stack_list_variables): Ditto.
* NEWS: Add frame filter note.
2013-05-10 Phil Muldoon <pmuldoon@redhat.com>
* gdb.python/py-framefilter.py: New File.
* gdb.python/py-framefilter-mi.exp: Ditto.
* gdb.python/py-framefilter.c: Ditto.
* gdb.python/py-framefilter-mi.exp: Ditto.
* gdb.python/py-framefilter-mi.c: Ditto,
* gdb.python/py-framefilter-gdb.py.in: Ditto.
2013-05-10 Phil Muldoon <pmuldoon@redhat.com>
* gdb.texinfo (Backtrace): Add "no-filter" argument.
(Python API): Add Frame Filters API, Frame Wrapper API,
Writing a Frame Filter/Wrapper, Managing Management of Frame
Filters chapter entries.
(Frame Filters API): New Node.
(Frame Wrapper API): New Node.
(Writing a Frame Filter): New Node.
(Managing Frame Filters): New Node.
(Progspaces In Python): Add note about frame_filters attribute.
(Objfiles in Python): Ditto.
(GDB/MI Stack Manipulation): Add -enable-frame-filters command,
@anchors and --no-frame-filters option to -stack-list-variables,
-stack-list-frames, -stack-list-locals and -stack-list-arguments
commands.
DJ Delorie [Fri, 10 May 2013 03:03:04 +0000 (03:03 +0000)]
merge from gcc
Andrew Pinski [Fri, 10 May 2013 01:08:48 +0000 (01:08 +0000)]
binutils/ChangeLog:
* doc/binutils.texi: Document -Mvirt disassembler option.
gas/ChangeLog:
* config/tc-mips.c (struct mips_set_options): New ase_virt field.
(mips_opts): Update for the new field.
(file_ase_virt): New variable.
(ISA_SUPPORTS_VIRT_ASE): New macro.
(ISA_SUPPORTS_VIRT64_ASE): New macro.
(MIPS_CPU_ASE_VIRT): New define.
(is_opcode_valid): Handle ase_virt.
(macro_build): Handle "+J".
(validate_mips_insn): Likewise.
(mips_ip): Likewise.
(enum options): Add OPTION_VIRT and OPTION_NO_VIRT.
(md_longopts): Add mvirt and mnovirt
(md_parse_option): Handle OPTION_VIRT and OPTION_NO_VIRT.
(mips_after_parse_args): Handle ase_virt field.
(s_mipsset): Handle "virt" and "novirt".
(mips_elf_final_processing): Add a comment about virt ASE might need a new flag.
(md_show_usage): Print out the usage of -mvirt and mno-virt options.
* doc/c-mips.texi: Document -mvirt and -mno-virt.
Document ".set virt" and ".set novirt".
gas/testsuite/ChangeLog:
* gas/mips/mips.exp: Run virt and virt64 testcases.
* gas/mips/virt.d: New file.
* gas/mips/virt.s: New file.
* gas/mips/virt64.d: New file.
* gas/mips/virt64.s: New file.
include/opcode/ChangeLog:
* mips.h (OP_MASK_CODE10): Correct definition.
(OP_SH_CODE10): Likewise.
Add a comment that "+J" is used now for OP_*CODE10.
(INSN_ASE_MASK): Update.
(INSN_VIRT): New macro.
(INSN_VIRT64): New macro
opcodes/ChangeLog:
* mips-dis.c (mips_arch_choices): Add INSN_VIRT to mips32r2 .
Add INSN_VIRT and INSN_VIRT64 to mips64r2.
(parse_mips_dis_option): Handle the virt option.
(print_insn_args): Handle "+J".
(print_mips_disassembler_options): Print out message about virt64.
* mips-opc.c (IVIRT): New define.
(IVIRT64): New define.
(mips_builtin_opcodes): Add dmfgc0, dmtgc0, hypcall, mfgc0, mtgc0,
tlbgr, tlbgwi, tlbginv, tlbginvf, tlbgwr, tlbgp VIRT instructions.
Move rfe to the bottom as it conflicts with tlbgp.
Alan Modra [Fri, 10 May 2013 00:00:05 +0000 (00:00 +0000)]
daily update
gdbadmin [Fri, 10 May 2013 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***
Doug Evans [Thu, 9 May 2013 18:03:28 +0000 (18:03 +0000)]
* symfile.c (syms_from_objfile_1): Delete args offsets, num_offsets.
All callers updated.
(syms_from_objfile): Ditto. Make static.
(symbol_file_add_with_addrs): Renamed from
symbol_file_add_with_addrs_or_offsets. Delete args offsets,
num_offsets. All callers updated.
* symfile.h (syms_from_objfile): Delete.
Doug Evans [Thu, 9 May 2013 17:24:55 +0000 (17:24 +0000)]
* symfile.c (decrement_reading_symtab): Add assert.
(increment_reading_symtab): Ditto.
Joel Brobecker [Thu, 9 May 2013 06:58:16 +0000 (06:58 +0000)]
Use fputc in place of putc to avoid -Wunused-value warning (AIX).
Currently, bfd does not compile with -Wunused-value because
the following code:
val = putc ('\n', f);
gets expanded into some code that triggers a warning:
warning: value computed is not used [-Wunused-value]
This is because putc is implemented as a macro...
>#define putc(__x, __p) (((!((__p)->_flag & 0xC000)) && \
> ((__p)->_flag = ((__p)->_flag & 0x3FFF) | 0x8000)),\
> (--(__p)->_cnt < 0 ? \
> __flsbuf((unsigned char) (__x), (__p)) : \
> (int) (*(__p)->_ptr++ = (unsigned char) (__x))))
It's the first part, before the coma operator, which triggers
the unused-value warning.
This patch fixes the issue by simply avoiding the macro and using
fputc instead.
bfd/ChangeLog:
* bfd.c (_bfd_default_error_handler): Replace use of putc
by fputc. Add comment explaining why.
Joel Brobecker [Thu, 9 May 2013 06:52:21 +0000 (06:52 +0000)]
source.c: Use fgetc instead of getc.
On AIX, getc is a macro which triggers an -Wunused-value warning.
gdb/ChangeLog:
* source.c (forward_search_command): Replace call to getc
by call to fgetc.
(reverse_search_command): Likewise.
Alan Modra [Thu, 9 May 2013 04:32:55 +0000 (04:32 +0000)]
* ppc-opc.c (extract_vlesi): Properly sign extend.
(extract_vlensi): Likewise. Comment reason for setting invalid.
Alan Modra [Thu, 9 May 2013 04:01:53 +0000 (04:01 +0000)]
* config/tc-ppc.c (md_apply_fix): Sign extend fieldval under
control of operand flag bits.
gdbadmin [Thu, 9 May 2013 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Thu, 9 May 2013 00:00:05 +0000 (00:00 +0000)]
daily update
Alan Modra [Wed, 8 May 2013 23:31:38 +0000 (23:31 +0000)]
* elflink.c (elf_link_add_object_symbols): Don't omit reading
of symbols when hashes already exist.
Doug Evans [Wed, 8 May 2013 22:38:19 +0000 (22:38 +0000)]
* psymtab.c (expand_symtabs_matching_via_partial): Fix file name
matching test.
Tom Tromey [Wed, 8 May 2013 18:56:02 +0000 (18:56 +0000)]
* gdb.base/solib-search.exp: Set test name for "set
solib-search-path" test.
Hafiz Abid Qadeer [Wed, 8 May 2013 16:15:02 +0000 (16:15 +0000)]
2013-05-08 Hafiz Abid Qadeer <abidh@codesourcery.com>
* gdb.trace/circ.exp: Remove unnecessary 'if then' checks.
(set_a_tracepoint): Set tracepoint before prologue.
(run_trace_experiment): Test setup_tracepoints and 'break end'
in it.
(trace_buffer_normal): Remove.
(gdb_trace_circular_tests): Remove. Move tests to...
(top level): ...here. Call 'runto_main' before checking for
trace support. Use commands to check the support for circular
trace buffer and changing of trace buffer size. Add test
to calculate size of single frame. Use this size to
calculate the size of trace buffer. Use 'tfind pc func9'
instead of 'tfind 9'. Use 'with_test_prefix'.
Joel Brobecker [Wed, 8 May 2013 06:25:21 +0000 (06:25 +0000)]
Avoid duplicating text in sol-thread.c:info_cb
This is a minor cleanup that helps avoiding duplicating the output
of a command when handling alternative situations.
gdb/ChangeLog:
* sol-thread.c (info_cb): Factorize the code a little.
Joel Brobecker [Wed, 8 May 2013 06:23:50 +0000 (06:23 +0000)]
Improve output of "maintenance info sol-threads" command.
This patch does the following:
- Puts the startfunc and "Sleep func" info on the same line;
- Renames "Sleep func" into "sleepfunc" to be consistent with
"startfunc"
- Avoids the use of a '-' as a separate before the "sleepfunc"
output, because the '-' looks odd and out of place when the
"startfunc" field is not printed (ti.ti_startfunc is nul).
- Use a '=' instead of ':' and avoids the space between
the name of the value and its value, mostly to help group
the value with its name.
For the record, this is how the new outout now looks like:
(gdb) maintenance info sol-threads
user thread #1, lwp 1, (active)
system thread #2, lwp 2, (active)
system thread #3, lwp 0, (asleep) sleepfunc=0xff32d9e0
user thread #4, lwp 4, (asleep) startfunc=[...].task_wrapper sleepfunc=0xff3290f0
system thread #5, lwp 7, (active) startfunc=_co_timerset
user thread #6, lwp 8, (active) startfunc=[...].task_wrapper
gdb/ChangeLog:
* sol-thread.c (info_cb): Rework the output of the "maintenance
info sol-threads" command a bit.
Joel Brobecker [Wed, 8 May 2013 06:19:32 +0000 (06:19 +0000)]
ti.ti_pc vs ti.ti_startfunc copy-pasto in sol-thread.c:info_cb
gdb/ChangeLog:
* sol-thread.c (info_cb) [ti.ti_state == TD_THR_SLEEP]:
Replace ti.ti_startfunc by ti.ti_pc.
Probably OK to commit without approval, so will likely do so in the
next few days.
Joel Brobecker [Wed, 8 May 2013 06:10:03 +0000 (06:10 +0000)]
Dummy implementation of solib_aix_free_library_list if libexpat missing.
gdb/ChangeLog:
* solib-aix.c (solib_aix_free_library_list): New function
for the case where HAVE_LIBEXPAT is not defined.
Joel Brobecker [Wed, 8 May 2013 05:50:47 +0000 (05:50 +0000)]
[doco] Document the XML format used for AIX shared lib support.
gdb/doc/ChangeLog:
* gdbint.texinfo (Native Debugging): Add "AIX Shared Library
Support" subsection documenting the XML format used to transfer
shared library info on AIX.
Joel Brobecker [Wed, 8 May 2013 05:40:44 +0000 (05:40 +0000)]
Document set/show debug aix-solib.
gdb/doc/ChangeLog:
* gdb.texinfo (Debugging Output): Add documentation of
"set debug aix-solib" and "show debug aix-solib" commands.
Alan Modra [Wed, 8 May 2013 00:00:06 +0000 (00:00 +0000)]
daily update
gdbadmin [Wed, 8 May 2013 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***
Tom Tromey [Tue, 7 May 2013 18:06:16 +0000 (18:06 +0000)]
* lib/selftest-support.exp: New file.
* gdb.gdb/complaints.exp: Load selftest-support.exp. Use
do_self_tests.
(setup_test, find_gdb): Remove.
* gdb.gdb/observer.exp: Load selftest-support.exp. Use
do_self_tests.
(setup_test, find_gdb): Remove.
(test_observer): Don't call setup_test. Remove argument.
* gdb.gdb/selftest.exp: Load selftest-support.exp.
(find_gdb): Remove.
* gdb.gdb/complaints.exp: Load selftest-support.exp. Use
do_self_tests.
(setup_test, find_gdb): Remove.
(test_with_self): Don't call setup_test. Remove argument.
Pedro Alves [Tue, 7 May 2013 17:51:42 +0000 (17:51 +0000)]
Merge gdb.arch/system-gcore.exp into gdb.base/gcore.exp
The test case gdb.arch/system-gcore.exp is almost an identical copy of
gdb.base/gcore.exp. The only functional change is the additional
comparison of the "info reg system" command output.
It should be safe to perform this comparison on all architectures.
Thus the patch removes the arch-specific version and adds "info reg
system" to the common gcore test case instead.
Tested on i686-linux and s390x-linux.
gdb/testsuite/Changelog:
2013-05-07 Andreas Arnez <arnez@linux.vnet.ibm.com>
* gdb.arch/system-gcore.exp: Remove.
* gdb.arch/gcore.c: Remove.
* gdb.base/gcore.exp: Add "info reg system".
Sergio Durigan Junior [Tue, 7 May 2013 17:04:29 +0000 (17:04 +0000)]
gdb/
2013-05-07 Sergio Durigan Junior <sergiodj@redhat.com>
PR breakpoints/15413:
* breakpoint.c (condition_completer): Simplify the code to
disconsider multiple locations of breakpoints when completing the
"condition" command.
gdb/testsuite/
2013-05-07 Sergio Durigan Junior <sergiodj@redhat.com>
PR breakpoints/15413:
* gdb.base/pending.exp: Add test for completion of the "condition"
command for pending breakpoints.
* gdb.linespec/linespec.ex: Add test for completion of the
"condition" command when dealing with multiple locations.
Will Newton [Tue, 7 May 2013 17:03:52 +0000 (17:03 +0000)]
bfd/elf-ifunc.c: Add header size arg to _bfd_elf_allocate_ifunc_dyn_relocs.
bfd/ChangeLog:
2013-05-07 Will Newton <will.newton@linaro.org>
* elf-ifunc.c (_bfd_elf_allocate_ifunc_dyn_relocs): Add a
plt_header_size argument for ports where it differs from
plt_entry_size.
* elf-bfd.h: Likewise.
* elf32-i386.c: Pass plt_header_size to
_bfd_elf_allocate_ifunc_dyn_relocs.
* elf64-x86-64.c: Likewise.
Will Newton [Tue, 7 May 2013 17:01:12 +0000 (17:01 +0000)]
bfd/elf-ifunc.c: Remove unused function _bfd_elf_create_ifunc_dyn_reloc.
bfd/ChangeLog:
2013-05-07 Will Newton <will.newton@linaro.org>
* elf-ifunc.c (_bfd_elf_create_ifunc_dyn_reloc): Remove unused
function.
* elf-bfd.h: Likewise.
Pierre Muller [Tue, 7 May 2013 13:04:58 +0000 (13:04 +0000)]
* common/linux-btrace.c: ARI fix: Include "gdb_wait.h"
instead of <sys/wait.h>.
Pierre Muller [Tue, 7 May 2013 13:02:19 +0000 (13:02 +0000)]
* nios2-tdep.c (nios2_dwarf_reg_to_regnum): ARI fix: remove
trailing new line from warning message.
Pierre Muller [Tue, 7 May 2013 13:00:07 +0000 (13:00 +0000)]
* contrib/ari/gdb_ari.sh (SOLIB_ADD, SOLIB_CREATE_INFERIOR_HOOK)
(PC_SOLIB): Change type from ari_deprecate to ari_regression.
Joel Brobecker [Tue, 7 May 2013 12:40:08 +0000 (12:40 +0000)]
Add missing ChangeLog entries...
... for the following commits:
2013-05-07 Joel Brobecker <brobecker@adacore.com>
* rs6000-nat.c (rs6000_core_ldinfo): Remove '\n' at end of
error message (ARI fix).
2013-05-07 Joel Brobecker <brobecker@adacore.com>
* features/library-list-aix.dtd: Replace library-list by
library-list-aix.
* rs6000-nat.c: Replace library-list by library-list-aix
throughout.
* solib-aix.c: Likewise.
2013-05-07 Joel Brobecker <brobecker@adacore.com>
* target.h (enum target_object) [TARGET_OBJECT_LIBRARIES_AIX]:
Renames TARGET_OBJECT_AIX_LIBRARIES.
* rs6000-nat.c: Replace TARGET_OBJECT_AIX_LIBRARIES with
TARGET_OBJECT_LIBRARIES_AIX throughout.
* solib-aix.c: Likwise.
There were added, but accidently not checked in.
Joel Brobecker [Tue, 7 May 2013 12:36:13 +0000 (12:36 +0000)]
rs6000-nat.c:rs6000_core_ldinfo: Remove \n at end of error message.
gdb/ChangeLog:
* rs6000-nat.c (rs6000_core_ldinfo): Remove '\n' at end of
error message (ARI fix).
Joel Brobecker [Tue, 7 May 2013 09:50:49 +0000 (09:50 +0000)]
AIX: Change XML to use library-list-aix instead of library-list.
This is more consistent with what we do with other similar XML lists,
and avoids a potential confusion with the library-list XML list.
gdb/ChangeLog:
* features/library-list-aix.dtd: Replace library-list by
library-list-aix.
* rs6000-nat.c: Replace library-list by library-list-aix
throughout.
* solib-aix.c: Likewise.
Joel Brobecker [Tue, 7 May 2013 09:50:41 +0000 (09:50 +0000)]
Rename TARGET_OBJECT_AIX_LIBRARIES to TARGET_OBJECT_LIBRARIES_AIX
More consistent with the name of other similar object names.
gdb/ChangeLog:
* target.h (enum target_object) [TARGET_OBJECT_LIBRARIES_AIX]:
Renames TARGET_OBJECT_AIX_LIBRARIES.
* rs6000-nat.c: Replace TARGET_OBJECT_AIX_LIBRARIES with
TARGET_OBJECT_LIBRARIES_AIX throughout.
* solib-aix.c: Likwise.
Yao Qi [Tue, 7 May 2013 09:26:09 +0000 (09:26 +0000)]
gdb/
* solib-dsbt.c (struct dsbt_info) <enable_break2_done>: Remove.
(get_dsbt_info, enable_break, dsbt_clear_solib): Update.
Yao Qi [Tue, 7 May 2013 09:23:28 +0000 (09:23 +0000)]
gdb/
* solib-dsbt.c (enable_break): Declare.
(dsbt_current_sos): Remove call to enable_break2.
(enable_break2): Rename to enable_break. Set solib breakpoint
on '_dl_debug_state'.
(enable_break): Remove.
Luis Machado [Tue, 7 May 2013 07:43:33 +0000 (07:43 +0000)]
gdb/
* ppc-linux-nat.c (ppc_linux_new_thread): Clear the new thread's
debug state prior to replicating existing hardware watchpoints or
breakpoints.
gdb/testsuite/
* gdb.threads/wp-replication.c: New file.
* gdb.threads/wp-replication.exp: New file.
Jan Kratochvil [Tue, 7 May 2013 01:38:04 +0000 (01:38 +0000)]
gdb/
* gcore.c (gcore_create_callback): Ignore sections with
separate_debug_objfile_backlink != NULL.
Sandra Loosemore [Tue, 7 May 2013 01:12:41 +0000 (01:12 +0000)]
2013-05-06 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.xml/tdesc-regs.exp: Add case for nios2.
Sandra Loosemore [Tue, 7 May 2013 01:11:16 +0000 (01:11 +0000)]
2013-05-06 Sandra Loosemore <sandra@codesourcery.com>
Andrew Jenner <andrew@codesourcery.com>
gdb/gdbserver/
* Makefile.in (SFILES): Add linux-nios2-low.c.
(clean): Add action to delete nios2-linux.c.
(nios2-linux.c): New rule.
* configure.srv: Add nios2*-*-linux*.
* linux-nios2-low.c: New.
Sandra Loosemore [Tue, 7 May 2013 01:09:29 +0000 (01:09 +0000)]
2013-05-06 Sandra Loosemore <sandra@codesourcery.com>
Andrew Jenner <andrew@codesourcery.com>
Chung-Lin Tang <cltang@codesourcery.com>
Julian Brown <julian@codesourcery.com>
Based on the nios2-elf port from Altera Corporation.
gdb/
* Makefile.in (ALL_TARGET_OBS): Add nios2-tdep.o and
nios2-linux-tdep.o.
(HFILES_NO_SRCDIR): Add nios2-tdep.h.
(ALLDEPFILES): Add nios2-tdep.c and nios2-linux-tdep.c.
* configure.tgt: Add nios2*-*-linux* and nios2*-*-* targets.
* nios2-tdep.h: New.
* nios2-tdep.c: New.
* nios2-linux-tdep.c: New.
* features/Makefile (WHICH): Add nios2-linux.
(nios2-linux-expedite): Set.
* features/nios2-cpu.xml: New.
* features/nios2.xml: New.
* features/nios2-linux.xml: New.
* features/nios2.c: New (autogenerated).
* features/nios2-linux.c: New (autogenerated).
* regformats/nios2-linux.dat: New (autogenerated).
* NEWS (Changes since GDB 7.6): Add new Nios II targets
and commands.
gdb/doc/
* gdb.texinfo (Nios II): New section.
(Nios II Features): New section.
Doug Evans [Tue, 7 May 2013 00:02:12 +0000 (00:02 +0000)]
* symfile.c: Whitespace cleanup.
Alan Modra [Tue, 7 May 2013 00:00:04 +0000 (00:00 +0000)]
daily update
gdbadmin [Tue, 7 May 2013 00:00:02 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Mon, 6 May 2013 23:36:48 +0000 (23:36 +0000)]
* config/tc-ppc.c (PPC_VLE_SPLIT16A): Delete unused macro.
(PPC_VLE_SPLIT16D, PPC_VLE_LO16A, PPC_VLE_LO16D): Likewise.
(PPC_VLE_HI16A, PPC_VLE_HI16D): Likewise.
(PPC_VLE_HA16A, PPC_VLE_HA16D): Likewise.
(md_apply_fix): Set fx_no_overflow for assorted relocations.
Shift and sign-extend fieldval for use by some VLE reloc
operand->insert functions.
Doug Evans [Mon, 6 May 2013 22:20:18 +0000 (22:20 +0000)]
* gdb.base/solib-search-lib1.c: New file.
* gdb.base/solib-search-lib2.c: New file.
* gdb.base/solib-search.c: New file.
* gdb.base/solib-search.h: New file.
* gdb.base/solib-search.exp: New file.
Doug Evans [Mon, 6 May 2013 22:18:39 +0000 (22:18 +0000)]
* solist.h (struct target_so_ops): New member clear_so.
* solib-svr4.c (svr4_clear_so): New function.
(_initialize_svr4_solib): Set svr4_so_ops.clear_so.
* solib.c (clear_so): Renamed from free_so_symbols.
All callers updated. Call target clear_so if it exists.
Doug Evans [Mon, 6 May 2013 22:11:16 +0000 (22:11 +0000)]
* lib/gdb.exp (gdb_core_cmd): New function.
* gdb.arch/system-gcore.exp: Use it.
* gdb.arch/vsx-regs.exp: Ditto.
* gdb.base/gcore.exp: Ditto.
* gdb.threads/gcore-thread.exp: Ditto.
Doug Evans [Mon, 6 May 2013 22:07:13 +0000 (22:07 +0000)]
* gdb.reverse/shr.h: New file.
* gdb.reverse/shr1.c: New file.
* gdb.reverse/shr2.c: #include "shr.h".
* gdb.reverse/solib-reverse.c: Remove #include <stdio.h>.
#include "shr.h". Replace calls to printf,sleep to call shr1 instead.
* gdb.reverse/solib-precsave.exp: Build shr2.sl.
Update tests using sleep/printf to use shr2.sl instead.
* gdb.reverse/solib-reverse.exp: Ditt.o
Tom Tromey [Mon, 6 May 2013 19:46:15 +0000 (19:46 +0000)]
* ada-lang.c (ada_value_primitive_packed_val): Don't
call value_incref.
* value.c (set_value_parent): Incref the new parent and decref
the old parent.
(value_copy, value_primitive_field): Use set_value_parent.
Tom Tromey [Mon, 6 May 2013 19:44:04 +0000 (19:44 +0000)]
* dwarf2loc.c (invalid_synthetic_pointer): Move earlier.
(indirect_pieced_value): Call dwarf2_fetch_constant_bytes
if needed.
* dwarf2loc.h (dwarf2_fetch_constant_bytes): Declare.
* dwarf2read.c (write_constant_as_bytes)
(dwarf2_fetch_constant_bytes): New functions.
gdb/testsuite
* gdb.dwarf2/implptrconst.c: New file.
* gdb.dwarf2/implptrconst.exp: New file.
* lib/dwarf.exp (Dwarf::_nz_quote): New proc.
(Dwarf::_handle_DW_FORM): Handle DW_FORM_block1.
(Dwarf::_location): Handle DW_OP_GNU_implicit_pointer.
Tom Tromey [Mon, 6 May 2013 19:39:09 +0000 (19:39 +0000)]
* dwarf2read.c (dwarf2_const_value_data): Remove unused
parameters.
(dwarf2_const_value_attr): Update.
Tom Tromey [Mon, 6 May 2013 19:38:04 +0000 (19:38 +0000)]
* somread.c (som_symfile_offsets): Add 'const' to addrs.
* machoread.c (macho_symfile_offsets): Add 'const' to addrs.
* xcoffread.c (xcoff_symfile_offsets): Add 'const' to addrs.
Remove declaration.
Tom Tromey [Mon, 6 May 2013 19:28:36 +0000 (19:28 +0000)]
* dwarf2read.c (dwarf2_const_value_attr): Use 'obstack', not
objfile's obstack.
Doug Evans [Mon, 6 May 2013 19:15:17 +0000 (19:15 +0000)]
* dbxread.c (process_one_symbol): Constify section_offsets parameter.
* stabsread.h (process_one_symbol): Update declaration.
* dwarf2read.c (dw2_relocate): Constify new_offsets, delta parameters.
* elfread.c (elf_symfile_relocate_probe): Ditto.
* psymtab.c (relocate_psymtabs): Ditto.
* objfiles.c (objfile_relocate1): Constify new_offsets parameter.
(objfile_relocate): Ditto.
* objfiles.h (objfile_relocate): Update declaration.
* symfile.c (relative_addr_info_to_section_offsets): Constify
addrs parameter.
(default_symfile_offsets): Ditto.
(syms_from_objfile_1): Constify offsets parameter.
(syms_from_objfile): Ditto.
(symbol_file_add_with_addrs_or_offsets): Ditto.
(symfile_map_offsets_to_segments): Constify data parameter.
* symfile.h (struct quick_symbol_functions): Constify new_offsets,
delta parameters of member relocate.
(struct sym_probe_fns): Constify new_offsets,
delta parameters of member sym_relocate_probe.
(struct sym_fns): Constify section_addr_info parameter of member
sym_offsets.
(relative_addr_info_to_section_offsets): Update declaration.
(default_symfile_offsets): Ditto.
(syms_from_objfile): Ditto.
(symfile_map_offsets_to_segments): Ditto.
Doug Evans [Mon, 6 May 2013 18:50:08 +0000 (18:50 +0000)]
* symfile.c (syms_from_objfile_1): Use correct section count when
objfile->sf == NULL.
Jeff Johnston [Mon, 6 May 2013 18:31:56 +0000 (18:31 +0000)]
2013-05-06 Sandra Loosemore <sandra@codesourcery.com>
* COPYING.NEWLIB: Add Altera Corporation copyright.
Mike Frysinger [Mon, 6 May 2013 18:03:33 +0000 (18:03 +0000)]
gdb: btrace: fix indentation style
Most of this func had the incorrect indentation level (starting with 4
spaces instead of 2).
Doug Evans [Mon, 6 May 2013 16:45:13 +0000 (16:45 +0000)]
* psympriv.h (struct partial_symtab): Augment comment for member
section_offsets.
Catherine Moore [Mon, 6 May 2013 15:25:45 +0000 (15:25 +0000)]
2013-05-06 Paul Brook <paul@codesourcery.com>
include/elf/
* mips.h (R_MIPS_PC32): Update comment.
* elf64-mips.c (elf_mips_gnu_pcrel32): New.
(bfd_elf64_bfd_reloc_type_lookup, bfd_elf64_bfd_reloc_name_lookup,
mips_elf64_rtype_to_howto): Handle R_MIPS_PC32.
* elfn32-mips.c (elf_mips_gnu_pcrel32): New.
(bfd_elfn32_bfd_reloc_type_lookup, bfd_elfn32_bfd_reloc_name_lookup,
mips_elfn32_rtype_to_howto): Handle R_MIPS_PC32.
2013-05-06 Paul Brook <paul@codesourcery.com>
Catherine Moore <clm@codesourcery.com>
gas/
* config/tc-mips.c (md_pcrel_from): Handle BFD_RELOC_32_PCREL.
(limited_pcrel_reloc_p): Likewise.
(md_apply_fix): Likewise.
(tc_gen_reloc): Likewise.
Catherine Moore [Mon, 6 May 2013 15:00:01 +0000 (15:00 +0000)]
2013-05-06 Richard Sandiford <rdsandiford@googlemail.com>
* config/tc-mips.c (limited_pcrel_reloc_p): New function.
(mips_fix_adjustable): Adjust pc-relative check to use
limited_pc_reloc_p.
Joel Brobecker [Mon, 6 May 2013 14:15:50 +0000 (14:15 +0000)]
Reimplement shared library support on ppc-aix...
... using the target_so_ops framework.
gdb/ChangeLog:
* target.h (TARGET_OBJECT_AIX_LIBRARIES): New target_object enum.
* features/library-list-aix.dtd: New file.
* solib-aix.h, solib-aix.c: New file.
* rs6000-aix-tdep.c: #include "solib.h" and "solib-aix.h".
(rs6000_find_toc_address_hook): Delete.
(rs6000_push_dummy_call): Rewrite code setting the TOC value.
(rs6000_aix_init_osabi): Register solib_aix_so_ops.
* rs6000-nat.c: Remove "xcoffsolib.h" include. Include
"xml-utils.h".
(map_vmap, vmap_exec, vmap_ldinfo, add_vmap, objfile_symbol_add)
(vmap_symtab, fixup_breakpoints): Delete.
(rs6000_xfer_shared_libraries): New function.
(rs6000_xfer_partial): Add TARGET_OBJECT_AIX_LIBRARIES handling.
(vmap_secs, bss_data_overlap, vmap_add_symbols): Delete.
(xcoff_relocate_symtab, xcoff_relocate_core): Delete.
(rs6000_ptrace_ldinfo, rs6000_core_ldinfo)
(rs6000_xfer_shared_library): New function.
(find_toc_address): Delete.
(_initialize_rs6000_nat): Do not set rs6000_find_toc_address_hook.
* rs6000-tdep.h (rs6000_find_toc_address_hook): Remove.
* xcoffread.c (record_minimal_symbol): Reloate symbol address
before creating minimal symbol. Adjust function description
accordingly.
(scan_xcoff_symtab): Replace call to
prim_record_minimal_symbol_and_info by call to
record_minimal_symbol.
(xcoff_symfile_offsets): Reimplement mostly as a wrapper
around default_symfile_offsets.
* configure.tgt: Add solib-aix.o to gdb_target_obs for
powerpc-aix targets.
* config/rs6000/nm-rs6000.h: Delete.
* config/powerpc/aix.mh (NAT_FILE): Delete.
(NATDEPFILES): Remove xcoffsolib.o.
* Makefile.in (XMLFILES): Add library-list-aix.dtd.
(ALL_TARGET_OBS): Add solib-aix.o.
(HFILES_NO_SRCDIR): Remove xcoffsolib.h and
config/rs6000/nm-rs6000.h. Add solib-aix.h.
(ALLDEPFILES): Add solib-aix.c. Remove xcoffsolib.c.
* xcoffsolib.h, xcoffsolib.c: Delete.
* solib.c (reload_shared_libraries): Remove reference to
SOLIB_CREATE_INFERIOR_HOOK.
* breakpoint.c (handle_solib_event): Remove reference to SOLIB_ADD.
(disable_breakpoints_in_shlibs): Remove reference to PC_SOLIB.
(momentary_bkpt_re_set): Replace SOLIB_ADD by solib_add in
comment.
* corelow.c (deprecated_core_resize_section_table): Delete.
* exec.c: Remove include of xcoffsolib.h".
(map_vmap, vmap): Delete.
(exec_close_1): Remove references to vmap.
(exec_file_attach): Remove vmap handling code, and reference
to DEPRECATED_IBM6000_TARGET.
(bfdsec_to_vmap): Delete.
(exec_files_info): Remove block of code handling VMAP.
* infcmd.c (post_create_inferior): Remove reference to
SOLIB_CREATE_INFERIOR_HOOK and SOLIB_ADD.
* infrun.c (follow_exec): Remove reference to
SOLIB_CREATE_INFERIOR_HOOK.
* stack.c (print_frame): Remove reference to PC_SOLIB.
* solib-dsbt.c (dsbt_current_sos): Adjust comment.
(dsbt_relocate_main_executable): Likewise.
* solib-frv.c (frv_current_sos): Likewise.
gdb/doc/ChangeLog:
* gdbint.texinfo (Algorithms): Remove entries documenting
DEPRECATED_IBM6000_TARGET, SOLIB_ADD, and
SOLIB_CREATE_INFERIOR_HOOK.
Joel Brobecker [Mon, 6 May 2013 12:55:52 +0000 (12:55 +0000)]
Fix -Wpointer-sign warning in sol-thread.c
gdb/ChangeLog:
* sol-thread.c (rw_common): Cast BUF to "gdb_byte *" in calls
to target_write_memory and target_read_memory.
Joel Brobecker [Mon, 6 May 2013 12:41:14 +0000 (12:41 +0000)]
darwin: warning resuming inferior after attach
This patch avoids a warning when resuming the execution of a program
that we attached to. For instance:
(gdb) attach 29989
(gdb) continue
Continuing.
warning: Mach error at "/[...]/darwin-nat.c:738" in function
"darwin_resume_thread": (os/kern) failure (0x5)
The warning is relatively harmless, but worrisome for the average
user. The warning comes from the fact that darwin_wait recorded
that the fake stop event corresponding to the suspend action was
caused by the main thread being suspended on a SIGTRAP. As a result
of this, when resuming the program's execution, we try to resume
the thread's execution as well. This is where the issue occurs,
as the thread was not in fact suspended, thus triggering the warning.
gdb/ChangeLog:
* darwin-nat.c (darwin_setup_fake_stop_event): New function.
(darwin_attach): Adjust using darwin_setup_fake_stop_event.
Joel Brobecker [Mon, 6 May 2013 12:37:52 +0000 (12:37 +0000)]
darwin-nat: Print all hex values with 0x prefix.
gdb/ChangeLog:
* darwin-nat.c: Replace all "%x" instances in format strings
into "0x%x" throughout.
Joel Brobecker [Mon, 6 May 2013 12:35:46 +0000 (12:35 +0000)]
darwin-nat.c: Do not use gdb_assert on system call outcomes.
There were many cases were we make a system call which could fail
due to reasons outside of the debugger control. We should handle
these situations a little more gracefully than triggering an
internal error.
gdb/ChangeLog:
* darwin-nat.c (darwin_mourn_inferior): Replace call to
gdb_assert by call to MACH_CHECK_ERROR.
(darwin_attach_pid): Raise an error rather than a failed
assertion when various system calls failed. Report a warning
instead of raising a failed assertion when PREV_NOT is not NULL
after call to mach_port_request_notification.
(darwin_ptrace_me): Raise an error rather than a failed
assertion when read returns nonzero.
Joel Brobecker [Mon, 6 May 2013 12:33:00 +0000 (12:33 +0000)]
amd64-darwin-tdep.c: Remove #include "gdb_assert.h"
gdb_assert.h is already included from darwin-nat.h, so no need to
include it again...
gdb/ChangeLog:
* amd64-darwin-tdep.c: Remove #include "gdb_assert.h".
Joel Brobecker [Mon, 6 May 2013 10:26:41 +0000 (10:26 +0000)]
Move ChangeLog entry from sim/ to sim/ppc/...
... where it belongs.
Alan Modra [Mon, 6 May 2013 09:32:55 +0000 (09:32 +0000)]
* elf64-ppc.c (opd_entry_value): Handle case where symbol
hashes are not available.
Alan Modra [Mon, 6 May 2013 08:45:40 +0000 (08:45 +0000)]
* elflink.c (elf_link_add_object_symbols): Don't save symbol
hashes around loading as-needed library. Zero them on allocation,
and restore to initial all-zero state if library not needed.
Arrange to reuse hashes if we load library again later.
gdbadmin [Mon, 6 May 2013 00:00:32 +0000 (00:00 +0000)]
*** empty log message ***
Alan Modra [Mon, 6 May 2013 00:00:06 +0000 (00:00 +0000)]
daily update
Jan Kratochvil [Sun, 5 May 2013 16:56:07 +0000 (16:56 +0000)]
gdb/
* cleanups.c (restore_my_cleanups): New gdb_assert for SENTINEL_CLEANUP.
Jan Kratochvil [Sun, 5 May 2013 16:54:26 +0000 (16:54 +0000)]
gdb/
* event-top.c (display_gdb_prompt): Call missing do_cleanups.
* infcmd.c (get_return_value) <!stop_regs>: Do not overwrite CLEANUP.
* symfile.c (symfile_bfd_open): New variable back_to. Do not leave
a stale cleanup. Fix double free of NAME.
Alan Modra [Sun, 5 May 2013 00:00:05 +0000 (00:00 +0000)]
daily update
gdbadmin [Sun, 5 May 2013 00:00:03 +0000 (00:00 +0000)]
*** empty log message ***
Eli Zaretskii [Sat, 4 May 2013 13:36:18 +0000 (13:36 +0000)]
Announce thread death on MS-Windows.
* windows-nat.c (windows_delete_thread): Accept an additional
argument, the thread's exit code, and announce thread death when
print_thread_events is non-zero and we are deleting a thread that
is not the main thread.
(get_windows_debug_event): Pass thread exit code to
windows_delete_thread.