ppc-aix osabi sniffer: Turn test of bfd flavour into assertion

Due to the way this function is registers, we know that given bfd's
flavour should always be bfd_target_xcoff_flavour, thus making
the former test always true, which means that this function should
always return GDB_OSABI_AIX, and never return GDB_OSABI_UNKNOWN.

This patch also fixes a typo detected by Tom Tromey that caused
the test itself to be completely ineffective.

gdb/ChangeLog (by Tom Tromey and Joel Brobecker):

        * rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Replace
        inneffective if condition by gdb assertion.  Add function
        description comment.

Document exp_descriptor.op_name should never return NULL.

This documents a constaint that struct exp_descriptor's "op_name"
method implementation should obey.  This might not have been part
of the initial design, but is currently true of all instantiations,
and already assumed by the current users.

gdb/ChangeLog:

        * parser-defs.h (struct exp_descriptor): Document constraint
        on return value for "op_name" callbacks.

* compress.c: Revert previous patch.

* compress.c (bfd_get_full_section_contents): Don't cache
decompressed contents.

Correct my ChangeLog entry

    * gdb.base/ctxobj.exp: Skip if skip_shlib_tests returns true.
        * gdb.base/print-file-var.exp: Likewise.
        * gdb.base/type-opaque.exp: Likewise.

*** empty log message ***

daily update

Add missed file on my last commit

* tracepoint.c (print_one_static_tracepoint_marker): Constify.
* symtab.c (iterate_over_some_symtabs): Constify.
* source.h (symtab_to_fullname): Return 'const char *'.
* source.c (symtab_to_fullname): Return 'const char *'.
* python/py-symtab.c (stpy_fullname): Constify.
* cli/cli-cmds.c (edit_command): Constify.
* breakpoint.c (print_breakpoint_location)
(update_static_tracepoint): Constify.

* breakpoint.c (compare_breakpoints): Fix comparison.

Remove some extraneous changes in readline/terminal.c

This patch removes some unnecessary differences between the official
version of readline, and GDB's copy of it.

readline/ChangeLog.gdb:

        * terminal.c: Remove duplicate includes of windows.h and
        wincon.h.
        (_rl_get_screen_size): Remove redundant code for MinGW getting
        the console size from the Windows API.

ChangeLog bfd

2012-10-18  Kai Tietz  <ktietz@redhat.com>

PR binutils/14067
* coff-i386.c (bfd_target): Add section flag SEC_EXCLUDE.
Allow BFD_COMPRESS and BFD_DECOMPRESS flags.
* coff-x86_64.c: Likewise.
* coffcode.h (DOT_ZDEBUG): New define.
(sec_to_styp_flags): Check for .zdebug.
(styp_to_sec_flags): Likewise.
* coffgen.c (make_a_section): Handle .debug_* section
compression/decompression flags.
* cofflink.c (mark_relocs): Ignore relocations
for a section, which isn't marked as used.
(_bfd_coff_link_input_bfd): Add support of compressed
debug sections.
* compress.c (decompress_contents): Loop as long
as there is input available and there is room for
output.
* bfd/pe-arm.c: Add .zdebug_ partial match entry.
* pe-i386.c: Likewise.
* pe-x86_64.c: Likewise.
* peXXigen.c (_bfd_XXi_swap_aouthdr_out): Don't clear all
data-directories as this might destroy content.

        * coff-i386.c (_bfd_generic_find_nearest_line_discriminator):
        define as coff_find_nearest_line_discriminator.
        * libcoff-in.h (coff_find_nearest_line_discriminator): New
        * libcoff.h: Regenerated.
        * coff-x86_64.c: Likewise.
        * coffgen.c (coff_find_nearest_line_discriminator): New function.
        prototype.

ChangeLog binutils

2012-10-18  Kai Tietz  <ktietz@redhat.com>

* objdump.c (dump_bfd): Call dump headers after
call of slurp_symtab.

ChangeLog ld

2012-10-18  Kai Tietz  <ktietz@redhat.com>

PR binutils/14067
* NEWS: Menition new feature.
* scripttempl/pep.sc: Add zdebug sections.
* scripttempl/pe.sc: L

    * objcopy.c (is_strip_section_1): Don't strip
        .reloc section by default.

    * config/obj-coff.c: Add include of struc-symbol.h header.
        (coff_frob_symbol): Check that function-aux entries are generated for
        defined symbols only.

* tic54x-dis.c (print_instruction): Don't use K&R style.
(print_parallel_instruction, sprint_dual_address)
(sprint_indirect_address, sprint_direct_address, sprint_mmr)
(sprint_cc2, sprint_condition): Likewise.

* valprint.c (generic_emit_char, generic_printstr): Pass size of
gdb_wchar_t to convert_between_encodings.

    * aarch64-asm.c (aarch64_ins_ldst_reglist): Initialize
        value with a default.
        (do_special_encoding): Likewise.
        (aarch64_ins_ldst_elemlist): Pre-initialize QSsize, and opcodeh2
        variables with default.
        * arc-dis.c (write_comments_): Don't use strncat due
        size of state->commentBuffer pointer isn't predictable.

    * doc/as.texinfo: Add missing documentation about section flag
        exclude.

PR gold/14727
* object.cc (Relobj::is_section_name_included): Also match
.sdata personality section.

* target-reloc.h (class Default_comdat_behavior): New, package up..
(get_comdat_behaviour): ..this.
(relocate_section): Add Relocate_comdat_behavior template arg,
adjust code to suit.
* arm.cc (Target_arm::relocate_section): Adjust to suit.
(Target_arm::scan_reloc_section): Likewise.
* i386.cc (Target_i386::relocate_section): Likewise.
* sparc.cc (Target_sparc::relocate_section): Likewise.
* tilegx.cc (Target_tilegx::relocate_section): Likewise.
* x86_64.cc (Target_x86_64::relocate_section): Likewise.
* powerpc.cc (class Relocate_comdat_behavior): New.
(Target_powerpc::relocate_section): Don't zap opd relocs.  Supply
gold::relocate_section with new template arg.

*** empty log message ***

daily update

* powerpc.cc (Target_powerpc::Scan::local, global): Always emit
dynamic relocs for GOT_TPREL got entries, without symbol if
resolving locally.
(Target_powerpc::do_gc_add_reference): Don't add for dynamic objects.
(Target_powerpc::scan_relocs): Define _GLOBAL_OFFSET_TABLE_ early.
(Target_powerpc::Relocate:relocate): REL32 reloc may be unaligned.

PR gold/14726
* gold.cc (queue_middle_tasks): Call gc_mark_symbol on _init and _fini.

gdb:
* breakpoint.c (invalidate_bp_value_on_memory_change): Add one
more parameter 'inferior'.
* corefile.c (write_memory_with_notification): Caller update.

* mi/mi-cmd-var.c: Include "mi-main.h".
(mi_cmd_var_assign): Set mi_suppress_notification.data_write_memory
to 1 and restore it later.
* mi/mi-cmds.c (mi_cmd mi_cmds): Update for "data-write-memory"
and "data-write-memory-bytes.
* mi/mi-interp.c: Include objfiles.h.
(mi_interpreter_init): Call observer_attach_memory_changed.
(mi_memory_changed): New.
* mi/mi-main.h (struct mi_suppress_notification) <memory>:
New field.

* NEWS: Mention new MI notification "memory-changed".

gdb/doc:

* observer.texi (GDB Observers): Update observer
'memory_changed'.
* gdb.texinfo (GDB/MI Async Records): Document for
"memory-changed" notification.

gdb/testsuite:

* gdb.mi/mi-memory-changed.exp: New.

*** empty log message ***

daily update

Add missing ChangeLog entry for previous commit:

2012-10-16  Joel Brobecker  <brobecker@adacore.com>

       * coff64-rs6000.c (rs6000coff64_vec): Set _close_and_cleanup
       field to _bfd_archive_close_and_cleanup.
       (aix5coff64_vec): Likewise.

dangling pointer in coff64-rs6000 archive cache.

bfd/ChangeLog:

        * coff64-rs6000.c (rs6000coff64_vec): Set _close_and_cleanup
        field to _bfd_archive_close_and_cleanup.
        (aix5coff64_vec): Likewise.

Dangling bfd pointer in archive cache.

This dandling pointer eventually leads to a crash when trying to run
on ppc-aix a program using threading...

bfd/ChangeLog:

        * coff-rs6000.c (rs6000coff_vec): Set _close_and_cleanup
        field to _bfd_archive_close_and_cleanup.
        (pmac_xcoff_vec): Likewise.

2012-10-16  Sriraman Tallam  <tmsriram@google.com>

* layout.cc (Layout::include_section): Keep sections marked
SHF_EXCLUDE when doing relocatable links.

Fixed AArch64 TLS relocation resolution.

bfd/

* elf64-aarch64.c (elf64_aarch64_tls_howto_table): Fix shift value for
R_AARCH64_TLSIE_LD_GOTTPREL_PREL19, R_AARCH64_TLSLE_MOVW_TPREL_G2,
R_AARCH64_TLSLE_MOVW_TPREL_G1, R_AARCH64_TLSLE_MOVW_TPREL_G1_NC,
R_AARCH64_TLSLE_ADD_TPREL_HI12.
(elf64_aarch64_tlsdesc_howto_table): Fix shift value for
R_AARCH64_TLSDESC_LD64_PREL19 and R_AARCH64_TLSDESC_OFF_G1.
(elf64_aarch64_final_link_relocate): Add signed_addend when resolving
AARCH64_TLSLE_*_TPREL_* relocations.

ld/testsuite/

* ld-aarch64/tlsle-symbol-offset.s: New file.
* ld-aarch64/tlsle-symbol-offset.d: New file.
* ld-aarch64/aarch64-elf.exp: Add tlsle-symbol-offset test.

gdb/testsuite/
* gdb.reverse/solib-precsave.exp: Skip if skip_shlib_test
returns true.
Call gdb_load_shlibs.
* gdb.reverse/solib-reverse.exp: Likewise.

gdb/
* dwarf2loc.c (dwarf_expr_reg_to_entry_parameter): Remove comment.

* elf32-xtensa.c (free_section_cache): Renamed from
clear_section_cache.  Don't zero cache.
(section_cache_section): Remove ineffectual zero of cache.
Call init_section_cache instead.

* powerpc.cc (Target_powerpc::define_save_restore_funcs): New func.
(Target_powerpc::do_finalize_sections): Call it.
(Output_data_save_res): New class and supporting functions.
(Target_powerpc::symval_for_branch): Only look up .opd entry for
normal symbols defined in object files.

*** empty log message ***

daily update

* lib/cp-support.exp (cp_test_ptype_class): Add support
for class typedefs.

* gdb.cp/derivation.exp: Add tests for g_instance.

New option -nh: inhibit loading of ~/.gdbinit.
* NEWS: Mention -nh.
* main.c (captured_main): Recognize and process -nh.
(print_gdb_help): Mention -nh.
* gdb.1: Mention -nh.  Remove erroneous docs on -nx behavior.

doc/
* gdb.texinfo (Mode Options): Document -nh.
Elaborate on docs for -nx.

Remove sp_regnum_from_eax and pc_regnum_from_eax

PR backtrace/14646
PR gdb/14647
* i386-tdep.h (gdbarch_tdep): Remove sp_regnum_from_eax and
pc_regnum_from_eax.
* i386-tdep.c (i386_gdbarch_init): Don't use sp_regnum_from_eax
nor pc_regnum_from_eax.
* amd64-tdep.c (amd64_x32_init_abi): Don't set sp_regnum_from_eax
nor pc_regnum_from_eax.

* elf.c (special_sections_d): Add comment.

gdb/
Fix entry values resolving in inlined frames.
* dwarf2loc.c (dwarf_expr_reg_to_entry_parameter): Move func_addr,
gdbarch and caller_frame initialization later.  Skip INLINE_FRAME
entries of FRAME.

gdb/testsuite/
Fix entry values resolving in inlined frames.
* gdb.arch/amd64-entry-value-inline.S: New file.
* gdb.arch/amd64-entry-value-inline.c: New file.
* gdb.arch/amd64-entry-value-inline.exp: New file.

gdb/testsuite/
Fix recent gdb_breakpoint regression.
* gdb.java/jmisc.exp: gdb_breakpoint for $function - remove curly
braces from the parameter.
* gdb.java/jprint.exp: Likewise.

* lib/gdb.exp (runto): Fix call to gdb_breakpoint.

Remove trailing '#' in gdb.dwarf2/dw2-icc-opaque.S

gdb/testsuite/ChangeLog:

        * gdb.dwarf2/dw2-icc-opaque.S: Remove '#'.

Build with -DMS_WIN64 on amd64-windows if Python enabled...

... and building with GCC.

gdb/ChangeLog:

        * configure.ac: Build with -DMS_WIN64 if building with Python
        enabled using GCC on amd64-windows.
        * configure: Regenerate.

PR python/14635:
* python/py-symtab.c (del_objfile_sal): Set 'symtab' field
to Py_None.
testsuite
* gdb.python/py-symtab.exp: Test sal and symtab destructors.

PR python/14634:
* python/py-symbol.c (sympy_dealloc): Check for NULL symbol.
testsuite
* gdb.python/py-symbol.exp: Test symbol destructor.

Updated the system register table.

opcodes/

* aarch64-opc.c (aarch64_sys_regs): Add rmr_el1, rmr_el2 and
rmr_el3; remove daifset and daifclr.

gas/testsuite/

* gas/aarch64/sysreg-1.s: Add tests of rmr_el1, rmr_el2 and rmr_el3.
* gas/aarch64/sysreg-1.d: Update.
* gas/aarch64/illegal.s: Add tests of daifset and daifclr.
* gas/aarch64/illegal.d: Update.

Added the changelog for the previous commit.

Added missing alignment check to load/store uimm12 immediate offset.

opcodes/

* aarch64-opc.c (operand_general_constraint_met_p): Change to check
the alignment of addr.offset.imm instead of that of shifter.amount for
operand type AARCH64_OPND_ADDR_UIMM12.

gas/testsuite/

* gas/aarch64/illegal-2.s: Add test case.
* gas/aarch64/illegal-2.l: Likewise.

* hppa.h (pa_opcodes): Use "cX" completer instead of "cx" in fstqx
opcodes.  Likewise, use "cM" instead of "cm" in fstqs opcodes.

*** empty log message ***

* config/tc-hppa.c (pa_get_number): New.
(pa_get_absolute_expression): Simplify.
(pa_ip): Use pa_get_number instead of pa_get_absolute_expression
to get SOP, SFU and COPR identifiers.

* config/tc-hppa.c (pa_ip): Reject double floating point stores and
loads that reference the right half of a floating point register.

* gas/hppa/basic/fmemLRbug.s: Remove double load and store instructions
which reference the right half of a floating point register.
* gas/hppa/basic/basic.exp: Adjust expected results.

daily update

gdb/testsuite/
* gdb.mi/mi2-cli.exp: Move to mi-cli.exp.
* gdb.mi/mi-cli.exp: New.

* gdb.mi/mi2-basics.exp: Remove.
* gdb.mi/mi2-break.exp: Remove.
* gdb.mi/mi2-console.exp: Remove.
* gdb.mi/mi2-disassemble.exp: Remove.
* gdb.mi/mi2-eval.exp: Remove.
* gdb.mi/mi2-file.exp: Remove.
* gdb.mi/mi2-hack-cli.exp: Remove.
* gdb.mi/mi2-pthreads.exp: Remove.
* gdb.mi/mi2-read-memory.exp: Remove.
* gdb.mi/mi2-regs.exp: Remove.
* gdb.mi/mi2-return.exp: Remove.
* gdb.mi/mi2-simplerun.exp: Remove.
* gdb.mi/mi2-stack.exp: Remove.
* gdb.mi/mi2-stepi.exp: Remove.
* gdb.mi/mi2-syn-frame.exp: Remove.
* gdb.mi/mi2-until.exp: Remove.
* gdb.mi/mi2-watch.exp: Remove.
* gdb.mi/mi2-var-block.exp: Remove.
* gdb.mi/mi2-var-cmd.exp: Remove.
* gdb.mi/mi2-var-display.exp: Remove.

*** empty log message ***

daily update

* config/tc-hppa.c (pa_ip): Limit unit conditions for uxor to those
not involving a carry.

* gas/hppa/basic/unit.s: Remove uxor instructions with unit condition
involving a carry.
* gas/hppa/basic/unit2.s: Likewise.
* gas/hppa/basic/basic.exp: Adjusted expected.

Replace -ldl with @lt_cv_dlopen_libs@

* Makefile.am (LIBDL): Replace -ldl with @lt_cv_dlopen_libs@.
* configure.in (lt_cv_dlopen_libs): AC_SUBST.
* Makefile.in: Regenerated.
* configure: Likewise.

*** empty log message ***

daily update

gas/
* doc/as.texinfo (-mpwr4, -mpwr7): Fix option name typos.

* powerpc.cc (Powerpc_relobj::add_gc_mark, process_gc_mark): New.
(struct Opd_ent): Make "discard" a bit field.  Add "gc_mark".
(Target_powerpc::do_gc_mark_symbol): Delay marking function code
section if scan_opd_relocs not yet called.
(Target_powerpc::gc_process_relocs): Call process_gc_mark.

* powerpc.cc (Output_data_plt_powerpc::add_entry, add_ifunc_entry,
add_local_ifunc_entry): Revert last change.
(Target_powerpc::make_plt_entry, make_local_ifunc_plt_entry): Likewise.

gdb/testsuite/
* gdb.mi/mi-breakpoint-changed.exp (test_pending_resolved): Remove
trail '.*' on matching patterns.

*** empty log message ***

daily update

sourceware.org/ml/gdb-patches/2012-10/msg00032.html

gdb/ChangeLog

        * remote-sim.c (gdbsim_create_inferior): Call init_thread_list to
        reset thread numbering back to 1.

Use is_x86_like_target to check x86 targets

* gdb.arch/i386-bp_permanent.exp: Skip if not is_x86_like_target.
* gdb.arch/i386-cfi-notcurrent.exp: Likewise.
* gdb.arch/i386-disp-step.exp: Likewise.
* gdb.arch/i386-gnu-cfi.exp: Likewise.
* gdb.arch/i386-prologue.exp: Likewise.
* gdb.arch/i386-size-overlap.exp: Likewise.
* gdb.arch/i386-size.exp: Likewise.
* gdb.arch/i386-unwind.exp: Likewise.

Check byte/word registers on x86_64

* gdb.arch/i386-byte.exp: Remove is_ilp32_target check.
* gdb.arch/i386-word.exp: Likewise.

Check is_amd64_regs_target to to set nr_regs

* gdb.arch/i386-avx.exp: Check is_amd64_regs_target instead of
is_ilp32_target to set nr_regs.
* gdb.arch/i386-sse.exp: Likewise.

PR breakpoints/14643.
* linespec.c (struct ls_parser): New member keyword_ok.
(linespec_lexer_lex_string): Add comment.
(linespec_lexer_lex_one): Ignore keywords if it's the wrong place
for one.
(parse_linespec): Set keyword_ok.

testsuite/
* gdb.linespec/ls-errs.exp: Change tests of "b if|task|thread".
* gdb.linespec/thread.c: New file.
* gdb.linespec/thread.exp: New file.

config.{guess,sub}: update from upstream config-patches repo

From: David Holsgrove <david.holsgrove@xilinx.com>

Adds microblaze little endian support.

Signed-off-by: David Holsgrove <david.holsgrove@xilinx.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>

* lib/gdb.exp (gdb_breakpoint): Fix varargs scan.
Recognize "message" -> print pass and fail.  Add eof case.
(runto): Recognize message, no-message.  Print pass/fail if requested,
with same treatment as gdb_breakpoint.
(runto_main): Pass no-message to runto.
(gdb_internal_error_resync): Add log message.
(gdb_file_cmd): Tweak internal error fail text for consistency.

2012-10-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

* arm-dis.c: Use preferred form of vrint instruction variants
for disassembly.

2012-10-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

* gas/arm/armv8-a+fp.d: Use preferred form of vrint instruction
variants for disassembly.
* gas/arm/armv8-a+fp.s: Likewise.
* gas/arm/armv8-a+simd.d: Likewise.
* gas/arm/armv8-a+simd.s: Likewise.

2012-10-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

* config/tc-arm.c: Change condition code insertion for
lds[hb] instructions from after the 2nd character to after the 3rd.
(tCM): Remove macro.
(TxCM): Likewise.
(TxCM_): Likewise.
(TCM): Likewise.

2012-10-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

* gas/arm/ldgesb-bad.d: New file.
* gas/arm/ldgesb-bad.l: Likewise.
* gas/arm/ldgesb-bad.s: Likewise.
* gas/arm/ldgesh-bad.d: Likewise.
* gas/arm/ldgesh-bad.l: Likewise.
* gas/arm/ldgesh-bad.s: Likewise.
* gas/arm/ldsgeb.d: Likewise.
* gas/arm/ldsgeb.s: Likewise.
* gas/arm/ldsgeb.l: Likewise.
* gas/arm/ldsgeh.d: Likewise.
* gas/arm/ldsgeh.s: Likewise.
* gas/arm/ldsgeh.l: Likewise.

* dwarf.c (display_gdb_index): Include static/global information
of each symbol.

* dwarf2read.c (process_psymtab_comp_unit_reader): Remove duplicate
"0x" prefix on address in log message.

* dwarf2read.c (read_1_byte): Add const to buf parameter.
(read_1_signed_byte, read_2_bytes, read_2_signed_bytes): Ditto.
(read_4_bytes, read_4_signed_bytes, read_8_bytes): Ditto.
(lookup_dwo_file): Add const to dwo_name parameter.
(lookup_dwo_comp_unit, lookup_dwo_type_unit): Ditto.

*** empty log message ***

daily update

merge from gcc

*** empty log message ***

daily update

Add AMD bdver3 support.

gas/

* config/tc-i386.c (cpu_arch): Add CPU_BDVER3_FLAGS.
* doc/c-i386.texi: Add -march=bdver3 option.

gas/testsuite/

* gas/i386/i386.exp: Run bdver3 test cases.
* gas/i386/nops-1-bdver3.d: New.
* gas/i386/arch-10-bdver3.d: New.
* gas/i386/x86-64-nops-1-bdver3.d: New.
* gas/i386/x86-64-arch-2-bdver3.d: New.

opcodes/

* i386-gen.c (cpu_flag_init): Add CPU_BDVER3_FLAGS.
* i386-init.h: Regenerated.

*** empty log message ***

daily update

* ld-scripts/sane1.d: Sort output from nm. Allow for other symbols in
output.

*** empty log message ***

PR binutils/14662
* elf.c (_bfd_elf_make_section_from_shdr): Treat .gdb_index as
SEC_DEBUGGING.

daily update

*** empty log message ***

daily update

gdb/
Fix crash during stepping on ppc32.
* ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): Test NULL
SYM.

gdb/testsuite/
Fix crash during stepping on ppc32.
* gdb.base/step-symless.c: New file.
* gdb.base/step-symless.exp: New file.