Kenneth Graunke [Sat, 15 Sep 2018 21:50:26 +0000 (14:50 -0700)]
iris: re-pin binding table contents if we didn't re-emit them
fixes glsl-vs-loop and other regressions from multibinder.
Kenneth Graunke [Sat, 15 Sep 2018 21:35:47 +0000 (14:35 -0700)]
iris: move binder pinning outside the dirty == 0 check
This might be a new batch with back to back non-dirty calls, if so we
need to inherit the old binder...
Chris Wilson [Fri, 14 Sep 2018 22:12:36 +0000 (15:12 -0700)]
iris: fix memzone_for_address since multibinder changes
Kenneth Graunke [Thu, 13 Sep 2018 06:31:46 +0000 (23:31 -0700)]
iris: update comments for multibinder
Kenneth Graunke [Thu, 13 Sep 2018 05:23:50 +0000 (22:23 -0700)]
iris: fix SO offset writes for multiple streams
Kenneth Graunke [Sun, 9 Sep 2018 02:43:34 +0000 (19:43 -0700)]
iris: Support multiple binder BOs, update Surface State Base Address
Kenneth Graunke [Tue, 11 Sep 2018 08:09:27 +0000 (01:09 -0700)]
iris: fix null FB and unbound tex surface state addresses
Kenneth Graunke [Sat, 8 Sep 2018 06:39:30 +0000 (23:39 -0700)]
iris: set EXEC_OBJECT_CAPTURE on all driver internal buffers
Kenneth Graunke [Fri, 7 Sep 2018 19:26:55 +0000 (12:26 -0700)]
iris: fix constant buffer 0 to be absolute
thanks to Jason for catching this. Fixes some va64 tests. Surprisingly
not much else, as apparently getting to UBO range 4 is uncommon!
Kenneth Graunke [Sat, 1 Sep 2018 01:03:19 +0000 (18:03 -0700)]
iris: don't unconditionally emit 3DSTATE_VF / 3DSTATE_VF_TOPOLOGY
this was just laziness on my part
Kenneth Graunke [Sat, 1 Sep 2018 07:58:29 +0000 (00:58 -0700)]
iris: skip over whole function if dirty == 0
kinda pointless in non-pathological cases, but does boost our score in
the drawarrays case by 50%...
Kenneth Graunke [Sun, 19 Aug 2018 17:31:29 +0000 (10:31 -0700)]
iris: Allow inlining of require/get_command_space
eliminates so many callqs for ptr++
Kenneth Graunke [Fri, 7 Sep 2018 02:42:58 +0000 (19:42 -0700)]
iris: use Eric's new caps helper
this does change a couple caps...PRIMITIVE_RESTART_FOR_PATCHES...
Kenneth Graunke [Sat, 1 Sep 2018 04:22:31 +0000 (21:22 -0700)]
iris: new caps
Kenneth Graunke [Wed, 29 Aug 2018 22:24:45 +0000 (15:24 -0700)]
iris: fix blend state memcpy
thanks to Jason for noticing grumpy valgrind
Kenneth Graunke [Sat, 25 Aug 2018 07:11:24 +0000 (00:11 -0700)]
iris: Skip primitive ID overrides if the shader wrote a custom value
Fixes glsl-1.50/execution/geometry/primitive-id-out
Kenneth Graunke [Fri, 24 Aug 2018 04:21:04 +0000 (21:21 -0700)]
iris: fix crash when binding optional shader for the first time
Kenneth Graunke [Thu, 23 Aug 2018 09:36:18 +0000 (02:36 -0700)]
iris: handle level/layer in direct maps
needed now that we do 1D linear
Kenneth Graunke [Thu, 23 Aug 2018 06:39:38 +0000 (23:39 -0700)]
iris: use linear for 1D textures
This gets us the gen9 compact linear storage
Kenneth Graunke [Thu, 23 Aug 2018 08:49:49 +0000 (01:49 -0700)]
iris: big old hack for tex-miplevel-selection
copied from ilo. I don't understand this at all..
Kenneth Graunke [Thu, 23 Aug 2018 09:15:12 +0000 (02:15 -0700)]
iris: fix sampler state setting
Kenneth Graunke [Tue, 21 Aug 2018 18:50:56 +0000 (11:50 -0700)]
iris: try to hack around binder issue
Kenneth Graunke [Tue, 21 Aug 2018 18:30:09 +0000 (11:30 -0700)]
iris: fix line-aa-width
we should probably move the roundf to st_atom_raster
Kenneth Graunke [Tue, 21 Aug 2018 06:37:13 +0000 (23:37 -0700)]
iris: implement get_sample_position
Fixes arb_sample_shading/builtin-gl-sample-position
Kenneth Graunke [Tue, 21 Aug 2018 04:23:25 +0000 (21:23 -0700)]
iris: z_res -> s_res
fixes crashes introduced a few commits ago
Kenneth Graunke [Tue, 21 Aug 2018 03:55:17 +0000 (20:55 -0700)]
iris: reenable R32G32B32 texture buffers
This dropped us from GL 4.2 to GL 3.3 by mistake. Thanks to Dave for
catching this!
Chris Wilson [Sun, 19 Aug 2018 09:32:43 +0000 (10:32 +0100)]
iris: Record reusability of bo on construction
We know that if the bufmgr->reuse is set to false or if the bo is too
large for a bucket, the same will be true when we come to free the bo.
Kenneth Graunke [Sun, 19 Aug 2018 21:05:53 +0000 (14:05 -0700)]
iris: Reduce binder alignment from 64 to 32
3DSTATE_BINDING_TABLE_POINTER_XS's alignment requirement is only 32B.
Makes us waste less precious binder space.
Kenneth Graunke [Sun, 19 Aug 2018 17:08:05 +0000 (10:08 -0700)]
iris: precompute hashes for cache tracking
saves a touch of cpu overhead in the new resolve tracking
Chris Wilson [Tue, 31 Jul 2018 13:47:02 +0000 (14:47 +0100)]
iris: AMD_pinned_memory
(rebased by Ken, mainly set res->internal_format)
Kenneth Graunke [Sun, 19 Aug 2018 07:21:34 +0000 (00:21 -0700)]
iris: proper cache tracking
this is copied from the i965 aux resolve stuff...minus the aux resolves
Kenneth Graunke [Sun, 19 Aug 2018 07:18:51 +0000 (00:18 -0700)]
iris: Move cache tracking to iris_resolve.c
Kenneth Graunke [Sun, 19 Aug 2018 07:31:46 +0000 (00:31 -0700)]
iris: use consistent copyright formatting
some of them had typos, didn't say 'authors or copyright holders',
or other mistakes. This is now https://opensource.org/licenses/MIT
text, formatted consistently.
Kenneth Graunke [Sun, 19 Aug 2018 06:21:41 +0000 (23:21 -0700)]
iris: track depth/stencil writes enabled
Kenneth Graunke [Sun, 19 Aug 2018 06:58:54 +0000 (23:58 -0700)]
iris: Move iris_sampler_view declaration to iris_resource.h
We'll need this for resolve tracking. There's also no genxml stuff here
Kenneth Graunke [Sun, 19 Aug 2018 06:43:14 +0000 (23:43 -0700)]
iris: Move things to iris_shader_state
We didn't originally have this struct, so we had lots of ad-hoc arrays.
Now that we have it, it makes sense to group things there.
Kenneth Graunke [Sun, 19 Aug 2018 06:39:48 +0000 (23:39 -0700)]
iris: move iris_shader_state from ice->shaders.state to ice->state.shaders
it's more state related...
Kenneth Graunke [Sun, 19 Aug 2018 06:44:11 +0000 (23:44 -0700)]
iris: Drop bogus sampler state saving
We do this in an earlier loop. This was just reading things out of the
array, and saving them back over the same array...but in the wrong slots
Kenneth Graunke [Sun, 19 Aug 2018 06:21:32 +0000 (23:21 -0700)]
iris: rename pipe to base
Kenneth Graunke [Sat, 18 Aug 2018 08:24:38 +0000 (01:24 -0700)]
iris: don't emit SBE all the time
Kenneth Graunke [Fri, 17 Aug 2018 06:49:31 +0000 (23:49 -0700)]
iris: port non-bucket alignment bugfix
Sergii's
24839663a40257e0468406d72c48d431b5ae2bd4
Kenneth Graunke [Fri, 17 Aug 2018 06:48:24 +0000 (23:48 -0700)]
iris: drop pwrite
nobody uses it
Kenneth Graunke [Fri, 17 Aug 2018 06:47:58 +0000 (23:47 -0700)]
iris: drop dead assignments
Eric's commit
9a6a6317629eb4c63d28860ded30778ac341ac63
Kenneth Graunke [Wed, 15 Aug 2018 20:35:05 +0000 (13:35 -0700)]
iris: last VUE map NOS, handle > 16 FS inputs
not sure if the UNCOMPILED_FS flagging is still needed, should
reevaluate those hacks at some point
Kenneth Graunke [Wed, 15 Aug 2018 08:34:10 +0000 (01:34 -0700)]
iris: implement ARB_clear_texture
Kenneth Graunke [Wed, 15 Aug 2018 06:37:53 +0000 (23:37 -0700)]
iris: call maybe_flush for each blorp operation
otherwise with high layer counts we may exceed two batches worth of
commands... (!)
Kenneth Graunke [Wed, 15 Aug 2018 06:22:12 +0000 (23:22 -0700)]
iris: assert depth is 1 in resource_copy_region
given the dstz parameter I don't think it does multiple slices..
Kenneth Graunke [Wed, 15 Aug 2018 06:20:21 +0000 (23:20 -0700)]
iris: blorp blit multiple slices
fixes getteximage-depth
Kenneth Graunke [Tue, 14 Aug 2018 23:44:07 +0000 (16:44 -0700)]
iris: Fix tiled memcpy for cubes...and for array slices
tiled_memcpy_map was not offsetting map->ptr based on the slice,
while unmap was. also, we were doing offsetting wrong for cubes.
Kenneth Graunke [Tue, 14 Aug 2018 22:50:42 +0000 (15:50 -0700)]
iris: disallow RGB32 formats too
Kenneth Graunke [Mon, 13 Aug 2018 23:41:19 +0000 (16:41 -0700)]
iris: Convert RGBX to RGBA for rendering.
Fixes a bunch of RGB bugs.
Kenneth Graunke [Sat, 11 Aug 2018 19:48:24 +0000 (12:48 -0700)]
iris: we can do multisample Z resolves
Kenneth Graunke [Sat, 11 Aug 2018 19:47:46 +0000 (12:47 -0700)]
iris: deal with Marek's new MSAA caps
storage sample count is equal to sample count for us, for now,
so 0 the pipe cap and ignore the new parameter
Kenneth Graunke [Sat, 11 Aug 2018 06:50:02 +0000 (23:50 -0700)]
iris: say no to more formats
copied from brw_surface_formats.c
Kenneth Graunke [Thu, 9 Aug 2018 19:27:58 +0000 (12:27 -0700)]
iris: actually do stencil blits
Kenneth Graunke [Thu, 9 Aug 2018 16:19:58 +0000 (09:19 -0700)]
iris: refcounting, who needs it?
that's right, we do!
Kenneth Graunke [Thu, 9 Aug 2018 10:28:24 +0000 (03:28 -0700)]
iris: drop stencil handling now that u_transfer_helper does it
Kenneth Graunke [Wed, 8 Aug 2018 21:54:09 +0000 (14:54 -0700)]
iris: use u_transfer_helper for depth stencil packing/unpacking
Kenneth Graunke [Tue, 7 Aug 2018 16:21:40 +0000 (09:21 -0700)]
iris: WTF transfers
stencil unfortunately is stored in the Weird Tile Format (WTF or Tile-W)
which needs special CPU detiling code.
Kenneth Graunke [Sun, 5 Aug 2018 06:19:12 +0000 (23:19 -0700)]
iris: allow S8 as a stencil format
Kenneth Graunke [Fri, 3 Aug 2018 23:18:09 +0000 (16:18 -0700)]
iris: actually emit stencil packets
Kenneth Graunke [Mon, 30 Jul 2018 22:08:02 +0000 (15:08 -0700)]
iris: clear stencil
Kenneth Graunke [Fri, 3 Aug 2018 08:24:51 +0000 (01:24 -0700)]
iris: depth or stencil fixes
Kenneth Graunke [Thu, 2 Aug 2018 05:27:16 +0000 (22:27 -0700)]
iris: fill out more caps
Kenneth Graunke [Wed, 1 Aug 2018 18:21:57 +0000 (11:21 -0700)]
iris: get angry about execbuf failures
want this to be easy to detect for now
Kenneth Graunke [Wed, 1 Aug 2018 00:32:47 +0000 (17:32 -0700)]
iris: simplify batch len qword alignment
Split from a patch by Chris Wilson so I can test it independently
Kenneth Graunke [Tue, 31 Jul 2018 23:10:50 +0000 (16:10 -0700)]
iris: rename ring to engine
makes more sense these days. split from a patch by Chris Wilson
Kenneth Graunke [Tue, 31 Jul 2018 22:40:12 +0000 (15:40 -0700)]
iris: remember to set bo->userptr
Chris Wilson [Mon, 30 Jul 2018 23:52:34 +0000 (00:52 +0100)]
iris: Wrap userptr for creating bo
Kenneth Graunke [Tue, 31 Jul 2018 22:34:44 +0000 (15:34 -0700)]
iris: sync bugfixes from brw_bufmgr
I wrote softpin support here first, then debugged and landed it in brw;
some of those fixes need to get brought back.
Kenneth Graunke [Tue, 31 Jul 2018 06:49:34 +0000 (23:49 -0700)]
iris: comment everything
1. Write the code
2. Add comments
3. PROFIT (or just avoid cost of explaining or relearning things...)
Kenneth Graunke [Tue, 31 Jul 2018 05:59:52 +0000 (22:59 -0700)]
iris: add minor comments
Dave Airlie [Tue, 31 Jul 2018 00:33:35 +0000 (10:33 +1000)]
iris: fix some hangs around null framebuffers
This fixes some cases in fbo-none* and framebuffer_no_attachments.
I'm not sure this is correct otherwise, the tests don't all pass yet
No idea if this is in any way the correct answer
Chris Wilson [Sat, 28 Jul 2018 20:10:17 +0000 (21:10 +0100)]
iris: Set resource modifier on handle
Required for gdm_bo_create_with_modifiers
Kenneth Graunke [Sat, 28 Jul 2018 03:57:55 +0000 (20:57 -0700)]
iris: we don't support textureGatherOffsets, need it lowered
Kenneth Graunke [Sat, 28 Jul 2018 03:25:21 +0000 (20:25 -0700)]
iris: cube arrays are cubes too
Kenneth Graunke [Fri, 27 Jul 2018 23:02:09 +0000 (16:02 -0700)]
iris: fix sample mask
0xffffffff does not mean 1, it means enable as many as there actually
are. we don't get set_sample_mask() calls until some masking is
actually applied...i.e. it doesn't get updated based on # of samples
in the FBO changing.
Kenneth Graunke [Fri, 27 Jul 2018 05:32:08 +0000 (22:32 -0700)]
iris: drop pipe_shader_state
looking at the freedreno code, this is totally unnecessary! we can just
store the NIR and be happy, and not have any vestiges of TGSI.
plus we can reuse this structure for compute shaders, without needing a
pipe_compute_state base.
Kenneth Graunke [Thu, 26 Jul 2018 08:11:11 +0000 (01:11 -0700)]
iris: fix GS output component limit
this is total, so should be 1024, not 128
Kenneth Graunke [Thu, 26 Jul 2018 08:06:27 +0000 (01:06 -0700)]
iris: Avoid croaking when trying to create FBO surfaces with bad formats
create_surface happens before st_validate_attachment, which actually
does the "hey, this is a render target now, is that OK?" check
Fixes asserts in ./bin/arb_texture_view-rendering-formats, allowing the
rest of the tests to run.
Kenneth Graunke [Thu, 26 Jul 2018 06:33:16 +0000 (23:33 -0700)]
iris: enable texture gather
Kenneth Graunke [Wed, 25 Jul 2018 22:09:50 +0000 (15:09 -0700)]
iris: BIG OL' HACK for UBO updates
We need to re-push data when UBO changes. This will need to be replaced
with a usage history based flushing system later.
Kenneth Graunke [Wed, 25 Jul 2018 21:39:02 +0000 (14:39 -0700)]
iris: update a todo comment
Kenneth Graunke [Wed, 25 Jul 2018 05:14:37 +0000 (22:14 -0700)]
iris: Don't reserve new binding table section unless things are dirty
Kenneth Graunke [Wed, 25 Jul 2018 04:15:13 +0000 (21:15 -0700)]
iris: implement texture/memory barriers
Kenneth Graunke [Wed, 25 Jul 2018 04:03:52 +0000 (21:03 -0700)]
iris: drop unused bo parameter
Kenneth Graunke [Wed, 25 Jul 2018 03:57:10 +0000 (20:57 -0700)]
iris: update bindings when changing programs
the binding table layout depends on program info.
not known to fix anything yet.
Kenneth Graunke [Wed, 25 Jul 2018 03:57:02 +0000 (20:57 -0700)]
iris: fix for disabling ssbos
Kenneth Graunke [Wed, 25 Jul 2018 00:44:09 +0000 (17:44 -0700)]
iris: fix SSBO indexing
st/nir offsets SSBO indexes by MaxABOs. This is not what we want,
as it bloats the binding tables. We'll need to adjust it to use
info->num_abos as the offset and buffer base instead. For now,
just use the inefficient format to get us rolling. We can add a
PIPE_CAP later.
Kenneth Graunke [Wed, 25 Jul 2018 00:03:48 +0000 (17:03 -0700)]
iris: enable SSBOs
Kenneth Graunke [Wed, 25 Jul 2018 00:02:25 +0000 (17:02 -0700)]
iris: fix TBO alignment to match 965
Kenneth Graunke [Tue, 24 Jul 2018 23:20:02 +0000 (16:20 -0700)]
iris: unbind compiled shaders if none are present
avoids the case where you have a stale compiled shader bound, but no
uncompiled shader bound, which is not just boats, but an entire marina
Kenneth Graunke [Tue, 24 Jul 2018 23:11:37 +0000 (16:11 -0700)]
iris: shorten loop
num_ubos doesn't include Tim's magic UBO for regular uniforms, so +1
Kenneth Graunke [Tue, 24 Jul 2018 23:03:32 +0000 (16:03 -0700)]
iris: emit binding table for atomic counters and SSBOs
Kenneth Graunke [Tue, 24 Jul 2018 22:54:00 +0000 (15:54 -0700)]
iris: implement set_shader_buffers
for SSBOs/ABOs. We just stream out SURFACE_STATE for now...since it's
a set_* API...and the buffer offset may change...not sure where else
we'd do it.
Kenneth Graunke [Tue, 24 Jul 2018 22:04:39 +0000 (15:04 -0700)]
iris: export get_shader_info
Kenneth Graunke [Tue, 24 Jul 2018 21:52:50 +0000 (14:52 -0700)]
iris: fix msaa flipping filters
Kenneth Graunke [Tue, 24 Jul 2018 21:49:13 +0000 (14:49 -0700)]
iris: expose more things that we already support
Kenneth Graunke [Tue, 24 Jul 2018 21:31:07 +0000 (14:31 -0700)]
iris: fix blorp filters
we have to switch to blorp enums after the rebase, but also we were
probably doing it wrong for MSAA before this.
Kenneth Graunke [Tue, 24 Jul 2018 17:59:10 +0000 (10:59 -0700)]
iris: hack around samples confusion