Thomas Koenig [Sun, 8 Dec 2019 13:42:42 +0000 (13:42 +0000)]
Error on Associate with a program.
2018-12-08 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92780
* resolve.c (resolve_assoc_var): Issue error if the associating
entity is a program.
2018-12-08 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92780
* gfortran.dg/associate_50.f90: New test.
From-SVN: r279088
Thomas Koenig [Sun, 8 Dec 2019 13:02:54 +0000 (13:02 +0000)]
re PR fortran/92764 (ICE in gfc_procedure_use)
2018-12-08 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92764
* interface.c (gfc_procedure_use): Check for existence of derived
component before using (twice).
2018-12-08 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92764
* gfortran.dg/interface_44.f90: New test.
From-SVN: r279087
Thomas Koenig [Sun, 8 Dec 2019 12:25:15 +0000 (12:25 +0000)]
re PR fortran/92755 (ICE in gfc_dep_resolver, at fortran/dependency.c:2123)
2019-12-08 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92755
* dependency.c (gfc_dep_resolver): Move skipping of _data ref
into the loop.
2019-12-08 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/92755
* gfortran.dg/dependency_57.f90: New test.
From-SVN: r279086
Rainer Orth [Sun, 8 Dec 2019 10:51:58 +0000 (10:51 +0000)]
Fix ia32 testsuite failures from C2x attributes on types
* g++.dg/cpp0x/gen-attrs-36.C: Update expected diagnostics.
* g++.dg/cpp0x/gen-attrs-37.C: Likewise.
* g++.dg/cpp0x/gen-attrs-8.C: Likewise.
From-SVN: r279085
GCC Administrator [Sun, 8 Dec 2019 00:16:24 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279084
Andrew Pinski [Sun, 8 Dec 2019 00:08:55 +0000 (00:08 +0000)]
Fix libstdc++ compiling for an aarch64 multilib with big-endian.
2019-12-07 Andrew Pinski <apinski@marvell.com>
* config/cpu/aarch64/opt/ext/opt_random.h: Wrap around with check
for little-endian like ext/random is done.
From-SVN: r279081
Marek Polacek [Sat, 7 Dec 2019 17:35:54 +0000 (17:35 +0000)]
PR c++/91678 - wrong error with decltype and location wrapper.
Compiling this testcase results in a bogus "invalid cast" error; this occurs
since the introduction of location wrappers in finish_id_expression.
Here we are parsing the decltype expression via cp_parser_decltype_expr which
can lead to calling various fold_* and c-family routines. They use
non_lvalue_loc, but that won't create a NON_LVALUE_EXPR wrapper around a location
wrapper.
So before the location wrappers addition cp_parser_decltype_expr would return
NON_LVALUE_EXPR <c>. Now it returns VIEW_CONVERT_EXPR<float *>(c), but the
STRIP_ANY_LOCATION_WRAPPER immediately following it strips the location wrapper,
and suddenly we don't know whether we have an lvalue anymore. And that's sad
because then decltype produces the wrong type, causing nonsense errors.
* fold-const.c (maybe_lvalue_p): Handle VIEW_CONVERT_EXPR.
* g++.dg/cpp0x/decltype73.C: New test.
From-SVN: r279077
Eric Botcazou [Sat, 7 Dec 2019 12:20:44 +0000 (12:20 +0000)]
re PR middle-end/90840 (ICE in simplify_subreg, at simplify-rtx.c:6441)
PR middle-end/90840
* expr.c (expand_assignment): In the case of a CONCAT on the LHS, make
sure to pass a valid inner mode in calls to simplify_gen_subreg.
From-SVN: r279076
Tobias Burnus [Sat, 7 Dec 2019 11:07:07 +0000 (11:07 +0000)]
Fortran] PR 92793 - fix column used for error diagnostic
PR fortran/92793
* trans.c (gfc_get_location): Declare.
* trans.c (gfc_get_location): Define; returns column-corrected location.
(trans_runtime_error_vararg, gfc_trans_runtime_check,
gfc_generate_module_code): Use new function.
* trans-array.c (gfc_trans_auto_array_allocation): Likewise.
* trans-common.c (build_field, get_init_field, create_common): Likewise.
* trans-decl.c (gfc_build_label_decl, gfc_get_symbol_decl): Likewise.
* trans-openmp.c (gfc_trans_omp_reduction_list, gfc_trans_omp_clauses):
Likewise.
* trans-stmt.c (gfc_trans_if_1): Likewise.
From-SVN: r279075
Richard Sandiford [Sat, 7 Dec 2019 09:57:04 +0000 (09:57 +0000)]
Fix @multitable handling in texi2pod.pl
While trying out Dennis's Armv8.6-A patch, I noticed that texi2pod.pl
didn't handle the new @multitable correctly. There were two problems:
(1) @multitables nested in other @tables inherited the @item type from
the enclosing @table. Since the new @multitable is in a @table @samp,
we applied @samp markup to the @multitable @items. This in turn
meant that it captured the @tab separator in the @item markup.
Fixed by pushing an empty item code onto the stack.
(2) We didn't handle @headitem. Fixed by enclosing it in italics,
like we do for section headings. This causes it to be underlined
in the man output.
2019-12-07 Richard Sandiford <richard.sandiford@arm.com>
contrib/
* texi2pod.pl: Handle @headitems in @multitables, printing them
in italics. Push an empty item code onto the stack.
From-SVN: r279074
Tobias Burnus [Sat, 7 Dec 2019 08:24:14 +0000 (08:24 +0000)]
re PR c/87488 (hyperlink filenames in diagnostics)
PR c/87488
* pretty-print.c (pp_begin_url, pp_end_url, test_urls): Use BEL
instead of ST sequence to terminate OSC 8 strings.
Co-Authored-By: David Malcolm <dmalcolm@redhat.com>
Co-Authored-By: Jakub Jelinek <jakub@redhat.com>
From-SVN: r279073
GCC Administrator [Sat, 7 Dec 2019 00:16:19 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279072
Jakub Jelinek [Fri, 6 Dec 2019 23:43:45 +0000 (00:43 +0100)]
re PR c++/92831 (CWG1299 extend_ref_init_temps_1 punts on COND_EXPRs)
PR c++/92831
* call.c (build_conditional_expr_1): For ?: with omitted middle
operand use cp_stabilize_reference if arg1 is glvalue_p rather than
just if it is lvalue_p.
* g++.dg/ext/temp-extend1.C: New test.
From-SVN: r279069
Tim Ruehsen [Fri, 6 Dec 2019 22:20:06 +0000 (22:20 +0000)]
Fix read buffer overflow in split_directories
* make-relative-prefix.c (split_directories):
Return early on empty 'name'
From-SVN: r279068
Marek Polacek [Fri, 6 Dec 2019 22:12:51 +0000 (22:12 +0000)]
Add test for c++/92451.
This was ICEing from r277865 to r278786.
* g++.dg/overload/error4.C: New test.
From-SVN: r279067
Jakub Jelinek [Fri, 6 Dec 2019 21:18:58 +0000 (22:18 +0100)]
parser.c (cp_parser_diagnose_invalid_type_name): Mention that concept is also available with -std=c++2a.
* parser.c (cp_parser_diagnose_invalid_type_name): Mention
that concept is also available with -std=c++2a.
From-SVN: r279066
Jakub Jelinek [Fri, 6 Dec 2019 21:18:10 +0000 (22:18 +0100)]
c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for now.
* c-cppbuiltin.c (c_cpp_builtins): Don't define __cpp_consteval for
now.
* g++.dg/cpp2a/feat-cxx2a.C: Don't test __cpp_consteval for now.
From-SVN: r279065
Jakub Jelinek [Fri, 6 Dec 2019 20:16:27 +0000 (21:16 +0100)]
PR c++/92831 - CWG 1299, not extending temporary lifetime for ?:
* cp-tree.h (extend_ref_init_temps): Add a new argument with NULL
default arg.
* call.c (set_up_extended_ref_temp): Add COND_GUARD argument, pass it
down to extend_ref_init_temps. Before pushing cleanup, if COND_GUARD
is non-NULL, create a bool temporary if needed, initialize to false
and guard the cleanup with the temporary being true.
(extend_ref_init_temps_1): Add COND_GUARD argument, pass it down
to recursive calls and set_up_extended_ref_temp. Handle COND_EXPR.
(extend_ref_init_temps): Add COND_GUARD argument, pass it down to
recursive calls and to extend_ref_init_temps_1.
* g++.dg/cpp0x/temp-extend2.C: New test.
From-SVN: r279064
Ian Lance Taylor [Fri, 6 Dec 2019 19:52:46 +0000 (19:52 +0000)]
re PR go/92820 (libgo.so.15 has executable stack)
PR go/92820
runtime: only build go-context for x86 GNU/Linux
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210258
From-SVN: r279063
Ian Lance Taylor [Fri, 6 Dec 2019 19:37:39 +0000 (19:37 +0000)]
re PR other/29842 ([meta-bug] outstanding patches / issues from STMicroelectronics)
PR go/29842
runtime: update HURD support for mOS now being embedded
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210285
From-SVN: r279062
Andreas Krebbel [Fri, 6 Dec 2019 19:30:37 +0000 (19:30 +0000)]
re PR rtl-optimization/92176 (LRA problem with reloads for subreg operands)
2019-12-06 Andreas Krebbel <krebbel@linux.ibm.com>
Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/92176
* lra.c (simplify_subreg_regno): Don't permit unconditional
changing mode for LRA too.
2019-12-06 Andreas Krebbel <krebbel@linux.ibm.com>
Vladimir Makarov <vmakarov@redhat.com>
PR rtl-optimization/92176
* gcc.target/s390/pr92176.c: New test.
Co-Authored-By: Vladimir Makarov <vmakarov@redhat.com>
From-SVN: r279061
Kwok Cheung Yeung [Fri, 6 Dec 2019 18:33:19 +0000 (18:33 +0000)]
Fix Fortran linker errors on AMD GCN
2019-12-06 Kwok Cheung Yeung <kcy@codesourcery.com>
libgomp/
* config/accel/proc.c (omp_get_num_procs): Apply ialias macro.
From-SVN: r279060
Martin Sebor [Fri, 6 Dec 2019 18:23:41 +0000 (18:23 +0000)]
Avoid -Wincompatible-pointer-types on targets like arm-eabi.
gcc/testsuite/ChangeLog:
* gcc.dg/Wstringop-overflow-23.c: Use the correct argument type.
* gcc.dg/Wstringop-overflow-24.c: Same.
From-SVN: r279059
Richard Sandiford [Fri, 6 Dec 2019 18:22:24 +0000 (18:22 +0000)]
[C++] Pass type uses through the verify_type_context hook
This patch makes the C++ frontend work with the verify_type_context hook.
We need some new type contexts for features that don't exist in C, but
otherwise the patch is very similar to the C one.
TCTX_CAPTURE_BY_COPY could really be treated as an instance of
TCTX_FIELD, but the error message is better if we split it out.
2019-12-06 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* target.h (TCTX_ALLOCATION, TCTX_DEALLOCATION, TCTX_EXCEPTIONS)
(TCTX_CAPTURE_BY_COPY): New type_context_kinds.
* config/aarch64/aarch64-sve-builtins.cc (verify_type_context):
Handle them.
gcc/cp/
* decl.c (start_decl_1): Use verify_type_context to check whether
the target allows variables of a particular type to have static
or thread-local storage duration.
(check_array_initializer): Use verify_type_context to check whether
the target allows a particular type to be used as an array element.
(create_array_type_for_decl): Likewise.
(cp_finish_decl): Use verify_type_context to check whether
the target allows static member variables of a particular type.
(grokdeclarator): Likewise. Also use verify_type_context to check
whether the target allows non-static member variables of a particular
type.
* except.c: Include target.h.
(is_admissible_throw_operand_or_catch_parameter): Use
verify_type_context to check whether the target allows particular
types to be thrown and caught.
* typeck2.c (add_exception_specifier): Likewise.
* init.c (build_new_1): Use verify_type_context to check whether
the target allows particular types to be dynamically allocated.
(build_vec_delete_1, build_delete): Use verify_type_context to check
whether the target allows particular types to be deleted.
* lambda.c (add_capture): Use verify_type_context to check
whether the target allows particular types to be captured by copy.
* pt.c: Include target.h.
(instantiate_class_template_1): Use verify_type_context to check
whether the target allows non-static member variables of a particular
type.
* typeck.c (cxx_alignof_expr): Use verify_type_context to check
whether the target allows the alignment of a particular type
to be measured.
(pointer_diff, cp_build_unary_op): Use verify_type_context to check
whether the target allows arithmetic involving pointers to particular
types.
gcc/testsuite/
* g++.dg/ext/sve-sizeless-1.C: New test.
* g++.dg/ext/sve-sizeless-2.C: Likewise.
From-SVN: r279058
Andrew Stubbs [Fri, 6 Dec 2019 17:49:47 +0000 (17:49 +0000)]
Fix unrecognised GCN instruction.
2019-12-06 Andrew Stubbs <ams@codesourcery.com>
gcc/
* config/gcn/gcn-valu.md (gather<mode>_insn_1offset<exec>): Use %o
in the asm output.
From-SVN: r279055
Andrew Stubbs [Fri, 6 Dec 2019 17:28:28 +0000 (17:28 +0000)]
Enable QI/HImode vector moves
2019-12-06 Andrew Stubbs <ams@codesourcery.com>
gcc/
* config/gcn/gcn-valu.md (VEC_1REG_MODE): Remove V64QI and V64HI.
(VEC_1REG_ALT): Likewise.
(VEC_ALL1REG_MODE): New mode iterator.
(VEC_1REG_INT_MODE): Remove V64QI and V64HI.
(VEC_1REG_INT_ALT): Likewise.
(VEC_ALL1REG_INT_MODE): New mode interator.
(VEC_ALL1REG_INT_ALT): Likewise.
(VEC_REG_MODE): Remove V64QI and V64HI.
(VEC_ALLREG_MODE): New mode interator.
(vec_merge): Change to VEC_ALLREG_MODE.
(vec_merge_with_clobber): Likewise.
(vec_merge_with_vcc): Likewise.
(mov<mode>): Likewise.
(mov<mode>_unspec): Likewise.
(*mov<mode>): Change to VEC_ALL1REG_MODE.
(mov<mode>_exec): Likewise.
(*mov<mode>_exec_match): Likewise.
(mov<mode>_sgprbase): Likewise.
(reload_in<mode>): Change to VEC_ALLREG_MODE.
(reload_out<mode>): Likewise.
(scalar address splits): Likewise.
(*vec_set<mode>): Change to VEC_ALL1REG_MODE.
(vec_set<mode>): Change to VEC_ALLREG_MODE.
(*vec_set<mode>_1): Change to VEC_ALL1REG_MODE.
(vec_duplicate<mode><exec>): Likewise.
(vec_extract<mode><scalar_mode>): Likewise.
(vec_init<mode><scalar_mode>): Change to VEC_ALLREG_MODE.
(gather_load<mode>): Likewise.
(gather<mode>_exec): Likewise.
(gather<mode>_expr<exec>): Likewise.
(gather<mode>_insn_1offset<exec>): Likewise.
(gather<mode>_insn_1offset_ds<exec>): Likewise.
(gather<mode>_insn_2offsets<exec>): Likewise.
(ds_bpermute<mode>): Change to VEC_ALL1REG_MODE.
(VEC_INT_MODE): Remove V64QI and V64HI.
(vcond_mask_<mode>di): Change to VEC_ALLREG_MODE.
(vcond<VEC_1REG_MODE:mode><VEC_1REG_ALT:mode>): Change to
VEC_ALL1REG_MODE.
(vcond<VEC_1REG_MODE:mode><VEC_1REG_ALT:mode>_exec): Likewise.
(vcondu<VEC_1REG_MODE:mode><VEC_1REG_INT_ALT:mode>): Likewise.
(vcondu<VEC_1REG_MODE:mode><VEC_1REG_INT_ALT:mode>_exec): Likewise.
(maskload<mode>di): Change to VEC_ALL1REG_MODE.
(maskstore<mode>di): Likewise.
(mask_gather_load<mode>): Likewise.
(mov_from_lane63_<mode>): Likewise.
* config/gcn/gcn.c (gcn_vector_mode_supported_p): Renable V64QImode
and V64HImode vectorization.
(gcn_related_vector_mode): New function.
(TARGET_VECTORIZE_RELATED_MODE): New define.
From-SVN: r279053
Jakub Jelinek [Fri, 6 Dec 2019 13:28:59 +0000 (14:28 +0100)]
re PR fortran/92775 (Incorrect expression in DW_AT_byte_stride on an array)
PR fortran/92775
* trans.h (struct lang_type, struct lang_decl): Remove span member.
(GFC_DECL_SPAN, GFC_TYPE_ARRAY_SPAN): Remove macros.
* trans-array.h (gfc_get_descriptor_offsets_for_info): Add another
argument.
* trans-array.c (gfc_get_descriptor_offsets_for_info): Add SPAN_OFF
argument and initialize *SPAN_OFF to the offset of span field.
* trans-types.c (gfc_get_array_descr_info): Adjust
gfc_get_descriptor_offsets_for_info caller. Compute elem_size
as base->span instead of TYPE_SIZE_UNIT (etype) constant.
From-SVN: r279045
Tobias Burnus [Fri, 6 Dec 2019 13:06:53 +0000 (13:06 +0000)]
[OpenMP/OpenACC/Fortran] Fix mapping of optional (present|absent) arguments
2019-12-06 Tobias Burnus <tobias@codesourcery.com>
Kwok Cheung Yeung <kcy@codesourcery.com>
gcc/fortran/
* trans-openmp.c (gfc_build_conditional_assign,
gfc_build_conditional_assign_expr): New static functions.
(gfc_omp_finish_clause, gfc_trans_omp_clauses): Handle mapping of
absent optional arguments and fix mapping of present optional args.
gcc/
* omp-low.c (lower_omp_target): For optional arguments, deref once
more to obtain the type.
libgomp/
* oacc-mem.c (update_dev_host, gomp_acc_insert_pointer): Just return
if input it a NULL pointer.
* testsuite/libgomp.oacc-c-c++-common/lib-43.c: Remove; dependent on
diagnostic of NULL pointer.
* testsuite/libgomp.oacc-c-c++-common/lib-47.c: Ditto.
* testsuite/libgomp.fortran/optional-map.f90: New.
* testsuite/libgomp.fortran/use_device_addr-1.f90
(test_dummy_opt_callee_1_absent): New.
(test_dummy_opt_call_1): Call it.
* testsuite/libgomp.fortran/use_device_addr-2.f90: Likewise.
* testsuite/libgomp.fortran/use_device_addr-3.f90: Likewise.
* testsuite/libgomp.fortran/use_device_addr-4.f90: Likewise.
* testsuite/libgomp.oacc-fortran/optional-cache.f95: New.
* testsuite/libgomp.oacc-fortran/optional-data-copyin-by-value.f90: New.
* testsuite/libgomp.oacc-fortran/optional-data-copyin.f90: New.
* testsuite/libgomp.oacc-fortran/optional-data-copyout.f90: New.
* testsuite/libgomp.oacc-fortran/optional-data-enter-exit.f90: New.
* testsuite/libgomp.oacc-fortran/optional-declare.f90: New.
* testsuite/libgomp.oacc-fortran/optional-firstprivate.f90: New.
* testsuite/libgomp.oacc-fortran/optional-host_data.f90: New.
* testsuite/libgomp.oacc-fortran/optional-nested-calls.f90: New.
* testsuite/libgomp.oacc-fortran/optional-private.f90: New.
* testsuite/libgomp.oacc-fortran/optional-reduction.f90: New.
* testsuite/libgomp.oacc-fortran/optional-update-device.f90: New.
* testsuite/libgomp.oacc-fortran/optional-update-host.f90: New.
Co-Authored-By: Kwok Cheung Yeung <kcy@codesourcery.com>
From-SVN: r279043
Richard Biener [Fri, 6 Dec 2019 11:44:27 +0000 (11:44 +0000)]
match.pd (nop_convert): Remove empty match.
2019-12-06 Richard Biener <rguenther@suse.de>
* match.pd (nop_convert): Remove empty match. Use nop_convert?
everywhere.
From-SVN: r279040
Christophe Lyon [Fri, 6 Dec 2019 10:54:46 +0000 (10:54 +0000)]
[testsuite][aarch64] type_redef_11.c: Update expected diagnostics.
After the fix for PR c/36941 and PR c/88827 (r278976), this test emits
a different error message and needs an update.
2019-12-06 Christophe Lyon <christophe.lyon@linaro.org>
PR c/36941
PR c/88827
* gcc.target/aarch64/sve/acle/general-c/type_redef_11.c: Update
expected diagnostics.
From-SVN: r279039
Richard Sandiford [Fri, 6 Dec 2019 10:31:44 +0000 (10:31 +0000)]
Avoid quadratic behaviour in prune_runtime_alias_test_list
prune_runtime_alias_test_list used ordered_remove to remove a merged
alias pair, which made the function quadratic when many aliases could
be removed.
I had a testcase in which these memmoves accounted for an impressive
85% of compile time. The fact that we had so many probably shows
a deeper problem, but still, it's easy to remove as we go.
2019-12-06 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* tree-data-ref.c (prune_runtime_alias_test_list): Exit early
for empty vectors. Avoid using ordered_remove and instead
shuffle the vector as we go.
From-SVN: r279038
Richard Biener [Fri, 6 Dec 2019 10:25:08 +0000 (10:25 +0000)]
genmatch.c (enum tree_code): Remove CONVERT{0,1,2} and VIEW_CONVERT{0,1,2}.
2019-12-06 Richard Biener <rguenther@suse.de>
* genmatch.c (enum tree_code): Remove CONVERT{0,1,2} and
VIEW_CONVERT{0,1,2}.
(expr::opt_grp): Add and initialize.
(lower_opt_convert): Rename to ...
(lower_opt): ... and work on opt_grp, simply switching operations
from being optional to being present or not.
(has_opt_convert): Rename to ...
(has_opt): ... and adjust.
(parser::parse_operation): Return the optional opt_grp,
remove special-casing of conditional operations and more generally
parse [digit]'?'.
(parser::parse_expr): Stick on the parsed opt_grp and perform
rough verification.
(parser::parse_for): Remove now unnecessary code.
(main): Likewise.
* doc/match-and-simplify.texi: Mention ? now works on all
unary operations and also match predicates.
From-SVN: r279037
Jan Hubicka [Fri, 6 Dec 2019 08:51:43 +0000 (09:51 +0100)]
cgraphclones.c (cgraph_node::create_clone): Only localize toplevel functions, not inline clones.
* cgraphclones.c (cgraph_node::create_clone): Only localize toplevel
functions, not inline clones.
From-SVN: r279036
Jan Hubicka [Fri, 6 Dec 2019 08:50:36 +0000 (09:50 +0100)]
* cfgexpand.c (expand_debug_expr): Do not ICE on SAD_EXPR.
From-SVN: r279035
Richard Biener [Fri, 6 Dec 2019 08:25:12 +0000 (08:25 +0000)]
genmatch.c (c_expr::gen_transform): Emit newlines from line number changes rather than after every semicolon.
2019-12-06 Richard Biener <rguenther@suse.de>
* genmatch.c (c_expr::gen_transform): Emit newlines from line
number changes rather than after every semicolon.
From-SVN: r279034
Richard Biener [Fri, 6 Dec 2019 07:53:15 +0000 (07:53 +0000)]
re PR tree-optimization/92819 (Worse code generated on avx2 due to simplify_vector_constructor)
2019-12-06 Richard Biener <rguenther@suse.de>
PR tree-optimization/92819
* match.pd (VEC_PERM_EXPR -> BIT_INSERT_EXPR): Handle inserts
into the last lane. For two-element vectors try inserting
into the last lane when inserting into the first fails.
* gcc.target/i386/pr92819-1.c: New testcase.
* gcc.target/i386/pr92803.c: Adjust.
From-SVN: r279033
Ian Lance Taylor [Fri, 6 Dec 2019 05:32:49 +0000 (05:32 +0000)]
re PR go/92810 (Compiling GCC go for aarch64_be-marvell-linux-gnu fails)
PR go/92810
libgo: recognize aarch64_be as arm64be
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210038
From-SVN: r279032
Martin Sebor [Fri, 6 Dec 2019 01:04:42 +0000 (01:04 +0000)]
PR testsuite/92829 - several test case failures starting with r278983
gcc/testsuite/ChangeLog:
* gcc.dg/Warray-bounds-56.c: Rearrange code to avoid powerpc64*
failures.
From-SVN: r279031
Jakub Jelinek [Fri, 6 Dec 2019 00:27:18 +0000 (01:27 +0100)]
common.opt (fprofile-partial-training): Terminate description with full stop.
* common.opt (fprofile-partial-training): Terminate description with
full stop.
From-SVN: r279030
Martin Sebor [Fri, 6 Dec 2019 00:18:32 +0000 (00:18 +0000)]
PR middle-end/92622 - FAIL: gcc.dg/Warray-bounds-22.c on ILP32: missing warnings for VLA on lines 67 and 69
gcc/ChangeLog:
PR middle-end/92622
* tree-vrp.c (vrp_prop::check_array_ref): Avoid using a variable
left uninitialized by get_addr_base_and_unit_offset ofn failure.
From-SVN: r279029
GCC Administrator [Fri, 6 Dec 2019 00:16:46 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r279028
Jan Hubicka [Fri, 6 Dec 2019 00:08:47 +0000 (01:08 +0100)]
Do not clear m_vr and bits in ipa_set_jf_unknown.
* ipa-prop.c (ipa_set_jf_unknown): Do not clear bits and m_vr.
(detect_type_change_from_memory_writes): Remoe parameter JFUNC.
(detect_type_change): Likewise.
(detect_type_change_ssa): Likewise.
(ipa_analyze_virtual_call_uses): Update.
From-SVN: r279025
Jakub Jelinek [Thu, 5 Dec 2019 23:53:09 +0000 (00:53 +0100)]
re PR tree-optimization/92768 (Maybe a wrong code for vector constants)
PR tree-optimization/92768
* gcc.dg/pr92768.c: Add -w -Wno-psabi to dg-options.
From-SVN: r279024
Sandra Loosemore [Thu, 5 Dec 2019 21:36:22 +0000 (16:36 -0500)]
Disable --eh-frame-hdr with -pie or -shared on nios2-linux-gnu.
2019-12-05 Sandra Loosemore <sandra@codesourcery.com>
Disable --eh-frame-hdr with -pie or -shared on nios2-linux-gnu.
The nios2 ABI doesn't have appropriate relocations to support
--eh-frame-hdr with -pie or -shared, so we need to override the
default specs that add that link option. Otherwise we get linker
warnings about invalid FDE encodings.
gcc/
* config/nios2/linux.h (LINK_EH_SPEC): Define.
gcc/testsuite/
* g++.target/nios2/hello-pie.C: New.
* g++.target/nios2/nios2.exp: New.
From-SVN: r279023
Jan Hubicka [Thu, 5 Dec 2019 20:53:39 +0000 (21:53 +0100)]
Fix g++.dg/torture/pr59226.C
this patch fixes ICE in g++.dg/torture/pr59226.C which was triggered by
new comdat_local sanity check. What happens here is that function gets
inlined into its own thunk which makes it !comdat_local_p but the updating
code does not notice since thunk calls comdat local alias of the function
itself and we look at alias target rather than original callee.
This also shows that we miss optimization here. Currently we will not inline
thunk out of its comdat local group w/o inlining function it is associated with
into it.
We should teach inline_call to reoslve edges to aliases while inlining and
relax calls_comdat_local flag. But this needs bit more work, so I fix the
ICE first.
* ipa-inline-transform.c (inline_call): Fix maintenatnce of comdat_local
From-SVN: r279021
Marek Polacek [Thu, 5 Dec 2019 20:13:03 +0000 (20:13 +0000)]
PR c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.
This patch implements C++20 P1331, allowing trivial default initialization in
constexpr contexts.
* c-cppbuiltin.c (c_cpp_builtins): Adjust the value of __cpp_constexpr.
* class.c (trivial_default_constructor_is_constexpr): Return true in
C++20.
* constexpr.c (cx_check_missing_mem_inits): Allow missing field
initializers in C++20.
(cxx_eval_call_expression): Don't clear CONSTRUCTOR_NO_CLEARING for
constexpr constructors in C++20.
(reduced_constant_expression_p): Don't set FIELD for union and array
types. Skip empty class fields without initializers.
* decl.c (check_for_uninitialized_const_var): Permit trivial default
initialization in constexpr.
(next_initializable_field): Don't skip vptr fields.
* method.c (walk_field_subobs): Still consider a constructor that
doesn't initialize all the members constexpr.
* g++.dg/cpp0x/constexpr-array6.C: Adjust dg-error.
* g++.dg/cpp0x/constexpr-ctor.C: Likewise.
* g++.dg/cpp0x/constexpr-diag3.C: Likewise.
* g++.dg/cpp0x/constexpr-diag4.C: Likewise.
* g++.dg/cpp0x/constexpr-ex3.C: Likewise.
* g++.dg/cpp0x/constexpr-template2.C: Likewise.
* g++.dg/cpp0x/constexpr-union2.C: Likewise.
* g++.dg/cpp0x/lambda/lambda-mangle.C: Rip out a piece of code ...
* g++.dg/cpp0x/lambda/lambda-mangle6.C: ... and put it here.
* g++.dg/cpp0x/pr79118.C: Adjust dg-error.
* g++.dg/cpp1y/constexpr-83921-3.C: Likewise.
* g++.dg/cpp1y/constexpr-neg1.C: Likewise.
* g++.dg/cpp1z/constexpr-lambda12.C: Likewise.
* g++.dg/cpp1z/feat-cxx1z.C: Use -std=c++17.
* g++.dg/cpp2a/constexpr-init1.C: New test.
* g++.dg/cpp2a/constexpr-init2.C: New test.
* g++.dg/cpp2a/constexpr-init3.C: New test.
* g++.dg/cpp2a/constexpr-init4.C: New test.
* g++.dg/cpp2a/constexpr-init5.C: New test.
* g++.dg/cpp2a/constexpr-init6.C: New test.
* g++.dg/cpp2a/constexpr-init7.C: New test.
* g++.dg/cpp2a/constexpr-init8.C: New test.
* g++.dg/cpp2a/constexpr-init9.C: New test.
* g++.dg/cpp2a/constexpr-init10.C: New test.
* g++.dg/cpp2a/constexpr-init11.C: New test.
* g++.dg/cpp2a/constexpr-init12.C: New test.
* g++.dg/cpp2a/constexpr-init13.C: New test.
* g++.dg/cpp2a/constexpr-init14.C: New test.
* g++.dg/cpp2a/constexpr-init15.C: New test.
* g++.dg/cpp2a/constexpr-try5.C: Adjust dg-error.
* g++.dg/cpp2a/feat-cxx2a.C: Test __cpp_constexpr.
* g++.dg/cpp2a/lambda-mangle.C: New test.
* g++.dg/debug/dwarf2/pr44641.C: Skip for c++2a.
* g++.dg/ext/stmtexpr21.C: Adjust dg-error.
Co-Authored-By: Jakub Jelinek <jakub@redhat.com>
From-SVN: r279019
Marek Polacek [Thu, 5 Dec 2019 20:06:46 +0000 (20:06 +0000)]
PR c++/92271 - make __is_same alias for __is_same_as.
Richard Smith proposed adding a synonym for __is_same_as, to accomodate the
convention of exposing std::SOME_TRAIT<A, B>::value as __SOME_TRAIT(A, B).
So add that alias, and also adjust the C++ printer. I didn't bother changing
the RID_ identifier.
* c-common.c: Add __is_same, an alias for __is_same_as.
* cxx-pretty-print.c (pp_cxx_trait_expression) <case CPTK_IS_SAME_AS>:
Print "__is_same".
* g++.dg/ext/is_same.C: New test.
From-SVN: r279018
Jan Hubicka [Thu, 5 Dec 2019 18:12:51 +0000 (19:12 +0100)]
cgraphclones.c (localize_profile): New function.
* cgraphclones.c (localize_profile): New function.
(cgraph_node::create_clone): Use it for partial profiles.
* common.opt (fprofile-partial-training): New flag.
* doc/invoke.texi (-fprofile-partial-training): Document.
* ipa-cp.c (update_profiling_info): For partial profiles do not
set function profile to zero.
* profile.c (compute_branch_probabilities): With partial profile
watch if edge count is zero and turn all probabilities to guessed.
(compute_branch_probabilities): For partial profiles do not apply
profile when entry count is zero.
* tree-profile.c (tree_profiling): Only do value_profile_transformations
when profile is read.
From-SVN: r279013
Sudakshina Das [Thu, 5 Dec 2019 18:03:01 +0000 (18:03 +0000)]
[Patch, GCC] Fix a condition post r278611
gcc/ChangeLog
2019-12-05 Sudakshina Das <sudi.das@arm.com>
* tree-vect-loop.c (vect_model_reduction_cost): Remove reduction_type
check from if condition.
From-SVN: r279012
Ian Lance Taylor [Thu, 5 Dec 2019 17:51:10 +0000 (17:51 +0000)]
re PR go/92820 (libgo.so.15 has executable stack)
PR go/92820
runtime: always mark assembly file as non-executable stack
Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/210037
From-SVN: r279010
Tobias Burnus [Thu, 5 Dec 2019 15:18:39 +0000 (15:18 +0000)]
OpenMP] Fix use_device_… with absent optional arg
gcc/fortran/
* trans-openmp.c (gfc_omp_is_optional_argument,
gfc_omp_check_optional_argument): Handle type(c_ptr),value which uses a
hidden argument for the is-present check.
gcc/
* omp-low.c (lower_omp_target): For use_device_ptr/use_derice_addr
and Fortran's optional arguments, unconditionally add the is-present
condition before the libgomp call.
libgomp/
* testsuite/libgomp.fortran/use_device_ptr-optional-2.f90: Add
'type(c_ptr), value' test case. Conditionally map the per-value
passed arguments.
From-SVN: r279004
David Edelsohn [Thu, 5 Dec 2019 14:40:11 +0000 (14:40 +0000)]
* cp-gimplify.c: Include memmodel.h.
From-SVN: r279003
Richard Sandiford [Thu, 5 Dec 2019 14:20:38 +0000 (14:20 +0000)]
Check for bitwise identity when encoding VECTOR_CSTs (PR 92768)
This PR shows that we weren't checking for bitwise-identical values
when trying to encode a VECTOR_CST, so -0.0 was treated the same as
0.0 for -fno-signed-zeros. The patch adds a new OEP flag to select
that behaviour.
2019-12-05 Richard Sandiford <richard.sandiford@arm.com>
gcc/
PR middle-end/92768
* tree-core.h (OEP_BITWISE): New flag.
* fold-const.c (operand_compare::operand_equal_p): Handle it.
* tree-vector-builder.h (tree_vector_builder::equal_p): Pass it.
gcc/testsuite/
PR middle-end/92768
* gcc.dg/pr92768.c: New test.
From-SVN: r279002
Jonathan Wakely [Thu, 5 Dec 2019 13:50:08 +0000 (13:50 +0000)]
libstdc++: Fix bug in std::span test
The previous commit fixed the std::span constructors from const arrays,
revealing a bug in this test.
* testsuite/23_containers/span/lwg3255.cc: Fix test. Constructing a
span of non-const elements should not be possible from a const array
or an array of const elements.
From-SVN: r279001
JeanHeyd "ThePhD" Meneide [Thu, 5 Dec 2019 13:50:01 +0000 (13:50 +0000)]
libstdc++: Implement P1872R0 and P1394R0 for std::span
This also fixes a bug in the implementation of LWG 3255, which causes:
FAIL: 23_containers/span/lwg3255.cc (test for excess errors)
That's because the test was wrong and verified the buggy behaviour. That
will be fixed in the following commit.
2019-12-05 JeanHeyd "ThePhD" Meneide <phdofthehouse@gmail.com>
Implement P1872R0 and P1394R0 for std::span
* include/bits/range_access.h (__adl_begin, __adl_end): Remove.
(sentinel_t, range_value_t, range_reference_t)
(range_rvalue_reference_t, __forwarding_range, disable_sized_range)
(output_range, input_range, forward_range, bidirectional_range)
(random_access_range, contiguous_range, common_range): Move here from
<ranges>, to make this the "ranges lite" internal header.
* include/std/ranges: Move basic aliases and concepts to
<bits/range_access.h>.
* include/std/span: Use concepts and ranges:: calls instead of
enable_if and friends.
* include/std/type_traits: Add __is_array_convertible trait.
From-SVN: r279000
Richard Biener [Thu, 5 Dec 2019 13:02:57 +0000 (13:02 +0000)]
re PR tree-optimization/92818 (Typo in vec_perm -> bit_insert pattern)
2019-12-05 Richard Biener <rguenther@suse.de>
PR middle-end/92818
* tree-ssa-forwprop.c (simplify_vector_constructor): Improve
heuristics on what don't care element to choose.
* match.pd (VEC_PERM_EXPR -> BIT_INSERT_EXPR): Fix typo.
* gcc.target/i386/pr92818.c: New testcase.
From-SVN: r278998
Jonathan Wakely [Thu, 5 Dec 2019 12:46:50 +0000 (12:46 +0000)]
libstdc++: Define std::lexicographical_compare_three_way for C++20
* include/bits/stl_algobase.h (lexicographical_compare_three_way):
Define for C++20.
* testsuite/25_algorithms/lexicographical_compare_three_way/1.cc: New
test.
* testsuite/25_algorithms/lexicographical_compare_three_way/
constexpr.cc: New test.
From-SVN: r278996
Martin Liska [Thu, 5 Dec 2019 12:35:26 +0000 (13:35 +0100)]
Fix __gcov_exit fn prototype.
2019-12-05 Martin Liska <mliska@suse.cz>
PR gcov-profile/92817
* coverage.c (build_gcov_exit_decl): Remove superfluous
void_type_node.
From-SVN: r278995
Jozef Lawrynowicz [Thu, 5 Dec 2019 10:56:02 +0000 (10:56 +0000)]
MSP430: Fix postinc addressing mode being used for dst op of CMP insns
2019-12-05 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* config/msp430/msp430.md (cbranch<mode>4): Use
msp430_general_dst_nonv_operand instead of nonimmediate_operand for
dest operand of CMP instruction.
(cbranchpsi4_real): Likewise.
(cbranchqi4_real): Likewise.
(cbranchhi4_real): Likewise.
(cbranchpsi4_reversed): Likewise.
(cbranchqi4_reversed): Likewise.
(cbranchhi4_reversed): Likewise.
From-SVN: r278994
Frederik Harwath [Thu, 5 Dec 2019 10:26:56 +0000 (10:26 +0000)]
Skip test gcc/testsuite/gcc.dg/asm-4.c for amdgcn target
2019-12-05 Frederik Harwath <frederik@codesourcery.com>
gcc/testsuite/
* gcc.dg/asm-4.c: Skip on target amdgcn-*-*.
From-SVN: r278993
Georg-Johann Lay [Thu, 5 Dec 2019 09:47:35 +0000 (09:47 +0000)]
re PR target/92055 ([avr] Support 64-bit double)
PR target/92055
* config/avr/t-avrlibc (MULTISUBDIR): Search for double, not double64.
From-SVN: r278992
Richard Biener [Thu, 5 Dec 2019 09:45:46 +0000 (09:45 +0000)]
re PR tree-optimization/92803 (error: type mismatch in 'vec_perm_expr' since r278764)
2019-12-05 Richard Biener <rguenther@suse.de>
PR tree-optimization/92803
* tree-ssa-forwprop.c (simplify_vector_constructor): Fix
invariant vector construction.
* gcc.target/i386/pr92803.c: New testcase.
From-SVN: r278991
Martin Liska [Thu, 5 Dec 2019 09:08:44 +0000 (10:08 +0100)]
Fix profile name files without -fprofile-dir.
2019-12-05 Martin Liska <mliska@suse.cz>
PR gcov-profile/91971
* coverage.c (coverage_init): Mangle full path
only when -fprofile-dir is used.
From-SVN: r278990
Jakub Jelinek [Thu, 5 Dec 2019 09:04:24 +0000 (10:04 +0100)]
re PR target/92791 (ICE in extract_insn, at recog.c:2311 since r278645)
PR target/92791
* config/i386/i386.md (movstrict<mode>): Move test for
TARGET_PARTIAL_REG_STALL and not optimizing for size from
expander's condition to the body - FAIL; in that case.
From-SVN: r278989
Jakub Jelinek [Thu, 5 Dec 2019 09:03:34 +0000 (10:03 +0100)]
re PR fortran/92781 (ICE in convert_nonlocal_reference_op, at tree-nested.c:1065)
PR fortran/92781
* trans-decl.c (gfc_get_symbol_decl): If sym->backend_decl is
current_function_decl, add length to current rather than parent
function and expect DECL_CONTEXT (length) to be current_function_decl.
* gfortran.dg/pr92781.f90: New test.
From-SVN: r278988
Paolo Carlini [Thu, 5 Dec 2019 08:59:24 +0000 (08:59 +0000)]
typeck2.c (build_functional_cast): Add location_t parameter and use it.
/gcc/cp
2019-12-05 Paolo Carlini <paolo.carlini@oracle.com>
* typeck2.c (build_functional_cast): Add location_t parameter
and use it.
* cp-tree.h: Update declaration.
* parser.c (cp_parser_functional_cast): Adjust call.
* call.c (build_op_delete_call): Likewise.
(build_new_method_call_1): Likewise.
* decl.c (check_initializer): Likewise.
* pt.c (tsubst_copy_and_build): Likewise.
* semantics.c (finish_compound_literal): Likewise.
/libcc1
2019-12-05 Paolo Carlini <paolo.carlini@oracle.com>
* libcp1plugin.cc (plugin_build_expression_list_expr): Adjust
build_functional_cast call.
/testsuite
2019-12-05 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/diagnostic/functional-cast-to-array-type-1.C: New.
* g++.dg/cpp0x/auto25.C: Check location(s) too.
* g++.dg/cpp0x/auto28.C: Likewise.
* g++.dg/init/reference2.C: Likewise.
* g++.dg/parse/template2.C: Likewise.
* g++.dg/template/error8.C: Likewise.
* g++.old-deja/g++.ns/crash3.C: Likewise.
* g++.old-deja/g++.ns/template7.C: Likewise.
* g++.old-deja/g++.pt/crash8.C: Likewise.
From-SVN: r278987
Tobias Burnus [Thu, 5 Dec 2019 08:38:53 +0000 (08:38 +0000)]
testsuite/libgomp.oacc-fortran: Update dg-output to fix GCN
* testsuite/libgomp.oacc-fortran/error_stop-1.f: Also don't
expect dg-output of 'Error termination.' for GCN.
* testsuite/libgomp.oacc-fortran/error_stop-2.f: Likewise.
* testsuite/libgomp.oacc-fortran/error_stop-3.f: Likewise.
Plus: Fix date of a previous commit in:
* gcc/fortran/ChangeLog
* gcc/testsuite/ChangeLog
From-SVN: r278986
Ian Lance Taylor [Thu, 5 Dec 2019 03:56:40 +0000 (03:56 +0000)]
* edtest.c (test1): Add noclone attribute.
From-SVN: r278985
Ian Lance Taylor [Thu, 5 Dec 2019 02:20:11 +0000 (02:20 +0000)]
libbacktrace: simplify DWARF section handling
This is in preparation for adding DWARF 5 support.
* internal.h (enum dwarf_section): Define.
(struct dwarf_sections): Define.
(backtrace_dwarf_add): Update declaration to replace specific
section parameters with dwarf_sections parameter.
* dwarf.c (struct dwarf_data): Replace specific section fields
with dwarf_sections field.
(read_attribute): Use dwarf_sections with altlink.
(build_address_map): Replace specific section parameters with
dwarf_sections parameter. Change all callers.
(read_line_info): Use dwarf_sections with ddata.
(read_referenced_name): Likewise.
(add_function_ranges): Likewise.
(read_function_entry): Likewise.
(read_function_info): Likewise.
(build_dwarf_data): Replace specific section parameters with
dwarf_sections parameter. Change all callers.
(backtrace_dwarf_add): Likewise.
* elf.c (enum debug_section): Remove.
(dwarf_section_names): Remove .zdebug names.
(elf_add): Track zsections separately. Build dwarf_sections.
* pecoff.c (enum debug_section): Remove.
(struct debug_section_info): Remove data field.
(coff_add): Build dwarf_sections.
* xcoff.c (enum dwarf_section): Remove. Replace DWSECT_xxx
references with DEBUG_xxx references.
(xcoff_add): Build dwarf_sections.
From-SVN: r278984
Martin Sebor [Thu, 5 Dec 2019 01:28:11 +0000 (01:28 +0000)]
PR middle-end/91582 - missing heap overflow detection for strcpy
gcc/ChangeLog:
PR middle-end/91582
* builtins.c (gimple_call_alloc_size): New function.
(compute_objsize): Add argument. Call gimple_call_alloc_size.
Handle variable offsets and indices.
* builtins.h (gimple_call_alloc_size): Declare.
(compute_objsize): Add argument.
* gcc/gimple-ssa-warn-restrict.c: Remove assertions.
* tree-ssa-strlen.c (handle_store): Handle calls to allocated objects.
gcc/testsuite/ChangeLog:
PR middle-end/91582
* c-c++-common/Wstringop-truncation.c: Remove xfails.
* g++.dg/warn/Wstringop-overflow-4.C: New test.
* g++.dg/ext/attr-alloc_size.C: Suppress -Warray-bounds.
* gcc.dg/Warray-bounds-56.c: New test.
* gcc.dg/Wstringop-overflow-22.c: New test.
* gcc.dg/attr-alloc_size.c: Suppress -Warray-bounds.
* gcc.dg/attr-copy-2.c: Same.
* gcc.dg/builtin-stringop-chk-5.c: Remove xfails.
* gcc.dg/builtin-stringop-chk-8.c: Same. Correct the text of expected
warnings.
* gcc.target/i386/pr82002-2a.c: Prune expected warning.
* gcc.target/i386/pr82002-2b.c: Same.
From-SVN: r278983
Jonathan Wakely [Thu, 5 Dec 2019 00:42:11 +0000 (00:42 +0000)]
libstdc++: Define pretty printer for comparison categories
* python/libstdcxx/v6/printers.py (StdCmpCatPrinter): New printer.
* testsuite/libstdc++-prettyprinters/cxx20.cc: New test.
From-SVN: r278982
Jonathan Wakely [Thu, 5 Dec 2019 00:42:06 +0000 (00:42 +0000)]
libstdc++: Implement spaceship for std::array (P1614R2)
As done for std::pair, this defines operator<=> as a non-member function
template and does not alter operator==, as expected to be proposed as
the resolution to an unpublished LWG issue.
Instead of calling std::lexicographical_compare_three_way the <=>
overload is implemented by hand to take advantage of the fact the
element types and array sizes are known to be the same.
* include/bits/cpp_type_traits.h (__is_byte<char8_t>): Add
specialization.
* include/std/array (operator<=>): Likewise.
* testsuite/23_containers/array/comparison_operators/constexpr.cc:
Test three-way comparisons and arrays of unsigned char.
* testsuite/23_containers/array/tuple_interface/get_neg.cc: Adjust
dg-error line numbers.
From-SVN: r278981
GCC Administrator [Thu, 5 Dec 2019 00:16:38 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r278980
Joseph Myers [Wed, 4 Dec 2019 23:26:10 +0000 (23:26 +0000)]
Fix C handling of use of lvalues of incomplete types (PR c/36941, PR c/88827).
Bug 88827 points out that GCC should not be rejecting C code that
dereferences a pointer to an incomplete type in the case that uses &*
to take the address of the resulting lvalue, because no constraint is
violated in that case (other than for C90 when the incomplete type is
unqualified void, which we already handle correctly) and as the lvalue
never gets converted to an rvalue there is no undefined behavior
either.
This means that the diagnostic for such a dereference is bogus and
should be removed; if the lvalue gets converted to an rvalue, there
should be an appropriate error later for the use of the incomplete
type. In most cases, there is, but bug 36941 points out the lack of a
diagnostic when the incomplete (non-void) type gets cast to void
(where a diagnostic seems appropriate for this undefined behavior as a
matter of quality of implementation).
This patch removes the bogus diagnostic (and C_TYPE_ERROR_REPORTED
which was only used in the code that is removed - only that one, bogus
diagnostic had this duplicate suppression, not any of the other, more
legitimate diagnostics for use of incomplete types) and makes
convert_lvalue_to_rvalue call require_complete_type for arguments not
of void types, so that all relevant code paths (possibly except some
for ObjC) get incomplete types diagnosed. It's possible that this
makes some other checks for incomplete types obsolete, but no attempt
is made to remove any such checks.
Bootstrapped with no regressions for x86_64-pc-linux-gnu.
PR c/36941
PR c/88827
gcc/c:
* c-typeck.c (convert_lvalue_to_rvalue): Call
require_complete_type for arguments not of void types.
(build_indirect_ref): Do not diagnose dereferencing pointers to
incomplete types.
* c-tree.h (C_TYPE_ERROR_REPORTED): Remove.
gcc/testsuite:
* gcc.dg/lvalue-9.c, gcc.dg/lvalue-10.c: New tests.
* gcc.dg/array-8.c, gcc.dg/enum-incomplete-1.c,
gcc.dg/enum-incomplete-3.c, gcc.dg/noncompile/incomplete-3.c,
gcc.dg/pr48552-1.c, gcc.dg/pr48552-2.c, gcc.dg/pr63543.c,
gcc.dg/pr69796.c: Update expected diagnostics.
From-SVN: r278976
David Edelsohn [Wed, 4 Dec 2019 20:04:10 +0000 (20:04 +0000)]
* cp-gimplify.c: Include tm_p.h.
From-SVN: r278975
Julian Brown [Wed, 4 Dec 2019 20:00:48 +0000 (20:00 +0000)]
Use fixed registers for queue ptr sgpr pair
gcc/
* config/gcn/gcn.h (FIXED_REGISTERS): Make s6/s7 fixed registers.
From-SVN: r278974
Peter Bergner [Wed, 4 Dec 2019 19:53:26 +0000 (19:53 +0000)]
Do not define builtins that overload disabled builtins.
PR bootstrap/92661
* config/rs6000/rs6000-c.c (struct altivec_builtin_types): Move to
rs6000.h.
(altivec_overloaded_builtins): Move to rs6000-call.c.
* config/rs6000/rs6000.h (struct altivec_builtin_types): Moved from
rs6000-c.c.
* config/rs6000/rs6000-call.c (rs6000_builtin_info): Make static.
(altivec_overloaded_builtins): Moved from rs6000-c.c.
(rs6000_common_init_builtins): Do no define builtins that overload
builtins that have been disabled.
From-SVN: r278973
Wilco Dijkstra [Wed, 4 Dec 2019 15:40:41 +0000 (15:40 +0000)]
[ARM] Improve max_cond_insns setting for Cortex cores
To enable cores to use the correct max_cond_insns setting, use the core-specific
tuning when a CPU/tune is selected unless -mrestrict-it is explicitly set.
On Cortex-A57 this gives 1.1% performance gain on SPECINT2006 as well as a
0.4% codesize reduction.
gcc/
* config/arm/arm.c (arm_option_override_internal):
Use max_cond_insns from CPU tuning unless -mrestrict-it is used.
From-SVN: r278968
Marek Polacek [Wed, 4 Dec 2019 14:52:12 +0000 (14:52 +0000)]
Remove stray comma in primary_constraint_error.
* parser.c (enum primary_constraint_error): Remove stray comma.
From-SVN: r278967
Wilco Dijkstra [Wed, 4 Dec 2019 14:45:59 +0000 (14:45 +0000)]
[AArch64] Add support for fused compare and branch
Add support for fused compare with branch. Rename the existing
AARCH64_FUSE_CMP_BRANCH to ALU_BRANCH, and AARCH64_FUSE_ALU_BRANCH
to ALU_CBZ to make it clear what is being fused.
gcc/
* config/aarch64/aarch64.c
(thunderxt88_tunings): Use AARCH64_FUSE_ALU_BRANCH.
(thunderx_tunings): Likewise.
(tsv110_tunings): Use AARCH64_FUSE_ALU_BRANCH and AARCH64_FUSE_ALU_CBZ.
(thunderx2t99_tunings): Likewise.
(aarch_macro_fusion_pair_p): Add support for AARCH64_FUSE_CMP_BRANCH.
* config/aarch64/aarch64-fusion-pairs.def: Add ALU_CBZ fusion.
From-SVN: r278966
Richard Biener [Wed, 4 Dec 2019 13:21:39 +0000 (13:21 +0000)]
tree-ssa-sccvn.c (vn_reference_lookup_3): Properly guard empty CTOR and memset partial-def registering.
2019-12-04 Richard Biener <rguenther@suse.de>
* tree-ssa-sccvn.c (vn_reference_lookup_3): Properly guard
empty CTOR and memset partial-def registering. Take advantage
of fancy offset analysis in memset handling.
From-SVN: r278965
Richard Sandiford [Wed, 4 Dec 2019 13:14:20 +0000 (13:14 +0000)]
Fix VIEW_CONVERT_EXPRs for VECTOR_BOOLEAN_TYPE_Ps
In r278410 I added code to handle VIEW_CONVERT_EXPRs between
variable-length vectors. This included support for decoding
a VECTOR_BOOLEAN_TYPE_P with subbyte elements.
However, it turns out that we were already mishandling such bool vectors
for fixed-length vectors: we treated each element as a stand-alone byte
instead of putting multiple elements into the same byte. I think in
principle this could have been an issue for AVX512 as well.
This patch adds encoding support for boolean vectors and reuses
a version of the new decode support for fixed-length vectors.
2019-12-04 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* fold-const.c (native_encode_vector_part): Handle
VECTOR_BOOLEAN_TYPE_Ps that have subbyte precision.
(native_decode_vector_tree): Delete, moving the bulk of the code to...
(native_interpret_vector_part): ...this new function. Use a pointer
and length instead of a vec<> and start index.
(native_interpret_vector): Use native_interpret_vector_part.
(fold_view_convert_vector_encoding): Likewise.
gcc/testsuite/
* gcc.target/aarch64/sve/acle/general/whilelt_5.c: New test.
From-SVN: r278964
Richard Biener [Wed, 4 Dec 2019 12:23:58 +0000 (12:23 +0000)]
tree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Handle non-constant defs in the most trivial way.
2019-12-04 Richard Biener <rguenther@suse.de>
* tree-ssa-sccvn.c (vn_walk_cb_data::push_partial_def): Handle
non-constant defs in the most trivial way.
(vn_reference_lookup_3): Also push down SSA partial defs.
* gcc.dg/tree-ssa/ssa-fre-84.c: New testcase.
From-SVN: r278963
Tobias Burnus [Wed, 4 Dec 2019 12:19:55 +0000 (12:19 +0000)]
Fortran] PR92754 - fix an issue with resolving intrinsic functions
gcc/fortran/
PR fortran/92754
* intrinsic.c (gfc_intrinsic_func_interface): Set
sym's flavor, intrinsic and function attribute if
unset.
gcc/testsuite/
PR fortran/92754
gfortran.dg/intrinsic_9.f90: New.
From-SVN: r278961
Martin Liska [Wed, 4 Dec 2019 10:13:49 +0000 (11:13 +0100)]
Initialize a BB count in switch lowering.
2019-12-04 Martin Liska <mliska@suse.cz>
* tree-switch-conversion.c (switch_decision_tree::try_switch_expansion):
Initialize count of newly created BB.
From-SVN: r278959
Jakub Jelinek [Wed, 4 Dec 2019 09:38:48 +0000 (10:38 +0100)]
re PR tree-optimization/92734 (Missing match.pd simplification done by fold_binary_loc on generic)
PR tree-optimization/92734
* match.pd ((A +- B) - A -> +- B, (A +- B) -+ B -> A,
A - (A +- B) -> -+ B, A +- (B -+ A) -> +- B): Handle nop_convert.
* gcc.dg/tree-ssa/pr92734-2.c: New test.
From-SVN: r278958
Richard Sandiford [Wed, 4 Dec 2019 09:18:13 +0000 (09:18 +0000)]
[C++] Opt out of GNU vector extensions for built-in SVE types
This is the C++ equivalent of r277950. The changes are very similar
to there. Perhaps the only noteworthy thing (that I know of) is that
the patch continues to treat !gnu_vector_type_p vector types as literal
types/potential constexprs. Disabling the GNU vector extensions
shouldn't in itself stop the types from being literal types, since
whatever the target provides instead might be constexpr material.
2019-12-04 Richard Sandiford <richard.sandiford@arm.com>
gcc/cp/
* cp-tree.h (CP_AGGREGATE_TYPE_P): Check for gnu_vector_type_p
instead of VECTOR_TYPE.
* call.c (build_conditional_expr_1): Restrict vector handling
to vectors that satisfy gnu_vector_type_p.
* cvt.c (ocp_convert): Only allow vectors to be converted
to bool if they satisfy gnu_vector_type_p.
(build_expr_type_conversion): Only allow conversions from
vectors if they satisfy gnu_vector_type_p.
* typeck.c (cp_build_binary_op): Only allow binary operators to be
applied to vectors if they satisfy gnu_vector_type_p.
(cp_build_unary_op): Likewise unary operators.
(build_reinterpret_cast_1):
gcc/testsuite/
* g++.target/aarch64/sve/acle/general-c++/gnu_vectors_1.C: New test.
* g++.target/aarch64/sve/acle/general-c++/gnu_vectors_2.C: New test.
From-SVN: r278957
Jakub Jelinek [Wed, 4 Dec 2019 08:47:13 +0000 (09:47 +0100)]
re PR fortran/92756 (ICE in lower_omp, at omp-low.c:12988)
PR fortran/92756
* trans-openmp.c (gfc_trans_omp_teams): Wrap OMP_TEAMS body into a
BIND_EXPR with a forced BLOCK.
* gfortran.dg/gomp/teams1.f90: New test.
* testsuite/libgomp.fortran/teams1.f90: New test.
* testsuite/libgomp.fortran/teams2.f90: New test.
From-SVN: r278956
Kewen Lin [Wed, 4 Dec 2019 05:10:46 +0000 (05:10 +0000)]
[rs6000] Fix PR92760 by checking VECTOR_MEM_NONE_P instead
PR92760 exposed one issue that VECTOR_UNIT_NONE_P (V2DImode) is true on Power7
then we won't return it as preferred_simd_mode but ISA 2.06 (Power7) does
introduce partial support on vector doubleword (very limitted) and more basic
support origins from ISA 2.07 (Power8) though. To make vectorizer still
leverage those few but available V2DImode related instructions, we need to
claim it's available on VSX (Power7 and up).
gcc/ChangeLog
PR target/92760
* gcc/config/rs6000/rs6000.c (rs6000_preferred_simd_mode): Use
VECTOR_MEM_NONE_P instead of VECTOR_UNIT_NONE_P.
From-SVN: r278955
GCC Administrator [Wed, 4 Dec 2019 00:16:41 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r278954
Jonathan Wakely [Tue, 3 Dec 2019 23:57:46 +0000 (23:57 +0000)]
libstdc++: Implement spaceship for std::pair (P1614R2)
This defines operator<=> as a non-member function template and does not
alter operator==. This contradicts the changes made by P1614R2, which
specify both as hidden friends, but that specification of operator<=> is
broken and the subject of a soon-to-be-published LWG issue.
* include/bits/stl_pair.h [__cpp_lib_three_way_comparison]
(operator<=>): Define for C++20.
* libsupc++/compare (__cmp2way_res_t): Rename to __cmp3way_res_t,
move into __detail namespace. Do not turn argument types into lvalues.
(__cmp3way_helper): Rename to __cmp3way_res_impl, move into __detail
namespace. Constrain with concepts instead of using void_t.
(compare_three_way_result): Adjust name of base class.
(compare_three_way_result_t): Use __cmp3way_res_impl directly.
(__detail::__3way_cmp_with): Add workaround for PR 91073.
(compare_three_way): Use workaround.
(__detail::__synth3way, __detail::__synth3way_t): Define new helpers
implementing synth-three-way and synth-three-way-result semantics.
* testsuite/20_util/pair/comparison_operators/constexpr_c++20.cc: New
test.
From-SVN: r278951
Jonathan Wakely [Tue, 3 Dec 2019 23:57:28 +0000 (23:57 +0000)]
libstdc++: Fix Doxygen markup error
* include/bits/stl_pair.h (pair): Remove stray Doxygen closing marker.
From-SVN: r278950
Jakub Jelinek [Tue, 3 Dec 2019 23:32:15 +0000 (00:32 +0100)]
cp-tree.h (enum cp_tree_index): Add CPTI_SOURCE_LOCATION_IMPL.
* cp-tree.h (enum cp_tree_index): Add CPTI_SOURCE_LOCATION_IMPL.
(source_location_impl): Define.
(enum cp_built_in_function): Add CP_BUILT_IN_SOURCE_LOCATION.
(fold_builtin_source_location): Declare.
* cp-gimplify.c: Include output.h, file-prefix-map.h and cgraph.h.
(cp_gimplify_expr, cp_fold): Handle CP_BUILT_IN_SOURCE_LOCATION.
Formatting fix.
(get_source_location_impl_type): New function.
(struct source_location_table_entry,
struct source_location_table_entry_hash): New types.
(source_location_table, source_location_id): New variables.
(fold_builtin_source_location): New function.
* constexpr.c (cxx_eval_builtin_function_call): Handle
CP_BUILT_IN_SOURCE_LOCATION.
* tree.c (builtin_valid_in_constant_expr_p): Likewise. Formatting
fix.
* decl.c (cxx_init_decl_processing): Register
__builtin_source_location.
* name-lookup.c (get_std_name_hint): Add source_location entry.
* g++.dg/cpp2a/srcloc1.C: New test.
* g++.dg/cpp2a/srcloc2.C: New test.
* g++.dg/cpp2a/srcloc3.C: New test.
* g++.dg/cpp2a/srcloc4.C: New test.
* g++.dg/cpp2a/srcloc5.C: New test.
* g++.dg/cpp2a/srcloc6.C: New test.
* g++.dg/cpp2a/srcloc7.C: New test.
* g++.dg/cpp2a/srcloc8.C: New test.
* g++.dg/cpp2a/srcloc9.C: New test.
* g++.dg/cpp2a/srcloc10.C: New test.
* g++.dg/cpp2a/srcloc11.C: New test.
* g++.dg/cpp2a/srcloc12.C: New test.
* g++.dg/cpp2a/srcloc13.C: New test.
* g++.dg/cpp2a/srcloc14.C: New test.
From-SVN: r278949
Eric Botcazou [Tue, 3 Dec 2019 23:10:46 +0000 (23:10 +0000)]
re PR bootstrap/92783 (SEGV in field_byte_offset)
PR bootstrap/92783
* gcc-interface/utils.c (rest_of_record_type_compilation): Move down
the guard for the position of fields in the descriptive type.
From-SVN: r278948
Paolo Carlini [Tue, 3 Dec 2019 20:46:32 +0000 (20:46 +0000)]
typeck.c (cp_build_addr_expr_1): Use the cp_expr_loc_or_input_loc location in a few additional diagnostics; tidy.
/cp
2019-12-03 Paolo Carlini <paolo.carlini@oracle.com>
* typeck.c (cp_build_addr_expr_1): Use the cp_expr_loc_or_input_loc
location in a few additional diagnostics; tidy.
(check_return_expr): Likewise.
* typeck.c (cp_build_addr_expr_1): Use tree_strip_any_location_wrapper
for the address of main pedwarn.
/testsuite
2019-12-03 Paolo Carlini <paolo.carlini@oracle.com>
* g++.dg/diagnostic/inconsistent-deduction-1.C: New.
* g++.dg/diagnostic/returning-a-value-1.C: Likewise.
* g++.dg/cpp0x/decltype3.C: Check location(s) too.
* g++.dg/cpp0x/decltype4.C: Likewise.
* g++.dg/cpp0x/lambda/lambda-deduce-ext-neg.C: Likewise.
* g++.dg/cpp2a/consteval13.C: Likewise.
* g++.dg/expr/pmf-1.C: Likewise.
* g++.dg/other/ptrmem2.C: Likewise.
* g++.dg/template/ptrmem17.C: Likewise.
* g++.old-deja/g++.bugs/900213_03.C: Likewise.
* g++.old-deja/g++.other/pmf7.C: Likewise.
* g++.old-deja/g++.other/ptrmem7.C: Likewise.
* g++.dg/diagnostic/main2.C: New.
From-SVN: r278947
Jan Hubicka [Tue, 3 Dec 2019 20:29:35 +0000 (21:29 +0100)]
ipa-fnsummary.c: Include tree-into-ssa.h.
* ipa-fnsummary.c: Include tree-into-ssa.h.
(compute_fn_summary): Call update_ssa.
From-SVN: r278946
Jakub Jelinek [Tue, 3 Dec 2019 19:27:47 +0000 (20:27 +0100)]
re PR c++/91369 (Implement P0784R7: constexpr new)
PR c++/91369
* constexpr.c (struct constexpr_global_ctx): Add cleanups member,
initialize it in the ctor.
(cxx_eval_constant_expression) <case TARGET_EXPR>: If TARGET_EXPR_SLOT
is already in the values hash_map, don't evaluate it again. Put
TARGET_EXPR_SLOT into hash_map even if not lval, and push it into
save_exprs too. If there is TARGET_EXPR_CLEANUP and not
CLEANUP_EH_ONLY, push the cleanup to cleanups vector.
<case CLEANUP_POINT_EXPR>: Save outer cleanups, set cleanups to
local auto_vec, after evaluating the body evaluate cleanups and
restore previous cleanups.
<case TRY_CATCH_EXPR>: Don't crash if the first operand is NULL_TREE.
(cxx_eval_outermost_constant_expr): Set cleanups to local auto_vec,
after evaluating the expression evaluate cleanups.
* g++.dg/cpp2a/constexpr-new8.C: New test.
From-SVN: r278945
Jan Hubicka [Tue, 3 Dec 2019 18:24:00 +0000 (19:24 +0100)]
Clear calls_comdat_local when comdat group is dissolved
while looking into Firefox inlining dumps I noticed that we often do not
inline because we think function calls comdat local while the comdat group
itself has been dissolved.
* cgraph.c (cgraph_node::verify_node): Check that calls_comdat_local
is set only for symbol in comdat group.
* symtab.c (symtab_node::dissolve_same_comdat_group_1): Clear it.
From-SVN: r278944
Jan Hubicka [Tue, 3 Dec 2019 18:15:53 +0000 (19:15 +0100)]
Do not update SSA in lto-stremaer-in
* cgraph.c: Include tree-into-ssa.h
(cgraph_node::get_body): Call update_ssa.
* cgraphunit.c (cgraph_node::expand): Likewise.
* lto-streamer-in.c (input_function): Do not call update_ssa.
From-SVN: r278943
Richard Sandiford [Tue, 3 Dec 2019 18:06:40 +0000 (18:06 +0000)]
Don't install unnecessary ARRAY_REF element sizes
Even EXACT_DIV_EXPR doesn't distribute across addition for wrapping
types, so in general we can't fold EXACT_DIV_EXPRs of POLY_INT_CSTs
at compile time. This was causing an ICE when trying to gimplify the
element size field in an ARRAY_REF.
If the result of that EXACT_DIV_EXPR is an invariant, we don't bother
recording it in the ARRAY_REF and simply read the element size from the
element type. This avoids the overhead of doing:
/* ??? tree_ssa_useless_type_conversion will eliminate casts to
sizetype from another type of the same width and signedness. */
if (TREE_TYPE (aligned_size) != sizetype)
aligned_size = fold_convert_loc (loc, sizetype, aligned_size);
return size_binop_loc (loc, MULT_EXPR, aligned_size,
size_int (TYPE_ALIGN_UNIT (elmt_type)));
each time array_ref_element_size is called.
So rather than read array_ref_element_size, do some arithmetic on it,
and only then check whether the result is an invariant, we might as
well check whether the element size is an invariant to start with.
We're then directly testing whether array_ref_element_size gives
a reusable value.
For consistency, the patch makes the same change for the offset field
in a COMPONENT_REF, although I don't think that can trigger yet.
2019-12-03 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* gimplify.c (gimplify_compound_lval): Don't gimplify and install
an array element size if array_element_size is already an invariant.
Similarly don't gimplify and install a field offset if
component_ref_field_offset is already an invariant.
gcc/testsuite/
* gcc.target/aarch64/sve/acle/general-c/struct_1.c: New test.
From-SVN: r278942
projects / gcc.git / log