mesa.git
8 years agoanv/device: Improve the api version check to allow 1.0.X
Jason Ekstrand [Thu, 28 Jan 2016 05:56:23 +0000 (21:56 -0800)]
anv/device: Improve the api version check to allow 1.0.X

8 years agovtn: Improve accuracy of acos approximation.
Francisco Jerez [Thu, 28 Jan 2016 02:39:48 +0000 (18:39 -0800)]
vtn: Improve accuracy of acos approximation.

The adjusted polynomial coefficients come from the numerical
minimization of the L2 norm of the relative error.  The old
coefficients would give a maximum relative error of about 15000 ULP in
the neighborhood around acos(x) = 0, the new ones give a relative
error bounded by less than 2000 ULP in the same neighborhood.

8 years agoAn alternate arccosine implementation
Jason Ekstrand [Thu, 28 Jan 2016 00:58:42 +0000 (16:58 -0800)]
An alternate arccosine implementation

8 years agoanv/meta_resolve: Fix a bug in the meta pipeline destroy path
Jason Ekstrand [Thu, 28 Jan 2016 03:48:43 +0000 (19:48 -0800)]
anv/meta_resolve: Fix a bug in the meta pipeline destroy path

8 years agoanv/skl: Fix crash in 16x multisampling
Chad Versace [Thu, 28 Jan 2016 01:26:18 +0000 (17:26 -0800)]
anv/skl: Fix crash in 16x multisampling

We built meta clear and resolve pipelines for only up to 8x samples.
There were no 16x pipelines.

8 years agoanv: Fix comment for anv_meta_state arrays
Chad Versace [Thu, 28 Jan 2016 01:22:20 +0000 (17:22 -0800)]
anv: Fix comment for anv_meta_state arrays

Array element i is for 2^i samples, not log2(i) samples.

8 years agoanv/push constants: Use constant buffer #2
Ben Widawsky [Wed, 27 Jan 2016 19:37:23 +0000 (11:37 -0800)]
anv/push constants: Use constant buffer #2

SKL has a workaround which requires either some weird programming of buffer 3,
OR, just never using buffer 0. Since we don't actually use multiple constant
buffers, it's easier to just not use 0.

Only SKL requires this workaround, but there is no harm in applying it to all
platforms. The big change here is that buffer #0 is relative to dynamic state
base normally (depending upon ISTPM), where buffer 1-3 is a GPU virtual address.

8 years agoanv/meta: Implement multisample clears
Chad Versace [Wed, 27 Jan 2016 22:34:27 +0000 (14:34 -0800)]
anv/meta: Implement multisample clears

8 years agoanv/meta: Simplify failure handling during clear init
Chad Versace [Wed, 27 Jan 2016 22:02:57 +0000 (14:02 -0800)]
anv/meta: Simplify failure handling during clear init

Remove all the fine-grained cleanup in
anv_device_init_meta_clear_state(). Instead, if anything fails during
initialization, simply call anv_device_finish_meta_clear_state() and let
it clean up the partially initialized anv_meta_state::clear.

8 years agoanv/meta: Implement vkCmdResolveImage
Chad Versace [Thu, 21 Jan 2016 01:10:41 +0000 (17:10 -0800)]
anv/meta: Implement vkCmdResolveImage

This handles multisample color images that have a floating-point or
normalized format and have a single array layer.

This does not yet handle integer formats nor multisample array images.

8 years agoanv/meta: Add func anv_meta_get_iview_layer()
Chad Versace [Mon, 25 Jan 2016 17:14:03 +0000 (09:14 -0800)]
anv/meta: Add func anv_meta_get_iview_layer()

This function is just meta_blit_get_dest_view_base_array_slice(), but
moved to the shared header anv_meta.h.

Will be needed by anv_meta_resolve.c.

8 years agoanv/gen8: Begin enabling pipeline multisample state
Chad Versace [Tue, 26 Jan 2016 18:56:06 +0000 (10:56 -0800)]
anv/gen8: Begin enabling pipeline multisample state

As far as I can tell, this patch sets all pipeline multisample state
except:
    - alpha to coverage
    - alpha to one
    - the dispatch count for per-sample dispatch

8 years agoanv/gen8: Set multisample surface state
Chad Versace [Tue, 26 Jan 2016 17:55:05 +0000 (09:55 -0800)]
anv/gen8: Set multisample surface state

8 years agoanv/meta: Merge anv_meta_clear.h into anv_meta.h
Chad Versace [Mon, 25 Jan 2016 16:56:36 +0000 (08:56 -0800)]
anv/meta: Merge anv_meta_clear.h into anv_meta.h

The header was too small.

8 years agovtn: Make tanh implementation even stupider
Kenneth Graunke [Wed, 27 Jan 2016 23:31:53 +0000 (15:31 -0800)]
vtn: Make tanh implementation even stupider

The dEQP "precision" test tries to verify that the reference functions

   float sinh(float a) { return ((exp(a) - exp(-a)) / 2); }
   float cosh(float a) { return ((exp(a) + exp(-a)) / 2); }
   float tanh(float a) { return (sinh(a) / cosh(a)); }

produce the same values as the built-ins.  We simplified away the
multiplication by 0.5 in the numerator and denominator, and apparently
this causes them not to match for exactly 1 out of 13,632 values.

So, put it back in, fixing the test, but making our code generation
(and precision?) worse.

8 years agonir/opt_algebraic: Use a more elementary mechanism for lowering ldexp
Jason Ekstrand [Wed, 27 Jan 2016 23:21:28 +0000 (15:21 -0800)]
nir/opt_algebraic: Use a more elementary mechanism for lowering ldexp

8 years agogen8/state: Fix QPitch for compressed textures on Broadwell
Jason Ekstrand [Wed, 27 Jan 2016 20:55:36 +0000 (12:55 -0800)]
gen8/state: Fix QPitch for compressed textures on Broadwell

8 years agoanv/image: Use the entire image height for compressed meta blits
Jason Ekstrand [Wed, 27 Jan 2016 20:37:15 +0000 (12:37 -0800)]
anv/image: Use the entire image height for compressed meta blits

8 years agoanv/image: Enlarge the image level 0 extent
Nanley Chery [Wed, 27 Jan 2016 20:08:56 +0000 (12:08 -0800)]
anv/image: Enlarge the image level 0 extent

The extent previously was supposed to match the mip at a given level
under the assumption that the base address would be that of the mip
as well.

Now however, the base address only matches the offset of the
containing tile. Therefore, enlarge the extent to match that of
phys_slice0, so that we don't draw/fetch in out of bounds territory.

This solution isn't perfect because the base adress isn't always at
the first tile, therefore the assumed valid memory region by the HW
contains some number of invalid tiles on two edges.

8 years agoanv/image: Minify before dividing by block dimensions
Jason Ekstrand [Wed, 27 Jan 2016 19:47:07 +0000 (11:47 -0800)]
anv/image: Minify before dividing by block dimensions

8 years agoanv/meta: Don't double-call choose_buffer_format
Jason Ekstrand [Wed, 27 Jan 2016 18:47:42 +0000 (10:47 -0800)]
anv/meta: Don't double-call choose_buffer_format

This fixes all the renderpass tests

8 years agoanv/meta: Modify make_image_for_buffer()'s image
Nanley Chery [Wed, 27 Jan 2016 05:51:36 +0000 (21:51 -0800)]
anv/meta: Modify make_image_for_buffer()'s image

Always use a valid buffer format and convert the extent to units of
elements with respect to original image format.

8 years agoanv/image: Use custom VkBufferImageCopy for iview initialization
Nanley Chery [Wed, 27 Jan 2016 02:40:54 +0000 (18:40 -0800)]
anv/image: Use custom VkBufferImageCopy for iview initialization

Use a custom VkBufferImageCopy with the user-provided struct as
the base. A few fields are modified when the iview is uncompressed
and the underlying image is compressed.

8 years agoanv: Add offset parameter to anv_image_view_init()
Nanley Chery [Wed, 27 Jan 2016 02:53:21 +0000 (18:53 -0800)]
anv: Add offset parameter to anv_image_view_init()

This is the offset of the tile that contains the mip specified by
isl_surf_get_image_intratile_offset_el(). Used to draw to/from the
specified mip.

8 years agoanv/meta: Calculate mip offset for compressed texture
Nanley Chery [Wed, 27 Jan 2016 02:10:12 +0000 (18:10 -0800)]
anv/meta: Calculate mip offset for compressed texture

This value will be used in a later commit.

8 years agoanv/meta: Disambiguate slice variable value
Nanley Chery [Wed, 27 Jan 2016 02:00:14 +0000 (18:00 -0800)]
anv/meta: Disambiguate slice variable value

This will simplify the usage of
isl_surf_get_image_intratile_offset_el().

8 years agogen8_state: use iview extent to program RENDER_SURFACE_STATE
Nanley Chery [Mon, 4 Jan 2016 22:53:55 +0000 (14:53 -0800)]
gen8_state: use iview extent to program RENDER_SURFACE_STATE

When creating an uncompressed ImageView on an compressed Image, the
SurfaceFormat is updated to match the ImageView's. The surface
dimensions must also change so that the HW sees the same size image
instead of a 4x larger one.

Fixes the following error which results from running many VulkanCTS
compressed tests in one shot:
  ResourceError (vk.queueSubmit(queue, 1, &submitInfo, *m_fence):
  VK_ERROR_OUT_OF_DEVICE_MEMORY at
  vktPipelineImageSamplingInstance.cpp:921)

Makes all compressed format tests with a height > 1 pass.

8 years agoanv/image: Scale iview extent by backing image
Nanley Chery [Mon, 4 Jan 2016 20:41:22 +0000 (12:41 -0800)]
anv/image: Scale iview extent by backing image

Aligns with formula's presented in Vulkan spec concerning CopyBufferToImage.
18.4 Copying Data Between Buffers and Images

This won't conflict with valid API usage, because:
1) Users are not allowed to create an uncompressed ImageView with a
compressed Image.
see: VkSpec - 11.5 Image Views - VkImageViewCreateInfo's Valid Usage box

2) If users create a differently formatted compressed ImageView with a
compressed Image, the block dimensions will still match.
see: VkSpec - 28.3.1.5 Format Compatibility Classes - Table 28.5

8 years agoanv/meta: Set depth to 0 for buffer image in CopyBufferToImage()
Nanley Chery [Wed, 27 Jan 2016 00:19:33 +0000 (16:19 -0800)]
anv/meta: Set depth to 0 for buffer image in CopyBufferToImage()

The buffer image is a flat 2D surface. Each surface represents an
array/depth layer, therefore, the Z-offset is 0 when blitting.

8 years agoanv/meta: Use the uncompressed rectangle when blitting
Nanley Chery [Tue, 5 Jan 2016 20:13:56 +0000 (12:13 -0800)]
anv/meta: Use the uncompressed rectangle when blitting

For an uncompressed ImageView of a compressed Image, the
dimensions and offsets are all divided by the appropriate
block dimensions.

We are not yet using an uncompressed ImageView for a
compressed Image, but will do so in a future commit.

8 years agoi965: Update the surface_format table for ETC formats
Nanley Chery [Tue, 29 Dec 2015 19:06:25 +0000 (11:06 -0800)]
i965: Update the surface_format table for ETC formats

Enable ETC support for BDW+. In Vulkan, an array lookup on
surface_format[] is used to determine HW support for certain
formats. In contrast, Mesa dynamically populates an array
which reports this information.

8 years agoanv/image: Update usages of isl_surf_get_image_offset_sa
Nanley Chery [Wed, 27 Jan 2016 17:29:09 +0000 (09:29 -0800)]
anv/image: Update usages of isl_surf_get_image_offset_sa

8 years agoisl: Add logical z offset to GEN4_2D surfaces
Nanley Chery [Wed, 27 Jan 2016 06:56:21 +0000 (22:56 -0800)]
isl: Add logical z offset to GEN4_2D surfaces

3D surfaces in Skylake are stored with ISL_DIM_LAYOUT_GEN4_2D. Any
delta in the logical z offset causes an equivalent delta in the
surface's array layer.

8 years agoisl/tests: Add some tests for intratile offsets
Chad Versace [Tue, 26 Jan 2016 00:22:17 +0000 (16:22 -0800)]
isl/tests: Add some tests for intratile offsets

Test isl_surf_get_image_intratile_offset_el() in the tests:
  test_bdw_2d_r8g8b8a8_unorm_512x512_array01_samples01_noaux_tiley0
  test_bdw_2d_r8g8b8a8_unorm_1024x1024_array06_samples01_noaux_tiley0

8 years agoisl: Add func isl_get_intratile_image_offset_el()
Chad Versace [Mon, 25 Jan 2016 20:43:56 +0000 (12:43 -0800)]
isl: Add func isl_get_intratile_image_offset_el()

8 years agoisl/tests: Rename t_assert_offset()
Chad Versace [Mon, 25 Jan 2016 23:08:33 +0000 (15:08 -0800)]
isl/tests: Rename t_assert_offset()

Rename it to t_assert_offset_el(), clarifying that the offset in units
of surface elements, not samples.

8 years agoisl: Add func isl_surf_get_image_offset_el()
Chad Versace [Mon, 25 Jan 2016 20:15:07 +0000 (12:15 -0800)]
isl: Add func isl_surf_get_image_offset_el()

This replaces function isl_surf_get_image_offset_sa()

8 years agoisl: Fix row pitch for compressed formats
Chad Versace [Mon, 25 Jan 2016 20:23:57 +0000 (12:23 -0800)]
isl: Fix row pitch for compressed formats

When calculating row pitch, the row's width in samples must be divided
by the format's block width. The commit below accidentally removed the
division.

    commit eea2d4d05987b4f8ad90a1588267f9495f1e9e99
    Author: Chad Versace <chad.versace@intel.com>
    Date:   Tue Jan 5 14:28:28 2016 -0800
    Subject: isl: Don't align phys_slice0_sa.width twice

8 years agoisl: Add func isl_surf_get_tile_info()
Chad Versace [Mon, 25 Jan 2016 19:45:12 +0000 (11:45 -0800)]
isl: Add func isl_surf_get_tile_info()

8 years agovtn: Fix atan2 for non-scalars.
Kenneth Graunke [Wed, 27 Jan 2016 23:07:18 +0000 (15:07 -0800)]
vtn: Fix atan2 for non-scalars.

The if/then/else block was bogus, as it can only take a scalar
condition, and we need to select component-wise.  The GLSL IR
implementation of atan2 handles this by looping over components,
but I decided to try and do it vector-wise, and messed up.

For now, just bcsel.  It means that we do the atan1 math even if
all components hit the quick case, but it works, and presumably
at least one component will hit the expensive path anyway.

8 years agovtn: Fix Modf.
Kenneth Graunke [Wed, 27 Jan 2016 22:20:47 +0000 (14:20 -0800)]
vtn: Fix Modf.

We were botching this for negative numbers - floor of a negative rounds
the wrong way.  Additionally, both results are supposed to retain the
sign of the original.

To fix this, just take the abs of both values, then put the sign back.
There's probably a better way to do this, but this works for now.

8 years agoi965: Fix SIN/COS precision problems.
Kenneth Graunke [Wed, 27 Jan 2016 20:21:04 +0000 (12:21 -0800)]
i965: Fix SIN/COS precision problems.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
8 years agoanv: Put back code to grow shader scratch space
Kristian Høgsberg Kristensen [Wed, 27 Jan 2016 19:36:44 +0000 (11:36 -0800)]
anv: Put back code to grow shader scratch space

This was lost in commit a71e614d33e8d869bbaced8948349a7180783ab7.

8 years agoanv: Update the device limits.
Kenneth Graunke [Wed, 27 Jan 2016 07:09:45 +0000 (23:09 -0800)]
anv: Update the device limits.

Fixes dEQP-VK.api.info.device.properties.  I haven't tested any others.

8 years agogen7/cmd_buffer: SCISSOR_RECT structs are tightly packed
Jason Ekstrand [Wed, 27 Jan 2016 06:10:11 +0000 (22:10 -0800)]
gen7/cmd_buffer: SCISSOR_RECT structs are tightly packed

The pointer has to be 32-byte aligned, but the structs themselves are 2
dwords each, tightly packed.

8 years agoanv/pipeline: Set MaximumVPIndex in 3DSTATE_CLIP
Jason Ekstrand [Wed, 27 Jan 2016 05:52:59 +0000 (21:52 -0800)]
anv/pipeline: Set MaximumVPIndex in 3DSTATE_CLIP

8 years agoanv/pipeline: Only lower input indirects if EmitNoIndirectInput is set
Jason Ekstrand [Wed, 27 Jan 2016 05:45:21 +0000 (21:45 -0800)]
anv/pipeline: Only lower input indirects if EmitNoIndirectInput is set

8 years agoanv/formats: Use is_power_of_two instead of is_rgb to determine renderability
Jason Ekstrand [Wed, 27 Jan 2016 01:28:16 +0000 (17:28 -0800)]
anv/formats: Use is_power_of_two instead of is_rgb to determine renderability

8 years agoHACK/i965/surface_formats: Mark A4B4G4R4 as being supported
Jason Ekstrand [Wed, 27 Jan 2016 01:10:57 +0000 (17:10 -0800)]
HACK/i965/surface_formats: Mark A4B4G4R4 as being supported

The table has this marked as unsupported on all gens, but I don't really
believe that given how early it is in the table.  I've tested and it seems
to work on Broadwell.  The Bspec says that it sould be renderable on SKL+
but alpha blending is questionable.

Side note: We really need to audit the format table again.

8 years agoanv: Support swizzled formats.
Jordan Justen [Tue, 26 Jan 2016 19:10:56 +0000 (11:10 -0800)]
anv: Support swizzled formats.

Some formats require a swizzle in order to map them to actual hardware
formats.  This allows us to turn on two new Vulkan formats.

8 years agoanv/image: Do swizzle remapping in anv_image.c
Jason Ekstrand [Wed, 27 Jan 2016 04:16:43 +0000 (20:16 -0800)]
anv/image: Do swizzle remapping in anv_image.c

TODO: At some point, we really need to make an image_view_init_info that's
a flyweight and stop stuffing everything into image_view.

8 years agoHACK: Expose support for stencil blits
Jason Ekstrand [Tue, 26 Jan 2016 23:59:43 +0000 (15:59 -0800)]
HACK: Expose support for stencil blits

If someone actually tries to use them, they won't work, but at least we
don't fail to return format properties now.

8 years agovtn: Delete references to IMix opcode.
Kenneth Graunke [Wed, 27 Jan 2016 01:02:35 +0000 (17:02 -0800)]
vtn: Delete references to IMix opcode.

This is being removed in SPIR-V.

Bugzilla: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15452

8 years agoi965/skl: Utilize new 5th bit for gateway messages
Ben Widawsky [Tue, 26 Jan 2016 23:42:08 +0000 (15:42 -0800)]
i965/skl: Utilize new 5th bit for gateway messages

Cc: Jordan Justen <jordan.l.justen@intel.com>
Signed-off-by: Ben Widawsky <benjamin.widawsky@intel.com>
8 years agogenX/pipeline: Don't make vertex bindings with holes
Jason Ekstrand [Tue, 26 Jan 2016 23:44:18 +0000 (15:44 -0800)]
genX/pipeline: Don't make vertex bindings with holes

8 years agoanv/cmd_buffer: Put base_instance in the second component
Jason Ekstrand [Tue, 26 Jan 2016 23:44:02 +0000 (15:44 -0800)]
anv/cmd_buffer: Put base_instance in the second component

8 years agoanv/image: clflush surface state map in anv_fill_buffer_surface_state().
Francisco Jerez [Tue, 26 Jan 2016 22:50:52 +0000 (14:50 -0800)]
anv/image: clflush surface state map in anv_fill_buffer_surface_state().

Some of its users had the required clflush on non-LLC platforms, some
didn't.  Put the clflush in anv_fill_buffer_surface_state() so we
don't forget.

8 years agoanv/image: clflush the right state map in anv_fill_image_surface_state().
Francisco Jerez [Tue, 26 Jan 2016 22:45:46 +0000 (14:45 -0800)]
anv/image: clflush the right state map in anv_fill_image_surface_state().

It was clflushing the nonrt_surface_state structure regardless of
which state structure was actually being initialized.

8 years agoanv/image: Upload raw buffer surface state for untyped storage image and texel buffer...
Francisco Jerez [Tue, 26 Jan 2016 20:23:08 +0000 (12:23 -0800)]
anv/image: Upload raw buffer surface state for untyped storage image and texel buffer access.

8 years agoanv/image: Fix image parameter initialization.
Francisco Jerez [Tue, 26 Jan 2016 20:20:01 +0000 (12:20 -0800)]
anv/image: Fix image parameter initialization.

8 years agoisl/gen9: Fix slice offset calculation for 1D array images.
Francisco Jerez [Tue, 26 Jan 2016 03:20:57 +0000 (19:20 -0800)]
isl/gen9: Fix slice offset calculation for 1D array images.

The X component of the offset is set to the layer index times layer
height which is obviously bogus, return the vertical offset of the
slice as Y component instead.  Fixes a few image load/store tests that
use 1D arrays on SKL when forcing it to fall back to untyped reads and
writes.

8 years agoi965/fs_surface_builder: Mask signed integers after conversion
Jason Ekstrand [Tue, 19 Jan 2016 01:30:59 +0000 (17:30 -0800)]
i965/fs_surface_builder: Mask signed integers after conversion

8 years agoanv/image: Actually fill out brw_image_param structs
Jason Ekstrand [Tue, 5 Jan 2016 21:55:00 +0000 (13:55 -0800)]
anv/image: Actually fill out brw_image_param structs

8 years agoanv/image_view: Add base mip and base layer fields
Jason Ekstrand [Tue, 5 Jan 2016 21:54:02 +0000 (13:54 -0800)]
anv/image_view: Add base mip and base layer fields

These will be needed by image_load_store

8 years agogen7: Add support for base vertex/instance
Jason Ekstrand [Tue, 26 Jan 2016 20:09:33 +0000 (12:09 -0800)]
gen7: Add support for base vertex/instance

8 years agogen8: Add support for base vertex/instance
Jason Ekstrand [Tue, 26 Jan 2016 20:08:31 +0000 (12:08 -0800)]
gen8: Add support for base vertex/instance

8 years agonir/spirv: Add proper support for InstanceIndex
Jason Ekstrand [Tue, 26 Jan 2016 19:48:23 +0000 (11:48 -0800)]
nir/spirv: Add proper support for InstanceIndex

8 years agonir/lower_io: Lower INSTNACE_INDEX
Jason Ekstrand [Tue, 26 Jan 2016 19:48:07 +0000 (11:48 -0800)]
nir/lower_io: Lower INSTNACE_INDEX

8 years agoglsl/enums: Add an enum for Vulkan instance index
Jason Ekstrand [Tue, 26 Jan 2016 19:47:23 +0000 (11:47 -0800)]
glsl/enums: Add an enum for Vulkan instance index

8 years agogenX/pipeline: Break emit_vertex_input out into common code
Jason Ekstrand [Tue, 26 Jan 2016 18:52:56 +0000 (10:52 -0800)]
genX/pipeline: Break emit_vertex_input out into common code

It's mostly the same and contains some non-trivial logic, so it really
should be shared.  Also, we're about to make some modifications here that
we would really like to share.

8 years agoanv: Remove long unused anv_aub.h
Kristian Høgsberg Kristensen [Tue, 26 Jan 2016 22:53:00 +0000 (14:53 -0800)]
anv: Remove long unused anv_aub.h

8 years agoanv: Dirty fragment shader descriptors in meta restore
Kristian Høgsberg Kristensen [Tue, 26 Jan 2016 22:43:07 +0000 (14:43 -0800)]
anv: Dirty fragment shader descriptors in meta restore

We need to reemit render targets, so dirtying VK_SHADER_STAGE_VERTEX_BIT
doesn't help us much.

8 years agoanv: Reemit STATE_BASE_ADDRESS after second level cmd buffers
Kristian Høgsberg Kristensen [Tue, 26 Jan 2016 22:41:06 +0000 (14:41 -0800)]
anv: Reemit STATE_BASE_ADDRESS after second level cmd buffers

Otherwise the primary batch will continue using the state base addresses
set by the secondary.  Fixes remaining renderpass tests.

8 years agoanv/meta: Fix sample mask in clear pipelines
Chad Versace [Tue, 26 Jan 2016 19:01:24 +0000 (11:01 -0800)]
anv/meta: Fix sample mask in clear pipelines

Once we begin emitting the correct sample mask,
genX_3DSTATE_SAMPLE_MASK_pack will hit an assertion if the mask contains
too many bits.

8 years agoi965/compiler: Set nir_options.vertex_id_zero_based
Jason Ekstrand [Tue, 26 Jan 2016 00:10:12 +0000 (16:10 -0800)]
i965/compiler: Set nir_options.vertex_id_zero_based

8 years agoHACK/i965: Default to scalar GS on BDW+
Jason Ekstrand [Mon, 25 Jan 2016 23:52:53 +0000 (15:52 -0800)]
HACK/i965: Default to scalar GS on BDW+

8 years agoMerge remote-tracking branch 'mattst88/nir-lower-pack-unpack' into vulkan
Jason Ekstrand [Mon, 25 Jan 2016 23:50:31 +0000 (15:50 -0800)]
Merge remote-tracking branch 'mattst88/nir-lower-pack-unpack' into vulkan

8 years agogen7/state: Apply min/mag filters individually for samplers
Jason Ekstrand [Mon, 25 Jan 2016 23:33:08 +0000 (15:33 -0800)]
gen7/state: Apply min/mag filters individually for samplers

This fixes tests which apply different min and mag filters, and depend on
the min filter to be correct.

8 years agogen8/state: Apply min/mag filters individually for samplers
Ben Widawsky [Mon, 25 Jan 2016 23:26:25 +0000 (15:26 -0800)]
gen8/state: Apply min/mag filters individually for samplers

This fixes tests which apply different min and mag filters, and depend on the
min filter to be correct.

8 years agoi965/fs: Feel free to spill partial reads/writes
Jason Ekstrand [Mon, 25 Jan 2016 23:00:38 +0000 (15:00 -0800)]
i965/fs: Feel free to spill partial reads/writes

Now that we properly handle write-masking, this should be safe.

8 years agoi965/fs: Properly write-mask spills
Jason Ekstrand [Mon, 25 Jan 2016 20:42:01 +0000 (12:42 -0800)]
i965/fs: Properly write-mask spills

For unspills (scratch reads), we can just set WE_all all the time because
we always unspill into a new GRF.  For spills, we have two options: If the
instruction has a 32-bit-per-channel destination and "normal" regioning,
then we just do a regular write and it will interleave channels from
different control-flow paths properly.  If, on the other hand, the the
regioning is non-normal, then we have to unspill, run the instruction, and
spill afterwards.  In this second case, we need to do the spill with
we_ALL.

8 years agoanv: Remove a few finished finishme
Kristian Høgsberg Kristensen [Mon, 25 Jan 2016 23:14:47 +0000 (15:14 -0800)]
anv: Remove a few finished finishme

8 years agoanv: Remove stale assert
Kristian Høgsberg Kristensen [Mon, 25 Jan 2016 23:12:43 +0000 (15:12 -0800)]
anv: Remove stale assert

This goes back to when we didn't have the subpass number in the command
buffer begin info.

8 years agoi965/gen7+: Use NIR for lowering of pack/unpack opcodes.
Matt Turner [Mon, 25 Jan 2016 19:07:28 +0000 (11:07 -0800)]
i965/gen7+: Use NIR for lowering of pack/unpack opcodes.

8 years agoi965/vec4: Implement nir_op_pack_uvec2_to_uint.
Matt Turner [Mon, 25 Jan 2016 18:49:15 +0000 (10:49 -0800)]
i965/vec4: Implement nir_op_pack_uvec2_to_uint.

And mark nir_op_pack_uvec4_to_uint unreachable, since it's only produced
by lowering pack[SU]norm4x8 which the vec4 backend does not need.

8 years agonir: Add lowering support for unpacking opcodes.
Matt Turner [Mon, 25 Jan 2016 19:07:02 +0000 (11:07 -0800)]
nir: Add lowering support for unpacking opcodes.

8 years agonir: Add lowering support for packing opcodes.
Matt Turner [Mon, 25 Jan 2016 19:05:52 +0000 (11:05 -0800)]
nir: Add lowering support for packing opcodes.

8 years agoi965/fs: Implement support for extract_word.
Matt Turner [Thu, 21 Jan 2016 02:56:37 +0000 (18:56 -0800)]
i965/fs: Implement support for extract_word.

The vec4 backend will lower it.

8 years agonir: Add opcodes to extract bytes or words.
Matt Turner [Thu, 21 Jan 2016 17:09:29 +0000 (09:09 -0800)]
nir: Add opcodes to extract bytes or words.

The uint versions zero extend while the int versions sign extend.

8 years agoanv/meta: Fix CopyBuffer when size matches HW limit
Nanley Chery [Thu, 31 Dec 2015 00:00:47 +0000 (16:00 -0800)]
anv/meta: Fix CopyBuffer when size matches HW limit

Perform a copy when the copy_size matches the HW limit (max_copy_size).
Otherwise the current behavior is that we fail the following assertion:

      assert(height < max_surface_dim);

because the values are equal.

8 years agoanv: Don't use uninitialized barycentric_interp_modes
Kristian Høgsberg Kristensen [Mon, 25 Jan 2016 19:34:32 +0000 (11:34 -0800)]
anv: Don't use uninitialized barycentric_interp_modes

If we don't have a fragment shader, wm_prog_data in undefined.

8 years agoanv: Disable fs dispatch for depth/stencil only pipelines
Kristian Høgsberg Kristensen [Mon, 25 Jan 2016 19:24:19 +0000 (11:24 -0800)]
anv: Disable fs dispatch for depth/stencil only pipelines

Fixes most renderpass bugs.

8 years agoglsl: Remove 2x16 half-precision pack/unpack opcodes.
Matt Turner [Thu, 21 Jan 2016 19:46:22 +0000 (11:46 -0800)]
glsl: Remove 2x16 half-precision pack/unpack opcodes.

i965/fs was the only consumer, and we're now doing the lowering in NIR.

8 years agoi965/fs: Switch from GLSL IR to NIR for un/packHalf2x16 lowering.
Matt Turner [Thu, 21 Jan 2016 23:30:57 +0000 (15:30 -0800)]
i965/fs: Switch from GLSL IR to NIR for un/packHalf2x16 lowering.

8 years agonir: Add lowering of nir_op_unpack_half_2x16.
Matt Turner [Thu, 21 Jan 2016 23:46:47 +0000 (15:46 -0800)]
nir: Add lowering of nir_op_unpack_half_2x16.

8 years agoi965: Make separate nir_options for scalar/vector stages.
Matt Turner [Thu, 21 Jan 2016 17:30:05 +0000 (09:30 -0800)]
i965: Make separate nir_options for scalar/vector stages.

We'll want to have different lowering options set for scalar/vector
stages.

8 years agoi965: Move brw_compiler_create() to new brw_compiler.c.
Matt Turner [Thu, 21 Jan 2016 17:19:53 +0000 (09:19 -0800)]
i965: Move brw_compiler_create() to new brw_compiler.c.

A future patch will want to use designated initalizers, which aren't
available in C++, but this is C.

8 years agonir: Make argument order of unop_convert match binop_convert.
Matt Turner [Thu, 21 Jan 2016 17:54:19 +0000 (09:54 -0800)]
nir: Make argument order of unop_convert match binop_convert.

Strangely the return and parameter types were reversed.

8 years agoanv/cmd_buffer: Zero out binding tables and samplers in state_reset
Jason Ekstrand [Sat, 23 Jan 2016 06:57:02 +0000 (22:57 -0800)]
anv/cmd_buffer: Zero out binding tables and samplers in state_reset

This fixes a use of an undefined value if the client uses push constants in
a stage without ever setting any descriptors on GEN8-9.

8 years agonir/opcodes: Properly flush denormals in fquantize2f16
Jason Ekstrand [Sat, 23 Jan 2016 06:04:09 +0000 (22:04 -0800)]
nir/opcodes: Properly flush denormals in fquantize2f16