Marek Polacek [Tue, 13 Aug 2019 15:05:48 +0000 (15:05 +0000)]
PR c++/90473 - wrong code with nullptr in default argument.
* call.c (null_ptr_cst_p): Update quote from the standard.
* decl.c (check_default_argument): Don't return nullptr when the arg
has side-effects.
* g++.dg/cpp0x/nullptr42.C: New test.
From-SVN: r274382
Marek Polacek [Tue, 13 Aug 2019 15:02:30 +0000 (15:02 +0000)]
* cp-tree.h (DECL_MUTABLE_P): Use FIELD_DECL_CHECK.
From-SVN: r274381
Mark Eggleston [Tue, 13 Aug 2019 13:38:17 +0000 (13:38 +0000)]
Add my name to MAINTAINERS.
From-SVN: r274380
Olivier Hainque [Tue, 13 Aug 2019 11:16:18 +0000 (11:16 +0000)]
Adjust placement of protoype for tablejump_casesi_pattern
So it appears next to the prototype of tablejump_p, matching
the definition placement in rtlanal.c.
From-SVN: r274378
Olivier Hainque [Tue, 13 Aug 2019 11:04:52 +0000 (11:04 +0000)]
Handle casesi dispatch tablejumps in create_trace_edges (as well)
* rtlanal.c (tablejump_casesi_pattern): New function, to
determine if a tablejump insn is a casesi dispatcher. Extracted
from patch_jump_insn.
* rtl.h (tablejump_casesi_pattern): Declare.
* cfgrtl.c (patch_jump_insn): Use it.
* dwarf2cfi.c (create_trace_edges): Use it.
testsuite/
* gnat.dg/casesi.ad[bs], test_casesi.adb: New test.
From-SVN: r274377
Wilco Dijkstra [Tue, 13 Aug 2019 10:46:44 +0000 (10:46 +0000)]
[AArch64] Fix PR81800
PR81800 is about the lrint inline giving spurious FE_INEXACT exceptions.
The previous change for PR81800 didn't fix this: when lrint is disabled
in the backend, the midend will simply use llrint. This actually makes
things worse since llrint now also ignores FE_INVALID exceptions!
The fix is to disable lrint/llrint on double if the size of a long is
smaller (ie. ilp32).
gcc/
PR target/81800
* gcc/config/aarch64/aarch64.md (lrint): Disable lrint pattern if GPF
operand is larger than a long int.
testsuite/
PR target/81800
* gcc.target/aarch64/no-inline-lrint_3.c: New test.
From-SVN: r274376
Richard Sandiford [Tue, 13 Aug 2019 10:40:02 +0000 (10:40 +0000)]
[AArch64] Improve SVE constant moves
If there's no SVE instruction to load a given constant directly, this
patch instead tries to use an Advanced SIMD constant move and then
duplicates the constant to fill an SVE vector. The main use of this
is to support constants in which each byte is in { 0, 0xff }.
Also, the patch prefers a simple integer move followed by a duplicate
over a load from memory, like we already do for Advanced SIMD. This is
a useful option to have and would be easy to turn off via a tuning
parameter if necessary.
The patch also extends the handling of wide LD1Rs to big endian,
whereas previously we punted to a full LD1RQ.
2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* machmode.h (opt_mode::else_mode): New function.
(opt_mode::else_blk): Use it.
* config/aarch64/aarch64-protos.h (aarch64_vq_mode): Declare.
(aarch64_full_sve_mode, aarch64_sve_ld1rq_operand_p): Likewise.
(aarch64_gen_stepped_int_parallel): Likewise.
(aarch64_stepped_int_parallel_p): Likewise.
(aarch64_expand_mov_immediate): Remove the optional gen_vec_duplicate
argument.
* config/aarch64/aarch64.c
(aarch64_expand_sve_widened_duplicate): Delete.
(aarch64_expand_sve_dupq, aarch64_expand_sve_ld1rq): New functions.
(aarch64_expand_sve_const_vector): Rewrite to handle more cases.
(aarch64_expand_mov_immediate): Remove the optional gen_vec_duplicate
argument. Use early returns in the !CONST_INT_P handling.
Pass all SVE data vectors to aarch64_expand_sve_const_vector rather
than handling some inline.
(aarch64_full_sve_mode, aarch64_vq_mode): New functions, split out
from...
(aarch64_simd_container_mode): ...here.
(aarch64_gen_stepped_int_parallel, aarch64_stepped_int_parallel_p)
(aarch64_sve_ld1rq_operand_p): New functions.
* config/aarch64/predicates.md (descending_int_parallel)
(aarch64_sve_ld1rq_operand): New predicates.
* config/aarch64/constraints.md (UtQ): New constraint.
* config/aarch64/aarch64.md (UNSPEC_REINTERPRET): New unspec.
* config/aarch64/aarch64-sve.md (mov<SVE_ALL:mode>): Remove the
gen_vec_duplicate from call to aarch64_expand_mov_immediate.
(@aarch64_sve_reinterpret<mode>): New expander.
(*aarch64_sve_reinterpret<mode>): New pattern.
(@aarch64_vec_duplicate_vq<mode>_le): New pattern.
(@aarch64_vec_duplicate_vq<mode>_be): Likewise.
(*sve_ld1rq<Vesize>): Replace with...
(@aarch64_sve_ld1rq<mode>): ...this new pattern.
gcc/testsuite/
* gcc.target/aarch64/sve/init_2.c: Expect ld1rd to be used
instead of a full vector load.
* gcc.target/aarch64/sve/init_4.c: Likewise.
* gcc.target/aarch64/sve/ld1r_2.c: Remove constants that no longer
need to be loaded from memory.
* gcc.target/aarch64/sve/slp_2.c: Expect the same output for
big and little endian.
* gcc.target/aarch64/sve/slp_3.c: Likewise. Expect 3 of the
doubles to be moved via integer registers rather than loaded
from memory.
* gcc.target/aarch64/sve/slp_4.c: Likewise but for 4 doubles.
* gcc.target/aarch64/sve/spill_4.c: Expect 16-bit constants to be
loaded via an integer register rather than from memory.
* gcc.target/aarch64/sve/const_1.c: New test.
* gcc.target/aarch64/sve/const_2.c: Likewise.
* gcc.target/aarch64/sve/const_3.c: Likewise.
From-SVN: r274375
Wilco Dijkstra [Tue, 13 Aug 2019 10:39:22 +0000 (10:39 +0000)]
[AArch64] Increase default function alignment
With -mcpu=generic the function alignment is currently 8, however almost all
supported cores prefer 16 or higher, so increase the default to 16:12.
This gives ~0.2% performance increase on SPECINT2017, while codesize is 0.12%
larger.
gcc/
* config/aarch64/aarch64.c (generic_tunings): Set function alignment to
16:12.
From-SVN: r274374
Jozef Lawrynowicz [Tue, 13 Aug 2019 10:31:17 +0000 (10:31 +0000)]
MSP430: Read MCU data from external file
gcc/ChangeLog:
2019-08-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* config/msp430/driver-msp430.c (msp430_set_driver_var): New.
* config/msp430/msp430-devices.c (canonicalize_path_dirsep): New.
(msp430_check_path_for_devices): New.
(parse_devices_csv_1): New.
(parse_devices_csv): New.
(msp430_extract_mcu_data): Try to find devices.csv and search for the
MCU data in devices.csv before using the hard-coded data.
Warn if devices.csv isn't found and the MCU wasn't found in the
hard-coded data either.
* config/msp430/msp430.h (DRIVER_SELF_SPECS): Call
msp430_set_driver_var for -mno-warn-devices-csv and -mdevices-csv-loc.
Search for devices.csv on -I and -L paths.
(EXTRA_SPEC_FUNCTIONS): Add msp430_check_path_for_devices and
msp430_set_driver_var.
* config/msp430/msp430.opt: Add -mwarn-devices-csv and
-mdevices-csv-loc=.
* doc/invoke.texi (-mmcu): Document that -I and -L paths are
searched for devices.csv.
(mwarn-devices-csv): Document option.
gcc/testsuite/ChangeLog:
2019-08-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* gcc.target/msp430/msp430.exp (msp430_device_permutations_runtest):
Handle csv-* and bad-devices-* tests.
* gcc.target/msp430/devices/README: Document how bad-devices-* tests
work.
* gcc.target/msp430/devices/bad-devices-1.c: New test.
* gcc.target/msp430/devices/bad-devices-2.c: Likewise.
* gcc.target/msp430/devices/bad-devices-3.c: Likewise.
* gcc.target/msp430/devices/bad-devices-4.c: Likewise.
* gcc.target/msp430/devices/bad-devices-5.c: Likewise.
* gcc.target/msp430/devices/bad-devices-6.c: Likewise.
* gcc.target/msp430/devices/csv-device-order.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_00.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_01.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_02.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_04.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_08.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_10.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_11.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_12.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_14.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_18.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_20.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_21.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_22.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_24.c: Likewise.
* gcc.target/msp430/devices/csv-msp430_28.c: Likewise.
* gcc.target/msp430/devices/csv-msp430fr5969.c: Likewise.
* gcc.target/msp430/devices/hard-foo.c: Likewise.
* gcc.target/msp430/devices/bad-devices-1.csv: New test support file.
* gcc.target/msp430/devices/bad-devices-2.csv: Likewise.
* gcc.target/msp430/devices/bad-devices-3.csv: Likewise.
* gcc.target/msp430/devices/bad-devices-4.csv: Likewise.
* gcc.target/msp430/devices/bad-devices-5.csv: Likewise.
* gcc.target/msp430/devices/bad-devices-6.csv: Likewise.
* gcc.target/msp430/devices/devices.csv: Likewise.
From-SVN: r274373
Richard Sandiford [Tue, 13 Aug 2019 10:21:37 +0000 (10:21 +0000)]
[AArch64] Use simd_immediate_info for SVE predicate constants
This patch makes predicate constants use the normal simd_immediate_info
machinery, rather than treating PFALSE and PTRUE as special cases.
This makes it easier to add other types of predicate constant later.
2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64-protos.h (aarch64_output_ptrue): Delete.
* config/aarch64/aarch64-sve.md (*aarch64_sve_mov<PRED_ALL:mode>):
Use a single Dn alternative instead of separate Dz and Dm
alternatives. Use aarch64_output_sve_move_immediate.
* config/aarch64/aarch64.c (aarch64_sve_element_int_mode): New
function.
(aarch64_simd_valid_immediate): Fill in the simd_immediate_info
for predicates too.
(aarch64_output_sve_mov_immediate): Handle predicate modes.
(aarch64_output_ptrue): Delete.
From-SVN: r274372
Richard Sandiford [Tue, 13 Aug 2019 10:18:28 +0000 (10:18 +0000)]
[AArch64] Make simd_immediate_info INDEX explicit
This patch tweaks the representation of SVE INDEX instructions in
simd_immediate_info so that it's easier to add new types of
constant on top.
2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64.c (simd_immediate_info::insn_type): Add
INDEX.
(simd_immediate_info::value, simd_immediate_info::step)
(simd_immediate_info::modifier, simd_immediate_info::shift): Replace
with...
(simd_immediate_info::u): ...this new union.
(simd_immediate_info::simd_immediate_info): Update accordingly.
(aarch64_output_simd_mov_immediate): Likewise.
(aarch64_output_sve_mov_immediate): Likewise.
From-SVN: r274371
Jozef Lawrynowicz [Tue, 13 Aug 2019 10:05:53 +0000 (10:05 +0000)]
MSP430: Consolidate handling of hard-coded MCU data
gcc/ChangeLog:
2019-08-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* gcc/config.gcc (msp430*-*-*): Add msp430-devices.o to extra_objs and
extra_gcc_objs.
* gcc/config/msp430/driver-msp430.c: Remove msp430_mcu_data.
(msp430_select_cpu): New spec function.
(msp430_select_hwmult_lib): Use msp430_extract_mcu_data to extract
MCU data.
* gcc/config/msp430/msp430-devices.c: New file.
* gcc/config/msp430/msp430-devices.h: New file.
* gcc/config/msp430/msp430.c: Remove msp430_mcu_data.
(msp430_option_override): Use msp430_extract_mcu_data to extract
MCU data.
(msp430_use_f5_series_hwmult): Likewise.
(use_32bit_hwmult): Likewise.
(msp430_no_hwmult): Likewise.
* gcc/config/msp430/msp430.h (ASM_SPEC): Don't pass -mmcu to the
assembler.
(DRIVER_SELF_SPECS): Call msp430_select_cpu if -mmcu is used without
and -mcpu option.
(EXTRA_SPEC_FUNCTIONS): Add msp430_select_cpu.
* gcc/config/msp430/t-msp430: Add rule to build msp430-devices.o.
Remove hard-coded MCU multilib data.
gcc/testsuite/ChangeLog:
2019-08-13 Jozef Lawrynowicz <jozef.l@mittosystems.com>
* gcc.target/msp430/msp430.exp
(check_effective_target_msp430_430_selected): New.
(check_effective_target_msp430_430x_selected): New.
(check_effective_target_msp430_mlarge_selected): New.
(check_effective_target_msp430_hwmul_not_none): New.
(check_effective_target_msp430_hwmul_not_16bit): New.
(check_effective_target_msp430_hwmul_not_32bit): New.
(check_effective_target_msp430_hwmul_not_f5): New.
(msp430_get_opts): New.
(msp430_device_permutations_runtest): New.
* gcc.target/msp430/devices/README: New file.
* gcc.target/msp430/devices-main.c: New test.
* gcc.target/msp430/devices/hard-
cc430f5123.c: Likewise.
* gcc.target/msp430/devices/hard-foo.c: Likewise.
* gcc.target/msp430/devices/hard-msp430afe253.c: Likewise.
* gcc.target/msp430/devices/hard-msp430cg4616.c: Likewise.
* gcc.target/msp430/devices/hard-msp430f4783.c: Likewise.
* gcc.target/msp430/devices/hard-rf430frl154h_rom.c: Likewise.
From-SVN: r274370
Richard Sandiford [Tue, 13 Aug 2019 09:50:35 +0000 (09:50 +0000)]
[AArch64] Make aarch64_classify_vector_mode use a switch statement
aarch64_classify_vector_mode used properties of a mode to test whether
the mode was a single Advanced SIMD vector, a single SVE vector, or a
tuple of SVE vectors. That works well for current trunk and is simpler
than checking for modes by name.
However, for the ACLE and for planned autovec improvements, we also
need partial SVE vector modes that hold:
- half of the available 32-bit elements
- a half or quarter of the available 16-bit elements
- a half, quarter, or eighth of the available 8-bit elements
These should be packed in memory and unpacked in registers. E.g.
VNx2SI has half the number of elements of VNx4SI, and so is half the
size in memory. When stored in registers, each VNx2SI element occupies
the low 32 bits of a VNx2DI element, with the upper bits being undefined.
The upshot is that:
GET_MODE_SIZE (VNx4SImode) == 2 * GET_MODE_SIZE (VNx2SImode)
since GET_MODE_SIZE must always be the memory size. This in turn means
that for fixed-length SVE, some partial modes can have the same size as
Advanced SIMD modes. We then need to be specific about which mode we're
dealing with.
This patch prepares for that by switching based on the mode instead
of querying properties.
A later patch makes sure that Advanced SIMD modes always win over
partial SVE vector modes in normal queries.
2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/aarch64.c (aarch64_classify_vector_mode): Switch
based on the mode instead of testing properties of it.
From-SVN: r274368
Richard Sandiford [Tue, 13 Aug 2019 09:49:36 +0000 (09:49 +0000)]
[AArch64] Add a "y" constraint for V0-V7
Some indexed SVE FCMLA operations have a 3-bit register field that
requires one of Z0-Z7. This patch adds a public "y" constraint for that.
The patch also documents "x", which is again intended to be a public
constraint.
2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* doc/md.texi: Document the x and y constraints for AArch64.
* config/aarch64/aarch64.h (FP_LO8_REGNUM_P): New macro.
(FP_LO8_REGS): New reg_class.
(REG_CLASS_NAMES, REG_CLASS_CONTENTS): Add an entry for FP_LO8_REGS.
* config/aarch64/aarch64.c (aarch64_hard_regno_nregs)
(aarch64_regno_regclass, aarch64_class_max_nregs): Handle FP_LO8_REGS.
* config/aarch64/predicates.md (aarch64_simd_register): Use
FP_REGNUM_P instead of checking the classes manually.
* config/aarch64/constraints.md (y): New constraint.
gcc/testsuite/
* gcc.target/aarch64/asm-x-constraint-1.c: New test.
* gcc.target/aarch64/asm-y-constraint-1.c: Likewise.
From-SVN: r274367
Richard Sandiford [Tue, 13 Aug 2019 09:38:39 +0000 (09:38 +0000)]
[AArch64] Make <perm_insn> the complete mnemonic
The Advanced SIMD and SVE permute patterns both split the permute
operation into a base name and a hilo suffix. That works well, but it
means that for "@" patterns, we need to pass the permute code twice,
once for the base name and once for the suffix.
Having a unified name avoids that and also makes the definitions
slightly simpler.
2019-08-13 Richard Sandiford <richard.sandiford@arm.com>
gcc/
* config/aarch64/iterators.md (perm_insn): Include the "1"/"2" suffix.
(perm_hilo): Remove UNSPEC_ZIP*, UNSEPC_TRN* and UNSPEC_UZP*.
* config/aarch64/aarch64-simd.md
(aarch64_<PERMUTE:perm_insn><PERMUTE:perm_hilo><mode>): Rename to..
(aarch64_<PERMUTE:perm_insn><mode>): ...this and remove perm_hilo
from the asm template.
* config/aarch64/aarch64-sve.md
(aarch64_<perm_insn><perm_hilo><PRED_ALL:mode>): Rename to..
(aarch64_<perm_insn><PRED_ALL:mode>): ...this and remove perm_hilo
from the asm template.
(aarch64_<perm_insn><perm_hilo><SVE_ALL:mode>): Rename to..
(aarch64_<perm_insn><SVE_ALL:mode>): ...this and remove perm_hilo
from the asm template.
* config/aarch64/aarch64-simd-builtins.def: Update comment.
From-SVN: r274366
Janne Blomqvist [Tue, 13 Aug 2019 09:04:18 +0000 (12:04 +0300)]
PR fortran/91414 Bugfix for previous commit
Correctly fill master_seed from os_seed.
From-SVN: r274365
Janne Blomqvist [Tue, 13 Aug 2019 08:24:43 +0000 (11:24 +0300)]
PR fortran/91414: Improved PRNG
Update the PRNG from xorshift1024* to xoshiro256** by the same
author. For details see
http://prng.di.unimi.it/
and the paper at
https://arxiv.org/abs/1805.01407
Also the seeding is slightly improved, by reading only 8 bytes from
the operating system and using the simple splitmix64 PRNG to fill in
the rest of the PRNG state (as recommended by the xoshiro author),
instead of reading the entire state from the OS.
Regtested on x86_64-pc-linux-gnu, Ok for trunk?
gcc/fortran/ChangeLog:
2019-08-13 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/91414
* check.c (gfc_check_random_seed): Reduce seed_size.
* intrinsic.texi (RANDOM_NUMBER): Update to match new PRNG.
gcc/testsuite/ChangeLog:
2019-08-13 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/91414
* gfortran.dg/random_seed_1.f90: Update to match new seed size.
libgfortran/ChangeLog:
2019-08-13 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/91414
* intrinsics/random.c (prng_state): Update state struct.
(master_state): Update to match new size.
(get_rand_state): Update to match new PRNG.
(rotl): New function.
(xorshift1024star): Replace with prng_next.
(prng_next): New function.
(jump): Update for new PRNG.
(lcg_parkmiller): Replace with splitmix64.
(splitmix64): New function.
(getosrandom): Fix return value, simplify.
(init_rand_state): Use getosrandom only to get 8 bytes, splitmix64
to fill rest of state.
(random_r4): Update to new function and struct names.
(random_r8): Likewise.
(random_r10): Likewise.
(random_r16): Likewise.
(arandom_r4): Liekwise.
(arandom_r8): Likewise.
(arandom_r10): Likwewise.
(arandom_r16): Likewise.
(xor_keys): Reduce size to match new PRNG.
(random_seed_i4): Update to new function and struct names, remove
special handling of variable p used in previous PRNG.
(random_seed_i8): Likewise.
From-SVN: r274361
Eric Botcazou [Tue, 13 Aug 2019 08:08:52 +0000 (08:08 +0000)]
[Ada] Remove unused component in record type
The component has been unused for a while. No functional changes.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* ali.ads (Linker_Option_Record): Remove Original_Pos component.
* ali.adb (Scan_ALI): Do not set it.
From-SVN: r274360
Eric Botcazou [Tue, 13 Aug 2019 08:08:47 +0000 (08:08 +0000)]
[Ada] Build full derivation for private concurrent type
This extends the processing done for the derivation of private
discriminated types to concurrent types, which is now required because
this derivation is no longer redone when a subtype of the derived
concurrent type is built.
This increases the number of entities generated internally in the
compiler but this case is sufficiently rare as not to be a real concern.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_ch3.adb (Build_Derived_Concurrent_Type): Add a couple of
local variables and use them. When the derived type fully
constrains the parent type, rewrite it as a subtype of an
implicit (unconstrained) derived type instead of the other way
around.
(Copy_And_Build): Deal with concurrent types and use predicates.
(Build_Derived_Private_Type): Build the full derivation if
needed for concurrent types too.
(Build_Derived_Record_Type): Add marker comment.
(Complete_Private_Subtype): Use predicates.
gcc/testsuite/
* gnat.dg/discr56.adb, gnat.dg/discr56.ads,
gnat.dg/discr56_pkg1.adb, gnat.dg/discr56_pkg1.ads,
gnat.dg/discr56_pkg2.ads: New testcase.
From-SVN: r274359
Ed Schonberg [Tue, 13 Aug 2019 08:08:40 +0000 (08:08 +0000)]
[Ada] Legality rule on ancestors of type extensions in generic bodies
This patch adds an RM reference for the rule that in a generic body a
type extension cannot have ancestors that are generic formal types. The
patch also extends the check to interface progenitors that may appear in
a derived type declaration or private extension declaration.
2019-08-13 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch3.adb (Check_Generic_Ancestor): New subprogram,
aubsidiary to Build_Derived_Record_Type. to enforce the rule
that a type extension declared in a generic body cznnot have an
ancestor that is a generic formal (RM 3.9.1 (4/2)). The rule
applies to all ancestors of the type, including interface
progenitors.
gcc/testsuite/
* gnat.dg/tagged4.adb: New testcase.
From-SVN: r274358
Eric Botcazou [Tue, 13 Aug 2019 08:08:32 +0000 (08:08 +0000)]
[Ada] Fix spurious instantiation error on private record type
This change was initially aimed at fixing a spurious instantiation error
due to a disambiguation issue which happens when a generic unit with two
formal type parameters is instantiated on a single actual type that is
private.
The compiler internally sets the Is_Generic_Actual_Type flag on the
actual subtypes built for the instantiation in order to ease the
disambiguation, but it would fail to set it on the full view if the
subtypes are private. The change makes it so that the flag is properly
set and reset on the full view in this case.
But this uncovered an issue in Subtypes_Statically_Match, which was
relying on a stalled Is_Generic_Actual_Type flag set on a full view
outside of the instantiation to return a positive answer. This bypass
was meant to solve an issue arising with a private discriminated record
type whose completion is a discriminated record type itself derived from
a private discriminated record type, which is used as actual type in an
instantiation in another unit, and the instantiation is used in a child
unit of the original unit. In this case, the private and full views of
the generic actual type are swapped in the child unit, but there was a
mismatch between the chain of full and underlying full views of the
private discriminated record type and that of the generic actual type.
This secondary issue is solved by avoiding to skip the full view in the
preparation of the completion of the private subtype and by directly
constraining the underlying full view of the full view of the base type
instead of building an underlying full view from scratch.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_ch3.adb (Build_Underlying_Full_View): Delete.
(Complete_Private_Subtype): Do not set the full view on the
private subtype here. If the full base is itself derived from
private, do not re-derive the parent type but instead constrain
an existing underlying full view.
(Prepare_Private_Subtype_Completion): Do not get to the
underlying full view, if any. Set the full view on the private
subtype here.
(Process_Full_View): Likewise.
* sem_ch12.adb (Check_Generic_Actuals): Also set
Is_Generic_Actual_Type on the full view if the type of the
actual is private.
(Restore_Private_Views): Also reset Is_Generic_Actual_Type on
the full view if the type of the actual is private.
* sem_eval.adb (Subtypes_Statically_Match): Remove bypass for
generic actual types.
gcc/testsuite/
* gnat.dg/generic_inst10.adb, gnat.dg/generic_inst10_pkg.ads:
New testcase.
From-SVN: r274357
Javier Miranda [Tue, 13 Aug 2019 08:08:27 +0000 (08:08 +0000)]
[Ada] Wrong dispatching call in type with aspect Implicit_Dereference
When a record type with an an access to class-wide type discriminant
has aspect Implicit_Dereference, and the discriminant is used as the
controlling argument of a dispatching call, the compiler may generate
wrong code to dispatch the call.
2019-08-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Selected_Component): When the type of the
component is an access to a class-wide type and the type of the
context is an access to a tagged type the relevant type is that
of the component (since in such case we may need to generate
implicit type conversions or dispatching calls).
gcc/testsuite/
* gnat.dg/tagged3.adb, gnat.dg/tagged3_pkg.adb,
gnat.dg/tagged3_pkg.ads: New testcase.
From-SVN: r274356
Ed Schonberg [Tue, 13 Aug 2019 08:08:22 +0000 (08:08 +0000)]
[Ada] Do not remove side-effects in an others_clause with function calls
An aggregate can be handled by the backend if it consists of static
constants of an elementary type, or null. If a component is a type
conversion we must preanalyze and resolve it to determine whether the
ultimate value is in one of these categories. Previously we did a full
analysis and resolution of the expression for the component, which could
lead to a removal of side-effects, which is semantically incorrect if
the expression includes functions with side-effects (e.g. a call to a
random generator).
2019-08-13 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_aggr.adb (Aggr_Assignment_OK_For_Backend): Preanalyze
expression, rather do a full analysis, to prevent unwanted
removal of side effects which mask the intent of the expression.
gcc/testsuite/
* gnat.dg/aggr27.adb: New testcase.
From-SVN: r274355
Eric Botcazou [Tue, 13 Aug 2019 08:08:15 +0000 (08:08 +0000)]
[Ada] Add GNAT.Branch_Prediction to Impunit
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* impunit.adb (Non_Imp_File_Names_95): Add
GNAT.Branch_Prediction.
From-SVN: r274354
Eric Botcazou [Tue, 13 Aug 2019 08:08:11 +0000 (08:08 +0000)]
[Ada] Small cleanup and improvement in inlining machinery
This is a small cleanup in the inlining machinery of the front-end
dealing with back-end inlining. It should save a few cycles at -O0 by
stopping it from doing useless work. No functional changes.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch6.adb: Remove with and use clauses for Sem_Ch12.
(Expand_Call_Helper): Swap the back-end inlining case and the
special front-end expansion case. In back-end inlining mode, do
not invoke Add_Inlined_Body unless the call may be inlined.
* inline.ads (Add_Pending_Instantiation): New function moved
from...
* inline.adb (Add_Inlined_Body): Simplify comment. Turn test on
the enclosing unit into assertion.
(Add_Pending_Instantiation): New function moved from...
* sem_ch12.ads (Add_Pending_Instantiation): ...here.
* sem_ch12.adb (Add_Pending_Instantiation): ...here.
From-SVN: r274353
Eric Botcazou [Tue, 13 Aug 2019 08:08:06 +0000 (08:08 +0000)]
[Ada] Fix bogus style check failure with pragma Style_Checks (Off)
This fixes a bogus style check failure for long lines in rare cases
where the compiler is invoked, with a -gnatyX switch where X is neither
'm' nor 'M', on a unit which contains "with" clauses for other units
that contain a pragma Style_Checks (Off).
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem.adb (Do_Analyze): Recompute Style_Check_Max_Line_Length
after restoring Style_Max_Line_Length.
From-SVN: r274352
Arnaud Charlet [Tue, 13 Aug 2019 08:08:01 +0000 (08:08 +0000)]
[Ada] Protect analysis of Indexing aspect against cascaded errors
2019-08-13 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* sem_ch13.adb (Check_Iterator_Functions): Protect against
cascaded errors.
From-SVN: r274351
Ed Schonberg [Tue, 13 Aug 2019 08:07:56 +0000 (08:07 +0000)]
[Ada] Add conformance check on actual subp. in instance of child unit
This patch properly diagnoses a conformance error between a formal
subprogram and the corresponding actual, when the instance is that of a
child unit that is instantiated as a compilation unit. The error is
normally suppressed on an instantiation nested within another generic,
given that analysis of the enclosing generic will have performed the
conformance check on the nested instance already. In the case of a
child unit, its instantiation requires an explicit check if it is a
compilation unit, because it has not been analyzed in the context of the
parent generic.
Compiling test.adb must yield:
container-list.ads:3:01: instantiation error at new_container_g-list_g.ads:12
container-list.ads:3:01: not mode conformant with declaration at types.ads:5
container-list.ads:3:01: mode of "Self" does not match
----
with New_Container_G.List_G;
pragma Elaborate_All (New_Container_G.List_G);
package Container.List is new Container.List_G (Init => Types.Init_Object);
with Types;
with Erreur;
with New_Container_G;
pragma Elaborate_All (New_Container_G);
package Container is new New_Container_G (
Element_T => Types.Integer_T,
Pos_Range_T => Types.Integer_Idx_T,
Container_Name => Erreur.None);
package Erreur is
type Container_Name_T is (None, Everything);
end;
----
package body New_Container_G.List_G is
function Get_Element_At_Pos
(Self : access List_T;
Pos : in Index_Range_T)
return Element_Ptr is
begin
if not Self.T_Status (Pos) then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Element_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Get_Element_Ptr_At_Pos,
Context => Erreur.Null_Context_C);
end if;
return Pos;
end Get_Element_At_Pos;
function Get_Element_At_Pos
(Self : in List_T;
Pos : in Index_Range_T)
return Element_T is
begin
if not Self.T_Status (Pos) then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Element_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Get_Element_At_Pos,
Context => Erreur.Null_Context_C);
end if;
return Self.Data (Pos);
end Get_Element_At_Pos;
procedure Add_New
(Self : in out List_T;
Pos : out Pos_Range_T) is
Free_Found : Boolean := False;
begin
if Self.First_Free = Rbc_Constants.Null_Pos then
Pos := Rbc_Constants.Null_Pos;
else
Self.Size := Self.Size + 1;
Self.T_Status (Self.First_Free) := True;
Pos := Self.First_Free;
Init (Self.Data (Pos));
if Self.First_Relevant not in
Rbc_Constants.Null_Pos + 1 .. Self.First_Free
then
Self.First_Relevant := Self.First_Free;
end if;
while not (Free_Found or Self.First_Free = Rbc_Constants.Null_Pos) loop
if Self.First_Free = Pos_Range_T'Last then
Self.First_Free := Rbc_Constants.Null_Pos;
else
Self.First_Free := Self.First_Free + 1;
if not Self.T_Status (Self.First_Free) then
Free_Found := True;
end if;
end if;
end loop;
end if;
end Add_New;
procedure Add_New_At_Pos
(Self : in out List_T;
Pos : in out Index_Range_T) is
Free_Found : Boolean := False;
begin
if Self.T_Status (Pos) then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Element_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Add_New_At_Pos,
Context => Erreur.Null_Context_C);
else
Self.Size := Self.Size + 1;
Self.T_Status (Pos) := True;
Init (Self.Data (Pos));
if Self.First_Relevant = Rbc_Constants.Null_Pos
or Pos < Self.First_Relevant
then
Self.First_Relevant := Pos;
end if;
if Self.First_Free = Pos
then
-- Look for a new First_Free
while not (Free_Found or Self.First_Free = Rbc_Constants.Null_Pos) loop
if Self.First_Free = Pos_Range_T'Last then
Self.First_Free := Rbc_Constants.Null_Pos;
else
Self.First_Free := Self.First_Free + 1;
if not Self.T_Status (Self.First_Free) then
Free_Found := True;
end if;
end if;
end loop;
end if;
-------------------------------------------------------------------------
end if;
end Add_New_At_Pos;
procedure Clear (Self : out List_T) is
begin
Self.T_Status := (others => False);
Self.First_Free := Init_First_Free;
Self.First_Relevant := Rbc_Constants.Null_Pos;
Self.Size := Empty;
end Clear;
procedure Remove_Element_At_Pos
(Self : in out List_T;
Pos : in Index_Range_T) is
Relevant_Found : Boolean := False;
begin
-- REMOVE ITEM IF VALID ---------------------------------------------
if not Self.T_Status (Pos) then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Element_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Remove_Element_At_Pos,
Context => Erreur.Null_Context_C);
end if;
Self.Size := Self.Size - 1;
Self.T_Status (Pos) := False;
if Self.First_Free not in Rbc_Constants.Null_Pos + 1 .. Pos then
Self.First_Free := Pos;
end if;
-- UPDATE FIRST_RELEVANT IF NECESSARY -----------------------------------
if Self.First_Relevant = Pos then
while
not (Relevant_Found or Self.First_Relevant = Rbc_Constants.Null_Pos)
loop
if Self.First_Relevant = Pos_Range_T'Last then
Self.First_Relevant := Rbc_Constants.Null_Pos;
else
Self.First_Relevant := Self.First_Relevant + 1;
if Self.T_Status (Self.First_Relevant) then
Relevant_Found := True;
end if;
end if;
end loop;
end if;
-------------------------------------------------------------------------
end Remove_Element_At_Pos;
procedure Next
(It : in out Iterator_T;
Self : in List_T) is
Relevant_Found : Boolean := False;
begin
if It = Rbc_Constants.Null_Pos then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Iterator_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Next,
Context => Erreur.Null_Context_C);
end if;
while not (Relevant_Found or It = Rbc_Constants.Null_Pos) loop
if It = Pos_Range_T'Last then
It := Rbc_Constants.Null_Pos;
else
It := It + 1;
if Self.T_Status (It) then
Relevant_Found := True;
end if;
end if;
end loop;
end Next;
function New_Iterator
(Self : in List_T)
return Iterator_T is
begin
return Self.First_Relevant;
end New_Iterator;
function Get
(It : in Iterator_T;
Self : in List_T)
return Element_Ptr is
begin
if It = Rbc_Constants.Null_Pos or else not Self.T_Status (It) then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Iterator_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Get_Ptr,
Context => Erreur.Null_Context_C);
end if;
return It;
end Get;
function Get
(It : in Iterator_T;
Self : in List_T)
return Element_T is
begin
if It = Rbc_Constants.Null_Pos or else not Self.T_Status (It) then
Erreur.Treat_Container_Error
(Error_Name => Erreur.Iterator_Not_Valid,
Container_Name => Container_Name,
Procedure_Name => Erreur.Get,
Context => Erreur.Null_Context_C);
end if;
return Self.Data (It);
end Get;
function Getstatus
(Self : in List_T;
Pos : in Index_Range_T)
return Boolean is
begin
return Self.T_Status (Pos);
end Getstatus;
function Init_First_Free return Pos_Range_T is
First_Free_Value : Pos_Range_T;
begin
if Full = Rbc_Constants.Null_Pos then
-- size is 0
First_Free_Value := Rbc_Constants.Null_Pos;
else
-- first free cell index is 1
First_Free_Value := Index_Range_T'First;
end if;
return First_Free_Value;
end Init_First_Free;
end New_Container_G.List_G;
with Rbc_Constants;
generic
with procedure Init (Self : out Element_T);
package New_Container_G.List_G is
type List_T is new Container_T with private;
function Get_Element_At_Pos
(Self : access List_T;
Pos : in Index_Range_T)
return Element_Ptr;
function Get_Element_At_Pos
(Self : in List_T;
Pos : in Index_Range_T)
return Element_T;
procedure Add_New
(Self : in out List_T;
Pos : out Pos_Range_T);
procedure Add_New_At_Pos
(Self : in out List_T;
Pos : in out Index_Range_T);
procedure Clear (Self : out List_T);
procedure Remove_Element_At_Pos
(Self : in out List_T;
Pos : in Index_Range_T);
procedure Next
(It : in out Iterator_T;
Self : in List_T);
function New_Iterator
(Self : in List_T)
return Iterator_T;
function Get
(It : in Iterator_T;
Self : in List_T)
return Element_Ptr;
function Get
(It : in Iterator_T;
Self : in List_T)
return Element_T;
function Getstatus
(Self : in List_T;
Pos : in Index_Range_T)
return Boolean;
private
function Init_First_Free return Pos_Range_T;
type Status_Array_T is array (Index_Range_T) of Boolean;
type List_T is new Container_T with
record
T_Status : Status_Array_T := (others => False);
First_Free : Pos_Range_T := Init_First_Free;
First_Relevant : Pos_Range_T := Rbc_Constants.Null_Pos;
end record;
end New_Container_G.List_G;
with Types_Alstom; use Types_Alstom;
with Rbc_Constants;
package body New_Container_G is
function Done
(It : in Iterator_T;
Self : in Container_T)
return Boolean is
pragma Unreferenced (Self);
Report : Boolean;
begin
if It = Rbc_Constants.Null_Pos then
Report := True;
else
Report := False;
end if;
return Report;
end Done;
procedure Execute (Self : in out Container_T'class;
This_Proc : in Proc_Access_T) is
begin
for I in Self.Data'First .. Self.Size loop
This_Proc (Self.Data (I));
end loop;
end Execute;
procedure Execute (Self : in out Container_T'class;
This_Proc : in Proc_Idx_Access_T) is
begin
for I in Self.Data'First .. Self.Size loop
This_Proc (Self.Data (I), I);
end loop;
end Execute;
function Selected_Subset
(Self : in Container_T'Class;
Ref : in Reference_T)
return Element_Set_T is
Set : Element_Set_T := (others => Rbc_Constants.Null_Pos);
Current : Pos_Range_T := 0;
begin
for I in Self.Data'Range loop
if Getstatus (Self, I) and then Is_Selected
(Elem => Self.Data (I),
Ref => Ref)
then
Current := Current + 1;
Set (Current) := I;
end if;
end loop;
return Set;
end Selected_Subset;
function Selected_Element
(Self : in Container_T'Class;
Ref : in Reference_T)
return Element_Ptr is
begin
for I in Self.Data'Range loop
if Getstatus (Self, I) and then Is_Selected
(Elem => Self.Data (I),
Ref => Ref)
then
return I;
end if;
end loop;
return Rbc_Constants.Null_Pos;
end Selected_Element;
function Getsize
(Self : in Container_T)
return Pos_Range_T is
begin
return Self.Size;
end Getsize;
end New_Container_G;
with Types;
with Erreur;
generic
-- Type of element to be stored
type Element_T is private;
type Pos_Range_T is range <>;
Container_Name : in Erreur.Container_Name_T;
package New_Container_G is
pragma Unreferenced (Container_Name);
subtype Element_Acc_T is Pos_Range_T;
subtype Element_Ptr is Element_Acc_T; -- for compatibility
subtype Iterator_T is Pos_Range_T;
subtype Index_Range_T is Pos_Range_T range 1 .. Pos_Range_T'Last;
type Element_Set_T is array (Index_Range_T) of Element_Ptr;
Full : constant Pos_Range_T := Pos_Range_T'Last;
Empty : constant Pos_Range_T := Pos_Range_T'First;
type Element_Array_T is array (Index_Range_T) of Element_T;
type Container_T is abstract tagged
record
Data : Element_Array_T;
Size : Pos_Range_T := Empty;
end record;
function Get
(It : in Iterator_T;
Self : in Container_T)
return Element_Ptr is abstract;
function Get
(It : in Iterator_T;
Self : in Container_T)
return Element_T is abstract;
procedure Next
(It : in out Iterator_T;
Self : in Container_T) is abstract;
function Done
(It : in Iterator_T;
Self : in Container_T)
return Boolean;
type Proc_Access_T is access procedure (Elem : in out Element_T);
type Proc_Idx_Access_T is access procedure (Elem : in out Element_T;
Idx : in Index_Range_T);
procedure Execute (Self : in out Container_T'class;
This_Proc : in Proc_Access_T);
procedure Execute (Self : in out Container_T'class;
This_Proc : in Proc_Idx_Access_T);
function Getstatus
(Self : in Container_T;
Pos : in Index_Range_T)
return Boolean is abstract;
generic
-- Type of the parameter of the is_selected () function.
type Reference_T is private;
with function Is_Selected
(Elem : in Element_T;
Ref : in Reference_T)
return Boolean;
function Selected_Subset
(Self : in Container_T'Class;
Ref : in Reference_T)
return Element_Set_T;
generic
-- Type of the parameter of the is_selected () function.
type Reference_T is private;
with function Is_Selected
(Elem : in Element_T;
Ref : in Reference_T)
return Boolean;
function Selected_Element
(Self : in Container_T'Class;
Ref : in Reference_T)
return Element_Ptr;
function Getsize
(Self : in Container_T)
return Pos_Range_T;
end New_Container_G;
----
package Rbc_Constants is
Null_Pos : constant := 0;
Irrelevant_Id : constant String := " ";
Nmax_Mc_Bits : constant := 32;
end Rbc_Constants;
with Ada.Text_IO;
with Types;
with Container.List;
procedure Test is
List : Container.List.List_T;
Pos : Types.Integer_Idx_T;
begin
Container.List.Add_New (Self => List,
Pos => Pos);
Ada.Text_IO.Put_Line ("no exception raised");
end Test;
package Types is
type Integer_T is range -1000 .. 1000;
type Integer_Idx_T is range 0 .. 100;
procedure Init_Object (Elem : in Integer_T);
end Types;
2019-08-13 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch8.adb (Analyze_Subprogram_Renaming): Do no suppress mode
conformance checks on child unit instance that is a compilation
unit.
From-SVN: r274350
Gary Dismukes [Tue, 13 Aug 2019 08:07:51 +0000 (08:07 +0000)]
[Ada] Do full name qualification of local exception names for LLVM
Exceptions declared within subprograms are associated with objects
allocated statically (at the global level), and it's helpful for the
LLVM compiler (and likely others, such as CCG) if the exception name is
fully qualified, to avoid link name clashes (gcc-based GNAT has always
"uniquified" these names). GNAT was using the simple name for local
exceptions (as for other local objects), but it now uses fully qualified
names for all exceptions.
When compiled with the command:
gcc -c -gnatG local_exception.adb | grep "local_exception__local_exc"
the following output is generated for the test further below:
local_exception__local_exc : static exception := (
local_exception__local_exc'unrestricted_access));
procedure Local_Exception is
Local_Exc : exception;
begin
null;
end Local_Exception;
2019-08-13 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_dbug.adb (Fully_Qualify_Name): Add full name qualification
for the E_Exception case.
From-SVN: r274349
Gary Dismukes [Tue, 13 Aug 2019 08:07:46 +0000 (08:07 +0000)]
[Ada] Compiler may blow up on array aggregates whose size is very large
The compiler may crash when compiling array aggregates where the
computation of the size produces a very large number that overflows
(possibly producing a small result), such as with an aggregate of a type
that is an array of arrays, where each array range has close to
Integer'Last elements. That can lead to Aggr_Size_OK returning
incorrectly returning True, following on to allocating a very large
array in function Flatten that blows the stack. The size computation
was being performed using type Int, so this was changed to use universal
arithmetic.
2019-08-13 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_aggr.adb (Aggr_Size_OK): Compute the aggregate size using
universal arithmetic, to avoid situations where the size
computation overflows.
gcc/testsuite/
* gnat.dg/aggr26.adb: New testcase.
From-SVN: r274348
Justin Squirek [Tue, 13 Aug 2019 08:07:41 +0000 (08:07 +0000)]
[Ada] Show Bit_Order and Scalar_Storage_Order in -gnatR4 output
This patch modifies the behavior of -gnatR4 so that representation
information for bit and scalar storage order gets displayed in all cases
and not just when defaults are overriden.
------------
-- Source --
------------
-- pkg.ads
package Pkg is
type Root is tagged record
Data0 : Integer;
end record;
type Derived is new Root with record
Data1 : Integer;
end record;
end Pkg;
-----------------
-- Compilation --
-----------------
$ gnatmake -gnatR4 pkg.ads
Representation information for unit Pkg (spec)
----------------------------------------------
for Root'Size use 128;
for Root'Alignment use 8;
for Root use record
Data0 at 8 range 0 .. 31;
end record;
for Root'Bit_Order use System.Low_Order_First;
for Root'Scalar_Storage_Order use System.Low_Order_First;
for Trootc'Size use 0;
for Trootc'Alignment use 0;
for Trootc use record
end record;
for Trootc'Bit_Order use System.Low_Order_First;
for Trootc'Scalar_Storage_Order use System.Low_Order_First;
for Derived'Size use 192;
for Derived'Alignment use 8;
for Derived use record
Data0 at 8 range 0 .. 31;
Data1 at 16 range 0 .. 31;
end record;
for Derived'Bit_Order use System.Low_Order_First;
for Derived'Scalar_Storage_Order use System.Low_Order_First;
for Tderivedc'Size use 0;
for Tderivedc'Alignment use 0;
for Tderivedc use record
Data0 at 8 range 0 .. 31;
Data1 at 16 range 0 .. 31;
end record;
for Tderivedc'Bit_Order use System.Low_Order_First;
for Tderivedc'Scalar_Storage_Order use System.Low_Order_First;i
2019-08-13 Justin Squirek <squirek@adacore.com>
gcc/ada/
* repinfo.adb (List_Scalar_Storage_Order): Modify conditionals
for displaying ordering to always be triggered when -gnatR4 is
in effect.
From-SVN: r274347
Justin Squirek [Tue, 13 Aug 2019 08:07:35 +0000 (08:07 +0000)]
[Ada] Implement pragma Max_Entry_Queue_Length
This patch implements AI12-0164-1 for the aspect/pragma
Max_Entry_Queue_Length. Previously, the GNAT specific pragma
Max_Queue_Length fulfilled this role, but was not named to match the
standard and thus was insufficent.
------------
-- Source --
------------
-- pass.ads
with System;
package Pass is
SOMETHING : constant Integer := 5;
Variable : Boolean := False;
protected type Protected_Example is
entry A (Item : Integer)
with Max_Entry_Queue_Length => 2; -- OK
entry B (Item : Integer);
pragma Max_Entry_Queue_Length (SOMETHING); -- OK
entry C (Item : Integer); -- OK
entry D (Item : Integer)
with Max_Entry_Queue_Length => 4; -- OK
entry D (Item : Integer; Item_B : Integer)
with Max_Entry_Queue_Length => Float'Digits; -- OK
entry E (Item : Integer);
pragma Max_Entry_Queue_Length (SOMETHING * 2); -- OK
entry E (Item : Integer; Item_B : Integer);
pragma Max_Entry_Queue_Length (11); -- OK
entry F (Item : Integer; Item_B : Integer);
pragma Pre (Variable = True);
pragma Max_Entry_Queue_Length (11); -- OK
entry G (Item : Integer; Item_B : Integer)
with Pre => (Variable = True),
Max_Entry_Queue_Length => 11; -- OK
private
Data : Boolean := True;
end Protected_Example;
Prot_Ex : Protected_Example;
end Pass;
-- fail.ads
package Fail is
-- Not near entry
pragma Max_Entry_Queue_Length (40); -- ERROR
-- Task type
task type Task_Example is
entry Insert (Item : in Integer)
with Max_Entry_Queue_Length => 10; -- ERROR
-- Entry family in task type
entry A (Positive) (Item : in Integer)
with Max_Entry_Queue_Length => 10; -- ERROR
end Task_Example;
Task_Ex : Task_Example;
-- Aspect applied to protected type
protected type Protected_Failure_0
with Max_Entry_Queue_Length => 50 is -- ERROR
entry A (Item : Integer);
private
Data : Integer := 0;
end Protected_Failure_0;
Protected_Failure_0_Ex : Protected_Failure_0;
protected type Protected_Failure is
pragma Max_Entry_Queue_Length (10); -- ERROR
-- Duplicates
entry A (Item : Integer)
with Max_Entry_Queue_Length => 10; -- OK
pragma Max_Entry_Queue_Length (4); -- ERROR
entry B (Item : Integer);
pragma Max_Entry_Queue_Length (40); -- OK
pragma Max_Entry_Queue_Length (4); -- ERROR
entry C (Item : Integer)
with Max_Entry_Queue_Length => 10, -- OK
Max_Entry_Queue_Length => 40; -- ERROR
-- Duplicates with the same value
entry AA (Item : Integer)
with Max_Entry_Queue_Length => 10; -- OK
pragma Max_Entry_Queue_Length (10); -- ERROR
entry BB (Item : Integer);
pragma Max_Entry_Queue_Length (40); -- OK
pragma Max_Entry_Queue_Length (40); -- ERROR
entry CC (Item : Integer)
with Max_Entry_Queue_Length => 10, -- OK
Max_Entry_Queue_Length => 10; -- ERROR
-- On subprogram
procedure D (Item : Integer)
with Max_Entry_Queue_Length => 10; -- ERROR
procedure E (Item : Integer);
pragma Max_Entry_Queue_Length (4); -- ERROR
function F (Item : Integer) return Integer
with Max_Entry_Queue_Length => 10; -- ERROR
function G (Item : Integer) return Integer;
pragma Max_Entry_Queue_Length (4); -- ERROR
-- Bad parameters
entry H (Item : Integer)
with Max_Entry_Queue_Length => 0; -- ERROR
entry I (Item : Integer)
with Max_Entry_Queue_Length => -1; -- ERROR
entry J (Item : Integer)
with Max_Entry_Queue_Length => 16#FFFF_FFFF_FFFF_FFFF_FFFF#; -- ERROR
entry K (Item : Integer)
with Max_Entry_Queue_Length => False; -- ERROR
entry L (Item : Integer)
with Max_Entry_Queue_Length => "JUNK"; -- ERROR
entry M (Item : Integer)
with Max_Entry_Queue_Length => 1.0; -- ERROR
entry N (Item : Integer)
with Max_Entry_Queue_Length => Long_Integer'(3); -- ERROR
-- Entry family
entry O (Boolean) (Item : Integer)
with Max_Entry_Queue_Length => 5; -- ERROR
private
Data : Integer := 0;
end Protected_Failure;
I : Positive := 1;
Protected_Failure_Ex : Protected_Failure;
end Fail;
-- dtest.adb
with Ada.Text_IO; use Ada.Text_IO;
procedure Dtest is
protected Prot is
entry Wait;
pragma Max_Entry_Queue_Length (2);
procedure Wakeup;
private
Barrier : Boolean := False;
end Prot;
protected body Prot is
entry Wait when Barrier is
begin
null;
end Wait;
procedure Wakeup is
begin
Barrier := True;
end Wakeup;
end Prot;
task type T;
task body T is
begin
Put_Line ("Waiting...");
Prot.Wait;
exception
when others =>
Put_Line ("Got exception");
end T;
T1, T2 : T;
begin
delay 0.1;
Prot.Wait;
Put_Line ("Done");
exception
when others =>
Put_Line ("Main got exception");
Prot.Wakeup;
end Dtest;
----------------------------
-- Compilation and output --
----------------------------
& gcc -c -g -gnatDG pass.ads
& gcc -c -g fail.ads
& grep -c "(2, 5, 0, 4, 6, 10, 11, 11, 11)" pass.ads.dg
& gnatmake -g -q dtest
fail.ads:5:04: pragma "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:12:15: aspect "Max_Entry_Queue_Length" cannot apply to task entries
fail.ads:17:15: aspect "Max_Entry_Queue_Length" cannot apply to task entries
fail.ads:26:12: aspect "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:36:07: pragma "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:42:07: pragma "Max_Entry_Queue_Length" duplicates aspect declared at
line 41
fail.ads:46:07: pragma "Max_Entry_Queue_Length" duplicates pragma declared at
line 45
fail.ads:50:15: aspect "Max_Entry_Queue_Length" for "C" previously given at
line 49
fail.ads:56:07: pragma "Max_Entry_Queue_Length" duplicates aspect declared at
line 55
fail.ads:60:07: pragma "Max_Entry_Queue_Length" duplicates pragma declared at
line 59
fail.ads:64:15: aspect "Max_Entry_Queue_Length" for "CC" previously given at
line 63
fail.ads:69:15: aspect "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:72:07: pragma "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:75:15: aspect "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:78:07: pragma "Max_Entry_Queue_Length" must apply to a protected entry
fail.ads:83:35: entity for aspect "Max_Entry_Queue_Length" must be positive
fail.ads:86:35: entity for aspect "Max_Entry_Queue_Length" must be positive
fail.ads:89:35: entity for aspect "Max_Entry_Queue_Length" out of range of
Integer
fail.ads:92:35: expected an integer type
fail.ads:92:35: found type "Standard.Boolean"
fail.ads:95:35: expected an integer type
fail.ads:95:35: found a string type
fail.ads:98:35: expected an integer type
fail.ads:98:35: found type universal real
2019-08-13 Justin Squirek <squirek@adacore.com>
gcc/ada/
* aspects.adb, aspects.ads: Register new aspect.
* par-prag.adb (Prag): Register new pragma
* sem_ch13.adb (Analyze_Aspect_Specifications): Add processing
for new aspect similar to Aspect_Max_Entry_Queue_Length.
* sem_prag.adb, sem_prag.ads (Analyze_Pragma): Register new
pragma and set it to use the same processing as
Pragma_Max_Queue_Length.
* snames.ads-tmpl: Move definition of
Name_Max_Entry_Queue_Length so that it can be processed as a
pragma in addition to a restriction and add an entry for the
pragma itself.
From-SVN: r274346
Yannick Moy [Tue, 13 Aug 2019 08:07:29 +0000 (08:07 +0000)]
[Ada] Avoid crash in GNATprove_Mode on allocator inside type
In the special mode for GNATprove, subtypes should be declared for
allocators when constraints are used. This was done previously but it
does not work inside spec expressions, as the declaration is not
inserted and analyzed in the AST in that case, leading to a later crash
on an incomplete entity. Thus, no declaration should be created in such
a case, letting GNATprove later reject such code due to the use of an
allocator in an interfering context.
2019-08-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_ch4.adb (Analyze_Allocator): Do not insert subtype
declaration for allocator inside a spec expression.
gcc/testsuite/
* gnat.dg/allocator2.adb, gnat.dg/allocator2.ads: New testcase.
From-SVN: r274345
Yannick Moy [Tue, 13 Aug 2019 08:07:24 +0000 (08:07 +0000)]
[Ada] Avoid crash in GNATprove due to inlining inside type
The special inlining for GNATprove should not inline calls inside record
types, used for the constraints of components.
There is no impact on compilation.
2019-08-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Call): Do not inline calls inside record
types.
From-SVN: r274344
Eric Botcazou [Tue, 13 Aug 2019 08:07:18 +0000 (08:07 +0000)]
[Ada] Spurious error on nested instantiation
This fixes a spurious error given by the compiler for a call to a
subprogram which is the formal subprogram parameter of a generic
package, if the generic package is instantiated in the body of an
enclosing generic package with two formal types and two formal
subprogram parameter homonyms taking them, and this instantiation takes
one the two formal types as actual, and the enclosing generic package is
instantiated on the same actual type with a single actual subprogram
parameter, and the aforementioned call is overloaded.
In this case, the renaming generated for the actual subprogram parameter
in the nested instantiation is ambiguous and must be disambiguated using
the corresponding formal parameter of the enclosing instantiation,
otherwise a (sub)type mismatch is created and later subprogram
disambiguation is not really possible.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_ch4.adb (Analyze_One_Call): Remove bypass for type
mismatch in nested instantiations.
* sem_ch8.adb (Find_Nearer_Entity): New function.
(Find_Renamed_Entity): Use it to disambiguate the candidates for
the renaming generated for an instantiation when it is
ambiguous.
gcc/testsuite/
* gnat.dg/generic_inst9.adb, gnat.dg/generic_inst9.ads,
gnat.dg/generic_inst9_pkg1-operator.ads,
gnat.dg/generic_inst9_pkg1.ads, gnat.dg/generic_inst9_pkg2.adb,
gnat.dg/generic_inst9_pkg2.ads: New testcase.
From-SVN: r274343
Eric Botcazou [Tue, 13 Aug 2019 08:07:13 +0000 (08:07 +0000)]
[Ada] Do not set Back_End_Inlining in ASIS mode
No impact on compilation.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gnat1drv.adb (Adjust_Global_Switches): Do not set
Back_End_Inlining in ASIS mode either.
From-SVN: r274342
Olivier Hainque [Tue, 13 Aug 2019 08:07:08 +0000 (08:07 +0000)]
[Ada] Fix incorrect binding to MapViewOfFile in s-win32.ads
Despite the "dw" prefix on the name, the dwNumberOfBytesToMap argument
to MapViewOfFile was changed from DWORD to SIZE_T when 64bit Windows
came about.
This change adjusts the binding we have for it in System.Win32
accordingly. For consistency with established practice, an s-win32
specific version of size_t is introduced and g-sercom__mingw.adb is
adjusted to disambiguate between this new size_t and the one already
exposed in System.CRTL.
2019-08-13 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* libgnat/s-win32.ads: Define size_t and fix the MapViewOfFile
binding to use it instead of DWORD for the dwNumberOfBytesToMap
argument.
* libgnat/g-sercom__mingw.adb (Read): State which definition of
size_t to fetch in call to Last_Index.
From-SVN: r274341
Arnaud Charlet [Tue, 13 Aug 2019 08:07:03 +0000 (08:07 +0000)]
[Ada] Systematically pass LN_S to relevant gnatlib targets
2019-08-13 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* gcc-interface/Make-lang.in: Remove unused TRACE variable. Pass
LN_S to relevant gnatlib targets.
* gcc-interface/Makefile.in: Systematically pass LN_S to
relevant gnatlib targets.
From-SVN: r274340
Yannick Moy [Tue, 13 Aug 2019 08:06:55 +0000 (08:06 +0000)]
[Ada] Avoid spurious errors on dimensionality checking in GNATprove
Complete the partial treatment that was started in r273405. Instead of
checking for the special case of nodes inside inlined bodies at the call
site, check for this condition inside the top-level procedures called
for dimensionality checking.
There is no impact on compilation.
2019-08-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_dim.adb (Analyze_Dimension,
Analyze_Dimension_Array_Aggregate, Analyze_Dimension_Call,
Analyze_Dimension_Extension_Or_Record_Aggregate): Return
immediately when inside an inlined body.
* sem_res.adb (Resolve_Call): Remove special checking now done
inside Analyze_Dimension_Call.
From-SVN: r274339
Justin Squirek [Tue, 13 Aug 2019 08:06:50 +0000 (08:06 +0000)]
[Ada] Disable anonymous allocator warning for library-level objects
This patch modifies the behavior of anonymous allocator warnings so that
they no longer get triggered in the case of an object declaration at
library-level.
2019-08-13 Justin Squirek <squirek@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Allocator): Add condition to detect
library-level object declarations
gcc/testsuite/
* gnat.dg/anon3.adb, gnat.dg/anon3.ads: New testcase.
From-SVN: r274338
Eric Botcazou [Tue, 13 Aug 2019 08:06:44 +0000 (08:06 +0000)]
[Ada] Add/fix documentation for the Double_*_Alignment parameters
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* doc/gnat_ugn/building_executable_programs_with_gnat.rst
(-gnateT): Document Double_Float_Alignment parameter and fix
description of Double_Scalar_Alignment parameter.
* gnat_ugn.texi: Regenerate.
From-SVN: r274337
Eric Botcazou [Tue, 13 Aug 2019 08:06:39 +0000 (08:06 +0000)]
[Ada] Fix spurious error on nested instantiation with inlining
This prevents the compiler from issuing a spurious error in a convoluted
case where a child generic package declared in an enclosing parent
generic package, which contains a second child generic package, contains
an inlined subprogram and the second child generic package contains an
instantiation of the first, and the enclosing parent generic package is
instantiated with inlining across units enabled (-gnatn[12]).
The problem is that the compiler attempts to instantiate the body of the
first child generic package in the context of the enclosing parent
generic package, instead of doing it in the context of the instantiation
of the parent generic package, because of the presence of the inlined
subprogram.
2019-08-13 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch6.adb (Expand_Call_Helper): If back-end inlining is
enabled, also instantiate the body of a generic unit containing
a subprogram subject to aspect/pragma Inline_Always at
optimization level zero.
* sem_ch12.adb (Might_Inline_Subp): Minor tweak.
(Analyze_Package_Instantiation): Do not instantiate the package
body because of inlining considerations if the instantiation is
done in a generic unit. Move around similar condition involving
the main unit. Add test on Back_End_Inlining to processing for
front-end inlining.
gcc/testsuite/
* gnat.dg/generic_inst8.adb, gnat.dg/generic_inst8.ads,
gnat.dg/generic_inst8_g.adb, gnat.dg/generic_inst8_g.ads: New
testcase.
From-SVN: r274336
Javier Miranda [Tue, 13 Aug 2019 08:06:34 +0000 (08:06 +0000)]
[Ada] Wrong initialization of Offset_To_Top in secondary DT
The compiler does not initialize well the runtime information required
to perform at runtime interface conversions on derivations of tagged
types that implement interfaces and have variable size components.
2019-08-13 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_disp.adb (Make_Secondary_DT): Handle record type
derivations that have interface components located at fixed
positions and interface components located at variable offset.
The offset of components located at fixed positions is computed
using the dummy object (similar to the case where all the
interface components are located at fixed positions).
(Make_DT): Build the dummy object for all tagged types that
implement interface types (that is, build it also for types with
variable size components), and use the dummy object to compute
the offset of all tag components located at fixed positions when
initializing the Interface_Table object.
gcc/testsuite/
* gnat.dg/tag2.adb, gnat.dg/tag2_pkg.ads: New testcase.
From-SVN: r274335
Justin Squirek [Tue, 13 Aug 2019 08:06:29 +0000 (08:06 +0000)]
[Ada] Add ability to list compiler switches with gnatcmd
This patch adds a new switch (--help-ada) to gnatcmd for displaying all
the availible build flags as well as fixing some minor differences in
output between implicit and explicit help for gnatcmd (e.g. "gnat" vs
"gnat --help").
$ gnat
GNAT Pro 20.0w (
19940713)
Copyright 1996-2019, Free Software Foundation, Inc.
To list Ada build switches use --help-ada
List of available commands
gnat bind gnatbind
gnat chop gnatchop
gnat clean gnatclean
gnat compile gnatmake -f -u -c
gnat check gnatcheck
gnat elim gnatelim
gnat find gnatfind
gnat krunch gnatkr
gnat link gnatlink
gnat list gnatls
gnat make gnatmake
gnat metric gnatmetric
gnat name gnatname
gnat preprocess gnatprep
gnat pretty gnatpp
gnat stack gnatstack
gnat stub gnatstub
gnat test gnattest
gnat xref gnatxref
Report bugs to report@adacore.com
$ gnat --help
GNAT Pro 20.0w (
19940713)
Copyright 1996-2019, Free Software Foundation, Inc.
To list Ada build switches use --help-ada
List of available commands
gnat bind gnatbind
gnat chop gnatchop
gnat clean gnatclean
gnat compile gnatmake -f -u -c
gnat check gnatcheck
gnat elim gnatelim
gnat find gnatfind
gnat krunch gnatkr
gnat link gnatlink
gnat list gnatls
gnat make gnatmake
gnat metric gnatmetric
gnat name gnatname
gnat preprocess gnatprep
gnat pretty gnatpp
gnat stack gnatstack
gnat stub gnatstub
gnat test gnattest
gnat xref gnatxref
Report bugs to report@adacore.com
$ gnat --help-ada
Usage: gnat switches sfile
sfile Source file name
-g Generate debugging information
-Idir Specify source files search path
-I- Do not look for sources in current directory
-O[0123] Control the optimization level
-gnata Assertions enabled. Pragma Assert/Debug to be activated
-gnatA Avoid processing gnat.adc, if present file will be ignored
-gnatb Generate brief messages to stderr even if verbose mode set
-gnatB Assume no bad (invalid) values except in 'Valid attribute
-gnatc Check syntax and semantics only (no code generation)
-gnatC Generate CodePeer intermediate format (no code generation)
-gnatd? Compiler debug option ? ([.]a-z,A-Z,0-9), see debug.adb
-gnatD Debug expanded generated code (max line length = 72)
-gnatDnn Debug expanded generated code (max line length = nn)
-gnateA Aliasing checks on subprogram parameters
-gnatec=? Specify configuration pragmas file, e.g. -gnatec=/x/f.adc
-gnateC Generate CodePeer messages (ignored without -gnatcC)
-gnated Disable synchronization of atomic variables
-gnateD? Define or redefine preprocessing symbol, e.g. -gnateDsym=val
-gnateE Generate extra information in exception messages
-gnatef Full source path in brief error messages
-gnateF Check overflow on predefined Float types
-gnateG Generate preprocessed source
-gnateinn Set maximum number of instantiations to nn
-gnateInn Index in multi-unit source, e.g. -gnateI2
-gnatel Turn on info messages on generated Elaborate[_All] pragmas
-gnateL Turn off info messages on generated Elaborate[_All] pragmas
-gnatem=? Specify mapping file, e.g. -gnatem=mapping
-gnatep=? Specify preprocessing data file, e.g. -gnatep=prep.data
-gnateP Pure/Prelaborate errors generate warnings rather than errors
-gnateS Generate SCO (Source Coverage Obligation) information
-gnatet=? Write target dependent information file ?, e.g. gnatet=tdf
-gnateT=? Read target dependent information file ?, e.g. gnateT=tdf
-gnateu Ignore unrecognized style/validity/warning switches
-gnateV Validity checks on subprogram parameters
-gnateY Ignore all Style_Checks pragmas in source
-gnatE Dynamic elaboration checking mode enabled
-gnatf Full errors. Verbose details, all undefined references
-gnatF Force all import/export external names to all uppercase
-gnatg GNAT implementation mode (used for compiling GNAT units)
-gnatG Output generated expanded code (max line length = 72)
-gnatGnn Output generated expanded code (max line length = nn)
-gnath Output this usage (help) information
-gnatH Legacy elaboration checking mode enabled
-gnati? Identifier char set (?=1/2/3/4/5/8/9/p/f/n/w)
-gnatI Ignore all representation clauses
-gnatjnn Format error and warning messages to fit nn character lines
-gnatJ Relaxed elaboration checking mode enabled
-gnatk Limit file names to nn characters (k = krunch)
-gnatl Output full source listing with embedded error messages
-gnatl=f Output full source listing to specified file
-gnatL List corresponding source text in -gnatG or -gnatD output
-gnatmnn Limit number of detected errors/warnings to nn (1-999999)
-gnatn[?] Enable pragma Inline across units (?=1/2 for moderate/full)
-gnato0 Disable overflow checking
-gnato Enable overflow checking in STRICT (-gnato1) mode (default)
-gnato? Enable overflow checks in STRICT/MINIMIZED/ELIMINATED (1/2/3) mode
-gnato?? Set mode for general/assertion expressions separately
-gnatp Suppress all checks
-gnatP Generate periodic calls to System.Polling.Poll
-gnatq Don't quit, try semantics, even if parse errors
-gnatQ Don't quit, write ali/tree file even if compile errors
-gnatr Treat pragma Restrictions as Restriction_Warnings
-gnatR? List rep info (?=0/1/2/3/4/e/m for none/types/all/sym/cg/ext/mech)
-gnatR?j List rep info in the JSON data interchange format
-gnatR?s List rep info to file.rep instead of standard output
-gnats Syntax check only
-gnatS Print listing of package Standard
-gnatt Tree output file to be generated
-gnatTnn All compiler tables start at nn times usual starting size
-gnatu List units for this compilation
-gnatU Enable unique tag for error messages
-gnatv Verbose mode. Full error output with source lines to stdout
-gnatVxx Enable selected validity checking mode, xx = list of parameters:
a turn on all validity checking options
c turn on checking for copies
C turn off checking for copies
d turn on default (RM) checking
D turn off default (RM) checking
e turn on checking for elementary components
E turn off checking for elementary components
f turn on checking for floating-point
F turn off checking for floating-point
i turn on checking for in params
I turn off checking for in params
m turn on checking for in out params
M turn off checking for in out params
n turn off all validity checks (including RM)
o turn on checking for operators/attributes
O turn off checking for operators/attributes
p turn on checking for parameters
P turn off checking for parameters
r turn on checking for returns
R turn off checking for returns
s turn on checking for subscripts
S turn off checking for subscripts
t turn on checking for tests
T turn off checking for tests
-gnatwxx Enable selected warning modes, xx = list of parameters:
* indicates default setting
+ indicates warning flag included in -gnatwa
a turn on all info/warnings marked below with +
A turn off all optional info/warnings
.a*+ turn on warnings for failing assertion
.A turn off warnings for failing assertion
_a*+ turn on warnings for anonymous allocators
_A turn off warnings for anonymous allocators
b+ turn on warnings for bad fixed value (not multiple of small)
B* turn off warnings for bad fixed value (not multiple of small)
.b*+ turn on warnings for biased representation
.B turn off warnings for biased representation
c+ turn on warnings for constant conditional
C* turn off warnings for constant conditional
.c+ turn on warnings for unrepped components
.C* turn off warnings for unrepped components
d turn on warnings for implicit dereference
D* turn off warnings for implicit dereference
.d turn on tagging of warnings with -gnatw switch
.D* turn off tagging of warnings with -gnatw switch
e treat all warnings (but not info) as errors
.e turn on every optional info/warning (no exceptions)
E treat all run-time warnings as errors
f+ turn on warnings for unreferenced formal
F* turn off warnings for unreferenced formal
.f turn on warnings for suspicious Subp'Access
.F* turn off warnings for suspicious Subp'Access
g*+ turn on warnings for unrecognized pragma
G turn off warnings for unrecognized pragma
.g turn on GNAT warnings
h turn on warnings for hiding declarations
H* turn off warnings for hiding declarations
.h turn on warnings for holes in records
.H* turn off warnings for holes in records
i*+ turn on warnings for implementation unit
I turn off warnings for implementation unit
.i*+ turn on warnings for overlapping actuals
.I turn off warnings for overlapping actuals
j+ turn on warnings for obsolescent (annex J) feature
J* turn off warnings for obsolescent (annex J) feature
.j+ turn on warnings for late dispatching primitives
.J* turn off warnings for late dispatching primitives
k+ turn on warnings on constant variable
K* turn off warnings on constant variable
.k turn on warnings for standard redefinition
.K* turn off warnings for standard redefinition
l turn on warnings for elaboration problems
L* turn off warnings for elaboration problems
.l turn on info messages for inherited aspects
.L* turn off info messages for inherited aspects
m+ turn on warnings for variable assigned but not read
M* turn off warnings for variable assigned but not read
.m*+ turn on warnings for suspicious modulus value
.M turn off warnings for suspicious modulus value
n* normal warning mode (cancels -gnatws/-gnatwe)
.n turn on info messages for atomic synchronization
.N* turn off info messages for atomic synchronization
o* turn on warnings for address clause overlay
O turn off warnings for address clause overlay
.o turn on warnings for out parameters assigned but not read
.O* turn off warnings for out parameters assigned but not read
p+ turn on warnings for ineffective pragma Inline in frontend
P* turn off warnings for ineffective pragma Inline in frontend
.p+ turn on warnings for suspicious parameter order
.P* turn off warnings for suspicious parameter order
q*+ turn on warnings for questionable missing parenthesis
Q turn off warnings for questionable missing parenthesis
.q+ turn on warnings for questionable layout of record types
.Q* turn off warnings for questionable layout of record types
r+ turn on warnings for redundant construct
R* turn off warnings for redundant construct
.r+ turn on warnings for object renaming function
.R* turn off warnings for object renaming function
s suppress all info/warnings
.s turn on warnings for overridden size clause
.S* turn off warnings for overridden size clause
t turn on warnings for tracking deleted code
T* turn off warnings for tracking deleted code
.t*+ turn on warnings for suspicious contract
.T turn off warnings for suspicious contract
u+ turn on warnings for unused entity
U* turn off warnings for unused entity
.u turn on warnings for unordered enumeration
.U* turn off warnings for unordered enumeration
v*+ turn on warnings for unassigned variable
V turn off warnings for unassigned variable
.v*+ turn on info messages for reverse bit order
.V turn off info messages for reverse bit order
w*+ turn on warnings for wrong low bound assumption
W turn off warnings for wrong low bound assumption
.w turn on warnings on pragma Warnings Off
.W* turn off warnings on pragma Warnings Off
x*+ turn on warnings for export/import
X turn off warnings for export/import
.x+ turn on warnings for non-local exception
.X* turn off warnings for non-local exception
y*+ turn on warnings for Ada compatibility issues
Y turn off warnings for Ada compatibility issues
.y turn on info messages for why pkg body needed
.Y* turn off info messages for why pkg body needed
z*+ turn on warnings for suspicious unchecked conversion
Z turn off warnings for suspicious unchecked conversion
.z*+ turn on warnings for record size not a multiple of alignment
.Z turn off warnings for record size not a multiple of alignment
-gnatW? Wide character encoding method (?=h/u/s/e/8/b)
-gnatx Suppress output of cross-reference information
-gnatX Language extensions permitted
-gnaty Enable default style checks (same as -gnaty3abcefhiklmnprst)
-gnatyxx Enable selected style checks xx = list of parameters:
1-9 check indentation
a check attribute casing
A check array attribute indexes
b check no blanks at end of lines
B check no use of AND/OR for boolean expressions
c check comment format (two spaces)
C check comment format (one space)
d check no DOS line terminators
e check end/exit labels present
f check no form feeds/vertical tabs in source
g check standard GNAT style rules, same as ydISux
h check no horizontal tabs in source
i check if-then layout
I check mode in
k check casing rules for keywords
l check reference manual layout
Lnn check max nest level < nn
m check line length <= 79 characters
Mnn check line length <= nn characters
n check casing of package Standard identifiers
N turn off all checks
o check subprogram bodies in alphabetical order
O check overriding indicators
p check pragma casing
r check casing for identifier references
s check separate subprogram specs present
S check separate lines after THEN or ELSE
t check token separation rules
u check no unnecessary blank lines
x check extra parentheses around conditionals
y turn on default style checks
- subtract (turn off) subsequent checks
+ add (turn on) subsequent checks
-gnatyN Cancel all previously set style checks
-gnatzc Distribution stub generation for caller stubs
-gnatzr Distribution stub generation for receiver stubs
-gnat83 Ada 83 mode
-gnat95 Ada 95 mode
-gnat2005 Ada 2005 mode
-gnat2012 Ada 2012 mode (default)
-gnat-p Cancel effect of previous -gnatp switch
2019-08-13 Justin Squirek <squirek@adacore.com>
gcc/ada/
* gnatcmd.adb (GNATCmd): Add constant for new compiler switch
--help-ada, and include usage subprogram. Add line to usage help
explaining the new flag.
(GNATCmd_Usage): Rename from locally declared Usage so as not to
confuse with the newly imported version. Add new argument case
for --help-ada and add bug report email to implicit display of
help without the --help flag so as to unify output between the
two cases.
From-SVN: r274334
Dmitriy Anisimkov [Tue, 13 Aug 2019 08:06:24 +0000 (08:06 +0000)]
[Ada] Better exception message on Invalid_Switch exception
Improve the error message introduced in the recent commit for
Invalid_Switch exception.
2019-08-13 Dmitriy Anisimkov <anisimko@adacore.com>
gcc/ada/
* libgnat/g-comlin.adb (Getopt): Quote unrecognized switch in
Invalid_Switch exception message.
From-SVN: r274333
Yannick Moy [Tue, 13 Aug 2019 08:06:18 +0000 (08:06 +0000)]
[Ada] Complete the more extended AST traversal used in GNATprove
Following the work on the Ada 202X feature of iterated aggregates
(AI12-061), Loop_Actions should have been listed as a semantic field of
nodes of kind N_Iterated_Component_Association. Fix this as well as the
new extended AST traversal which should traverse these fields.
There is no impact on compilation.
2019-08-13 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb (Traverse_More_Func): Take into account
Loop_Actions inside N_Iterated_Component_Association nodes.
* sinfo.ads: Document correctly Loop_Actions as a field of nodes
of kind N_Iterated_Component_Association.
From-SVN: r274332
Claire Dross [Tue, 13 Aug 2019 08:06:12 +0000 (08:06 +0000)]
[Ada] Extend range type in search primitives of formal vectors
2019-08-13 Claire Dross <dross@adacore.com>
gcc/ada/
* libgnat/a-cfinve.adb, libgnat/a-cofove.adb (Find_Index,
Reverse_Find_Index): Use bigger type to avoid range check
failure at the last loop iteration.
From-SVN: r274331
Martin Liska [Tue, 13 Aug 2019 07:31:25 +0000 (09:31 +0200)]
Simplify dump_printf in value-prof.c
2019-08-13 Martin Liska <mliska@suse.cz>
* value-prof.c (gimple_ic_transform): Add new line.
Print details with MSG_NOTE.
2019-08-13 Martin Liska <mliska@suse.cz>
* gcc.dg/tree-prof/ic-misattribution-1.c: Use -fdump-ipa-profile-node.
From-SVN: r274330
Martin Liska [Tue, 13 Aug 2019 07:30:57 +0000 (09:30 +0200)]
Automatically detect GNU jobserver with -flto.
2019-08-13 Martin Liska <mliska@suse.cz>
* doc/invoke.texi: Document automatic detection of jobserver.
* lto-wrapper.c (run_gcc): Detect jobserver always.
From-SVN: r274329
Uros Bizjak [Tue, 13 Aug 2019 04:27:08 +0000 (06:27 +0200)]
i386.md (ix86_expand_vector_set): Use vec_merge path for TARGET_MMX_WITH_SSE && TARGET_SSE4_1.
* config/i386/i386.md (ix86_expand_vector_set) <case E_V2SImode>:
Use vec_merge path for TARGET_MMX_WITH_SSE && TARGET_SSE4_1.
<case E_V8QImode>: Ditto.
* config/i386/mmx.md (*mmx_pinsrd): New insn pattern.
(*mmx_pinsrb): Ditto.
From-SVN: r274328
GCC Administrator [Tue, 13 Aug 2019 00:16:21 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274327
Thomas Koenig [Mon, 12 Aug 2019 20:21:37 +0000 (20:21 +0000)]
re PR fortran/91424 (Extend warnings about DO loops)
2019-08-12 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/91424
* frontend-passes.c (do_subscript): Do not warn for an
expression a second time. Do not warn about a zero-trip loop.
(doloop_warn): Also look at contained namespaces.
2019-08-12 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/91424
* gfortran.dg/do_subscript_3.f90: New test.
* gfortran.dg/do_subscript_4.f90: New test.
* gfortran.dg/pr70754.f90: Use indices that to not overflow.
2019-08-12 Thomas Koenig <tkoenig@gcc.gnu.org>
PR fortran/91422
* testsuite/libgomp.oacc-fortran/routine-7.f90: Correct array
dimension.
From-SVN: r274320
Jonathan Wakely [Mon, 12 Aug 2019 16:41:27 +0000 (17:41 +0100)]
PR libstdc++/90361 add missing macro definition
The src/c++17/string-inst.cc file needs to override the default string
ABI so that it still contains the expected symbols even when the library
is configured with --with-default-libstdcxx-abi=gcc4-compatible.
PR libstdc++/90361
* src/c++17/string-inst.cc: Use _GLIBCXX_USE_CXX11_ABI=1 by default.
From-SVN: r274314
Jakub Jelinek [Mon, 12 Aug 2019 15:55:56 +0000 (17:55 +0200)]
re PR target/83250 (_mm256_zextsi128_si256 missing for AVX2 zero extension)
PR target/83250
PR target/91340
* config/i386/avxintrin.h (_mm256_zextpd128_pd256,
_mm256_zextps128_ps256, _mm256_zextsi128_si256): New intrinsics.
* config/i386/avx512fintrin.h (_mm512_zextpd128_pd512,
_mm512_zextps128_ps512, _mm512_zextsi128_si512, _mm512_zextpd256_pd512,
_mm512_zextps256_ps512, _mm512_zextsi256_si512): Likewise.
* gcc.target/i386/avx-typecast-1.c: New test.
* gcc.target/i386/avx-typecast-2.c: New test.
* gcc.target/i386/avx512f-typecast-2.c: New test.
From-SVN: r274313
Jonathan Wakely [Mon, 12 Aug 2019 14:54:12 +0000 (15:54 +0100)]
Add noexcept-specifier to std::apply and std::make_from_tuple
When unpacking a std::tuple we know that the std::get calls are
noexcept, so only the invocation (for std::apply) and construction (for
std::make_from_tuple) can throw.
We also know the std::get calls won't throw for a std::array, but this
patch doesn't specialize the variable template for std::array. For an
arbitrary tuple-like type we don't know if the std::get calls will
throw, and so just use a potentially-throwing noexcept-specifier.
* include/std/tuple (__unpack_std_tuple): New variable template and
partial specializations.
(apply, make_from_tuple): Add noexcept-specifier.
* testsuite/20_util/tuple/apply/2.cc: New test.
* testsuite/20_util/tuple/make_from_tuple/2.cc: New test.
From-SVN: r274312
Richard Biener [Mon, 12 Aug 2019 11:02:21 +0000 (11:02 +0000)]
re PR lto/91375 (ICE on valid code in subbinfo_with_vtable_at_offset at ipa-devirt.c:2760 since r256685)
2019-08-12 Richard Biener <rguenther@suse.de>
PR lto/91375
* tree.c (free_lang_data_in_type): Do not free TYPE_BINFO dependent on
flag_devirtualize.
From-SVN: r274310
Richard Biener [Mon, 12 Aug 2019 10:59:58 +0000 (10:59 +0000)]
re PR driver/91130 (-MF clashes with -flto on aarch64)
2019-08-12 Richard Biener <rguenther@suse.de>
PR driver/91130
* lto-wrapper.c (get_options_from_collect_gcc_options): Remove
lang_mask option, always use CL_DRIVER.
(get_options_from_collect_gcc_options): Adjust.
(find_and_merge_options): Likewise.
(run_gcc): Likewise.
From-SVN: r274309
Dmitriy Anisimkov [Mon, 12 Aug 2019 09:01:58 +0000 (09:01 +0000)]
[Ada] Fix IPv6 numeric address detection
IPv6 numeric address can't have less than 2 colons. It fixes the error
when Get_Host_By_Name called with hostname composed by only hexadecimal
symbols.
2019-08-12 Dmitriy Anisimkov <anisimko@adacore.com>
gcc/ada/
* libgnat/g-socket.adb (Is_IPv6_Address): Check that no less
then 2 colons in IPv6 numeric address.
From-SVN: r274308
Dmitriy Anisimkov [Mon, 12 Aug 2019 09:01:53 +0000 (09:01 +0000)]
[Ada] New parameter Quiet for procedure GNAT.Command_Line.Getopt
Getopt procedure is parsing the command line or set of strings. If the
command line contains unknown switch than the Getopt prints error
message to the console and raises the exception Invalid_Switch. The
printing can be inappropriate in some cases. The new parameter Quiet
allows avoiding console output.
2019-08-12 Dmitriy Anisimkov <anisimko@adacore.com>
gcc/ada/
* libgnat/g-comlin.ads, libgnat/g-comlin.adb (Getopt): Add
parameter Quiet. Need to do not output error messages to
console. Invalid_Switch exception generation surrounded by an
error message.
From-SVN: r274307
Ed Schonberg [Mon, 12 Aug 2019 09:01:48 +0000 (09:01 +0000)]
[Ada] Missing check on outbound parameter of a non-null access type
This patch adds code to generate proper post-call checks when an actual
for an in-out or out parameter has a non-null access type. No
constraints are applied to an inbound access parameter, but on exit a
not-null check must be performed if the type of the actual requires it.
2019-08-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_ch6.adb (Expand_Actuals. Add_Call_By_Copy_Code): Add code
to generate proper checks when an actual for an in-out or out
parameter has a non-null access type. No constraints are
applied to an inbound access parameter, but on exit a not-null
check must be performed if the type of the actual requires it.
gcc/testsuite/
* gnat.dg/null_check.adb: New testcase.
From-SVN: r274306
Ed Schonberg [Mon, 12 Aug 2019 09:01:43 +0000 (09:01 +0000)]
[Ada] Crash on illegal left-hand side in assignment of renamed variable
This patch fixes a crash on an assignment where the left-hand side is a
renaming of a function call that does not involve ceiling priorities.
This avoids a compiler crash in some cases, and prevents a useless
retrieval and compilation of run-time packages.
2019-08-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_util.adb (Is_Expaned_Priority_Attribute): Check whether
call comes from a rewritten attribute before comparing name with
Get_Ceiling run-time subprogram.
gcc/testsuite/
* gnat.dg/renaming15.adb: New testcase.
From-SVN: r274305
Eric Botcazou [Mon, 12 Aug 2019 09:01:38 +0000 (09:01 +0000)]
[Ada] Small comment tweaks for 3 predicates on bit-aligned references
They fix a few glitches left and right. No functional changes.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_util.ads (Component_May_Be_Bit_Aligned): Small comment
tweaks.
(Possible_Bit_Aligned_Component): Likewise.
(Type_May_Have_Bit_Aligned_Components): Likewise.
* exp_util.adb (Component_May_Be_Bit_Aligned): Likewise.
(Possible_Bit_Aligned_Component): Likewise.
(Type_May_Have_Bit_Aligned_Components): Likewise.
From-SVN: r274304
Eric Botcazou [Mon, 12 Aug 2019 09:01:33 +0000 (09:01 +0000)]
[Ada] Fix internal error on comparison of unaligned slices
This fixes an internal error in the code generator when it is trying to
take the address of a slice which does not start on a byte boundary, in
order to generate a comparison between slices with a dynamic length.
This case is not supported by the code generator and comes from an
explicit representation clause on a record type, so it must be detected
and handled by the front-end by expanding the comparison on an
element-by-element basis.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Op_Eq): Expand the array equality if
either operand is a possibly unaligned slice.
* exp_ch6.adb (Expand_Simple_Function_Return): Do not generate a
copy for a possibly unaligned object if it is represented as a
scalar.
* exp_util.adb (Is_Possibly_Unaligned_Slice): Do not always
return false if the target doesn't have strict alignment.
gcc/testsuite/
* gnat.dg/slice10.adb: New testcase.
From-SVN: r274303
Bob Duff [Mon, 12 Aug 2019 09:01:25 +0000 (09:01 +0000)]
[Ada] Do not suppress checks in instances of internal generics
This patch removes suppression of checks in nested instances of internal
packages. No test.
This was inconsistent: only for packages, not for subprograms. Only for
nested instantiations, not library level ones. Not for GNAT units.
Furthermore, the user should have control via pragma Suppress or
switches.
Furthermore, without this change, there could be missing tampering
checks in Ada.Containers.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* sem_ch12.adb (Instantiate_Package_Body): Remove suppression of
checks in instances of internal units.
* sem_ch6.adb (Analyze_Function_Return): Do not generate a
constraint check on an extended_return_statement if the subtype
of the return object in the statement is identical to the return
subtype of the function.
From-SVN: r274302
Bob Duff [Mon, 12 Aug 2019 09:01:20 +0000 (09:01 +0000)]
[Ada] Prevent crash in Is_Reachable
This patch fixes a bug in Is_Reachable, which causes a crash when checks
are on.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/a-cbmutr.adb (Is_Reachable): Declare Idx to be of the
base subtype. Clearly it makes no sense to loop "while Idx >=
0", if Idx is of a nonnegative subtype.
From-SVN: r274301
Bob Duff [Mon, 12 Aug 2019 09:01:14 +0000 (09:01 +0000)]
[Ada] Prevent crash in Put_Scaled
This patch fixes a bug in Put_Scaled, which causes a crash when checks
are on.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/a-tifiio.adb (Put_Scaled): Prevent AA from being
negative, since Field is range 0 .. something.
From-SVN: r274300
Bob Duff [Mon, 12 Aug 2019 09:01:09 +0000 (09:01 +0000)]
[Ada] Remove doc for language version switches
Remove documentation for Ada language version switches, and note that
they are no longer needed. These tools now silently ignore such
switches, and process the file correctly no matter what version of Ada
is used.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* doc/gnat_ugn/gnat_utility_programs.rst (gnatmetric, gnatpp,
gnatstub): Remove documentation for Ada language version
switches, and note that they are no longer needed.
From-SVN: r274299
Gary Dismukes [Mon, 12 Aug 2019 09:01:04 +0000 (09:01 +0000)]
[Ada] Hang on loop in generic with subtype indication specifying a range
The compiler may hang when a for loop expanded in a generic
instantiation has a range specified by a subtype indication with an
explicit range that has a bound that is an attribute applied to a
discriminant-dependent array component. The Parent field of the bound
may not be set, which can lead to endless looping when an actual subtype
created for the array component is passed to Insert_Actions. This is
fixed by setting the Parent fields of the copied bounds before
Preanalyze is called on them.
2019-08-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_ch5.adb (Prepare_Param_Spec_Loop): Set the parents of the
copied low and high bounds in the case where the loop range is
given by a discrete_subtype_indication, to prevent hanging (or
Assert_Failure) in Insert_Actions.
gcc/testsuite/
* gnat.dg/generic_inst7.adb, gnat.dg/generic_inst7_pkg.adb,
gnat.dg/generic_inst7_pkg.ads, gnat.dg/generic_inst7_types.ads:
New testcase.
From-SVN: r274298
Ed Schonberg [Mon, 12 Aug 2019 09:00:59 +0000 (09:00 +0000)]
[Ada] Improper error message on equality op with different operand types
2019-08-12 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch6.adb (heck_Untagged_Equality): Verify that user-defined
equality has the same profile as the predefined equality before
applying legality rule in RM 4.5.2 (9.8).
gcc/testsuite/
* gnat.dg/equal10.adb, gnat.dg/equal10.ads: New testcase.
From-SVN: r274297
Bob Duff [Mon, 12 Aug 2019 09:00:39 +0000 (09:00 +0000)]
[Ada] Minor cleanups in exception handling
No change in behavior, so no test.
2019-08-12 Bob Duff <duff@adacore.com>
gcc/ada/
* libgnat/a-except.ads: Update obsolete comment, still making
clear that this is a variant. Add explicit default for Id
component of Exception_Occurrence, because that value is used.
Define Null_Occurrence less redundantly.
* libgnat/a-einuoc.adb: Minor simplification of code.
From-SVN: r274296
Justin Squirek [Mon, 12 Aug 2019 09:00:27 +0000 (09:00 +0000)]
[Ada] Implement Ada.Directories.Hierarchical_File_Names
This patch corrects certain behaviors within Ada.Directories to better
conform to conformance tests and implements the package
Ada.Directories.Hierarchical_File_Names outlined in AI05-0049-1.
Only partial test sources are included.
------------
-- Source --
------------
-- main.ads
with Ada.Directories.Hierarchical_File_Names;
use Ada.Directories.Hierarchical_File_Names;
with Ada.Exceptions; use Ada.Exceptions;
with Ada.Text_IO; use Ada.Text_IO;
procedure Main is
FULL_PATH_A : constant String := "/export/work/user/bug";
FULL_PATH_B : constant String := "/export/work/user";
RELATIVE_PATH_A : constant String := "export/work/user/bug/";
RELATIVE_PATH_B : constant String := "export/work/user/bug";
SIMPLE_PATH_A : constant String := "bug/";
SIMPLE_PATH_B : constant String := "bug";
ROOT_PATH : constant String := "/";
CURRENT_DIR : constant String := ".";
PARENT_DIR : constant String := "..";
RELATIVE_WITH_CURRENT : constant String := RELATIVE_PATH_A & ".";
RELATIVE_WITH_PARENT : constant String := RELATIVE_PATH_A & "..";
begin
Put_Line ("Simple_Name");
Put_Line (Is_Simple_Name (FULL_PATH_A)'Image);
Put_Line (Is_Simple_Name (FULL_PATH_B)'Image);
Put_Line (Is_Simple_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Simple_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Simple_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Simple_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Simple_Name (ROOT_PATH)'Image);
Put_Line (Is_Simple_Name (CURRENT_DIR)'Image);
Put_Line (Is_Simple_Name (PARENT_DIR)'Image);
Put_Line (Is_Simple_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Simple_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line (Simple_Name (FULL_PATH_A));
Put_Line (Simple_Name (FULL_PATH_B));
Put_Line (Simple_Name (RELATIVE_PATH_A));
Put_Line (Simple_Name (RELATIVE_PATH_B));
Put_Line (Simple_Name (SIMPLE_PATH_A));
Put_Line (Simple_Name (SIMPLE_PATH_B));
Put_Line (Simple_Name (ROOT_PATH));
Put_Line (Simple_Name (CURRENT_DIR));
Put_Line (Simple_Name (PARENT_DIR));
Put_Line (Simple_Name (RELATIVE_WITH_CURRENT));
Put_Line (Simple_Name (RELATIVE_WITH_PARENT));
Put_Line ("Root_Directory_Name");
Put_Line (Is_Root_Directory_Name (FULL_PATH_A)'Image);
Put_Line (Is_Root_Directory_Name (FULL_PATH_B)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Root_Directory_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Root_Directory_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Root_Directory_Name (ROOT_PATH)'Image);
Put_Line (Is_Root_Directory_Name (CURRENT_DIR)'Image);
Put_Line (Is_Root_Directory_Name (PARENT_DIR)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Root_Directory_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Is_Parent_Directory_Name");
Put_Line (Is_Parent_Directory_Name (FULL_PATH_A)'Image);
Put_Line (Is_Parent_Directory_Name (FULL_PATH_B)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Parent_Directory_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Parent_Directory_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Parent_Directory_Name (ROOT_PATH)'Image);
Put_Line (Is_Parent_Directory_Name (CURRENT_DIR)'Image);
Put_Line (Is_Parent_Directory_Name (PARENT_DIR)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Parent_Directory_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Is_Current_Directory_Name");
Put_Line (Is_Current_Directory_Name (FULL_PATH_A)'Image);
Put_Line (Is_Current_Directory_Name (FULL_PATH_B)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Current_Directory_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Current_Directory_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Current_Directory_Name (ROOT_PATH)'Image);
Put_Line (Is_Current_Directory_Name (CURRENT_DIR)'Image);
Put_Line (Is_Current_Directory_Name (PARENT_DIR)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Current_Directory_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Is_Full_Name");
Put_Line (Is_Full_Name (FULL_PATH_A)'Image);
Put_Line (Is_Full_Name (FULL_PATH_B)'Image);
Put_Line (Is_Full_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Full_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Full_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Full_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Full_Name (ROOT_PATH)'Image);
Put_Line (Is_Full_Name (CURRENT_DIR)'Image);
Put_Line (Is_Full_Name (PARENT_DIR)'Image);
Put_Line (Is_Full_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Full_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line ("Relative_Name");
Put_Line (Is_Relative_Name (FULL_PATH_A)'Image);
Put_Line (Is_Relative_Name (FULL_PATH_B)'Image);
Put_Line (Is_Relative_Name (RELATIVE_PATH_A)'Image);
Put_Line (Is_Relative_Name (RELATIVE_PATH_B)'Image);
Put_Line (Is_Relative_Name (SIMPLE_PATH_A)'Image);
Put_Line (Is_Relative_Name (SIMPLE_PATH_B)'Image);
Put_Line (Is_Relative_Name (ROOT_PATH)'Image);
Put_Line (Is_Relative_Name (CURRENT_DIR)'Image);
Put_Line (Is_Relative_Name (PARENT_DIR)'Image);
Put_Line (Is_Relative_Name (RELATIVE_WITH_CURRENT)'Image);
Put_Line (Is_Relative_Name (RELATIVE_WITH_PARENT)'Image);
Put_Line (Relative_Name (FULL_PATH_A));
Put_Line (Relative_Name (FULL_PATH_B));
Put_Line (Relative_Name (RELATIVE_PATH_A));
Put_Line (Relative_Name (RELATIVE_PATH_B));
begin
Put_Line (Relative_Name (SIMPLE_PATH_A));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (SIMPLE_PATH_B));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (ROOT_PATH));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (CURRENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Relative_Name (PARENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
Put_Line (Relative_Name (RELATIVE_WITH_CURRENT));
Put_Line (Relative_Name (RELATIVE_WITH_PARENT));
Put_Line ("Containing_Directory");
Put_Line (Containing_Directory (FULL_PATH_A));
Put_Line (Containing_Directory (FULL_PATH_B));
Put_Line (Containing_Directory (RELATIVE_PATH_A));
Put_Line (Containing_Directory (RELATIVE_PATH_B));
Put_Line (Containing_Directory (SIMPLE_PATH_A));
Put_Line (Containing_Directory (SIMPLE_PATH_B));
begin
Put_Line (Containing_Directory (ROOT_PATH));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Containing_Directory (CURRENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
begin
Put_Line (Containing_Directory (PARENT_DIR));
exception
when E: others =>
Put_Line (Exception_Information (E));
end;
Put_Line (Containing_Directory (RELATIVE_WITH_CURRENT));
Put_Line (Containing_Directory (RELATIVE_WITH_PARENT));
Put_Line ("Initial_Directory");
Put_Line (Initial_Directory (FULL_PATH_A));
Put_Line (Initial_Directory (FULL_PATH_B));
Put_Line (Initial_Directory (RELATIVE_PATH_A));
Put_Line (Initial_Directory (RELATIVE_PATH_B));
Put_Line (Initial_Directory (SIMPLE_PATH_A));
Put_Line (Initial_Directory (SIMPLE_PATH_B));
Put_Line (Initial_Directory (ROOT_PATH));
Put_Line (Initial_Directory (CURRENT_DIR));
Put_Line (Initial_Directory (PARENT_DIR));
Put_Line (Initial_Directory (RELATIVE_WITH_CURRENT));
Put_Line (Initial_Directory (RELATIVE_WITH_PARENT));
end;
-----------------
-- Compilation --
-----------------
$ gnatmake -q main.adb
Simple_Name
FALSE
FALSE
FALSE
FALSE
TRUE
TRUE
FALSE
TRUE
TRUE
FALSE
FALSE
bug
user
bug
bug
bug
bug
/
.
..
.
..
Root_Directory_Name
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
FALSE
FALSE
Is_Parent_Directory_Name
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
Is_Current_Directory_Name
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
FALSE
Is_Full_Name
TRUE
TRUE
FALSE
FALSE
FALSE
FALSE
TRUE
FALSE
FALSE
FALSE
FALSE
Relative_Name
FALSE
FALSE
TRUE
TRUE
TRUE
TRUE
FALSE
TRUE
TRUE
TRUE
TRUE
export/work/user/bug
export/work/user
work/user/bug/
work/user/bug
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "bug/" is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "bug" is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "/" is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name "." is
composed of a single part
raised ADA.IO_EXCEPTIONS.NAME_ERROR : relative path name ".." is
composed of a single part
work/user/bug/.
work/user/bug/..
Containing_Directory
/export/work/user
/export/work
export/work/user/bug
export/work/user
bug
.
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory "/" has no containing directory
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory "." has no containing directory
raised ADA.IO_EXCEPTIONS.USE_ERROR : directory ".." has no containing directory
export/work/user/bug
export/work/user/bug
Initial_Directory
/
/
export
export
bug
bug
/
.
..
export
export
2019-08-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* libgnat/a-dhfina.adb, libgnat/a-dhfina.ads (Is_Simple_Name,
Is_Root_Directory, Is_Parent_Directory,
Is_Current_Directory_Name, Is_Relative_Name, Initial_Directory,
Relative_Name, Compose): Add implementation and documentation.
* libgnat/a-direct.adb (Containing_Directory): Modify routine to
use routines from Ada.Directories.Hierarchical_File_Names and
remove incorrect special case for parent directories.
(Fetch_Next_Entry): Add check for current directory and parent
directory and ignore them under certain circumstances.
(Simple_Nmae): Add check for null result from
Simple_Name_Internal and raise Name_Error.
(Simple_Name_Internal): Add explicit check for root directories,
sanitize trailing directory separators, and modify behavior so
that current and parent directories are considered valid
results.
* Makefile.rtl: Add entry to GNATRTL_NONTASKING_OBJS.
From-SVN: r274295
Eric Botcazou [Mon, 12 Aug 2019 09:00:04 +0000 (09:00 +0000)]
[Ada] Improve error message for Object_Size clause on dynamic array
This makes the compiler issue the same error:
size clause not allowed for variable length type
for an Object_Size clause on a variable-sized type as for a Size clause,
for example on the following procedure:
procedure P (X, Y : Integer) is
subtype Sub is String (X .. Y) with Object_Size => 64;
begin
null;
end;
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* freeze.adb (Freeze_Entity): Give the same error for an
Object_Size clause on a variable-sized type as for a Size
clause.
From-SVN: r274294
Gary Dismukes [Mon, 12 Aug 2019 08:59:58 +0000 (08:59 +0000)]
[Ada] Suppress_Initialization not respected for private subtypes
The compiler fails to suppress initialization on a variable of a subtype
of a private type (such as System.Address) even though the subtype has
aspect Suppress_Initialization. This can lead to errors on object
declarations specified with Thread_Local_Storage when Initialize_Scalars
is applied (as well as leading to default initialization when it
shouldn't).
2019-08-12 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_prag.adb (Analyze_Pragma, Pragma_Suppress_Initialization):
For private types, set the Suppress_Initialization flag on the
Full_View of the entity rather than the entity's base type.
gcc/testsuite/
* gnat.dg/suppress_initialization2.adb,
gnat.dg/suppress_initialization2.ads: New testcase.
From-SVN: r274293
Yannick Moy [Mon, 12 Aug 2019 08:59:53 +0000 (08:59 +0000)]
[Ada] New aspect/pragma No_Caching for analysis of volatile data
A new aspect/pragma can be attached to volatile variables to indicate
that such a variable is not used for interactions with the external
world, but only that accesses to that variable should not be optimized
by the compiler. This is in particular useful for guarding against fault
injection. SPARK Reference manual has been updated to allow this use of
volatile data, see section 7.1.2, so that GNATprove can analyze such
variables as not volatile.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* aspects.adb, aspects.ads (Aspect_No_Caching): New aspect.
* contracts.adb, contracts.ads (Add_Contract_Item): Add handling
of No_Caching.
(Analyze_Object_Contract): Add handling of No_Caching.
* einfo.adb, einfo.ads
(Get_Pragma): Add handling of No_Caching.
* doc/gnat_rm/implementation_defined_aspects.rst,
doc/gnat_rm/implementation_defined_pragmas.rst: Document new
aspect/pragma.
* gnat_rm.texi: Regenerate.
* par-prag.adb (Prag): New pragma Pragma_No_Caching.
* sem_ch13.adb (Analyze_Aspect_Specifications,
Check_Aspect_At_Freeze_Point): Add handling of No_Caching.
* sem_prag.adb (Analyze_Pragma): Deal with pragma No_Caching.
* sem_prag.ads (Analyze_External_Property_In_Decl_Part): Now
applies to No_Caching.
* sem_util.adb, sem_util.ads (Is_Effectively_Volatile): Add
handling of No_Caching.
(No_Caching_Enabled): New query function.
* snames.ads-tmpl: New names for pragma.
gcc/testsuite/
* gnat.dg/no_caching.adb, gnat.dg/no_caching.ads: New testcase.
From-SVN: r274292
Yannick Moy [Mon, 12 Aug 2019 08:59:47 +0000 (08:59 +0000)]
[Ada] Adapt new extended traversal of AST to have optional part
The new extended traversal of the AST for GNATprove use now optionally
traverses the ranges under Itypes, based on a formal parameter.
There is no impact on compilation.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb, sem_util.ads (Traverse_More_Func,
Traverse_More_Proc): Add formal parameter for Itypes traversal.
From-SVN: r274291
Yannick Moy [Mon, 12 Aug 2019 08:59:42 +0000 (08:59 +0000)]
[Ada] More precise handling of Size/Object_Size in GNATprove
GNATprove does a partial expansion which did not allow getting the
most precise value for attributes Size/Object_Size. Now fixed.
There is no impact on compilation.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* exp_attr.adb, exp_attr.ads (Expand_Size_Attribute): New
procedure to share part of the attribute expansion with
GNATprove mode.
(Expand_N_Attribute_Reference): Extract part of the
Size/Object_Size expansion in the new procedure
Expand_Size_Attribute.
* exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Expand
Size/Object_Size attributes using the new procedure
Expand_Size_Attribute.
From-SVN: r274290
Yannick Moy [Mon, 12 Aug 2019 08:59:37 +0000 (08:59 +0000)]
[Ada] SPARK: disable expansion of Enum_Rep
Disable expansion of Enum_Rep into a type conversion as it is incorrect
in SPARK.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* exp_spark.adb (Expand_SPARK_N_Attribute_Reference): Only
expand Enum_Rep attribute when its parameter is a literal.
From-SVN: r274289
Justin Squirek [Mon, 12 Aug 2019 08:59:33 +0000 (08:59 +0000)]
[Ada] Inconsistent compile time Constraint_Error warning
This patch corrects several bugs within the compiler which led to
inconsistent handling of compile time Constraint_Errors. Notibly,
subtype out of range checks which are only out of range of the subtype
must be warnings while out of range checks where the value is out of
range of the base type must be an error. Also, type conversions and
qualified expressions on literals constitute errors on any out of range
value. The compiler needed many of these cases clarified.
------------
-- Source --
------------
-- main.ads
with System;
package Main is
type T_Enum is (Enum_1, Enum_2, Unknown)
with Default_Value => Unknown;
subtype T_Valid_Enum is T_Enum range Enum_1 .. Enum_2;
Value : T_Valid_Enum; -- WARNING
generic
type T_Element is (<>);
Init : T_Element;
package Generic_Test is
Value : T_Element := Init;
end;
package titi is new Generic_Test (T_Valid_Enum, Unknown); -- WARNING
type My_Float is digits System.Max_Base_Digits;
My_Float_Last : constant := My_Float'Last;
Out_Of_Range : constant := My_Float_Last + 1.0;
Flt1 : My_Float := Out_Of_Range; -- ERROR
A : Positive := Positive (16#9999_9999_9999#); -- ERROR
B : Positive := 16#9999_9999_9999#; -- ERROR
C : Positive := 0; -- WARNING
D : Positive := Positive (0); -- ERROR
E : Positive := Positive'(16#9999_9999_9999#); -- ERROR
F : Positive := Positive'(0); -- ERROR
end;
-----------------
-- Compilation --
-----------------
$ gnatmake -q -gnatw_a main.adb
main.ads:9:12: warning: value not in range of type "T_Valid_Enum" defined at
line 7
main.ads:9:12: warning: "Constraint_Error" will be raised at run time
main.ads:18:52: warning: value not in range of type "T_Element" defined at
line 12, instance at line 18
main.ads:18:52: warning: "Constraint_Error" will be raised at run time
main.ads:25:23: value not in range of type "My_Float" defined at line 20
main.ads:25:23: static expression fails Constraint_Check
main.ads:27:19: value not in range of type "Standard.Positive"
main.ads:27:19: static expression fails Constraint_Check
main.ads:28:19: value not in range of type "Standard.Positive"
main.ads:28:19: static expression fails Constraint_Check
main.ads:29:19: warning: value not in range of type "Standard.Positive"
main.ads:29:19: warning: "Constraint_Error" will be raised at run time
main.ads:30:19: value not in range of type "Standard.Positive"
main.ads:30:19: static expression fails Constraint_Check
main.ads:31:27: value not in range of type "Standard.Positive"
main.ads:31:27: static expression fails Constraint_Check
main.ads:32:27: value not in range of type "Standard.Positive"
main.ads:32:27: static expression fails Constraint_Check
gnatmake: "main.ads" compilation error
2019-08-12 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_eval.adb (Check_Non_Static_Context): Add a condition to
determine if a range violation constitues a warning or an error.
(Out_Of_Range): Add a condition to determine if a range
violation constitues a warning or an error.
From-SVN: r274288
Eric Botcazou [Mon, 12 Aug 2019 08:59:28 +0000 (08:59 +0000)]
[Ada] Eliminate redundant range checks on conversions
This gets rid of redundant range checks generated in 5 out of the 9
cases of scalar conversions, i.e. (integer, fixed-point, floating-point)
converted to (integer, fixed-point, floating-point).
The problem is that the Real_Range_Check routine rewrites the conversion
node into a conversion to the base type so, when its parent node is
analyzed, a new conversion to the subtype may be introduced, depending
on the context, giving rise to a second range check against the subtype
bounds.
This change makes Real_Range_Check rewrite the expression of the
conversion node instead of the node, so that the type of the node is
preserved and no new conversion is introduced. As a matter of fact,
this is exactly what happens in the float-to-float case which goes to
the Generate_Range_Check circuit instead and does not suffer from the
duplication of range checks.
For the following procedure, the compiler must now generate exactly one
range check per nested function:
procedure P is
type I1 is new Integer range -100 .. 100;
type I2 is new Integer range -200 .. 200;
type D1 is delta 0.5 range -100.0 .. 100.0;
type D2 is delta 0.5 range -200.0 .. 200.0;
type F1 is new Long_Float range -100.0 .. 100.0;
type F2 is new Long_Float range -200.0 .. 200.0;
function Conv (A : I2) return I1 is
begin
return I1 (A);
end;
function Conv (A : D2) return I1 is
begin
return I1 (A);
end;
function Conv (A : F2) return I1 is
begin
return I1 (A);
end;
function Conv (A : I2) return D1 is
begin
return D1 (A);
end;
function Conv (A : D2) return D1 is
begin
return D1 (A);
end;
function Conv (A : F2) return D1 is
begin
return D1 (A);
end;
function Conv (A : I2) return F1 is
begin
return F1 (A);
end;
function Conv (A : D2) return F1 is
begin
return F1 (A);
end;
function Conv (A : F2) return F1 is
begin
return F1 (A);
end;
begin
null;
end;
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Real_Range_Check): Do not rewrite the conversion
node but its expression instead, after having fetched its
current value. Clear the Do_Range_Check flag on entry. Return
early for a rewritten float-to-float conversion. Remove
redundant local variable. Suppress all checks when inserting
the temporary and do not reanalyze the node.
From-SVN: r274287
Eric Botcazou [Mon, 12 Aug 2019 08:59:23 +0000 (08:59 +0000)]
[Ada] Sprint: minor comment tweak
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sprint.ads: Minor comment tweak.
From-SVN: r274286
Eric Botcazou [Mon, 12 Aug 2019 08:59:18 +0000 (08:59 +0000)]
[Ada] Fix leak of Do_Range_Check flag in -gnatVa mode
This fixes a small glitch in Insert_Valid_Check, which needs to
propagate the Do_Range_Check flag onto the rewritten expression, but
uses its Original_Node as the source of the copy. Now Original_Node
does not necessarily point to the node that was just rewritten, but to
the ultimately original node, which is not the same node if the
expression was rewritten multiple times. The end result is that a
stalled Do_Range_Check flag can be wrongly resintated and leak to the
code generator.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* checks.adb (Insert_Valid_Check): Do not retrieve the
Do_Range_Check flag from the Original_Node but from the
Validated_Object. Remove useless bypass for floating-point
types.
gcc/testsuite/
* gnat.dg/range_check7.adb: New testcase.
From-SVN: r274285
Yannick Moy [Mon, 12 Aug 2019 08:59:13 +0000 (08:59 +0000)]
[Ada] Extended traversal subprograms for GNATprove
GNATprove needs traversal subprograms that do not simply traverse
syntactic nodes like Atree.Traverse_Func and Atree.Traverse_Proc, but
also traverse semantic nodes which are logically children of the nodes.
Now available through Sem_Util.Traverse_More_Func and
Sem_Util.Traverse_More_Proc.
There is no impact on compilation.
2019-08-12 Yannick Moy <moy@adacore.com>
gcc/ada/
* sem_util.adb, sem_util.ads (Traverse_More_Func,
Traverse_More_Proc): New traversal subprograms.
From-SVN: r274284
Jerome Lambourg [Mon, 12 Aug 2019 08:59:08 +0000 (08:59 +0000)]
[Ada] VxWorks: call s-tpopsp.Self only when needed
2019-08-12 Jerome Lambourg <lambourg@adacore.com>
gcc/ada/
* libgnarl/s-taprop__vxworks.adb (Abort_Handler): Only call
s-tpopsp.Self when actually needed.
From-SVN: r274283
Eric Botcazou [Mon, 12 Aug 2019 08:59:02 +0000 (08:59 +0000)]
[Ada] Plug small loophole in Discrete_Range_Check
This routine would not return if range checks are suppressed.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_ch4.adb (Discrete_Range_Check): Return if checks are
suppressed.
From-SVN: r274282
Eric Botcazou [Mon, 12 Aug 2019 08:58:57 +0000 (08:58 +0000)]
[Ada] Add special bypass for obsolete code pattern
This change prevents the analysis phase of the front-end from setting
the Do_Range_Check flag in the very peculiar case of the source of a
conversion whose result is passed by reference to a "valued procedure",
because the expansion phase would not be able to generate the check.
This pattern appears in the ancient DEC Starlet package and it doesn't
seem to be useful at this point to change the expander to deal with it,
so instead the analysis phase is adjusted. Morever the compiler already
issues a warning in this case so this is probably good enough.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_res.adb: Add with & use clause for Sem_Mech and
alphabetize.
(Resolve_Actuals): Do not apply a scalar range check for the
source of a conversion whose result is passed by reference to a
valued procedure.
From-SVN: r274281
Eric Botcazou [Mon, 12 Aug 2019 08:58:52 +0000 (08:58 +0000)]
[Ada] Fix missing range check for In/Out parameter with -gnatVa
This plugs another small loophole in the front-end which fails to
generate a range check for a scalar In/Out parameter when -gnatVa is
specified. This also fixes a few more leaks of the Do_Range_Check flag
on actual parameters, both in regular and -gnatVa modes, as well as a
leak specific to expression function in -gnatp mode.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* checks.adb (Insert_Valid_Check): Reset the Do_Range_Check flag
on the validated object.
* exp_ch6.adb (Add_Call_By_Copy_Code): Reset the Do_Range_Check
flag on the actual here, as well as on the Expression if the
actual is a N_Type_Conversion node.
(Add_Validation_Call_By_Copy_Code): Generate the incoming range
check if needed and reset the Do_Range_Check flag on the
Expression if the actual is a N_Type_Conversion node.
(Expand_Actuals): Do not reset the Do_Range_Check flag here.
Generate the incoming range check for In parameters here instead
of...
(Expand_Call_Helper): ...here. Remove redudant condition.
* sem_res.adb (Resolve_Actuals): Use local variable A_Typ and
remove obsolete comments.
(Resolve_Type_Conversion): Do not force the Do_Range_Check flag
on the operand if range checks are suppressed.
gcc/testsuite/
* gnat.dg/range_check6.adb: New testcase.
From-SVN: r274280
Eric Botcazou [Mon, 12 Aug 2019 08:58:46 +0000 (08:58 +0000)]
[Ada] Fix incorrect Do_Range_Check on type conversion
This gets rid of another leak of the Do_Range_Check flag to the back-end
which is specific to expression functions. No functional changes.
2019-08-12 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* checks.adb (Activate_Range_Check): Remove redundant argument.
(Generate_Range_Check): Likewise.
(Apply_Float_Conversion_Check): Reset the Do_Range_Check flag on
entry and remove redundant condition.
From-SVN: r274279
Rainer Orth [Mon, 12 Aug 2019 08:47:34 +0000 (08:47 +0000)]
Fix Ada comparison failure on SPARC
* ipa-predicate.c (add_condition): Restore inverted test.
From-SVN: r274277
Martin Liska [Mon, 12 Aug 2019 07:36:48 +0000 (09:36 +0200)]
Move is_valid_fd to filedescriptor.c file.
2019-08-12 Martin Liska <mliska@suse.cz>
* Makefile.in: Add filedescriptor.c.
* filedescriptor.c: New file.
* lrealpath.c (is_valid_fd): Remove.
From-SVN: r274273
GCC Administrator [Mon, 12 Aug 2019 00:16:25 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274272
Janne Blomqvist [Sun, 11 Aug 2019 09:42:41 +0000 (12:42 +0300)]
PR fortran/91413 Generate warning when making array static
When moving a local variable from the stack to static storage, the
procedure is no longer safe to be called recursively or concurrently
from multiple threads. Thus generate a warning when this is done.
Also double the default limit for switching from stack to static.
Regtested on x86_64-pc-linux-gnu.
gcc/fortran/ChangeLog:
2019-08-11 Janne Blomqvist <jb@gcc.gnu.org>
PR fortran/91413
* invoke.texi (-fmax-stack-var-size): Document increased default.
* options.c (gfc_post_options): Increase default stack var size to
65536 bytes.
* trans-decl.c (gfc_finish_var_decl): Generate warning when local
array moved to static storage.
From-SVN: r274264
Iain Buclaw [Sun, 11 Aug 2019 06:53:14 +0000 (06:53 +0000)]
d: Fix ICE: gimplification failed (gimplify.c at 13436)
The expression that caused the ICE
++(a += 1.0);
The D front-end rewrites and applies implicit type conversions so the
expression gets simplified as
(int)((double) a += 1.0) += 1
The codegen pass would subsequently generate the following invalid code
(int)(double) a = (int)((double) a + 1.0) + 1
The LHS expression `(int)(double) a', represented as a FIX_TRUNC_EXPR
being what trips as it is not a valid lvalue for assignment.
While LHS casts are stripped away, convert_expr adds a double cast
because it converts the expression to its original type before
converting it to its target type. There is no valid reason why this is
done, so it has been removed.
gcc/d/ChangeLog:
PR d/90601
* d-convert.cc (convert_expr): Don't convert an expression to its
original front-end type before converting to its target type.
gcc/testsuite/ChangeLog:
PR d/90601
* gdc.dg/pr90601.d: New test.
From-SVN: r274263
Hans-Peter Nilsson [Sun, 11 Aug 2019 01:40:39 +0000 (01:40 +0000)]
Correct a single misfire in previous ChangeLog cleanup.
From-SVN: r274262
GCC Administrator [Sun, 11 Aug 2019 00:16:25 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r274261
Steven G. Kargl [Sat, 10 Aug 2019 18:26:13 +0000 (18:26 +0000)]
decl.c (match_old_style_init): Use a clearer error message.
2019-08-10 Steven G. Kargl <kargl@gcc.gnu.org>
* decl.c (match_old_style_init): Use a clearer error message.
* expr.c (gfc_check_assign): Update BOZ checking to provide a stricter
adherence to the Fortran standard. Use gfc_invalid_boz () to
relax errors into warnings.
* gfortran.h (gfc_isym_id): Add new ids GFC_ISYM_DFLOAT,
GFC_ISYM_FLOAT, GFC_ISYM_REALPART, and GFC_ISYM_SNGL
* intrinsic.c (add_functions): Use new ids to split REAL generic into
REAL, FLOAT, DFLOAT, SNGL, and REALPART generics.
(gfc_intrinsic_func_interface): Allow new intrinsics in an
initialization expression
* resolve.c (resolve_operator): Deal with BOZ as operands.
Use gfc_invalid_boz to allow for errors or warnings via the
-fallow-invalid-boz option. A BOZ cannot be an operand to an
unary operator. Both operands of a binary operator cannot be BOZ.
For binary operators, convert a BOZ operand into the type and
kind of the other operand for REAL or INTEGER operand.
* trans-intrinsic.c: Use new ids to cause conversions to happen.
2019-08-10 Steven G. Kargl <kargl@gcc.gnu.org>
* gfortran.dg/boz_8.f90: Adjust error messages.
* gfortran.dg/nan_4.f90: Ditto.
* gfortran.dg/boz_1.f90: Add -fallow-invalid-boz to dg-options,
and test for warnings.
* gfortran.dg/boz_3.f90: Ditto.
* gfortran.dg/boz_4.f90: Ditto.
* gfortran.dg/dec_structure_6.f90: Ditto.
* gfortran.dg/ibits.f90: Ditto.
From-SVN: r274257
Iain Buclaw [Sat, 10 Aug 2019 14:11:49 +0000 (14:11 +0000)]
d: Fix internal compiler error: in add_expr, at tree.c:7794
gcc/d/ChangeLog:
PR d/91238
* d-codegen.cc (build_address): If taking the address of a CALL_EXPR,
wrap it in a TARGET_EXPR.
gcc/testsuite/ChangeLog:
PR d/91238
* gdc.dg/pr91238.d: New test.
From-SVN: r274253
Jakub Jelinek [Sat, 10 Aug 2019 10:18:25 +0000 (12:18 +0200)]
tree-core.h (enum omp_clause_code): Add OMP_CLAUSE_DEVICE_TYPE.
* tree-core.h (enum omp_clause_code): Add OMP_CLAUSE_DEVICE_TYPE.
(enum omp_clause_device_type_kind): New enum.
(struct tree_omp_clause): Add subcode.device_type_kind.
* tree.h (OMP_CLAUSE_DEVICE_TYPE_KIND): Define.
* tree.c (omp_clause_num_ops, omp_clause_code_name): Add entries
for device_type clause.
(walk_tree_1): Handle OMP_CLAUSE_DEVICE_TYPE.
* tree-pretty-print.c (dump_omp_clause): Likewise.
c-family/
* c-pragma.h (enum pragma_omp_clause): Add
PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
c/
* c-parser.c (c_parser_omp_clause_name): Parse device_type.
(c_parser_omp_clause_device_type): New function.
(c_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(OMP_DECLARE_TARGET_CLAUSE_MASK): Add PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(c_parser_omp_declare_target): Handle device_type clauses. Remove
diagnostics for declare target with clauses nested in clause-less
declare target declaration-definition-seq.
* c-typeck.c (c_finish_omp_clauses): Handle OMP_CLAUSE_DEVICE_TYPE.
cp/
* parser.c (cp_parser_omp_clause_name): Parse device_type.
(cp_parser_omp_clause_device_type): New function.
(cp_parser_omp_all_clauses): Handle PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(OMP_DECLARE_TARGET_CLAUSE_MASK): Add PRAGMA_OMP_CLAUSE_DEVICE_TYPE.
(cp_parser_omp_declare_target): Handle device_type clauses. Remove
diagnostics for declare target with clauses nested in clause-less
declare target declaration-definition-seq.
* semantics.c (finish_omp_clauses): Handle OMP_CLAUSE_DEVICE_TYPE.
testsuite/
* c-c++-common/gomp/declare-target-2.c: Don't expect error for
declare target with clauses in between declare target without clauses
and end declare target.
* c-c++-common/gomp/declare-target-4.c: New test.
From-SVN: r274252
Jakub Jelinek [Sat, 10 Aug 2019 10:13:52 +0000 (12:13 +0200)]
re PR target/91408 (ICE in extract_insn, at recog.c:2310 since r273981)
PR target/91408
* config/i386/mmx.md (usadv8qi): Use register_operand instead of
vector_operand.
* gcc.target/i386/pr91408.c: New test.
From-SVN: r274251
Jakub Jelinek [Sat, 10 Aug 2019 09:59:17 +0000 (11:59 +0200)]
Assorted ChangeLog cleanups.
From-SVN: r274250
Iain Buclaw [Sat, 10 Aug 2019 05:25:44 +0000 (05:25 +0000)]
Fix ODR violation in d/runtime.cc
gcc/d/ChangeLog:
PR d/90893
* runtime.cc (enum libcall_type): Rename to...
(enum d_libcall_type): ...this.
(get_libcall_type): Use d_libcall_type.
(build_libcall_decl): Likewise.
From-SVN: r274249
projects / gcc.git / log