mesa.git
4 years agoradv: update internal reference
Erik Faye-Lund [Mon, 20 Apr 2020 11:11:10 +0000 (13:11 +0200)]
radv: update internal reference

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs/relnotes: update internal references
Erik Faye-Lund [Mon, 20 Apr 2020 11:40:10 +0000 (13:40 +0200)]
docs/relnotes: update internal references

I'm not 100% sure if it feels right to update these. I mean, this keeps
links working as they should, even if exported to something else than
HTML. But it also feels a bit like history revisionism. It's probably
the right thing to do, though.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: update internal references
Erik Faye-Lund [Mon, 20 Apr 2020 11:10:12 +0000 (13:10 +0200)]
docs: update internal references

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agoREADME: update references to internal docs
Erik Faye-Lund [Mon, 20 Apr 2020 11:07:37 +0000 (13:07 +0200)]
README: update references to internal docs

These documents are no longer HTML files, so the internal reference
should be updated.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: drop news in favour of the introduction as index-page
Erik Faye-Lund [Thu, 30 Jan 2020 18:27:17 +0000 (19:27 +0100)]
docs: drop news in favour of the introduction as index-page

This kind of only makes sense once we have a separate home-page. But I
think this is a good way of showing why we should do this; Sphinx
doesn't support pagination, because it's not meant as a general-purpose
website framewrork. And for documentation, pagination is not really
something you need.

There's probably a lot more pages that should be moved into a separate
webpage, similar to this. In general, I think this should be done for
pages that don't relate to the source code too much, e.g isn't needed to
understand the code, or for instance explains how to get the source code.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agogitlab-ci: build and deploy docs
Erik Faye-Lund [Mon, 27 May 2019 15:12:10 +0000 (17:12 +0200)]
gitlab-ci: build and deploy docs

Dunno if alpine is a good idea. It's what the gitlab docs use for most
of their examples, so that's what I've gone with... Can probably be
changed to something else if wanted.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: include specs into the generated docs
Erik Faye-Lund [Sat, 18 Apr 2020 09:54:11 +0000 (11:54 +0200)]
docs: include specs into the generated docs

Unfortunately, it doesn't seem like there's a way to have sphinx copy
this without moving the files, becasue html_extra_path doesn't copy the
directory itself when given a directory, only files inside and
subdirectories.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: bundle extra files
Erik Faye-Lund [Sat, 18 Apr 2020 09:44:57 +0000 (11:44 +0200)]
docs: bundle extra files

These are documents that are bundled in the root of the website, and
contains some useful, extra documentation. Let's include them.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: use rst-note for highlighted text
Erik Faye-Lund [Sat, 18 Apr 2020 10:55:14 +0000 (12:55 +0200)]
docs: use rst-note for highlighted text

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: reformat license table as rst table
Erik Faye-Lund [Sat, 18 Apr 2020 09:20:31 +0000 (11:20 +0200)]
docs: reformat license table as rst table

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: use rst footnotes instead of manual ones
Erik Faye-Lund [Sat, 18 Apr 2020 09:07:53 +0000 (11:07 +0200)]
docs: use rst footnotes instead of manual ones

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: Add the favicon to the new page.
Laura Ekstrand [Mon, 11 Jun 2018 22:42:39 +0000 (15:42 -0700)]
docs: Add the favicon to the new page.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: do not copy source-files to site
Erik Faye-Lund [Mon, 10 Jun 2019 18:15:08 +0000 (20:15 +0200)]
docs: do not copy source-files to site

These docs have publically available sources in the first place, there's
no point in including a copy of them here as well.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: Remove version.
Laura Ekstrand [Wed, 6 Jun 2018 21:43:35 +0000 (14:43 -0700)]
docs: Remove version.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: add xlibdriver to table-of-contents
Erik Faye-Lund [Tue, 4 Jun 2019 15:29:39 +0000 (17:29 +0200)]
docs: add xlibdriver to table-of-contents

It's not so nice to have a hidden article, so let's add this one to the
TOC under "User Topics".

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: drop open-coded toc for articles
Erik Faye-Lund [Sat, 18 Apr 2020 10:57:44 +0000 (12:57 +0200)]
docs: drop open-coded toc for articles

Sphinx already provides a proper table-of-contents, so we don't need to
roll our own.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: use code-blocks
Erik Faye-Lund [Tue, 4 Jun 2019 12:14:13 +0000 (14:14 +0200)]
docs: use code-blocks

Sphinx can syntax-highlight a block if we use the right syntax.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: format notes as rst-notes
Erik Faye-Lund [Tue, 4 Jun 2019 08:39:58 +0000 (10:39 +0200)]
docs: format notes as rst-notes

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: include meson in the toctree
Laura Ekstrand [Fri, 18 May 2018 23:28:49 +0000 (16:28 -0700)]
docs: include meson in the toctree

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: use code-block with caption instead of table
Erik Faye-Lund [Mon, 6 May 2019 12:18:23 +0000 (14:18 +0200)]
docs: use code-block with caption instead of table

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: disable syntax-highlighting by default
Erik Faye-Lund [Tue, 4 Jun 2019 13:15:39 +0000 (15:15 +0200)]
docs: disable syntax-highlighting by default

The default is python, which we don't really do a whole lot of in
our docs, so let's just disable to none instead.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: use sphinx
Erik Faye-Lund [Thu, 2 May 2019 21:21:36 +0000 (23:21 +0200)]
docs: use sphinx

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: fixup heading-levels
Erik Faye-Lund [Sat, 18 Apr 2020 10:38:05 +0000 (12:38 +0200)]
docs: fixup heading-levels

I have no idea why pandoc messed up these headers...

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: fixup broken rst
Erik Faye-Lund [Tue, 4 Jun 2019 12:14:27 +0000 (14:14 +0200)]
docs: fixup broken rst

This removes a bit of markup, because it seems rst doesn't really
support markup on links this way. I'm not sure why Pandoc generates
this, but it misrenders.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: escape trailing underscores properly
Erik Faye-Lund [Tue, 4 Jun 2019 14:45:37 +0000 (16:45 +0200)]
docs: escape trailing underscores properly

In reStructuredText, a trailing underscore means a hyperlink reference,
but it seems pandoc doesn't get this right for symbols that have already
been escaped. So let's manually fix these up.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: escape asterisks
Erik Faye-Lund [Tue, 4 Jun 2019 14:40:20 +0000 (16:40 +0200)]
docs: escape asterisks

Seems pandoc messed these up, and left out some escpaing. Let's fix it
up by hand.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: escape double colons
Erik Faye-Lund [Tue, 4 Jun 2019 12:14:27 +0000 (14:14 +0200)]
docs: escape double colons

It seems pandoc doesn't really understand that double colons needs to be
escaped. So let's fix that up by hand.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: fixup botched table
Erik Faye-Lund [Thu, 2 May 2019 19:20:51 +0000 (21:20 +0200)]
docs: fixup botched table

Pandoc silently fails on colspan, breaking this table. But rst supports
this just fine, so let's just hand-convert this table instead.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: delete no longer needed file
Erik Faye-Lund [Sat, 18 Apr 2020 09:32:07 +0000 (11:32 +0200)]
docs: delete no longer needed file

These files were used by the theming of the old website, and is no
longer needed.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agoTEMP: remove rst-conversion scripts
Erik Faye-Lund [Sun, 19 Apr 2020 09:39:28 +0000 (11:39 +0200)]
TEMP: remove rst-conversion scripts

These have now served their purpose, so let's get rid of them again.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agodocs: convert articles to reructuredtext
Erik Faye-Lund [Fri, 12 Jun 2020 18:09:42 +0000 (20:09 +0200)]
docs: convert articles to reructuredtext

This uses the previously added scripts to convert the documentation to
reStructuredText, which is both easier to read offline, and can be used
to generate modern HTML for online documentation.

No modification to the generated results have been done.

Acked-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agoTEMP: add rst-conversion scripts
Erik Faye-Lund [Mon, 10 Jun 2019 17:08:35 +0000 (19:08 +0200)]
TEMP: add rst-conversion scripts

This is just a temporary commit, adding the scripts that performs the
automated conversion of the docs. The next commit contains the results
of the conversion, and the commit following that removes these scripts
again.

To redo the conversion in the next commit, rebase interactively to edit
this commit and delete the next one, and run './update-docs.sh' from the
root directory. Then continue the rebasing, and resolve any conflicts
that might have occurred in the manual fixes on top. Finally, build the
documentation to ensure no further fixups are needed.

Reviewed-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4630>

4 years agoiris: drop dead #include "config.h"
Eric Engestrom [Fri, 5 Jun 2020 08:39:19 +0000 (10:39 +0200)]
iris: drop dead #include "config.h"

There hasn't been a config.h in a long time (it was an artifact of the
autotool build).

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5350>

4 years agoi965: drop dead #include "config.h"
Eric Engestrom [Fri, 5 Jun 2020 08:38:31 +0000 (10:38 +0200)]
i965: drop dead #include "config.h"

There hasn't been a config.h in a long time (it was an artifact of the
autotool build).

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5350>

4 years agodocs: update the blocks of unused EGL enums assigned to us
Eric Engestrom [Wed, 3 Jun 2020 09:35:50 +0000 (11:35 +0200)]
docs: update the blocks of unused EGL enums assigned to us

See src/egl/generate/egl.xml for reference.

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5309>

4 years agointel/genxml: replace gen_sort_tags.py MIT licence with SPDX equivalent
Eric Engestrom [Fri, 5 Jun 2020 14:45:29 +0000 (16:45 +0200)]
intel/genxml: replace gen_sort_tags.py MIT licence with SPDX equivalent

Much more readable with the same information :)

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5362>

4 years agointel/genxml: drop python 2 support for gen_sort_tags.py
Eric Engestrom [Fri, 5 Jun 2020 14:41:44 +0000 (16:41 +0200)]
intel/genxml: drop python 2 support for gen_sort_tags.py

Python 2 is dead and this script is only run by devs, all of which have
had python3 available for basically forever.

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5362>

4 years agov3d: add missing unlock() in error path
Eric Engestrom [Fri, 29 May 2020 18:19:22 +0000 (20:19 +0200)]
v3d: add missing unlock() in error path

CoverityID: 1435701
Fixes: e5a81ac70431502bc592 ("broadcom/vc5: Don't forget to get the BO offset when opening a dmabuf.")
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5263>

4 years agoturnip: remove some dead/redundant code
Jonathan Marek [Thu, 16 Apr 2020 19:44:06 +0000 (15:44 -0400)]
turnip: remove some dead/redundant code

A bit of cleanup to reduce noise in the codebase.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5447>

4 years agoci/bare-metal: Terminate the job with an error on kernel panic.
Eric Anholt [Tue, 9 Jun 2020 17:00:17 +0000 (10:00 -0700)]
ci/bare-metal: Terminate the job with an error on kernel panic.

Otherwise, we'll time out after 60 minutes of waiting for the run to
complete.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2651
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5393>

4 years agoci/bare-metal: Stop fetching the git tree.
Eric Anholt [Mon, 8 Jun 2020 22:36:16 +0000 (15:36 -0700)]
ci/bare-metal: Stop fetching the git tree.

Like for LAVA, make the tradeoff of moving the test scripts and data (55k)
into the artifacts in order to make the per-build jobs not have to pull
down the git tree (hundreds of MB when you don't hit a cached container
for your specific user, which I see happen multiple times a day in my CI
runs).

To do this, we have to be a bit more careful in some places about our
working directory potentially being dirty.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5393>

4 years agoci/bare-metal: Use the deqp-runner bits straight out of the artifacts.
Eric Anholt [Mon, 8 Jun 2020 22:09:51 +0000 (15:09 -0700)]
ci/bare-metal: Use the deqp-runner bits straight out of the artifacts.

We've already uploaded and downloaded them from fd.o and put them in the
rootfs, so we can clean up the extra prep work.

Our test job now extends from .test so that the artifacts' install dir
with all the scripts is extracted.  This required moving the dependency on
meson-testing to the x86 test-gl/test-vk job blocks.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5393>

4 years agoci/bare-metal: Make which test to run configurable.
Eric Anholt [Mon, 8 Jun 2020 22:23:52 +0000 (15:23 -0700)]
ci/bare-metal: Make which test to run configurable.

I'll use this to run tracie in a new job I'm working on.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5393>

4 years agoci/bare-metal: Reword the final output of the init script on the board.
Eric Anholt [Mon, 8 Jun 2020 21:55:53 +0000 (14:55 -0700)]
ci/bare-metal: Reword the final output of the init script on the board.

I'm going to be adding tracie, which isn't deqp.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5393>

4 years agopanfrost: Tiled to linear layout conversion
Icecream95 [Sun, 19 Apr 2020 03:44:17 +0000 (15:44 +1200)]
panfrost: Tiled to linear layout conversion

Tiling is expensive, so this patch converts textures that appear to be
used for streaming to a linear layout.

Performance of mpv is significantly improved, with software-decoded
1080p mp4 playback on RK3288 going from 30fps to 50fps when testing
with `--untimed --no-audio`.

To keep things simple, conversion only happens when updating the whole
texture and no mipmapping is used.

v2: Make it clear that the heuristic doesn't rely on a texture being
uninitialized, since layout switching code can get confusing (Alyssa).

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4628>

4 years agopanfrost: Create a new sampler view bo when the layout changes
Icecream95 [Fri, 12 Jun 2020 08:14:02 +0000 (20:14 +1200)]
panfrost: Create a new sampler view bo when the layout changes

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4628>

4 years agopanfrost: Move sampler view bo creation to a separate function
Icecream95 [Thu, 30 Apr 2020 03:21:17 +0000 (15:21 +1200)]
panfrost: Move sampler view bo creation to a separate function

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4628>

4 years agointel/compiler: Drop opt_sampler_eot()
Matt Turner [Tue, 9 Jun 2020 20:51:10 +0000 (13:51 -0700)]
intel/compiler: Drop opt_sampler_eot()

Gen9 and Cherryview have the ability to mark texture instructions with
the End-of-thread bit under some conditions, which allows the texture
result to be written to the render target directly, rather than
returning to the EU.

In order to handle overlapping primitives correctly, we have to use the
'sendc' instruction which stalls until other threads potentially writing
to the same locations in the render target are retired. Unfortunately,
this stall happens before the texture is sampled (rather than in
parallel with stall), so for some literal edge cases (like the diagonal
edge between two triangles forming a rectangle) there can be a
performance penalty. As a result, it's probably not a good idea to use
this optimization in general.

I had planned to leave it enabled only for BLORP, where we use rectangle
primitives and are typically clearing/blitting an entire render target
without any overlapping primitives, but I noticed that the optimization
wasn't applied in some normal cases anyway. For example, in the piglit
test tests/shaders/glsl-fs-texture2d-bias.shader_test it is applied to
one BLORP-blit shader but not another due to some kind of mishandling of
register types (the destination register type of the texture operation
is UD while the color source of the render target write is F).

Additionally the instruction scheduler assumed that the combined texture
and render target write operation took 0 cycles, leading to cycle
estimates that are wildly inaccurate. Since the optimization was not
implemented for SIMD32 and our decision whether to use the SIMD32
program is made by comparing the estimated performance with that of the
SIMD16 shader, we wrongly threw out a bunch of SIMD32 programs that are
likely profitable.

   total cycles in shared programs: 472807891 -> 473784245 (0.21%)
   cycles in affected programs: 108277 -> 1084631 (901.72%)
   helped: 0
   HURT: 1290

   total sends in shared programs: 998955 -> 1000245 (0.13%)
   sends in affected programs: 1400 -> 2690 (92.14%)
   helped: 0
   HURT: 1290

   LOST:   0
   GAINED: 33

This patch shows no performance changes in Intel's Mesa performance CI.

Given the problems, the lack of evidence that the pass improves
performance, and the fact that the hardware feature was removed from
subsequent GPU generations, I think that the pass is not valuable and
should be removed.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Matt Turner <mattst88@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5412>

4 years agoci: Disable some flaky tests on turnip.
Eric Anholt [Thu, 11 Jun 2020 16:00:35 +0000 (09:00 -0700)]
ci: Disable some flaky tests on turnip.

These have appeared more than once in the flake reporting channel, and a
couple of them have spuriously failed marge-bot merges.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5429>

4 years agoci: Fix weird filesystem globs appearing in failed test .qpa files.
Eric Anholt [Thu, 11 Jun 2020 20:19:11 +0000 (13:19 -0700)]
ci: Fix weird filesystem globs appearing in failed test .qpa files.

When you get a filure and go looking in the results, you'll find weird stuff like this in the XML:

Reference images fill undefined pixels with 3x3 grid pattern.
Attachment 0 (p' = p bin boot builds
dEQP-VK.renderpass.suballocation.attachment_allocation.grow_shrink.89.qpa
deqp dev etc home init install lib media mnt proc results root run sbin
set-job-env-vars.sh sys tmp usr var (1, 1, 1, 1) + (-1, -1, -1, 1))

because we were not quoting the line and 'p *' was getting expanded.

Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5435>

4 years agodocs: update calendar, add news item, and link releases notes for 20.0.8
Dylan Baker [Fri, 12 Jun 2020 17:02:05 +0000 (10:02 -0700)]
docs: update calendar, add news item, and link releases notes for 20.0.8

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5444>

4 years agodocs: Add sha256sums for 20.0.8
Dylan Baker [Fri, 12 Jun 2020 01:37:10 +0000 (18:37 -0700)]
docs: Add sha256sums for 20.0.8

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5444>

4 years agodocs: Add release notes for 20.0.8
Dylan Baker [Fri, 12 Jun 2020 01:17:30 +0000 (18:17 -0700)]
docs: Add release notes for 20.0.8

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5444>

4 years agopan/mdg: Prefer type over regmode for schedule constraints
Alyssa Rosenzweig [Fri, 12 Jun 2020 16:22:54 +0000 (12:22 -0400)]
pan/mdg: Prefer type over regmode for schedule constraints

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5443>

4 years agopan/mdg: Analyze types for 64-bitness in RA
Alyssa Rosenzweig [Fri, 12 Jun 2020 16:21:11 +0000 (12:21 -0400)]
pan/mdg: Analyze types for 64-bitness in RA

Instead of reg_mode.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5443>

4 years agopan/mdg: Explicitly type 64-bit uniform moves
Alyssa Rosenzweig [Fri, 12 Jun 2020 16:20:52 +0000 (12:20 -0400)]
pan/mdg: Explicitly type 64-bit uniform moves

Instead of relying on reg_mode.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5443>

4 years agoturnip: add emit renderpass cache flushes for sysmem 3D CmdClearAttachments
Jonathan Marek [Thu, 11 Jun 2020 13:49:23 +0000 (09:49 -0400)]
turnip: add emit renderpass cache flushes for sysmem 3D CmdClearAttachments

This clear path behaves like a draw, it needs the same flush as tu_draw.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5426>

4 years agoturnip: add layered 3D path clear for CmdClearAttachments
Jonathan Marek [Thu, 11 Jun 2020 13:34:28 +0000 (09:34 -0400)]
turnip: add layered 3D path clear for CmdClearAttachments

This fixes cases where the 3D path is used with layered rendering.

Fixes dEQP-VK.renderpass.suballocation.multisample_resolve.layers* failures

Note the blob's 3D fallback path behaves differently, and uses the
framebuffer information to clear each layer individually (changing the MRT
state each time). But that's not possible in all cases, and the blob fails
to clear properly in dEQP-VK.geometry.layered.*.secondary_cmd_buffer cases.
So this clear path is not based on the blob's behavior.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5426>

4 years agoturnip: share code between 3D blit/clear path and tu_pipeline
Jonathan Marek [Thu, 11 Jun 2020 12:38:18 +0000 (08:38 -0400)]
turnip: share code between 3D blit/clear path and tu_pipeline

Instead of filling out registers manually, fill out ir3 structs and re-use
code from tu_pipeline.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5426>

4 years agoturnip: pipeline program state refactor
Jonathan Marek [Thu, 11 Jun 2020 00:32:17 +0000 (20:32 -0400)]
turnip: pipeline program state refactor

This refactor simplifies things a bit, and will make it easier to share
some logic with tu_clear_blit (see next patches).

This changes the order in which some things are emitted, and emits less
for disabled shader stages. There's also as extra write to SP_GS_PRIM_SIZE
that is removed.

Signed-off-by: Jonathan Marek <jonathan@marek.ca>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5426>

4 years agopanfrost: Demote mediump varyings to fp16
Alyssa Rosenzweig [Tue, 9 Jun 2020 22:15:20 +0000 (18:15 -0400)]
panfrost: Demote mediump varyings to fp16

Likewise lowp.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Override varying format to minimal precision
Alyssa Rosenzweig [Mon, 8 Jun 2020 22:11:29 +0000 (18:11 -0400)]
panfrost: Override varying format to minimal precision

Spec allows this!

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Use shader_info harder
Alyssa Rosenzweig [Mon, 8 Jun 2020 22:05:21 +0000 (18:05 -0400)]
panfrost: Use shader_info harder

We already have this metadata..

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Only store varying formats
Alyssa Rosenzweig [Wed, 10 Jun 2020 19:48:33 +0000 (15:48 -0400)]
panfrost: Only store varying formats

This reduces linking complexity.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Allow R/RG/RGB varyings
Alyssa Rosenzweig [Wed, 10 Jun 2020 19:47:45 +0000 (15:47 -0400)]
panfrost: Allow R/RG/RGB varyings

This can be a bandwidth savings.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Remove unused routines
Alyssa Rosenzweig [Mon, 8 Jun 2020 21:46:05 +0000 (17:46 -0400)]
panfrost: Remove unused routines

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Use new varying linking
Alyssa Rosenzweig [Thu, 4 Jun 2020 19:45:34 +0000 (15:45 -0400)]
panfrost: Use new varying linking

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Add high-level varying emit
Alyssa Rosenzweig [Mon, 8 Jun 2020 19:29:05 +0000 (15:29 -0400)]
panfrost: Add high-level varying emit

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Add helper to determine if we are capturing
Alyssa Rosenzweig [Wed, 10 Jun 2020 19:13:12 +0000 (15:13 -0400)]
panfrost: Add helper to determine if we are capturing

That is, is the varying setup for xfb *and* is there a buffer for it?

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Emit xfb records
Alyssa Rosenzweig [Mon, 8 Jun 2020 18:08:45 +0000 (14:08 -0400)]
panfrost: Emit xfb records

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Emit special varyings
Alyssa Rosenzweig [Mon, 8 Jun 2020 17:52:38 +0000 (13:52 -0400)]
panfrost: Emit special varyings

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Emit unlinked varyings
Alyssa Rosenzweig [Mon, 8 Jun 2020 17:45:17 +0000 (13:45 -0400)]
panfrost: Emit unlinked varyings

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Determine varying buffer presence
Alyssa Rosenzweig [Mon, 8 Jun 2020 17:32:38 +0000 (13:32 -0400)]
panfrost: Determine varying buffer presence

Essentially the same logic as before, but the assumptions are much more
explicit.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Introduce bitfields for tracking varyings
Alyssa Rosenzweig [Mon, 8 Jun 2020 16:56:33 +0000 (12:56 -0400)]
panfrost: Introduce bitfields for tracking varyings

Rather than having all sorts of random state flyng about with varying
emission, we can use a simple present mask and general stride to encode
everything we need for non-XFB cases, and layer XFB on top easily
enough.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Add panfrost_streamout_offset helper
Alyssa Rosenzweig [Wed, 10 Jun 2020 23:28:28 +0000 (19:28 -0400)]
panfrost: Add panfrost_streamout_offset helper

Calculates the bias required for an xfb record in the src_offset field
to account for truncating the address to force alignment.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopanfrost: Calculate varying size by format
Alyssa Rosenzweig [Wed, 10 Jun 2020 19:35:41 +0000 (15:35 -0400)]
panfrost: Calculate varying size by format

Will enable <16-byte varyings.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agopan/mdg: Avoid fusing ld_vary_16 with non-zero component
Alyssa Rosenzweig [Wed, 10 Jun 2020 18:06:43 +0000 (14:06 -0400)]
pan/mdg: Avoid fusing ld_vary_16 with non-zero component

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5423>

4 years agoaco: fix shared subdword loads
Daniel Schürmann [Fri, 12 Jun 2020 10:59:27 +0000 (11:59 +0100)]
aco: fix shared subdword loads

Shared subdword loads don't need byte alignment as they are split
into multiple loads if necessary.

Fixes: 5cde4989d3c8c25b0ba2a11ec450625e30092b16 ('aco: remove unnecessary split- and create_vector instructions for subdword loads')
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5441>

4 years agoradv: enable radv_enable_mrt_output_nan_fixup for RAGE 2
Samuel Pitoiset [Fri, 5 Jun 2020 12:25:20 +0000 (14:25 +0200)]
radv: enable radv_enable_mrt_output_nan_fixup for RAGE 2

To fix game artifacts. It's always sad to have to fix game bugs
inside drivers ...

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5359>

4 years agoradv/llvm: implement radv_enable_mrt_output_nan_fixup workaround
Samuel Pitoiset [Fri, 5 Jun 2020 13:05:07 +0000 (15:05 +0200)]
radv/llvm: implement radv_enable_mrt_output_nan_fixup workaround

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5359>

4 years agoaco: implement radv_enable_mrt_output_nan_fixup workaround
Samuel Pitoiset [Fri, 5 Jun 2020 12:28:09 +0000 (14:28 +0200)]
aco: implement radv_enable_mrt_output_nan_fixup workaround

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5359>

4 years agoradv: add new drirc option radv_enable_mrt_output_nan_fixup
Samuel Pitoiset [Fri, 5 Jun 2020 12:24:33 +0000 (14:24 +0200)]
radv: add new drirc option radv_enable_mrt_output_nan_fixup

To replace NaN from FS with zeros to fix game bugs.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5359>

4 years agoglsl: fix incorrect optimisation in opt_constant_variable()
Timothy Arceri [Wed, 10 Jun 2020 05:19:22 +0000 (15:19 +1000)]
glsl: fix incorrect optimisation in opt_constant_variable()

When handling function inputs the optimisation pass incorrectly
assumes the inputs are undefined. Here we simply change things to
assume inputs have always been assigned a value. Any further
optimisations will be taken care of once function inlining takes
place.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2984
Fixes: 65122e9e8038 ("ir_constant_variable: New pass to mark constant-assigned variables constant.")
Reviewed-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5413>

4 years agoradv: set DB_SHADER_CONTROL.CONSERVATIVE_Z_EXPORT correctly
Samuel Pitoiset [Tue, 9 Jun 2020 15:59:00 +0000 (17:59 +0200)]
radv: set DB_SHADER_CONTROL.CONSERVATIVE_Z_EXPORT correctly

Use the SPIR-V execution modes if set.

Cc: 20.1 <mesa-stable@lists.freedesktop.org>
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5404>

4 years agoandroid: nvir/gv100: update sources in Makefile.sources
Mauro Rossi [Thu, 11 Jun 2020 19:47:12 +0000 (21:47 +0200)]
android: nvir/gv100: update sources in Makefile.sources

Fixes the following building errors:

FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so
...
ld.lld: error: undefined symbol: nv50_ir::getTargetGV100(unsigned int)
...
ld.lld: error: undefined symbol: nv50_ir::getTargetGV100(unsigned int)
clang-9: error: linker command failed with exit code 1 (use -v to see invocation)

Fixes: 78103abe ("nvir/gv100: initial support")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Reviewed-by: Karol Herbst <kherbst@redhat.com>
4 years agofreedreno/ir3: limit pre-fetched tex dest
Rob Clark [Thu, 11 Jun 2020 19:03:03 +0000 (12:03 -0700)]
freedreno/ir3: limit pre-fetched tex dest

Teach RA to setup additional interference to prevent textures fetched
before the FS starts from ending up in a register that is too high to
encode.

Fixes mis-rendering in multiple playcanv.as webgl apps.

Note that the regression was not actually 733bee57eb8's fault, but
that was the commit that exposed the problem.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3108
Fixes: 733bee57eb8 ("glsl: lower samplers with highp coordinates correctly")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5431>

4 years agofreedreno/ir3: remove RA "q-values" optimization
Rob Clark [Thu, 11 Jun 2020 21:56:29 +0000 (14:56 -0700)]
freedreno/ir3: remove RA "q-values" optimization

This is mainly the "piglit optimization" (ie, since piglit launches an
separate process for for each test).  It was never wired up for a6xx,
and makes register class setup unnecessarily complicated.  Remove it to
simplify the next patch.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5431>

4 years agofreedreno/ir3: respect tex prefetch limits
Rob Clark [Thu, 11 Jun 2020 18:00:55 +0000 (11:00 -0700)]
freedreno/ir3: respect tex prefetch limits

Refactor a bit the limit checking in the bindless case, and add tex/samp
limit checking for the non-bindless case, to ensure we do not try to
prefetch textures which cannot be encoded in the # of bits available.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5431>

4 years agofreedreno/ir3: add debug code to print conflicting half-regs
Rob Clark [Thu, 11 Jun 2020 16:47:05 +0000 (09:47 -0700)]
freedreno/ir3: add debug code to print conflicting half-regs

I keep re-typing this from time to time when debugging various things.
Which is dumb.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5431>

4 years agonir/print: print tex dest type
Rob Clark [Thu, 11 Jun 2020 16:43:11 +0000 (09:43 -0700)]
nir/print: print tex dest type

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5431>

4 years agoiris/icl+: Report same caching domain as main surface for clear color BO.
Francisco Jerez [Tue, 9 Jun 2020 22:23:30 +0000 (15:23 -0700)]
iris/icl+: Report same caching domain as main surface for clear color BO.

Even though the clear color BO is bound as a read-only buffer, report
the same caching domain as the main BO in use_surface() (typically
IRIS_DOMAIN_RENDER_WRITE) in order to avoid ping-ponging back and
forth between IRIS_DOMAIN_RENDER_WRITE and IRIS_DOMAIN_OTHER_READ,
which leads to increased stall-at-pixel-scoreboard synchronization
between draw calls.

Fixes a 5%-10% FPS regression in some benchmarks spotted on ICL.

Reported-by: Clayton Craft <clayton.a.craft@intel.com>
Fixes: eb5d1c27227302167d299 "iris: Annotate all BO uses with domain and sequence number information."
Closes: #3097
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5411>

4 years agoandroid: aco: add aco_ir.cpp to Makefile.sources
Mauro Rossi [Thu, 11 Jun 2020 06:17:02 +0000 (08:17 +0200)]
android: aco: add aco_ir.cpp to Makefile.sources

Fixes the following building errors:

FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/vulkan.radv_intermediates/LINKED/vulkan.radv.so
...
ld.lld: error: undefined symbol: aco::can_use_SDWA(chip_class, std::__1::unique_ptr<aco::Instruction, aco::instr_deleter_functor> const&)
...
ld.lld: error: undefined symbol: aco::can_use_opsel(chip_class, aco_opcode, int, bool)
...
clang-9: error: linker command failed with exit code 1 (use -v to see invocation)

Fixes: d9cfb8ad ("aco: validate instructions reading/writing upper halves/bytes")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5425>

4 years agodocs: update calendar, add news item, and link releases notes for 20.1.1
Eric Engestrom [Wed, 10 Jun 2020 18:43:39 +0000 (20:43 +0200)]
docs: update calendar, add news item, and link releases notes for 20.1.1

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5421>

4 years agodocs: Add release notes for 20.1.1
Eric Engestrom [Wed, 10 Jun 2020 18:01:30 +0000 (20:01 +0200)]
docs: Add release notes for 20.1.1

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5421>

4 years agoac/surface: don't free dcc_retile_map on failure
Marek Olšák [Thu, 11 Jun 2020 09:00:44 +0000 (05:00 -0400)]
ac/surface: don't free dcc_retile_map on failure

because the hash table now owns it.

Fixes: bd553f0546d - ac/surface: cache DCC retile maps (v2)
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5424>

4 years agoac/surface: enable DCC for the first level in the mip tail on gfx10
Marek Olšák [Thu, 11 Jun 2020 08:30:04 +0000 (04:30 -0400)]
ac/surface: enable DCC for the first level in the mip tail on gfx10

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5424>

4 years agoac/surface: require that gfx8 doesn't have DCC in order to be displayable
Marek Olšák [Thu, 11 Jun 2020 08:20:44 +0000 (04:20 -0400)]
ac/surface: require that gfx8 doesn't have DCC in order to be displayable

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5424>

4 years agoac/surface: don't set is_displayable if displayable DCC is missing
Marek Olšák [Wed, 10 Jun 2020 15:43:49 +0000 (11:43 -0400)]
ac/surface: don't set is_displayable if displayable DCC is missing

If flags.display isn't set, then displayable DCC will not be computed, so
is_displayable will always be false.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5424>

4 years agoamd/addrlib: fix the C++ one definition rule violation
Marek Olšák [Wed, 10 Jun 2020 12:53:40 +0000 (08:53 -0400)]
amd/addrlib: fix the C++ one definition rule violation

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/1854
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5414>

4 years agoiris: Better handle metadata in NIR passes
Jason Ekstrand [Fri, 22 May 2020 03:24:28 +0000 (22:24 -0500)]
iris: Better handle metadata in NIR passes

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5171>