Richard Biener [Fri, 28 Sep 2018 11:33:29 +0000 (11:33 +0000)]
tree.h (BLOCK_ORIGIN): New.
2018-09-28 Richard Biener <rguenther@suse.de>
* tree.h (BLOCK_ORIGIN): New.
* omp-expand.c (grid_expand_target_grid_body): Assign
BLOCK_ORIGIN to BLOCK_ABSTRACT_ORIGIN.
* tree-inline.c (remap_block): Likewise.
* auto-profile.c (get_function_decl_from_block): Simplify
by eliding the BLOCK_ABSTRACT_ORIGIN chasing.
* langhooks.c (lhd_print_error_function): Likewise.
* optinfo-emit-json.cc (optrecord_json_writer::inlining_chain_to):
Likewise.
* tree-ssa-live.c (remove_unused_scope_block_p): Likewise.
* tree.c (block_nonartificial_location): Likewise.
(block_ultimate_origin): Likewise.
* tree-pretty-print.c (percent_K_format): Likewise. Remove
no longer needed LTO case.
cp/
* error.c (cp_print_error_function): Simplify by eliding
the BLOCK_ABSTRACT_ORIGIN chasing.
From-SVN: r264689
Andrew Stubbs [Fri, 28 Sep 2018 10:54:34 +0000 (10:54 +0000)]
Simplify vec_merge according to the mask.
This patch was part of the original patch we acquired from Honza and Martin.
It simplifies nested vec_merge operations using the same mask.
Self-tests are included.
2018-09-28 Andrew Stubbs <ams@codesourcery.com>
Jan Hubicka <jh@suse.cz>
Martin Jambor <mjambor@suse.cz>
* simplify-rtx.c (simplify_merge_mask): New function.
(simplify_ternary_operation): Use it, also see if VEC_MERGEs with the
same masks are used in op1 or op2.
(test_vec_merge): New function.
(test_vector_ops): Call test_vec_merge.
Co-Authored-By: Jan Hubicka <jh@suse.cz>
Co-Authored-By: Martin Jambor <mjambor@suse.cz>
From-SVN: r264688
Eric Botcazou [Fri, 28 Sep 2018 08:47:20 +0000 (08:47 +0000)]
sparc-protos.h (sparc_branch_cost): Declare.
* config/sparc/sparc-protos.h (sparc_branch_cost): Declare.
* config/sparc/sparc.h (BRANCH_COST): Call sparc_branch_cost.
* config/sparc/sparc.c (struct processor_costs): Add branch_cost field.
(cypress_costs): Set it.
(supersparc_costs): Likewise.
(hypersparc_costs): Likewise.
(leon_cost): Likewise.
(leon3_costs): Likewise.
(sparclet_costs): Likewise.
(ultrasparc_costs): Likewise.
(ultrasparc_costs): Likewise.
(niagara_costs): Likewise.
(niagara2_costs): Likewise.
(niagara3_costs): Likewise.
(niagara4_costs): Likewise.
(niagara7_costs): Likewise.
(m8_costs): Likewise.
(TARGET_CAN_FOLLOW_JUMP): Define.
(pass_work_around_errata::gate): Minor tweak.
(sparc_option_override): Remove MASK_FSMULD mask for V7 processors.
Do not set both MASK_VIS4 and MASK_VIS4B for M8 processor.
Automaitcally clear MASK_FSMULD mask for V7 processors.
(sparc_can_follow_jump): New static function.
(output_ubranch): Deal with CROSSING_JUMP_P.
(sparc_use_sched_lookahead): Rewrite using switch statement.
(sparc_issue_rate): Reorder.
(sparc_branch_cost): New function.
From-SVN: r264687
GCC Administrator [Fri, 28 Sep 2018 00:16:43 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264685
Segher Boessenkool [Thu, 27 Sep 2018 22:56:37 +0000 (00:56 +0200)]
rs6000: Fix one more vec_splat case
This fixes the one remaining case where the stricter vec_splat checking
complains in the testsuite.
* g++.dg/ext/altivec-6.C: Change the vec_splat second argument to a
valid value, in the "vector bool int" case.
From-SVN: r264681
Martin Sebor [Thu, 27 Sep 2018 22:55:23 +0000 (22:55 +0000)]
tree.h (tree_to_shwi): Add attribute nonnull and pure.
gcc/ChangeLog:
* tree.h (tree_to_shwi): Add attribute nonnull and pure.
(tree_to_poly_int64, tree_to_uhwi, tree_to_poly_uint64): Same.
(int_fits_type_p): Same.
gcc/ada/ChangeLog:
* gcc-interface/utils.c (make_packable_type): Introduce a temporary
to avoid -Wnonnull.
(unchecked_convert): Same.
From-SVN: r264680
Jinsong Ji [Thu, 27 Sep 2018 20:48:53 +0000 (20:48 +0000)]
mmintrin.h (_mm_unpackhi_pi8): Change __int128_t to __int128.
2018-09-27 Jinsong Ji <jji@us.ibm.com>
Bill Schmidt <wschmidt@linux.ibm.com>
* config/rs6000/mmintrin.h (_mm_unpackhi_pi8): Change __int128_t
to __int128.
(_mm_unpacklo_pi8): Likewise.
(_mm_add_pi8): Likewise.
(_mm_add_pi16): Likewise.
(_mm_add_pi32): Likewise.
(_mm_sub_pi8): Likewise.
(_mm_sub_pi16): Likewise.
(_mm_sub_pi32): Likewise.
(_mm_cmpgt_pi8): Likewise.
(_mm_cmpeq_pi16): Likewise.
(_mm_cmpgt_pi16): Likewise.
(_mm_cmpeq_pi32): Likewise.
(_mm_cmpgt_pi32): Likewise.
(_mm_adds_pi8): Likewise.
(_mm_adds_pi16): Likewise.
(_mm_adds_pu8): Likewise.
(_mm_adds_pu16): Likewise.
(_mm_subs_pi8): Likewise.
(_mm_subs_pi16): Likewise.
(_mm_subs_pu8): Likewise.
(_mm_subs_pu16): Likewise.
(_mm_madd_pi16): Likewise.
(_mm_mulhi_pi16): Likewise.
(_mm_mullo_pi16): Likewise.
(_mm_sll_pi16): Likewise.
(_mm_sra_pi16): Likewise.
(_mm_srl_pi16): Likewise.
(_mm_set1_pi16): Likewise.
(_mm_set1_pi8): Likewise.
* config/rs6000/xmmintrin.h (_mm_max_pi16): Likewise.
(_mm_max_pu8): Likewise.
(_mm_min_pi16): Likewise.
(_mm_min_pu8): Likewise.
From-SVN: r264678
Uros Bizjak [Thu, 27 Sep 2018 20:21:06 +0000 (22:21 +0200)]
i386.md (UNSPEC_FLDCW): Remove.
* config/i386/i386.md (UNSPEC_FLDCW): Remove.
From-SVN: r264677
Uros Bizjak [Thu, 27 Sep 2018 20:04:15 +0000 (22:04 +0200)]
i386.md (FPSR_REG): Remove.
* config/i386/i386.md (FPSR_REG): Remove.
(x86_fnstcw_1): Use (const_int 0) instead of FPCR_REG.
(x86_fldcw_1): Remove insn pattern.
(fnstenv): Do not clobber FPCR_REG.
(fldenv): Ditto.
* config/i386/i386.h (FIXED_REGISTERS) Remove fpsr register.
(CALL_USED_REGISTERS): Ditto.
(REG_ALLOC_ORDER): Ditto.
(REG_CLASS_CONTENTS): Ditto.
(HI_REGISTER_NAMES): Ditto.
(ADDITIONAL_REGISTER_NAMES): Use defines instead
of numerical constants.
* config/i386/i386.c (regclass_map): Remove fpsr register.
(dbx_register_map): Ditto.
(dbx64_register_map): Ditto.
(svr4_dbx_register_map): Ditto.
(print_reg): Do not handle FPCR_REG.
testsuite/ChangeLog:
* gcc.dg/rtl/x86_64/dfinit.c: Update scan-rtl-dump string.
* gcc.dg/rtl/x86_64/times-two.c.before-df.c: Ditto.
* gcc.target/i386/pr79804.c (foo): Use register "19", not "20".
From-SVN: r264676
Segher Boessenkool [Thu, 27 Sep 2018 19:54:09 +0000 (21:54 +0200)]
rs6000: Delete many HAVE_AS_* (PR87149)
This deletes most HAVE_AS_* that determine if the assembler supports
some ISA level (and also HAVE_AS_MFPGPR and HAVE_AS_DFP).
These are not useful: we will only generate an instruction that requires
some newer ISA if the user specifically asked for it (with -mcpu=, say).
If the assembler cannot handle that, it is fine if it gives an error.
They also hurt: it increases the number of possible situations that all
need handling and all need testing. We do not handle all cases, and
obviously do not test all either.
This patch removes:
HAVE_AS_POPCNTB (power5, 2.02)
HAVE_AS_FPRND (power5+, 2.04)
HAVE_AS_CMPB (power6, 2.05)
HAVE_AS_POPCNTD (power7, 2.06)
HAVE_AS_POWER8 (power8, 2.07)
HAVE_AS_POWER9 (power9, 3.0)
HAVE_AS_DFP (power6, 2.05, server)
HAVE_AS_MFPGPR (power6x but not later, not arch)
PR target/87149
* config.in (HAVE_AS_CMPB, HAVE_AS_DFP, HAVE_AS_FPRND, HAVE_AS_MFPGPR,
HAVE_AS_POPCNTB, HAVE_AS_POPCNTD, HAVE_AS_POWER8, HAVE_AS_POWER9):
Delete, always treat as true.
* config/powerpcspe/powerpcspe.c (rs6000_option_override_internal):
Ditto. Simplify remaining code.
* config/powerpcspe/powerpcspe.h: Ditto.
* config/rs6000/rs6000.c (rs6000_option_override_internal): Ditto.
Simplify remaining code.
(rs6000_expand_builtin): Ditto.
* config/rs6000/rs6000.h: Ditto.
* configure.ac: Ditto.
* configure: Regenerate.
From-SVN: r264675
Martin Liska [Thu, 27 Sep 2018 14:53:35 +0000 (16:53 +0200)]
coverage.c (get_coverage_counts): Revert the formatting of missing profile opt info.
2018-09-27 Martin Liska <mliska@suse.cz>
* coverage.c (get_coverage_counts): Revert the formatting
of missing profile opt info.
* g++.dg/pr60518.C: Add -Wno-missing-profile.
* g++.dg/torture/pr59265.C: Likewise.
* g++.dg/tree-prof/morefunc.C: Likewise.
* g++.dg/tree-ssa/dom-invalid.C: Likewise.
* gcc.dg/pr26570.c: Likewise.
* gcc.dg/pr32773.c: Likewise.
* gcc.dg/pr40209.c: Likewise.
* gcc.dg/pr51957-1.c: Likewise.
* gcc.dg/pr80747.c: Likewise.
* gcc.target/aarch64/pr62262.c: Likewise.
From-SVN: r264669
Richard Biener [Thu, 27 Sep 2018 14:17:52 +0000 (14:17 +0000)]
re PR debug/87451 (FAIL: gcc.dg/debug/dwarf2/inline5.c)
2018-09-27 Richard Biener <rguenther@suse.de>
PR testsuite/87451
* gcc.dg/debug/dwarf2/inline5.c: Deal with different comment characters.
From-SVN: r264668
Richard Biener [Thu, 27 Sep 2018 14:10:45 +0000 (14:10 +0000)]
re PR debug/37801 (DWARF output for inlined functions doesn't always use DW_TAG_inlined_subroutine)
2018-09-27 Richard Biener <rguenther@suse.de>
PR debug/37801
PR debug/87440
* dwarf2out.c (set_block_origin_self): Do not mark outermost
block as we do not output that.
(gen_inlined_subroutine_die): Elide the originally outermost
block, matching what we do for concrete instances.
(decls_for_scope): Add parameter specifying whether to recurse
to subblocks.
* gcc.dg/debug/dwarf2/inline2.c: Adjust.
* gcc.dg/debug/dwarf2/inline4.c: New testcase.
From-SVN: r264667
Andrew Stubbs [Thu, 27 Sep 2018 11:15:48 +0000 (11:15 +0000)]
[pr82089] Don't sign-extend SFV 1 in BImode
This is an update of the patch posted to PR82089 long ago. We ran into the
same bug on GCN, so we need this fixed as part of this series.
2018-09-27 Andrew Stubbs <ams@codesourcery.com>
Tom de Vries <tom@codesourcery.com>
PR 82089
gcc/
* expmed.c (emit_cstore): Fix handling of result_mode == BImode and
STORE_FLAG_VALUE == 1.
Co-Authored-By: Tom de Vries <tom@codesourcery.com>
From-SVN: r264666
Paolo Carlini [Thu, 27 Sep 2018 09:53:08 +0000 (09:53 +0000)]
re PR c++/67544 (ICE: SIGSEGV in tree_check3 (tree.h:2896) with -fconcepts)
2018-09-27 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/67544
* g++.dg/concepts/pr67544.C: New.
From-SVN: r264665
Paolo Carlini [Thu, 27 Sep 2018 08:33:41 +0000 (08:33 +0000)]
re PR c++/84940 (internal compiler error: in build_value_init_noctor, at cp/init.c:465)
/cp
2018-09-27 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/84940
* semantics.c (finish_unary_op_expr): Check return value of
build_x_unary_op for error_mark_node.
/testsuite
2018-09-27 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/84940
* g++.dg/expr/unary4.C: New.
From-SVN: r264664
Andreas Krebbel [Thu, 27 Sep 2018 08:03:42 +0000 (08:03 +0000)]
S/390: Implement speculation barrier
gcc/ChangeLog:
2018-09-27 Andreas Krebbel <krebbel@linux.ibm.com>
* config/s390/s390.md (PPA_TX_ABORT, PPA_OOO_BARRIER): New
constant definitions.
("tx_assist"): Replace magic number with PPA_TX_ABORT.
("*ppa"): Enable pattern also for -march=zEC12 -mno-htm.
("speculation_barrier"): New expander definition.
From-SVN: r264663
GCC Administrator [Thu, 27 Sep 2018 00:16:55 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264661
Indu Bhagat [Wed, 26 Sep 2018 22:29:54 +0000 (22:29 +0000)]
re PR gcov-profile/86957 (gcc should warn about missing profiles for a compilation unit or a new function with -fprofile-use)
2018-09-26 Indu Bhagat <indu.bhagat@oracle.com>
PR gcov-profile/86957
* common.opt: New warning option -Wmissing-profile.
* coverage.c (get_coverage_counts): Add warning for missing .gcda file.
* doc/invoke.texi: Document -Wmissing-profile.
From-SVN: r264657
Joseph Myers [Wed, 26 Sep 2018 21:14:16 +0000 (22:14 +0100)]
Support excess precision for integer / floating-point comparisons (PR c/87390).
In C11, implicit conversions from integer to floating-point types
produce results with the range and precision of the corresponding
evaluation format rather than only those of the type implicitly
converted to. This patch implements that case of C11 excess precision
semantics in the case of a comparison between integer and
floating-point types, previously missed when implementing other cases
of excess precision for such implicit conversions. As with other such
fixes, this patch conservatively follows the reading of C99 where
conversions from integer to floating-point do not produce results with
excess precision and so the change is made for C11 mode only.
Bootstrapped with no regressions on x86_64-pc-linux-gnu.
gcc/c:
PR c/87390
* c-typeck.c (build_binary_op): Use excess precision for
comparisons of integers and floating-point for C11 and later.
gcc/testsuite:
PR c/87390
* gcc.target/i386/excess-precision-9.c,
gcc.target/i386/excess-precision-10.c: New tests.
From-SVN: r264656
Jim Wilson [Wed, 26 Sep 2018 21:06:01 +0000 (21:06 +0000)]
RISC-V: Add missing negate patterns.
gcc/
* config/riscv/riscv.md (subsi3_extended2): Add J constraint.
(negdi2, negsi2, negsi2_extended, negsi2_extended2): New.
From-SVN: r264655
Martin Sebor [Wed, 26 Sep 2018 19:03:26 +0000 (19:03 +0000)]
tree.c (zerop): Change return type to bool.
gcc/ChangeLog:
* tree.c (zerop): Change return type to bool.
(integer_zerop, integer_onep, integer_each_onep): Same.
(integer_all_onesp, integer_minus_onep, integer_pow2p): Same.
(integer_nonzerop, integer_truep, tree_ctz, real_zerop): Same.
(real_onep, real_minus_onep, chain_index): Same.
(print_type_hash_statistics, type_list_equal): Same.
* tree.h (zerop): Same.
(zerop, integer_zerop, integer_onep, integer_each_onep): Same.
(integer_all_onesp, integer_minus_onep, integer_pow2p): Same.
(integer_nonzerop, integer_truep, tree_ctz, real_zerop): Same.
(real_onep, real_minus_onep, chain_index): Same.
(print_type_hash_statistics, type_list_equal): Same.
From-SVN: r264653
Jim Wilson [Wed, 26 Sep 2018 18:42:19 +0000 (18:42 +0000)]
RISC-V: Delete obsolete MIPS comment.
gcc/
* config/riscv/riscv.h (FUNCTION_ARG_REGNO_P): Fix comment.
From-SVN: r264652
Jakub Jelinek [Wed, 26 Sep 2018 17:00:49 +0000 (19:00 +0200)]
re PR target/87414 (-mindirect-branch=thunk produces thunk with incorrect CFI on x86_64)
PR target/87414
* config/i386/i386.c: Include debug.h and dwarf2out.h.
(output_indirect_thunk): Emit DW_CFA_def_cfa_offset after the
call.
From-SVN: r264651
Andrew Stubbs [Wed, 26 Sep 2018 15:59:13 +0000 (15:59 +0000)]
Fix AArch64 ILP32 ICE.
Ensure that the address really is the correct mode for an address.
2018-09-25 Andrew Stubbs <ams@codesourcery.com>
gcc/
* builtins.c (get_builtin_sync_mem): Force address mode conversion.
From-SVN: r264650
Uros Bizjak [Wed, 26 Sep 2018 15:25:15 +0000 (17:25 +0200)]
crtprec.c (set_precision): Use fnstcw instead of fstcw.
* config/i386/crtprec.c (set_precision): Use fnstcw instead of fstcw.
From-SVN: r264649
Uros Bizjak [Wed, 26 Sep 2018 15:17:32 +0000 (17:17 +0200)]
i386.h (enum reg_class): Remove FP_TOP_SSE_REGS and FP_SECOND_SSE_REGS.
* config/i386/i386.h (enum reg_class): Remove FP_TOP_SSE_REGS
and FP_SECOND_SSE_REGS.
(REG_CLASS_NAMES): Ditto.
(REG_CLASS_CONTENTS): Ditto.
* config/i386/i386.c (ix86_preferred_reload_class) Do not handle
FP_TOP_SSE_REGS and FP_SECOND_SSE_REGS classes.
(ix86_preferred_output_reload_class): Ditto.
* config/i386/i386.md (fix_trunc<mode>_i387_fisttp): Change "=&1f"
clobber constraint to "=&f".
(fix_truncdi_i387): Ditto.
(lrintxfdi2): Ditto.
(fistdi2_<rounding>): Ditto.
(fpremxf4_i387): Change "=u" constraint to "=f".
(fprem1xf4_i387): Ditto.
(sincosxf3): Ditto.
(fptanxf4_i387): Ditto.
(fxtractxf3_i387): Ditto.
(fscalexf4_i387): Ditto.
(atan2xf3): Change "u" constraint to "f".
(fyl2xxf3_i387): Ditto.
(fyl2xp1xf3_i387): Ditto.
From-SVN: r264648
Ian Lance Taylor [Wed, 26 Sep 2018 15:17:30 +0000 (15:17 +0000)]
syscall: don't assume we have a GETEUID system call
On Alpha GNU/Linux there is no geteuid system call, there is only
getresuid. The raw geteuid system call is only used for testing, so
just skip the test if it's not available.
Reviewed-on: https://go-review.googlesource.com/137655
From-SVN: r264647
Uros Bizjak [Wed, 26 Sep 2018 15:00:00 +0000 (17:00 +0200)]
* ChangeLog: Add missing PR number.
From-SVN: r264646
Uros Bizjak [Wed, 26 Sep 2018 14:55:59 +0000 (16:55 +0200)]
re PR target/87439 (ICE in ix86_mode_needed, at config/i386/i386.c:18907)
PR target/87439
* config/i386/i386.h (NUM_MODES_FOR_MODE_SWITCHING): Update
for removed I387_MASK_PM entity.
From-SVN: r264645
Jeff Law [Wed, 26 Sep 2018 14:50:03 +0000 (08:50 -0600)]
Revert
2018-09-26 Alexey Neyman <stilor@att.net>
* graphite.h: Include <isl/id.h> and <isl/space.h>; these
headers are no longer pulled in by <isl/val.h>.
From-SVN: r264644
Richard Biener [Wed, 26 Sep 2018 14:35:48 +0000 (14:35 +0000)]
re PR debug/87443 (GCC mixes abstract and concrete instances in abstract origins for inlines)
2018-09-26 Richard Biener <rguenther@suse.de>
PR debug/87443
* dwarf2out.c (gen_lexical_block_die): Do not equate inline
or concrete instance DIE to the tree. Create abstract origin
attributes also for concrete instances.
* gcc.dg/debug/dwarf2/inline5.c: New testcase.
From-SVN: r264643
Alexey Neyman [Wed, 26 Sep 2018 14:09:03 +0000 (14:09 +0000)]
graphite.h: Include <isl/id.h> and <isl/space.h>...
* graphite.h: Include <isl/id.h> and <isl/space.h>; these
headers are no longer pulled in by <isl/val.h>.
From-SVN: r264642
Rainer Orth [Wed, 26 Sep 2018 12:56:09 +0000 (12:56 +0000)]
Ignore chmod errors during mostlyclean-local, check-go-tool
* Makefile.am (mostlyclean-local): Ignore chmod errors.
(check-go-tool): Likewise.
* Makefile.in: Regenerate.
From-SVN: r264641
Martin Jambor [Wed, 26 Sep 2018 11:58:18 +0000 (13:58 +0200)]
[PR 87347] Prevent segfaults if TYPE_ARG_TYPES is NULL
2018-09-26 Martin Jambor <mjambor@suse.cz>
PR c/87347
c/
* c-parser.c (warn_for_abs): Bail out if TYPE_ARG_TYPES is NULL. Fix
comment.
testsuite/
* gcc.dg/pr87347.c: New test.
From-SVN: r264640
Paolo Carlini [Wed, 26 Sep 2018 09:59:56 +0000 (09:59 +0000)]
re PR c++/71131 ([concepts] Ill-formed code declaring a variable with a template concept not rejected)
2018-09-26 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/71131
* g++.dg/concepts/pr71131.C: New.
2018-09-26 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/71127
* g++.dg/concepts/pr71127.C: New.
From-SVN: r264639
Paolo Carlini [Wed, 26 Sep 2018 09:23:00 +0000 (09:23 +0000)]
re PR c++/67655 ([concepts] expression constraints and variadic expansions)
2018-09-26 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/67655
* g++.dg/concepts/pr67655.C: New.
From-SVN: r264638
Elisa Barboni [Wed, 26 Sep 2018 09:20:10 +0000 (09:20 +0000)]
[Ada] SPARK: minor error message enhancement
2018-09-26 Elisa Barboni <barboni@adacore.com>
gcc/ada/
* sem_prag.adb (Check_Refined_Global_Item): Improve error
message.
From-SVN: r264637
Thomas Quinot [Wed, 26 Sep 2018 09:20:05 +0000 (09:20 +0000)]
[Ada] Fix inheritance of representation items defined as aspects
When a representation item is defined by a pragma or attribute
definition clause, the entity it applies to is that of the Name of the
representation item. But when it is defined by an aspect definition, the
entity is directly denoted by the Entity attribute of the represenation
item. The circuitry that inherits representation items for derived types
or subtypes must account for these two possible cases.
2018-09-26 Thomas Quinot <quinot@adacore.com>
gcc/ada/
* sem_ch13.adb (Inherit_Aspects_At_Freeze_Point): For a
representation item that is an N_Aspect_Definition, retrieve the
entity it applies to using the Entity attribute.
gcc/testsuite/
* gnat.dg/sso13.adb: New testcase.
From-SVN: r264636
Justin Squirek [Wed, 26 Sep 2018 09:19:53 +0000 (09:19 +0000)]
[Ada] Spurious ineffective use_clause warning
This patch fixes an issue whereby user-defined subprograms used as
generic actuals with corresponding formals containing other formal types
led to spurious ineffective use_clause warnings.
2018-09-26 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_ch8.adb (Analyze_Subprogram_Renaming): Add extra condition
to check for unmarked subprogram references coming from
renamings.
gcc/testsuite/
* gnat.dg/warn16.adb: New testcase.
From-SVN: r264635
Arnaud Charlet [Wed, 26 Sep 2018 09:19:47 +0000 (09:19 +0000)]
[Ada] Store -G xxx switches
2018-09-26 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* back_end.adb (Scan_Compiler_Arguments): Store -G xxx switches.
From-SVN: r264634
Yannick Moy [Wed, 26 Sep 2018 09:19:43 +0000 (09:19 +0000)]
[Ada] Issue info message on inlined subprograms in GNATprove mode
Issue a positive message that inlining was performed in GNATprove mode,
when corresponding debug switch -gnatd_f is set.
2018-09-26 Yannick Moy <moy@adacore.com>
gcc/ada/
* errout.ads: Update comment for insertion character '?'.
* inline.adb: Use simple insertion character '?' for GNATprove
info messages.
* sem_res.adb (Resolve_Call): Issue an info message on inlining
in GNATprove mode.
From-SVN: r264633
Ed Schonberg [Wed, 26 Sep 2018 09:19:38 +0000 (09:19 +0000)]
[Ada] Missing front-end code for constraint checks on fixed point exprs
This patch ensures that the front-end generates constraint checks for
some operations that previously depended on gigi for the corresponding
check. The patch also resets the Do_Range_Check flag so that it never
appears in the tree presented to gigi.
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* checks.adb (Apply_Type_Conversion_Checks): Do not generate a
range check on the expression of the conversion if it involves a
fixed-point type, as such conversions are handled specially
during expansion.
* exp_ch4.adb (Expand_N_Type_Conversion): In a conversion from
Fixed to Integer, use the base type of the expression to ensure
that the caller will generate the proper constraint check when
needed.
From-SVN: r264632
Maroua Maalej [Wed, 26 Sep 2018 09:19:33 +0000 (09:19 +0000)]
[Ada] SPARK: fix a bug related to loop exit environment
2018-09-26 Maroua Maalej <maalej@adacore.com>
gcc/ada/
* sem_spark.adb (Check_Loop_Statement): Fix a bug related to
loop exit environment.
(Check_Statement): fixing a bug when comparing the source and
target in an assignment statement.
From-SVN: r264631
Hristian Kirtchev [Wed, 26 Sep 2018 09:19:28 +0000 (09:19 +0000)]
[Ada] Spurious elaboration issue due to inlining
This patch ensures that the full compilation context is captured prior
to package or subprogram instantiation/inlining and restored after the
action takes place.
2018-09-26 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* sem_ch12.adb (Instantiate_Package_Body): Capture and restore
the full compilation context.
(Instantiate_Subprogram_Body): Capture and restore the full
compilation context.
gcc/testsuite/
* gnat.dg/elab7.adb, gnat.dg/elab7_pkg1.adb,
gnat.dg/elab7_pkg1.ads, gnat.dg/elab7_pkg2.adb,
gnat.dg/elab7_pkg2.ads: New testcase.
From-SVN: r264630
Yannick Moy [Wed, 26 Sep 2018 09:19:12 +0000 (09:19 +0000)]
[Ada] Do not issue by default info messages for inlining in GNATprove
Info messages about lack of inlining for analysis in GNATprove may be
confusing to users. They are now only issued when GNATprove is called
with switch --info, which it passes on to gnat2why with switch -gnatd_f.
There is no effect on compilation.
2018-09-26 Yannick Moy <moy@adacore.com>
gcc/ada/
* debug.adb: Add use for -gnatd_f switch.
* inline.adb (Cannot_Inline): Only issue info message for
failure to inline in GNATprove mode when switch -gnatd_f is
used.
From-SVN: r264629
Javier Miranda [Wed, 26 Sep 2018 09:19:04 +0000 (09:19 +0000)]
[Ada] Spurious error on interface conversion under ZFP
The frontend reports an error under ZFP when performing the type
conversion of a tagged object to one of its covered interface types.
2018-09-26 Javier Miranda <miranda@adacore.com>
gcc/ada/
* exp_disp.adb (Expand_Interface_Conversion): No displacement of
the pointer needed when the type of the operand is an interface
type that maches the target type and we are compiling under
configurable runtime. Adding also documentation explaining why
this cannot be done when compiling with the full runtime.
* exp_intr.adb: Update comment.
gcc/testsuite/
* gnat.dg/interface8.adb, gnat.dg/interface8.ads: New testcase.
From-SVN: r264628
Hristian Kirtchev [Wed, 26 Sep 2018 09:18:58 +0000 (09:18 +0000)]
[Ada] Add a No_Return annotation to ease static analysis
2018-09-26 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* sem_ch5.adb (Wrap_Loop_Statement): Annotate as No_Return.
From-SVN: r264627
Ed Schonberg [Wed, 26 Sep 2018 09:18:52 +0000 (09:18 +0000)]
[Ada] Spurious error on private extension with predicate
This patch fixes a spurious error involving a private extension whose
full view includes a dynamic predicate, when the parent type is itself
private at the point of the predicate check. The conversion is known to
be legal so no extra conversion checks are required.
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_util.adb (Make_Predicate_Call): Use OK_Convert_To when
applying a predicate check to prevent spurious errors when
private ancestors are involved.
gcc/testsuite/
* gnat.dg/predicate2-containers.ads,
gnat.dg/predicate2-project-name_values.ads,
gnat.dg/predicate2-project-registry-attribute.ads,
gnat.dg/predicate2-project-registry.ads,
gnat.dg/predicate2-project-typ-set.ads,
gnat.dg/predicate2-project-typ.ads,
gnat.dg/predicate2-project.ads,
gnat.dg/predicate2-source_reference.ads, gnat.dg/predicate2.ads,
gnat.dg/predicate2_main.adb: New testcase.
From-SVN: r264626
Hristian Kirtchev [Wed, 26 Sep 2018 09:18:35 +0000 (09:18 +0000)]
[Ada] Spurious dependency on secondary stack
This patch reimplements the handling of the secondary stack when the
iteration scheme of a loop statement requires this support.
Prior to this modification, an iterator loop over a container was
assumed to require unconditional secondary stack management. This is
however not always true because of user-defined iterator types, where
routines First and Next return an iterator that does require the
secondary stack.
------------
-- Source --
------------
-- gnat.adc
pragma Restrictions (No_Secondary_Stack);
-- test.ads
package Test is
type Test_Type is private
with
Default_Initial_Condition,
Iterable => (First => First_Element,
Next => Next_Element,
Has_Element => Has_Element,
Element => Element);
type Cursor_Type is private;
function First_Element (T : Test_Type) return Cursor_Type;
function Next_Element (T : Test_Type; C : Cursor_Type) return Cursor_Type;
function Has_Element (T : Test_Type; C : Cursor_Type) return Boolean;
function Element (T : Test_Type; C : Cursor_Type) return Natural;
private
type Cursor_Type is new Natural;
type Test_Type is record
null;
end record;
function First_Element (T : Test_Type) return Cursor_Type
is (0);
function Next_Element (T : Test_Type; C : Cursor_Type) return Cursor_Type
is (0);
function Has_Element (T : Test_Type; C : Cursor_Type) return Boolean
is (False);
function Element (T : Test_Type; C : Cursor_Type) return Natural
is (0);
end Test;
-- main.adb
with Test; use Test;
procedure Main is
F : Boolean;
M : Test_Type;
begin
for Elem of M loop
null;
end loop;
F := (for all C of M => C = 1);
F := (for all C in M => True);
end Main;
-----------------
-- Compilation --
-----------------
$ gnatmake -q --RTS=zfp -nostdlib main.adb
2018-09-26 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* exp_ch4.adb (Expand_N_Allocator): Ensure that the use of the
secondary stack does not clash with restriction
No_Secondary_Stack.
* exp_ch6.adb (Expand_N_Extended_Return_Statement): Ensure that
the use of the secondary stack does not clash with restriction
No_Secondary_Stack.
* sem_ch5.adb (Analyze_Loop_Statement): Wrap the loop in a block
prior to analysis in order to either provide a local scope for
an iterator, or ensure that the secondary stack is properly
managed.
(Check_Call): Account for the case where the tree may be
unanalyzed or contain prior errors.
(Has_Call_Using_Secondary_Stack): Renamed to Has_Sec_Stack_Call.
Update all uses of the subprogram.
(Prepare_Loop_Statement): New routine.
From-SVN: r264625
Javier Miranda [Wed, 26 Sep 2018 09:18:29 +0000 (09:18 +0000)]
[Ada] Mimic the C++ ABI when passing class-wide conversion actuals
This patch does not affect the behavior of Ada-only code but improves
consistency with the code generated by the C++ compiler.
2018-09-26 Javier Miranda <miranda@adacore.com>
gcc/ada/
* sem_res.adb (Resolve_Actuals): If the formal is a class-wide
type conversion then do not skip resolving and expanding the
conversion; required to displace the pointer to the object and
reference the dispatch table associated with the target
interface type.
From-SVN: r264624
Hristian Kirtchev [Wed, 26 Sep 2018 09:18:23 +0000 (09:18 +0000)]
[Ada] Pair miscount in Dynamic_HTable.Put
This patch corrects the logic of GNAT.Dynamic_HTables.Dynamic_HTable.Put to
update the number of key-value pairs in the hash table only when the put is
adding a new pair, rather than updating the value of an existing pair.
2018-09-26 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* libgnat/g-dynhta.adb (Prepend_Or_Replace): Update the number
of key-value pairs in the hash table only when adding a brand
new pair.
gcc/testsuite/
* gnat.dg/dynhash1.adb: New testcase.
From-SVN: r264623
Sergey Rybin [Wed, 26 Sep 2018 09:18:16 +0000 (09:18 +0000)]
[Ada] Add notes about processing of aggregate projects
2018-09-26 Sergey Rybin <rybin@adacore.com>
gcc/ada/
* doc/gnat_ugn/gnat_utility_programs.rst: Add note about
processing of aggregate projects in gnatmetric and gnatstub.
From-SVN: r264622
Hristian Kirtchev [Wed, 26 Sep 2018 09:18:09 +0000 (09:18 +0000)]
[Ada] Minor reformattings
2018-09-26 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* contracts.adb, exp_unst.adb, exp_util.adb, gnat1drv.adb,
opt.ads, par-prag.adb, sem_ch3.adb, sem_ch5.adb, sem_prag.adb,
sinfo.ads, snames.ads-tmpl: Minor reformatting.
From-SVN: r264621
Hristian Kirtchev [Wed, 26 Sep 2018 09:18:02 +0000 (09:18 +0000)]
[Ada] New unit GNAT.Sets
This patch implements unit GNAT.Sets which currently offers a general purpose
membership set. The patch also streamlines GNAT.Dynamic_HTables and GNAT.Lists
to use parts of the same API, types, and exceptions as those used by GNAT.Sets.
2018-09-26 Hristian Kirtchev <kirtchev@adacore.com>
gcc/ada/
* gcc-interface/Make-lang.in: Add unit GNAT.Sets to the list of
front end sources.
* impunit.adb: Add unit GNAT.Sets to the list of predefined
units.
* Makefile.rtl: Add unit GNAT.Sets to the list of non-tasking
units.
* libgnat/g-sets.adb: New unit.
* libgnat/g-sets.ads: New unit.
* libgnat/g-dynhta.adb (Minimum_Size): Decrease to 8 in order to
allow for small sets. Update all occurrences of Table_Locked to
Iterated.
(Ensure_Unlocked): Query the number of iterators.
(Find_Node): Use the supplied equality.
(Is_Empty): New routine.
(Lock): Update the number of iterators.
(Prepend_Or_Replace): Use the supplied equality.
(Size): Update the return type.
(Unlock): Update the number of iterators.
* libgnat/g-dynhta.ads: Update all occurrences of Table_Locked
to Iterated. Rename formal subprogram Equivalent_Keys to "=".
(Bucket_Range_Type, Pair_Count_Type): Remove types.
(Not_Created, Table_Locked, Iterator_Exhausted): Remove
exceptions.
(Hash_Table): Update to store the number of iterators rather
than locks.
(Is_Empty): New routine.
(Size): Update the return type.
* libgnat/g-lists.adb: Update all occurrences of List_Locked to
Iterated.
(Ensure_Unlocked): Query the number of iterators.
(Length): Remove.
(Lock): Update the number of iterators.
(Size): New routine.
(Unlock): Update the number of iterators.
* libgnat/g-lists.ads: Update all occurrences of List_Locked to
Iterated.
(Element_Count_Type): Remove type.
(Not_Created, Table_Locked, Iterator_Exhausted): Remove
exceptions.
(Linked_List): Update type to store the number of iterators
rather than locks.
(Length): Remove.
(Size): New routine.
* libgnat/gnat.ads (Bucket_Range_Type): New type.
(Iterated, Iterator_Exhausted, and Not_Created): New exceptions.
gcc/testsuite/
* gnat.dg/sets1.adb: New testcase.
* gnat.dg/dynhash.adb, gnat.dg/linkedlist.adb: Update testcases
to new API.
From-SVN: r264620
Javier Miranda [Wed, 26 Sep 2018 09:17:56 +0000 (09:17 +0000)]
[Ada] ICE on mix of tagged and limited interfaces
2018-09-26 Javier Miranda <miranda@adacore.com>
gcc/ada/
* checks.adb (Install_Null_Excluding_Check): Do not add
null-excluding checks when the tree may not be fully decorated.
This patch cascade errors.
From-SVN: r264619
Gary Dismukes [Wed, 26 Sep 2018 09:17:51 +0000 (09:17 +0000)]
[Ada] Illegal formal objects associated with anonymous acc-to-subp args
The compiler was incorrectly accepting generic instantiations with
formal objects of named access-to-subprogram types associated with an
actual of an anonymous access-to-subprogram type.
Analyze_Object_Declaration tests for objects initialized anonymous
access-to-subprogram values, and wraps a conversion around the argument,
which normally will result in error checks during resolution in
Valid_Conversion, but the conversion was only created when the
initialization expression Comes_From_Source, which prevented the
conversion wrapping from happening for constant declarations resulting
from generic expansion. The test for Comes_From_Source was removed.
The following test must report the error output given further below for
the three constructs marked as errors when compiled with this command:
gcc -c -gnatj70 bad_anon_access_instance.adb
procedure Bad_Anon_Access_Instance (Anon_Acc : access procedure) is
type Ref is access procedure;
Ref_1 : Ref := Anon_Acc; -- ERROR (flagged by GNAT)
Ref_2 : constant Ref := Anon_Acc; -- ERROR (flagged by GNAT)
generic
Formal_Ref : Ref;
package Gen is
end Gen;
package Inst
is new Gen (Formal_Ref => Anon_Acc); -- ERROR (but not flagged by GNAT)
begin
null;
end Bad_Anon_Access_Instance;
-------------
Error output:
-------------
bad_anon_access_instance.adb:4:19: illegal attempt to store anonymous
access to subprogram, value has
deeper accessibility than any
master (RM 3.10.2 (13)), use named
access type for "Anon_Acc" instead
of access parameter
bad_anon_access_instance.adb:6:28: illegal attempt to store anonymous
access to subprogram, value has
deeper accessibility than any
master (RM 3.10.2 (13)), use named
access type for "Anon_Acc" instead
of access parameter
bad_anon_access_instance.adb:14:32: illegal attempt to store
anonymous access to subprogram,
value has deeper accessibility
than any master (RM 3.10.2 (13)),
use named access type for
"Anon_Acc" instead of access
parameter
2018-09-26 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* sem_ch3.adb (Analyze_Object_Declaration): Remove test for
Comes_From_Source, which prevented implicit conversions from
being applied to anonymous access-to-subprogram formals in
constant declartions that arise from instance associations for
generic formal objects. Add RM and AARM references to comment.
From-SVN: r264618
Olivier Hainque [Wed, 26 Sep 2018 09:17:46 +0000 (09:17 +0000)]
[Ada] Front-end support for OpenACC pragmas
This patch introduces the upper part of the Ada front-end support for a first
set of OpenACC directives (Acc_Kernels, Acc_Loop, Acc_Parallel, Acc_Data) and
their clauses.
The pragmas syntax is documented, pragmas are recognized and checked for
syntactic correctness, keyed on -fopenacc. A couple of new flags are defined
on loop statements in the GNAT tree.
2018-09-26 Olivier Hainque <hainque@adacore.com>
gcc/ada/
* opt.ads (OpenAcc_Enabled): New flag. False by default. True
when OpenACC pragmas are requested to be honored, when -fopenacc
is found on the command line.
* back_end.adb (Scan_Compiler_Arguments): Set OpenACC_Enabled if
-fopenacc is seen on the command line.
* sinfo.adb, sinfo.ads (Is_OpenAcc_Environment): New
flag/predicate on Loop statements which embed an Acc_Kernels,
Acc_Parallel or Acc_Data pragma.
(Is_OpenAcc_Loop): New flag/predicate on Loop statements which
embed an Acc_Loop pragma.
(Set_Is_OpenAcc_Environment, Set_Is_OpenAcc_Loop): Setters for
the new flags.
* par-prag.adb (Prag): Handle Acc_Data, Acc_Loop, Acc_Parallel
and Acc_Kernels pragmas. Nothing to do here, all handled by
sem_prag.
* sem_prag.adb (Acc_First, Acc_Next,
Validate_Acc_Condition_Clause, Validate_Acc_Data_Clause,
Validate_Acc_Int_Expr_Clause, Validate_Acc_Int_Expr_List_Clause,
Validate_Acc_Loop_Collapse, Validate_Acc_Loop_Gang,
Validate_Acc_Loop_Vector, Validate_Acc_Loop_Worker,
Validate_Acc_Name_Reduction, Validate_Acc_Size_Expressions): New
helper for Analyze_Pragma, to handle OpenACC pragmas.
(Analyze_Pragma): Handle Acc_Data, Acc_Loop, Acc_Parallel and
Acc_Kernels pragmas.
* sem_ch5.adb (Disable_Constant): Unset Is_True_Constant on
variable entity, action for ...
(Disable_Constants): Helper for Analyze_Loop_Statement, to ...
(Analyze_Loop_Statement): Disable True_Constant on variables
referenced within an OpenACC environment.
* snames.ads-tmpl: Declare Name_Ids for the OpenACC directives
and clauses we can handle. Remove an exraneous whitespace before
columns, preventing line length overflow in the generated spec
with Ids now reaching beyond 999.
* doc/gnat_rm/implementation_defined_pragmas.rst: Document
pragma Acc_Parallel, Acc_Loop, Acc_Kernels and Acc_Data.
* gnat_rm.texi: Regenerate.
From-SVN: r264617
Ed Schonberg [Wed, 26 Sep 2018 09:17:41 +0000 (09:17 +0000)]
[Ada] Missing error on non-limited derived type with limited component
This patch fixes a missing error on a type extension with limited
components, when the parent type is a derived limited interface. This
may allow the unit to improperly compile, but may lead to bind-time
errors when compiling a client of that unit.
Compiling p.adb must yield:
keys.ads:8:06: extension of nonlimited type cannot have limited components
keys.ads:8:06: limitedness is not inherited from limited interface
keys.ads:8:06: add "limited" to type indication
----
with Keys;
procedure P is
begin
null;
end;
----
with GNAT.Semaphores;
package Keys is
type Ref0 is limited interface;
type Ref2 is limited interface and Ref0;
type Object is new Ref2 with record
Lock : aliased GNAT.Semaphores.Binary_Semaphore
(True, GNAT.Semaphores.Default_Ceiling);
end record;
end;
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch3.adb (Is_Onown_Limited): A derived type whose parent P
is a derived limited record is not itself limited if P is a
derived limited interface.
From-SVN: r264616
Eric Botcazou [Wed, 26 Sep 2018 09:17:36 +0000 (09:17 +0000)]
[Ada] Inlining of renamed subprogram instances in package body
This fixes a small discrepancy in the handling of renamed subprograms
declared in a package body, between those originally a regular
subprogram and those an instance of a generic subprogram, the latter
being slightly hindered.
The difference comes from the setting of the Is_Public flag, which was
more conservative in the latter case because instantiations of generic
subprograms are done in compiler-generated local packages.
It is eliminated by allowing Has_Referencer to recurse into nested
packages, but only if they are themselves not instances of generic
packages.
The compiler must now fully inline Doit_I into Doit at -O2 in:
package P is
generic procedure Doit_G;
procedure Doit;
end P;
package body P is
N : Natural := 0;
procedure Doit_G is
begin
N := 1;
end Doit_G;
procedure Doit_I is new Doit_G;
procedure Doit renames Doit_I;
end P;
2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* sem_ch7.adb (Has_Referencer): Remove Top_Level parameter and
add In_Nested_Instance and
Has_Outer_Referencer_Of_Non_Subprograms parameters. Rename
Has_Non_Subprograms_Referencer variable into
Has_Referencer_Of_Non_Subprograms and initialize it with the new
third parameter. Adjust recursive calls and to the renaming.
Replace test on Top_Level with test on In_Nested_Instance to
decide whether to clear the Is_Public flag on entities.
(Hide_Public_Entities): Adjust call to Has_Referencer.
From-SVN: r264615
Eric Botcazou [Wed, 26 Sep 2018 09:17:31 +0000 (09:17 +0000)]
[Ada] Preparation for new description of interface thunks
This adjusts and exposes a couple of functions of the front-end used for the
generation of interface thunks so as to make them callable from gigi. This
also propagates the debug info setting from the targets to the thunks so as
to make stepping into primitives work better in the debugger.
2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* exp_disp.adb (Expand_Interface_Conversion): Use Present test.
(Expand_Interface_Thunk): Propagate debug info setting from
target.
* exp_util.ads (Find_Interface_Tag): Adjust comment.
* exp_util.adb (Find_Interface_Tag): Remove assertions of
success.
* sem_util.adb (Is_Variable_Size_Record): Only look at
components and robustify the implementation.
* fe.h (Find_Interface_Tag): Declare.
(Is_Variable_Size_Record): Likewise.
From-SVN: r264614
Thomas Quinot [Wed, 26 Sep 2018 09:17:26 +0000 (09:17 +0000)]
[Ada] Propagate bit order and SSO from root to classwide equivalent type
2018-09-26 Thomas Quinot <quinot@adacore.com>
gcc/ada/
* exp_util.adb (Make_CW_Equivalent_Type): Propagate bit order
and scalar storage order from root type to classwide equivalent
type, to prevent rejection of the equivalent type by the
freezing circuitry.
gcc/testsuite/
* gnat.dg/sso12.adb: New testcase.
From-SVN: r264613
Justin Squirek [Wed, 26 Sep 2018 09:17:21 +0000 (09:17 +0000)]
[Ada] Crash on expression functions within quantified expressions
This patch fixes an issue whereby using a call to an expression function
as the domain of iteration for a loop would trigger a crash due to the
function not being frozen appropriately.
2018-09-26 Justin Squirek <squirek@adacore.com>
gcc/ada/
* sem_ch5.adb (Analyze_Iterator_Specification): Add conditional
to freeze called functions within iterator specifications during
full analysis.
(Preanalyze_Range): Minor typo fix.
gcc/testsuite/
* gnat.dg/expr_func8.adb: New testcase.
From-SVN: r264612
Ed Schonberg [Wed, 26 Sep 2018 09:17:16 +0000 (09:17 +0000)]
[Ada] Missing predicate check on return value
The semantics of the return statement includes an implicit conversion of
the value to the return type of the funcction. This conversion, as
elsewhere, entails a predicate check if the return type has a predicate
aspect.
We do not apply the check to a case expression because in the context of
a return statement it will be expanded into a series of return
statements, each of which will receive a predicate check.
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* sem_ch6.adb (Analyze_Function_Return): If the return type has
a dynamic_predicate, apply a Predicate_Check to the expression,
given that it is implicitly converted to the return type.
Exclude case expressions from the check, because in this context
the expression is expanded into individual return statements.
gcc/testsuite/
* gnat.dg/predicate3.adb, gnat.dg/predicate3_pkg.ads: New
testcase.
From-SVN: r264611
Eric Botcazou [Wed, 26 Sep 2018 09:17:10 +0000 (09:17 +0000)]
[Ada] ICE on array of task type with -gnatct
2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/decl.c (gnat_to_gnu_entity) <E_Task_Type>: In
-gnatct mode, process the discriminants only for a definition.
From-SVN: r264610
Eric Botcazou [Wed, 26 Sep 2018 09:17:05 +0000 (09:17 +0000)]
[Ada] Fix assertion failure on record subtype with -gnatRj
The JSON output of the -gnatR machinery was choking on record subtypes
and the change fixes this oversight.
The following package must now compile properly with -gnatRj:
package P is
type Rec (D : Integer) is record
C : Integer;
case D is
when 1 =>
S : String (1 .. 20);
when 2 =>
B : Boolean;
when others =>
Ch1 : Character;
F : Float;
Ch2 : Character;
end case;
end record;
subtype Rec1 is Rec (1);
end P;
2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* repinfo.adb (List_Record_Layout): Be prepared for JSON output.
(List_Record_Info): Use the flat representation for record
subtypes in the JSON format.
From-SVN: r264609
Justin Squirek [Wed, 26 Sep 2018 09:16:59 +0000 (09:16 +0000)]
[Ada] Regression in partial compilation of RCI units
This patch fixes an issue whereby the compilation of partial sources
(packages without bodies that require them) would not occur when said
sources were remote call interfaces. This is required because such
interfaces may have bodies that only exist on the server side or vice
versa
2018-09-26 Justin Squirek <squirek@adacore.com>
gcc/ada/
* lib-writ.adb, lib-writ.ads (Write_With_Lines): Add
documentation and an extra conditional check for RCI units so
that generated ali files will list the spec only instead of a
body when a body is not found.
From-SVN: r264608
Eric Botcazou [Wed, 26 Sep 2018 09:16:54 +0000 (09:16 +0000)]
[Ada] Set Current_Error_Node directly
This changes gigi to set Current_Error_Node directly, which should
result in a more robust error handling.
2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/gigi.h (error_gnat_node): Delete.
* gcc-interface/trans.c (error_gnat_node): Likewise.
(gigi): Replace it with Current_Error_Node.
(gnat_to_gnu): Likewise.
* gcc-interface/utils.c (rest_of_subprog_body_compilation):
Likewise.
* gcc-interface/misc.c (internal_error_function): Do not set it.
From-SVN: r264607
Eric Botcazou [Wed, 26 Sep 2018 09:16:49 +0000 (09:16 +0000)]
[Ada] Wrong handling of address clause for limited record type
2018-09-26 Eric Botcazou <ebotcazou@adacore.com>
gcc/ada/
* gcc-interface/decl.c (gnat_to_gnu_entity) <E_Variable>: Adjust
code retrieving the address when a clause has already been
processed.
* gcc-interface/trans.c (gnat_to_gnu)
<N_Attribute_Definition_Clause>: For an object with a Freeze
node, build a meaningful expression.
gcc/testsuite/
* gnat.dg/addr12.adb, gnat.dg/addr12_a.adb,
gnat.dg/addr12_a.ads, gnat.dg/addr12_b.adb,
gnat.dg/addr12_b.ads, gnat.dg/addr12_c.ads: New testcase.
From-SVN: r264606
Arnaud Charlet [Wed, 26 Sep 2018 09:16:44 +0000 (09:16 +0000)]
[Ada] Introduce -gnatd_A to set Opt.Disable_ALI_File
This will allow us to remove the import of flag_compare_debug in
lib-writ.adb in a second stage.
2018-09-26 Arnaud Charlet <charlet@adacore.com>
gcc/ada/
* gnat1drv.adb (Adjust_Global_Switches): -gnatd_A sets
Opt.Disable_ALI_File.
* debug.adb: Update debug flags documentation.
From-SVN: r264605
Ed Schonberg [Wed, 26 Sep 2018 09:16:39 +0000 (09:16 +0000)]
[Ada] Disable special handling for preconditions specified by pragmas
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* contracts.adb (Analyze_Entry_Or_Subprogram_Contract): The
analysis of preconditions specified by pragmas (rather than
aspects) is not delayed, and therefore expressions functions
that are completions do not need special handling during
expansion.
From-SVN: r264604
Ed Schonberg [Wed, 26 Sep 2018 09:16:33 +0000 (09:16 +0000)]
[Ada] Unnesting: fix handling of up level refs for entries
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* exp_unst.adb: Fix handling of up level references for entries.
From-SVN: r264603
Ed Schonberg [Wed, 26 Sep 2018 09:16:28 +0000 (09:16 +0000)]
[Ada] Fix ICE related to type freezing
2018-09-26 Ed Schonberg <schonberg@adacore.com>
gcc/ada/
* contracts.adb (Expand_Subprogram_Contract,
Process_Preconditions_For): Apply Freeze_Expr_Types to the
expression for a precondition of an expression function that is
a completion, when the completion appears in the private part
and the declaration it completes is in the visible part of the
same package.
* freeze.adb (Freeze_Expr_Types): Do not establish the scope of
the operation if it is already installed, as will be the case
when called to analyze the contract oc the subprogram (which
happens when generating code inside the subprogram body).
From-SVN: r264602
Maroua Maalej [Wed, 26 Sep 2018 09:16:23 +0000 (09:16 +0000)]
[Ada] SPARK: update borrowing effects for IN parameters
2018-09-26 Maroua Maalej <maalej@adacore.com>
gcc/ada/
* sem_spark.adb (Check_Param_In, Setup_Parameter_Or_Global):
Change the operation associated to assigning to an IN parameter.
In SPARK, IN access-to-variable is an observe operation for a
function, and borrow operation for a procedure.
From-SVN: r264601
Arnaud Charlet [Wed, 26 Sep 2018 09:16:18 +0000 (09:16 +0000)]
[Ada] Vxlink: minor reformatting
2018-09-26 Arnaud Charlet <charlet@adacore.com>
gcc/ada
* vxlink.adb: Minor reformatting.
From-SVN: r264600
Gary Dismukes [Wed, 26 Sep 2018 09:15:48 +0000 (09:15 +0000)]
[Ada] Fix miscellaneous typos
2018-09-26 Gary Dismukes <dismukes@adacore.com>
gcc/ada/
* exp_ch9.adb, layout.adb, sem_attr.adb, sem_res.adb: Fix
miscellaneous typos.
From-SVN: r264599
Matthew Malcomson [Wed, 26 Sep 2018 09:13:18 +0000 (09:13 +0000)]
A few places in the arm and aarch64 backends check whether an atomic operation needs acquire or release semantics.
A few places in the arm and aarch64 backends check whether an atomic
operation needs acquire or release semantics.
This is generally done with a check like
(is_mm_relaxed (model)
|| is_mm_consume (model)
|| is_mm_release (model))
In this patch we introduce two helper functions to make things a little
tidier.
There are a few places in the arm/ backend that check whether an
operation needs memory model semantics with an idiom that can now be
replaced with the new aarch_mm_needs_* functions, so we make that
replacement.
There is also some backslash removal to make things a little tidier.
Full bootstrap and regression test plus cross-compilation regression tests done
on arm-none-linux-gnueabihf.
Ok for trunk?
gcc/ChangeLog:
2018-09-20 Matthew Malcomson <matthew.malcomson@arm.com>
* config/arm/arm.c (arm_split_compare_and_swap, arm_split_atomic_op):
Use new helper functions.
* config/arm/sync.md (atomic_load<mode>, atomic_store<mode>):
Use new helper functions.
* config/arm/aarch-common-protos.h (aarch_mm_needs_acquire,
aarch_mm_needs_release): New declarations.
* config/arm/aarch-common.c (aarch_mm_needs_acquire,
aarch_mm_needs_release): New.
From-SVN: r264598
Jerome Lambourg [Wed, 26 Sep 2018 09:13:03 +0000 (09:13 +0000)]
[Ada] Vxlink: kill a CodePeer warning
2018-09-26 Jerome Lambourg <lambourg@adacore.com>
gcc/ada/
* vxlink.adb: Kill a CodePeer warning.
From-SVN: r264597
Paolo Carlini [Wed, 26 Sep 2018 09:08:24 +0000 (09:08 +0000)]
re PR c++/67656 ([concepts] matched variadics in expression constraint report as unmatched)
2018-09-26 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/67656
* g++.dg/concepts/pr67656.C: New.
From-SVN: r264596
Eric Botcazou [Wed, 26 Sep 2018 07:36:45 +0000 (07:36 +0000)]
arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
* config/arm/arm.c (arm_reorg): Skip Thumb reorg pass for thunks.
(arm32_output_mi_thunk): Deal with long calls.
From-SVN: r264595
Richard Biener [Wed, 26 Sep 2018 07:05:01 +0000 (07:05 +0000)]
re PR debug/87428 ("Missed" inline instances cause bogus DWARF to be emitted)
2018-09-26 Richard Biener <rguenther@suse.de>
PR debug/87428
PR debug/87362
* tree-inline.c (expand_call_inline): When the location
of the call is UNKNOWN_LOCATION use DECL_SOURCE_LOCATION
or BUILTINS_LOCATION for the BLOCK_SOURCE_LOCATION of
the inserted BLOCK to make inlined_function_outer_scope_p
recognize it.
* dwarf2out.c (add_call_src_coords_attributes): Do not add
coords for reserved locations.
From-SVN: r264594
Ian Lance Taylor [Wed, 26 Sep 2018 03:29:07 +0000 (03:29 +0000)]
runtime, os: fix the build on Solaris
Reviewed-on: https://go-review.googlesource.com/137535
From-SVN: r264593
GCC Administrator [Wed, 26 Sep 2018 00:16:57 +0000 (00:16 +0000)]
Daily bump.
From-SVN: r264592
Segher Boessenkool [Tue, 25 Sep 2018 23:42:28 +0000 (01:42 +0200)]
rs6000: Use set_attr_alternative in some places
Some code is much neater if it uses set_attr_alternative than if it
does everything by hand. Change some patterns to use this shorthand.
* config/rs6000/rs6000.md (*movcc_internal1): Use set_attr_alternative.
(*call_indirect_nonlocal_sysv<mode>): Ditto.
(*call_value_indirect_nonlocal_sysv<mode>): Ditto.
(*sibcall_nonlocal_sysv<mode>): Ditto.
(*sibcall_value_nonlocal_sysv<mode>): Ditto.
(<bd>_<mode>): Ditto.
(<bd>tf_<mode>): Ditto.
From-SVN: r264588
Segher Boessenkool [Tue, 25 Sep 2018 23:31:22 +0000 (01:31 +0200)]
rs6000: Simplify "switch (which_alternative)" patterns
A few of the rs6000 patterns use C code as output control string, where
that code is just a "switch (which_alternative)" with all alternatives
returning a constant string or just the result of a function call as
template.
Write such cases as just a list of templates, with the few pieces that
are C code preceded by "*".
* config/rs6000/altivec.md (*altivec_mov<mode>): Write the output
control string as a list of templates instead of as C code.
(*altivec_movti): Ditto.
* config/rs6000/darwin.md (movdf_low_di): Ditto.
From-SVN: r264587
Jim Wilson [Tue, 25 Sep 2018 22:52:38 +0000 (22:52 +0000)]
RISC-V: Fix weak symbols with medany and explicit relocs.
gcc/
* config/riscv/riscv.c (riscv_split_symbol): Mark auipc label as weak
when target symbol is weak.
gcc/testsuite/
* gcc.target/riscv/weak-1.c: New.
From-SVN: r264586
Jeff Law [Tue, 25 Sep 2018 22:17:45 +0000 (16:17 -0600)]
re PR c/87387 (trunk/gcc/builtins.c:585:7: warning: -Wself-assign problem)
PR c/87387
* builtins.c (unterminated_array): Simplify.
* expr.c (string_constant): Handle SSA_NAME. Add more exceptions
where pointer arithmetic is safe.
* gcc.dg/warn-stpcpy-no-nul.c: Drop unnecessary xfails.
* gcc.dg/warn-stplen-no-nul.c: Likewise.
From-SVN: r264585
Segher Boessenkool [Tue, 25 Sep 2018 22:09:38 +0000 (00:09 +0200)]
rs6000: Do not allow out of range immediate in vsplt[bhw] (PR86987)
The original AltiVec manuals had the immediate lane number in the
splat instructions as a 5-bit number, but anything too big has no
defined meaning, and gas will choke on it too. This patch disallows
it in the instruction patterns as well as in the builtins. This
solves PR86987.
PR target/86987
* config/rs6000/altivec.md (altivec_vspltb): Use
const_0_to_15_operand instead of u5bit_cint_operand.
(*altivec_vspltb_internal): Ditto.
(altivec_vspltb_direct): Ditto.
(altivec_vsplth): Use const_0_to_7_operand instead of
u5bit_cint_operand.
(*altivec_vsplth_internal): Ditto.
(altivec_vsplth_direct): Ditto.
(altivec_vspltw): Use const_0_to_3_operand instead of
u5bit_cint_operand.
(*altivec_vspltw_internal): Ditto.
(altivec_vspltw_direct): Ditto.
(altivec_vspltsf): Ditto.
(*altivec_vspltsf_internal): Ditto.
* config/rs6000/rs6000.c (rs6000_expand_binop_builtin): Handle the
various splats with the proper size immediate. Reorder the various
cases by ascending size of immediate, and put all such together.
From-SVN: r264584
Alexandre Oliva [Tue, 25 Sep 2018 19:04:44 +0000 (19:04 +0000)]
adjust dinst.adb's expectations for location views
The testcase failed when the compiler used .loc view syntax, because
it expected discriminators at the end of the .loc lines.
for gcc/testsuite/ChangeLog
* gnat.dg/dinst.adb: Adjust for locviews.
From-SVN: r264583
Will Schmidt [Tue, 25 Sep 2018 18:34:06 +0000 (18:34 +0000)]
altivec-6.C: Updated vec_splat() calls.
[testsuite]
2018-09-25 Will Schmidt <will_schmidt@vnet.ibm.com>
* g++.dg/ext/altivec-6.C: Updated vec_splat() calls.
* gcc.target/powerpc/fold-vec-splat-char.c: Remove invalid
vec_splat calls from recently added tests. Update instruction counts.
* gcc.target/powerpc/fold-vec-splat-floatdouble.c: Same.
* gcc.target/powerpc/fold-vec-splat-int.c: Same.
* gcc.target/powerpc/fold-vec-splat-longlong.c: Same.
* gcc.target/powerpc/fold-vec-splat-pixel.c: Same.
* gcc.target/powerpc/fold-vec-splat-short.c: Same.
From-SVN: r264582
Marek Polacek [Tue, 25 Sep 2018 18:02:47 +0000 (18:02 +0000)]
re PR c++/87425 (ICE with virtual assignment operator)
PR c++/87425
* g++.dg/cpp2a/constexpr-virtual12.C: New test.
From-SVN: r264581
Jakub Jelinek [Tue, 25 Sep 2018 16:40:57 +0000 (18:40 +0200)]
re PR c++/87398 (g++ ICE on valid code: tree check: expected record_type or union_type or qual_union_type, have array_type in cxx_eval_constant_expression, at cp/constexpr.c:4820)
PR c++/87398
* constexpr.c (cxx_eval_constant_expression) <case OBJ_TYPE_REF>: Only
look through COMPONENT_REFs with DECL_FIELD_IS_BASE FIELD_DECLs.
* g++.dg/other/pr87398.C: New test.
* g++.dg/cpp2a/constexpr-virtual10.C: New test.
* g++.dg/cpp2a/constexpr-virtual11.C: New test.
From-SVN: r264580
Martin Jambor [Tue, 25 Sep 2018 16:28:40 +0000 (18:28 +0200)]
[PR 87339] Fix failure of gcc.dg/warn-abs-1.c on some targets
2018-09-25 Martin Jambor <mjambor@suse.cz>
PR testsuite/87339
* gcc.dg/warn-abs-1.c: Do not test _Float128. Remove dg-skip-if and
float125 target.
* gcc.target/i386/warn-abs-3.c: New test.
From-SVN: r264579
Uros Bizjak [Tue, 25 Sep 2018 16:06:36 +0000 (18:06 +0200)]
* config/i386/i386.md: Move nearbyint patterns closer to rint.
From-SVN: r264578
Paolo Carlini [Tue, 25 Sep 2018 16:05:48 +0000 (16:05 +0000)]
re PR c++/81246 (ICE on invalid C++ code (with a non-type template parameter having type 'float'): Segmentation fault)
2018-09-25 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/81246
* g++.dg/cpp0x/pr81246.C: New.
From-SVN: r264577
Mike Crowe [Tue, 25 Sep 2018 14:59:27 +0000 (14:59 +0000)]
Use steady_clock to implement condition_variable::wait_for with predicate
In r263225 (
d2e378182a12d68fe5caeffae681252662a2fe7b), I fixed
condition_variable::wait_for to use std::chrono::steady_clock for the wait.
Unfortunately, I failed to spot that the same fix is required for the
wait_for variant that takes a predicate too.
2018-09-25 Mike Crowe <mac@mcrowe.com>
* include/std/condition_variable (condition_variable::wait_for): Use
steady clock in overload that uses a predicate.
From-SVN: r264575
Jonathan Wakely [Tue, 25 Sep 2018 14:59:16 +0000 (15:59 +0100)]
PR libstdc++/87431 optimise valueless_by_exception()
If a std::variant can never get into valueless state then we don't need
to do a runtime check for a valid alternative.
PR libstdc++/87431
* include/std/variant (_Variant_storage<true, _Types...>::_M_valid):
Avoid runtime test when all alternatives are scalars and so cannot
throw during initialization.
From-SVN: r264574
Richard Biener [Tue, 25 Sep 2018 14:51:39 +0000 (14:51 +0000)]
re PR debug/83941 (Debug info generated with -flto contains useless forwarders)
2018-09-25 Richard Biener <rguenther@suse.de>
PR debug/83941
* dwarf2out.c (add_AT_external_die_ref): Remove now redundant
GC-ification.
(maybe_create_die_with_external_ref): Do not create
DW_TAG_imported_unit here.
(add_abstract_origin_attribute): Handle external BLOCK refs.
(dwarf2out_abstract_function): Simplify LTO case.
(dwarf2out_early_finish): Create DW_TAG_imported_unit explicitely
rather than using maybe_create_die_with_external_ref.
From-SVN: r264573
Ian Lance Taylor [Tue, 25 Sep 2018 14:31:57 +0000 (14:31 +0000)]
internal/bytealg, internal/cpu, internal/poll: portability fixes
In internal/bytealg correct a +build tag to never build indexbyte_generic.go
for the gofrontend, where we always use indexbyte_native.go.
For internal/cpu let the Makefile define CacheLineSize using goarch.sh,
rather than trying to enumerate all the possibilities in cpu_ARCH.go files.
In internal/poll call the C fcntl function rather than using SYS_FCNTL.
Change mksysinfo.sh to ensure that F_GETPIPE_SZ is always defined,
and check that in internal/poll.
Reviewed-on: https://go-review.googlesource.com/137256
From-SVN: r264572
Uros Bizjak [Tue, 25 Sep 2018 14:26:11 +0000 (16:26 +0200)]
i386.md (frndintxf2_mask_pm): Remove.
* config/i386/i386.md (frndintxf2_mask_pm): Remove.
(frndintxf2_mask_pm_i387): Ditto.
(nearbyintxf2): Rewrite expander pattern to match rintxf2.
Enable for !flag_trapping_math.
(nearbyint<mode>2): Enable x87 modes for !flag_trapping_math.
Enable SSE modes for TARGET_SSE4_1 and expand them with round insn.
Change operand 1 predicate to nonimmediate_operand.
(attr "i387_cw"): Remove mask_pm.
* config/i386/i386.h (enum ix86_stack_slot): Remove SLOT_CW_MASK_PM.
(enum ix86_entity): Remove I387_MASK_PM.
* config/i386/i386.c (ix86_i387_mode_needed): Do not
handle I387_MASK_PM.
(ix86_mode_needed): Ditto.
(ix86_mode_after): Ditto.
(ix86_mode_entry): Ditto.
(ix86_mode_exit): Ditto.
(emit_i387_cw_initialization): Do not handle I387_CW_MASK_PM.
From-SVN: r264571
projects / gcc.git / log