gcc.git
4 years agoDelete changes meant for a private branch.
Michael Meissner [Tue, 5 May 2020 18:01:48 +0000 (14:01 -0400)]
Delete changes meant for a private branch.

2020-05-05  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/rs6000-builtin.def: Delete changes meant for a
private branch.
* config/rs6000/rs6000-c.c: Likewise.
* config/rs6000/rs6000-call.c: Likewise.
* gcc/config/rs6000/rs6000.c: Likewise.

2020-05-05  Michael Meissner  <meissner@linux.ibm.com>

* gcc.dg/nextafter-2.c: Delete changes meant for a private branch.
* gcc.target/powerpc/pr70117.c: Likewise.

2020-05-05  Michael Meissner  <meissner@linux.ibm.com>

* config.host: Delete changes meant for a private branch.
* config/rs6000/t-float128: Likewise.
* configure.ac: Likewise.
* configure: Likewise.

4 years agoPatch ieee128-lib-patch010b
Michael Meissner [Tue, 5 May 2020 17:46:28 +0000 (13:46 -0400)]
Patch ieee128-lib-patch010b

4 years agoNew file
Michael Meissner [Tue, 5 May 2020 17:42:09 +0000 (13:42 -0400)]
New file

4 years agoNew files
Michael Meissner [Tue, 5 May 2020 17:41:30 +0000 (13:41 -0400)]
New files

4 years agoRTEMS: Improve GCC specification
Sebastian Huber [Mon, 6 Apr 2020 14:34:50 +0000 (16:34 +0200)]
RTEMS: Improve GCC specification

Add a start/end file specification if the -qrtems option is present.
Allow targets to customize it.

Support the standard -nodefaultlibs option.

gcc/

* config/rtems.h (RTEMS_STARTFILE_SPEC): Define if undefined.
(RTEMS_ENDFILE_SPEC): Likewise.
(STARTFILE_SPEC): Update comment.  Add RTEMS_STARTFILE_SPEC.
(ENDFILE_SPEC): Add RTEMS_ENDFILE_SPEC.
(LIB_SPECS): Support -nodefaultlibs option.
* config/or1k/rtems.h (RTEMS_STARTFILE_SPEC): Define.
(RTEMS_ENDFILE_SPEC): Likewise.
* config/rs6000/rtems.h (RTEMS_STARTFILE_SPEC): Likewise.
(RTEMS_ENDFILE_SPEC): Likewise.
* config/v850/rtems.h (RTEMS_STARTFILE_SPEC): Likewise.
(RTEMS_ENDFILE_SPEC): Likewise.

4 years agoPRU: Remove TARGET_HARD_REGNO_CALL_PART_CLOBBERED
Dimitar Dimitrov [Sun, 15 Sep 2019 15:01:22 +0000 (18:01 +0300)]
PRU: Remove TARGET_HARD_REGNO_CALL_PART_CLOBBERED

Per clarification in [1], macro is supposed to check for partial
clobbering of single HW registers. Since PRU declares only 8-bit
HW registers, and ABI does not define individual bit clobbering,
it is safe to remove the implementation.

[1] https://gcc.gnu.org/ml/gcc-patches/2019-09/msg00778.html

gcc/ChangeLog:

2020-05-05  Dimitar Dimitrov  <dimitar@dinux.eu>

* config/pru/pru.c (pru_hard_regno_call_part_clobbered): Remove.
(TARGET_HARD_REGNO_CALL_PART_CLOBBERED): Remove.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
4 years agotestsuite: pru: Add clobber test
Dimitar Dimitrov [Fri, 22 Jun 2018 03:35:42 +0000 (06:35 +0300)]
testsuite: pru: Add clobber test

gcc/testsuite/ChangeLog:

2020-05-05  Dimitar Dimitrov  <dimitar@dinux.eu>

* gcc.target/pru/clobber-sp.c: New test.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
4 years agoPRU: Fix R3.w0 register class
Dimitar Dimitrov [Fri, 6 Sep 2019 19:15:07 +0000 (22:15 +0300)]
PRU: Fix R3.w0 register class

TI has clarified [1] that R3.w0 is caller saved, so allow compiler to
use it. This is safe change because older GCC versions treat R3.w0 as
fixed register and never use it.

[1] https://e2e.ti.com/support/tools/ccs/f/81/t/849993

gcc/ChangeLog:

2020-05-05  Dimitar Dimitrov  <dimitar@dinux.eu>

* config/pru/pru.h: Mark R3.w0 as caller saved.

gcc/testsuite/ChangeLog:

2020-05-05  Dimitar Dimitrov  <dimitar@dinux.eu>

* gcc.target/pru/lra-framepointer-fragmentation-1.c: Update test to
take into account additional available registers.
* gcc.target/pru/lra-framepointer-fragmentation-2.c: Ditto.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
4 years agoPRU: Simplify machine description
Dimitar Dimitrov [Mon, 17 Jun 2019 19:39:01 +0000 (22:39 +0300)]
PRU: Simplify machine description

Use the new @insn syntax for simpler gen_* invocation.

gcc/ChangeLog:

2020-05-05  Dimitar Dimitrov  <dimitar@dinux.eu>

* config/pru/pru.c (pru_emit_doloop): Use new gen_doloop_end_internal
and gen_doloop_begin_internal.
(pru_reorg_loop): Use gen_pruloop with mode.
* config/pru/pru.md: Use new @insn syntax.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
4 years agoPRU: Fix comment to avoid fall through warning
Dimitar Dimitrov [Sun, 15 Sep 2019 11:14:57 +0000 (14:14 +0300)]
PRU: Fix comment to avoid fall through warning

gcc/ChangeLog:

2020-05-05  Dimitar Dimitrov  <dimitar@dinux.eu>

* config/pru/pru.c (pru_print_operand): Fix fall through comment.

Signed-off-by: Dimitar Dimitrov <dimitar@dinux.eu>
4 years agoPatch ieee128-lib-patch009b
Michael Meissner [Tue, 5 May 2020 17:39:52 +0000 (13:39 -0400)]
Patch ieee128-lib-patch009b

4 years agoPatch ieee128-lib-patch008b
Michael Meissner [Tue, 5 May 2020 17:38:28 +0000 (13:38 -0400)]
Patch ieee128-lib-patch008b

4 years agoPatch ieee128-lib-patch007b
Michael Meissner [Tue, 5 May 2020 17:37:28 +0000 (13:37 -0400)]
Patch ieee128-lib-patch007b

4 years agoUpdate ChangeLog
Michael Meissner [Tue, 5 May 2020 17:36:17 +0000 (13:36 -0400)]
Update ChangeLog

4 years agoRemove extra newline
Michael Meissner [Tue, 5 May 2020 17:35:40 +0000 (13:35 -0400)]
Remove extra newline

4 years agoPatch ieee128-lib-patch006b
Michael Meissner [Tue, 5 May 2020 17:35:09 +0000 (13:35 -0400)]
Patch ieee128-lib-patch006b

4 years agoPatch ieee128-lib-patch005b
Michael Meissner [Tue, 5 May 2020 17:33:34 +0000 (13:33 -0400)]
Patch ieee128-lib-patch005b

4 years agoPatch ieee128-lib-patch004b
Michael Meissner [Tue, 5 May 2020 17:32:22 +0000 (13:32 -0400)]
Patch ieee128-lib-patch004b

4 years agoPatch ieee128-lib-patch003b
Michael Meissner [Tue, 5 May 2020 17:31:03 +0000 (13:31 -0400)]
Patch ieee128-lib-patch003b

4 years agoPatch ieee128-lib-patch002b
Michael Meissner [Tue, 5 May 2020 17:30:07 +0000 (13:30 -0400)]
Patch ieee128-lib-patch002b

4 years agoPatch ieee128-lib-patch001b
Michael Meissner [Tue, 5 May 2020 16:28:48 +0000 (12:28 -0400)]
Patch ieee128-lib-patch001b

4 years agosetup branch
Michael Meissner [Tue, 5 May 2020 16:24:18 +0000 (12:24 -0400)]
setup branch

4 years agoi386: Use "clobber (scratch)" in expanders
Uros Bizjak [Tue, 5 May 2020 16:01:06 +0000 (18:01 +0200)]
i386: Use "clobber (scratch)" in expanders

Use "clobber (scratch:M)" instad of "clobber (match_scratch:M N)" in expanders.

* config/i386/i386.md (fixuns_trunc<mode>si2): Use
"clobber (scratch:M)" instad of "clobber (match_scratch:M N)".
(addqi3_cconly_overflow): Ditto.
(umulv<mode>4): Ditto.
(<s>mul<mode>3_highpart): Ditto.
(tls_global_dynamic_32): Ditto.
(tls_local_dynamic_base_32): Ditto.
(atanxf2): Ditto.
(asinxf2): Ditto.
(acosxf2): Ditto.
(logxf2): Ditto.
(log10xf2): Ditto.
(log2xf2): Ditto.
(*adddi_4): Remove "m" constraint from scratch operand.
(*add<mode>_4): Ditto.

4 years agoc-attribs.c: Fix warning about use of uninitialized variable nunits
Stefan Schulze Frielinghaus [Sun, 26 Apr 2020 07:42:29 +0000 (09:42 +0200)]
c-attribs.c: Fix warning about use of uninitialized variable nunits

In function handle_vector_size_attribute local variable nunits is
supposed to be initialized by function type_valid_for_vector_size.
However, in case ARGS is null the function may return with a non-null
value and leave nunits uninitialized.  This results in warning/error:

gcc/poly-int.h: In function 'tree_node* handle_vector_size_attribute(tree_node**, tree, tree, int, bool*)':
gcc/poly-int.h:330:3: error: 'nunits' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  330 |   ((void) (&(RES).coeffs[0] == (C *) 0), \
      |   ^
gcc/c-family/c-attribs.c:3695:26: note: 'nunits' was declared here
 3695 |   unsigned HOST_WIDE_INT nunits;
      |

Added attribute nonnull for argument args in order to silence warning
and added an assert statement in order to check the invariant candidate.

gcc/c-family/ChangeLog:

2020-05-05  Stefan Schulze Frielinghaus  <stefansf@linux.ibm.com>

* c-attribs.c (handle_vector_size_attribute): Add attribute
nonnull for argument args in order to silence warning of
uninitialized variable usage.  Since this is local to the
compilation unit and thus cannot be checked at call sides by the
compiler, added an assert statement in order to verify this.

4 years agoc++: Avoid inconsistency in lambda fn's this pointer name [pr94807]
Nathan Sidwell [Tue, 5 May 2020 14:47:13 +0000 (07:47 -0700)]
c++: Avoid inconsistency in lambda fn's this pointer name [pr94807]

* coroutines.cc (morph_fn_to_coro): Just check for
closure_identifier.
* pt.c (tsubst_function_decl): Update lambda fn's this_ptr name.

4 years agocsa, postreload: Improve csa after recent cselib changes [PR94516]
Jakub Jelinek [Tue, 5 May 2020 14:34:51 +0000 (16:34 +0200)]
csa, postreload: Improve csa after recent cselib changes [PR94516]

This patch addresses a missed optimization caused by the cselib changes.
Already in the past postreload could replace sp = sp + const_int with
sp = regxy if regxy already has the right value, but with the cselib
changes it happens several times more often.  It can result in smaller
code, so it seems undesirable to prevent such optimizations, but
unfortunately it can get into the way of stack adjustment coalescing,
where e.g. if we used to have sp = sp + 32; sp = sp - 8;, previously
we'd turn that into sp = sp + 24;, but now postreload optimizes
into sp = r12; sp = sp - 8; and csa gives up.

The patch just adds a REG_EQUAL note when changing sp = sp + const into
sp = reg, where we remember it was actually a stack adjustment by certain
constant, and the combine-stack-adj changes than make use of those REG_EQUAL
notes, together with LR tracking (csa did enable the note problem, just
didn't simulate each insn) so that we can add the needed clobbers etc.
(taken from the other stack adjustment insn).

2020-05-05  Jakub Jelinek  <jakub@redhat.com>

PR rtl-optimization/94516
* postreload.c (reload_cse_simplify): When replacing sp = sp + const
with sp = reg, add REG_EQUAL note with sp + const.
* combine-stack-adj.c (try_apply_stack_adjustment): Change return
type from int to bool.  Add LIVE and OTHER_INSN arguments.  Undo
postreload sp = sp + const to sp = reg optimization if needed and
possible.
(combine_stack_adjustments_for_block): Add LIVE argument.  Handle
reg = sp insn with sp + const REG_EQUAL note.  Adjust
try_apply_stack_adjustment caller, call
df_simulate_initialize_forwards and df_simulate_one_insn_forwards.
(combine_stack_adjustments): Allocate and free LIVE bitmap,
adjust combine_stack_adjustments_for_block caller.

4 years agoc++: Member template function lookup failure [PR94799]
Marek Polacek [Wed, 29 Apr 2020 02:30:44 +0000 (22:30 -0400)]
c++: Member template function lookup failure [PR94799]

Whew, this took a while.  We fail to parse "p->template A<T>::a()"
(where p is of type A<T> *) because since r249752 we treat the RHS of the ->
as dependent and avoid a lookup in the enclosing context: since that rev
cp_parser_template_name checks parser->context->object_type too, which
here is unknown_type_node, signalling a type-dependent object:

 7756   if (dependent_p)
 7757     /* Tell cp_parser_lookup_name that there was an object, even though it's
 7758        type-dependent.  */
 7759     parser->context->object_type = unknown_type_node;

with which cp_parser_template_name returns identifier 'A', cp_parser_class_name
then creates a TEMPLATE_ID_EXPR A<T>, but then

23735       decl = make_typename_type (scope, decl, tag_type, tf_error);

in cp_parser_class_name fails because scope is NULL.  Then we return
error_mark_node and parse errors ensue.

I've tried various approaches, e.g. keeping TEMPLATE_ID_EXPR around
instead of calling make_typename_type, which didn't work, whereupon I
realized that since we don't want to perform name lookup if we've seen
the template keyword and the scope is dependent, we can adjust
parser->context->object_type and use the type of the object expression
as the scope, even if it's type-dependent.  This should be in line with
[basic.lookup.classref]p4.  If the postfix expression doesn't have a type,
use typeof to carry its type.  This typeof will be processed in
tsubst/TYPENAME_TYPE.

PR c++/94799
* parser.c (cp_parser_postfix_dot_deref_expression): If we have
a type-dependent object of class type, stash it to
parser->context->object_type.  If the postfix expression doesn't have
a type, use typeof.
(cp_parser_class_name): Consider object scope too.
(cp_parser_lookup_name): Remove code dealing with the case when
object_type is unknown_type_node.

* g++.dg/lookup/this1.C: Adjust dg-error.
* g++.dg/template/lookup12.C: New test.
* g++.dg/template/lookup13.C: New test.
* g++.dg/template/lookup14.C: New test.
* g++.dg/template/lookup15.C: New test.

4 years agoRemove __gcov_flush.
Martin Liska [Tue, 5 May 2020 14:15:47 +0000 (16:15 +0200)]
Remove __gcov_flush.

PR gcov-profile/93623
* tree-cfg.c (stmt_can_terminate_bb_p): Update comment to reflect
reality.
PR gcov-profile/93623
* Makefile.in: Remove __gcov_flush.
* gcov.h (__gcov_flush): Remove.
* libgcov-interface.c (__gcov_flush): Remove.
(init_mx): Use renamed mutex.
(__gcov_lock): Likewise.
(__gcov_unlock): Likewise.
(__gcov_fork): Likewise.
(__gcov_flush): Remove.

4 years agoUse __gcov_dump and __gcov_reset in execv and fork context.
Martin Liska [Tue, 5 May 2020 14:15:46 +0000 (16:15 +0200)]
Use __gcov_dump and __gcov_reset in execv and fork context.

PR gcov-profile/93623
* libgcov-interface.c (__gcov_fork): Do not flush
and reset only in child process.
(__gcov_execl): Dump counters only and reset them
only if exec* fails.
(__gcov_execlp): Likewise.
(__gcov_execle): Likewise.
(__gcov_execv): Likewise.
(__gcov_execvp): Likewise.
(__gcov_execve): Likewise.

4 years agoDo locking for __gcov_dump and __gcov_reset as well.
Martin Liska [Tue, 5 May 2020 14:15:45 +0000 (16:15 +0200)]
Do locking for __gcov_dump and __gcov_reset as well.

PR gcov-profile/93623
* Makefile.in: Add _gcov_lock_unlock to LIBGCOV_INTERFACE.
* libgcov-interface.c (ALIAS_void_fn): Remove.
(__gcov_lock): New.
(__gcov_unlock): New.
(__gcov_flush): Use __gcov_lock and __gcov_unlock.
(__gcov_reset): Likewise.
(__gcov_dump): Likewise.
* libgcov.h (__gcov_lock): New declaration.
(__gcov_unlock): Likewise.

4 years agooptgen: make more sanity checks for enums.
Martin Liska [Tue, 5 May 2020 14:13:46 +0000 (16:13 +0200)]
optgen: make more sanity checks for enums.

* opt-functions.awk (opt_args_non_empty): New function.
* opt-read.awk: Use the function for various option arguments.

4 years agoProvide warning for missing jobserver.
Martin Liska [Tue, 5 May 2020 14:11:33 +0000 (16:11 +0200)]
Provide warning for missing jobserver.

PR driver/94330
* lto-wrapper.c (run_gcc): When using -flto=jobserver,
report warning when the jobserver is not detected.

4 years agoAdd missing ChangeLog entries.
Martin Liska [Tue, 5 May 2020 14:10:13 +0000 (16:10 +0200)]
Add missing ChangeLog entries.

4 years agogcov: print total_lines summary for all files.
Martin Liska [Fri, 17 Apr 2020 15:19:12 +0000 (17:19 +0200)]
gcov: print total_lines summary for all files.

gcc/ChangeLog:

2020-04-17  Martin Liska  <mliska@suse.cz>

PR gcov-profile/94636
* gcov.c (main): Print total lines summary at the end.
(generate_results): Expect file_name always being non-null.
Print newline after intermediate file is printed in order to align with
what we do for normal files.

4 years agoProvide hint for misspelled -fdump-foo options.
Martin Liska [Thu, 19 Mar 2020 10:58:53 +0000 (11:58 +0100)]
Provide hint for misspelled -fdump-foo options.

gcc/ChangeLog:

2020-03-19  Martin Liska  <mliska@suse.cz>

* dumpfile.c (dump_switch_p): Change return type
and print option suggestion.
* dumpfile.h: Change return type.
* opts-global.c (handle_common_deferred_options):
Move error into dump_switch_p function.

gcc/testsuite/ChangeLog:

2020-03-19  Martin Liska  <mliska@suse.cz>

* gcc.dg/spellcheck-options-22.c: New test.

4 years agoMerge dg-options and dg-additional-options if len <= 120 chars.
Martin Liska [Wed, 15 Apr 2020 06:49:45 +0000 (08:49 +0200)]
Merge dg-options and dg-additional-options if len <= 120 chars.

gcc/testsuite/ChangeLog:

2020-04-15  Martin Liska  <mliska@suse.cz>

* g++.dg/concepts/diagnostic1.C: Merge dg-options and
dg-additional-options if len <= 120 chars.
* g++.dg/cpp1y/new1.C: Likewise.
* g++.dg/cpp1y/new2.C: Likewise.
* g++.dg/debug/dwarf2/pr61433.C: Likewise.
* g++.dg/init/new18.C: Likewise.
* g++.dg/ipa/devirt-19.C: Likewise.
* g++.dg/ipa/devirt-52.C: Likewise.
* g++.dg/ipa/pr44372.C: Likewise.
* g++.dg/ipa/pr58371.C: Likewise.
* g++.dg/ipa/pr63587-2.C: Likewise.
* g++.dg/ipa/pr78211.C: Likewise.
* g++.dg/opt/dump1.C: Likewise.
* g++.dg/opt/pr44919.C: Likewise.
* g++.dg/opt/pr47615.C: Likewise.
* g++.dg/opt/pr82159-2.C: Likewise.
* g++.dg/other/pr52048.C: Likewise.
* g++.dg/pr57662.C: Likewise.
* g++.dg/pr59510.C: Likewise.
* g++.dg/pr67989.C: Likewise.
* g++.dg/pr81194.C: Likewise.
* g++.dg/template/canon-type-8.C: Likewise.
* g++.dg/template/crash107.C: Likewise.
* g++.dg/template/show-template-tree-3.C: Likewise.
* g++.dg/tm/cgraph_edge.C: Likewise.
* g++.dg/torture/20141013.C: Likewise.
* g++.dg/torture/pr34641.C: Likewise.
* g++.dg/torture/pr34850.C: Likewise.
* g++.dg/torture/pr36745.C: Likewise.
* g++.dg/torture/pr40991.C: Likewise.
* g++.dg/torture/pr48271.C: Likewise.
* g++.dg/torture/pr53602.C: Likewise.
* g++.dg/torture/pr53752.C: Likewise.
* g++.dg/torture/pr54838.C: Likewise.
* g++.dg/torture/pr58252.C: Likewise.
* g++.dg/tree-ssa/pr22444.C: Likewise.
* g++.dg/tree-ssa/pr24351-3.C: Likewise.
* g++.dg/tree-ssa/pr27283.C: Likewise.
* g++.dg/tree-ssa/pr27291.C: Likewise.
* g++.dg/tree-ssa/pr27548.C: Likewise.
* g++.dg/tree-ssa/pr42337.C: Likewise.
* g++.dg/ubsan/pr65583.C: Likewise.
* g++.old-deja/g++.robertl/eb27.C: Likewise.
* gcc.dg/tree-ssa/dse-points-to.c: Likewise.
* gcc.target/arm/simd/vmmla_1.c: Likewise.
* gcc.target/i386/vect-pr67800.c: Likewise.
* gcc.target/mips/cfgcleanup-jalr2.c: Likewise.
* gcc.target/mips/cfgcleanup-jalr3.c: Likewise.

4 years agoUse const for template argument.
Martin Liska [Tue, 4 Feb 2020 13:55:25 +0000 (14:55 +0100)]
Use const for template argument.

libstdc++-v3/ChangeLog:

2020-02-04  Martin Liska  <mliska@suse.cz>

PR c/92472
* include/parallel/multiway_merge.h:
Use const for _Compare template argument.

4 years agoPut index check before use.
Martin Liska [Tue, 4 Feb 2020 13:57:59 +0000 (14:57 +0100)]
Put index check before use.

liboffloadmic/ChangeLog:

2020-02-04  Martin Liska  <mliska@suse.cz>

PR other/89860
* runtime/offload_target.cpp: Put index check
before its use.

4 years agoUse const for some function arguments.
Martin Liska [Tue, 4 Feb 2020 13:55:14 +0000 (14:55 +0100)]
Use const for some function arguments.

gcc/ChangeLog:

2020-02-04  Martin Liska  <mliska@suse.cz>

PR c/92472
* alloc-pool.h: Use const for some arguments.
* bitmap.h: Likewise.
* mem-stats.h: Likewise.
* sese.h (get_entry_bb): Likewise.
(get_exit_bb): Likewise.

4 years agoRemove 2 dead variables in bid_internal.h.
Martin Liska [Tue, 4 Feb 2020 13:54:51 +0000 (14:54 +0100)]
Remove 2 dead variables in bid_internal.h.

libgcc/config/libbid/ChangeLog:

2020-02-04  Martin Liska  <mliska@suse.cz>

PR libgcc/92565
* bid_internal.h (handle_UF_128_rem): Remove unused variable.
(handle_UF_128): Likewise.

4 years agorewrite hybrid SLP detection
Richard Biener [Wed, 25 Mar 2020 13:41:51 +0000 (14:41 +0100)]
rewrite hybrid SLP detection

This rewrites hybrid SLP detection to be simpler and cope with
group size changes in the SLP graph.  In particular detection
works starting from non-SLP stmts following use->def chains
rather than walking the SLP graph and following def->use chains.

It's all temporary of course since non-SLP and thus hybrid SLP
will go away.

2020-05-05  Richard Biener  <rguenther@suse.de>

* tree-vect-slp.c (struct vdhs_data): New.
(vect_detect_hybrid_slp): New walker.
(vect_detect_hybrid_slp): Rewrite.

4 years agotestsuite/92177 - adjust expected patterns for gcc.dg/vect/bb-slp-22.c
Richard Biener [Tue, 5 May 2020 13:38:24 +0000 (15:38 +0200)]
testsuite/92177 - adjust expected patterns for gcc.dg/vect/bb-slp-22.c

We now always vectorize two BBs, adjust the selector to also scan
for integer multiplication vectorization explicitely.

2020-05-05  Richard Biener  <rguenther@suse.de>

PR testsuite/92177
* gcc.dg/vect/bb-slp-22.c: Adjust.

4 years agoipa/94947 - fix test for externally visible variables for IPA PTA
Richard Biener [Tue, 5 May 2020 11:09:50 +0000 (13:09 +0200)]
ipa/94947 - fix test for externally visible variables for IPA PTA

This fixes lack of an escape point of externally declared variables.

2020-05-05  Richard Biener  <rguenther@suse.de>

PR ipa/94947
* tree-ssa-structalias.c (ipa_pta_execute): Use
varpool_node::externally_visible_p ().
(refered_from_nonlocal_var): Likewise.

* gcc.dg/torture/pr94947-1.c: New testcase.
* gcc.dg/torture/pr94947-2.c: Likewise.

4 years agoSilence warning in LTO mode on VxWorks
Eric Botcazou [Tue, 5 May 2020 10:33:11 +0000 (12:33 +0200)]
Silence warning in LTO mode on VxWorks

The link phase is always partial (-r) for VxWorks in kernel mode, which
means that it uses incremental LTO linking by default (-flinker-output=rel).
But in this mode the LTO plugin outputs a warning if one of the object files
involved in the link does not contain LTO bytecode, before switching to
nolto-rel mode.  We do not do repeated incremental linking for VxWorks so
silence the warning.

lto-plugin/
* lto-plugin.c: Document -linker-output-auto-notlo-rel option.
(linker_output_set): Change type to bool.
(linker_output_known): Likewise.
(linker_output_auto_nolto_rel): New variable.
(all_symbols_read_handler): Take it into account.
<LDPO_REL>: Do not issue the warning if it is set.
(process_option): Process -linker-output-auto-notlo-rel.
(cleanup_handler): Remove unused variable.
(onload) <LDPT_LINKER_OUTPUT>: Adjust to above type change.
gcc/
* gcc.c (LTO_PLUGIN_SPEC): Define if not already.
(LINK_PLUGIN_SPEC): Execute LTO_PLUGIN_SPEC.
* config/vxworks.h (LTO_PLUGIN_SPEC): Define.

4 years agoDo not put incomplete CONSTRUCTORs into static memory
Eric Botcazou [Tue, 5 May 2020 10:31:26 +0000 (12:31 +0200)]
Do not put incomplete CONSTRUCTORs into static memory

The CONSTRUCTOR_NO_CLEARING flag was invented to avoid generating a memset
for  CONSTRUCTORS that lack elements, but it turns out that the gimplifier
can generate a memcpy for them instead, which is worse performance-wise,
so this prevents it from doing that for them.

* gimplify.c (gimplify_init_constructor): Do not put the constructor
into static memory if it is not complete.

4 years agotree-optimization/94949 - fix load eliding in SM
Richard Biener [Tue, 5 May 2020 09:00:09 +0000 (11:00 +0200)]
tree-optimization/94949 - fix load eliding in SM

This fixes the case of not using the multithreaded model when
only conditionally storing to the destination.  We cannot elide
the load in this case.

2020-05-05  Richard Biener  <rguenther@suse.de>

PR tree-optimization/94949
* tree-ssa-loop-im.c (execute_sm): Check whether we use
the multithreaded model or always compute the stored value
before eliding a load.

* gcc.dg/torture/pr94949.c: New testcase.

4 years agoaarch64: eliminate redundant zero extend after bitwise negation
Alex Coplan [Tue, 5 May 2020 09:33:02 +0000 (10:33 +0100)]
aarch64: eliminate redundant zero extend after bitwise negation

The attached patch eliminates a redundant zero extend from the AArch64 backend. Given the following C code:

unsigned long long foo(unsigned a)
{
    return ~a;
}

prior to this patch, AArch64 GCC at -O2 generates:

foo:
        mvn     w0, w0
        uxtw    x0, w0
        ret

but the uxtw is redundant, since the mvn clears the upper half of the x0 register. After applying this patch, GCC at -O2 gives:

foo:
        mvn     w0, w0
        ret

Testing:
    Added regression test which passes after applying the change to aarch64.md.
    Full bootstrap and regression on aarch64-linux with no additional failures.

        * config/aarch64/aarch64.md (*one_cmpl_zero_extend): New.
        * gcc.target/aarch64/mvn_zero_ext.c: New test.

4 years agomatch.pd: Canonicalize (x + (x << cst)) into (x * cst2) [PR94800]
Jakub Jelinek [Tue, 5 May 2020 09:36:47 +0000 (11:36 +0200)]
match.pd: Canonicalize (x + (x << cst)) into (x * cst2) [PR94800]

The popcount* testcases show yet another creative way to write popcount,
but rather than adjusting the popcount matcher to deal with it, I think
we just should canonicalize those (X + (X << C) to X * (1 + (1 << C))
and (X << C1) + (X << C2) to X * ((1 << C1) + (1 << C2)), because for
multiplication we already have simplification rules that can handle nested
multiplication (X * CST1 * CST2), while the the shifts and adds we have
nothing like that.  And user could have written the multiplication anyway,
so if we don't emit the fastest or smallest code for the multiplication by
constant, we should improve that.  At least on the testcases seems the
emitted code is reasonable according to cost, except that perhaps we could
in some cases try to improve expansion of vector multiplication by
uniform constant.

2020-05-05  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/94800
* match.pd (X + (X << C) to X * (1 + (1 << C)),
(X << C1) + (X << C2) to X * ((1 << C1) + (1 << C2))): New
canonicalizations.

* gcc.dg/tree-ssa/pr94800.c: New test.
* gcc.dg/tree-ssa/popcount5.c: New test.
* gcc.dg/tree-ssa/popcount5l.c: New test.
* gcc.dg/tree-ssa/popcount5ll.c: New test.

4 years agox86: Fix *vec_dupv4hi constraints [PR94942]
Jakub Jelinek [Tue, 5 May 2020 09:33:47 +0000 (11:33 +0200)]
x86: Fix *vec_dupv4hi constraints [PR94942]

This insn and split splits into HI->V?HImode broadcast for avx2 and later,
but either the operands need to be %xmm0-%xmm15 (i.e. VEX encoded insn), or
the insn needs both AVX512BW and AVX512VL.
Now, Yv constraint is v for AVX512VL and x otherwise, so for -mavx512vl -mno-avx512bw
we ICE if we end up with a %xmm16+ register from RA.
Yw constraint is v for AVX512VL and AVX512BW and nothing otherwise, so
in this pattern we actually need xYw.

2020-05-05  Jakub Jelinek  <jakub@redhat.com>

PR target/94942
* config/i386/mmx.md (*vec_dupv4hi): Use xYw constraints instead of Yv.

* gcc.target/i386/pr94942.c: New test.

4 years agomatch.pd: Optimize (((type)A * B) >> prec) != 0 into __imag__ .MUL_OVERFLOW [PR94914]
Jakub Jelinek [Tue, 5 May 2020 09:31:43 +0000 (11:31 +0200)]
match.pd: Optimize (((type)A * B) >> prec) != 0 into __imag__ .MUL_OVERFLOW [PR94914]

On x86 (the only target with umulv4_optab) one can use mull; seto to check
for overflow instead of performing wider multiplication and performing
comparison on the high bits.

2020-05-05  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/94914
* match.pd ((((type)A * B) >> prec) != 0 to .MUL_OVERFLOW(A, B) != 0):
New simplification.

* gcc.target/i386/pr94914.c: New test.

4 years agoi386: Use int_nonimmediate_operand more
Uros Bizjak [Tue, 5 May 2020 09:31:52 +0000 (11:31 +0200)]
i386: Use int_nonimmediate_operand more

Pattern explosing and manual mode checks can be avoided by using
int_nonimmediate_operand special predicate.

While there, rewrite *x86_mov<SWI48:mode>cc_0_m1_neg_leu<SWI:mode>
to a combine pass splitter.

* config/i386/i386.md (*testqi_ext_3): Use
int_nonimmediate_operand instead of manual mode checks.
(*x86_mov<SWI48:mode>cc_0_m1_neg_leu<SWI:mode>):
Use int_nonimmediate_operand predicate.  Rewrite
define_insn_and_split pattern to a combine pass splitter.

4 years agofix build of targets not implementing add_stmt_cost
Richard Biener [Tue, 5 May 2020 09:25:00 +0000 (11:25 +0200)]
fix build of targets not implementing add_stmt_cost

C++ makes mismatched prototype and implementation OK.

2020-05-05  Richard Biener  <rguenther@suse.de>

* targhooks.h (default_add_stmt_cost): Add vec_info * parameter.

4 years agobuild: Fix 32-bit TLS detection with 64-bit-default gas on Solaris/x86
Rainer Orth [Tue, 5 May 2020 08:42:23 +0000 (10:42 +0200)]
build: Fix 32-bit TLS detection with 64-bit-default gas on Solaris/x86

I've recently tested i386-pc-solaris2.11 bootstrap on Solaris 11/x86
with only the bundled tools (using /usr/gnu/bin/as from binutils 2.30 in
this case).  It failed compiling libgo/runtime/proc.c, creating invalid
assembly:

proc.s: Assembler messages:
proc.s:2092: Error: junk at end of line, first unrecognized character is `*'

        .globl  __emutls_v.*runtime.g

and several more errors.  This is completely unexpected since Solaris
does support TLS.  It turned out that 32-bit TLS detection in
gcc/configure had failed:

configure:25145: checking assembler for thread-local storage support
configure:25158: /usr/gnu/bin/as   --fatal-warnings -o conftest.o conftest.s >&5
conftest.s: Assembler messages:
conftest.s:6: Error: relocated field and relocation type differ in signedness
conftest.s:7: Error: @TLSLDM reloc is not supported with 64-bit output format
conftest.s:7: Error: junk `@tlsldm' after expression

which isn't unexpected given that the bundled gas has been configured
for x86_64-pc-solaris2.11, i.e. 64-bit-default.

This is easily fixed by explicitly passing --32 for the 32-bit case,
matching what is done for the 64-bit test.

Tested on i386-pc-solaris2.11 with 32-bit-default and 64-bit-default gas
as well as with /usr/bin/as, always correctly detecting TLS support.

* configure.ac <i[34567]86-*-*>: Add --32 to tls_as_opt on Solaris.
* configure: Regenerate.

4 years agoadd vec_info * parameters where needed
Richard Biener [Mon, 16 Mar 2020 10:47:00 +0000 (11:47 +0100)]
add vec_info * parameters where needed

Soonish we'll get SLP nodes which have no corresponding scalar
stmt and thus not stmt_vec_info and thus no way to get back to
the associated vec_info.  This patch makes the vec_info available
as part of the APIs instead of putting in that back-pointer into
the leaf data structures.

2020-05-05  Richard Biener  <rguenther@suse.de>

* tree-vectorizer.h (_stmt_vec_info::vinfo): Remove.
(STMT_VINFO_LOOP_VINFO): Likewise.
(STMT_VINFO_BB_VINFO): Likewise.
* tree-vect-data-refs.c: Adjust for the above, adding vec_info *
parameters and adjusting calls.
* tree-vect-loop-manip.c: Likewise.
* tree-vect-loop.c: Likewise.
* tree-vect-patterns.c: Likewise.
* tree-vect-slp.c: Likewise.
* tree-vect-stmts.c: Likewise.
* tree-vectorizer.c: Likewise.

* target.def (add_stmt_cost): Add vec_info * parameter.
* target.h (stmt_in_inner_loop_p): Likewise.
* targhooks.c (default_add_stmt_cost): Adjust.
* doc/tm.texi: Re-generate.

* config/aarch64/aarch64.c (aarch64_extending_load_p): Add
vec_info * parameter and adjust.
(aarch64_sve_adjust_stmt_cost): Likewise.
(aarch64_add_stmt_cost): Likewise.
* config/arm/arm.c (arm_add_stmt_cost): Likewise.
* config/i386/i386.c (ix86_add_stmt_cost): Likewise.
* config/rs6000/rs6000.c (rs6000_add_stmt_cost): Likewise.

4 years agoi386: Simplify {,v}ph{add,sub{,s}{w,d} insn patterns [PR94460]
Jakub Jelinek [Tue, 5 May 2020 07:01:37 +0000 (09:01 +0200)]
i386: Simplify {,v}ph{add,sub{,s}{w,d} insn patterns [PR94460]

As mentioned in the previous PR94460 patch, the RTL patterns look too
large/complicated, we can simplify them by just performing two 2 arg
permutations to move the arguments into the right spots and then just
doing the plus/minus (or signed saturation version thereof).

2020-05-05  Jakub Jelinek  <jakub@redhat.com>

PR target/94460
* config/i386/sse.md (avx2_ph<plusminus_mnemonic>wv16hi3,
ssse3_ph<plusminus_mnemonic>wv8hi3, ssse3_ph<plusminus_mnemonic>wv4hi3,
avx2_ph<plusminus_mnemonic>dv8si3, ssse3_ph<plusminus_mnemonic>dv4si3,
ssse3_ph<plusminus_mnemonic>dv2si3): Simplify RTL patterns.

4 years agoDaily bump.
GCC Administrator [Tue, 5 May 2020 00:16:17 +0000 (00:16 +0000)]
Daily bump.

4 years agoc++: Avoid unnecessary copying in cp_fold [PR94038]
Patrick Palka [Mon, 4 May 2020 22:30:32 +0000 (18:30 -0400)]
c++: Avoid unnecessary copying in cp_fold [PR94038]

When folding a CALL_EXPR, we can avoid copying it until folding changes
one of its arguments.  And when folding a TREE_VEC, we can avoid using
an intermediate releasing_vec by copying the TREE_VEC as soon as folding
changes one of its arguments, like we do in the CALL_EXPR case.

Incidentally, the CALL_EXPR change also fixes the testcase in PR94038.
The reason is that the call to maybe_constant_value from cp_fold on
the call 'bar<int>()' now reuses the result of the earlier call to
maybe_constant_value from fold_for_warn, via the cv_cache.  This earlier
call passes uid_sensitive=true, whereas the call from cp_fold passes
uid_sensitive=false, and so by reusing the cached result of the earlier
call we now avoid instantiating bar<int> at all.

gcc/cp/ChangeLog:

PR c++/94038
* cp-gimplify.c (cp_fold) <case CALL_EXPR>: Move some variable
declarations closer to their uses.  Copy the CALL_EXPR only
when one of its arguments has changed.
<case TREE_VEC>: Instead of first collecting the folded
arguments into a releasing_vec, just make a copy of the TREE_VEC
as soon as folding changes one of its arguments.

gcc/testsuite/ChangeLog:

PR c++/94038
* g++.dg/warn/pr94038.C: New test.

4 years agolibstdc++: Fix the return type of __cxa_finalize
Fangrui Song [Mon, 4 May 2020 22:07:19 +0000 (23:07 +0100)]
libstdc++: Fix the return type of __cxa_finalize

This should return void according to the Itanium C++ ABI.

2020-05-04  Fangrui Song  <maskray@google.com>

* libsupc++/cxxabi.h (__cxa_finalize): Fix return type.

4 years agolibstdc++: Fix broken link to SGI STL FAQ
Jonathan Wakely [Mon, 4 May 2020 21:54:25 +0000 (22:54 +0100)]
libstdc++: Fix broken link to SGI STL FAQ

The previous URL to an entry in the wayback machine now redirects to a
page saying "SGI.com Tech Archive Resources now retired" so use an older
entry from the archive.

* doc/xml/faq.xml: Use working link for SGI STL FAQ.
* doc/html/*: Regenerate.

4 years agolibstdc++: Fix incorrect size calculation in PMR resource (PR 94906)
Jonathan Wakely [Mon, 4 May 2020 20:13:28 +0000 (21:13 +0100)]
libstdc++: Fix incorrect size calculation in PMR resource  (PR 94906)

Calculating the size of a chunk being returned to the upstream allocator
was done with a 32-bit type, so it wrapped if the chunk was 4GB or
larger.

I don't know how to test this without allocating 4GB, so there's no test
in the testsuite. It has been tested manually with allocations sizes and
alignments exceeding 4GB.

PR libstdc++/94906
* src/c++17/memory_resource.cc
(monotonic_buffer_resource::_Chunk::release): Use size_t for shift
operands.

4 years agoFix Ada bootstrap on Cygwin64
Eric Botcazou [Mon, 4 May 2020 21:32:39 +0000 (23:32 +0200)]
Fix Ada bootstrap on Cygwin64

This fixes two compilation errors preventing bootstrap with Ada
on x86_64-pc-cygwin.

2020-05-04  Mikael Pettersson  <mikpelinux@gmail.com>

PR bootstrap/94918
* mingw32.h: Prevent windows.h from including emmintrin.h on Cygw64.
* s-oscons-tmplt.c (Serial_Port_Descriptor): Use System.Win32.HANDLE
also on Cygwin.

4 years agors6000: AIX long double builtins for 64 bit long double.
David Edelsohn [Thu, 30 Apr 2020 15:29:32 +0000 (11:29 -0400)]
rs6000: AIX long double builtins for 64 bit long double.

When long doubles are 64 bit, the AIX C library overrides the definitions
but GCC builtins point to 128 bit names.  This patch overrides the
builtins for fmodl, frexpl, ldexpl and modfl to refer to the 64 bit symbols.

2020-05-04  Clement Chigot  <clement.chigot@atos.net>
    David Edelsohn  <dje.gcc@gmail.com>

* config/rs6000/rs6000-call.c (rs6000_init_builtins): Override explicit
for fmodl, frexpl, ldexpl and modfl builtins.

4 years agointernal-fn: Avoid dropping the lhs of some calls [PR94941]
Richard Sandiford [Mon, 4 May 2020 20:21:16 +0000 (21:21 +0100)]
internal-fn: Avoid dropping the lhs of some calls [PR94941]

create_output_operand coerces an output operand to the insn's
predicates, using a suggested rtx location if convenient.
But if that rtx location is actually required rather than
optional, the builder of the insn has to emit a move afterwards.

(We could instead add a new interface that does this automatically,
but that's future work.)

This PR shows that we were failing to emit the move for some of the
vector load internal functions.  I think there are other routines in
internal-fn.c that potentially have the same problem, but this patch is
supposed to be a conservative subset suitable for backporting to GCC 10.

2020-05-04  Richard Sandiford  <richard.sandiford@arm.com>

gcc/
PR middle-end/94941
* internal-fn.c (expand_load_lanes_optab_fn): Emit a move if the
chosen lhs is different from the gcall lhs.
(expand_mask_load_optab_fn): Likewise.
(expand_gather_load_optab_fn): Likewise.

gcc/testsuite/
PR middle-end/94941
* gcc.target/aarch64/sve/acle/general/unoptimized_1.c: New test.

4 years agocoroutines: Mark the gro as artificial.
Iain Sandoe [Fri, 1 May 2020 18:20:46 +0000 (19:20 +0100)]
coroutines: Mark the gro as artificial.

This corrects an oversight, the coro.gro object is a
a compiler-generated entity and should be marked as
artificial and ignored.

gcc/cp/ChangeLog:

2020-05-04  Iain Sandoe  <iain@sandoe.co.uk>

* coroutines.cc (morph_fn_to_coro): Mark the coro.gro variable
as artificial and ignored.

4 years agoUpdate gcc sv.po.
Joseph Myers [Mon, 4 May 2020 19:44:02 +0000 (19:44 +0000)]
Update gcc sv.po.

* sv.po: Update.

4 years agolibstdc++: Avoid negating a size_t [pr 94747]
Nathan Sidwell [Mon, 4 May 2020 17:06:40 +0000 (10:06 -0700)]
libstdc++:  Avoid negating a size_t  [pr 94747]

Although the code here is well formed, it doesn't show intent well.
The reason checkers trigger on this is that it is a cause of real
bugs.  So, negate a ptrdiff_t instead.

* libsupc++/dyncast.cc (__dynamic_cast): Cast offsetof to
ptrdiff_t before negation, to show intent more clearly.

4 years agoAdded missing ChangeLog entries
Uros Bizjak [Mon, 4 May 2020 16:56:31 +0000 (18:56 +0200)]
Added missing ChangeLog entries

4 years agoi386: Use SBB more [PR94650]
Uros Bizjak [Mon, 4 May 2020 16:53:30 +0000 (18:53 +0200)]
i386: Use SBB more [PR94650]

When returning 0 or -1, "SBB reg,reg" instruction that borrows carry
flag can be used.  Carry flag can be generated by converting compare
with zero to a LTU compare with one, so e.g.

return -(x == 0)

generates:

        cmpq    $1, %rdi
        sbbq    %rax, %rax

instead of:

        xorl    %eax, %eax
        testq   %rdi, %rdi
        sete    %al
        negq    %rax

A similar conversion can be used for

return -(x != 0)

where NEG insn can be used instead of compare.  According to x86 ISA,
NEG insn sets carry flag when the source operand is != 0, resulting in:

        negq    %rdi
        sbbq    %rax, %rax

The conversion avoids partial register stall with SETcc instructions.

PR target/94795
* config/i386/i386.md (*neg<mode>_ccc): New insn pattern.
(EQ compare->LTU compare splitter): New splitter.
(NE compare->NEG splitter): Ditto.

testsuite/ChangeLog:

PR target/94795
* gcc.target/i386/pr94795-1.c: New test.
* gcc.target/i386/pr94795-2.c: New test.

4 years agoc++: Simplify process_template_parm
Nathan Sidwell [Mon, 4 May 2020 16:49:52 +0000 (09:49 -0700)]
c++: Simplify process_template_parm

Process_template_parm ends up walking the parameter list twice.
There's not need to do this.  Just rember the final node and modify
its CHAIN directly.  Also comment on why end_template_parm_list does a
pop and a push, rather than modifying the header in place.

pt.c (process_template_parm): Don't walk the template list twice,
remember the final node instead.
(end_template_parm_list): Refactor.  Comment on why we do a pop
and a push.

4 years agoc++: Don't save parms in nested requirement [pr 94827]
Nathan Sidwell [Mon, 4 May 2020 16:44:39 +0000 (09:44 -0700)]
c++: Don't save parms in nested requirement [pr 94827]

This followup patch just removes some stashing that we never made use of.

* constraint.cc (tsubst_nested_requirement): TYPE directly holds
notmalized requirement.
(finish_nested_requirement): Don't stash current tpl parms into
the requirement.
(diagnose_nested_requirement): TYPE directly holds notmalized
requirement.

4 years agoRevert "tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]"
Marek Polacek [Mon, 4 May 2020 14:26:43 +0000 (10:26 -0400)]
Revert "tree: Don't reuse types if TYPE_USER_ALIGN differ [PR94775]"

This reverts commit 6318fe77395fc0dd59419bc4d69cd06ac0158e54.

Revert:
2020-04-30  Marek Polacek  <polacek@redhat.com>

PR c++/94775
* tree.c (check_base_type): Return true only if TYPE_USER_ALIGN match.
(check_aligned_type): Check if TYPE_USER_ALIGN match.

4 years agotree-optimization/93891 - improve same-store disambiguation
Richard Biener [Tue, 25 Feb 2020 10:46:02 +0000 (11:46 +0100)]
tree-optimization/93891 - improve same-store disambiguation

We need a reference to assess alignment, fall back to the original
reference tree if available.

2020-05-04  Richard Biener  <rguenther@suse.de>

PR tree-optimization/93891
* tree-ssa-sccvn.c (vn_reference_lookup_3): Fall back to
the original reference tree for assessing access alignment.

4 years agolibstdc++: Make pmr::synchronized_pool_resource work without libpthread (PR 94936)
Jonathan Wakely [Mon, 4 May 2020 12:34:23 +0000 (13:34 +0100)]
libstdc++: Make pmr::synchronized_pool_resource work without libpthread (PR 94936)

I implicitly assumed that programs using pmr::synchronized_pool_resource
would also be using multiple threads, and so the weak symbols in
gthr-posix.h would be resolved by linking to libpthread. If that isn't
true then it crashes when trying to use pthread_key_create.

This commit makes the pool resource check __gthread_active_p() before
using thread-specific data, and just use a single set of memory pools
when there's only a single thread.

PR libstdc++/94936
* src/c++17/memory_resource.cc (synchronized_pool_resource::_TPools):
Add comment about single-threaded behaviour.
(synchronized_pool_resource::_TPools::move_nonempty_chunks()): Hoist
class member access out of loop.
(synchronized_pool_resource::synchronized_pool_resource())
(synchronized_pool_resource::~synchronized_pool_resource())
(synchronized_pool_resource::release()): Check __gthread_active_p
before creating and/or deleting the thread-specific data key.
(synchronized_pool_resource::_M_thread_specific_pools()): Adjust
assertions.
(synchronized_pool_resource::do_allocate(size_t, size_t)): Add fast
path for single-threaded case.
(synchronized_pool_resource::do_deallocate(void*, size_t, size_t)):
Likewise. Return if unable to find a pool that owns the allocation.
* testsuite/20_util/synchronized_pool_resource/allocate_single.cc:
New test.
* testsuite/20_util/synchronized_pool_resource/cons_single.cc: New
test.
* testsuite/20_util/synchronized_pool_resource/release_single.cc: New
test.

4 years agotree-optimization/39612 - avoid issueing loads in SM when possible
Richard Biener [Thu, 30 Apr 2020 08:47:15 +0000 (10:47 +0200)]
tree-optimization/39612 - avoid issueing loads in SM when possible

Currently store-motion emits a load of the value in the loop
preheader even when the original loop does not contain any read
of the reference.  This avoids doing this.  In the conditional
store-motion case we need to mark the sunk stores with no-warning
since the control dependence is too tricky to figure out for
the uninit warning.

2020-05-04  Richard Biener  <rguenther@suse.de>

PR tree-optimization/39612
* tree-ssa-loop-im.c (im_mem_ref::loaded): New member.
(set_ref_loaded_in_loop): New.
(mark_ref_loaded): Likewise.
(gather_mem_refs_stmt): Call mark_ref_loaded for loads.
(execute_sm): Avoid issueing a load when it was not there.
(execute_sm_if_changed): Avoid issueing warnings for the
conditional store.

* gcc.dg/tree-ssa/pr39612.c: New testcase.

4 years agotree-inline: Simplify IPA-CP type conversion (PR 93385)
Martin Jambor [Mon, 4 May 2020 11:53:54 +0000 (13:53 +0200)]
tree-inline: Simplify IPA-CP type conversion (PR 93385)

when callers and callees do not quite agree on the type of a
parameter, usually with ill-defined K&R or with smilarly wrong LTO
input, IPA-CP can attempt to try and substitute a wrong type for a
parameter (see e.g. gcc.dg/torture/pr48063.c).  Function
tree_function_versioning attempts to handle this in order not to
create invalid gimple but it then creates the mapping using
setup_one_parameter which also handles the same situation to avoid
similar problems when inlining and in more defined way.

So this patch simply removes the conversion attempts in
tree_function_versioning itself.  It is helpful for my upcoming fix of
PR 93385 because then I do not need to teach
ipa_param_body_adjustments to distinguish between successful and
unsuccessful mappings - setup_one_parameter uses force_value_to_type
for conversions which simly maps the worst cases to zero.

2020-05-04  Martin Jambor  <mjambor@suse.cz>

PR ipa/93385
* tree-inline.c (tree_function_versioning): Leave any type conversion
of replacements to setup_one_parameter and its friend
force_value_to_type.

4 years agoi386: Use SHR to compare with large power-of-two constants [PR94650]
Uros Bizjak [Mon, 4 May 2020 11:49:14 +0000 (13:49 +0200)]
i386: Use SHR to compare with large power-of-two constants [PR94650]

Convert unsigned compares where

m >= LARGE_POWER_OF_TWO

and LARGE_POWER_OF_TWO represent an immediate where bit 33+ is set to use
a SHR instruction and compare the result to 0.  This avoids loading a
large immediate with MOVABS insn.

        movabsq $1099511627775, %rax
        cmpq    %rax, %rdi
        ja      .L5

gets converted to:

shrq $40, %rdi
jne .L5

PR target/94650
* config/i386/predicates.md (shr_comparison_operator): New predicate.
* config/i386/i386.md (compare->shr splitter): New splitters.

testsuite/ChangeLog:

PR target/94650
* gcc.targeti/i386/pr94650.c: New test.

4 years agomatch.pd: Optimize (x < 0) != (y < 0) into (x ^ y) < 0 [PR94718]
Jakub Jelinek [Mon, 4 May 2020 09:03:32 +0000 (11:03 +0200)]
match.pd: Optimize (x < 0) != (y < 0) into (x ^ y) < 0 [PR94718]

The following patch (on top of the two other PR94718 patches) performs the
actual optimization requested in the PR.

2020-05-04  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/94718
* match.pd ((X < 0) != (Y < 0) into (X ^ Y) < 0): New simplification.

* gcc.dg/tree-ssa/pr94718-4.c: New test.
* gcc.dg/tree-ssa/pr94718-5.c: New test.

4 years agomatch.pd: Decrease number of nop conversions around bitwise ops [PR94718]
Jakub Jelinek [Mon, 4 May 2020 09:01:08 +0000 (11:01 +0200)]
match.pd: Decrease number of nop conversions around bitwise ops [PR94718]

On the following testcase, there are in *.optimized dump 14 nop conversions
(from signed to unsigned and back), while this patch decreases that number
to just 4; for bitwise ops it really doesn't matter if they are performed in
signed or unsigned, so the patch (in GIMPLE only, there are some comments
about it being undesirable during GENERIC earlier), if it sees both
bitop operands nop converted from the same types performs the bitop in their
non-converted type and converts the result (i.e. 2 conversions into 1),
similarly, if a bitop has one operand nop converted from something, the
other not and the result is converted back to the type of the nop converted
operand before conversion, it is possible to replace those 2 conversions
with just a single conversion of the other operand.

2020-05-04  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/94718
* match.pd (bitop (convert @0) (convert? @1)): For GIMPLE, if we can,
replace two nop conversions on bit_{and,ior,xor} argument
and result with just one conversion on the result or another argument.

* gcc.dg/tree-ssa/pr94718-3.c: New test.

4 years agomatch.pd: Move (X & C) eqne (Y & C) -> -> (X ^ Y) & C eqne 0 opt to match.pd [PR94718]
Jakub Jelinek [Mon, 4 May 2020 08:57:46 +0000 (10:57 +0200)]
match.pd: Move (X & C) eqne (Y & C) -> -> (X ^ Y) & C eqne 0 opt to match.pd [PR94718]

This patch moves this optimization from fold-const.c to match.pd where it
is actually much shorter to do and lets optimize even code not seen together
in a single expression in the source, as the first step towards fixing the
PR.

2020-05-04  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/94718
* fold-const.c (fold_binary_loc): Move (X & C) eqne (Y & C)
-> (X ^ Y) & C eqne 0 optimization to ...
* match.pd ((X & C) op (Y & C) into (X ^ Y) & C op 0): ... here.

* gcc.dg/tree-ssa/pr94718-1.c: New test.
* gcc.dg/tree-ssa/pr94718-2.c: New test.

4 years agodiagnostics: get_option_html_page fixes
Jakub Jelinek [Mon, 4 May 2020 07:31:27 +0000 (09:31 +0200)]
diagnostics: get_option_html_page fixes

While testing the --with-documentation-root-url= changes, I run into
[Wreturn-type] URL pointing to gfortran documentation where it obviously
isn't documented.  The following patch updates the list of options to match
reality (on the other side -Wconversion-extra is gfortran only option
documented in gfortran.texi).

Or, perhaps better use the attached patch instead, which doesn't have a
hardcoded list and instead uses the flags?  I went through options.c
and the updated list of options matches exactly the cases where CL_Fortran
is set for "-W*" options together with CL_C and/or CL_CXX (ok, there is also
-Wall and -Wextra, but hopefully we don't emit [Wall] or [Wextra] for
anything).

2020-05-04  Jakub Jelinek  <jakub@redhat.com>

* opts.c (get_option_html_page): Instead of hardcoding a list of
options common between C/C++ and Fortran only use gfortran/
documentation for warnings that have CL_Fortran set but not
CL_C or CL_CXX.

4 years agoDaily bump.
GCC Administrator [Mon, 4 May 2020 00:16:16 +0000 (00:16 +0000)]
Daily bump.

4 years agoi386: Use plus_constant instead of gen_rtx_PLUS
Uros Bizjak [Sun, 3 May 2020 18:52:06 +0000 (20:52 +0200)]
i386: Use plus_constant instead of gen_rtx_PLUS

Replace gen_rtx_PLUS with a GEN_INT with plus_constant.

2020-05-03  Uroš Bizjak  <ubizjak@gmail.com>

        * config/i386/i386-expand.c (ix86_expand_int_movcc):
Use plus_constant instead of gen_rtx_PLUS with GEN_INT.
(emit_memmov): Ditto.
(emit_memset): Ditto.
(ix86_expand_strlensi_unroll_1): Ditto.
(release_scratch_register_on_entry): Ditto.
(gen_frame_set): Ditto.
(ix86_emit_restore_reg_using_pop): Ditto.
(ix86_emit_outlined_ms2sysv_restore): Ditto.
(ix86_expand_epilogue): Ditto.
(ix86_expand_split_stack_prologue): Ditto.
* config/i386/i386.md (push immediate splitter): Ditto.
(strmov): Ditto.
(strset): Ditto.

4 years agolibstdc++: Make byte-sized std::fill_n a constant expression (PR 94933)
Jonathan Wakely [Sun, 3 May 2020 11:46:15 +0000 (12:46 +0100)]
libstdc++: Make byte-sized std::fill_n a constant expression (PR 94933)

The overload for byte types uses memset and isn't constexpr. This adds
the specifier and uses std::is_constant_evaluated() to provide a
compile-time alternative.

PR libstdc++/94933
* include/bits/stl_algobase.h (__fill_a1): Make overload for byte types
usable in constant expressions.
* testsuite/25_algorithms/fill_n/constexpr.cc: Test with bytes and
non-scalars.

4 years agoFix incorrect use of 'Unrestricted_Access in testcase
Eric Botcazou [Sun, 3 May 2020 09:22:22 +0000 (11:22 +0200)]
Fix incorrect use of 'Unrestricted_Access in testcase

4 years agoDaily bump.
GCC Administrator [Sun, 3 May 2020 00:16:16 +0000 (00:16 +0000)]
Daily bump.

4 years agogfortran: Get asan library from TEST_ALWAYS_FLAGS
H.J. Lu [Sat, 2 May 2020 19:46:44 +0000 (12:46 -0700)]
gfortran: Get asan library from TEST_ALWAYS_FLAGS

Update gfortran_target_compile to get the newly built asan library from
TEST_ALWAYS_FLAGS to avoid:

/usr/bin/ld: cannot find libasan_preinit.o: No such file or directory
/usr/bin/ld: cannot find -lasan
collect2: error: ld returned 1 exit status
compiler exited with status 1
FAIL: gfortran.dg/asan/pointer_assign_16.f90 -fsanitize=address  -O0  (test for excess errors)

PR fortran/94788
* lib/gfortran.exp (gfortran_target_compile): Get asan library
from TEST_ALWAYS_FLAGS.

4 years agoDarwin: Fix a diagnostic spelling [PR93861]
Iain Sandoe [Sat, 2 May 2020 18:20:02 +0000 (19:20 +0100)]
Darwin: Fix a diagnostic spelling [PR93861]

Add a missing '-' to a diagnostic.

gcc/ChangeLog:

2020-05-02  Iain Sandoe  <iain@sandoe.co.uk>

PR translation/93861
* config/darwin-driver.c (darwin_driver_init): Adjust spelling in
a warning.

4 years agoAdd asan subdirectory for gfortran.dg.
Thomas Koenig [Sat, 2 May 2020 15:30:01 +0000 (17:30 +0200)]
Add asan subdirectory for gfortran.dg.

Because the test case for PR 94788 requires -fsanitize=address to expose
the double free, I have created a subdirectory under gfortran.dg
where such test cases can go.

I have tested this with

make check-fortran RUNTESTFLAGS="asan.exp=*"

and it works; with a compiler that introduces the double free bug
into the test case, the result is as expected

2020-05-02  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/94788
* gfortran.dg/asan: New directory.
* gfortran.dg/asan/asan.exp: New file.
* gfortran.dg/asan/pointer_assign_16.f90: New test case.

4 years agotilegx: Unbreak build
Jakub Jelinek [Sat, 2 May 2020 10:09:04 +0000 (12:09 +0200)]
tilegx: Unbreak build

../../gcc/config/tilegx/tilegx.md:4109:1: ambiguous attribute 'n'; could be '1' (via 'I124MODE:n') or '4' (via 'I48MODE:n')
../../gcc/config/tilegx/tilegx.md:4109:1: ambiguous attribute 'n'; could be '1' (via 'I124MODE:n') or '' (via 'I48MODE:n')
../../gcc/config/tilegx/tilegx.md:4109:1: ambiguous attribute 'n'; could be '2' (via 'I124MODE:n') or '4' (via 'I48MODE:n')
../../gcc/config/tilegx/tilegx.md:4109:1: ambiguous attribute 'n'; could be '2' (via 'I124MODE:n') or '' (via 'I48MODE:n')
../../gcc/config/tilegx/tilegx.md:4109:1: ambiguous attribute 'n'; could be '4' (via 'I124MODE:n') or '' (via 'I48MODE:n')

The insn name already uses <I124MODE:n> explicitly, just the preparation
stmts don't, and as it creates a I124MODE lowpart subreg of a word mode
register, <I124MODE:n> seems obviously correct.

2020-05-02  Jakub Jelinek  <jakub@redhat.com>

* config/tilegx/tilegx.md
(insn_stnt<I124MODE:n>_add<I48MODE:bitsuffix>): Use <I124MODE:n>
rather than just <n>.

4 years agoAdd patch_area_size and patch_area_entry to crtl
H.J. Lu [Sat, 2 May 2020 04:03:10 +0000 (21:03 -0700)]
Add patch_area_size and patch_area_entry to crtl

Currently patchable area is at the wrong place.  It is placed immediately
after function label and before .cfi_startproc.  A backend should be able
to add a pseudo patchable area instruction durectly into RTL.  This patch
adds patch_area_size and patch_area_entry to crtl so that the patchable
area info is available in RTL passes.

It also limits patch_area_size and patch_area_entry to 65535, which is
a reasonable maximum size for patchable area.

gcc/

PR target/93492
* cfgexpand.c (pass_expand::execute): Set crtl->patch_area_size
and crtl->patch_area_entry.
* emit-rtl.h (rtl_data): Add patch_area_size and patch_area_entry.
* opts.c (common_handle_option): Limit
function_entry_patch_area_size and function_entry_patch_area_start
to USHRT_MAX.  Fix a typo in error message.
* varasm.c (assemble_start_function): Use crtl->patch_area_size
and crtl->patch_area_entry.
* doc/invoke.texi: Document the maximum value for
-fpatchable-function-entry.

gcc/c-family/

PR target/93492
* c-attribs.c (handle_patchable_function_entry_attribute): Limit
value to USHRT_MAX (65535).

gcc/testsuite/

PR target/93492
* c-c++-common/patchable_function_entry-error-1.c: New test.
* c-c++-common/patchable_function_entry-error-2.c: Likewise.
* c-c++-common/patchable_function_entry-error-3.c: Likewise.

4 years agoDaily bump.
GCC Administrator [Sat, 2 May 2020 00:16:18 +0000 (00:16 +0000)]
Daily bump.

4 years agoc++: Missing SFINAE with inaccessible static data member [PR90880]
Patrick Palka [Fri, 1 May 2020 20:18:19 +0000 (16:18 -0400)]
c++: Missing SFINAE with inaccessible static data member [PR90880]

This is a missing SFINAE issue when verifying the accessibility of a
static data member.

The cause is that check_accessibility_of_qualified_id unconditionally
passes tf_warning_or_error to perform_or_defer_access_check, even when
called from tsubst_qualified_id(..., complain=tf_none).

This patch fixes this by plumbing 'complain' from tsubst_qualified_id
through check_accessibility_of_qualified_id to reach
perform_or_defer_access_check, and by giving
check_accessibility_of_qualified_id the appropriate return value.

gcc/cp/ChangeLog:

PR c++/90880
* cp-tree.h (check_accessibility_of_qualified_id): Add
tsubst_flags_t parameter and change return type to bool.
* parser.c (cp_parser_lookup_name): Pass tf_warning_to_error to
check_accessibility_of_qualified_id.
* pt.c (tsubst_qualified_id): Return error_mark_node if
check_accessibility_of_qualified_id returns false.
* semantics.c (check_accessibility_of_qualified_id): Add
complain parameter.  Pass complain instead of
tf_warning_or_error to perform_or_defer_access_check.  Return
true unless perform_or_defer_access_check returns false.

gcc/testsuite/ChangeLog:

PR c++/90880
* g++.dg/template/sfinae29.C: New test.

4 years agoc++: Parenthesized-init of aggregates accepts invalid code [PR94885]
Marek Polacek [Thu, 30 Apr 2020 15:36:17 +0000 (11:36 -0400)]
c++: Parenthesized-init of aggregates accepts invalid code [PR94885]

Here we have (conceptually *) something like

  struct B { };
  struct D : B { };
  D(0); // invalid

and in C++20 the ()-initialization has created a { 0 } constructor that
it tries to initialize an object of type D with.  We should reject
initializing an object of type B from 0, but we wrongly accept it because
process_init_constructor_record skips initializers for empty bases/fields:
       if (DECL_SIZE (field) && integer_zerop (DECL_SIZE (field))
           && !TREE_SIDE_EFFECTS (next))
         /* Don't add trivial initialization of an empty base/field to the
            constructor, as they might not be ordered the way the back-end
            expects.  */
         continue;
but here 'next' was error_mark_node, returned by massage_elt_init, so we
wound up with { } which would validly value-initialize the object.

[*] Usually digest_init in build_new_method_call_1 would detect this,
but in this case the instance is is_dummy_object and we don't call
digest just yet.

PR c++/94885
* typeck2.c (process_init_constructor_record): Return PICFLAG_ERRONEOUS
if an initializer element was erroneous.

* g++.dg/cpp2a/paren-init26.C: New test.

4 years agoDarwin: Fix bootstrap break from libsanitizer changes.
Iain Sandoe [Fri, 1 May 2020 18:55:36 +0000 (19:55 +0100)]
Darwin: Fix bootstrap break from libsanitizer changes.

The recent libsanitizer change seems to have had a corrupt
chunk, that caused it to apply a change part way through the
SUBTARGET_INIT_BUILTINS macro, leading to a bootstrap fail
in stage1.

gcc/ChangeLog:

2020-05-01  Iain Sandoe  <iain@sandoe.co.uk>

* config/i386/darwin.h: Repair SUBTARGET_INIT_BUILTINS.
Override SUBTARGET_SHADOW_OFFSET macro.

4 years agotestsuite: Enable asan tests on FreeBSD x86_64
Andreas Tobler [Tue, 21 Jan 2020 21:16:02 +0000 (22:16 +0100)]
testsuite: Enable asan tests on FreeBSD x86_64

Enable asan tests on FreeBSD x86_64.

testsuite:

* gcc.dg/asan/pr87930.c: Enable on x86_64 FreeBSD.
* c-c++-common/asan/asan-interface-1.c: Likewise.
* c-c++-common/asan/clone-test-1.c: Likewise.
* c-c++-common/asan/no-asan-stack.c: Likewise.
* c-c++-common/asan/pr59063-1.c: Likewise.
* c-c++-common/asan/pr59063-2.c: Likewise.
* g++.dg/asan/asan_test.C: Likewise.
* g++.dg/asan/asan_test_utils.h: Likewise.
* g++.dg/asan/interception-failure-test-1.C: Likewise.
* g++.dg/asan/interception-malloc-test-1.C: Likewise.

4 years agoc++: Local class DMI using local static [PR90479]
Jason Merrill [Fri, 1 May 2020 17:53:32 +0000 (13:53 -0400)]
c++: Local class DMI using local static [PR90479]

For default member initializers in templates it's important to push into the
right context during get_nsdmi.  But for a local class that's not possible,
and trying leaves the function context we need to be in, so don't try.

gcc/cp/ChangeLog
2020-05-01  Jason Merrill  <jason@redhat.com>

PR c++/90479
* init.c (get_nsdmi): Don't push_to_top_level for a local class.

4 years agoc++: -fmerge-all-constants vs. destructors [PR91529]
Jason Merrill [Fri, 1 May 2020 17:53:32 +0000 (13:53 -0400)]
c++: -fmerge-all-constants vs. destructors [PR91529]

cp_finish_decl avoids setting TREE_READONLY on TREE_STATIC variables that
have non-constant construction or destruction, but -fmerge-all-constants was
converting an automatic variable to static while leaving TREE_READONLY set.

Fixed by clearing the flag in cp_finish_decl in the presence of
-fmerge-all-constants.

gcc/cp/ChangeLog
2020-05-01  Jason Merrill  <jason@redhat.com>

PR c++/91529
* decl.c (cp_finish_decl): Also clear TREE_READONLY if
-fmerge-all-constants.

4 years agoc++: generic lambda and -fsanitize=vla-bound [PR93822]
Jason Merrill [Fri, 1 May 2020 17:53:32 +0000 (13:53 -0400)]
c++: generic lambda and -fsanitize=vla-bound [PR93822]

Within the generic lambda the VLA capture proxy VAR_DECL has DECL_VALUE_EXPR
which is a NOP_EXPR to the VLA type of the proxy.  The problem here was that
when instantiating we were tsubsting that type twice, once for the type of
the DECL and once for the type of the NOP_EXPR, and getting two
different (though equivalent) types.  Then gimplify_type_sizes fixed up the
type of the DECL, but that didn't affect the type of the NOP_EXPR, leading
to sadness.

Fixed by directly reusing the type from the DECL.

gcc/cp/ChangeLog
2020-05-01  Jason Merrill  <jason@redhat.com>

PR c++/93822
* pt.c (tsubst_decl): Make sure DECL_VALUE_EXPR continues to have
the same type as the variable.

4 years agoi386: Use generic division to generate INVALID and DIVZERO exceptions
Uros Bizjak [Fri, 1 May 2020 17:20:57 +0000 (19:20 +0200)]
i386: Use generic division to generate INVALID and DIVZERO exceptions

Introduce math_force_eval to evaluate generic division to generate
INVALID and DIVZERO exceptions.

libgcc/ChangeLog:

* config/i386/sfp-exceptions.c (__math_force_eval): New define.
(__sfp_handle_exceptions): Use __math_force_eval to evaluete
generic division to generate INVALID and DIVZERO exceptions.

libatomic/ChangeLog:

* config/x86/fenv.c (__math_force_eval): New define.
(__atomic_feraiseexcept): Use __math_force_eval to evaluete
generic division to generate INVALID and DIVZERO exceptions.

libgfortran/ChangeLog:

* config/fpu-387.h (__math_force_eval): New define.
(local_feraiseexcept): Use __math_force_eval to evaluete
generic division to generate INVALID and DIVZERO exceptions.

4 years agogcc: Enable bits for sanitizer support on FreeBSD x86_64
Andreas Tobler [Fri, 1 May 2020 07:04:01 +0000 (09:04 +0200)]
gcc: Enable bits for sanitizer support on FreeBSD x86_64

This patch add the necessary bits to suport libasan on FreeBSD x86_64.

gcc
* config/i386/i386.h: Define a new macro: SUBTARGET_SHADOW_OFFSET.
* config/i386/i386.c (ix86_asan_shadow_offset): Use this macro.
* config/i386/darwin.h: Override the SUBTARGET_SHADOW_OFFSET macro.
* config/i386/freebsd.h: Likewise.
* config/freebsd.h (LIBASAN_EARLY_SPEC): Define.
LIBTSAN_EARLY_SPEC): Likewise. (LIBLSAN_EARLY_SPEC): Likewise.

libsanitizer:

* configure.tgt: Add x86_64- and i?86-*-freebsd* targets.