openpower-isa.git
14 months agoadd "WRONG" sv.cmp in test_pysvp64dis.py
Luke Kenneth Casson Leighton [Mon, 15 May 2023 20:47:18 +0000 (21:47 +0100)]
add "WRONG" sv.cmp in test_pysvp64dis.py

14 months agofix sv_analysis ldux, missing s/d:RA
Luke Kenneth Casson Leighton [Mon, 15 May 2023 20:46:18 +0000 (21:46 +0100)]
fix sv_analysis ldux, missing s/d:RA

14 months agosort out sv.cmp zz (and correct unit tests)
Luke Kenneth Casson Leighton [Mon, 15 May 2023 20:43:41 +0000 (21:43 +0100)]
sort out sv.cmp zz (and correct unit tests)

14 months agoCROpFF3RM and CROpFF5RM were swapped round.
Luke Kenneth Casson Leighton [Mon, 15 May 2023 20:06:56 +0000 (21:06 +0100)]
CROpFF3RM and CROpFF5RM were swapped round.
FF3 has the CR-bit
(and only zz - bit 6)
FF5 has only the inv-bit

14 months agofound the location to cut/paste the disassembly extra from
Luke Kenneth Casson Leighton [Mon, 15 May 2023 19:47:02 +0000 (20:47 +0100)]
found the location to cut/paste the disassembly extra from
https://bugs.libre-soc.org/show_bug.cgi?id=1084

14 months agoRC1 does not exist in CROps, the selection of behaviour *called* RC1
Luke Kenneth Casson Leighton [Mon, 15 May 2023 19:38:34 +0000 (20:38 +0100)]
RC1 does not exist in CROps, the selection of behaviour *called* RC1
is whether the CROp destination is a 3-bit CR *field* (RC1=0)
or if it is a 5-bit CR *bit* (RC1=1)

14 months agofix empty slot in EXTRA
Luke Kenneth Casson Leighton [Mon, 15 May 2023 19:16:15 +0000 (20:16 +0100)]
fix empty slot in EXTRA
move (swap) Mode[0] and Mode[1] in CROps,
ff y/n is now Mode[1], VLI is now Mode[0].
https://bugs.libre-soc.org/show_bug.cgi?id=1083

14 months agoextraneous space
Luke Kenneth Casson Leighton [Mon, 15 May 2023 19:01:38 +0000 (20:01 +0100)]
extraneous space

14 months agoremove extraneous space
Luke Kenneth Casson Leighton [Mon, 15 May 2023 18:58:13 +0000 (19:58 +0100)]
remove extraneous space

14 months agosome empty slots now in RM and also source=dest in EXTRA
Luke Kenneth Casson Leighton [Mon, 15 May 2023 15:38:01 +0000 (16:38 +0100)]
some empty slots now in RM and also source=dest in EXTRA

14 months agold/st mismatch in power_insn.py and sv_analysis.py
Luke Kenneth Casson Leighton [Mon, 15 May 2023 15:37:26 +0000 (16:37 +0100)]
ld/st mismatch in power_insn.py and sv_analysis.py
some EXTRA slots run empty now due to source/dest being the same
register (s:RA;d:RA)

14 months agoadd sv.ffmadds test to test_pysvp64dis.py
Luke Kenneth Casson Leighton [Mon, 15 May 2023 15:12:42 +0000 (16:12 +0100)]
add sv.ffmadds test to test_pysvp64dis.py

14 months agoin DCT/FFT 3-in 2-out set had to make RT same source-dest EXTRA
Luke Kenneth Casson Leighton [Mon, 15 May 2023 15:07:04 +0000 (16:07 +0100)]
in DCT/FFT 3-in 2-out set had to make RT same source-dest EXTRA
puzzlingly this frees up 2 bits but still cannot do EXTRA3 due to needing
1 bit for selecting RS=RT+MAXVL or RS=RC

14 months agomove RG bit in CRops to Mode[2] from Mode[3] MSB0-numbering
Luke Kenneth Casson Leighton [Mon, 15 May 2023 12:44:09 +0000 (13:44 +0100)]
move RG bit in CRops to Mode[2] from Mode[3] MSB0-numbering

14 months agogot linked-list-pointer-chasing working
Luke Kenneth Casson Leighton [Mon, 15 May 2023 11:55:20 +0000 (12:55 +0100)]
got linked-list-pointer-chasing working
including with LD/ST-with-update
https://bugs.libre-soc.org/show_bug.cgi?id=1047

14 months agobug in power_insn.py where record.svp64 is None (??)
Luke Kenneth Casson Leighton [Mon, 15 May 2023 11:46:29 +0000 (12:46 +0100)]
bug in power_insn.py where record.svp64 is None (??)

14 months agohave to now add LD/ST-update instructions to list of explicit-allowed
Luke Kenneth Casson Leighton [Mon, 15 May 2023 10:30:18 +0000 (11:30 +0100)]
have to now add LD/ST-update instructions to list of explicit-allowed
(as .long) due to extension of RA/RT with EXTRAs, the test RA!=RT is not
a 5-bit test it is a 7-bit test

14 months agoprevent duplicate EXTRA2/3 in power_insndb when assembling/disassembling
Luke Kenneth Casson Leighton [Mon, 15 May 2023 10:15:48 +0000 (11:15 +0100)]
prevent duplicate EXTRA2/3 in power_insndb when assembling/disassembling
https://bugs.libre-soc.org/show_bug.cgi?id=1084

14 months agopower_insn: filter out empty pcode lines
Dmitry Selyutin [Sun, 14 May 2023 20:25:34 +0000 (20:25 +0000)]
power_insn: filter out empty pcode lines

14 months agopower_insn: fix verbose assembly extra info
Dmitry Selyutin [Sun, 14 May 2023 20:15:09 +0000 (20:15 +0000)]
power_insn: fix verbose assembly extra info

14 months agoattempting to get LD/ST-Update SVP64 EXTRA3 working, getting some
Luke Kenneth Casson Leighton [Sun, 14 May 2023 16:34:10 +0000 (17:34 +0100)]
attempting to get LD/ST-Update SVP64 EXTRA3 working, getting some
interesting behaviour in pysvp64dis
https://bugs.libre-soc.org/show_bug.cgi?id=1084

14 months agoclassify LD/ST-Immediate-Update as EXTRA3.
Luke Kenneth Casson Leighton [Sun, 14 May 2023 15:44:24 +0000 (16:44 +0100)]
classify LD/ST-Immediate-Update as EXTRA3.
this allows continuous range on registers up to 128

14 months agowhitespace cleanup and remove as many PHP-style-formatters as i can stand
Luke Kenneth Casson Leighton [Sun, 14 May 2023 15:35:41 +0000 (16:35 +0100)]
whitespace cleanup and remove as many PHP-style-formatters as i can stand

14 months agoadd rest of bfp_* helpers needed to run fcvt js test
Jacob Lifshay [Sat, 13 May 2023 01:06:47 +0000 (18:06 -0700)]
add rest of bfp_* helpers needed to run fcvt js test

14 months agofix `even` polarity in bfp_ROUND_TO_INTEGER
Jacob Lifshay [Sat, 13 May 2023 01:05:24 +0000 (18:05 -0700)]
fix `even` polarity in bfp_ROUND_TO_INTEGER

14 months agoignore FPSCR in fcvt js test
Jacob Lifshay [Sat, 13 May 2023 01:04:39 +0000 (18:04 -0700)]
ignore FPSCR in fcvt js test

14 months agoallow ignoring FPSCR in tests
Jacob Lifshay [Sat, 13 May 2023 01:03:58 +0000 (18:03 -0700)]
allow ignoring FPSCR in tests

14 months agopow should not become self.pow
Jacob Lifshay [Sat, 13 May 2023 01:02:56 +0000 (18:02 -0700)]
pow should not become self.pow

14 months agofix bugs in fcvt* pseudocode
Jacob Lifshay [Sat, 13 May 2023 00:59:40 +0000 (17:59 -0700)]
fix bugs in fcvt* pseudocode

14 months agocheck expected CR fields in Data-Dependent Fail-First
Luke Kenneth Casson Leighton [Fri, 12 May 2023 20:01:52 +0000 (21:01 +0100)]
check expected CR fields in Data-Dependent Fail-First

14 months agoadd some bfp_* functions -- this isn't yet enough to run fcvt*
Jacob Lifshay [Fri, 12 May 2023 06:48:06 +0000 (23:48 -0700)]
add some bfp_* functions -- this isn't yet enough to run fcvt*

14 months agomake truediv available to pseudocode
Jacob Lifshay [Fri, 12 May 2023 06:44:51 +0000 (23:44 -0700)]
make truediv available to pseudocode

technically `/` in pseudocode is supposed to be real number division,
with `รท` being division with result truncated to integer, however
luke decided to just use `/` for integer division in pseudocode,
so we need a way to work around that.

14 months agoadd bfp classification predicates
Jacob Lifshay [Fri, 12 May 2023 06:43:41 +0000 (23:43 -0700)]
add bfp classification predicates

14 months agoallow assigning BFPState and SelectableMSB0Fraction values in pseudo-code
Jacob Lifshay [Fri, 12 May 2023 06:38:09 +0000 (23:38 -0700)]
allow assigning BFPState and SelectableMSB0Fraction values in pseudo-code

14 months agoadd support for *_flag global variables needed by bfp_* functions
Jacob Lifshay [Fri, 12 May 2023 06:35:41 +0000 (23:35 -0700)]
add support for *_flag global variables needed by bfp_* functions

14 months agomake lexer replace class with class_ since it's a python keyword
Jacob Lifshay [Fri, 12 May 2023 06:32:16 +0000 (23:32 -0700)]
make lexer replace class with class_ since it's a python keyword

14 months agofix SelectableMSB0Fraction's constructor
Jacob Lifshay [Fri, 12 May 2023 06:31:02 +0000 (23:31 -0700)]
fix SelectableMSB0Fraction's constructor

14 months agoundefined is a function that needs to be called
Jacob Lifshay [Fri, 12 May 2023 06:30:12 +0000 (23:30 -0700)]
undefined is a function that needs to be called

14 months agofix broken FPSCR fields
Jacob Lifshay [Fri, 12 May 2023 05:49:34 +0000 (22:49 -0700)]
fix broken FPSCR fields

14 months agoRevert "add stub reset_xflags function"
Jacob Lifshay [Fri, 12 May 2023 01:53:59 +0000 (18:53 -0700)]
Revert "add stub reset_xflags function"

the function actually should be in pseudocode

This reverts commit c44cd164b385a18fb635e7087c2a253c30d9c81c.

14 months agocorrections to dd-ffirst tests when VLi=0, the write to regfile
Luke Kenneth Casson Leighton [Thu, 11 May 2023 20:02:37 +0000 (21:02 +0100)]
corrections to dd-ffirst tests when VLi=0, the write to regfile
is *not* carried out on the failed test. but Rc=1 does (TODO)

14 months agoSelectableMSB0Fraction is now basically complete and correct afaict
Jacob Lifshay [Thu, 11 May 2023 08:05:04 +0000 (01:05 -0700)]
SelectableMSB0Fraction is now basically complete and correct afaict

14 months agoadd very very very basic write-out of instruction log
Luke Kenneth Casson Leighton [Wed, 10 May 2023 22:10:16 +0000 (23:10 +0100)]
add very very very basic write-out of instruction log

14 months agochange FPSCR to a required parameter of ISACallerHelper
Jacob Lifshay [Wed, 10 May 2023 05:17:49 +0000 (22:17 -0700)]
change FPSCR to a required parameter of ISACallerHelper

14 months agoRevert "remove now-unnecessary SO global, since XER[SO] syntax now translates to...
Jacob Lifshay [Wed, 10 May 2023 04:58:02 +0000 (21:58 -0700)]
Revert "remove now-unnecessary SO global, since XER[SO] syntax now translates to XER.SO"

luke wants the SO global to stay even though it's unnecessary

This reverts commit a50eb1eb70ee305ba3091455cf1473abd4a74fb2.

14 months agoswitch to using self.FPSCR
Jacob Lifshay [Wed, 10 May 2023 02:30:03 +0000 (19:30 -0700)]
switch to using self.FPSCR

14 months agoswitch to using FPSCRState for double2single.mdwn
Jacob Lifshay [Wed, 10 May 2023 02:27:41 +0000 (19:27 -0700)]
switch to using FPSCRState for double2single.mdwn

14 months agoadd self.FPSCR
Jacob Lifshay [Wed, 10 May 2023 02:16:37 +0000 (19:16 -0700)]
add self.FPSCR

14 months agoremove now-unnecessary SO global, since XER[SO] syntax now translates to XER.SO
Jacob Lifshay [Wed, 10 May 2023 02:12:01 +0000 (19:12 -0700)]
remove now-unnecessary SO global, since XER[SO] syntax now translates to XER.SO

14 months agosupport FPSCR[RN] syntax that translates to FPSCR.RN
Jacob Lifshay [Wed, 10 May 2023 01:54:26 +0000 (18:54 -0700)]
support FPSCR[RN] syntax that translates to FPSCR.RN

14 months agoadd support for accessing XER using XER.SO syntax -- intended for new pseudocode
Jacob Lifshay [Wed, 10 May 2023 01:48:47 +0000 (18:48 -0700)]
add support for accessing XER using XER.SO syntax -- intended for new pseudocode

14 months agoSetFX is not a normal function -- it can assign to its input
Jacob Lifshay [Tue, 9 May 2023 07:27:19 +0000 (00:27 -0700)]
SetFX is not a normal function -- it can assign to its input

14 months agoswitch fpcvt over to using FPSCR attributes
Jacob Lifshay [Tue, 9 May 2023 07:25:23 +0000 (00:25 -0700)]
switch fpcvt over to using FPSCR attributes

14 months agoadd parser support for attributes like FPSCR.RN
Jacob Lifshay [Tue, 9 May 2023 07:22:57 +0000 (00:22 -0700)]
add parser support for attributes like FPSCR.RN

14 months agomove apply_trailer into parser class
Jacob Lifshay [Tue, 9 May 2023 07:13:08 +0000 (00:13 -0700)]
move apply_trailer into parser class

14 months agobypass ply's eating SyntaxErrors
Jacob Lifshay [Tue, 9 May 2023 07:10:27 +0000 (00:10 -0700)]
bypass ply's eating SyntaxErrors

14 months agoFPSCR.FPRF can be assigned strings
Jacob Lifshay [Tue, 9 May 2023 07:06:30 +0000 (00:06 -0700)]
FPSCR.FPRF can be assigned strings

14 months agoadd XERState since XER has fields too
Jacob Lifshay [Tue, 9 May 2023 07:05:30 +0000 (00:05 -0700)]
add XERState since XER has fields too

14 months agoadd ld/st data-dependent fail-first /vli (inclusive)
Luke Kenneth Casson Leighton [Wed, 10 May 2023 18:30:51 +0000 (19:30 +0100)]
add ld/st data-dependent fail-first /vli (inclusive)

14 months agofix data-dependent fail-first on load
Luke Kenneth Casson Leighton [Wed, 10 May 2023 18:28:27 +0000 (19:28 +0100)]
fix data-dependent fail-first on load

14 months agopower_insn: remove redundant logs
Dmitry Selyutin [Wed, 10 May 2023 17:17:58 +0000 (17:17 +0000)]
power_insn: remove redundant logs

14 months agocyclemodel/inorder: hide set inheritance
Dmitry Selyutin [Wed, 10 May 2023 11:54:23 +0000 (04:54 -0700)]
cyclemodel/inorder: hide set inheritance

14 months agocyclemodel/inorder: fix coding style
Dmitry Selyutin [Wed, 10 May 2023 11:52:49 +0000 (04:52 -0700)]
cyclemodel/inorder: fix coding style

14 months agoextend previous hard-coded magic constant (256) used to indicate
Luke Kenneth Casson Leighton [Wed, 10 May 2023 11:33:26 +0000 (12:33 +0100)]
extend previous hard-coded magic constant (256) used to indicate
"effectively unlimited" (see check_extsign) out to 1024. it would be
better to set this at the bare-minimum limit (257, 258) as it requests
that python runtime create massive-large ints

14 months agoadd WIP fp_working_format.py
Jacob Lifshay [Wed, 10 May 2023 08:21:00 +0000 (01:21 -0700)]
add WIP fp_working_format.py

14 months agoseparate ISAPages out from inherited ISA Class
Luke Kenneth Casson Leighton [Tue, 9 May 2023 17:26:49 +0000 (18:26 +0100)]
separate ISAPages out from inherited ISA Class

14 months agofix some broken FieldSelectableInt handling
Jacob Lifshay [Tue, 9 May 2023 06:10:29 +0000 (23:10 -0700)]
fix some broken FieldSelectableInt handling

14 months agocomment TODO on Load-Fault in strncpy example
Luke Kenneth Casson Leighton [Sun, 7 May 2023 09:44:36 +0000 (10:44 +0100)]
comment TODO on Load-Fault in strncpy example

14 months agoadd stub reset_xflags function
Luke Kenneth Casson Leighton [Sun, 7 May 2023 09:12:41 +0000 (10:12 +0100)]
add stub reset_xflags function

14 months agominor_19.csv: convert RA to RA0 for minmax
Dmitry Selyutin [Sun, 7 May 2023 08:13:46 +0000 (11:13 +0300)]
minor_19.csv: convert RA to RA0 for minmax

14 months agoadd FPSCR to Test API (ExpectedState, SimState). untested
Luke Kenneth Casson Leighton [Sat, 6 May 2023 13:31:13 +0000 (14:31 +0100)]
add FPSCR to Test API (ExpectedState, SimState). untested

14 months agoadd FPSCR to ISACaller
Luke Kenneth Casson Leighton [Sat, 6 May 2023 13:26:39 +0000 (14:26 +0100)]
add FPSCR to ISACaller

14 months agonotes: make FPSCR definition more like MSR (see openpower/consts.py)
Luke Kenneth Casson Leighton [Sat, 6 May 2023 13:22:44 +0000 (14:22 +0100)]
notes: make FPSCR definition more like MSR (see openpower/consts.py)

14 months agodrastically simplify fpscr.py. extreme overcomplexity introducing
Luke Kenneth Casson Leighton [Sat, 6 May 2023 13:21:04 +0000 (14:21 +0100)]
drastically simplify fpscr.py. extreme overcomplexity introducing
an entirely new paradigm - without discussion - creates a maintenance
headache we cannot afford

14 months agoadd comment about why the new check has been added
Luke Kenneth Casson Leighton [Sat, 6 May 2023 09:07:28 +0000 (10:07 +0100)]
add comment about why the new check has been added

14 months agoget table down to under 80 chars per line
Luke Kenneth Casson Leighton [Sat, 6 May 2023 09:02:43 +0000 (10:02 +0100)]
get table down to under 80 chars per line

14 months agofix fpscr table parser error reporting
Jacob Lifshay [Sat, 6 May 2023 03:38:22 +0000 (20:38 -0700)]
fix fpscr table parser error reporting

14 months agoadd FPSCRState and FPSCRRecord and a FPSCR smoke-test
Jacob Lifshay [Sat, 6 May 2023 03:34:18 +0000 (20:34 -0700)]
add FPSCRState and FPSCRRecord and a FPSCR smoke-test

14 months agoadd initial fmv/fcvt tests, though they're broken due to FPSCR being unimplemented
Jacob Lifshay [Fri, 5 May 2023 02:19:29 +0000 (19:19 -0700)]
add initial fmv/fcvt tests, though they're broken due to FPSCR being unimplemented

14 months agoadd check that generated .py files are in .gitignore
Jacob Lifshay [Fri, 5 May 2023 00:55:15 +0000 (17:55 -0700)]
add check that generated .py files are in .gitignore

14 months agoverify fields.txt forms' field separators ('|') line up with headers'
Jacob Lifshay [Fri, 5 May 2023 00:34:27 +0000 (17:34 -0700)]
verify fields.txt forms' field separators ('|') line up with headers'

14 months agomerge maddrs/msubrs, unit tests changed accordingly
Konstantinos Margaritis [Thu, 4 May 2023 15:38:33 +0000 (15:38 +0000)]
merge maddrs/msubrs, unit tests changed accordingly

14 months agoAdd 2 more instructions to help with 2-coeff butterfly
Konstantinos Margaritis [Thu, 4 May 2023 14:11:31 +0000 (14:11 +0000)]
Add 2 more instructions to help with 2-coeff butterfly
fdct_round_shift(a*c1 +/- b*c2)
They are to be used complementary to maddsubrs, so one can now
do this calculation in 3 instructions.
Added some unit tests to demonstrate the operation.

14 months agouse a simpler way to do the same thing
Konstantinos Margaritis [Mon, 1 May 2023 18:05:10 +0000 (18:05 +0000)]
use a simpler way to do the same thing

14 months agoHandle large 64-bit values, but only the low 64-bit half of the multiplication, add...
Konstantinos Margaritis [Sun, 30 Apr 2023 21:29:47 +0000 (21:29 +0000)]
Handle large 64-bit values, but only the low 64-bit half of the multiplication, add more tests

14 months agodo proper rounding, no rounding for SH=0 (for now), add tests
Konstantinos Margaritis [Sun, 30 Apr 2023 18:10:35 +0000 (18:10 +0000)]
do proper rounding, no rounding for SH=0 (for now), add tests

14 months agoResult needs rounding so add +1 to prod*
Konstantinos Margaritis [Sat, 29 Apr 2023 15:29:32 +0000 (15:29 +0000)]
Result needs rounding so add +1 to prod*

14 months agohandle negatives correctly by adding sign bit to final result
Konstantinos Margaritis [Fri, 28 Apr 2023 16:41:22 +0000 (16:41 +0000)]
handle negatives correctly by adding sign bit to final result

14 months agoalmost there, positive values work, negative values differ by 1
Konstantinos Margaritis [Fri, 28 Apr 2023 16:02:26 +0000 (16:02 +0000)]
almost there, positive values work, negative values differ by 1

14 months agouse proper register sizes
Konstantinos Margaritis [Fri, 28 Apr 2023 11:48:48 +0000 (11:48 +0000)]
use proper register sizes

14 months agoMULS instead of MUL, RA instead of RT in in1
Konstantinos Margaritis [Fri, 28 Apr 2023 11:41:02 +0000 (11:41 +0000)]
MULS instead of MUL, RA instead of RT in in1

14 months agoTurns out DCTI-Form is another variant of A-Form
Konstantinos Margaritis [Fri, 28 Apr 2023 11:26:11 +0000 (11:26 +0000)]
Turns out DCTI-Form is another variant of A-Form

14 months agominor fixes in pseudocode, CONST_UI->CONST_SH in minor_22.csv
Konstantinos Margaritis [Fri, 28 Apr 2023 11:10:24 +0000 (11:10 +0000)]
minor fixes in pseudocode, CONST_UI->CONST_SH in minor_22.csv

14 months agoWIP: maddsubrs initial approach
Konstantinos Margaritis [Fri, 28 Apr 2023 09:46:45 +0000 (09:46 +0000)]
WIP: maddsubrs initial approach

14 months agomaddsubrs no longer has CR0
Luke Kenneth Casson Leighton [Thu, 4 May 2023 14:16:06 +0000 (15:16 +0100)]
maddsubrs no longer has CR0

14 months agofix forgotten stuff from last commit
Jacob Lifshay [Thu, 4 May 2023 04:41:31 +0000 (21:41 -0700)]
fix forgotten stuff from last commit

14 months agoadd fcvt/fmv -- no tests yet
Jacob Lifshay [Thu, 4 May 2023 04:27:06 +0000 (21:27 -0700)]
add fcvt/fmv -- no tests yet

14 months agosupport calling functions with no args in pseudocode
Jacob Lifshay [Thu, 4 May 2023 04:25:42 +0000 (21:25 -0700)]
support calling functions with no args in pseudocode

14 months agoshow actual mdwn source location in backtrace when parser raises SyntaxError
Jacob Lifshay [Thu, 4 May 2023 04:15:45 +0000 (21:15 -0700)]
show actual mdwn source location in backtrace when parser raises SyntaxError

14 months agomove Assign to parser class in prep for improving syntax error reporting
Jacob Lifshay [Thu, 4 May 2023 04:08:49 +0000 (21:08 -0700)]
move Assign to parser class in prep for improving syntax error reporting