cached-property.git
6 years agoRelease 1.5.0 1.5.0
Daniel [Wed, 5 Sep 2018 15:23:58 +0000 (08:23 -0700)]
Release 1.5.0

6 years agoUpdate pytest and pytest-cov
Daniel [Wed, 5 Sep 2018 15:18:23 +0000 (08:18 -0700)]
Update pytest and pytest-cov

6 years agoMerge pull request #114 from luzfcb/fix-travis-ci-python3.7_build
Daniel Roy Greenfeld [Wed, 5 Sep 2018 02:21:45 +0000 (19:21 -0700)]
Merge pull request #114 from luzfcb/fix-travis-ci-python3.7_build

use sudo=true and dist: xenial to fix python3.7 travis-ci build

6 years agofix travis-ci python3.7 build
Fabio C. Barrioneuvo da Luz [Wed, 5 Sep 2018 00:41:14 +0000 (21:41 -0300)]
fix travis-ci python3.7 build

6 years agoBump project version
Daniel [Tue, 31 Jul 2018 15:48:46 +0000 (08:48 -0700)]
Bump project version

6 years agoUpdate to add Python 3.7 and remove 3.3
Daniel [Tue, 31 Jul 2018 15:47:51 +0000 (08:47 -0700)]
Update to add Python 3.7 and remove 3.3

6 years agoMerge pull request #103 from asottile/patch-1
Daniel Roy Greenfeld [Thu, 14 Jun 2018 16:31:41 +0000 (09:31 -0700)]
Merge pull request #103 from asottile/patch-1

Also catch `SyntaxError` from asyncio import

6 years agoMerge pull request #101 from pydanny/pyup-update-pytest-3.5.0-to-3.6.1
Daniel Roy Greenfeld [Thu, 14 Jun 2018 16:30:26 +0000 (09:30 -0700)]
Merge pull request #101 from pydanny/pyup-update-pytest-3.5.0-to-3.6.1

Update pytest to 3.6.1

6 years agoMerge pull request #98 from pydanny/pyup-update-wheel-0.30.0-to-0.31.1
Daniel Roy Greenfeld [Thu, 14 Jun 2018 16:30:14 +0000 (09:30 -0700)]
Merge pull request #98 from pydanny/pyup-update-wheel-0.30.0-to-0.31.1

Update wheel to 0.31.1

6 years agoMerge branch 'master' into pyup-update-wheel-0.30.0-to-0.31.1 pyup-update-wheel-0.30.0-to-0.31.1
Daniel Roy Greenfeld [Thu, 14 Jun 2018 16:29:45 +0000 (09:29 -0700)]
Merge branch 'master' into pyup-update-wheel-0.30.0-to-0.31.1

6 years agoMerge pull request #92 from pydanny/pyup-update-wheel-0.30.0-to-0.31.0
Daniel Roy Greenfeld [Thu, 14 Jun 2018 16:29:21 +0000 (09:29 -0700)]
Merge pull request #92 from pydanny/pyup-update-wheel-0.30.0-to-0.31.0

Update wheel to 0.31.0

6 years agoAlso catch `SyntaxError` from asyncio import
Anthony Sottile [Mon, 11 Jun 2018 18:32:55 +0000 (11:32 -0700)]
Also catch `SyntaxError` from asyncio import

Apparently, `asyncio` is installable in python 2 and an import can trigger this:

```bash
pip install asyncio cached-property
python -c 'import cached_property'
```

```python
$ python -c 'import cached_property'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/private/tmp/venv/lib/python2.7/site-packages/cached_property.py", line 12, in <module>
    import asyncio
  File "/private/tmp/venv/lib/python2.7/site-packages/asyncio/__init__.py", line 9, in <module>
    from . import selectors
  File "/private/tmp/venv/lib/python2.7/site-packages/asyncio/selectors.py", line 39
    "{!r}".format(fileobj)) from None
                               ^
SyntaxError: invalid syntax
```

Originally seen in https://github.com/pre-commit/pre-commit/issues/766

6 years agoUpdate pytest from 3.5.0 to 3.6.1 pyup-update-pytest-3.5.0-to-3.6.1
pyup-bot [Wed, 6 Jun 2018 01:41:05 +0000 (18:41 -0700)]
Update pytest from 3.5.0 to 3.6.1

6 years agoUpdate wheel from 0.30.0 to 0.31.1
pyup-bot [Mon, 14 May 2018 01:13:20 +0000 (18:13 -0700)]
Update wheel from 0.30.0 to 0.31.1

6 years agoMerge pull request #97 from robert-cody/doc_fix_and_gitignore
Daniel Roy Greenfeld [Wed, 2 May 2018 19:10:48 +0000 (12:10 -0700)]
Merge pull request #97 from robert-cody/doc_fix_and_gitignore

Doc fix and gitignore

6 years agoAdd IntelliJ IDEA and local venvs to .gitignore.
robert-cody [Wed, 2 May 2018 17:23:08 +0000 (20:23 +0300)]
Add IntelliJ IDEA and local venvs to .gitignore.

6 years agoBlank line is required after literal block.
robert-cody [Wed, 2 May 2018 17:22:21 +0000 (20:22 +0300)]
Blank line is required after literal block.

6 years agoUpdate README.rst
Daniel Roy Greenfeld [Mon, 16 Apr 2018 14:14:14 +0000 (09:14 -0500)]
Update README.rst

6 years agoMerge pull request #94 from gtback/patch-1
Daniel Roy Greenfeld [Mon, 9 Apr 2018 23:30:29 +0000 (18:30 -0500)]
Merge pull request #94 from gtback/patch-1

Update release dates for 1.4.1 and 1.4.2

6 years agoUpdate release dates for 1.4.1. and 1.4.2
Greg Back [Mon, 9 Apr 2018 19:13:49 +0000 (14:13 -0500)]
Update release dates for 1.4.1. and 1.4.2

6 years agoMerge branch 'master' into pyup-update-wheel-0.30.0-to-0.31.0 pyup-update-wheel-0.30.0-to-0.31.0
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:59:00 +0000 (17:59 -0500)]
Merge branch 'master' into pyup-update-wheel-0.30.0-to-0.31.0

6 years agoReally fixed the tests per 1.4.2
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:57:13 +0000 (17:57 -0500)]
Really fixed the tests per

6 years agoUpdate contributing docs
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:56:39 +0000 (17:56 -0500)]
Update contributing docs

6 years agoUpdate contributing docs
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:55:00 +0000 (17:55 -0500)]
Update contributing docs

6 years agoFix the tests
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:52:07 +0000 (17:52 -0500)]
Fix the tests

6 years agoRemove black so travis doesnt blow up
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:27:28 +0000 (17:27 -0500)]
Remove black so travis doesnt blow up

6 years agoAdd black code style back
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:25:01 +0000 (17:25 -0500)]
Add black code style back

6 years agoCorrected test invocation
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:23:51 +0000 (17:23 -0500)]
Corrected test invocation

6 years agoImproved code formatting and prep for release 1.4.1 1.4.1
Daniel Roy Greenfeld [Sun, 8 Apr 2018 22:19:00 +0000 (17:19 -0500)]
Improved code formatting and prep for release 1.4.1

6 years agoMerge branch 'master' into pyup-update-wheel-0.30.0-to-0.31.0
Daniel Roy Greenfeld [Fri, 6 Apr 2018 14:40:15 +0000 (09:40 -0500)]
Merge branch 'master' into pyup-update-wheel-0.30.0-to-0.31.0

6 years agoMerge pull request #91 from pydanny/pyup-update-pytest-3.3.0-to-3.5.0
Daniel Roy Greenfeld [Fri, 6 Apr 2018 14:39:43 +0000 (09:39 -0500)]
Merge pull request #91 from pydanny/pyup-update-pytest-3.3.0-to-3.5.0

Update pytest to 3.5.0

6 years agoMerge pull request #89 from pydanny/pyup-update-freezegun-0.3.9-to-0.3.10
Daniel Roy Greenfeld [Fri, 6 Apr 2018 14:39:33 +0000 (09:39 -0500)]
Merge pull request #89 from pydanny/pyup-update-freezegun-0.3.9-to-0.3.10

Update freezegun to 0.3.10

6 years agoDon't test asyncio on older versions of Python
Daniel Roy Greenfeld [Thu, 5 Apr 2018 03:03:02 +0000 (22:03 -0500)]
Don't test asyncio on older versions of Python

Per #93, asyncio tests need to be bypassed for older versions of Python

6 years agoUpdate wheel from 0.30.0 to 0.31.0
pyup-bot [Mon, 2 Apr 2018 04:00:12 +0000 (23:00 -0500)]
Update wheel from 0.30.0 to 0.31.0

6 years agoUpdate pytest from 3.3.0 to 3.5.0 pyup-update-pytest-3.3.0-to-3.5.0
pyup-bot [Fri, 23 Mar 2018 11:35:55 +0000 (06:35 -0500)]
Update pytest from 3.3.0 to 3.5.0

6 years agoUpdate freezegun from 0.3.9 to 0.3.10 pyup-update-freezegun-0.3.9-to-0.3.10
pyup-bot [Tue, 6 Mar 2018 04:04:31 +0000 (23:04 -0500)]
Update freezegun from 0.3.9 to 0.3.10

6 years agoUpdate HISTORY.rst
Daniel Roy Greenfeld [Mon, 26 Feb 2018 23:11:11 +0000 (18:11 -0500)]
Update HISTORY.rst

6 years agoMerge pull request #87 from dotlambda/patch-1
Daniel Roy Greenfeld [Mon, 26 Feb 2018 23:10:17 +0000 (18:10 -0500)]
Merge pull request #87 from dotlambda/patch-1

Include conftest.py in PyPI tarball

6 years agoInclude conftest.py in PyPI tarball
Robert Schütz [Mon, 26 Feb 2018 22:39:37 +0000 (23:39 +0100)]
Include conftest.py in PyPI tarball

This is required to make the tests work.

6 years agoRemove Python 2.6 support and bump to 1.4.0 1.4.0
Daniel Roy Greenfeld [Sun, 25 Feb 2018 23:03:34 +0000 (18:03 -0500)]
Remove Python 2.6 support and bump to 1.4.0

6 years agoMerge pull request #86 from vbraun/async_await
Daniel Roy Greenfeld [Sun, 25 Feb 2018 22:56:30 +0000 (17:56 -0500)]
Merge pull request #86 from vbraun/async_await

Support @cached_property coroutines (async/await)

6 years agoSupport cached coroutines (async/await)
Volker Braun [Sun, 25 Feb 2018 14:30:58 +0000 (15:30 +0100)]
Support cached coroutines (async/await)

6 years agoUpdate requirements.txt
Daniel Roy Greenfeld [Tue, 28 Nov 2017 15:12:52 +0000 (07:12 -0800)]
Update requirements.txt

6 years agoUpdate requirements.txt
Daniel Roy Greenfeld [Tue, 28 Nov 2017 15:12:30 +0000 (07:12 -0800)]
Update requirements.txt

6 years agoMerge pull request #74 from pydanny/pyup-update-coverage-4.4.1-to-4.4.2
Daniel Roy Greenfeld [Tue, 28 Nov 2017 15:08:30 +0000 (07:08 -0800)]
Merge pull request #74 from pydanny/pyup-update-coverage-4.4.1-to-4.4.2

Update coverage to 4.4.2

7 years agoUpdate coverage from 4.4.1 to 4.4.2 pyup-update-coverage-4.4.1-to-4.4.2
pyup-bot [Sun, 5 Nov 2017 22:20:51 +0000 (14:20 -0800)]
Update coverage from 4.4.1 to 4.4.2

7 years agoSwitch two scoops academy to two scoops press
Audrey Roy Greenfeld [Fri, 22 Sep 2017 00:09:23 +0000 (17:09 -0700)]
Switch two scoops academy to two scoops press

7 years agoUpdate to Python 3.6 1.3.1
Audrey Roy Greenfeld [Fri, 22 Sep 2017 00:04:03 +0000 (17:04 -0700)]
Update to Python 3.6

7 years agoMerge pull request #60 from pydanny/pyup-update-coverage-4.1-to-4.4.1
Daniel Roy Greenfeld [Thu, 21 Sep 2017 23:11:35 +0000 (16:11 -0700)]
Merge pull request #60 from pydanny/pyup-update-coverage-4.1-to-4.4.1

Update coverage to 4.4.1

7 years agoMerge pull request #59 from pydanny/pyup-update-freezegun-0.3.7-to-0.3.9
Daniel Roy Greenfeld [Thu, 21 Sep 2017 23:11:15 +0000 (16:11 -0700)]
Merge pull request #59 from pydanny/pyup-update-freezegun-0.3.7-to-0.3.9

Update freezegun to 0.3.9

7 years agoUpdate coverage from 4.1 to 4.4.1 pyup-update-coverage-4.1-to-4.4.1
pyup-bot [Mon, 15 May 2017 06:37:34 +0000 (23:37 -0700)]
Update coverage from 4.1 to 4.4.1

7 years agoUpdate freezegun from 0.3.7 to 0.3.9 pyup-update-freezegun-0.3.7-to-0.3.9
pyup-bot [Sat, 13 May 2017 01:07:30 +0000 (18:07 -0700)]
Update freezegun from 0.3.7 to 0.3.9

7 years agoMerge pull request #43 from pydanny/pyup-update-pytest-cov-2.3.0-to-2.4.0
Daniel Roy Greenfeld [Thu, 13 Apr 2017 22:02:56 +0000 (15:02 -0700)]
Merge pull request #43 from pydanny/pyup-update-pytest-cov-2.3.0-to-2.4.0

Update pytest-cov to 2.4.0

8 years agoUpdate pytest-cov from 2.3.0 to 2.4.0 pyup-update-pytest-cov-2.3.0-to-2.4.0
pyup-bot [Mon, 10 Oct 2016 20:01:44 +0000 (13:01 -0700)]
Update pytest-cov from 2.3.0 to 2.4.0

8 years agoMerge pull request #35 from pydanny/pyup-update-pytest-cov-2.2.0-to-2.3.0
Daniel Roy Greenfeld [Mon, 18 Jul 2016 21:05:14 +0000 (14:05 -0700)]
Merge pull request #35 from pydanny/pyup-update-pytest-cov-2.2.0-to-2.3.0

Update pytest-cov to 2.3.0

8 years agoUpdate pytest-cov from 2.2.0 to 2.3.0 pyup-update-pytest-cov-2.2.0-to-2.3.0
pyup-bot [Tue, 5 Jul 2016 20:07:50 +0000 (13:07 -0700)]
Update pytest-cov from 2.2.0 to 2.3.0

8 years agoUpdate README.rst
Daniel Roy Greenfeld [Wed, 22 Jun 2016 21:59:55 +0000 (05:59 +0800)]
Update README.rst

8 years agoUpdate README.rst
Daniel Roy Greenfeld [Mon, 20 Jun 2016 06:51:34 +0000 (23:51 -0700)]
Update README.rst

8 years agoUpdate README.rst
Daniel Roy Greenfeld [Thu, 9 Jun 2016 06:07:45 +0000 (23:07 -0700)]
Update README.rst

8 years agoMerge pull request #33 from pydanny/pyup-initial-update
Daniel Roy Greenfeld [Thu, 9 Jun 2016 06:06:33 +0000 (23:06 -0700)]
Merge pull request #33 from pydanny/pyup-initial-update

Initial Update

8 years agoMerge pull request #23 from mbehrle/fix-codec
Daniel Roy Greenfeld [Thu, 9 Jun 2016 06:01:53 +0000 (23:01 -0700)]
Merge pull request #23 from mbehrle/fix-codec

Fixing UnicodeDecodeError in setup.py (issue22).

8 years agoPin freezegun to latest version 0.3.7 pyup-initial-update
pyup-bot [Thu, 9 Jun 2016 05:58:42 +0000 (22:58 -0700)]
Pin freezegun to latest version 0.3.7

8 years agoUpdate wheel from 0.23.0 to 0.29.0
pyup-bot [Thu, 9 Jun 2016 05:58:41 +0000 (22:58 -0700)]
Update wheel from 0.23.0 to 0.29.0

8 years agoPin pytest-cov to latest version 2.2.0
pyup-bot [Thu, 9 Jun 2016 05:58:41 +0000 (22:58 -0700)]
Pin pytest-cov to latest version 2.2.0

8 years agoPin pytest to latest version 2.9.2
pyup-bot [Thu, 9 Jun 2016 05:58:40 +0000 (22:58 -0700)]
Pin pytest to latest version 2.9.2

8 years agoPin coverage to latest version 4.1
pyup-bot [Thu, 9 Jun 2016 05:58:39 +0000 (22:58 -0700)]
Pin coverage to latest version 4.1

8 years agoAdded @adamwill to authors
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:53:15 +0000 (17:53 -0800)]
Added @adamwill to authors

8 years agoPrep for 1.3.0 release 1.3.0
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:48:05 +0000 (17:48 -0800)]
Prep for 1.3.0 release

8 years agoUse more modern SVG badges and fix their links.
Audrey Roy Greenfeld [Wed, 25 Nov 2015 01:42:11 +0000 (17:42 -0800)]
Use more modern SVG badges and fix their links.

8 years agoFixing travis
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:45:14 +0000 (17:45 -0800)]
Fixing travis

8 years agoUpdate authors and history
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:43:30 +0000 (17:43 -0800)]
Update authors and history

8 years agoMerge branch 'master' of github.com:pydanny/cached-property
Audrey Roy Greenfeld [Wed, 25 Nov 2015 01:38:40 +0000 (17:38 -0800)]
Merge branch 'master' of github.com:pydanny/cached-property

8 years agoUpdating to a production/stable designation
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:41:19 +0000 (17:41 -0800)]
Updating to a production/stable designation

8 years agoAdd sudo: false so that Travis runs on new container-based infrastructure.
Audrey Roy Greenfeld [Wed, 25 Nov 2015 01:38:32 +0000 (17:38 -0800)]
Add sudo: false so that Travis runs on new container-based infrastructure.

8 years agoPython 3.5 support and history/authors
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:35:02 +0000 (17:35 -0800)]
Python 3.5 support and history/authors

8 years agoMerge pull request #28 from proofit404/master
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:28:03 +0000 (17:28 -0800)]
Merge pull request #28 from proofit404/master

Correct invalidation cache documentation.

8 years agoAdded @ionelmc to the contributors list
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:30:43 +0000 (17:30 -0800)]
Added @ionelmc to the contributors list

8 years agoMerge pull request #25 from ionelmc/patch-1
Daniel Roy Greenfeld [Wed, 25 Nov 2015 01:24:31 +0000 (17:24 -0800)]
Merge pull request #25 from ionelmc/patch-1

Remove confusingly placed lock from example

8 years agoCorrect invalidation cache documentation.
Artem Malyshev [Wed, 18 Nov 2015 07:04:40 +0000 (10:04 +0300)]
Correct invalidation cache documentation.

9 years agoCleanup example.
Ionel Cristian Mărieș [Thu, 1 Oct 2015 12:55:53 +0000 (15:55 +0300)]
Cleanup example.

9 years agoRemove confusingly placed lock from example
Ionel Cristian Mărieș [Thu, 1 Oct 2015 12:54:20 +0000 (15:54 +0300)]
Remove confusingly placed lock from example

9 years agoFixing UnicodeDecodeError in setup.py (issue22).
Mathias Behrle [Tue, 12 May 2015 12:49:22 +0000 (14:49 +0200)]
Fixing UnicodeDecodeError in setup.py (issue22).

9 years agoFix Adam's name
Daniel Greenfeld [Thu, 30 Apr 2015 21:43:16 +0000 (14:43 -0700)]
Fix Adam's name

9 years agoUpdate AUTHORS.rst
Daniel Greenfeld [Thu, 30 Apr 2015 16:30:49 +0000 (09:30 -0700)]
Update AUTHORS.rst

9 years agoMerge pull request #20 from AdamWill/utf8
Daniel Greenfeld [Thu, 30 Apr 2015 16:30:22 +0000 (09:30 -0700)]
Merge pull request #20 from AdamWill/utf8

drop some non-ASCII characters from HISTORY.rst

9 years agodrop some non-ASCII characters from HISTORY.rst
Adam Williamson [Wed, 29 Apr 2015 23:54:14 +0000 (16:54 -0700)]
drop some non-ASCII characters from HISTORY.rst

This file was using some odd unicode character instead of a
normal apostrophe in a couple of places. Replace one occurrence
with a normal apostrophe and remove the other (the possessive
"its" does not contain an apostrophe).

9 years agoUpdate README.rst
Daniel Greenfeld [Tue, 28 Apr 2015 16:52:10 +0000 (09:52 -0700)]
Update README.rst

9 years agoBump for 1.2.0 1.2.0
Daniel Greenfeld [Tue, 28 Apr 2015 16:34:43 +0000 (09:34 -0700)]
Bump for 1.2.0

9 years agoUpdate HISTORY.rst
Daniel Greenfeld [Tue, 28 Apr 2015 16:30:45 +0000 (09:30 -0700)]
Update HISTORY.rst

9 years agoUpdate HISTORY.rst
Daniel Greenfeld [Tue, 28 Apr 2015 16:28:53 +0000 (09:28 -0700)]
Update HISTORY.rst

9 years agoUpdate HISTORY.rst
Daniel Greenfeld [Tue, 28 Apr 2015 16:24:19 +0000 (09:24 -0700)]
Update HISTORY.rst

9 years agoAdded @gsakkis to contributors
Daniel Greenfeld [Wed, 22 Apr 2015 02:49:58 +0000 (19:49 -0700)]
Added @gsakkis to contributors

9 years agoMerge pull request #18 from gsakkis/master
Daniel Greenfeld [Wed, 22 Apr 2015 02:48:15 +0000 (19:48 -0700)]
Merge pull request #18 from gsakkis/master

Misc improvements AWESOME!!!!

9 years agoFixes for Python 2.6 and Python 3
George Sakkis [Tue, 21 Apr 2015 10:09:05 +0000 (13:09 +0300)]
Fixes for Python 2.6 and Python 3

9 years agoRevert cached_property_with_ttl/threaded_cached_property_with_ttl to settable just...
George Sakkis [Tue, 21 Apr 2015 00:21:36 +0000 (03:21 +0300)]
Revert cached_property_with_ttl/threaded_cached_property_with_ttl to settable just like cached_property/threaded_cached_property

9 years agoRefactor cached_property_with_ttl.
George Sakkis [Tue, 21 Apr 2015 00:08:27 +0000 (03:08 +0300)]
Refactor cached_property_with_ttl.

Cache (value, time) in the object's __dict__ instead of doing an extra lookup
in a '_cache' dict; also avoids the potential name clash with an unrelated
attribute named '_cache'.

9 years agoBeef up and refactor tests (DRY)
George Sakkis [Mon, 20 Apr 2015 22:46:51 +0000 (01:46 +0300)]
Beef up and refactor tests (DRY)

9 years agoFix threaded_cached_property_with_ttl.
George Sakkis [Sun, 19 Apr 2015 22:19:17 +0000 (01:19 +0300)]
Fix threaded_cached_property_with_ttl.

9 years agoFix the previous commit and add more test assertions to show why it was wrong.
George Sakkis [Mon, 20 Apr 2015 00:46:09 +0000 (03:46 +0300)]
Fix the previous commit and add more test assertions to show why it was wrong.

Although the previous commit correctly cached and returned only the first computed
value (since dict.setdefault() is atomic), the actual computation could be performed
more than once in multithreaded environment, with all but the first computed values
being discarded.

9 years agoMake cached_property thread-safe and alias threaded_cached_property to it.
George Sakkis [Sun, 19 Apr 2015 20:57:59 +0000 (23:57 +0300)]
Make cached_property thread-safe and alias threaded_cached_property to it.

dict.setdefault() is atomic since three years ago; see http://bugs.python.org/issue13521