buildroot.git
5 years agoconfigs/pc_x86_64_efi: use a GPT partition table
Carlos Santos [Sat, 29 Sep 2018 03:16:09 +0000 (00:16 -0300)]
configs/pc_x86_64_efi: use a GPT partition table

Since all EFI-based systems support GPT, this commit changes
pc_x86_64_efi to use a GPT partition table. It shows an example of how
to craft a disk image with GPT partitioning instead of MBR. This is
achieved by means of a post-image script which uses
mkdosfs+mcopy+sfdisk, since genimage is unable to deal with GPT. Long
term, it would be ideal if genimage had GPT support, but until then,
this script shows how to achieve creating a GPT-based disk image.

The script was kept as simple as possible to make it easy to understand
and adapt for other purposes.

The root filesystem location is passed to the kernel by a partition
UUID, so it is possible to boot on QEMU, directly from the disk image,
or dump the image to a physical device.

Signed-off-by: Carlos Santos <casantos@datacom.com.br>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pkg-cmake: <pkg>_SUBDIR cleanup
Lionel Orry [Thu, 11 Oct 2018 09:57:55 +0000 (11:57 +0200)]
package/pkg-cmake: <pkg>_SUBDIR cleanup

No functional change is brought by this modification.

This patch removes redundant <pkg>_SRCDIR declaration
  (already defined in pkg-generic.mk)

Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pkg-python: <pkg>_SUBDIR cleanup
Lionel Orry [Thu, 11 Oct 2018 09:57:54 +0000 (11:57 +0200)]
package/pkg-python: <pkg>_SUBDIR cleanup

No functional change is brought by this modification.

This patch:
* removes redundant <pkg>_SRCDIR and <pkg>_BUILDDIR declarations
  (already defined in pkg-generic.mk)
* documents the usage of <pkg>_SUBDIR in the python-specific section of
  the manual.

Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pkg-meson: <pkg>_SUBDIR cleanup
Lionel Orry [Thu, 11 Oct 2018 09:57:53 +0000 (11:57 +0200)]
package/pkg-meson: <pkg>_SUBDIR cleanup

No functional change is brought by this modification.

This patch:
* removes a redundant <pkg>_SRCDIR declaration (already defined in
  pkg-generic.mk)
* documents the usage of <pkg>_SUBDIR in the meson-specific section of
  the manual.

Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pkg-waf: add support for <pkg>_SUBDIR
Lionel Orry [Thu, 11 Oct 2018 09:57:52 +0000 (11:57 +0200)]
package/pkg-waf: add support for <pkg>_SUBDIR

In the Buildroot manual, it is specified that the Waf-based
infrastructure supports the <pkg>_SUBDIR variable, which was not true.

This patch:
* makes use of this variable by changing to the given sub-directory
  before executing waf commands,
* documents the usage of <pkg>_SUBDIR in the waf-specific section of
  the manual.

Signed-off-by: Lionel Orry <lionel.orry@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/python-pyzmq: enable draft APIs when supported by ZeroMQ
Lionel Flandrin [Tue, 5 Feb 2019 10:28:14 +0000 (11:28 +0100)]
package/python-pyzmq: enable draft APIs when supported by ZeroMQ

This doesn't introduce a new config flag, instead it just automatically enables
draft support if it's configured in the zeromq package itself.

Signed-off-by: Lionel Flandrin <lionel@svkt.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/zeromq: allow building with draft APIs enabled
Lionel Flandrin [Tue, 5 Feb 2019 10:28:13 +0000 (11:28 +0100)]
package/zeromq: allow building with draft APIs enabled

Signed-off-by: Lionel Flandrin <lionel@svkt.org>
[Thomas: add explicit --disable-drafts]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agosystem: allow selecting merged /usr along with custom rootfs skeleton
Carlos Santos [Mon, 7 May 2018 14:44:31 +0000 (11:44 -0300)]
system: allow selecting merged /usr along with custom rootfs skeleton

If the user is brave enough to use a custom rootfs skeleton then we must
not prevent using merged /usr too. Actually it is already possible to do
this, although indirectly, by selecting BR2_INIT_SYSTEMD.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agoMakefile: allow rootfs overlays to override symbolic links
Carlos Santos [Mon, 7 May 2018 14:44:30 +0000 (11:44 -0300)]
Makefile: allow rootfs overlays to override symbolic links

Since commit 0db34529f48 we use rsync with the --keep-dirlinks option to
prevent overlays from accidentally overwriding /{usr,bin,sbin,lib} links
when BR2_ROOTFS_MERGED_USR option is enabled. Unfortunately this also
prevents replacing a symlink by a directory on purpose (e.g. /var/log,
to persist system logs).

Steps to reproduce:

- enable BR2_ROOTFS_MERGED_USR and BR2_PACKAGE_SKELETON_INIT_SYSV
- mkdir some_path/rootfs-overlay/var/log
- enable BR2_ROOTFS_OVERLAY="some_path/rootfs-overlay"
- run 'make'
- 'target/var/log' is still a symlink to '../tmp', not a directory

The --keep-dirlinks option can be dropped, since we run sanity checks
on overlays. Now the rsync invocation is identical to the SYSTEM_RSYNC
logic we have in system/system.mk, so use that variable.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agoMakefile: check rootfs overlays with BR2_ROOTFS_MERGED_USR enabled
Carlos Santos [Mon, 7 May 2018 14:44:29 +0000 (11:44 -0300)]
Makefile: check rootfs overlays with BR2_ROOTFS_MERGED_USR enabled

Add a step to target-finalize that checks each rootfs overlay, following
the criteria established for custom skeletons and using the same script
uesd by skeleton-custom.mk.

Add a paragraph to the documentation clarifying that rootfs overlays
don't need to contain /bin, /lib or /sbin and must not contain them when
BR2_ROOTFS_MERGED_USR is enabled.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agoskeleton-custom: install /bin, /lib, and /sbin
Carlos Santos [Mon, 7 May 2018 14:44:28 +0000 (11:44 -0300)]
skeleton-custom: install /bin, /lib, and /sbin

skeleton-custom does not install the required /bin, /lib and /sbin
directories (or symlinks), which may result in an imcomplete tree, The
user could add the required directories/symlinks to the skeleton but
they may be invalid, depending on the state of BR2_ROOTFS_MERGED_USR.

Steps to reproduce:

- Enable BR2_ROOTFS_MERGED_USR and BR2_INIT_SYSTEMD
- Set BR2_ROOTFS_SKELETON_CUSTOM_PATH to "system/skeleton"
- Run "make skeleton"
- target/{bin.lib,sbin} will not exist

Add calls to SYSTEM_USR_SYMLINKS_OR_DIRS to INSTALL_TARGET_CMDS and
INSTALL_STAGING_CMDS, so the required directories or symlinks are
created.

Add a paragraph to the documentation clarifying that custom skeletons
don't need to contain /bin, /lib or /sbin and must not contain them when
BR2_ROOTFS_MERGED_USR is enabled.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agoskeleton-custom: use a script to check merged usr structure
Carlos Santos [Mon, 7 May 2018 14:44:27 +0000 (11:44 -0300)]
skeleton-custom: use a script to check merged usr structure

Introduce support/scripts/check-merged-usr.sh, a script that check if a
given path complies to the merged /usr requirements:

    /
    /bin -> usr/bin
    /lib -> usr/lib
    /sbin -> usr/sbin
    /usr/bin/
    /usr/lib/
    /usr/sbin/

Use this script in skeleton-custom.mk instead of a bunch of variables
filled by $(shell ...) macros. The same script will be used to check
rootfs overlays, in a forthcoming change.

Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agoboot/uboot: add support for bundling ATF BL31 in ELF format into U-Boot
Michał Łyszczek [Sun, 11 Nov 2018 21:39:42 +0000 (22:39 +0100)]
boot/uboot: add support for bundling ATF BL31 in ELF format into U-Boot

Rockchip's rk3328 encapsulates the BL31 part of ATP but it needs
image in ELF format. This is extension to
2c4809e6088660dc71de9de8cee0bba312aafbe4

This commit introduces a BR2_TARGET_UBOOT_NEEDS_ATF_BL31_ELF variable
to achieve this.

Signed-off-by: Michał Łyszczek <michal.lyszczek@bofc.pl>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agoboot/arm-trusted-firmware: add option to choose custom version
Michał Łyszczek [Wed, 6 Feb 2019 13:58:58 +0000 (14:58 +0100)]
boot/arm-trusted-firmware: add option to choose custom version

Allow user to choose specific, stable version from official ATF
repository

Signed-off-by: Michał Łyszczek <michal.lyszczek@bofc.pl>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/libv4l: remove qt support
Peter Korsgaard [Wed, 6 Feb 2019 15:11:16 +0000 (16:11 +0100)]
package/libv4l: remove qt support

Now that Qt4 is removed, the support in libv4l can be removed as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/gpsd: remove qt support
Peter Korsgaard [Wed, 6 Feb 2019 15:11:15 +0000 (16:11 +0100)]
package/gpsd: remove qt support

Now that Qt4 is removed, the support in gpsd can be removed as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agoutils/genrandconfig: drop qt4 fixups
Peter Korsgaard [Wed, 6 Feb 2019 15:11:14 +0000 (16:11 +0100)]
utils/genrandconfig: drop qt4 fixups

Now that Qt4 is removed, these fixups can be removed as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agocore/sdk: don't mangle symlinks with '.' or '..' at start
Joel Carlson [Sat, 22 Dec 2018 15:18:52 +0000 (16:18 +0100)]
core/sdk: don't mangle symlinks with '.' or '..' at start

The current transform changes any '.' at the start of a filename to
$(BR2_SDK_PREFIX). This also applies to the target of a symlink, when
it is relative.

We thus might end up with something like:
    $(BR2_SDK_PREFIX)/bin/aarch64-linux-gnu-ar ->
    $(BR2_SDK_PREFIX)./opt/ext-toolchain/bin/aarch64-linux-gnu-ar

when it should be:
    $(BR2_SDK_PREFIX)/bin/aarch64-linux-gnu-ar ->
    ../opt/ext-toolchain/bin/aarch64-linux-gnu-ar

We fix that by making sure we always remove a known prefix, i.e. we
remove the path to host dir. The obvious solution would be to cd into
$(HOST_DIR)/.. , then tar ./host/ and finally use a --transfrom pattern
as 's,^\./$(notdir $(HOST_DIR)),$(BR2_SDK_PREFIX)'.

Since $(HOST_DIR) can point to a user-supplied location, we don't know
very well how the pattern may patch.

Instead, we cd into / and tar the full path to $(HOST_DIR).

Since tar removes any leading '/', it would spurr a warning message,
which is annoying. So we explicitly remove the leading '/' from
$(HOST_DIR) when we tar it.

Finally, we transform all filenames to replace a leading $(HOST_DIR)
(without a leading /) to the prefix to use.

Signed-off-by: Joel Carlson <JoelsonCarl@gmail.com>
[yann.morin.1998@free.fr:
  - use a single transform pattern
  - use full HOST_DIR path as pattern to replace
  - update commit log accordingly
]
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/libb64: fix integer overflow and uninitialized C++ objects
Mikael Eliasson [Thu, 23 Aug 2018 14:04:46 +0000 (16:04 +0200)]
package/libb64: fix integer overflow and uninitialized C++ objects

Fixes a runtime bug on compilers where unsigned char is the default.
Fixes a runtime bug where _state variable in the encoder and decoder
c++ objects where not initialized by the constructors.

Signed-off-by: Mikael Eliasson <mikael@robomagi.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agosupport/scripts/pkg-stats: add latest upstream version information
Thomas Petazzoni [Tue, 5 Feb 2019 15:19:59 +0000 (16:19 +0100)]
support/scripts/pkg-stats: add latest upstream version information

This commit adds fetching the latest upstream version of each package
from release-monitoring.org.

The fetching process first tries to use the package mappings of the
"Buildroot" distribution [1]. This mapping mechanism allows to tell
release-monitoring.org what is the name of a package in a given
distribution/build-system. For example, the package xutil_util-macros
in Buildroot is named xorg-util-macros on release-monitoring.org. This
mapping can be seen in the section "Mappings" of
https://release-monitoring.org/project/15037/.

If there is no mapping, then it does a regular search, and within the
search results, looks for a package whose name matches the Buildroot
name.

Even though fetching from release-monitoring.org is a bit slow, using
multiprocessing.Pool has proven to not be reliable, with some requests
ending up with an exception. So we keep a serialized approach, but
with a single HTTPSConnectionPool() for all queries. Long term, we
hope to be able to use a database dump of release-monitoring.org
instead.

From an output point of view, the latest version column:

 - Is green when the version in Buildroot matches the latest upstream
   version

 - Is orange when the latest upstream version is unknown because the
   package was not found on release-monitoring.org

 - Is red when the version in Buildroot doesn't match the latest
   upstream version. Note that we are not doing anything smart here:
   we are just testing if the strings are equal or not.

 - The cell contains the link to the project on release-monitoring.org
   if found.

 - The cell indicates if the match was done using a distro mapping, or
   through a regular search.

[1] https://release-monitoring.org/distro/Buildroot/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Tested-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/dhcpcd: systemv and systemd services conflict with NetworkManager
Jim Brennan [Tue, 1 May 2018 00:02:45 +0000 (00:02 +0000)]
package/dhcpcd: systemv and systemd services conflict with NetworkManager

When NetworkManager and dhcpcd packages are both enabled, dhcpcd
services and NetworkManager both spawn dhcpcd. This causes the network
port to retrieve an IP address and later lose it a few seconds after
startup.

This patch prevents dhcpcd services from launching dhcpcd if
NetworkManager is enabled.

Signed-off-by: Jim Brennan <jbrennan@impinj.com>
[Thomas: add a comment in the code to explain the seemingly strange
condition.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/brcm-patchram-plus: new package
Vadim Kochan [Mon, 24 Dec 2018 17:28:47 +0000 (19:28 +0200)]
package/brcm-patchram-plus: new package

Add tool which allows to setup broadcom bluetooth
device via UART.

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[Thomas: add hash for license file.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/qt: remove package
Peter Korsgaard [Wed, 6 Feb 2019 14:10:58 +0000 (15:10 +0100)]
package/qt: remove package

Qt4 has been marked obsolete for close to 1 year, since commit 3538b5fb10
(qt: mark as obsolete) and is no longer supported upstream since December
2015:

https://blog.qt.io/blog/2015/05/26/qt-4-8-7-released/

So now finally remove it as the in tree users have been removed.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/qwt: remove qt4 support
Peter Korsgaard [Wed, 6 Feb 2019 14:10:57 +0000 (15:10 +0100)]
package/qwt: remove qt4 support

Qt4 support is about to be dropped, so remove the support from qwt as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/quazip: remove qt4 support
Peter Korsgaard [Wed, 6 Feb 2019 14:10:56 +0000 (15:10 +0100)]
package/quazip: remove qt4 support

Qt4 support is about to be dropped, so remove the support from quazip as
well.

Also add an explicit depends on for qt5 for consistency with other packages.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/qjson: remove qt4 support
Peter Korsgaard [Wed, 6 Feb 2019 14:10:55 +0000 (15:10 +0100)]
package/qjson: remove qt4 support

Qt4 support is about to be dropped, so remove the support from qjson as
well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
[Arnout: also remove redundant BR2_STATIC_LIBS dependency/comment]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/qextserialport: remove qt4 support
Peter Korsgaard [Wed, 6 Feb 2019 14:10:54 +0000 (15:10 +0100)]
package/qextserialport: remove qt4 support

Qt4 support is about to be dropped, so remove the support from
qextserialport as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/libmediaart: remove qt4 support
Peter Korsgaard [Wed, 6 Feb 2019 14:10:53 +0000 (15:10 +0100)]
package/libmediaart: remove qt4 support

Qt4 support is about to be dropped, so remove the support from libmediaart
as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/qtuio: remove package
Peter Korsgaard [Wed, 6 Feb 2019 14:10:52 +0000 (15:10 +0100)]
package/qtuio: remove package

The qtuio package uses the obsolete qt4 package, which we are about to
remove, so remove qtuio as well.

CC: Stephan Hoffmann <sho@relinux.de>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/pinentry: remove qt4 option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:51 +0000 (15:10 +0100)]
package/pinentry: remove qt4 option

The qt4 option uses the obsolete qt4 package, which we are about to remove,
so remove the pinentry-qt4 option as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/poppler: remove qt option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:50 +0000 (15:10 +0100)]
package/poppler: remove qt option

The qt option uses the obsolete qt4 package, which we are about to remove,
so remove the poppler qt option as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/opencv3: remove qt backend option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:49 +0000 (15:10 +0100)]
package/opencv3: remove qt backend option

The qt backend option uses the obsolete qt4 package, which we are about to
remove, so remove the qt backend option as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/opencv: remove qt backend option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:48 +0000 (15:10 +0100)]
package/opencv: remove qt backend option

The qt backend option uses the obsolete qt4 package, which we are about to
remove, so remove the qt backend option as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/amd-catalyst: remove control center option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:47 +0000 (15:10 +0100)]
package/amd-catalyst: remove control center option

The control center option uses the obsolete qt4 package, which we are about
to remove, so remote the cccle option as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/sdl: remove qtopia video driver option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:46 +0000 (15:10 +0100)]
package/sdl: remove qtopia video driver option

The qtopia option uses the obsolete qt4 package, which we are about to
remove, to remove the qtopia option as well.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
[Arnout: move the enable-qtopia=no option to the beginning]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/python-sip: remove qt4 support
Peter Korsgaard [Wed, 6 Feb 2019 14:10:45 +0000 (15:10 +0100)]
package/python-sip: remove qt4 support

python-pyqt has been removed and qt4 support is about to be dropped, so
remove the support from python-sip as well.

The comments and dependencies are not how we normally do things: the
dependency on Qt5 is obvious for a package which is essentially python
bindings for Qt5, and the other dependencies are implied by Qt5. So
remove all that and limit to a single dependency on Qt5.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
[Arnout: further simplify dependencies and comments]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/python-pyqt: remove package
Peter Korsgaard [Wed, 6 Feb 2019 14:10:44 +0000 (15:10 +0100)]
package/python-pyqt: remove package

The python-pyqt package uses the obsolete qt4 package, which we are about to
remove, so remove python-pyqt as well.

CC: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/gnuradio: remove qtgui option
Peter Korsgaard [Wed, 6 Feb 2019 14:10:43 +0000 (15:10 +0100)]
package/gnuradio: remove qtgui option

The gr-qtgui option uses python-pyqt/Qt4, which we are about to remove, so
remove the option.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/kodi: Add windowing support for Raspberry Pi & AMLogic
Bernd Kuhls [Sun, 1 Apr 2018 13:01:09 +0000 (15:01 +0200)]
package/kodi: Add windowing support for Raspberry Pi & AMLogic

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/kodi: Rework windowing support options
Bernd Kuhls [Sun, 1 Apr 2018 13:01:08 +0000 (15:01 +0200)]
package/kodi: Rework windowing support options

To prepare the bump to the next Kodi version 18.0-Leia we rework the
options to control the windowing platform Kodi is built for. An
automatic choice will no longer be suitable after addition of support
for wayland and gbm, the former also providing a choice to use either
OpenGL or OpenGL ES.

This patch introduces a new choice option by converting the current
X11-based OpenGL support to the new scheme. Other windowing platforms
will be added by subsequent patches.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/kodi: remove X11-based OpenGL ES support
Bernd Kuhls [Sun, 1 Apr 2018 13:01:07 +0000 (15:01 +0200)]
package/kodi: remove X11-based OpenGL ES support

To prepare the bump to the next Kodi version 18.0-Leia we remove the
current OpenGL ES support options. Kodi 18.0 will bring a major
overhaul of the supported windowing platforms, x11-based gles support
was removed, see upstream PR 12196.

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/meson: fix RPATH patch
Peter Seiderer [Fri, 4 Jan 2019 19:32:33 +0000 (20:32 +0100)]
package/meson: fix RPATH patch

The re-added ([1]) patch missed to remove two lines of the original
unconditional code.

[1] https://git.buildroot.net/buildroot/commit/?id=5c939246a802c0ad9704dac1505105037542a1d3

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/systemd: set vconsole support option to default y
David J. Fogle [Fri, 4 Jan 2019 18:16:59 +0000 (18:16 +0000)]
package/systemd: set vconsole support option to default y

Without support for vconsole, systemd will abruptly kill anything
spawned on the console, thus preventing users from loging in from
the console, effectively locking them out if the target does not
have another mean of logging in (no sshd, no serial line...)

We fix that by making support for vconsole default to y, since
logging in from the console if more frequent than not. Users can
still de-activate it when they know they don't need it.

Note that logging from a serial line is not impacted, and still
works whether vconsole is enabled or not.

Signed-off-by: David Fogle <david.j.fogle@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/wine: add gettext dependency for host-wine only with NLS enabled
Vadim Kochan [Sat, 5 Jan 2019 20:00:44 +0000 (22:00 +0200)]
package/wine: add gettext dependency for host-wine only with NLS enabled

Checked that host-wine compiles ok without host-gettext, so no needs
to specify this dependency.

libgettextpo is required by tools/wrc
(https://linux.die.net/man/1/wrc) which allows to convert windows
resources also to *.po format, which is not needed if NLS is disabled.

Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/googlefontdirectory: change to Google Fonts repo
Bartosz Bilas [Thu, 17 Jan 2019 21:14:22 +0000 (22:14 +0100)]
package/googlefontdirectory: change to Google Fonts repo

The current repository doesn't include new fonts, so this commit
changes the package to use the new official google github repository
which contains a lot of new available fonts.

The fonts are now organized in sub-folders per license, so we have to
take into this into account, and the
BR2_PACKAGE_GOOGLEFONTDIRECTORY_FONTS should now contain values such
as ufl/ubuntu or ofl/marvel.

Because the different fonts have different license files, we really
need to use each per-font license file, which explains why we have so
many hashes in the .hash file.

The list of licenses and license files is automatically derived from
the list of fonts in BR2_PACKAGE_GOOGLEFONTDIRECTORY_FONTS. Note that
a very small set of fonts (~15 among 1000+ fonts) lack a license file,
so if those fonts are used, legal-info will fail because the expected
license file doesn't exist. We consider this as a bug that should be
reported upstream, because each font should have a license file.

While we're at it, we use a foreach loop to install the fonts.

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/luarocks: refactor buildroot addon without patch
Francois Perrad [Sun, 20 Jan 2019 07:19:45 +0000 (08:19 +0100)]
package/luarocks: refactor buildroot addon without patch

addon commands are actually implemented in luarocks 3.0.4,
and they must be located in luarocks/cmd/external.

so, it is useless to patch luarocks.

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/rcw: new package
Paresh Chaudhary [Wed, 16 Jan 2019 12:39:52 +0000 (06:39 -0600)]
package/rcw: new package

This package adds NXP Layerscape and QoriQ reset config word
(RCW) / pre-bootloader (PBL) generation support.

The RCW is used to setup clocking and IO allocations and then launches
the next stage of boot (usually u-boot).

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/postgresql: change systemd service type to notify
Joseph Kogut [Mon, 4 Feb 2019 18:53:40 +0000 (19:53 +0100)]
package/postgresql: change systemd service type to notify

During activation, pg_ctl uses exec to start the db server, which causes
the service to never finish activating when Type=forking. Upstream
recommends configuring --with-systemd and using Type=notify.

https://www.postgresql.org/docs/10/static/server-start.html

Upstream says:
    When using systemd, you can use the following service unit file
    [...]
    Using Type=notify requires that the server binary was built with
    configure --with-systemd.

Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/openocd: allow CMSIS-DAP support
Matt Wood [Mon, 7 Jan 2019 17:12:19 +0000 (12:12 -0500)]
package/openocd: allow CMSIS-DAP support

In commit aa441aa84c38ad5319c4ff7fb27c84530e19c204 ("openocd: bump to
version 0.8.0"), some logic in openocd.mk was added to enable
CMSIS-DAP when BR2_PACKAGE_OPENOCD_CMSIS_DAP is enabled, but this
option was not created, because hidapi was not packaged in
Buildroot. This package now exists, so we can create
BR2_PACKAGE_OPENOCD_CMSIS_DAP and really make it possible to build
CMSIS DAP support.

Signed-off-by: Matt Wood <mattwood2000@gmail.com>
[Thomas:
 - rework commit log
 - add missing "depends on" in Config.in]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years ago.gitlab-ci.yml: use "extends" keyword
Ricardo Martincoski [Mon, 21 Jan 2019 01:11:11 +0000 (23:11 -0200)]
.gitlab-ci.yml: use "extends" keyword

Replace all YAML anchors with the new "extends" keyword because it is
more readable and more flexible (it works across configuration files
combined with the new "include" keyword).

Readability is more meaningful in .gitlab-ci.yml.in.
In the part of .gitlab-ci.yml that is auto-generated by 'make
.gitlab-ci.yml' keep the keyword in the same line of the job name.
So instead of this:
 zynqmp_zcu106_defconfig:
     extends: .defconfig
 tests.boot.test_atf.TestATFAllwinner:
     extends: .runtime_test
Use this:
 zynqmp_zcu106_defconfig: { extends: .defconfig }
 tests.boot.test_atf.TestATFAllwinner: { extends: .runtime_test }
Do this to to keep .gitlab-ci.yml easier to be post-processed by a
script.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/gst1-shark: new package
Chris Packham [Fri, 25 Jan 2019 09:13:22 +0000 (22:13 +1300)]
package/gst1-shark: new package

GstShark leverages GStreamers newest instrumentation subsystem by
installing a set of custom hooks to the trace points. A variety of
data analytics are extracted and presented to the user in a graphical,
friendly way.

https://developer.ridgerun.com/wiki/index.php?title=GstShark
https://github.com/RidgeRun/gst-shark

Signed-off-by: Chris Packham <judge.packham@gmail.com>
Cc: Wolfgang Grandegger <wg@grandegger.com>
Cc: João Victor Oliveira <jv.oliveirag@gmail.com>
Cc: Adam Duskett <aduskett@gmail.com>
Cc: Igor Miranda <igorcmiranda3110@gmail.com>
[Thomas:
 - fix package prompt to be gtk1-shark in Config.in
 - license is LGPL-2.1+, not LGPL-2.1
 - add entry to DEVELOPERS file]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agotesting/tests/download: test git special ref
Ricardo Martincoski [Sat, 12 May 2018 02:58:32 +0000 (23:58 -0300)]
testing/tests/download: test git special ref

Add a special ref to the static repo and check on the git refs test case
the download of a git package:
 - with the sha1 of a special ref as version;

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Cc: Arnout Vandecappelle <arnout@mind.be>
[Arnout: change to use the sha1 of a special ref instead of the name]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/gerbera: new package
Fabrice Fontaine [Sun, 20 May 2018 08:28:53 +0000 (10:28 +0200)]
package/gerbera: new package

A free media server.
Stream your media to devices on your home network.

https://gerbera.io

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
[Thomas:
 - fix S99gerbera to be compliant with the init script pattern
   that was recently put in place
 - add -l option in init script for logging
 - license code is GPL-2.0]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agotesting/tests/download: test git tag
Ricardo Martincoski [Sat, 12 May 2018 02:58:31 +0000 (23:58 -0300)]
testing/tests/download: test git tag

Add a tag to the static repo and check on the git refs test case the
download of a git package:
 - with the name of a tag as version;
 - with the sha1 of a tag itself as version;
 - with the partial sha1 of a tag itself as version;
 - with the sha1 of a commit pointed by a tag as version;
 - with the partial sha1 of a commit pointed by a tag as version;
 - with the sha1 of a commit reachable only by a tag as version;
 - with the partial sha1 of a commit reachable only by a tag as version.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Cc: Arnout Vandecappelle <arnout@mind.be>
Tested-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agotesting/download: GIT use BRConfigTest
Matt Weber [Wed, 6 Feb 2019 03:25:30 +0000 (21:25 -0600)]
testing/download: GIT use BRConfigTest

Enables the test to use the new non-emulator base class which takes
significantly less test time.

Cc: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agotesting/infra: Add BRConfigTest as superclass of BRTest
Ricardo Martincoski [Wed, 6 Feb 2019 03:25:29 +0000 (21:25 -0600)]
testing/infra: Add BRConfigTest as superclass of BRTest

The git tests don't need to do a full build, they only need to do a
configure and download and/or legal-info. More tests of that type will
be added in the future. Therefore, we want to have a test base class
that doesn't automatically do a full build in the setUp().

Add this new class as a superclass of the existing BRTest class, so we
don't need to update existing tests. Only the code in run-tests that
iterates over all subclasses of BRTest has to be adapted to use
BRConfigTest instead.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agopackage/luacrypto: remove package
Peter Korsgaard [Tue, 5 Feb 2019 20:03:09 +0000 (21:03 +0100)]
package/luacrypto: remove package

Fixes:
http://autobuild.buildroot.net/results/afd/afdc598b80356a8301d890232466de421f7779d5/

Luacrypto fails to build with openssl 1.1.x.  The package has not seen any
functional changes since it was added in 2013 and has no reverse
dependencies.

The upstream repository (https://github.com/starius/luacrypto) explicitly
states:

this project is deprecated, use luaossl

So remove the package.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/fftw: remove as regular package
Thomas Petazzoni [Mon, 21 Jan 2019 13:51:10 +0000 (14:51 +0100)]
package/fftw: remove as regular package

fftw is no longer a package: only fftw-single, fftw-double,
fftw-long-double and fftw-quad are. fftw.mk only contains some common
definitions that are used by the different fftw variants.

The old BR2_PACKAGE_FFTW_PRECISION_* options, which are no longer used
anywhere, are moved to Config.in.legacy.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/liquid-dsp: use the new fftw-single package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:09 +0000 (14:51 +0100)]
package/liquid-dsp: use the new fftw-single package

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pulseaudio: use the new fftw-single package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:08 +0000 (14:51 +0100)]
package/pulseaudio: use the new fftw-single package

This patch add an explicitly dependency to fftw-single (the only compatible
fftw's flavor) instead of default behavior where the package do assumption
about the compatible version.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/libvips: use the new fftw-double package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:07 +0000 (14:51 +0100)]
package/libvips: use the new fftw-double package

This patch add an explicitly dependency to fftw-double (the only compatible
fftw's flavor) instead of default behavior where the package do assumption
about the compatible version.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/imagemagick: use the new fftw-double package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:06 +0000 (14:51 +0100)]
package/imagemagick: use the new fftw-double package

This patch add an explicitly dependency to fftw-double (the only compatible
fftw's flavor) instead of default behavior where the package do assumption
about the compatible version.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/httping: use the new fftw-double package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:05 +0000 (14:51 +0100)]
package/httping: use the new fftw-double package

This patch add an explicitly dependency to fftw-double (the only compatible
fftw's flavor) instead of default behavior where the package do assumption
about the compatible version.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/hackrf: use the new fftw-single package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:04 +0000 (14:51 +0100)]
package/hackrf: use the new fftw-single package

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/gqrx: remove unneeded fftw dependency
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:03 +0000 (14:51 +0100)]
package/gqrx: remove unneeded fftw dependency

Thanks to the new fftw package organization, gnuradio already selects
the appropriate fftw precision, and there is no need to propagate the
"depends on BR2_PACKAGE_FFTW_PRECISION_SINGLE" that used to be present
in the gnuradio package.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
[Thomas: reorder "depends on" as suggested by Yann]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/gnuradio: use the new fftw-single package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:02 +0000 (14:51 +0100)]
package/gnuradio: use the new fftw-single package

Thanks to the new fftw package organization, we can use a "select"
instead of "depends on".

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/aubio: use the new fftw-double and fftw-single packages
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:01 +0000 (14:51 +0100)]
package/aubio: use the new fftw-double and fftw-single packages

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
[Thomas: drop the condition on BR2_PACKAGE_FFTW]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/alsa-utils: use the new fftw-single package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:51:00 +0000 (14:51 +0100)]
package/alsa-utils: use the new fftw-single package

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/fftw: break fftw-double into a dedicated package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:50:59 +0000 (14:50 +0100)]
package/fftw: break fftw-double into a dedicated package

fftw's library name depends on the precision option. Consequently,
it's possible to install multiple flavor on the same target.

This patch breaks fftw double precision into a new package and:

- makes BR2_PACKAGE_FFTW_PRECISION_DOUBLE select BR2_PACKAGE_FFTW_DOUBLE
  to keep compatibility with packages that use
  BR2_PACKAGE_FFTW_PRECISION_DOUBLE. This option will be removed in a
  follow-up commit;
- removes BR2_PACKAGE_FFTW_USE_SSE2 since it is only used for single
  and double precision. The corresponding options are directly handled in
  fftw-double package;
- makes fftw depend on fftw-double when this package is enabled;
- turns fftw itself into a generic-package instead of an
  autotools-package: it no longer builds anything and only allows to
  trigger the build of the appropriate fftw-* sub-packages, as a
  temporary compatibility mechanism.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
[Yann/Thomas:
 - Use FFTW_DOUBLE_DL_SUBDIR to avoid downloading fftw multiple times
 - Minor reformatting tweaks in fftw-double.mk
 - Drop from fftw.mk FFTW_CONF_ENV/FFTW_CONF_OPTS which are no
   longer used
 - Make fftw a generic package so that its dependencies are built
 - Do not deprecate BR2_PACKAGE_FFTW_PRECISION_DOUBLE and instead
   make it select BR2_PACKAGE_FFTW_DOUBLE, so that packages using
   BR2_PACKAGE_FFTW_PRECISION_QUAD continue to work.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/fftw: break fftw-quad into a dedicated package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:50:58 +0000 (14:50 +0100)]
package/fftw: break fftw-quad into a dedicated package

fftw's library name depends on the precision option. Consequently,
it's possible to install multiple flavor on the same target.

This patch breaks fftw quad precision into a new package and:

- makes BR2_PACKAGE_FFTW_PRECISION_QUAD select BR2_PACKAGE_FFTW_QUAD
  to keep compatibility with packages that use
  BR2_PACKAGE_FFTW_PRECISION_QUAD. This option will be removed in a
  follow-up commit;

- makes fftw depend on fftw-quad when this package is enabled.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
[Yann/Thomas:
 - Force --disable-quad in FFTW_CONF_OPTS, just for the sake of
   clarity (fftw is no longer going to build the quad variant)
 - Use FFTW_QUAD_DL_SUBDIR to avoid downloading fftw multiple times
 - Minor reformatting tweaks in fftw-quad.mk
 - Do not deprecate BR2_PACKAGE_FFTW_PRECISION_QUAD and instead
   make it select BR2_PACKAGE_FFTW_QUAD, so that packages using
   BR2_PACKAGE_FFTW_PRECISION_QUAD continue to work.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
[Gwenhael/Yann]:
 - (BR2_i386 || BR2_x86_64) -> BR2_TOOLCHAIN_HAS_LIBQUADMATH
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/fftw: break fftw-long-double into a dedicated package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:50:57 +0000 (14:50 +0100)]
package/fftw: break fftw-long-double into a dedicated package

fftw's library name depends on the precision option. Consequently,
it's possible to install multiple flavor on the same target.

This patch breaks fftw long double precision into a new package and:

- makes BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE select
  BR2_PACKAGE_FFTW_LONG_DOUBLE to keep compatibility with packages
  that use BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE. This option will be
  removed in a follow-up commit;

- makes fftw depend on fftw-long-double when this package is enabled.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
[Yann/Thomas:
 - Force --disable-long-double in FFTW_CONF_OPTS, just for the sake of
   clarity (fftw is no longer going to build the long double variant)
 - Use FFTW_LONG_DOUBLE_DL_SUBDIR to avoid downloading fftw multiple times
 - Minor reformatting tweaks in fftw-long-double.mk
 - Do not deprecate BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE and instead
   make it select BR2_PACKAGE_FFTW_LONG_DOUBLE, so that packages using
   BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE continue to work.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/fftw: break fftw-single into a dedicated package
Gwenhael Goavec-Merou [Mon, 21 Jan 2019 13:50:56 +0000 (14:50 +0100)]
package/fftw: break fftw-single into a dedicated package

fftw's library name depends on the precision option. Consequently,
it's possible to install multiple flavor on the same target.

This patch breaks fftw single precision into a new package and:

- makes BR2_PACKAGE_FFTW_PRECISION_SINGLE select
  BR2_PACKAGE_FFTW_SINGLE to keep compatibility with packages that use
  BR2_PACKAGE_FFTW_PRECISION_SINGLE. This option will be removed in a
  follow-up commit;

- removes the BR2_PACKAGE_FFTW_USE_SSE and BR2_PACKAGE_FFTW_USE_NEON
  otpions since they are only used for single precision. The
  corresponding CPU-capability options are directly handled in
  the fftw-single package;

- makes fftw depend on fftw-single when this package is enabled.

Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
[Yann/Thomas:
 - Force --disable-single in FFTW_CONF_OPTS, just for the sake of
   clarity (fftw is no longer going to build the single variant)
 - Use FFTW_SINGLE_DL_SUBDIR to avoid downloading fftw multiple times
 - Minor reformatting tweaks in fftw-single.mk
 - Do not deprecate BR2_PACKAGE_FFTW_PRECISION_SINGLE and instead make
   it select BR2_PACKAGE_FFTW_SINGLE, so that packages using
   BR2_PACKAGE_FFTW_PRECISION_SINGLE continue to work.]
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/fftw: prepare for splitting into multiple packages
Thomas Petazzoni [Mon, 21 Jan 2019 13:50:55 +0000 (14:50 +0100)]
package/fftw: prepare for splitting into multiple packages

In preparation for splitting into multiple packages, this commit
changes the fftw.mk package to use FFTW_COMMON_CONF_OPTS,
FFTW_COMMON_CONF_ENV and FFTW_COMMON_CFLAGS, which will be re-used by
the soon-to-be-introduced per-precision packages.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agotesting/tests/download: test git submodules
Ricardo Martincoski [Sat, 12 May 2018 02:58:30 +0000 (23:58 -0300)]
testing/tests/download: test git submodules

Add two submodules as static repos, add a branch to the main static repo
and check on the git refs test case the download of a git package:
 - repo with submodule but without support in the package;
 - repo with recursive submodules with support in the package.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Cc: Arnout Vandecappelle <arnout@mind.be>
[Arnout: remove handling of inconsistent tarball hashes - that's an
 actual bug that should be fixed]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
5 years agosupport/testing: add docker / docker-compose tests
Peter Korsgaard [Mon, 4 Feb 2019 16:55:57 +0000 (17:55 +0100)]
support/testing: add docker / docker-compose tests

Build for x86-64 as public containers in general are only available for
x86-64.  Docker needs a number of kernel options enabled, so use a custom
kernel config based on the qemu one.

Docker needs entropy at startup, so enable the virtio-rng-pci device to
expose entropy to the guest.  The default RAM amount (128M) is not enough to
run docker / docker-compose, so bump to 512MB.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopython-dateutil: bump to version 2.8.0
Asaf Kahlon [Tue, 5 Feb 2019 20:31:38 +0000 (22:31 +0200)]
python-dateutil: bump to version 2.8.0

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/liquid-dsp: drop support for fftw-double and fftw-long-double
Thomas Petazzoni [Mon, 21 Jan 2019 13:51:11 +0000 (14:51 +0100)]
package/liquid-dsp: drop support for fftw-double and fftw-long-double

liquid-dsp has the following code:

So, if it uses the external fftw library, it can only use the fftwf
variant, i.e the fftw-single variant. Otherwise, it uses its internal
FFT library.

There is no way for liquid-dsp to use fftw-double or fftw-long-double.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Gwenhael Goavec-Merou <gwenhael.goavec-merou@trabucayre.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pugixml: force-enable 'long long' support to support gcc<4.8
Thomas De Schampheleire [Tue, 5 Feb 2019 14:28:26 +0000 (15:28 +0100)]
package/pugixml: force-enable 'long long' support to support gcc<4.8

Although pugixml will enable 'long long' support automatically if it detects
C++11 (gcc 4.8+), we would like to support older gcc compilers too.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agosupport/download/scp: fix download with scheme prefix 'scp://'
Thomas De Schampheleire [Mon, 4 Feb 2019 18:05:46 +0000 (19:05 +0100)]
support/download/scp: fix download with scheme prefix 'scp://'

The scp download helper is broken when the server URL starts with 'scp://'.
Such prefix is used in two situations:
1. to let FOO_SITE point to an scp location without explicitly having to set
   'FOO_SITE_METHOD = scp'

2. when BR2_PRIMARY_SITE or BR2_BACKUP_SITE points to an scp location. In
   this case, there is no equivalent of 'SITE_METHOD'.

Strip out the scheme prefix, similarly to how the 'file' download helper
does it. That helper has the same cases as above.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/tn5250: remove package
Peter Korsgaard [Tue, 5 Feb 2019 19:01:09 +0000 (20:01 +0100)]
package/tn5250: remove package

The latest (0.17.4) tn5250 release is from 2008, doesn't build with openssl
1.1.x and was dropped from Debian in 2011 because nobody cared to maintain
it:

https://packages.qa.debian.org/t/tn5250.html

Given all of that, it is unlikely to be used much, so remove it.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/dovecot: security bump to version 2.3.4.1
Peter Korsgaard [Tue, 5 Feb 2019 16:57:10 +0000 (17:57 +0100)]
package/dovecot: security bump to version 2.3.4.1

Fixes the following security issues:

 * CVE-2019-3814: If imap/pop3/managesieve/submission client has
   trusted certificate with missing username field
   (ssl_cert_username_field), under some configurations Dovecot
   mistakenly trusts the username provided via authentication instead
   of failing.

 * ssl_cert_username_field setting was ignored with external SMTP AUTH,
   because none of the MTAs (Postfix, Exim) currently send the
   cert_username field. This may have allowed users with trusted
   certificate to specify any username in the authentication. This bug
   didn't affect Dovecot's Submission service.

For more details, see the announcement:
https://www.dovecot.org/list/dovecot-news/2019-February/000394.html

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agoutils/check-package: warn about overridden variables
Ricardo Martincoski [Sun, 27 Jan 2019 18:59:43 +0000 (16:59 -0200)]
utils/check-package: warn about overridden variables

For the general case, appending values to variables is OK and also a
good practice, like this:
|PACKAGE_VAR = value1
|ifeq ...
|PACKAGE_VAR += value2

or this, when the above is not possible:
|PACKAGE_VAR = value1
|ifeq ...
|PACKAGE_VAR := $(PACKAGE_VAR), value2

But this override is an error:
|PACKAGE_VAR = value1
|PACKAGE_VAR = value2

as well this one:
|ifeq ...
|PACKAGE_VAR += value1
|endif
|PACKAGE_VAR = value2

And this override is error-prone:
|PACKAGE_VAR = value1
|ifeq ...
|PACKAGE_VAR = value2

Create a check function to warn about overridden variables.

Some variables are likely to have a default value that gets overridden
in a conditional, so ignore them. The name of such variables end in
_ARCH, _CPU, _SITE, _SOURCE or _VERSION.

After ignoring these variable names, there are a few exceptions to this
rule in the tree. For them use the comment that disables the check.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Simon Dawson <spdawson@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Tested-by: Titouan Christophe <titouan.christophe@railnova.eu>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/zbar: bump to version 57d601e82089f2f31de9e1683c3834f237421f5d
Fabrice Fontaine [Mon, 4 Feb 2019 19:00:15 +0000 (20:00 +0100)]
package/zbar: bump to version 57d601e82089f2f31de9e1683c3834f237421f5d

When building statically zbar, build fails on:
configure: error: unable to find libv4l.so

The following errors are raised in config.log:
configure:19371:
/home/buildroot/buildroot-test/instance-0/output/host/bin/arm-linux-gcc -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -O2 -g2  -static -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64  -static conftest.c -lv4l2 -lpthread  >&5
/home/buildroot/buildroot-test/instance-0/output/host/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/lib/libv4l2.a(libv4l2_la-libv4l2.o): In function `v4l2_set_src_and_dest_format':
/home/buildroot/buildroot-test/instance-0/output/build/libv4l-1.16.2/lib/libv4l2/libv4l2.c:952: undefined reference to `v4lconvert_supported_dst_format'

To fix this error, bump to version
57d601e82089f2f31de9e1683c3834f237421f5d to replace AC_CHECK_LIB by
PKG_CHECK_MODULES to find the correct library (-lv4lconvert but also
-ljpeg, ...)

Fixes:
 - http://autobuild.buildroot.org/results/acf39e4754508d7ee49e21f08ff0a1fcac4fb7cd

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
5 years agopackage/pound: Fix build with OpenSSL 1.1.x
Bernd Kuhls [Tue, 5 Feb 2019 17:07:36 +0000 (11:07 -0600)]
package/pound: Fix build with OpenSSL 1.1.x

The patches enable two new API configurations, one for OpenSSL 1.1.x
and the other LibreSSL.

A dependency is added to use the Buildroot host tool openssl to
create headers (dh512.h).  This resolves a host OS mismatch with
openssl versions. (The Makefile does this generation as part of
the initial build)

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agosupport/testing: test_dropbear.py: drop ssh port forward to the host
Peter Korsgaard [Tue, 5 Feb 2019 09:45:42 +0000 (10:45 +0100)]
support/testing: test_dropbear.py: drop ssh port forward to the host

It is not used and may conflict with other services running on port 2222 on
the host machine.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agosupport/testing: test_dropbear.py: add test for ssh connection to localhost
Peter Korsgaard [Tue, 5 Feb 2019 09:45:41 +0000 (10:45 +0100)]
support/testing: test_dropbear.py: add test for ssh connection to localhost

Use sshpass to pass the password on the command line.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agosupport/testing: test_dropbear.py: use a constant for the password
Peter Korsgaard [Tue, 5 Feb 2019 09:45:40 +0000 (10:45 +0100)]
support/testing: test_dropbear.py: use a constant for the password

The password is used in multiple places, so add a constant for it instead of
hardcoding it multiple times.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/ipmitool: add openssl 1.1.x compatibility
Matt Weber [Tue, 5 Feb 2019 14:37:09 +0000 (08:37 -0600)]
package/ipmitool: add openssl 1.1.x compatibility

Changes adapt the current codebase to use supported APIs now that openssl
1.1.x by default disables all deprecated items.

Fixes
http://autobuild.buildroot.net/results/97d/97dab568f1f3d342b6bfcb9f597ced4de6f1309e

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agolinux: bump Linux CIP to version v4.4.171-cip30
Angelo Compagnucci [Tue, 5 Feb 2019 16:12:01 +0000 (17:12 +0100)]
linux: bump Linux CIP to version v4.4.171-cip30

This patch bumps the Linux CIP version to v4.4.171-cip30 and updates the
download url to the new official one.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/ibrdtnd: include cstring
Matt Weber [Tue, 5 Feb 2019 14:07:32 +0000 (08:07 -0600)]
package/ibrdtnd: include cstring

Failure output
 SecurityCertificateManager.lo
 SecurityCertificateManager.cpp: In static member function 'static void dtn::security::SecurityCertificateManager::validateSubject(X509*, const string&)':
 SecurityCertificateManager.cpp:208:53: error: 'memcmp' was not declared in this scope
        if(memcmp(utf8_eid, utf8_cert_name, utf8_eid_len) == 0){

Upstream
https://github.com/ibrdtn/ibrdtn/commit/122fa8ed49f896abf6a389505f3d0b66d49d1e77

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/ibrdtnd: add openssl 1.1.x compatibility
Matt Weber [Tue, 5 Feb 2019 14:07:31 +0000 (08:07 -0600)]
package/ibrdtnd: add openssl 1.1.x compatibility

Upstream
https://github.com/ibrdtn/ibrdtn/pull/265

Fixes
http://autobuild.buildroot.net/results/385/3852a414afacbe3c044b1e49be8ccf8c554c8565

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/softether: bump to v4.28-9669-beta
Matt Weber [Tue, 5 Feb 2019 11:47:52 +0000 (05:47 -0600)]
package/softether: bump to v4.28-9669-beta

Source code is now compatible with OpenSSL 1.1.x.

Fixes
http://autobuild.buildroot.net/results/a6f/a6f1f326ce2525ee0f9d423f1b6d989a89e6b87e/build-end.log

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/tpm2-tss: bump version to 2.1.1
Peter Korsgaard [Tue, 5 Feb 2019 11:55:53 +0000 (12:55 +0100)]
package/tpm2-tss: bump version to 2.1.1

Fixes a number of issues since 2.1.0:
https://github.com/tpm2-software/tpm2-tss/releases/tag/2.1.1

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/mender: fixing init script naming
Angelo Compagnucci [Tue, 5 Feb 2019 14:16:41 +0000 (15:16 +0100)]
package/mender: fixing init script naming

Commit f88947c2fe2d (package/mender: adding systemv init file) added an init
script, but the installation logic referred to S04mender instead of S42mender.

Update the installation logic to match the file name.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
[Peter: expand commit message description]
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/moarvm: resolve libtommath name collision
Matt Weber [Tue, 5 Feb 2019 13:17:51 +0000 (07:17 -0600)]
package/moarvm: resolve libtommath name collision

Fixes
http://autobuild.buildroot.net/results/02f/02ff68698603ebdce5d13d3130a15b5a1ecc14d2/build-end.log

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agoMakefile: unexport 'PLATFORM' and 'OS' environment variables
Thomas De Schampheleire [Tue, 5 Feb 2019 11:03:42 +0000 (12:03 +0100)]
Makefile: unexport 'PLATFORM' and 'OS' environment variables

Some package builds may fail when environment variables are present with the
same names as make variables in a package. This is a bigger problem for
environment variables with generic names, like 'PLATFORM' and 'OS'.

'PLATFORM' is for example a problem for host-acl.

Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/qpid-proton: openssl 1.1.x compatibility
Matt Weber [Tue, 5 Feb 2019 12:38:54 +0000 (06:38 -0600)]
package/qpid-proton: openssl 1.1.x compatibility

Updates are based on the original bug report upstream.
https://issues.apache.org/jira/browse/PROTON-1326

Fixes
http://autobuild.buildroot.net/results/f90/f9085f223cd54c70daf29b12e6c66edb416f7243/

Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/mender: adding a readme file
Angelo Compagnucci [Tue, 5 Feb 2019 10:49:59 +0000 (11:49 +0100)]
package/mender: adding a readme file

This patch adds a readme file with basic instructions to get mender up
and running on a production system.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Acked-by: <aduskett@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/mender: adding device_type file
Angelo Compagnucci [Tue, 5 Feb 2019 10:49:58 +0000 (11:49 +0100)]
package/mender: adding device_type file

In order to have the mender package working out of the box, the
/etc/mender/device_type should be present and should contain a
valid device_type value.
This patch provides a default file that can be overridden easily
from an overlay.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Acked-by: <aduskett@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
5 years agopackage/mender: adding artifact_info file
Angelo Compagnucci [Tue, 5 Feb 2019 10:49:57 +0000 (11:49 +0100)]
package/mender: adding artifact_info file

In order to have the mender package working out of the box, the
/etc/mender/artifact_info should be present and should contain a
valid artifact_name value.
This patch provides a default file that can be overridden easily
from an overlay.

Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
Acked-by: <aduskett@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>