gcc.git
5 years agoDefine C11 macros such as FLT_DECIMAL_DIG for C++17
Jonathan Wakely [Mon, 24 Jun 2019 12:09:47 +0000 (13:09 +0100)]
Define C11 macros such as FLT_DECIMAL_DIG for C++17

* testsuite/18_support/headers/cfloat/values_c++17.cc: New test.

From-SVN: r272615

5 years agoDaily bump.
GCC Administrator [Mon, 24 Jun 2019 00:16:17 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r272613

5 years agocompiler: edit error messages to avoid -Wformat-diag warnings
Ian Lance Taylor [Sun, 23 Jun 2019 22:10:19 +0000 (22:10 +0000)]
compiler: edit error messages to avoid -Wformat-diag warnings

    GCC recently introduced -Wformat-diag to scrutinize GCC error messages.
    It reports a number of warnings about gofrontend code, such as:

    ../../trunk/gcc/go/gofrontend/import.cc: In member function ‘Type* Import::type_for_index(int, const string&, size_t, bool*)’:
    ../../trunk/gcc/go/gofrontend/import.cc:1129:48: warning: unquoted operator ‘>=’ in format [-Wformat-diag]
     1129 |         "error in %s at %lu: bad type index %d >= %d",
          |                                                ^~

    ../../trunk/gcc/go/gofrontend/ast-dump.cc: In member function ‘void Ast_dump_context::dump(Gogo*, const char*)’:
    ../../trunk/gcc/go/gofrontend/ast-dump.cc:203:25: warning: unquoted option name ‘-fgo-dump-ast’ in format [-Wformat-diag]
      203 |     "cannot open %s:%m, -fgo-dump-ast ignored", dumpname.c_str());
          |                         ^~~~~~~~~~~~~

    ../../trunk/gcc/go/gofrontend/expressions.cc: In static member function ‘static Bexpression* Func_expression::get_code_pointer(Gogo*, Named_object*, Location)’:
    ../../trunk/gcc/go/gofrontend/expressions.cc:1350:29: warning: misspelled term ‘builtin function’ in format; use ‘built-in function’ instead [-Wformat-diag]
     1350 |     "invalid use of special builtin function %qs; must be called",
          |                             ^~~~~~~~~~~~~~~~

    ../../trunk/gcc/go/gofrontend/gogo.cc: In member function ‘void Gogo::add_linkname(const string&, bool, const string&, Location)’:
    ../../trunk/gcc/go/gofrontend/gogo.cc:2527:4: warning: unquoted sequence of 2 consecutive punctuation characters ‘//’ in format [-Wformat-diag]
     2527 |   ("%s is not a function; "
          |   ~^~~~~~~~~~~~~~~~~~~~~~~~
     2528 |    "//go:linkname is only supported for functions"),
          |    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    This CL edits error messages to avoid these warnings.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/183497

* go.test/test/blank1.go: Update for diagnostic message changes.

From-SVN: r272608

5 years agocompiler: add go_debug and use it for debug messages
Ian Lance Taylor [Sun, 23 Jun 2019 22:04:53 +0000 (22:04 +0000)]
compiler: add go_debug and use it for debug messages

    GCC recently added a new warning -Wformat-diag which does a lot of
    rigorous checks on GCC diagnostic messages.  This produces a number of
    unnecessary diagnostics on gofrontend diagnostic output, such as

    ../../trunk/gcc/go/gofrontend/escape.cc: In member function ‘virtual int Escape_analysis_assign::statement(Block*, size_t*, Statement*)’:
    ../../trunk/gcc/go/gofrontend/escape.cc:1336:33: warning: spurious leading punctuation sequence ‘[’ in format [-Wformat-diag]
     1336 |       go_inform(s->location(), "[%d] %s esc: %s",
          |                                 ^

    ../../trunk/gcc/go/gofrontend/escape.cc: In member function ‘void Escape_analysis_assign::call(Call_expression*)’:
    ../../trunk/gcc/go/gofrontend/escape.cc:1964:17: warning: unquoted operator ‘::’ in format [-Wformat-diag]
     1964 |         "esccall:: indirect call <- %s, untracked",
          |                 ^~

    ../../trunk/gcc/go/gofrontend/escape.cc:1964:34: warning: unbalanced punctuation character ‘<’ in format [-Wformat-diag]
     1964 |         "esccall:: indirect call <- %s, untracked",
          |                                  ^

    Avoid these messages by adding a new function go_debug that uses only
    printf formatting, not GCC diagnostic formatting, and change all the
    optimization debugging messages to use it.  None of the debugging
    messages used the GCC diagnostic formatting specifiers anyhow.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/183437

From-SVN: r272607

5 years ago[Darwin, PPC, testsuite] Fix builtins-2 for Darwin.
Iain Sandoe [Sun, 23 Jun 2019 20:29:09 +0000 (20:29 +0000)]
[Darwin, PPC, testsuite] Fix builtins-2 for Darwin.

This cannot pass for current Darwin, since it requires VSX and we
don't have any hardware supporting that.  Add a dg-requires clause
for this.

2019-06-23  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/builtins-2.c: Require VSX hardware support.

From-SVN: r272606

5 years ago[Darwin, PPC, testsuite] Fix pr80125 testcase for Darwin.
Iain Sandoe [Sun, 23 Jun 2019 20:12:22 +0000 (20:12 +0000)]
[Darwin, PPC, testsuite] Fix pr80125 testcase for Darwin.

Darwin (unlike most of the members of the PowerPC port family)
defaults to signed chars, so the test was failing to compile with
a "mismatched parameters" error.

2019-06-23  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/pr80125.c (foo): Use an unsigned char
vector explicitly for the vec_perm.

From-SVN: r272605

5 years ago[Darwin, PPC, testsuite] Fix builtins-1 testcase for Darwin.
Iain Sandoe [Sun, 23 Jun 2019 19:48:55 +0000 (19:48 +0000)]
[Darwin, PPC, testsuite] Fix builtins-1 testcase for Darwin.

This needs to account for Darwin's __USER_LABEL_PREFIX__.

2019-06-23  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/builtins-1.c: Account for Darwin's use of
__USER_LABEL_PREFIX__.

From-SVN: r272604

5 years ago[Darwin, PPC] Handle GCC target pragma.
Iain Sandoe [Sun, 23 Jun 2019 19:23:51 +0000 (19:23 +0000)]
[Darwin, PPC] Handle GCC target pragma.

For compatibility with other members of the port.
Note, that we do not handle the longcall attribute, since longcall
is not required/used on current Darwin.

2019-06-23  Iain Sandoe  <iain@sandoe.co.uk>

* config/rs6000/darwin.h: Handle GCC target pragma.

From-SVN: r272603

5 years ago[Darwin, PPC] Emit uppercase versions of ppc defines.
Iain Sandoe [Sun, 23 Jun 2019 19:13:08 +0000 (19:13 +0000)]
[Darwin, PPC] Emit uppercase versions of ppc defines.

Emit __PPC__ (32b) and __PPC64__ (64bit) as per the other members
of the PowerPC port.

2019-06-23  Iain Sandoe  <iain@sandoe.co.uk>

* config/rs6000/darwin.h: (__PPC__, __PPC64__): New.

From-SVN: r272602

5 years ago[Darwin, PPC, testsuite] Fix pr71785 testcase for Darwin.
Iain Sandoe [Sun, 23 Jun 2019 18:56:21 +0000 (18:56 +0000)]
[Darwin, PPC, testsuite] Fix pr71785 testcase for Darwin.

Firstly, we adjust the test conditions to use non-PIC code for Darwin.
Secondly, we have to account for out-of-line GPR restores which gives
a false positive on one of the scan-assembler-not.  Lastly, we make the
test a bit more specific for Darwin - that it looks for absence of
branches to local labels.

2019-06-23  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/pr71785.c: For Darwin, make test non-PIC,
expect the out-of-line GPR restore, and test specifically for
absence of branches to local labels.

From-SVN: r272601

5 years agoRename DEFAULT_ARG to DEFERRED_PARSE.
Marek Polacek [Sun, 23 Jun 2019 15:10:00 +0000 (15:10 +0000)]
Rename DEFAULT_ARG to DEFERRED_PARSE.

From-SVN: r272600

5 years agoDaily bump.
GCC Administrator [Sun, 23 Jun 2019 00:16:20 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r272599

5 years agoFix typo in ChangeLog
Jerry DeLisle [Sat, 22 Jun 2019 20:02:51 +0000 (20:02 +0000)]
Fix typo in ChangeLog

From-SVN: r272595

5 years agore PR fortran/89782 (Can do an internal READ of a character array when it is a parame...
Jerry DeLisle [Sat, 22 Jun 2019 19:58:47 +0000 (19:58 +0000)]
re PR fortran/89782 (Can do an internal READ of a character array when it is a parameter, but not a scalar character parameter)

2019-06-22  Jerry DeLisle  <jvdelisle@gcc.gnu.org>

PR fortran/89782
* io.c (gfc_resolve_dt): Check that internal units are not
character PARAMETER.

* gfortran.dg/io_constraints.f90: New test.

From-SVN: r272594

5 years ago[Darwin, PPC, testsuite] Add requires for DFP to two tests.
Iain Sandoe [Sat, 22 Jun 2019 19:43:26 +0000 (19:43 +0000)]
[Darwin, PPC, testsuite] Add requires for DFP to two tests.

The two tests use decimal floating point, add the relevant dg-requires
so that they are unsupported on platforms without DFP.

2019-06-22  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/pr64205.c: Require effective target dfp.
* gcc.target/powerpc/pr79909.c: Likewise.

From-SVN: r272592

5 years ago[Darwin, PPC, testsuite] Fix darwin-bool-1.c.
Iain Sandoe [Sat, 22 Jun 2019 19:38:47 +0000 (19:38 +0000)]
[Darwin, PPC, testsuite] Fix darwin-bool-1.c.

This test is failing because of a pedantic warning that is unrelated to the
purpose of the test.  Fixed by suppressing that warning.

2019-06-22  Iain Sandoe  <iain@sandoe.co.uk>

* gcc.target/powerpc/darwin-bool-1.c: Suppress the pedantic
warning about _Bool.

From-SVN: r272591

5 years ago* config/avr/avr.c (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.
Jeff Law [Sat, 22 Jun 2019 16:31:50 +0000 (10:31 -0600)]
* config/avr/avr.c (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.

From-SVN: r272590

5 years agore PR c++/65707 (internal compiler error: in unify, at cp/pt.c:18577)
Marek Polacek [Sat, 22 Jun 2019 16:29:06 +0000 (16:29 +0000)]
re PR c++/65707 (internal compiler error: in unify, at cp/pt.c:18577)

PR c++/65707
PR c++/89480
PR c++/58836
* g++.dg/cpp0x/nondeduced5.C: New test.
* g++.dg/cpp0x/nondeduced6.C: New test.
* g++.dg/cpp0x/nondeduced7.C: New test.

From-SVN: r272589

5 years agore PR c++/66256 (noexcept evaluation done before end of class)
Marek Polacek [Sat, 22 Jun 2019 15:51:49 +0000 (15:51 +0000)]
re PR c++/66256 (noexcept evaluation done before end of class)

PR c++/66256
* g++.dg/cpp0x/noexcept54.C: New test.

From-SVN: r272588

5 years agoalias-access-path-6.c: New testcase.
Jan Hubicka [Sat, 22 Jun 2019 15:32:51 +0000 (17:32 +0200)]
alias-access-path-6.c: New testcase.

* gcc.dg/tree-ssa/alias-access-path-6.c: New testcase.
* tree-ssa-alias.c (nonoverlapping_component_refs_p): Do not
give up on bitfields; continue searching for different refs
appearing later.

From-SVN: r272587

5 years agoPR c++/86476 - noexcept-specifier is a complete-class context.
Marek Polacek [Sat, 22 Jun 2019 15:14:30 +0000 (15:14 +0000)]
PR c++/86476 - noexcept-specifier is a complete-class context.

PR c++/52869
* cp-tree.def (DEFAULT_ARG): Update commentary.
* cp-tree.h (UNPARSED_NOEXCEPT_SPEC_P): New macro.
(tree_default_arg): Use tree_base instead of tree_common.
(do_push_parm_decls, maybe_check_overriding_exception_spec): Declare.
* decl.c (do_push_parm_decls): New function, broken out of...
(store_parm_decls): ...here.  Call it.
* except.c (nothrow_spec_p): Accept DEFAULT_ARG in the assert.
* parser.c (cp_parser_noexcept_specification_opt,
cp_parser_late_noexcept_specifier, noexcept_override_late_checks):
Forward-declare.
(unparsed_noexcepts): New macro.
(push_unparsed_function_queues): Update initializer.
(cp_parser_direct_declarator): Pass FRIEND_P to
cp_parser_exception_specification_opt.
(inject_parm_decls): New.
(pop_injected_parms): New.
(cp_parser_class_specifier_1): Implement delayed parsing of
noexcept-specifiers.
(cp_parser_save_noexcept): New.
(cp_parser_late_noexcept_specifier): New.
(noexcept_override_late_checks): New.
(cp_parser_noexcept_specification_opt): Add FRIEND_P parameter.  Call
cp_parser_save_noexcept instead of the normal processing if needed.
(cp_parser_exception_specification_opt): Add FRIEND_P parameter and
pass it to cp_parser_noexcept_specification_opt.
(cp_parser_save_member_function_body): Fix comment.
(cp_parser_save_default_args): Maybe save the noexcept-specifier to
post process.
(cp_parser_transaction): Update call to
cp_parser_noexcept_specification_opt.
(cp_parser_transaction_expression): Likewise.
* parser.h (cp_unparsed_functions_entry): Add new field to carry
a noexcept-specifier.
* pt.c (dependent_type_p_r): Handle unparsed noexcept expression.
* search.c (maybe_check_overriding_exception_spec): New function, broken
out of...
(check_final_overrider): ...here.  Call
maybe_check_overriding_exception_spec.
* tree.c (canonical_eh_spec): Handle UNPARSED_NOEXCEPT_SPEC_P.
(cp_tree_equal): Handle DEFAULT_ARG.

* g++.dg/cpp0x/noexcept45.C: New test.
* g++.dg/cpp0x/noexcept46.C: New test.
* g++.dg/cpp0x/noexcept47.C: New test.
* g++.dg/cpp0x/noexcept48.C: New test.
* g++.dg/cpp0x/noexcept49.C: New test.
* g++.dg/cpp0x/noexcept50.C: New test.
* g++.dg/cpp0x/noexcept51.C: New test.
* g++.dg/cpp0x/noexcept52.C: New test.
* g++.dg/cpp0x/noexcept53.C: New test.
* g++.dg/eh/shadow1.C: Adjust dg-error.

From-SVN: r272586

5 years agoPR c++/90881 - bogus -Wunused-value in unevaluated context.
Marek Polacek [Sat, 22 Jun 2019 14:43:00 +0000 (14:43 +0000)]
PR c++/90881 - bogus -Wunused-value in unevaluated context.

* cvt.c (convert_to_void): Don't emit unused warnings in
an unevaluated context.

* g++.dg/cpp0x/Wunused-value1.C: New test.

From-SVN: r272585

5 years agodecl.c (grokdeclarator): Use id_loc...
Paolo Carlini [Sat, 22 Jun 2019 09:36:38 +0000 (09:36 +0000)]
decl.c (grokdeclarator): Use id_loc...

/cp
2019-06-22  Paolo Carlini  <paolo.carlini@oracle.com>

* decl.c (grokdeclarator): Use id_loc, typespec_loc, and
locations[ds_storage_class] in a few additional places.

/testsuite
2019-06-22  Paolo Carlini  <paolo.carlini@oracle.com>

* g++.dg/diagnostic/auto-storage-1.C: New.
* g++.dg/diagnostic/no-type-1.C: Likewise.
* g++.dg/diagnostic/no-type-2.C: Likewise.
* g++.dg/diagnostic/top-level-auto-1.C: Likewise.
* g++.dg/cpp0x/auto9.C: Test some locations too.
* g++.dg/cpp1z/register1.C: Likewise.
* g++.dg/cpp1z/register2.C: Likewise.
* g++.dg/cpp1z/register3.C: Likewise.
* g++.dg/other/error34.C: Likewise.

From-SVN: r272584

5 years agoDaily bump.
GCC Administrator [Sat, 22 Jun 2019 00:16:17 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r272583

5 years agocompiler: intrinsify some math/bits functions
Cherry Zhang [Fri, 21 Jun 2019 22:42:18 +0000 (22:42 +0000)]
compiler: intrinsify some math/bits functions

    Let the Go frontend recognize some math/bits functions and turn
    them into intrinsics.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/183266

* go-gcc.cc (Gcc_backend::Gcc_backend): Define math/bits
builtins.

From-SVN: r272579

5 years agoruntime: inline and remove eqtype
Ian Lance Taylor [Fri, 21 Jun 2019 22:21:40 +0000 (22:21 +0000)]
runtime: inline and remove eqtype

    Now that type equality is just a pointer equality, write it
    inlined and remove the eqtype function.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/182978

From-SVN: r272578

5 years agocompiler: open code some type assertions
Ian Lance Taylor [Fri, 21 Jun 2019 22:00:57 +0000 (22:00 +0000)]
compiler: open code some type assertions

    Now that type equality is just simple pointer equality, we can
    open code some type assertions instead of making runtime calls.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/182977

From-SVN: r272577

5 years agore PR c++/90909 (call devirtualized to pure virtual)
Paolo Carlini [Fri, 21 Jun 2019 21:58:19 +0000 (21:58 +0000)]
re PR c++/90909 (call devirtualized to pure virtual)

2019-06-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/90909
* g++.dg/other/final7.C: New.

From-SVN: r272576

5 years agotree-vect-data-refs.c (vect_find_stmt_data_reference): Handle even zero DR_OFFSET...
Jakub Jelinek [Fri, 21 Jun 2019 21:38:35 +0000 (23:38 +0200)]
tree-vect-data-refs.c (vect_find_stmt_data_reference): Handle even zero DR_OFFSET...

* tree-vect-data-refs.c (vect_find_stmt_data_reference): Handle
even zero DR_OFFSET, but DR_BASE_ADDRESS of POINTER_PLUS_EXPR
containing the offset as possible simd lane access.  Look through
widening conversion.  Move the
TREE_CODE (DR_INIT (newdr)) == INTEGER_CST test earlier and reindent.

* g++.dg/vect/simd-2.cc: Don't xfail, instead expect vectorization on
x86.
* g++.dg/vect/simd-5.cc: Likewise.

From-SVN: r272575

5 years agore PR c++/90909 (call devirtualized to pure virtual)
Paolo Carlini [Fri, 21 Jun 2019 20:47:40 +0000 (20:47 +0000)]
re PR c++/90909 (call devirtualized to pure virtual)

/cp
2019-06-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/90909
Revert:
2019-05-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/67184
PR c++/69445
* call.c (build_over_call): Devirtualize when the final overrider
comes from the base.

/testsuite
2019-06-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/90909
Revert:
2019-05-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/67184
PR c++/69445
* g++.dg/other/final3.C: New.
* g++.dg/other/final4.C: Likewise.
* g++.dg/other/final5.C: Likewise.

* g++.dg/other/final6.C: New.

From-SVN: r272574

5 years agore PR c++/90909 (call devirtualized to pure virtual)
Paolo Carlini [Fri, 21 Jun 2019 20:46:51 +0000 (20:46 +0000)]
re PR c++/90909 (call devirtualized to pure virtual)

/cp
2019-06-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/90909
Revert:
2019-05-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/67184
PR c++/69445
* call.c (build_over_call): Devirtualize when the final overrider
comes from the base.

/testsuite
2019-06-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/90909
Revert:
2019-05-21  Paolo Carlini  <paolo.carlini@oracle.com>

PR c++/67184
PR c++/69445
* g++.dg/other/final3.C: New.
* g++.dg/other/final4.C: Likewise.
* g++.dg/other/final5.C: Likewise.

* g++.dg/other/final6.C: New.

From-SVN: r272573

5 years agoPR c++/61490 - qualified-id in friend function definition.
Marek Polacek [Fri, 21 Jun 2019 20:43:47 +0000 (20:43 +0000)]
PR c++/61490 - qualified-id in friend function definition.

* decl.c (grokdeclarator): Diagnose qualified-id in friend function
definition.  Improve location for diagnostics of friend functions.

* g++.dg/diagnostic/friend2.C: New test.
* g++.dg/diagnostic/friend3.C: New test.

From-SVN: r272572

5 years agoPR c++/60223 - ICE with T{} in non-deduced context.
Marek Polacek [Fri, 21 Jun 2019 20:32:06 +0000 (20:32 +0000)]
PR c++/60223 - ICE with T{} in non-deduced context.

* pt.c (unify): Allow COMPOUND_LITERAL_P in a non-deduced context.

* g++.dg/cpp0x/nondeduced1.C: New test.
* g++.dg/cpp0x/nondeduced2.C: New test.
* g++.dg/cpp0x/nondeduced3.C: New test.
* g++.dg/cpp0x/nondeduced4.C: New test.

From-SVN: r272571

5 years agoPR c++/64235 - missing syntax error with invalid alignas.
Marek Polacek [Fri, 21 Jun 2019 20:26:54 +0000 (20:26 +0000)]
PR c++/64235 - missing syntax error with invalid alignas.

* parser.c (cp_parser_std_attribute_spec): Commit to tentative parse
if there's a missing close paren.

* g++.dg/parse/alignas1.C: New test.

From-SVN: r272570

5 years agore PR fortran/67884 (Missing error message on required allocatable attribute)
Steven G. Kargl [Fri, 21 Jun 2019 20:24:01 +0000 (20:24 +0000)]
re PR fortran/67884 (Missing error message on required allocatable attribute)

2019-06-21  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/67884
* resolve.c (deferred_requirements) : Check only the result variable.
(resolve_fl_procedure): Check deferred requirements on functions.

2019-06-21  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/67884
* gfortran.dg/dummy_procedure_8.f90: Remove a test that is ...
* gfortran.dg/pr67884.f90: ... covered here.  New test.

From-SVN: r272569

5 years agoPR c++/90490 - fix decltype issues in noexcept-specifier.
Marek Polacek [Fri, 21 Jun 2019 20:19:24 +0000 (20:19 +0000)]
PR c++/90490 - fix decltype issues in noexcept-specifier.

* except.c (build_noexcept_spec): Call
instantiate_non_dependent_expr_sfinae before
build_converted_constant_expr instead of calling
instantiate_non_dependent_expr after it.  Add
processing_template_decl_sentinel.

* g++.dg/cpp0x/noexcept43.C: New test.
* g++.dg/cpp0x/noexcept44.C: New test.

From-SVN: r272568

5 years agoPR c++/90875 - added -Wswitch-outside-range option
Matthew Beliveau [Fri, 21 Jun 2019 19:58:32 +0000 (19:58 +0000)]
PR c++/90875 - added -Wswitch-outside-range option

From-SVN: r272567

5 years ago[Darwin, fixincludes] Fix Darwin9/10 math.h issues.
Iain Sandoe [Fri, 21 Jun 2019 19:18:18 +0000 (19:18 +0000)]
[Darwin, fixincludes] Fix Darwin9/10 math.h issues.

Darwin has had long long functions for some considerable time and these are
exposed in Darwin8 and Darwin11+ headers.  However, for some reason it was
elected to hide them behind __STRICT_ANSI__ and __STDC_VERSION__ on Darwin9
and Darwin10.  This is a problem for G++/libstdc++ that expects the functions
to be available for strict ansi (-std=c++14, for example) and without
defining __STDC_VERSION__.  The fix here follows the pattern used in
Darwin11+ headers where the functions may be explicitly hidden by defining
__DARWIN_NO_LONG_LONG.

This fixes the tr1 testsuite fails seen on Darwin9 and 10.

2019-06-21  Iain Sandoe  <iain@sandoe.co.uk>

* inclhack.def: Replace the complex test using __STRICT_ANSI__ and
__STDC_VERSION__ with a test using __DARWIN_NO_LONG_LONG.
Ensure that the top level math.h uses <> to wrap included headers
rather than "".
* fixincl.x: Regenerated.
* tests/base/architecture/ppc/math.h: Update test to include the
__DARWIN_NO_LONG_LONG case.

From-SVN: r272563

5 years ago[Darwin, fixincludes] Fix Darwin14 header issues.
Iain Sandoe [Fri, 21 Jun 2019 19:03:45 +0000 (19:03 +0000)]
[Darwin, fixincludes] Fix Darwin14 header issues.

There are two issues with the Darwin14 (SDK) headers in which unguarded
advanced syntax elements causes any code including these headers to fail.

2019-06-21  Iain Sandoe  <iain@sandoe.co.uk>

* inclhack.def: Guard __has_attribute and __has_extension in
os/base.h.
Guard Apple blocks syntax in dispatch/object.h.
* fixincl.x: Regenerate.
* tests/base/dispatch/object.h: New file.
* tests/base/os/base.h: New file.

From-SVN: r272561

5 years agore PR tree-optimization/90930 (Excessive memory consumption)
Richard Biener [Fri, 21 Jun 2019 18:12:58 +0000 (18:12 +0000)]
re PR tree-optimization/90930 (Excessive memory consumption)

2019-06-21  Richard Biener  <rguenther@suse.de>

PR tree-optimization/90930
* tree-ssa-reassoc.c (rewrite_expr_tree_parallel): Set visited
flag on new stmts to avoid re-processing them.

From-SVN: r272560

5 years agoPR c++/90875 - added -Wswitch-outside-range option
Matthew Beliveau [Fri, 21 Jun 2019 17:50:29 +0000 (17:50 +0000)]
PR c++/90875 - added -Wswitch-outside-range option

* doc/invoke.texi (Wswitch-outside-range): Document.

* c.opt (Wswitch-outside-range): Added new option.
* c-warn.c (c_do_switch_warnings): Use OPT_Wswitch-outside-range.

* c-c++-common/Wswitch-outside-range-1.c: New test.
* c-c++-common/Wswitch-outside-range-2.c: New test.
* c-c++-common/Wswitch-outside-range-3.c: New test.
* c-c++-common/Wswitch-outside-range-4.c: New test.

From-SVN: r272559

5 years agore PR fortran/51991 (Wrong error message with variables named "SAVE*")
Steven G. Kargl [Fri, 21 Jun 2019 16:57:24 +0000 (16:57 +0000)]
re PR fortran/51991 (Wrong error message with variables named "SAVE*")

2019-06-21  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/51991
* decl.c (gfc_match_save): If SAVE was not seen, return MATCH_NO
instead issuing an error message and returning MATCH_ERROR.

2019-06-21  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/51991
gfortran.dg/pr51991.f90

From-SVN: r272556

5 years agore PR tree-optimization/90949 (null pointer check removed)
Jeff Law [Fri, 21 Jun 2019 16:36:00 +0000 (10:36 -0600)]
re PR tree-optimization/90949 (null pointer check removed)

PR tree-optimization/90949
* tree-ssa-copy.c (fini_copy_prop): Use reset_flow_sensitive_info.
* tree-ssanames.c (reset_flow_sensitive_info): Reset non-null state.

* gcc.c-torture/execute/pr90949.c: New test.

From-SVN: r272555

5 years agoFix missing name in ChangeLog
Richard Sandiford [Fri, 21 Jun 2019 15:02:46 +0000 (15:02 +0000)]
Fix missing name in ChangeLog

Fix another case in which a name in the commit message wasn't copied to
the ChangeLog -- sorry!

From-SVN: r272553

5 years agoPR c++/90953 - ICE with -Wmissing-format-attribute.
Marek Polacek [Fri, 21 Jun 2019 14:41:22 +0000 (14:41 +0000)]
PR c++/90953 - ICE with -Wmissing-format-attribute.

* c-common.c (check_function_arguments_recurse): Use
get_attribute_name.
(check_missing_format_attribute): Likewise.

* g++.dg/warn/miss-format-7.C: New test.

From-SVN: r272552

5 years agoFix missing name in ChangeLog
Richard Sandiford [Fri, 21 Jun 2019 14:38:39 +0000 (14:38 +0000)]
Fix missing name in ChangeLog

It was in the commit message but got dropped from the ChangeLog entry
due to a scripting bug.

From-SVN: r272551

5 years agocompiler: omit write barrier for assignment to *(convert(&local))
Ian Lance Taylor [Fri, 21 Jun 2019 14:34:26 +0000 (14:34 +0000)]
compiler: omit write barrier for assignment to *(convert(&local))

    Assignments to local variables don't need a write barrier. But
    currently the compiler inserts a write barrier if the LHS is a
    local variable with type converted, as *(convert(&local)). Let
    the compiler recognize this pattern and omit the write barrier.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/182541

From-SVN: r272550

5 years agocompiler: open code string slice expressions
Ian Lance Taylor [Fri, 21 Jun 2019 14:14:58 +0000 (14:14 +0000)]
compiler: open code string slice expressions

    Currently a string slice expression is implemented with a runtime
    call __go_string_slice. Change it to open code it, which is more
    efficient, and allows the backend to further optimize it.

    Also omit the write barrier for length-only update (i.e.
    s = s[:n]).

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/182540

From-SVN: r272549

5 years agore PR debug/90914 (ICE in schedule_generic_params_dies_gen, at dwarf2out.c:27153)
Richard Biener [Fri, 21 Jun 2019 13:56:54 +0000 (13:56 +0000)]
re PR debug/90914 (ICE in schedule_generic_params_dies_gen, at dwarf2out.c:27153)

2019-06-21  Richard Biener  <rguenther@suse.de>

PR debug/90914
* dwarf2out.c (prune_unused_types_walk): Always consider
function-local extern declarations as used.

* g++.dg/debug/pr90914.C: New testcase.

From-SVN: r272547

5 years agore PR tree-optimization/90913 (ICE in maybe_gen_insn, at optabs.c:7341 since r272239)
Richard Biener [Fri, 21 Jun 2019 11:10:39 +0000 (11:10 +0000)]
re PR tree-optimization/90913 (ICE in maybe_gen_insn, at optabs.c:7341 since r272239)

2019-06-21  Richard Biener  <rguenther@suse.de>

PR tree-optimization/90913
* tree-vect-loop-manip.c (vect_loop_versioning): Do not re-use
the scalar variant of if-conversion versioning.

* gfortran.dg/vect/pr90913.f90: New testcase.

From-SVN: r272545

5 years agoomp-low.c (lower_rec_simd_input_clauses): Add rvar2 argument...
Jakub Jelinek [Fri, 21 Jun 2019 06:48:57 +0000 (08:48 +0200)]
omp-low.c (lower_rec_simd_input_clauses): Add rvar2 argument...

* omp-low.c (lower_rec_simd_input_clauses): Add rvar2 argument,
create another "omp scan inscan exclusive" array if
!ctx->scan_inclusive.
(lower_rec_input_clauses): Handle exclusive scan inscan reductions.
(lower_omp_scan): Likewise.
* tree-vectorizer.h (struct _stmt_vec_info): Use 3-bit instead of
2-bit bitfield for simd_lane_access_p member.
* tree-vect-data-refs.c (vect_analyze_data_refs): Also handle
aux == (void *)-4 as simd lane access.
* tree-vect-stmts.c (check_scan_store): Handle exclusive scan.  Update
comment with permutations to show the canonical permutation order.
(vectorizable_scan_store): Handle exclusive scan.
(vectorizable_store): Call vectorizable_scan_store even for
STMT_VINFO_SIMD_LANE_ACCESS_P > 3.

* gcc.dg/vect/vect-simd-12.c: New test.
* gcc.dg/vect/vect-simd-13.c: New test.
* gcc.dg/vect/vect-simd-14.c: New test.
* gcc.dg/vect/vect-simd-15.c: New test.
* gcc.target/i386/sse2-vect-simd-12.c: New test.
* gcc.target/i386/sse2-vect-simd-13.c: New test.
* gcc.target/i386/sse2-vect-simd-14.c: New test.
* gcc.target/i386/sse2-vect-simd-15.c: New test.
* gcc.target/i386/avx2-vect-simd-12.c: New test.
* gcc.target/i386/avx2-vect-simd-13.c: New test.
* gcc.target/i386/avx2-vect-simd-14.c: New test.
* gcc.target/i386/avx2-vect-simd-15.c: New test.
* gcc.target/i386/avx512f-vect-simd-12.c: New test.
* gcc.target/i386/avx512f-vect-simd-13.c: New test.
* gcc.target/i386/avx512f-vect-simd-14.c: New test.
* gcc.target/i386/avx512bw-vect-simd-15.c: New test.
* g++.dg/vect/simd-6.cc: New test.
* g++.dg/vect/simd-7.cc: New test.
* g++.dg/vect/simd-8.cc: New test.
* g++.dg/vect/simd-9.cc: New test.
* c-c++-common/gomp/scan-2.c: Don't expect any diagnostics.

From-SVN: r272544

5 years agore PR c++/90950 (OpenMP clause handling rejecting references to incomplete types...
Jakub Jelinek [Fri, 21 Jun 2019 06:46:45 +0000 (08:46 +0200)]
re PR c++/90950 (OpenMP clause handling rejecting references to incomplete types in templates)

PR c++/90950
* semantics.c (finish_omp_clauses): Don't reject references to
incomplete types if processing_template_decl.

* g++.dg/gomp/lastprivate-1.C: New test.

From-SVN: r272543

5 years agotree-vect-data-refs.c (vect_find_stmt_data_reference): Handle "omp simd array" arrays...
Jakub Jelinek [Fri, 21 Jun 2019 06:45:59 +0000 (08:45 +0200)]
tree-vect-data-refs.c (vect_find_stmt_data_reference): Handle "omp simd array" arrays with one byte elements.

* tree-vect-data-refs.c (vect_find_stmt_data_reference): Handle
"omp simd array" arrays with one byte elements.

* gcc.dg/vect/vect-simd-11.c: New test.
* gcc.target/i386/sse2-vect-simd-11.c: New test.
* gcc.target/i386/avx2-vect-simd-11.c: New test.
* gcc.target/i386/avx512bw-vect-simd-11.c: New test.

From-SVN: r272542

5 years agoDaily bump.
GCC Administrator [Fri, 21 Jun 2019 00:16:20 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r272538

5 years agore PR c++/79781 (ICE on valid C++ code with -std=c++14 (in assemble_integer, at varas...
Marek Polacek [Thu, 20 Jun 2019 22:35:34 +0000 (22:35 +0000)]
re PR c++/79781 (ICE on valid C++ code with -std=c++14 (in assemble_integer, at varasm.c:2733))

PR c++/79781
* g++.dg/ext/goto1.C: New test.

From-SVN: r272527

5 years agore PR fortran/77632 ([F08] Pointer initialisation does not quite work with arrays)
Steven G. Kargl [Thu, 20 Jun 2019 22:16:29 +0000 (22:16 +0000)]
re PR fortran/77632 ([F08] Pointer initialisation does not quite work with arrays)

2019-06-20  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/77632
* /decl.c (variable_decl): Mark a variable that is a target in pointer
initialization when in PROGRAM, MODULE, or SUBMODULE scope with an
implicit save.

2019-06-20  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/77632
* gfortran.dg/pr77632_1.f90: New test.

From-SVN: r272526

5 years agore PR c++/68265 (Arbitrary syntactic nonsense silently accepted after 'int (*){}...
Marek Polacek [Thu, 20 Jun 2019 22:06:36 +0000 (22:06 +0000)]
re PR c++/68265 (Arbitrary syntactic nonsense silently accepted after 'int (*){}' until the next close brace)

PR c++/68265
* g++.dg/parse/error62.C: New test.

From-SVN: r272525

5 years agore PR fortran/86587 (Derived-type with attributes BIND(C) and PRIVATE raises an error...
Steven G. Kargl [Thu, 20 Jun 2019 21:39:43 +0000 (21:39 +0000)]
re PR fortran/86587 (Derived-type with attributes BIND(C) and PRIVATE raises an error but standard accepts it)

2019-06-20  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/86587
* symbol.c (verify_bind_c_derived_type): Remove erroneous error
checking for BIND(C) and PRIVATE attributes.

2019-06-20  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/86587
* gfortran.dg/pr86587.f90: New test.

From-SVN: r272524

5 years agoalpha.md (@unaligned_store<mode>): Rename from unaligned_store<mode>.
Uros Bizjak [Thu, 20 Jun 2019 21:07:38 +0000 (23:07 +0200)]
alpha.md (@unaligned_store<mode>): Rename from unaligned_store<mode>.

* config/alpha/alpha.md (@unaligned_store<mode>):
Rename from unaligned_store<mode>.
(@reload_in<mode>_aligned): Rename from reload_in<mode>_aligned.
* config/alpha/sync.md (@load_locked_<mode>): Rename
from load_locked_<mode>.
(@store_conditional_<mode>): Rename from store_conditional_<mode>.
(@atomic_compare_and_swap<mode>_1): Rename
from atomic_compare_and_swap<mode>_1.
(@atomic_exchange<mode>_1): Rename from atomic_exchange<mode>_1.
* config/alpha/alpha.c (alpha_expand_mov_nobwx):
Use gen_reload_in_aligned and gen_unaligned_store.
(emit_load_locked): Remove.
(emit_store_conditional): Ditto.
(alpha_split_atomic_op): Use gen_load_locked and gen_store_conditional.
(alpha_split_compare_and_swap): Ditto.
(alpha_expand_compare_and_swap_12): Use gen_atomic_compare_and_swap_1.
(alpha_split_compare_and_swap_12): Use gen_load_locked
and gen_store_conditional.
(alpha_split_atomic_exchange): Ditto.
(alpha_expand_atomic_exchange_12): Use gen_atomic_exchange_1.
(alpha_split_atomic_exchange_12): Use gen_load_locked
and gen_store_conditional.

From-SVN: r272523

5 years agolibfortran/65921: Add forgotten PR number to ChangeLog
Janne Blomqvist [Thu, 20 Jun 2019 20:26:39 +0000 (23:26 +0300)]
libfortran/65921: Add forgotten PR number to ChangeLog

2019-06-14  Janne Blomqvist  <jb@gcc.gnu.org>

        PR fortran/65921
        * runtime/memory.c (SIZE_MAX):Remove macro definition.
        (xmallocarray): Use __builtin_mul_overflow.

From-SVN: r272520

5 years ago[objective-c/c++, testsuite] Fix stubify tests for -fnext-runtime.
Iain Sandoe [Thu, 20 Jun 2019 19:15:58 +0000 (19:15 +0000)]
[objective-c/c++, testsuite] Fix stubify tests for -fnext-runtime.

These tests were broken in the first place, and more broken following
the change to drop pic symbol stubs unless the linker needs them.

Fixed to work for x86 as well as powerpc and amended the options to
force pic symbol stubs on.

gcc/testsuite/

2019-06-20  Iain Sandoe  <iain@sandoe.co.uk>

* obj-c++.dg/stubify-1.mm: Adjust options and scan-asm checks.
* obj-c++.dg/stubify-2.mm: Likewise.
* objc.dg/stubify-1.m: Likewise.
* objc.dg/stubify-2.m: Likewise.

From-SVN: r272518

5 years ago[aarch64] Refactor common errata work-around specs
Richard Earnshaw [Thu, 20 Jun 2019 17:27:06 +0000 (17:27 +0000)]
[aarch64] Refactor common errata work-around specs

With the addition of the AArch64 NetBSD support code we now have four
ports all using and defining the same errata work-around headers.
That's silly and long-term becomes a maintenance burden.

This patch factors all that code into a single header to eliminate all
the duplication.

* config/aarch64/aarch64-errata.h: New file.
* config/aarch64/aarch64-elf-raw.h (CA53_ERR_835769_SPEC): Delete.
(CA53_ERR_843419_SPEC): Delete.
(LINK_SPEC): Use AARCH64_ERRATA_LINK_SPEC instead of above.
* config/aarch64/aarch64-linux.h: Likewise.
* config/aarch64/aarch64-netbsd.h: Likewise.
* config/aarch64/aarch64-freebsd.h: Likewise.

From-SVN: r272515

5 years ago* config/sh/sh.c (sh2a_function_vector_p): Use get_attribute_name.
Marek Polacek [Thu, 20 Jun 2019 17:12:38 +0000 (17:12 +0000)]
* config/sh/sh.c (sh2a_function_vector_p): Use get_attribute_name.

From-SVN: r272514

5 years agors6000.md (isa attribute): Add support for for a future processor.
Michael Meissner [Thu, 20 Jun 2019 17:10:51 +0000 (17:10 +0000)]
rs6000.md (isa attribute): Add support for for a future processor.

2019-06-20  Michael Meissner  <meissner@linux.ibm.com>

* config/rs6000/rs6000.md (isa attribute): Add support for
for a future processor.

From-SVN: r272513

5 years agore PR c++/87512 (Error: the type ‘const auto’ of ‘constexpr’ variable is not literal)
Marek Polacek [Thu, 20 Jun 2019 15:37:35 +0000 (15:37 +0000)]
re PR c++/87512 (Error: the type ‘const auto’ of ‘constexpr’ variable is not literal)

PR c++/87512
* g++.dg/cpp1z/inline-var7.C: New test.

From-SVN: r272512

5 years agoi386: Generate standard floating point scalar operation patterns
H.J. Lu [Thu, 20 Jun 2019 15:30:54 +0000 (15:30 +0000)]
i386: Generate standard floating point scalar operation patterns

Standard floating point scalar operation patterns for combiner, which
preserve the rest of the vector, look like

     (vec_merge:V2DF
       (vec_duplicate:V2DF (reg:DF 87))
       (reg/v:V2DF 85 [ x ])
       (const_int 1 [0x1])]))

and

     (vec_merge:V2DF
       (vec_duplicate:V2DF
         (op:DF (vec_select:DF (reg/v:V2DF 85 [ x ])
                (parallel [ (const_int 0 [0])]))
         (reg:DF 87))
       (reg/v:V2DF 85 [ x ])
       (const_int 1 [0x1])]))

This patch adds and generates such standard floating point scalar
operation patterns for +, -, *, /, > and <.

Tested on x86-64.

gcc/

PR target/54855
* config/i386/i386-expand.c (ix86_expand_vector_set): Generate
standard scalar operation pattern for V2DF.
* config/i386/sse.md (*<sse>_vm<plusminus_insn><mode>3): New.
(*<sse>_vm<multdiv_mnemonic><mode>3): Likewise.
(*ieee_<ieee_maxmin><mode>3): Likewise.
(vec_setv2df_0): Likewise.

gcc/testsuite/

PR target/54855
* gcc.target/i386/pr54855-1.c: New test.
* gcc.target/i386/pr54855-2.c: Likewise.
* gcc.target/i386/pr54855-3.c: Likewise.
* gcc.target/i386/pr54855-4.c: Likewise.
* gcc.target/i386/pr54855-5.c: Likewise.
* gcc.target/i386/pr54855-6.c: Likewise.
* gcc.target/i386/pr54855-7.c: Likewise.
* gcc.target/i386/pr54855-8.c: Likewise.
* gcc.target/i386/pr54855-9.c: Likewise.
* gcc.target/i386/pr54855-10.c: Likewise.

From-SVN: r272511

5 years agotree-ssa-alias.c (aliasing_component_refs_p): Remove ref2_is_decl parameter; it has...
Jan Hubicka [Thu, 20 Jun 2019 14:18:02 +0000 (16:18 +0200)]
tree-ssa-alias.c (aliasing_component_refs_p): Remove ref2_is_decl parameter; it has no use in gimple memory model.

* tree-ssa-alias.c (aliasing_component_refs_p): Remove ref2_is_decl
parameter; it has no use in gimple memory model.
(indirect_ref_may_alias_decl_p): Update.

* gcc.c-torture/execute/alias-access-path-1.c: New testcase.

From-SVN: r272510

5 years agoSkip libstdc++ debug build in early bootstrap stages
Jonathan Wakely [Thu, 20 Jun 2019 14:17:57 +0000 (15:17 +0100)]
Skip libstdc++ debug build in early bootstrap stages

As mentioned in PR 90770, this is a patch that Debian have been carrying
for some time. The additional unoptimized copies of libstdc++ libs that
get built during each stage are never going to be used, so don't bother
building them.

For a profiled bootstrap this means we won't train the compiler on the
unoptimized library code with assertions enabled, but that doesn't seem
like a big problem, as the same code has already been compiled once for
the main libstdc++ library.

* acinclude.m4 (GLIBCXX_ENABLE_DEBUG): Only do debug build for final
stage of bootstrap.
* configure: Regenerate.

From-SVN: r272509

5 years agoQualify calls to __never_valueless in <variant>
Jonathan Wakely [Thu, 20 Jun 2019 14:17:51 +0000 (15:17 +0100)]
Qualify calls to __never_valueless in <variant>

* include/std/variant (_Variant_storage, _Extra_visit_slot_needed):
Qualify calls to __never_valueless.

From-SVN: r272508

5 years agore PR c++/89873 (internal compiler error: unexpected expression of kind implicit_conv...
Marek Polacek [Thu, 20 Jun 2019 12:22:25 +0000 (12:22 +0000)]
re PR c++/89873 (internal compiler error: unexpected expression of kind implicit_conv_expr)

PR c++/89873
* g++.dg/cpp1y/noexcept1.C: New test.

From-SVN: r272507

5 years agore PR fortran/90937 (ICE: in gfc_get_symbol_decl, at fortran/trans-decl.c:1538)
Thomas Koenig [Thu, 20 Jun 2019 11:56:50 +0000 (11:56 +0000)]
re PR fortran/90937 (ICE: in gfc_get_symbol_decl, at fortran/trans-decl.c:1538)

2019-06-20  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/90937
* trans-types.c (get_formal_from_actual_arglist): Get symbol from
current namespace so it will be freed later.  If symbol is of type
character, get an empty character length.

2019-06-20  Thomas Koenig  <tkoenig@gcc.gnu.org>

PR fortran/90937
* gfortran.dg/external_procedure_4.f90: New test.

From-SVN: r272506

5 years ago[testsuite] Add missing dg-require-effective-target global_constructor
Tom de Vries [Thu, 20 Jun 2019 10:37:18 +0000 (10:37 +0000)]
[testsuite] Add missing dg-require-effective-target global_constructor

Add missing dg-require-effective-target global_constructor.

Tested on nvptx.

2019-06-20  Tom de Vries  <tdevries@suse.de>

* gcc.dg/pr90866-2.c: Require global_constructor.

From-SVN: r272505

5 years ago[testsuite] Add missing dg-require-effective-target nonlocal_goto
Tom de Vries [Thu, 20 Jun 2019 10:37:05 +0000 (10:37 +0000)]
[testsuite] Add missing dg-require-effective-target nonlocal_goto

Add missing dg-require-effective-target nonlocal_goto.

Tested on nvptx.

2019-06-20  Tom de Vries  <tdevries@suse.de>

* gcc.c-torture/compile/pr89280.c: Require nonlocal_goto.
* gcc.dg/pr88870.c: Same.
* gcc.dg/pr90082.c: Same.

From-SVN: r272504

5 years ago[testsuite] Add missing dg-require-effective-target indirect_jumps
Tom de Vries [Thu, 20 Jun 2019 10:36:49 +0000 (10:36 +0000)]
[testsuite] Add missing dg-require-effective-target indirect_jumps

Add missing dg-require-effective-target indirect_jumps.

Tested on nvptx.

2019-06-20  Tom de Vries  <tdevries@suse.de>

* gcc.dg/pr89737.c: Require indirect_jumps.
* gcc.dg/torture/pr87693.c: Same.
* gcc.dg/torture/pr89135.c: Same.
* gcc.dg/torture/pr90071.c: Same.

From-SVN: r272503

5 years ago[testsuite] Add missing dg-require-effective-target label_values
Tom de Vries [Thu, 20 Jun 2019 10:36:35 +0000 (10:36 +0000)]
[testsuite] Add missing dg-require-effective-target label_values

Add missing dg-require-effective-target label_values.

Tested on nvptx.

2019-06-20  Tom de Vries  <tdevries@suse.de>

* gcc.c-torture/compile/pr89280.c: Require label_values.
* gcc.dg/pr89737.c: Same.
* gcc.dg/pr90082.c: Same.
* gcc.dg/torture/pr89135.c: Same.
* gcc.dg/torture/pr89247.c: Same.
* gcc.dg/torture/pr90071.c: Same.

From-SVN: r272502

5 years ago[testsuite] Add missing dg-require-effective-target alloca
Tom de Vries [Thu, 20 Jun 2019 10:36:18 +0000 (10:36 +0000)]
[testsuite] Add missing dg-require-effective-target alloca

Add missing dg-require-effective-target alloca.

Tested on nvptx.

2019-06-20  Tom de Vries  <tdevries@suse.de>

* gcc.c-torture/compile/pr77754-1.c: Require alloca.
* gcc.c-torture/compile/pr77754-2.c: Same.
* gcc.c-torture/compile/pr77754-3.c: Same.
* gcc.c-torture/compile/pr77754-4.c: Same.
* gcc.c-torture/compile/pr77754-5.c: Same.
* gcc.c-torture/compile/pr77754-6.c: Same.
* gcc.c-torture/compile/pr87110.c: Same.
* gcc.c-torture/execute/pr86528.c: Same.
* gcc.dg/Walloca-larger-than-2.c: Same.
* gcc.dg/Walloca-larger-than.c: Same.
* gcc.dg/Warray-bounds-41.c: Same.
* gcc.dg/Wrestrict-17.c: Same.
* gcc.dg/Wstrict-overflow-27.c: Same.
* gcc.dg/Wstringop-truncation-3.c: Same.
* gcc.dg/pr78902.c: Same.
* gcc.dg/pr87099.c: Same.
* gcc.dg/pr87320.c: Same.
* gcc.dg/pr89045.c: Same.
* gcc.dg/strlenopt-62.c: Same.
* gcc.dg/tree-ssa/alias-37.c: Same.

From-SVN: r272501

5 years agoFix outdated reference to C++17 draft in the docs
Jonathan Wakely [Thu, 20 Jun 2019 09:13:03 +0000 (10:13 +0100)]
Fix outdated reference to C++17 draft in the docs

* doc/xml/manual/status_cxx2017.xml: Fix outdated reference to
C++17 working draft.

From-SVN: r272500

5 years agoImprove tests for std::vector<bool> printer
Jonathan Wakely [Thu, 20 Jun 2019 09:04:55 +0000 (10:04 +0100)]
Improve tests for std::vector<bool> printer

The current tests wouldn't notice if the vector<bool> contents were
printed in reverse, because it would read the same forwards and
backwards. Change the content so the tests would fail if that happened.

* testsuite/libstdc++-prettyprinters/simple.cc: Use non-palindromic
vector<bool> for test.
* testsuite/libstdc++-prettyprinters/simple11.cc: Likewise.

From-SVN: r272499

5 years agoDecrease hash-table-verification-limit from 100 to 10.
Martin Liska [Thu, 20 Jun 2019 07:41:42 +0000 (09:41 +0200)]
Decrease hash-table-verification-limit from 100 to 10.

2019-06-20  Martin Liska  <mliska@suse.cz>

* params.def (PARAM_HASH_TABLE_VERIFICATION_LIMIT): Decrease
to 10.

From-SVN: r272498

5 years agotree-vect-stmts.c (enum scan_store_kind): New type.
Jakub Jelinek [Thu, 20 Jun 2019 07:06:08 +0000 (09:06 +0200)]
tree-vect-stmts.c (enum scan_store_kind): New type.

* tree-vect-stmts.c (enum scan_store_kind): New type.
(scan_store_can_perm_p): Change last argument from int * to
vec<enum scan_store_kind> *, record precisely which permutations
need whole vector left shift or that plus VEC_COND_EXPR.
(vectorizable_scan_store): Adjust caller, use whole vector left shift
and additional VEC_COND_EXPR only for those iterations that need it.

From-SVN: r272497

5 years agofix ARM --with-fpu option checking and error message
Alexandre Oliva [Thu, 20 Jun 2019 05:55:34 +0000 (05:55 +0000)]
fix ARM --with-fpu option checking and error message

Fix the test for failure in parsecpu's checking of the --with-fpu
argument, and the error message that gets printed when the check
fails.

for  gcc/ChangeLog

* config.gcc: Fix ARM --with-fpu checking and error message.

From-SVN: r272496

5 years agoDaily bump.
GCC Administrator [Thu, 20 Jun 2019 00:16:14 +0000 (00:16 +0000)]
Daily bump.

From-SVN: r272495

5 years agoFix non-standard behaviour of std::istream_iterator
Jonathan Wakely [Wed, 19 Jun 2019 22:57:10 +0000 (23:57 +0100)]
Fix non-standard behaviour of std::istream_iterator

The current implementation of istream_iterator allows the iterator to be
reused after reaching end-of-stream, so that subsequent reads from the
stream can succeed (e.g. if the stream state has been cleared and stream
position changed from EOF). The P0738R2 paper clarified that the
expected behaviour is to set the stream pointer to null after reaching
end-of-stream, preventing further reads.

This implements that requirement, and adds the new default constructor
to std::ostream_iterator.

* include/bits/stream_iterator.h (istream_iterator::_M_equal()): Make
private.
(istream_iterator::_M_read()): Do not check stream state before
attempting extraction. Set stream pointer to null when extraction
fails (P0738R2).
(operator==(const istream_iterator&, const istream_iterator&)): Change
to be a hidden friend of istream_iterator.
(operator!=(const istream_iterator&, const istream_iterator&)):
Likewise.
(ostream_iterator::ostream_iterator()): Add default constructor.
(ostream_iterator::ostream_iterator(ostream_type*, const C*)): Use
addressof.
* testsuite/24_iterators/istream_iterator/1.cc: New test.
* testsuite/24_iterators/ostream_iterator/1.cc: New test.
* testsuite/24_iterators/ostream_iterator/70766.cc: Also check
constructor taking a string.
* testsuite/24_iterators/ostream_iterator/requirements/constexpr.cc:
New test.

From-SVN: r272491

5 years agoHave std::vector printer's iterator return bool for vector<bool>
Michael Weghorn [Wed, 19 Jun 2019 22:57:06 +0000 (22:57 +0000)]
Have std::vector printer's iterator return bool for vector<bool>

Have the pretty-printer for 'std::vector<bool>' return a
value of type 'bool' rather than an 'int'.

This way, the type is clear and that can be used for better
display and a 'gdb.Value' constructed from the returned value
will have type 'bool' again, not e.g. 'long long' as happened
previously (at least with GDB 8.2.1 on amd64).

2019-06-19  Michael Weghorn  <m.weghorn@posteo.de>
    Jonathan Wakely  <jwakely@redhat.com>

PR libstdc++/90945
* python/libstdcxx/v6/printers.py (StdVectorPrinter._iterator): Use
values of type bool for vector<bool> elements.
* testsuite/libstdc++-prettyprinters/simple.cc: Test vector<bool>.
* testsuite/libstdc++-prettyprinters/simple11.cc: Likewise.

Co-Authored-By: Jonathan Wakely <jwakely@redhat.com>
From-SVN: r272490

5 years agoPR libstdc++/90920 restore previous checks for empty ranges
Jonathan Wakely [Wed, 19 Jun 2019 22:57:02 +0000 (23:57 +0100)]
PR libstdc++/90920 restore previous checks for empty ranges

The change in r263433 broke the contract of the __rotate functions, by no
longer accepting empty ranges. That means that callers which inlined the
old version of std::rotate (without checks) that end up linking to a new
definition of std::__rotate (also without checks) could perform a divide
by zero and crash.

This restores the old contract of the __rotate overloads.

PR libstdc++/90920 partially revert r263433
* include/bits/stl_algo.h (__rotate): Restore checks for empty ranges.
(rotate): Remove checks.
* testsuite/25_algorithms/rotate/90920.cc: New test.

From-SVN: r272489

5 years agore PR tree-optimization/90626 (fold strcmp(a, b) == 0 to zero when one string length...
Martin Sebor [Wed, 19 Jun 2019 21:46:09 +0000 (21:46 +0000)]
re PR tree-optimization/90626 (fold strcmp(a, b) == 0 to zero when one string length is exact and the other is unequal)

PR tree-optimization/90626

gcc/ChangeLog:
* tree-ssa-strlen.c (strxcmp_unequal): Fix typos.

From-SVN: r272487

5 years agoPR c++/60364 - noreturn after first decl not diagnosed.
Marek Polacek [Wed, 19 Jun 2019 21:27:45 +0000 (21:27 +0000)]
PR c++/60364 - noreturn after first decl not diagnosed.

* attribs.c (get_attribute_namespace): No longer static.
(decl_attributes): Avoid shadowing.  Preserve the C++11 form for C++11
attributes.
(attr_noreturn_exclusions): Make it extern.
* attribs.h (get_attribute_namespace): Declare.
* tree-inline.c (function_attribute_inlinable_p): Use
get_attribute_name.

* c-attribs.c (handle_noreturn_attribute): No longer static.
* c-common.h (handle_noreturn_attribute, attr_noreturn_exclusions):
Declare.
* c-format.c (check_function_format): Use get_attribute_name.

* decl.c (duplicate_decls): Give an error when a function is
declared [[noreturn]] after its first declaration.
* parser.c (cp_parser_std_attribute): Don't treat C++11 noreturn
attribute as equivalent to GNU's.
* tree.c (std_attribute_table): Add noreturn.

* g++.dg/warn/noreturn-8.C: New test.
* g++.dg/warn/noreturn-9.C: New test.
* g++.dg/warn/noreturn-10.C: New test.
* g++.dg/warn/noreturn-11.C: New test.

From-SVN: r272486

5 years agoPR tree-optimization/90626 - fold strcmp(a, b) == 0 to zero when one string length...
Martin Sebor [Wed, 19 Jun 2019 20:37:41 +0000 (20:37 +0000)]
PR tree-optimization/90626 - fold strcmp(a, b) == 0 to zero when one string length is exact and the other is unequal

gcc/ChangeLog:

PR tree-optimization/90626
* tree-ssa-strlen.c (strxcmp_unequal): New function.
(handle_builtin_string_cmp): Call it.

gcc/testsuite/ChangeLog:

PR tree-optimization/90626
* gcc.dg/strlenopt-65.c: New test.
* gcc.dg/strlenopt-66.c: New test.
* gcc.dg/strlenopt.h (strcmp, strncmp): Declare.

From-SVN: r272485

5 years ago[Darwin, specs] Tidy some more linker options.
Iain Sandoe [Wed, 19 Jun 2019 19:16:17 +0000 (19:16 +0000)]
[Darwin, specs] Tidy some more linker options.

pie, no-pie and rdynamic are driver options, we can process them in the
relevant place and drop them once dealt with.  There's no need to generate
a new header to process the "no_compact_unwind" which is applied on the
basis of the target system.

Support for the -pie, -no_pie and -no_compact_unwind options should ideally
be checked at configure time, however the status quo is to assert that linkers
capable of targeting the relevant systems support these options (i.e. we trust
that the user doesn't attempt to configure inappropriately).

TODO: check the availability of the linker opts in configure rather than
trusting to the user.

This will fix the fail of pie-7.c, which is a result of failing to handle the
no-pie driver option.

2019-06-19  Iain Sandoe  <iain@sandoe.co.uk>

* config/darwin.h (DRIVER_SELF_SPECS): Add RDYNAMIC, DARWIN_PIE_SPEC
and DARWIN_NOPIE_SPEC.
(RDYNAMIC): New, modified from DARWIN_EXPORT_DYNAMIC.
(DARWIN_PIE_SPEC): Collate from darwin.h and darwin9.h.
(DARWIN_NOPIE_SPEC): Collate from darwin10.h.
(DARWIN_NOCOMPACT_UNWIND): New from darwin10.h
(DARWIN_EXPORT_DYNAMIC): Delete.
* config/darwin10.h (LINK_GCC_C_SEQUENCE_SPEC): Move no_compact_unwind
and pie options processing to  darwin.h.
* config/darwin9.h (DARWIN_PIE_SPEC): Move pie processing to darwin.h

From-SVN: r272484

5 years agoPR translation/90156 - add linter check suggesting to replace %<%s%> with %qs
Martin Sebor [Wed, 19 Jun 2019 19:08:24 +0000 (19:08 +0000)]
PR translation/90156 - add linter check suggesting to replace %<%s%> with %qs

gcc/c-family/ChangeLog:

PR translation/90156
* c-format.c (function_format_info::format_type): Adjust type.
(function_format_info::is_raw): New member.
(decode_format_type): Adjust signature.  Handle "raw" diag attributes.
(decode_format_attr): Adjust call to decode_format_type.
Avoid a redundant call to convert_format_name_to_system_name.
Avoid abbreviating the word "arguments" in a diagnostic.
(format_warning_substr): New function.
(avoid_dollar_number): Quote dollar sign in a diagnostic.
(finish_dollar_format_checking): Same.
(check_format_info): Same.
(struct baltoks_t): New.
(c_opers, c_keywords, cxx_keywords, badwords, contrs): New arrays.
(maybe_diag_unbalanced_tokens, check_tokens, check_plain): New
functions.
(check_format_info_main): Call check_plain.  Use baltoks_t.  Call
maybe_diag_unbalanced_tokens.
(handle_format_attribute): Spell out the word "arguments" in
a diagnostic.

gcc/testsuite/ChangeLog:

PR translation/90156
* gcc.dg/format/gcc_diag-11.c: Enable.

From-SVN: r272483

5 years agore PR fortran/69499 ([F03] ICE-on-invalid on combining select type with wrong statement)
Steven G. Kargl [Wed, 19 Jun 2019 18:18:40 +0000 (18:18 +0000)]
re PR fortran/69499 ([F03] ICE-on-invalid on combining select type with wrong statement)

2019-06-19  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/69499
* match.c (gfc_match_select_type):  SELECT TYPE is an executable
statement, and cannot appear in MODULE or SUBMODULE scope.

2019-06-19  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/69499
* gfortran.dg/pr69499.f90: New test.
* gfortran.dg/module_error_1.f90: Update dg-error string.

From-SVN: r272482

5 years agore PR fortran/69398 ([OOP] ICE on class with duplicate dimension attribute specified)
Steven G. Kargl [Wed, 19 Jun 2019 18:04:46 +0000 (18:04 +0000)]
re PR fortran/69398 ([OOP] ICE on class with duplicate dimension attribute specified)

2019-06-19  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/69398
* decl.c (attr_decl): Check for duplicate DIMENSION attribute for a
CLASS entity.

2019-06-19  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/69398
* gfortran.dg/pr69398.f90: New test.

From-SVN: r272481

5 years agore PR fortran/87907 (ICE in resolve_contained_fntype, at fortran/resolve.c:587)
Steven G. Kargl [Wed, 19 Jun 2019 17:58:54 +0000 (17:58 +0000)]
re PR fortran/87907 (ICE in resolve_contained_fntype, at fortran/resolve.c:587)

2019-06-19  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/87907
* resolve.c (resolve_contained_fntype): Do not dereference a NULL
pointer.

2019-06-19  Steven G. Kargl  <kargl@gcc.gnu.org>

PR fortran/87907
* gfortran.dg/pr87907.f90: New testcase.

From-SVN: r272480

5 years ago[Darwin] Fix two off-by-one errors in the driver.
Iain Sandoe [Wed, 19 Jun 2019 16:07:58 +0000 (16:07 +0000)]
[Darwin] Fix two off-by-one errors in the driver.

2019-06-19  Iain Sandoe  <iain@sandoe.co.uk>

        * config/darwin-driver.c (darwin_driver_init): Fix off-by-one errors
        in computing the number of options to be moved.

From-SVN: r272479

5 years agonetbsd-elf.h (SYSARCH_ARM_SYNC_ICACHE): New definition.
Maya Rashish [Wed, 19 Jun 2019 16:01:24 +0000 (16:01 +0000)]
netbsd-elf.h (SYSARCH_ARM_SYNC_ICACHE): New definition.

*  config/arm/netbsd-elf.h (SYSARCH_ARM_SYNC_ICACHE): New definition.
(CLEAR_INSN_CACHE) Use it.

From-SVN: r272478

5 years agoFix value category bugs in std::reduce
Jonathan Wakely [Wed, 19 Jun 2019 15:29:49 +0000 (16:29 +0100)]
Fix value category bugs in std::reduce

* include/std/numeric (reduce(Iter, Iter, T, BinOp)): Fix value
category used in invocable check.
(reduce(Iter, Iter, T)): Pass initial value as rvalue.
* testsuite/26_numerics/reduce/2.cc: New test.

From-SVN: r272477

5 years agocompiler: optimize string concatenations
Ian Lance Taylor [Wed, 19 Jun 2019 15:13:53 +0000 (15:13 +0000)]
compiler: optimize string concatenations

    runtime.concatstring{2,3,4,5} are just wrappers of concatstrings.
    These wrappers don't provide any benefit, at least in the C
    calling convention we use, where passing arrays by value isn't an
    efficient thing. Change it to always use concatstrings.

    Also, the cap field of the slice passed to concatstrings is not
    necessary. So change it to pass a pointer and a length directly,
    which is more efficient than passing a slice header by value.

    Reviewed-on: https://go-review.googlesource.com/c/gofrontend/+/182539

From-SVN: r272476

5 years agoi386.md (cmpstrnsi): Remove dead code.
Uros Bizjak [Wed, 19 Jun 2019 14:38:58 +0000 (16:38 +0200)]
i386.md (cmpstrnsi): Remove dead code.

* config/i386/i386.md (cmpstrnsi): Remove dead code.

From-SVN: r272474

5 years agoSimplify setjmp and non-local goto implementation (PR84521)
Wilco Dijkstra [Wed, 19 Jun 2019 12:52:43 +0000 (12:52 +0000)]
Simplify setjmp and non-local goto implementation (PR84521)

This fixes and simplifies the setjmp and non-local goto implementation.
Currently the virtual frame pointer is saved when using __builtin_setjmp or
a non-local goto.  Depending on whether a frame pointer is used, this may
either save SP or FP with an immediate offset.  However the goto or longjmp
always updates the hard frame pointer.

A receiver veneer in the original function then assigns the hard frame pointer
to the virtual frame pointer, which should, if it works correctly, again assign
SP or FP.  However the special elimination code in eliminate_regs_in_insn
doesn't do this correctly unless the frame pointer is used, and even if it
worked by writing SP, the frame pointer would still be corrupted.

A much simpler implementation is to always save and restore the hard frame
pointer.  This avoids 2 redundant instructions which add/subtract the virtual
frame offset.  A large amount of code can be removed as a result, including all
implementations of TARGET_BUILTIN_SETJMP_FRAME_VALUE (all of which already use
the hard frame pointer).  The expansion of nonlocal_goto on PA can be simplied
to just restore the hard frame pointer.

This fixes the most obvious issues, however there are still issues on targets
which define HARD_FRAME_POINTER_IS_FRAME_POINTER (arm, mips).
Each function could have a different hard frame pointer, so a non-local goto
may restore the wrong frame pointer (TARGET_BUILTIN_SETJMP_FRAME_VALUE could
be useful for this).

The i386 TARGET_BUILTIN_SETJMP_FRAME_VALUE was incorrect: if stack_realign_fp
is true, it would save the hard frame pointer value but restore the virtual
frame pointer which according to ix86_initial_elimination_offset can have a
non-zero offset from the hard frame pointer.

The ia64 implementation of nonlocal_goto seems incorrect since the helper
function moves the the frame pointer value into the static chain register
(so this patch does nothing to make it better or worse).

AArch64 + x86-64 bootstrap OK, new test passes on AArch64, x86-64 and Arm.

gcc/
PR middle-end/84521
* builtins.c (expand_builtin_setjmp_setup): Save
hard_frame_pointer_rtx.
(expand_builtin_setjmp_receiver): Do not emit sfp = fp move since we
restore fp.
* function.c (expand_function_start): Save hard_frame_pointer_rtx for
non-local goto.
* lra-eliminations.c (eliminate_regs_in_insn): Remove sfp = fp
elimination code.
(remove_reg_equal_offset_note): Remove unused function.
* reload1.c (eliminate_regs_in_insn): Remove sfp = hfp elimination
code.
* config/arc/arc.c (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.
(arc_builtin_setjmp_frame_value): Remove function.
* config/avr/avr.c  (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.
(avr_builtin_setjmp_frame_value): Remove function.
* config/i386/i386.c (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.
(ix86_builtin_setjmp_frame_value): Remove function.
* config/pa/pa.md (nonlocal_goto): Remove FP adjustment.
* config/sparc/sparc.c (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.
(sparc_builtin_setjmp_frame_value): Remove function.
* config/vax/vax.c (TARGET_BUILTIN_SETJMP_FRAME_VALUE): Remove.
(vax_builtin_setjmp_frame_value): Remove function.
* config/xtensa/xtensa.c (xtensa_frame_pointer_required): Force frame
pointer if has_nonlocal_label.

testsuite/
PR middle-end/84521
* gcc.c-torture/execute/pr84521.c: New test.

From-SVN: r272473

5 years agomd.texi: Document vec_shl_<mode> pattern.
Jakub Jelinek [Wed, 19 Jun 2019 10:00:04 +0000 (12:00 +0200)]
md.texi: Document vec_shl_<mode> pattern.

* doc/md.texi: Document vec_shl_<mode> pattern.
* optabs.def (vec_shl_optab): New optab.
* optabs.c (shift_amt_for_vec_perm_mask): Add shift_optab
argument, if == vec_shl_optab, check for left whole vector shift
pattern rather than right shift.
(expand_vec_perm_const): Add vec_shl_optab support.
* optabs-query.c (can_vec_perm_var_p): Mention also vec_shl optab
in the comment.
* tree-vect-generic.c (lower_vec_perm): Support permutations which
can be handled by vec_shl_optab.
* tree-vect-stmts.c (scan_store_can_perm_p): New function.
(check_scan_store): Use it.
(vectorizable_scan_store): If target can't do normal permutations,
try to use whole vector left shifts and if needed a VEC_COND_EXPR
after it.
* config/i386/sse.md (vec_shl_<mode>): New expander.

* gcc.dg/vect/vect-simd-8.c: If main is defined, don't include
tree-vect.h nor call check_vect.
* gcc.dg/vect/vect-simd-9.c: Likewise.
* gcc.dg/vect/vect-simd-10.c: New test.
* gcc.target/i386/sse2-vect-simd-8.c: New test.
* gcc.target/i386/sse2-vect-simd-9.c: New test.
* gcc.target/i386/sse2-vect-simd-10.c: New test.
* gcc.target/i386/avx2-vect-simd-8.c: New test.
* gcc.target/i386/avx2-vect-simd-9.c: New test.
* gcc.target/i386/avx2-vect-simd-10.c: New test.
* gcc.target/i386/avx512f-vect-simd-8.c: New test.
* gcc.target/i386/avx512f-vect-simd-9.c: New test.
* gcc.target/i386/avx512f-vect-simd-10.c: New test.

From-SVN: r272472